[00:54:02] 10Citoid, 10VisualEditor, 10VisualEditor-ContentEditable: Put Citoid in the regular Cite menu anyway - https://phabricator.wikimedia.org/T96118#1214513 (10Neil_P._Quinn_WMF) @Whatamidoing-WMF: yes, I found this behavior pretty mystifying as well. According to @Jdforrester-WMF, this confusion partly due to... [00:56:07] 10Citoid, 10VisualEditor, 10VisualEditor-ContentEditable: Put Citoid in the regular Cite menu anyway - https://phabricator.wikimedia.org/T96118#1214538 (10Neil_P._Quinn_WMF) [00:56:11] 10OOjs-UI, 10VisualEditor, 7Design, 3Editing Department 2014/15 Q4 blockers: MediaWiki theme: Alter the toolbar and dropdown menu design - https://phabricator.wikimedia.org/T86693#974283 (10Neil_P._Quinn_WMF) [00:56:19] 10Citoid, 10VisualEditor, 10VisualEditor-ContentEditable: Put Citoid in the regular Cite menu anyway - https://phabricator.wikimedia.org/T96118#1214540 (10Neil_P._Quinn_WMF) p:5Triage>3Low [01:00:56] 10WikiEditor, 3Editing Department 2014/15 Q4 blockers: editSessionID is duplicated in Edit:Schema for Wikitext - https://phabricator.wikimedia.org/T95919#1214556 (10Krenair) ... In some circumstances and not others, I think. It might depend on some part of my code that checks whether the request was POST or not. [01:03:54] 10VisualEditor, 10MediaWiki-Special-pages: VE detecting ISBN magic word as invalid link - https://phabricator.wikimedia.org/T95992#1214562 (10Krenair) It's because of that "./"... [01:19:45] 10VisualEditor, 10MediaWiki-Special-pages: VE detecting ISBN magic word as invalid link - https://phabricator.wikimedia.org/T95992#1214607 (10Josve05a) It should not show up as an editable link at all... [04:53:25] 10TemplateData, 6Community-Liaison, 10WMF-Product-Strategy: Please make me a list of commonly used templates in Wikipedia articles - https://phabricator.wikimedia.org/T96323#1214707 (10Rdicerb) @Whatamidoing-WMF - this looks like it's related to the Qualtrics survey results from T92844. Am I correct in think... [06:25:57] 10VisualEditor: no warning of unsaved content - https://phabricator.wikimedia.org/T96344#1214755 (10Conny) 3NEW [06:48:17] 10VisualEditor: picture sizes - https://phabricator.wikimedia.org/T96345#1214773 (10Conny) 3NEW [09:12:04] (03PS1) 10Esanders: Restrict native selection rangeCount to 1 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204723 [09:23:35] (03PS2) 10Esanders: Restrict native selection rangeCount to 1 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204723 (https://phabricator.wikimedia.org/T96310) [09:24:03] 10VisualEditor: Firefox lets you create a multi range selection - https://phabricator.wikimedia.org/T96310#1214920 (10Esanders) https://gerrit.wikimedia.org/r/#/c/204723/ [09:25:35] (03CR) 10Esanders: [C: 032] Show template description in the template search [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/203459 (https://phabricator.wikimedia.org/T53436) (owner: 10Mooeypoo) [09:27:42] (03PS7) 10Esanders: Use plural grammar in table context for deleting multiple rows/columns [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198738 (https://phabricator.wikimedia.org/T87234) (owner: 10Pratikbsp) [09:27:48] (03CR) 10jenkins-bot: [V: 04-1] Use plural grammar in table context for deleting multiple rows/columns [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198738 (https://phabricator.wikimedia.org/T87234) (owner: 10Pratikbsp) [09:28:25] (03Merged) 10jenkins-bot: Show template description in the template search [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/203459 (https://phabricator.wikimedia.org/T53436) (owner: 10Mooeypoo) [09:49:05] (03CR) 10Esanders: Rewrite the table context as an actual ve.ui.Context (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204269 (owner: 10Esanders) [09:49:20] (03PS8) 10Esanders: Use plural grammar in table context for deleting multiple rows/columns [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198738 (https://phabricator.wikimedia.org/T87234) (owner: 10Pratikbsp) [09:49:22] (03PS6) 10Esanders: Rewrite the table context as an actual ve.ui.Context [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204269 [09:49:24] (03CR) 10jenkins-bot: [V: 04-1] Use plural grammar in table context for deleting multiple rows/columns [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198738 (https://phabricator.wikimedia.org/T87234) (owner: 10Pratikbsp) [09:49:26] (03CR) 10jenkins-bot: [V: 04-1] Rewrite the table context as an actual ve.ui.Context [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204269 (owner: 10Esanders) [09:49:48] (03PS1) 10Esanders: Add missing @class markers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204730 [09:52:43] 10VisualEditor: Language-appropriate icons for italic and bold for Serbian language - https://phabricator.wikimedia.org/T95761#1214930 (10Milicevic01) No, at least not on srwiki and enwiki (with Serbian language in settings) [10:00:04] (03CR) 10Esanders: "At the CSS level, we flip the meaning of left and right, so margin-left: 1em; actually means "margin-before", because it depends on direct" [oojs/ui] - 10https://gerrit.wikimedia.org/r/201617 (owner: 10Mooeypoo) [10:03:32] (03CR) 10Esanders: "Sorry, saw your first comment. I think we should provide before/after only. As you say we are only using 'center' so it's not so bad as a " [oojs/ui] - 10https://gerrit.wikimedia.org/r/201617 (owner: 10Mooeypoo) [10:27:25] (03CR) 10Esanders: "FIXME: Go to aliens.html demo - press CTRL+A, notice the view selection ends half way through the last table caption." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/200337 (https://phabricator.wikimedia.org/T89352) (owner: 10Divec) [10:33:15] (03CR) 10Bartosz Dziewoński: [C: 032] Simplify OO.ui.SelectWidget#getTargetItem [oojs/ui] - 10https://gerrit.wikimedia.org/r/204293 (owner: 10Esanders) [10:36:45] (03Merged) 10jenkins-bot: Simplify OO.ui.SelectWidget#getTargetItem [oojs/ui] - 10https://gerrit.wikimedia.org/r/204293 (owner: 10Esanders) [10:43:38] 10VisualEditor, 10VisualEditor-Tables: Cursoring inside caption nodes broken (regression) - https://phabricator.wikimedia.org/T96356#1214978 (10Esanders) 3NEW a:3Esanders [10:43:57] (03PS1) 10Esanders: Fix cursoring inside a caption node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204739 (https://phabricator.wikimedia.org/T96356) [11:16:39] 10VisualEditor: Select all produces strange offsets - https://phabricator.wikimedia.org/T96357#1215004 (10Esanders) 3NEW [11:53:17] 10VisualEditor: Select all produces strange offsets - https://phabricator.wikimedia.org/T96357#1215062 (10Esanders) This appears to be caused by block slugs - if you remove all block aliens from the document the bug goes away. [12:06:34] (03PS1) 10Esanders: Check for all important elements when pasting between instances [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204749 [12:16:18] 10VisualEditor: picture sizes - https://phabricator.wikimedia.org/T96345#1215097 (10Aklapper) So you open a page that has upright=1.5 in its wikitext source, and then edit that page with VisualEditor, and after saving in VisualEditor the upright parameter is deleted? (In general, a list of steps is welcome and m... [12:20:19] 10VisualEditor: no warning of unsaved content - https://phabricator.wikimedia.org/T96344#1215113 (10Aklapper) Hi @Conny, unfortunately this report is not very useful because it does not describe the problem well. If you have time and can still reproduce the problem, please [[ https://www.mediawiki.org/wiki/How_... [12:26:22] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: VE Inspectors in mobile should have a "cancel" or "back" button - https://phabricator.wikimedia.org/T96303#1215122 (10Aklapper) [12:43:15] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References, 3Editing Department 2014/15 Q4 blockers, and 2 others: Allow use of Citoid auto-fill citation inspector when editing a basic reference - https://phabricator.wikimedia.org/T94621#1215141 (10matej_suchanek) [12:43:47] 10OOjs-UI, 10VisualEditor, 10VisualEditor-MediaWiki, 3Editing Department 2014/15 Q4 blockers, and 4 others: FlaggedRevs edit notices don't render properly in VisualEditor - https://phabricator.wikimedia.org/T95989#1215142 (10matej_suchanek) [12:44:00] 10VisualEditor, 10VisualEditor-MediaWiki, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-01_(1.25wmf24), and 3 others: Mysterious missingrev failure during save - https://phabricator.wikimedia.org/T94367#1215143 (10matej_suchanek) [12:49:37] 10Citoid, 10Mathoid-General-or-Unknown, 10MediaWiki-extensions-Graph, 10MediaWiki-extensions-WikiHiero, and 4 others: Services need to share the same domain name - https://phabricator.wikimedia.org/T95402#1215149 (10faidon) There has been previous agreement that non-IP whitelisted partners will be phased o... [13:11:42] (03PS2) 10Physikerwelt: Prepare math extension for mathoid PNG support [extensions/Math] - 10https://gerrit.wikimedia.org/r/204328 (https://phabricator.wikimedia.org/T78056) [13:26:42] 10Citoid, 6Services, 3Editing Department 2014/15 Q4 blockers, 7Technical-Debt: Promisify html-metadata - https://phabricator.wikimedia.org/T96363#1215222 (10Mvolz) 3NEW a:3Mvolz [13:27:50] 10Citoid, 10VisualEditor, 3Editing Department 2014/15 Q4 blockers: Improper use of doi - https://phabricator.wikimedia.org/T95984#1215239 (10Josve05a) [13:28:27] 10Citoid, 10VisualEditor: Move the insert-button to the "frame" surounding the reference, instead of in the window - https://phabricator.wikimedia.org/T95983#1215244 (10Josve05a) [13:28:44] 10OOjs-UI, 10Living-Style-Guide, 7Design, 5Patch-For-Review: LSG Homepage - https://phabricator.wikimedia.org/T95658#1215245 (10violetto) I've made this change: "This introduction page should be the home page followed by Terminology's content underneath. Content within these 2 links should appear on the... [13:28:50] 10Citoid, 10VisualEditor, 7Community-consensus-needed: Move the insert-button to the "frame" surounding the reference, instead of in the window - https://phabricator.wikimedia.org/T95983#1205609 (10Josve05a) [13:29:06] 10Citoid, 10VisualEditor: Move the insert-button to the "frame" surounding the reference, instead of in the window - https://phabricator.wikimedia.org/T95983#1205609 (10Josve05a) [13:29:30] 10Citoid, 10VisualEditor, 3Editing Department 2014/15 Q4 blockers: Find doi in link to doi.org - https://phabricator.wikimedia.org/T95981#1215250 (10Josve05a) [13:29:35] 10OOjs-UI, 10Living-Style-Guide, 7Design, 5Patch-For-Review: LSG Homepage - https://phabricator.wikimedia.org/T95658#1215251 (10violetto) [13:58:35] (03CR) 10Divec: Restrict native selection rangeCount to 1 (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204723 (https://phabricator.wikimedia.org/T96310) (owner: 10Esanders) [14:04:06] (03CR) 10Divec: [C: 032] Fix cursoring inside a caption node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204739 (https://phabricator.wikimedia.org/T96356) (owner: 10Esanders) [14:06:24] (03Merged) 10jenkins-bot: Fix cursoring inside a caption node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204739 (https://phabricator.wikimedia.org/T96356) (owner: 10Esanders) [14:14:48] 10VisualEditor: picture sizes - https://phabricator.wikimedia.org/T96345#1215369 (10Conny) Page has two pictures with upright=1.5 allready. Want to add [1] a third one and than as mentioned. In the VE after adding before saving all pictures have same size. [1] https://de.wikipedia.org/w/index.php?title=Benutzer... [14:18:53] 10VisualEditor: no warning of unsaved content - https://phabricator.wikimedia.org/T96344#1215407 (10Conny) While in editing mode I clicked the article tab upper left. Normaly in MediaWiki editing mode Browser says, that there is unsaved content and asks, do I really wan't to leave. User Agent: Mozilla/5.0 (Wind... [15:22:24] (03CR) 10Paladox: "@MarkTraceur please review again since wikieditor is not ready to switch oojs-ui icons just yet. and these icons are svg and can be replac" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (https://phabricator.wikimedia.org/T37342) (owner: 10Paladox) [15:29:22] Krinkle: Hmm. Why did https://integration.wikimedia.org/ci/job/unicodejs-publish/ #5 get triggered 10 days later? [15:29:34] (03PS17) 10Paladox: Add svg to LESS file [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/195529 (https://phabricator.wikimedia.org/T37342) [15:29:48] (03PS18) 10Paladox: Add svg to LESS file [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/195529 (https://phabricator.wikimedia.org/T37342) [15:30:34] (03PS51) 10Paladox: Re add svg images [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (https://phabricator.wikimedia.org/T37342) [15:36:48] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-Tables, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-22_(1.26wmf3): Cursoring inside caption nodes broken (regression) - https://phabricator.wikimedia.org/T96356#1215598 (10Jdforrester-WMF) 5Open>3Resolved p:5Triage>3Hi... [15:36:54] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-Tables, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-22_(1.26wmf3): Cursoring inside caption nodes broken (regression) - https://phabricator.wikimedia.org/T96356#1214978 (10Jdforrester-WMF) [15:37:42] James_F: Because I simulated a push in Zuul [15:37:51] Krinkle: Ah. OK. [15:37:54] or rather, a merge [15:38:03] To make sure it still works after I changed it from ZUUL_BRANCH to DOC_SUBPATH [15:38:11] as destination directory [15:38:16] supposed to be identical [15:38:19] except that the latter also supports tags [15:38:40] Right. [15:39:19] $ zuul enqueue --trigger gerrit --pipeline postmerge --project unicodejs --change 201944,2 [15:39:27] Zuul is quite modular like that [15:40:12] James_F: qunit jobs haven't failed due to time outs these past 24h I think. Did you spot any? [15:40:21] in mwext-VE-qunit [15:40:25] or elsewhere [15:40:35] Krinkle: I didn't, no. Fixed? [15:42:29] 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-22_(1.26wmf3), 7user-notice: Template search results list should contain each template's descripton - https://phabricator.wikimedia.org/T53436#1215617 (10Jdforrester-WMF) 5Open>3Resolved [15:42:40] 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-22_(1.26wmf3), 7user-notice: Template search results list should contain each template's descripton - https://phabricator.wikimedia.org/T53436#572953 (10Jdforrester-WMF) [15:43:10] James_F: Well, ever since the NFS outage, disk interaction on labs instances hasn't been the same. [15:43:17] It stalls for minutes at a time sometimes [15:43:23] Hmm. [15:43:39] Which surfaced most prominently in mediawiki jobs (incl. extensions) that use MySQL [15:43:44] We switched that to tmpfs [15:44:00] It's quite plausible that that was also causing the AJAX requests to api.php and load.php to time out in the qunit jobs [15:44:13] tmpfs beinf fully in RAM [15:44:15] * James_F nods. [15:44:19] took away the stagnation [15:44:31] and also boosted speed by 60% overall phpunit job :D [15:44:39] :-) [15:44:46] https://phabricator.wikimedia.org/T96230#1215473 [15:45:07] We're now back under the 10 minute line for zend (!) jobs [15:45:18] averaging at 8 minutes [15:45:20] Neat. [15:45:26] Though that's not a great bar to have passed. [15:45:36] which compares to the performance we had using sqlite on production hardware slaves [15:46:11] And hhvm got a boost as well. [15:46:16] 10VisualEditor, 10VisualEditor-MediaWiki-References: When numbering references VE ignores those in infoboxes - https://phabricator.wikimedia.org/T96380#1215630 (10Josve05a) [15:46:18] Full mwcore phpunit suite now in less than 3 minutes [15:46:35] I such at describing bugs... ^^ [15:46:38] suck* [15:51:08] 10Citoid, 10VisualEditor, 3Editing Department 2014/15 Q4 blockers: Find doi in link to doi.org - https://phabricator.wikimedia.org/T95981#1215657 (10Josve05a) Also, using the doi 10.1016/j.ejpain.2010.09.005 caused {T95984}. [16:00:37] https://en.wikipedia.org/wiki/USRC_Erie?veaction=edit - when you modify that infobox a reference list is added :/ [16:00:53] (though not in the wikitext) [16:01:34] Krenair: That sounds like a "feature" of the template. [16:04:19] James_F: Yikes, we need to split up -publish from -coverage, otherwise it overwrites the coverage report with that of the tag :D [16:04:36] Krinkle: Is the tag's coverage wrong? [16:05:10] James_F: Well, we shouldn't do coverage for tags or branches. And certainly not if the publishing end point is per-project. [16:05:28] Krinkle: Oh, right. [16:05:59] 10VisualEditor: picture sizes - https://phabricator.wikimedia.org/T96345#1215711 (10Jdforrester-WMF) [16:06:58] 10Citoid, 10VisualEditor: Move the insert-button to the "frame" surounding the reference, instead of in the window - https://phabricator.wikimedia.org/T95983#1215716 (10Jdforrester-WMF) 5Open>3declined a:3Jdforrester-WMF No, an insert button appears alongside each result. It is possible to have multiple... [16:08:04] James_F: I've always assumed it but is this also the home of oojs/oojs ui? [16:08:11] Negative24: Yes. [16:08:26] Negative24: That might change, if it's too noisy here. [16:08:27] 10Citoid, 10VisualEditor: Move the insert-button to the "frame" surounding the reference, instead of in the window - https://phabricator.wikimedia.org/T95983#1215719 (10Josve05a) But when only one result is shown, it looks a bit malformed or...simply put "annoyingly placed". But oh-well.. [16:09:23] * Adipose just realized that James_F is Jdforrester-WMF [16:10:47] *gasp* [16:11:03] Adipose: Yes. :-) [16:11:34] * Adipose facepalms for not noticing that... [16:11:36] (03PS3) 10Jforrester: ve.ce.Surface: Restrict native selection rangeCount to 1 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204723 (https://phabricator.wikimedia.org/T96310) (owner: 10Esanders) [16:13:30] (03CR) 10Divec: [C: 032] ve.ce.Surface: Restrict native selection rangeCount to 1 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204723 (https://phabricator.wikimedia.org/T96310) (owner: 10Esanders) [16:13:48] (03CR) 10Jforrester: ve.ce.Surface: Restrict native selection rangeCount to 1 (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204723 (https://phabricator.wikimedia.org/T96310) (owner: 10Esanders) [16:14:30] Is there a tool type or tool widget that can display a label like the drop down tool but isn't a menu? [16:14:54] (03PS2) 10Jforrester: contextitems/*: Add missing @class markers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204730 (owner: 10Esanders) [16:15:02] (03CR) 10Jforrester: [C: 032] contextitems/*: Add missing @class markers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204730 (owner: 10Esanders) [16:15:50] (03Merged) 10jenkins-bot: ve.ce.Surface: Restrict native selection rangeCount to 1 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204723 (https://phabricator.wikimedia.org/T96310) (owner: 10Esanders) [16:16:38] 10VisualEditor, 10VisualEditor-ContentEditable, 7Browser-Support-Firefox, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-22_(1.26wmf3): Firefox lets you create a multi range selection, which VisualEditor doesn't support - https://phabricator.wikimedia.org/T96310#1215734 (10Jdforrester-WMF)... [16:16:39] 10VisualEditor, 10VisualEditor-ContentEditable, 7Browser-Support-Firefox, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-22_(1.26wmf3): Firefox lets you create a multi range selection, which VisualEditor doesn't support - https://phabricator.wikimedia.org/T96310#1214038 (10Jdforrester-WMF) [16:16:55] 10VisualEditor, 10VisualEditor-ContentEditable, 7Browser-Support-Firefox, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-22_(1.26wmf3): Firefox lets you create a multi range selection, which VisualEditor doesn't support - https://phabricator.wikimedia.org/T96310#1214038 (10Jdforrester-WMF)... [16:17:05] Krinkle, hey [16:17:22] (03Merged) 10jenkins-bot: contextitems/*: Add missing @class markers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204730 (owner: 10Esanders) [16:17:40] Negative24: Not quite sure what you mean. If it's not listed on https://tools.wmflabs.org/oojs-ui/oojs-ui/demos/index.html#widgets-mediawiki-vector-ltr it probably doesn't exist yet. [16:20:12] Krenair: Hi [16:21:16] Krinkle, the user who wrote that svwiki gadget which set dependencies but not the ResourceLoader option emailed me [16:21:42] And basically suggested that it should automatically imply the option, which doesn't sound that unreasonable to me [16:22:12] Krenair: Meh, it's obsolete when we make it the default. [16:22:26] Would rather have it be explicit. [16:24:34] We should probably be explicit about requiring it in the docs [16:33:58] (03CR) 10Jforrester: "What's WIP here?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/203965 (https://phabricator.wikimedia.org/T95696) (owner: 10Mooeypoo) [16:37:28] (03PS7) 10Jforrester: Rewrite the table context as an actual ve.ui.Context [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204269 (owner: 10Esanders) [16:37:45] 10WikiEditor: mw:Extension:WikiEditor injects HTML5 obsolete tags. - https://phabricator.wikimedia.org/T96387#1215812 (10Technical13) 3NEW [16:37:45] (03CR) 10Jforrester: "PS7 is a rebase." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204269 (owner: 10Esanders) [16:37:54] (03PS9) 10Jforrester: Use plural grammar in table context for deleting multiple rows/columns [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198738 (https://phabricator.wikimedia.org/T87234) (owner: 10Pratikbsp) [16:39:03] (03CR) 10Catrope: [C: 032] Check for all important elements when pasting between instances [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204749 (owner: 10Esanders) [16:41:30] (03Merged) 10jenkins-bot: Check for all important elements when pasting between instances [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204749 (owner: 10Esanders) [16:46:03] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers: VE Inspectors in mobile should have a "cancel" or "back" button - https://phabricator.wikimedia.org/T96303#1215837 (10Jdforrester-WMF) p:5Triage>3High [16:46:29] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers: VE Inspectors in mobile should have a "cancel" or "back" button - https://phabricator.wikimedia.org/T96303#1213921 (10Jdforrester-WMF) Can we do this by overriding the default behaviour of the window manager? [16:46:36] 10VisualEditor: picture sizes - https://phabricator.wikimedia.org/T96345#1215854 (10Conny) Thank you @Jdforrester-WMF :) . [16:46:49] 10OOjs-UI, 10VisualEditor, 7Technical-Debt: Generalize the media search widget masonry fit algorithm into an OOUI masonry fit widget - https://phabricator.wikimedia.org/T96292#1215858 (10Jdforrester-WMF) p:5Triage>3Normal [16:47:13] 10VisualEditor, 6Community-Liaison: Collaborate with TeaHouse and others to update VE Documentation - https://phabricator.wikimedia.org/T96237#1215863 (10Jdforrester-WMF) p:5Triage>3Normal [16:47:35] 10VisualEditor: One user often can't create new articles in VisualEditor while logged in - https://phabricator.wikimedia.org/T96115#1215867 (10Jdforrester-WMF) p:5Triage>3Normal [16:48:40] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References, 3Editing Department 2014/15 Q4 blockers, and 3 others: Allow use of Citoid auto-fill citation inspector when editing a basic reference - https://phabricator.wikimedia.org/T94621#1215885 (10Etonkovidova) [16:50:04] 10VisualEditor, 10VisualEditor-MediaWiki: Make interlanguage links visible (e.g., so that you can avoid typing on the same line) - https://phabricator.wikimedia.org/T71822#1215898 (10Jdforrester-WMF) 5stalled>3Open p:5Triage>3Lowest [16:53:18] (03CR) 10Catrope: [C: 032] Rewrite the table context as an actual ve.ui.Context [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204269 (owner: 10Esanders) [16:53:20] 10VisualEditor: no warning of unsaved content - https://phabricator.wikimedia.org/T96344#1215929 (10Conny) If I click on tab "Lesen" there comes a message :) : **Bist du sicher? Bist du sicher, dass du zum Ansichtsmodus wechseln möchtest, ohne vorher zu speichern?** [16:53:32] (03CR) 10Catrope: [C: 032] Use plural grammar in table context for deleting multiple rows/columns [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198738 (https://phabricator.wikimedia.org/T87234) (owner: 10Pratikbsp) [16:54:12] 10VisualEditor, 10VisualEditor-Tables, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-22_(1.26wmf3): "Delete row"/"Delete column" messages do not use the plural when multiple rows/columns are selected (but they do delete multiple rows/columns) - https://phabricator.wikimedia.org/T87234#1215937... [16:55:06] (03PS2) 10Jforrester: [PULL THROUGH] Fix SurfaceWidget and DebugBar hacks [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200574 (owner: 10Esanders) [16:55:21] (03PS4) 10Jforrester: [BREAKING CHANGE] Fix font sizes and padding in Surface and SurfaceWidget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/200575 (owner: 10Esanders) [16:55:41] Hey MatmaRex. [16:55:45] How are you doing? [16:55:51] hi there. [16:56:25] i just took a nap and i can't decide if i feel better or worse because of it, thank you. [16:56:59] Ha. [16:57:35] 10VisualEditor: no warning of unsaved content - https://phabricator.wikimedia.org/T96344#1215957 (10Catrope) I get a message when I click on "Artikel", but it's a different message coming from the browser. Works for me in both Firefox and Chrome. Note that these messages only appear if you've actually made a ch... [16:58:19] 10VisualEditor: no warning of unsaved content - https://phabricator.wikimedia.org/T96344#1215960 (10Jdforrester-WMF) 5Open>3Invalid a:3Jdforrester-WMF [17:03:28] (03PS5) 10Florianschmidtwelzow: Allow skin developers to set an offset for toolbar floating [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/203011 (https://phabricator.wikimedia.org/T95528) [17:19:22] 10VisualEditor: no warning of unsaved content - https://phabricator.wikimedia.org/T96344#1216034 (10Conny) @Catrope tested again, same problem. But this Chromeversion is old (because of the system here WinXP...). [17:20:15] 10VisualEditor: no warning of unsaved content - https://phabricator.wikimedia.org/T96344#1216038 (10Catrope) >>! In T96344#1216034, @Conny wrote: > @Catrope tested again, same problem. But this Chromeversion is old (because of the system here WinXP...). Then it may well be a bug in your old version of Chrome. H... [17:22:50] (03CR) 10Catrope: [C: 032] Trigger packed galleries resizing logic to match read mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/204509 (owner: 10Esanders) [17:23:23] (03CR) 10Catrope: [C: 031] "OK to merge once MW core patch has been merged" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/204509 (owner: 10Esanders) [17:23:25] (03Merged) 10jenkins-bot: Rewrite the table context as an actual ve.ui.Context [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204269 (owner: 10Esanders) [17:23:27] (03Merged) 10jenkins-bot: Use plural grammar in table context for deleting multiple rows/columns [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198738 (https://phabricator.wikimedia.org/T87234) (owner: 10Pratikbsp) [17:29:49] (03PS1) 10Jforrester: Update VE core submodule to master (795aab5) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/204816 [17:34:17] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (795aab5) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/204816 (owner: 10Jforrester) [17:37:12] 10VisualEditor, 10VisualEditor-MediaWiki-References: When numbering references VE ignores those in infoboxes - https://phabricator.wikimedia.org/T96380#1216102 (10Neil_P._Quinn_WMF) p:5Triage>3Lowest [17:40:34] 10VisualEditor, 10VisualEditor-MediaWiki-References: When numbering references VE ignores those in infoboxes - https://phabricator.wikimedia.org/T96380#1216121 (10Neil_P._Quinn_WMF) The behavior that @Josve05a is describing occurs when the reference list is generated by the `{{reflist}}` template. When it's ge... [17:41:00] (03Abandoned) 10Jforrester: Create CE view initialization event for when $element is created [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/195228 (https://phabricator.wikimedia.org/T91831) (owner: 10Esanders) [17:42:22] (03PS12) 10Jforrester: Add a clean-up script for use as a pre-commit hook [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118758 [17:44:56] 10TemplateData, 6Community-Liaison, 10WMF-Product-Strategy: Please make me a list of commonly used templates in Wikipedia articles - https://phabricator.wikimedia.org/T96323#1216146 (10Rdicerb) @Eloquence -possible to get this resourced, or should I ask Analytics? [17:51:53] (03Merged) 10jenkins-bot: Update VE core submodule to master (795aab5) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/204816 (owner: 10Jforrester) [17:52:01] 10VisualEditor, 10VisualEditor-ContentEditable, 10Parsoid: [ and ] as replacement for [ ] in weblinks not recognised by VE - https://phabricator.wikimedia.org/T95854#1216168 (10ssastry) p:5Triage>3Normal [17:52:12] 10VisualEditor, 10VisualEditor-ContentEditable, 10Parsoid: [ and ] as replacement for [ ] in weblinks not recognised by VE - https://phabricator.wikimedia.org/T95854#1216169 (10ssastry) a:3cscott [17:54:38] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-Links, 5Patch-For-Review: VisualEditor: A link can span whitespace but won't be displayed so cannot be edited or noticed - https://phabricator.wikimedia.org/T39835#1216182 (10Jdforrester-WMF) a:5Catrope>3None [17:54:41] 10MediaWiki-ResourceLoader, 7Wikimedia-log-errors: PHP Notice: Uninitialized string offset: includes/libs/JavaScriptMinifier.php on line 571 - https://phabricator.wikimedia.org/T75556#1216183 (10Jdforrester-WMF) a:5Catrope>3None [17:54:45] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers: Getting stuck inside Link inspector while trying to clear the link text when there was no match for it in the inspector - https://phabricator.wikimedia.org/T68696#1216185 (10Jdforrester-WMF) a:5Catrope>3None [17:54:47] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers: VisualEditor Mobile: [Regression wmf4] Link suggestions are appearing in a broken way inside Link Inspector in mobile - https://phabricator.wikimedia.org/T74402#1216186 (10Jdforrester-WMF) a:5Catrope>3None [17:56:14] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers: In Mobile VE, heading code isn't loaded, causing corruptions when deleting across them - https://phabricator.wikimedia.org/T96395#1216212 (10Jdforrester-WMF) 3NEW [17:57:02] 10VisualEditor, 10VisualEditor-ContentEditable, 3Editing Department 2014/15 Q4 blockers: VisualEditor: Deletion across a header caused it to remain without WS, leading Parsoid to output "====" - https://phabricator.wikimedia.org/T52100#1216223 (10Jdforrester-WMF) 5Open>3Resolved Split that into... [17:57:10] 10VisualEditor, 10VisualEditor-ContentEditable: VisualEditor: Deletion across a header caused it to remain without WS, leading Parsoid to output "====" - https://phabricator.wikimedia.org/T52100#1216227 (10Jdforrester-WMF) [17:57:17] RoanKattouw: T96395 [17:58:24] (03PS1) 10Catrope: Also load mwformatting in mobile [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/204828 (https://phabricator.wikimedia.org/T96395) [18:00:20] (03CR) 10Jforrester: [C: 032] Also load mwformatting in mobile [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/204828 (https://phabricator.wikimedia.org/T96395) (owner: 10Catrope) [18:00:44] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-22_(1.26wmf3): In Mobile VE, heading code isn't loaded, causing corruptions when deleting across them - https://phabricator.wikimedia.org/T96395#1216242 (10Jdforrester-WMF) 5Open>3Res... [18:01:33] Oh, the standup was an hour ago.. [18:01:40] I don't know why I thought it was at 7 [18:02:23] It was at 7 yesterday. [18:02:43] it was.. [18:02:59] Me and Bartosz turned up at 6 and eventually realised. Then I couldn't attend at 7. [18:03:00] (03Merged) 10jenkins-bot: Also load mwformatting in mobile [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/204828 (https://phabricator.wikimedia.org/T96395) (owner: 10Catrope) [18:03:18] 10VisualEditor, 10VisualEditor-MediaWiki-References: When numbering references VE ignores those in infoboxes - https://phabricator.wikimedia.org/T96380#1216258 (10Neil_P._Quinn_WMF) [18:06:27] 10MediaWiki-ResourceLoader, 10VisualEditor, 10VisualEditor-Initialisation, 10VisualEditor-Performance, and 2 others: Pre-fetch VisualEditor modules to improve load speed - https://phabricator.wikimedia.org/T59952#1216271 (10Krenair) [18:13:07] 10Citoid, 10VisualEditor, 3Editing Department 2014/15 Q4 blockers: Empty tag added using Citoid in VisualEditor (?) - https://phabricator.wikimedia.org/T96052#1216282 (10gpaumier) This might have been T96120. [18:13:18] Krenair, Krinkle: Yeah, sorry, yesterday's standup was moved because of the quarterly review meeting [18:15:25] RoanKattouw: Yeah, makes sense [18:15:38] RoanKattouw: Though for part of the year it would normally be on 7pm as well [18:16:01] So when it's 5, 6, or 7, I just assume it's sticky [18:16:24] (03CR) 10Catrope: [C: 04-1] "Instead of requiring extensions to call adJsConfigVars, I think it would be better if we just added a $wgVisualEditorToolbarScrollOffset v" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/203011 (https://phabricator.wikimedia.org/T95528) (owner: 10Florianschmidtwelzow) [18:17:11] 10VisualEditor, 10VisualEditor-MediaWiki-References: When numbering references VE ignores those in infoboxes (when reference list is generated by {{reflist}} template) - https://phabricator.wikimedia.org/T96380#1216315 (10Aklapper) [18:18:48] 10Citoid, 10VisualEditor, 3Editing Department 2014/15 Q4 blockers: Improper use of doi - https://phabricator.wikimedia.org/T95984#1216319 (10Etonkovidova) It seems that some urls are better than others. Paste http://www.nature.com/bjc/journal/v108/n1/full/bjc2012516a.html into autofill and there will be doi... [18:20:52] 10VisualEditor, 10VisualEditor-MediaWiki-References: When numbering references VE ignores those in infoboxes (when reference list is generated by {{reflist}} template) - https://phabricator.wikimedia.org/T96380#1216324 (10Krinkle) I think this bug should focus on the fact that references in the main text flow... [18:23:03] 10TemplateData, 6Community-Liaison, 10WMF-Product-Strategy: Please make me a list of commonly used templates in Wikipedia articles - https://phabricator.wikimedia.org/T96323#1216325 (10Eloquence) @Ironholds do you have bandwidth to take a look? [18:23:12] 10VisualEditor, 10VisualEditor-MediaWiki-References: Transcluded references (e.g. in infoboxes) should follow the same numbering as the main document - https://phabricator.wikimedia.org/T96380#1216327 (10Krinkle) [18:26:19] (03CR) 10Florianschmidtwelzow: "But this wouldn't allow different skins from setting different values? E.g. Vector shouldn't have this offset, but would have it, if anoth" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/203011 (https://phabricator.wikimedia.org/T95528) (owner: 10Florianschmidtwelzow) [18:26:45] 10TemplateData, 6Community-Liaison, 10WMF-Product-Strategy: Please make me a list of commonly used templates in Wikipedia articles - https://phabricator.wikimedia.org/T96323#1216332 (10Ironholds) Yep. [18:28:56] (03CR) 10Catrope: "Hmm, yeah, you're right :( it needs to be set on $out" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/203011 (https://phabricator.wikimedia.org/T95528) (owner: 10Florianschmidtwelzow) [18:31:39] 10VisualEditor, 10Browser-Tests, 6Release-Engineering: Selenium bug with Firefox causes VE test failure - https://phabricator.wikimedia.org/T90651#1216342 (10Aklapper) 5Open>3Resolved a:3Aklapper >>! In T90651#1157077, @zeljkofilipin wrote: > I see the commit is merged. Can this be closed? No reply. A... [18:36:28] 10VisualEditor, 10VisualEditor-MediaWiki-References: Transcluded references (e.g. in infoboxes) should follow the same numbering as the main document - https://phabricator.wikimedia.org/T96380#1216370 (10matmarex) [18:36:30] 10VisualEditor, 10VisualEditor-DataModel, 10VisualEditor-MediaWiki-References: VisualEditor: References created by templates numbered alone, not with the rest of the page, and don't show up as references to insert - https://phabricator.wikimedia.org/T52474#1216371 (10matmarex) [18:37:58] 10MediaWiki-ResourceLoader, 10VisualEditor: Devise a means of testing local code on production wikis - https://phabricator.wikimedia.org/T87384#1216385 (10Aklapper) @ori: Does matmarex' comment fulfil your needs? If yes, should this be documented somewhere (where?) and this ticket closed? [18:38:11] 10MediaWiki-Page-editing, 7JavaScript: Live preview should process JSConfigVars - https://phabricator.wikimedia.org/T92944#1216386 (10Aklapper) p:5Triage>3Low [18:45:32] (03CR) 10Catrope: [C: 04-1] Rearrange images when the media search window resizes (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/204568 (https://phabricator.wikimedia.org/T95017) (owner: 10Mooeypoo) [18:46:48] (03CR) 10CSteipp: [C: 04-1] "Minor update still needed. But hopefully Chad/Nik have a better way entirely." (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/197737 (https://phabricator.wikimedia.org/T93075) (owner: 10Physikerwelt) [18:56:34] 10TemplateData, 6Community-Liaison, 10WMF-Product-Strategy: Please make me a list of commonly used templates in Wikipedia articles - https://phabricator.wikimedia.org/T96323#1216505 (10Rdicerb) Thank you! :D [19:16:40] (03PS1) 10Physikerwelt: Update Hook call [extensions/Math] - 10https://gerrit.wikimedia.org/r/204851 [19:17:29] (03CR) 10Chad: [C: 04-2] "I'm really not a huge fan of this approach at all. It seems fragile and prone to security issues (per Chris). Also, SearchShowHit is calle" [extensions/Math] - 10https://gerrit.wikimedia.org/r/197737 (https://phabricator.wikimedia.org/T93075) (owner: 10Physikerwelt) [19:20:38] (03Abandoned) 10Physikerwelt: Render math tags in search results [extensions/Math] - 10https://gerrit.wikimedia.org/r/197737 (https://phabricator.wikimedia.org/T93075) (owner: 10Physikerwelt) [19:22:18] (03CR) 10Physikerwelt: "Please comment on T93075 to discuss alternative aproaches." [extensions/Math] - 10https://gerrit.wikimedia.org/r/197737 (https://phabricator.wikimedia.org/T93075) (owner: 10Physikerwelt) [19:25:15] 10WikiEditor, 7JavaScript: Remove button for from toolbar - https://phabricator.wikimedia.org/T40487#1216595 (10He7d3r) [19:32:08] 10WikiEditor, 7Browser-Support-Internet-Explorer: Toolbar : Special character insertion moves cursor to beginning of edit box - https://phabricator.wikimedia.org/T24479#1216619 (10He7d3r) [19:32:10] 10WikiEditor: too many buttons in the toolbar, or little available width for the toolbar, causes buttons to overflow - https://phabricator.wikimedia.org/T25943#1216621 (10He7d3r) [19:32:12] 10WikiEditor, 7JavaScript, 7Performance: "Replace all" is very slow: WikiEditor should do a one-step replace when replacing all occurrences - https://phabricator.wikimedia.org/T25510#1216622 (10He7d3r) [19:32:14] 10WikiEditor: Custom bold and italic icons for Russian & Ukrainian language - https://phabricator.wikimedia.org/T25914#1216618 (10He7d3r) [19:36:12] 10VisualEditor, 7Browser-Support-Firefox: Editing a picture's caption doesn't work correctly in Firefox - https://phabricator.wikimedia.org/T76219#1216632 (10Neil_P._Quinn_WMF) I tried to reproduce this on Firefox 37.0.1 and [[https://en.wikipedia.org/w/index.php?title=User%3ANeil_P._Quinn-WMF%2Fsandbox&diff=6... [19:36:24] 10VisualEditor, 7Browser-Support-Firefox: Editing a picture's caption doesn't work correctly in Firefox - https://phabricator.wikimedia.org/T76219#1216633 (10Neil_P._Quinn_WMF) 5Open>3Resolved [19:45:51] Krinkle, "$content The most appropriate element containing the content, such as #mw-content-text (regular content root) or #wikiPreview (live preview root)" [19:46:15] why shouldn't a ve-mw-gallery node be consider a live preview container? [19:48:14] I noticed that for galleries it expected $content to contain *all* galleries on the page [19:48:22] are you saying the documentation suggests that is correct [19:48:32] if so - what do you propose? [19:50:02] edsanders: Where do you intend to use this? [19:50:12] https://gerrit.wikimedia.org/r/#/c/204509/ [19:51:07] but anyone who adds partial content to the page dynamically will have the same issue, e.g. flow [19:51:10] edsanders: I think for the use case of re-rendering a section (e.g. after making a section edit and saving a document fragment, refreshing that part of the page) it would work fine and in that case you'd have a container, too. [19:51:26] But running it on a single node seems odd. And would suggest you're running it inside CE, not in View. [19:51:37] And I think we really really don't want to have user scripts run on the CE dom. [19:51:39] the implentation of gallery was broken in that sense [19:51:49] it has a closure variable $galleries [19:52:09] which gets updated every time you fired the hook, based on children of $content only [19:52:13] 10VisualEditor: issues with CTRL-K on OSX (at least) - https://phabricator.wikimedia.org/T70181#1216718 (10Neil_P._Quinn_WMF) Seems to be fixed now, at least using Firefox 37.0.1 and Chrome 35.0.1916.153. Please reopen if you can still reproduce. [19:52:24] 10VisualEditor: issues with CTRL-K on OSX (at least) - https://phabricator.wikimedia.org/T70181#1216722 (10Neil_P._Quinn_WMF) 5stalled>3Resolved [19:52:33] so if you fired on the second half of the page only, it would 'forget' the galleries in the first half [19:52:51] Yeah, I saw that, but that's a separate bug. [19:52:59] Krinkle, we can't fire on a container - it would trigger other functionality we don't want - such as sortable tables [19:53:18] as in this case the only container of the galleries is the document root node [19:54:03] Yes. [19:54:48] wikipage.content is for view content though. [19:54:58] And the way it is used by many gadgets will destroy things. [19:55:19] focusable nodes are essentially locked-off previews of the read mode [19:55:47] plenty of gadgets perform global queries on the document instead of using the $content context. [19:56:07] Sometimes that's the only way they can do what they need to do. [19:56:22] another example would be math nodes that use the JS lib to render [19:56:24] Triggering wikipage hooks on the edit surface is a bad idea. [19:56:39] We can maybe fine a way to expose the gallery methods and expose them and call them ourselves [19:56:39] currently we have to re-implement that logic in VE [19:57:06] We don't want an interactive widget inside the surface right? [19:57:16] That's what most wikipage.content handlers do though. [19:57:54] e.g. ajax to the api and request data in real time. [19:57:57] for a refreshing template [19:58:09] sortable, indeed. [19:58:24] sometimes interactivity [19:58:33] sometimes rendering - such as gallery and math [19:58:49] also, gallery as it is is quite poorly written and performs quite badly with its resizing. I file a bug about this but that script was introduced by a volunteer and merged by another and is not maintained or owned by anyone. [19:58:53] we can deal with either provided they are protected nodes [19:59:10] Like I said, nothing prevents it from going outside that container. [19:59:22] I though the packed mode was written by multimedia team? [19:59:29] Even if it's well-written and limits is search focus to the container, the execution focus often still goes outside (with good reason) [20:00:04] as long as it doesn't modify outside the container though [20:00:21] eg. for a template X "Refresh foo" it will make ajax calls while the editor is active and paint it in the sidebar or other view-like things. [20:00:26] It will, and it does. [20:00:55] ok - so we should expose the gallery code another way? [20:01:05] If it's for rendering purposes, we can either think of a generic way to handle that or if we have a subclass for it already, call the logic directly. [20:01:39] Yeah, in a way that allows us to do it passively [20:01:52] edsanders: packed mode was written by bawolff. updating the packed mode rendering on live preview and window resize was written by m4tx (GCI student) [20:03:28] Krinkle, is there a standard for doing that? [20:03:36] edsanders: mw.page.gallery.something [20:03:38] as a public method [20:03:58] or mw.gallery.something even [20:03:59] not sure [20:04:58] A rough write up at https://phabricator.wikimedia.org/T88654 [20:05:39] edsanders: I'm curious why it needs to much code. There should be a way to do it more css-y. [20:05:54] Maybe with less resizing. [20:06:11] It re-requesting the thumbnails and all that seems quite extreme. [20:08:41] 10VisualEditor, 7Browser-Support-Google-Chrome: VE shows 'not logged in' msg. for logged-in user: Chrome on 56K connection - https://phabricator.wikimedia.org/T57756#1216796 (10Jdforrester-WMF) 5stalled>3Resolved a:3Jdforrester-WMF Not able to reproduce, report based on code that's changed significantly... [20:09:01] yes, it's crap [20:09:19] I think mooeypoo should rewrite it [20:09:34] as our resident bricklayer [20:10:18] 10VisualEditor, 10VisualEditor-MediaWiki-Templates: Transclusion dialog's "Add more information" button responds to right-click but should not - https://phabricator.wikimedia.org/T71230#1216800 (10Jdforrester-WMF) p:5Triage>3Low [20:10:29] 10VisualEditor, 10VisualEditor-MediaWiki-Templates: Transclusion dialog's "Add more information" button responds to right-click but should not - https://phabricator.wikimedia.org/T71230#743333 (10Jdforrester-WMF) Not Firefox specific any more. [20:10:58] 10VisualEditor, 10Beta-Cluster, 10Wikimedia-Search: File search on beta labs returns results from production commons and beta commons. VE search results are in unexpected order also. - https://phabricator.wikimedia.org/T90650#1216804 (10Jdforrester-WMF) 5Open>3declined [20:11:38] 10VisualEditor, 10VisualEditor-MediaWiki-Media: Search text for inserting media should be selected on open - https://phabricator.wikimedia.org/T78821#1216808 (10Jdforrester-WMF) [20:11:39] 10VisualEditor, 10VisualEditor-MediaWiki-Media: Insert/Media inspector should appear with focus on input box and default text pre-selected - https://phabricator.wikimedia.org/T88021#1216807 (10Jdforrester-WMF) [20:11:51] 10VisualEditor, 10VisualEditor-MediaWiki-Media: Insert/Media inspector should appear with focus on input box and default text pre-selected - https://phabricator.wikimedia.org/T88021#1002653 (10Jdforrester-WMF) [20:11:53] 10VisualEditor, 10VisualEditor-MediaWiki-Media: Search text for inserting media should be selected on open - https://phabricator.wikimedia.org/T78821#1216811 (10Jdforrester-WMF) 5Open>3Resolved [20:11:58] 10VisualEditor, 10VisualEditor-MediaWiki-Media: Insert/Media inspector should appear with focus on input box and default text pre-selected - https://phabricator.wikimedia.org/T88021#1216813 (10Jdforrester-WMF) 5Open>3Resolved [20:12:24] 10WikiEditor, 7Easy, 5Patch-For-Review, 7Upstream: WikiEditor: Add SVG versions of editing toolbar icons - https://phabricator.wikimedia.org/T37342#1216815 (10Paladox) I think I found a fix for chrome zooming out what about using zoom: 0.9; because that fixes the problem for me. [20:12:29] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Suggestion lists (of templates/links/categories/etc.) differ over time with the same input (e.g. between browsers/users) - https://phabricator.wikimedia.org/T55231#1216816 (10Jdforrester-WMF) 5Open>3declined [20:13:46] 10WikiEditor, 3Editing Department 2014/15 Q4 blockers: editSessionID is duplicated in Edit:Schema for Wikitext - https://phabricator.wikimedia.org/T95919#1216820 (10Jdforrester-WMF) p:5High>3Unbreak! [20:23:44] 10WikiEditor, 7JavaScript: Remove button for from toolbar - https://phabricator.wikimedia.org/T40487#1216856 (10EoRdE6) I brought this up on the en.wiki village pump not knowing this was here. I think it would be a simple fix to use either {{big}} or the span style that it uses. [20:30:55] 10WikiEditor: mw:Extension:WikiEditor injects HTML5 obsolete tags. - https://phabricator.wikimedia.org/T96387#1216882 (10EoRdE6) This may have already been filed as T40487 awhile ago. [20:42:55] edsanders, are you the person to ask about surface/toolbar active state stuff? I have a bug I'm trying to follow up on in Mobile and I'm going in circles. [20:43:20] you can try me [20:43:37] edsanders, when we load VE in desktop, the cursor is placed on the beginning of the surface, which means the toolbar can read the state and activate whatever buttons are relevant [20:43:48] but in mobile, we don't have a cursor active -- and the toolbar is active by default [20:44:40] if you deliberately click in the surface and then out of it, the toolbar is turned off -- which means that the state change is active. I think all tools listen to "updateState" by the toolbar at that point and active/deactivate themselves accordingly [20:45:01] thing is -- I can't figure out where VE actually decides to place the cursor somewhere in the document -- it seems that this is the problem in mobile [20:45:08] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor:Clicking on reference does not bring up the reference add dialog for a specific case in production - https://phabricator.wikimedia.org/T59725#1216959 (10Etonkovidova) 5Open>3Resolved [20:45:11] edsanders, does this makes sense? [20:46:01] right [20:46:12] edsanders, I'm looking at ve.ce.Surface.initialize [20:46:37] there's "this.documentView.getDocumentNode().setLive( true );" but that method seems to iterate through the branch nodes and set them to "live" [20:46:37] it might be higher up [20:46:44] so I think that's not the right place [20:48:28] edsanders, I also placed a debugger in ve.ui.Toolbar#updateToolState, which, if this.getSurface()is null (like in the initialization of the mobile ve) emits 'updateState' for the tools -- but that debugger statement isn't popping up in VE mobile load.. [20:48:29] 10VisualEditor, 10VisualEditor-MediaWiki, 7Browser-Support-Opera: Unable to edit any page with VE using Opera 12: "ve-api: Revision IDs (doc=0,api=NNN) returned by server do not match." - https://phabricator.wikimedia.org/T96435#1216976 (10matmarex) 3NEW a:3matmarex [20:48:57] So by default ve doesn't focus the surface on load [20:49:01] which is correct [20:49:02] oh... wait, it's called from ve.init.mw.ViewPageTarget#activate... but there's no mobile [20:49:15] edsanders, it does in ViewPageTarget [20:49:19] it's up to the instantiator of ve to do this [20:49:24] in stand alone that is demo.js [20:49:28] pageTarget.getSurface().getView().focus(); [20:49:42] in MW it will probably be in one of the init.js files [20:49:59] demo.js: container.surface.getView().focus(); [20:50:01] edsanders, yeah I remember fixing this for firefox [20:50:03] In mobile VE that would be MobileViewTarget.js [20:50:09] Remember that ViewPageTarget.js is desktop-only [20:50:56] is the desired behaviour on mobile to *not* focus the surface? [20:51:23] edsanders, if it is, we need to disable all tools by default. Or rather, have the toolbar emit updateState [20:51:36] if not, then we need to focus the surface [20:51:47] yes [20:51:52] the default state should be disabled [20:51:59] So it sounds like maybe the dm.Selection is out of sync with reality? [20:52:02] although RoanKattouw might have played with that for performance? [20:52:04] We shouldn't have the cursor in the beginning of the document? [20:52:13] Unless we have a NullSelection and the toolbar is still active [20:52:27] no the surface starts off with a NullSelection [20:52:41] if it helps, the debug bar shows "null" initially [20:53:06] if you check out the minimal demo [20:53:17] demos/ve/minimal.html [20:53:22] (requires grunt build) [20:53:26] you'll see that same bug [20:53:33] the surface is not focused, but the tools are enabled [20:53:35] edsanders, oh, I see. So it's not just for mobile. [20:53:48] nope [20:54:57] hm [20:55:12] I would just override ve.ui.Tool to disable the tool on construction [20:55:31] or... I was thinking of forcing an updateState on construction of the surface [20:55:51] that way, whether you have a cusror somewhere or not, you get the valid state [20:55:52] IIRC MatmaRex painstakingly got rid of that updateState call [20:55:57] Maybe that caused this [20:55:58] no.. it's still there? [20:56:57] all tools have "onUpdateState" method [20:57:02] OO.ui and ve.ui tools [20:57:10] No, what I mean is [20:57:10] hmm? [20:57:12] the problem is that is too late [20:57:25] edsanders, well, it doesn't seem to be emitted at all on construction of the surface? [20:57:26] the tools will start off enabled, then when the surface is ready they get disabled [20:57:29] You suggested calling updateState an additional time, and we recently removed a *call to* (not the *function named*) updateState [20:57:37] one of the calls, not all of them [20:57:39] edsanders, oh, oh, I see what youmean [20:57:51] you already *must* emit 'updateState' event on toolbar after it's initialized, if that's what we're talking about [20:58:04] otherwise 'menu' toolgroups are busted [20:58:07] Oh, right, so you're saying maybe we start tools off as disabled and we enable them conditionally later? [20:58:09] MatmaRex, either that doesn't happen properly or that doesn't happen always? [20:58:16] maybe [20:58:21] I think we should default the tools to disabled, then emit updateState on surface ready [20:58:31] what i am saying is that, for OOUI toolbars, it must be done [20:58:36] MatmaRex, atm, the problem is that in the minimal demo and in mobile, the toolbar is enabled but the focus isn't on the surface [20:58:41] so you can click the buttons but they do nothing [20:58:44] VE code already disregards many things about OOUI toolbars that must be done or not done :) [20:59:07] the tools are constructed before the surface. In the absence of a surface we should assume the tools have nothing to do and disable them [20:59:15] * mooeypoo nods [20:59:30] once the surface is ready - it should emit an 'updateState' which, with a NullSelection will keep *most* tools disabled [20:59:53] if the init script then focuses the surface, then updateState will go again with a real selection [21:00:11] toolbar.updateToolState() seems to be what we should call when the surface is enabled [21:02:02] or you can emit a 'contextChange' from the surface model [21:02:50] I'm looking at this.getView().initialize(); [21:02:50] this.getModel().startHistoryTracking(); [21:03:06] we could make the second line this.getModel().initialize() [21:03:31] where is this? [21:03:32] then dm.Surface.initialize = fn{ this.startHistoryTracking(); this.emit( 'contextChange' ); } [21:03:41] ve.ui.surface [21:04:02] ohh [21:04:32] 10VisualEditor, 10VisualEditor-MediaWiki: Error during editor initialization leaves it in half-loaded unrecoverable state - https://phabricator.wikimedia.org/T96437#1217020 (10matmarex) 3NEW [21:06:12] edsanders, yeah this works in ve-mw and mobile [21:06:21] going to check minimal in a sec and push a fix to gerrit [21:10:30] edsanders, RoanKattouw MatmaRex https://gerrit.wikimedia.org/r/#/c/204934/ [21:11:28] (03CR) 10Esanders: [C: 031] Initialize toolbar tools disabled until surface is initialized [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204934 (owner: 10Mooeypoo) [21:14:12] (03CR) 10Catrope: [C: 031] Initialize toolbar tools disabled until surface is initialized [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204934 (owner: 10Mooeypoo) [21:21:10] (03CR) 10Bartosz Dziewoński: "I know next to nothing about this." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204934 (owner: 10Mooeypoo) [21:22:39] 10VisualEditor: [Regression pre-wmf 3] Citation dialogs are now not showing any parameters in it - https://phabricator.wikimedia.org/T96443#1217091 (10Ryasmeen) 3NEW a:3Mooeypoo [21:24:08] (03PS1) 10Esanders: Split visualEditor.css into apex & mediawiki versions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204935 [21:30:28] (03CR) 10Catrope: [C: 032] Initialize toolbar tools disabled until surface is initialized [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204934 (owner: 10Mooeypoo) [21:33:46] (03Merged) 10jenkins-bot: Initialize toolbar tools disabled until surface is initialized [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204934 (owner: 10Mooeypoo) [21:37:18] heh :) at first i got kicked [21:37:47] with reason "invite only channel". then i just repeat it and i can join ? [21:39:55] 10VisualEditor, 10MediaWiki-extensions-Graph, 10Possible-Tech-Projects, 6Services, and 2 others: Outreachy and GSoC 2015 Proposal for Graph editing in Visual Editor - https://phabricator.wikimedia.org/T93788#1217185 (10ssastry) [21:41:02] (03PS1) 10Esanders: [BREAKING CHANGE] Simplify getModelFromDom signature [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204941 [21:41:04] (03PS1) 10Esanders: Create RTL version of minimal demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204942 [21:41:07] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-Tables: Cannot click into table cell on Firefox - https://phabricator.wikimedia.org/T96446#1217186 (10Neil_P._Quinn_WMF) 3NEW [21:41:29] (03PS1) 10Esanders: Use simplified getModelFromDom API [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/204943 [21:44:30] (03PS1) 10Bartosz Dziewoński: Don't drop attributes when parsing HTML on Opera 12 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204944 (https://phabricator.wikimedia.org/T96435) [21:44:51] MatmaRex, can we have *-icons-editing-all.css? [21:45:17] (03CR) 10Jforrester: "> :/ this is going to bloat the user_properties table...can you use the UserLoadDefaults hook instead?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/204933 (owner: 10Jforrester) [21:45:20] edsanders: ask James_F [21:45:36] why? [21:45:53] for the minimal demo [21:47:30] we're trying to concatenate where possible [21:47:32] (03CR) 10Catrope: [C: 032] Don't drop attributes when parsing HTML on Opera 12 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204944 (https://phabricator.wikimedia.org/T96435) (owner: 10Bartosz Dziewoński) [21:47:54] is there any relation between Mediawiki VE and Wordpress VE? [21:48:26] as in https://en.support.wordpress.com/visual-editor/ [21:48:26] RoanKattouw: by the way. is there a simple reason why we can't just use the XML version of DomParser in that function? [21:48:47] (it seemed to work when i tried it) [21:49:49] (03Merged) 10jenkins-bot: Don't drop attributes when parsing HTML on Opera 12 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204944 (https://phabricator.wikimedia.org/T96435) (owner: 10Bartosz Dziewoński) [21:51:46] 10VisualEditor, 10VisualEditor-EditingTools, 3Editing Department 2014/15 Q4 blockers: [Regression pre-wmf3] Language Tool doesn't appear in the interface any more - https://phabricator.wikimedia.org/T96447#1217220 (10Jdforrester-WMF) 3NEW [21:52:07] mutante: They stole our name. Otherwise, no. [21:52:10] https://phabricator.wikimedia.org/T96447 [21:52:33] James_F, icons-editing-all.css? [21:52:35] MatmaRex: What do you mean exactly? [21:52:42] edsanders: No. [21:52:47] Use XML DOMParser to generate an HTML DOM? [21:52:50] James_F: i was wondering because both are a PHP project and kind of doing the same thing [21:53:04] RoanKattouw: yeah [21:53:16] mutante: Ours is JS, thankyousoverymuch. :-) [21:53:29] obviously, only when we pass XHTML there, but we usually do. [21:54:09] 10VisualEditor, 10VisualEditor-MediaWiki, 7Browser-Support-Opera, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-22_(1.26wmf3): Unable to edit any page with VE using Opera 12: "ve-api: Revision IDs (doc=0,api=NNN) returned by server do not ma... - https://phabricator.wikimedia.org/T96435#1217227 [21:54:15] 10VisualEditor, 10VisualEditor-MediaWiki, 7Browser-Support-Opera, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-22_(1.26wmf3): Unable to edit any page with VE using Opera 12: "ve-api: Revision IDs (doc=0,api=NNN) returned by server do not ma... - https://phabricator.wikimedia.org/T96435#1216976 [21:54:18] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-Tables: Cannot click into table cell on Firefox - https://phabricator.wikimedia.org/T96446#1217232 (10Neil_P._Quinn_WMF) [21:54:27] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-Tables: Cannot click into table cell on Firefox - https://phabricator.wikimedia.org/T96446#1217236 (10Neil_P._Quinn_WMF) p:5Normal>3Low [21:54:29] 10VisualEditor, 10VisualEditor-EditingTools, 3Editing Department 2014/15 Q4 blockers: [Regression pre-wmf3] Language Tool doesn't appear in the interface any more - https://phabricator.wikimedia.org/T96447#1217220 (10Jdforrester-WMF) [21:55:33] James_F: right, i meant Mediawiki and Wordpress.. *nod* [21:56:12] mutante: WordPress could (and should) switch their 'Visual Editor' plugin to use VisualEditor rather than CKEditor (or whatever it is), but it's a lot of work. [21:56:40] (03CR) 10Jforrester: [C: 032] Split visualEditor.css into apex & mediawiki versions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204935 (owner: 10Esanders) [21:57:16] James_F: gotcha [21:58:17] 10WikiEditor, 3Editing Department 2014/15 Q4 blockers: editSessionID is duplicated in Edit:Schema for Wikitext - https://phabricator.wikimedia.org/T95919#1217254 (10Jdforrester-WMF) a:3Catrope [21:58:20] James_F, https://github.com/wikimedia/VisualEditor/blob/master/demos/ve/minimal.html [21:58:23] terrible answer [21:58:49] (03CR) 10Bartosz Dziewoński: [C: 032] [BREAKING CHANGE] Fix font sizes and padding in Surface and SurfaceWidget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/200575 (owner: 10Esanders) [21:59:04] edsanders: The whole point was to avoid having them all in one file. [21:59:18] edsanders: There are ~500 of them. [21:59:29] edsanders: Do you really want them embedded in one mammoth CSS file? [21:59:58] *editing*-all [22:05:36] RoanKattouw, hey [22:05:39] Hey [22:05:44] I'm digging around in EventLogging things [22:05:49] How do I get server-side logged events to show? [22:06:02] I just noticed James assigned you that task I have some code for locally [22:06:04] edsanders: That's ~300 or something silly. [22:06:10] Krenair: Oh, awesome, even better. :-) [22:06:13] 300 what? [22:06:23] RoanKattouw, $wgEventLoggingFile = '/home/alex/Development/MediaWiki/events.log'; [22:06:26] Krenair: Oh? Code? [22:06:26] Krenair: Does it work? ;-) [22:06:29] Yeah I tried that [22:06:34] events.log isn't written to :( [22:06:35] James_F, I don't think so [22:06:41] At least not quite [22:06:41] edsanders: Icons in icons-editing-*.css [22:07:05] we already including icons-editing-* [22:07:08] nm got it [22:07:09] just as separate files [22:07:10] permissions issue [22:07:17] aha [22:07:18] edsanders: All of them? I think we're still missing a few. [22:07:19] Krenair: So what's this code you have localyl? [22:07:19] I hate those issues [22:07:26] edsanders: BICBW. [22:07:26] no - all of them [22:07:39] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-Tables: Cannot click into table cell on Firefox - https://phabricator.wikimedia.org/T96446#1217272 (10Neil_P._Quinn_WMF) [22:07:45] RoanKattouw, store the editing stats/session id in a cookie instead of hidden inputs [22:07:51] (03Merged) 10jenkins-bot: Split visualEditor.css into apex & mediawiki versions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204935 (owner: 10Esanders) [22:08:02] Hmm :S [22:08:04] IIRC the issue I was running into was more bfcache crap :( [22:08:10] But the hidden inputs thing is *almost* perfect [22:08:23] Is there a problem with using the pageshow event to get around the bfcache issue? [22:08:28] edsanders: Write a grunt copy:… task then? [22:08:46] RoanKattouw, the pageshow event? [22:08:51] edsanders: But Flow won't use it. WikiEditor won't use it. CodeEditor won't use it. Etc. [22:09:04] Firefox has a pageshow event that fires when a tab comes back from the dead [22:09:24] I think we reproduced the issue in Chrome [22:09:30] Aaron says so [22:09:32] But I can't reproduce it [22:09:42] Urgh. [22:09:53] Only in Firefox [22:10:30] Also, there is a way to disable bfcache [22:10:36] by having an onbeforeunload handler [22:11:12] We generally try to avoid that because bfcache enhances performance though [22:11:39] so if we detect that we hit bfcache, generate a new session ID and set that instead? [22:11:44] yeah [22:11:51] I guess that does mean we need to generate a new one client-side [22:11:57] But VE already does that [22:12:00] We'll need to generate an init event as well [22:12:07] Yeah that too [22:12:09] Yeah but VE does everything client-side [22:12:18] VE also doesn't have to put up with this crap [22:12:28] So... in what scenarios have *you* been able to reproduce duplicate IDs locally? [22:12:29] because it doesn't involve moving between pages and forms etc. [22:12:36] The only one I found was back button after save in Firefox [22:12:55] Multiple tabs aren't an issue (but would be a big problem with cookies I'd expect), and the back button doesn't do anything weird in Chrome [22:13:27] for me [22:13:39] I don't think I had a consistent way of doing it that I trust [22:13:42] But maybe you've found things I haven't, I mean I've only been poking at this for less than half an hour [22:14:54] I really have no confidence in the stuff I've done involving these events. [22:15:07] Nothing has worked as expected. [22:15:50] Your hidden input strategy seemed good to me [22:16:13] Well, clearly it didn't work as well as expected.. [22:16:22] Yeah I mean [22:16:31] (03Merged) 10jenkins-bot: [BREAKING CHANGE] Fix font sizes and padding in Surface and SurfaceWidget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/200575 (owner: 10Esanders) [22:16:33] How often do people use the back button [22:16:38] And how often do they use Firefox [22:16:46] Does that match the frequency of these duplicate sessions? [22:17:13] And do we have the browser distribution for these bad sessions? Are they all Firefox? [22:17:20] I have no idea what the browser stats are for these. [22:17:27] Aaron could check, I guess. [22:18:57] I don't think the beta tables, which I do have access to, would be a good representation of the actual frequencies... [22:19:28] (03PS3) 10Jforrester: Update VE core submodule to master (5b0e269) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200574 (owner: 10Esanders) [22:19:57] (03CR) 10Jforrester: [C: 032] Update VE core submodule to master (5b0e269) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200574 (owner: 10Esanders) [22:25:12] (03PS1) 10Bartosz Dziewoński: Update VE core submodule to master (5b0e269) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/204956 [22:25:19] ugh [22:25:22] i have great timing [22:25:38] (03Abandoned) 10Bartosz Dziewoński: Update VE core submodule to master (5b0e269) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/204956 (owner: 10Bartosz Dziewoński) [22:26:02] MatmaRex: It needs a special pull-through, you see. [22:26:15] i know [22:26:34] i wanted to merge that and so i submitted the submodule update [22:26:44] * James_F grins [22:28:38] (03Merged) 10jenkins-bot: Update VE core submodule to master (5b0e269) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200574 (owner: 10Esanders) [22:39:39] 10WikiEditor, 7JavaScript: Remove button for from toolbar - https://phabricator.wikimedia.org/T40487#1217353 (10Technical13) a:3Technical13 [22:40:41] 10WikiEditor, 7JavaScript: Remove button for from toolbar - https://phabricator.wikimedia.org/T40487#432312 (10Technical13) [22:40:43] 10WikiEditor: mw:Extension:WikiEditor injects HTML5 obsolete tags. - https://phabricator.wikimedia.org/T96387#1217354 (10Technical13) [22:52:39] (03PS5) 10Bartosz Dziewoński: [BREAKING CHANGE] MenuLayout: Reimplement without inline styles [oojs/ui] - 10https://gerrit.wikimedia.org/r/198565 [22:55:11] 10WikiEditor, 6Editing, 10MediaWiki-extensions-ProofreadPage, 7JavaScript, and 2 others: WikiEditor toolbar is loaded twice when editing - https://phabricator.wikimedia.org/T93384#1217375 (10GOIII) UPDATE: Seems to be resolved for me as well as for previous reports (en.wikisource) //Thank You//. ... and a... [22:55:26] MatmaRex: ^^^ Neat. [22:57:45] 10VisualEditor, 10VisualEditor-MediaWiki: VE-MW special characters panel takes a while to open the first time, freezing the UI - https://phabricator.wikimedia.org/T96456#1217378 (10matmarex) 3NEW [22:57:46] :) [23:01:24] (03PS3) 10Bartosz Dziewoński: MenuLayout: Fix initialization order [oojs/ui] - 10https://gerrit.wikimedia.org/r/204125 [23:01:26] (03PS6) 10Bartosz Dziewoński: [BREAKING CHANGE] MenuLayout: Reimplement without inline styles [oojs/ui] - 10https://gerrit.wikimedia.org/r/198565 [23:04:28] 10WikiEditor, 6Editing, 10MediaWiki-extensions-ProofreadPage, 7JavaScript, and 2 others: WikiEditor toolbar is loaded twice when editing - https://phabricator.wikimedia.org/T93384#1217395 (10Krenair) I'm glad that change resolved it. Thanks for confirming it, and for waiting for code review to happen. [23:04:45] 10WikiEditor, 6Editing, 7JavaScript, 5Patch-For-Review, 7Regression: WikiEditor toolbar is loaded twice when editing - https://phabricator.wikimedia.org/T93384#1217396 (10Krenair) [23:04:52] 10WikiEditor, 6Editing, 7JavaScript, 7Regression: WikiEditor toolbar is loaded twice when editing - https://phabricator.wikimedia.org/T93384#1135838 (10Krenair) [23:13:17] (03PS1) 10Bartosz Dziewoński: ve.ui.SpecialCharacterDialog: Update for changes in OOjs ui [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204963 [23:13:54] (03CR) 10Bartosz Dziewoński: "VE change: https://gerrit.wikimedia.org/r/#/c/204963/" [oojs/ui] - 10https://gerrit.wikimedia.org/r/198565 (owner: 10Bartosz Dziewoński) [23:14:23] James_F, viewport position when section editing seems pretty broken and unpredictable right now, fyi, not sure that's a regression (e.g. editing the goals page on mw.org, or https://meta.wikimedia.org/w/index.php?title=Research:Wikidata_gap_analysis o nmeta) [23:17:41] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki-Links: VE ignores some changes? - https://phabricator.wikimedia.org/T95059#1217403 (10Etonkovidova) There are two issues here: First, VE Link inspector always displays links with the first letter capitalized. 1. Type a word in lower c... [23:21:42] (03PS1) 10Jforrester: Follow-up 28844ed: Revert mis-rename of Language command [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204965 (https://phabricator.wikimedia.org/T96447) [23:22:00] Eloquence: I think it's gradually worsened, yes. [23:22:04] Eloquence: Something to fi. [23:22:06] +x [23:22:57] 10VisualEditor, 10VisualEditor-EditingTools, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review: [Regression pre-wmf3] Language Tool doesn't appear in the interface any more - https://phabricator.wikimedia.org/T96447#1217414 (10Jdforrester-WMF) a:3Jdforrester-WMF [23:23:14] 10VisualEditor: Nested references cause infinite loop - https://phabricator.wikimedia.org/T96193#1217415 (10Etonkovidova) 5Open>3Resolved [23:23:23] 10VisualEditor: Nested references cause infinite loop - https://phabricator.wikimedia.org/T96193#1210596 (10Etonkovidova) Checked in beta. [23:24:01] (03CR) 10Catrope: [C: 032] Follow-up 28844ed: Revert mis-rename of Language command [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204965 (https://phabricator.wikimedia.org/T96447) (owner: 10Jforrester) [23:26:15] (03Merged) 10jenkins-bot: Follow-up 28844ed: Revert mis-rename of Language command [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204965 (https://phabricator.wikimedia.org/T96447) (owner: 10Jforrester) [23:32:53] 10VisualEditor, 7Verified-in-Phase0: Nested references cause infinite loop - https://phabricator.wikimedia.org/T96193#1217435 (10Etonkovidova) [23:36:39] 10VisualEditor, 10VisualEditor-EditingTools, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-22_(1.26wmf3): [Regression pre-wmf3] Language Tool doesn't appear in the interface any more - https://phabricator.wikimedia.org/T96447#1217437 (10Jdforrester-WMF) 5Open>3Resolved [23:36:58] (03PS1) 10Jforrester: Update VE core submodule to master (8bb191b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/204967 [23:38:17] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (8bb191b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/204967 (owner: 10Jforrester) [23:40:46] (03Merged) 10jenkins-bot: Update VE core submodule to master (8bb191b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/204967 (owner: 10Jforrester) [23:43:27] 10VisualEditor, 7Technical-Debt: Tech debt: references inside other references cause infinite loops - https://phabricator.wikimedia.org/T96460#1217460 (10Mooeypoo) 3NEW [23:43:51] 10VisualEditor, 10VisualEditor-MediaWiki-References, 7Technical-Debt: Tech debt: references inside other references cause infinite loops - https://phabricator.wikimedia.org/T96460#1217467 (10Jdforrester-WMF) p:5Triage>3Normal [23:44:05] 10VisualEditor, 10VisualEditor-MediaWiki-References, 7Technical-Debt: Tech debt: references inside other references cause infinite loops - https://phabricator.wikimedia.org/T96460#1217471 (10Mooeypoo) [23:44:07] 10VisualEditor, 7Verified-in-Phase0: Nested references cause infinite loop - https://phabricator.wikimedia.org/T96193#1217472 (10Mooeypoo) [23:45:15] James_F, What do you think of https://phabricator.wikimedia.org/T95992 ? [23:45:19] I think it should be editable [23:45:28] Krenair: It's a dupe. [23:45:42] ok, that works as well :) [23:45:52] And yes, it should be editable. [23:45:54] * James_F hunts. [23:46:46] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-Tables, 7Browser-Support-Firefox: Cannot click into a particular table cell on Firefox - https://phabricator.wikimedia.org/T96446#1217488 (10Jdforrester-WMF) p:5Low>3Normal a:3Esanders [23:47:10] 10VisualEditor, 10MediaWiki-Special-pages: VE detecting ISBN magic word as invalid link - https://phabricator.wikimedia.org/T95992#1217492 (10Jdforrester-WMF) [23:47:12] 10VisualEditor, 10VisualEditor-DataModel, 10VisualEditor-MediaWiki-Links, 3Editing Department 2014/15 Q4 blockers: VisualEditor: ISBN link labels (from magic words) can be changed, but not the underlying links - https://phabricator.wikimedia.org/T63558#1217493 (10Jdforrester-WMF) [23:47:43] James_F, also https://phabricator.wikimedia.org/T95059#1217403 [23:48:13] (03PS1) 10Catrope: Work around 1c57794e3 in MW core mangling boolean properties [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/204970 (https://phabricator.wikimedia.org/T96443) [23:48:48] pretty sure all titles begin with uppercase in MW [23:49:15] Krenair: Not if you set that silly flag, e.g. on Wiktionaries. [23:49:17] Krenair: But yes. [23:50:20] oh it's configurable, right [23:50:41] I wonder whether we check that, but that's separate [23:51:00] Probably don't. :-( [23:51:11] mw.Title does that for you [23:52:33] (03CR) 10Legoktm: [C: 031] Work around 1c57794e3 in MW core mangling boolean properties [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/204970 (https://phabricator.wikimedia.org/T96443) (owner: 10Catrope) [23:56:18] 10TemplateData, 6Community-Liaison, 10WMF-Product-Strategy: Please make me a list of commonly used templates in Wikipedia articles - https://phabricator.wikimedia.org/T96323#1217533 (10Qgil) For what is worth: https://en.wikipedia.org/wiki/Wikipedia:TemplateData#Commonly_used_templates