[00:01:16] (03CR) 10Legoktm: [C: 032] Work around 1c57794e3 in MW core mangling boolean properties [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/204970 (https://phabricator.wikimedia.org/T96443) (owner: 10Catrope) [00:02:00] (03Merged) 10jenkins-bot: Work around 1c57794e3 in MW core mangling boolean properties [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/204970 (https://phabricator.wikimedia.org/T96443) (owner: 10Catrope) [00:05:37] (03PS1) 10Bartosz Dziewoński: ve.ui.SpecialCharacterDialog: Specify 'transition' only for 'border-color', not 'all' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204975 [00:06:01] 10VisualEditor, 10VisualEditor-MediaWiki: VE-MW special characters panel takes a while to open the first time, freezing the UI - https://phabricator.wikimedia.org/T96456#1217546 (10matmarex) There are two slow things here, each taking roughly half of the time in my profiling: * ve.ui.SpecialCharacterPage cons... [00:07:46] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-Performance: VE-MW special characters panel takes a while to open the first time, freezing the UI - https://phabricator.wikimedia.org/T96456#1217548 (10matmarex) [00:08:08] 10TemplateData, 6Community-Liaison, 10WMF-Product-Strategy: Please make me a list of commonly used templates in Wikipedia articles - https://phabricator.wikimedia.org/T96323#1217549 (10Ironholds) Yes; that was generated by me, an age ago, back when no joins were necessary because no templatedata existed (jus... [00:17:23] 10TemplateData, 10VisualEditor, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-22_(1.26wmf3): [Regression pre-wmf3] Citation dialogs are now not showing any parameters in it - https://phabricator.wikimedia.org/T96443#1217550 (10Jdforrester-WMF) 5Open>3Resolved a:5Mooeypoo>3Catrope [00:17:30] 10TemplateData, 10VisualEditor, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-22_(1.26wmf3): [Regression pre-wmf3] Citation dialogs are now not showing any parameters in it - https://phabricator.wikimedia.org/T96443#1217091 (10Jdforrester-WMF) [00:21:47] (03CR) 10Catrope: [C: 032] [BREAKING CHANGE] Simplify getModelFromDom signature [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204941 (owner: 10Esanders) [00:22:11] (03PS2) 10Catrope: [PULL-THROUGH] Use simplified getModelFromDom API [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/204943 (owner: 10Esanders) [00:23:17] (03PS1) 10Bartosz Dziewoński: ve.ui.SpecialCharacterPage: Use less jQuery for better performance [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204976 (https://phabricator.wikimedia.org/T96456) [00:24:15] (03Merged) 10jenkins-bot: [BREAKING CHANGE] Simplify getModelFromDom signature [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204941 (owner: 10Esanders) [00:25:13] (03CR) 10Catrope: [C: 032] ve.ui.SpecialCharacterPage: Use less jQuery for better performance [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204976 (https://phabricator.wikimedia.org/T96456) (owner: 10Bartosz Dziewoński) [00:28:29] (03CR) 10Catrope: "Wouldn't using UserLoadDefaults change the default value for *all* users with user_id mod 2 == 0, rather than just those that were created" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/204933 (owner: 10Jforrester) [00:29:14] (03CR) 10Catrope: Allow skin developers to set an offset for toolbar floating [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/203011 (https://phabricator.wikimedia.org/T95528) (owner: 10Florianschmidtwelzow) [00:29:57] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers: When the cursor is not active in the document, the toolbar is not activated, as nothing happens on tapping on the options, which is very confusing - https://phabricator.wikimedia.org/T86230#1217568 (10Mooeypoo) This is... [00:30:18] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers: When the cursor is not active in the document, the toolbar is not activated, as nothing happens on tapping on the options, which is very confusing - https://phabricator.wikimedia.org/T86230#1217569 (10Mooeypoo) a:3Mooe... [00:32:31] (03CR) 10Legoktm: "Make 'VisualEditorToolbarScrollOffset' an array?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/203011 (https://phabricator.wikimedia.org/T95528) (owner: 10Florianschmidtwelzow) [00:33:43] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 6Mobile-Web, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review: Rewrite VisualEditorOverlay header using oojs ui. - https://phabricator.wikimedia.org/T96187#1217572 (10Catrope) Why is this tagged Patch-For-Review? [00:41:48] RoanKattouw: using Node.textContent will be even faster [00:41:50] native text node creation [00:41:52] instead of new textnode/append operation [00:46:17] (03PS2) 10Mooeypoo: Rearrange images when the media search window resizes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/204568 (https://phabricator.wikimedia.org/T95017) [00:48:40] Krinkle: Context? [00:48:51] Krinkle: Oh, I see, MatmaRex's change [00:49:59] (03PS2) 10Krinkle: ve.ui.SpecialCharacterPage: Use less jQuery for better performance [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204976 (https://phabricator.wikimedia.org/T96456) (owner: 10Bartosz Dziewoński) [00:50:07] RoanKattouw: Oh, I thought it was your commit. [00:50:42] (03CR) 10Bartosz Dziewoński: [C: 031] ve.ui.SpecialCharacterPage: Use less jQuery for better performance [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204976 (https://phabricator.wikimedia.org/T96456) (owner: 10Bartosz Dziewoński) [00:50:50] thanks [00:50:57] (03PS3) 10Krinkle: ve.ui.SpecialCharacterPage: Use less jQuery for better performance [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204976 (https://phabricator.wikimedia.org/T96456) (owner: 10Bartosz Dziewoński) [00:51:03] Moving it next to each other the two assignments :) [00:51:12] Otherwise I'd dishonour your name by mixing it like that [00:51:14] You wouldn't do that [00:51:33] (03CR) 10Krinkle: [C: 031] ve.ui.SpecialCharacterPage: Use less jQuery for better performance [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204976 (https://phabricator.wikimedia.org/T96456) (owner: 10Bartosz Dziewoński) [00:51:50] (03PS4) 10Bartosz Dziewoński: ve.ui.SpecialCharacterPage: Use less jQuery for better performance [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204976 (https://phabricator.wikimedia.org/T96456) [00:52:04] (03CR) 10Bartosz Dziewoński: "(Removed accidental dependency.)" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204976 (https://phabricator.wikimedia.org/T96456) (owner: 10Bartosz Dziewoński) [00:52:19] (03CR) 10Krinkle: [C: 032] ve.ui.SpecialCharacterPage: Use less jQuery for better performance [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204976 (https://phabricator.wikimedia.org/T96456) (owner: 10Bartosz Dziewoński) [00:54:15] (03CR) 10Krinkle: [C: 032] ve.ui.SpecialCharacterDialog: Specify 'transition' only for 'border-color', not 'all' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204975 (owner: 10Bartosz Dziewoński) [00:54:33] http://jsperf.com/textcontent-vs-createtextelement/54 [00:55:31] (03Merged) 10jenkins-bot: ve.ui.SpecialCharacterPage: Use less jQuery for better performance [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204976 (https://phabricator.wikimedia.org/T96456) (owner: 10Bartosz Dziewoński) [00:56:05] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: Citoid mobile opens with the right half of its screen blank - https://phabricator.wikimedia.org/T96313#1217586 (10Mooeypoo) [00:56:07] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers: In iOS Safari, all dialogs in mobile VE opening halfway or as empty on the first attempt of every edit session - https://phabricator.wikimedia.org/T86233#1217588 (10Mooeypoo) [00:56:32] (03Merged) 10jenkins-bot: ve.ui.SpecialCharacterDialog: Specify 'transition' only for 'border-color', not 'all' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204975 (owner: 10Bartosz Dziewoński) [01:37:54] 10OOjs-UI, 10UI-Standardization, 7Design: ButtonGroupWidget use cases - https://phabricator.wikimedia.org/T88637#1217656 (10matmarex) I assume this task was inspired by our demo page. > 1. I don't think we need colored labels here, but let me know if you have a use case. Indeed, we probably don't. The widg... [01:46:12] (03PS1) 10Bartosz Dziewoński: demo: Simplify ButtonGroupWidget and ButtonSelectWidget examples [oojs/ui] - 10https://gerrit.wikimedia.org/r/204981 (https://phabricator.wikimedia.org/T88637) [01:51:26] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-Performance, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-22_(1.26wmf3): VE-MW special characters panel takes a while to open the first time, freezing the UI - https://phabricator.wikimedia.org/T96456#1217669 (10Jdforrester-WMF) 5O... [01:51:35] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-Performance, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-22_(1.26wmf3): VE-MW special characters panel takes a while to open the first time, freezing the UI - https://phabricator.wikimedia.org/T96456#1217378 (10Jdforrester-WMF) a:... [02:15:05] (03PS1) 10Divec: WIP POC: walkDom function for document-order traversal [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204985 [02:19:18] (03CR) 10Divec: "I don't think the overhead of 1 or 2 function calls per node is actually all that onerous in many cases." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204985 (owner: 10Divec) [02:38:37] (03PS2) 10Divec: WIP POC: walkDom function for document-order traversal [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204985 [03:03:09] (03CR) 10Divec: [C: 04-1] WIP POC: walkDom function for document-order traversal (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204985 (owner: 10Divec) [12:28:36] (03CR) 10Bartosz Dziewoński: "To be honest I don't like this much. A much simpler convention would be that all *Element classes are mixins, and all *Widget classes are " [oojs/ui] - 10https://gerrit.wikimedia.org/r/200195 (owner: 10Cscott) [14:29:38] (03PS1) 10Bartosz Dziewoński: Fold GroupWidget and ItemWidget into default functionality [oojs/ui] - 10https://gerrit.wikimedia.org/r/205006 (https://phabricator.wikimedia.org/T91565) [14:31:30] (03PS1) 10Esanders: Add device switcher to demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205007 [14:32:52] (03CR) 10jenkins-bot: [V: 04-1] Fold GroupWidget and ItemWidget into default functionality [oojs/ui] - 10https://gerrit.wikimedia.org/r/205006 (https://phabricator.wikimedia.org/T91565) (owner: 10Bartosz Dziewoński) [17:38:29] (03PS1) 10Esanders: Fix demo pages hash loader [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205011 [17:50:36] (03PS1) 10Esanders: Fix placement of linear selection inside a table [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205012 (https://phabricator.wikimedia.org/T96446) [18:28:47] edsanders: Remember the +0,-0 trick from last year? [18:29:02] Looks like they're finally exposing strict equality in the public api in ES6 [18:29:13] Without the workaround we came up with [18:29:18] Object.is() [18:29:23] Object.is(0, -0); // => false [18:30:20] Previously the only way to expose that logic is to create a read-only property in strict mode and detect whether an exception is thrown when assigning the value (indicating the value is not "same") [20:25:56] 10VisualEditor: In VisualEditor, footnote immediately following a period sometimes wraps to new line even though there is space left in the line - https://phabricator.wikimedia.org/T96487#1218166 (10pajz) 3NEW [21:20:40] 10VisualEditor: The Visual Editor always displays "One note" at startup - https://phabricator.wikimedia.org/T96480#1218198 (10matmarex) [21:20:41] 10VisualEditor: Editnotices with hidden content shows as "1 notice" - https://phabricator.wikimedia.org/T95822#1218199 (10matmarex) [21:22:29] 10VisualEditor, 10VisualEditor-MediaWiki: Editnotices with hidden content shows as "1 notice" - https://phabricator.wikimedia.org/T95822#1201307 (10matmarex) [21:33:22] 10VisualEditor, 10VisualEditor-MediaWiki: Editnotices with hidden content shows as "1 notice" - https://phabricator.wikimedia.org/T95822#1218210 (10matmarex) pl.wp and it.wp seem to be using the same system as en.wp had previously; de.wp has something similar, but slightly different. en.wp's implementation was... [21:53:01] Krinkle|detached, handy [23:59:00] (03CR) 10GOIII: "Just curious: what is the point of retaining the instances using 'white', 'black', 'silver' and similar full-names of colors?" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/190175 (owner: 10Gerrit Patch Uploader)