[00:00:01] <grrrit-wm>	 (03CR) 10Catrope: "This is for a different bug. The bug this fixes is that if you go to /w/index.php?action=edit&editingStatsId=123, the value from the query" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/205188 (owner: 10Catrope)
[00:02:03] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Update VE core submodule to master (952a9bb) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/204943 (owner: 10Esanders)
[00:02:11] <grrrit-wm>	 (03CR) 10Alex Monk: "Well then we're going to run into issues with ShowEditFormInitial I think" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/205188 (owner: 10Catrope)
[00:02:55] <grrrit-wm>	 (03PS1) 10Catrope: Add dependency on mw.user [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/205191 
[00:03:23] <grrrit-wm>	 (03PS2) 10Jforrester: demo: Create RTL version of minimal demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204942 (owner: 10Esanders)
[00:03:31] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] demo: Create RTL version of minimal demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204942 (owner: 10Esanders)
[00:03:46] <RoanKattouw>	 Krenair: What issues would we run into?
[00:04:44] <RoanKattouw>	 OK I can reproduce the statsId stickiness in Chrome
[00:04:54] <RoanKattouw>	 Now that I have "Disable cache" turned off
[00:05:07] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Fix placement of linear selection inside a table [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205012 (https://phabricator.wikimedia.org/T96446) (owner: 10Esanders)
[00:05:17] <Krenair>	 umm
[00:05:20] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (952a9bb) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/204943 (owner: 10Esanders)
[00:05:23] <Krenair>	 Actually I was wrong.
[00:05:27] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-Tables, 7Browser-Support-Firefox, and 2 others: Cannot click into a particular table cell on Firefox - https://phabricator.wikimedia.org/T96446#1219206 (10Jdforrester-WMF) 5Open>3Resolved
[00:05:37] <RoanKattouw>	 Oh FFS
[00:05:37] <Krenair>	 I think I've changed how getEditingStatsId works since the version I have in my head
[00:05:47] <grrrit-wm>	 (03CR) 10Alex Monk: [C: 032] Only trust POSTed stats IDs [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/205188 (owner: 10Catrope)
[00:05:54] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Update VE core submodule to master (952a9bb) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/204943 (owner: 10Esanders)
[00:05:57] <RoanKattouw>	 Why does mw.user.generateSessionId() return a string of length 16 while the server-side equivalent returns a string of length 32?
[00:05:59] <RoanKattouw>	 WTF
[00:06:04] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-Tables, 7Browser-Support-Firefox, and 2 others: Cannot click into a particular table cell on Firefox - https://phabricator.wikimedia.org/T96446#1217186 (10Jdforrester-WMF)
[00:06:08] <Krenair>	 I seem to recall hearing about that before
[00:06:09] <RoanKattouw>	 generateSessionId is also used for VE sessions, right?
[00:06:57] <Krenair>	 mw.user.generateRandomSessionId
[00:07:01] <Krenair>	 yes
[00:07:07] <grrrit-wm>	 (03CR) 10Jforrester: "Could we have a test for this?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205089 (https://phabricator.wikimedia.org/T96088) (owner: 10Esanders)
[00:07:30] <RoanKattouw>	 So VE sessions have 16-char IDs while WE sessions have 32-char IDs?
[00:07:40] * RoanKattouw looks at database to check
[00:08:08] <Krenair>	 The schema, which was set up for VE, says 32-char
[00:08:13] <Krenair>	 :)
[00:09:34] <grrrit-wm>	 (03Merged) 10jenkins-bot: demo: Create RTL version of minimal demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204942 (owner: 10Esanders)
[00:09:36] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix placement of linear selection inside a table [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205012 (https://phabricator.wikimedia.org/T96446) (owner: 10Esanders)
[00:09:38] <grrrit-wm>	 (03Merged) 10jenkins-bot: Only trust POSTed stats IDs [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/205188 (owner: 10Catrope)
[00:09:41] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update VE core submodule to master (952a9bb) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/204943 (owner: 10Esanders)
[00:11:14] <RoanKattouw>	 ]> select length(event_editingSessionId) as length, event_editor, count(*) from Edit_11448630 WHERE timestamp BETWEEN "20150419160000" AND "20150419170000" GROUP BY event_editor, length;
[00:11:20] <RoanKattouw>	 |     16 | visualeditor |    13189 |
[00:11:23] <RoanKattouw>	 |     32 | wikitext     |   105149 |
[00:11:32] <RoanKattouw>	 No other results
[00:11:38] <RoanKattouw>	 Cool story
[00:12:18] <RoanKattouw>	 So, I'll un-WIP my patch because I've now tested it and it works for me
[00:12:36] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 10Wikimedia-Site-requests: Kill $wmgUseVisualEditorNamespace - https://phabricator.wikimedia.org/T92797#1219212 (10Krenair) a:3MZMcBride
[00:12:41] <RoanKattouw>	 But it does mean that wikitext session IDs will randomly be length 16 sometimes (when they've been regenerated by a pageshow handler) rather than 32
[00:16:49] <grrrit-wm>	 (03PS2) 10Catrope: Regenerate editingStatsId on pageshow [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/205189 
[00:17:41] <grrrit-wm>	 (03PS3) 10Catrope: Fix find and replace viewport search [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205089 (https://phabricator.wikimedia.org/T96088) (owner: 10Esanders)
[00:18:49] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] Fix find and replace viewport search (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205089 (https://phabricator.wikimedia.org/T96088) (owner: 10Esanders)
[00:21:02] <grrrit-wm>	 (03PS2) 10Catrope: Add dependency on mw.user [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/205191 
[00:21:10] <RoanKattouw>	 Oops, crap
[00:22:19] <grrrit-wm>	 (03PS3) 10Catrope: Regenerate editingStatsId on pageshow [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/205189 
[00:22:28] <grrrit-wm>	 (03PS3) 10Catrope: Add dependency on mw.user [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/205191 
[00:27:10] <RoanKattouw>	 Krenair: ---^^
[00:28:46] <grrrit-wm>	 (03CR) 10Alex Monk: [C: 032] Add dependency on mw.user [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/205191 (owner: 10Catrope)
[00:29:41] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add dependency on mw.user [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/205191 (owner: 10Catrope)
[00:29:56] <Krenair>	 RoanKattouw, so... on every page, regenerate the ID?
[00:30:20] <RoanKattouw>	 Well, pageshow only fires when bfcache is used
[00:30:26] <RoanKattouw>	 Technically it also fires on first load I think
[00:30:39] <Krenair>	 ah, ok
[00:30:43] <RoanKattouw>	 But that appears to happen before we attach to it
[00:31:23] <RoanKattouw>	 Also https://gerrit.wikimedia.org/r/205194 fixes the issue of revid being 0 for all client-side events, but I'm not too sure that I did the right thing there
[00:32:03] <Krenair>	 MDN: "The pageshow event is fired when a session history entry is being traversed to. (This includes back/forward as well as initial page-showing after the onload event.)"
[00:32:52] <RoanKattouw>	 Yeah
[00:35:30] <Krenair>	 that makes it sound like this fires on every page?
[00:35:36] <Krenair>	 not just back/forward?
[00:37:13] <RoanKattouw>	 It does
[00:37:20] <RoanKattouw>	 [17:30]	RoanKattouw	Technically it also fires on first load I think
[00:37:23] <RoanKattouw>	 [17:30]	RoanKattouw	But that appears to happen before we attach to it
[00:52:48] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-22_(1.26wmf3): "Bitdefender Total Security 2015" inserts <script> tags into contentEditable surfaces - https://phabricator.wikimedia.org/T96533#1219240 (10Jdforrester-WMF...
[00:53:24] <wikibugs>	 10Citoid, 3Editing Department 2014/15 Q4 blockers: Ensure DOI, PMID, and PMCID are in the resultant citation when they're the requested format - https://phabricator.wikimedia.org/T95434#1219246 (10Jdforrester-WMF)
[00:53:35] <wikibugs>	 10Citoid, 10VisualEditor: Improper use of doi - https://phabricator.wikimedia.org/T95984#1219248 (10Jdforrester-WMF)
[01:15:31] <grrrit-wm>	 (03PS1) 10Catrope: Populate abort.type in Schema:Edit logging [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/205195 (https://phabricator.wikimedia.org/T95938) 
[01:16:35] <Krenair>	 RoanKattouw, oh, I was planning to look at that task this week
[01:16:53] <Krenair>	 RoanKattouw, this will break when the user presses preview/show changes
[01:17:04] <RoanKattouw>	 How?
[01:17:25] <RoanKattouw>	 Oh, crap, right
[01:17:40] <Krenair>	 unless they're using JS live preview, they'll get a new edit form with the text they put in before
[01:17:43] <RoanKattouw>	 Yeah
[01:17:48] <Krenair>	 not the saved version
[01:18:04] <RoanKattouw>	 I have to do what editWarning does
[01:18:06] <Krenair>	 I think you'll just have to hash it on the server and compare on abort
[01:18:11] <RoanKattouw>	 If wgAction === 'submit', assume it was changed
[01:18:20] <RoanKattouw>	 Hmm or do that
[01:18:31] <Krenair>	 that's a bad assumption
[01:18:31] <RoanKattouw>	 The problem is that browsers don't expose hash functions in JS
[01:18:35] <Krenair>	 urgh.
[01:18:35] <RoanKattouw>	 And it's 2015 :(
[01:18:53] <RoanKattouw>	 I mean, I'm not demanding my flying car, just the ability to run md5 (or sha1) from JS
[01:23:17] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Don't use OOUI icon packs, add 'link' icon [extensions/VisualEditor] (REL1_25) - 10https://gerrit.wikimedia.org/r/204931 (https://phabricator.wikimedia.org/T96273) (owner: 10Bartosz Dziewoński)
[01:24:50] <grrrit-wm>	 (03Merged) 10jenkins-bot: Don't use OOUI icon packs, add 'link' icon [extensions/VisualEditor] (REL1_25) - 10https://gerrit.wikimedia.org/r/204931 (https://phabricator.wikimedia.org/T96273) (owner: 10Bartosz Dziewoński)
[01:38:45] <grrrit-wm>	 (03PS4) 10Jforrester: Regenerate editingStatsId on pageshow [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/205189 (https://phabricator.wikimedia.org/T95919) (owner: 10Catrope)
[01:41:30] <James_F>	 RoanKattouw: https://gerrit.wikimedia.org/r/#/q/status:merged+project:mediawiki/core+(owner:Catrope+OR+owner:Divec+OR+owner:Krinkle+OR+owner:tparscal%2540wikimedia.org+OR+owner:Esanders+OR+owner:Mooeypoo+OR+owner:Krenair+OR+owner:matmarex+OR+owner:Jforrester)+-age:2w,n,z
[01:44:06] <Krenair>	 all merged MW core commits owned by one of us which is older than 2w?
[01:44:59] <James_F>	 Krenair: Which is not older than two weeks.
[01:45:09] <James_F>	 Krenair: Part of https://gerrit.wikimedia.org/r/#/projects/mediawiki/extensions/VisualEditor,dashboards/merged:merged
[01:45:20] <James_F>	 Krenair: But mostly I was lamenting how much we've been doing cherry-picks.
[01:45:52] <James_F>	 Krenair: If you're going to look at gerrit queries, https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/extensions/WikiEditor+owner:%22Catrope+%253Croan.kattouw%2540gmail.com%253E%22,n,z ;-)
[01:49:48] <Krenair>	 :)
[01:50:22] <Krenair>	 Unless you want these for morning swat, I think I'm going to do that later
[01:51:35] <wikibugs>	 10VisualEditor: "Re-use" does not allow changes specific to the new use (like correct page numbers, quotes) - https://phabricator.wikimedia.org/T96536#1219298 (10LuisVilla) 3NEW
[02:02:27] <James_F>	 Krenair: Morning SWAT would be amazing, but quality > speed.
[02:03:47] <wikibugs>	 10VisualEditor: templatedata editor may insert spurious whitespace that impacts template rendering? - https://phabricator.wikimedia.org/T96537#1219305 (10LuisVilla) 3NEW
[02:30:18] <wikibugs>	 10VisualEditor, 6Collaboration-Team, 10Flow, 5Patch-For-Review: Click outside to close doesn't always work as intended for mention inspector - https://phabricator.wikimedia.org/T94109#1219312 (10Quiddity)
[03:03:25] <wikibugs>	 10VisualEditor, 6Editing: Obviate the need for wikis' wrapper and functionality-replacement templates - https://phabricator.wikimedia.org/T95543#1219339 (10MZMcBride) Even with the list of "blocked by" tasks here, it's still difficult to discern exactly what type of templates we're discussing here. Which templ...
[03:03:45] <wikibugs>	 10Cite, 10Wikimedia-Hackathon-2015: Render references list in multiple columns based on the number of items - https://phabricator.wikimedia.org/T33597#1219340 (10MZMcBride) >>! In T33597#798688, @Krinkle wrote: > I've been eyeballing this for over a year now and think I've got a good idea of how to implement i...
[03:13:38] <wikibugs>	 10WikiEditor, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review: action.abort.type in Schema:Edit not populated for Wikitext - https://phabricator.wikimedia.org/T95938#1219353 (10Krenair) a:3Catrope
[03:14:07] <grrrit-wm>	 (03CR) 10Alex Monk: [C: 04-1] "Per chat, this will break when the user uses show preview/changes" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/205195 (https://phabricator.wikimedia.org/T95938) (owner: 10Catrope)
[03:16:56] <Krenair>	 James_F, tuesday's meeting was cancelled?
[03:17:13] <James_F>	 Krenair: The HOLD replaced by the since-created all-staff one.
[03:17:17] <Krenair>	 ah.
[03:17:44] <James_F>	 No need to have both cluttering up people's diaries.
[03:20:02] <wikibugs>	 10VisualEditor: "Re-use" does not allow changes specific to the new use (like correct page numbers, quotes) - https://phabricator.wikimedia.org/T96536#1219357 (10MZMcBride) I suppose this is related to {T15127}.
[03:25:52] <wikibugs>	 10Cite: Allow hiding of Cite.php references - https://phabricator.wikimedia.org/T10033#1219362 (10MZMcBride) I wonder if we implemented {T20231}, what impact that would have on this task.  I'm thinking about alternate ways in which we could present reference markers besides superscript [1][2][3] etc. One alterna...
[03:32:46] <wikibugs>	 10Cite: Cite: If there's no <references /> block on the page, insert the wikitext for one automatically in the right place - https://phabricator.wikimedia.org/T32763#1219367 (10MZMcBride) I'm sympathetic to the task description's problem statement as I also find manually adding `<references />` to be tedious. Ho...
[03:37:33] <wikibugs>	 10Cite: Cite: Provide a way for users to find articles which have the reference list inserted automatically - https://phabricator.wikimedia.org/T69700#1219373 (10MZMcBride) Yeah... this is a bit bizarre. I'd like to better understand why <https://gerrit.wikimedia.org/r/149091> was necessary.  In the past, I've u...
[03:40:57] <grrrit-wm>	 (03PS3) 10Divec: WIP POC: walkDom function for document-order traversal [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204985 
[03:42:15] <grrrit-wm>	 (03CR) 10Divec: "Is the use of jquery selectors helpful?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204985 (owner: 10Divec)
[03:49:35] <wikibugs>	 10Cite: Cite: Provide a way for users to find articles which have the reference list inserted automatically - https://phabricator.wikimedia.org/T69700#1219383 (10MZMcBride) I looked at <https://gerrit.wikimedia.org/r/145474> briefly. I'm not sure why the tracking category logic was added in the context of groupe...
[06:47:46] <Juandev>	 hi
[06:48:13] <Juandev>	 which bug is about the possibility to move dialog boxes over canvas?
[07:27:21] <grrrit-wm>	 (03PS4) 10Divec: WIP: walkDomTree function for document-order traversal [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204985 
[07:29:58] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] WIP: walkDomTree function for document-order traversal [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204985 (owner: 10Divec)
[08:43:42] <grrrit-wm>	 (03PS5) 10Divec: WIP: walkDomTree function for document-order traversal [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204985 
[09:33:06] <wikibugs>	 10MediaWiki-ResourceLoader, 10WikiEditor: Request amendment of Bangla character set in WikiEditor - https://phabricator.wikimedia.org/T96494#1220227 (10Aklapper)
[09:35:37] <wikibugs>	 10Cite: Cite: If there's no <references /> block on the page, insert the wikitext for one automatically in the right place - https://phabricator.wikimedia.org/T32763#1220228 (10thiemowmde) Is this a VisualEditor ticket? I agree that VisualEditor should enforce a `<references />` tag. But "magically" changing the...
[09:40:05] <wikibugs>	 10VisualEditor, 10VisualEditor-CopyPaste, 7Browser-Support-Apple-Safari, 3Editing Department 2014/15 Q4 blockers, and 2 others: Insufficient span tags stripping from copy-and-paste in Safari - https://phabricator.wikimedia.org/T71494#1220236 (10NicoV) Please, do something about this, this is really annoyin...
[09:40:22] <wikibugs>	 10VisualEditor, 10VisualEditor-CopyPaste, 7Browser-Support-Apple-Safari, 3Editing Department 2014/15 Q4 blockers, and 2 others: Insufficient span tags stripping from copy-and-paste in Safari - https://phabricator.wikimedia.org/T71494#1220237 (10NicoV) p:5High>3Unbreak!
[09:44:36] <wikibugs>	 10MediaWiki-ResourceLoader, 10VisualEditor, 10VisualEditor-MediaWiki, 10WikiEditor, and 2 others: Import WikiEditor's list into the Special Character inserter - https://phabricator.wikimedia.org/T91608#1220243 (10Aklapper) >>! In T91608#1218308, @Hrishikes wrote: > The Bangla character set is incomplete....
[10:55:48] <wikibugs>	 10VisualEditor, 10VisualEditor-CopyPaste, 7Browser-Support-Apple-Safari, 3Editing Department 2014/15 Q4 blockers, and 2 others: Insufficient span tags stripping from copy-and-paste in Safari - https://phabricator.wikimedia.org/T71494#1220374 (10Aklapper) p:5Unbreak!>3High Restoring previous priority "h...
[11:06:22] <wikibugs>	 10VisualEditor, 10VisualEditor-CopyPaste, 7Browser-Support-Apple-Safari, 3Editing Department 2014/15 Q4 blockers, and 2 others: Insufficient span tags stripping from copy-and-paste in Safari - https://phabricator.wikimedia.org/T71494#1220379 (10NicoV) Examples of this not working have been posted both here...
[11:08:20] <grrrit-wm>	 (03CR) 10Esanders: Fix find and replace viewport search (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205089 (https://phabricator.wikimedia.org/T96088) (owner: 10Esanders)
[11:09:58] <grrrit-wm>	 (03PS4) 10Esanders: Fix find and replace viewport search [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205089 (https://phabricator.wikimedia.org/T96088) 
[11:11:13] <grrrit-wm>	 (03CR) 10Esanders: "Re:test, it's based on viewport size etc. so would need a well controlled browser test, which we don't have." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205089 (https://phabricator.wikimedia.org/T96088) (owner: 10Esanders)
[11:31:06] <wikibugs>	 10VisualEditor, 6Collaboration-Team, 10Flow, 5Patch-For-Review: Click outside to close doesn't always work as intended for mention inspector - https://phabricator.wikimedia.org/T94109#1220396 (10Esanders) Inspectors don't close if the model selection (i.e. cursor position) is unchanged. This will require s...
[11:31:21] <wikibugs>	 10VisualEditor, 6Collaboration-Team, 10Flow: Click outside to close doesn't always work as intended for mention inspector - https://phabricator.wikimedia.org/T94109#1220397 (10Esanders)
[11:39:03] <grrrit-wm>	 (03CR) 10Esanders: "Yes, but even in your example the user has to calculate the $giveFocus target." [oojs/ui] - 10https://gerrit.wikimedia.org/r/201680 (https://phabricator.wikimedia.org/T87714) (owner: 10Prtksxna)
[11:40:34] <grrrit-wm>	 (03CR) 10Esanders: "As there's no simple answer to where the focus should return to, I don't think we can call this a basic usability feature." [oojs/ui] - 10https://gerrit.wikimedia.org/r/201680 (https://phabricator.wikimedia.org/T87714) (owner: 10Prtksxna)
[11:43:29] <grrrit-wm>	 (03CR) 10Esanders: [C: 031] [BREAKING CHANGE] MenuLayout: Reimplement without inline styles (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/198565 (owner: 10Bartosz Dziewoński)
[11:44:14] <grrrit-wm>	 (03CR) 10Esanders: [C: 032] MenuLayout: Fix initialization order [oojs/ui] - 10https://gerrit.wikimedia.org/r/204125 (owner: 10Bartosz Dziewoński)
[11:49:52] <grrrit-wm>	 (03Merged) 10jenkins-bot: MenuLayout: Fix initialization order [oojs/ui] - 10https://gerrit.wikimedia.org/r/204125 (owner: 10Bartosz Dziewoński)
[11:50:27] <grrrit-wm>	 (03CR) 10Esanders: "Why is ve different to read mode? Where are the styles set for read mode? Is this just an MW issue?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205177 (https://phabricator.wikimedia.org/T56381) (owner: 10Bartosz Dziewoński)
[11:54:40] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 5Patch-For-Review: VisualEditor: Long lines in preformatted paragraphs should not wrap in VE - https://phabricator.wikimedia.org/T56381#1220410 (10Esanders)
[12:04:54] <grrrit-wm>	 (03CR) 10Esanders: "Ah, I see it only works because of ce=true. *sigh* ok." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205177 (https://phabricator.wikimedia.org/T56381) (owner: 10Bartosz Dziewoński)
[12:14:01] <wikibugs>	 10VisualEditor, 10VisualEditor-DataModel: Empty annotations cannot be deleted - https://phabricator.wikimedia.org/T96528#1220432 (10Esanders) What are the real world examples where these annotations come up?  Could we flag some meta items as 'deletable' for the transaction builder?
[13:52:59] <wikibugs>	 10VisualEditor, 10Browser-Tests, 6Release-Engineering: Selenium bug with Firefox causes VE test failure - https://phabricator.wikimedia.org/T90651#1220534 (10zeljkofilipin) {icon thumbs-up}
[14:08:26] <grrrit-wm>	 (03CR) 10Anomie: Work around 1c57794e3 in MW core mangling boolean properties (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/204970 (https://phabricator.wikimedia.org/T96443) (owner: 10Catrope)
[14:23:26] <wikibugs>	 10VisualEditor, 10VisualEditor-DataModel, 3Editing Department 2014/15 Q4 blockers: Empty annotations cannot be deleted - https://phabricator.wikimedia.org/T96528#1220620 (10Jdforrester-WMF) >>! In T96528#1220432, @Esanders wrote: > What are the real world examples where these annotations come up?  https://of...
[14:23:31] <wikibugs>	 10VisualEditor, 10VisualEditor-DataModel, 3Editing Department 2014/15 Q4 blockers: Empty annotations cannot be deleted - https://phabricator.wikimedia.org/T96528#1220621 (10Jdforrester-WMF) p:5Triage>3Normal
[15:48:09] <grrrit-wm>	 (03PS1) 10Ricordisamoa: Add 'license-name' matching SPDX conventions [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/205270 
[15:48:10] <grrrit-wm>	 (03PS1) 10Ricordisamoa: Add 'license-name' matching SPDX conventions [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/205270 
[15:53:09] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Add 'license-name' matching SPDX conventions [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/205270 (owner: 10Ricordisamoa)
[15:53:10] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Add 'license-name' matching SPDX conventions [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/205270 (owner: 10Ricordisamoa)
[15:53:14] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add 'license-name' matching SPDX conventions [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/205270 (owner: 10Ricordisamoa)
[15:53:15] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add 'license-name' matching SPDX conventions [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/205270 (owner: 10Ricordisamoa)
[15:53:44] <wikibugs>	 10VisualEditor, 6Community-Liaison, 10WMF-Product-Strategy, 3Editing Department 2014/15 Q4 blockers: How many active editors are using VisualEditor at large Wikipedias? - https://phabricator.wikimedia.org/T94637#1220815 (10Ironholds) Given "____" above you probably need to be more precise in your request....
[15:56:10] <grrrit-wm>	 (03PS3) 10Jforrester: Move setDocument call from ve.dm.Document up to ve.Document [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/203475 (owner: 10Catrope)
[15:56:20] <grrrit-wm>	 (03CR) 10Jforrester: [C: 04-1] "Still needs a test." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/203475 (owner: 10Catrope)
[16:25:20] <wikibugs>	 10VisualEditor, 6Community-Liaison, 10WMF-Product-Strategy, 3Editing Department 2014/15 Q4 blockers: How many active editors are using VisualEditor at large Wikipedias? - https://phabricator.wikimedia.org/T94637#1220942 (10Whatamidoing-WMF) Oliver, my research question is "How many registered editors at th...
[16:28:37] <wikibugs>	 10VisualEditor, 6Community-Liaison, 10WMF-Product-Strategy, 3Editing Department 2014/15 Q4 blockers: How many active editors are using VisualEditor at large Wikipedias? - https://phabricator.wikimedia.org/T94637#1220957 (10Ironholds) Okay, then let's say: distinct usernames on each project with a VisualEdi...
[16:42:06] <grrrit-wm>	 (03PS1) 10Esanders: Add removable flag to meta items [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205291 (https://phabricator.wikimedia.org/T96528) 
[16:44:37] <grrrit-wm>	 (03CR) 10Esanders: "@Roan: MetaList#onTransact test needs updating, but it looks far too magical for me to touch." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205291 (https://phabricator.wikimedia.org/T96528) (owner: 10Esanders)
[16:44:40] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add removable flag to meta items [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205291 (https://phabricator.wikimedia.org/T96528) (owner: 10Esanders)
[16:45:33] <grrrit-wm>	 (03CR) 10Esanders: "(only fails because ve.dm.example.withMeta was changed slightly)" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205291 (https://phabricator.wikimedia.org/T96528) (owner: 10Esanders)
[16:45:47] <grrrit-wm>	 (03CR) 10Krinkle: [C: 032] demo: Fix demo pages hash loader [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205011 (owner: 10Esanders)
[16:48:19] <wikibugs>	 10VisualEditor: VisualEditor: do not remove line break before first category when a user deletes {{DEFAULTSORT}} - https://phabricator.wikimedia.org/T58530#1221041 (10Neil_P._Quinn_WMF) This issue [[https://pt.wikipedia.org/w/index.php?title=Usu%C3%A1rio%28a%29%3ANeil_P._Quinn-WMF%2FTestcase%2FT58530&diff=419591...
[16:48:41] <grrrit-wm>	 (03Merged) 10jenkins-bot: demo: Fix demo pages hash loader [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205011 (owner: 10Esanders)
[16:56:43] <wikibugs>	 10VisualEditor: VisualEditor: do not remove line break before first category when a user deletes {{DEFAULTSORT}} - https://phabricator.wikimedia.org/T58530#1221060 (10Neil_P._Quinn_WMF) 5stalled>3Open p:5Triage>3Lowest
[17:11:56] <grrrit-wm>	 (03CR) 10Mooeypoo: "The underlying parent (SelectWidget) can get away with a more accurate select naming, but the two top widgets should go with set/getValue " [oojs/ui] - 10https://gerrit.wikimedia.org/r/204414 (https://phabricator.wikimedia.org/T87602) (owner: 10Mooeypoo)
[17:19:43] <nischayn22>	 Hi guys, I am trying to make a plugin for VE to support semantic annotations. Need help understanding if this will need changes in Parsoid?
[17:20:25] <nischayn22>	 By semantic annotations I mean SMW annotations which are usually of the type [[Property::Value]]
[17:20:39] <Krenair>	 hi nischayn22
[17:20:53] <nischayn22>	 hi Krenair 
[17:21:09] <nischayn22>	 How are you?
[17:21:13] <Krenair>	 I believe that would need parsoid changes yes
[17:21:39] <nischayn22>	 Ah, that's what I feared :/
[17:22:36] <nischayn22>	 Does parsoid have support for MW style hooks to add more features to wikitext?
[17:22:44] <Krenair>	 Great, thanks. I don't remember when we last spoke but I'm on the Editing team now. :)
[17:23:25] <nischayn22>	 That's great. I just looked at some VE code and it looks like a lot of good work has gone in :)
[17:24:43] <Krenair>	 I think it has some sort of extensions system.
[17:25:41] <Krenair>	 For example there is lib/ext.Cite.js
[17:25:57] <nischayn22>	 Okay, that's good.
[17:27:14] <nischayn22>	 Krenair: My understanding of VE is that its a tool to make HTML which is then sent to parsoid asking for wikitext. This wikitext is then saved as the page's source. Can you please confirm if that's correct?
[17:28:02] <Krenair>	 That's the idea. It's much more complicated in practice.
[17:29:06] <nischayn22>	 Can understand that, there's parser functions, templates and many more things.
[17:37:33] <wikibugs>	 10VisualEditor, 7Browser-Support-Firefox: VisualEditor:  Cursor misplaced while editing.  I click here, and it types over there. - https://phabricator.wikimedia.org/T60493#1221198 (10Neil_P._Quinn_WMF) Seems to [[https://en.wikipedia.org/w/index.php?title=User%3ANeil_P._Quinn-WMF%2FTestcase%2FT60493&diff=65735...
[17:37:51] <wikibugs>	 10VisualEditor, 7Browser-Support-Firefox: VisualEditor:  Cursor misplaced while editing.  I click here, and it types over there. - https://phabricator.wikimedia.org/T60493#1221199 (10Neil_P._Quinn_WMF) 5stalled>3Resolved
[17:44:07] <grrrit-wm>	 (03PS4) 10Mooeypoo: [wip] Keep the parameter list expanded after it was expanded once [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/203965 (https://phabricator.wikimedia.org/T95696) 
[17:50:56] <wikibugs>	 10VisualEditor, 6Collaboration-Team, 10Flow: Don't use a * selector to set box-sizing in Flow - https://phabricator.wikimedia.org/T96513#1221269 (10EBernhardson) p:5Triage>3Normal we have workarounds for ve in the target css, needs more thought into what the best solution is.
[17:54:38] <wikibugs>	 10VisualEditor, 6Collaboration-Team, 10Flow: Don't use a * selector to set box-sizing in Flow - https://phabricator.wikimedia.org/T96513#1221304 (10Esanders) >>! In T96513#1221269, @EBernhardson wrote: > we have workarounds for ve in the target css, needs more thought into what the best solution is.  I menti...
[17:55:23] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: MenuLayout: Remove some redundant code [oojs/ui] - 10https://gerrit.wikimedia.org/r/205298 
[17:55:34] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "Hmm, I seem to have accidentally reverted some changes made between PS1 and PS2 in PS3. Followup: https://gerrit.wikimedia.org/r/205298" [oojs/ui] - 10https://gerrit.wikimedia.org/r/204125 (owner: 10Bartosz Dziewoński)
[17:57:18] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "I dunno, but right now this doesn't work. :)" [oojs/ui] - 10https://gerrit.wikimedia.org/r/204414 (https://phabricator.wikimedia.org/T87602) (owner: 10Mooeypoo)
[17:57:21] <wikibugs>	 10VisualEditor, 10VisualEditor-EditingTools, 6Collaboration-Team, 6Mobile-Web, 7JavaScript: Add user settings frontend JavaScript API - https://phabricator.wikimedia.org/T96155#1221347 (10EBernhardson) p:5Triage>3Normal
[18:13:27] <wikibugs>	 10VisualEditor: VisualEditor: Reference dialog retains style of copy/pasted contents - https://phabricator.wikimedia.org/T60689#1221422 (10Neil_P._Quinn_WMF) I've [[https://fr.wikipedia.org/w/index.php?title=Utilisateur%3ANeil_P._Quinn-WMF%2FTestcase%2FT60689&diff=114195603&oldid=114195075|tested this]] again us...
[18:13:54] <wikibugs>	 10VisualEditor: VisualEditor: Reference dialog retains style of copy/pasted contents - https://phabricator.wikimedia.org/T60689#1221423 (10Neil_P._Quinn_WMF) 5stalled>3Resolved
[18:22:46] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable, 3Editing Department 2014/15 Q4 blockers: More <span> corruption (unknown source) - https://phabricator.wikimedia.org/T96589#1221468 (10Jdforrester-WMF) 3NEW
[18:23:18] <wikibugs>	 10VisualEditor, 10VisualEditor-CopyPaste, 7Browser-Support-Apple-Safari, 3Editing Department 2014/15 Q4 blockers, and 2 others: Insufficient span tags stripping from copy-and-paste in Safari - https://phabricator.wikimedia.org/T71494#1221479 (10Jdforrester-WMF) 5Open>3Resolved Moved new bug reports to...
[18:23:27] <wikibugs>	 10VisualEditor, 10VisualEditor-CopyPaste, 7Browser-Support-Apple-Safari, 7notice, 7user-notice: Insufficient span tags stripping from copy-and-paste in Safari - https://phabricator.wikimedia.org/T71494#1221483 (10Jdforrester-WMF)
[18:25:47] <wikibugs>	 10VisualEditor: [Regression pre-wmf-3] Media settings dialog: Caption box is small  - https://phabricator.wikimedia.org/T96591#1221496 (10Etonkovidova) 3NEW
[18:28:08] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable: Be able to set placeholder text (generic content?) on an empty CE surface - https://phabricator.wikimedia.org/T96593#1221523 (10Jdforrester-WMF) 3NEW
[18:33:12] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable, 3Editing Department 2014/15 Q4 blockers: More <span> corruption (unknown source) - https://phabricator.wikimedia.org/T96589#1221548 (10NicoV) For information, it seems to have appeared with the last deployment on frwiki : T71494 seemed fixed for like a week, an...
[18:34:36] <wikibugs>	 10VisualEditor, 7Browser-Support-Apple-Safari: VisualEditor:  Cutting (removing) last sections on page, and then pasting them back in, results in duplicated section headings - https://phabricator.wikimedia.org/T61847#1221574 (10Neil_P._Quinn_WMF) [[https://en.wikipedia.org/w/index.php?title=User%3ANeil_P._Quin...
[18:34:42] <wikibugs>	 10VisualEditor, 7Browser-Support-Apple-Safari: VisualEditor:  Cutting (removing) last sections on page, and then pasting them back in, results in duplicated section headings - https://phabricator.wikimedia.org/T61847#1221575 (10Neil_P._Quinn_WMF) 5stalled>3Resolved
[18:37:35] <wikibugs>	 10VisualEditor, 6Collaboration-Team, 10Flow, 10Parsoid: Previewing a link to a File in Flow's VE-mode, opens a broken destination due to /w/ - https://phabricator.wikimedia.org/T96492#1221597 (10cscott)
[18:40:25] <wikibugs>	 10VisualEditor, 6Collaboration-Team, 10Flow, 10Parsoid: Previewing a link to a File in Flow's VE-mode, opens a broken destination due to /w/ - https://phabricator.wikimedia.org/T96492#1221626 (10cscott) Can you dump the Parsoid output?  I'd be surprised if this was a Parsoid bug; double-checking parsoid ou...
[18:43:15] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers: VE Inspectors in mobile should have a "cancel" or "back" button - https://phabricator.wikimedia.org/T96303#1221657 (10Mooeypoo) a:3Mooeypoo As discussed with Trevor and Roan. the conclusion is that this should follow...
[18:43:43] <grrrit-wm>	 (03PS1) 10Mooeypoo: Add a cancel action to the Citoid inspector [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/205312 (https://phabricator.wikimedia.org/T96303) 
[18:44:29] <grrrit-wm>	 (03PS2) 10Catrope: Add removable flag to meta items [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205291 (https://phabricator.wikimedia.org/T96528) (owner: 10Esanders)
[18:45:36] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] "PS2 fixes the assertion count in the MetaList onTransact test. The reason that that test still throws an assertion count error is because " [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205291 (https://phabricator.wikimedia.org/T96528) (owner: 10Esanders)
[18:45:48] <grrrit-wm>	 (03PS1) 10Anomie: Further cleanup for core API change [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/205333 (https://phabricator.wikimedia.org/T96595) 
[18:47:14] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review: VE Inspectors in mobile should have a "cancel" or "back" button - https://phabricator.wikimedia.org/T96303#1221724 (10Mooeypoo) Note about usability of this -- this can be added to all inspectors ex...
[18:49:37] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add removable flag to meta items [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205291 (https://phabricator.wikimedia.org/T96528) (owner: 10Esanders)
[18:54:47] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Further cleanup for core API change [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/205333 (https://phabricator.wikimedia.org/T96595) (owner: 10Anomie)
[18:55:11] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Add a cancel action to the Citoid inspector [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/205312 (https://phabricator.wikimedia.org/T96303) (owner: 10Mooeypoo)
[18:58:23] <grrrit-wm>	 (03PS1) 10Mooeypoo: Add a default 'cancel' action to FragmentInspectors [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205339 (https://phabricator.wikimedia.org/T96303) 
[18:59:34] <grrrit-wm>	 (03PS2) 10Mooeypoo: Add a default 'cancel' action to FragmentInspectors [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205339 (https://phabricator.wikimedia.org/T96303) 
[19:01:06] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add a cancel action to the Citoid inspector [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/205312 (https://phabricator.wikimedia.org/T96303) (owner: 10Mooeypoo)
[19:01:40] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add a default 'cancel' action to FragmentInspectors [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205339 (https://phabricator.wikimedia.org/T96303) (owner: 10Mooeypoo)
[19:02:45] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Further cleanup for core API change [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/205333 (https://phabricator.wikimedia.org/T96595) (owner: 10Anomie)
[19:03:51] <grrrit-wm>	 (03PS3) 10Mooeypoo: Add a default 'cancel' action to FragmentInspectors [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205339 (https://phabricator.wikimedia.org/T96303) 
[19:04:00] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Further cleanup for core API change [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/205333 (https://phabricator.wikimedia.org/T96595) (owner: 10Anomie)
[19:04:37] <grrrit-wm>	 (03PS4) 10Mooeypoo: Add a default 'cancel' action to FragmentInspectors [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205339 (https://phabricator.wikimedia.org/T96303) 
[19:04:47] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Add a default 'cancel' action to FragmentInspectors [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205339 (https://phabricator.wikimedia.org/T96303) (owner: 10Mooeypoo)
[19:05:53] <wikibugs>	 10VisualEditor: [Regression pre-wmf-3] Media settings dialog: Caption box is small - https://phabricator.wikimedia.org/T96591#1221819 (10Etonkovidova) Basic reference {F121237}
[19:06:20] <grrrit-wm>	 (03Merged) 10jenkins-bot: Further cleanup for core API change [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/205333 (https://phabricator.wikimedia.org/T96595) (owner: 10Anomie)
[19:06:40] <RoanKattouw>	 Krinkle|detached: https://integration.wikimedia.org/ci/job/mediawiki-extensions-hhvm/13204/console just happened to me twice within five minutes (on different commits though)
[19:06:48] <RoanKattouw>	 Krinkle|detached: 19:00:54 IOError: Lock for file '/mnt/jenkins-workspace/workspace/mediawiki-extensions-hhvm/src/extensions/ConfirmEdit/.git/config' did already exist, delete '/mnt/jenkins-workspace/workspace/mediawiki-extensions-hhvm/src/extensions/ConfirmEdit/.git/config.lock' in case the lock is illegal
[19:06:49] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: VE mobile toolbar should be disabled if the focus is not on the document - https://phabricator.wikimedia.org/T96305#1221837 (10Mooeypoo) a:3Mooeypoo This was fixed by this: https://gerrit.wikimedia.org/r/#/c/204934/
[19:09:42] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-22_(1.26wmf3): VE mobile toolbar should be disabled if the focus is not on the document - https://phabricator.wikimedia.org/T96305#1221855 (10Jdforrester-WMF) 5Open>3Resolved p:5Triage>3Norm...
[19:09:42] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-22_(1.26wmf3): VE mobile toolbar should be disabled if the focus is not on the document - https://phabricator.wikimedia.org/T96305#1213966 (10Jdforrester-WMF)
[19:09:42] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add a default 'cancel' action to FragmentInspectors [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205339 (https://phabricator.wikimedia.org/T96303) (owner: 10Mooeypoo)
[19:10:16] <grrrit-wm>	 (03PS5) 10Mooeypoo: [wip] Keep the parameter list expanded after it was expanded once [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/203965 (https://phabricator.wikimedia.org/T95696) 
[19:11:51] <wikibugs>	 10MediaWiki-Page-editing, 10MediaWiki-Interface, 10UI-Standardization, 7Design: Replace [edit | edit source] next to section title with edit pencil at the right end of the line - https://phabricator.wikimedia.org/T96515#1221897 (10violetto) @matmarex, I'm going to go through the links you pasted.  True @Ri...
[19:13:12] <grrrit-wm>	 (03PS6) 10Mooeypoo: Keep the parameter list expanded after it was expanded once [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/203965 (https://phabricator.wikimedia.org/T95696) 
[19:33:11] <RoanKattouw>	 Krenair: Could you CR https://gerrit.wikimedia.org/r/#/c/205189/?
[19:33:39] <Krenair>	 I was looking at that earlier
[19:34:09] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Fix find and replace viewport search [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205089 (https://phabricator.wikimedia.org/T96088) (owner: 10Esanders)
[19:34:25] <Krenair>	 gonna test it now
[19:34:57] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] i18n: Warn that the special character list is unused in MW [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205180 (owner: 10Jforrester)
[19:35:36] <wikibugs>	 10VisualEditor, 10VisualEditor-EditingTools, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-22_(1.26wmf3): [Regression wmf2] "Error: offset was inside an ignoreChildren node" appears while having recursive Find and Replace in a page - https://phabricator.wikimedia.org/T96088#1222036 (10Jdforre...
[19:38:06] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] Focus on the first focusable element in template dialog (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/204204 (owner: 10Mooeypoo)
[19:39:27] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] Rearrange images when the media search window resizes (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/204568 (https://phabricator.wikimedia.org/T95017) (owner: 10Mooeypoo)
[19:39:27] <Krenair>	 RoanKattouw, I'm not convinced it works...
[19:40:04] <RoanKattouw>	 How so?]
[19:41:32] <wikibugs>	 10VisualEditor, 10VisualEditor-EditingTools, 10MediaWiki-extensions-SyntaxHighlight-(GeSHi), 7Browser-Support-Firefox: Inspector for editing syntax-highlight extension contents is really tiny, can't be resized - https://phabricator.wikimedia.org/T57934#1222051 (10Jdforrester-WMF) p:5Low>3Lowest
[19:41:36] <wikibugs>	 10VisualEditor, 10VisualEditor-EditingTools, 7Technical-Debt: Let users be able to re-size FragmentInspectors - https://phabricator.wikimedia.org/T96609#1222063 (10Jdforrester-WMF) 3NEW
[19:41:58] <Krenair>	 RoanKattouw, it looks like it's resetting the ID after the initial ready event
[19:42:05] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers: Space should be reserved for mobile inspector - https://phabricator.wikimedia.org/T96289#1222070 (10Jdforrester-WMF) p:5Triage>3High
[19:42:13] <RoanKattouw>	 Ugh
[19:42:25] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review: VE Inspectors in mobile should have a "cancel" or "back" button - https://phabricator.wikimedia.org/T96303#1222076 (10Jdforrester-WMF)
[19:42:27] <wikibugs>	 10VisualEditor, 6Mobile-Web: Mobile VE - Link inspector should have a back or cancel button - https://phabricator.wikimedia.org/T91844#1222077 (10Jdforrester-WMF)
[19:42:31] <RoanKattouw>	 I guess I could try doing something cleverer
[19:42:36] <Krenair>	 have you checked the values being logged closely?
[19:42:46] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 6Mobile-Web, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-22_(1.26wmf3): Mobile VE - Link inspector should have a back or cancel button - https://phabricator.wikimedia.org/T91844#1222082 (10Jdforrester-WMF) p:5Triage>3High a:3Mooeypoo
[19:42:55] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 6Mobile-Web, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-22_(1.26wmf3): Mobile VE - Link inspector should have a back or cancel button - https://phabricator.wikimedia.org/T91844#1097351 (10Jdforrester-WMF)
[19:43:12] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: VE Inspectors in mobile should have a "cancel" or "back" button - https://phabricator.wikimedia.org/T96303#1213921 (10Jdforrester-WMF)
[19:43:38] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review: Media search dialog should allow for dynamic reflow of the images when the screen changes dimensions - https://phabricator.wikimedia.org/T95017#1222088 (10Jdforrester-WMF)
[19:44:43] <grrrit-wm>	 (03PS1) 10Mooeypoo: Followup Id9e9c77: Add 'cancel' in AnnotationInspector 'insert' mode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205353 (https://phabricator.wikimedia.org/T96303) 
[19:45:01] <mooeypoo>	 RoanKattouw, whoopsie, sorry, this too as followup ^
[19:46:44] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Followup Id9e9c77: Add 'cancel' in AnnotationInspector 'insert' mode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205353 (https://phabricator.wikimedia.org/T96303) (owner: 10Mooeypoo)
[19:48:03] <RoanKattouw>	 Krenair: WTF now it's not working for me
[19:48:06] <RoanKattouw>	 It was working before
[19:49:12] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix find and replace viewport search [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205089 (https://phabricator.wikimedia.org/T96088) (owner: 10Esanders)
[19:49:15] <grrrit-wm>	 (03Merged) 10jenkins-bot: i18n: Warn that the special character list is unused in MW [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205180 (owner: 10Jforrester)
[19:49:19] <RoanKattouw>	 Oh I see what you're saying
[19:49:30] <RoanKattouw>	 When you press back, first it logs ready with the old ID, then it changes the ID
[19:49:45] <RoanKattouw>	 But it also caches the ID for abors?
[19:49:47] <Krenair>	 it seems to do this on the initial load
[19:49:47] <RoanKattouw>	 Sigh
[19:49:51] <Krenair>	 not just after pressing back
[19:50:31] <RoanKattouw>	 Yeah that sounds right
[19:50:35] <RoanKattouw>	 But it wasn't working at all before
[19:50:39] <RoanKattouw>	 Now it'll work too well
[19:50:40] <RoanKattouw>	 But I can fix that
[19:50:49] <wikibugs>	 10VisualEditor, 10VisualEditor-EditingTools, 7Design, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-22_(1.26wmf3): Have close buttons on inspectors and dialogs alike, in mobile and desktop environments - https://phabricator.wikimedia.org/T93749#1222126 (10Jdforrester-WMF) 5Open>3Resolve...
[19:50:58] <wikibugs>	 10VisualEditor, 10VisualEditor-EditingTools, 7Design, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-22_(1.26wmf3): Have close buttons on inspectors and dialogs alike, in mobile and desktop environments - https://phabricator.wikimedia.org/T93749#1145034 (10Jdforrester-WMF)
[19:51:08] <wikibugs>	 10VisualEditor, 10VisualEditor-EditingTools, 7Design, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-22_(1.26wmf3): Have close buttons on inspectors and dialogs alike, in mobile and desktop environments - https://phabricator.wikimedia.org/T93749#1145034 (10Jdforrester-WMF)
[19:51:25] <wikibugs>	 10VisualEditor, 10VisualEditor-EditingTools, 7Design, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-22_(1.26wmf3): Have close buttons on inspectors and dialogs alike, in mobile and desktop environments - https://phabricator.wikimedia.org/T93749#1145034 (10Jdforrester-WMF)
[19:51:39] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 6Mobile-Web, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-22_(1.26wmf3): Mobile VE - Link inspector should have a back or cancel button - https://phabricator.wikimedia.org/T91844#1222139 (10Jdforrester-WMF) 5Open>3Resolved
[19:51:58] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers: VisualEditor Mobile: The Link inspector icon remains highlighted in the toolbar for mobile VE even if no new link has been added - https://phabricator.wikimedia.org/T67305#1222140 (10Jdforrester-WMF)
[19:52:00] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 6Mobile-Web, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-22_(1.26wmf3): Mobile VE - Link inspector should have a back or cancel button - https://phabricator.wikimedia.org/T91844#1097351 (10Jdforrester-WMF)
[19:52:10] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers: Make VisualEditor good enough for mobile tablet and phone enablement - https://phabricator.wikimedia.org/T94725#1222146 (10Jdforrester-WMF)
[19:52:11] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers: VisualEditor Mobile: The Link inspector icon remains highlighted in the toolbar for mobile VE even if no new link has been added - https://phabricator.wikimedia.org/T67305#1222142 (10Jdforrester-WMF) 5Open>3Resolved...
[19:52:19] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-22_(1.26wmf3): VisualEditor Mobile: The Link inspector icon remains highlighted in the toolbar for mobile VE even if no new link has been added - https://phabricator.wikimedia.org/T67305#683722 (10J...
[19:52:45] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 6Mobile-Web, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-22_(1.26wmf3): Mobile VE - Link inspector should have a back or cancel button - https://phabricator.wikimedia.org/T91844#1097351 (10Jdforrester-WMF)
[19:52:46] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers: Getting stuck inside Link inspector while trying to clear the link text when there was no match for it in the inspector - https://phabricator.wikimedia.org/T68696#1222149 (10Jdforrester-WMF)
[19:52:54] <wikibugs>	 10TemplateData, 10VisualEditor, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-22_(1.26wmf3): [Regression pre-wmf3] Citation dialogs are now not showing any parameters in it - https://phabricator.wikimedia.org/T96443#1222151 (10Ryasmeen) Verified the fix in Betalabs
[19:53:01] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-22_(1.26wmf3): Getting stuck inside Link inspector while trying to clear the link text when there was no match for it in the inspector - https://phabricator.wikimedia.org/T68696#1222152 (10Jdforrest...
[19:53:45] <wikibugs>	 10VisualEditor, 10VisualEditor-EditingTools, 7Design: VisualEditor: Inspectors apply if you exit from them without a positive action, which can be a bit confusing - https://phabricator.wikimedia.org/T55546#1222155 (10Jdforrester-WMF) Maybe we should label the "cancel" button "remove" or somesuch? I don't know…
[19:54:19] <wikibugs>	 10VisualEditor, 10VisualEditor-EditingTools, 7Design: VisualEditor: Inspectors apply if you exit from them without a positive action, which can be a bit confusing - https://phabricator.wikimedia.org/T55546#1222159 (10Jdforrester-WMF)
[19:54:45] <wikibugs>	 10VisualEditor, 10VisualEditor-EditingTools, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-22_(1.26wmf3): VisualEditor: Label the "Remove" button in link inspector as "Cancel" if in link creation mode - https://phabricator.wikimedia.org/T71359#1222166 (10Jdforrester-WMF) 5Open>3Resolved...
[19:54:50] <wikibugs>	 10VisualEditor, 10VisualEditor-EditingTools, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-22_(1.26wmf3): VisualEditor: Label the "Remove" button in link inspector as "Cancel" if in link creation mode - https://phabricator.wikimedia.org/T71359#731337 (10Jdforrester-WMF)
[19:55:24] <grrrit-wm>	 (03PS3) 10Bartosz Dziewoński: Do not wrap <pre> nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205177 (https://phabricator.wikimedia.org/T56381) 
[19:55:36] <grrrit-wm>	 (03Merged) 10jenkins-bot: Followup Id9e9c77: Add 'cancel' in AnnotationInspector 'insert' mode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205353 (https://phabricator.wikimedia.org/T96303) (owner: 10Mooeypoo)
[19:56:01] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "Verified and it works for me with MW too." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205177 (https://phabricator.wikimedia.org/T56381) (owner: 10Bartosz Dziewoński)
[19:56:13] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable: If the initial selection is a node (i.e. the document only contains nodes, no text), select the first node and display its context menu - https://phabricator.wikimedia.org/T59477#1222176 (10Jdforrester-WMF)
[19:56:22] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable: If the initial selection is a node (i.e. the document only contains nodes, no text), select the first node and display its context menu - https://phabricator.wikimedia.org/T59477#643064 (10Jdforrester-WMF) (Confirmed still an issue.)
[19:57:32] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Do not wrap <pre> nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205177 (https://phabricator.wikimedia.org/T56381) (owner: 10Bartosz Dziewoński)
[19:58:02] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-22_(1.26wmf3): VisualEditor: Long lines in preformatted paragraphs should not wrap in VE - https://phabricator.wikimedia.org/T56381#1222181 (10Jdforrester-WMF) 5Open>3Resolved a:3matmarex
[19:58:07] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-22_(1.26wmf3): VisualEditor: Long lines in preformatted paragraphs should not wrap in VE - https://phabricator.wikimedia.org/T56381#578021 (10Jdforrester-WMF)
[19:59:50] <grrrit-wm>	 (03Merged) 10jenkins-bot: Do not wrap <pre> nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205177 (https://phabricator.wikimedia.org/T56381) (owner: 10Bartosz Dziewoński)
[20:08:10] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable, 10Parsoid: &#91; and &#93; as replacement for [ ] in weblinks not recognised by VE - https://phabricator.wikimedia.org/T95854#1222219 (10cscott) @Raymond: can you describe your test case a little more?  Are you editing an existing link containing square bracket...
[20:19:41] <wikibugs>	 10MediaWiki-ResourceLoader, 10WikiEditor: Request amendment of Bangla character set in WikiEditor - https://phabricator.wikimedia.org/T96494#1222252 (10Krenair) So we basically just want to do the equivalent of https://en.wikisource.org/w/index.php?title=MediaWiki:Gadget-charinsert-core.js&diff=5358255&oldid=5...
[20:26:34] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable, 10Parsoid: &#91; and &#93; as replacement for [ ] in weblinks not recognised by VE - https://phabricator.wikimedia.org/T95854#1222275 (10Raymond) >>! In T95854#1222219, @cscott wrote: > @Raymond: can you describe your test case a little more?  @cscott This bug...
[20:36:40] <grrrit-wm>	 (03CR) 10Sharmaans: LaTeX to Mathematica Function Translation PHP Regex replacement of LaTeX function input into corresponding Mathematica function (038 comments) [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/203954 (owner: 10Sharmaans)
[21:24:16] <wikibugs>	 10OOjs-UI, 10MediaWiki-General-or-Unknown, 5MW-1.25-release: Remove OOUI icon packs from MW 1.25 release - https://phabricator.wikimedia.org/T96273#1222437 (10matmarex) 5Open>3Resolved
[21:34:09] <grrrit-wm>	 (03CR) 10Physikerwelt: LaTeX to Mathematica Function Translation PHP Regex replacement of LaTeX function input into corresponding Mathematica function (032 comments) [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/203954 (owner: 10Sharmaans)
[21:35:17] <wikibugs>	 10VisualEditor, 6Collaboration-Team, 10Flow, 10Parsoid: Previewing a link to a File in Flow's VE-mode, opens a broken destination due to /w/ - https://phabricator.wikimedia.org/T96492#1222475 (10EBernhardson) The content coming from parsoid should be fine, the issue for flow is that we render content from...
[21:40:59] <wikibugs>	 10MediaWiki-ResourceLoader, 10WikiEditor: Request amendment of Bangla character set in WikiEditor - https://phabricator.wikimedia.org/T96494#1222502 (10GOIII) Not 100% sure but I //believe// the current list found at the bottom of [[https://en.wikisource.org/wiki/MediaWiki_talk:Gadget-charinsert-core.js#Propos...
[21:52:20] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers: VisualEditor Mobile: In android, while trying to apply a link on a selected text, strips off the first letter of the text in the link inspector - https://phabricator.wikimedia.org/T70244#1222557 (10Krenair)
[21:55:32] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 7Browser-Support-Google-Chrome, 3Editing Department 2014/15 Q4 blockers: VisualEditor Mobile: Tapping on Return while cursor is at the end of a text, deletes that text in Nexus 7 (Android 4.4.2) - https://phabricator.wikimedia.org/T68758#1222599 (10Krenair)
[21:55:40] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 7Browser-Support-Google-Chrome, 3Editing Department 2014/15 Q4 blockers: VisualEditor Mobile: Tapping on Return while cursor is at the end of a text, deletes that text in Nexus 7 (Android 4.4.2) - https://phabricator.wikimedia.org/T68758#703789 (10Krenair)
[21:57:08] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers: VisualEditor Mobile: For the first time in each edit session in Nexus 7 (Android 4.4.2), Link Inspector gets auto-zoomed in, which looks like partial rendering of the UI - https://phabricator.wikimedia.org/T68759#1222620...
[22:04:09] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers: VisualEditor Mobile: Performance issue with adding Citations in Mobile - https://phabricator.wikimedia.org/T72184#1222650 (10Krenair)
[22:04:25] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers: VisualEditor Mobile: Cannot overwrite a text entered in CE in mobile VE using desktop Firefox - https://phabricator.wikimedia.org/T74409#1222653 (10Krenair)
[22:07:25] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 7Browser-Support-Google-Chrome, 3Editing Department 2014/15 Q4 blockers: VisualEditor Mobile: Cannot save any edit in mobile VE for Nexus 7(Android 4.4.2) - https://phabricator.wikimedia.org/T68756#1222659 (10Krenair) Was this specifically with that device,...
[22:11:06] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 7Browser-Support-Apple-Safari, 3Editing Department 2014/15 Q4 blockers: VisualEditor Mobile: [Regression wmf15] Pressing backspace to delete  the link target inside link inspector closes the inspector - https://phabricator.wikimedia.org/T70195#1222673 (10Kren...
[22:11:25] <wikibugs>	 10OOjs-UI, 10Living-Style-Guide, 7Design, 5Patch-For-Review: Apply typography, space, and layout styles - https://phabricator.wikimedia.org/T95661#1222675 (10violetto) @Prtksxna, I fixed some issues. [[ https://github.com/munmay/layoutTemplates/tree/gh-pages | Check em here ]].
[22:21:00] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-22_(1.26wmf3): Slugs should not be visible through context menu - https://phabricator.wikimedia.org/T93042#1222698 (10Ryasmeen) Verified the fix in Betalabs
[22:22:55] <wikibugs>	 10VisualEditor, 10VisualEditor-Tables, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-22_(1.26wmf3): "Delete row"/"Delete column" messages do not use the plural when multiple rows/columns are selected (but they do delete multiple rows/columns) - https://phabricator.wikimedia.org/T87234#1222705...
[22:28:06] * RoanKattouw punches https://code.google.com/p/chromium/issues/detail?id=344507
[22:28:44] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-22_(1.26wmf3), 7user-notice: Template search results list should contain each template's descripton - https://phabricator.wikimedia.org/T53436#1222720 (10Ryasmeen) Verified the fix in Betalabs
[22:32:38] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers: VisualEditor Mobile: [Regression wmf4] Link suggestions are appearing in a broken way inside Link Inspector in mobile - https://phabricator.wikimedia.org/T74402#1222723 (10Krenair) I cannot reproduce this on my mobile d...
[22:34:52] <wikibugs>	 10VisualEditor, 6Collaboration-Team, 10Flow, 10Parsoid: Previewing a link to a File in Flow's VE-mode, opens a broken destination due to /w/ - https://phabricator.wikimedia.org/T96492#1222728 (10Mattflaschen) >>! In T96492#1222475, @EBernhardson wrote: > The content coming from parsoid should be fine, the...
[22:35:41] <grrrit-wm>	 (03PS5) 10Catrope: Regenerate editingStatsId on pagehide [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/205189 
[22:35:49] <RoanKattouw>	 Krenair: I cracked it ---^^
[22:35:52] <grrrit-wm>	 (03PS1) 10Jforrester: Update VE core submodule to master (6775f4d) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/205454 
[22:35:55] <superm401>	 Can someone comment on https://phabricator.wikimedia.org/T96492 ?  We're trying to figure out the relevant ways that VE's handling of base href differs from ours.
[22:36:51] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Update VE core submodule to master (6775f4d) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/205454 (owner: 10Jforrester)
[22:37:22] <RoanKattouw>	 Krenair: If you could look at that quickly, we could get it deployed today
[22:39:50] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (6775f4d) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/205454 (owner: 10Jforrester)
[22:40:12] * Krenair testing
[22:42:37] <Krenair>	 RoanKattouw, certainly appears to work!
[22:43:01] <wikibugs>	 10VisualEditor, 10RESTBase, 6operations, 7Performance: Set up an API base path for REST and action APIs - https://phabricator.wikimedia.org/T95229#1222742 (10BBlack) >>! In T95229#1210586, @csteipp wrote: > Yep, being able to setup a new $foo.wikimedia.org domain, and not get penalized in performance when...
[22:43:12] <Krinkle>	 RoanKattouw: That's caused by a previous job being aborted, and the workspace being killed while git was cloning something.
[22:43:32] <Krinkle>	 Requires manually purging that .git from that slave
[22:44:00] <Krenair>	 RoanKattouw, oh, er, hang on
[22:44:03] <Krenair>	 RoanKattouw, abort event
[22:44:11] <Krinkle>	 Because Jenkins does not clean/reset workspaces right now, and even in cases where we do, Zuul does not clean up git locks properly
[22:44:19] <RoanKattouw>	 Krenair: That's in a separate branch isn't it?
[22:44:22] <RoanKattouw>	 What about it?
[22:44:50] <Krenair>	 This code gives it a separate session ID
[22:44:57] <Krinkle>	 I've rm-rf'ed that git clone just now
[22:47:55] <wikibugs>	 10VisualEditor, 6Collaboration-Team, 10Flow, 10Parsoid: Previewing a link to a File in Flow's VE-mode, opens a broken destination due to /w/ - https://phabricator.wikimedia.org/T96492#1222747 (10Catrope) VE expects its input documents to have a `<base>` with a sensible `href`. It then performs minimal magi...
[22:48:11] <RoanKattouw>	 hah I think I tested that
[22:48:12] * RoanKattouw tests again
[22:48:42] <RoanKattouw>	 Crap, right
[22:49:06] <RoanKattouw>	 But only in Chrome
[22:49:08] <RoanKattouw>	 (of course)
[22:50:04] <RoanKattouw>	 Got it
[22:50:10] <RoanKattouw>	 If we move this code to the unload handler that fixes it
[22:52:09] <grrrit-wm>	 (03PS6) 10Catrope: Regenerate editingStatsId on unload [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/205189 
[22:52:14] <RoanKattouw>	 Krenair: How about this? ---^^
[22:54:51] <wikibugs>	 10VisualEditor, 6Collaboration-Team, 10Flow, 10Parsoid: Previewing a link to a File in Flow's VE-mode, opens a broken destination due to /w/ - https://phabricator.wikimedia.org/T96492#1222752 (10Mattflaschen) This is a reason to look at a shared base class that is MW-specific (so it can assume things like...
[22:55:03] <wikibugs>	 10VisualEditor, 6Collaboration-Team, 10Flow, 10Parsoid: Previewing a link to a File in Flow's VE-mode, opens a broken destination due to /w/ - https://phabricator.wikimedia.org/T96492#1222753 (10Mattflaschen) @Quiddity, what browser was this in?
[22:55:58] <Krenair>	 did you test it, RoanKattouw?
[22:56:05] <RoanKattouw>	 Yes, it works for me
[22:56:12] <RoanKattouw>	 And I tested aborts this time :D
[22:56:28] <RoanKattouw>	 But you keep finding bugs in my code, so if you could test it again, that would be awesome
[22:56:56] <Krenair>	 Aborts are still broken
[23:23:57] <grrrit-wm>	 (03PS1) 10Catrope: Update VE core submodule to master (6775f4d) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/205464 
[23:24:15] <RoanKattouw>	 ryasmeen: It wasn't pulled through yet it turns out, here's a pull-through ---^^
[23:24:47] <ryasmeen>	 okay. thanks RoanKattouw
[23:30:23] <Krenair>	 did you also find the issue with abort events, RoanKattouw?
[23:30:50] <grrrit-wm>	 (03PS1) 10Legoktm: Remove unused 'pkg' from Gruntfile.js [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/205466 
[23:34:43] <RoanKattouw>	 Krenair: No, how do I reproduce?
[23:34:58] <Krenair>	 save, go back, abort
[23:35:04] <Krenair>	 check session id of abort event
[23:35:46] <RoanKattouw>	 WFM in Chrome
[23:36:55] <RoanKattouw>	 But broken in Firefox
[23:36:57] <RoanKattouw>	 WTF why
[23:37:05] <RoanKattouw>	 I thought we'd broken bfcache in Firefox by having that unload handler
[23:43:53] <RoanKattouw>	 Hmm I could reproduce before but now I can't
[23:43:59] <RoanKattouw>	 I'll fix up my code a bit though
[23:44:12] <RoanKattouw>	 Running $( '#editingStatsId' ) (i.e. a DOM lookup) from an unload handler is probably scary
[23:44:39] <grrrit-wm>	 (03PS7) 10Catrope: Regenerate editingStatsId on unload [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/205189 
[23:47:11] <RoanKattouw>	 Hrmph
[23:47:15] <RoanKattouw>	 unload doesn't fire at all on back
[23:47:22] <RoanKattouw>	 So we should register aborts from pagehide, I gues
[23:49:39] <RoanKattouw>	 Argh Firefox behaves differently depending on whether the inspector is open
[23:50:46] <RoanKattouw>	 Or on whether it has been open in the past... ? WTF
[23:50:54] * RoanKattouw opens a private browsing window
[23:53:16] <RoanKattouw>	 Krenair: OK so the abort bug doesn't happen for me with PS7 (which has a minor change that may or may not matter) when I use a private browsing window (FF) / incognito window (Chrome) with no inspector open
[23:53:26] <RoanKattouw>	 With an inspector open, weird shit happens :(
[23:54:17] <RoanKattouw>	 But these duplicate sessions are 0.2% of sessions as it is, so the number of people that use the back button with the inspector open in Firefox should be so low that I'm not sure I want to bother
[23:56:24] <grrrit-wm>	 (03PS1) 10Mooeypoo: Add class to mobile window manager [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205472 (https://phabricator.wikimedia.org/T86233) 
[23:58:48] <grrrit-wm>	 (03PS2) 10Catrope: Add class to mobile window manager [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205472 (https://phabricator.wikimedia.org/T86233) (owner: 10Mooeypoo)
[23:59:46] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] Add class to mobile window manager (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205472 (https://phabricator.wikimedia.org/T86233) (owner: 10Mooeypoo)