[00:00:54] (03PS3) 10Mooeypoo: Add class to mobile window manager [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205472 (https://phabricator.wikimedia.org/T86233) [00:01:25] (03CR) 10Catrope: [C: 032] Add class to mobile window manager [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205472 (https://phabricator.wikimedia.org/T86233) (owner: 10Mooeypoo) [00:02:02] (03PS1) 10Mooeypoo: Correct display for full-screen dialogs in Mobile VE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/205475 (https://phabricator.wikimedia.org/T86233) [00:04:24] (03CR) 10Catrope: [C: 04-1] Correct display for full-screen dialogs in Mobile VE (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/205475 (https://phabricator.wikimedia.org/T86233) (owner: 10Mooeypoo) [00:05:11] (03Merged) 10jenkins-bot: Add class to mobile window manager [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205472 (https://phabricator.wikimedia.org/T86233) (owner: 10Mooeypoo) [00:09:51] (03Abandoned) 10Catrope: Update VE core submodule to master (6775f4d) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/205464 (owner: 10Catrope) [00:10:15] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (6775f4d) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/205454 (owner: 10Jforrester) [00:10:31] (03Abandoned) 10Catrope: Update VE core submodule to master (6775f4d) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/205454 (owner: 10Jforrester) [00:10:50] (03PS1) 10Catrope: Update VE core submodule to master (a666ccc) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/205476 [00:11:20] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (a666ccc) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/205476 (owner: 10Catrope) [00:12:46] (03CR) 10Sharmaans: LaTeX to Mathematica Function Translation PHP Regex replacement of LaTeX function input into corresponding Mathematica function (031 comment) [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/203954 (owner: 10Sharmaans) [00:12:57] (03Merged) 10jenkins-bot: Update VE core submodule to master (a666ccc) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/205476 (owner: 10Catrope) [00:13:32] ryasmeen: Pull-through done [00:15:30] (03PS2) 10Mooeypoo: Correct display for full-screen dialogs in Mobile VE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/205475 (https://phabricator.wikimedia.org/T86233) [00:16:28] (03CR) 10Catrope: [C: 032] Correct display for full-screen dialogs in Mobile VE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/205475 (https://phabricator.wikimedia.org/T86233) (owner: 10Mooeypoo) [00:20:14] (03Merged) 10jenkins-bot: Correct display for full-screen dialogs in Mobile VE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/205475 (https://phabricator.wikimedia.org/T86233) (owner: 10Mooeypoo) [00:32:02] (03PS2) 10Jforrester: build: Remove unused 'pkg' from Gruntfile.js [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/205466 (owner: 10Legoktm) [00:32:07] (03CR) 10Jforrester: [C: 032] build: Remove unused 'pkg' from Gruntfile.js [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/205466 (owner: 10Legoktm) [00:33:57] (03Merged) 10jenkins-bot: build: Remove unused 'pkg' from Gruntfile.js [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/205466 (owner: 10Legoktm) [00:45:38] Krenair: So, does the latest version of https://gerrit.wikimedia.org/r/205189 work for you? [00:45:49] It works for me in incognito windows without inspectors in both FF and Chrome [00:46:18] With inspectors it's weird, but right now people are breathing down our necks about this and the number of users that actually use browser inspectors is low enough IMO [00:57:55] RoanKattouw, I tried it again and it worked [00:58:06] RoanKattouw: Doesn't pagehide/show also fire when switching tabs and windows? [00:58:16] Krinkle: Nope, common misconception [00:58:29] Krinkle: Also my latest patchset doesn't use either because Chrome [00:58:37] yeah [00:58:42] (I added that bug to our meta-bug) [00:59:05] RoanKattouw: Oh that's window.focus/blur [00:59:09] https://integration.wikimedia.org/zuul/jquery-visibility.js [00:59:28] However it fires a virtual show/hide event [01:00:34] RoanKattouw, shouldn't this be linked to that task about broken sessions? [01:00:53] otherwise looks good [01:01:16] Oh crap yes [01:01:42] (03PS8) 10Catrope: Regenerate editingStatsId on unload [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/205189 (https://phabricator.wikimedia.org/T95919) [01:01:45] There [01:05:04] (03CR) 10Alex Monk: [C: 032] "Works for me." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/205189 (https://phabricator.wikimedia.org/T95919) (owner: 10Catrope) [01:06:30] (03Merged) 10jenkins-bot: Regenerate editingStatsId on unload [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/205189 (https://phabricator.wikimedia.org/T95919) (owner: 10Catrope) [01:06:57] I really hope this fixes it. [01:07:01] (03PS1) 10Catrope: Regenerate editingStatsId on unload [extensions/WikiEditor] (wmf/1.26wmf1) - 10https://gerrit.wikimedia.org/r/205484 (https://phabricator.wikimedia.org/T95919) [01:07:15] (03PS1) 10Catrope: Regenerate editingStatsId on unload [extensions/WikiEditor] (wmf/1.26wmf2) - 10https://gerrit.wikimedia.org/r/205485 (https://phabricator.wikimedia.org/T95919) [01:07:21] (03CR) 10Catrope: [C: 032] Regenerate editingStatsId on unload [extensions/WikiEditor] (wmf/1.26wmf2) - 10https://gerrit.wikimedia.org/r/205485 (https://phabricator.wikimedia.org/T95919) (owner: 10Catrope) [01:07:32] (03CR) 10Catrope: [C: 032] Regenerate editingStatsId on unload [extensions/WikiEditor] (wmf/1.26wmf1) - 10https://gerrit.wikimedia.org/r/205484 (https://phabricator.wikimedia.org/T95919) (owner: 10Catrope) [01:07:35] Woo. [01:07:36] I do too [01:07:40] But the incidence was already pretty low [01:07:49] I mean Aaron made a big deal about it, but it's 0.2% of sessions [01:08:10] And because of the session ID length weirdness, we can tell exactly how often this code kicks in [01:08:18] (03Merged) 10jenkins-bot: Regenerate editingStatsId on unload [extensions/WikiEditor] (wmf/1.26wmf2) - 10https://gerrit.wikimedia.org/r/205485 (https://phabricator.wikimedia.org/T95919) (owner: 10Catrope) [01:08:46] (03Merged) 10jenkins-bot: Regenerate editingStatsId on unload [extensions/WikiEditor] (wmf/1.26wmf1) - 10https://gerrit.wikimedia.org/r/205484 (https://phabricator.wikimedia.org/T95919) (owner: 10Catrope) [01:15:29] (03CR) 10Catrope: [C: 032] Re-add A/B testing framework for new accounts [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/204933 (owner: 10Jforrester) [01:18:13] (03Merged) 10jenkins-bot: Re-add A/B testing framework for new accounts [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/204933 (owner: 10Jforrester) [01:18:28] (03PS1) 10Jforrester: [TEMPORARY] Re-point A/B testing preference for test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/205488 [01:23:36] (03PS2) 10Catrope: [TEMPORARY] Re-point A/B testing preference for test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/205488 (owner: 10Jforrester) [01:23:41] (03CR) 10Catrope: [C: 032] [TEMPORARY] Re-point A/B testing preference for test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/205488 (owner: 10Jforrester) [01:30:04] (03CR) 10Catrope: [C: 04-1] "Code looks good, and the effect this achieves is impressive: you can put in a URL to an incomplete page name and you get search results fo" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201627 (https://phabricator.wikimedia.org/T94334) (owner: 10Alex Monk) [01:30:58] RoanKattouw, we really just need to split external link inputs from internal link inputs [01:31:15] some tex- [01:31:50] (03Merged) 10jenkins-bot: [TEMPORARY] Re-point A/B testing preference for test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/205488 (owner: 10Jforrester) [01:32:04] Krenair: Ever heard of uneval() ? [01:32:13] it's a thing in Firefox [01:32:19] ... no? [01:32:31] It's kind of like JSON.stringify [01:32:37] but scarier [01:32:45] var a = {}, a.b = 123 [01:33:04] a.toSource(); // "({b:123})" [01:33:16] which uses uneval() underneath [01:33:50] sounds like fun [01:46:40] (03PS1) 10Legoktm: test: Configuring banana-checker for i18n messages [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/205493 [01:46:41] (03PS1) 10Legoktm: test: Configuring banana-checker for i18n messages [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/205493 [01:46:45] (03CR) 10Legoktm: "check experimental" [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/205493 (owner: 10Legoktm) [01:46:46] (03CR) 10Legoktm: "check experimental" [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/205493 (owner: 10Legoktm) [01:52:18] (03CR) 10Legoktm: "recheck" [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/205493 (owner: 10Legoktm) [01:52:19] (03CR) 10Legoktm: "recheck" [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/205493 (owner: 10Legoktm) [01:52:38] (03CR) 10jenkins-bot: [V: 04-1] test: Configuring banana-checker for i18n messages [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/205493 (owner: 10Legoktm) [01:52:39] (03CR) 10jenkins-bot: [V: 04-1] test: Configuring banana-checker for i18n messages [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/205493 (owner: 10Legoktm) [01:54:37] (03PS2) 10Legoktm: test: Configuring banana-checker for i18n messages [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/205493 [01:54:38] (03PS2) 10Legoktm: test: Configuring banana-checker for i18n messages [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/205493 [01:54:42] (03PS1) 10Legoktm: Add missing class to autoload [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/205496 [01:54:43] (03PS1) 10Legoktm: Add missing class to autoload [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/205496 [01:56:39] (03CR) 10Legoktm: "check experimental" [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/205493 (owner: 10Legoktm) [01:56:40] (03CR) 10Legoktm: "check experimental" [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/205493 (owner: 10Legoktm) [02:15:03] (03PS1) 10Legoktm: Re-build extension.json, deprecate and empty CiteThisPage.php [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/205498 [02:15:04] (03PS1) 10Legoktm: Re-build extension.json, deprecate and empty CiteThisPage.php [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/205498 [02:15:16] * legoktm pats grrrit-wm [02:21:09] James_F|Away: https://gerrit.wikimedia.org/r/#/c/205498/ will definitely not break anything ;) [03:07:22] I was talking with RoanKattouw_away about https://phabricator.wikimedia.org/T96492 earlier. It turns out there is a very similar (but not the same bug in article VE). [03:08:11] Not sure if it should be split; for now, since it's so close I'm keeping it in the same task. [03:22:22] (03PS1) 10Legoktm: test: Configuring banana-checker for i18n messages [extensions/Cite] - 10https://gerrit.wikimedia.org/r/205510 [03:22:25] (03CR) 10Legoktm: "check experimental" [extensions/Cite] - 10https://gerrit.wikimedia.org/r/205510 (owner: 10Legoktm) [03:22:40] (03CR) 10jenkins-bot: [V: 04-1] test: Configuring banana-checker for i18n messages [extensions/Cite] - 10https://gerrit.wikimedia.org/r/205510 (owner: 10Legoktm) [03:27:14] (03PS2) 10Legoktm: test: Configuring banana-checker for i18n messages [extensions/Cite] - 10https://gerrit.wikimedia.org/r/205510 [03:29:53] (03PS1) 10Legoktm: test: Configuring banana-checker for i18n messages [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/205513 [03:29:56] (03CR) 10Legoktm: "check experimental" [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/205513 (owner: 10Legoktm) [03:45:10] superm401-night: Interesting; please do file that separately [03:45:30] superm401-night: Cause that looks like a bug in the CE node (but not the context item apparently?) to adjust for the base URL [03:48:03] 10VisualEditor, 10VisualEditor-ContentEditable: Link to file has wrong href - https://phabricator.wikimedia.org/T96643#1223130 (10Mattflaschen) 3NEW [03:48:14] 10VisualEditor, 6Collaboration-Team, 10Flow, 10Parsoid: Previewing a link to a File in Flow's VE-mode, opens a broken destination due to /w/ - https://phabricator.wikimedia.org/T96492#1218278 (10Mattflaschen) [03:48:41] 10VisualEditor, 6Collaboration-Team, 10Flow, 10Parsoid: Previewing a link to a File in Flow's VE-mode, opens a broken destination due to /w/ - https://phabricator.wikimedia.org/T96492#1218278 (10Mattflaschen) Broken into a separate bug (T96643) per @Catrope's request. [03:49:08] RoanKattouw, done. Broken into https://phabricator.wikimedia.org/T96643 . [03:49:14] Thanks [03:49:59] Hmm the context item link is also wrong [03:50:56] Oh, I thought I checked that; I guess not. [03:54:50] 10VisualEditor, 10VisualEditor-ContentEditable: Newly created links on subpages are rendered with wrong href - https://phabricator.wikimedia.org/T96643#1223175 (10Catrope) a:3Catrope [03:55:01] Sorry, you were right [03:55:15] What's wrong with both of them is the leading colon (URL-encoded as %3A) [03:55:21] I'm gonna punt that bug to someone else [03:55:38] But *if you are on a subpage*, the CE rendering was missing /wiki while the context item wasn't [03:56:07] This is because of some old code that dealt with a Parsoid issue that doesn't exist any more [03:56:10] Removing it will fix this [03:56:12] Patch inbound [03:57:15] (03PS1) 10Catrope: ce.MWInternalLinkAnnotation: Remove outdated ../ stripping code [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/205521 (https://phabricator.wikimedia.org/T96643) [04:04:31] 10VisualEditor, 10VisualEditor-MediaWiki-Links: Leading colon for file links should not be included in URLs and link captions - https://phabricator.wikimedia.org/T96644#1223208 (10Catrope) 3NEW [04:05:08] 10VisualEditor, 10VisualEditor-ContentEditable, 5Patch-For-Review: Newly created links on subpages are rendered with wrong href - https://phabricator.wikimedia.org/T96643#1223130 (10Catrope) >>! In T96643#1223195, @gerritbot wrote: > Change 205521 had a related patch set uploaded (by Catrope): > ce.MWInterna... [04:10:01] (03PS1) 10Divec: Document getNodeAndOffset better, in preparation for cleanup [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205523 [04:26:03] (03CR) 10Jforrester: [C: 032] ce.MWInternalLinkAnnotation: Remove outdated ../ stripping code [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/205521 (https://phabricator.wikimedia.org/T96643) (owner: 10Catrope) [04:27:53] (03Merged) 10jenkins-bot: ce.MWInternalLinkAnnotation: Remove outdated ../ stripping code [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/205521 (https://phabricator.wikimedia.org/T96643) (owner: 10Catrope) [04:28:05] 10VisualEditor, 10VisualEditor-ContentEditable, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-22_(1.26wmf3): Newly created links on subpages are rendered with wrong href - https://phabricator.wikimedia.org/T96643#1223239 (10Jdforrester-WMF) p:5Triage>3High [04:28:24] 10VisualEditor, 10VisualEditor-ContentEditable, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-22_(1.26wmf3): Newly created links on subpages are rendered with wrong href - https://phabricator.wikimedia.org/T96643#1223242 (10Jdforrester-WMF) 5Open>3Resolved [04:30:15] 10MediaWiki-ResourceLoader, 10WikiEditor: Request amendment of Bangla character set in WikiEditor - https://phabricator.wikimedia.org/T96494#1223246 (10Hrishikes) @Nasirkhan can you help with the JSON format? List now available at the enWS CharInsert gadget and not on its talk page. [04:31:03] (03CR) 10Jforrester: [C: 032] Add missing class to autoload [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/205496 (owner: 10Legoktm) [04:31:04] (03CR) 10Jforrester: [C: 032] Add missing class to autoload [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/205496 (owner: 10Legoktm) [04:31:20] (03Merged) 10jenkins-bot: Add missing class to autoload [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/205496 (owner: 10Legoktm) [04:31:21] (03Merged) 10jenkins-bot: Add missing class to autoload [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/205496 (owner: 10Legoktm) [04:32:30] (03PS2) 10Jforrester: Re-build extension.json, deprecate and empty CiteThisPage.php [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/205498 (owner: 10Legoktm) [04:32:31] (03PS2) 10Jforrester: Re-build extension.json, deprecate and empty CiteThisPage.php [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/205498 (owner: 10Legoktm) [04:34:09] (03CR) 10Jforrester: [C: 031] "Is this good to go for production?" [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/205498 (owner: 10Legoktm) [04:34:10] (03CR) 10Jforrester: [C: 031] "Is this good to go for production?" [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/205498 (owner: 10Legoktm) [04:34:50] (03CR) 10Legoktm: "Yep, all the necessary changes were merged prior to 1.26wmf1!" [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/205498 (owner: 10Legoktm) [04:34:51] (03CR) 10Legoktm: "Yep, all the necessary changes were merged prior to 1.26wmf1!" [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/205498 (owner: 10Legoktm) [04:36:18] (03CR) 10Bartosz Dziewoński: "It still has its own stacking context, so it should not be a big issue?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205177 (https://phabricator.wikimedia.org/T56381) (owner: 10Bartosz Dziewoński) [04:36:25] (03CR) 10Jforrester: [C: 032] "Let's hope so. :-)" [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/205498 (owner: 10Legoktm) [04:36:26] (03CR) 10Jforrester: [C: 032] "Let's hope so. :-)" [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/205498 (owner: 10Legoktm) [04:36:37] \o/ [04:36:40] (03Merged) 10jenkins-bot: Re-build extension.json, deprecate and empty CiteThisPage.php [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/205498 (owner: 10Legoktm) [04:36:41] (03Merged) 10jenkins-bot: Re-build extension.json, deprecate and empty CiteThisPage.php [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/205498 (owner: 10Legoktm) [04:42:49] 10MediaWiki-ResourceLoader, 10WikiEditor: Request amendment of Bangla character set in WikiEditor - https://phabricator.wikimedia.org/T96494#1223278 (10AuFCL) @Hrishikes, @Nasirkhan: What follows is my best attempt for mashing everything together in what (I hope) is the correct format. I have no way of even va... [04:55:31] 10MediaWiki-ResourceLoader, 10WikiEditor: Request amendment of Bangla character set in WikiEditor - https://phabricator.wikimedia.org/T96494#1223291 (10Hrishikes) >>! In T96494#1223278, @AuFCL wrote: > @Hrishikes, @Nasirkhan: What follows is my best attempt for mashing everything together in what (I hope) is t... [06:22:43] 10VisualEditor, 10VisualEditor-ContentEditable: Gallery edit still not easy - https://phabricator.wikimedia.org/T96647#1223344 (10Juandev) 3NEW [06:38:01] 10MediaWiki-ResourceLoader, 10WikiEditor: Request amendment of Bangla character set in WikiEditor - https://phabricator.wikimedia.org/T96494#1223353 (10Nasirkhan) Added 2 characters and changed the order at https://en.wikisource.org/wiki/User:AuFCL/specialcharacters.json and i think there are no change needed [06:45:15] 10OOjs-UI, 10Living-Style-Guide, 7Design, 5Patch-For-Review: Apply typography, space, and layout styles - https://phabricator.wikimedia.org/T95661#1223358 (10Prtksxna) >>! In T95661#1222675, @violetto wrote: > @Prtksxna, I fixed some issues. [[ https://github.com/munmay/layoutTemplates/tree/gh-pages | Chec... [06:58:03] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Special Character replaces the whole gallery when the character inserter is opened while selecting the gallery - https://phabricator.wikimedia.org/T62802#1223416 (10matmarex) [06:58:32] 10VisualEditor, 10VisualEditor-EditingTools: Special character insertion replaces selected content (including focusable nodes) - https://phabricator.wikimedia.org/T62802#1223419 (10matmarex) [06:59:55] 10VisualEditor, 10VisualEditor-ContentEditable: Gallery edit still not easy - https://phabricator.wikimedia.org/T96647#1223432 (10matmarex) [06:59:56] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-Plugins: VisualEditor: Support galleries - https://phabricator.wikimedia.org/T45037#1223433 (10matmarex) [07:05:04] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor:The gallery inspector adds a newline while opening up a gallery - https://phabricator.wikimedia.org/T62310#1223491 (10matmarex) No longer occurs, probably fixed a long time ago. {F128164} [07:05:14] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor:The gallery inspector adds a newline while opening up a gallery - https://phabricator.wikimedia.org/T62310#1223492 (10matmarex) 5Open>3Resolved [07:18:18] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-Plugins: VisualEditor: Support galleries - https://phabricator.wikimedia.org/T45037#1223534 (10matmarex) [07:18:19] 10VisualEditor, 10MediaWiki-Interface, 10Possible-Tech-Projects: Rearranging the order of image (link)s in galleries via drag and drop (AJAXy) - https://phabricator.wikimedia.org/T13500#1223533 (10matmarex) [07:21:57] 10VisualEditor, 10VisualEditor-EditingTools: Special character insertion replaces selected content (including focusable nodes) - https://phabricator.wikimedia.org/T62802#1223542 (10matmarex) According to T60118 this is intentional, but I think we should reconsider, especially given {T65227}. WikiEditor's speci... [07:58:47] 10MediaWiki-ResourceLoader, 10WikiEditor: Request amendment of Bangla character set in WikiEditor - https://phabricator.wikimedia.org/T96494#1223586 (10AuFCL) >>! In T96494#1223353, @Nasirkhan wrote: > Added 2 characters and changed the order at https://en.wikisource.org/wiki/User:AuFCL/specialcharacters.json... [08:05:29] 10TemplateData, 6Community-Liaison, 10WMF-Product-Strategy: Please make me a list of commonly used templates in Wikipedia articles - https://phabricator.wikimedia.org/T96323#1223591 (10Whatamidoing-WMF) @rdicerb: This has nothing to do with the Qualtrics survey. This has to do with the inconvenience of add... [08:06:06] 10MediaWiki-ResourceLoader, 10WikiEditor: Request amendment of Bangla character set in WikiEditor - https://phabricator.wikimedia.org/T96494#1223595 (10Hrishikes) Ah, I see that you have already noticed the syntax problem. I had already pinged you not knowing that you have noticed. I am no expert, but I notice... [08:18:10] 10MediaWiki-ResourceLoader, 10WikiEditor: Request amendment of Bangla character set in WikiEditor - https://phabricator.wikimedia.org/T96494#1223620 (10Hrishikes) @AuFCL If the font does not matter, the characters zwj and zwnj can be copy-pasted from the Arabic portion, is it not? [08:39:45] 10VisualEditor, 10VisualEditor-EditingTools: Special characters menu in VisualEditor does not include en dash - https://phabricator.wikimedia.org/T95819#1223644 (10matmarex) a:3matmarex [08:40:58] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Provide tooltips for each item in the Special Character inserter so users can tell items from each other - https://phabricator.wikimedia.org/T70425#1223647 (10matmarex) a:3matmarex [08:41:58] 10VisualEditor, 10VisualEditor-EditingTools, 10WikiEditor: Special character insertion replaces selected content (including focusable nodes) - https://phabricator.wikimedia.org/T62802#1223649 (10matmarex) [09:11:03] (03CR) 10Physikerwelt: LaTeX to Mathematica Function Translation PHP Regex replacement of LaTeX function input into corresponding Mathematica function (031 comment) [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/203954 (owner: 10Sharmaans) [09:12:06] (03Abandoned) 10Ori.livneh: [WIP] Reduce reliance of IndexValueStore hashing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192698 (owner: 10Ori.livneh) [09:12:11] (03Abandoned) 10Ori.livneh: [WIP] Reduce reliance of IndexValueStore hashing [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192694 (owner: 10Ori.livneh) [09:15:08] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Provide tooltips for each item in the Special Character inserter so users can tell items from each other - https://phabricator.wikimedia.org/T70425#1223739 (10matmarex) For VisualEditor-MediaWiki, we're now reusing the special characters list from the... [09:18:43] (03CR) 10Esanders: Add removable flag to meta items (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205291 (https://phabricator.wikimedia.org/T96528) (owner: 10Esanders) [09:26:30] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki: Special characters menu in VisualEditor does not include en dash - https://phabricator.wikimedia.org/T95819#1223767 (10matmarex) [09:27:00] (03PS1) 10Bartosz Dziewoński: ve.ui.SpecialCharacterDialog: Allow encapsulation of selected content [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205556 (https://phabricator.wikimedia.org/T65227) [09:27:02] (03PS1) 10Bartosz Dziewoński: ve.ui.SpecialCharacterPage: Allow providing a tooltip for characters [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205557 (https://phabricator.wikimedia.org/T70425) [09:27:18] (03PS1) 10Bartosz Dziewoński: Allow special characters with tooltip or that encapsulate text [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/205558 (https://phabricator.wikimedia.org/T65227) [09:28:18] (03PS3) 10Esanders: Add removable flag to meta items [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205291 (https://phabricator.wikimedia.org/T96528) [09:29:21] (03CR) 10Esanders: "/me counters that there is no such bug, just that the test case you wrote was wrong. MetaList test still failing." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205291 (https://phabricator.wikimedia.org/T96528) (owner: 10Esanders) [09:31:48] (03CR) 10jenkins-bot: [V: 04-1] Add removable flag to meta items [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205291 (https://phabricator.wikimedia.org/T96528) (owner: 10Esanders) [09:32:20] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki, 5Patch-For-Review: Special characters menu in VisualEditor does not include en dash - https://phabricator.wikimedia.org/T95819#1223806 (10matmarex) VisualEditor-MediaWiki is now reusing the list of characters from the wikitext editor, b... [10:04:01] (03PS1) 10Bartosz Dziewoński: ve.ui.WhitespacePreservingTextInputWidget: Trim whitespace in input [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205567 (https://phabricator.wikimedia.org/T74561) [10:09:10] 10VisualEditor, 10VisualEditor-ContentEditable: VisualEditor: Inserting Whitespaces at the end of a preformatted text takes the cursor out of the pre tags. - https://phabricator.wikimedia.org/T70455#1223914 (10matmarex) 5Open>3Resolved a:3matmarex I think my recent change 71ceef7dbb6ba95c84987c5c7ffbfeca... [10:10:12] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki, 5Patch-For-Review: Special characters menu in VisualEditor does not include en dash - https://phabricator.wikimedia.org/T95819#1223922 (10Krenair) It wasn't accidental... these characters (7 of them, I think it was?) would not work as t... [10:17:06] 10VisualEditor: Link editor autocomplete won't let me add a space at the end - https://phabricator.wikimedia.org/T95646#1223937 (10matmarex) Fixed by f696ef7da6874398a99bed138264800b70ea0aae. [10:17:49] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Links: Link editor autocomplete won't let me add a space at the end - https://phabricator.wikimedia.org/T95646#1223938 (10matmarex) 5Open>3Resolved p:5Triage>3Unbreak! a:3Esanders [10:18:02] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Links: Link editor autocomplete won't let me add a space at the end - https://phabricator.wikimedia.org/T95646#1196753 (10matmarex) [10:18:03] 10VisualEditor, 10VisualEditor-MediaWiki-Links: When adding an internal link in VisualEditor, space character is not accepted - https://phabricator.wikimedia.org/T95875#1223943 (10matmarex) [10:18:52] 10VisualEditor, 10VisualEditor-MediaWiki-Links: Remove whitespace from user-inputted links - https://phabricator.wikimedia.org/T89013#1223946 (10matmarex) [10:18:54] 10VisualEditor, 10VisualEditor-Links, 10VisualEditor-MediaWiki-Links, 5Patch-For-Review: Trim whitespace in LinkTargetInputWidget - https://phabricator.wikimedia.org/T94498#1223947 (10matmarex) [10:21:22] 10VisualEditor, 3Editing Department 2014/15 Q4 blockers: [[Mediawiki:Badtitletext]] being added to articles - https://phabricator.wikimedia.org/T93045#1223953 (10matmarex) [10:21:24] 10VisualEditor, 10VisualEditor-Links, 10VisualEditor-MediaWiki-Links, 5Patch-For-Review: Trim whitespace in LinkTargetInputWidget - https://phabricator.wikimedia.org/T94498#1223949 (10matmarex) 5Resolved>3Open Good thing we fixed the horrible breakage (for which we had T95646 filed in the meantime), bu... [10:23:09] 10VisualEditor: "Often used" special characters not displayed on pl.wikipedia despite configuration - https://phabricator.wikimedia.org/T95856#1223957 (10matmarex) 5Open>3Invalid a:3matmarex This has fixed itself. [10:25:19] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki, 5Patch-For-Review: Special characters menu in VisualEditor does not include en dash - https://phabricator.wikimedia.org/T95819#1223965 (10matmarex) The dashes would, as they don't encapsulate anything, they only had tooltips defined. I... [10:26:20] 10VisualEditor, 10VisualEditor-DataModel: VisualEditor: HTML non-breaking spaces ( ) converted to ",[object Object], ,[object Object]," - https://phabricator.wikimedia.org/T60282#1223969 (10matmarex) Last report a year ago; presumably this was a Parsoid issue that was since fixed? [10:27:53] 10VisualEditor, 10VisualEditor-DataModel: VisualEditor: HTML non-breaking spaces ( ) converted to ",[object Object], ,[object Object]," - https://phabricator.wikimedia.org/T60282#1223971 (10matmarex) [10:43:45] (03PS1) 10Esanders: Manually set starting progress to 0 incase stylsheets are slow to apply [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/205577 (https://phabricator.wikimedia.org/T93964) [10:44:23] 10VisualEditor, 10VisualEditor-ContentEditable: Make non-breakable spaces visible in the editor - https://phabricator.wikimedia.org/T96666#1223998 (10matmarex) 3NEW [10:44:42] 10VisualEditor, 10VisualEditor-ContentEditable: VisualEditor: Ctrl-Space to insert a non-breaking space (NBSP), and a way to see the difference - https://phabricator.wikimedia.org/T53045#1224005 (10matmarex) [10:44:43] 10VisualEditor, 10VisualEditor-ContentEditable: Make non-breakable spaces visible in the editor - https://phabricator.wikimedia.org/T96666#1224006 (10matmarex) [10:45:03] 10VisualEditor, 10VisualEditor-ContentEditable: Make non-breakable spaces visible in the editor - https://phabricator.wikimedia.org/T96666#1223998 (10matmarex) [10:45:04] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Add non-breaking space (nbsp) to the "special character" dialog - https://phabricator.wikimedia.org/T70429#1224007 (10matmarex) [10:46:43] Krinkle|detached, is this a problem with resource loader https://gerrit.wikimedia.org/r/#/c/205577/ ? [10:49:41] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Add non-breaking space (nbsp) to the "special character" dialog - https://phabricator.wikimedia.org/T70429#1224015 (10Esanders) Or you could somehow annotate the whole word as nowrap. Arguably 100 °C would be clearer than 100 °C [10:53:04] 10VisualEditor, 10VisualEditor-ContentEditable: Make non-breaking spaces (nbsp) visible in VisualEditor - https://phabricator.wikimedia.org/T96666#1224016 (10matmarex) [10:55:00] 10VisualEditor, 10VisualEditor-ContentEditable: VisualEditor: Ctrl-Space to insert a non-breaking space (NBSP), and a way to see the difference - https://phabricator.wikimedia.org/T53045#1224019 (10matmarex) [10:55:12] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Add non-breaking space (nbsp) to the "special character" dialog - https://phabricator.wikimedia.org/T70429#743220 (10matmarex) [10:55:29] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Add non-breaking space (nbsp) to the "special character" dialog - https://phabricator.wikimedia.org/T70429#743220 (10matmarex) [10:56:00] 10VisualEditor, 10VisualEditor-ContentEditable: Make non-breaking spaces (nbsp) visible in VisualEditor - https://phabricator.wikimedia.org/T96666#1224027 (10matmarex) [10:56:01] 10VisualEditor, 10VisualEditor-EditingTools: Leading white spaces should be highlighted and converted to   or something - https://phabricator.wikimedia.org/T78137#1224026 (10matmarex) [11:04:58] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki, 10Parsoid, 7Design: Spaces at the start of a paragraph aren't very obvious - https://phabricator.wikimedia.org/T68628#1224029 (10matmarex) {T78137} sounds like an interesting approach. I tested now and it seems like the leading sp... [11:06:25] 10VisualEditor: [Regression pre-wmf21] ve-ui-mwCategoryPopupWidget-content element is misaligned - https://phabricator.wikimedia.org/T92354#1224032 (10matmarex) 5stalled>3Resolved [11:08:00] (03CR) 10Esanders: [C: 04-1] WIP: walkDomTree function for document-order traversal (036 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204985 (owner: 10Divec) [11:16:36] 10VisualEditor: VisualEditor: Removing or breaking HTML tags ( and tags vanish) - https://phabricator.wikimedia.org/T62585#1224038 (10Aklapper) [11:18:52] 10VisualEditor, 10VisualEditor-ContentEditable: Numbered list with images is not preserved after Save - https://phabricator.wikimedia.org/T75777#1224040 (10Aklapper) [11:22:52] (03PS1) 10Divec: Fix getNodeAndOffset for block slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205580 (https://phabricator.wikimedia.org/T96357) [11:24:52] (03CR) 10jenkins-bot: [V: 04-1] Fix getNodeAndOffset for block slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205580 (https://phabricator.wikimedia.org/T96357) (owner: 10Divec) [11:25:47] 10VisualEditor, 5Patch-For-Review: Select all produces strange offsets - https://phabricator.wikimedia.org/T96357#1224051 (10dchan) Change 205580 fixes the view selection. But there's a separate issue that the model selection is not in fact correct: a CTRL+A selection should start at DM position 1, not positio... [11:28:02] 10VisualEditor, 10VisualEditor-ContentEditable: Calculated highlights for focusable nodes sometimes extend outside the bounds of the node (CSS positioning with overflow: hidden) - https://phabricator.wikimedia.org/T96667#1224052 (10matmarex) 3NEW [11:28:20] 10VisualEditor, 10VisualEditor-ContentEditable: VisualEditor: Reconsider CSS content munging - https://phabricator.wikimedia.org/T52577#1224063 (10matmarex) Indeed we did, this was done by the invaluable Ed in ee5b69772963c5d3f17b15742023cf33fc5dd48a. [11:28:32] 10VisualEditor, 10VisualEditor-ContentEditable: VisualEditor: CSS munging causing absolutely-positioned
s used to create pie charts(!) to break - https://phabricator.wikimedia.org/T55226#588509 (10matmarex) [11:28:33] 10VisualEditor, 10VisualEditor-ContentEditable: VisualEditor: CSS munging causing CSS image cropping template {{Css Image Crop}} to display wrong portion of image - https://phabricator.wikimedia.org/T53166#538617 (10matmarex) [11:28:35] 10VisualEditor, 10VisualEditor-ContentEditable: VisualEditor: CSS munging causing absolutely-positioned chess diagrams(?) to break - https://phabricator.wikimedia.org/T53932#1224069 (10matmarex) [11:28:37] 10VisualEditor, 10VisualEditor-ContentEditable: VisualEditor: Reconsider CSS content munging - https://phabricator.wikimedia.org/T52577#1224064 (10matmarex) 5Open>3Resolved a:3Esanders [11:29:13] 10VisualEditor, 10VisualEditor-ContentEditable: VisualEditor: CSS munging causing CSS image cropping template {{Css Image Crop}} to display wrong portion of image - https://phabricator.wikimedia.org/T53166#538617 (10matmarex) The issue as filed was resolved long time ago (see parent bug T52577), I filed T96667... [11:29:22] 10VisualEditor, 10VisualEditor-ContentEditable: VisualEditor: CSS munging causing CSS image cropping template {{Css Image Crop}} to display wrong portion of image - https://phabricator.wikimedia.org/T53166#1224081 (10matmarex) 5Open>3Resolved [11:29:26] 10VisualEditor, 10VisualEditor-ContentEditable: VisualEditor: CSS munging causing absolutely-positioned
s used to create pie charts(!) to break - https://phabricator.wikimedia.org/T55226#588509 (10matmarex) The issue as filed was resolved long time ago (see parent bug T52577), I filed T96667 to track the... [11:29:36] 10VisualEditor, 10VisualEditor-ContentEditable: VisualEditor: CSS munging causing absolutely-positioned
s used to create pie charts(!) to break - https://phabricator.wikimedia.org/T55226#1224086 (10matmarex) 5Open>3Resolved [11:29:39] 10VisualEditor, 5Patch-For-Review: Select all produces an incorrect DOM range - https://phabricator.wikimedia.org/T96357#1224087 (10dchan) [11:31:01] 10VisualEditor, 5Patch-For-Review: Select all produces an incorrect DOM range when the page ends in a block slug - https://phabricator.wikimedia.org/T96357#1215004 (10dchan) [11:43:35] 10VisualEditor, 10VisualEditor-MediaWiki-Templates: templatedata editor may insert spurious whitespace (and tags) that impacts template rendering? - https://phabricator.wikimedia.org/T96537#1224106 (10Aklapper) [11:47:38] 10VisualEditor, 10VisualEditor-EditingTools: When inserting a comment in VisualEditor, selected text should be transformed into text of comment - https://phabricator.wikimedia.org/T96190#1224113 (10Aklapper) p:5Triage>3Lowest [11:51:27] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-Links, 5Patch-For-Review: VisualEditor: A link can span whitespace but won't be displayed so cannot be edited or noticed - https://phabricator.wikimedia.org/T39835#1224126 (10matmarex) >>! In T39835#1170062, @NicoV wrote: > There's also... [11:52:18] 10VisualEditor, 3Editing Department 2014/15 Q4 blockers: Link with as only label - https://phabricator.wikimedia.org/T95730#1198872 (10matmarex) https://fr.wikipedia.org/w/index.php?title=Saint-Florent-des-Bois&diff=prev&oldid=113366483 [11:52:32] 10VisualEditor: Long Help text (e.g. in Russian) creates linebreak between "question mark" Icon and text - https://phabricator.wikimedia.org/T89112#1224130 (10Aklapper) @Sunpriat: I fail to reproduce this (horizontal size is always enough to not trigger a linebreak), no matter which zoom level I try in Firefox 3... [11:52:47] 10VisualEditor, 10VisualEditor-Links, 10VisualEditor-MediaWiki-Links: Trim whitespace in LinkTargetInputWidget - https://phabricator.wikimedia.org/T94498#1224135 (10matmarex) [11:54:52] 10VisualEditor, 10VisualEditor-DataModel, 3Editing Department 2014/15 Q4 blockers: added on XX Wikipedia - https://phabricator.wikimedia.org/T95708#1224136 (10matmarex) Variants with just ``: https://fr.wikipedia.org/w/index.php?title=Chip-Seq&oldid=113950851 ` 10VisualEditor: [Regression-pre-1.26wmf2]: Link inspector-disabled 'Open' button can be clicked - https://phabricator.wikimedia.org/T95790#1224138 (10matmarex) [12:06:45] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-DataModel: Select all + overwrite fails on a document that starts and ends with a block slug - https://phabricator.wikimedia.org/T96671#1224142 (10dchan) 3NEW [12:07:03] 10VisualEditor, 10VisualEditor-ContentEditable, 3Editing Department 2014/15 Q4 blockers: More corruption (unknown source) - https://phabricator.wikimedia.org/T96589#1224151 (10matmarex) There seem to be a few distinct issues. ---- https://fr.wikipedia.org/w/index.php?title=La_route_M%C3%A9diterran%C... [12:14:04] 10VisualEditor, 10VisualEditor-ContentEditable, 3Editing Department 2014/15 Q4 blockers: More corruption (unknown source) - https://phabricator.wikimedia.org/T96589#1224157 (10NicoV) As I recall, the last one was a newly created article with VE with each line begin inside ..., s... [12:15:34] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-DataModel: Select all + overwrite fails on a document that starts and ends with a block slug - https://phabricator.wikimedia.org/T96671#1224160 (10dchan) Note we *need* these block slugs in the DOM to hold the selection in some cases. This is bec... [12:16:27] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-DataModel: Select all + overwrite fails on a document that starts and ends with a block slug - https://phabricator.wikimedia.org/T96671#1224163 (10dchan) [12:18:09] 10VisualEditor, 5Patch-For-Review: Select all produces an incorrect DOM range when the page ends in a block slug - https://phabricator.wikimedia.org/T96357#1224173 (10dchan) See T96671 for the related issue. [12:23:31] 10VisualEditor, 10VisualEditor-MediaWiki, 10Parsoid: Space before colon rendered as when wrapped in a reference - https://phabricator.wikimedia.org/T96673#1224179 (10matmarex) 3NEW [12:24:19] 10VisualEditor, 10VisualEditor-ContentEditable, 3Editing Department 2014/15 Q4 blockers: More corruption (unknown source) - https://phabricator.wikimedia.org/T96589#1224190 (10matmarex) 5Open>3Invalid a:3matmarex I managed to reproduce the one with ` ` consistently, filed as T96673.... [12:25:16] (03PS1) 10Esanders: Strip language annotations on external import [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/205585 (https://phabricator.wikimedia.org/T95708) [12:25:48] 10VisualEditor, 10VisualEditor-DataModel, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review: added on XX Wikipedia - https://phabricator.wikimedia.org/T95708#1224204 (10Esanders) Couldn't reproduce this locally, but will add language annotations to the external import blacklist... [12:26:37] (03CR) 10Bartosz Dziewoński: "Probably also fixes T96101?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/205585 (https://phabricator.wikimedia.org/T95708) (owner: 10Esanders) [12:34:40] 10OOjs-UI: ToggleWidget should be an abstract superclass, line InputWidget, not a mixin - https://phabricator.wikimedia.org/T96674#1224211 (10matmarex) 3NEW a:3matmarex [12:45:54] 10VisualEditor, 10VisualEditor-DataModel, 3Editing Department 2014/15 Q4 blockers: added on ZZ Wikipedia - https://phabricator.wikimedia.org/T96101#1224228 (10Esanders) [12:45:55] 10VisualEditor, 10VisualEditor-DataModel, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review: added on XX Wikipedia - https://phabricator.wikimedia.org/T95708#1224229 (10Esanders) [12:46:05] 10VisualEditor, 10VisualEditor-DataModel, 3Editing Department 2014/15 Q4 blockers: added on ZZ Wikipedia - https://phabricator.wikimedia.org/T96101#1208284 (10Esanders) Same cause, marking as duplicate. [12:46:24] (03CR) 10Esanders: "Marked as duplicate" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/205585 (https://phabricator.wikimedia.org/T95708) (owner: 10Esanders) [13:02:55] (03PS1) 10Bartosz Dziewoński: ButtonWidget: Remove pointless #isHyperlink property [oojs/ui] - 10https://gerrit.wikimedia.org/r/205592 [13:02:57] (03PS1) 10Bartosz Dziewoński: ButtonWidget: Remove href to make unclickable when disabled [oojs/ui] - 10https://gerrit.wikimedia.org/r/205593 (https://phabricator.wikimedia.org/T93004) [13:11:31] (03PS2) 10Divec: Fix getNodeAndOffset for block slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205580 (https://phabricator.wikimedia.org/T96357) [13:15:50] (03PS1) 10Bartosz Dziewoński: ButtonInputWidget: Don't double-mixin FlaggedElement [oojs/ui] - 10https://gerrit.wikimedia.org/r/205597 [13:19:52] MatmaRex, comment on https://gerrit.wikimedia.org/r/#/c/198565/ [13:31:27] 10Citoid, 6Services: bad curl causes citoid to respond with a traceback - https://phabricator.wikimedia.org/T95898#1224331 (10mobrovac) a:3mobrovac [13:34:50] (03PS1) 10Bartosz Dziewoński: [BREAKING CHANGE] Convert ToggleWidget from a mixin to an abstract class [oojs/ui] - 10https://gerrit.wikimedia.org/r/205601 (https://phabricator.wikimedia.org/T96674) [13:39:28] (03PS7) 10Bartosz Dziewoński: [BREAKING CHANGE] MenuLayout: Reimplement without inline styles [oojs/ui] - 10https://gerrit.wikimedia.org/r/198565 [13:39:29] edsanders: done [13:44:06] 10OOjs-UI: Rename GroupWidget, ItemWidget, and ToggleWidget to *Mixin. - https://phabricator.wikimedia.org/T94198#1224359 (10matmarex) Alternative to this: {T91565} + {T96674}. [13:59:19] edsanders: It's possible in theory, but I suspect something else is going on. [13:59:20] The browser is optimising paints [13:59:38] Can you reproduce it without the inline style somewhat reliably? If so, try console.log'ing the css width value [13:59:53] I reckon maybe then it will be gone, because the compute style triggers a repaint [14:00:44] if you put a debug point, it reports no styles [14:01:49] the jQuery animation code would get the width anyway [14:02:40] (03PS1) 10Divec: Filibuster: fix stringification errors [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205604 [14:02:46] 10VisualEditor, 10RESTBase, 6operations, 7Performance: Set up an API base path for REST and action APIs - https://phabricator.wikimedia.org/T95229#1224417 (10Anomie) The `/api/{name}/` pattern seems ok, although I still find "v1" to be a strange name for restbase. [14:06:00] (03PS1) 10Bartosz Dziewoński: Remove ancient bad copy-paste documentation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/205605 [14:08:24] (03CR) 10Divec: "Done^6" (036 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204985 (owner: 10Divec) [14:08:53] (03PS6) 10Divec: WIP: walkDomTree function for document-order traversal [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204985 [14:17:23] 10VisualEditor, 10RESTBase, 6operations, 7Performance: Set up an API base path for REST and action APIs - https://phabricator.wikimedia.org/T95229#1224475 (10mobrovac) >>! In T95229#1224417, @Anomie wrote: > The `/api/{name}/` pattern seems ok, although I still find "v1" to be a strange name for restbase.... [14:17:37] (03CR) 10Esanders: [C: 032] Filibuster: fix stringification errors [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205604 (owner: 10Divec) [14:20:35] 10VisualEditor, 10RESTBase, 6operations, 7Performance: Set up an API base path for REST and action APIs - https://phabricator.wikimedia.org/T95229#1224477 (10Anomie) >>! In T95229#1224475, @mobrovac wrote: > I don't see //v1// as the //name for RESTBase//, but rather as the //version of the content API//.... [14:25:25] (03Merged) 10jenkins-bot: Filibuster: fix stringification errors [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205604 (owner: 10Divec) [14:25:30] (03PS1) 10Bartosz Dziewoński: ve.ce.MWEntityNode: Show whitespace characters, like in ve.ce.TextNode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/205611 [14:51:24] 10VisualEditor, 10RESTBase, 6operations, 7Performance: Set up an API base path for REST and action APIs - https://phabricator.wikimedia.org/T95229#1224521 (10BBlack) Where are we going to place non-restbase services in this URL path schema relative to restbase? I assume "page" isn't the name of restbase e... [14:55:13] 10VisualEditor, 10RESTBase, 6operations, 7Performance: Set up an API base path for REST and action APIs - https://phabricator.wikimedia.org/T95229#1224530 (10mobrovac) >>! In T95229#1224477, @Anomie wrote: > Above Gabriel claimed "v1" was the name. If it's the version then it's not following the `/api/{nam... [15:04:39] 10VisualEditor, 10RESTBase, 6operations, 7Performance: Set up an API base path for REST and action APIs - https://phabricator.wikimedia.org/T95229#1224566 (10mobrovac) >>! In T95229#1224521, @BBlack wrote: > Where are we going to place non-restbase services in this URL path schema relative to restbase? I... [15:10:22] (03PS1) 10Bartosz Dziewoński: ve.ce.TextNode: Do "meaningful whitespace characters" first [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205618 [15:10:24] (03PS1) 10Bartosz Dziewoński: [POC] Show non-breaking spaces (nbsp) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205619 (https://phabricator.wikimedia.org/T96666) [15:11:37] edsanders: thoughts on https://gerrit.wikimedia.org/r/205619 ? [15:18:56] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-Tables: VisualEditor: "Insert table" tool should be (also?) in the "Table" menu, not (or in addition to?) "Insert" menu - https://phabricator.wikimedia.org/T75212#1224665 (10MarkAHershberger) My client asked about this and I told her "That's how it... [16:31:14] 10VisualEditor, 10MediaWiki-General-or-Unknown: The visual editor silently alters non-breaking spaces into normal spaces - https://phabricator.wikimedia.org/T96701#1224837 (10Nnemo) 3NEW [16:32:57] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: Tech debt: Move the mobile css files to core - https://phabricator.wikimedia.org/T96703#1224852 (10Mooeypoo) 3NEW [16:35:44] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: Tech debt: Clean up "minerva" folder theme in VE-mw - https://phabricator.wikimedia.org/T96704#1224862 (10Mooeypoo) 3NEW [16:41:54] 10VisualEditor, 10VisualEditor-ContentEditable, 5Patch-For-Review: Make non-breaking spaces (nbsp) visible in VisualEditor - https://phabricator.wikimedia.org/T96666#1224892 (10Nnemo) For me, making the non-breaking spaces visible is not a prerequisite to being able to insert them. These are two different t... [16:43:36] 10Citoid: French special characters not represented correctly - https://phabricator.wikimedia.org/T95833#1224909 (10gpaumier) It looks like this isn't limited to French characters. [[ https://en.wikipedia.org/w/index.php?diff=657496613 | In another diff]], the title of the page (a page from the [[ http://www.kei... [16:51:50] (03PS2) 10Jforrester: ce.Document#getNodeAndOffset: Document better ahead of cleanup [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205523 (owner: 10Divec) [16:51:58] (03CR) 10Jforrester: [C: 032] ce.Document#getNodeAndOffset: Document better ahead of cleanup [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205523 (owner: 10Divec) [16:52:27] (03CR) 10Jforrester: [C: 032] Manually set starting progress to 0 incase stylsheets are slow to apply [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/205577 (https://phabricator.wikimedia.org/T93964) (owner: 10Esanders) [16:52:48] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-Performance, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-22_(1.26wmf3): Progress bar moves backwards sometimes - https://phabricator.wikimedia.org/T93964#1224945 (10Jdforrester-WMF) 5Open>3Resolved [16:54:05] 10VisualEditor, 10VisualEditor-ContentEditable: More corruption (unknown source) - https://phabricator.wikimedia.org/T96589#1224968 (10Jdforrester-WMF) [16:54:30] 10VisualEditor, 10VisualEditor-DataModel: added on ZZ Wikipedia - https://phabricator.wikimedia.org/T96101#1224971 (10Jdforrester-WMF) [16:54:58] (03CR) 10Esanders: "It's not bad. I'd prefer it if was styled differently, maybe even had a tooltip, but that would require more work certainly." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205619 (https://phabricator.wikimedia.org/T96666) (owner: 10Bartosz Dziewoński) [16:55:03] (03PS2) 10Jforrester: Strip language annotations on external import [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/205585 (https://phabricator.wikimedia.org/T95708) (owner: 10Esanders) [16:56:27] (03CR) 10Esanders: "The problem with all of these is that they look 'wrong' in the editor unless you know what they are, so the people are likely to want to c" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205619 (https://phabricator.wikimedia.org/T96666) (owner: 10Bartosz Dziewoński) [16:57:36] (03CR) 10jenkins-bot: [V: 04-1] Strip language annotations on external import [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/205585 (https://phabricator.wikimedia.org/T95708) (owner: 10Esanders) [16:58:23] (03CR) 10Jforrester: [C: 031] "Meh. The problem is pasting the parent/language setting is arguably the right thing to do if it's different from the content language (e.g" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/205585 (https://phabricator.wikimedia.org/T95708) (owner: 10Esanders) [17:00:05] (03CR) 10Jforrester: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/205585 (https://phabricator.wikimedia.org/T95708) (owner: 10Esanders) [17:05:19] (03Merged) 10jenkins-bot: ce.Document#getNodeAndOffset: Document better ahead of cleanup [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205523 (owner: 10Divec) [17:05:21] (03CR) 10jenkins-bot: [V: 04-1] Manually set starting progress to 0 incase stylsheets are slow to apply [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/205577 (https://phabricator.wikimedia.org/T93964) (owner: 10Esanders) [17:06:40] (03CR) 10Jforrester: [C: 032] "…" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/205577 (https://phabricator.wikimedia.org/T93964) (owner: 10Esanders) [17:08:41] (03Merged) 10jenkins-bot: Manually set starting progress to 0 incase stylsheets are slow to apply [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/205577 (https://phabricator.wikimedia.org/T93964) (owner: 10Esanders) [17:17:46] (03CR) 10Esanders: [C: 031] "Looks fine, but breaking change, so will wait until we want to release this." [oojs/ui] - 10https://gerrit.wikimedia.org/r/198565 (owner: 10Bartosz Dziewoński) [17:27:19] 10TemplateData, 6Community-Liaison, 10WMF-Product-Strategy: Please make me a list of commonly used templates in Wikipedia articles - https://phabricator.wikimedia.org/T96323#1225013 (10Ironholds) Okay, this is without a doubt one of the slowest and most inefficient database structures _possible_ for asking f... [17:27:43] 10Citoid: French special characters not represented correctly - https://phabricator.wikimedia.org/T95833#1225015 (10mobrovac) >>! In T95833#1224909, @gpaumier wrote: > Am I correct in assuming this is the same issue? Yup, the content is not utf8-encoded. Thnx for reporting! [17:28:28] 10MediaWiki-ResourceLoader, 10WikiEditor: Request amendment of Bangla character set in WikiEditor - https://phabricator.wikimedia.org/T96494#1225016 (10Hrishikes) Fixed the characters. Not sure about whatever AuFCL meant by legality or validity of JSON format. Language part is over, however. [17:35:25] 10Citoid: UTF8 characters not represented correctly - https://phabricator.wikimedia.org/T95833#1225029 (10Jdforrester-WMF) p:5Triage>3Unbreak! [17:35:36] 10Citoid: UTF8 characters not represented correctly - https://phabricator.wikimedia.org/T95833#1201461 (10Jdforrester-WMF) Argh. [17:45:33] 10MediaWiki-ResourceLoader, 10WikiEditor: Request amendment of Bangla character set in WikiEditor - https://phabricator.wikimedia.org/T96494#1225063 (10Hrishikes) {F149140} [17:46:37] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-Tables: Support sortable columns in tables - https://phabricator.wikimedia.org/T95189#1225064 (10Jdforrester-WMF) p:5Triage>3Normal [18:13:31] 10VisualEditor, 10RESTBase, 6operations, 7Performance: Set up an API base path for REST and action APIs - https://phabricator.wikimedia.org/T95229#1225095 (10mobrovac) After a heated IRC discussion, there is consensus around the fact that there should be a 1:1 mapping between `name` in `/api/{name}` and ba... [18:22:46] 10VisualEditor, 10RESTBase, 6operations, 7Performance: Set up an API base path for REST and action APIs - https://phabricator.wikimedia.org/T95229#1225111 (10GWicke) >>! In T95229#1225095, @mobrovac wrote: > After a heated IRC discussion, there is consensus around the fact that there should be a 1:1 mappin... [18:24:40] who do I ask about how to configure MwFeedback [18:24:53] * hexmode google some more while hoping for an anwer [18:25:43] I suspect I have to feed it into the global config object [18:26:01] legoktm: ping? [18:26:08] hi [18:26:48] legoktm: so, is there a pointer on how to config the MwFeedback thing? Just read up on config? [18:27:06] is this the javascript thing? [18:27:10] yes [18:27:47] is there someone else I should ask? [18:28:06] hexmode: https://doc.wikimedia.org/mediawiki-core/master/js/#!/api/mw.Feedback [18:28:16] hexmode: The code should self-document? [18:28:18] I really don't know much more about it than that [18:28:26] heh [18:28:29] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 7Technical-Debt: Tech debt: Move the mobile css files to core - https://phabricator.wikimedia.org/T96703#1225119 (10Aklapper) [18:28:30] I think the "This feature works with classic MediaWiki pages and is not compatible with LiquidThreads or Flow." comment is wrong though [18:28:35] * hexmode love self documentation [18:28:43] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 7Technical-Debt: Tech debt: Clean up "minerva" folder theme in VE-mw - https://phabricator.wikimedia.org/T96704#1225120 (10Aklapper) [18:28:59] legoktm: tyvm, I'll poke around :) [18:29:21] 10VisualEditor: Per-wiki customizable drop down menu for templates - https://phabricator.wikimedia.org/T96710#1225122 (10Elitre) 3NEW [18:30:03] legoktm: No, it doesn't work with LQT yet, I think. [18:30:22] legoktm: But ISTR that superm401 fixed Flow so it does with that. I think. [18:30:46] https://phabricator.wikimedia.org/T91805 is fixed [18:31:26] 10VisualEditor: VE silently alters non-breaking spaces into normal spaces - https://phabricator.wikimedia.org/T96701#1225129 (10Aklapper) [18:32:00] 10VisualEditor: VE silently alters non-breaking spaces into normal spaces - https://phabricator.wikimedia.org/T96701#1224837 (10Aklapper) Where exactly is this nbsp entered? Anywhere in the text? Which browser is this about? [18:40:50] * Krinkle yields from mental event loop and looks at James_F [18:41:10] Path forward on https://phabricator.wikimedia.org/T52513 (round-trip testing) ? [18:41:30] 10OOjs-UI: Turn on type checking for OO.ui.infuse. - https://phabricator.wikimedia.org/T90929#1225141 (10Krinkle) [18:41:31] 10OOjs: Static methods can't know which class they belong to or which class they're called with - https://phabricator.wikimedia.org/T89721#1225138 (10Krinkle) 5Open>3stalled [18:46:44] Krinkle: i was looking at the VE feedback page, notice this in NicoV's messages. [18:46:47] Une demande multi-origines (Cross-Origin Request) a été bloquée : la politique « Same Origin » ne permet pas de consulter la ressource distante située sur https://rest.wikimedia.org/en.wikipedia.org/v1/page/html/Axial_Seamount [18:46:54] looks like a CORS action failing... [18:47:50] i think he might be behind one of those broken corporate firewals that strip cors headers. ? [18:47:59] i think he also had trouble with MMV... [18:50:43] but you guys were thinking about moving that on a single domain anyways i seem to remember [18:54:47] (03PS1) 10Mobrovac: Update to service-template-node v0.1.3 [services/citoid] - 10https://gerrit.wikimedia.org/r/205645 [18:57:38] thedj: Yes, for different reasons [18:57:40] (DNS slowness) [18:59:39] ok. this would be an extra bonus reason i guess [18:59:54] (03CR) 10Mobrovac: [C: 032 V: 032] "Self-merging as this patch contains important security updates." [services/citoid] - 10https://gerrit.wikimedia.org/r/205645 (owner: 10Mobrovac) [19:00:56] 10Citoid, 6Services: bad curl causes citoid to respond with a traceback - https://phabricator.wikimedia.org/T95898#1225151 (10mobrovac) https://gerrit.wikimedia.org/r/#/c/205645/ fixes the issue. [19:02:07] 10VisualEditor: VE silently alters non-breaking spaces into normal spaces - https://phabricator.wikimedia.org/T96701#1225154 (10Nnemo) >>! In T96701#1225129, @Aklapper wrote: > Where exactly is this nbsp entered? Anywhere in the text? Yes, I enter a non-breaking space anywhere in the text of the article. >>!... [19:05:26] 10VisualEditor, 10RESTBase, 6operations, 7Performance: Set up an API base path for REST and action APIs - https://phabricator.wikimedia.org/T95229#1225155 (10TheDJ) >Also, RESTbase already sends liberal CORS headers with its responses anyway. Another reason to do this, not yet mentioned as far as I see, i... [19:44:41] 10VisualEditor, 10VisualEditor-Tables: Menu items in table popup widget (e.g. "Insert before") truncated in most languages (box not wide enough) - https://phabricator.wikimedia.org/T78119#1225198 (10Aklapper) Could anybody provide a pointer to the corresponding LESS file(s)? I'm kind of curious if I can fix t... [20:13:40] 10VisualEditor, 10VisualEditor-ContentLanguage, 7I18n: VisualEditor: Typing problem in Assamese - https://phabricator.wikimedia.org/T54726#1225288 (10Aklapper) Could somebody please answer if what's left to do in this ticket "just" a dup of {T51569}, or is there more to do (if so, what?) [20:34:14] hmm, restbase emits more cors headers than required it seems. or perhaps, it just doesn't distinguish between HEAD and GET.... [21:16:31] 10VisualEditor, 10RESTBase, 6operations, 7Performance: Set up an API base path for REST and action APIs - https://phabricator.wikimedia.org/T95229#1225413 (10Tgr) >>! In T95229#1225155, @TheDJ wrote: > I know @tgr or @gilles gathered some statistics on the level of 'brokenness' of CORS throughout the user... [21:18:20] 10VisualEditor, 10MediaWiki-General-or-Unknown: The visual editor displays two incorrect apostrophes in the ref - https://phabricator.wikimedia.org/T96718#1225415 (10Nnemo) 3NEW [21:36:54] (03PS1) 10Legoktm: Work around 1c57794e3 in MW core mangling boolean properties [extensions/TemplateData] (REL1_25) - 10https://gerrit.wikimedia.org/r/205727 (https://phabricator.wikimedia.org/T96443) [21:38:04] 10VisualEditor, 10MediaWiki-General-or-Unknown: The visual editor displays two incorrect apostrophes in the ref - https://phabricator.wikimedia.org/T96718#1225482 (10Nnemo) [21:40:14] (03CR) 10Legoktm: [C: 032] Work around 1c57794e3 in MW core mangling boolean properties [extensions/TemplateData] (REL1_25) - 10https://gerrit.wikimedia.org/r/205727 (https://phabricator.wikimedia.org/T96443) (owner: 10Legoktm) [21:46:16] (03Merged) 10jenkins-bot: Work around 1c57794e3 in MW core mangling boolean properties [extensions/TemplateData] (REL1_25) - 10https://gerrit.wikimedia.org/r/205727 (https://phabricator.wikimedia.org/T96443) (owner: 10Legoktm) [21:50:43] (03PS1) 10Legoktm: Further cleanup for core API change [extensions/VisualEditor] (REL1_25) - 10https://gerrit.wikimedia.org/r/205734 (https://phabricator.wikimedia.org/T96595) [21:53:59] MatmaRex, hey [21:54:02] so https://gerrit.wikimedia.org/r/#/c/205556/1/src/ui/dialogs/ve.ui.SpecialCharacterDialog.js [21:54:49] Why do we do that toInsert/toEncapsulate thing instead of just [21:55:17] if ( typeof character === 'string' ) { fragment.insertContent( character, true ).collapseToEnd().select(); } etc. [21:55:18] ? [21:56:06] oh he's away. It is almost midnight there... [21:56:14] i'm still here though [21:56:56] Krenair: i dunno, seemed nicer to me? we would have that code repeated twice, once for string, once for object [21:57:24] Krenair: and i was hoping to come up with a saner format for this configuration [21:57:39] MatmaRex, it's one line... [21:57:42] since the current is basically what was the easiest to implement in WikiEditor [21:57:47] and really not needed for toEncapsulate [21:58:20] okay [21:58:36] Krenair: can you leave me a reminder on the changeset? i am awaying for serious in a minute [21:59:06] ok [21:59:54] (03CR) 10Legoktm: [C: 032] Further cleanup for core API change [extensions/VisualEditor] (REL1_25) - 10https://gerrit.wikimedia.org/r/205734 (https://phabricator.wikimedia.org/T96595) (owner: 10Legoktm) [22:00:01] (03CR) 10Alex Monk: [C: 04-1] "Let's not do this toInsert/toEncapsulate thing. Especially with toEncapsulate, actually." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205556 (https://phabricator.wikimedia.org/T65227) (owner: 10Bartosz Dziewoński) [22:00:42] Krenair: Are you going to be OK to throw together a bunch of things for SWAT? [22:00:55] Krenair: RoanKattouw was doing them yesterday but he's rather distracted now. [22:01:16] Sure [22:01:39] Krenair: Can mention in the KIT, or on here in five minutes' time if you prefer. [22:01:52] here please [22:01:56] Kk. [22:02:54] (03Merged) 10jenkins-bot: Further cleanup for core API change [extensions/VisualEditor] (REL1_25) - 10https://gerrit.wikimedia.org/r/205734 (https://phabricator.wikimedia.org/T96595) (owner: 10Legoktm) [22:17:47] James_F, alright so what do we need to do for swat today? [22:18:39] Krenair: Roan did https://gerrit.wikimedia.org/r/#/c/205489/ https://gerrit.wikimedia.org/r/#/c/205490/ last night, that's good. [22:19:28] Krenair: https://gerrit.wikimedia.org/r/#/c/204933/ and https://gerrit.wikimedia.org/r/#/c/205488/ need SWATing (but not configuring on yet). [22:19:41] Krenair: We'll configure in tomorrow morning's SWAT, I guess. [22:20:27] James_F, I won't be around for tomorrow "morning"'s swat, but OK [22:22:29] (03PS1) 10Jforrester: Update VisualEditor core submodule to 1.26wmf2 HEAD (c90fcc4) [extensions/VisualEditor] (wmf/1.26wmf2) - 10https://gerrit.wikimedia.org/r/205767 [22:22:39] And that. ^^^ [22:22:43] Krenair: No worries, I can be. [22:23:46] We backporting these to just wmf2? [22:23:54] Yeah. [22:27:50] looks like I need to do it manually :( [22:27:57] Eh. [22:32:51] ++<<<<<<< HEAD [22:32:51] + "VisualEditorRestbaseURL": false, [22:32:52] ++======= [22:32:52] + "VisualEditorEnableSplitTest": false, [22:32:52] ++>>>>>>> 96aa5c9... Re-add A/B testing framework for new accounts [22:32:53] bah [22:34:31] (03PS1) 10Alex Monk: Re-add A/B testing framework for new accounts [extensions/VisualEditor] (wmf/1.26wmf2) - 10https://gerrit.wikimedia.org/r/205772 [22:34:33] (03PS1) 10Alex Monk: [TEMPORARY] Re-point A/B testing preference for test [extensions/VisualEditor] (wmf/1.26wmf2) - 10https://gerrit.wikimedia.org/r/205773 [22:34:45] Ta. [22:35:13] (03CR) 10Alex Monk: [C: 032] [TEMPORARY] Re-point A/B testing preference for test [extensions/VisualEditor] (wmf/1.26wmf2) - 10https://gerrit.wikimedia.org/r/205773 (owner: 10Alex Monk) [22:35:29] (03CR) 10Alex Monk: [C: 032] Re-add A/B testing framework for new accounts [extensions/VisualEditor] (wmf/1.26wmf2) - 10https://gerrit.wikimedia.org/r/205772 (owner: 10Alex Monk) [22:36:05] Oh. I hope that's not going to break due to the order... [22:36:52] 10VisualEditor, 10WMF-Product-Strategy, 3Editing Department 2014/15 Q4 blockers: Perform a weekly review of edits made with VisualEditor - https://phabricator.wikimedia.org/T94767#1225878 (10gpaumier) 2015-04-21: * [[ https://en.wikipedia.org/w/index.php?oldid=657635954#Tue_Apr_21_2015_09:26:27_GMT-0700_.28P... [22:37:03] Krenair: In case you didn't guess, we'll revert "[TEMPORARY] Re-point A/B testing preference for test" once the test of the test is complete. :-) [22:37:12] :) [22:37:31] (03Merged) 10jenkins-bot: Re-add A/B testing framework for new accounts [extensions/VisualEditor] (wmf/1.26wmf2) - 10https://gerrit.wikimedia.org/r/205772 (owner: 10Alex Monk) [22:38:44] That was fast. [22:38:47] Thanks Krinkle. [22:38:55] (Well, relatively speaking :)) [22:38:55] Krinkle is amazing. [22:40:24] (03Merged) 10jenkins-bot: [TEMPORARY] Re-point A/B testing preference for test [extensions/VisualEditor] (wmf/1.26wmf2) - 10https://gerrit.wikimedia.org/r/205773 (owner: 10Alex Monk) [22:41:59] yw :) [22:50:22] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/205777/ [23:00:29] 10WikiEditor, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review: editSessionID is duplicated in Edit:Schema for Wikitext - https://phabricator.wikimedia.org/T95919#1226147 (10Jdforrester-WMF) 5Open>3Resolved This should now be resolved (or, at least, much lower than the 0.2% of sessions it was b... [23:00:36] 10WikiEditor, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review: editSessionID is duplicated in Edit:Schema for Wikitext - https://phabricator.wikimedia.org/T95919#1226149 (10Jdforrester-WMF) [23:06:56] (03PS3) 10Mooeypoo: Rearrange images when the media search window resizes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/204568 (https://phabricator.wikimedia.org/T95017) [23:15:51] 10MediaWiki-ResourceLoader, 7Performance: Top-queue stylesheets should be versioned for improved caching - https://phabricator.wikimedia.org/T96797#1226346 (10Krinkle) 3NEW [23:17:24] (03PS4) 10Mooeypoo: Focus on the first focusable element in template dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/204204 [23:23:16] 10VisualEditor, 10RESTBase, 6operations, 7Performance: Set up an API base path for REST and action APIs - https://phabricator.wikimedia.org/T95229#1226371 (10GWicke) [23:28:36] 10WikiEditor, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review: editSessionID is duplicated in Edit:Schema for Wikitext - https://phabricator.wikimedia.org/T95919#1226373 (10Halfak) @jdforrester-WMF, sure. When should I expect to see new data rolling in? [23:53:24] (03CR) 10Jforrester: [C: 032] Update VisualEditor core submodule to 1.26wmf2 HEAD (c90fcc4) [extensions/VisualEditor] (wmf/1.26wmf2) - 10https://gerrit.wikimedia.org/r/205767 (owner: 10Jforrester) [23:54:21] (03CR) 10Jforrester: [C: 032] test: Configuring banana-checker for i18n messages [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/205493 (owner: 10Legoktm) [23:54:22] (03CR) 10Jforrester: [C: 032] test: Configuring banana-checker for i18n messages [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/205493 (owner: 10Legoktm) [23:54:42] (03CR) 10Jforrester: [C: 031] "Good to go once 'npm' test job is installed." [extensions/Cite] - 10https://gerrit.wikimedia.org/r/205510 (owner: 10Legoktm) [23:55:14] (03PS2) 10Jforrester: Remove extraneous comma [extensions/WikiEditor] (wmf/1.26wmf1) - 10https://gerrit.wikimedia.org/r/205186 [23:55:16] oh oops [23:55:17] (03PS2) 10Jforrester: Remove extraneous comma [extensions/WikiEditor] (wmf/1.26wmf2) - 10https://gerrit.wikimedia.org/r/205185 [23:55:26] I forgot to -1 that :P [23:55:26] legoktm: :-) [23:55:39] I was going to configure it to automatically read from extension.json [23:55:48] Read what? [23:55:50] 10VisualEditor: Preceding Timeline extension with