[00:28:50] <grrrit-wm>	 (03CR) 10Jforrester: [C: 031] "Product sign-off." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/203965 (https://phabricator.wikimedia.org/T95696) (owner: 10Mooeypoo)
[00:31:34] <grrrit-wm>	 (03CR) 10Divec: [C: 032] "I support this, because I see no reason to presume that the source has correct language tagging, nor that the editor will spot any discrep" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/205585 (https://phabricator.wikimedia.org/T95708) (owner: 10Esanders)
[00:32:35] <grrrit-wm>	 (03PS1) 10Jforrester: Revert "[TEMPORARY] Re-point A/B testing preference for test" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/205791 
[00:32:44] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Revert "[TEMPORARY] Re-point A/B testing preference for test" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/205791 (owner: 10Jforrester)
[00:33:19] <grrrit-wm>	 (03Merged) 10jenkins-bot: Strip language annotations on external import [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/205585 (https://phabricator.wikimedia.org/T95708) (owner: 10Esanders)
[00:33:21] <grrrit-wm>	 (03CR) 10Jforrester: "Makes sense." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/205585 (https://phabricator.wikimedia.org/T95708) (owner: 10Esanders)
[00:34:41] <grrrit-wm>	 (03Merged) 10jenkins-bot: Revert "[TEMPORARY] Re-point A/B testing preference for test" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/205791 (owner: 10Jforrester)
[00:35:04] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Remove ancient bad copy-paste documentation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/205605 (owner: 10Bartosz Dziewoński)
[00:36:14] <grrrit-wm>	 (03CR) 10Jforrester: [C: 04-1] "OOjs UI item not yet in a release." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/204204 (owner: 10Mooeypoo)
[00:36:51] <James_F>	 TrevorParscal: CR on https://gerrit.wikimedia.org/r/#/c/204568/ https://gerrit.wikimedia.org/r/#/c/205567/ https://gerrit.wikimedia.org/r/#/c/205618/ and whether https://gerrit.wikimedia.org/r/#/c/205619/ is sane (I sort-of like it).
[00:37:10] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove ancient bad copy-paste documentation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/205605 (owner: 10Bartosz Dziewoński)
[00:43:45] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review: Select all produces an incorrect DOM range when the page ends in a block slug - https://phabricator.wikimedia.org/T96357#1226503 (10Jdforrester-WMF) p:5Triage>3High a:3dchan
[00:43:50] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 04-1] "Just some naming issues to resolve." (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/204568 (https://phabricator.wikimedia.org/T95017) (owner: 10Mooeypoo)
[00:43:52] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review: Select all produces an incorrect DOM range when the page ends in a block slug - https://phabricator.wikimedia.org/T96357#1215004 (10Jdforrester-WMF)
[00:44:27] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] ve.ui.WhitespacePreservingTextInputWidget: Trim whitespace in input [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205567 (https://phabricator.wikimedia.org/T74561) (owner: 10Bartosz Dziewoński)
[00:45:28] <wikibugs>	 10VisualEditor, 10VisualEditor-EditingTools, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review, 5WMF-deploy-2015-04-22_(1.26wmf3): VisualEditor: Don't allow whitespace-only comments to be inserted - https://phabricator.wikimedia.org/T74561#1226506 (10Jdforrester-WMF) a:3matmarex
[00:45:34] <wikibugs>	 10VisualEditor, 10VisualEditor-EditingTools, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review, 5WMF-deploy-2015-04-22_(1.26wmf3): VisualEditor: Don't allow whitespace-only comments to be inserted - https://phabricator.wikimedia.org/T74561#763374 (10Jdforrester-WMF)
[00:47:55] <grrrit-wm>	 (03Merged) 10jenkins-bot: ve.ui.WhitespacePreservingTextInputWidget: Trim whitespace in input [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205567 (https://phabricator.wikimedia.org/T74561) (owner: 10Bartosz Dziewoński)
[00:50:29] <wikibugs>	 10VisualEditor, 10VisualEditor-EditingTools, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review, 5WMF-deploy-2015-04-22_(1.26wmf3): VisualEditor: Don't allow whitespace-only comments to be inserted - https://phabricator.wikimedia.org/T74561#1226522 (10Jdforrester-WMF) 5Open>3Resolved
[00:51:16] <wikibugs>	 10VisualEditor, 3Editing Department 2014/15 Q4 blockers: Help the HTML Editing Task Force shape "Editing on the Web" (aka future of contentEditable) - https://phabricator.wikimedia.org/T91781#1226526 (10Jdforrester-WMF) a:5Catrope>3Esanders
[00:57:28] <grrrit-wm>	 (03PS4) 10Mooeypoo: Rearrange images when the media search window resizes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/204568 (https://phabricator.wikimedia.org/T95017) 
[01:03:50] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review, 5WMF-deploy-2015-04-22_(1.26wmf3): Media search dialog should allow for dynamic reflow of the images when the screen changes dimensions - https://phabricator.wikimedia.org/T95017#1226547 (10Jdforre...
[01:04:02] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review, 5WMF-deploy-2015-04-22_(1.26wmf3): Media search dialog should allow for dynamic reflow of the images when the screen changes dimensions - https://phabricator.wikimedia.org/T95017#1178329 (10Jdforre...
[01:04:02] <wikibugs>	 10VisualEditor: Resize a browser window with open Media settings dialog  - highlighted area for an image will be off - https://phabricator.wikimedia.org/T88349#1226549 (10Jdforrester-WMF)
[01:11:41] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Rearrange images when the media search window resizes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/204568 (https://phabricator.wikimedia.org/T95017) (owner: 10Mooeypoo)
[01:12:40] <grrrit-wm>	 (03PS1) 10Jforrester: Update VE core submodule to master (54819a1) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/205802 
[01:13:01] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Update VE core submodule to master (54819a1) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/205802 (owner: 10Jforrester)
[01:14:19] <grrrit-wm>	 (03Merged) 10jenkins-bot: Rearrange images when the media search window resizes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/204568 (https://phabricator.wikimedia.org/T95017) (owner: 10Mooeypoo)
[01:14:54] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update VE core submodule to master (54819a1) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/205802 (owner: 10Jforrester)
[03:30:33] <grrrit-wm>	 (03CR) 10Jdlrobson: "I suspect it is related to sharing on social networks" [skins/Vector] - 10https://gerrit.wikimedia.org/r/201877 (owner: 10Ori.livneh)
[03:48:37] <grrrit-wm>	 (03CR) 10Brian Wolff: "the css logo image dates back to 2004, which is before anyone cared about facebook." [skins/Vector] - 10https://gerrit.wikimedia.org/r/201877 (owner: 10Ori.livneh)
[05:01:21] <grrrit-wm>	 (03CR) 10Krinkle: "@Jdlrobson: It is not and never would be the first image in the page. Both in Monobook and in Vector the project logo is in the sidebar wh" [skins/Vector] - 10https://gerrit.wikimedia.org/r/201877 (owner: 10Ori.livneh)
[05:43:57] <grrrit-wm>	 (03PS1) 10Krinkle: build: Commit sync-gh-pages script [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205819 
[05:46:59] <grrrit-wm>	 (03PS2) 10Krinkle: build: Commit sync-gh-pages script [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205819 
[07:08:10] <wikibugs>	 10MediaWiki-ResourceLoader, 10WikiEditor: Request amendment of Bangla character set in WikiEditor - https://phabricator.wikimedia.org/T96494#1226910 (10Hrishikes) Submitting json file. @Krenair @GOIII @AuFCL please check legality/validity of the format.  {F151383}
[08:09:58] <wikibugs>	 10MediaWiki-ResourceLoader, 10WikiEditor: Request amendment of Bangla character set in WikiEditor - https://phabricator.wikimedia.org/T96494#1227000 (10GOIII) @Hrishikes  There is an end-comma missing for the character right before the opening `[` for ZWS.  Whenever in doubt, use the online JSON verification t...
[08:29:17] <wikibugs>	 10VisualEditor: Long Help text (e.g. in Russian) creates linebreak between "question mark" Icon and text - https://phabricator.wikimedia.org/T89112#1227008 (10Sunpriat) this window now more in width so that the problem is not visible or it has been fixed {F151604}
[09:22:08] <wikibugs>	 10MediaWiki-ResourceLoader, 10WikiEditor: Request amendment of Bangla character set in WikiEditor - https://phabricator.wikimedia.org/T96494#1227083 (10Hrishikes) >>! In T96494#1227000, @GOIII wrote: > @Hrishikes >  > There is an end-comma missing for the character right before the opening `[` for ZWS. >  > Wh...
[10:03:30] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-References: VE displays two incorrect apostrophes at the end of a reference that ends with an URL - https://phabricator.wikimedia.org/T96718#1227147 (10Aklapper)
[10:06:59] <wikibugs>	 10VisualEditor: Long Help text (e.g. in Russian) creates linebreak between "question mark" Icon and text - https://phabricator.wikimedia.org/T89112#1227160 (10Aklapper) 5Open>3Resolved a:3Aklapper Yay. Closing the task.
[10:35:26] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "We've only recently gotten rid of the 30-day waiting period by moving the logo from inlined CSS to a ResourceLoader module. I don't think " [skins/Vector] - 10https://gerrit.wikimedia.org/r/201877 (owner: 10Ori.livneh)
[10:51:36] <wikibugs>	 10VisualEditor, 10RESTBase, 6operations, 7Performance: Set up an API base path for REST and action APIs - https://phabricator.wikimedia.org/T95229#1227204 (10akosiaris) >>>! In T95229#1224477, @Anomie wrote: >> Above Gabriel claimed "v1" was the name. If it's the version then it's not following the `/api/{...
[11:15:23] <grrrit-wm>	 (03CR) 10Esanders: [C: 032] build: Commit sync-gh-pages script [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205819 (owner: 10Krinkle)
[11:18:05] <grrrit-wm>	 (03Merged) 10jenkins-bot: build: Commit sync-gh-pages script [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205819 (owner: 10Krinkle)
[11:37:50] <grrrit-wm>	 (03CR) 10Esanders: [C: 032] ve.ui.SpecialCharacterPage: Allow providing a tooltip for characters [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205557 (https://phabricator.wikimedia.org/T70425) (owner: 10Bartosz Dziewoński)
[11:42:20] <grrrit-wm>	 (03CR) 10Esanders: [C: 031] "Dependencies unmet" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/205558 (https://phabricator.wikimedia.org/T65227) (owner: 10Bartosz Dziewoński)
[11:44:25] <grrrit-wm>	 (03CR) 10Esanders: [C: 04-1] "Do you have a dependent commit that uses this yet?" (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204985 (owner: 10Divec)
[11:47:27] <matanya>	 edsanders: hi there, is there a way to remove a template in VE? or just edit it ?
[11:47:49] <edsanders>	 you should be able to select templates
[11:48:10] <edsanders>	 and delete them with backspace/del
[11:48:20] <edsanders>	 they should also show a context menu which lets you edit them
[11:48:34] <matanya>	 i can, but i can't remove them completely, at least i didn't figure how
[11:48:46] <grrrit-wm>	 (03CR) 10Esanders: [C: 032] "This *really* needs unit tests." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205580 (https://phabricator.wikimedia.org/T96357) (owner: 10Divec)
[11:48:49] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Fix getNodeAndOffset for block slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205580 (https://phabricator.wikimedia.org/T96357) (owner: 10Divec)
[11:51:03] <wikibugs>	 10VisualEditor: Create unit tests for ve.ce.Document#getNodeAndOffset - https://phabricator.wikimedia.org/T96838#1227285 (10Esanders) 3NEW
[11:51:05] <matanya>	 edsanders: seems like a UX problem (i.e. peback). Thank you
[11:51:28] <edsanders>	 np
[12:31:10] <wikibugs>	 10VisualEditor, 10RESTBase, 6operations, 7Performance: Set up an API base path for REST and action APIs - https://phabricator.wikimedia.org/T95229#1227327 (10Yurik) I second @akosiaris sentiment - #1 (`/api/content/v1/...`) seems like a much cleaner choice out of the once mentioned above. Alternatively, un...
[12:45:49] <wikibugs>	 10VisualEditor, 10RESTBase, 6operations, 7Performance: Set up an API base path for REST and action APIs - https://phabricator.wikimedia.org/T95229#1227337 (10Anomie) >>! In T95229#1227327, @Yurik wrote: > Alternatively, unless there is a good reason not to, we could put the `api` into the domain, e.g. `//a...
[12:49:25] <wikibugs>	 10VisualEditor, 10RESTBase, 6operations, 7Performance: Set up an API base path for REST and action APIs - https://phabricator.wikimedia.org/T95229#1227338 (10Yurik) Thanks @anomie. So back to `/api/content/v1/`, or a shorter `/a/c/1/` since some browsers might not support header compression, and it will be...
[12:50:26] <wikibugs>	 10VisualEditor, 10RESTBase, 6operations, 7Performance: Set up an API base path for REST and action APIs - https://phabricator.wikimedia.org/T95229#1227340 (10Anomie) Personally I'd much rather see the reasonably clear /api/content/ than the cryptic /a/c/.
[13:16:09] <wikibugs>	 10VisualEditor, 6Community-Liaison, 10Wikimedia-Site-requests: Plan to re-enable VisualEditor by default for all logged-out and newly-created users of the English Wikipedia - https://phabricator.wikimedia.org/T90667#1227384 (10Elitre) For updates about pilot and study, please see: https://meta.wikimedia.org/...
[13:19:18] <wikibugs>	 10VisualEditor, 10Wikimedia-Site-requests, 3Editing Department 2014/15 Q4 blockers, 7Epic, and 3 others: Run test of having VisualEditor on for some newly-created accounts on the English Wikipedia - https://phabricator.wikimedia.org/T90666#1227385 (10Elitre) Copy/pasting from the other task! For updates ab...
[13:43:56] <wikibugs>	 10MediaWiki-ResourceLoader, 10WikiEditor: Request amendment of Bangla character set in WikiEditor - https://phabricator.wikimedia.org/T96494#1227452 (10Hrishikes) Updated json file:  {F152309}
[14:02:48] <wikibugs>	 10MediaWiki-ResourceLoader, 10WikiEditor: Request amendment of Bangla character set in WikiEditor - https://phabricator.wikimedia.org/T96494#1227524 (10Hrishikes) At jsonlint, the content is shown as valid when pasted there, but the file shows   Parse error on line 1:  ^ Expecting '{', '['  when url is pasted....
[14:25:18] <grrrit-wm>	 (03CR) 10Esanders: [C: 04-1] "Needs rebase" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205580 (https://phabricator.wikimedia.org/T96357) (owner: 10Divec)
[14:26:05] <grrrit-wm>	 (03CR) 10Esanders: [C: 032] ve.ce.MWEntityNode: Show whitespace characters, like in ve.ce.TextNode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/205611 (owner: 10Bartosz Dziewoński)
[14:27:54] <grrrit-wm>	 (03Merged) 10jenkins-bot: ve.ce.MWEntityNode: Show whitespace characters, like in ve.ce.TextNode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/205611 (owner: 10Bartosz Dziewoński)
[14:28:57] <grrrit-wm>	 (03PS1) 10Mobrovac: Add .dockerignore listing .git, node_modules/ and coverage/ [services/citoid] - 10https://gerrit.wikimedia.org/r/205858 
[14:29:07] <grrrit-wm>	 (03CR) 10Jdlrobson: "ok bad guess - anyone able to answer Mz's question then? Why didn't we just use an image?" [skins/Vector] - 10https://gerrit.wikimedia.org/r/201877 (owner: 10Ori.livneh)
[14:29:23] <grrrit-wm>	 (03CR) 10Mobrovac: [C: 032 V: 032] Add .dockerignore listing .git, node_modules/ and coverage/ [services/citoid] - 10https://gerrit.wikimedia.org/r/205858 (owner: 10Mobrovac)
[14:30:11] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-References: VE displays two incorrect apostrophes at the end of a reference that ends with an external link - https://phabricator.wikimedia.org/T96718#1227671 (10Nnemo)
[14:30:22] <grrrit-wm>	 (03CR) 10Esanders: [C: 032] ButtonInputWidget: Don't double-mixin FlaggedElement [oojs/ui] - 10https://gerrit.wikimedia.org/r/205597 (owner: 10Bartosz Dziewoński)
[14:31:38] <grrrit-wm>	 (03CR) 10Esanders: [C: 032] ButtonWidget: Remove pointless #isHyperlink property [oojs/ui] - 10https://gerrit.wikimedia.org/r/205592 (owner: 10Bartosz Dziewoński)
[14:35:41] <grrrit-wm>	 (03Merged) 10jenkins-bot: ButtonInputWidget: Don't double-mixin FlaggedElement [oojs/ui] - 10https://gerrit.wikimedia.org/r/205597 (owner: 10Bartosz Dziewoński)
[14:36:18] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "Well, we actually don't quite accept it; there is some mangling in ve.init.mw.Platform.prototype.fetchSpecialCharList (MW's format is actu" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205556 (https://phabricator.wikimedia.org/T65227) (owner: 10Bartosz Dziewoński)
[14:38:45] <grrrit-wm>	 (03CR) 10Esanders: [C: 032] ButtonWidget: Remove href to make unclickable when disabled [oojs/ui] - 10https://gerrit.wikimedia.org/r/205593 (https://phabricator.wikimedia.org/T93004) (owner: 10Bartosz Dziewoński)
[14:38:55] <grrrit-wm>	 (03PS2) 10Bartosz Dziewoński: ve.ui.SpecialCharacterDialog: Allow encapsulation of selected content [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205556 (https://phabricator.wikimedia.org/T65227) 
[14:40:05] <grrrit-wm>	 (03Merged) 10jenkins-bot: ButtonWidget: Remove pointless #isHyperlink property [oojs/ui] - 10https://gerrit.wikimedia.org/r/205592 (owner: 10Bartosz Dziewoński)
[14:41:42] <grrrit-wm>	 (03CR) 10Esanders: [C: 031] [BREAKING CHANGE] Convert ToggleWidget from a mixin to an abstract class [oojs/ui] - 10https://gerrit.wikimedia.org/r/205601 (https://phabricator.wikimedia.org/T96674) (owner: 10Bartosz Dziewoński)
[14:41:49] <grrrit-wm>	 (03Merged) 10jenkins-bot: ButtonWidget: Remove href to make unclickable when disabled [oojs/ui] - 10https://gerrit.wikimedia.org/r/205593 (https://phabricator.wikimedia.org/T93004) (owner: 10Bartosz Dziewoński)
[14:44:36] <wikibugs>	 10VisualEditor, 10RESTBase, 10Traffic, 6operations, 7Performance: Set up an API base path for REST and action APIs - https://phabricator.wikimedia.org/T95229#1227766 (10BBlack)
[14:59:04] <grrrit-wm>	 (03CR) 10Esanders: "I think we can also safely filter out the suggestions to internal red-links starting 'http://'. In 99.99999% of cases it's just confusing " [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201627 (https://phabricator.wikimedia.org/T94334) (owner: 10Alex Monk)
[15:45:26] <wikibugs>	 10VisualEditor, 7Accessibility: Tool menu: navigating with Tabs skips some icons - https://phabricator.wikimedia.org/T93232#1228025 (10matmarex)
[15:45:26] <grrrit-wm>	 (03PS1) 10Mobrovac: Update citoid to 7e3ee47 [services/citoid/deploy] - 10https://gerrit.wikimedia.org/r/205872 (https://phabricator.wikimedia.org/T95308) 
[15:58:14] <wikibugs>	 10MediaWiki-ResourceLoader, 10WikiEditor: Request amendment of Bangla character set in WikiEditor - https://phabricator.wikimedia.org/T96494#1228080 (10Hrishikes) Patch for Bangla character set as under:  "bangla":["ঀ","অ","আ","ই","ঈ","উ","ঊ","ঋ","ঌ","এ","ঐ","ও","ঔ","া","ি","ী","ু","ূ","ৃ","ে","ৈ","ো","ৌ","্য"...
[15:59:41] <wikibugs>	 10VisualEditor, 10WikiEditor, 6Editing, 3Editing Department 2014/15 Q4 blockers: Request amendment of Bangla character set in WikiEditor - https://phabricator.wikimedia.org/T96494#1228082 (10Jdforrester-WMF) a:3Jdforrester-WMF
[16:37:28] <wikibugs>	 10VisualEditor, 10WikiEditor, 6Editing, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review: Request amendment of Bangla character set in WikiEditor - https://phabricator.wikimedia.org/T96494#1228142 (10Jdforrester-WMF) @Nasirkhan, @Hrishikes: I've updated the special characters list in the above...
[16:38:03] <Krenair>	 James_F, hey, just got back
[16:38:08] <James_F>	 Hey.
[16:38:10] <Krenair>	 Thanks for dealing with that
[16:39:26] <wikibugs>	 10VisualEditor: VE silently alters non-breaking spaces into normal spaces - https://phabricator.wikimedia.org/T96701#1228158 (10matmarex)
[16:39:27] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable: VisualEditor: Ctrl-Space to insert a non-breaking space (NBSP), and a way to see the difference - https://phabricator.wikimedia.org/T53045#1228159 (10matmarex)
[16:39:58] <wikibugs>	 10VisualEditor, 10WikiEditor, 6Editing, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review: Request amendment of Bangla character set in WikiEditor - https://phabricator.wikimedia.org/T96494#1228160 (10Hrishikes) Bengali characters are confirmed. Present at http://unicode.org/charts/PDF/U0980.pdf
[16:46:46] <grrrit-wm>	 (03CR) 10Mobrovac: [C: 032 V: 032] Update citoid to 7e3ee47 [services/citoid/deploy] - 10https://gerrit.wikimedia.org/r/205872 (https://phabricator.wikimedia.org/T95308) (owner: 10Mobrovac)
[16:48:17] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable, 5Patch-For-Review: Make non-breaking spaces (nbsp) visible in VisualEditor - https://phabricator.wikimedia.org/T96666#1228205 (10matmarex) Hmm. I still think we should show the user some kind of confirmation that they managed to insert a non-breaking space. Per...
[16:52:18] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable, 5Patch-For-Review: Make non-breaking spaces (nbsp) visible in VisualEditor - https://phabricator.wikimedia.org/T96666#1228214 (10matmarex)
[16:55:53] <wikibugs>	 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Add non-breaking space (nbsp) to the "special character" dialog - https://phabricator.wikimedia.org/T70429#1228217 (10matmarex) We already have the ability to use different label on the button than the character that will be inserted (we use it for mor...
[16:57:07] <wikibugs>	 10OOjs-UI, 5OOjs-UI-next-release, 10VisualEditor, 10VisualEditor-MediaWiki-Links, 3Editing Department 2014/15 Q4 blockers: Disabled ButtonWidget with href should not be clickable - https://phabricator.wikimedia.org/T93004#1228218 (10Jdforrester-WMF) 5Open>3Resolved
[16:57:13] <wikibugs>	 10OOjs-UI, 5OOjs-UI-next-release, 10VisualEditor, 10VisualEditor-MediaWiki-Links, 3Editing Department 2014/15 Q4 blockers: Disabled ButtonWidget with href should not be clickable - https://phabricator.wikimedia.org/T93004#1126337 (10Jdforrester-WMF)
[16:57:42] <wikibugs>	 10VisualEditor, 10RESTBase, 10Traffic, 6operations, 7Performance: Set up an API base path for REST and action APIs - https://phabricator.wikimedia.org/T95229#1228222 (10GWicke) The problem with 'content' is that it is not general enough, as this API will expose non-content information as well. Using `v1`...
[16:58:17] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Links, 7Design, 3Editing Department 2014/15 Q4 blockers: Search interface for link dialogue - https://phabricator.wikimedia.org/T76397#1228224 (10Jdforrester-WMF) a:5sucheta>3None
[16:58:28] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Links, 7Design, 3Editing Department 2014/15 Q4 blockers: External link interface for link dialogue - https://phabricator.wikimedia.org/T76398#1228232 (10Jdforrester-WMF) a:5sucheta>3None
[16:59:01] <wikibugs>	 10Citoid, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review, 5WMF-deploy-2015-04-22_(1.26wmf3): Bad formats cause citoid to crash - https://phabricator.wikimedia.org/T95308#1228233 (10Jdforrester-WMF)
[16:59:14] <wikibugs>	 10Citoid, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review, 5WMF-deploy-2015-04-22_(1.26wmf3): Bad formats cause citoid to crash - https://phabricator.wikimedia.org/T95308#1228234 (10Jdforrester-WMF) 5Open>3Resolved
[16:59:31] <wikibugs>	 10Citoid, 6Services, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-22_(1.26wmf3): bad curl causes citoid to respond with a traceback - https://phabricator.wikimedia.org/T95898#1228236 (10Jdforrester-WMF) 5Open>3Resolved
[16:59:38] <wikibugs>	 10Citoid, 6Services, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-22_(1.26wmf3): bad curl causes citoid to respond with a traceback - https://phabricator.wikimedia.org/T95898#1203047 (10Jdforrester-WMF)
[17:01:45] <wikibugs>	 10VisualEditor, 10RESTBase, 10Traffic, 6operations, 7Performance: Set up an API base path for REST and action APIs - https://phabricator.wikimedia.org/T95229#1228242 (10Anomie) I'd still prefer something more descriptive than "rest"—as you said on IRC, it's the underlying technology rather than any indic...
[17:19:01] <grrrit-wm>	 (03PS3) 10Divec: Fix getNodeAndOffset for block slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205580 (https://phabricator.wikimedia.org/T96357) 
[17:51:04] <wikibugs>	 10Citoid, 10VisualEditor, 10VisualEditor-ContentEditable: Put Citoid in the regular Cite menu anyway - https://phabricator.wikimedia.org/T96118#1228340 (10Whatamidoing-WMF) @Neil_P._Quinn_WMF, I don't want "wait until a multi-quarter design project, which may or may not solve this problem anyway, is finally...
[17:53:52] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki, 10Parsoid, and 2 others: Spaces at the start of a paragraph aren't very obvious - https://phabricator.wikimedia.org/T68628#1228349 (10gpaumier)
[17:53:57] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki, 10Parsoid, and 2 others: Spaces at the start of a paragraph aren't very obvious - https://phabricator.wikimedia.org/T68628#687159 (10gpaumier) This issue came up 4 times out of 100 reviewed diffs, and accounted for ⅔ of problematic d...
[17:58:57] <wikibugs>	 10VisualEditor, 6Community-Liaison, 10WMF-Product-Strategy: Support VisualEditor rollout with research and analyses - https://phabricator.wikimedia.org/T93394#1136147 (10gpaumier)
[18:02:55] <wikibugs>	 10Citoid, 10VisualEditor, 10VisualEditor-ContentEditable: Put Citoid in the regular Cite menu anyway - https://phabricator.wikimedia.org/T96118#1228383 (10Neil_P._Quinn_WMF) @Jdforrester-WMF, I think that's a fair point. It seems like we should put this simple bandaid on the problem right now, in addition to...
[18:05:30] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 6Mobile-Web, 3Editing Department 2014/15 Q4 blockers, and 3 others: Mobile VE - Link inspector should have a back or cancel button - https://phabricator.wikimedia.org/T91844#1228384 (10Jdforrester-WMF)
[18:05:50] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki, 3Editing Department 2014/15 Q4 blockers, and 2 others: "Bitdefender Total Security 2015" inserts <script> tags into contentEditable surfaces - https://phabricator.wikimedia.org/T96533#1228385 (10Jdforrester-WMF)
[18:06:21] <wikibugs>	 10VisualEditor, 10VisualEditor-Tables, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-22_(1.26wmf3), 7user-notice: "Delete row"/"Delete column" messages do not use the plural when multiple rows/columns are selected (but they do delete multipl... - https://phabricator.wikimedia.org/T87234#1228386
[18:14:46] <wikibugs>	 10WikiEditor, 7Easy, 5Patch-For-Review, 7Upstream: WikiEditor: Add SVG versions of editing toolbar icons - https://phabricator.wikimedia.org/T37342#1228421 (10Paladox) Hi I fonund a fix to chrome zooming out problem. we should use preserveAspectRatio="none" and xml:space="preserve" in button-sprite.svg file.
[18:15:14] <grrrit-wm>	 (03PS52) 10Paladox: Re add svg images [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (https://phabricator.wikimedia.org/T37342) 
[18:16:06] <grrrit-wm>	 (03CR) 10Paladox: "Hi I think I managed to find a fix for chrome zooming out issue if we use preserveAspectRatio="none" and xml:space="preserve" in button-sp" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (https://phabricator.wikimedia.org/T37342) (owner: 10Paladox)
[18:16:44] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 3Editing Department 2014/15 Q4 blockers: VisualEditor: Implement some form of auto-save - https://phabricator.wikimedia.org/T57370#1228449 (10Jdforrester-WMF)
[18:16:46] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10VisualEditor-Performance, 7Browser-Support-Apple-Safari, 3Editing Department 2014/15 Q4 blockers: VisualEditor Mobile: Switching tabs in mobile safari often causes page to refresh causing data loss of sess... - https://phabricator.wikimedia.org/T70017#1228448
[18:19:23] <wikibugs>	 10WikiEditor, 7Easy, 5Patch-For-Review, 7Upstream: WikiEditor: Add SVG versions of editing toolbar icons - https://phabricator.wikimedia.org/T37342#1228470 (10Paladox) Found the fix at http://yootheme.com/support/question/6801?order=modified
[18:23:35] <wikibugs>	 10OOjs-UI, 10UI-Standardization, 7Design, 5Patch-For-Review: ButtonGroupWidget use cases - https://phabricator.wikimedia.org/T88637#1228506 (10violetto) Thanks for answering all my questions @matmarex
[18:24:20] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 7Browser-Support-Google-Chrome, 3Editing Department 2014/15 Q4 blockers: VisualEditor Mobile: Chrome for mobile keyboard doesn't fire useful key events for backspace - https://phabricator.wikimedia.org/T69262#1228508 (10Jdforrester-WMF) a:3dchan
[18:28:14] <grrrit-wm>	 (03PS53) 10Paladox: Re add svg images [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (https://phabricator.wikimedia.org/T37342) 
[18:30:49] <grrrit-wm>	 (03CR) 10Paladox: "@MarkTraceur please review. Chrome bug fixed now in this patch." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (https://phabricator.wikimedia.org/T37342) (owner: 10Paladox)
[18:34:26] <grrrit-wm>	 (03PS19) 10Paladox: Add svg to LESS file [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/195529 (https://phabricator.wikimedia.org/T37342) 
[18:35:24] <grrrit-wm>	 (03PS6) 10Paladox: Add skin.json [skins/Vector] - 10https://gerrit.wikimedia.org/r/203047 (https://phabricator.wikimedia.org/T87875) 
[18:35:25] <wikibugs>	 10VisualEditor, 7Easy: Change MediaWiki:Visualeditor-feedback-tool to say "Leave feedback about this software" - https://phabricator.wikimedia.org/T91804#1228579 (10Whatamidoing-WMF)
[18:35:46] <grrrit-wm>	 (03CR) 10Paladox: "@Bartosz Dziewoński please review." [skins/Vector] - 10https://gerrit.wikimedia.org/r/203047 (https://phabricator.wikimedia.org/T87875) (owner: 10Paladox)
[18:36:22] <grrrit-wm>	 (03PS18) 10Paladox: Add collapsiblenav back [skins/Vector] - 10https://gerrit.wikimedia.org/r/190717 (https://phabricator.wikimedia.org/T69954) 
[18:37:30] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 04-1] "I would prefer if we had only one entry point. Keeping them in sync sucks." [skins/Vector] - 10https://gerrit.wikimedia.org/r/203047 (https://phabricator.wikimedia.org/T87875) (owner: 10Paladox)
[18:44:23] <wikibugs>	 10OOjs-UI, 10UI-Standardization, 7Design: ButtonGroupWidget use cases - https://phabricator.wikimedia.org/T88637#1228632 (10matmarex) 5Open>3Resolved
[18:55:06] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Fix getNodeAndOffset for block slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205580 (https://phabricator.wikimedia.org/T96357) (owner: 10Divec)
[18:57:06] <grrrit-wm>	 (03CR) 10Alex Monk: "Sigh. Then we lose the ability to link to such pages." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201627 (https://phabricator.wikimedia.org/T94334) (owner: 10Alex Monk)
[19:09:20] <grrrit-wm>	 (03CR) 10Jforrester: "Yeah. :-(" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201627 (https://phabricator.wikimedia.org/T94334) (owner: 10Alex Monk)
[19:12:35] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-29_(1.26wmf4): Select all produces an incorrect DOM range when the page ends in a block slug - https://phabricator.wikimedia.org/T96357#1228761 (10Jdforrester-WMF) 5Open>3Resolved
[19:14:51] <wikibugs>	 10VisualEditor, 10WikiEditor, 6Editing, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-29_(1.26wmf4): Request amendment of Bangla character set in WikiEditor - https://phabricator.wikimedia.org/T96494#1228776 (10Jdforrester-WMF) 5Open>3Resolved
[19:20:19] <James_F>	 Krenair: Could you re-review https://gerrit.wikimedia.org/r/#/c/205556/ ?
[19:22:52] <grrrit-wm>	 (03CR) 10Esanders: "So (1) on our projects there are no such pages. There is a redirect at 'http://' but that's it. (2) We can show links to existing pages (w" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201627 (https://phabricator.wikimedia.org/T94334) (owner: 10Alex Monk)
[19:24:42] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "Yeah, but (I think) I kept a showcase of all existing functionality in this commit, just in fewer widgets (except flags – I'm not sure if " [oojs/ui] - 10https://gerrit.wikimedia.org/r/204981 (https://phabricator.wikimedia.org/T88637) (owner: 10Bartosz Dziewoński)
[19:26:23] <wikibugs>	 10VisualEditor, 6Collaboration-Team, 10Flow: Don't use a * selector to set box-sizing in Flow - https://phabricator.wikimedia.org/T96513#1228830 (10Esanders)
[19:33:22] <Krenair>	 James_F, I think it's okay... will test later
[19:39:47] <wikibugs>	 10MediaWiki-ResourceLoader, 7JavaScript: ResourceLoader JS validator rejects valid user scripts - https://phabricator.wikimedia.org/T96901#1228876 (10He7d3r) 3NEW
[19:43:18] <James_F>	 Krenair: Thanks!
[19:48:54] <wikibugs>	 10OOjs, 10OOjs-UI, 10VisualEditor: Deprecate class static properties that are reserved in JavaScript - https://phabricator.wikimedia.org/T96640#1228908 (10Krinkle) I've searched for all the above mentioned property names with prefix `static.`, using GitHub Code Search on `wikimedia/*`.  The only match that a...
[19:54:49] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "Let's finish this. These just need to be added to one of the icon packs. Also, images should be pure black, not semitransparent (we do the" [oojs/ui] - 10https://gerrit.wikimedia.org/r/201639 (owner: 10Violetto)
[19:58:56] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-Performance, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-22_(1.26wmf3): Progress bar moves backwards sometimes - https://phabricator.wikimedia.org/T93964#1228935 (10Ryasmeen) I found this again today on Firefox.
[19:59:33] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-Tables, 7Browser-Support-Firefox, and 2 others: Cannot click into a particular table cell on Firefox - https://phabricator.wikimedia.org/T96446#1228942 (10Ryasmeen) Verified the fix on Betalabs
[20:00:53] <wikibugs>	 10MediaWiki-ResourceLoader, 7JavaScript: ResourceLoader JS validator rejects valid user scripts - https://phabricator.wikimedia.org/T96901#1228956 (10Krinkle) @He7d3r  ES3 does not allow keywords in dot notation. That restriction was removed in ES5 because it was stilly. Modern browsers ship JavaScript engines...
[20:01:22] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix getNodeAndOffset for block slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205580 (https://phabricator.wikimedia.org/T96357) (owner: 10Divec)
[20:01:39] <wikibugs>	 10MediaWiki-ResourceLoader: ResourceLoader JavaScript parser should allow ES6 syntax features  - https://phabricator.wikimedia.org/T75714#1228960 (10Krinkle)
[20:01:47] <wikibugs>	 10MediaWiki-ResourceLoader, 7JavaScript: ResourceLoader JavaScript parser should allow ES5 syntax features  - https://phabricator.wikimedia.org/T96901#1228961 (10Krinkle)
[20:01:59] <wikibugs>	 10MediaWiki-ResourceLoader, 7JavaScript: ResourceLoader JavaScript parser should allow ES5 syntax features - https://phabricator.wikimedia.org/T96901#1228876 (10Krinkle)
[20:05:28] <wikibugs>	 10VisualEditor: Cannot open any page with VE in Betalabs, getting error "Error loading data from server: internal_api_error_DBConnectionError: [8c78efd3] Exception Caught: DB connection error: Can't connect to MySQL: - https://phabricator.wikimedia.org/T96905#1229005 (10Ryasmeen)
[20:15:36] <wikibugs>	 10VisualEditor: [Regression pre-wmf-3] Media settings dialog: Caption box is small - https://phabricator.wikimedia.org/T96591#1221496 (10Ryasmeen) Is it an intentional change?
[20:15:59] <wikibugs>	 10VisualEditor: [Regression pre-wmf-3] Media settings dialog Caption box is small , also the text box in Basic Reference - https://phabricator.wikimedia.org/T96591#1229097 (10Ryasmeen)
[20:20:10] <grrrit-wm>	 (03PS6) 10Bartosz Dziewoński: Add viewCompact, viewDetails, visionSimulator icons for iconography page [oojs/ui] - 10https://gerrit.wikimedia.org/r/201639 (owner: 10Violetto)
[20:20:38] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 031] Add viewCompact, viewDetails, visionSimulator icons for iconography page [oojs/ui] - 10https://gerrit.wikimedia.org/r/201639 (owner: 10Violetto)
[20:21:12] <James_F>	 MatmaRex: I was thinking of doing an OOjs UI cut with a few breaking changes thrown in.
[20:21:22] <James_F>	 MatmaRex: Which ones do you think should go?
[20:21:34] <James_F>	 (And what else?)
[20:21:54] <wikibugs>	 10VisualEditor, 10VisualEditor-EditingTools, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-22_(1.26wmf3): [Regression pre-wmf3] Language Tool doesn't appear in the interface any more - https://phabricator.wikimedia.org/T96447#1229128 (10Ryasmeen) Verified the fix in Betalabs
[20:22:14] <MatmaRex>	 James_F: well, both, maybe?
[20:22:41] <MatmaRex>	 James_F: only one of them affects only VE.
[20:22:52] <James_F>	 MatmaRex: There are three.
[20:22:52] <James_F>	 https://gerrit.wikimedia.org/r/#/q/status:open+project:oojs/ui+-message:WIP,n,z
[20:23:07] <MatmaRex>	 argh. the dashboard has limit:10
[20:23:33] <James_F>	 The OOjs UI (default) dashboard also only looks for ones touched in the last three weeks.
[20:23:35] <MatmaRex>	 we can safely do that one too, it probably affects nothing
[20:23:48] <MatmaRex>	 (the VE dashboard https://gerrit.wikimedia.org/r/#/projects/mediawiki/extensions/VisualEditor,dashboards/custom:custom)
[20:24:29] <MatmaRex>	 James_F: when do you want to do it?
[20:25:26] <MatmaRex>	 James_F: https://phabricator.wikimedia.org/T91152 will also be a breaking change when i do it. i was going to do it this week after i deal with the RL OOUI icons finally.
[20:26:09] <James_F>	 MatmaRex: Maybe today? Depends on what you think is best.
[20:27:37] <James_F>	 MatmaRex: (if so, do you want to fix 91152 quickly or wait for 0.11.0 in a month or two?)
[20:28:11] <mooeypoo>	 MatmaRex, do you have a minute to talk about an ooui issue?
[20:28:21] <MatmaRex>	 i would want to get that fixed quickly, this has been biting us in the ass again and again
[20:28:43] <MatmaRex>	 for example https://phabricator.wikimedia.org/T96628 filed this week has that as root cause
[20:29:34] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Add viewCompact, viewDetails, visionSimulator icons for iconography page [oojs/ui] - 10https://gerrit.wikimedia.org/r/201639 (owner: 10Violetto)
[20:30:10] <James_F>	 MatmaRex: :-( We can wait a bit, but we like to give teams as much time as possible for OOjs UI change-overs – especially breaking ones.
[20:30:34] <James_F>	 MatmaRex: That said, the main teams affected are now Multimedia (with you) and Collaboration (with Roan), so…
[20:30:50] <James_F>	 (Also, we should probably talk about this in the departmental channel, I guess?)
[20:31:00] <MatmaRex>	 James_F: i don't really want to be the release manager guy for OOUI, so i'll leave the decision for you. i think we should try to do the OOUI breaking release next week, or maybe friday-ish if i get that fixed before then
[20:31:34] <James_F>	 MatmaRex: OK, that works.
[20:31:35] <MatmaRex>	 i'll put T91152 on top of my list
[20:31:42] * James_F will wait a day.
[20:31:55] <wikibugs>	 10OOjs-UI, 10VisualEditor, 10VisualEditor-MediaWiki, 10Apex, and 2 others: OOjs UI uses font-size of 12.8px (0.8×16px) for windows and toolbars, but Vector skin uses 14px (0.875×16px) for body content, creating inconsistency between widgets in windows/toolba... - https://phabricator.wikimedia.org/T91152#1229190
[20:32:02] <MatmaRex>	 mooeypoo: sure
[20:32:43] <wikibugs>	 10VisualEditor: [Regression pre-wmf3] Inspectors inside Media Settings>caption and Basic reference dialog are appearing too big - https://phabricator.wikimedia.org/T96628#1229194 (10matmarex) a:3matmarex The root cause of this is T91152 which I am hoping to solve this week.
[20:32:46] <mooeypoo>	 MatmaRex, I was looking and working on this: https://phabricator.wikimedia.org/T95470
[20:33:00] <wikibugs>	 10VisualEditor, 10Beta-Cluster: Cannot open any page with VE in Betalabs, getting error "Error loading data from server: internal_api_error_DBConnectionError: [8c78efd3] Exception Caught: DB connection error: Can't connect to MySQL: - https://phabricator.wikimedia.org/T96905#1229198 (10Ryasmeen) p:5Triage>3...
[20:33:02] <mooeypoo>	 MatmaRex, the main issue seems to be that "plain" buttons are not really set up to display text instead of their icon
[20:33:50] <mooeypoo>	 It's a CSS issue; when I have the text displayed (not hidden) it looks terrible -- i thought of copying over the styling of the toolGroup css, but that refers to "title" while the group has "label" (or vice versa?)
[20:34:11] <mooeypoo>	 which makes adjusting the css a bit of a mess, which also suggests it might not be the right way of doing it
[20:34:11] <MatmaRex>	 "plain" buttons?
[20:34:25] <mooeypoo>	 MatmaRex, citoid is just an OO.ui.InspectorTool
[20:34:32] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add viewCompact, viewDetails, visionSimulator icons for iconography page [oojs/ui] - 10https://gerrit.wikimedia.org/r/201639 (owner: 10Violetto)
[20:34:33] <mooeypoo>	 it's inside a tool group tool thing
[20:34:39] <mooeypoo>	 but it's not in itself a group tool
[20:34:47] <mooeypoo>	 the labels seem to work on the dropdown menus 
[20:34:57] <mooeypoo>	 not on "regular" OO.ui.Tool
[20:35:04] <MatmaRex>	 hmm.
[20:35:07] <MatmaRex>	 ooooh. right.
[20:35:50] <MatmaRex>	 yes, Tools in a 'bar' ToolGroup only ever display their icons, never the label.
[20:36:08] <MatmaRex>	 (which is obviously bad in this case)
[20:37:23] <MatmaRex>	 hmm. so, we should probably make them display the label instead if the icon is not present
[20:37:31] <MatmaRex>	 mooeypoo: would that make sense?
[20:38:19] <MatmaRex>	 it kind of sucks though. for Tools, we reuse the label - sometimes as actual text label, sometimes as title text (tooltip)
[20:39:37] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-References, 3Editing Department 2014/15 Q4 blockers: Replace cite icon with "cite" label in toolbar - https://phabricator.wikimedia.org/T95470#1229243 (10matmarex)
[20:40:58] <grrrit-wm>	 (03CR) 10Violetto: "The images should be pure black. If they're not, something must have happened to change that." [oojs/ui] - 10https://gerrit.wikimedia.org/r/201639 (owner: 10Violetto)
[20:42:57] <mooeypoo>	 MatmaRex, that makes sense
[20:44:30] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "viewCompact and viewDetails were #01010101, for some reason. I corrected it." [oojs/ui] - 10https://gerrit.wikimedia.org/r/201639 (owner: 10Violetto)
[20:44:41] <MatmaRex>	 okay. that actually looks fairly simple to do
[20:46:06] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: BarToolGroup: Remove repeated code [oojs/ui] - 10https://gerrit.wikimedia.org/r/205965 
[20:51:57] <Krinkle>	 James_F: roundtrip testing
[20:53:06] <James_F>	 Krinkle: edsanders?
[21:01:54] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: BarToolGroup: Allow tools with labels instead of icons [oojs/ui] - 10https://gerrit.wikimedia.org/r/205974 (https://phabricator.wikimedia.org/T95470) 
[21:01:55] <MatmaRex>	 mooeypoo: ^
[21:02:38] <mooeypoo>	 MatmaRex, I think that another (probably smaller) issue to consider is to make the difference between label and title a lot more consistent. That way, an OO.ui.Tool can display *both* icon and label if we want it to (which we might) but still have "title" always configured as a popup
[21:02:40] <mooeypoo>	 if that makes sense?
[21:02:50] <mooeypoo>	 ooh that was fast
[21:02:50] <MatmaRex>	 yes, it does
[21:02:56] <MatmaRex>	 Tool is borked this way
[21:03:21] <MatmaRex>	 i think James_F used to have a patch that tried to do this
[21:04:42] <MatmaRex>	 by the way, i have a few trivial/documentation patchs in OOUI. anyone care to review? https://gerrit.wikimedia.org/r/204107 https://gerrit.wikimedia.org/r/205298 https://gerrit.wikimedia.org/r/204981 https://gerrit.wikimedia.org/r/205965
[21:05:22] <wikibugs>	 10VisualEditor: [Regression pre-wmf3] Inspectors inside Media Settings>caption and Basic reference dialog are appearing too big - https://phabricator.wikimedia.org/T96628#1229346 (10matmarex) p:5Triage>3High
[21:05:27] <wikibugs>	 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki, 5Patch-For-Review: Special characters menu in VisualEditor does not include en dash - https://phabricator.wikimedia.org/T95819#1229348 (10matmarex) p:5Triage>3Normal
[21:05:31] <wikibugs>	 10OOjs-UI, 5Patch-For-Review: ToggleWidget should be an abstract superclass, line InputWidget, not a mixin - https://phabricator.wikimedia.org/T96674#1229350 (10matmarex) p:5Triage>3Normal
[21:06:18] <mooeypoo>	 MatmaRex, I'm testing your patch against Citoid to see if it works there as expected
[21:06:34] <MatmaRex>	 yep, thanks. i only gave it a cursory look in the OOUI demo
[21:09:07] <mooeypoo>	 MatmaRex, it doesn't work
[21:09:23] <Krenair>	 James_F, alright, I'll test it now
[21:09:27] <MatmaRex>	 it ought to!
[21:09:34] <mooeypoo>	 MatmaRex, in Citoid's ve.ui.CiteFromIdInspectorTool.js I remove ve.ui.CiteFromIdInspectorTool.static.icon = 'reference';
[21:09:38] <James_F>	 Krenair: Thanks.
[21:09:45] <mooeypoo>	 MatmaRex, it still has both title and label
[21:09:49] <mooeypoo>	 and yet, in the toolbar, it's empty
[21:10:25] <Krenair>	 If I can remember which characters we were doing this change for...
[21:11:03] <mooeypoo>	 MatmaRex, to be fair, when I was playing around with this a couple of days ago, I added "oo-ui-tool-textual" and then a :not( .oo-ui-tool-textual ) in all the css rules that had display: none; on them
[21:11:23] <MatmaRex>	 maybe VE's tools do some special magic. looking
[21:11:39] <mooeypoo>	 MatmaRex, that's probably going to make things much more complicated, but I did discover the issue with title/label and the fact that it hides the title in the regular tools
[21:12:38] <T13|mobile>	 Sorry mooeypoo, your nick always makes me chuckle.
[21:12:57] <mooeypoo>	 T13|mobile, i'll take that as a compliment. I'm very amusing.
[21:13:37] <Krenair>	 oh I remember
[21:14:36] <T13|mobile>	 The 'ey' gets omitted in my head and your nick becomes a moonpie
[21:16:05] <mooeypoo>	 Who was it that was amused by my switch of lunch nicks? From 'mooey|lunch' to 'mooeypoo' ? I think your mental omission is better....
[21:16:28] <T13|mobile>	 http://www.urbandictionary.com/define.php?term=Moo+Poo
[21:16:36] <RoanKattouw>	 I don't remember who pointed it out, but I thought the most hilarious thing about your nick was that it basically means BS
[21:16:41] <MatmaRex>	 D:
[21:16:53] <grrrit-wm>	 (03CR) 10Jforrester: "> except flags – I'm not sure if ButtonOptionWidget should accept flags at all" [oojs/ui] - 10https://gerrit.wikimedia.org/r/204981 (https://phabricator.wikimedia.org/T88637) (owner: 10Bartosz Dziewoński)
[21:16:59] <mooeypoo>	 O.O
[21:17:10] <Krenair>	 PHP Notice:  Undefined index: file in /home/alex/Development/MediaWiki/includes/resourceloader/ResourceLoaderImageModule.php on line 180
[21:17:10] <Krenair>	 hm
[21:17:13] <mooeypoo>	 RoanKattouw, indeed, that's the point of it 
[21:17:40] <mooeypoo>	 Though it seems urbandictionary made that one its least favorite definition
[21:18:22] * T13|mobile wanders off now...
[21:18:51] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-References, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review: Replace cite icon with "cite" label in toolbar - https://phabricator.wikimedia.org/T95470#1229374 (10Jdforrester-WMF) a:3Mooeypoo
[21:19:51] <Krenair>	 I think my dev wiki is completely broken
[21:20:25] <James_F>	 Krenair: Is /vendor up to date?
[21:20:38] <Krenair>	 no
[21:20:50] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki-Mobile, 7Browser-Support-Apple-Safari, 3Editing Department 2014/15 Q4 blockers: VisualEditor: Safari on iPad converts numbers that resemble phone numbers to href=tel: links - https://phabricator.wikimedia.org/T55315#1229377 (10Jdforr...
[21:21:45] <MatmaRex>	 mooeypoo: hmm, it works for me. i don't have citoid set up, but i tested by removing the .icon from BoldAnnotationTool in VE standalone
[21:21:46] <James_F>	 Krenair: That'd break some things, probably.
[21:23:41] <MatmaRex>	 mooeypoo: http://i.imgur.com/pbpVKo0.png
[21:24:20] <mooeypoo>	 MatmaRex, I'm an idiot, I forgot to build and copy to my devwiki
[21:24:23] <mooeypoo>	 trying again
[21:24:31] <James_F>	 :-)
[21:24:46] <Krenair>	 James_F, well it's not that
[21:24:48] <Krenair>	 Maybe MatmaRex knows?
[21:26:01] <MatmaRex>	 hm?
[21:26:47] <Krenair>	 I appear to be getting no JS on my local wiki
[21:27:00] <mooeypoo>	 MatmaRex, I take it back, you rock, it works
[21:27:06] <Krenair>	 And I have warnings pointing to ResourceLoaderImageModule in my error log
[21:27:10] <mooeypoo>	 MatmaRex, only small thing -- the button has an underline on hover
[21:27:38] <James_F>	 mooeypoo: Is that not intended?
[21:27:45] <MatmaRex>	 Krenair: do you have old MobileFrontend or Gather exts?
[21:27:51] <Krenair>	 probably
[21:28:19] <mooeypoo>	 James_F, it looks different than the "insert" button
[21:28:24] <James_F>	 Ah.
[21:28:36] <mooeypoo>	 If that is intended, then that's fine, but I wasn't sure it is?
[21:29:21] <MatmaRex>	 Krenair: there was a backwards-incompatible change to ResourceLoaderImageModule's definition format. update these.
[21:29:52] <Krenair>	 MatmaRex, that looks better!
[21:31:21] <MatmaRex>	 mooeypoo: hmm
[21:31:31] <MatmaRex>	 it should have text-decoration: none;
[21:32:11] <mooeypoo>	 MatmaRex, on hover, it's ignoring that 
[21:32:29] <Krenair>	 MatmaRex, it seems to work as well
[21:32:30] <Krenair>	 thank you!
[21:33:07] <MatmaRex>	 mooeypoo: you should be getting underlines on the dropdown menu items, then, too?
[21:33:09] <MatmaRex>	 Krenair: :)
[21:33:16] <mooeypoo>	 MatmaRex, I am not.
[21:33:19] <MatmaRex>	 i have no underlines anywhere
[21:33:33] <Krenair>	 TrevorParscal?
[21:34:00] <mooeypoo>	 MatmaRex, not sure what to say.. the "Cite" button now has underline when I hover oer it
[21:34:11] <MatmaRex>	 oh, wait
[21:34:24] <MatmaRex>	 indeed it should have an underline, per the current CSS
[21:34:34] <MatmaRex>	 no idea why i'm not seeing any
[21:35:41] <MatmaRex>	 amending
[21:37:02] <grrrit-wm>	 (03PS2) 10Bartosz Dziewoński: BarToolGroup: Allow tools with labels instead of icons [oojs/ui] - 10https://gerrit.wikimedia.org/r/205974 (https://phabricator.wikimedia.org/T95470) 
[21:37:03] <MatmaRex>	 mooeypoo: that ^ should be better
[21:37:50] <mooeypoo>	 MatmaRex, testing
[21:38:27] <mooeypoo>	 MatmaRex, perfect
[21:39:46] <mooeypoo>	 MatmaRex, I know that the toolbar stuff is planned to be refactored, but in general i think it might be a good idea to also allow a button to have *both* icon and label if it should
[21:39:58] <mooeypoo>	 in this case it really doesn't need it, but just mentioning for the record
[21:40:19] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 3Editing Department 2014/15 Q4 blockers: Make VisualEditor primary (first editor tab) on the English Wikipedia for people for whom it's enabled - https://phabricator.wikimedia.org/T92895#1229428 (10Jdforrester-WMF) In the weekly triage on 2015-04-22, this task was di...
[21:40:30] <MatmaRex>	 yeah, it would be reasonable
[21:40:31] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 10Wikimedia-Site-requests: Make VisualEditor primary (first editor tab) on the English Wikipedia for people for whom it's enabled - https://phabricator.wikimedia.org/T92895#1229429 (10Jdforrester-WMF) p:5Normal>3Low
[21:40:45] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: VisualEditor Mobile: Double clicking on citation note in Mobile using desktop Safari opens up the Basic reference dialog which was explicitly disabled for Mobile - https://phabricator.wikimedia.org/T74407#1229431 (10Jdforrester-WMF)
[21:40:45] <MatmaRex>	 no idea when that refactoring is likely to happen, though
[21:41:14] <MatmaRex>	 (alas)
[21:41:15] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers: Make VisualEditor good enough for mobile tablet and phone enablement - https://phabricator.wikimedia.org/T94725#1229437 (10Jdforrester-WMF)
[21:41:15] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: VisualEditor Mobile: Double clicking on citation note in Mobile using desktop Safari opens up the Basic reference dialog which was explicitly disabled for Mobile - https://phabricator.wikimedia.org/T74407#1229434 (10Jdforrester-WMF) 5Open>3declined a:3Jdfor...
[21:41:38] <wikibugs>	 10Citoid, 10VisualEditor: Empty <ref /> tag added using Citoid in VisualEditor (?) - https://phabricator.wikimedia.org/T96052#1229438 (10Jdforrester-WMF)
[21:41:56] <wikibugs>	 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-22_(1.26wmf3): "Undo" only undoes Citoid's addition of content, not the whole ref (aka Citoid inserts empty <ref/> tags) - https://phabricator.wikimedia.org/T96120#1229440 (10Jdforre...
[21:41:57] <wikibugs>	 10Citoid, 10VisualEditor: Empty <ref /> tag added using Citoid in VisualEditor (?) - https://phabricator.wikimedia.org/T96052#1207172 (10Jdforrester-WMF)
[21:42:21] <wikibugs>	 10Citoid, 10VisualEditor: Empty <ref /> tag added using Citoid in VisualEditor (?) - https://phabricator.wikimedia.org/T96052#1207172 (10Jdforrester-WMF) In the weekly triage on 2015-04-22, this task was discussed. We considered that it was likely this was a dupe of {T96120}, and after testing that appears to...
[21:42:57] <grrrit-wm>	 (03PS1) 10Mooeypoo: Change Citoid's tool from icon to label [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/205981 (https://phabricator.wikimedia.org/T95470) 
[21:43:00] <James_F>	 MatmaRex: When you get around to it! ;-)
[21:43:07] <James_F>	 MatmaRex: (Not serious.)
[21:43:09] <MatmaRex>	 rrrrright.
[21:43:55] <MatmaRex>	 i have hoping TrevorParscal would do it, but he's management now :P (the lazy bum :>)
[21:44:01] <James_F>	 MatmaRex: :-)
[21:44:10] <MatmaRex>	 James_F: are you bored? i have a few trivial/documentation patches in OOUI. https://gerrit.wikimedia.org/r/204107 https://gerrit.wikimedia.org/r/205298 https://gerrit.wikimedia.org/r/204981 https://gerrit.wikimedia.org/r/205965
[21:44:10] <grrrit-wm>	 (03CR) 10Mooeypoo: [C: 031] "wfm and works in citoid." [oojs/ui] - 10https://gerrit.wikimedia.org/r/205974 (https://phabricator.wikimedia.org/T95470) (owner: 10Bartosz Dziewoński)
[21:44:13] <James_F>	 MatmaRex: You'll have to find your own minion and convince them.
[21:44:30] <James_F>	 MatmaRex: Sure.
[21:44:33] <James_F>	 mooeypoo: Not +2?
[21:44:47] <mooeypoo>	 James_F, I meant to +2
[21:44:59] <grrrit-wm>	 (03CR) 10Mooeypoo: [C: 032] BarToolGroup: Allow tools with labels instead of icons [oojs/ui] - 10https://gerrit.wikimedia.org/r/205974 (https://phabricator.wikimedia.org/T95470) (owner: 10Bartosz Dziewoński)
[21:45:04] <James_F>	 :-)
[21:45:12] <mooeypoo>	 :D whoops
[21:45:26] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Better document how FormLayout and InputWidgets work together [oojs/ui] - 10https://gerrit.wikimedia.org/r/204107 (https://phabricator.wikimedia.org/T95853) (owner: 10Bartosz Dziewoński)
[21:45:31] * mooeypoo thanks James_F 
[21:45:43] <James_F>	 :-)
[21:46:20] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] BarToolGroup: Remove repeated code [oojs/ui] - 10https://gerrit.wikimedia.org/r/205965 (owner: 10Bartosz Dziewoński)
[21:46:36] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] MenuLayout: Remove some redundant code [oojs/ui] - 10https://gerrit.wikimedia.org/r/205298 (owner: 10Bartosz Dziewoński)
[21:46:52] <wikibugs>	 10OOjs-UI, 5OOjs-UI-next-release, 3Editing Department 2014/15 Q4 blockers: Better document how FormLayout and InputWidgets work together - https://phabricator.wikimedia.org/T95853#1229461 (10Jdforrester-WMF) 5Open>3Resolved
[21:46:58] <wikibugs>	 10OOjs-UI, 5OOjs-UI-next-release, 3Editing Department 2014/15 Q4 blockers: Better document how FormLayout and InputWidgets work together - https://phabricator.wikimedia.org/T95853#1201723 (10Jdforrester-WMF)
[21:47:19] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] "Meh." [oojs/ui] - 10https://gerrit.wikimedia.org/r/204981 (https://phabricator.wikimedia.org/T88637) (owner: 10Bartosz Dziewoński)
[21:47:47] <wikibugs>	 10OOjs-UI, 5OOjs-UI-next-release, 10UI-Standardization, 7Design, 3Editing Department 2014/15 Q4 blockers: ButtonGroupWidget use cases - https://phabricator.wikimedia.org/T88637#1229473 (10Jdforrester-WMF) p:5Triage>3Normal a:3matmarex
[21:47:54] <wikibugs>	 10OOjs-UI, 5OOjs-UI-next-release, 10UI-Standardization, 7Design, 3Editing Department 2014/15 Q4 blockers: ButtonGroupWidget use cases - https://phabricator.wikimedia.org/T88637#1016666 (10Jdforrester-WMF)
[21:48:30] <MatmaRex>	 thanks James_F
[21:48:36] <grrrit-wm>	 (03Merged) 10jenkins-bot: Better document how FormLayout and InputWidgets work together [oojs/ui] - 10https://gerrit.wikimedia.org/r/204107 (https://phabricator.wikimedia.org/T95853) (owner: 10Bartosz Dziewoński)
[21:49:23] <grrrit-wm>	 (03CR) 10Jforrester: [C: 04-1] "This is verging on a breaking change; we intentionally didn't replace the wrong icons with each other unless they were a good visual as we" [oojs/ui] - 10https://gerrit.wikimedia.org/r/196206 (owner: 10Prtksxna)
[21:49:54] <grrrit-wm>	 (03Merged) 10jenkins-bot: BarToolGroup: Remove repeated code [oojs/ui] - 10https://gerrit.wikimedia.org/r/205965 (owner: 10Bartosz Dziewoński)
[21:49:56] <grrrit-wm>	 (03Merged) 10jenkins-bot: BarToolGroup: Allow tools with labels instead of icons [oojs/ui] - 10https://gerrit.wikimedia.org/r/205974 (https://phabricator.wikimedia.org/T95470) (owner: 10Bartosz Dziewoński)
[21:50:12] <grrrit-wm>	 (03Merged) 10jenkins-bot: MenuLayout: Remove some redundant code [oojs/ui] - 10https://gerrit.wikimedia.org/r/205298 (owner: 10Bartosz Dziewoński)
[21:50:17] <grrrit-wm>	 (03CR) 10Jforrester: [C: 04-1] "Needs to pass its tests. :-)" [oojs/ui] - 10https://gerrit.wikimedia.org/r/205006 (https://phabricator.wikimedia.org/T91565) (owner: 10Bartosz Dziewoński)
[21:51:06] <grrrit-wm>	 (03PS3) 10Jforrester: [BREAKING CHANGE] ButtonWidget: remove deprecated nofollow option alias [oojs/ui] - 10https://gerrit.wikimedia.org/r/191204 (https://phabricator.wikimedia.org/T89767) (owner: 10Cscott)
[21:51:30] <grrrit-wm>	 (03CR) 10Jforrester: "I think 0.10.0 is due to arrive around now, so removing my -2." [oojs/ui] - 10https://gerrit.wikimedia.org/r/191204 (https://phabricator.wikimedia.org/T89767) (owner: 10Cscott)
[21:51:59] <grrrit-wm>	 (03Merged) 10jenkins-bot: demo: Simplify ButtonGroupWidget and ButtonSelectWidget examples [oojs/ui] - 10https://gerrit.wikimedia.org/r/204981 (https://phabricator.wikimedia.org/T88637) (owner: 10Bartosz Dziewoński)
[21:52:01] <James_F>	 MatmaRex: Can I grab CR on https://gerrit.wikimedia.org/r/#/c/204414/ please?
[21:52:15] <grrrit-wm>	 (03Abandoned) 10Jforrester: [WIP] [BREAKING CHANGE] Make all Elements flaggable, and scrap the FlaggedElement mixin [oojs/ui] - 10https://gerrit.wikimedia.org/r/164007 (owner: 10Jforrester)
[21:52:46] <cscott>	 James_F: before you bump major versions, probably look at https://gerrit.wikimedia.org/r/200195
[21:53:16] <cscott>	 MatmaRex: you might want to look at that one, too, in case there are any PHP-side renames I missed.
[21:53:17] <James_F>	 cscott: I'm not about to do the release, worry not.
[21:53:30] <cscott>	 i'm just sayin' that patch is growing grey hair
[21:53:35] <MatmaRex>	 James_F: yes, -1, causes exception when opening the deom
[21:53:46] <James_F>	 MatmaRex: Good reason to CR. :-)
[21:54:12] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 04-1] "Causes exception when opening the demo, some of setValue/setItemByValue calls are mixed up?" [oojs/ui] - 10https://gerrit.wikimedia.org/r/204414 (https://phabricator.wikimedia.org/T87602) (owner: 10Mooeypoo)
[21:58:30] <grrrit-wm>	 (03PS1) 1020after4: Returning boolean falsy value here breaks mergeMessageFileList.php [extensions/CiteThisPage] (wmf/1.26wmf3) - 10https://gerrit.wikimedia.org/r/205987 
[21:58:31] <grrrit-wm>	 (03PS1) 1020after4: Returning boolean falsy value here breaks mergeMessageFileList.php [extensions/CiteThisPage] (wmf/1.26wmf3) - 10https://gerrit.wikimedia.org/r/205987 
[21:58:52] <grrrit-wm>	 (03PS1) 1020after4: Returning boolean falsy value here breaks mergeMessageFileList.php [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/205988 
[21:58:53] <grrrit-wm>	 (03PS1) 1020after4: Returning boolean falsy value here breaks mergeMessageFileList.php [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/205988 
[22:00:54] <grrrit-wm>	 (03CR) 1020after4: [C: 032] Returning boolean falsy value here breaks mergeMessageFileList.php [extensions/CiteThisPage] (wmf/1.26wmf3) - 10https://gerrit.wikimedia.org/r/205987 (owner: 1020after4)
[22:00:55] <grrrit-wm>	 (03CR) 1020after4: [C: 032] Returning boolean falsy value here breaks mergeMessageFileList.php [extensions/CiteThisPage] (wmf/1.26wmf3) - 10https://gerrit.wikimedia.org/r/205987 (owner: 1020after4)
[22:01:08] <grrrit-wm>	 (03Merged) 10jenkins-bot: Returning boolean falsy value here breaks mergeMessageFileList.php [extensions/CiteThisPage] (wmf/1.26wmf3) - 10https://gerrit.wikimedia.org/r/205987 (owner: 1020after4)
[22:01:09] <grrrit-wm>	 (03Merged) 10jenkins-bot: Returning boolean falsy value here breaks mergeMessageFileList.php [extensions/CiteThisPage] (wmf/1.26wmf3) - 10https://gerrit.wikimedia.org/r/205987 (owner: 1020after4)
[22:01:35] <Krenair>	 TrevorParscal, I checked, it was going to be either the 16th or the 17th. It's on the google doc but not my calendar (yet)
[22:02:44] <Krenair>	 (and it's now on my calendars)
[22:04:31] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-References, 3Editing Department 2014/15 Q4 blockers: Replace cite icon with "cite" label in toolbar - https://phabricator.wikimedia.org/T95470#1229518 (10matmarex)
[22:04:47] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-References, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review: Replace cite icon with "cite" label in toolbar - https://phabricator.wikimedia.org/T95470#1191562 (10matmarex)
[22:06:15] <wikibugs>	 10Citoid, 10VisualEditor: Evaluate citoid's  for citations used on Wikimedia sites - https://phabricator.wikimedia.org/T96927#1229521 (10gpaumier) 3NEW a:3gpaumier
[22:07:51] <RoanKattouw>	 guillom: "Evaluate Citoid's [missing noun] for citations"
[22:08:14] <guillom>	 RoanKattouw: thanks; fixing now
[22:08:46] <wikibugs>	 10Citoid, 10VisualEditor: Evaluate citoid for citations used on Wikimedia sites - https://phabricator.wikimedia.org/T96927#1229538 (10gpaumier)
[22:08:59] <guillom>	 I couldn't figure out what noun I wanted there in the first place so I cheated :)
[22:09:43] <wikibugs>	 10VisualEditor, 6Community-Liaison, 10WMF-Product-Strategy: Support VisualEditor rollout with research and analyses - https://phabricator.wikimedia.org/T93394#1229544 (10gpaumier)
[22:09:44] <wikibugs>	 10Citoid, 10VisualEditor: Evaluate citoid for citations used on Wikimedia sites - https://phabricator.wikimedia.org/T96927#1229521 (10gpaumier)
[22:09:45] <Krenair>	 James_F, MatmaRex: I think https://gerrit.wikimedia.org/r/#/c/205556/ and the commits that depend on it are fine
[22:09:49] <Krenair>	 Not sure whether to +1 or +2
[22:10:48] <MatmaRex>	 edsanders reviewed some
[22:11:43] <grrrit-wm>	 (03CR) 10Alex Monk: [C: 032] ve.ui.SpecialCharacterDialog: Allow encapsulation of selected content [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205556 (https://phabricator.wikimedia.org/T65227) (owner: 10Bartosz Dziewoński)
[22:14:15] <grrrit-wm>	 (03CR) 10Alex Monk: [C: 031] "Let's merge this when the dependencies get pulled in" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/205558 (https://phabricator.wikimedia.org/T65227) (owner: 10Bartosz Dziewoński)
[22:14:47] <grrrit-wm>	 (03Merged) 10jenkins-bot: ve.ui.SpecialCharacterDialog: Allow encapsulation of selected content [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205556 (https://phabricator.wikimedia.org/T65227) (owner: 10Bartosz Dziewoński)
[22:18:37] <Krenair>	 ryasmeen, hey
[22:18:38] <Krenair>	 you there?
[22:18:48] <ryasmeen>	 Hey Krenair
[22:19:11] <Krenair>	 I've been looking through the mobile tickets but have had difficulty reproducing some of them
[22:19:15] <Krenair>	 like https://phabricator.wikimedia.org/T68756
[22:20:07] <Krenair>	 I checked and I could definitely save on my Android 4.3 phone
[22:20:26] <ryasmeen>	 hmm yeah, these are all quite old bugs as you can see. I will have to go through them one by one and check whether they are reproducible
[22:20:34] <Krenair>	 ryasmeen, could you re-check that one?
[22:21:09] <ryasmeen>	 I dont have any android device right now at home, but I will check it tomorrow and can get back to you on this.
[22:21:15] <ryasmeen>	 is that okay?
[22:21:30] <grrrit-wm>	 (03PS2) 10Alex Monk: ve.ui.SpecialCharacterPage: Allow providing a tooltip for characters [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205557 (https://phabricator.wikimedia.org/T70425) (owner: 10Bartosz Dziewoński)
[22:22:08] <grrrit-wm>	 (03CR) 10Alex Monk: [C: 032] ve.ui.SpecialCharacterPage: Allow providing a tooltip for characters [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205557 (https://phabricator.wikimedia.org/T70425) (owner: 10Bartosz Dziewoński)
[22:22:19] <Krenair>	 That's fine of course, thanks ryasmeen 
[22:23:44] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] ve.ui.SpecialCharacterPage: Allow providing a tooltip for characters [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205557 (https://phabricator.wikimedia.org/T70425) (owner: 10Bartosz Dziewoński)
[22:26:06] <Krenair>	 22:23:41 npm ERR! EEXIST, symlink '../esprima/bin/esparse.js'
[22:26:06] <Krenair>	 22:23:41 File exists: ../esprima/bin/esparse.js
[22:26:06] <Krenair>	 22:23:41 Move it away, and try again. 
[22:26:08] <Krenair>	 Krinkle?
[22:33:11] <wikibugs>	 10VisualEditor, 3Editing Department 2014/15 Q4 blockers: Perform a weekly review of edits made with VisualEditor - https://phabricator.wikimedia.org/T94767#1229622 (10gpaumier)
[22:33:29] <wikibugs>	 10VisualEditor, 6Community-Liaison: Support VisualEditor rollout with research and analyses - https://phabricator.wikimedia.org/T93394#1229623 (10gpaumier)
[22:40:01] <Krenair>	 wtf, why does chrome's device inspector close as soon as I enter a command into the console?
[22:55:02] <grrrit-wm>	 (03CR) 10BryanDavis: [C: 031] Returning boolean falsy value here breaks mergeMessageFileList.php (031 comment) [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/205988 (owner: 1020after4)
[22:55:03] <grrrit-wm>	 (03CR) 10BryanDavis: [C: 031] Returning boolean falsy value here breaks mergeMessageFileList.php (031 comment) [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/205988 (owner: 1020after4)
[22:56:44] <grrrit-wm>	 (03CR) 10Jforrester: [C: 031] Change Citoid's tool from icon to label [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/205981 (https://phabricator.wikimedia.org/T95470) (owner: 10Mooeypoo)
[22:57:46] <James_F>	 Krenair: Because it loves you?
[22:58:09] <Krenair>	 It's incredibly unhelpful when you're trying to test things against a mobile device
[22:58:26] <James_F>	 Yeah.
[22:58:32] <James_F>	 Though be careful.
[22:58:47] <James_F>	 The device simulator isn't very accurate.
[22:59:01] <James_F>	 (We really need to ship you a phone and tablet.)
[22:59:35] <RoanKattouw>	 Krenair: When you get a Jenkins failure like that, just rerun it, it's a race condition in npm / esprima
[22:59:52] <Krenair>	 Yeah it ran twice and succeeded the second time
[23:00:19] <Krenair>	 James_F, it was against my actual phone with the isWideScreen check commented out
[23:00:37] <James_F>	 Krenair: Ah, fun.
[23:00:47] <James_F>	 Krenair: The remote-debugger-over-USB feature is rather neat.
[23:00:53] <Krenair>	 Yeah. When it works.
[23:01:01] <James_F>	 :-)
[23:18:33] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Returning boolean falsy value here breaks mergeMessageFileList.php [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/205988 (owner: 1020after4)
[23:18:34] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Returning boolean falsy value here breaks mergeMessageFileList.php [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/205988 (owner: 1020after4)
[23:19:36] <Krinkle>	 Krenair: esprima happens every now and then since almost 6 months now. Race condition in npm-install. Filed upstream, they're workkng on it. Just try again.
[23:20:15] <grrrit-wm>	 (03CR) 10Alex Monk: [C: 032] ve.ui.SpecialCharacterPage: Allow providing a tooltip for characters [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205557 (https://phabricator.wikimedia.org/T70425) (owner: 10Bartosz Dziewoński)
[23:20:25] <grrrit-wm>	 (03PS1) 10Jforrester: Update VE core submodule to master (10da24e) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/206010 
[23:20:41] <James_F>	 Ha.
[23:21:02] <grrrit-wm>	 (03CR) 10Jforrester: [C: 04-1] "Belay this, there's another patch just landing." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/206010 (owner: 10Jforrester)
[23:22:34] <grrrit-wm>	 (03CR) 10Esanders: [C: 031] [BREAKING CHANGE] ButtonWidget: remove deprecated nofollow option alias [oojs/ui] - 10https://gerrit.wikimedia.org/r/191204 (https://phabricator.wikimedia.org/T89767) (owner: 10Cscott)
[23:22:55] <James_F>	 edsanders: Should JFDI and merge the three breaking changes at once?
[23:23:13] <grrrit-wm>	 (03Merged) 10jenkins-bot: Returning boolean falsy value here breaks mergeMessageFileList.php [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/205988 (owner: 1020after4)
[23:23:14] <grrrit-wm>	 (03Merged) 10jenkins-bot: Returning boolean falsy value here breaks mergeMessageFileList.php [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/205988 (owner: 1020after4)
[23:23:18] <grrrit-wm>	 (03Merged) 10jenkins-bot: ve.ui.SpecialCharacterPage: Allow providing a tooltip for characters [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205557 (https://phabricator.wikimedia.org/T70425) (owner: 10Bartosz Dziewoński)
[23:23:42] <edsanders>	 just deferring to your release plan
[23:45:09] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] [BREAKING CHANGE] Convert ToggleWidget from a mixin to an abstract class [oojs/ui] - 10https://gerrit.wikimedia.org/r/205601 (https://phabricator.wikimedia.org/T96674) (owner: 10Bartosz Dziewoński)
[23:45:51] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] [BREAKING CHANGE] ButtonWidget: remove deprecated nofollow option alias [oojs/ui] - 10https://gerrit.wikimedia.org/r/191204 (https://phabricator.wikimedia.org/T89767) (owner: 10Cscott)
[23:47:06] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] [BREAKING CHANGE] MenuLayout: Reimplement without inline styles [oojs/ui] - 10https://gerrit.wikimedia.org/r/198565 (owner: 10Bartosz Dziewoński)
[23:48:37] <grrrit-wm>	 (03CR) 10Jforrester: "Trevor says he will work on this tomorrow with Bartosz and C. Scott. We'll skip it for this week's release, and probably do it next week i" [oojs/ui] - 10https://gerrit.wikimedia.org/r/200195 (owner: 10Cscott)
[23:49:05] <Krinkle>	 Krenair: James_F: Actually, upstream jscs followed my recommendation. Now awaiting release propagation
[23:49:16] <Krenair>	 yay
[23:49:21] <Krinkle>	 and we'll need to do a train of updates everywhere as well after
[23:49:23] <James_F>	 Krinkle: Gosh, really? Wow.
[23:49:34] <James_F>	 edsanders: Trevor said yes, so that's what we're doing.
[23:49:39] <grrrit-wm>	 (03Merged) 10jenkins-bot: [BREAKING CHANGE] Convert ToggleWidget from a mixin to an abstract class [oojs/ui] - 10https://gerrit.wikimedia.org/r/205601 (https://phabricator.wikimedia.org/T96674) (owner: 10Bartosz Dziewoński)
[23:50:28] <grrrit-wm>	 (03Merged) 10jenkins-bot: [BREAKING CHANGE] ButtonWidget: remove deprecated nofollow option alias [oojs/ui] - 10https://gerrit.wikimedia.org/r/191204 (https://phabricator.wikimedia.org/T89767) (owner: 10Cscott)
[23:50:30] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] MenuLayout: Reimplement without inline styles [oojs/ui] - 10https://gerrit.wikimedia.org/r/198565 (owner: 10Bartosz Dziewoński)
[23:50:33] <Krinkle>	 James_F: https://github.com/jscs-dev/esprima-harmony/commit/514426ff149aa7b402e00a812aa0e85656271542
[23:51:03] <James_F>	 Krinkle: Yay. ETA?
[23:51:12] <James_F>	 (Release cycle dance.)
[23:56:06] <Krinkle>	 James_F: I'm not sure, he usually does it right after a fix like this, but it's been 4 days.