[00:03:01] Meh. [00:04:22] 10OOjs-UI, 5OOjs-UI-next-release, 3Editing Department 2014/15 Q4 blockers, 7Technical-Debt: ToggleWidget should be an abstract superclass, line InputWidget, not a mixin - https://phabricator.wikimedia.org/T96674#1229829 (10Jdforrester-WMF) 5Open>3Resolved [00:04:24] mooeypoo: Can I get your input on something? [00:04:39] 10OOjs-UI, 5OOjs-UI-next-release, 3Editing Department 2014/15 Q4 blockers, 7Technical-Debt: ToggleWidget should be an abstract superclass, line InputWidget, not a mixin - https://phabricator.wikimedia.org/T96674#1224211 (10Jdforrester-WMF) [00:04:51] 10OOjs-UI, 5OOjs-UI-next-release, 3Editing Department 2014/15 Q4 blockers, 7Technical-Debt: ToggleWidget should be an abstract superclass, like InputWidget, not a mixin - https://phabricator.wikimedia.org/T96674#1229833 (10Jdforrester-WMF) [00:04:52] mooey|mtg: Does this look right to you? https://i.imgur.com/5Zh94Ep.png [00:04:58] Deskana: Wrong channel. :-) [00:04:59] Deskana: She's headed down to R32 for a meeting with me right now [00:05:00] I'll show her [00:05:06] RoanKattouw: Cool, thanks. [00:05:18] James_F: What channel should I use, oh glorious one? [00:05:29] Deskana: #wikimedia-collaboration, or #wikimedia-editing [00:05:48] #mediawiki-visualeditor-deprecated [00:05:54] 10OOjs-UI, 5OOjs-UI-next-release, 3Editing Department 2014/15 Q4 blockers, 7developer-notice: Remove deprecated `nofollow` config option - https://phabricator.wikimedia.org/T89767#1229834 (10Jdforrester-WMF) 5Open>3Resolved [00:06:00] No no, this team still exists [00:06:09] It's just she's better than us now. :-) [00:06:18] 10OOjs-UI, 5OOjs-UI-next-release, 3Editing Department 2014/15 Q4 blockers, 7developer-notice: Remove deprecated `nofollow` config option - https://phabricator.wikimedia.org/T89767#1044961 (10Jdforrester-WMF) [00:09:11] (03PS8) 10Jforrester: [BREAKING CHANGE] MenuLayout: Reimplement without inline styles [oojs/ui] - 10https://gerrit.wikimedia.org/r/198565 (owner: 10Bartosz Dziewoński) [00:10:26] James_F: Ah the notice tags in phabricator are nice! [00:10:39] I'll start using these to remind myself of announcing CI stuff as well [00:10:39] Krinkle: Yup, guillom is awesome. [00:10:45] to wikitech-l [00:12:18] (03CR) 10Jforrester: [C: 032] "PS8 is a rebase." [oojs/ui] - 10https://gerrit.wikimedia.org/r/198565 (owner: 10Bartosz Dziewoński) [00:15:24] (03Merged) 10jenkins-bot: [BREAKING CHANGE] MenuLayout: Reimplement without inline styles [oojs/ui] - 10https://gerrit.wikimedia.org/r/198565 (owner: 10Bartosz Dziewoński) [00:15:34] Deskana: Looks fine to her [00:15:36] Deskana: (With the caveat that she can't actually read Arabic) [00:15:56] RoanKattouw: Right, I was referring to the directionality, with half of the stuff in RTL and the other in LTR. That's great, thank you. :-) [00:17:03] (03PS2) 10Jforrester: Fold GroupWidget and ItemWidget into default functionality [oojs/ui] - 10https://gerrit.wikimedia.org/r/205006 (https://phabricator.wikimedia.org/T91565) (owner: 10Bartosz Dziewoński) [00:19:58] (03CR) 10jenkins-bot: [V: 04-1] Fold GroupWidget and ItemWidget into default functionality [oojs/ui] - 10https://gerrit.wikimedia.org/r/205006 (https://phabricator.wikimedia.org/T91565) (owner: 10Bartosz Dziewoński) [00:27:37] (03PS1) 10Jforrester: Tag v0.10.0 [oojs/ui] - 10https://gerrit.wikimedia.org/r/206035 [00:27:50] edsanders: Could you quickly look over ^^^ and +2? [00:32:13] James_F, RoanKattouw: http://en.wikipedia.org/api/rest_v1/page/html/San_Francisco [00:33:21] gwicke: Is that new? [00:33:34] yeah, fairly new [00:33:36] gwicke: I've seen that from Parsoid-lb before but not RESTbase I think? [00:33:38] Nice. [00:33:41] as in a couple of minutes old [00:34:00] :-D [00:34:39] I still have to tweak cache headers in RB, but once that's done we should be set to try loading directly from RB again [00:34:45] Nice. [00:34:46] hopefully without the slow-down [00:34:52] Yeah. [00:35:04] Where did you get with the Mobile App reading this? [00:35:08] (Or was it Web?) [00:35:17] it'll reuse an existing spdy connection now, and use esams if from Europe [00:35:41] you mean the app service? [00:35:56] that's hopefully going out next week [00:35:59] Nice. [00:45:11] (03PS2) 10Jforrester: Update VE core submodule to master (7f8fae5) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/206010 [00:46:11] (03PS2) 10Jforrester: Allow special characters with tooltip or that encapsulate text [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/205558 (https://phabricator.wikimedia.org/T65227) (owner: 10Bartosz Dziewoński) [00:46:29] (03CR) 10Jforrester: [C: 032] "PS2 is a rebase onto the pull-through." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/205558 (https://phabricator.wikimedia.org/T65227) (owner: 10Bartosz Dziewoński) [00:48:29] (03CR) 10Esanders: [C: 032] Tag v0.10.0 [oojs/ui] - 10https://gerrit.wikimedia.org/r/206035 (owner: 10Jforrester) [00:48:37] Thanks, edsanders. [00:52:40] (03CR) 10Alex Monk: [C: 032] Update VE core submodule to master (7f8fae5) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/206010 (owner: 10Jforrester) [00:52:42] (03Merged) 10jenkins-bot: Tag v0.10.0 [oojs/ui] - 10https://gerrit.wikimedia.org/r/206035 (owner: 10Jforrester) [00:53:46] Thanks! [00:57:47] 10VisualEditor, 3Editing Department 2014/15 Q4 blockers: Remove dropdown for other cite options from the toolbar. Options will be accessible from the auto-cite tool - https://phabricator.wikimedia.org/T96946#1229930 (10KHammerstein) 3NEW [01:05:34] (03PS2) 10Jforrester: Update OOjs UI to v0.10.0 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204963 (owner: 10Bartosz Dziewoński) [01:07:02] (03CR) 10Jforrester: [C: 031] Update OOjs UI to v0.10.0 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204963 (owner: 10Bartosz Dziewoński) [01:10:27] 10VisualEditor, 3Editing Department 2014/15 Q4 blockers: Table header/content cell control should be in context menu, not in toolbar - https://phabricator.wikimedia.org/T96947#1229950 (10KHammerstein) 3NEW [01:18:35] 10VisualEditor, 10VisualEditor-EditingTools, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-29_(1.26wmf4): Quotation marks added via special characters tool should wrap selected text, not replace it - https://phabricator.wikimedia.org/T65227#1229962 (10Jdforrester-WMF) 5Open>3Resolved [01:18:42] 10VisualEditor, 10VisualEditor-EditingTools, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-29_(1.26wmf4): Quotation marks added via special characters tool should wrap selected text, not replace it - https://phabricator.wikimedia.org/T65227#654797 (10Jdforrester-WMF) [01:18:58] 10VisualEditor, 10VisualEditor-EditingTools, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-29_(1.26wmf4): VisualEditor: Provide tooltips for each item in the Special Character inserter so users can tell items from each other - https://phabricator.wikimedia.org/T70425#1229965 (10Jdforrester-WM... [01:18:59] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Add non-breaking space (nbsp) to the "special character" dialog - https://phabricator.wikimedia.org/T70429#1229968 (10Jdforrester-WMF) [01:19:07] 10VisualEditor, 10VisualEditor-EditingTools, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-29_(1.26wmf4): VisualEditor: Provide tooltips for each item in the Special Character inserter so users can tell items from each other - https://phabricator.wikimedia.org/T70425#742879 (10Jdforrester-WMF) [01:19:25] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-29_(1.26wmf4): Special characters menu in VisualEditor does not include en dash - https://phabricator.wikimedia.org/T95819#1229971 (10Jdforrester-WMF) 5Open>3Resolved [01:19:34] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-29_(1.26wmf4): Special characters menu in VisualEditor does not include en dash - https://phabricator.wikimedia.org/T95819#1201179 (10Jdforrester-WMF) [01:24:00] mooey|mtg, so I looked at https://gerrit.wikimedia.org/r/#/c/203965/6 quickly [01:24:37] not in much detail, but I wonder... Why do we need to do all of this extra passing around of IDs/events etc.? [01:25:40] Krenair, I'm about to leave but quickly -- because we're rebuilding the search widget [01:25:51] or rather, we were... I think i canceled the deletion of it [01:26:02] 10VisualEditor, 10Beta-Cluster: Cannot open any page with VE in Betalabs, getting error "Error loading data from server: internal_api_error_DBConnectionError: [8c78efd3] Exception Caught: DB connection error: Can't connect to MySQL: - https://phabricator.wikimedia.org/T96905#1229983 (10Shizhao) me2 [01:26:16] Krenair, I'll take a look tomorrow to verify [01:26:19] gtg [01:26:21] ok [01:28:04] Krenair: Want to do the V+2 dance with https://gerrit.wikimedia.org/r/#/c/206049/ and https://gerrit.wikimedia.org/r/#/c/206048/ ? :-) [01:28:29] Krenair: (Feel free to say no.) [01:29:33] not right now [01:29:54] Kk. [01:30:38] edsanders: ? :-) [01:43:56] 10VisualEditor, 3Editing Department 2014/15 Q4 blockers: Remove dropdown for other cite options from the toolbar. Options will be accessible from the auto-cite tool - https://phabricator.wikimedia.org/T96946#1229991 (10KHammerstein) [04:36:16] 10VisualEditor: When inserting a column in a table, cells are not moved to the right - https://phabricator.wikimedia.org/T96955#1230163 (10Nicolas_Raoul) 3NEW [04:38:12] 10VisualEditor: When inserting a column in a table, cells are not moved to the right - https://phabricator.wikimedia.org/T96955#1230170 (10Nicolas_Raoul) [06:11:27] 10VisualEditor, 10VisualEditor-EditingTools, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-29_(1.26wmf4): VisualEditor: Provide tooltips for some items in the Special Character inserter so users can tell items from each other - https://phabricator.wikimedia.org/T70425#1230345 (10matmarex) [06:30:38] 10VisualEditor, 10VisualEditor-EditingTools, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-29_(1.26wmf4): Quotation marks added via special characters tool should wrap selected text, not replace it - https://phabricator.wikimedia.org/T65227#1230373 (10matmarex) The pairs of quotes appropriat... [08:11:30] 10Citoid: Keep citoid.wmflabs.org up to date with master - https://phabricator.wikimedia.org/T96965#1230489 (10mobrovac) 3NEW a:3mobrovac [08:12:14] 10Citoid, 10VisualEditor: Evaluate citoid for citations used on Wikimedia sites - https://phabricator.wikimedia.org/T96927#1230498 (10mobrovac) [08:12:15] 10Citoid: Keep citoid.wmflabs.org up to date with master - https://phabricator.wikimedia.org/T96965#1230499 (10mobrovac) [08:53:16] 10VisualEditor, 10MediaWiki-extensions-MultimediaViewer, 6Multimedia: MMV not working for pages after saved with VisualEditor and not reloaded - https://phabricator.wikimedia.org/T97010#1230732 (10Florian) 3NEW [08:59:37] 10VisualEditor, 10RESTBase, 10Traffic, 6operations, 7Performance: Set up an API base path for REST and action APIs - https://phabricator.wikimedia.org/T95229#1230755 (10akosiaris) >>! In T95229#1228222, @GWicke wrote: > The problem with 'content' is that it is not general enough, as this API will expose... [09:31:46] 10VisualEditor, 10Beta-Cluster: Cannot open any page with VE in Betalabs, getting error "Error loading data from server: internal_api_error_DBConnectionError: [8c78efd3] Exception Caught: DB connection error: Can't connect to MySQL: - https://phabricator.wikimedia.org/T96905#1230772 (10Aklapper) p:5High>3Un... [09:53:37] 10VisualEditor, 3Editing Department 2014/15 Q4 blockers: Remove dropdown for other cite options from the toolbar. Options will be accessible from the auto-cite tool - https://phabricator.wikimedia.org/T96946#1230804 (10Aklapper) Potentially related (Cite menu), maybe not: {T95470}, {T96118} [10:12:54] (03PS1) 10Divec: Tests for getNodeAndOffset (matching current quirky behaviour) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/206094 (https://phabricator.wikimedia.org/T96838) [12:15:38] (03PS1) 10Bartosz Dziewoński: Update for changes in OOjs UI (Ib40e3477) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/206102 (https://phabricator.wikimedia.org/T91152) [12:15:44] (03PS1) 10Bartosz Dziewoński: Update for changes in OOjs UI (Ib40e3477) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/206103 (https://phabricator.wikimedia.org/T91152) [12:24:53] 10OOjs-UI, 10VisualEditor, 10VisualEditor-MediaWiki, 10Apex, and 3 others: OOjs UI uses font-size of 12.8px (0.8×16px) for windows and toolbars, but Vector skin uses 14px (0.875×16px) for body content, creating inconsistency between widgets in windows/toolba... - https://phabricator.wikimedia.org/T91152#1230987 [12:59:08] 10OOjs-UI, 5OOjs-UI-next-release, 3Editing Department 2014/15 Q4 blockers, 7Technical-Debt: ToggleWidget should be an abstract superclass, like InputWidget, not a mixin - https://phabricator.wikimedia.org/T96674#1231047 (10Ricordisamoa) [13:06:41] 10VisualEditor: Detect browser compatibility in core - https://phabricator.wikimedia.org/T97025#1231051 (10Esanders) 3NEW [13:17:37] 10VisualEditor: Detect browser compatibility in core - https://phabricator.wikimedia.org/T97025#1231068 (10Esanders) [13:19:29] 10VisualEditor: Detect browser compatibility in core - https://phabricator.wikimedia.org/T97025#1231051 (10Esanders) Problem: What do we do for browsers where attempting to load visualEditor.js would cause them to crash? E.g. they crash on OO.inheritClass, or Function.bind? [13:22:06] 10VisualEditor, 10RESTBase, 10Traffic, 6operations, 7Performance: Set up an API base path for REST and action APIs - https://phabricator.wikimedia.org/T95229#1231079 (10Anomie) >>! In T95229#1230755, @akosiaris wrote: > TL;DR: `/api/_/v1/` Eeew. > Thoughts ? I have serious doubts about encouraging thi... [13:28:18] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: When using citation templates, the page title and access date fields should be filled automatically - https://phabricator.wikimedia.org/T58772#1231094 (10Elitre) @Capt_Swing: can you please clarify? What did you test, and where? Links are appreciated.... [13:38:49] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Provide some kind of template suggestion in the transclusion editor - https://phabricator.wikimedia.org/T55590#1231127 (10Gerardduenas) It would really be appreciated in wikipedia's sister projects to have a costumizable common templates dropdown as th... [14:11:55] (03PS16) 10Esanders: [WIP] Link Inspector Redesign [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174725 (owner: 10SuchetaG) [14:19:54] 10VisualEditor, 10VisualEditor-ContentEditable, 5Patch-For-Review: Make non-breaking spaces (nbsp) visible in VisualEditor - https://phabricator.wikimedia.org/T96666#1231207 (10Nnemo) >>! In T96666#1228205, @matmarex wrote: > Hmm. I still think we should show the user some kind of confirmation that they mana... [14:23:53] Krinkle|detached, Krenair what would be a sensible way to find out of an extension is enabled from JS (specifically PageImages)? [14:30:54] 10VisualEditor, 10RESTBase, 10Traffic, 6operations, 7Performance: Set up an API base path for REST and action APIs - https://phabricator.wikimedia.org/T95229#1231237 (10Tgr) How about mapping `/api/foo/v1` to `http://rest.wikimedia.org/{domain}/v1/foo` (for some whitelist or non-blacklist)? Right now, RE... [14:39:29] 10VisualEditor, 10VisualEditor-ContentEditable, 5Patch-For-Review: Make non-breaking spaces (nbsp) visible in VisualEditor - https://phabricator.wikimedia.org/T96666#1231261 (10Nnemo) [14:45:55] 10VisualEditor, 10VisualEditor-ContentEditable, 5Patch-For-Review: Make non-breaking spaces (nbsp) visible in VisualEditor - https://phabricator.wikimedia.org/T96666#1231267 (10Nnemo) @matmarex, I have edited the task's description a little. On Windows, non-breaking spaces are supported in any app, even Not... [14:46:59] 10VisualEditor, 10VisualEditor-ContentEditable, 5Patch-For-Review: Make non-breaking spaces (nbsp) visible in VisualEditor - https://phabricator.wikimedia.org/T96666#1231269 (10Jdforrester-WMF) But "Word" is not a system you can compare to "OS X"… :-) [15:01:51] (03PS1) 10Esanders: Fix old dates [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/206122 [15:04:10] (03CR) 10Jforrester: [C: 032] Fix old dates [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/206122 (owner: 10Esanders) [15:05:39] MatmaRex: Hey. [15:07:04] (03Merged) 10jenkins-bot: Fix old dates [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/206122 (owner: 10Esanders) [15:10:46] (03PS1) 10Esanders: Fix old dates [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/206123 [15:11:04] (03CR) 10Jforrester: [C: 032] Fix old dates [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/206123 (owner: 10Esanders) [15:13:59] (03CR) 10jenkins-bot: [V: 04-1] Fix old dates [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/206123 (owner: 10Esanders) [15:14:20] (03CR) 10Jforrester: [C: 032] "…" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/206123 (owner: 10Esanders) [15:16:01] 10VisualEditor, 10RESTBase, 10Traffic, 6operations, 7Performance: Set up an API base path for REST and action APIs - https://phabricator.wikimedia.org/T95229#1231287 (10GWicke) 5Open>3Resolved a:3GWicke Sorry for now updating the ticket yesterday. We decided to go with `/api/rest_v1/`: http://en.... [15:16:08] (03Merged) 10jenkins-bot: Fix old dates [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/206123 (owner: 10Esanders) [15:18:47] (03CR) 10Bartosz Dziewoński: [C: 032] Update OOjs UI to v0.10.0 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204963 (owner: 10Bartosz Dziewoński) [15:24:35] grumble: we released 0.10 without renaming mixins? [15:27:16] cscott: Non-breaking change. [15:27:17] oh, i see MatmaRex objected at the last minute. [15:27:17] cscott: And yes. [15:27:31] cscott: On the 18th, four days before the cut. :-) [15:27:58] (Also, OOjs stuff now belongs in -editing I guess, rather than making everyone join -visualeditor.) [15:28:03] oh, i missed that somehow. sorry. [15:28:09] Not that it helps you. [15:28:10] Yeah. [15:28:28] should have checked that before i pinged you about this last night, but i was on my way out the door at the time. [15:28:32] As I posted, Trevor said he wanted to discuss with you and MatmaRex today before proceeding, to make sure we all agree. [15:28:38] anyway, release early release often! ;) [15:28:43] No worries at all. Progress! :-) [15:29:50] i think we have some renaming to do to resolve the "safe typechecking for OO.ui.Element.infuse" thing, too. we agreed what to do, and then nobody got around to doing it. :) so on to 0.11! [15:30:24] i think there is a conspiracy at WMF to ensure that the number of IRC channels I must subscribe to is not finite. [15:34:56] * James_F nods. [15:35:00] * James_F grins. [15:38:54] (03Merged) 10jenkins-bot: Update OOjs UI to v0.10.0 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204963 (owner: 10Bartosz Dziewoński) [15:54:35] (03CR) 10Jforrester: [C: 032] "Coverage improvements yay." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/206094 (https://phabricator.wikimedia.org/T96838) (owner: 10Divec) [15:55:21] 10VisualEditor, 10VisualEditor-ContentEditable, 3Editing Department 2014/15 Q4 blockers, 7Technical-Debt, 5WMF-deploy-2015-04-29_(1.26wmf4): Create unit tests for ve.ce.Document#getNodeAndOffset - https://phabricator.wikimedia.org/T96838#1231380 (10Jdforrester-WMF) 5Open>3Resolved p:5Triage>3Norma... [15:55:42] 10VisualEditor, 10VisualEditor-ContentEditable, 3Editing Department 2014/15 Q4 blockers, 7Technical-Debt, 5WMF-deploy-2015-04-29_(1.26wmf4): Create unit tests for ve.ce.Document#getNodeAndOffset - https://phabricator.wikimedia.org/T96838#1227285 (10Jdforrester-WMF) [15:57:48] (03Merged) 10jenkins-bot: Tests for getNodeAndOffset (matching current quirky behaviour) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/206094 (https://phabricator.wikimedia.org/T96838) (owner: 10Divec) [16:07:02] (03PS1) 10Jforrester: Update VE core submodule to master (40ff4c2) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/206133 [16:09:33] 10VisualEditor, 10VisualEditor-ContentEditable: VisualEditor: Ctrl-Space to insert a non-breaking space (NBSP), and a way to see the difference - https://phabricator.wikimedia.org/T53045#1231433 (10Nnemo) [16:09:34] 10VisualEditor: VE silently alters non-breaking spaces into normal spaces - https://phabricator.wikimedia.org/T96701#1231432 (10Nnemo) [16:11:53] 10VisualEditor: VE silently alters non-breaking spaces into normal spaces - https://phabricator.wikimedia.org/T96701#1231439 (10Nnemo) This task and the task T53045 are closely related, but the task T53045 is not required for this one. The visual editor's feature for inserting a non-breaking space will not remo... [16:13:34] 10VisualEditor: VE silently alters non-breaking spaces into normal spaces - https://phabricator.wikimedia.org/T96701#1231445 (10Nnemo) [16:16:48] (03CR) 10Krinkle: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204985 (owner: 10Divec) [16:24:01] 10VisualEditor, 10VisualEditor-ContentEditable: VisualEditor: Ctrl-Space to insert a non-breaking space (NBSP), and a way to see the difference - https://phabricator.wikimedia.org/T53045#1231490 (10Nnemo) For this feature, I suggest Ctrl Shift Space rather than Ctrl Space. Reasons : # Ctrl Space is already t... [16:35:00] 10Citoid: UTF8 characters not represented correctly - https://phabricator.wikimedia.org/T95833#1231510 (10Mvolz) a:3Mvolz [16:37:13] 10VisualEditor, 10VisualEditor-ContentEditable: VisualEditor: Ctrl-Space to insert a non-breaking space (NBSP), and a way to see the difference - https://phabricator.wikimedia.org/T53045#1231530 (10Nnemo) For this feature, something would need to be clarified : What would the keyboard combination insert in th... [16:39:13] 10VisualEditor, 10VisualEditor-MediaWiki, 3Editing Department 2014/15 Q4 blockers: Handle load failures more gracefully - https://phabricator.wikimedia.org/T97041#1231542 (10Jdforrester-WMF) 3NEW [16:40:40] 10VisualEditor, 10CiteThisPage: Elsevier journals don't seem to work in Citoid - https://phabricator.wikimedia.org/T97042#1231551 (10Whatamidoing-WMF) 3NEW [16:41:13] 10VisualEditor, 10VisualEditor-MediaWiki: When wiki is read-only locked on load, offer the user the possibility of loading the editor anyway - https://phabricator.wikimedia.org/T97043#1231561 (10Jdforrester-WMF) 3NEW [16:44:50] 10Citoid, 10TemplateData: Some templates don't support multiple author fields - https://phabricator.wikimedia.org/T97044#1231571 (10Mvolz) 3NEW [16:53:51] 10Citoid, 10TemplateData: Some templates don't support multiple author fields - https://phabricator.wikimedia.org/T97044#1231607 (10Mvolz) Actually, we probably could do something like this in the extension, if the field that citoid gets is a list of lists, but the field in the template data is just a flat fie... [17:09:44] edsanders: You're needed for the 10:30 IRC meeting in -parsoid but that's it today. [17:09:47] edsanders: Is that OK? [17:10:57] sure [17:18:29] RoanKattouw, https://gerrit.wikimedia.org/r/#/c/205291/ [17:19:37] 10Cite, 7Wikimedia-log-errors: Cannot add element to the array as the next element is already occupied - https://phabricator.wikimedia.org/T97052#1231705 (10demon) 3NEW [17:19:47] Krinkle|detached, Krenair what would be a sensible way to find out of an extension is enabled from JS (specifically PageImages)? [17:20:11] Does PageImages expose any JS modules? [17:20:49] edsanders: Ideally one wouldn't based on installation alone since extensions can often be configured or disabled in partial ways. Best to check for the interface you intend to use directly. [17:20:54] Module registration indeed [17:21:04] Or config vars. [17:21:15] Or properties in the API response [17:21:21] I don't think so [17:21:45] Properties in the API response should work, right? [17:21:45] it changes the API response [17:22:10] but I think it omits the image property if it doesn't exist [17:22:38] so if you got a set of results with no images, you may not be able to tell [17:23:56] * edsanders checks [17:24:27] Krenair, Krinkle, RoanKattouw_away yes - if there are not thumbnails available in your results it just omits the property [17:24:51] So that's not good enough? [17:24:57] No [17:25:05] What do you need to detect this extension for? [17:25:12] link inspector [17:25:22] if the wiki is not configured with images, we shouldn't show images [17:25:34] And if it is, but there aren't any? [17:25:43] we show a placeholder image [17:25:55] so the results are consistent [17:26:10] there is a similar issue with wikidata descriptions [17:26:22] it depends on the wikibase extension [17:26:53] edsanders: What kind of value does the extra property hold. Array? [17:27:11] "thumbnail": { [17:27:11] "source": "http://localhost/MediaWiki/core/images/thumb/b/b6/Obamamiltondavis1.jpg/80px-Obamamiltondavis1.jpg", [17:27:11] "width": 80, [17:27:11] "height": 74 [17:27:11] }, [17:28:03] Hm... right [17:28:25] Which is a common pattern in MediaWiki. Properties have predictable types, if they exist they're the way they should be. [17:28:27] No if/elseing [17:28:34] so we can't easily make this null or false otherewise. [17:29:00] We could add "nothumbnail": true [17:29:18] or "" probably since that's how MW API treats boolean [17:29:25] so a separate property. [17:29:29] Kind of ugly, but works [17:32:03] Krinkle, that's very ugly - the thumbnail is only added by an extension [17:32:14] you can't have core generate a list of extensions which aren't installed, just in case [17:32:23] edsanders: No, that's not what I meant [17:32:39] edsanders: PageImages would add "nothumbnail" if there is none. [17:32:48] So that you can tell whether it's not installed or just has no data [17:33:31] but only once you've looked at a response item? that's also ugly [17:33:50] couldn't we have VE sniffy around in PHP land and expose a JS var? [17:33:54] *sniff [17:33:58] only the first time, but yeah, either that or a separate request, which only moves the problem in terms of delay [17:34:40] edsanders: Could add it to ve.data module I gues [17:34:45] yup [17:34:48] I'd prefer that [17:35:00] what should we look for in PHP? [17:35:14] ( I need to do this for ext/Wikibase too ) [17:35:39] edsanders: Avoid adding it to wgVisualEditorConfig as that bloats the startup module before the editor is initialised. Ve.data is loaded early and part of the main http request. [17:35:48] We should probably move more stuff in there not needed in init.init as well [17:36:09] edsanders: Any public interface. class_exists would work [17:36:31] ApiQueryPageImages [17:36:49] Even better: PAGE_IMAGES_INSTALLED [17:36:52] https://github.com/wikimedia/mediawiki-extensions-PageImages/blob/master/PageImages.php#L7 [17:36:57] defined() [17:37:59] https://github.com/search?type=Code&q=PAGE_IMAGES_INSTALLED%20@wikimedia [17:42:37] thanks [17:51:07] when is mooey|away usually around? I need some help with code that she has touched. [17:51:55] actually... this is more of a VE question [17:52:53] How can I override the args VE passes to mediawiki.feedback? Should I just submit a patch? [17:53:50] hexmode: Sure. [17:54:19] I think it needs more than a patch... a bug describing the issue and then a patch :) [18:10:39] mooeypoo: Krinkle: I'm looking at ve.ui.MWHelpPopupTool.prototype.onFeedbackClick on line 188 of ve.ui.MWPopupTool.js and I want to override some hard coded values. Is there a way to set (for example) this.feedbackPromise before this is called so I can do that? Or should I file a bug? [18:10:55] * hexmode continues to draft a bug while he waits [18:14:25] 10Citoid, 10VisualEditor: Evaluate citoid for citations used on Wikimedia sites - https://phabricator.wikimedia.org/T96927#1231933 (10Whatamidoing-WMF) @gpaumier, do you hope to do this for all 280+ Wikipedias? Any of the non-Wikipedias? Citoid depends upon good TemplateData, so I believe that you will nee... [18:15:21] TrevorParscal: I think part of my problem is a lack of understanding of oojs. Is there a good pointer for how I would go about to extending ve.ui.MWHelpPopupTool so that my instance of VE would use it? [18:18:20] 10VisualEditor: VisualEditor should allow wikis to override args passed to the feedback form - https://phabricator.wikimedia.org/T97062#1231943 (10MarkAHershberger) 3NEW [18:18:29] hexmode: Register a module that depends on the module that provides ve.ui.MWHelpPopupTool, then in a js file extend that class and make yours has the same 'static.name' and register it with ve.ui.toolFactory.register(), like that file does, too. [18:18:51] (Boo.) [18:19:25] hexmode: When VE instantiates a class, it uses toolfactory as proxy with symbolic names instead of direct class references. So you can provide your own class for the 'notices' tool. [18:20:05] Krinkle: ok... is there a code sample somewhere of a class that does this? I obviously need some docs. Where should I start? [18:20:53] * hexmode looks at notices [18:22:35] hexmode: I assume you know how to register a ResourceModule and add a js file. [18:23:34] hexmode: In the JS file, create a class that extends ve.ui.MWHelpPopupTool (https://www.mediawiki.org/wiki/OOjs/Inheritance). Add your own onFeedbackClick method. And call ve.ui.toolFactory.register at the end of the file. [18:23:52] I am somewhat familiar with that but haven't done a lot with it. Should I just see how ve-wmf is registered [18:24:18] ve-wmf is not a resource loader module [18:24:40] ve-mw, then? [18:24:42] No. [18:24:44] :( [18:24:48] That's about 20 different modules. [18:24:52] You'll go mad. [18:25:01] You see my problem ;) [18:25:05] Complex software is complex. [18:25:14] Pick a simple extension, like Math or Cite or whatever. [18:25:19] ve-mw is a directory with different files that are then registered as various modules. [18:25:29] https://www.mediawiki.org/wiki/ResourceLoader/Developing_with_ResourceLoader#Registering [18:25:44] Or, yes, read the documentation. :-) [18:25:52] There's very little to it. Looking at an actual extension will only distract you with specifics of that extension. [18:26:22] ok, thanks. I needed to do this sooner or later. [18:26:44] I'm sure I'll be back but you guys have helped me a lot [18:27:20] * hexmode thinks complex software should have emergent simplicity [18:27:30] ve.ui.MWPopupTool.js is provided by ext.visualEditor.mwcore, so depend on that module. And be sure to add your module name to wgVisualEditorPluginModules [18:27:59] hexmode: Simplicity is not a replacement for learning though :) There's a first time for everything. [18:28:08] :) [18:34:47] 10MediaWiki-Page-editing: Alert editors before they save an edit creating a disambiguation link (or at least a high-traffic disambiguation link). - https://phabricator.wikimedia.org/T97063#1232000 (10Aklapper) p:5Normal>3Low [18:35:22] 10VisualEditor: VisualEditor should allow wikis to override args passed to the feedback form - https://phabricator.wikimedia.org/T97062#1232002 (10MarkAHershberger) 5Open>3Resolved a:3MarkAHershberger Docs: https://www.mediawiki.org/wiki/ResourceLoader/Developing_with_ResourceLoader#Registering From IRC:... [18:39:35] FWIW, I'm going to create ExampleVEExtension to test all this. Maybe write up some quick howtos that other people can use. If I get anywhere ... that is. [18:52:32] 10VisualEditor: In en.wiki, VisualEditor failed to load while trying to re-open it after saving an edit on it , showed an error about Revision ID mismatch - https://phabricator.wikimedia.org/T97069#1232065 (10Ryasmeen) 3NEW [18:52:46] 10VisualEditor: In en.wiki, VisualEditor failed to load while trying to re-open it after saving an edit on it , showed an error about Revision ID mismatch - https://phabricator.wikimedia.org/T97069#1232072 (10Ryasmeen) a:3Esanders [18:55:05] 10VisualEditor: In en.wiki, VisualEditor failed to load while trying to re-open it after saving an edit on it , showed an error about Revision ID mismatch - https://phabricator.wikimedia.org/T97069#1232098 (10Ryasmeen) We had a related change around this in wmf2: https://phabricator.wikimedia.org/T94367 [18:55:22] Hey edsanders [18:55:41] hi [18:55:50] Just found this issue on en.wiki, looks pretty bad [18:55:57] https://phabricator.wikimedia.org/T97069 [18:56:26] Yes - looks like Krenair's area? [18:56:45] ah okay, reassigning it to him [18:57:00] 10VisualEditor: In en.wiki, VisualEditor failed to load while trying to re-open it after saving an edit on it , showed an error about Revision ID mismatch - https://phabricator.wikimedia.org/T97069#1232099 (10Ryasmeen) a:5Esanders>3Krenair [18:59:04] does this happen every time you try to re-open it after saving ryasmeen? [18:59:26] Krenair: sadly yes! :( [18:59:45] What browser is that? [19:00:34] Krenair: Firefox [19:00:44] Checking on other browsers [19:01:30] does it happen on beta? [19:02:13] Krenair:So not happening on Chrome in en.wiki [19:02:13] It works for me... [19:02:22] (on chrome) [19:02:30] checking betalabs and mw.org [19:02:44] Krenair: try in firefox ? [19:04:11] Betalabs is dead , so cant check there [19:04:28] Krenair: not happening in mw.org [19:04:58] testwiki works for me in firefox [19:05:03] So its only in en.wiki with firefox [19:05:42] I reproduced it once on enwiki in firefox [19:05:46] Elena got it too [19:06:00] and again [19:06:04] I just checked with her on her sandbox in en.wiki [19:06:06] retry works [19:06:44] Krenair: retry would work yes, but edit again and save ...then again you will get that error [19:07:54] what's up with beta? [19:12:29] I dont know :| [19:13:41] 10MediaWiki-ResourceLoader: Media queries not respected in skins - https://phabricator.wikimedia.org/T40586#1232154 (10Paladox) [19:14:18] Krenair: https://phabricator.wikimedia.org/T96905 [19:14:24] this was from yesterday [19:14:31] looks like its still not resolved [19:14:43] 10MediaWiki-ResourceLoader: Media queries not respected in skins - https://phabricator.wikimedia.org/T40586#444603 (10Paladox) Is this resolved or does this still occur. [20:08:16] ryasmeen, there appears to be a bunch of issues with labs, including networking etc. [20:08:24] ops are aware [20:18:41] 10VisualEditor, 6Community-Liaison, 10Wikimedia-Site-requests, 3Editing Department 2014/15 Q4 blockers, and 4 others: Run test of having VisualEditor on for some newly-created accounts on the English Wikipedia - https://phabricator.wikimedia.org/T90666#1232305 (10Rdicerb) [20:20:32] 10VisualEditor, 6Collaboration-Team, 10Flow, 10Parsoid: Previewing a link to a File in Flow's VE-mode, opens a broken destination due to /w/ - https://phabricator.wikimedia.org/T96492#1232308 (10Catrope) We probably want to stop passing `body=true` to Parsoid, so we get the `` and can benefit from th... [20:23:31] 10VisualEditor, 6Collaboration-Team, 10Flow: Previewing a link to a File in Flow's VE-mode, opens a broken destination due to /w/ - https://phabricator.wikimedia.org/T96492#1232316 (10Mattflaschen) [20:23:43] 10VisualEditor, 6Collaboration-Team, 10Flow: Previewing a link to a File in Flow's VE-mode, opens a broken destination due to /w/ - https://phabricator.wikimedia.org/T96492#1232318 (10GWicke) `body=true` can also lead to data corruption if the first element is a : ``` document.documentElement.innerHTM... [20:24:19] Krenair: i see [20:24:33] Krenair: have you been able to reproduce that issue consistently? [20:26:56] 10VisualEditor, 6Collaboration-Team, 10Flow: Previewing a link to a File in Flow's VE-mode, opens a broken destination due to /w/ - https://phabricator.wikimedia.org/T96492#1232321 (10Mattflaschen) It looks we may need to revisit e4ab381fff5da49acf21f8a0533517ed201bca5b, and extract the body contents as a Co... [20:30:50] ryasmeen, yeah. not quite sure why it's happening specifically in this situation in FF only... [20:38:36] RoanKattouw, fyi ryasmeen has been running into another strange issue with our check for differing rev ids [20:38:52] in particular, under Firefox only it seems, when you save and then re-open VE [20:39:08] caching the old version from restbase perhaps? [20:39:12] Weeeird [20:41:50] Doesn't happen with the inspector open [20:41:55] But doesn't happen with it closed [20:41:57] * RoanKattouw stabs Firefox [20:42:29] 10OOjs-UI, 7Documentation: Make documentation on toolbars, tool groups, and tools - https://phabricator.wikimedia.org/T91195#1232379 (10Spage) p:5Lowest>3Normal [20:42:55] Oh, hm, hold on [20:43:11] Krenair: From looking at the network traffic, it looks like we don't even retry at all, we go straight to warning the user? [20:43:20] I thought we would first retry the higher rev id... [20:44:48] Oh, crap [20:44:53] Yeah I thought our logic there was a bit broken [20:44:58] this.retriedRevIdConflict is not reset between loads [20:45:05] So on a *recycled* Target we go straight to warning [20:45:08] ah. [20:45:51] Patch inbound [20:46:23] thanks [20:48:08] (03PS1) 10Catrope: Don't give up immediately for revid mismatches on second load [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/206185 (https://phabricator.wikimedia.org/T97069) [20:49:01] Krenair: ---^^ [20:49:08] Krenair: That should probably be cherry-picked [20:49:11] (cc James_F|Away ---^^ ) [20:50:28] (03CR) 10Alex Monk: [C: 032] Don't give up immediately for revid mismatches on second load [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/206185 (https://phabricator.wikimedia.org/T97069) (owner: 10Catrope) [20:55:42] 10OOjs-UI, 7Documentation: Make documentation on toolbars, tool groups, and tools - https://phabricator.wikimedia.org/T91195#1232471 (10Spage) a:3KMenger @bmansurov also had difficulty figuring out OOjs UI toolbars. * The generated doc https://doc.wikimedia.org/oojs-ui/master/#!/api/OO.ui.Toolbar has a big... [20:57:14] (03Merged) 10jenkins-bot: Don't give up immediately for revid mismatches on second load [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/206185 (https://phabricator.wikimedia.org/T97069) (owner: 10Catrope) [21:02:34] 10VisualEditor, 5Patch-For-Review: In en.wiki, VisualEditor failed to load while trying to re-open it after saving an edit on it , showed an error about Revision ID mismatch - https://phabricator.wikimedia.org/T97069#1232505 (10Krenair) a:5Krenair>3Catrope [21:07:15] 10OOjs-UI, 7Documentation: Make documentation on toolbars, tool groups, and tools - https://phabricator.wikimedia.org/T91195#1232519 (10matmarex) I added the big example recently after being prodded by @Negative24 :) demos/pages/toolbars.js is pretty awful and you probably don't want to look there if you value... [21:08:42] 10OOjs-UI, 7Documentation: Make documentation on toolbars, tool groups, and tools - https://phabricator.wikimedia.org/T91195#1232523 (10matmarex) (I also wouldn't count on the promised rewrite happening soon, sadly, now that I'm doing primarily Multimedia rather than VisualEditor and Trevor is doing management... [21:10:32] (03CR) 10Jforrester: [C: 032] Change Citoid's tool from icon to label [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/205981 (https://phabricator.wikimedia.org/T95470) (owner: 10Mooeypoo) [21:11:14] 10VisualEditor, 10VisualEditor-MediaWiki-References, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-29_(1.26wmf4): Replace cite icon with "cite" label in toolbar - https://phabricator.wikimedia.org/T95470#1232528 (10Jdforrester-WMF) 5Open>3Resolved p:5Triage>3High [21:11:30] 10VisualEditor, 10VisualEditor-MediaWiki-References, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-29_(1.26wmf4): Replace cite icon with "cite" label in toolbar - https://phabricator.wikimedia.org/T95470#1191562 (10Jdforrester-WMF) [21:11:45] (03Merged) 10jenkins-bot: Change Citoid's tool from icon to label [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/205981 (https://phabricator.wikimedia.org/T95470) (owner: 10Mooeypoo) [21:24:45] 10MediaWiki-Page-editing, 10MediaWiki-extensions-Disambiguator: Alert editors before they save an edit creating a disambiguation link (or at least a high-traffic disambiguation link). - https://phabricator.wikimedia.org/T97063#1232605 (10matmarex) [21:27:30] 10MediaWiki-Page-editing, 10MediaWiki-extensions-Disambiguator: Alert editors before they save an edit creating a disambiguation link (or at least a high-traffic disambiguation link). - https://phabricator.wikimedia.org/T97063#1232626 (10matmarex) [21:32:00] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: When using citation templates, the page title and access date fields should be filled automatically - https://phabricator.wikimedia.org/T58772#1232646 (10Ragesoss) Here's what I did: http://en.wikipedia.beta.wmflabs.org/w/index.php?title=Template:Cite_... [22:02:14] Trevor and James stuck in meeting [22:02:19] who needs 3 pm PT standup? [22:06:58] 3 pm KIT is cancelled for today [22:17:25] 10VisualEditor, 10VisualEditor-ContentEditable: VisualEditor: Ctrl-Space to insert a non-breaking space (NBSP), and a way to see the difference - https://phabricator.wikimedia.org/T53045#1232726 (10Ltrlg) Inserting only the character is not persistent: there is at least one browser which replaces non-breaking... [22:35:12] jaufrecht, James_F|Away: RB is ready for direct HTML loading from the /api/rest_v1/ entry point now [22:35:36] not sure who is handling config changes in the VE team these days [23:06:50] prepared patches at https://gerrit.wikimedia.org/r/#/c/206316/ [23:23:20] gwicke: Was the entry point set up in such a way that it would be expected to work in labs? [23:23:29] I can't test it there because beta labs is down [23:25:30] it worked earlier today [23:27:02] I wonder if restbase is down [23:27:09] in labs [23:27:22] All of beta labs is down anyway [23:27:24] So no one will notice [23:27:44] fun [23:28:02] seems to be more down than up recently [23:28:41] http://en.wikipedia.beta.wmflabs.org/wiki/Main_Page seems to work though [23:29:56] Oh yeah that's right, it works for me now [23:32:00] rather sporadic though [23:32:16] looks like a labs issue though [23:34:52] 10VisualEditor, 10VisualEditor-MediaWiki, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review, and 3 others: On second edit attempt between loads, VisualEditor fails to load, complaining about revID mis-match - https://phabricator.wikimedia.org/T97069#1232883 (10Jdforrester-WMF) 5Open>3Resolved [23:34:52] 10VisualEditor, 10VisualEditor-MediaWiki, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review, and 3 others: On second edit attempt between loads, VisualEditor fails to load, complaining about revID mis-match - https://phabricator.wikimedia.org/T97069#1232883 (10Jdforrester-WMF) 5Open>3Resolved [23:35:40] 10VisualEditor, 10VisualEditor-MediaWiki, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review, and 3 others: On second edit attempt between loads, VisualEditor fails to load, complaining about revID mis-match - https://phabricator.wikimedia.org/T97069#1232065 (10Jdforrester-WMF) [23:35:40] 10VisualEditor, 10VisualEditor-MediaWiki, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review, and 3 others: On second edit attempt between loads, VisualEditor fails to load, complaining about revID mis-match - https://phabricator.wikimedia.org/T97069#1232065 (10Jdforrester-WMF)