[00:02:58] <James_F>	 Krenair: Gosh. :-)
[00:03:46] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Links, 7Design, 3Editing Department 2014/15 Q4 blockers: Search interface for link dialogue - https://phabricator.wikimedia.org/T76397#1240494 (10Jdforrester-WMF)
[00:03:50] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Links, 7Design, 3Editing Department 2014/15 Q4 blockers, and 2 others: Page images in link suggestions - https://phabricator.wikimedia.org/T93693#1240491 (10Jdforrester-WMF) 5Open>3Resolved
[00:04:08] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Links, 7Design, 3Editing Department 2014/15 Q4 blockers, and 2 others: Icons for redirects, disambig, red link suggestions; default icon when there is no image - https://phabricator.wikimedia.org/T93694#1240495 (10Jdforrester-WMF) a:3sucheta
[00:06:22] <wikibugs>	 10Citoid, 10VisualEditor: Change label on Citoid tool to say "Look up" - https://phabricator.wikimedia.org/T97353#1240522 (10Rdicerb) Cite?
[00:34:10] <gwicke>	 James_F: re https in beta, should we just change it to http://
[00:34:17] <gwicke>	 ?
[00:34:26] <James_F>	 gwicke: Patch written and in git. :-)
[00:34:31] <gwicke>	 I guess VE won't use https anyway, so no mixed-content concerns
[00:34:40] <gwicke>	 ok, nm then ;)
[00:34:59] <James_F>	 :-)
[00:35:01] <gwicke>	 James_F: can you add the patch to the deploy calendar?
[00:35:28] <James_F>	 gwicke: Roan's just pushing now. Beta Cluster config is OK to push out-of-band as long as you're (a) sure and (b) no-one's watching, right greg-g? ;-)
[00:35:40] <gwicke>	 kk
[00:35:41] <RoanKattouw>	 It's fine
[00:36:00] <greg-g>	 right right
[00:36:08] <greg-g>	 just don't break it
[00:36:10] <greg-g>	 ;)
[00:37:18] <gwicke>	 I wish we could edit that deployments page in VE every time I visit it
[00:39:39] <James_F>	 gwicke: You can!
[00:39:43] <James_F>	 gwicke: Just… badly.
[00:39:47] <James_F>	 gwicke: Lua sucks, etc.
[00:39:54] <gwicke>	 yeahh..
[00:59:13] <grrrit-wm>	 (03CR) 10Catrope: Add ve.fixBase() utility (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/206463 (owner: 10Catrope)
[01:58:49] <grrrit-wm>	 (03PS1) 10SuchetaG: New ordering in link suggestions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207014 
[02:00:30] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] New ordering in link suggestions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207014 (owner: 10SuchetaG)
[02:19:30] <grrrit-wm>	 (03PS1) 10SuchetaG: Replacing current order of link suggestions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207015 
[02:21:51] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Replacing current order of link suggestions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207015 (owner: 10SuchetaG)
[02:22:53] <grrrit-wm>	 (03PS1) 10Krinkle: dm.Surface: Fix invalid documentation syntax [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/207016 
[02:23:51] <grrrit-wm>	 (03PS2) 10Krinkle: dm.Surface: Fix invalid documentation syntax [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/207016 
[02:24:35] <grrrit-wm>	 (03CR) 10Krinkle: "See https://doc.wikimedia.org/VisualEditor/master/#!/api/ve.dm.Surface-method-startQueueingContextChanges" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/207016 (owner: 10Krinkle)
[03:04:18] <grrrit-wm>	 (03PS2) 10Divec: Don't skip inline slug contents in getNodeAndOffset() [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/206951 (owner: 10Catrope)
[03:15:05] <grrrit-wm>	 (03CR) 10Divec: "I reinstated the skip code but for block slugs only, with a comment explaining why it is needed in that case. Let me know if that looks ok" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/206951 (owner: 10Catrope)
[03:40:33] <wikibugs>	 10WikiEditor: WikiEditor styles are not loaded when editing any JS or CSS page - https://phabricator.wikimedia.org/T97299#1240735 (10GOIII) Just to nip a possible issue from arising.... `resize: vertical` is not currently recognized by any version of [[https://developer.mozilla.org/en-US/docs/Web/CSS/resize#Spec...
[04:19:31] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Links, 7Design: Underline matching parts of link suggestions - https://phabricator.wikimedia.org/T93697#1240756 (10Pginer-WMF) Is this in the context of {T76397}? If that is the case, it would be great to link it in some way (e.g., dependency) to provide a bit more co...
[05:41:33] <wikibugs>	 10VisualEditor, 7Design: Flow for adding a new citation - https://phabricator.wikimedia.org/T97390#1240824 (10Nirzar) 3NEW
[06:16:27] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Links, 7Design, 3Editing Department 2014/15 Q4 blockers, and 2 others: Icons for redirects, disambig, red link suggestions; default icon when there is no image - https://phabricator.wikimedia.org/T93694#1240869 (10Nirzar) Here are the icons for the placeholders for...
[06:38:02] <grrrit-wm>	 (03PS3) 10Catrope: Add ve.fixBase() utility [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/206463 
[06:45:42] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] dm.Surface: Fix invalid documentation syntax [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/207016 (owner: 10Krinkle)
[06:46:57] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] ve.ce.TextNode: Do "meaningful whitespace characters" first [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205618 (owner: 10Bartosz Dziewoński)
[06:48:14] <grrrit-wm>	 (03Merged) 10jenkins-bot: dm.Surface: Fix invalid documentation syntax [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/207016 (owner: 10Krinkle)
[06:50:56] <grrrit-wm>	 (03Merged) 10jenkins-bot: ve.ce.TextNode: Do "meaningful whitespace characters" first [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205618 (owner: 10Bartosz Dziewoński)
[07:28:14] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "By "space mucking" I just meant the nbsp handling we do now. The order of operations doesn't matter now, but would if we merged https://ge" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205618 (owner: 10Bartosz Dziewoński)
[07:37:12] <wikibugs>	 10Citoid, 10Possible-Tech-Projects: Add wikitext support for citoid for automatic reference insertion - https://phabricator.wikimedia.org/T94223#1240997 (10NiharikaKohli) Saving this for the next Outreachy/GSoC round. Didn't get enough time to feature this one as a potential project.
[07:48:06] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable: Unable to edit a specific table content - https://phabricator.wikimedia.org/T97398#1241011 (10Raymond) 3NEW
[08:14:56] <grrrit-wm>	 (03PS2) 10SuchetaG: Replacing current order of link suggestions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207015 
[08:16:39] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Replacing current order of link suggestions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207015 (owner: 10SuchetaG)
[08:22:49] <grrrit-wm>	 (03PS3) 10SuchetaG: Replacing current order of link suggestions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207015 
[08:24:45] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Replacing current order of link suggestions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207015 (owner: 10SuchetaG)
[08:32:16] <wikibugs>	 10WikiEditor: WikiEditor styles are not loaded when editing any JS or CSS page - https://phabricator.wikimedia.org/T97299#1241049 (10Edokter)
[08:32:35] <wikibugs>	 10WikiEditor: WikiEditor styles are not loaded when editing any JS or CSS page - https://phabricator.wikimedia.org/T97299#1238414 (10Edokter) It will work in Opera >12 (which is Webkit). The overflow condition only applies to non-textareas. The Mozilla page is slightly outdated. Not really an issue.
[08:55:11] <wikibugs>	 10VisualEditor, 10Parsoid, 10RESTBase, 3Editing Department 2014/15 Q4 blockers, 7user-notice: Page edited with VE corrupted on save with wikitext of page from another wiki with same oldid - https://phabricator.wikimedia.org/T97155#1241057 (10Utar) @ssastry: Thanks for clearing that out. @GWicke: Thanks....
[09:14:02] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable: Unable to edit a specific table content - https://phabricator.wikimedia.org/T97398#1241075 (10Aklapper) Confirming with Firefox 37
[09:51:17] <wikibugs>	 10Citoid: UTF8 characters not represented correctly - https://phabricator.wikimedia.org/T95833#1241099 (10Mvolz)
[10:08:46] <wikibugs>	 10VisualEditor: Add a "Cancel" button to all dialogs - https://phabricator.wikimedia.org/T97363#1241117 (10Aklapper) >>! In T97363#1240264, @Jdforrester-WMF wrote: > Those aren't dialogs, they're inspectors.   (I'm afraid your user base might neither know nor care, but feel free to correct the task summary if th...
[10:15:35] <grrrit-wm>	 (03CR) 10He7d3r: [C: 031] Change location of Search-Replace Link adjacent to Insert Links [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/149925 (https://phabricator.wikimedia.org/T25824) (owner: 10Gerrit Patch Uploader)
[10:48:34] <grrrit-wm>	 (03CR) 10Esanders: "Did you mean to abandon this? In general you shouldn't have to create multiple commits in gerrit if you rebase. As you long as you keep th" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207014 (owner: 10SuchetaG)
[10:48:51] <grrrit-wm>	 (03Abandoned) 10Esanders: New ordering in link suggestions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207014 (owner: 10SuchetaG)
[10:52:15] <grrrit-wm>	 (03CR) 10Esanders: [C: 031] Don't skip inline slug contents in getNodeAndOffset() [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/206951 (owner: 10Catrope)
[10:56:13] <wikibugs>	 10Cite, 7Wikimedia-log-errors: Cannot add element to the array as the next element is already occupied - https://phabricator.wikimedia.org/T97052#1241239 (10Aklapper) p:5Triage>3Normal
[10:56:38] <grrrit-wm>	 (03CR) 10Esanders: [C: 04-1] "looking good" (034 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207015 (owner: 10SuchetaG)
[10:57:03] <wikibugs>	 10Citoid: Some charsets characters not converted into UTF-8 correctly - https://phabricator.wikimedia.org/T95833#1241241 (10Mvolz)
[11:00:00] <wikibugs>	 10VisualEditor: When a trigger can't execute a command, it never prevents default - https://phabricator.wikimedia.org/T97022#1241248 (10Esanders)
[11:00:20] <wikibugs>	 10WikiEditor: WikiEditor styles are not loaded when editing any JS or CSS page - https://phabricator.wikimedia.org/T97299#1241250 (10Edokter)
[11:12:40] <wikibugs>	 10OOjs-UI: Create error state for TextInputWidget - https://phabricator.wikimedia.org/T97403#1241281 (10Esanders) 3NEW a:3matmarex
[11:25:33] <wikibugs>	 10Citoid: Some charsets characters not converted into UTF-8 correctly - https://phabricator.wikimedia.org/T95833#1241304 (10Mvolz) So the three urls we have so far, in the html   2 set (it/fr) to charset=iso-8859-1 in the html, fr: no encoding set in response; it: charset=ISO-8859-1 set 1 set (jp) to charset=Shi...
[12:15:01] <wikibugs>	 10OOjs-UI: Create error state for TextInputWidget - https://phabricator.wikimedia.org/T97403#1241363 (10Esanders) We have the 'invalid' flag (driven by the isValid method), but it has no core styling. We also may want to provide an api for setting validity on a plain text widget, without having to override the i...
[12:26:01] <grrrit-wm>	 (03PS7) 10Esanders: [NEVER MERGE] Local hack for testing link inspector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/206390 
[12:26:03] <grrrit-wm>	 (03PS1) 10Esanders: Separate inputting of internal and external links [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207062 
[13:12:13] <grrrit-wm>	 (03CR) 10Matthias Mullie: [C: 031] "WFM" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/206463 (owner: 10Catrope)
[13:12:26] <grrrit-wm>	 (03CR) 10Matthias Mullie: [C: 031] "WFM" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/206464 (owner: 10Catrope)
[13:17:00] <wikibugs>	 10VisualEditor, 10Parsoid, 10RESTBase, 3Editing Department 2014/15 Q4 blockers, 7user-notice: Page edited with VE corrupted on save with wikitext of page from another wiki with same oldid - https://phabricator.wikimedia.org/T97155#1241497 (10Elitre) https://phabricator.wikimedia.org/T97141 may be related?
[13:32:13] <wikibugs>	 10MediaWiki-ResourceLoader, 6Performance-Team, 5Patch-For-Review: Make position of modules currently added with addModuleStyles explicit - https://phabricator.wikimedia.org/T97410#1241515 (10Nemo_bis)
[13:35:35] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable: VisualEditor: Editing window does not scroll when dragging - https://phabricator.wikimedia.org/T53669#1241518 (10Elitre) I tested moving an image again today, and this is the result on my Air Os X in https://en.wikipedia.org/wiki/Victor_Diaz_Lamich?veaction=edit,...
[13:55:54] <wikibugs>	 10VisualEditor, 10VisualEditor-DataModel, 10VisualEditor-MediaWiki-References, 3Editing Department 2014/15 Q4 blockers: VisualEditor: References created by templates numbered alone, not with the rest of the page, and don't show up as references to insert - https://phabricator.wikimedia.org/T52474#1241562 (1...
[14:03:36] <grrrit-wm>	 (03PS1) 10Gilles: Explicitly define module position [extensions/Math] - 10https://gerrit.wikimedia.org/r/207097 (https://phabricator.wikimedia.org/T97410) 
[14:16:17] <grrrit-wm>	 (03PS1) 10Gilles: Explicitly define module position [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207109 (https://phabricator.wikimedia.org/T97410) 
[14:25:46] <wikibugs>	 10VisualEditor, 10Parsoid, 10RESTBase, 3Editing Department 2014/15 Q4 blockers, 7user-notice: Page edited with VE corrupted on save with wikitext of page from another wiki with same oldid - https://phabricator.wikimedia.org/T97155#1241625 (10Jdforrester-WMF)
[14:26:16] <wikibugs>	 10VisualEditor, 10Parsoid, 10RESTBase, 3Editing Department 2014/15 Q4 blockers, 7user-notice: Page edited with VE corrupted on save with wikitext of page from another wiki with same oldid - https://phabricator.wikimedia.org/T97155#1234365 (10Jdforrester-WMF) This now looks like it's fixed, including the...
[14:26:35] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Explicitly define module position [extensions/Math] - 10https://gerrit.wikimedia.org/r/207097 (https://phabricator.wikimedia.org/T97410) (owner: 10Gilles)
[14:27:22] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Explicitly define module position [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207109 (https://phabricator.wikimedia.org/T97410) (owner: 10Gilles)
[14:28:40] <grrrit-wm>	 (03Merged) 10jenkins-bot: Explicitly define module position [extensions/Math] - 10https://gerrit.wikimedia.org/r/207097 (https://phabricator.wikimedia.org/T97410) (owner: 10Gilles)
[14:30:13] <grrrit-wm>	 (03PS2) 10Jforrester: Explicitly define module position [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207109 (https://phabricator.wikimedia.org/T97410) (owner: 10Gilles)
[14:30:34] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] "PS2 does the change for extension.json too." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207109 (https://phabricator.wikimedia.org/T97410) (owner: 10Gilles)
[14:30:39] <wikibugs>	 10TemplateData, 10VisualEditor: VE: does not show a property "example" for templates - https://phabricator.wikimedia.org/T97417#1241642 (10Sunpriat) 3NEW
[14:31:28] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Links, 7Design, 3Editing Department 2014/15 Q4 blockers, and 2 others: Icons for redirects, disambig, red link suggestions; default icon when there is no image - https://phabricator.wikimedia.org/T93694#1241651 (10Jdforrester-WMF) >>! In T93694#1240869, @Nirzar wrot...
[14:31:30] <wikibugs>	 10TemplateData, 10VisualEditor: VE: does not show a property "example" for templates - https://phabricator.wikimedia.org/T97417#1241652 (10Sunpriat)
[14:31:50] <James_F>	 edsanders: Did you see the new icons on https://phabricator.wikimedia.org/T93694 ? Want to throw them in?
[14:32:42] <grrrit-wm>	 (03Merged) 10jenkins-bot: Explicitly define module position [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207109 (https://phabricator.wikimedia.org/T97410) (owner: 10Gilles)
[14:33:36] <edsanders>	 so we're not doing them as icons?
[14:33:45] <James_F>	 They aren't icons?
[14:34:01] <edsanders>	 icons would be black and 24x24
[14:34:07] <James_F>	 They aren't?
[14:34:46] <edsanders>	 they're like 600x600
[14:35:09] <James_F>	 Helpful. Yeah, re-snap to 24x and solid black, and make the RTL versions.
[14:35:11] <wikibugs>	 10VisualEditor, 10Parsoid, 10RESTBase, 3Editing Department 2014/15 Q4 blockers, 7user-notice: Page edited with VE corrupted on save with wikitext of page from another wiki with same oldid - https://phabricator.wikimedia.org/T97155#1241668 (10GWicke) @jdforrester-wmf, the re-render script is not completel...
[14:35:14] <James_F>	 Or I can? Probably?
[14:35:51] <edsanders>	 they'd need to be designed on a 24x24, some of those won't work so small
[14:36:09] <edsanders>	 also disambig is multi-colour
[14:36:24] <James_F>	 Eurgh.
[14:36:25] <edsanders>	 we don't have to do them as icons - but these are not icons
[14:36:28] <James_F>	 I didn't look that closely.
[14:44:59] <James_F>	 edsanders: You fixing or should I?
[14:45:58] <edsanders>	 We can either use them as not icons, or have them redone by design
[15:09:20] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Links, 7Design, 3Editing Department 2014/15 Q4 blockers, and 2 others: Icons for redirects, disambig, red link suggestions; default icon when there is no image - https://phabricator.wikimedia.org/T93694#1241731 (10Esanders) If these are going to be icons, they need...
[15:11:59] <wikibugs>	 10VisualEditor, 10Parsoid, 10RESTBase, 3Editing Department 2014/15 Q4 blockers, 7user-notice: Page edited with VE corrupted on save with wikitext of page from another wiki with same oldid - https://phabricator.wikimedia.org/T97155#1241746 (10cscott) @GWicke: what time period are you using for the RESTbas...
[15:24:10] <wikibugs>	 10VisualEditor, 10Parsoid, 10RESTBase, 3Editing Department 2014/15 Q4 blockers, 7user-notice: Page edited with VE corrupted on save with wikitext of page from another wiki with same oldid - https://phabricator.wikimedia.org/T97155#1241762 (10GWicke) @cscott:  ``` (rowDate > new Date('2015-04-23T23:30-070...
[15:27:47] <grrrit-wm>	 (03PS1) 10Jforrester: [WIP] Add new icons for link search results [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207120 
[15:28:05] <grrrit-wm>	 (03PS2) 10Jforrester: [WIP] Add new icons for link search results [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207120 
[15:28:21] <James_F>	 edsanders: ^^^ I've re-sized, re-snapped, re-coloured and re-designed them.
[15:31:45] <grrrit-wm>	 (03CR) 10Esanders: Replacing current order of link suggestions (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207015 (owner: 10SuchetaG)
[15:32:20] <edsanders>	 no css :( ?
[15:32:48] <James_F>	 edsanders: I'm in a hurry.
[15:33:09] <James_F>	 edsanders: There's a reason it's WIP. ;-)
[15:33:10] <edsanders>	 slacker
[15:33:13] <James_F>	 Yes.
[15:35:47] <wikibugs>	 10VisualEditor, 10Parsoid, 10RESTBase, 3Editing Department 2014/15 Q4 blockers, 7user-notice: Page edited with VE corrupted on save with wikitext of page from another wiki with same oldid - https://phabricator.wikimedia.org/T97155#1241792 (10cscott) Thanks for the nice machine-readable dates.  My Lazy Pr...
[15:37:37] <grrrit-wm>	 (03CR) 10Jforrester: [C: 04-1] "External link input field should go red (error state) when the input is an invalid external link (e.g. "****") and pressing "Done" should " [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207062 (owner: 10Esanders)
[15:42:22] <grrrit-wm>	 (03CR) 10Esanders: "Error state is blocked on OOUI. We can fixup soon." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207062 (owner: 10Esanders)
[15:42:53] <wikibugs>	 10MediaWiki-ResourceLoader, 6Performance-Team, 5Patch-For-Review: Make addModuleStyles modules marked as "bottom" actually load at the bottom - https://phabricator.wikimedia.org/T97420#1241809 (10Gilles) 3NEW a:3Gilles
[15:42:56] <edsanders>	 James_F, is Bartosz working today?
[15:43:33] <James_F>	 edsanders: Probably? But mostly on Multimedia stuff with marktraceur.
[15:43:42] <marktraceur>	 Ideally...
[15:43:57] <James_F>	 edsanders: Also, there's error state for input boxes already in OOjs UI; did we miss something?
[15:44:41] <edsanders>	 he needs to be available for link inspector related work as p1
[15:44:58] <edsanders>	 James_F, it's on the bug
[15:45:32] <James_F>	 edsanders: The bug to which that patch isn't linked? ;-)
[15:45:48] <edsanders>	 no, https://phabricator.wikimedia.org/T97403
[15:46:21] <James_F>	 edsanders: You've missed the other use, in Transclusion dialog, which is a red ring around a text input widget.
[15:46:27] <James_F>	 edsanders: Which I assumed was in OOjs UI.
[15:46:51] <edsanders>	 Yes - I saw that, it's VE css though
[15:46:57] <James_F>	 Oh.
[15:46:59] <edsanders>	 same suggestion as in the bug, so didn't repeat myself
[15:47:07] <James_F>	 Well, can we use that for now?
[15:47:28] <James_F>	 And do the tech debt tomorrow?
[15:47:48] <edsanders>	 also overriding isValid isn't the best api
[15:47:56] <James_F>	 Agreed.
[15:48:17] <grrrit-wm>	 (03PS1) 10Krinkle: Add example property to HTML rendering [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/207123 (https://phabricator.wikimedia.org/T53049) 
[15:49:35] <wikibugs>	 10TemplateData, 10VisualEditor: VE: does not show a property "example" for templates - https://phabricator.wikimedia.org/T97417#1241826 (10Krinkle) > [..] the text of this field is not visible in TemplateData table  That's a separate issue. We forgot to update the table as part of T53049. Fixed in https://gerr...
[15:50:01] <James_F>	 edsanders: Well, ideally you'd do super.isValid() && local.isValid()
[15:51:00] <grrrit-wm>	 (03CR) 10Jforrester: "This table is getting awfully wide…" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/207123 (https://phabricator.wikimedia.org/T53049) (owner: 10Krinkle)
[15:51:17] <Krinkle>	 James_F: Already working on a follow-up :)
[15:51:24] <James_F>	 Krinkle: Hmm. OK.
[15:51:24] <Krinkle>	 But wanted this in separately.
[15:51:27] * James_F nods.
[15:52:41] <Krinkle>	 James_F: Moving example, default and autovalue to below description. Keeping name,description,type,status as main (and sortable) columns
[15:52:53] <Krinkle>	 Similar to what Commons' is already doing.
[15:53:05] <Krinkle>	 Looks like they figured out it didn't scale, either.
[15:53:05] <James_F>	 Sounds sensible.
[15:56:43] <MatmaRex>	 edsanders: hi
[15:57:46] <edsanders>	 hi, did you see the bug I filed for textinputwidget error
[15:58:33] <grrrit-wm>	 (03PS1) 10Krinkle: HtmlView: Move "default", "example", and "autovalue" under description [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/207124 
[15:59:22] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] HtmlView: Move "default", "example", and "autovalue" under description [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/207124 (owner: 10Krinkle)
[16:00:26] <MatmaRex>	 edsanders: yes. i assume you're not asking me to do design, just copy the good parts from VE?
[16:00:49] <MatmaRex>	 (because i'd rather not do design which will inevitably get obsoleted next month :P)
[16:02:27] <wikibugs>	 10OOjs-UI, 10MediaWiki-extensions-UploadWizard, 6Multimedia: Create a datepicker input widget - https://phabricator.wikimedia.org/T97425#1241899 (10MarkTraceur) 3NEW a:3matmarex
[16:02:52] <wikibugs>	 10OOjs-UI, 10MediaWiki-extensions-UploadWizard, 6Multimedia: Use OOUI datepicker input widget in UploadWizard - https://phabricator.wikimedia.org/T97426#1241911 (10MarkTraceur) 3NEW a:3matmarex
[16:03:15] <wikibugs>	 10OOjs-UI, 10MediaWiki-extensions-UploadWizard, 6Multimedia: Create a datepicker input widget - https://phabricator.wikimedia.org/T97425#1241919 (10MarkTraceur)
[16:03:19] <wikibugs>	 10OOjs-UI, 10MediaWiki-extensions-UploadWizard, 6Multimedia: Use OOUI datepicker input widget in UploadWizard - https://phabricator.wikimedia.org/T97426#1241911 (10MarkTraceur)
[16:04:18] <wikibugs>	 10OOjs-UI, 10MediaWiki-extensions-UploadWizard, 6Multimedia: Create a datepicker input widget - https://phabricator.wikimedia.org/T97425#1241923 (10MarkTraceur) 5Open>3declined Duplicate of T91148, sorry
[16:04:22] <wikibugs>	 10OOjs-UI, 10MediaWiki-extensions-UploadWizard, 6Multimedia: Use OOUI datepicker input widget in UploadWizard - https://phabricator.wikimedia.org/T97426#1241911 (10MarkTraceur)
[16:04:49] <wikibugs>	 10OOjs-UI, 10MediaWiki-extensions-UploadWizard, 6Multimedia: Use OOUI datepicker input widget in UploadWizard - https://phabricator.wikimedia.org/T97426#1241911 (10MarkTraceur)
[16:04:53] <wikibugs>	 10OOjs-UI, 10MediaWiki-extensions-UploadWizard, 6Multimedia: Create a datepicker input widget - https://phabricator.wikimedia.org/T97425#1241928 (10MarkTraceur) 5declined>3Open
[16:05:04] <grrrit-wm>	 (03PS2) 10Krinkle: HtmlView: Move "default", "example", and "autovalue" under description [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/207124 
[16:05:53] <wikibugs>	 10OOjs-UI, 10MediaWiki-extensions-UploadWizard, 6Multimedia: Create a datepicker input widget - https://phabricator.wikimedia.org/T97425#1241899 (10MarkTraceur)
[16:05:57] <wikibugs>	 10OOjs-UI, 10UI-Standardization: Date and time input widgets - https://phabricator.wikimedia.org/T91148#1075130 (10MarkTraceur)
[16:06:08] <MatmaRex>	 edsanders: i'll do that tomorrow or late today, have to leave for a while now.
[16:07:02] <edsanders>	 MatmaRex, yes - that's fine
[16:21:14] <wikibugs>	 10VisualEditor, 3Editing Department 2014/15 Q4 blockers: Link with <nowiki/> as only label - https://phabricator.wikimedia.org/T95730#1241969 (10gpaumier) Another one: https://en.wikipedia.org/w/index.php?diff=659680286
[16:24:32] <grrrit-wm>	 (03PS4) 10SuchetaG: Replacing current order of link suggestions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207015 
[16:24:48] <grrrit-wm>	 (03PS8) 10Esanders: [NEVER MERGE] Local hack for testing link inspector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/206390 
[16:24:50] <grrrit-wm>	 (03PS2) 10Esanders: Separate inputting of internal and external links [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207062 
[16:26:19] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Replacing current order of link suggestions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207015 (owner: 10SuchetaG)
[16:29:58] <wikibugs>	 10VisualEditor, 10Parsoid, 10Parsoid-Nowiki, 3Editing Department 2014/15 Q4 blockers: VisualEditor: Adding nowiki tags in unrelated edit - https://phabricator.wikimedia.org/T70511#1242006 (10gpaumier)
[16:30:36] <wikibugs>	 10VisualEditor, 10Parsoid, 10Parsoid-Nowiki, 3Editing Department 2014/15 Q4 blockers: VisualEditor: Adding nowiki tags in unrelated edit - https://phabricator.wikimedia.org/T70511#721178 (10gpaumier) Nominating as blocker since it's a pretty nasty issue. I'm not sure if it's still happening but we should m...
[16:45:37] <grrrit-wm>	 (03PS9) 10Esanders: [NEVER MERGE] Local hack for testing link inspector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/206390 
[16:45:39] <grrrit-wm>	 (03PS3) 10Esanders: Separate inputting of internal and external links [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207062 
[16:45:41] <grrrit-wm>	 (03PS5) 10Esanders: Replacing current order of link suggestions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207015 (owner: 10SuchetaG)
[16:45:43] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable, 3Editing Department 2014/15 Q4 blockers: VisualEditor: Pre-annotation is from up-page, so deleting and replacing the first character in a link de-links it; deleting and replacing the first bold character in a wor... - https://phabricator.wikimedia.org/T52678#1242054
[16:54:22] <grrrit-wm>	 (03PS10) 10Esanders: [NEVER MERGE] Local hack for testing link inspector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/206390 
[16:54:24] <grrrit-wm>	 (03PS4) 10Esanders: Separate inputting of internal and external links [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207062 
[16:54:26] <grrrit-wm>	 (03PS6) 10Esanders: Replacing current order of link suggestions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207015 (owner: 10SuchetaG)
[16:58:16] <grrrit-wm>	 (03PS11) 10Esanders: [NEVER MERGE] Local hack for testing link inspector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/206390 
[16:58:18] <grrrit-wm>	 (03PS1) 10Esanders: Fix height when descriptions not present [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207141 
[17:09:59] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Fix height when descriptions not present [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207141 (owner: 10Esanders)
[17:10:50] <wikibugs>	 10MediaWiki-ResourceLoader, 6Performance-Team, 5Patch-For-Review: Make addModuleStyles modules marked as "bottom" actually load at the bottom - https://phabricator.wikimedia.org/T97420#1242127 (10Krinkle) From Gerrit: > What kind of CSS is required for the no-js mode but is not required for a FOUC-less first...
[17:13:57] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Add images and descriptions to link context items [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/206492 (https://phabricator.wikimedia.org/T93695) (owner: 10Esanders)
[17:14:25] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Links, 7Design, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-29_(1.26wmf4): Page images in context item (ve.ui.LinkContextItem) - https://phabricator.wikimedia.org/T93695#1242160 (10Jdforrester-WMF) 5Open>3Resolved a:3Esanders
[17:14:29] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Links, 7Design, 3Editing Department 2014/15 Q4 blockers: Search interface for link dialogue - https://phabricator.wikimedia.org/T76397#1242163 (10Jdforrester-WMF)
[17:17:18] <wikibugs>	 10OOjs-UI: Create error state for TextInputWidget - https://phabricator.wikimedia.org/T97403#1242181 (10Jdforrester-WMF) p:5Triage>3High
[17:18:08] <wikibugs>	 10WikiEditor, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review: editSessionID is duplicated in Edit:Schema for Wikitext - https://phabricator.wikimedia.org/T95919#1242184 (10Halfak) @Jdforrester-WMF, @Catrope & @Krenair.  Any progress here?
[17:18:46] <grrrit-wm>	 (03CR) 10Jforrester: [C: 04-1] "Per design at https://phabricator.wikimedia.org/T76397 needs to say "Page does not exist yet" or similar, and it should be styled red. Rig" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207015 (owner: 10SuchetaG)
[17:19:13] <grrrit-wm>	 (03PS7) 10Jforrester: Replacing current order of link suggestions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207015 (https://phabricator.wikimedia.org/T93698) (owner: 10SuchetaG)
[17:19:34] <grrrit-wm>	 (03PS5) 10Jforrester: Separate inputting of internal and external links [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207062 (owner: 10Esanders)
[17:19:38] <grrrit-wm>	 (03PS6) 10Jforrester: Separate inputting of internal and external links [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207062 (https://phabricator.wikimedia.org/T93700) (owner: 10Esanders)
[17:21:26] <wikibugs>	 10MediaWiki-ResourceLoader, 7JavaScript: mw.loader.using loads modules one by one. I would want to load all modules at the same time - https://phabricator.wikimedia.org/T94914#1242197 (10Krinkle) I can't reproduce this.  Location: https://www.mediawiki.org/wiki/MediaWiki Console: > mw.loader.using(['ext.cite',...
[17:21:43] <wikibugs>	 10MediaWiki-ResourceLoader, 7JavaScript: mw.loader.using should not load modules in separate requests - https://phabricator.wikimedia.org/T94914#1242198 (10Krinkle)
[17:23:01] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add images and descriptions to link context items [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/206492 (https://phabricator.wikimedia.org/T93695) (owner: 10Esanders)
[17:24:17] <grrrit-wm>	 (03CR) 10Jforrester: [C: 04-1] "If you input "http://www.amazon.com" as an explicit internal link, it still gets inserted as an MWLinkNode external link." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207062 (https://phabricator.wikimedia.org/T93700) (owner: 10Esanders)
[17:25:03] <wikibugs>	 10MediaWiki-ResourceLoader, 5MW-1.25-release, 7Wikimedia-log-errors: User modules constantly invalidate their cache timestamp - https://phabricator.wikimedia.org/T94810#1242232 (10Krinkle) a:3Krinkle
[17:26:12] <wikibugs>	 10MediaWiki-ResourceLoader: ResourceLoader: Prefix global isCompatible() and startUp() functions - https://phabricator.wikimedia.org/T28803#1242244 (10Krinkle) 5Open>3declined a:3Krinkle
[17:29:20] <grrrit-wm>	 (03PS2) 10Jforrester: Fix height when descriptions not present [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207141 (owner: 10Esanders)
[17:33:10] <wikibugs>	 10MediaWiki-ResourceLoader, 7Upstream: CSSJanus only supports flipping one text-shadow or border-shadow in RTL languages while the CSS syntax allows multiple - https://phabricator.wikimedia.org/T62805#1242275 (10Krinkle) 5Open>3Resolved a:3Krinkle I can't reproduce this in the latest version of CSSJanus....
[17:33:16] <grrrit-wm>	 (03PS12) 10Jforrester: [NEVER MERGE] Local hack for testing link inspector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/206390 (owner: 10Esanders)
[17:36:03] <wikibugs>	 10MediaWiki-Page-editing, 10MediaWiki-ResourceLoader, 7JavaScript: jquery dialog with auto size takes 50% screen width in RTL language wikis - https://phabricator.wikimedia.org/T86979#1242290 (10Krinkle) 5Open>3stalled Awaiting feedback from #i18n about what the desired course of action is.
[17:36:19] <wikibugs>	 10MediaWiki-Page-editing, 10MediaWiki-ResourceLoader, 7JavaScript: jquery dialog with auto size takes 50% screen width in RTL language wikis - https://phabricator.wikimedia.org/T86979#1242293 (10Krinkle) p:5High>3Normal
[17:37:33] <wikibugs>	 10MediaWiki-ResourceLoader, 10Sentry: Add startup script to automatically wrap asynchronous functions in try..catch - https://phabricator.wikimedia.org/T85262#1242302 (10Krinkle) p:5High>3Low
[17:38:24] <wikibugs>	 10WikiEditor: Update browser blacklists for WikiEditor modules - https://phabricator.wikimedia.org/T78527#1242316 (10Krinkle)
[17:38:48] <wikibugs>	 10MediaWiki-ResourceLoader: Implement a CSS preprocessor for direction flipping based on the content direction - https://phabricator.wikimedia.org/T89561#1242319 (10Krinkle) p:5Normal>3Low
[17:39:02] <James_F>	 Bah.
[17:39:07] <James_F>	 Someone screwed up.
[17:39:15] <Krenair>	 ?
[17:40:54] <James_F>	 RL patches aren't meant to come into here any more.
[17:41:02] <wikibugs>	 10MediaWiki-ResourceLoader, 7Performance: Allow minification of SVG files - https://phabricator.wikimedia.org/T36812#1242334 (10Krinkle) p:5Low>3Normal
[17:41:21] <wikibugs>	 10MediaWiki-ResourceLoader, 7Performance: Allow minification of SVG files - https://phabricator.wikimedia.org/T36812#389647 (10Krinkle) Raising priority per T59777. We're using more SVGs nowadays.
[17:41:31] <wikibugs>	 10MediaWiki-ResourceLoader, 7Tracking: CSSMin::encodeImageAsDataURI() should be smarter about SVG images (tracking) - https://phabricator.wikimedia.org/T59777#1242345 (10Krinkle) 5Open>3stalled p:5High>3Normal
[17:42:36] <Krinkle>	 James_F: Aye, yeah. I guess #wikimedia-dev suffices for that
[17:42:54] <Krinkle>	 or is it because I'm the acting user. in which cause -editing :)
[17:42:54] <James_F>	 Krinkle: I moved them to -editing, but someone merged without rebasing and undid it.
[17:42:56] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Templates: Improve tabbing in template dialog - https://phabricator.wikimedia.org/T97323#1242362 (10Neil_P._Quinn_WMF) @Whatamidoing-WMF, T70768 is about choosing between two designs for tabbing behavior (one where the info and trash button accessible from the keyboard,...
[17:43:02] <Krinkle>	 Oh, yikes
[17:43:17] <James_F>	 Yeah. :-(
[17:44:45] <wikibugs>	 10MediaWiki-ResourceLoader: Support loading legacy "site" and "user" modules with mw.loader - https://phabricator.wikimedia.org/T32358#348628 (10Krinkle)
[17:44:48] <wikibugs>	 10MediaWiki-ResourceLoader, 7Performance: ResourceLoader: Avoid making a separate request for the site module - https://phabricator.wikimedia.org/T65587#1242378 (10Krinkle)
[17:45:08] <Krinkle>	 I'm creating a quick workboard for RL at https://phabricator.wikimedia.org/project/board/274/ - way overdue.
[17:49:23] <wikibugs>	 10OOjs-UI, 6Collaboration-Team, 10Flow: Migrate Flow components to OO UI - https://phabricator.wikimedia.org/T97442#1242406 (10Mattflaschen) 3NEW
[17:49:49] <wikibugs>	 10MediaWiki-ResourceLoader: Force <noscript> to render in old browsers that are given a "no-javascript" environment - https://phabricator.wikimedia.org/T73522#1242417 (10Krinkle) Lazy-parsing `<noscript>` is possible, but it isn't as straight forward as I made it seem. It might be too generic and is certainly fr...
[17:50:08] <wikibugs>	 10MediaWiki-ResourceLoader: Let skins set $wgResourceLoaderSkinScripts for core (and other?) RL modules that have skin-specific scripts - https://phabricator.wikimedia.org/T78368#1242428 (10Jdforrester-WMF) a:5Jdforrester-WMF>3None
[17:51:10] <wikibugs>	 10MediaWiki-ResourceLoader, 7Technical-Debt: ResourceLoader: Redesign how debug mode operates - https://phabricator.wikimedia.org/T85805#1242433 (10Krinkle)
[17:51:13] <wikibugs>	 10MediaWiki-ResourceLoader: ResourceLoader: Remove obsolete closures from files - https://phabricator.wikimedia.org/T50886#1242432 (10Krinkle)
[17:51:37] <wikibugs>	 10MediaWiki-ResourceLoader: ResourceLoader: Remove obsolete closures from files - https://phabricator.wikimedia.org/T50886#1242435 (10Krinkle) p:5Normal>3Low
[17:52:46] <wikibugs>	 10OOjs-UI, 6Collaboration-Team, 10Flow: Migrate Flow components to OO UI - https://phabricator.wikimedia.org/T97442#1242454 (10Mattflaschen)
[17:53:03] <wikibugs>	 10MediaWiki-ResourceLoader: Unversioned module requests (e.g. "site") should not take 5 minutes to roll over - https://phabricator.wikimedia.org/T49941#1242459 (10Krinkle)
[17:55:40] <wikibugs>	 10VisualEditor: VisualEditor: Easy way to reproduce a weird behavior with the link tool - https://phabricator.wikimedia.org/T70102#1242471 (10Neil_P._Quinn_WMF) Test comment! Hi mom!
[17:57:50] <Krenair>	 RoanKattouw, hey, you there?
[17:58:31] <RoanKattouw>	 Yeah
[17:59:18] <wikibugs>	 10MediaWiki-ResourceLoader: Unversioned module requests (e.g. "site") should not take 5 minutes to roll over - https://phabricator.wikimedia.org/T49941#1242485 (10Krinkle) 5Open>3declined a:3Krinkle At the moment the duration of 5 minutes is by design. This is not related to master-slave database replicati...
[18:00:53] <wikibugs>	 10MediaWiki-Page-editing: Say use BACK key. Else returnToMain will throw away the users edit - https://phabricator.wikimedia.org/T19683#1242498 (10He7d3r)
[18:01:10] <Krenair>	 RoanKattouw, I haven't made any progress on https://phabricator.wikimedia.org/T95919#1234009 because I've been busy with other things
[18:01:26] <wikibugs>	 10MediaWiki-ResourceLoader, 7Tracking: ResourceLoader: Cache issues (tracking) - https://phabricator.wikimedia.org/T56945#641361 (10Krinkle)
[18:01:31] <wikibugs>	 10MediaWiki-ResourceLoader, 10Deployment-Systems, 6operations: Bad cache stuck due to race condition with scap between different web servers - https://phabricator.wikimedia.org/T47877#1242508 (10Krinkle)
[18:01:36] <wikibugs>	 10MediaWiki-ResourceLoader, 7Tracking: ResourceLoader: Cache issues (tracking) - https://phabricator.wikimedia.org/T56945#1242509 (10Krinkle) 5Open>3Resolved a:3Krinkle
[18:03:47] <Krenair>	 RoanKattouw, but if you could look at it that'd be great
[18:03:59] <Krenair>	 sigh... it also looks like they want to hold a meeting
[18:04:41] <RoanKattouw>	 Yeah Dan said something about that when he was here last week
[18:05:11] <Krenair>	 I guess I'll decide whether I'm going to decline or not at the weekend
[18:08:30] <wikibugs>	 10WikiEditor, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review: editSessionID is duplicated in Edit:Schema for Wikitext - https://phabricator.wikimedia.org/T95919#1242548 (10Catrope) >>! In T95919#1234009, @Krenair wrote: > Yeah, the new session IDs created when you hit the back button are shorter...
[18:08:42] <wikibugs>	 10WikiEditor, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review: editSessionID is duplicated in Edit:Schema for Wikitext - https://phabricator.wikimedia.org/T95919#1242550 (10Jdforrester-WMF) >>! In T95919#1242184, @Halfak wrote: > @Jdforrester-WMF, @Catrope & @Krenair.  Any progress here?   What do...
[18:10:39] <Krenair>	 James_F, RoanKattouw: I *think* there might be a point there regarding sampling of events after we re-generate the ID for the purposes of getting a new session when you press back
[18:10:50] <RoanKattouw>	 oooooh
[18:10:56] <RoanKattouw>	 Right, the 25% thing
[18:10:57] <James_F>	 Krenair: Oooh, OK. That was not clear from the task.
[18:10:58] <RoanKattouw>	 Good point
[18:11:26] <RoanKattouw>	 No he used the phrase "I don't think we sample them correctly", I just completely failed to realize what that meant
[18:11:36] <RoanKattouw>	 Yeah that's probably a problem
[18:11:46] <James_F>	 Don't they sample based on the first character of the string?
[18:11:52] <Krenair>	 Before we merged that re-generation commit we assumed that if there was a session ID set, it was not filtered out by the sample code
[18:11:56] <James_F>	 So however long it is, it should Just Work™?
[18:12:07] <James_F>	 Hmm.
[18:12:09] <Krenair>	 But in this commit we ignore the sampling and just set a new ID
[18:14:53] <RoanKattouw>	 I'll work on that later today
[18:15:50] <James_F>	 Thanks, RoanKattouw.
[18:18:36] <wikibugs>	 10MediaWiki-ResourceLoader, 10WikiEditor, 7Performance: wikieditor pages not being cached by browsers when they should be - https://phabricator.wikimedia.org/T71211#1242582 (10Krinkle) Assuming this is not reproducible on a Wikimedia wiki, the most likely cause is that jhaar's wiki may have caching incorrect...
[18:19:19] <wikibugs>	 10MediaWiki-ResourceLoader, 10WikiEditor, 7Performance: wikieditor pages not being cached by browsers when they should be - https://phabricator.wikimedia.org/T71211#1242584 (10Krinkle) 5Open>3declined a:3Krinkle Closing since original author does not have a Phabricator account and most likely won't rea...
[18:20:24] <wikibugs>	 10VisualEditor, 3Editing Department 2014/15 Q4 blockers: Internal links weirdly mangled in VisualEditor - https://phabricator.wikimedia.org/T97447#1242588 (10gpaumier) 3NEW
[18:22:57] <grrrit-wm>	 (03PS6) 10Paladox: Change location of Search-Replace Link adjacent to Insert Links [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/149925 (https://phabricator.wikimedia.org/T25824) (owner: 10Gerrit Patch Uploader)
[18:23:10] <grrrit-wm>	 (03PS7) 10Paladox: Change location of Search-Replace Link adjacent to Insert Links [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/149925 (https://phabricator.wikimedia.org/T25824) (owner: 10Gerrit Patch Uploader)
[18:25:00] <grrrit-wm>	 (03PS10) 10Paladox: Added GLOBAL[''] [extensions/Math] - 10https://gerrit.wikimedia.org/r/206804 (https://phabricator.wikimedia.org/T88946) 
[18:26:06] <wikibugs>	 10MediaWiki-ResourceLoader, 5Patch-For-Review, 7Performance: ResourceLoader should not respond with HTTP 304 without Expires (and other) headers - https://phabricator.wikimedia.org/T53283#1242628 (10Krinkle) a:3aaron
[18:26:19] <wikibugs>	 10VisualEditor, 3Editing Department 2014/15 Q4 blockers: Perform a weekly review of edits made with VisualEditor - https://phabricator.wikimedia.org/T94767#1242636 (10gpaumier) 2015-04-28: * [[ https://en.wikipedia.org/w/index.php?oldid=659709258#Tue_Apr_28_2015_09:14:38_GMT-0700_.28PDT.29.2C_Guillaume_.28WMF....
[18:30:54] <grrrit-wm>	 (03PS20) 10Paladox: Add svg to LESS file [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/195529 (https://phabricator.wikimedia.org/T37342) 
[18:33:09] <James_F>	 RoanKattouw: https://gerrit.wikimedia.org/r/#/c/204269/7/src/ui/contextitems/ve.ui.TableContextItem.js
[18:34:54] <wikibugs>	 10MediaWiki-ResourceLoader: ResourceLoader: Responses for load.php should compress content - https://phabricator.wikimedia.org/T47935#1242694 (10Krinkle) 5Open>3stalled
[18:37:56] <wikibugs>	 10MediaWiki-ResourceLoader: Move mediawiki.special.js to a separate module - https://phabricator.wikimedia.org/T49134#1242723 (10Krinkle)
[18:38:10] <wikibugs>	 10MediaWiki-ResourceLoader, 7Technical-Debt: Move mediawiki.special.js to a separate module - https://phabricator.wikimedia.org/T49134#512278 (10Krinkle)
[18:39:41] <wikibugs>	 10MediaWiki-ResourceLoader, 7Technical-Debt: Move mediawiki.special.js to a separate module - https://phabricator.wikimedia.org/T49134#512278 (10Krinkle) There is no bug that I can see, though there is technical debt.  We never load "mediawiki.special" as a module, only as a stylesheet. So this is consistent....
[18:41:59] <wikibugs>	 10MediaWiki-ResourceLoader, 7I18n: Mediawiki no longer accepts unicode object property name without quotes - https://phabricator.wikimedia.org/T53539#1242736 (10Krinkle) This is most likely because special Unicode characters, like reserved words, were not allowed in object literals and dot notation in ES3. The...
[18:42:11] <wikibugs>	 10MediaWiki-ResourceLoader, 7JavaScript: ResourceLoader JavaScript parser should allow ES5 syntax features - https://phabricator.wikimedia.org/T96901#1228876 (10Krinkle)
[18:42:14] <wikibugs>	 10MediaWiki-ResourceLoader, 7I18n: Mediawiki no longer accepts unicode object property name without quotes - https://phabricator.wikimedia.org/T53539#1242738 (10Krinkle)
[18:43:42] <wikibugs>	 10MediaWiki-ResourceLoader, 7Upstream: [upstream] @import in LESS should try relative path before consulting global import paths - https://phabricator.wikimedia.org/T62368#1242745 (10Krinkle) 5Open>3stalled
[18:43:45] <wikibugs>	 10MediaWiki-ResourceLoader: [Regression] @import "./variables" stopped working for custom skins in 1.23 - https://phabricator.wikimedia.org/T66595#1242748 (10Krinkle)
[18:46:55] <wikibugs>	 10MediaWiki-ResourceLoader: CSSMin: Support @embed for external urls - https://phabricator.wikimedia.org/T42832#1242757 (10Krinkle) 5Open>3declined
[18:48:31] <wikibugs>	 10WikiEditor, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review: editSessionID is duplicated in Edit:Schema for Wikitext - https://phabricator.wikimedia.org/T95919#1242777 (10Halfak) > I get weird sessions with short sessionIds that only have "ready" events rather than the expected new, full session...
[18:48:51] <wikibugs>	 10Citoid, 10VisualEditor: Change label on Citoid tool to say "Look up" - https://phabricator.wikimedia.org/T97353#1242780 (10Whatamidoing-WMF) "Look-up" is not a verb.  It's either an adjective (as in "the look-up action") or a noun ("Lookup" with extra hyphenation; the extra hyphenation is commonly recommende...
[18:49:16] <wikibugs>	 10MediaWiki-ResourceLoader, 7Technical-Debt: ResourceLoader should have a context instead of using global object variables - https://phabricator.wikimedia.org/T36738#1242781 (10Krinkle)
[18:49:41] <wikibugs>	 10MediaWiki-ResourceLoader: Unable to refer to core images in extension styles - https://phabricator.wikimedia.org/T36493#1242787 (10Krinkle) 5Open>3declined a:3Krinkle
[18:51:25] <wikibugs>	 10MediaWiki-ResourceLoader: Wrong output of duplicate stylesheet links for site module - https://phabricator.wikimedia.org/T31720#1242797 (10Krinkle) 5stalled>3declined a:3Krinkle Please re-open if this is still an issue.
[18:57:27] <wikibugs>	 10MediaWiki-ResourceLoader, 6Performance-Team, 5Patch-For-Review: Make addModuleStyles modules marked as "bottom" actually load at the bottom - https://phabricator.wikimedia.org/T97420#1242830 (10Gilles) @krinkle can CSS-only modules added via addModules end up at the bottom in no JS mode?  The reason to be...
[18:59:22] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable: Be able to set placeholder text (generic content?) on an empty CE surface - https://phabricator.wikimedia.org/T96593#1221523 (10Pginer-WMF)
[18:59:48] <wikibugs>	 10MediaWiki-ResourceLoader, 6Performance-Team, 5Patch-For-Review: Make addModuleStyles modules marked as "bottom" actually load at the bottom - https://phabricator.wikimedia.org/T97420#1242855 (10Gilles) I know that it's easy to do with JS and RL, but the styles we're talking in my use case can't be JS-only....
[19:02:30] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review, and 3 others: On second edit attempt between loads, VisualEditor fails to load, complaining about revID mis-match - https://phabricator.wikimedia.org/T97069#1242869 (10Krenair) I just tested this and could...
[19:04:55] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review, and 3 others: On second edit attempt between loads, VisualEditor fails to load, complaining about revID mis-match - https://phabricator.wikimedia.org/T97069#1242872 (10Ryasmeen) Krenair, Trying on Firefox?...
[19:05:01] <wikibugs>	 10VisualEditor, 7Design: Flow for adding a new citation - https://phabricator.wikimedia.org/T97390#1242873 (10aripstra) Please provide an estimate of how long it will take to implement these designs so we can plan for usability testing.
[19:10:47] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review, and 3 others: On second edit attempt between loads, VisualEditor fails to load, complaining about revID mis-match - https://phabricator.wikimedia.org/T97069#1242907 (10Krenair) Have checked it in FF 37, yep.
[19:11:23] <wikibugs>	 10MediaWiki-ResourceLoader, 6Performance-Team, 5Patch-For-Review: Make addModuleStyles modules marked as "bottom" actually load at the bottom - https://phabricator.wikimedia.org/T97420#1242908 (10Krinkle) >>! In T97420#1242855, @Gilles wrote: > [..] there's no reason to make no-JS so much slower in terms of...
[19:12:49] <wikibugs>	 10MediaWiki-ResourceLoader, 7JavaScript: ResourceLoader JavaScript parser should allow ES5 syntax features - https://phabricator.wikimedia.org/T96901#1242912 (10Krinkle) p:5Triage>3Normal
[19:18:42] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review, and 3 others: On second edit attempt between loads, VisualEditor fails to load, complaining about revID mis-match - https://phabricator.wikimedia.org/T97069#1242935 (10Ryasmeen) Getting it in Chrome too  {...
[19:22:46] <wikibugs>	 10MediaWiki-ResourceLoader, 6Performance-Team, 5Patch-For-Review: Make addModuleStyles modules marked as "bottom" actually load at the bottom - https://phabricator.wikimedia.org/T97420#1242944 (10Gilles) My question remains: does the regular bottom queue work in no-JS mode for styles modules? getScriptsForBo...
[19:27:43] <grrrit-wm>	 (03PS4) 10Krinkle: ve.utils: Add ve.fixBase() utility [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/206463 (owner: 10Catrope)
[19:28:02] <grrrit-wm>	 (03CR) 10Krinkle: [C: 032] ve.utils: Add ve.fixBase() utility [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/206463 (owner: 10Catrope)
[19:28:38] <wikibugs>	 10VisualEditor, 10VisualEditor-Tables: Clean up mess from copy-pasted tables - https://phabricator.wikimedia.org/T97462#1242957 (10Whatamidoing-WMF) 3NEW
[19:30:46] <grrrit-wm>	 (03Merged) 10jenkins-bot: ve.utils: Add ve.fixBase() utility [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/206463 (owner: 10Catrope)
[19:30:57] <wikibugs>	 10MediaWiki-ResourceLoader, 6Performance-Team, 5Patch-For-Review: Make addModuleStyles modules marked as "bottom" actually load at the bottom - https://phabricator.wikimedia.org/T97420#1242982 (10Krinkle) >>! In T97420#1242944, @Gilles wrote: > My question remains: does the regular bottom queue work in no-JS...
[19:37:56] <wikibugs>	 10MediaWiki-ResourceLoader, 6Performance-Team, 5Patch-For-Review: Make addModuleStyles modules marked as "bottom" actually load at the bottom - https://phabricator.wikimedia.org/T97420#1243009 (10Gilles) In no-JS mode all the CSS is loaded in the head with addModuleStyles. Because currently addModuleStyles o...
[19:38:05] <RoanKattouw>	 Krinkle: Hey do you have any idea why mw.log.error would be undefined on beta labs?
[19:39:39] <Krinkle>	 Note that that method was added less than a week ago
[19:40:06] <RoanKattouw>	 Ugh
[19:40:09] <Krinkle>	 But ahm, yeah, it should be fine
[19:40:13] <Krinkle>	 But beta is beta.
[19:40:15] <RoanKattouw>	 Somehow mediawiki.js hasn't updated on beta
[19:40:17] <Krinkle>	 Deployments are funky
[19:40:18] <RoanKattouw>	 But EventLogging has
[19:40:20] <RoanKattouw>	 So it keeps erroring
[19:40:22] <Krinkle>	 Aye
[19:41:08] <Krinkle>	 $ cat /srv/mediawiki-staging/php-master/resources/src/mediawiki/mediawiki.js | grep error
[19:41:08] <Krinkle>	 			 * Write a message the console's error channel.
[19:41:08] <Krinkle>	 			log.error = function () {
[19:41:11] <Krinkle>	 The file is updated
[19:41:21] <RoanKattouw>	 Can you touch it?
[19:41:57] <Krinkle>	 Yeah
[19:41:58] <Krinkle>	 doing
[19:42:11] <Krinkle>	 scapping the file now
[19:42:45] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Links, 7Design, 3Editing Department 2014/15 Q4 blockers, and 2 others: Icons for redirects, disambig, red link suggestions; default icon when there is no image - https://phabricator.wikimedia.org/T93694#1243039 (10Nirzar) @esanders can you tell me the dimension for...
[19:47:18] <grrrit-wm>	 (03PS1) 10Catrope: Follow-up c4cf18b02e: bring table icons back [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/207249 
[19:54:34] <grrrit-wm>	 (03PS1) 10Jforrester: Follow-up I3b9804b00: Fix names of table context icons [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/207253 
[19:55:04] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Follow-up I3b9804b00: Fix names of table context icons [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/207253 (owner: 10Jforrester)
[19:55:10] <grrrit-wm>	 (03Abandoned) 10Jforrester: Follow-up c4cf18b02e: bring table icons back [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/207249 (owner: 10Catrope)
[19:55:19] <grrrit-wm>	 (03PS1) 10Jforrester: Follow-up I3b9804b00: Fix names of table context icons [VisualEditor/VisualEditor] (wmf/1.26wmf3) - 10https://gerrit.wikimedia.org/r/207254 
[19:55:34] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Follow-up I3b9804b00: Fix names of table context icons [VisualEditor/VisualEditor] (wmf/1.26wmf3) - 10https://gerrit.wikimedia.org/r/207254 (owner: 10Jforrester)
[19:56:17] <grrrit-wm>	 (03PS1) 10Catrope: Follow-up 85381a6b75: update another instance of 'language' to 'textLanguage' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207255 
[19:56:41] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Follow-up 85381a6b75: update another instance of 'language' to 'textLanguage' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207255 (owner: 10Catrope)
[19:56:49] <grrrit-wm>	 (03PS1) 10Jforrester: Follow-up 85381a6b75: update another instance of 'language' to 'textLanguage' [extensions/VisualEditor] (wmf/1.26wmf3) - 10https://gerrit.wikimedia.org/r/207256 
[19:57:05] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Follow-up 85381a6b75: update another instance of 'language' to 'textLanguage' [extensions/VisualEditor] (wmf/1.26wmf3) - 10https://gerrit.wikimedia.org/r/207256 (owner: 10Jforrester)
[19:57:22] <grrrit-wm>	 (03PS1) 10Catrope: Update for Id369ecaec704 in MW core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207258 
[19:58:17] <James_F>	 RoanKattouw: https://gerrit.wikimedia.org/r/#/c/204566/3/VisualEditor.php
[19:59:32] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Follow-up 85381a6b75: update another instance of 'language' to 'textLanguage' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207255 (owner: 10Catrope)
[20:00:32] <grrrit-wm>	 (03CR) 10Jforrester: "…" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207255 (owner: 10Catrope)
[20:00:35] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Follow-up 85381a6b75: update another instance of 'language' to 'textLanguage' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207255 (owner: 10Catrope)
[20:01:02] <grrrit-wm>	 (03Merged) 10jenkins-bot: Follow-up I3b9804b00: Fix names of table context icons [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/207253 (owner: 10Jforrester)
[20:01:04] <grrrit-wm>	 (03Merged) 10jenkins-bot: Follow-up I3b9804b00: Fix names of table context icons [VisualEditor/VisualEditor] (wmf/1.26wmf3) - 10https://gerrit.wikimedia.org/r/207254 (owner: 10Jforrester)
[20:01:08] <grrrit-wm>	 (03Merged) 10jenkins-bot: Follow-up 85381a6b75: update another instance of 'language' to 'textLanguage' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207255 (owner: 10Catrope)
[20:01:10] <grrrit-wm>	 (03Merged) 10jenkins-bot: Follow-up 85381a6b75: update another instance of 'language' to 'textLanguage' [extensions/VisualEditor] (wmf/1.26wmf3) - 10https://gerrit.wikimedia.org/r/207256 (owner: 10Jforrester)
[20:01:47] <grrrit-wm>	 (03PS2) 10Catrope: Update for Id369ecaec704 in MW core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207258 
[20:02:49] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Update VE core submodule to master (345f2be) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/206847 (owner: 10Jforrester)
[20:06:13] <grrrit-wm>	 (03PS1) 10Jforrester: Update VisualEditor core submodule to 1.26wmf3 HEAD (8c55266) [extensions/VisualEditor] (wmf/1.26wmf3) - 10https://gerrit.wikimedia.org/r/207261 
[20:07:24] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Update VisualEditor core submodule to 1.26wmf3 HEAD (8c55266) [extensions/VisualEditor] (wmf/1.26wmf3) - 10https://gerrit.wikimedia.org/r/207261 (owner: 10Jforrester)
[20:10:18] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update VE core submodule to master (345f2be) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/206847 (owner: 10Jforrester)
[20:10:50] <grrrit-wm>	 (03PS1) 10Catrope: Update VE core submodule to master (d1d06fc) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207265 
[20:11:04] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update VisualEditor core submodule to 1.26wmf3 HEAD (8c55266) [extensions/VisualEditor] (wmf/1.26wmf3) - 10https://gerrit.wikimedia.org/r/207261 (owner: 10Jforrester)
[20:11:31] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Update VE core submodule to master (d1d06fc) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207265 (owner: 10Catrope)
[20:13:21] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update VE core submodule to master (d1d06fc) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207265 (owner: 10Catrope)
[20:13:27] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Port ve.init.mw.Target to ve.fixBase() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/206464 (owner: 10Catrope)
[20:18:57] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Update for Id369ecaec704 in MW core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207258 (owner: 10Catrope)
[20:21:13] <grrrit-wm>	 (03Merged) 10jenkins-bot: Port ve.init.mw.Target to ve.fixBase() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/206464 (owner: 10Catrope)
[20:21:18] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update for Id369ecaec704 in MW core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207258 (owner: 10Catrope)
[20:22:09] <James_F>	 RoanKattouw: https://gerrit.wikimedia.org/r/#/c/203475/
[20:22:30] <wikibugs>	 10MediaWiki-ResourceLoader, 10OOjs-UI, 10VisualEditor, 3Editing Department 2014/15 Q4 blockers, and 2 others: RL manifest for OOjs UI icon packs should be better - https://phabricator.wikimedia.org/T92551#1243173 (10Jdforrester-WMF) Done?
[20:26:49] <grrrit-wm>	 (03PS4) 10Catrope: Move setDocument call from ve.dm.Document up to ve.Document [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/203475 
[20:29:23] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Move setDocument call from ve.dm.Document up to ve.Document [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/203475 (owner: 10Catrope)
[20:31:14] <grrrit-wm>	 (03PS5) 10Catrope: Move setDocument call from ve.dm.Document up to ve.Document [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/203475 
[20:33:44] <grrrit-wm>	 (03CR) 10Jforrester: [C: 031] "With this, ve.Document and ve.dm.Document coverage goes from 94.48% to 94.51%." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/203475 (owner: 10Catrope)
[20:37:57] <grrrit-wm>	 (03CR) 10Krinkle: [C: 032] Move setDocument call from ve.dm.Document up to ve.Document [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/203475 (owner: 10Catrope)
[20:38:17] <James_F>	 Thanks, Krinkle.
[20:39:12] <wikibugs>	 10WikiEditor, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review: editSessionID is duplicated in Edit:Schema for Wikitext - https://phabricator.wikimedia.org/T95919#1243236 (10Jdforrester-WMF) >>! In T95919#1242777, @Halfak wrote: >> I get weird sessions with short sessionIds that only have "ready" e...
[20:40:52] <grrrit-wm>	 (03Merged) 10jenkins-bot: Move setDocument call from ve.dm.Document up to ve.Document [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/203475 (owner: 10Catrope)
[20:44:13] <wikibugs>	 10Citoid, 10VisualEditor: Change label on Citoid tool to say "Look up" - https://phabricator.wikimedia.org/T97353#1243248 (10mobrovac) >>! In T97353#1242780, @Whatamidoing-WMF wrote: > "Look-up" is not a verb.  It's either an adjective (as in "the look-up action") or a noun ("Lookup" with extra hyphenation; th...
[20:50:40] <Krinkle>	 RoanKattouw: :P I'm not sure that counts as code coverage. You added one line in an already covered method. So it went from 94.48% (154 / 163) to 94.51% (155 / 164)
[20:51:09] <Krinkle>	 But it;s good that ce nodes now have a document!
[20:51:23] <Krinkle>	 Bit scary that worked so far
[20:54:31] <RoanKattouw>	 It was technically already covered but this functionality wasn't being asserted
[20:54:37] <RoanKattouw>	 Also yeah .getDocument() returned null on all ce.Nodes
[20:54:44] <RoanKattouw>	 That was what made me fix this :)
[21:17:54] <wikibugs>	 10OOjs-UI, 10UI-Standardization: Move the "MediaWiki" OOjs UI theme to the MediaWiki repo - https://phabricator.wikimedia.org/T76633#1243391 (10matmarex)
[21:17:57] <wikibugs>	 10MediaWiki-ResourceLoader, 10OOjs-UI, 10VisualEditor, 3Editing Department 2014/15 Q4 blockers, and 2 others: RL manifest for OOjs UI icon packs should be better - https://phabricator.wikimedia.org/T92551#1243388 (10matmarex) 5Open>3Resolved Done.
[21:41:49] <grrrit-wm>	 (03PS8) 10Paladox: Change location of Search-Replace Link adjacent to Insert Links [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/149925 (https://phabricator.wikimedia.org/T25824) (owner: 10Gerrit Patch Uploader)
[21:57:41] <grrrit-wm>	 (03PS1) 10Catrope: Perform 25% sampling on the client side as well [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/207290 (https://phabricator.wikimedia.org/T95919) 
[21:58:56] <Krenair>	 >>> 'a' > 1
[21:58:57] <ecmabot-wm>	 Krenair: (boolean) false
[21:59:01] <Krenair>	 >>> 'a' < 1
[21:59:02] <ecmabot-wm>	 Krenair: (boolean) false
[21:59:10] <Krenair>	 >>> '1' > 'a'
[21:59:10] <ecmabot-wm>	 Krenair: (boolean) false
[21:59:16] <Krenair>	 >>> 'a' > '1'
[21:59:17] <ecmabot-wm>	 Krenair: (boolean) true
[22:01:21] <grrrit-wm>	 (03CR) 10Alex Monk: [C: 032] Perform 25% sampling on the client side as well [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/207290 (https://phabricator.wikimedia.org/T95919) (owner: 10Catrope)
[22:03:02] <grrrit-wm>	 (03Merged) 10jenkins-bot: Perform 25% sampling on the client side as well [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/207290 (https://phabricator.wikimedia.org/T95919) (owner: 10Catrope)
[22:03:37] <RoanKattouw>	 >>> '253abc'.charAt(0) > '3'
[22:03:37] <ecmabot-wm>	 RoanKattouw: (boolean) false
[22:03:40] <RoanKattouw>	 >>> 'f253abc'.charAt(0) > '3'
[22:03:41] <ecmabot-wm>	 RoanKattouw: (boolean) true
[22:05:30] <jdlrobson>	 \o what extension provides oojs-ui.styles.icons ?
[22:05:34] <jdlrobson>	 it's breaking a bunch of stuff in mobile
[22:05:49] <jdlrobson>	 well 1 major thing so far..
[22:09:00] <RoanKattouw>	 Oh crap
[22:09:12] <RoanKattouw>	 I merged MatmaRex's OOUI-icons-via-RLIM patch
[22:09:28] <RoanKattouw>	 I grepped extensions that I knew used OOUI and updated VE, but I didn't realize mobile used it
[22:09:42] <RoanKattouw>	 jdlrobson: What's broken? Missing icons probably? Or did mw-ui-icon get messed up?
[22:09:50] <jdlrobson>	 https://phabricator.wikimedia.org/T97473 :-/
[22:10:07] <MatmaRex>	 oh. hmph
[22:10:12] <MatmaRex>	 icon name clash
[22:10:16] <jdlrobson>	 RoanKattouw:  i haven't debugged too much but it seems like oojs-ui.styles.icons is being loaded straight away
[22:10:17] <RoanKattouw>	 Right
[22:10:20] <jdlrobson>	 rather than defer loaded
[22:10:26] <RoanKattouw>	 Well the loading order shouldn't matter
[22:10:37] <RoanKattouw>	 It does matter because there is an icon naming conflict between OOUI and MWUI
[22:10:56] <jdlrobson>	 RoanKattouw: sure but as a side note if none of the css is being used you might as well defer load it
[22:11:04] <RoanKattouw>	 And we introduced this new feature where OOUI icons are automatically made available as MWUI icons
[22:11:04] <jdlrobson>	 but right now we just need to resolve the name clash
[22:11:25] <jdlrobson>	 are they all loaded by default?
[22:11:42] <MatmaRex>	 jdlrobson: oojs-ui.styles.icons is loaded when you load oojs-ui
[22:11:56] <MatmaRex>	 these are the "basic" icons
[22:12:16] <jdlrobson>	 MatmaRex: okay phew this isn't so bad then - we only load oojs-ui in beta
[22:12:19] <MatmaRex>	 there are plenty more in "icon packs", which are not loaded normally
[22:12:23] <jdlrobson>	 so this bug isn't for all users luckily
[22:12:39] <MatmaRex>	 (or when you call OutputPage::enabledOOUI() server-side)
[22:12:43] <MatmaRex>	 enableOOUI*
[22:13:23] <jdlrobson>	 you'll have to be careful with oojs-ui.styles.icons since we may have more nameclashes
[22:13:29] <jdlrobson>	 (mobile is using mw-ui-icon all over the place)
[22:14:31] <jdlrobson>	 so anyway we have 2 options... 1) We switch to your settings icon but we'd need it in white rather than black (as originally discussed in icon standardisation as something we needed) 2) we rename both icons to something less generic
[22:15:32] <RoanKattouw>	 The white rather than black thing is probably easy enough by just requesting the inverted variant
[22:16:05] <jdlrobson>	 but how would we do that using your icon pack?
[22:16:11] <MatmaRex>	 jdlrobson: mw-ui-icon-advanced-invert
[22:16:13] <MatmaRex>	 i think
[22:16:22] <MatmaRex>	 that is a white cog icon, which should also be loaded by default
[22:16:33] <RoanKattouw>	 I think he needs mw-ui-icon-settings-invert ?
[22:16:40] <MatmaRex>	 jdlrobson: (by the way, i can't repro the issue on betalabs)
[22:16:50] <jdlrobson>	 RoanKattouw: yup that works
[22:16:57] <jdlrobson>	 MatmaRex: try http://en.m.wikipedia.beta.wmflabs.org/wiki/Headings?mobileaction=beta
[22:17:08] <MatmaRex>	 RoanKattouw: MW 'settings' icon is a cog, OOUI 'settings' icon is a "knobs" icon
[22:17:12] <jdlrobson>	 ok i'll grab kaity and have a chat
[22:17:20] <MatmaRex>	 OOUI 'advanced' icon is a cog
[22:17:25] <RoanKattouw>	 Ooh OK
[22:18:19] <MatmaRex>	 jdlrobson: oh, i can repro there. hmm. what does 'mobileaction=beta' do, exactly?
[22:18:28] <MatmaRex>	 (i have both beta and experimental enabled in MF settings)
[22:19:04] <MatmaRex>	 ah wait, nevermind.
[22:20:27] <jdlrobson>	 MatmaRex: we use oojs ui more in beta hence the inconsistency
[22:21:08] <MatmaRex>	 (i was looking at a wrong wiki, i can repro)
[22:25:01] <jdlrobson>	 anyway this is good, means we can start identifying inconsistent icons :)
[23:18:00] <grrrit-wm>	 (03PS4) 10Jforrester: [WIP] Add new icons for link search results [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207120 (https://phabricator.wikimedia.org/T93694) 
[23:18:28] <grrrit-wm>	 (03PS7) 10Jforrester: Separate inputting of internal and external links [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207062 (https://phabricator.wikimedia.org/T93699) (owner: 10Esanders)
[23:26:16] <grrrit-wm>	 (03PS3) 10Jforrester: Fix height when descriptions not present [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207141 (owner: 10Esanders)
[23:26:24] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Fix height when descriptions not present [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207141 (owner: 10Esanders)
[23:28:30] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix height when descriptions not present [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207141 (owner: 10Esanders)
[23:49:07] <grrrit-wm>	 (03PS1) 10Krinkle: Remove obsolete bin/generateDocs.sh script [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207316 
[23:49:12] <grrrit-wm>	 (03PS1) 10Krinkle: bin: Enable 'set -e' and 'set -u' in bash scripts [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207317 
[23:55:37] <grrrit-wm>	 (03PS13) 10Jforrester: [NEVER MERGE] Local hack for testing link inspector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/206390 (owner: 10Esanders)
[23:55:39] <grrrit-wm>	 (03PS8) 10Jforrester: Separate inputting of internal and external links [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207062 (https://phabricator.wikimedia.org/T93699) (owner: 10Esanders)
[23:55:41] <grrrit-wm>	 (03PS8) 10Jforrester: Replacing current order of link suggestions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207015 (https://phabricator.wikimedia.org/T93698) (owner: 10SuchetaG)
[23:55:55] <grrrit-wm>	 (03CR) 10Jforrester: "PS8 is a rebase." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207062 (https://phabricator.wikimedia.org/T93699) (owner: 10Esanders)
[23:56:05] <grrrit-wm>	 (03CR) 10Jforrester: "PS8 is a rebase." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207015 (https://phabricator.wikimedia.org/T93698) (owner: 10SuchetaG)
[23:57:04] <grrrit-wm>	 (03PS2) 10Jforrester: Remove obsolete bin/generateDocs.sh script [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207316 (owner: 10Krinkle)
[23:57:13] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Remove obsolete bin/generateDocs.sh script [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207316 (owner: 10Krinkle)
[23:58:11] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] bin: Enable 'set -e' and 'set -u' in bash scripts [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207317 (owner: 10Krinkle)