[00:00:06] (03PS1) 10Krinkle: bin: Enable 'set -e' and 'set -u' in bash scripts [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/207323 [00:00:19] (03PS1) 10Jforrester: bin: Remove buildi18n-json.sh, unused since 2013 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207325 [00:00:51] (03Merged) 10jenkins-bot: Remove obsolete bin/generateDocs.sh script [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207316 (owner: 10Krinkle) [00:00:53] (03Merged) 10jenkins-bot: bin: Enable 'set -e' and 'set -u' in bash scripts [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207317 (owner: 10Krinkle) [00:00:56] (03CR) 10Krinkle: "Ran all three script to ensure they run error-less and and produce clean no-op branches." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/207323 (owner: 10Krinkle) [00:01:47] Krinkle: You doing the same for MW core versions of these scripts? [00:02:36] (03CR) 10Sharmaans: "Hello Dr. Schubotz," [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/206465 (owner: 10Sharmaans) [00:04:55] Sure [00:07:48] (03CR) 10Jforrester: [C: 032] bin: Enable 'set -e' and 'set -u' in bash scripts [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/207323 (owner: 10Krinkle) [00:07:50] (03CR) 10Krinkle: [C: 032] bin: Remove buildi18n-json.sh, unused since 2013 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207325 (owner: 10Jforrester) [00:10:10] (03CR) 10Jforrester: "(Let's kill the other one too.)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207325 (owner: 10Jforrester) [00:10:33] Oh right [00:10:36] Yeah, go for it :D [00:10:37] (03Merged) 10jenkins-bot: bin: Enable 'set -e' and 'set -u' in bash scripts [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/207323 (owner: 10Krinkle) [00:10:56] (03PS2) 10Jforrester: bin: Remove buildi18n-*.sh, unused since 2013 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207325 [00:11:42] (03CR) 10Krinkle: [C: 032] bin: Remove buildi18n-*.sh, unused since 2013 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207325 (owner: 10Jforrester) [00:13:54] (03PS1) 10Jforrester: Follow-up a4bbe98cd: Kill emptiness hack check in bin/updateSubmodule.sh too [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207330 [00:14:00] (And that, please.) [00:14:33] (03Merged) 10jenkins-bot: bin: Remove buildi18n-*.sh, unused since 2013 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207325 (owner: 10Jforrester) [00:36:30] James_F: do you prefer to wait with wikipedias until tomorrow? [00:36:47] gwicke: I think so. Just in case. [00:37:12] kk, lets schedule for tomorrow morning [00:37:31] https://gerrit.wikimedia.org/r/#/c/206320/ [00:40:28] {{done}} [00:47:46] (03CR) 10Jforrester: [C: 032] HtmlView: Move "default", "example", and "autovalue" under description [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/207124 (owner: 10Krinkle) [00:47:55] (03CR) 10Jforrester: [C: 032] Add example property to HTML rendering [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/207123 (https://phabricator.wikimedia.org/T53049) (owner: 10Krinkle) [00:48:45] gwicke: Thanks! [00:49:34] (03Merged) 10jenkins-bot: Add example property to HTML rendering [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/207123 (https://phabricator.wikimedia.org/T53049) (owner: 10Krinkle) [00:49:36] (03Merged) 10jenkins-bot: HtmlView: Move "default", "example", and "autovalue" under description [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/207124 (owner: 10Krinkle) [00:50:42] Krinkle: Also, could you +2 https://gerrit.wikimedia.org/r/#/c/207330/ please? [00:51:30] James_F: Unless I did it wrong in the other commit, that should be -n not -z [00:51:33] (03PS1) 10GWicke: Revert "Update RESTBase pre-connect URL to hit /_preconnect" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207340 (https://phabricator.wikimedia.org/T97500) [00:51:42] -z means the variable is empty [00:51:53] Krinkle: I just copied it. [00:51:57] Krinkle: So… [00:52:14] I think the other was = not != [00:52:25] Oh, right. [00:52:38] :) [00:53:05] Good catch though, I hadn't tested that one. I guess that one is broken right now [00:53:13] It is. [00:53:16] I tested the update-* scripts [00:53:22] (03CR) 10Alex Monk: "why?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207340 (https://phabricator.wikimedia.org/T97500) (owner: 10GWicke) [00:54:10] Krinkle: {{done}} [00:54:57] (03CR) 10Jforrester: [C: 04-1] Revert "Update RESTBase pre-connect URL to hit /_preconnect" (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207340 (https://phabricator.wikimedia.org/T97500) (owner: 10GWicke) [00:56:59] (03CR) 10GWicke: Revert "Update RESTBase pre-connect URL to hit /_preconnect" (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207340 (https://phabricator.wikimedia.org/T97500) (owner: 10GWicke) [00:57:22] (03CR) 10Krinkle: [C: 032] Follow-up a4bbe98cd: Kill emptiness hack check in bin/updateSubmodule.sh too [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207330 (owner: 10Jforrester) [00:57:28] Krinkle: Ta. [00:58:53] (03Merged) 10jenkins-bot: Follow-up a4bbe98cd: Kill emptiness hack check in bin/updateSubmodule.sh too [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207330 (owner: 10Jforrester) [01:03:52] (03PS1) 10GWicke: Revert "Pre-fetch RESTBase DNS and negotiate TLS" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207345 [01:03:56] (03CR) 10jenkins-bot: [V: 04-1] Revert "Pre-fetch RESTBase DNS and negotiate TLS" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207345 (owner: 10GWicke) [01:07:38] (03PS2) 10GWicke: Revert "Pre-fetch RESTBase DNS and negotiate TLS" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207345 (https://phabricator.wikimedia.org/T97500) [01:09:14] (03CR) 10jenkins-bot: [V: 04-1] Revert "Pre-fetch RESTBase DNS and negotiate TLS" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207345 (https://phabricator.wikimedia.org/T97500) (owner: 10GWicke) [01:10:07] (03PS3) 10GWicke: Revert "Pre-fetch RESTBase DNS and negotiate TLS" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207345 (https://phabricator.wikimedia.org/T97500) [01:10:57] (03Abandoned) 10GWicke: Revert "Update RESTBase pre-connect URL to hit /_preconnect" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207340 (https://phabricator.wikimedia.org/T97500) (owner: 10GWicke) [01:13:30] (03CR) 10Alex Monk: [C: 04-1] "commit message does not provide reason for reverting" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207345 (https://phabricator.wikimedia.org/T97500) (owner: 10GWicke) [01:14:43] (03PS4) 10GWicke: Revert "Pre-fetch RESTBase DNS and negotiate TLS" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207345 (https://phabricator.wikimedia.org/T97500) [01:16:04] (03CR) 10Alex Monk: Revert "Pre-fetch RESTBase DNS and negotiate TLS" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207345 (https://phabricator.wikimedia.org/T97500) (owner: 10GWicke) [01:16:59] [13oojs.github.io] 15jdforrester created 06release-1.1.7 (+1 new commit): 02https://github.com/oojs/oojs.github.io/commit/aaa2aaba2330 [01:17:00] 13oojs.github.io/06release-1.1.7 14aaa2aab 15James D. Forrester: Publish v1.1.7 release from npm [01:18:08] [13oojs.github.io] 15jdforrester opened pull request #9: Publish v1.1.7 release from npm (06master...06release-1.1.7) 02https://github.com/oojs/oojs.github.io/pull/9 [01:22:39] (03PS1) 10Jforrester: Update OOjs to v1.1.7 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/207350 [01:26:26] (03PS2) 10Jforrester: Add unregister method to ModelRegistry [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/206374 (owner: 10Esanders) [01:26:54] (03CR) 10Jforrester: "PS2 is a rebase onto the OOjs release pull-through of the dependency." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/206374 (owner: 10Esanders) [02:04:29] (03PS1) 10Jforrester: Update VE core submodule to master (170bc6b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207360 [02:11:42] (03CR) 10Krinkle: [C: 032] Update OOjs to v1.1.7 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/207350 (owner: 10Jforrester) [02:12:34] (03CR) 10Krinkle: [C: 032] Update VE core submodule to master (170bc6b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207360 (owner: 10Jforrester) [02:14:18] (03Merged) 10jenkins-bot: Update OOjs to v1.1.7 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/207350 (owner: 10Jforrester) [02:14:20] (03Merged) 10jenkins-bot: Update VE core submodule to master (170bc6b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207360 (owner: 10Jforrester) [04:40:56] (03CR) 10Divec: [C: 04-1] Add unregister method to ModelRegistry (033 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/206374 (owner: 10Esanders) [09:36:13] (03PS14) 10Esanders: [NEVER MERGE] Local hack for testing link inspector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/206390 [09:36:15] (03PS9) 10Esanders: Separate inputting of internal and external links [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207062 (https://phabricator.wikimedia.org/T93699) [09:36:17] (03PS9) 10Esanders: Replacing current order of link suggestions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207015 (https://phabricator.wikimedia.org/T93698) (owner: 10SuchetaG) [10:09:18] Hey, have installed VisualEditor on my mediawiki, but when pressing the "Edit" button the progress bar just hangs, inspection complains about this: Unknown dependency: oojs-ui.styles.icons-editing-advanced [10:11:00] Is it missing files in resources/lib/oojs-ui directory? [10:17:35] (03PS15) 10Esanders: [NEVER MERGE] Local hack for testing link inspector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/206390 [10:17:37] (03PS10) 10Esanders: Separate inputting of internal and external links [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207062 (https://phabricator.wikimedia.org/T93699) [10:17:39] (03PS10) 10Esanders: Replacing current order of link suggestions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207015 (https://phabricator.wikimedia.org/T93698) (owner: 10SuchetaG) [10:17:41] (03PS1) 10Esanders: Only pull description from wikibase [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207411 [10:21:03] (03CR) 10jenkins-bot: [V: 04-1] Separate inputting of internal and external links [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207062 (https://phabricator.wikimedia.org/T93699) (owner: 10Esanders) [13:40:33] (03PS16) 10Esanders: [NEVER MERGE] Local hack for testing link inspector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/206390 [13:40:35] (03PS1) 10Esanders: Follow redirects in the link inspector API [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207440 [14:12:54] (03CR) 10Esanders: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207062 (https://phabricator.wikimedia.org/T93699) (owner: 10Esanders) [14:48:47] (03CR) 10Jforrester: [C: 032] Replacing current order of link suggestions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207015 (https://phabricator.wikimedia.org/T93698) (owner: 10SuchetaG) [14:50:53] (03Merged) 10jenkins-bot: Replacing current order of link suggestions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207015 (https://phabricator.wikimedia.org/T93698) (owner: 10SuchetaG) [14:51:22] (03CR) 10Jforrester: [C: 032] "Let's do the insert-internal-with-http-as-external fix later." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207062 (https://phabricator.wikimedia.org/T93699) (owner: 10Esanders) [14:51:33] (03CR) 10Jforrester: [C: 032] Only pull description from wikibase [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207411 (owner: 10Esanders) [14:53:13] (03Merged) 10jenkins-bot: Separate inputting of internal and external links [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207062 (https://phabricator.wikimedia.org/T93699) (owner: 10Esanders) [14:53:16] (03Merged) 10jenkins-bot: Only pull description from wikibase [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207411 (owner: 10Esanders) [14:53:41] (03CR) 10Jforrester: [C: 032] Follow redirects in the link inspector API [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207440 (owner: 10Esanders) [14:55:14] (03Merged) 10jenkins-bot: Follow redirects in the link inspector API [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207440 (owner: 10Esanders) [14:59:10] edsanders: You working on https://phabricator.wikimedia.org/T93694 ? [14:59:48] (Sorry.) [15:04:42] (03Abandoned) 10Jforrester: [NEVER MERGE] Local hack for testing link inspector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/206390 (owner: 10Esanders) [15:07:13] No, nirzar is [15:07:45] at least that's what I told Trevor yesterday before I went out [15:07:48] edsanders: On the CSS and the hooking into the code? Or just replacing the assets? [15:07:56] edsanders: What's wrong with my tweaked assets at least for now? [15:08:07] redesigning them to look good at 24x24 & 48x48 [15:08:43] Could we put them in as-is now and replace the images later? [15:08:48] ok [15:08:51] * James_F just wants to get this mostly out the door. [15:09:41] * edsanders is responsible for the quality of the code the team generates [15:09:48] Yes. [15:09:56] Which is why it's so high. [15:16:14] (03PS3) 10Esanders: Convert 'external' links to internal pages pasted into the search field [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201627 (https://phabricator.wikimedia.org/T94334) (owner: 10Alex Monk) [15:47:12] (03CR) 10Jforrester: [C: 031] Convert 'external' links to internal pages pasted into the search field [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201627 (https://phabricator.wikimedia.org/T94334) (owner: 10Alex Monk) [15:49:08] James_F: jscs has been unleashed [15:49:28] Krinkle: Woo. Full stack done? [15:49:30] and an associated grunt-jscs release [15:49:33] Yep [15:49:34] Krinkle: Time to write some patches? [15:49:38] Yeah :D [15:49:53] grunt-jscs v1.8.0 / node-jscs v1.13.0 [15:50:00] * James_F nods. [15:50:14] https://phabricator.wikimedia.org/T90816 [15:50:18] I'll do a few to start with [15:50:33] Want me to take a couple? [15:54:30] James_F: Also updating karma-coverage (which fixes the bug where text-summary needs dir but shouldn't), and karma-chrome-launcher (which fixes the CHROME_BIN) [15:55:09] Both patches I submitted in February I think, but they made it :) [15:56:57] (03PS1) 10Jforrester: build: Bump various devDependencies [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/207468 (https://phabricator.wikimedia.org/T90816) [15:57:10] Krinkle: ^^^ Like that? :-) [15:58:27] (03PS1) 10Krinkle: build: Bump dependencies [unicodejs] - 10https://gerrit.wikimedia.org/r/207470 [15:59:15] (03PS2) 10Krinkle: build: Bump dependencies [unicodejs] - 10https://gerrit.wikimedia.org/r/207470 [15:59:15] Right [15:59:34] (03PS1) 10Jforrester: build: Bump various devDependencies [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207471 (https://phabricator.wikimedia.org/T90816) [15:59:56] James_F: Be sure to include the Gruntfile fixup as well [16:00:03] (03CR) 10Jforrester: [C: 032] build: Bump dependencies [unicodejs] - 10https://gerrit.wikimedia.org/r/207470 (owner: 10Krinkle) [16:01:06] (03Merged) 10jenkins-bot: build: Bump dependencies [unicodejs] - 10https://gerrit.wikimedia.org/r/207470 (owner: 10Krinkle) [16:02:17] Looks like QUnit 1.18 has a new diff [16:02:18] finally [16:02:21] haven't seen this one yet [16:04:32] projects that support node.js should stay on 1.17 since node-qunit (third party) doesn't support 1.18 due to a bug [16:04:46] But VE is fine :) [16:19:50] James_F, RoanKattouw_away, edsanders: see discussion in ops [16:20:03] (03Restored) 10Esanders: [NEVER MERGE] Local hack for testing link inspector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/206390 (owner: 10Esanders) [16:20:46] (03PS1) 10Marcoil: WIP: T86782: Load module ext.cite.style [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207483 [16:20:48] (03CR) 10Paladox: "@Physikerwelt please review. seems global has problems. so by using GLOBAL[''] fixed problem." [extensions/Math] - 10https://gerrit.wikimedia.org/r/206804 (https://phabricator.wikimedia.org/T88946) (owner: 10Paladox) [16:21:55] (03CR) 10jenkins-bot: [V: 04-1] WIP: T86782: Load module ext.cite.style [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207483 (owner: 10Marcoil) [16:24:05] (03CR) 10Alex Monk: [C: 032] Revert "Pre-fetch RESTBase DNS and negotiate TLS" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207345 (https://phabricator.wikimedia.org/T97500) (owner: 10GWicke) [16:24:56] RoanKattouw_away: So as we suspected, Apple did indeed not fix the off-by-one error in their JS JIT compiler in iOS 8.3 so jQuery update it is.. [16:26:01] (03Merged) 10jenkins-bot: Revert "Pre-fetch RESTBase DNS and negotiate TLS" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207345 (https://phabricator.wikimedia.org/T97500) (owner: 10GWicke) [16:32:36] (03PS1) 10Marcoil: WIP: T86782: Horrible hack to make the new Cite CSS appear in VE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207487 [16:33:35] (03CR) 10jenkins-bot: [V: 04-1] WIP: T86782: Horrible hack to make the new Cite CSS appear in VE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207487 (owner: 10Marcoil) [16:37:52] James_F: Could you merge the master patch for the jQuery update so that it makes it into the new wmf4? [16:42:01] Krinkle: Could you get the wmf3 one on the SWAT window or done out-of-order? [16:43:07] James_F: Already on SWAT for this evening [16:43:15] Krinkle: Ta. [16:43:24] thx [16:43:32] We should bump VE and OOjs UI too. [16:44:13] edsanders: Code doesn't need to be unabandoned to be tested with. :-) [16:45:42] 10Cite, 10Parsoid, 5Patch-For-Review: Use CSS to style Parsoid's Cite extension output - https://phabricator.wikimedia.org/T86782#1245994 (10marcoil) Preliminary patches are available in gerrit. They are all considered WIP, but pushing them to get early feedback on the general approach. * https://gerrit.wik... [16:47:13] Oh, that checkbox for tag editing/revdel thing relates to one of my first MediaWiki patches... [16:47:24] https://gerrit.wikimedia.org/r/#/c/6904/ [16:47:30] James_F, I want it to be hung off the end of other commits so other people testing it have it [16:47:35] Krenair: :-) [16:47:39] edsanders: Sure. [16:47:52] Of course, I didn't cause the bug [16:48:00] That's a newer thing [16:48:07] Indeed. [16:48:14] I'm sceptical it's a regression. [16:48:18] Because I never saw it working. [16:48:19] Did you? [16:49:16] I doubt it ever worked [16:49:24] Yeah. [16:49:28] because it didn't modify https://gerrit.wikimedia.org/r/#/c/6904/1/includes/logging/LogEventsList.php [16:49:35] Who wrote this tag editing thing, anyway? [16:49:41] (https://gerrit.wikimedia.org/r/#/c/203061/9 didn't, I mean) [16:49:45] Maybe we should revert the feature. [16:49:45] TTO [16:49:49] ... why? [16:50:04] Well, if it doesn't work, it seems poor form to taunt users with it. [16:50:33] Why can't we simply fix the bug? [16:50:56] Why can't people implementing features make them work? [16:51:03] It does work for some users [16:51:14] Sysops and others who can delete pages. [16:51:26] Which isn't the best advert for equality. :-) [16:51:51] (03PS5) 10Esanders: Show different icons for different result types [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207120 (https://phabricator.wikimedia.org/T93694) (owner: 10Jforrester) [16:51:53] (03PS17) 10Esanders: [NEVER MERGE] Local hack for testing link inspector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/206390 [16:53:48] (03CR) 10Jforrester: [C: 031] Show different icons for different result types [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207120 (https://phabricator.wikimedia.org/T93694) (owner: 10Jforrester) [16:53:51] edsanders: Want to +2? [16:54:20] I'd like code review [16:55:11] Krenair: Could you? We'd like to get it in before the cut. [16:55:27] oh, the wmf4 cut? [16:55:29] (Sorry for the rush.) [16:55:30] Yeah. [16:55:32] looking [16:55:36] Thanks. [16:57:56] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 7Design, 3Editing Department 2014/15 Q4 blockers, and 2 others: Icons for redirects, disambig, red link suggestions; default icon when there is no image - https://phabricator.wikimedia.org/T93694#1246025 (10Jdforrester-WMF) [16:59:43] (03CR) 10Alex Monk: [C: 032] Show different icons for different result types [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207120 (https://phabricator.wikimedia.org/T93694) (owner: 10Jforrester) [16:59:45] (03PS18) 10Esanders: [NEVER MERGE] Local hack for testing link inspector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/206390 [16:59:47] (03PS1) 10Esanders: Make static methods static in linkCache [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207492 [17:01:34] (03Merged) 10jenkins-bot: Show different icons for different result types [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207120 (https://phabricator.wikimedia.org/T93694) (owner: 10Jforrester) [17:02:11] (03CR) 10Esanders: Add unregister method to ModelRegistry (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/206374 (owner: 10Esanders) [17:06:48] 10VisualEditor: Doesn't show wrong interlanguage interwiki link, so it can't be fixed either - https://phabricator.wikimedia.org/T97547#1246056 (10Elitre) 3NEW [17:08:23] 10VisualEditor, 6Mobile-Web: Extremely high amount of errors for anonymous editors - https://phabricator.wikimedia.org/T97494#1246083 (10Jdlrobson) [17:13:27] 10MediaWiki-ResourceLoader, 5MW-1.25-release, 7Performance, 7Wikimedia-log-errors: User modules constantly invalidate their cache timestamp - https://phabricator.wikimedia.org/T94810#1246093 (10Krinkle) >>! In T94810#1199543, @Krinkle wrote: > I assume the reason these timestamps are computed from a startu... [17:17:12] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 7Design, 3Editing Department 2014/15 Q4 blockers, and 2 others: Icons for redirects, disambig, red link suggestions; default icon when there is no image - https://phabricator.wikimedia.org/T93694#1246098 (10Jdforrester-WMF) 5Open>3Resolved [17:17:16] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 7Design, 3Editing Department 2014/15 Q4 blockers: New search interface for link dialogue - https://phabricator.wikimedia.org/T76397#1246099 (10Jdforrester-WMF) [17:17:22] (03CR) 10Krinkle: [C: 031] "Untested, looks good." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207492 (owner: 10Esanders) [17:17:36] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 7Design, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-29_(1.26wmf4): New search interface for link dialogue - https://phabricator.wikimedia.org/T76397#1246101 (10Jdforrester-WMF) 5Open>3Resolved [17:19:23] Krinkle: Any chance you could respond to https://phabricator.wikimedia.org/T52707 in the next 30 minutes? It's going to be the third week in a row that it's discussed at the weekly triage at 11:00… [17:20:37] (03CR) 10Divec: Add unregister method to ModelRegistry (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/206374 (owner: 10Esanders) [17:23:32] James_F: OK [17:27:25] 10VisualEditor, 10VisualEditor-MediaWiki, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review, and 3 others: On second edit attempt between loads, VisualEditor fails to load, complaining about revID mis-match - https://phabricator.wikimedia.org/T97069#1246134 (10Jdforrester-WMF) 5Open>3Resolved... [17:29:53] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 7Design, 3Editing Department 2014/15 Q4 blockers, and 3 others: New search interface for link dialogue - https://phabricator.wikimedia.org/T76397#1246146 (10Jdforrester-WMF) [17:40:17] 10VisualEditor, 3Editing Department 2014/15 Q4 blockers, 7Technical-Debt: Separate ve.init and ve.platform - https://phabricator.wikimedia.org/T52707#1246176 (10Krinkle) [17:40:54] 10VisualEditor, 3Editing Department 2014/15 Q4 blockers, 7Technical-Debt: Separate ve.init and ve.platform - https://phabricator.wikimedia.org/T52707#588553 (10Krinkle) [17:41:26] James_F: I've done a quick update. As it stands it doesn't seem high priority, but it depends on how important the blocked tasks are. [17:41:31] * James_F nods. [17:41:44] Krinkle: Thank you. [17:42:08] James_F: I'm not sure what you wanted to be rewritten though, so not sure if t's what you wnated. [17:42:49] I'll add a Goal section to clarify intent [17:42:55] Krinkle: I think it's fine. ISTR that Roan dictated the blocked task at me when he was in a rush. Thanks. [17:48:43] 10VisualEditor, 3Editing Department 2014/15 Q4 blockers, 7Technical-Debt: Separate ve.init and ve.platform - https://phabricator.wikimedia.org/T52707#1246196 (10Krinkle) [17:54:37] 10Citoid, 10TemplateData: Citoid and bot disagree about use of language parameter in cite book - https://phabricator.wikimedia.org/T97256#1246214 (10Rdicerb) Adding @Qgil, @Whatamidoing-WMF, @Elitre and @Quiddity to see how this can perhaps be made into a bot developer engagement process. May require different... [17:56:36] (03CR) 10Esanders: Add unregister method to ModelRegistry (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/206374 (owner: 10Esanders) [18:01:56] (03PS1) 10Esanders: Remove OOUI content icons [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207507 [18:03:58] 10VisualEditor: 2px gap between the 3 .oo-ui-iconElement and their associated indicator-down arrows - https://phabricator.wikimedia.org/T97555#1246269 (10Quiddity) 3NEW [18:04:38] (03CR) 10Divec: Add unregister method to ModelRegistry (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/206374 (owner: 10Esanders) [18:05:20] (03PS3) 10Divec: Add unregister method to ModelRegistry [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/206374 (owner: 10Esanders) [18:06:42] (03CR) 10jenkins-bot: [V: 04-1] Remove OOUI content icons [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207507 (owner: 10Esanders) [18:07:05] (03PS4) 10Divec: Add unregister method to ModelRegistry [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/206374 (owner: 10Esanders) [18:08:05] Hi :) Please excuse the noob question, I've been searching for about 15 mins now and figure one of you can help me faster! "Is there a way to install this as a beta feature on a custom mediawiki project and, if so, could you please point me in the right direction?" Thank you! [18:08:48] Roux_: There are installation instructions at https://www.mediawiki.org/wiki/Extension:VisualEditor [18:09:29] Installing VE is a bit less straightforward than installing a typical extension, but it can certainly be done; a bunch of people here run VE on their development machines [18:09:37] If you run into any problems, don't hesitate to ask here [18:11:21] Bless you! I honestly thought I was already on the extension page, haven't seen one this big -- I'll let you know if there's any trouble. Thanks :) [18:11:56] 10MediaWiki-ResourceLoader, 5MW-1.25-release, 7Performance, 7Wikimedia-log-errors: User modules constantly invalidate their cache timestamp - https://phabricator.wikimedia.org/T94810#1246302 (10Krinkle) It's primarily: 1. Desktop views from logged-in users This makes sense as OutputPage has to generate u... [18:14:22] Krenair, RoanKattouw: the _preconnect removal will need to be deployed before we can load from RB again [18:14:44] you want me to do it now? [18:16:53] Krenair: as in deploy the cherry-pick? [18:17:28] it's not crazy urgent as we rolled back the config change [18:17:34] is there a backport etc. or do we need to make one? [18:17:37] so swat could work [18:17:50] yes, would need a backport [18:18:05] it's a simple patch fortunately [18:18:07] 10VisualEditor, 10VisualEditor-EditingTools, 10Parsoid, 3Editing Department 2014/15 Q4 blockers: Link editor should guard against using interlanguage links - https://phabricator.wikimedia.org/T95850#1246331 (10Jdforrester-WMF) [18:18:33] 10VisualEditor, 10VisualEditor-EditingTools, 10Parsoid, 3Editing Department 2014/15 Q4 blockers: Link editor should guard against using interlanguage links - https://phabricator.wikimedia.org/T95850#1246333 (10Jdforrester-WMF) p:5Triage>3Low [18:19:13] Krenair: if you could handle the patches that'd be great [18:20:04] (03CR) 10Divec: [C: 031] "Happy to merge now; check whether my comments are OK." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/206374 (owner: 10Esanders) [18:21:03] 10VisualEditor, 10VisualEditor-CopyPaste, 3Editing Department 2014/15 Q4 blockers: Incorrect pasting of multi lined plain text - https://phabricator.wikimedia.org/T96006#1246337 (10Jdforrester-WMF) [18:24:08] 10Citoid, 10Graphoid, 6Mobile-Apps, 6Services, and 3 others: SCA services should not use a proxy for our domains - https://phabricator.wikimedia.org/T97530#1246355 (10mobrovac) p:5Unbreak!>3Normal @akosiaris reverted the LVS IP block in https://gerrit.wikimedia.org/r/#/c/207489 until we come up with a... [18:29:13] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers: Fix the jump when opening the mobile inspector - https://phabricator.wikimedia.org/T96289#1246370 (10Jdforrester-WMF) [18:34:30] 10VisualEditor, 10VisualEditor-MediaWiki: VisualEditor fails to load, complaining about revID mis-match - https://phabricator.wikimedia.org/T97558#1246405 (10Quiddity) 3NEW [18:34:37] James_F, ^ [18:37:52] Duplicate? [18:39:08] Oh [18:39:11] I think I understand what that is [18:39:42] 10VisualEditor, 10VisualEditor-MediaWiki: VisualEditor fails to load, complaining about revID mis-match - https://phabricator.wikimedia.org/T97558#1246417 (10Catrope) This is because we're trying to use the new RESTbase endpoint thing in beta and it doesn't seem to work there. [18:40:48] 10VisualEditor, 6Mobile-Web: Extremely high amount of errors for anonymous editors - https://phabricator.wikimedia.org/T97494#1246419 (10Anomie) >>! In T97494#1246071, @Jdlrobson wrote: > this.get( { action: 'tokens', type: type, assert: assert } ); What are your values for "type" and "assert" there? In parti... [18:41:38] quiddity: Dupe but not good. [18:41:48] (03CR) 10Esanders: [C: 032] Add unregister method to ModelRegistry [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/206374 (owner: 10Esanders) [18:42:38] Argh [18:42:40] Guess what [18:42:43] The correct URL is https://restbase-beta.wmflabs.org/en.wikipedia.beta.wmflabs.org/v1/ [18:42:45] But that 502s [18:43:14] (03CR) 10Esanders: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207507 (owner: 10Esanders) [18:44:46] (03Merged) 10jenkins-bot: Add unregister method to ModelRegistry [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/206374 (owner: 10Esanders) [18:45:48] RoanKattouw: Is the bug "Beta Cluster config for RB sucks"? [18:45:53] grumble grumble [18:46:28] I'm fixing it best I can [18:46:34] RoanKattouw: *hugs* [18:46:36] Working around the fact that everything under the sun is broken in labs [18:46:48] :-) [18:48:04] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-Links, 3Editing Department 2014/15 Q4 blockers: Copying link makes it relative to edited page - https://phabricator.wikimedia.org/T95136#1246431 (10Jdforrester-WMF) p:5Triage>3Normal [18:48:12] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 6Mobile-Web, 3Editing Department 2014/15 Q4 blockers, 7Technical-Debt: Move VisualEditor code from MobileFrontend to VisualEditor - https://phabricator.wikimedia.org/T96186#1246432 (10Jdforrester-WMF) p:5Triage>3Normal [18:48:27] 10VisualEditor, 10Parsoid, 3Editing Department 2014/15 Q4 blockers: nowiki around several lines, apparently for only 1 space at the beginning of a line - https://phabricator.wikimedia.org/T96093#1246433 (10Jdforrester-WMF) p:5Triage>3Low [18:51:19] 10VisualEditor, 10VisualEditor-ContentEditable, 3Editing Department 2014/15 Q4 blockers: Cursoring over an MWLinkNode takes you two characters to the right/left, not one - https://phabricator.wikimedia.org/T96307#1246445 (10Jdforrester-WMF) [18:51:27] 10WikiEditor, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review: action.abort.type in Schema:Edit not populated for Wikitext - https://phabricator.wikimedia.org/T95938#1246446 (10Jdforrester-WMF) [18:51:36] 10VisualEditor, 3Editing Department 2014/15 Q4 blockers: Link with as only label - https://phabricator.wikimedia.org/T95730#1246447 (10Jdforrester-WMF) [18:53:59] 10VisualEditor, 3Editing Department 2014/15 Q4 blockers, 7Technical-Debt: Separate ve.init and ve.platform - https://phabricator.wikimedia.org/T52707#1246450 (10Jdforrester-WMF) In the public weekly triage on 2015-04-29, we discussed this task. We decided that this task, though important, does not block furt... [18:54:04] 10VisualEditor, 7Technical-Debt: Separate ve.init and ve.platform - https://phabricator.wikimedia.org/T52707#1246451 (10Jdforrester-WMF) [18:56:13] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki-Mobile, 7Browser-Support-Apple-Safari, 3Editing Department 2014/15 Q4 blockers: VisualEditor: Safari on iPad converts numbers that resemble phone numbers to href=tel: links - https://phabricator.wikimedia.org/T55315#1246464 (10Jdforr... [18:56:19] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 7Browser-Support-Google-Chrome, 3Editing Department 2014/15 Q4 blockers: VisualEditor Mobile: Cannot save any edit in mobile VE for Nexus 7(Android 4.4.2) - https://phabricator.wikimedia.org/T68756#1246465 (10Jdforrester-WMF) [18:56:25] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 3Editing Department 2014/15 Q4 blockers: Frozen link inspector and "Uncaught Error..." when a link is repeatedly inserted after clicking in the same place in a blank paragraph in insert mode - https://phabricator.wikimedia.org/T91318#1246467 (10Jdforrester-WMF) [19:00:03] 10VisualEditor, 10VisualEditor-MediaWiki: Release VisualEditor-MediaWiki as "1.0" - https://phabricator.wikimedia.org/T84936#1246489 (10Jdforrester-WMF) [19:00:05] 10VisualEditor, 10VisualEditor-ContentLanguage: Cursor not moving past "ग्र" and other multiple code-unit grapheme clusters on left arrow key press - https://phabricator.wikimedia.org/T53846#1246486 (10Jdforrester-WMF) 5Open>3Resolved a:3Jdforrester-WMF Have tested quite a lot and this seems fine. [19:00:07] 10VisualEditor, 10VisualEditor-ContentLanguage, 7Tracking: VisualEditor multilingual input / i18n issues (tracking) - https://phabricator.wikimedia.org/T35077#1246490 (10Jdforrester-WMF) [19:01:21] 10VisualEditor, 10VisualEditor-ContentLanguage, 7I18n: VisualEditor: Add support for adding dir/lang attributes to paragraphs and similar arbitrary elements (div, p, lists etc.) - https://phabricator.wikimedia.org/T43009#1246494 (10Jdforrester-WMF) [19:01:34] 10VisualEditor, 10VisualEditor-ContentLanguage: VisualEditor: Provide a language inspector to handle
blocks and similar - https://phabricator.wikimedia.org/T62187#1246497 (10Jdforrester-WMF) [19:01:36] 10VisualEditor, 10VisualEditor-ContentLanguage, 7I18n: VisualEditor: Add support for adding dir/lang attributes to paragraphs and similar arbitrary elements (div, p, lists etc.) - https://phabricator.wikimedia.org/T43009#429948 (10Jdforrester-WMF) [19:07:33] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki-Mobile, 7Browser-Support-Apple-Safari, 3Editing Department 2014/15 Q4 blockers: VisualEditor: Safari on iPad converts numbers that resemble phone numbers to href=tel: links - https://phabricator.wikimedia.org/T55315#1246520 (10Jdforr... [19:07:35] 10VisualEditor, 10VisualEditor-DataModel, 10VisualEditor-MediaWiki, 7Tracking: Broken browser plugins cause cruft to be injected into the page - https://phabricator.wikimedia.org/T54327#1246523 (10Jdforrester-WMF) [19:07:37] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers: Make VisualEditor good enough for mobile tablet and phone enablement - https://phabricator.wikimedia.org/T94725#1246522 (10Jdforrester-WMF) [19:08:30] 10VisualEditor, 10Parsoid, 10RESTBase, 3Editing Department 2014/15 Q4 blockers, 7user-notice: Page edited with VE corrupted on save with wikitext of page from another wiki with same oldid - https://phabricator.wikimedia.org/T97155#1246525 (10Jdforrester-WMF) 5Open>3Resolved [19:09:08] (03PS1) 10Jforrester: Perform 25% sampling on the client side as well [extensions/WikiEditor] (wmf/1.26wmf3) - 10https://gerrit.wikimedia.org/r/207529 (https://phabricator.wikimedia.org/T95919) [19:09:15] (03CR) 10Jforrester: [C: 032] Perform 25% sampling on the client side as well [extensions/WikiEditor] (wmf/1.26wmf3) - 10https://gerrit.wikimedia.org/r/207529 (https://phabricator.wikimedia.org/T95919) (owner: 10Jforrester) [19:10:41] Krinkle: I think jQuery is trying to be smarter than it should be...I'm constructing a button thusly: this.$button = $( '