[00:01:24] 10VisualEditor, 10VisualEditor-Media: Image for Audio Clip Resizes - https://phabricator.wikimedia.org/T91574#1251126 (10Whatamidoing-WMF) [00:02:44] Krinkle: Hmm, @example doesn't appear to work after a custom tag? [00:02:59] this fails: @todo foo\n\n @example\n code here [00:03:11] this succeeds: @example\n code here\n\n@todo foo [00:07:27] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki-Media: VisualEditor: resizing audio file causes it to resize 0px dialogs do not report size. - https://phabricator.wikimedia.org/T69265#1251141 (10Whatamidoing-WMF) I'm seeing it start off with the 0px size (in the display), and no way... [00:11:31] RoanKattouw: It's an extension of the description. [00:11:41] Custom tags start the entity block / meta data [00:11:46] Aaah right OK [00:11:48] Yeah. It's a bit ticky [00:12:00] That explains a LOT [00:12:12] of why @example has been such a pain in the butt [00:12:12] RoanKattouw: Is it specific to custom tags? I'd expect it to also not work after @class or anything [00:12:17] I haven't checked [00:12:25] I only had @todo there which is a custom tag I added [00:12:36] After @example the description can even continue afaik [00:12:40] multiple examples [00:12:49] Whereas other tags are key/value pair [00:12:52] Which is why @example is indented. [00:12:54] Oh so that does work! [00:12:55] It's not a meta tag [00:12:56] I'll have to do that [00:13:14] after @todo it just becomes part of todo's body [00:13:20] per regular line continuation [00:13:34] But since t's only valid in class descriptions, it presumably became plain text or indented code [00:13:39] Yeaj [00:13:41] it did [00:13:43] Did you get an error? [00:13:44] ah, ok [00:13:46] cool [00:13:51] my parser is still up to date then :) [00:13:53] Multiple examples doesn't work though [00:14:05] Hm.. it should. [00:14:06] :D [00:14:21] What do I use to separate examples from each other? [00:14:22] I mean, I have no reason to believe it would work, other than that it it's logically possible. [00:14:26] I tried a double blank line [00:14:30] two empty lines with no indentation. [00:14:35] Maybe a paragraph of text to be sure. [00:15:01] Yeah it works if you add text [00:15:04] But I don't want to add text :( [00:15:30] Describe the example? [00:15:35] A brief label/title [00:15:54] Yeah trying that now [00:15:58] RoanKattouw: Also, examples can be given keyword 'preview' to start in the preview mode instead of editor [00:16:12] hah nice [00:16:15] Which is probably good for the type of classes that are very visual and identifiable in that way [00:16:17] Yeah maybe not for modal dialog examples :P [00:16:28] Also I don't have a working eg-iframe yet and that's pretty low on my list [00:16:39] So for the dozens of panel layouts we have, I'd find the preview more helpful. [00:16:49] Krinkle: You should tell Kirsten that though, for some of the OOUI ones we might want that [00:16:50] to identify what layout Im looking for [00:17:01] Yeah, I'm still figuring out when it's best to use it. [00:17:03] Not sure yet [00:21:06] I found a funny bug [00:21:43] If you do /** @class mw-ui.enhance */ at the top of a file with a bunch of global functions, it doesn't like that because you can't have - in the class name [00:22:37] So it adds mw-ui as a thing in the navigation, but when you go there it complains "class mw not found" and the functions end up being listed as global functions, but there are no "global function" warnings [00:22:52] Krinkle: BTW is there a flag to make jsduck not warn about global functions? [00:23:26] I realize this code base really shouldn't have them, but we'll fix that later, for now I'd like to be able to document my global functions without Jenkins going crazy [00:23:37] I can add fake @class things to each file that has them I guess [00:24:38] RoanKattouw: Flow? [00:25:01] Yeah [00:25:02] What kind of functions are these? [00:25:04] Tsk, talk about this in -collaboration. :-P [00:25:16] -editing [00:25:42] Or there. [00:26:08] 10MediaWiki-ResourceLoader, 6Mobile-Web, 6Performance-Team: Module user.groups styles should not be loaded on startup on all pages - https://phabricator.wikimedia.org/T97325#1251161 (10Jdlrobson) [00:26:13] 10MediaWiki-ResourceLoader, 6Mobile-Web, 6Performance-Team: Module user.groups styles should not be loaded on startup on all pages - https://phabricator.wikimedia.org/T97325#1251162 (10Jdlrobson) a:5Gilles>3None [00:29:53] Gah. [00:30:02] RL stuff is still coming into here. [00:30:09] James_F: Deja vu [00:30:21] * James_F considers hitting wikibugs again with an axe. [00:30:53] Hm.. http://tools.wmflabs.org/?tool=wikibugs [00:30:57] doesn't list you? [00:31:01] I thought.. [00:32:28] Yeah, I'm on grrrit-wm but not wikibugs. [00:32:39] I'd have to hit it with someone else's axe again. [00:32:59] Also, cool website: http://tools.wmflabs.org/wikibugs/ [00:37:44] (03CR) 10Jforrester: [C: 04-1] "Needs rebase." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/195236 (owner: 10Catrope) [00:38:06] TrevorParscal: https://gerrit.wikimedia.org/r/#/c/207974/ https://gerrit.wikimedia.org/r/#/c/207942/ https://gerrit.wikimedia.org/r/#/c/207935/ [00:40:54] 10VisualEditor, 10VisualEditor-ContentEditable: Nested italics and bold is handled differently by VE and mediawiki - https://phabricator.wikimedia.org/T97739#1251178 (10AxelBoldt) 3NEW [00:43:34] (03CR) 10Trevor Parscal: [C: 032] ve.init.mw.ViewPageTarget: Set custom font-size for original .mw-body-content too [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207974 (https://phabricator.wikimedia.org/T97690) (owner: 10Bartosz Dziewoński) [00:44:02] (03CR) 10Trevor Parscal: [C: 032] ve.ui.MWParameterPage: Remove dead CSS [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207942 (https://phabricator.wikimedia.org/T97516) (owner: 10Bartosz Dziewoński) [00:45:14] (03CR) 10Trevor Parscal: [C: 032] Use consistent error state for text input widgets [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/207935 (https://phabricator.wikimedia.org/T97516) (owner: 10Bartosz Dziewoński) [00:46:16] 10VisualEditor, 10VisualEditor-MediaWiki, 10UI-Standardization, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review: Use consistent error state for text input widgets - https://phabricator.wikimedia.org/T97516#1251212 (10Jdforrester-WMF) [00:46:21] 10VisualEditor, 10VisualEditor-MediaWiki, 10UI-Standardization, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review: Use consistent error state for text input widgets - https://phabricator.wikimedia.org/T97516#1244692 (10Jdforrester-WMF) [00:46:36] 10VisualEditor, 10VisualEditor-MediaWiki, 10UI-Standardization, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-05-06_(1.26wmf5): Use consistent error state for text input widgets - https://phabricator.wikimedia.org/T97516#1251214 (10Jdforrester-WMF) 5Open>3Resolved [00:46:52] 10VisualEditor, 10VisualEditor-MediaWiki, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-05-06_(1.26wmf5): [Regression pre-wmf5] Article font a lot smaller while loading VisualEditor - https://phabricator.wikimedia.org/T97690#1251220 (10Jdforrester-WMF) 5Open>3Resolved [00:46:53] (03Merged) 10jenkins-bot: ve.init.mw.ViewPageTarget: Set custom font-size for original .mw-body-content too [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207974 (https://phabricator.wikimedia.org/T97690) (owner: 10Bartosz Dziewoński) [00:47:41] (03Merged) 10jenkins-bot: ve.ui.MWParameterPage: Remove dead CSS [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207942 (https://phabricator.wikimedia.org/T97516) (owner: 10Bartosz Dziewoński) [00:47:50] (03Merged) 10jenkins-bot: Use consistent error state for text input widgets [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/207935 (https://phabricator.wikimedia.org/T97516) (owner: 10Bartosz Dziewoński) [01:23:17] (03PS1) 10Jforrester: Update VE core submodule to master (424a9f4) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/208054 [01:24:28] legoPanda: Time to re-sync extension.json for VisualEditor and delete VisualEditor.php? [01:24:30] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (424a9f4) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/208054 (owner: 10Jforrester) [01:24:40] James_F: yesssss! [01:24:48] well, not delete :P [01:24:53] legoPanda: Don't think it'll break the cluster? [01:24:55] Ha. [01:25:03] s/delete/replace with an error/ [01:25:10] CiteThisPage hasn't! [01:25:24] well it did, but that was fixed >.> [01:25:31] * James_F laughs. [01:25:43] Want me to do so, and you merge, or the reverse? [01:25:53] (The reverse works better as you'll know more.) [01:26:20] (03Merged) 10jenkins-bot: Update VE core submodule to master (424a9f4) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/208054 (owner: 10Jforrester) [01:26:24] I probably won't have time until later tonight, I'm deep in CA right now [01:26:28] Fun. [01:48:13] (03PS1) 10Jforrester: Update extension.json and empty out PHP entry point [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/208057 (https://phabricator.wikimedia.org/T87992) [01:49:18] (03CR) 10Jforrester: Update extension.json and empty out PHP entry point (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/208057 (https://phabricator.wikimedia.org/T87992) (owner: 10Jforrester) [01:58:22] (03PS2) 10Jforrester: Update extension.json, get rid of PHP entry point [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/201235 (owner: 10Legoktm) [01:59:03] (03CR) 10Jforrester: [C: 031] "PS2 is a rebase/regeneration/reconsideration-of-how-much-we-want-to-break-i18n. :-)" [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/201235 (owner: 10Legoktm) [02:49:47] 10OOjs-UI, 10Gather, 10Gather Sprint Greatest Hits, 6Mobile-Web, 3Mobile-Web-Sprint-46-Taken:-The-Dan-Garry-Story: Tiny search icon in alpha and Gather beta - https://phabricator.wikimedia.org/T97654#1251323 (10matmarex) Is there a list of mw-ui icon names used by MobileFrontend? They seem to be spread o... [06:41:24] 10VisualEditor, 10VisualEditor-MediaWiki: Editnotices with hidden content shows as "1 notice" - https://phabricator.wikimedia.org/T95822#1251429 (10Sunpriat) [10:05:32] 10VisualEditor, 10Parsoid, 10Parsoid-Nowiki, 3Editing Department 2014/15 Q4 blockers: VisualEditor: Adding nowiki tags in unrelated edit - https://phabricator.wikimedia.org/T70511#1251536 (10marcoil) 5Open>3Resolved I'm unable to reproduce. I suppose this was fixed in the round of `nowiki` work last qu... [11:35:56] 10TemplateData, 10VisualEditor, 10VisualEditor-EditingTools: TemplateData could mark meta templates, so they can be filtered out from autosuggest - https://phabricator.wikimedia.org/T97757#1251602 (10TheDJ) 3NEW [11:37:56] 10OOjs-UI, 10UI-Standardization, 7Design: PopupButtonWidget should be shown at hover not on-click. - https://phabricator.wikimedia.org/T88630#1251611 (10Prtksxna) a:5Prtksxna>3None Feel free to re-assign once we come to a resolution. [12:08:09] 10TemplateData, 6Community-Liaison, 10WMF-Product-Strategy: Please make me a list of commonly used templates in Wikipedia articles - https://phabricator.wikimedia.org/T96323#1251641 (10LuisV_WMF) @Ironholds any update on this? Curious. [12:12:47] 10TemplateData, 6Community-Liaison, 10WMF-Product-Strategy: Please make me a list of commonly used templates in Wikipedia articles - https://phabricator.wikimedia.org/T96323#1251650 (10Ironholds) As I reported to Rachel just two days ago, I've been in wall-to-wall S&D work this week and haven't had a time to... [12:13:47] 10TemplateData, 6Community-Liaison, 10WMF-Product-Strategy: Please make me a list of commonly used templates in Wikipedia articles - https://phabricator.wikimedia.org/T96323#1251653 (10LuisV_WMF) OK, good to know - thanks! (And obviously she's the right one to talk to about this stuff :) [14:12:57] 10VisualEditor, 10MediaWiki-extensions-Graph, 10Parsoid, 6Services, 3Google-Summer-of-Code-2015: Graph editing in VisualEditor - https://phabricator.wikimedia.org/T89287#1251847 (10Micru) All these examples look amazing, I wonde if they are relevant to this task >> https://github.com/mbostock/d3/wiki/Gal... [14:15:35] hi all. I have a couple of quick things for you. [14:17:03] the first one is that I'm trying to open https://es.wikipedia.org/w/index.php?title=Primera_B_(Argentina)&veaction=edit&vesection=6 in IE 11, and it just hangs (I'm not logged in there, if it helps, and trying to edit the entire article instead gives the same result). [14:19:29] the second one is that opening https://es.wikipedia.org/w/index.php?title=Primera_B_(Argentina)&veaction=edit&vesection=6 in other browsers (FF, Chrome, Opera) works instead but the section is totally out of focus. I need to scroll down the page to see it. [14:19:44] Do I need to file any of these? Thank you. [14:21:05] 10MediaWiki-Page-editing, 7I18n, 5Patch-For-Review: Long edit comments get entirely removed instead of truncated (error in cutting multibyte chars?) - https://phabricator.wikimedia.org/T85700#1251861 (10MaxBioHazard) https://ru.wikipedia.org/w/index.php?title=Теперь_его_дозор_окончен&diff=70530965&oldid=7047... [14:21:20] 10MediaWiki-Page-editing, 7I18n, 5Patch-For-Review: Long edit comments get entirely removed instead of truncated (error in cutting multibyte chars?) - https://phabricator.wikimedia.org/T85700#1251862 (10MaxBioHazard) 5Resolved>3Open [15:05:55] Good morning James_F! ^^^. [15:06:03] How are you, Elitre? [15:26:48] Busy, I think. Our friend at eswiki are discussing VE with me. [15:27:22] * James_F nods. [15:27:40] Tell me if you need any help. [15:42:59] (03PS11) 10Paladox: Added GLOBAL[''] [extensions/Math] - 10https://gerrit.wikimedia.org/r/206804 (https://phabricator.wikimedia.org/T88946) [15:45:31] (03PS21) 10Paladox: Add svg to LESS file [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/195529 (https://phabricator.wikimedia.org/T37342) [15:45:50] (03PS54) 10Paladox: Re add svg images [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (https://phabricator.wikimedia.org/T37342) [15:58:08] James_F: what I reported at 16:15 comes from an example I gave them, so I hoped that worked better :) [15:58:56] James_F: Also, we're having the edit/edit source conversation, and I'm explaining why "Edit with VE" is not optimal as an option. [15:59:45] Elitre: Yeah, could you file those issues? Being logged in or not shouldn't make a difference. [15:59:59] both of those?, and, sure thing! [16:00:03] Elitre: Yeah. [16:11:01] 10VisualEditor, 6Mobile-Web: Extremely high amount of errors for anonymous editors - https://phabricator.wikimedia.org/T97494#1243804 (10phuedx) Moved this to **In Sprint** as this appears to be actively investigated. [16:11:19] 10VisualEditor: VisualEditor hangs on loading - https://phabricator.wikimedia.org/T97788#1252141 (10Elitre) 3NEW [16:15:40] 10VisualEditor: Section out of focus while section-editing - https://phabricator.wikimedia.org/T97789#1252155 (10Elitre) 3NEW [16:18:59] James_F: was tempted to mark them as unbreak now, as for all of the bugs I reported so far :p [16:37:55] 10TemplateData, 10VisualEditor, 10VisualEditor-EditingTools: TemplateData could mark meta templates, so they can be filtered out from autosuggest - https://phabricator.wikimedia.org/T97757#1252209 (10FriedhelmW) A set of categories will do better than a magic word. In de.wp, documentation templates are in th... [16:47:54] 10OOjs-UI, 10Gather, 10Gather Sprint Greatest Hits, 6Mobile-Web, and 2 others: Tiny search icon in alpha and Gather beta - https://phabricator.wikimedia.org/T97654#1252219 (10matmarex) > It was copied from Apex, since apparently no one thought that one would be useful with MediaWiki UI… Sorry, that wasn't... [16:51:16] 10OOjs-UI, 10Gather, 10Gather Sprint Greatest Hits, 6Mobile-Web, and 2 others: Tiny search icon in alpha and Gather beta - https://phabricator.wikimedia.org/T97654#1252235 (10Jdlrobson) Phew! Thanks a bunch. Gives me more confidence that our icon styles/implementation can be merged somewhere down the line.... [17:06:46] 10OOjs-UI, 10Gather, 10Gather Sprint Greatest Hits, 6Mobile-Web, and 2 others: Tiny search icon in alpha and Gather beta - https://phabricator.wikimedia.org/T97654#1252334 (10matmarex) I filed T97793 to track down the conflicts. [17:14:42] James_F, so... [17:14:51] edsanders: So… [17:16:10] so...? [17:17:36] SO! [17:17:40] Oh, we merged the external link vs. internal link thing? [17:17:45] Nice! [17:17:53] 10Citoid, 10VisualEditor, 7Design, 3Editing Department 2014/15 Q4 blockers: Adjusted workflow for adding a new citation - https://phabricator.wikimedia.org/T97390#1252405 (10Jdforrester-WMF) [17:18:04] you wanted to talk to me about something [17:18:07] I only noticed it when I saw it on mw.o, heh [17:18:12] Krenair: Yup. A lovely set of changes from edsanders and Sucheta. [17:18:15] Krenair: :-) [17:18:16] Krenair, that's how we roll, deal with it [17:18:23] edsanders: https://phabricator.wikimedia.org/T97390 [17:18:52] edsanders: See the new mock-ups at the top of the description, ignore the rest. [17:18:57] Thank you edsanders & sucheta [17:19:00] +1 [17:19:10] neat [17:19:50] part of me reacts badly to 'automatic' / 'manual' but I can't think of anything better [17:19:58] 10OOjs-UI, 6Mobile-Web, 10UI-Standardization: Inconsistent icon used in mobile/oojs ui for clearing search results. - https://phabricator.wikimedia.org/T97804#1252409 (10Jdlrobson) 3NEW [17:20:01] I've been looking at https://phabricator.wikimedia.org/T95700 but couldn't figure out what link exactly was triggering this issue [17:20:21] edsanders: This means (1) no more cite menu (2) use the tabbed interface (3) embed the "re-use" panel into the list (4) Citoid extension would add the new "Automatic" panel (sub-class the inspector?) rather than build the whole thing. [17:20:57] on second thoughts, I'm not 100% sure if this is actually a suitable use of the tab interface [17:20:57] edsanders: Seem sane? [17:21:21] you're clicking on a tab to get access to buttons to click on [17:22:12] unless you are suggesting the manual dialogs are going to be squeezed into an inspector [17:22:31] edsanders: Yes, rather than the alternative of https://phab.wmfusercontent.org/file/data/i5w6xq3ijd6d5p7cdedf/PHID-FILE-o5z7yut2bop4ouqfpxkp/ph3zea32jc6oefdr/citation-box.png which is the same. [17:23:11] 'Yes' to what? [17:23:59] The link you followed to view this file is invalid or expired. [17:24:26] Krenair, it's the third mock in the description on the bug [17:24:32] I found it [17:25:01] Also, what does the 're-use' tab do? Show you a page with one button?? [17:26:08] the benefit of the tabs is that is can hide away advanced options, making things appear simpler to the beginner. the disadvantage is that we aren't really dealing with tabbed content [17:26:55] edsanders: The re-use tab has the current re-use dialog pane inside it. [17:27:10] edsanders: It makes the choices clear and plain. [17:27:19] does that fit in an inspector? [17:27:26] edsanders: The width is about the same, yes. [17:27:36] but it requires a fair amount of height [17:27:38] Don't have that mock-up on Phabriactor. [17:27:45] Sure, but that's OK. [17:28:03] The language inspector takes a bunch of height too. [17:30:08] 10VisualEditor, 6Collaboration-Team, 10Flow: VE debug bar not positioned / backgrounded in Flow - https://phabricator.wikimedia.org/T97807#1252468 (10Esanders) 3NEW [17:31:29] * edsanders measures [17:31:40] it's currently nearly twice as high (180 vs 300) [17:32:04] maybe squeeze it down to 250 [17:32:39] Yeah. [17:32:42] It doesn't need that height. [17:32:44] ew 'What do you want to reference' is not a good placeholder for that dialog [17:32:49] Most of it exists for it. [17:32:59] edsanders: Yeah, Nirzar had better copy for it. [17:35:07] MatmaRex, the document margins in VE are not quite right [17:35:56] the first para doesn't align with the header [17:36:52] 10OOjs-UI, 10VisualEditor, 6Mobile-Web, 10UI-Standardization: Inconsistent icon used in mobile/oojs ui for clearing search results. - https://phabricator.wikimedia.org/T97804#1252530 (10matmarex) I think it should be possible to use MobileFrontend's icon in OOjs UI. We use it in two places in VE: {F159363... [17:37:04] edsanders: eh [17:37:17] edsanders: sorry, we made to many breaking changes this week and i'm busy unbreaking MobileFrotnend [17:37:29] James_F: TrevorP|Away: thoughts on https://phabricator.wikimedia.org/T97804#1252530 ? [17:38:53] 10VisualEditor: Unable to select more than paragraph with the cursor - https://phabricator.wikimedia.org/T97809#1252533 (10Pginer-WMF) 3NEW [17:41:08] 10Citoid, 10VisualEditor, 3Editing Department 2014/15 Q4 blockers: Book ISBN links are broken in preview window because of /w/ instead of /wiki/ - https://phabricator.wikimedia.org/T95700#1252556 (10Krenair) What was the exact URL being used here? [17:43:05] 10VisualEditor: Unable to select more than one paragraph using the keyboard - https://phabricator.wikimedia.org/T97809#1252578 (10Pginer-WMF) [17:53:11] 10VisualEditor, 3Editing Department 2014/15 Q4 blockers: Unable to select more than one paragraph using the keyboard - https://phabricator.wikimedia.org/T97809#1252604 (10Catrope) [17:53:46] 10OOjs-UI, 10VisualEditor, 6Mobile-Web, 10UI-Standardization: Inconsistent icon used in mobile/oojs ui for clearing search results. - https://phabricator.wikimedia.org/T97804#1252611 (10matmarex) a:3matmarex [17:57:57] 10OOjs-UI, 10VisualEditor, 6Mobile-Web, 10UI-Standardization: Inconsistent icon used in mobile/oojs ui for clearing search results. - https://phabricator.wikimedia.org/T97804#1252630 (10matmarex) a:5matmarex>3None Oh, we have this icon available in OOjs UI as `closeInput`: {F159372,size=full,layout=inl... [18:19:34] 10MediaWiki-ResourceLoader, 10OOjs-UI: Support icons changing color on hover - https://phabricator.wikimedia.org/T97816#1252732 (10Catrope) 3NEW [18:28:50] 10VisualEditor, 6Editing Department, 3Google-Summer-of-Code-2015: Unified language proofing tools integration framework (GSoC'15 Proposal) - https://phabricator.wikimedia.org/T93752#1252825 (10Ankita-ks) [18:36:02] hi. I'm having some trouble when I run 'npm run-script doc'-- getting a lot of errors ... I'm not sure how to fix this. Does anyone have a moment to help me? [18:36:43] what errors? [18:37:06] oojs-ui@0.11.0 doc: `jsduck` [18:37:06] npm ERR! Exit status 2 [18:37:06] npm ERR! [18:37:06] npm ERR! Failed at the oojs-ui@0.11.0 doc script. [18:37:06] npm ERR! This is most likely a problem with the oojs-ui package, [18:37:07] npm ERR! not with npm itself. [18:37:07] npm ERR! Tell the author that this fails on your system: [18:37:08] npm ERR! jsduck [18:37:08] npm ERR! You can get their info via: [18:37:09] npm ERR! npm owner ls oojs-ui [18:37:09] npm ERR! There is likely additional logging output above. [18:37:10] npm ERR! System Darwin 14.1.0 [18:37:10] npm ERR! command "node" "/usr/local/bin/npm" "run-script" "doc" [18:37:11] npm ERR! cwd /Users/kirsten/Sites/ui [18:38:41] kirstenMA, so what happens when you simply run "jsduck"? [18:39:13] This happens when I run 'npm run-script doc' [18:39:44] That's what I've been doing whenever I update my local build. [18:40:16] oh, sorry. I'll try running jsduck [18:40:35] more warnings... [18:41:13] https://www.irccloud.com/pastebin/UvMC315Q [18:41:33] * RoanKattouw raises eyebrow [18:41:42] Did you modify jsduck.categories.json? [18:41:50] Oh, hold on, I see [18:41:54] Warning: /Users/kirsten/Sites/ui/node_modules/oojs/dist/oojs.jquery.js File not found [18:41:58] kirstenMA: Run npm install [18:42:03] okay [18:43:40] 10TemplateData, 6Community-Liaison, 10WMF-Product-Strategy: Please make me a list of commonly used templates in Wikipedia articles - https://phabricator.wikimedia.org/T96323#1252960 (10Rdicerb) Hmmm - had a quick chat with @JdForrester-WMF and he mentioned this kind of query frankly could take several days.... [18:44:55] RoanKattouw: That ran without errors, but a couple warnings. [18:45:39] https://www.irccloud.com/pastebin/MA9tgD8N [18:45:55] Oh, OK [18:46:00] That's probably harmless [18:46:11] jsduck should hopefully work now [18:46:20] okay. I will try it [18:46:48] Do I need to do the npm install each time I update my local build? [18:47:04] In theory, I think so [18:47:10] But in practice it doesn't need to be run that frequently [18:47:31] This time you had to run it because things were moved around, which doesn't happen often [18:48:11] ah. okay. Thank you! [18:48:16] 10TemplateData, 6Community-Liaison, 10WMF-Product-Strategy: Please make me a list of commonly used templates in Wikipedia articles - https://phabricator.wikimedia.org/T96323#1252986 (10Ironholds) That we could update terribly conveniently - but it won't note which ones have TemplateData entries :/. [18:48:21] Krinkle: To catch you up on the gist of the above: oojs moved, this broke jsduck until npm install was run, which is fine, but 'npm run doc' does not print jsduck's warnings at all, it just prints a message saying that it failed :S [18:50:07] Krinkle: Also, can I grab a +2 on https://gerrit.wikimedia.org/r/#/c/208060/ ? [18:50:42] RoanKattouw: Does npm-run eat all stderr from jsduck? [18:50:49] Or only for fatal errors? [18:51:00] Not sure [18:51:03] I've not experienced either [18:51:08] 10VisualEditor, 6Collaboration-Team: betalabs: Existing pages for File internal links are displayed red in VE - https://phabricator.wikimedia.org/T97830#1253014 (10Etonkovidova) 3NEW [18:51:10] npm version might be outdated though [18:52:32] 10TemplateData, 6Community-Liaison, 10WMF-Product-Strategy: Please make me a list of commonly used templates in Wikipedia articles - https://phabricator.wikimedia.org/T96323#1253027 (10Elitre) Which, incidentally, is what I need to know for several of those wikis. [18:53:19] RoanKattouw: The jsduck ran fine this time, but I'm getting some errors on test files that rendered fine in a browser before I updated. [18:54:27] 10TemplateData, 6Community-Liaison, 10WMF-Product-Strategy: Please make me a list of commonly used templates in Wikipedia articles - https://phabricator.wikimedia.org/T96323#1253045 (10Ironholds) Yerp :/ [18:54:56] https://www.irccloud.com/pastebin/zMevA8Ap [18:55:10] Ahm, hah [18:55:20] Did whoever moved stuff around forget to update eg-iframe? [18:55:22] * RoanKattouw checks [18:55:51] kirstenMA: IRCCloud :) [18:56:50] 10VisualEditor, 6Collaboration-Team: betalabs: Links to non-existing File page do not display a warning in Link inspector - https://phabricator.wikimedia.org/T97832#1253051 (10Etonkovidova) 3NEW [18:56:54] that's what I use :) [18:59:04] 10VisualEditor, 6Mobile-Web: Extremely high amount of errors for anonymous editors - https://phabricator.wikimedia.org/T97494#1253073 (10Jdlrobson) This is the post that is happening on the client: var api = new mw.Api(); api.postWithToken( { action: 'edit', title: self.title, prependtext,... [19:03:41] James_F, is https://phabricator.wikimedia.org/T76398 supposed to be resolved? [19:06:10] 10VisualEditor, 6Editing Department, 3Google-Summer-of-Code-2015: Community bonding evaluation for Unified language proofing tools integration framework - https://phabricator.wikimedia.org/T97837#1253123 (10Ankita-ks) 3NEW a:3Ankita-ks [19:13:32] 10VisualEditor, 10Parsoid: Disable editing on pages that experience mediawiki API failures while generating HTML - https://phabricator.wikimedia.org/T97649#1253134 (10ssastry) Image info timeouts are handled differently since their impact is restricted to the image itself. They are represented in the DOM (see... [19:21:23] 10VisualEditor, 10VisualEditor-MediaWiki-Links: Leading colon for file links should not be included in URLs and link captions - https://phabricator.wikimedia.org/T96644#1253144 (10Etonkovidova) See also {T97830} [19:23:23] 10VisualEditor: [Regression?] Removing edited articles from watchlist at it.wp - https://phabricator.wikimedia.org/T97838#1253147 (10Elitre) 3NEW [19:27:50] 10VisualEditor, 6operations: [Regression?] Removing edited articles from watchlist at it.wp - https://phabricator.wikimedia.org/T97838#1253167 (10Elitre) Actually, adding @Ori. Maybe this has to do with JavaScript "experiments" at it.wiki? [19:31:34] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 7Design, 3Editing Department 2014/15 Q4 blockers: External link interface for link dialogue - https://phabricator.wikimedia.org/T76398#1253192 (10Esanders) 5Open>3Resolved a:3Esanders [19:31:36] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-Links, 7Tracking: VisualEditor: Improvements and behaviour changes to the link input widget (tracking) - https://phabricator.wikimedia.org/T50789#1253194 (10Esanders) [19:33:38] 10OOjs-UI, 10Gather, 10Gather Sprint Greatest Hits, 6Mobile-Web, and 2 others: Tiny search icon in alpha and Gather beta - https://phabricator.wikimedia.org/T97654#1253200 (10Esanders) 5Open>3Resolved a:3Esanders [20:01:11] 10OOjs-UI, 10Gather, 10Gather Sprint Greatest Hits, 6Mobile-Web, and 2 others: Tiny search icon in alpha and Gather beta - https://phabricator.wikimedia.org/T97654#1253325 (10matmarex) (This will get properly fixed in MobileFrontend when we release new OOjs UI version, and update MediaWiki core to use it.) [20:25:42] 10VisualEditor: When saving an edit with VisualEditor, the "Watch page" checkbox is disabled even though the page is already on the watchlist - https://phabricator.wikimedia.org/T97851#1253371 (10pajz) 3NEW [20:48:09] 10VisualEditor: When saving an edit with VisualEditor, the "Watch page" checkbox is disabled even though the page is already on the watchlist - https://phabricator.wikimedia.org/T97851#1253429 (10Catrope) [20:48:11] 10VisualEditor, 6operations: [Regression?] Removing edited articles from watchlist at it.wp - https://phabricator.wikimedia.org/T97838#1253430 (10Catrope) [20:48:26] 10VisualEditor, 6operations: [Regression?] Removing edited articles from watchlist at it.wp - https://phabricator.wikimedia.org/T97838#1253147 (10Catrope) >>! In T97838#1253167, @Elitre wrote: > Actually, adding @Ori. Maybe this has to do with JavaScript "experiments" at it.wiki? Well it's apparently also hap... [21:16:15] 10VisualEditor, 6Mobile-Web: Extremely high amount of errors for anonymous editors - https://phabricator.wikimedia.org/T97494#1253525 (10Anomie) >>! In T97494#1253073, @Jdlrobson wrote: > prependtext, Really, no key? > basetimestamp: self.timestamp, > starttimestamp: self.timestamp That doesn'... [21:17:15] RoanKattouw: FYI, anno 2015 its' universal truth that nestedIndexOf beats any other implementation 10x [21:17:15] http://jsperf.com/commonelements [21:17:19] TrevorP|Away: ^ [21:17:20] :D [21:17:32] "Don't worry about performance" - beat us once again [21:20:24] I'm sure you recognise the functions :) [21:21:16] 10VisualEditor, 10MediaWiki-extensions-Graph, 10Parsoid, 6Services, 3Google-Summer-of-Code-2015: Graph editing in VisualEditor - https://phabricator.wikimedia.org/T89287#1253536 (10Yurik) Unfortunately no - those examples use JavaScript, which we cannot expose in Graphs due to privacy and security reason... [21:24:11] In IE sortingPlusPass is the fastest, but either way dictionaries is the slowest one in all. [21:48:37] 10VisualEditor, 6Collaboration-Team, 10Collaboration-Team-Sprint-A-2015-05-06, 10Flow, 5Patch-For-Review: Previewing a link to a File in Flow's VE-mode, opens a broken destination due to /w/ - https://phabricator.wikimedia.org/T96492#1253593 (10Catrope) 5Open>3Resolved [21:49:53] 10OOjs-UI, 10VisualEditor, 10VisualEditor-MediaWiki, 10Vector, 3Editing Department 2014/15 Q4 blockers: Change OOUI MediaWiki theme to be optimized for font-size of 14px (0.875em×16px), instead of 12.8px (0.8em×16px), like MediaWiki Vector skin - https://phabricator.wikimedia.org/T97631#1253595 (10GOIII)... [21:55:32] 10VisualEditor, 6Collaboration-Team, 10Collaboration-Team-Sprint-A-2015-05-06, 10Flow, 5Patch-For-Review: Previewing a link to a File in Flow's VE-mode, opens a broken destination due to /w/ - https://phabricator.wikimedia.org/T96492#1253611 (10Catrope) [21:55:35] 10VisualEditor, 6Collaboration-Team, 10Flow: clicking a link to a Hebrew Wikipedia category while editing a Flow post in VisualEditor shows a broken page - https://phabricator.wikimedia.org/T96272#1253610 (10Catrope) [21:55:53] 10VisualEditor, 6Collaboration-Team, 10Collaboration-Team-Sprint-A-2015-05-06, 10Flow, 5WMF-deploy-2015-05-06_(1.26wmf5): Previewing a link to a File in Flow's VE-mode, opens a broken destination due to /w/ - https://phabricator.wikimedia.org/T96492#1218278 (10Catrope) [22:18:30] (03PS1) 10Esanders: Divide surface margins by 0.8 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/208288 [22:19:05] (03CR) 10Jforrester: [C: 031] Divide surface margins by 0.8 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/208288 (owner: 10Esanders) [22:21:36] (03CR) 10jenkins-bot: [V: 04-1] Divide surface margins by 0.8 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/208288 (owner: 10Esanders) [22:22:21] (03CR) 10Jforrester: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/208288 (owner: 10Esanders) [22:27:11] James_F: Is there hope for https://www.mediawiki.org/wiki/Thread:Extension_talk:TemplateData/Place_strings_in_rows ? [22:27:14] e.g. reflect inline/block-ness in wikitext [22:27:22] at least in terms of style [22:27:49] Krinkle: Yes, we've talked about it before – do you think it'd be worth being a top-level boolean? [22:28:50] We can't associate it with the html output though, they're intersecting subjects but not semantically meant to be the same [22:29:00] e.g. whether the thing itself is inline or a block [22:29:04] (or inline-block) [22:29:26] That's something we can detect client-side and should address in VE (or possibly Parsoid) [22:29:39] But for the source yeah. [22:29:43] Parsoid talked about wanting this attribute in TD so they could serialise "correctly". [22:29:45] This user brings up a good point about diff review. [22:29:48] Which I'd be OK with. [22:30:06] What do they default to for existing? [22:30:12] Do they try to guess based on context? [22:30:30] (03CR) 10Bartosz Dziewoński: [C: 032] Divide surface margins by 0.8 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/208288 (owner: 10Esanders) [22:31:01] Krinkle: Yeah. :-( [22:31:27] Krinkle: ISTR something like "if its output is a block-level, put on lines". [22:32:44] (03CR) 10jenkins-bot: [V: 04-1] Divide surface margins by 0.8 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/208288 (owner: 10Esanders) [22:33:21] James_F: hm.. from testing, I'm not seeing that. [22:33:33] Krinkle: Did you break CI? [22:33:36] 10WikiEditor, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review: editSessionID is duplicated in Edit:Schema for Wikitext - https://phabricator.wikimedia.org/T95919#1253701 (10Halfak) Again, I have tried to test this fix and I'm struggling to get a single WikiText event logged. I have saved 27 edi... [22:33:39] I assume creating a new page with an infobox will produce a long string [22:34:00] No? [22:34:08] Krinkle: Maybe? [22:34:18] That ve-me failure? [22:34:19] esprima [22:34:24] update jscs :) [22:34:57] ... in mediawiki-c0re [22:35:09] Krinkle: Oh, bah, forgot that one. [22:35:10] * James_F fixes. [22:35:15] Thx, I forgot that one too [22:35:20] for a second there I thought it was a regression [22:37:00] 10VisualEditor, 10VisualEditor-MediaWiki, 3Editing Department 2014/15 Q4 blockers: Editnotices with hidden content shows as "1 notice" - https://phabricator.wikimedia.org/T95822#1253702 (10matmarex) [22:42:11] Krinkle: https://gerrit.wikimedia.org/r/208294 [22:58:19] (03CR) 10Krinkle: [C: 032] Divide surface margins by 0.8 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/208288 (owner: 10Esanders) [23:02:58] (03Merged) 10jenkins-bot: Divide surface margins by 0.8 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/208288 (owner: 10Esanders) [23:07:47] (03PS1) 10Catrope: Follow-up cc5ca3a2f6: now that we sample client-side, send all editingStatsIds to the client [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/208299 (https://phabricator.wikimedia.org/T95919) [23:09:53] 10WikiEditor, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review: editSessionID is duplicated in Edit:Schema for Wikitext - https://phabricator.wikimedia.org/T95919#1253789 (10Halfak) Working with @Catrope, we found the source of the issue. It seems that a new session ID is not generated for edits a... [23:12:06] (03CR) 10Alex Monk: [C: 032] Follow-up cc5ca3a2f6: now that we sample client-side, send all editingStatsIds to the client [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/208299 (https://phabricator.wikimedia.org/T95919) (owner: 10Catrope) [23:12:58] (03Merged) 10jenkins-bot: Follow-up cc5ca3a2f6: now that we sample client-side, send all editingStatsIds to the client [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/208299 (https://phabricator.wikimedia.org/T95919) (owner: 10Catrope) [23:47:36] (03PS1) 10SuchetaG: Adding the hightlightQuery method as a general utility [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/208309 [23:50:19] (03CR) 10jenkins-bot: [V: 04-1] Adding the hightlightQuery method as a general utility [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/208309 (owner: 10SuchetaG) [23:53:18] (03PS2) 10SuchetaG: Adding the hightlightQuery method as a general utility [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/208309