[00:40:45] 10VisualEditor, 10VisualEditor-MediaWiki: Editnotices for newpage creations are shown with a broken link, when using a non-default (local) language - https://phabricator.wikimedia.org/T97875#1253918 (10Quiddity) 3NEW [00:59:16] 10VisualEditor: [Regression?] Removing edited articles from watchlist at it.wp - https://phabricator.wikimedia.org/T97838#1253949 (10Dzahn) [01:56:32] (03PS1) 10Catrope: Follow-up cc5ca3a2f6: now that we sample client-side, send all editingStatsIds to the client [extensions/WikiEditor] (wmf/1.26wmf4) - 10https://gerrit.wikimedia.org/r/208324 (https://phabricator.wikimedia.org/T95919) [01:56:45] (03PS1) 10Catrope: Follow-up cc5ca3a2f6: now that we sample client-side, send all editingStatsIds to the client [extensions/WikiEditor] (wmf/1.26wmf3) - 10https://gerrit.wikimedia.org/r/208325 (https://phabricator.wikimedia.org/T95919) [02:00:55] (03CR) 10Catrope: [C: 032] Follow-up cc5ca3a2f6: now that we sample client-side, send all editingStatsIds to the client [extensions/WikiEditor] (wmf/1.26wmf3) - 10https://gerrit.wikimedia.org/r/208325 (https://phabricator.wikimedia.org/T95919) (owner: 10Catrope) [02:01:10] (03CR) 10Catrope: [C: 032] Follow-up cc5ca3a2f6: now that we sample client-side, send all editingStatsIds to the client [extensions/WikiEditor] (wmf/1.26wmf4) - 10https://gerrit.wikimedia.org/r/208324 (https://phabricator.wikimedia.org/T95919) (owner: 10Catrope) [02:01:41] (03Merged) 10jenkins-bot: Follow-up cc5ca3a2f6: now that we sample client-side, send all editingStatsIds to the client [extensions/WikiEditor] (wmf/1.26wmf3) - 10https://gerrit.wikimedia.org/r/208325 (https://phabricator.wikimedia.org/T95919) (owner: 10Catrope) [02:02:02] (03Merged) 10jenkins-bot: Follow-up cc5ca3a2f6: now that we sample client-side, send all editingStatsIds to the client [extensions/WikiEditor] (wmf/1.26wmf4) - 10https://gerrit.wikimedia.org/r/208324 (https://phabricator.wikimedia.org/T95919) (owner: 10Catrope) [02:18:40] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 3Editing Department 2014/15 Q4 blockers: Switch link inspector over to using the new IndexLayout in OOjs UI - https://phabricator.wikimedia.org/T97878#1254025 (10Jdforrester-WMF) 3NEW a:3TrevorParscal [02:18:48] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 3Editing Department 2014/15 Q4 blockers: Switch link inspector over to using the new IndexLayout in OOjs UI - https://phabricator.wikimedia.org/T97878#1254033 (10Jdforrester-WMF) [02:18:56] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 3Editing Department 2014/15 Q4 blockers: Switch link inspector over to using the new IndexLayout in OOjs UI - https://phabricator.wikimedia.org/T97878#1254025 (10Jdforrester-WMF) [02:21:28] (03PS1) 10Catrope: Alias ve.debounce to OO.ui.debounce [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/208330 [02:23:14] 10VisualEditor, 10VisualEditor-MediaWiki-References, 7Design, 3Editing Department 2014/15 Q4 blockers: Kill the citation menu and instead off the options as selection palette in an inspector vs. "Re-use" - https://phabricator.wikimedia.org/T97880#1254043 (10Jdforrester-WMF) 3NEW [02:24:13] 10VisualEditor, 10VisualEditor-ContentEditable, 3Editing Department 2014/15 Q4 blockers: Cursoring over an MWLinkNode takes you two characters to the right/left, not one - https://phabricator.wikimedia.org/T96307#1254049 (10dchan) The obvious solution is to put something inside. But we have to avoid Chromium... [02:24:28] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References, 7Design, 3Editing Department 2014/15 Q4 blockers: Make Citoid extend the new general citation inspector to add an "Automatic" section as the first (default) tab - https://phabricator.wikimedia.org/T97881#1254050 (10Jdforrester-WMF) 3NEW [02:24:47] RoanKattouw: No unit tests? [02:24:53] (03CR) 10jenkins-bot: [V: 04-1] Alias ve.debounce to OO.ui.debounce [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/208330 (owner: 10Catrope) [02:25:50] Could use sinon to fake the timer, and then make a few calls that add / don't add data to an array and assert array contains is in expected sequence and skipped thigns it should skip. [02:26:01] Like the mw.hook tests in mediawiki core, an example if you want. [02:26:25] EventEmitter might be a better example for how to test that [02:27:21] It didn't have any in VE :( [02:28:20] sinon is in npm btw :) [02:28:57] * Krinkle notes to remember to figure a way to instrument oojs-ui before concat. [02:29:07] coverage is not nice [02:33:58] 10WikiEditor, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review: editSessionID is duplicated in Edit:Schema for Wikitext - https://phabricator.wikimedia.org/T95919#1254060 (10Catrope) >>! In T95919#1253800, @gerritbot wrote: > Change 208299 merged by jenkins-bot: > Follow-up cc5ca3a2f6: now that we... [02:44:31] (03PS2) 10Catrope: Populate abort.type in Schema:Edit logging [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/205195 (https://phabricator.wikimedia.org/T95938) [02:44:34] (03CR) 10jenkins-bot: [V: 04-1] Populate abort.type in Schema:Edit logging [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/205195 (https://phabricator.wikimedia.org/T95938) (owner: 10Catrope) [02:46:02] (03PS3) 10Catrope: Populate abort.type in Schema:Edit logging [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/205195 (https://phabricator.wikimedia.org/T95938) [02:46:48] 10Citoid, 10VisualEditor: Change label on Citoid tool to say "Look up" / "Generate" / etc. - https://phabricator.wikimedia.org/T97353#1254062 (10Jdforrester-WMF) a:3Nirzar [02:47:02] 10Citoid, 10VisualEditor: Change label on Citoid tool to say "Look up" / "Generate" / etc. - https://phabricator.wikimedia.org/T97353#1240121 (10Jdforrester-WMF) [02:47:06] 10Citoid, 10VisualEditor, 7Design, 3Editing Department 2014/15 Q4 blockers: Adjusted workflow for adding a new citation - https://phabricator.wikimedia.org/T97390#1254065 (10Jdforrester-WMF) [02:47:28] 10Citoid, 10VisualEditor: Change label on Citoid tool to say "Look up" / "Generate" / etc. - https://phabricator.wikimedia.org/T97353#1240121 (10Jdforrester-WMF) Nirzar/Abbey to determine best wording. [02:47:41] 10Citoid, 10VisualEditor, 3Editing Department 2014/15 Q4 blockers: Change label on Citoid tool to say "Look up" / "Generate" / etc. - https://phabricator.wikimedia.org/T97353#1254069 (10Jdforrester-WMF) [02:50:42] Eurgh, https://integration.wikimedia.org/cover/visualeditor/Chromium%2041.0.2272%20(Ubuntu)/src/dm/ve.dm.Scalable.js.html makes me sad. [02:50:58] Six ways to configure them and we consistently only test one. [03:11:37] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 3Editing Department 2014/15 Q4 blockers: Switch link inspector over to using the new IndexLayout in OOjs UI - https://phabricator.wikimedia.org/T97878#1254079 (10Jdforrester-WMF) [03:11:41] 10Citoid, 10VisualEditor, 7Design, 3Editing Department 2014/15 Q4 blockers: Adjusted workflow for adding a new citation - https://phabricator.wikimedia.org/T97390#1254078 (10Jdforrester-WMF) [03:30:38] (03PS1) 10Jforrester: build: Bump grunt-jscs to latest version [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/208336 [03:33:26] [13grunt-banana-checker] 15jdforrester created 06bump-jscs (+1 new commit): 02https://github.com/wikimedia/grunt-banana-checker/commit/208d2f50b5ef [03:33:26] 13grunt-banana-checker/06bump-jscs 14208d2f5 15James D. Forrester: build: Bump grunt-jscs to latest version [03:34:19] [13grunt-banana-checker] 15jdforrester opened pull request #19: build: Bump grunt-jscs to latest version (06master...06bump-jscs) 02https://github.com/wikimedia/grunt-banana-checker/pull/19 [03:34:47] wikimedia/grunt-banana-checker#55 (bump-jscs - 208d2f5 : James D. Forrester): The build passed. [03:34:47] Change view : https://github.com/wikimedia/grunt-banana-checker/commit/208d2f50b5ef [03:34:47] Build details : http://travis-ci.org/wikimedia/grunt-banana-checker/builds/60920362 [04:03:02] [13grunt-banana-checker] 15Krinkle pushed 1 new commit to 06master: 02https://github.com/wikimedia/grunt-banana-checker/commit/12c5d388c5e3471f1cef973d93381ef3a14fb449 [04:03:02] 13grunt-banana-checker/06master 1412c5d38 15Timo Tijhof: Merge pull request #19 from wikimedia/bump-jscs... [04:04:23] wikimedia/grunt-banana-checker#57 (master - 12c5d38 : Timo Tijhof): The build passed. [04:04:23] Change view : https://github.com/wikimedia/grunt-banana-checker/compare/32c8148cc028...12c5d388c5e3 [04:04:23] Build details : http://travis-ci.org/wikimedia/grunt-banana-checker/builds/60921312 [04:23:50] (03CR) 10Legoktm: [C: 04-1] Update extension.json, get rid of PHP entry point (031 comment) [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/201235 (owner: 10Legoktm) [04:25:03] (03PS3) 10Legoktm: Update extension.json, get rid of PHP entry point [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/201235 [04:25:17] (03CR) 10Legoktm: [C: 031] Update extension.json, get rid of PHP entry point [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/201235 (owner: 10Legoktm) [04:29:24] (03CR) 10Legoktm: [C: 032] build: Bump grunt-jscs to latest version [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/208336 (owner: 10Jforrester) [04:29:38] (03CR) 10jenkins-bot: [V: 04-1] build: Bump grunt-jscs to latest version [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/208336 (owner: 10Jforrester) [04:31:19] really? [05:21:44] (03PS1) 10Divec: WIP: Zero-width space to avoid empty annotation cursoring bug [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/208355 (https://phabricator.wikimedia.org/T96307) [07:28:30] 10VisualEditor, 10Graph, 10Mediawiki-extensions-Graph-VE, 10Parsoid, and 2 others: Enable VisualEditor support in Graph extension (GSoC 2015 Proposal) - https://phabricator.wikimedia.org/T93585#1254177 (10ferdbold) [09:12:36] 10VisualEditor, 10VisualEditor-MediaWiki, 10OOjs-UI, 10Vector, 3Editing Department 2014/15 Q4 blockers: Change OOUI MediaWiki theme to be optimized for font-size of 14px (0.875em×16px), instead of 12.8px (0.8em×16px), like MediaWiki Vector skin - https://phabricator.wikimedia.org/T97631#1254230 (10matmare... [11:40:55] (03CR) 10Esanders: [C: 032] "I believe focus is restored by onSurfaceObserverBranchNodeChange, which is why this is no longer necessary." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/207875 (https://phabricator.wikimedia.org/T73119) (owner: 10MarkAHershberger) [11:43:56] (03Merged) 10jenkins-bot: ui.ListAction: Fix screen jumping in Internet Explorer [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/207875 (https://phabricator.wikimedia.org/T73119) (owner: 10MarkAHershberger) [11:45:30] (03CR) 10Esanders: [C: 04-1] "Good plan. Small fixes." (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/208309 (owner: 10SuchetaG) [16:34:34] 10VisualEditor, 6Mobile-Web, 10OOjs-UI, 10UI-Standardization: Inconsistent icon used in mobile/oojs ui for clearing search results. - https://phabricator.wikimedia.org/T97804#1254665 (10Florian) But it's not really a "close", wouldn't it be better to use the OOJsUI clear icon? :) [19:05:27] 10VisualEditor, 10VisualEditor-MediaWiki, 3Editing Department 2014/15 Q4 blockers: Handle load failures more gracefully - https://phabricator.wikimedia.org/T97041#1254766 (10Krenair) What sort of failures are we missing this on? We do show error messages when we have issues fetching data from the server. [19:29:49] (03PS1) 10Esanders: Add missing local var [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/208404 [19:31:47] (03CR) 10jenkins-bot: [V: 04-1] Add missing local var [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/208404 (owner: 10Esanders) [20:06:45] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers: VisualEditor Mobile: Allow formatting editing - https://phabricator.wikimedia.org/T67586#1254793 (10Krenair) What else do we need to do here other than add the formatting menu to MobileViewTarget? [21:24:57] 10VisualEditor, 6Mobile-Web, 10OOjs-UI, 10UI-Standardization: Inconsistent icon used in mobile/oojs ui for clearing search results. - https://phabricator.wikimedia.org/T97804#1254807 (10matmarex) a:3matmarex [21:35:24] 10VisualEditor, 6Mobile-Web, 10OOjs-UI, 10UI-Standardization, 5Patch-For-Review: Inconsistent icon used in mobile/oojs ui for clearing search results. - https://phabricator.wikimedia.org/T97804#1254811 (10matmarex) Indeed. If the above is merged, you shouldn't need any changes in MobileFrontend. [21:38:35] (03PS1) 10Bartosz Dziewoński: Update icon name: clear → cancel after Idbd0da9f in OOjs UI [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/208468 (https://phabricator.wikimedia.org/T97804) [21:57:26] (03Abandoned) 10Bartosz Dziewoński: [POC] Show non-breaking spaces (nbsp) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205619 (https://phabricator.wikimedia.org/T96666) (owner: 10Bartosz Dziewoński) [21:57:43] 10VisualEditor, 10VisualEditor-ContentEditable: Make non-breaking spaces (nbsp) visible in VisualEditor - https://phabricator.wikimedia.org/T96666#1254822 (10matmarex) p:5Triage>3Normal