[00:00:34] James_F: oojs ui release? [00:00:47] (03Merged) 10jenkins-bot: MWTemplateTitleInputWidget: Add missing local var [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/208404 (owner: 10Esanders) [00:02:59] TrevorParscal: Yes. [00:03:05] TrevorParscal: You OK to test and approve? [00:03:22] sure, everything already merged? [00:03:34] * James_F checks. [00:03:51] 10VisualEditor: Unnaturally big link dialogue in multimedia dialogue - https://phabricator.wikimedia.org/T98101#1259464 (10tarlocesilion) 3NEW [00:04:07] TrevorParscal: Ed complained about the rounded corners on the tabs but no patch… [00:04:24] hmm, they aren't round enough? they are too round? [00:04:40] He thinks they should be square, I think. [00:04:56] TrevorParscal: Other than that, nothing urgent for this work (though https://gerrit.wikimedia.org/r/#/c/208694/ would be nice if you're happy to quickly review). [00:06:34] i used the border-radius variable in the theme, so I doubt it's actually wrong [00:06:42] but, I don't really know [00:06:47] because that theme is terrible [00:06:48] * James_F finds the task. [00:07:32] Can't see it. [00:08:25] it's tiny [00:08:28] anyway [00:08:33] yeah, i'm gtg now [00:08:59] maybe https://gerrit.wikimedia.org/r/#/c/208390/ could be added too? [00:09:12] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 7Technical-Debt: Tech debt: Clean up "minerva" folder theme in VE-mw - https://phabricator.wikimedia.org/T96704#1259474 (10Jdforrester-WMF) p:5Triage>3Normal [00:09:22] 10VisualEditor, 10VisualEditor-MediaWiki: Set up mass round-trip testing infrastructure on real content - https://phabricator.wikimedia.org/T52513#1259476 (10Jdforrester-WMF) a:5Krinkle>3None [00:09:54] TrevorParscal: It has a scary dependency tree. [00:10:00] interesting [00:10:01] And it doesn't rebase cleanly to master. [00:10:02] i'll leave it [00:10:05] OK. [00:10:07] Doing the cut now. [00:10:13] cool [00:13:47] Hmm [00:13:56] Could https://phabricator.wikimedia.org/T98101 be related to recent font-size / em changes? [00:14:49] RoanKattouw: Yes. [00:15:21] 10VisualEditor: Unnaturally big link dialogue in multimedia dialogue - https://phabricator.wikimedia.org/T98101#1259495 (10Josve05a) I noticed the same while editing in references on enwp. {F160561} So this seems to be affecting all "secondary" pop-ups, that originate from another pop-up, if that makes sence. On... [00:15:51] 10VisualEditor, 10OOjs-UI: Unnaturally big link dialogue in multimedia dialogue - https://phabricator.wikimedia.org/T98101#1259498 (10Jdforrester-WMF) p:5Triage>3High a:3matmarex [00:41:31] 10WikiEditor: Convert WikiEditor to use extension registration - https://phabricator.wikimedia.org/T87993#1259554 (10Jdforrester-WMF) [00:45:12] (03PS1) 10Jforrester: Update OOjs UI to v0.11.1 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/208863 [00:54:16] (03PS2) 10Jforrester: Alias ve.debounce to OO.ui.debounce [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/208330 (owner: 10Catrope) [01:00:38] (03CR) 10Jforrester: [C: 031] Populate abort.type in Schema:Edit logging [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/205195 (https://phabricator.wikimedia.org/T95938) (owner: 10Catrope) [01:01:06] Krenair: Don't suppose I can convince you to +2 the above? :-) [01:02:06] Assuming the user made changes if they previewed/show changes? :/ [01:02:37] Krenair: It's better than adding a large payload to every edit. [01:02:52] Krenair: And close enough to reality. [01:03:36] I still think the schema for this is simply wrong [01:03:46] But it's the schema we've got. [01:03:57] We can fix it in schema 2.0 in a few months' time. [01:05:16] (03CR) 10Jforrester: [C: 04-1] Alias ve.debounce to OO.ui.debounce (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/208330 (owner: 10Catrope) [01:05:44] 10VisualEditor: Enable meta + enter as a keyboard shortcut to submit dialogs and pages - https://phabricator.wikimedia.org/T98105#1259600 (10Neil_P._Quinn_WMF) 3NEW [01:06:02] 10VisualEditor: Enable meta + enter as a keyboard shortcut to submit dialogs and pages - https://phabricator.wikimedia.org/T98105#1259607 (10Neil_P._Quinn_WMF) [01:06:23] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.11.1 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/208863 (owner: 10Jforrester) [01:06:56] James_F, I'm not sure this logic makes sense [01:07:29] mw.config.get( 'wgAction' ) === 'submit' || origText === $textarea.val() ? 'nochange' : 'abandon' [01:07:45] if we're previewing, or the text is the same, then no change has been made [01:07:52] Oh, hmm, yes. [01:07:57] Oh crap, sorry [01:07:57] But we're supposed to be assuming that previewing means a change was made? [01:07:57] That's wrong, RoanKattouw. [01:08:06] Yeah, it's meant to be !== [01:08:09] (03PS3) 10Catrope: Alias ve.debounce to OO.ui.debounce [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/208330 [01:08:29] Yup, fixing [01:08:38] (03CR) 10Jforrester: [C: 032] Alias ve.debounce to OO.ui.debounce [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/208330 (owner: 10Catrope) [01:09:09] (03PS4) 10Catrope: Populate abort.type in Schema:Edit logging [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/205195 (https://phabricator.wikimedia.org/T95938) [01:09:33] Krenair: Good catch! [01:10:29] RoanKattouw, James_F: So now... [01:10:50] if we're not previewing, or no change has been made, no change has been made [01:11:06] (03CR) 10jenkins-bot: [V: 04-1] Populate abort.type in Schema:Edit logging [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/205195 (https://phabricator.wikimedia.org/T95938) (owner: 10Catrope) [01:12:18] Shouldn't that be an and? [01:14:17] Ugh [01:14:19] Right [01:14:21] Sorry [01:14:28] I'm not having a good day am I [01:15:23] (03PS5) 10Catrope: Populate abort.type in Schema:Edit logging [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/205195 (https://phabricator.wikimedia.org/T95938) [01:16:16] (03CR) 10Alex Monk: [C: 032] Populate abort.type in Schema:Edit logging [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/205195 (https://phabricator.wikimedia.org/T95938) (owner: 10Catrope) [01:16:24] (03CR) 10jenkins-bot: [V: 04-1] Populate abort.type in Schema:Edit logging [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/205195 (https://phabricator.wikimedia.org/T95938) (owner: 10Catrope) [01:17:31] 01:16:24 Error: your composer.lock file is not up to date, run "composer update" to install newer dependencies [01:17:49] 01:15:32 oojs/oojs-ui: 0.11.1 installed, 0.11.0 required. [01:17:50] Krenair: Yeah, we're waiting for OOjs UI upgrades were quicker? :-( [01:19:02] (03Merged) 10jenkins-bot: Update OOjs UI to v0.11.1 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/208863 (owner: 10Jforrester) [01:19:04] (03Merged) 10jenkins-bot: Alias ve.debounce to OO.ui.debounce [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/208330 (owner: 10Catrope) [01:19:14] (03Merged) 10jenkins-bot: Populate abort.type in Schema:Edit logging [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/205195 (https://phabricator.wikimedia.org/T95938) (owner: 10Catrope) [01:19:21] Finally. [01:19:29] (03PS1) 10Jforrester: Populate abort.type in Schema:Edit logging [extensions/WikiEditor] (wmf/1.26wmf4) - 10https://gerrit.wikimedia.org/r/208870 (https://phabricator.wikimedia.org/T95938) [01:19:37] (03PS1) 10Jforrester: Populate abort.type in Schema:Edit logging [extensions/WikiEditor] (wmf/1.26wmf3) - 10https://gerrit.wikimedia.org/r/208871 (https://phabricator.wikimedia.org/T95938) [01:20:50] (03CR) 10jenkins-bot: [V: 04-1] Populate abort.type in Schema:Edit logging [extensions/WikiEditor] (wmf/1.26wmf4) - 10https://gerrit.wikimedia.org/r/208870 (https://phabricator.wikimedia.org/T95938) (owner: 10Jforrester) [01:25:23] (03CR) 10Alex Monk: [C: 032] Fix page restoration when Parsoid load fails [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/208507 (owner: 10Esanders) [01:26:59] (03Merged) 10jenkins-bot: Fix page restoration when Parsoid load fails [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/208507 (owner: 10Esanders) [01:43:10] (03PS2) 10Jforrester: demo: Fix hiding of edit toolbar in read mode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/208611 (owner: 10Esanders) [01:43:18] (03CR) 10Jforrester: [C: 032] demo: Fix hiding of edit toolbar in read mode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/208611 (owner: 10Esanders) [01:43:30] (03CR) 10Jforrester: [C: 032] Update icon name: clear → cancel after Idbd0da9f in OOjs UI [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/208468 (https://phabricator.wikimedia.org/T97804) (owner: 10Bartosz Dziewoński) [01:44:57] (03CR) 10Jforrester: [C: 032] Remove absolute URL regex from base link target widget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/208569 (owner: 10Esanders) [01:47:52] (03Merged) 10jenkins-bot: demo: Fix hiding of edit toolbar in read mode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/208611 (owner: 10Esanders) [01:47:54] (03Merged) 10jenkins-bot: Update icon name: clear → cancel after Idbd0da9f in OOjs UI [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/208468 (https://phabricator.wikimedia.org/T97804) (owner: 10Bartosz Dziewoński) [01:48:31] (03CR) 10Jforrester: "recheck" [extensions/WikiEditor] (wmf/1.26wmf4) - 10https://gerrit.wikimedia.org/r/208870 (https://phabricator.wikimedia.org/T95938) (owner: 10Jforrester) [01:49:25] 10Citoid, 10VisualEditor, 10VisualEditor-ContentEditable, 5Patch-For-Review: Put Citoid in the regular Cite menu anyway - https://phabricator.wikimedia.org/T96118#1259667 (10Jdforrester-WMF) 5Open>3declined a:3Jdforrester-WMF We've decided instead to not do this, but do a wider re-design. [01:49:30] (03Abandoned) 10Jforrester: Put the Citoid tool in the menu as well as the toolbar [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/206484 (https://phabricator.wikimedia.org/T96118) (owner: 10Jforrester) [01:49:37] (03Abandoned) 10Jforrester: Don't show the individual citation templates in the cite menu [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/206485 (owner: 10Jforrester) [01:50:27] (03Merged) 10jenkins-bot: Remove absolute URL regex from base link target widget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/208569 (owner: 10Esanders) [01:54:58] (03PS1) 10Jforrester: Update VE core submodule to master (9be0272) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/208879 [02:01:45] (03Merged) 10jenkins-bot: Update VE core submodule to master (9be0272) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/208879 (owner: 10Jforrester) [04:06:40] (03PS1) 10Legoktm: jenkins job validation, do not submit [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/208897 [04:10:30] (03Abandoned) 10Legoktm: jenkins job validation, do not submit [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/208897 (owner: 10Legoktm) [09:23:36] 10Citoid, 10Security-Reviews, 6Security-Team: Security review of Citoid - https://phabricator.wikimedia.org/T98096#1259928 (10Mvolz) FYI, the codebase is going to change substantially following T75993 (and to some extent T95295) so it will need to be redone following that, I suspect. [09:35:56] 10VisualEditor, 10OOjs-UI: Unnaturally big link dialogue in multimedia dialogue - https://phabricator.wikimedia.org/T98101#1259960 (10matmarex) [09:35:58] 10VisualEditor, 5Patch-For-Review: [Regression pre-wmf3] Inspectors inside Media Settings>caption and Basic reference dialog are appearing too big - https://phabricator.wikimedia.org/T96628#1259961 (10matmarex) [09:40:44] 10VisualEditor, 10OOjs-UI: Unnaturally big link dialogue in multimedia dialogue - https://phabricator.wikimedia.org/T98101#1259963 (10matmarex) This is already fixed, try it on beta: http://en.wikipedia.beta.wmflabs.org/. The fix will be deployed with MediaWiki 1.26wmf5 – on Wednesday, 13 May 2015 to Wikipedia... [09:47:48] (03PS1) 10Esanders: Fix multi-selection comment [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/208923 [09:52:38] 10VisualEditor: Create a generic target/title input widget in MW core - https://phabricator.wikimedia.org/T98122#1259992 (10Esanders) 3NEW [09:54:38] 10VisualEditor: Create a generic target/title input widget in MW core - https://phabricator.wikimedia.org/T98122#1260006 (10Esanders) [10:07:29] 10VisualEditor: Irregular highlighted borders appear around the text-box inside link inspector - https://phabricator.wikimedia.org/T98080#1260022 (10Esanders) 5Open>3Resolved https://gerrit.wikimedia.org/r/#/c/208694/ [10:08:27] (03PS5) 10Esanders: Highlight matching parts of link suggestions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/208624 (https://phabricator.wikimedia.org/T93697) (owner: 10SuchetaG) [10:08:37] (03CR) 10Esanders: [C: 032] Highlight matching parts of link suggestions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/208624 (https://phabricator.wikimedia.org/T93697) (owner: 10SuchetaG) [10:12:29] (03Merged) 10jenkins-bot: Highlight matching parts of link suggestions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/208624 (https://phabricator.wikimedia.org/T93697) (owner: 10SuchetaG) [10:23:48] 10Citoid, 10Security-Reviews, 6Security-Team: Security review of Citoid - https://phabricator.wikimedia.org/T98096#1260057 (10mobrovac) >>! In T98096#1259928, @Mvolz wrote: > FYI, the codebase is going to change substantially following T75993 (and to some extent T95295) so it will need to be redone following... [10:26:57] (03CR) 10Divec: [C: 032] Fix multi-selection comment [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/208923 (owner: 10Esanders) [10:29:50] (03Merged) 10jenkins-bot: Fix multi-selection comment [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/208923 (owner: 10Esanders) [11:09:32] edsanders: https://github.com/wikimedia/html-metadata/blob/promisify/test/static.js [11:32:20] 10VisualEditor, 6Multimedia: VisualEditor doesn't handle paragraph breaks in image captions editor correctly - https://phabricator.wikimedia.org/T98132#1260191 (10Amire80) 3NEW [11:46:05] 10VisualEditor: Visual Editor should let people link to another wiki easily - https://phabricator.wikimedia.org/T98135#1260223 (10Gryllida) 3NEW [12:58:00] 10VisualEditor, 10VisualEditor-ContentEditable, 3Editing Department 2014/15 Q4 blockers: VisualEditor: We need a representation of red-linked images - https://phabricator.wikimedia.org/T52788#1260328 (10Esanders) a:3sucheta [13:02:47] (03PS1) 10Mvolz: Change label text from 'Lookup' to 'Generate' [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/208951 (https://phabricator.wikimedia.org/T97353) [13:03:06] (03PS2) 10Mvolz: Change label text from 'Lookup' to 'Generate' [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/208951 (https://phabricator.wikimedia.org/T97353) [13:07:28] (03PS2) 10Esanders: [BREAKING CHANGE] Link widget refactor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/208570 [13:08:00] 10Citoid, 10VisualEditor, 7Design, 3Editing Department 2014/15 Q4 blockers: Change the label that says "Or use the full citation dialog to fill in the details yourself" - https://phabricator.wikimedia.org/T96119#1260352 (10Mvolz) 5Open>3declined [13:08:14] 10Citoid, 10VisualEditor, 7Design, 3Editing Department 2014/15 Q4 blockers: Change the label that says "Or use the full citation dialog to fill in the details yourself" - https://phabricator.wikimedia.org/T96119#1208772 (10Mvolz) Declined in favour of new design: T97390 [13:09:50] 10Citoid: Front-end side url/doi validation - https://phabricator.wikimedia.org/T98140#1260365 (10Mvolz) 3NEW [13:10:15] (03PS2) 10Esanders: Use new TabSelectWidget in link inspector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/208619 [13:10:17] (03PS3) 10Esanders: Link inspector refactor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/208571 [13:11:19] (03CR) 10Esanders: "Dependency mentioned in commit message has been met." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/208619 (owner: 10Esanders) [13:12:12] (03CR) 10jenkins-bot: [V: 04-1] Use new TabSelectWidget in link inspector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/208619 (owner: 10Esanders) [13:12:55] (03CR) 10jenkins-bot: [V: 04-1] Link inspector refactor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/208571 (owner: 10Esanders) [13:29:07] (03PS1) 10Amire80: Replace "articles" with "pages" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/208952 [14:16:36] 10Citoid, 10VisualEditor, 10VisualEditor-ContentEditable, 5Patch-For-Review: Put Citoid in the regular Cite menu anyway - https://phabricator.wikimedia.org/T96118#1260560 (10Elitre) Deadline for this? Task #? (The irony of Ed commenting in the other task several weeks ago that <<[...] Instead of fixing the... [14:30:16] 10Citoid, 10VisualEditor, 10VisualEditor-ContentEditable, 5Patch-For-Review: Put Citoid in the regular Cite menu anyway - https://phabricator.wikimedia.org/T96118#1260630 (10Mvolz) @Elitre Task is T97390 [14:30:31] 10Citoid, 10VisualEditor, 10VisualEditor-ContentEditable: Put Citoid in the regular Cite menu anyway - https://phabricator.wikimedia.org/T96118#1260632 (10Mvolz) [14:35:11] 10Citoid, 10VisualEditor, 10VisualEditor-ContentEditable: Put Citoid in the regular Cite menu anyway - https://phabricator.wikimedia.org/T96118#1260646 (10Elitre) Thank you! [15:12:41] 10Mediawiki-extensions-Graph-VE, 3Google-Summer-of-Code-2015: Community bonding evaluation for "Enable VisualEditor support in Graph extension" - https://phabricator.wikimedia.org/T97502#1260736 (10ferdbold) [15:13:26] 10Mediawiki-extensions-Graph-VE, 3Google-Summer-of-Code-2015: Community bonding evaluation for "Enable VisualEditor support in Graph extension" - https://phabricator.wikimedia.org/T97502#1244170 (10ferdbold) [15:23:32] (03PS1) 10Esanders: Refactor reference source selection out into a widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/208971 [15:32:19] 10VisualEditor: No direct indication of current formatting - https://phabricator.wikimedia.org/T98160#1260751 (10gpaumier) 3NEW [15:33:14] 10VisualEditor: No direct indication of current styling - https://phabricator.wikimedia.org/T98160#1260760 (10Jdforrester-WMF) p:5Triage>3Normal [15:33:36] 10VisualEditor: No direct indication of current styling - https://phabricator.wikimedia.org/T98160#1260751 (10Jdforrester-WMF) The work to adjust the styling and behaviour of the toolbar may fix this, possibly. [15:36:07] 10VisualEditor, 10OOjs-UI, 7Design, 3Editing Department 2014/15 Q4 blockers: MediaWiki theme: Alter the toolbar and dropdown menu design - https://phabricator.wikimedia.org/T86693#1260776 (10Jdforrester-WMF) [15:36:09] 10VisualEditor: No direct indication of current styling - https://phabricator.wikimedia.org/T98160#1260775 (10Jdforrester-WMF) [15:40:57] 10VisualEditor, 6Community-Liaison, 3Editing Department 2014/15 Q4 blockers: Deliver a "translation table" at some Phase 5 wikis - https://phabricator.wikimedia.org/T98149#1260789 (10Jdforrester-WMF) [15:49:49] edsanders: Was https://gerrit.wikimedia.org/r/#/c/208624/ meant to change the styling? No .css files touched and nothing seems different… [15:52:45] 10VisualEditor: No direct indication of current styling - https://phabricator.wikimedia.org/T98160#1260812 (10gpaumier) [15:52:52] (03CR) 10Jforrester: [C: 032] "Though I still think we should have gone with "Search $wgSitename"." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/208952 (owner: 10Amire80) [15:53:29] 10Citoid, 10VisualEditor, 7Design: Change the label that says "Or use the full citation dialog to fill in the details yourself" - https://phabricator.wikimedia.org/T96119#1260815 (10Jdforrester-WMF) [15:53:51] (03CR) 10Jforrester: [C: 032] Change label text from 'Lookup' to 'Generate' [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/208951 (https://phabricator.wikimedia.org/T97353) (owner: 10Mvolz) [15:54:13] 10Citoid, 10VisualEditor, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-05-06_(1.26wmf5): Change label on Citoid tool to say "Generate" - https://phabricator.wikimedia.org/T97353#1260816 (10Jdforrester-WMF) p:5Triage>3Normal [15:54:24] (03Merged) 10jenkins-bot: Replace "articles" with "pages" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/208952 (owner: 10Amire80) [15:54:26] (03Merged) 10jenkins-bot: Change label text from 'Lookup' to 'Generate' [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/208951 (https://phabricator.wikimedia.org/T97353) (owner: 10Mvolz) [15:54:32] 10Citoid, 10VisualEditor, 7Design, 3Editing Department 2014/15 Q4 blockers: Consolidate citation workflow into an inspector - https://phabricator.wikimedia.org/T97390#1260822 (10Jdforrester-WMF) [15:54:34] 10Citoid, 10VisualEditor, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-05-06_(1.26wmf5): Change label on Citoid tool to say "Generate" - https://phabricator.wikimedia.org/T97353#1260821 (10Jdforrester-WMF) 5Open>3Resolved [15:55:19] 10Citoid, 10VisualEditor, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-05-06_(1.26wmf5): Change label on Citoid tool to say "Generate" - https://phabricator.wikimedia.org/T97353#1260831 (10Jdforrester-WMF) a:5Nirzar>3Mvolz [15:55:31] 10VisualEditor, 6Mobile-Web, 10OOjs-UI, 10UI-Standardization, and 2 others: Inconsistent icon used in mobile/oojs ui for clearing search results. - https://phabricator.wikimedia.org/T97804#1260832 (10Jdforrester-WMF) [15:55:55] 10WikiEditor, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review: editSessionID is duplicated in Edit:Schema for Wikitext - https://phabricator.wikimedia.org/T95919#1260836 (10Jdforrester-WMF) [16:01:23] James_F: Hello. I'm curious, what's a "KIT"? [16:02:14] guillom: Keeping In Touch meeting. [16:02:22] Oh, I see. [16:02:22] guillom: Other teams call them "stand up"s. [16:02:45] James_F: Thanks. And is it actually in R32? (just checking) [16:03:00] guillom: Today yes. [16:03:12] Ok; I shall attend, then :) [16:03:29] Thanks. [16:20:54] neilpquinn: https://translatewiki.net/w/i.php?title=Special:MessageGroupStats&language=gl&group=ext-visualeditor-0-all#sortable:3=asc [16:35:16] (03PS4) 10Jforrester: [PULL THROUGH] Link inspector refactor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/208571 (owner: 10Esanders) [16:37:19] (03CR) 10jenkins-bot: [V: 04-1] [PULL THROUGH] Link inspector refactor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/208571 (owner: 10Esanders) [16:48:24] (03CR) 10Jforrester: [C: 031] Be more selective in application of 0.8em font size [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/208509 (owner: 10Esanders) [16:50:18] (03PS8) 10Florianschmidtwelzow: Allow skin developers to set an offset for toolbar floating [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/203011 (https://phabricator.wikimedia.org/T95528) [16:52:36] (03CR) 10Jforrester: [C: 04-1] "Needs to alter extension.json too (and by the end of today, only)." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/203011 (https://phabricator.wikimedia.org/T95528) (owner: 10Florianschmidtwelzow) [16:53:50] (03CR) 10Bartosz Dziewoński: "In Vector only?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/208509 (owner: 10Esanders) [16:54:54] (03CR) 10Bartosz Dziewoński: "By the way, the plan is to get rid of these overrides entirely (for Vector, at least), see T97631. I just haven't had time to work on it r" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/208509 (owner: 10Esanders) [16:57:43] (03PS55) 10Paladox: Re add svg images [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (https://phabricator.wikimedia.org/T37342) [16:58:20] (03PS23) 10Paladox: Add svg to LESS file [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/195529 (https://phabricator.wikimedia.org/T37342) [17:09:00] James_F, standup? [17:44:32] (03CR) 10Jforrester: [C: 032] Convert 'external' links to internal pages pasted into the search field [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201627 (https://phabricator.wikimedia.org/T94334) (owner: 10Alex Monk) [17:47:42] (03CR) 10Jforrester: [C: 032] "Tech debt to fix the rest." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/208509 (owner: 10Esanders) [17:47:44] (03Merged) 10jenkins-bot: Convert 'external' links to internal pages pasted into the search field [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201627 (https://phabricator.wikimedia.org/T94334) (owner: 10Alex Monk) [17:50:19] (03Merged) 10jenkins-bot: Be more selective in application of 0.8em font size [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/208509 (owner: 10Esanders) [17:50:38] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-05-06_(1.26wmf5): Link inspector should understand full internal page URLs as internal links - https://phabricator.wikimedia.org/T94334#1261208 (10Jdforrester-WMF) 5Open>3Resolved [18:04:51] (03PS19) 10Esanders: [NEVER MERGE] Local hack for testing link inspector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/206390 [18:05:20] 10VisualEditor: [Regression pre-wmf5] Clicking on Cite does not open the Autofill citation dialog rather adds the citation note immediately on the page - https://phabricator.wikimedia.org/T98178#1261503 (10Ryasmeen) 3NEW [18:08:28] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 7Design, 3Editing Department 2014/15 Q4 blockers, and 2 others: Underline matching parts of link suggestions - https://phabricator.wikimedia.org/T93697#1261554 (10Jdforrester-WMF) [18:19:52] (03PS1) 10Esanders: Remove bold from result titles so that query highlighting works [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/209022 [18:20:02] James_F: Do you remember what ticket is about stuff like [[foo|'' I have https://phabricator.wikimedia.org/T95730 but it's not exactly the same, because it's not formatted. [18:59:22] 10VisualEditor: [Regression pre-wmf] The context menu for references list is appearing beyond the editable area of the page , misplaced toolbar on top - https://phabricator.wikimedia.org/T98191#1262002 (10Ryasmeen) 3NEW [18:59:25] (03PS4) 10Paladox: WIP: DO NOT SUBMIT (Extension registration) [extensions/Math] - 10https://gerrit.wikimedia.org/r/187654 (https://phabricator.wikimedia.org/T87941) (owner: 10Physikerwelt) [19:00:23] (03CR) 10Paladox: "recheck" [extensions/Math] - 10https://gerrit.wikimedia.org/r/187654 (https://phabricator.wikimedia.org/T87941) (owner: 10Physikerwelt) [19:12:22] 10VisualEditor: [Regression pre-wmf5] The context menu for references list is appearing beyond the editable area of the page , misplaced toolbar on top - https://phabricator.wikimedia.org/T98191#1262047 (10Ryasmeen) p:5Normal>3High a:3Esanders [19:15:17] 10VisualEditor: [Regression pre-wmf5] The font for headings/texts etc are appearing bigger after opening VE and switching to read mode - https://phabricator.wikimedia.org/T98193#1262057 (10Ryasmeen) 3NEW [19:24:16] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 3Editing Department 2014/15 Q4 blockers: Frozen link inspector and "Uncaught Error..." when a link is repeatedly inserted after clicking in the same place in a blank paragraph in insert mode - https://phabricator.wikimedia.org/T91318#1262097 (10Jdforrester-WMF)... [19:24:24] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 3Editing Department 2014/15 Q4 blockers: Frozen link inspector and "Uncaught Error..." when a link is repeatedly inserted after clicking in the same place in a blank paragraph in insert mode - https://phabricator.wikimedia.org/T91318#1079977 (10Jdforrester-WMF)... [19:27:30] (03CR) 10Jforrester: "I think underlining looks better…" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/209022 (owner: 10Esanders) [19:28:27] 10VisualEditor: [Regression pre-wmf5] The font for headings/texts etc are appearing bigger after opening VE and switching to read mode - https://phabricator.wikimedia.org/T98193#1262119 (10Krinkle) Confirmed. First problem: After switching back to Read mode, the `div.ve-init-target` element remains in the DOM.... [19:29:49] 10VisualEditor, 10Analytics-EventLogging, 10Beta-Cluster: Beta cluster is sending VisualEditor events to production bits.wikimedia.org/statsv - https://phabricator.wikimedia.org/T98196#1262125 (10Krinkle) 3NEW [19:41:45] (03PS1) 10Jforrester: jshint: Kill file-level globals and add "moment" to the list [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/209044 [19:43:55] 10VisualEditor, 10Parsoid, 3Editing Department 2014/15 Q4 blockers: Link with as only label - https://phabricator.wikimedia.org/T95730#1262173 (10Jdforrester-WMF) [19:44:10] 10VisualEditor, 10Parsoid, 3Editing Department 2014/15 Q4 blockers: Link with as only label - https://phabricator.wikimedia.org/T95730#1198872 (10Jdforrester-WMF) I thought these were now impossible for Parsoid to save? [19:45:55] (03CR) 10jenkins-bot: [V: 04-1] jshint: Kill file-level globals and add "moment" to the list [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/209044 (owner: 10Jforrester) [19:46:13] 10VisualEditor, 10Parsoid, 3Editing Department 2014/15 Q4 blockers: Empty nowiki tags added by VisualEditor - https://phabricator.wikimedia.org/T97430#1262182 (10Jdforrester-WMF) [19:47:39] 10VisualEditor: [Regression pre-wmf5] The font for headings/texts etc are appearing bigger after opening VE and switching to read mode - https://phabricator.wikimedia.org/T98193#1262204 (10Krinkle) p:5Normal>3High I can reproduce this locally and also noticed that it's not limited to the use case of switchin... [19:48:55] MatmaRex: I suspect ^ may be related to the oojs-ui body font-size changes stuff recently. Can you take a look? [19:51:09] Krinkle: yes. ed has a patch pending for it [19:51:13] or possibly actually merged already [19:51:20] by james [19:51:22] 10VisualEditor, 10Analytics-EventLogging, 10Beta-Cluster: Beta cluster is sending VisualEditor events to production bits.wikimedia.org/statsv - https://phabricator.wikimedia.org/T98196#1262230 (10greg) @ori: just pinging you because of the bits change you pushed yesterday re beta cluster, related? [19:53:11] 10VisualEditor, 3Editing Department 2014/15 Q4 blockers: Perform a weekly review of edits made with VisualEditor - https://phabricator.wikimedia.org/T94767#1262236 (10gpaumier) 2015-05-05: * [[ https://en.wikipedia.org/w/index.php?oldid=660976810#Tue_May_05_2015_10:26:51_GMT-0700_.28PDT.29.2C_Guillaume_.28WMF.... [20:07:55] 10VisualEditor: [Regression pre-wmf5] Link inspector opens with a red highlight around the empty text field except the first time of every edit session - https://phabricator.wikimedia.org/T98202#1262287 (10Ryasmeen) 3NEW [20:08:22] 10VisualEditor, 10Parsoid, 3Editing Department 2014/15 Q4 blockers: Link with as only label - https://phabricator.wikimedia.org/T95730#1262295 (10ssastry) >>! In T95730#1262173, @Jdforrester-WMF wrote: > I thought these were now impossible for Parsoid to save? No, Parsoid doesn't treat links with... [20:24:28] 10VisualEditor: [Regression pre-wmf5] Link inspector opens with a red highlight around the empty text field except for the first time of every edit session - https://phabricator.wikimedia.org/T98202#1262377 (10Ryasmeen) a:3Esanders [20:38:57] 10VisualEditor: [Usability Suggestion] In link inspector, after switching back from External link to Search pages while a text is selected, retaining the original text in the text field will be helpful - https://phabricator.wikimedia.org/T98210#1262398 (10Ryasmeen) 3NEW a:3Esanders [20:49:47] 10VisualEditor: The URL in the context menu of an external link is clickable after adding label to it but not otherwise - https://phabricator.wikimedia.org/T98211#1262421 (10Ryasmeen) 3NEW a:3Esanders [20:56:20] 10VisualEditor: A mouse icon appears upon hovering over the search and external link icon in link inspector but none of them are clickable oject - https://phabricator.wikimedia.org/T98213#1262448 (10Ryasmeen) 3NEW a:3Esanders [20:58:02] neilpquinn: Hey, would you be available for a quick chat this afternoon? I'm trying to map out who's doing what in VE research/analysis and I'd like to get a better sense of what you do. [20:58:07] (03CR) 10Alex Monk: [BREAKING CHANGE] Link widget refactor (033 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/208570 (owner: 10Esanders) [20:58:32] Sure. I don't *do* a heck of a lot yet, but I'm happy to talk about it :) [20:59:17] neilpquinn: When's a good time for you? I'm here until ~3:45. [20:59:45] guillom: I don't have anything scheduled, so anytime you want. [21:00:19] neilpquinn: ok; I'm on 5th, how about I come pick you up and we go sit in the big lounge? [21:02:38] guillom: sure, I'm in the silent workspace. [21:03:10] neilpquinn: heh I guess I'm on the other side of that wall then :p [22:00:51] 10VisualEditor, 10OOjs-UI: PopupWidget placement breaking embedded context item in VE - https://phabricator.wikimedia.org/T98236#1262728 (10Esanders) 3NEW [22:16:44] (03CR) 10Jforrester: [C: 031] Refactor reference source selection out into a widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/208971 (owner: 10Esanders) [22:26:27] 10VisualEditor, 10OOjs-UI: PopupWidget placement breaking embedded context item in VE - https://phabricator.wikimedia.org/T98236#1262840 (10Esanders) p:5Triage>3Unbreak! a:3Mooeypoo [22:30:03] (03PS1) 10Mooeypoo: Use the new popup alignment interface for ltr/rtl correction [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/209137 (https://phabricator.wikimedia.org/T98236) [22:33:46] edsanders, I submitted a fix, but DesktopcContext#updateDimensions shouldn't really change the popup alignment directly like that.. maybe we should add 'setAlignment' in the OO.ui.PopupWidget that can properly deal with it? [22:34:09] mooeypoo, yeah - as I said in editing, this is what happens when you don't use setters [22:34:37] Indeed [22:34:46] 10VisualEditor, 10OOjs-UI, 5Patch-For-Review: PopupWidget placement breaking embedded context item in VE - https://phabricator.wikimedia.org/T98236#1262876 (10Esanders) Still todo: Provide a setAlignment method to PopupWidget so this can't happen again. [22:37:00] mooeypoo, interestingly your fix doesn't work in rtl [22:37:41] mooeypoo, no, I take that back [22:37:48] I had some local hacks on ooui.js [22:38:29] (03CR) 10Esanders: [C: 032] Use the new popup alignment interface for ltr/rtl correction [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/209137 (https://phabricator.wikimedia.org/T98236) (owner: 10Mooeypoo) [22:38:43] thanks [22:41:00] (03Merged) 10jenkins-bot: Use the new popup alignment interface for ltr/rtl correction [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/209137 (https://phabricator.wikimedia.org/T98236) (owner: 10Mooeypoo) [22:46:58] (03PS1) 10Jforrester: Update VE core submodule to master (2127edd) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/209141 [22:47:06] edsanders: ^^^ Pull through for you. [22:50:14] (03CR) 10Esanders: [C: 032] Update VE core submodule to master (2127edd) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/209141 (owner: 10Jforrester) [22:51:51] (03Merged) 10jenkins-bot: Update VE core submodule to master (2127edd) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/209141 (owner: 10Jforrester) [22:52:59] Ta. [22:53:19] 10VisualEditor, 10OOjs-UI, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review, 5WMF-deploy-2015-05-06_(1.26wmf5): PopupWidget placement breaking embedded context item in VE - https://phabricator.wikimedia.org/T98236#1262950 (10Jdforrester-WMF) 5Open>3Resolved [22:53:30] 10VisualEditor, 10OOjs-UI, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review, 5WMF-deploy-2015-05-06_(1.26wmf5): PopupWidget placement breaking embedded context item in VE - https://phabricator.wikimedia.org/T98236#1262728 (10Jdforrester-WMF) [22:55:48] (03CR) 10Jforrester: [C: 032] Populate abort.type in Schema:Edit logging [extensions/WikiEditor] (wmf/1.26wmf4) - 10https://gerrit.wikimedia.org/r/208870 (https://phabricator.wikimedia.org/T95938) (owner: 10Jforrester) [22:55:53] (03CR) 10Jforrester: [C: 032] Populate abort.type in Schema:Edit logging [extensions/WikiEditor] (wmf/1.26wmf3) - 10https://gerrit.wikimedia.org/r/208871 (https://phabricator.wikimedia.org/T95938) (owner: 10Jforrester) [22:57:20] (03Merged) 10jenkins-bot: Populate abort.type in Schema:Edit logging [extensions/WikiEditor] (wmf/1.26wmf4) - 10https://gerrit.wikimedia.org/r/208870 (https://phabricator.wikimedia.org/T95938) (owner: 10Jforrester) [22:58:09] (03Merged) 10jenkins-bot: Populate abort.type in Schema:Edit logging [extensions/WikiEditor] (wmf/1.26wmf3) - 10https://gerrit.wikimedia.org/r/208871 (https://phabricator.wikimedia.org/T95938) (owner: 10Jforrester) [23:28:20] 10VisualEditor, 6WMF-Design-Research, 3Editing Department 2014/15 Q4 blockers: VE Readiness / New Editors Experience (VE and WTE) - https://phabricator.wikimedia.org/T96995#1263073 (10Jdforrester-WMF) [23:28:26] 10VisualEditor: [Usability Suggestion] In link inspector, after switching back from External link to Search pages while a text is selected, retaining the original text in the text field will be helpful - https://phabricator.wikimedia.org/T98210#1263074 (10Nirzar) +1 I agree... [23:29:24] 10VisualEditor, 6Mobile-Web, 10OOjs-UI, 10UI-Standardization, and 3 others: Inconsistent icon used in mobile/oojs ui for clearing search results. - https://phabricator.wikimedia.org/T97804#1263079 (10Jdforrester-WMF) [23:47:32] 10VisualEditor: [Regression pre-wmf5] The context menu for references list is appearing beyond the editable area of the page , misplaced toolbar on top - https://phabricator.wikimedia.org/T98191#1263214 (10Ryasmeen) 5Open>3Resolved https://gerrit.wikimedia.org/r/#/c/209140/ [23:48:41] 10VisualEditor: [Regression pre-wmf5] The context menu for references list is appearing beyond the editable area of the page , misplaced toolbar on top - https://phabricator.wikimedia.org/T98191#1263224 (10Jdforrester-WMF) Nope, https://gerrit.wikimedia.org/r/#/c/209137/ instead. :-) [23:48:55] 10VisualEditor, 5WMF-deploy-2015-05-06_(1.26wmf5): [Regression pre-wmf5] The context menu for references list is appearing beyond the editable area of the page , misplaced toolbar on top - https://phabricator.wikimedia.org/T98191#1263227 (10Jdforrester-WMF) a:5Esanders>3Mooeypoo [23:49:33] 10VisualEditor, 6WMF-Design-Research, 3Editing Department 2014/15 Q4 blockers: VE Usability testing for basic editing tasks for VE release - https://phabricator.wikimedia.org/T96994#1263236 (10Jdforrester-WMF) [23:50:45] 10VisualEditor, 6WMF-Design-Research: VE image updating: test two concepts side by side - https://phabricator.wikimedia.org/T96979#1263250 (10Jdforrester-WMF) [23:57:30] 10VisualEditor: [Regression pre-wmf5] The font for headings/texts etc are appearing bigger after opening VE and switching to read mode - https://phabricator.wikimedia.org/T98193#1263280 (10Ryasmeen) a:3matmarex