[00:00:55] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki: [Regression pre-wmf5] The font for headings/texts etc are appearing bigger after opening VE and switching to read mode - https://phabricator.wikimedia.org/T98193#1263286 (10Jdforrester-WMF)
[00:00:59] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki: [Regression pre-wmf5] The font for headings/texts etc are appearing bigger after opening VE and switching to read mode - https://phabricator.wikimedia.org/T98193#1262057 (10Jdforrester-WMF) Oh dear.
[00:01:39] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki: [Regression pre-wmf5] Switching from VE to read mode re-embiggens the text again and makes it impossible to edit twice in one session - https://phabricator.wikimedia.org/T98193#1263291 (10Jdforrester-WMF) p:5High>3Unbreak!
[00:13:09] <wikibugs>	 10WikiEditor, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review: action.abort.type in Schema:Edit not populated for Wikitext - https://phabricator.wikimedia.org/T95938#1263337 (10Jdforrester-WMF) This is now deployed to production as of 2015-05-06 ~00:05 UTC. Please confirm.
[00:23:27] <wikibugs>	 10VisualEditor, 3Editing Department 2014/15 Q4 blockers: [Usability Suggestion] In link inspector, after switching back from External link to Search pages while a text is selected, retaining the original text in the text field will be helpful - https://phabricator.wikimedia.org/T98210#1263371 (10Nirzar)
[00:27:33] <wikibugs>	 10VisualEditor, 3Editing Department 2014/15 Q4 blockers: [Usability] Consistency between inspector and context menu - https://phabricator.wikimedia.org/T98271#1263401 (10Nirzar) 3NEW
[00:29:28] <wikibugs>	 10VisualEditor, 3Editing Department 2014/15 Q4 blockers: Move the delete action outside of edit for link inspector and language inspector - https://phabricator.wikimedia.org/T98272#1263415 (10Nirzar) 3NEW
[00:35:55] <wikibugs>	 10VisualEditor, 3Editing Department 2014/15 Q4 blockers: Adding link flow after the first dialog  - https://phabricator.wikimedia.org/T98273#1263429 (10Nirzar) 3NEW
[00:41:27] <ryasmeen>	 James_F: we probably need a pull through for this https://phabricator.wikimedia.org/T98080 ? I dont see it fixed in betalabs.
[00:42:58] <RoanKattouw>	 ryasmeen: Worse, it needs an OOUI release
[00:43:12] <RoanKattouw>	 Those usually only happen once a week
[00:45:19] <ryasmeen>	 oh no! :(
[00:45:20] <James_F>	 RoanKattouw: It was released.
[00:45:54] <RoanKattouw>	 Hah you're righ
[00:45:59] <RoanKattouw>	 The release I did yesterday
[00:46:11] <James_F>	 Yes.
[00:46:18] <RoanKattouw>	 (helped with)
[00:46:28] <ryasmeen>	 so it should be working in Betalabs? 
[00:47:01] <James_F>	 Theoretically.
[00:47:12] <wikibugs>	 10VisualEditor, 6WMF-Design-Research: VE image updating: test two concepts side by side - https://phabricator.wikimedia.org/T96979#1263482 (10aripstra) a:5KHammerstein>3None
[00:47:14] <ryasmeen>	 ok but its not practically :(
[00:47:23] <ryasmeen>	 re-opening it then
[00:47:33] <James_F>	 Which template?
[00:47:57] <James_F>	 Hmm.
[00:48:02] <James_F>	 I think Ed mis-triaged that bug.
[00:48:16] <James_F>	 The thing he linked to was for making it not red on initial focus.
[00:48:20] <James_F>	 Which is indeed fixed.
[00:48:46] <ryasmeen>	 ah right!
[00:49:18] <James_F>	 Which is https://phabricator.wikimedia.org/T98202
[00:49:23] <wikibugs>	 10VisualEditor: Irregular highlighted borders appear around the text-box inside link inspector - https://phabricator.wikimedia.org/T98080#1263506 (10Ryasmeen) 5Resolved>3Open
[00:49:37] <ryasmeen>	 James_F: yeah
[00:49:42] <wikibugs>	 10VisualEditor: [Regression pre-wmf5] Link inspector opens with a red highlight around the empty text field except for the first time of every edit session - https://phabricator.wikimedia.org/T98202#1263512 (10Jdforrester-WMF) 5Open>3Resolved Fixed in https://gerrit.wikimedia.org/r/#/c/208694/
[00:50:14] <wikibugs>	 10VisualEditor, 10OOjs-UI, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-05-06_(1.26wmf5): [Regression pre-wmf5] Link inspector opens with a red highlight around the empty text field except for the first time of every edit session - https://phabricator.wikimedia.org/T98202#1263517 (10Jdforrester...
[00:50:21] <wikibugs>	 10VisualEditor, 10OOjs-UI, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-05-06_(1.26wmf5): [Regression pre-wmf5] Link inspector opens with a red highlight around the empty text field except for the first time of every edit session - https://phabricator.wikimedia.org/T98202#1262287 (10Jdforrester...
[00:51:02] <ryasmeen>	 James_F: no, that one is also not fixed
[00:51:15] <James_F>	 You sure?
[00:51:17] * James_F re-tests.
[00:51:32] <ryasmeen>	 yeah so the initial focus is not red for the first time when you open link inspector
[00:51:42] <James_F>	 But it is when you switch to external.
[00:51:43] <James_F>	 Bah.
[00:51:59] <ryasmeen>	 but after that it again comes back on each try
[00:53:48] * James_F sighs.
[01:00:06] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 3Editing Department 2014/15 Q4 blockers: [Regression?] Removing edited articles from watchlist at it.wp - https://phabricator.wikimedia.org/T97838#1263606 (10Jdforrester-WMF)
[01:00:46] <wikibugs>	 10VisualEditor: Irregular highlighted borders appear around the text-box inside link inspector - https://phabricator.wikimedia.org/T98080#1263607 (10Ryasmeen) This also happens in Media Settings dialog {F161038}
[01:42:12] <grrrit-wm>	 (03PS2) 10Jforrester: Update extension.json and empty out PHP entry point [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/208057 (https://phabricator.wikimedia.org/T87992) 
[01:42:43] <grrrit-wm>	 (03CR) 10Jforrester: "PS2 is a re-generation." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/208057 (https://phabricator.wikimedia.org/T87992) (owner: 10Jforrester)
[01:44:26] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Update extension.json and empty out PHP entry point [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/208057 (https://phabricator.wikimedia.org/T87992) (owner: 10Jforrester)
[05:30:40] <wikibugs>	 10Mediawiki-extensions-Graph-VE: Community bonding evaluation for "Enable VisualEditor support in Graph extension" - https://phabricator.wikimedia.org/T97502#1263847 (10Qgil)
[09:30:03] <wikibugs>	 10Mediawiki-extensions-Graph-VE, 10VisualEditor, 10Graph, 10Parsoid, and 2 others: Enable VisualEditor support in Graph extension (GSoC 2015 Proposal) - https://phabricator.wikimedia.org/T93585#1264155 (10Yurik) The graph extension has been launched on all production wikis.
[10:31:49] <grrrit-wm>	 (03PS1) 10Esanders: Redesign CiteFromIdInspector [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/209198 (https://phabricator.wikimedia.org/T97390) 
[11:45:16] <mvcp36>	 Hello everyone
[11:45:40] <mvcp36>	 I'm trying to install VisualEditor on my mediawiki server and I seem to have run into a problem
[11:46:40] <mvcp36>	 it's running on an ubuntu server, I installed parsoid without any issues but when I try to run the visualeditor I get an SSL error
[11:47:02] <mvcp36>	 Is there a way to make parsoid ignore the fact that the wiki is using a self signed SSL cert?
[12:04:42] <grrrit-wm>	 (03PS2) 10Esanders: Redesign CiteFromIdInspector [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/209198 (https://phabricator.wikimedia.org/T97390) 
[12:09:28] <grrrit-wm>	 (03CR) 10Esanders: "needs review asap" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/208971 (owner: 10Esanders)
[12:10:10] <grrrit-wm>	 (03CR) 10Esanders: [C: 032] jshint: Kill file-level globals and add "moment" to the list [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/209044 (owner: 10Jforrester)
[12:13:20] <grrrit-wm>	 (03CR) 10Esanders: "Underline has two problems: (1) spaces don't get underlined due to how jquery.highlight works, so you get '<u>Barack</u> <u>Ob</u>ama' and" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/209022 (owner: 10Esanders)
[12:17:05] <grrrit-wm>	 (03CR) 10Alex Monk: [C: 031] "not tested yet" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/208971 (owner: 10Esanders)
[12:22:51] <edsanders>	 Krinkle|detached, do you still have the MW/core, MW/extensions folder structure?
[12:28:37] <Krenair>	 I think I have that on my desktop
[12:28:50] <Krenair>	 which I don't use for MW development anymore so haven't updated
[12:28:59] <Krenair>	 I might've gotten around to fixing it at some point
[12:50:58] <SMC>	 hello guys, i#m looking for a solution that the visualeditor inserts pdf files with the tags <pdf>filename</pdf> instead of the usual [[ ]]. Can you help me?
[12:51:51] <Krenair>	 what extension provides that syntax?
[12:52:13] <SMC>	 it's embedPDF
[12:54:11] <edsanders>	 Krenair, https://gerrit.wikimedia.org/r/#/c/209216/ stuck by a load order bug
[12:54:51] <edsanders>	 SMC, there currently isn't a generic tool for inserting extension tags, just editing them
[12:56:52] <edsanders>	 SMC, the simplest example of creating an insert tool for a specific extension can by found in wikihiero (wikihiero/modules/VisualEditor)
[12:57:19] <Krenair>	 fun
[12:58:52] <SMC>	 my first thinking was that a make a check when using the insert media funktion of the filename ending .. if it is an pdf the function has to use the tags
[13:06:18] <edsanders>	 Krenair, shouldn't extensions just register __DIR__ . "extension.json" instead of expecting core to know where they are?
[13:06:51] <edsanders>	 SMC, it would be difficult to override the media insert dialog - plus that generates very different HTML to an extension
[13:07:16] <edsanders>	 you'd be better off copying the wikihiero approach
[13:08:03] <edsanders>	 VisualEditor is not a wikitext editor, it is a Parsoid HTML editor, so you aren't generating <pdf>filename</pdf>
[13:09:32] <SMC>	 hm ok, maybe that would be the problem.. 
[13:09:45] <edsanders>	 but <div typeof="mw:Extension/embedPDF" data-mw='{"name":"embedPDF","attrs":{},"body":{"extsrc":"filename"}}'></div>
[13:10:38] <edsanders>	 the logic for doing that is already in generic was is already in the MWExtenion* classes, so you just need to extend them, like wikihiero does
[13:11:19] <edsanders>	 * the logic for doing that is already implemented generically in the MWExtenion* classes ...
[13:21:01] <Krenair>	 edsanders, I think that extensions being in weird non-standard places is considered a bit of an edge case
[13:21:24] <edsanders>	 as mentioned in the bug we already have globals to support it
[13:21:36] <edsanders>	 before the .json commit it wasn't a problem
[13:42:33] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Remove bold from result titles so that query highlighting works [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/209022 (owner: 10Esanders)
[13:42:57] <SMC>	 thanks edsanders .. maybe i'll find a way 
[13:44:52] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove bold from result titles so that query highlighting works [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/209022 (owner: 10Esanders)
[14:15:14] <Krenair>	 edsanders, how do you actually trigger GeneralReferenceDialog?
[14:55:25] <James_F>	 Krenair: It's currently only triggered from the Citoid extension.
[14:55:39] <James_F>	 Krenair: We're changing that soon-ish, but it's not available right now.
[14:56:04] <Krenair>	 Where is the Citoid part of https://gerrit.wikimedia.org/r/208971 then?
[14:56:29] <James_F>	 Krenair: getSurface().execute( 'window', 'open', 'generalreference', { …} ) 
[14:57:11] <James_F>	 Krenair: https://gerrit.wikimedia.org/r/#/c/209198/ but it's not a breaking change, is it?
[14:57:23] <edsanders>	 no
[14:57:44] <edsanders>	 as long as it works as before then it's good to merge
[14:58:14] <edsanders>	 you will need to have citoid extension enabled to test it though, as James points out
[14:58:28] <James_F>	 Citoid extension installation is relatively easy.
[14:58:42] <James_F>	 You need the extension and a few MW: messages set.
[14:59:04] <Krenair>	 yeah I already installed that
[15:06:22] <Krenair>	 edsanders, "We couldn't make a citation for you. You can make one by using the ."
[15:06:37] <Krenair>	 it doesn't provide a proper way to try again either
[15:06:40] <edsanders>	 ah
[15:07:03] <grrrit-wm>	 (03PS2) 10Divec: WIP: Zero-width space to avoid empty annotation cursoring bug [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/208355 (https://phabricator.wikimedia.org/T96307) 
[15:07:05] <edsanders>	 this is the Citoid patch yes?
[15:08:33] <Krenair>	 yes
[15:09:49] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] WIP: Zero-width space to avoid empty annotation cursoring bug [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/208355 (https://phabricator.wikimedia.org/T96307) (owner: 10Divec)
[15:22:43] <grrrit-wm>	 (03PS2) 10Esanders: Refactor reference source selection out into a widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/208971 
[15:23:16] <grrrit-wm>	 (03PS1) 10Esanders: Fix preview widget class name [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/209241 
[15:23:40] <grrrit-wm>	 (03CR) 10Jforrester: [C: 031] "Whoops." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/209241 (owner: 10Esanders)
[15:40:55] <grrrit-wm>	 (03PS3) 10Esanders: Redesign CiteFromIdInspector [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/209198 (https://phabricator.wikimedia.org/T97390) 
[16:32:08] <wikibugs>	 10VisualEditor, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review: Remove dropdown for other cite options from the toolbar. Options will be accessible from the auto-cite tool - https://phabricator.wikimedia.org/T96946#1265395 (10Jdforrester-WMF)
[16:32:12] <wikibugs>	 10Citoid, 10VisualEditor, 7Design, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review: Consolidate citation workflow into an inspector - https://phabricator.wikimedia.org/T97390#1265394 (10Jdforrester-WMF)
[16:33:38] <Krinkle>	 edsanders: Yep.
[16:33:52] <Krinkle>	 edsanders: mediawiki/core, mediawiki/extensions/
[16:34:06] <edsanders>	 Krinkle, see https://phabricator.wikimedia.org/T98319 and patch
[16:34:16] <Krinkle>	 edsanders: Its the only workable set up if you deal with wmf branches and older release branches.
[16:34:26] <Krinkle>	 Because otherwise skins/ and extensions/ get screwed up
[16:34:57] <Krinkle>	 I use require_ from the other directory directly and set wgExtensionAssetsPath accordingly for front-end references. 
[16:35:23] <edsanders>	 have you got a fix for the backend problem^^ ?
[16:36:07] <Krinkle>	 What backend problem? This set up has worked without issues for over 5 years. Afaik Roan and Reedy (used to?) have the same set up, as do most "old timer" MW devs that predate me :)
[16:37:34] <edsanders>	 have you read the bug?
[16:38:31] <wikibugs>	 10VisualEditor, 6Community-Liaison, 10WMF-Product-Strategy, 3Editing Department 2014/15 Q4 blockers, 3Search-and-Discovery-Research-and-Data-Sprint: How many active editors are using VisualEditor at large Wikipedias? - https://phabricator.wikimedia.org/T94637#1265438 (10Ironholds)
[16:39:09] <Krinkle>	 Yes, I raised the issue and caused the bug to get filed.
[16:39:26] <Krinkle>	 https://github.com/Krinkle/dotfiles/blob/master/hosts/KrinkleMac/templates/mw-LocalSettings.php#L24-L29
[16:39:37] <Krinkle>	 https://github.com/Krinkle/dotfiles/blob/master/hosts/KrinkleMac/mw-CommonSettings.php#L288-L292
[16:39:44] <Krinkle>	 There is a $path parameter for a reason
[16:39:49] <Krinkle>	 Though your patch would make things a lot easier
[16:40:07] <edsanders>	 Yes, but it doesn't work - Setup.php which sets the defaults, hasn't run yet
[16:40:43] <Krinkle>	 Such a global var has never been needed because MediaWIki has no concept of an extension directory in the backend. Code gets loaded in LocalSettings, anything in the backend expands relatively, not absolutely.
[16:41:38] <Krinkle>	 Typically using __DIR__, e.g. when registering modules or classes.
[16:42:12] <Krinkle>	 edsanders: Perhaps $path can optionally be a directory, to make it slightly easier to use.
[16:42:34] <Krenair>	 I seem to recall maintenance scripts breaking with that directory setup
[16:42:40] <Krinkle>	 Nope.
[16:42:57] <Krinkle>	 If you've got more than one wiki, you should have MW_INSTALL_PATH set in the env
[16:43:03] <Krinkle>	 same as in prod
[16:43:26] <Krenair>	 I had only one wiki with that setup
[16:43:36] <Krinkle>	 you run the extension php file directly, and that usees the env to discover mediawiki core
[16:43:51] <Krinkle>	 https://github.com/Krinkle/dotfiles/blob/master/hosts/KrinkleMac/modules/setup.sh#L25-L28
[16:44:08] <Krinkle>	 for Maintenance that is
[16:45:00] <Krinkle>	 Krenair: Yeah, that works well. But it becomes more or less mandatory to have the env variables when working with multiple hostnames.
[16:45:30] <Krenair>	 This was a setup on my desktop that had only one wiki but core in it's own directory
[16:45:40] <Krinkle>	 I use *.mediawiki.dev for a basic wiki farm using the same source code. And mediawiki.dev for an isolated simple wiki.
[16:46:00] <Krenair>	 You were sitting next to me when I set up my laptop :)
[16:46:26] <Krinkle>	 Right
[16:50:29] <wikibugs>	 10VisualEditor: A mouse icon appears upon hovering over the search and external link icon in link inspector but none of them are clickable object - https://phabricator.wikimedia.org/T98213#1265527 (10Ryasmeen)
[16:52:39] <wikibugs>	 10VisualEditor: Irregular highlighted borders appear around the text-box inside link inspector - https://phabricator.wikimedia.org/T98080#1265548 (10Ryasmeen) We changed something around this in this week: https://phabricator.wikimedia.org/T97516 . May be related?
[17:07:45] <wikibugs>	 10VisualEditor, 6Community-Liaison, 10WMF-Product-Strategy, 3Editing Department 2014/15 Q4 blockers, 3Search-and-Discovery-Research-and-Data-Sprint: How many active editors are using VisualEditor at large Wikipedias? - https://phabricator.wikimedia.org/T94637#1265607 (10Ironholds)
[17:08:50] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: Revert "Be more selective in application of 0.8em font size" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/209273 (https://phabricator.wikimedia.org/T98193) 
[17:11:20] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 5Patch-For-Review: [Regression pre-wmf5] Switching from VE to read mode re-embiggens the text again and makes it impossible to edit twice in one session - https://phabricator.wikimedia.org/T98193#1265634 (10matmarex) If this is "Unbreak Now!" priority, I recommend me...
[17:13:28] <grrrit-wm>	 (03PS4) 10Mvolz: Redesign CiteFromIdInspector [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/209198 (https://phabricator.wikimedia.org/T97390) (owner: 10Esanders)
[17:13:39] <grrrit-wm>	 (03PS3) 10Mvolz: Refactor reference source selection out into a widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/208971 (owner: 10Esanders)
[17:15:50] <wikibugs>	 10WikiEditor, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review: editSessionID is duplicated in Edit:Schema for Wikitext - https://phabricator.wikimedia.org/T95919#1265671 (10Halfak) Hey folks,  I ran the usual set of tests against this again and while I'm *finally* seeing sessions logged when I hit...
[17:18:29] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Links: Link inspector tabs (Search/External) not consistent with VE/OOUI design pattern - https://phabricator.wikimedia.org/T98370#1265682 (10Krinkle) 3NEW
[17:20:49] <edsanders>	 Krinkle, Krenair so any ideas on how we should work around the load order issues of Setup.php?
[17:21:29] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Links: Irregular highlighted borders appear around the text-box inside link inspector - https://phabricator.wikimedia.org/T98080#1265727 (10Ryasmeen)
[17:21:41] <Krinkle>	 edsanders: The value is only significant if it's not the default, right?
[17:21:45] <Krinkle>	 So it should work fine
[17:21:54] <Krinkle>	 if false, use $IP/extensions. If not false, use it.
[17:22:07] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Links: A mouse icon appears upon hovering over the search and external link icon in link inspector but none of them are clickable object - https://phabricator.wikimedia.org/T98213#1265731 (10Ryasmeen)
[17:22:12] <edsanders>	 Krenair, $IP/extensions gets set in Setup.php
[17:22:24] <edsanders>	 extensions are registered before that
[17:22:35] <Krinkle>	 I see that, but that's only for the main run time after glbal functions and hooks are run
[17:22:37] <Krinkle>	 Use it inline.
[17:22:45] <Krinkle>	 In the relevant global function
[17:22:48] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Links: The URL in the context menu of an external link is clickable after adding label to it but not otherwise - https://phabricator.wikimedia.org/T98211#1265732 (10Ryasmeen)
[17:22:53] <edsanders>	 use what inline?
[17:23:27] <edsanders>	 do the fallback twice?
[17:23:48] <Krinkle>	 Even if you can get in there before some critical point in setup, it's pointless. because that might give you a non-false value as default, but a non-default value (which is what this whole thing is for)  would be et by the user in LocalSettings.php in the same synchronous execution path that calls wfLoadEtension so there's no possible place to get it set.
[17:23:51] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Links, 3Editing Department 2014/15 Q4 blockers: [Usability Suggestion] In link inspector, after switching back from External link to Search pages while a text is selected, retaining the original text in the text field w... - https://phabricator.wikimedia.org/T98210#1265754
[17:24:31] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Links, 10OOjs-UI, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-05-06_(1.26wmf5): [Regression pre-wmf5] Link inspector opens with a red highlight around the empty text field except for the first time of ... - https://phabricator.wikimedia.org/T98202#1265758
[17:24:39] <Krinkle>	 Actually, $IP is set before LocalSettings.php
[17:24:48] <Krinkle>	 Just use it direcrtly in DefaultSettings.php
[17:25:28] <edsanders>	 $wgExtensionPath = "$IP/extensions"; ?
[17:25:33] <Krinkle>	 Yup
[17:25:44] <edsanders>	 why aren't the others like that?
[17:25:52] <Krinkle>	 They are, just not the ones from the stone age.
[17:26:08] <Krinkle>	 Because $IP used to be a substituted assignment in LocalSettings.php generated by the installer
[17:26:18] <Krinkle>	 But that hasn't been the case for many years.
[17:26:41] <Krinkle>	 Search for $IP in Defaultsettings. Plenty do use it.
[17:30:12] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Revert "Be more selective in application of 0.8em font size" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/209273 (https://phabricator.wikimedia.org/T98193) (owner: 10Bartosz Dziewoński)
[17:30:58] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-05-06_(1.26wmf5): [Regression pre-wmf5] Switching from VE to read mode re-embiggens the text again and makes it impossible to edit twice in one session - https://phabricator.wikimedia.org/T98193#1265808 (10Jd...
[17:31:10] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-05-06_(1.26wmf5): [Regression pre-wmf5] Switching from VE to read mode re-embiggens the text again and makes it impossible to edit twice in one session - https://phabricator.wikimedia.org/T98193#1262057 (10Jd...
[17:31:20] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Links: Dark highlight appears over the first match inside the link inspector after hovering over on some other article entry from the search result list - https://phabricator.wikimedia.org/T98085#1265815 (10Ryasmeen)
[17:31:48] <edsanders>	 Krinkle, also the signature of wfLoadExtension/Skin seems stupid
[17:31:53] <edsanders>	 ($name, $path=null)
[17:32:08] <edsanders>	 1. why would you every want to set a full fixed path
[17:32:22] <grrrit-wm>	 (03CR) 10Mvolz: [C: 04-1] "In the re-use tab, it shows the empty ref tag that the inspector automatically inserts when the inspector is created. I'm not sure if ther" [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/209198 (https://phabricator.wikimedia.org/T97390) (owner: 10Esanders)
[17:32:23] <edsanders>	 2. if you set a path, the $name parameter becomes unused
[17:33:59] <grrrit-wm>	 (03Merged) 10jenkins-bot: Revert "Be more selective in application of 0.8em font size" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/209273 (https://phabricator.wikimedia.org/T98193) (owner: 10Bartosz Dziewoński)
[17:36:50] <grrrit-wm>	 (03CR) 10Mvolz: "Also, the drop-down menu for the full list of citation templates still shows up to the right in the change." [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/209198 (https://phabricator.wikimedia.org/T97390) (owner: 10Esanders)
[17:40:48] <grrrit-wm>	 (03PS2) 10Jforrester: jshint: Kill file-level globals and add "moment" to the list [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/209044 
[17:47:15] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Links: Irregular highlighted borders appear around the text-box inside link inspector - https://phabricator.wikimedia.org/T98080#1265866 (10Krinkle) >>! In T98080#1260022, @Esanders wrote: > https://gerrit.wikimedia.org/r/#/c/208694/  That relates to T98202, which is ab...
[17:47:23] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Links: Irregular highlighted borders appear around the text-box inside link inspector - https://phabricator.wikimedia.org/T98080#1265868 (10Krinkle)
[17:47:26] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Links, 10OOjs-UI, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-05-06_(1.26wmf5): [Regression pre-wmf5] Link inspector opens with a red highlight around the empty text field except for the first time of ... - https://phabricator.wikimedia.org/T98202#1262287
[17:47:50] <wikibugs>	 10Citoid: Show "we were unable to make citation for you" instead of offering completely empty template.  - https://phabricator.wikimedia.org/T92428#1265872 (10Mvolz)
[17:47:55] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Links, 10OOjs-UI, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-05-06_(1.26wmf5): [Regression pre-wmf5] Link inspector should not have red highlight when still empty - https://phabricator.wikimedia.org/T98202#1265873 (10Krinkle)
[17:49:36] <wikibugs>	 10VisualEditor, 10VisualEditor-Performance, 10Parsoid, 10RESTBase, 7RESTBase-API: RFC: API for retrieval and saving of top-level HTML elements / sections by element ID - https://phabricator.wikimedia.org/T94890#1265874 (10GWicke)
[17:53:54] <grrrit-wm>	 (03CR) 10Mvolz: [C: 031] "Tested without citoid extension enabled (obviously couldn't see widget there since there was no way to get to it but it didn't break anyth" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/208971 (owner: 10Esanders)
[18:00:46] <grrrit-wm>	 (03CR) 10Jforrester: [C: 031] Refactor reference source selection out into a widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/208971 (owner: 10Esanders)
[18:00:57] <James_F>	 edsanders: ^^^ Did you want that merged?
[18:01:30] <edsanders>	 yup
[18:04:54] <grrrit-wm>	 (03CR) 10Esanders: "@Mvolz - that's an existing bug with the referenceListNode too. Will fix separately (in ve-mw)." [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/209198 (https://phabricator.wikimedia.org/T97390) (owner: 10Esanders)
[18:10:28] <wikibugs>	 10Citoid, 10VisualEditor, 3Editing Department 2014/15 Q4 blockers: Book ISBN links are broken in content view because of linking to /w/ instead of /wiki/ - https://phabricator.wikimedia.org/T95700#1265974 (10Jdforrester-WMF)
[18:11:07] <grrrit-wm>	 (03PS5) 10Esanders: Redesign CiteFromIdInspector [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/209198 (https://phabricator.wikimedia.org/T97390) 
[18:11:09] <grrrit-wm>	 (03PS1) 10Esanders: Don't show placeholder references in lists [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/209285 
[18:12:18] <grrrit-wm>	 (03CR) 10Esanders: "@Mvolz fixed with https://gerrit.wikimedia.org/r/#/c/209285/ (and a one liner in this patch)." [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/209198 (https://phabricator.wikimedia.org/T97390) (owner: 10Esanders)
[18:16:21] <grrrit-wm>	 (03PS2) 10Esanders: Don't show placeholder references in lists [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/209285 
[18:16:23] <grrrit-wm>	 (03PS4) 10Esanders: Refactor reference source selection out into a widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/208971 
[18:19:46] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 10OOjs-UI, 10Vector, 3Editing Department 2014/15 Q4 blockers: Change OOUI MediaWiki theme to be optimized for font-size of 14px (0.875em×16px), instead of 12.8px (0.8em×16px), like MediaWiki Vector skin - https://phabricator.wikimedia.org/T97631#1248353 (10Jdforre...
[18:25:15] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Links: Link inspector tabs (Search/External) not consistent with VE/OOUI design pattern - https://phabricator.wikimedia.org/T98370#1266068 (10Krinkle)
[18:25:19] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Links, 3Editing Department 2014/15 Q4 blockers: Switch link inspector over to using the new IndexLayout in OOjs UI - https://phabricator.wikimedia.org/T97878#1266070 (10Krinkle)
[18:25:44] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Links: Link inspector tabs (Search/External) not consistent with VE/OOUI design pattern - https://phabricator.wikimedia.org/T98370#1265682 (10Krinkle) I believe this would be resolved by T97878. Marking as duplicate since there isn't much value in keeping this around.
[18:29:32] <Krinkle>	 MatmaRex: Unless you're on it already, I'll fix pl.wiki Editnotice.
[18:30:23] <MatmaRex>	 thanks
[18:30:29] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Links, 3Editing Department 2014/15 Q4 blockers: Stage insertion and application of new links with a "preview" interstitial step before you actually apply - https://phabricator.wikimedia.org/T98273#1266112 (10Jdforrester-WMF)
[18:35:22] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Refactor reference source selection out into a widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/208971 (owner: 10Esanders)
[18:38:10] <grrrit-wm>	 (03Merged) 10jenkins-bot: Refactor reference source selection out into a widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/208971 (owner: 10Esanders)
[18:43:36] <tinajohnson>	 Visual editor loads but the toolbars doesn't come up in vagrant. By loading I mean the progress bar comes half way and disappears but slightly fades the page it usually does. Did pretty much everything said in http://www.mediawiki.org/wiki/Extension:VisualEditor#Basic_configuration_for_MediaWiki-VisualEditor , except the last one (not a private wiki). Anyone
[18:43:37] <tinajohnson>	 knows why ? 
[18:50:25] <Krenair>	 tinajohnson, well what shows in the console?
[18:50:34] <Krenair>	 that's the first thing you should check with these types of issues
[18:52:30] <tinajohnson>	 ah ! "VisualEditor failed to load: Error: Module ext.visualEditor.mediawiki has failed dependencies"
[18:53:43] <Krenair>	 did you run git submodule update --init --recursive
[18:54:15] <tinajohnson>	 did run this, git submodule update --init
[18:55:50] <tinajohnson>	 "Exception in module-execute in module ext.visualEditor.core:"
[18:56:00] <tinajohnson>	 ^this one shows up too
[18:57:30] <tinajohnson>	 if the error log helps, https://dpaste.de/yBoL
[18:59:39] <wikibugs>	 10VisualEditor: [Regression wmf5]Cannot not open VE after switching to Read mode from Edit mode  - https://phabricator.wikimedia.org/T98388#1266206 (10Ryasmeen) 3NEW
[18:59:51] <grrrit-wm>	 (03CR) 10Jforrester: [C: 031] Don't show placeholder references in lists [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/209285 (owner: 10Esanders)
[19:00:32] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-05-06_(1.26wmf5): [Regression pre-wmf5] Switching from VE to read mode re-embiggens the text again and makes it impossible to edit twice in one session - https://phabricator.wikimedia.org/T98193#1266214 (10Ry...
[19:01:09] <wikibugs>	 10VisualEditor: [Regression wmf5]Cannot not open VE after switching to Read mode from Edit mode - https://phabricator.wikimedia.org/T98388#1266217 (10Ryasmeen) p:5Triage>3Unbreak!
[19:01:28] <grrrit-wm>	 (03PS3) 10Jforrester: jshint: Kill file-level globals and add "moment" to the list [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/209044 
[19:01:41] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] "Per Ed." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/209044 (owner: 10Jforrester)
[19:03:30] <Krenair>	 got the latest versions of VE-MW, VE core, and MW core tinajohnson?
[19:05:39] <Krenair>	 the ordering on https://phabricator.wikimedia.org/T95700#1265974 is funny
[19:05:49] <Krenair>	 Backlog: Urgent Fixes is first, i.e. older
[19:05:52] <Krenair>	 then there's Backlog
[19:06:01] <tinajohnson>	 Krenair: hm, this is a mediawiki vagrant created a few days ago. I believe it is up to date.
[19:06:08] <Krenair>	 the actual column shown at the top is Backlog: Urgent Fixes
[19:06:23] <tinajohnson>	 Krenair: http://newsletter-test.wmflabs.org/ this is the one
[19:06:28] <Krenair>	 "A few days ago" generally isn't good enough
[19:07:09] <tinajohnson>	 I'll make sure in few mins
[19:07:23] <Krenair>	 huh
[19:07:31] <Krenair>	 something is broken there
[19:07:37] <Krenair>	 you have two "Edit source" tabs
[19:08:08] <wikibugs>	 10VisualEditor, 10VisualEditor-EditingTools, 7Design: VisualEditor: Inspectors apply if you exit from them without a positive action, which can be a bit confusing - https://phabricator.wikimedia.org/T55546#1266228 (10Whatamidoing-WMF) We now have a "Remove" button, which is nice, but since the link is automa...
[19:08:17] <tinajohnson>	 yeah, fishy I know.. happened when I added lines to Localsettings.php
[19:08:32] <tinajohnson>	 I was following this http://www.mediawiki.org/wiki/Extension:VisualEditor#Setting_VisualEditor_up
[19:09:21] <wikibugs>	 10VisualEditor: Add a "Cancel" button to all dialogs, inspectors, widgets, tools, etc. - https://phabricator.wikimedia.org/T97363#1266229 (10Whatamidoing-WMF)
[19:09:43] <grrrit-wm>	 (03Merged) 10jenkins-bot: jshint: Kill file-level globals and add "moment" to the list [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/209044 (owner: 10Jforrester)
[19:14:10] <grrrit-wm>	 (03PS6) 10Mvolz: Redesign CiteFromIdInspector [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/209198 (https://phabricator.wikimedia.org/T97390) (owner: 10Esanders)
[19:16:22] <tinajohnson>	 Krenair: I commented out the require
[19:17:10] <tinajohnson>	 sorry, I meant to say, I commented out the require_once statement and I get this now http://newsletter-test.wmflabs.org/
[19:18:21] <tinajohnson>	 I had role enabled visual editor in vagrant and then later I added the configuration statements to Localsettings.php manually.  I suppose there is no need for that
[19:21:48] <grrrit-wm>	 (03CR) 10Mvolz: [C: 031] "Tested with I92d38e00eaa, works. (have not tested bonus :))" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/209285 (owner: 10Esanders)
[19:22:04] <tinajohnson>	 Krenair: VisualEditor came up
[19:22:42] <tinajohnson>	 I did a git pull and all works fine now, thanks !
[19:24:58] <Krenair>	 I didn't do much
[19:25:03] <Krenair>	 but you're very welcome :p
[19:26:12] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Links: Opening the link inspector with text selected should auto-populate search results for that text - https://phabricator.wikimedia.org/T97723#1266300 (10Whatamidoing-WMF) Isn't that how it was working just a little while ago?  This might be an accidental regression.
[19:30:18] <grrrit-wm>	 (03CR) 10Mvolz: [C: 031] "Tested with and without I8dc5146, works." [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/209198 (https://phabricator.wikimedia.org/T97390) (owner: 10Esanders)
[19:30:47] <tinajohnson>	 Krenair: Vagrant did make it a lot easier, automatically configuring parsoid and all. I do have the same issue in my local wiki, I'll try a git pull there too :)
[19:31:28] <Krenair>	 I've only ever seen these issues caused by mis-matching versions
[19:32:10] <Krenair>	 these requirements change on a very frequent basis
[19:35:15] <tinajohnson>	 yes, I require to use VE in a page for my extension. do I have to import VE ?
[19:35:37] <Krenair>	 you want to integrate your extension with VE?
[19:36:35] <tinajohnson>	 I mean to use it in my extension
[19:37:32] <tinajohnson>	 Supposing I've a page where newsletters can be created. I need to have a textbox where the body can be created
[19:37:44] <tinajohnson>	 VE can be really useful there
[19:38:07] <Krenair>	 will you ever need to deal with editing existing wikitext?
[19:38:47] <tinajohnson>	 hm, maybe yes. later in the project
[19:38:53] <tinajohnson>	 as of now, no I guess
[19:40:16] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Links, 3Editing Department 2014/15 Q4 blockers: [Usability Suggestion] In link inspector, after switching back from External link to Search pages while a text is selected, retaining the original text in the text field w... - https://phabricator.wikimedia.org/T98210#1266370
[19:40:26] <tinajohnson>	 template more or less looks like the one used in Special:MassMessage. But instead of just a text box, I would love to have VE along with it 
[19:40:41] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Links: The URL in the context menu of an external link is clickable after adding label to it but not otherwise - https://phabricator.wikimedia.org/T98211#1266375 (10Ryasmeen) p:5Triage>3Normal
[19:41:20] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Links: A mouse icon appears upon hovering over the search and external link icon in link inspector but none of them are clickable object - https://phabricator.wikimedia.org/T98213#1266378 (10Ryasmeen) p:5Triage>3Normal
[19:43:15] <Krinkle>	 James_F|Away: MatmaRex: In debugging the pl.wiki edit notice, I also noticed that VE's "Newarticletext" is broken. It uses a relative /wiki/... url instead of http://.../wiki/ and as such renders as plain text e.g. https://pl.wikipedia.org/wiki/ASpis_tre%C5%9Bci?veaction=edit  says " the box below (see the [/wiki/Pomoc:Spis_tre%C5%9Bci help page] for more"
[19:43:32] <Krinkle>	 I dont know if that's a known issue, but I basically fixed it while debugging, will submit a patch soon FYI :)
[19:44:19] <MatmaRex>	 ha. nice
[19:44:45] <MatmaRex>	 sorry, i am busy today. i learned that i had an assignment due yesterday.
[19:46:05] <wikibugs>	 10VisualEditor, 10VisualEditor-EditingTools: Please change the "highlight" color in the search results for the link inspector - https://phabricator.wikimedia.org/T98393#1266394 (10Whatamidoing-WMF) 3NEW
[19:55:16] <James_F>	 MatmaRex: Whoops.
[19:55:45] <wikibugs>	 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-Links: Please change the "highlight" color in the search results for the link inspector - https://phabricator.wikimedia.org/T98393#1266423 (10Ryasmeen)
[19:56:00] <MatmaRex>	 quite
[19:57:19] <wikibugs>	 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-Links: Please change the "highlight" color in the search results for the link inspector - https://phabricator.wikimedia.org/T98393#1266440 (10Esanders) I agree, but this is an upstream issue with the OOJS-UI MediaWiki theme
[19:59:34] <wikibugs>	 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-Links, 7Tracking: VisualEditor: Improvements and  behaviour changes to the link input widget (tracking) - https://phabricator.wikimedia.org/T50789#1266456 (10Whatamidoing-WMF)
[20:02:03] <grrrit-wm>	 (03PS1) 10Krinkle: api: Expand helppage url before passing to 'newarticletext' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/209350 
[20:02:07] <Krinkle>	 MatmaRex: ^
[20:02:18] <Krinkle>	 MatmaRex: Ah, no worries then :)
[20:03:38] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] api: Expand helppage url before passing to 'newarticletext' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/209350 (owner: 10Krinkle)
[20:06:11] <wikibugs>	 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-Links, 10OOjs-UI, 7Design: Please change the "highlight" color in the search results for the link inspector - https://phabricator.wikimedia.org/T98393#1266474 (10Esanders)
[20:13:04] <wikibugs>	 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki, 3Editing Department 2014/15 Q4 blockers: Rendered references in context view when working from /w/index.php?title=…&veaction=edit link to /w/ not /wiki/ - https://phabricator.wikimedia.org/T95700#1266503 (10Jdforrester-WMF)
[20:13:14] <wikibugs>	 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki, 3Editing Department 2014/15 Q4 blockers: Rendered references in context view when working from /w/index.php?title=…&veaction=edit link to /w/ not /wiki/ - https://phabricator.wikimedia.org/T95700#1198015 (10Jdforrester-WMF) On re-testing, this is not fixe...
[20:14:27] <wikibugs>	 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki, 3Editing Department 2014/15 Q4 blockers: Rendered references in context view when working from /w/index.php?title=…&veaction=edit link to /w/ not /wiki/ - https://phabricator.wikimedia.org/T95700#1266523 (10Jdforrester-WMF)
[20:14:35] <wikibugs>	 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki, 3Editing Department 2014/15 Q4 blockers: Rendered references in context view when working from /w/index.php?title=…&veaction=edit link to /w/ not /wiki/ - https://phabricator.wikimedia.org/T95700#1198015 (10Jdforrester-WMF)
[20:15:05] <wikibugs>	 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-Links, 10OOjs-UI, 7Design: Please change the "highlight" color in the search results for the link inspector - https://phabricator.wikimedia.org/T98393#1266529 (10Jdforrester-WMF) a:3Nirzar
[20:16:12] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Links, 3Editing Department 2014/15 Q4 blockers: [Usability Suggestion] In link inspector, after switching back from External link to Search pages while a text is selected, retaining the original text in the text field w... - https://phabricator.wikimedia.org/T98210#1266543
[20:16:25] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 3Editing Department 2014/15 Q4 blockers: [Regression?] Removing edited articles from watchlist at it.wp - https://phabricator.wikimedia.org/T97838#1266545 (10Jdforrester-WMF)
[20:16:42] <wikibugs>	 10VisualEditor, 3Editing Department 2014/15 Q4 blockers: Move the delete action outside of edit for link inspector and language inspector - https://phabricator.wikimedia.org/T98272#1266546 (10Jdforrester-WMF)
[20:19:22] <aharoni>	 hola
[20:22:58] <wikibugs>	 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-Tables, 7Design: Tables: "Merge cells" and "Make header" should be in a context menu, not the toolbar - https://phabricator.wikimedia.org/T75228#1266600 (10Jdforrester-WMF)
[20:23:00] <wikibugs>	 10VisualEditor, 3Editing Department 2014/15 Q4 blockers: Table header/content cell control should be in context menu, not in toolbar - https://phabricator.wikimedia.org/T96947#1266599 (10Jdforrester-WMF)
[20:31:30] <grrrit-wm>	 (03Merged) 10jenkins-bot: api: Expand helppage url before passing to 'newarticletext' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/209350 (owner: 10Krinkle)
[20:41:28] <James_F>	 aharoni: Hey.
[20:41:47] <halfak>	 o/ RoanKattouw, I've got sad news.  
[20:42:02] <halfak>	 When you have a chance, could you take a look at my last post here: https://phabricator.wikimedia.org/T95919 ?
[20:47:15] <wikibugs>	 10VisualEditor: Table header/content cell control should be in context menu, not in toolbar - https://phabricator.wikimedia.org/T96947#1266763 (10Jdforrester-WMF)
[20:47:34] <RoanKattouw>	 halfak: *sigh*
[20:47:48] <RoanKattouw>	 I know that back sessions don't have an init event
[20:47:50] <wikibugs>	 10VisualEditor: Table header/content cell control should be in context menu, not in toolbar - https://phabricator.wikimedia.org/T96947#1229950 (10Jdforrester-WMF) In the weekly triage meeting on 2015-05-06, we discussed this task. We felt that this was not as high priority as the other user-facing work that we n...
[20:47:57] <RoanKattouw>	 But they should have a ready event
[20:49:46] <wikibugs>	 10VisualEditor, 10VisualEditor-DataModel, 10VisualEditor-MediaWiki-References, 3Editing Department 2014/15 Q4 blockers: VisualEditor: References created by templates numbered alone, not with the rest of the page, and don't show up as references to insert - https://phabricator.wikimedia.org/T52474#1266772 (1...
[20:50:06] <wikibugs>	 10VisualEditor, 10VisualEditor-Performance, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review, and 2 others: Internal nodes should eventually be in a separate document ("sub-documents") - https://phabricator.wikimedia.org/T49344#1266774 (10Jdforrester-WMF)
[20:50:08] <wikibugs>	 10VisualEditor, 10VisualEditor-DataModel, 10VisualEditor-MediaWiki-References, 3Editing Department 2014/15 Q4 blockers: VisualEditor: References created by templates numbered alone, not with the rest of the page, and don't show up as references to insert - https://phabricator.wikimedia.org/T52474#1266773 (1...
[20:51:35] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable, 3Editing Department 2014/15 Q4 blockers: VisualEditor: Pre-annotation is from up-page, so deleting and replacing the first character in a link de-links it; deleting and replacing the first bold character in a wor... - https://phabricator.wikimedia.org/T52678#1266775
[20:51:42] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable: VisualEditor: Pre-annotation is from up-page, so deleting and replacing the first character in a link de-links it; deleting and replacing the first bold character in a word de-bolds it; etc. - https://phabricator.wikimedia.org/T52678#1266776 (10Jdforrester-WMF)
[20:51:57] <wikibugs>	 10VisualEditor, 10VisualEditor-DataModel, 10VisualEditor-MediaWiki-References: VisualEditor: References created by templates numbered alone, not with the rest of the page, and don't show up as references to insert - https://phabricator.wikimedia.org/T52474#558083 (10Jdforrester-WMF)
[20:52:10] <Krenair>	 RoanKattouw, umm
[20:52:22] <Krenair>	 don't we generate a new session ID on back?
[20:52:27] <Krenair>	 and therefore it'll go into a separate session?
[20:52:34] <Krenair>	 and this was deliberate?
[20:52:59] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Links, 3Editing Department 2014/15 Q4 blockers: Stage insertion and application of new links with a "preview" interstitial step before you actually apply - https://phabricator.wikimedia.org/T98273#1266786 (10Jdforrester-WMF) In the weekly triage meeting on 2015-05-06,...
[20:53:08] <RoanKattouw>	 Yes adn yes
[20:53:21] <RoanKattouw>	 Well, technically we generate it on unload
[20:53:32] <RoanKattouw>	 after the last event has been sent
[20:53:36] <halfak>	 RoanKattouw, I can run another round or try something different to get that ready event. 
[20:54:01] <RoanKattouw>	 Let me look at your log
[20:54:25] <halfak>	 kk.  The worklog should be pretty clear (except for my typos -- sorry about those)
[20:54:46] <RoanKattouw>	 "Note that some sessions only have an attempt. "
[20:54:49] <RoanKattouw>	 I don't see that in the SQL result
[20:55:50] <halfak>	 Yeah.  I think that might be a typo.  It should have said "only have a success"
[20:55:53] <RoanKattouw>	 Hmm but the second log does have that
[20:56:01] <RoanKattouw>	 No, in the first log every session that has an attempt has a success
[20:56:06] <RoanKattouw>	 The second log does have a discrepancy
[20:56:08] * halfak looks again 
[20:56:20] <RoanKattouw>	 A session with only a success and nothing else
[20:57:06] <RoanKattouw>	 Also, I observe that you rely on page_title being populated
[20:57:51] <RoanKattouw>	 I don't know how it's populated, but for each of the session IDs that appear in your log, could you run a separate query to find all rows with that session ID regardless of other fields (except a restriction by timestamp to make the query not super slow)
[20:59:13] <RoanKattouw>	 halfak: ---^^ basically just to make sure that your event_page.title restrictions don't drop any events
[21:00:06] <halfak>	 +1  will give that a try. 
[21:00:32] * halfak runs to a meeting. 
[21:00:39] <halfak>	 Will report on new queries when I'm done. 
[21:33:09] <halfak>	 RoanKattouw, https://meta.wikimedia.org/wiki/Research_talk:VisualEditor%27s_effect_on_newly_registered_editors/Work_log/2015-05-06#Updates
[21:33:16] <halfak>	 Looks like filtering on page_title wasn't the issue. 
[21:33:25] <halfak>	 When should I expect the "ready" event to fire?
[21:34:24] <RoanKattouw>	 ready should fire every time an edit form loads
[21:34:42] <RoanKattouw>	 So 1) right after init, 2) on preview/showchanges, 3) on back
[21:38:18] <halfak>	 RoanKattouw, I'll go see if waiting around helps and check the console for errors. 
[21:38:36] <aharoni>	 RoanKattouw, Krenair - This may be a somewhat surprising use of a VE JS hook: https://gerrit.wikimedia.org/r/#/c/209380/
[21:38:39] <RoanKattouw>	 OK
[21:38:58] <RoanKattouw>	 Sorry for crossing the streams and putting part of this in #wikimedia-dev
[21:39:11] <RoanKattouw>	 Over there I suggested disabling sampling on a small wiki like mw.org to make testing easier
[21:39:22] <aharoni>	 I tested it and it seems to do what I want, but it may be not entirely expected. Your review is welcome, if you have time.
[21:39:30] <RoanKattouw>	 And exclude the possibility that the session ID changes mid-session to something that gets dropped
[21:40:00] <RoanKattouw>	 halfak: Speaking of, could you look at events in the same minute to see if events from your session could possibly have been registered with a different sessionID?
[21:40:43] <halfak>	 RoanKattouw, so we'd need to do a different sessionId *and* a different page Id.
[21:40:48] <halfak>	 *title
[21:41:30] <RoanKattouw>	 Hmm yeah that does seem implausible
[21:41:52] <halfak>	 Is "ready" client-side?
[21:41:56] <RoanKattouw>	 Yes
[21:42:12] <RoanKattouw>	 ready and abort are client-side, init and save* are server-side
[21:44:25] <halfak>	 I can't seem to produce a request for event.gif in the edit pane whether I hit back or not
[21:44:38] <halfak>	 Wait... found it
[21:44:48] <halfak>	 OK.  I got it without doing the back-dance
[21:45:32] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Links, 3Editing Department 2014/15 Q4 blockers: Move the delete action outside of edit for link inspector and language inspector - https://phabricator.wikimedia.org/T98272#1266970 (10Jdforrester-WMF) p:5Triage>3Normal
[21:45:40] <halfak>	 For some reason, i don't get a ready even when i click "edit" for my sandbox, but I get it on a random article. 
[21:45:50] <wikibugs>	 10VisualEditor, 10Parsoid, 3Editing Department 2014/15 Q4 blockers: <a> and <style> tags added by VE - https://phabricator.wikimedia.org/T97279#1266976 (10Jdforrester-WMF) p:5Triage>3Normal
[21:45:56] * halfak switches to an incognito & new user
[21:45:57] <wikibugs>	 10VisualEditor, 10Parsoid, 3Editing Department 2014/15 Q4 blockers: <a> and <style> tags added by VE - https://phabricator.wikimedia.org/T97279#1237846 (10Jdforrester-WMF) How did this make it past Parsoid?
[21:46:18] <wikibugs>	 10VisualEditor, 10Parsoid, 3Editing Department 2014/15 Q4 blockers: Wikisyntax replaced by HTML syntax - https://phabricator.wikimedia.org/T97280#1266984 (10Jdforrester-WMF) Probably the same issue as {T97279}?
[21:46:28] <wikibugs>	 10VisualEditor, 10Parsoid, 3Editing Department 2014/15 Q4 blockers: Wikisyntax replaced by HTML syntax - https://phabricator.wikimedia.org/T97280#1266986 (10Jdforrester-WMF) p:5Triage>3Normal
[21:46:43] <wikibugs>	 10VisualEditor, 10Parsoid, 3Editing Department 2014/15 Q4 blockers: Empty nowiki tags added by VisualEditor - https://phabricator.wikimedia.org/T97430#1266988 (10Jdforrester-WMF) p:5Triage>3Normal
[21:47:10] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable, 3Editing Department 2014/15 Q4 blockers: Unable to select more than one paragraph using the keyboard - https://phabricator.wikimedia.org/T97809#1266990 (10Jdforrester-WMF) p:5Triage>3Normal
[21:48:04] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 3Editing Department 2014/15 Q4 blockers: Assist pl/it/de/ru/meta-wiki communities in updating their edit-notice systems to stop hidden content showing as "1 notice" - https://phabricator.wikimedia.org/T95822#1266996 (10Jdforrester-WMF) p:5Triage>3Normal
[21:48:31] <wikibugs>	 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References, 3Editing Department 2014/15 Q4 blockers: Remove dropdown for other cite options from the toolbar. Options will be accessible from the auto-cite tool - https://phabricator.wikimedia.org/T96946#1267001 (10Jdforrester-WMF) p:5Triage>3Normal
[21:48:52] <wikibugs>	 10VisualEditor, 6WMF-Design-Research, 3Editing Department 2014/15 Q4 blockers: VE Usability testing for basic editing tasks for VE release - https://phabricator.wikimedia.org/T96994#1267006 (10Jdforrester-WMF) p:5Triage>3High
[21:48:52] <halfak>	 I'm definitely seeing the ready event fire. 
[21:49:02] <halfak>	 Whether I hit back or not. 
[21:49:03] <wikibugs>	 10VisualEditor, 6WMF-Design-Research, 3Editing Department 2014/15 Q4 blockers: VE Readiness / New Editors Experience (VE and WTE) - https://phabricator.wikimedia.org/T96995#1267008 (10Jdforrester-WMF) p:5Triage>3High
[21:49:28] <halfak>	 For some interesting reason, I don't see it in my account, but I do if I test with a new account that I created a couple of days ago. 
[21:49:33] * halfak grosses fingers
[21:49:36] <halfak>	 *crosses
[21:49:43] <halfak>	 Hopefully it's some gadget I have enabled. 
[21:50:49] <halfak>	 So it seems that I can tell if I am sampled for by looking for that ready event. 
[21:51:40] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Links, 7Design, 3Editing Department 2014/15 Q4 blockers, and 2 others: Highlight matching parts of link suggestions - https://phabricator.wikimedia.org/T93697#1267019 (10Jdforrester-WMF) 5Open>3Resolved
[21:52:08] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Links, 7Design, 3Editing Department 2014/15 Q4 blockers, and 2 others: Highlight matching parts of link suggestions - https://phabricator.wikimedia.org/T93697#1143613 (10Jdforrester-WMF)
[21:53:48] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 3Editing Department 2014/15 Q4 blockers: Handle load failures more gracefully - https://phabricator.wikimedia.org/T97041#1267029 (10Jdforrester-WMF) >>! In T97041#1254766, @Krenair wrote: > What sort of failures are we missing this on? We do show error messages when...
[21:54:01] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 3Editing Department 2014/15 Q4 blockers: Handle load failures more gracefully - https://phabricator.wikimedia.org/T97041#1267031 (10Jdforrester-WMF)
[21:54:44] <Krinkle>	 RoanKattouw: What's the use case for wgRevisionId in the wikitext editor? What is it used for?
[21:54:58] <wikibugs>	 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References, 7Design, 3Editing Department 2014/15 Q4 blockers: Make Citoid extend the new general citation inspector to add an "Automatic" section as the first (default) tab - https://phabricator.wikimedia.org/T97881#1267034 (10Jdforrester-WMF)
[21:55:06] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-References, 7Design, 3Editing Department 2014/15 Q4 blockers: Kill the citation menu and instead off the options as selection palette in an inspector vs. "Re-use" - https://phabricator.wikimedia.org/T97880#1267036 (10Jdforrester-WMF)
[21:55:35] <wikibugs>	 10Citoid, 10VisualEditor, 7Design, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review: Consolidate citation workflow into an inspector - https://phabricator.wikimedia.org/T97390#1267037 (10Jdforrester-WMF)
[21:55:44] <RoanKattouw>	 Krinkle: EventLogging events
[21:55:51] <RoanKattouw>	 (Not a very good justification, I know)
[21:56:19] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-EditingTools, 7Design, 3Editing Department 2014/15 Q4 blockers: [Usability] Consistency between inspector and context menu - https://phabricator.wikimedia.org/T98271#1267042 (10Jdforrester-WMF)
[21:57:12] <Krinkle>	 RoanKattouw: Yeah, from WikiEditor. But that's the point?
[21:57:15] <Krinkle>	 what's*
[21:58:05] <Krinkle>	 bbiab
[21:59:14] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 6Mobile-Web, 3Editing Department 2014/15 Q4 blockers: Mobile VE - cursor remains in place while contents scoll - https://phabricator.wikimedia.org/T92004#1267066 (10Jdforrester-WMF)
[21:59:26] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 6Mobile-Web, 3Editing Department 2014/15 Q4 blockers: Mobile VE - Dropdown menus need larger tap areas - https://phabricator.wikimedia.org/T92010#1267067 (10Jdforrester-WMF)
[22:00:08] <wikibugs>	 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-Links, 3Editing Department 2014/15 Q4 blockers: Link inspector does not close while placing the cursor on the same line (for empty line) and also it shifts the cursor to the left after typ... - https://phabricator.wikimedia.org/T93013#1267069
[22:00:27] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki-Mobile, 7Browser-Support-Apple-Safari, 3Editing Department 2014/15 Q4 blockers: On iOS Safari, opening the software keyboard scrolls the toolbar out of view, and dismissing the keyboa... - https://phabricator.wikimedia.org/T95414#1267071
[22:00:45] <wikibugs>	 10VisualEditor, 10VisualEditor-DataModel, 3Editing Department 2014/15 Q4 blockers, 7Technical-Debt: If a GeneratedContentNode is destroyed before it finished parsing, its promise isn't aborted - https://phabricator.wikimedia.org/T95354#1267083 (10Jdforrester-WMF)
[22:01:28] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 7Browser-Support-Apple-Safari, 3Editing Department 2014/15 Q4 blockers, 7Mobile: Text should remain selected after leaving link dialogue in iOS Safari - https://phabricator.wikimedia.org/T66580#1267086 (10Jdforrester-WMF)
[22:01:45] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki-Links, 3Editing Department 2014/15 Q4 blockers: Typing after closing link inspector - the first letter gets transposed - https://phabricator.wikimedia.org/T91541#1267087 (10Jdforrester-WMF)
[22:01:56] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 10VisualEditor-Performance, 3Editing Department 2014/15 Q4 blockers: Editing a transclusion with many templates hangs the browser - https://phabricator.wikimedia.org/T71799#1267091 (10Jdforrester-WMF)
[22:02:38] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 3Editing Department 2014/15 Q4 blockers: VE should prompt user to log in if they are not logged in and their IP is anononly blocked - https://phabricator.wikimedia.org/T95752#1267095 (10Jdforrester-WMF)
[22:02:46] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 3Editing Department 2014/15 Q4 blockers: VE should prompt user to log in if they are not logged in and their IP is anononly blocked - https://phabricator.wikimedia.org/T95752#1199504 (10Jdforrester-WMF)
[22:03:12] <wikibugs>	 10VisualEditor, 10VisualEditor-EditingTools, 10Parsoid, 3Editing Department 2014/15 Q4 blockers: <code> tags added around closing bracket of an external link - https://phabricator.wikimedia.org/T96064#1267101 (10Jdforrester-WMF)
[22:03:29] <wikibugs>	 10VisualEditor, 10VisualEditor-EditingTools, 10Parsoid, 3Editing Department 2014/15 Q4 blockers: <code> tags added around closing bracket of an external link - https://phabricator.wikimedia.org/T96064#1207464 (10Jdforrester-WMF) How was "the closing bracket" even available to VisualEditor?
[22:03:41] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable, 10Wikimedia-Hackathon-2015, 3Editing Department 2014/15 Q4 blockers: Change how link annotations work (and fix link continuation rendering) - https://phabricator.wikimedia.org/T91285#1267106 (10Jdforrester-WMF)
[22:06:26] <wikibugs>	 10Citoid, 6Services, 3Editing Department 2014/15 Q4 blockers, 7Technical-Debt: Promisify html-metadata - https://phabricator.wikimedia.org/T96363#1267121 (10Jdforrester-WMF)
[22:08:33] <wikibugs>	 10VisualEditor, 10VisualEditor-EditingTools, 10Parsoid, 7Design, 3Editing Department 2014/15 Q4 blockers: Link editor should guard against using interlanguage (rather than interwiki) links - https://phabricator.wikimedia.org/T95850#1267131 (10Jdforrester-WMF)
[22:09:17] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 6Mobile-Web, 3Editing Department 2014/15 Q4 blockers, 7Technical-Debt: Move VisualEditor code from MobileFrontend to VisualEditor - https://phabricator.wikimedia.org/T96186#1267143 (10Jdforrester-WMF)
[22:09:32] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers: VisualEditor Mobile: The tapping on Mobile VE is extremely inconsistent compared to standard - https://phabricator.wikimedia.org/T67413#1267144 (10Jdforrester-WMF)
[22:09:38] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers: VisualEditor Mobile: Cursor appears over the toolbar in iPad Mini and Nexus 7 for Mobile VE - https://phabricator.wikimedia.org/T67325#1267146 (10Jdforrester-WMF)
[22:10:03] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers: VisualEditor Mobile: When the context menu appears in mobile, the button alignment for "Next" and "Page Settings" option at the top right gets a bit lower - https://phabricator.wikimedia.org/T74570#1267148 (10Jdforrester...
[22:10:23] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers: VisualEditor Mobile: Cannot type the reference name inside Re-use existing reference dialog unless select a reference from that dialog - https://phabricator.wikimedia.org/T70824#1267153 (10Jdforrester-WMF)
[22:10:30] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 7Browser-Support-Apple-Safari, 3Editing Department 2014/15 Q4 blockers: VisualEditor Mobile: Text cannot be pasted into link inspector search field from mobile browser - https://phabricator.wikimedia.org/T70018#1267155 (10Jdforrester-WMF)
[22:10:41] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 7Browser-Support-Google-Chrome, 3Editing Department 2014/15 Q4 blockers: VisualEditor Mobile: Tapping on Return while cursor is at the end of a text, deletes that text in Nexus 7 (Android 4.4.2) - https://phabricator.wikimedia.org/T68758#1267157 (10Jdforreste...
[22:10:48] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers: VisualEditor Mobile: Tapping at the end of each link duplicates the preceding link text in Nexus 7 (Android 4.4.2) - https://phabricator.wikimedia.org/T68754#1267159 (10Jdforrester-WMF)
[22:10:55] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers: VisualEditor Mobile: In android, while trying to apply a link on a selected text, strips off the first letter of the text in the link inspector - https://phabricator.wikimedia.org/T70244#1267161 (10Jdforrester-WMF)
[22:11:10] <wikibugs>	 10VisualEditor, 10VisualEditor-CopyPaste, 3Editing Department 2014/15 Q4 blockers: Incorrect pasting of multi lined plain text - https://phabricator.wikimedia.org/T96006#1267163 (10Jdforrester-WMF)
[22:11:18] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki, 10Parsoid, and 2 others: Spaces at the start of a paragraph aren't very obvious - https://phabricator.wikimedia.org/T68628#1267165 (10Jdforrester-WMF)
[22:11:32] <halfak>	 RoanKattouw, I think I got it. 
[22:12:01] <halfak>	 I switched to a new account and the events are coming through just fine.  I'm going to run some global analyses to confirm that the numbers look about right. 
[22:12:27] <halfak>	 I have no idea how my old EpochFail account was somehow making server-side events not fire, but w/e.  I just need to know that it's going to work for newbies. 
[22:13:16] <James_F>	 halfak: Yeah. Very odd, though.
[22:13:53] <James_F>	 halfak: Obviously, if we're good to go on this point, yay, but we really should understand the issue so we can avoid this tripping us up in future (or spoiling the data for some subtle sub-set of users).
[22:14:17] <halfak>	 +1 James_F 
[22:14:34] <halfak>	 I wish these things were easier to dissect. 
[22:14:41] * halfak shakes fists at sampling
[22:14:44] * James_F blames the gods of Internet past.
[22:14:46] <James_F>	 And that. :-)
[22:16:59] <wikibugs>	 10VisualEditor, 10OOjs-UI, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-05-06_(1.26wmf5): PopupWidget placement breaking embedded context item in VE - https://phabricator.wikimedia.org/T98236#1267204 (10Jdforrester-WMF)
[22:17:03] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Links, 7Design, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-05-06_(1.26wmf5): Highlight matching parts of link suggestions - https://phabricator.wikimedia.org/T93697#1267203 (10Jdforrester-WMF)
[22:18:36] <wikibugs>	 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-Links, 10OOjs-UI, 7Design: Please change the "highlight" color in the search results for the link inspector - https://phabricator.wikimedia.org/T98393#1267223 (10Nirzar) Yes, this is an mediawiki theme issue. we can address this.   We...
[22:20:05] <halfak>	 FUn story, we have a couple of 33 character editingSessionIds O.o
[22:20:12] * James_F sighs.
[22:20:52] <James_F>	 There are two problems in computer science: Off by one errors, the halting problem, and the halting problem, and the halting problem.
[22:21:17] <halfak>	 ^ Better version of that joke
[22:26:08] <Krenair>	 halfak, 33 characters..???!
[22:26:14] <Krenair>	 How does that happen?
[22:26:26] <Krenair>	 what type of events?
[22:26:34] <halfak>	 Someone edit the hidden html elements to troll us?
[22:26:39] <Krenair>	 oh, right
[22:26:40] <Krenair>	 probably
[22:26:42] <halfak>	 lol
[22:27:00] * halfak will get them as soon as his query finishes
[22:27:01] <Krenair>	 damn trouble makers
[22:27:10] * Krenair shakes fist
[22:28:13] <halfak>	 It looks like ~1% of back-dance edits have a save attempt, but no ready. 
[22:28:29] <halfak>	 Overall this represents 0.01% of edit sessions.
[22:28:38] <halfak>	 So, it's probably OK. 
[22:28:53] <halfak>	 An even smaller percentage have a save success, but no attempt
[22:29:04] <RoanKattouw>	 That's the other thing
[22:29:30] <RoanKattouw>	 At some point you have to look at the percentages and accept that some (hopefully <<1%) percentage of sessions are just gonna be weird
[22:30:14] <halfak>	 RoanKattouw, +1
[22:30:44] <wikibugs>	 10TemplateData, 6Community-Liaison, 10WMF-Product-Strategy: Please make me a list of commonly used templates in Wikipedia articles - https://phabricator.wikimedia.org/T96323#1267273 (10Rdicerb) Is there a 50% solution within this? Perhaps it's somewhat effective to have a 50% solution than a 0% solution, isn...
[22:31:10] <Krenair>	 yeah
[22:31:17] <Krenair>	 because we let some of it be client-controlled
[22:32:24] <halfak>	 Uh oh.  
[22:32:59] <halfak>	 124/818=15% of save attempts in a back-dance have no ready
[22:33:05] <halfak>	 I was looking at overall sessions
[22:34:01] <halfak>	 When it's a direct edit, that proportion is more like 30% 17774/59240
[22:34:18] <halfak>	 So it looks like ready is a problem with wikitext
[22:34:26] <halfak>	 Could it be people with JS off?
[22:35:10] <RoanKattouw>	 That's possible
[22:35:14] <RoanKattouw>	 Then they'd have no client-side events at all
[22:36:49] <halfak>	 Could be bots too? 
[22:37:15] <halfak>	 I mean, they'd use the API and we wouldn't log that, right?
[22:39:59] <RoanKattouw>	 You would get inits then
[22:40:07] <RoanKattouw>	 And probably no save* events either, hopefully
[22:41:09] <halfak>	 RoanKattouw, we'd get init events for bots?
[22:41:48] <RoanKattouw>	 Sorry
[22:41:52] <RoanKattouw>	 *wouldn't get inits
[22:41:56] <halfak>	 Gotcha.  
[22:42:11] <halfak>	 Krenair, can you confirm that we shouldn't expect to see API edits show up?
[22:42:24] <halfak>	 30% seems like a high proportion for no-js people. 
[22:42:36] <Krenair>	 I'm not 100% confident
[22:43:52] <Krenair>	 It might be possible for API clients to set editingStatsId and get it logged
[22:44:49] <Krenair>	 but otherwise I can't think of any reasons for api users to trigger events
[22:44:53] <halfak>	 Hmm... I think I need someone to look into that for me.  
[22:44:57] <Krenair>	 ways for*
[22:45:17] <halfak>	 It seems that I should file a separate bug for the missing 30% of 'ready'.  Does that sound right?
[22:45:20] <Krenair>	 obviously they don't receive a form, so they shouldn't be triggering any of those hooks
[22:45:40] <halfak>	 Krenair, problem is that I managed to save a few edits without getting a ready. 
[22:45:53] <Krenair>	 and AttemptSave/AttemptSaveAfter hooks check for the parameter being set
[22:46:09] <halfak>	 Oh yeah.  Of course. 
[22:46:21] <halfak>	 So the best explanation we have is no-js
[22:46:31] <halfak>	 For the missing 30% of readys
[22:46:38] <Krenair>	 So unless all of the enwiki bot editors have banded together purely to mess around with me... I doubt it :)
[22:46:55] <Krenair>	 I think so.
[22:47:02] <Krenair>	 But that's still a high percentage.
[22:52:03] <halfak>	 OK.  I'll file a bug.  Maybe someone will have the time to look into it.  
[22:52:13] <halfak>	 But first, let me get those weird 33 char ids. 
[22:52:46] <wikibugs>	 10VisualEditor: [Regression wmf5]Cannot not open VE after switching to Read mode from Edit mode - https://phabricator.wikimedia.org/T98388#1267341 (10Catrope) git bisect blames https://gerrit.wikimedia.org/r/#/c/208507
[23:01:00] <wikibugs>	 10WikiEditor, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review: editSessionID is duplicated in Edit:Schema for Wikitext - https://phabricator.wikimedia.org/T95919#1267368 (10Halfak) I did some more testing here using a new user account and I was unable to reproduce these issues.   (See the same wor...
[23:02:26] <halfak>	 RoanKattouw, I've updated the bug here: https://phabricator.wikimedia.org/T95919
[23:02:31] <halfak>	 Can you take a look and comment?
[23:02:55] <halfak>	 Krenair, I pulled up those 33 char session ids.  They have a weird space in them.  See https://meta.wikimedia.org/wiki/Research_talk:VisualEditor%27s_effect_on_newly_registered_editors/Work_log/2015-05-06#33_char_session_ids
[23:08:27] <grrrit-wm>	 (03PS1) 10Catrope: Follow-up 5c38995bd94f: don't destroy toolbar twice [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/209392 (https://phabricator.wikimedia.org/T98388) 
[23:15:10] <grrrit-wm>	 (03CR) 10Alex Monk: [C: 032] Don't show placeholder references in lists [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/209285 (owner: 10Esanders)
[23:17:30] <grrrit-wm>	 (03Merged) 10jenkins-bot: Don't show placeholder references in lists [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/209285 (owner: 10Esanders)
[23:17:45] <Krenair>	 RoanKattouw, not one else if statement?
[23:18:26] <RoanKattouw>	 Krenair: Right, duh
[23:18:49] <Krenair>	 :P
[23:18:51] <grrrit-wm>	 (03PS2) 10Catrope: Follow-up 5c38995bd94f: don't destroy toolbar twice [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/209392 (https://phabricator.wikimedia.org/T98388) 
[23:20:10] <grrrit-wm>	 (03CR) 10Alex Monk: [C: 032] Follow-up 5c38995bd94f: don't destroy toolbar twice [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/209392 (https://phabricator.wikimedia.org/T98388) (owner: 10Catrope)
[23:24:25] <grrrit-wm>	 (03Merged) 10jenkins-bot: Follow-up 5c38995bd94f: don't destroy toolbar twice [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/209392 (https://phabricator.wikimedia.org/T98388) (owner: 10Catrope)
[23:27:01] <grrrit-wm>	 (03PS1) 10Catrope: Follow-up 5c38995bd94f: don't destroy toolbar twice [extensions/VisualEditor] (wmf/1.26wmf5) - 10https://gerrit.wikimedia.org/r/209397 (https://phabricator.wikimedia.org/T98388) 
[23:27:54] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Follow-up 5c38995bd94f: don't destroy toolbar twice [extensions/VisualEditor] (wmf/1.26wmf5) - 10https://gerrit.wikimedia.org/r/209397 (https://phabricator.wikimedia.org/T98388) (owner: 10Catrope)
[23:30:00] <grrrit-wm>	 (03Merged) 10jenkins-bot: Follow-up 5c38995bd94f: don't destroy toolbar twice [extensions/VisualEditor] (wmf/1.26wmf5) - 10https://gerrit.wikimedia.org/r/209397 (https://phabricator.wikimedia.org/T98388) (owner: 10Catrope)
[23:30:32] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 3Editing Department 2014/15 Q4 blockers, 7Regression, and 2 others: [Regression wmf5] Cannot not open VE after switching to Read mode from Edit mode  - https://phabricator.wikimedia.org/T98388#1267473 (10Jdforrester-WMF) 5Open>3Resolved a:3Catrope
[23:30:38] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 3Editing Department 2014/15 Q4 blockers, 7Regression, and 2 others: [Regression wmf5] Cannot not open VE after switching to Read mode from Edit mode - https://phabricator.wikimedia.org/T98388#1266206 (10Jdforrester-WMF)
[23:44:57] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 3Editing Department 2014/15 Q4 blockers, 7Regression, and 2 others: [Regression wmf5] Cannot not open VE after switching to Read mode from Edit mode - https://phabricator.wikimedia.org/T98388#1267529 (10Ryasmeen) Verified the fix in Betalabs and test2
[23:45:12] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 3Editing Department 2014/15 Q4 blockers, 7Regression, and 3 others: [Regression wmf5] Cannot not open VE after switching to Read mode from Edit mode - https://phabricator.wikimedia.org/T98388#1267530 (10Ryasmeen)
[23:45:17] <Josve05a>	 Quick questions, where can I transalte these to Swedish? I think on tranlsatewiki.net, right? But is there a more specific place I can look? https://usercontent.irccloud-cdn.com/file/nMShLsnF/Screenshot+2015-05-07+at+01.43.42+-+Edited.png
[23:45:41] <Josve05a>	 translate*
[23:45:59] <James_F>	 Josve05a: One second.
[23:46:17] <James_F>	 Josve05a: https://translatewiki.net/w/i.php?title=Special:Translate&group=ext-visualeditor-0-all&language=sv&filter=%21translated&action=translate
[23:46:22] <Josve05a>	 thanks
[23:47:04] <Josve05a>	 Damn, I do not have right to translate those :/
[23:47:22] <James_F>	 Josve05a: I can write them in if you tell me what to say. :-)
[23:47:29] <James_F>	 Josve05a: (Or just ask for translator rights.)
[23:47:38] <Josve05a>	 I should have that...
[23:47:50] <Josve05a>	 Hnag on..I as logged out. Testing loggin in
[23:48:12] <Josve05a>	 There we go :D
[23:49:58] <James_F>	 Aha. Yay.
[23:51:42] <James_F>	 mooeypoo: https://translatewiki.net/w/i.php?title=Special:Translate&group=ext-visualeditor-0-all&language=he&filter=%21translated&action=translate
[23:55:30] <Josve05a>	 Wish I could help out more, but my knowledge of VE is not that great and I don't want to translate anything which might become "bad", so I just  traslated some of those James_F.