[07:42:57] Hi! I've had an interesting issue with VisualEditor on my wiki [07:43:11] Specifically, it mangled some interwiki prefixes without the editor doing anything to cause it [07:43:29] The diff is https://fastlizard4.org/w/index.php?diff=3030&oldid=3029&rcid=4253 ; he only added the line at the end of the diff, everything else was seemingly done by VE's own volition [08:15:01] 10VisualEditor, 6Community-Liaison: Update "Known Problems" page for VE - https://phabricator.wikimedia.org/T94382#1316963 (10Whatamidoing-WMF) 5Open>3Resolved Assuming that any changes to https://www.mediawiki.org/wiki/VisualEditor/Target_browser_matrix don't make the percentage of supported browsers any... [08:49:47] (03CR) 10Sbisson: [C: 032] Explicitly define module position [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/213807 (https://phabricator.wikimedia.org/T97410) (owner: 10Gilles) [08:50:34] (03Merged) 10jenkins-bot: Explicitly define module position [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/213807 (https://phabricator.wikimedia.org/T97410) (owner: 10Gilles) [09:00:14] (03PS1) 10Paladox: Explicitly define module position [extensions/WikiEditor] (wmf/1.26wmf8) - 10https://gerrit.wikimedia.org/r/214310 (https://phabricator.wikimedia.org/T97410) [09:01:08] (03PS62) 10Paladox: WikiEditor: Add svg images [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (https://phabricator.wikimedia.org/T37342) [09:01:21] (03PS26) 10Paladox: Add svg to LESS file [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/195529 (https://phabricator.wikimedia.org/T37342) [09:20:34] (03CR) 10Yurik: "Paladox, please do not rebase so often. Rebase should only be done when it has been a long time, and significant functionality has changed" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/195529 (https://phabricator.wikimedia.org/T37342) (owner: 10Paladox) [10:21:24] (03CR) 10Paladox: "Hi sorry but I rebased it to download for my site since I use the svg images." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/195529 (https://phabricator.wikimedia.org/T37342) (owner: 10Paladox) [10:22:09] (03CR) 10Paladox: "Hi I tested it and it looks ok and better and works on chrome zooming in and out." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/195529 (https://phabricator.wikimedia.org/T37342) (owner: 10Paladox) [10:36:05] 10Citoid, 6Services, 3Editing Department 2014/15 Q4 blockers, 7Technical-Debt: Promisify html-metadata - https://phabricator.wikimedia.org/T96363#1317163 (10Mvolz) @mobrovac, where are we on this one? [10:42:43] (03CR) 10Yurik: "Paladox, if you use it for another site, that's fine - you can rebase right on the site by doing "git rebase master". My point was that th" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/195529 (https://phabricator.wikimedia.org/T37342) (owner: 10Paladox) [11:05:44] (03CR) 10Paladox: "Oh ok should I move this patch to a new one since it has 60+ because I kept rebasing. if it was less patch it would be easer to review." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/195529 (https://phabricator.wikimedia.org/T37342) (owner: 10Paladox) [11:06:10] (03CR) 10Paladox: "That is for the other one." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/195529 (https://phabricator.wikimedia.org/T37342) (owner: 10Paladox) [11:10:57] 10Citoid, 6Services, 3Editing Department 2014/15 Q4 blockers, 7Technical-Debt: Promisify html-metadata - https://phabricator.wikimedia.org/T96363#1317233 (10mobrovac) >>! In T96363#1317163, @Mvolz wrote: > @mobrovac, where are we on this one? I'm happy with it. I added some commits to the PR, so it's bas... [11:15:23] (03CR) 10Yurik: "No, creating yet another patch is not a good solution - keep it as is. Simply try to minimize notifications - for example, there is an ema" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/195529 (https://phabricator.wikimedia.org/T37342) (owner: 10Paladox) [11:32:03] 10VisualEditor, 10VisualEditor-EditingTools: Problems with scrolling in the "Options" dialog make some tooltips drop of the displayed dialog - https://phabricator.wikimedia.org/T100571#1317249 (10Aklapper) [11:38:23] 10VisualEditor: VE ans ISBN numbers: Add empty nowiki tag and introduces unnecessary link to Special - https://phabricator.wikimedia.org/T100646#1317270 (10Magioladitis) 3NEW [11:38:43] 10VisualEditor: VE and ISBN numbers: Adds empty nowiki tag and introduces unnecessary link to Special:BookSources - https://phabricator.wikimedia.org/T100646#1317279 (10Magioladitis) [12:03:02] 10VisualEditor, 6Collaboration-Team, 10Continuous-Integration-Infrastructure, 10Flow, 6Mobile-Web: Create Jenkins builds for Editing across repositories (MobileFrontend, VisualEditor etc) - https://phabricator.wikimedia.org/T90647#1317335 (10hashar) [12:51:34] 10Citoid, 10VisualEditor: Regression: Valid maps data with citoid field/ template data type mismatch causes a js error/ endless pending - https://phabricator.wikimedia.org/T100651#1317393 (10Mvolz) 3NEW [13:52:27] (03Restored) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/163847 (owner: 10Hashar) [13:52:30] (03PS4) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/163847 [13:52:50] (03Restored) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163846 (owner: 10Hashar) [13:52:54] (03PS2) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163846 [13:55:02] 10Cite: Allow readers to mark a sentence/selection as needing a citation - https://phabricator.wikimedia.org/T89578#1317598 (10Mattflaschen) [13:55:26] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/163847 (owner: 10Hashar) [13:55:56] (03CR) 10jenkins-bot: [V: 04-1] Jenkins job validation (DO NOT SUBMIT) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163846 (owner: 10Hashar) [13:56:15] 10VisualEditor: Cannot save page edits due to parsoidserver-http: HTTP 500 in Chinese Wikipedia when using Visual Editor - https://phabricator.wikimedia.org/T100136#1317603 (10Aklapper) Thanks for taking the time to report this! What are exact steps to reproduce the problem, so that anybody else could try? Also... [14:00:54] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163846 (owner: 10Hashar) [14:06:06] hhey i'm struggling to get parsoid working on MW1.25.1 with the REL1_25 branch. loading bar makes it most of the way then freezes. parsoid works as can be seen http://psychonautwiki.org:8142 and console reads "Uncaught TypeError: Cannot read property 'render' of undefined" if this is related [14:06:16] 10VisualEditor: Ve Edit tab not enabled in Wikipedia space? - https://phabricator.wikimedia.org/T100067#1317612 (10Aklapper) I might not understand "Wikipedia space" correctly here. So far I only see links to Sandboxes posted here? :) [14:06:48] i'm using debian so /etc/mediawiki/parsoid/settings.js is configured, and visualeditor appears to be reaching parsoid as logs indicate requests are received [14:07:32] 10VisualEditor: VE and ISBN numbers: Adds empty nowiki tag and introduces unnecessary link to Special:BookSources - https://phabricator.wikimedia.org/T100646#1317616 (10matmarex) I think this happened because you accidentally unlinked the last number of the ISBN, which made the link necessary. In this case this... [14:07:53] 10VisualEditor, 10VisualEditor-ContentEditable, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review: [Regression wmf4] Link continuation is broken - https://phabricator.wikimedia.org/T74108#771051 (10matmarex) [14:07:54] 10VisualEditor: VE and ISBN numbers: Adds empty nowiki tag and introduces unnecessary link to Special:BookSources - https://phabricator.wikimedia.org/T100646#1317618 (10matmarex) [14:09:05] (03PS1) 10Mvolz: Check templateField type [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/214340 (https://phabricator.wikimedia.org/T100651) [14:09:25] (03CR) 10jenkins-bot: [V: 04-1] Check templateField type [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/214340 (https://phabricator.wikimedia.org/T100651) (owner: 10Mvolz) [14:11:36] (03PS2) 10Mvolz: Check templateField type [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/214340 (https://phabricator.wikimedia.org/T100651) [14:18:17] 10Citoid, 10VisualEditor, 5Patch-For-Review: Regression: Valid maps data with citoid field/ template data type mismatch causes a js error/ endless pending - https://phabricator.wikimedia.org/T100651#1317641 (10Mvolz) a:3Mvolz [14:31:49] (03CR) 10Esanders: "review please" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/209695 (owner: 10Esanders) [14:39:16] 10VisualEditor: Ve Edit tab not enabled in Wikipedia space? - https://phabricator.wikimedia.org/T100067#1317670 (10Magioladitis) @Aklapper Try this page then: https://en.wikipedia.org/wiki/Wikipedia:Dead-end_pages I am mainly interested in the sandbox fix though [15:12:14] (03CR) 10Edokter: "Paladox, this is why you need to create branches; each patch lives in it's own branch so they do not need to be rebased when something els" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/195529 (https://phabricator.wikimedia.org/T37342) (owner: 10Paladox) [15:15:54] 10VisualEditor, 7Accessibility, 7Easy: Copyright warning's readability should be improved - https://phabricator.wikimedia.org/T100017#1317811 (10Aklapper) [15:50:59] Hi All, silly question but do you know if VE supports tables now? I haven't upgraded in a fair whack due to other committments but can't find any info on mediawiki (must be looking in the wrong place) [16:01:47] Adamlonsdale: Hi, VE supports tables, yes. You can create a table, add cells and columns. [16:02:05] thanks! Will upgrade tonight [16:11:56] 10VisualEditor: VE and ISBN numbers: Adds empty nowiki tag and introduces unnecessary link to Special:BookSources - https://phabricator.wikimedia.org/T100646#1317952 (10mgrabovsky) Is this really the same bug? Cf. [[ https://en.wikipedia.org/w/index.php?diff=664431956 | this edit ]], where I changed digits insid... [16:19:01] (03Abandoned) 10Marcoil: WIP: T86782: Horrible hack to make the new Cite CSS appear in VE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207487 (owner: 10Marcoil) [16:22:49] 10VisualEditor: Trying to add a paragraph in VE after a template - https://phabricator.wikimedia.org/T100671#1317978 (10Magioladitis) 3NEW [16:30:18] (03PS4) 10Marcoil: T86782: Use Parsoid's new Cite HTML and CSS [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207483 [16:32:20] (03CR) 10jenkins-bot: [V: 04-1] T86782: Use Parsoid's new Cite HTML and CSS [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207483 (owner: 10Marcoil) [16:34:44] (03PS5) 10Marcoil: T86782: Use Parsoid's new Cite HTML and CSS [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207483 [16:37:19] (03CR) 10jenkins-bot: [V: 04-1] T86782: Use Parsoid's new Cite HTML and CSS [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207483 (owner: 10Marcoil) [16:42:20] (03PS6) 10Marcoil: T86782: Use Parsoid's new Cite HTML and CSS [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207483 [16:44:00] (03CR) 10jenkins-bot: [V: 04-1] T86782: Use Parsoid's new Cite HTML and CSS [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207483 (owner: 10Marcoil) [16:44:50] (03PS7) 10Marcoil: T86782: Use Parsoid's new Cite HTML and CSS [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207483 [17:21:59] James_F: Do you know the ticket number for that Tags issue? [17:23:58] guillom: https://phabricator.wikimedia.org/T100439 and https://phabricator.wikimedia.org/T100248 [17:24:11] guillom: Not sure if it really does mean they 'don't show' or if they're not in the DB. [17:24:16] James_F: Thank you! [17:24:27] I'm pretty sure they weren't in the DB [17:24:36] From reading the code that claims to fix it [17:24:42] RoanKattouw: Yeah. :-( [17:24:48] RoanKattouw: And probably no way to back-fill. [17:25:13] Almost certainly not [17:29:13] (03CR) 10Catrope: [C: 032] Use more appropriate RecentChange_save hook for tagging [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/214101 (https://phabricator.wikimedia.org/T100439) (owner: 10Aaron Schulz) [17:30:06] (03PS1) 10Jforrester: Use more appropriate RecentChange_save hook for tagging [extensions/VisualEditor] (wmf/1.26wmf6) - 10https://gerrit.wikimedia.org/r/214385 (https://phabricator.wikimedia.org/T100439) [17:30:14] (03PS1) 10Jforrester: Use more appropriate RecentChange_save hook for tagging [extensions/VisualEditor] (wmf/1.26wmf7) - 10https://gerrit.wikimedia.org/r/214386 (https://phabricator.wikimedia.org/T100439) [17:31:00] (03Merged) 10jenkins-bot: Use more appropriate RecentChange_save hook for tagging [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/214101 (https://phabricator.wikimedia.org/T100439) (owner: 10Aaron Schulz) [17:32:44] (03PS1) 10Jforrester: Use more appropriate RecentChange_save hook for tagging [extensions/VisualEditor] (wmf/1.26wmf8) - 10https://gerrit.wikimedia.org/r/214390 (https://phabricator.wikimedia.org/T100439) [17:32:57] (03CR) 10Jforrester: [C: 032] Use more appropriate RecentChange_save hook for tagging [extensions/VisualEditor] (wmf/1.26wmf6) - 10https://gerrit.wikimedia.org/r/214385 (https://phabricator.wikimedia.org/T100439) (owner: 10Jforrester) [17:33:01] (03CR) 10Jforrester: [C: 032] Use more appropriate RecentChange_save hook for tagging [extensions/VisualEditor] (wmf/1.26wmf8) - 10https://gerrit.wikimedia.org/r/214390 (https://phabricator.wikimedia.org/T100439) (owner: 10Jforrester) [17:33:47] (03CR) 10Jforrester: [C: 032] Use more appropriate RecentChange_save hook for tagging [extensions/VisualEditor] (wmf/1.26wmf7) - 10https://gerrit.wikimedia.org/r/214386 (https://phabricator.wikimedia.org/T100439) (owner: 10Jforrester) [17:37:39] 10Mediawiki-extensions-Graph-VE, 10MediaWiki-API: Add action=parse ability to do recursivePreprocess - https://phabricator.wikimedia.org/T100570#1318227 (10Anomie) As for expanding without additional processing, does action=expandtemplates not do what you want? Why recursivePreprocess() instead of preprocess()... [17:44:18] (03Merged) 10jenkins-bot: Use more appropriate RecentChange_save hook for tagging [extensions/VisualEditor] (wmf/1.26wmf6) - 10https://gerrit.wikimedia.org/r/214385 (https://phabricator.wikimedia.org/T100439) (owner: 10Jforrester) [17:44:39] (03Merged) 10jenkins-bot: Use more appropriate RecentChange_save hook for tagging [extensions/VisualEditor] (wmf/1.26wmf8) - 10https://gerrit.wikimedia.org/r/214390 (https://phabricator.wikimedia.org/T100439) (owner: 10Jforrester) [17:46:27] (03Merged) 10jenkins-bot: Use more appropriate RecentChange_save hook for tagging [extensions/VisualEditor] (wmf/1.26wmf7) - 10https://gerrit.wikimedia.org/r/214386 (https://phabricator.wikimedia.org/T100439) (owner: 10Jforrester) [18:01:26] James_F: You need those wmf* commits deployed now? [18:01:35] RoanKattouw: Krenair's on it. [18:01:47] I uploaded the core updates [18:01:51] for wmf7 and wmf8 [18:02:02] OK [18:02:03] What about 6? [18:02:13] wmf6 is not deployed is it? [18:02:16] I did ask about that [18:02:27] https://noc.wikimedia.org/conf/highlight.php?file=wikiversions.json ctrl+f wmf6 [18:02:36] It's not deployed /now/ [18:02:49] But I hear the cluster has been going back and forth between being 7/8 and 6/7 [18:03:01] 10Citoid, 10VisualEditor, 3Editing Department 2014/15 Q4 blockers: Insertion of tag - https://phabricator.wikimedia.org/T100464#1318303 (10gpaumier) [18:03:07] Just within the last hour I saw a surprised "oh so wmf8 is in prod?" comment in -operations [18:03:08] legoktm, want to go first with your patch for the warnings or can I do the important VE fix? [18:03:24] Krenair: it's not ready yet. still testing it [18:03:28] okay, will do wmf6 after the currently-in-prod ones [18:03:48] labs-ns0 just died :/ [18:06:16] sent the core commits for jenkins merge [18:10:30] wmf6 change also uploaded and +2'd [18:18:02] James_F, fix is on wmf7 (i.e. including enwiki) [18:20:01] (and works) [18:20:56] confirmed on testwiki (wmf8) [18:23:17] wmf6 done too [18:24:01] Krenair: Yay. Thank you so much. [18:26:52] I'm disappearing for dinner now, then back to revision, if something else is needed I can be reached by poking my @wm.o account (e.g. via hangouts or email) [18:28:20] 10VisualEditor, 10MediaWiki-Change-tagging, 10MediaWiki-Recent-changes, 3Editing Department 2014/15 Q4 blockers, and 6 others: Special:RecentChanges does not list tags, filter broken - https://phabricator.wikimedia.org/T100439#1318393 (10Jdforrester-WMF) 5Open>3Resolved a:3aaron [18:28:34] 10VisualEditor, 10MediaWiki-Change-tagging, 10MediaWiki-Recent-changes, 3Editing Department 2014/15 Q4 blockers, and 5 others: Special:RecentChanges does not list tags, filter broken - https://phabricator.wikimedia.org/T100439#1312823 (10Jdforrester-WMF) [18:29:14] 10Mediawiki-extensions-Graph-VE, 10MediaWiki-API: Add action=parse ability to do recursivePreprocess - https://phabricator.wikimedia.org/T100570#1318407 (10ferdbold) Hey guys, any tips on where to get help about working with templates? I agree with you about the module needing to be able to handle template pa... [18:29:19] Krenair: Have fun! [18:52:08] hey i'm struggling to get parsoid working on MW1.25.1 with the REL1_25 branch. loading bar makes it most of the way then freezes. parsoid works as can be seen http://psychonautwiki.org:8142 and console reads "Uncaught TypeError: Cannot read property 'render' of undefined" if this is related [18:52:13] i'm using debian so /etc/mediawiki/parsoid/settings.js is configured, and visualeditor appears to be reaching parsoid as logs indicate requests are received [19:01:02] 10VisualEditor: defeature __NOEDITSECTION__ from VE - https://phabricator.wikimedia.org/T100691#1318523 (10eranroz) 3NEW [19:13:18] 10Mediawiki-extensions-Graph-VE, 10MediaWiki-API: Add action=parse ability to do recursivePreprocess - https://phabricator.wikimedia.org/T100570#1318545 (10Yurik) I don't know exactly why I needed to use the recursive one -- it was suggested by the parser gurus for the see when all template calls need to be ex... [19:33:46] 10Mediawiki-extensions-Graph-VE, 10MediaWiki-API: Add action=parse ability to do recursivePreprocess - https://phabricator.wikimedia.org/T100570#1318594 (10Anomie) >>! In T100570#1318545, @Yurik wrote: > I don't know exactly why I needed to use the recursive one -- it was > suggested by the parser gurus for th... [19:45:46] James_F: when you want to let me know there is a message in VE it would be nice to display the message would it? is this a known bug ? [19:48:26] matanya: On which wiki? [19:48:50] it.wiki [19:50:14] matanya, O already fixed similar problem in he.wiki. This is probably due to: https://it.wikipedia.org/w/index.php?title=MediaWiki:Editnotice-0 [19:50:35] makes sense [20:03:43] 10VisualEditor, 6Community-Liaison, 10Wikimania-Hackathon-2015: VisualEditor translathon at Wikimania Mexico - https://phabricator.wikimedia.org/T91108#1318631 (10Elitre) As a follow-up, Siebrand will support me with the translathon (details TBA), so he and Rachel will let me know about a room ASAP. [20:12:57] o/ James_F [20:13:06] Hey. [20:13:11] I heard there were some issues that may have affected the pilot [20:13:18] Want to chat before the deployment meeting? [20:13:26] Yes! [20:13:28] So. [20:13:56] Late on Friday, a MediaWiki change was emergency-deployed that broke revision tagging. [20:15:01] wouldn't that have been after we disabled the test test? [20:15:14] matanya: known, filed somewhere [20:15:17] This means that from almost exactly 00:00 UTC on Saturday through to early evening UTC (~18:15) today, all edits made with VisualEditor weren't tagged as such. [20:15:35] matanya: https://phabricator.wikimedia.org/T95822 someone should totally do this [20:15:36] Which means that the three day evaluation period is almost entirely tainted by this breakage. [20:16:05] thanks MatmaRex [20:16:09] So my questions are: Do you use the rctags for the evaluation or some other source? Is this a problem? Is it even noticable? [20:16:18] Krenair: 24 hours of starting, not 24 hours of testing. [20:16:37] oh, we're monitoring ve edits by users created during those 24 hours? ok [20:17:16] Do we need to run it again? [20:17:54] Krenair: We're monitoring the first 3-ish days' edits by users who were created during that 24 hours, whether they were VE or not, to detect whether it made a difference to the VE measurements. [20:18:18] eranroz: interested in that ? [20:18:31] As halfak is looking at all edits, this doesn't necessarily break everything. :-) But it might, and it's Aaron's call. [20:19:19] No use of RC tags [20:19:25] OK. [20:19:35] Well, that's a relief. :-) [20:19:39] If this *only* affected RC tags, then I'm not worried. [20:19:42] It did. [20:19:52] Edits saved correctly, no disruption to UX or anything. [20:19:58] Just MW threw the RC tags on the floor. [20:19:59] matanya: no. I think it should be fixed locally by one of the admins in each site [20:20:08] hey guys, I found some invalid Schema:Edit events while looking at a recent alarm [20:20:22] milimetric: Oh dear. VE or WT side? [20:20:27] it looks like action.abort.timing and action.ready.timing are getting passed "null" instead of a number [20:20:52] I think VE is the only one instrumenting the timing [20:21:02] halfak: OK, can you ping the e-mail thread to close that concern out? [20:23:24] James_F, sure, but it seems like we should settle this first. [20:23:33] milimetric, do you know what rate this represents? [20:23:40] And what time period? [20:24:31] not right now. I do know that the rate wasn't significant enough to trip our alarms until just now, and then the alarms recovered in a few minutes [20:24:47] 10Citoid, 10VisualEditor: Evaluate citoid for citations used on Wikimedia sites - https://phabricator.wikimedia.org/T96927#1318699 (10gpaumier) @Elitre: == Russian Wikipedia == {P699} [20:24:53] so halfak: I'm just being cautious but I'll have to parse the logs to know more [20:25:54] however, I just found that action.saveSuccess.timing has the same problem, which means those events are not getting registered either and that's potentially worse [20:26:52] +1 [20:28:45] milimetric: Looking at https://github.com/wikimedia/mediawiki-extensions-VisualEditor/blob/master/modules/ve-mw/init/ve.init.mw.trackSubscriber.js [20:30:41] milimetric: if ( action === 'abort' ) { timing = {} } [20:30:45] James_F: I've gotta jump into a meeting and I'll run the logs through python after [20:30:55] I'll find you % validation problems for the last day or so [20:31:12] sadly, we have no monitoring per schema, so it's possible it's high and it snuck under our overall threshold [20:31:18] milimetric: :-( [20:31:20] Kk. [20:31:40] timing = {} might be a problem, yeah, because we'd want it to just not be included in the payload at all [20:31:50] Hmm. [20:31:51] I'll have to read the code again, I think I found the bug and pointed it out last time [20:31:55] * James_F nods. [20:38:04] 10VisualEditor, 10MediaWiki-Change-tagging, 10MediaWiki-Recent-changes, 3Editing Department 2014/15 Q4 blockers, and 5 others: Special:RecentChanges does not list tags, filter broken - https://phabricator.wikimedia.org/T100439#1318740 (10Jdforrester-WMF) [20:38:22] Even if this validation issues is a high %, we should be able to process the raw logs. I'll wait patiently for milimetric's results. [20:38:32] Luckily, we don't need timing data for this analysis :) [20:38:52] But, logs showing up correctly in the DB seems like a good blocker for the experiment. [20:38:56] :/ [20:41:09] halfak: :-( [20:41:44] halfak: They can't be that many of them, given that this code hasn't changed in weeks. [20:42:22] James_F, +1 fingers crossed -- or not crossed -- whatever is "lucky" [20:57:51] 10Citoid, 10VisualEditor, 10Parsoid, 3Editing Department 2014/15 Q4 blockers: Insertion of tag - https://phabricator.wikimedia.org/T100464#1318796 (10Jdforrester-WMF) [20:59:17] 10Citoid, 10VisualEditor, 10Parsoid, 3Editing Department 2014/15 Q4 blockers: Insertion of tag - https://phabricator.wikimedia.org/T100464#1313348 (10Jdforrester-WMF) Why wouldn't Parsoid convert these tags? They shouldn't have data-parsoid entries (?) so won't be considered original wikitext as ra... [21:08:54] 10Cite, 7Wikimedia-log-errors: Cannot add element to the array as the next element is already occupied - https://phabricator.wikimedia.org/T97052#1318827 (10Jdforrester-WMF) Offending line in Cite_body.php is: $this->mRefs[$group][] = array( 'count' => - 1, 'text' => $str, 'key' => ++$this->mOutCnt ); Not... [21:09:04] 10Cite, 6Editing-Department, 7Wikimedia-log-errors: Cannot add element to the array as the next element is already occupied - https://phabricator.wikimedia.org/T97052#1318828 (10Jdforrester-WMF) [21:12:11] halfak: :-) [21:20:40] halfak, how do you know if something is a VE edit or wikitext edit without the RC tag? [21:21:05] event_logging. [21:21:11] ah, ok. [21:21:49] Generally, I need to take roughly the same measurements regardless of whether the editor was using VE/Wikitext. That helps. [21:22:20] Not comparing VE to Wikitext -- just the world in which VE is enabled by default for new editors against the world in which it is not. [21:22:49] k [21:23:24] ok, so, you have event logging monitoring various aspects of that world, so to speak? [21:23:37] and something in there tells you if the editor is using VE or not. [21:38:25] subbu|afk: yeah, there's an "editor" field in the Schema:Edit and that's populated to 'visualeditor' or 'wikitext'. That's the split that's used by dashboards like this: https://edit-analysis.wmflabs.org/compare/ [21:38:51] I'm out of my meeting now and I'll try to run those log numbers before the next meeting, but I don't think it'll finish, lotta gigibits :) [21:39:11] milimetric: Aha! Because we have 100% of the event logging, we could back-fill the missing RC tags for all the VE edits? [21:43:54] milimetric, thanks for the explanation. :) [21:50:30] yes, James_F, we should be able to fill the RC tags for all saveSuccess events that validated [22:09:00] milimetric: That'd be good, at least. [22:11:52] milimetric: How's the script doing? [22:13:04] James_F: don't think it'll be done before our meeting, I'm not quite sure if it's better to unzip these first or just zcat | my.python.thing.py. Zcat seems to be taking forever [22:14:10] milimetric: :-( [22:14:42] James_F: but I ran some quick checks on the tail of the whole error log [22:15:06] of the last errors in the tail, no matter how far back I went, VE errors were never more than 0.7% [22:15:13] so I think that's a good thing :) [22:15:18] milimetric: Understood. [22:15:21] (Yes. :-)) [22:15:25] we should be fine, I'll just get some solid number [22:15:29] * James_F nods. [22:15:51] I'm more worried about the CPU load on this poor EL machine, it's maxing out from time to time [22:16:28] That's not good. [22:33:52] is there no way to spread the load over to more machines? [22:50:40] RoanKattouw: We're go for the A/B test. [22:50:48] Cool [22:51:18] RoanKattouw: https://wikitech.wikimedia.org/w/index.php?title=Deployments&diff=160968&oldid=160949 [22:51:28] Thanks [22:51:32] Was just about to ask [22:52:48] RoanKattouw: You got the approval 3 seconds after it was granted. :-)