[00:00:24] (03PS1) 10Legoktm: Update mediawiki/codesniffer to 0.2.0 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/215559 [00:01:28] (03PS1) 10Legoktm: Set manifest_version in extension.json [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/215560 (https://phabricator.wikimedia.org/T100745) [00:56:31] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 10MediaWiki-extensions-SpamBlacklist: The external link section in the Link Inspector in VE should refuse links that are blocked by MW:Spam-blacklist - https://phabricator.wikimedia.org/T100201#1332591 (10Legoktm) https://en.wikipedia.org/w/api.php?action=help&... [00:58:31] 10VisualEditor: Opening the link inspector with text selected immediately shows search results for that text, but only the first time - https://phabricator.wikimedia.org/T100533#1332594 (10matmarex) [00:58:32] 10VisualEditor, 10VisualEditor-MediaWiki-Links: Opening the link inspector with text selected should auto-populate search results for that text - https://phabricator.wikimedia.org/T97723#1332595 (10matmarex) [00:58:34] 10VisualEditor, 7Design, 3Editing Department 2014/15 Q4 blockers: [Usability] auto open the results when link tool is used - https://phabricator.wikimedia.org/T101167#1332593 (10matmarex) [00:59:19] 10VisualEditor, 10VisualEditor-MediaWiki-Links: Opening the link inspector with text selected should auto-populate search results for that text - https://phabricator.wikimedia.org/T97723#1250814 (10matmarex) [01:13:42] 10VisualEditor, 6Team-Practices: Make improvements to the VisualEditor team's processes - https://phabricator.wikimedia.org/T101207#1332665 (10Neil_P._Quinn_WMF) [01:27:21] 10VisualEditor, 6Team-Practices: Make improvements to the VisualEditor team's processes - https://phabricator.wikimedia.org/T101207#1332678 (10gpaumier) [02:11:42] 10VisualEditor, 6Team-Practices: Make improvements to the VisualEditor team's processes - https://phabricator.wikimedia.org/T101207#1332698 (10Neil_P._Quinn_WMF) a:5Neil_P._Quinn_WMF>3JAufrecht [02:12:22] 10VisualEditor, 6Team-Practices: Make improvements to the VisualEditor team's processes - https://phabricator.wikimedia.org/T101207#1332658 (10Neil_P._Quinn_WMF) p:5High>3Normal [02:12:44] 10VisualEditor, 6Team-Practices: Publish VisualEditor process report on mediawiki.org - https://phabricator.wikimedia.org/T101209#1332700 (10Neil_P._Quinn_WMF) 3NEW a:3Neil_P._Quinn_WMF [02:13:01] 10VisualEditor, 6Team-Practices: Make improvements to the VisualEditor team's processes - https://phabricator.wikimedia.org/T101207#1332658 (10Neil_P._Quinn_WMF) [02:13:03] 10VisualEditor, 6Team-Practices: Publish VisualEditor process report on mediawiki.org - https://phabricator.wikimedia.org/T101209#1332709 (10Neil_P._Quinn_WMF) [02:19:15] 10VisualEditor, 6Community-Liaison, 7user-notice: Advertise VisualEditor's cool new features to existing editors - https://phabricator.wikimedia.org/T101211#1332730 (10Neil_P._Quinn_WMF) 3NEW a:3Neil_P._Quinn_WMF [02:26:18] 10VisualEditor, 10VisualEditor-ContentEditable: Unable to remove bold and italic formatting from pastes of external sources - https://phabricator.wikimedia.org/T101212#1332739 (10Quiddity) 3NEW [02:36:02] (03CR) 10Jforrester: [C: 032] Set manifest_version in extension.json [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/215560 (https://phabricator.wikimedia.org/T100745) (owner: 10Legoktm) [02:36:11] (03CR) 10Jforrester: [C: 032] Update mediawiki/codesniffer to 0.2.0 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/215559 (owner: 10Legoktm) [02:36:31] (03CR) 10Jforrester: [C: 032] Update mediawiki/codesniffer to 0.2.0 [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/215555 (owner: 10Legoktm) [02:36:42] (03CR) 10Jforrester: [C: 032] Update mediawiki/codesniffer to 0.2.0 [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/215552 (owner: 10Legoktm) [02:38:26] (03Merged) 10jenkins-bot: Update mediawiki/codesniffer to 0.2.0 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/215559 (owner: 10Legoktm) [02:38:28] (03Merged) 10jenkins-bot: Set manifest_version in extension.json [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/215560 (https://phabricator.wikimedia.org/T100745) (owner: 10Legoktm) [02:38:32] (03Merged) 10jenkins-bot: Update mediawiki/codesniffer to 0.2.0 [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/215555 (owner: 10Legoktm) [02:38:36] (03Merged) 10jenkins-bot: Update mediawiki/codesniffer to 0.2.0 [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/215552 (owner: 10Legoktm) [03:46:03] (03PS4) 10Divec: WIP Insertions: heed cursor position relative to annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/215314 (https://phabricator.wikimedia.org/T94062) [03:48:03] (03CR) 10jenkins-bot: [V: 04-1] WIP Insertions: heed cursor position relative to annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/215314 (https://phabricator.wikimedia.org/T94062) (owner: 10Divec) [06:43:30] 10VisualEditor-LanguageTool, 3Google-Summer-of-Code-2015: Community bonding evaluation for Unified language proofing tools integration framework - https://phabricator.wikimedia.org/T97837#1332992 (10NiharikaKohli) @Ankita-ks Any updates on the blog post? Also please get started on the actual coding part now. W... [06:45:45] 10VisualEditor-LanguageTool, 3Google-Summer-of-Code-2015: Community bonding evaluation for Unified language proofing tools integration framework - https://phabricator.wikimedia.org/T97837#1333001 (10Ankita-ks) @NiharikaKohli : Yes, here's the link to the blog : https://ksankita.wordpress.com/ Already working o... [06:46:55] 10VisualEditor-LanguageTool, 3Google-Summer-of-Code-2015: Community bonding evaluation for Unified language proofing tools integration framework - https://phabricator.wikimedia.org/T97837#1333002 (10NiharikaKohli) @Ankita-ks Great! Add the link to the description. [07:37:17] 10VisualEditor-LanguageTool, 3Google-Summer-of-Code-2015: Community bonding evaluation for Unified language proofing tools integration framework - https://phabricator.wikimedia.org/T97837#1333064 (10Ankita-ks) [08:50:20] 10VisualEditor, 6Community-Liaison, 7user-notice: Advertise VisualEditor's cool new features to existing editors - https://phabricator.wikimedia.org/T101211#1333131 (10Whatamidoing-WMF) Does "Table editing" include table creation and importing csv files? [08:55:13] (03PS1) 10Divec: Rename variables to clarify state snapshot timing [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/215583 [08:55:45] (03PS5) 10Divec: WIP Insertions: heed cursor position relative to annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/215314 (https://phabricator.wikimedia.org/T94062) [08:56:04] (03PS1) 10Divec: Prune old unused property [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/215584 [09:12:13] 10VisualEditor: I can't open VisualEditor in Safari 8 on Mac OS 10.10 - https://phabricator.wikimedia.org/T99991#1333186 (10Whatamidoing-WMF) It does appear to be "just me", or more precisely, just Safari on my computer. The behavior persists despite regardless of whether I'm logged in or out, whether I'm in a... [09:37:50] (03CR) 10Esanders: [C: 04-1] WIP Insertions: heed cursor position relative to annotations (033 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/215314 (https://phabricator.wikimedia.org/T94062) (owner: 10Divec) [09:49:46] 10VisualEditor, 10Continuous-Integration-Infrastructure, 6Editing-Department, 5Patch-For-Review, 7Regression: Submodule not being updated in Jenkins jobs - https://phabricator.wikimedia.org/T101105#1333209 (10hashar) I have refreshed all the jobs. Should be fine now. I sent a mail to the qa list to have... [10:02:16] Hi, so there is some progress. the button gets added to the toolbar when I run the code from my browser console. But not when I load the webpage (I am hosting it locally) [10:02:31] this is the code i use : https://gist.github.com/ankita-kumari/370b676b1796a6af1f98 [10:02:41] can anyone help me with this? [10:04:43] 10VisualEditor, 10Continuous-Integration-Infrastructure, 6Editing-Department, 5Patch-For-Review, 7Regression: Submodule not being updated in Jenkins jobs - https://phabricator.wikimedia.org/T101105#1333221 (10hashar) 5Open>3Resolved [10:21:59] (03CR) 10Esanders: [C: 032] Prune old unused property [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/215584 (owner: 10Divec) [10:23:21] edsanders|away, you around by any chance or just +2-and-run? [10:23:26] (03CR) 10Esanders: [C: 032] Rename variables to clarify state snapshot timing [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/215583 (owner: 10Divec) [10:23:42] hi [10:23:53] edsanders|away, thanks for the review for flow DM! [10:24:33] edsanders|away, I answered and was wondering if you saw and have thoughts about this specifically: https://gerrit.wikimedia.org/r/#/c/209166/24/modules/flow/dm/mixins/mw.flow.dm.List.js [10:24:48] (03Merged) 10jenkins-bot: Prune old unused property [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/215584 (owner: 10Divec) [10:25:22] you made a good point, but I am not sure it's better to merge the two objects when we need both order (with the array) and almost exclusively reference by Id. Just want to make sure, though, and it might have gotten lost within the patchsets. [10:25:46] (03Merged) 10jenkins-bot: Rename variables to clarify state snapshot timing [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/215583 (owner: 10Divec) [10:25:55] you can use two stores if they are needed [10:27:23] if the items contain enough data to sort them you could calculate the sorted list on the fly - although if you access it often you may want to keep that cache [10:27:37] Yeah, was wondering if you had any ideas on how to merge it. It can work with both, i just need to make sure it's added/deleted properly for both. [10:28:28] merge? [10:42:29] edsanders|away, as in merge the two objects into one object [10:43:13] Anyhoo, I think there's probably a reason for using two object, but since you raised the objection, I wanted to make sure I'm not missing some trick that can be used here and is better. [10:43:41] edsanders|away, Especially since the dm.List is pretty much based off of (almost a dead copy of) OO.ui.GroupElement, minus the $element and append/prepend stuff. [11:31:53] 10Cite, 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References: Basic reference shouldn't appear in catch-all group - https://phabricator.wikimedia.org/T101130#1333383 (10matmarex) On a wiki with Citoid: {F173700} Non-Citoid behavior is correct. [13:49:02] 10VisualEditor, 3Editing Department 2014/15 Q4 blockers: [Usability] Escape should cancel the link dialog and not link the word using link tool - https://phabricator.wikimedia.org/T101176#1333703 (10Aklapper) (@Nirzar: What's the use of the "[Usability]" prefix added to this task's summary? How is it relevant... [13:57:51] 10VisualEditor, 7Design, 3Editing Department 2014/15 Q4 blockers, 7Tracking: Address usability problems in link inspector [tracking] - https://phabricator.wikimedia.org/T101166#1333719 (10Aklapper) [14:23:16] (03CR) 10Divec: "Done done done" (033 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/215314 (https://phabricator.wikimedia.org/T94062) (owner: 10Divec) [14:26:43] (03PS1) 10Krinkle: VisualEditorDataModule: Use definition summary instead of time tracking [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/215631 (https://phabricator.wikimedia.org/T94074) [14:40:14] 10VisualEditor, 6Collaboration-Team, 10Flow, 10Wikimania-Hackathon-2015, 7Epic: Associate non-body content such as annotations and talk to a location in the article - https://phabricator.wikimedia.org/T89575#1333831 (10Quiddity) [14:41:08] (03PS1) 10Esanders: FindAndRepalceDialog tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/215632 [14:53:09] (03PS6) 10Divec: Insertions: heed cursor position relative to annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/215314 (https://phabricator.wikimedia.org/T94062) [15:10:54] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-Links: VisualEditor: Link inspector should indicate link target when applied via keyboard shortcut - https://phabricator.wikimedia.org/T69446#1333973 (10Krinkle) 5declined>3Resolved a:3Krinkle The current link inspector solved this b... [15:10:56] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-Links, 7Tracking: VisualEditor: Improvements and behaviour changes to the link input widget (tracking) - https://phabricator.wikimedia.org/T50789#1333976 (10Krinkle) [15:11:15] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-Links: VisualEditor: Link inspector should make it easier to change the label - https://phabricator.wikimedia.org/T53438#1333979 (10Krinkle) [15:11:18] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-Links: VisualEditor: Link input widget should have separate inputs for target and display text - https://phabricator.wikimedia.org/T55973#1333980 (10Krinkle) [15:12:03] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Link inspector sets wrong title when clicking suggestion - https://phabricator.wikimedia.org/T70934#1333982 (10Krinkle) [15:12:04] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-Links: VisualEditor: Link inspector ignores selected value - https://phabricator.wikimedia.org/T67343#1333983 (10Krinkle) [15:12:36] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-Links: VisualEditor: Link inspector crashes when inserting link on non-linkable or empty selection - https://phabricator.wikimedia.org/T53404#1333986 (10Krinkle) [15:12:37] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Clicking the hyper link button twice breaks the button. - https://phabricator.wikimedia.org/T53984#1333985 (10Krinkle) [15:13:22] (03PS4) 10Divec: WIP: Zero-width space to avoid empty annotation cursoring bug [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/208355 (https://phabricator.wikimedia.org/T96307) [15:15:13] (03CR) 10jenkins-bot: [V: 04-1] WIP: Zero-width space to avoid empty annotation cursoring bug [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/208355 (https://phabricator.wikimedia.org/T96307) (owner: 10Divec) [15:19:47] 10VisualEditor, 10Analytics, 10Wikimedia-Site-requests, 3Editing Department 2014/15 Q4 blockers, 7database: Backfill rctag data for VisualEditor from 2015-05-23–2015-05-28 - https://phabricator.wikimedia.org/T101270#1334021 (10Jdforrester-WMF) 3NEW [16:18:58] 10VisualEditor, 6Collaboration-Team, 10Flow: Flow: display of templates different from display in wikitext - https://phabricator.wikimedia.org/T100921#1334192 (10DannyH) [16:19:26] btw, oh mighty VE folk, can someone verify about templates; we're creating a graph ve.dm and ve.ce that works with straight-up nodes (for GSoC project) -- if, however, I have a template. Say, {{Graph|type=bar}} etc -- that is a transclusion node. But will it render a graph node underneath it if the graph node is set up properly? It should, right? [16:20:48] As in, transclusion node should be able to render the graph if that's what we defined it as... yes? We shouldn't be doing anything super specific to make graph templates work, we should strictly work on making graph *nodes* work. Am I missing anything? [16:20:50] No it won't [16:20:54] I mean, not in DM [16:20:58] RoanKattouw, uhm, why? [16:21:08] All it'll do is render a preview from the PHP API [16:21:37] So if the template parameters change, it will query the php parser again for the new image? [16:21:38] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers: Make VisualEditor good enough for mobile tablet and phone enablement - https://phabricator.wikimedia.org/T94725#1334205 (10Jdforrester-WMF) [16:21:39] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 6WMF-Design, 3Editing Department 2014/15 Q4 blockers: Provide design guidance for minimal VisualEditor header on phones - https://phabricator.wikimedia.org/T93325#1334206 (10Jdforrester-WMF) [16:21:45] Yeah [16:22:19] You can see this by putting in a template like {{echo|foo}} , messing with the parameters and looking at the network tab [16:22:25] RoanKattouw, that makes sense. I thought it's trying to render an actual node underneath, but that works too. It still means that in the "Have VE display graph nodes" GSoC project, we have nothing to do with templates [16:22:32] plus, graph templates already should work anyways [16:23:00] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 6WMF-Design, 3Editing Department 2014/15 Q4 blockers, 7Epic: Agree a new overall design for VisualEditor on mobile phone-sized devices - https://phabricator.wikimedia.org/T93325#1334211 (10Jdforrester-WMF) [16:23:28] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10MobileFrontend-Feature-requests, 6WMF-Design-Research, and 2 others: Provide VisualEditor regardless of device size - https://phabricator.wikimedia.org/T85630#1334215 (10Jdforrester-WMF) [16:23:31] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers: Make VisualEditor good enough for mobile tablet and phone enablement - https://phabricator.wikimedia.org/T94725#1171139 (10Jdforrester-WMF) [16:23:40] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10MobileFrontend-Feature-requests, 6WMF-Design-Research, and 2 others: Provide VisualEditor regardless of device size - https://phabricator.wikimedia.org/T85630#951148 (10Jdforrester-WMF) [16:23:43] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 6WMF-Design, 3Editing Department 2014/15 Q4 blockers, 7Epic: Agree a new overall design for VisualEditor on mobile phone-sized devices - https://phabricator.wikimedia.org/T93325#1334217 (10Jdforrester-WMF) [16:24:47] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers: Make VisualEditor good enough for mobile tablet and phone enablement - https://phabricator.wikimedia.org/T94725#1334225 (10Jdforrester-WMF) [16:24:49] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10MobileFrontend-Feature-requests, 6WMF-Design-Research, and 2 others: Provide VisualEditor regardless of device size - https://phabricator.wikimedia.org/T85630#951148 (10Jdforrester-WMF) [16:26:30] RoanKattouw, much obliged [16:47:26] Hi, can someone please help me with this? I am trying to add a button to the visualeditor toolbar [16:47:41] ankita-ks, what do you need? [16:47:53] This here is the code I use. it's a template as of now. https://gist.github.com/ankita-kumari/370b676b1796a6af1f98 [16:48:08] but it works when i run it from browser console [16:48:22] and not when I reload the page [16:48:35] mooeypoo : could you help me with this? [16:49:08] ankita-ks, it seems you're missing a couple of properties [16:49:15] where do you want the button to go into? You're missing a group [16:49:26] the main toolbar [16:49:31] alright [16:49:34] i'll add that [16:49:35] I'm looking for an example for you [16:49:45] alright. thank you :) [16:50:34] I don't know if adding it to the main toolbar is advisable (I think VE's trying to minimize that by adding tools to the "More" submenu) but let me see here an example [16:51:25] ankita-ks, also, what kind of tool is thihs? What does it open? A dialog? An inspector? [16:51:51] when done, it should collect all the text and send it to a server [16:52:02] The response from the server has to be displayed [16:52:13] displayed in where? I assume a dialog? [16:52:15] for now the display could be a dialog [16:52:26] okay, so if that's the case, i'd change that to a DialogTool [16:52:30] But later on i plan to annotate the text based on the response [16:52:42] ankita-ks, go by the example of ve.ui.MWMediaDialogTool.js [16:52:59] in modules/ve-mw/ui/tools/ [16:53:14] mooeypoo : okay [16:53:16] found it [16:53:40] ankita-ks, it sounds like you will eventually need a custom Action; that is a tiny bit more complicated, but totally doable. If you want to start just to make sure your tool appears and loads a dialog, though, take a look at the tool I just showed [16:53:48] you can see all the properties there [16:53:53] ve.ui.MWMediaDialogTool.static.group = 'object'; [16:54:03] alright [16:54:09] I will try this first [16:54:17] ankita-ks, notice it's extending ve.ui.DialogTool and not just ve.ui.Tool [16:54:40] oh yes, that it is [16:54:54] what is the group property? [16:55:01] and what are the different groups? [16:55:06] mooeypoo ^ [16:55:10] And I am not too sure you need the updateState like this... no matter what state is updated, that tool is active? [16:55:23] ankita-ks, ooh, uhm, I'm not sure I remember. James_F ? [16:55:43] You need to be disabled if the toolbar is disabled. [16:55:50] E.g. if the focus isn't on that surface. [16:56:15] yeah, the 'onUpdateState' needs to change -- I think you can simply take it off completely, DialogTool has onUpdateState of its own that disables the tool if the ce is not focused IIRC [16:56:42] alright. [16:56:52] Is there anywhere I can read about this? [16:57:05] There does not seem to be much documentation on the subject. [16:57:11] Not much :\ [16:57:30] There's OO.ui.Tool documentation, but I am not sure if there's a VE specific one [16:58:38] Alright [16:58:48] I will make the edits you suggested. [16:58:52] And see if it works [16:58:58] ankita-ks, I have to run to a meeting, but if you wait a few minutes, more VE folks will get on after the Standup meeting [16:59:05] sure [16:59:14] i'll try more in the mean time [16:59:17] thank you :) [17:02:51] No problems. I'm still here to help, but I might be a bit slow to respond -- let me know if you need anything [17:03:27] (03PS1) 10Bartosz Dziewoński: ve.ui.CiteFromIdInspector: Simplify icon sizing [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/215658 [17:03:27] James_F: Do you know where/why there are comments from Tidy in the VE surface? [17:03:30] https://wikitech.wikimedia.org/wiki/RCStream?veaction=edit [17:03:39] "Tidy found serious XHTML errors" (i) [17:03:47] in the middle of the article between two source code sections [17:04:11] I don't think that was there before? [17:04:23] They roundtrip weirdly [17:04:43] 10VisualEditor, 10VisualEditor-MediaWiki: "Web cite" icon badly displayed in 90% zoom - https://phabricator.wikimedia.org/T98677#1334353 (10matmarex) 5Open>3Resolved a:3matmarex I looked at the screenshots again and it looks like the font size in the popup is too large, which leads me to believe this was... [17:04:54] gwicke: subbu: ^ [17:06:32] Krinkle, I don't see it. and why would tidy be involved in parsoid html anyway? [17:06:39] subbu: Exactly. [17:06:51] subbu: Scroll down to the syntax highlight areas [17:07:03] there is a (i) icon there, which represents an HTML comment [17:07:23] ah .. i see it. [17:10:42] Krinkle, i dumped the html, and looking at the encapsulation tags, looks like action=parse on extension output is causing that. [17:11:56] [17:11:57] [17:11:57] [17:13:10] Krinkle, so, I would say the syntaxhighlight extension in wikitech is generating something that Tidy doesn't like. [17:13:19] s/in/on [17:23:06] 10VisualEditor, 7Design, 3Editing Department 2014/15 Q4 blockers, 7Tracking: Address usability problems in link inspector [tracking] - https://phabricator.wikimedia.org/T101166#1334443 (10Nirzar) [17:23:09] 10VisualEditor, 10VisualEditor-MediaWiki-Links: Opening the link inspector with text selected should auto-populate search results for that text - https://phabricator.wikimedia.org/T97723#1334444 (10Nirzar) [17:27:11] mooeypoo : Here is what I use now : https://gist.github.com/ankita-kumari/0eee56059b19e3f34f1d [17:27:31] but even now it does not load on refresh but does on running through browser console [17:27:34] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 6WMF-Design, 3Editing Department 2014/15 Q4 blockers, 7Epic: Agree a new overall design for VisualEditor on mobile phone-sized devices - https://phabricator.wikimedia.org/T93325#1334466 (10Nirzar) [17:34:27] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 6WMF-Design, 3Editing Department 2014/15 Q4 blockers, 7Epic: Agree a new overall design for VisualEditor on mobile phone-sized devices - https://phabricator.wikimedia.org/T93325#1334487 (10matmarex) Possibly related: (mobile-first design elements which we... [17:34:57] ankita-ks, why did you comment out icon? [17:35:32] I have decided upon the image to be used yet [17:35:40] *haven't [17:35:52] ankita-ks, you can use something for now, just to see if it appears in there [17:35:58] alright [17:36:02] chaning that [17:36:08] 10VisualEditor, 3Editing Department 2014/15 Q4 blockers: [Usability] Escape should cancel the link dialog and not link the word using link tool - https://phabricator.wikimedia.org/T101176#1334490 (10Nirzar) Apart from design tag, I was using [usability] in places where the item was identified as usability issu... [17:36:12] ankita-ks, also, the title [17:36:32] not urgent, but you should use the OO.ui.DeferMessage ... thing and i18n it [17:37:21] yes, that i will. I haven't done that bit yet. [17:37:27] So the image does appear [17:37:34] But the problem remains [17:37:39] does not load on refresh [17:37:49] only loads through browser console. [17:37:54] ^ mooeypoo [17:38:07] 10VisualEditor, 7Design, 3Editing Department 2014/15 Q4 blockers, 7Tracking: Address usability problems in link inspector [tracking] - https://phabricator.wikimedia.org/T101166#1334504 (10Jdforrester-WMF) [17:38:10] 10VisualEditor, 3Editing Department 2014/15 Q4 blockers: [Usability] Escape should cancel the link dialog and not link the word using link tool - https://phabricator.wikimedia.org/T101176#1334501 (10Jdforrester-WMF) 5Open>3Resolved a:3Jdforrester-WMF This is now fixed in master (first Esc closes the sear... [17:38:26] So you see the console message but not the tool itself in the toolbar? [17:38:26] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 3Editing Department 2014/15 Q4 blockers: [Usability] Escape should cancel the link dialog and not link the word using link tool - https://phabricator.wikimedia.org/T101176#1334507 (10Jdforrester-WMF) p:5Triage>3Normal a:5Jdforrester-WMF>3Esanders [17:38:58] no. i see the toolbar too [17:39:07] but only when i paste this code in the console [17:39:08] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 3Editing Department 2014/15 Q4 blockers: Opening the link inspector with text selected should auto-populate search results for that text - https://phabricator.wikimedia.org/T97723#1334518 (10Jdforrester-WMF) [17:39:16] 10VisualEditor, 7Design: [Usability] auto open the results when link tool is used - https://phabricator.wikimedia.org/T101167#1334520 (10Jdforrester-WMF) [17:40:07] 10VisualEditor, 10VisualEditor-MediaWiki, 10OOjs-UI, 7Design, 3Editing Department 2014/15 Q4 blockers: Make the save page button flush to the toolbar. - https://phabricator.wikimedia.org/T101165#1334522 (10Jdforrester-WMF) p:5Triage>3Normal [17:40:25] ^ mooey|mtg [17:40:47] ankita-ks, that sounds like your file isn't loading [17:40:53] is it defined in resource loader ? did you add it? [17:41:05] Is this part of an extension or part of VE ? [17:41:19] part of an extension for ve [17:41:31] In the extension, then, you'll need to make sure that file is loading [17:41:32] No i haven't added it to the resourceloader [17:41:49] How do i do that? [17:41:49] that's why it's not loaded :) you have to make sure ResourceLoader loads the file, and then your tool will appear [17:42:42] 10VisualEditor, 7Design, 3Editing Department 2014/15 Q4 blockers: [Usability] convert the auto suggest widget to search widget in link inspector - https://phabricator.wikimedia.org/T101169#1334537 (10Jdforrester-WMF) p:5Triage>3High [17:42:49] 10VisualEditor, 7Design, 3Editing Department 2014/15 Q4 blockers, 7Tracking: Address usability problems in link inspector [tracking] - https://phabricator.wikimedia.org/T101166#1334540 (10Jdforrester-WMF) p:5Triage>3High [17:46:16] 10VisualEditor, 10VisualEditor-CopyPaste, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review: Right-clicking on focusable nodes should not give useless "copy image" options - https://phabricator.wikimedia.org/T98650#1334580 (10Jdforrester-WMF) [17:47:12] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 6WMF-Design, 3Editing Department 2014/15 Q4 blockers, 7Epic: Agree a new overall design for VisualEditor on mobile phone-sized devices - https://phabricator.wikimedia.org/T93325#1334589 (10Nirzar) @matmarex we can keep this task to discuss the wider scope... [17:47:24] 10WikiEditor, 3Editing Department 2014/15 Q4 blockers: editSessionID is duplicated in Edit:Schema for Wikitext - https://phabricator.wikimedia.org/T95919#1334590 (10Jdforrester-WMF) [17:47:30] 10VisualEditor, 10VisualEditor-MediaWiki, 3Editing Department 2014/15 Q4 blockers: [Regression wmf3] Action "switch to source editing" does not activate - https://phabricator.wikimedia.org/T97646#1334591 (10Jdforrester-WMF) [17:50:51] (03CR) 10Trevor Parscal: [C: 032] Allow right click copy on focusable nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/209970 (https://phabricator.wikimedia.org/T98589) (owner: 10Esanders) [17:52:28] 10VisualEditor, 10VisualEditor-CopyPaste, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-06-09_(1.26wmf9): Make it possible to cut and copy focusable nodes using the browser context menu - https://phabricator.wikimedia.org/T98589#1334629 (10Jdforrester-WMF) 5Open>3Resolved a:3Esanders [17:52:41] 10VisualEditor, 10VisualEditor-CopyPaste, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-06-09_(1.26wmf9): Right-clicking on focusable nodes should not give useless "copy image" options - https://phabricator.wikimedia.org/T98650#1334632 (10Jdforrester-WMF) 5Open>3Resolved [17:53:30] (03Merged) 10jenkins-bot: Allow right click copy on focusable nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/209970 (https://phabricator.wikimedia.org/T98589) (owner: 10Esanders) [17:53:53] ankita-ks, I'm in a meeting, so I can't reall yhelp a lot, but here's a link to get you started: http://www.mediawiki.org/wiki/Manual:$wgResourceModules [17:54:14] mooey|mtg : alright. thank you. this should help :) [17:54:27] ankita-ks, if the extension you're working on already exists (if you're expanding an extension) then these should already appear.. otherwise, you'll have to create these in the base file [17:55:21] Alright. I will have to create these then [17:55:52] 10VisualEditor, 7Design, 3Editing Department 2014/15 Q4 blockers: Increase width of link inspector - https://phabricator.wikimedia.org/T101290#1334659 (10Nirzar) 3NEW [17:56:40] (03CR) 10Trevor Parscal: [C: 032] "Please note the potential for additional coverage that James called out" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/215337 (owner: 10Esanders) [17:56:58] 10VisualEditor, 7Design, 3Editing Department 2014/15 Q4 blockers: Increase width of link inspector - https://phabricator.wikimedia.org/T101290#1334666 (10Nirzar) [17:57:36] (03CR) 10Trevor Parscal: [C: 032] Test for DSVFileTransferHandler [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/215519 (owner: 10Esanders) [17:58:01] 10VisualEditor, 7Design, 3Editing Department 2014/15 Q4 blockers: Increase width of link inspector - https://phabricator.wikimedia.org/T101290#1334670 (10Nirzar) p:5Triage>3Low [17:59:22] (03Merged) 10jenkins-bot: Add tests for methods converting click targets to table selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/215337 (owner: 10Esanders) [18:00:01] (03Merged) 10jenkins-bot: Test for DSVFileTransferHandler [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/215519 (owner: 10Esanders) [18:10:20] 10VisualEditor, 6WMF-Design, 6WMF-Design-Research, 3Editing Department 2014/15 Q4 blockers: Emphasize VE's save button for new users by animating the progress bar attached to the bottom of the toolbar - https://phabricator.wikimedia.org/T99274#1334756 (10Jdforrester-WMF) [18:11:51] 10VisualEditor, 6WMF-Design, 6WMF-Design-Research, 3Editing Department 2014/15 Q4 blockers: Emphasize VE's save button by animating the progress bar attached to the bottom of the toolbar - https://phabricator.wikimedia.org/T99274#1334769 (10Neil_P._Quinn_WMF) [18:15:11] 10VisualEditor, 7Design, 3Editing Department 2014/15 Q4 blockers: Increase width of inspectors on desktop - https://phabricator.wikimedia.org/T101290#1334828 (10Jdforrester-WMF) [18:15:21] 10VisualEditor, 6WMF-Design, 6WMF-Design-Research, 3Editing Department 2014/15 Q4 blockers: Emphasize VE's save button by animating the progress bar attached to the bottom of the toolbar - https://phabricator.wikimedia.org/T99274#1334830 (10Neil_P._Quinn_WMF) [18:29:53] 10Cite, 6Collaboration-Team, 10Flow, 6Language-Engineering, and 4 others: Use CSS to style Parsoid's Cite extension output - https://phabricator.wikimedia.org/T86782#1334894 (10ssastry) [20:24:29] (03PS2) 10SuchetaG: Fixing the behaviour of resizable images so that redlinked images, inline and block, can be represented properly [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/213812 [22:29:04] (03CR) 10Esanders: [C: 032] build: Update to full jscs preset [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/215550 (owner: 10Jforrester) [22:30:46] (03CR) 10jenkins-bot: [V: 04-1] build: Update to full jscs preset [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/215550 (owner: 10Jforrester) [23:18:22] (03PS3) 10Jforrester: build: Update to full jscs preset [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/215550 [23:18:52] (03CR) 10Jforrester: [C: 032] "PS3 is a rebase to fix the V-1; +2 per Ed." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/215550 (owner: 10Jforrester) [23:21:23] (03Merged) 10jenkins-bot: build: Update to full jscs preset [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/215550 (owner: 10Jforrester) [23:23:36] (03PS2) 10Jforrester: FindAndRepalceDialog tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/215632 (owner: 10Esanders) [23:23:49] edsanders|away: You there? [23:24:59] edsanders|away: Would you be mad if I made jscs auto-fix things when you did `grunt`? This would mean that fixing jscs failures would be easy, but they would fail in CI with a more mysterious message. [23:26:01] James_F: How about defining something like 'grunt fix' that fixes things, but have that not run by default? [23:26:09] Then things are easy to fix and you don't get confusing failures [23:26:14] RoanKattouw: Meh.e [23:26:16] OK. [23:31:29] (03PS1) 10Jforrester: build: Provide a `grunt fix` task to auto-fix jscs failures [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/215816 [23:33:53] (03PS1) 10Jforrester: build: Provide a `grunt fix` task to auto-fix jscs failures [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/215819 [23:35:12] TrevorParscal: https://integration.wikimedia.org/cover/visualeditor/Chromium%2041.0.2272%20(Ubuntu)/src/ui/tools/index.html Bah. [23:36:00] (03PS3) 10Jforrester: ve.ui.FindAndReplaceDialog: Add unit tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/215632 (owner: 10Esanders) [23:36:04] (03CR) 10jenkins-bot: [V: 04-1] build: Provide a `grunt fix` task to auto-fix jscs failures [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/215819 (owner: 10Jforrester) [23:42:36] (03CR) 10Catrope: [C: 032] build: Provide a `grunt fix` task to auto-fix jscs failures [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/215816 (owner: 10Jforrester) [23:43:04] (03CR) 10Catrope: [C: 04-1] build: Provide a `grunt fix` task to auto-fix jscs failures (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/215819 (owner: 10Jforrester) [23:44:39] (03PS2) 10Jforrester: build: Provide a `grunt fix` task to auto-fix jscs failures [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/215819 [23:45:41] (03Merged) 10jenkins-bot: build: Provide a `grunt fix` task to auto-fix jscs failures [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/215816 (owner: 10Jforrester) [23:45:48] (03PS1) 10Jforrester: Update VE core submodule to master (1440dc0) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/215826 [23:46:42] (03CR) 10jenkins-bot: [V: 04-1] build: Provide a `grunt fix` task to auto-fix jscs failures [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/215819 (owner: 10Jforrester) [23:47:20] (03CR) 10Jforrester: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/215819 (owner: 10Jforrester) [23:47:30] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (1440dc0) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/215826 (owner: 10Jforrester) [23:47:45] (03CR) 10Jforrester: [C: 031] ve.ui.FindAndReplaceDialog: Add unit tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/215632 (owner: 10Esanders)