[00:02:03] (03PS1) 10Jforrester: Update VE core submodule to master (795550c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/215830 [00:02:46] (03Abandoned) 10Jforrester: Update VE core submodule to master (1440dc0) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/215826 (owner: 10Jforrester) [00:04:04] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (795550c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/215830 (owner: 10Jforrester) [00:35:05] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/215819/ and https://gerrit.wikimedia.org/r/#/c/215830/ [00:47:38] (03CR) 10Krinkle: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/215830 (owner: 10Jforrester) [01:05:58] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (795550c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/215830 (owner: 10Jforrester) [01:06:07] (03CR) 10Catrope: [C: 032] build: Provide a `grunt fix` task to auto-fix jscs failures [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/215819 (owner: 10Jforrester) [01:08:20] (03Merged) 10jenkins-bot: Update VE core submodule to master (795550c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/215830 (owner: 10Jforrester) [01:08:22] (03Merged) 10jenkins-bot: build: Provide a `grunt fix` task to auto-fix jscs failures [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/215819 (owner: 10Jforrester) [05:57:05] (03CR) 10Divec: [C: 04-1] "Using a line array to restrict the RegExp engine is sound. The use of substr can be avoided." (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/215632 (owner: 10Esanders) [10:46:40] (03CR) 10Krinkle: [WIP] Check templateField type & add tests (031 comment) [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/214340 (https://phabricator.wikimedia.org/T100651) (owner: 10Mvolz) [11:06:00] (03PS7) 10Divec: Insertions: heed cursor position relative to annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/215314 (https://phabricator.wikimedia.org/T94062) [12:47:56] (03PS4) 10Esanders: FindAndRepalceDialog tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/215632 [13:49:42] (03CR) 10Esanders: [C: 032] Fixing the behaviour of resizable images so that redlinked images, inline and block, can be represented properly [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/213812 (owner: 10SuchetaG) [13:50:14] (03CR) 10Esanders: [C: 032] Insertions: heed cursor position relative to annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/215314 (https://phabricator.wikimedia.org/T94062) (owner: 10Divec) [13:52:20] (03Merged) 10jenkins-bot: Fixing the behaviour of resizable images so that redlinked images, inline and block, can be represented properly [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/213812 (owner: 10SuchetaG) [13:52:52] (03Merged) 10jenkins-bot: Insertions: heed cursor position relative to annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/215314 (https://phabricator.wikimedia.org/T94062) (owner: 10Divec) [14:27:54] (03CR) 10Jforrester: [C: 04-1] FindAndRepalceDialog tests (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/215632 (owner: 10Esanders) [14:28:50] (03PS5) 10Esanders: FindAndReplaceDialog tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/215632 [14:29:03] Whee. [14:29:09] edsanders|away: David now happy with it? [14:29:33] (03CR) 10Esanders: FindAndReplaceDialog tests (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/215632 (owner: 10Esanders) [14:32:06] (03CR) 10Jforrester: [C: 031] FindAndReplaceDialog tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/215632 (owner: 10Esanders) [15:48:40] 10VisualEditor, 6Collaboration-Team, 10Flow: Flow preview doesn't show that interwiki links will disappear if saved without a ":" prefix - https://phabricator.wikimedia.org/T101406#1337806 (10He7d3r) 3NEW [16:14:41] 10VisualEditor, 7Design, 3VisualEditor 2014/15 Q4 blockers: Increase width of inspectors on desktop - https://phabricator.wikimedia.org/T101290#1337879 (10Esanders) Are we running out of space in many examples? At 400 there's a lot of whitespace... [16:15:50] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-Links, 3VisualEditor 2014/15 Q4 blockers: Link inspector does not close while placing the cursor on the same line (for empty line) and also it shifts the cursor to the left after typing th... - https://phabricator.wikimedia.org/T93013#1337882 [16:15:51] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki-Links, 3VisualEditor 2014/15 Q4 blockers: Typing after closing link inspector - the first letter gets transposed - https://phabricator.wikimedia.org/T91541#1337881 (10Esanders) [16:16:20] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki-Links, 3VisualEditor 2014/15 Q4 blockers: Typing after closing link inspector - the first letter gets transposed - https://phabricator.wikimedia.org/T91541#1089714 (10Esanders) This is only possible because of T93013 [16:19:58] 10VisualEditor, 3VisualEditor 2014/15 Q4 blockers: Perform a weekly review of edits made with VisualEditor - https://phabricator.wikimedia.org/T94767#1337892 (10gpaumier) Here's the A/B-test-special requested by James: 2015-06-04: * [[ https://en.wikipedia.org/w/index.php?oldid=665489085#Thu_Jun_04_2015_09:16... [16:20:31] 10VisualEditor, 3VisualEditor 2014/15 Q4 blockers: Perform a weekly review of edits made with VisualEditor - https://phabricator.wikimedia.org/T94767#1337894 (10Jdforrester-WMF) Thank you! [16:21:41] (03CR) 10Divec: [C: 032] FindAndReplaceDialog tests (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/215632 (owner: 10Esanders) [16:24:12] (03Merged) 10jenkins-bot: FindAndReplaceDialog tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/215632 (owner: 10Esanders) [16:38:48] 10VisualEditor, 6Collaboration-Team, 10Flow: Flow preview doesn't show that interwiki links will disappear if saved without a ":" prefix - https://phabricator.wikimedia.org/T101406#1338001 (10Catrope) Is this a bug in VisualEditor, perhaps? Or in Parsoid? Does it happen when editing article pages with VE? [16:56:16] Is there a bug for lack of focus states on buttons in VE? [16:58:36] neilpquinn: By focused state do you mean pressed state? [16:59:00] hah I just found an OOUI bug [16:59:30] RoanKattouw: A bug? In OOUI?! … [17:18:10] RoanKattouw: I mean the state you get when you've tabbed over a button. As seen in https://phabricator.wikimedia.org/M31. [17:20:22] Oh yeah it looks like tabbing onto buttons doesn't work at all? [17:25:26] (03PS1) 10Esanders: Move cursor to end when changing link mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/215937 (https://phabricator.wikimedia.org/T98895) [17:27:54] RoanKattouw: hah, yes, essentially [17:35:21] 10VisualEditor: I can't open VisualEditor in Safari 8 on Mac OS 10.10 - https://phabricator.wikimedia.org/T99991#1338173 (10Whatamidoing-WMF) 5Open>3Resolved a:3Whatamidoing-WMF And today it works on office.wiki. I have no idea what changed, but I'm happy. [17:47:09] 10VisualEditor, 6Collaboration-Team, 10Flow: Flow preview doesn't show that interwiki links will disappear if saved without a ":" prefix - https://phabricator.wikimedia.org/T101406#1338205 (10He7d3r) I can't really test, because I'm getting > TypeError: $trigger.data(...).$dialog is undefined load.php:4:588... [17:49:10] 10VisualEditor, 6Collaboration-Team, 10Flow: Flow preview doesn't show that interwiki links will disappear if saved without a ":" prefix - https://phabricator.wikimedia.org/T101406#1338209 (10Catrope) ``` TypeError: $trigger.data(...).$dialog is undefined load.php:4:588 ``` Ouch, that sounds like a local scr... [17:58:01] 10VisualEditor: Improve awkward handling of link display text ("label") when inserting wiki page, wiki files, or external links - https://phabricator.wikimedia.org/T101417#1338233 (10G.Hagedorn) 3NEW [18:00:35] 10VisualEditor, 6Collaboration-Team, 10Flow: Flow preview doesn't show that interwiki links will disappear if saved without a ":" prefix - https://phabricator.wikimedia.org/T101406#1338254 (10He7d3r) Apparently, that comes from > $trigger.data('callout').$dialog.find('li.cx-campaign-translations').replaceWit... [18:06:48] 10VisualEditor, 6Collaboration-Team, 10Flow: Flow preview doesn't show that interwiki links will disappear if saved without a ":" prefix - https://phabricator.wikimedia.org/T101406#1337806 (10He7d3r) I created {T101421} for that other bug. [18:10:38] 10VisualEditor, 10VisualEditor-EditingTools: Improve awkward handling of link display text ("label") when inserting wiki page, wiki files, or external links - https://phabricator.wikimedia.org/T101417#1338303 (10Aklapper) [18:46:31] 10VisualEditor, 6Community-Liaison: Support VisualEditor rollout with research and analyses - https://phabricator.wikimedia.org/T93394#1338426 (10gpaumier) [18:46:35] 10Citoid, 10VisualEditor: Evaluate citoid for citations used on Wikimedia sites - https://phabricator.wikimedia.org/T96927#1338425 (10gpaumier) 5Open>3Resolved [18:46:47] 10VisualEditor: I can't open VisualEditor in Safari 8 on Mac OS 10.10 - https://phabricator.wikimedia.org/T99991#1338428 (10Neil_P._Quinn_WMF) [18:46:57] Hi [18:47:07] How to integrate VisualEditor with my own MediaWiki project? [19:04:17] tymonr, have you installed the extension and got it working? [19:04:33] Krenair: Nah. I can't find download link :/ [19:04:56] https://www.mediawiki.org/wiki/Extension:VisualEditor#Download [19:44:16] Krenair: ahh.. Thanks [19:47:23] (03PS63) 10Paladox: WikiEditor: Add svg images [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (https://phabricator.wikimedia.org/T37342) [19:48:45] (03CR) 10Paladox: "@Umherirrender please review. This re adds the svg images they have all been tested in chrome, internet explorer and Microsoft edge. Pleas" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (https://phabricator.wikimedia.org/T37342) (owner: 10Paladox) [19:54:44] 10VisualEditor, 6Collaboration-Team: Flow preview doesn't show that interwiki links will disappear if saved without a ":" prefix - https://phabricator.wikimedia.org/T101406#1338663 (10Mattflaschen) [19:54:53] 10VisualEditor: Flow preview doesn't show that interwiki links will disappear if saved without a ":" prefix - https://phabricator.wikimedia.org/T101406#1337806 (10Mattflaschen) [20:04:20] (03CR) 10Umherirrender: "@Paladox: Sorry, I have not enough knowledge about svg to review this patch set" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (https://phabricator.wikimedia.org/T37342) (owner: 10Paladox) [20:20:56] 10VisualEditor: VisualEditor doesn't colon-prefix interwiki links when needed, causing them to become language links - https://phabricator.wikimedia.org/T101406#1338717 (10Catrope) [20:23:19] 10VisualEditor: VisualEditor doesn't colon-prefix interwiki links when needed, causing them to become language links - https://phabricator.wikimedia.org/T101406#1338719 (10Catrope) https://www.mediawiki.org/w/index.php?title=User:Catrope/Sandbox&diff=1666237&oldid=1656914 shows that this only happens when you tr... [20:24:49] (03CR) 10Paladox: "Oh ok." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (https://phabricator.wikimedia.org/T37342) (owner: 10Paladox) [20:25:05] (03CR) 10Paladox: "@TheDJ please review." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (https://phabricator.wikimedia.org/T37342) (owner: 10Paladox) [20:39:32] (03CR) 10Paladox: "@Krinkle please could you review. Comment above will redirect you to website where you can test the svg icons." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (https://phabricator.wikimedia.org/T37342) (owner: 10Paladox) [21:59:18] Hi, I am working on a proof reading extension for visualeditor [21:59:46] I have been trying to add a button to the toolbar. But the button does not load on page refresh [21:59:57] while it does when i run the same code from console [22:00:02] https://github.com/ankita-kumari/VisualEditor-LanguageTool/blob/master/modules/ext.LanguageTool.js [22:00:10] This is the code I have used [22:00:20] Can someone help me with this? [22:02:08] 10VisualEditor, 10VisualEditor-CopyPaste: Cutting text with native "Cut" key removes the text but doesn't put it in the clipboard - https://phabricator.wikimedia.org/T101449#1339153 (10gpaumier) 3NEW [22:03:03] (03CR) 10Trevor Parscal: [C: 032] Move cursor to end when changing link mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/215937 (https://phabricator.wikimedia.org/T98895) (owner: 10Esanders) [22:05:02] (03Merged) 10jenkins-bot: Move cursor to end when changing link mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/215937 (https://phabricator.wikimedia.org/T98895) (owner: 10Esanders) [22:12:48] TrevorParscal : could you help me with this? [22:18:32] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Links, 3VisualEditor 2014/15 Q4 blockers: [Regression wmf6] In Firefox, When the link inspector autoswitches to the external link tab, the cursor is inserted before "http://" - https://phabricator.wikimedia.org/T98895#1339241 (10Jdforrester-... [22:26:16] MatmaRex: https://gerrit.wikimedia.org/r/#/c/200195/ [22:26:26] what are you thoughts about this? [22:27:54] (03CR) 10Trevor Parscal: [C: 032] Make sure reference result menu can wrap [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/211523 (https://phabricator.wikimedia.org/T99267) (owner: 10Alex Monk) [22:28:24] (03CR) 10Trevor Parscal: [C: 032] Fix tabbing to info/delete buttons in template dialogs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/211521 (https://phabricator.wikimedia.org/T97323) (owner: 10Alex Monk) [22:28:55] 10VisualEditor, 10VisualEditor-MediaWiki-References, 3VisualEditor 2014/15 Q4 blockers: Text in VE's re-use citation menu should wrap - https://phabricator.wikimedia.org/T99267#1339304 (10Jdforrester-WMF) 5Open>3Resolved [22:28:57] TrevorParscal: my opinion is that it isn't necessary, but it's not a change for the worse either, so if cscott cared enough to do it, we can merge it [22:29:32] that's very kind of you [22:29:55] heh [22:30:03] (03Merged) 10jenkins-bot: Make sure reference result menu can wrap [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/211523 (https://phabricator.wikimedia.org/T99267) (owner: 10Alex Monk) [22:30:13] cscott: you feel the love? [22:30:29] (03Merged) 10jenkins-bot: Fix tabbing to info/delete buttons in template dialogs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/211521 (https://phabricator.wikimedia.org/T97323) (owner: 10Alex Monk) [22:34:00] 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 3VisualEditor 2014/15 Q4 blockers: Improve tabbing in template dialog - https://phabricator.wikimedia.org/T97323#1339323 (10Jdforrester-WMF) 5Open>3Resolved [22:34:04] 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 3VisualEditor 2014/15 Q4 blockers: Improve tabbing in template dialog - https://phabricator.wikimedia.org/T97323#1239168 (10Jdforrester-WMF) [22:34:47] 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 10OOjs-UI, 5OOjs-UI-next-release, 3VisualEditor 2014/15 Q4 blockers: Heading of template editor is centered; hence most text currently covered by "Apply changes" button in some languages - https://phabricator.wikimedia.org/T76947#1339329 (10Jdforrester-W... [22:34:58] 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 10OOjs-UI, 5OOjs-UI-next-release, 3VisualEditor 2014/15 Q4 blockers: Heading of template editor is centered; hence most text currently covered by "Apply changes" button in some languages - https://phabricator.wikimedia.org/T76947#823411 (10Jdforrester-WM... [22:36:00] 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 10OOjs-UI, 5OOjs-UI-next-release, and 2 others: Heading of template editor is centered; hence most text currently covered by "Apply changes" button in some languages - https://phabricator.wikimedia.org/T76947#1339343 (10matmarex) Worth a #user-notice, I t... [22:36:39] 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 10OOjs-UI, 5OOjs-UI-next-release, and 2 others: Heading of template editor is centered; hence most text currently covered by "Apply changes" button in some languages - https://phabricator.wikimedia.org/T76947#1339345 (10Jdforrester-WMF) >>! In T76947#1339... [22:37:31] 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 10OOjs-UI, 5OOjs-UI-next-release, and 2 others: Heading of template editor is centered; hence most text currently covered by "Apply changes" button in some languages - https://phabricator.wikimedia.org/T76947#1339346 (10matmarex) Well, no, it doesn't chan... [22:38:22] 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 10OOjs-UI, 5OOjs-UI-next-release, and 2 others: Heading of template editor is centered; hence most text currently covered by "Apply changes" button in some languages - https://phabricator.wikimedia.org/T76947#1339347 (10Jdforrester-WMF) The main place peo... [22:40:20] TrevorParscal: https://gerrit.wikimedia.org/r/#/q/status:open+project:oojs/ui+-message:WIP+-label:Code-Review%253C%253D-1,n,z [22:41:21] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 6Mobile-Web, 7Epic, and 2 others: [EPIC] Move VisualEditor code from MobileFrontend to VisualEditor - https://phabricator.wikimedia.org/T96186#1339360 (10Tgr) [22:44:24] 10VisualEditor, 7Epic: [EPIC] Make improvements to the VisualEditor team's processes - https://phabricator.wikimedia.org/T101207#1339381 (10JAufrecht) [22:45:43] jaufrecht: Could we avoid putting "[EPIC]" in the title of tasks? [22:47:56] jaufrecht: possibly we should just use the epic tag/project instead? [22:50:30] I did both, but don't feel strongly about the specifics. What's the objection to [EPIC] in the title? [22:51:01] jaufrecht: It's ugly and non-standard. [22:51:42] 10VisualEditor, 7Epic: Make improvements to the VisualEditor team's processes - https://phabricator.wikimedia.org/T101207#1339411 (10JAufrecht) [22:51:57] jaufrecht: We have 24 epics, and that was the only one with "EPIC" in the title: https://phabricator.wikimedia.org/maniphest/query/1nVxm5bzmrQX/#R [22:52:11] jaufrecht: Thanks. [22:52:49] one of our top recommendations is going to be around handling Epics in the backlog, but I don't know what exactly the fix is going to be. [22:53:05] * James_F nods. [22:54:10] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Reconsider template tool tabbing behaviour to go to the next field (not the info or remove buttons) - https://phabricator.wikimedia.org/T70768#1339419 (10Neil_P._Quinn_WMF) 5Open>3Resolved [22:57:00] 10VisualEditor, 7Epic: Make improvements to the VisualEditor team's processes - https://phabricator.wikimedia.org/T101207#1339424 (10JAufrecht) [22:58:24] 10VisualEditor: Finalize pre-solutions draft of report - https://phabricator.wikimedia.org/T101458#1339426 (10JAufrecht) 3NEW a:3JAufrecht [22:59:53] 10VisualEditor: Finish sharable draft of suggested process changes - https://phabricator.wikimedia.org/T101459#1339435 (10JAufrecht) 3NEW a:3JAufrecht [23:00:05] 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 3VisualEditor 2014/15 Q4 blockers: Improve tabbing in template dialog - https://phabricator.wikimedia.org/T97323#1339442 (10Neil_P._Quinn_WMF) @Krenair, I just tried this out on the beta cluster, and now the tabbing goes straight from one parameter field to... [23:01:08] 10VisualEditor: Finalize pre-solutions draft of report - https://phabricator.wikimedia.org/T101458#1339452 (10JAufrecht) [23:02:05] 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 3VisualEditor 2014/15 Q4 blockers, 5WMF-deploy-2015-06-09_(1.26wmf9): Improve tabbing in template dialog - https://phabricator.wikimedia.org/T97323#1339456 (10Krenair) Works for me... [23:09:07] (03CR) 10Bartosz Dziewoński: [C: 032] Account for MWTitleInputWidget having been moved into MW core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/213561 (owner: 10Catrope) [23:10:14] MatmaRex: Thanks. :-) [23:11:03] (03Merged) 10jenkins-bot: Account for MWTitleInputWidget having been moved into MW core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/213561 (owner: 10Catrope) [23:19:52] 10VisualEditor, 10UI-Standardization: Save dialog should use OOJS-UI (MW-UI) checkboxes - https://phabricator.wikimedia.org/T86617#1339504 (10Mattflaschen) Maybe it could use OO.ui.infuse (with some custom code to transform it pre-infuse if needed)? [23:20:02] 10VisualEditor, 10UI-Standardization: Save dialog should use OOJS-UI checkboxes - https://phabricator.wikimedia.org/T86617#1339505 (10Mattflaschen) [23:22:31] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Reconsider template tool tabbing behaviour to go to the next field (not the info or remove buttons) - https://phabricator.wikimedia.org/T70768#1339518 (10Neil_P._Quinn_WMF) 5Resolved>3declined [23:23:47] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 6Mobile-Web, 7Epic, and 2 others: [EPIC] Move VisualEditor code from MobileFrontend to VisualEditor - https://phabricator.wikimedia.org/T96186#1339528 (10Jdlrobson) [23:29:34] 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 3VisualEditor 2014/15 Q4 blockers, 5WMF-deploy-2015-06-09_(1.26wmf9): Improve tabbing in template dialog - https://phabricator.wikimedia.org/T97323#1339557 (10Neil_P._Quinn_WMF) @Krenair, ah, I see. It works as expected on Chrome and Safari, but not in Fi... [23:37:31] 10VisualEditor, 10VisualEditor-EditingTools, 7Accessibility: In Firefox, tabbing in the template dialog skips parameter actions - https://phabricator.wikimedia.org/T101466#1339623 (10Neil_P._Quinn_WMF) 3NEW [23:38:16] (03PS1) 10Esanders: Restrict 'fullscreen' mode to success 'result' panel [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/216006 [23:42:53] (03PS2) 10Jforrester: Restrict 'fullscreen' mode to success 'result' panel [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/216006 (https://phabricator.wikimedia.org/T98715) (owner: 10Esanders) [23:43:01] (03CR) 10Jforrester: [C: 032] Restrict 'fullscreen' mode to success 'result' panel [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/216006 (https://phabricator.wikimedia.org/T98715) (owner: 10Esanders) [23:43:11] (03CR) 10Bartosz Dziewoński: "There was a bug for this somewhere." [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/216006 (https://phabricator.wikimedia.org/T98715) (owner: 10Esanders) [23:43:23] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki, 3VisualEditor 2014/15 Q4 blockers: Behavior of "Automatic" citation when bad input is provided is confusing - https://phabricator.wikimedia.org/T98715#1339658 (10Jdforrester-WMF) 5Open>3Resolved a:3Esanders [23:43:48] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki, 3VisualEditor 2014/15 Q4 blockers: Behavior of "Automatic" citation when bad input is provided is confusing - https://phabricator.wikimedia.org/T98715#1275334 (10Jdforrester-WMF) [23:46:56] Hi, i have been stuck at this problem for a long time now. :| but could you please let me know where am i going wrong. [23:47:16] I am trying to develop this extension for VisualEditor. [23:47:27] And the button does not get added to the toolbar [23:47:33] 10VisualEditor, 6Community-Liaison, 10Wikimedia-Site-requests, 7Epic, and 5 others: Run test of having VisualEditor on for some newly-created accounts on the English Wikipedia - https://phabricator.wikimedia.org/T90666#1339702 (10Jdforrester-WMF) Test continues with data collection and then analysis, but t... [23:47:36] and i can't figure our why [23:47:52] https://github.com/ankita-kumari/VisualEditor-LanguageTool [23:47:59] This is where the code is. [23:48:05] it works from the console. [23:48:18] i would really appreciate any help on this [23:48:25] I have been stuck for way too long. :| [23:48:55] TrevorParscal , sucheta : do you have any pointers? [23:50:06] (03Merged) 10jenkins-bot: Restrict 'fullscreen' mode to success 'result' panel [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/216006 (https://phabricator.wikimedia.org/T98715) (owner: 10Esanders) [23:50:23] Hmm [23:50:33] ankita-ks: You say it works from the console, what do you mean by that exactly? [23:50:40] If you run the code from the console, the button is added? [23:50:59] when i paste this in the browser console : https://github.com/ankita-kumari/VisualEditor-LanguageTool/blob/master/modules/ext.LanguageTool.js [23:51:03] Right [23:51:05] the button does get added [23:51:13] yes [23:51:15] OK I think I found the problem [23:51:22] what is it? [23:51:28] LanguageTool.php needs $wgVisualEditorPluginModules[] = 'ext.languageTool.foo'; [23:51:48] what does that option mean? [23:52:27] ^ RoanKattouw [23:52:33] "when VisualEditor loads, also load this module" [23:53:00] Adding a module to $wgResourceModules doesn't mean the .js files get loaded, it just says "this collection of files [this module] is called ext.languageTool.foo" [23:53:14] It won't be loaded unless you tell something "load ext.languageTool.foo" [23:53:30] So that line tells VisualEditor that it should load ext.languageTool.foo when it loads itself [23:53:44] ah okay [23:53:46] alright [23:53:50] it does work now [23:53:54] Awesome [23:53:54] thank you very much [23:53:57] :) [23:54:01] Sorry you had to be stuck on that for so long [23:54:17] At least it works now. So that's okay :) [23:54:29] A lot of people have been away from their usual timezones recently [23:55:12] I understand. Amir (my mentor) has been travelling a lot lately too [23:55:47] Right [23:56:05] Yeah that sounds right, we moved a meeting that was supposed to be today because Amir was traveling [23:57:00] yup