[00:00:10] 10VisualEditor: Publish VisualEditor process report on mediawiki.org - https://phabricator.wikimedia.org/T101209#1339769 (10Neil_P._Quinn_WMF) [00:00:11] 10VisualEditor: Finalize pre-solutions draft of report - https://phabricator.wikimedia.org/T101458#1339770 (10Neil_P._Quinn_WMF) [00:16:59] 10VisualEditor, 10VisualEditor-ContentEditable: VisualEditor: Pasting in text containing a tab character causes VE to scroll to the top - https://phabricator.wikimedia.org/T74390#1339827 (10Neil_P._Quinn_WMF) Seems to work for me on En.wiki. Reopen if necessary. [00:17:37] 10VisualEditor, 10VisualEditor-ContentEditable: VisualEditor: Pasting in text containing a tab character causes VE to scroll to the top - https://phabricator.wikimedia.org/T74390#1339828 (10Neil_P._Quinn_WMF) 5Open>3Resolved [00:18:43] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki, 3VisualEditor 2014/15 Q4 blockers, 5WMF-deploy-2015-06-09_(1.26wmf9): Behavior of "Automatic" citation when bad input is provided is confusing - https://phabricator.wikimedia.org/T98715#1339829 (10matmarex) 5Resolved>3Open Not all fixed yet; this pa... [00:51:14] 10VisualEditor, 10VisualEditor-CopyPaste: When a partial table is pasted into VE, separate cell contents with spaces - https://phabricator.wikimedia.org/T101478#1339952 (10Neil_P._Quinn_WMF) 3NEW [01:03:02] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-Tables: When a partial table is pasted into VE, separate cell contents with spaces - https://phabricator.wikimedia.org/T101478#1340013 (10Neil_P._Quinn_WMF) [01:13:47] 10VisualEditor, 7I18n: reconsider the terminology around citations, references and footnotes in VisualEditor - https://phabricator.wikimedia.org/T85679#1340023 (10Neil_P._Quinn_WMF) p:5Low>3Lowest [01:14:21] 10VisualEditor, 7I18n: Reconsider the terminology around citations, references and footnotes in VisualEditor - https://phabricator.wikimedia.org/T85679#1340025 (10Neil_P._Quinn_WMF) [01:20:14] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-extensions-GuidedTour, 7Design, and 5 others: Create a guided tour for VisualEditor using GuidedTour guiders - https://phabricator.wikimedia.org/T89074#1340033 (10Neil_P._Quinn_WMF) For information: @Mattflaschen spent a long time (weeks, from what I'm... [01:29:07] 10VisualEditor: Improve and streamline VisualEditor's user education features - https://phabricator.wikimedia.org/T101481#1340043 (10Neil_P._Quinn_WMF) 3NEW a:3Neil_P._Quinn_WMF [01:30:29] 10VisualEditor: Harmonize some warning messages - https://phabricator.wikimedia.org/T99963#1340053 (10Neil_P._Quinn_WMF) [01:30:30] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-extensions-GuidedTour, 7Design, and 5 others: Create a guided tour for VisualEditor using GuidedTour guiders - https://phabricator.wikimedia.org/T89074#1340052 (10Neil_P._Quinn_WMF) [01:30:34] 10VisualEditor, 10VisualEditor-MediaWiki-Links: Remove tooltips from search results in the link inspector - https://phabricator.wikimedia.org/T99312#1340054 (10Neil_P._Quinn_WMF) [01:30:36] 10VisualEditor, 10WikiEditor, 6WMF-Design-Research: Tooltip text on the "Edit" and "Edit Source" tabs should be more helpful to new users - https://phabricator.wikimedia.org/T99271#1340055 (10Neil_P._Quinn_WMF) [01:30:40] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Show a message explaining how to edit references when reflist is selected - https://phabricator.wikimedia.org/T54736#1340056 (10Neil_P._Quinn_WMF) [01:30:42] 10VisualEditor: Improve and streamline VisualEditor's user education features - https://phabricator.wikimedia.org/T101481#1340051 (10Neil_P._Quinn_WMF) [01:32:34] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-extensions-GuidedTour, 7Design, and 5 others: Offer new users of VisualEditor a short guided tour - https://phabricator.wikimedia.org/T89074#1340061 (10Neil_P._Quinn_WMF) a:5KHammerstein>3None [01:33:27] 10VisualEditor, 6WMF-Design-Research, 7Epic: Improve and streamline VisualEditor's user education features - https://phabricator.wikimedia.org/T101481#1340063 (10Neil_P._Quinn_WMF) [01:33:55] 10VisualEditor, 6WMF-Design-Research, 7Epic: Improve and streamline VisualEditor's user education features - https://phabricator.wikimedia.org/T101481#1340043 (10Neil_P._Quinn_WMF) [01:37:21] 10VisualEditor: Help VisualEditor users find the wikitext "Save" button - https://phabricator.wikimedia.org/T90864#1340074 (10Neil_P._Quinn_WMF) [01:37:22] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-extensions-GuidedTour, 7Design, 3VisualEditor 2014/15 Q4 blockers: Change Welcome dialogue content to more helpful message to new users based on the GuidedTour - https://phabricator.wikimedia.org/T89072#1340073 (10Neil_P._Quinn_WMF) [01:37:26] 10VisualEditor, 6Community-Liaison, 7Documentation: Check and update VE Documentation - https://phabricator.wikimedia.org/T96237#1340071 (10Neil_P._Quinn_WMF) [01:37:28] 10Citoid, 10VisualEditor, 6Community-Liaison: Update Help:VisualEditor/User_guide#Editing_references at mediawiki.org - https://phabricator.wikimedia.org/T94938#1340072 (10Neil_P._Quinn_WMF) [01:37:30] 10VisualEditor, 6WMF-Design-Research, 7Epic: Improve and streamline VisualEditor's user education features - https://phabricator.wikimedia.org/T101481#1340070 (10Neil_P._Quinn_WMF) [01:37:34] 10VisualEditor, 10VisualEditor-InterfaceLanguage, 10VisualEditor-MediaWiki, 7I18n: VisualEditor: As much as possible, the link to the user manual should lead directly to a manual in the user's language - https://phabricator.wikimedia.org/T53797#1340075 (10Neil_P._Quinn_WMF) [01:49:03] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: VisualEditor not available on Samsung Galaxy Tablet 4 8.0, If using Wikipedia's desktop site in Firefox - https://phabricator.wikimedia.org/T101483#1340117 (10Whatamidoing-WMF) [03:11:19] 10VisualEditor, 6Community-Liaison, 7Documentation: Check and update VE Documentation - https://phabricator.wikimedia.org/T96237#1340226 (10Whatamidoing-WMF) This is not really the sort of task that gets "finished". It's ongoing maintenance. Every time the design changes or a new feature is added, then thi... [04:25:42] 10VisualEditor, 10MediaWiki-Change-tagging, 10MediaWiki-Recent-changes, 7Regression, and 3 others: Special:RecentChanges does not list tags, filter broken - https://phabricator.wikimedia.org/T100439#1340288 (10KartikMistry) 5Resolved>3Open //contenttranslation// tag still not working. See: https://es.w... [06:08:01] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-extensions-GuidedTour, 7Design, and 5 others: Offer new users of VisualEditor a short guided tour - https://phabricator.wikimedia.org/T89074#1340355 (10Mattflaschen) a:3Mattflaschen >>! In T89074#1340033, @Neil_P._Quinn_WMF wrote: > For information: @... [06:23:23] 10Cite, 5Patch-For-Review: Error introduced in recent #tag:ref change, breaks nested refs in enwp - https://phabricator.wikimedia.org/T100477#1340361 (10Rwessel) New here, apologies in advance for not getting things right... There are a couple of referencing errors on "C (programming language)" on enwiki that... [06:51:42] 10Mediawiki-extensions-Graph-VE: Community bonding evaluation for "Enable VisualEditor support in Graph extension" - https://phabricator.wikimedia.org/T97502#1340378 (10NiharikaKohli) @Mooeypoo, @mvolz ping ping! [06:55:47] 10Mediawiki-extensions-Graph-VE: Community bonding evaluation for "Enable VisualEditor support in Graph extension" - https://phabricator.wikimedia.org/T97502#1340383 (10Mvolz) LGTM :). Resolved? [07:02:27] 10Mediawiki-extensions-Graph-VE, 10VisualEditor, 10Graph, 10Parsoid, and 2 others: Graph editing in VisualEditor - https://phabricator.wikimedia.org/T89287#1340389 (10NiharikaKohli) [07:02:32] 10Mediawiki-extensions-Graph-VE: Community bonding evaluation for "Enable VisualEditor support in Graph extension" - https://phabricator.wikimedia.org/T97502#1340386 (10NiharikaKohli) 5Open>3Resolved Good work, @ferdbold. [07:10:23] 10VisualEditor, 10MediaWiki-Change-tagging, 10MediaWiki-Recent-changes, 7Regression, and 3 others: Special:RecentChanges does not list tags, filter broken - https://phabricator.wikimedia.org/T100439#1340394 (10Pginer-WMF) HHVM is not working either: https://es.wikipedia.org/w/index.php?title=Especial:Cambi... [07:28:52] 10VisualEditor, 10VisualEditor-MediaWiki-Templates: Template followed by comment: No comment icon shown; text inserted between template and comment, no way to insert text after comment - https://phabricator.wikimedia.org/T89101#1340422 (10Whatamidoing-WMF) I can't reproduce this in Safari 8. Is this still a p... [07:30:07] hi, can anyone explain what the 'group' parameter signifies in the tools. For instance : ve.ui.BoldAnnotationTool.static.group = 'textStyle'; [07:30:26] what kind of different group options exist? [07:30:46] also, what determines the position of a tool button on toolbar [07:31:25] For instance when I add a button, it goes into Insert > LanguageTool (LanguageTool being the button I want to add) [07:31:40] What if I wanted the button to display on the main toolbar? [07:31:50] 10VisualEditor: Hidden HTML comment appears to be part of the template's name, when the template is selected - https://phabricator.wikimedia.org/T101493#1340423 (10Whatamidoing-WMF) 3NEW [07:31:52] Krinkle , mvolz ^ [07:43:44] mooeypoo : hi, it works now. [07:44:03] the extension button i was trying to add to the toolbar [07:44:20] But how can i display it on the main toolbar [07:44:34] right now it appears as Insert > LanguageTool [07:46:02] ankita-ks, I am not sure [07:46:13] I think that the main toolbar has a different configuration [07:46:21] okay [07:46:43] Can you tell me how does the group option work> [07:46:46] *? [07:47:02] eg : ve.ui.BoldAnnotationTool.static.group = 'textStyle'; [07:47:12] Are there some predefined groups [07:47:17] or can we create new ones? [07:48:23] ^ mooeypoo [07:51:15] The groups are predefined. I'm sure you can create a new group, but i have to admit I don't know how [07:51:23] you should probably talk to TrevorParscal about this [07:51:49] As for putting the button in the main toolbar, try to see how the new character tool does it, maybe? [07:52:20] "specialcharacter" [07:54:04] Hang on, I'm checking for you [07:54:39] ankita-ks, the way the Cite tool does it is it creates its own group [07:54:42] try that? [07:55:16] okay [07:55:21] looking into it [07:55:39] is there any documentation for toolbar available anywhere? [07:57:45] heh, I am not sure [07:57:51] I think there was a talk about changing some of it [07:58:03] ankita-ks, your best bet with this is to talk to TrevorParscal and MatmaRex [07:58:16] They know the toolbar best. [07:58:35] okay. I will ping them when they are around. [07:58:42] thank you for helping me out :) [07:58:54] I think that you need to set up your own group and then also add the group definition to the toolbar definition in ve.init [07:59:00] but I am not 100% sure, so I don't want to confuse you [07:59:08] no problems :) [08:06:44] mooeypoo : okay. let me find out how to do that. Looking at Cite for now [08:07:31] Be careful with Cite, though, as it does have some weird conditional code that rebuilds the original toolbar definition [08:07:39] but the tool *itself* should be okay [08:11:28] alright. :) [09:18:20] 10Citoid: Automated archiving of URLs - https://phabricator.wikimedia.org/T89438#1340574 (10Qgil) As seen in the Wikimedia Blog: **[[ https://blog.wikimedia.org/2015/06/01/preserving-wikipedia-citations/ | Preserving Wikipedia citations for the future: Geoffrey Bilder ]]** [10:23:17] 10VisualEditor, 10VisualEditor-Performance, 10Parsoid, 10RESTBase, 7RESTBase-API: RFC: API for retrieval and saving of top-level HTML elements / sections by element ID - https://phabricator.wikimedia.org/T94890#1175324 (10mobrovac) [10:46:57] (03PS1) 10Divec: At empty matches, don't assume lastIndex is unchanged [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/216061 [10:59:23] (03CR) 10Esanders: [C: 032] At empty matches, don't assume lastIndex is unchanged [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/216061 (owner: 10Divec) [10:59:25] (03CR) 10Divec: "I can't think of a simple way to unit test this code (i.e. short of coding up something with Object.defineProperty). It doesn't necessaril" (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/216061 (owner: 10Divec) [11:01:50] (03Merged) 10jenkins-bot: At empty matches, don't assume lastIndex is unchanged [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/216061 (owner: 10Divec) [12:23:01] 10Cite, 10MediaWiki-Interface, 10MediaWiki-Parser, 7Regression: Source of ref-tag is visable in ToC - https://phabricator.wikimedia.org/T101509#1340907 (10matmarex) [12:36:32] 10Cite, 10MediaWiki-Interface, 10MediaWiki-Parser, 7Regression: in section headings shown as raw text in TOC - https://phabricator.wikimedia.org/T101390#1340953 (10Aklapper) [12:36:39] 10Cite, 10MediaWiki-Interface, 10MediaWiki-Parser, 7Regression: in section headings shown as raw text in TOC - https://phabricator.wikimedia.org/T101390#1337363 (10Aklapper) [12:36:41] 10Cite, 10MediaWiki-Interface, 10MediaWiki-Parser, 7Regression: Source of ref-tag is visable in ToC - https://phabricator.wikimedia.org/T101509#1340956 (10Aklapper) [12:37:11] 10VisualEditor, 6Community-Liaison, 10Wikimania-Hackathon-2015: VisualEditor translathon at Wikimania Mexico - https://phabricator.wikimedia.org/T91108#1340959 (10Elitre) @Rfarrand, thanks a lot for your answer. Announcements about the translathon will be made way before the hackathon starts, which means I w... [12:38:43] 10Cite, 10MediaWiki-Interface, 10MediaWiki-Parser, 7Regression: Source of ref-tag is visable in ToC - https://phabricator.wikimedia.org/T101509#1340962 (10Aklapper) This particular problem has already been reported into our bug tracking system as T101390, but please feel free to report any further issues y... [12:47:38] 10VisualEditor, 6Community-Liaison, 10Wikimania-Hackathon-2015: VisualEditor translathon at Wikimania Mexico - https://phabricator.wikimedia.org/T91108#1340973 (10Qgil) [12:57:47] \o/ VE bucketing complete. Now for the preliminary analysis. [13:30:01] yay [14:44:53] (03Restored) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/163847 (owner: 10Hashar) [14:44:56] (03PS5) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/163847 [14:47:28] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/163847 (owner: 10Hashar) [15:16:58] (03PS1) 10Esanders: Remove some assumptions about the state of the context [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/216106 (https://phabricator.wikimedia.org/T98811) [15:18:17] (03PS1) 10Esanders: Empty all inputs on link inspector teardown [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/216107 [15:22:24] edsanders: Nice. You had a chance to look at fixing https://gerrit.wikimedia.org/r/#/c/205291/ at all? [15:33:17] If a wanted to achieve something a grid layout inside of a dialog, what would be the best way to build my layouts? [15:33:47] Can I just configure panel layouts to display child widgets inside horizontally instead of vertically? [17:03:48] James_F, standup? [17:45:36] TrevorParscal : Hi, could you tell me how the group parameter in tools work? for eg, ve.ui.MWCitationDialogTool.static.group = 'cite'; [17:46:11] As far as I have understood from tinkering around with the code, it somehow determines the placement of the buttons in the toolbar. [17:46:31] Are there fixed predefined groups? or can i create a new one? [17:47:04] ankita-ks: The groups are referenced in the toolbar definition; they're used to collect multiple tools into one toolbar menu (or whatever). [17:47:09] Basically I want my button to get added to the main toolbar. But right now it goes into Insert > LanguageTool [17:47:28] ankita-ks: You need to over-ride the toolbar definition, which I strongly advise against. :-( [17:47:37] It's intentional that very few things are in the toolbar. [17:47:37] okay. [17:48:04] ankita-ks: But if you have to, search for "toolbarGroups". [17:48:05] So where would you suggest i place the proof reading button? [17:48:14] Beware that it's very delicate and might change. [17:48:23] alright [18:57:59] TrevorParscal , James_F , MatmaRex : Where do you think a button for language proofing go on the toolbar? This is a markup that I created earlier : https://phabricator.wikimedia.org/T93752 [18:58:38] Please let me know if I should change the position of the button, so I can move forward with it. :) [19:17:57] Does it matter if I append elements to a widget after that widget has been added to the screen? [19:18:49] I think that's an OOUI or jQuery thing [19:24:02] ankita-ks: sounds reasonable to me [19:24:51] MatmaRex : Well, I am having trouble with putting it up on the main toolbar. [19:25:46] As far as I understand I might need to create a new group. [19:27:32] Do I need to add it to ve.init.mw.Target.static.toolbarGroups in ve.init.mw.Target.js [19:27:35] ? [19:27:58] ferdbold: it will probably work, but it's not explicitly supported. you're doing it on your own responsibility :) [19:28:12] ankita-ks: hmm [19:29:35] MatmaRex: ok. Is there a specific way to handle having to add/delete widgets at runtime? [19:29:40] MatmaRex: *cough* OO.ui.DatePickerWidget *cough* [19:31:20] ankita-ks: hmm, yes, if you wanted to add the tool at the end of the main toolbar, then yes. [19:31:50] ankita-ks: do you need it to be there? it will be easier to add it to one of the existing groups [19:32:27] Not really. I just felt it would be better if it was on the main toolbar because I could not decide a group for it. [19:32:35] Where do you think should it be placed? [19:32:38] ^ MatmaRex [19:33:35] ferdbold: What are you trying to do exactly? [19:34:04] James_F: working on it. :) http://bzdionopru.localtunnel.me/wiki/index.php/Specjalna:Pusta_strona [19:34:49] RoanKattouw: I'm trying to have a dialog where the user could add rows of text inputs to enter data inside [19:34:58] ankita-ks: i think it doesn't matter much where you place it for now? we can always change it later. let's focus on making it actually work :) [19:35:12] ferdbold: OK so I think you want to subclass GroupWidget [19:35:16] Well yes, you are right. :) [19:35:17] RoanKattouw: Something like a table, it's for entering graph data, so x and y coordinates in this case [19:35:17] ankita-ks: if you set .static.autoAddToCatchall = true, it will appear magically under the "Insert" menu [19:35:26] Cause it sounds like you want "a managed group of widgets that are all the same type" [19:35:36] MatmaRex: Neat. [19:35:54] alright [19:36:13] I would recommend having the table be a GroupWidget subclass that manages a widget for each row [19:36:15] What does this option mean? [19:36:38] ankita-ks: "Automatically add me to the 'random stuff' menu" [19:36:45] Which is labeled "Insert" [19:36:50] okay [19:37:11] ankita-ks: it will be "Insert" because it has "include: '*'" in ve.init.mw.Target.static.toolbarGroups [19:38:33] RoanKattouw: Do you actually mean GroupElement? GroupWidget seems deprecated [19:38:50] Hmm, I thought GroupWidget was an extension of GroupElement [19:38:51] * RoanKattouw looks [19:38:52] okay. Does that mean that whenever a group is not explicitly defined, it goes under Insert? [19:39:05] James_F: speaking of which, what do you think about adding runtime dependencies to OOUI? [19:39:30] James_F: that widget depends on Moment.js for date calculations, which is why it's currently MediaWiki-only [19:39:35] ferdbold: Yeah it looks like GroupWidget is just GroupElement but with disabled state inheritance, which you probably don't need [19:39:38] (calculations and formatting) [19:39:53] MatmaRex: Beyond jQuery? [19:39:57] MatmaRex: And OOjs. [19:40:03] MatmaRex: Ah. MW-widgets for now is fine. Adding Moment.js to OOUI's payload needs some consideration. [19:40:14] It used to do setElementGroup() stuff but that was moved into GroupElement apparently [19:40:43] RoanKattouw: So I would create a TableWidget under Widget which mixes in GroupElement, correct? [19:40:48] Yes [19:41:01] And then you'd add RowWidgets to it [19:41:32] GroupElement will manage them for you in this.$items [19:41:46] And if you need to do special management things, you can do that by overriding addItems/removeItems/clearItems [19:42:30] But I think you might not have to do that. You can probably do most things by accessing this.items and with event aggregation (see .aggregate() in GroupElement) [19:52:32] RoanKattouw: Alright, I'll try that after I get a basic prototype working. Thanks a lot! [19:55:27] Hello, all. Could someone who knows how to install VisualEditor (Krenair? mvolz?) please look at the question posted at https://www.mediawiki.org/wiki/Talk:VisualEditor#Exception_in_load-callback_in_module_ext.visualEditor.targetLoader: ? [19:55:51] that one seems very common [19:56:03] it's mis-matching versions of MW and VE [20:04:32] whatami, replied [20:04:42] Thank you! [20:10:30] thanks for referring it to me. this is definitely not the first time it's come up [20:45:09] I'm having a weird issue with IndexLayout where the CardLayouts within are covered partially by the tab menu above, any idea what is causing this? [20:45:35] There doesn't seem to be any CSS that "pushes back" the cards so they are not under the menu [21:00:39] [13grunt-banana-checker] 15jdforrester created 06bump-dev-deps (+1 new commit): 02https://github.com/wikimedia/grunt-banana-checker/commit/be9f3e47a150 [21:00:40] 13grunt-banana-checker/06bump-dev-deps 14be9f3e4 15James D. Forrester: build: Bump devDep grunt-contrib-jshint to 0.11.2 [21:03:20] wikimedia/grunt-banana-checker#59 (bump-dev-deps - be9f3e4 : James D. Forrester): The build passed. [21:03:20] Change view : https://github.com/wikimedia/grunt-banana-checker/commit/be9f3e47a150 [21:03:20] Build details : http://travis-ci.org/wikimedia/grunt-banana-checker/builds/65631469 [21:04:45] 10VisualEditor, 10Parsoid: Ref generating templates show reflists when edited - https://phabricator.wikimedia.org/T101553#1342420 (10ssastry) The problem is that we auto-generate , but this is not the right thing to do in all scenarios. A simple solution for this would be to add a autogen-refs = f... [21:08:37] [13grunt-banana-checker] 15jdforrester created 06release from 06v0.2.1 (+0 new commits): 02https://github.com/wikimedia/grunt-banana-checker/commits/release [21:09:18] [13grunt-banana-checker] 15jdforrester 04deleted 06release at 1404f6f3d: 02https://github.com/wikimedia/grunt-banana-checker/commit/04f6f3d [21:09:51] [13grunt-banana-checker] 15jdforrester created 06release from 06v0.2.1 (+0 new commits): 02https://github.com/wikimedia/grunt-banana-checker/commits/release [21:10:12] [13grunt-banana-checker] 15jdforrester opened pull request #20: build: Bump devDep grunt-contrib-jshint to 0.11.2 (06master...06bump-dev-deps) 02https://github.com/wikimedia/grunt-banana-checker/pull/20 [21:10:48] wikimedia/grunt-banana-checker#60 (release - 04f6f3d : James D. Forrester): The build passed. [21:10:48] Change view : https://github.com/wikimedia/grunt-banana-checker/compare/release [21:10:48] Build details : http://travis-ci.org/wikimedia/grunt-banana-checker/builds/65632357 [21:12:26] [13grunt-banana-checker] 15jdforrester closed pull request #12: Standardise the error reporting system (06master...06cleaner-errors) 02https://github.com/wikimedia/grunt-banana-checker/pull/12 [21:14:58] wikimedia/grunt-banana-checker#61 (release - 04f6f3d : James D. Forrester): The build passed. [21:14:58] Change view : https://github.com/wikimedia/grunt-banana-checker/compare/release [21:14:58] Build details : http://travis-ci.org/wikimedia/grunt-banana-checker/builds/65632441 [21:24:56] 10Mediawiki-extensions-Graph-VE: Weekly reports for "Enable VisualEditor support in Graph extension" - https://phabricator.wikimedia.org/T101119#1342457 (10ferdbold) [21:31:50] 10VisualEditor: Publish VisualEditor process report on mediawiki.org - https://phabricator.wikimedia.org/T101209#1342458 (10JAufrecht) a:5Neil_P._Quinn_WMF>3JAufrecht [21:37:55] Can someone explain what actions and commands are? And how do they interact with tools? [21:39:28] 10VisualEditor: Finish sharable draft of suggested process changes - https://phabricator.wikimedia.org/T101459#1342472 (10JAufrecht) [21:41:00] ankita-ks: A tool, when clicked, executes a command [21:41:08] Keyboard shortcuts can also be bound to commands [21:41:18] This is how we make sure that Ctrl+B always does exactly the same as clicking the Bold tool [21:41:32] ah..okay [21:41:37] what about actions? [21:42:14] Commands are defined in CommandRegistry and MWCommandRegisty [21:42:40] A command definition looks something like new ve.ui.Command( 'meta', 'window', 'open', { args: ['meta'] } ); [21:43:02] Commands are defined in terms of actions [21:43:19] "When this command fires, execute this action with these arguments" [21:43:38] The definition above defines the 'meta' command as "in WindowAction, call open( 'meta' )" [21:44:03] So actions are where things actually happen [21:44:25] Commands and actions are separate so that we can reuse code between commands that are very similar (like opening a window) [21:44:58] hmm..okay..so if i want a certain thing to happen on clicking a tool button, I need to create an action for it? [21:45:20] Either that, or find a way to reuse an existing action [21:45:30] What is the thing you need to happen? [21:45:53] (You will definitely need to create command that executes the action, and tell the tool about that command) [21:45:55] I need to collect the text in the editing area and send it to the languagetool server [21:46:01] Oh OK [21:46:08] Yeah that sounds like you need a new action [21:46:12] We don't have anything like that right now [21:46:17] okay [21:46:25] Let me find you a simple-ish example of an action class [21:46:30] okay [21:46:46] also as of now I do not need to create a command, or do I? [21:47:05] Yes, you do [21:49:13] But I can see that there are some actions which do not have a corresponding command? [21:51:34] Yeah that happens sometimes [21:51:56] But maybe it shouldn't [21:52:18] There is an executeAction() method in ui.Surface to execute an action, so some things might be using that directly [21:52:31] HistoryAction is a very very simple example of an action class [21:52:35] AnnotationAction is a bit meatier [21:54:33] okay [21:54:42] Looking at HistoryAction first [21:58:19] [13grunt-banana-checker] 15legoktm pushed 1 new commit to 06master: 02https://github.com/wikimedia/grunt-banana-checker/commit/6c763dfcf7f4ff70bc224d948a53a4ef51c5a98d [21:58:19] 13grunt-banana-checker/06master 146c763df 15Kunal Mehta: Merge pull request #20 from wikimedia/bump-dev-deps... [21:59:35] [13grunt-banana-checker] 15jdforrester 04deleted 06bump-dev-deps at 14be9f3e4: 02https://github.com/wikimedia/grunt-banana-checker/commit/be9f3e4 [22:02:15] [13grunt-banana-checker] 15jdforrester created 06release-0.2.2 (+2 new commits): 02https://github.com/wikimedia/grunt-banana-checker/compare/f73e1d95ab41^...e63a59f99083 [22:02:15] 13grunt-banana-checker/06release-0.2.2 14f73e1d9 15James D. Forrester: package: Update licence syntax [22:02:15] 13grunt-banana-checker/06release-0.2.2 14e63a59f 15James D. Forrester: Tag v0.2.2 [22:02:30] [13grunt-banana-checker] 15jdforrester 04deleted 06release at 1404f6f3d: 02https://github.com/wikimedia/grunt-banana-checker/commit/04f6f3d [22:02:46] [13grunt-banana-checker] 15jdforrester opened pull request #21: Release 0.2.2 (06master...06release-0.2.2) 02https://github.com/wikimedia/grunt-banana-checker/pull/21 [22:04:12] wikimedia/grunt-banana-checker#63 (master - 6c763df : Kunal Mehta): The build passed. [22:04:13] Change view : https://github.com/wikimedia/grunt-banana-checker/compare/74343d1bc92e...6c763dfcf7f4 [22:04:13] Build details : http://travis-ci.org/wikimedia/grunt-banana-checker/builds/65637786 [22:07:11] [13grunt-banana-checker] 15legoktm closed pull request #21: Release 0.2.2 (06master...06release-0.2.2) 02https://github.com/wikimedia/grunt-banana-checker/pull/21 [22:07:26] Whee. [22:09:12] [13grunt-banana-checker] 15jdforrester tagged 06v0.2.2 at 06master: 02https://github.com/wikimedia/grunt-banana-checker/commits/v0.2.2 [22:09:52] [13grunt-banana-checker] 15jdforrester 04deleted 06release-0.2.2 at 14e63a59f: 02https://github.com/wikimedia/grunt-banana-checker/commit/e63a59f [22:11:10] wikimedia/grunt-banana-checker#67 (v0.2.2 - c5e13f0 : Kunal Mehta): The build passed. [22:11:10] Change view : https://github.com/wikimedia/grunt-banana-checker/compare/v0.2.2 [22:11:10] Build details : http://travis-ci.org/wikimedia/grunt-banana-checker/builds/65639345 [22:12:35] wikimedia/grunt-banana-checker#64 (release-0.2.2 - e63a59f : James D. Forrester): The build has errored. [22:12:35] Change view : https://github.com/wikimedia/grunt-banana-checker/compare/f73e1d95ab41^...e63a59f99083 [22:12:35] Build details : http://travis-ci.org/wikimedia/grunt-banana-checker/builds/65638366 [22:33:15] James_F: whenver you have a minute, unbreak now: https://gerrit.wikimedia.org/r/216326 (i broke stuff, eh) [22:58:14] MatmaRex: That doesn't need cherry-picking, does it? [22:58:38] no [22:58:53] cool [23:54:55] (03PS1) 10Legoktm: test: Updating development dependencies [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/216342 [23:55:09] James_F: ^ review that one for perfect-ness and then I'll submit the rest?