[16:24:08] (03PS6) 10Paladox: Update jquery.client.js to 2.0.0 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/216531 [16:49:54] (03CR) 10Jforrester: [C: 032] Focus insert button on panel switch [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/219384 (https://phabricator.wikimedia.org/T97352) (owner: 10Esanders) [16:50:12] (03Merged) 10jenkins-bot: Focus insert button on panel switch [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/219384 (https://phabricator.wikimedia.org/T97352) (owner: 10Esanders) [16:50:17] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References, 3VisualEditor 2015/16 Q1 blockers: Let me press return instead of clicking the green "Insert" button - https://phabricator.wikimedia.org/T97352#1382945 (10Jdforrester-WMF) 5Open>3Resolved a:3Esanders [16:53:13] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References, 3VisualEditor 2014/15 Q4 blockers: Let me press return instead of clicking the green "Insert" button - https://phabricator.wikimedia.org/T97352#1382958 (10Jdforrester-WMF) [16:56:36] 10VisualEditor, 10VisualEditor-Tables, 10Parsoid: Tables render differently in VisualEditor depending upon whether they're inside a complex transclusion - https://phabricator.wikimedia.org/T103128#1382962 (10Whatamidoing-WMF) 3NEW [17:39:53] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10MobileFrontend-Feature-requests, 3VisualEditor 2015/16 Q1 blockers: Provide VisualEditor regardless of device size - https://phabricator.wikimedia.org/T85630#1383136 (10Capt_Swing) [17:42:51] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10MobileFrontend-Feature-requests, 3VisualEditor 2015/16 Q1 blockers: Provide VisualEditor regardless of device size - https://phabricator.wikimedia.org/T85630#1383167 (10Capt_Swing) I removed Design Research from this, since this doesn't seem to be a resear... [17:56:46] 10VisualEditor: Create VE Product Burnup chart - https://phabricator.wikimedia.org/T102272#1383232 (10JAufrecht) [17:56:48] 10VisualEditor, 7Epic: Re-groom VE's product backlog - https://phabricator.wikimedia.org/T102266#1383233 (10JAufrecht) [18:40:37] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-Templates, 10VisualEditor-Tables: Table with some template-generated rows appears with additional jumbled empty table cells - https://phabricator.wikimedia.org/T70306#1383488 (10matmarex) [18:40:55] 10VisualEditor, 10VisualEditor-Tables, 10Parsoid: Tables render differently in VisualEditor depending upon whether they're inside a complex transclusion - https://phabricator.wikimedia.org/T103128#1383492 (10matmarex) Related to T70306. [19:27:52] 10Cite: Render references list in multiple columns based on the number of items - https://phabricator.wikimedia.org/T33597#1383669 (10Aklapper) @Krinkle: Still working on this? [20:25:32] 10VisualEditor, 10VisualEditor-MediaWiki-Links: Link target input shouldn't default to link text when switching from internal to external - https://phabricator.wikimedia.org/T103177#1383872 (10Catrope) 3NEW [20:38:06] (03PS1) 10Legoktm: build: Updating development dependencies [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/219452 [20:38:31] (03PS1) 10Legoktm: build: Updating development dependencies [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/219455 [20:38:52] (03PS1) 10Legoktm: build: Updating development dependencies [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/219458 [20:39:35] (03CR) 10Jforrester: [C: 032] build: Updating development dependencies [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/219452 (owner: 10Legoktm) [20:39:49] (03CR) 10Jforrester: [C: 032] build: Updating development dependencies [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/219455 (owner: 10Legoktm) [20:40:04] (03CR) 10Jforrester: [C: 032] build: Updating development dependencies [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/219458 (owner: 10Legoktm) [20:40:27] (03Merged) 10jenkins-bot: build: Updating development dependencies [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/219452 (owner: 10Legoktm) [20:40:32] (03CR) 10jenkins-bot: [V: 04-1] build: Updating development dependencies [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/219458 (owner: 10Legoktm) [20:40:44] (03Merged) 10jenkins-bot: build: Updating development dependencies [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/219455 (owner: 10Legoktm) [20:59:01] 10VisualEditor: Create VE Product Burnup chart - https://phabricator.wikimedia.org/T102272#1383942 (10JAufrecht) [21:00:13] 10VisualEditor, 7Epic: Re-groom VE's product backlog - https://phabricator.wikimedia.org/T102266#1383946 (10JAufrecht) Per our new rules on exploding epics, this task has been completely broken into other tasks so I'm closing it. (And, I guess, manually moving the one open blocker so that it now blocks the par... [21:01:07] 10VisualEditor: Consolidate VE Planning efforts into one backlog - https://phabricator.wikimedia.org/T102262#1383950 (10JAufrecht) [21:01:09] 10VisualEditor: Move high-level plans into Phabricator - https://phabricator.wikimedia.org/T102561#1383951 (10JAufrecht) [21:01:27] 10VisualEditor: Move high-level plans into Phabricator - https://phabricator.wikimedia.org/T102561#1367662 (10JAufrecht) [21:01:28] 10VisualEditor, 7Epic: Re-groom VE's product backlog - https://phabricator.wikimedia.org/T102266#1383952 (10JAufrecht) [21:02:08] 10VisualEditor: Consolidate VE Planning efforts into one backlog - https://phabricator.wikimedia.org/T102262#1361088 (10JAufrecht) [21:02:10] 10VisualEditor, 7Epic: Re-groom VE's product backlog - https://phabricator.wikimedia.org/T102266#1383956 (10JAufrecht) 5Open>3Invalid p:5Triage>3Normal [21:22:28] Hi, I need help with something. I just updated my my installation of mediawiki [21:22:39] And I am getting this error in VisualEditor [21:23:15] https://gist.github.com/ankita-kumari/ee2391caa20021fc2634 [21:23:21] which can be traced to this [21:23:25] https://gist.github.com/ankita-kumari/04303a09d7911c05f095 [21:32:56] (03PS2) 10Bartosz Dziewoński: build: Updating development dependencies [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/219458 (owner: 10Legoktm) [21:33:21] hi ankita-ks [21:33:32] hi MatmaRex [21:34:01] Did you look at the gists? [21:35:49] yeah, i'm trying to see what could be causing it [21:36:14] but all the dependencies seem to be set up correctly [21:36:29] okay. :| [21:36:30] ankita-ks: are you sure you're running the master branch of MediaWiki and master branch of VisualEditor? [21:36:41] (never hurts to ask :) ) [21:36:54] Let me check. (I think so) [21:38:21] MatmaRex : yup. master branch [21:40:55] hm. :( [21:43:35] ankita-ks: (continuing here from #mediawiki) [21:43:45] ankita-ks: So yeah while the inspector is open, do whatever it is you did to provoke the error [21:44:04] done [21:44:33] This should have activated the debugger and jumped it to the offending code, right? [21:45:33] If that happened, click the Console tab, type ve.init.Platform , press enter, and tell me what you see [21:46:45] Okay. So I can see the trace backs of the fucntion calls [21:46:55] and the error [21:47:38] on typing ve.init.Platform, I get function VeInitPlatform() [21:47:48] OK so that is there [21:47:50] clicking that takes me to the function body [21:47:55] What about ve.init.platform (lowercase p)? [21:48:12] undefined [21:48:25] OK... [21:48:28] ve.init.mw.Platform ? [21:48:36] Is that the problem? [21:48:45] Yeah ve.init.platform being undefined is a problem [21:48:49] But I'm wondering why [21:49:36] Typing "ve.init.mw.Platform" gives me "function VeInitMwPlatform()" [21:49:41] OK so that's defined [21:49:44] Interesting [21:50:07] Hmm [21:50:14] Can you pastebin the result of ve.init.Platform.toString() ? [21:51:03] RoanKattouw : https://gist.github.com/ankita-kumari/c3a98e9cda13199173c9 [21:51:31] hah [21:51:42] You probably have an outdated version of VE core [21:51:54] After updating extensions/VisualEditor to master, did you run git submodule update ? [21:52:00] Try running that and see if that fixees it [21:52:23] RoanKattouw : no, did not. Doing that [21:54:16] RoanKattouw : It works now, thank you! :) [21:54:25] Yay! [21:54:37] So yeah, every time you update VE, you have to run git submodule update [21:54:58] Alright. Will take care in future. how did you know this was the problem btw? [21:55:00] It's a common pitfall, but usually things explode more spectacularly when you forget, in which case I would have recognized what happened more quickly [21:55:21] Well, I looked for the code that defines ve.init.platofmr [21:55:37] There's ve.init.platform = this; in the ve.init.Platform constructor on my machine [21:55:58] Then I remembered that that hasn't always been there, it was moved there a little while ago, so I wondered if maybe you had an outdated version that didn't do that [21:56:20] So ve.init.Platform.toString() told me what that function looked like for you, and it wasn't the same as the one I saw, it was shorter [21:56:55] RoanKattouw : Okay. Thank you! :) [21:58:38] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-Tables: Unable to edit a specific table content - https://phabricator.wikimedia.org/T97398#1384120 (10Neil_P._Quinn_WMF) Okay, thanks for the update! I'm going to close this. Anybody (including Andre) feel free to reopen if you can still reproduc... [21:58:50] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-Tables: Unable to edit a specific table content - https://phabricator.wikimedia.org/T97398#1384121 (10Neil_P._Quinn_WMF) 5Open>3Resolved [22:02:00] RoanKattouw : could you help me with one more thing? [22:02:07] Sure [22:02:36] I have been working on an extension. And it worked fine with the earlier version of VisualEditor. But it doesn't anymore. [22:03:00] There are two errors. [22:04:58] Error 1 : https://gist.github.com/ankita-kumari/23ba6712ec265d733db9 [22:05:33] Error 2 : https://gist.github.com/ankita-kumari/db04bb49004647ff4700 [22:09:48] Are those 404 not found errors? [22:10:06] If you go to http://127.0.0.1/mediawiki/extensions/examples/LanguageTool/modules/ext.languageTool.js , do you see JS code or an error? [22:11:23] This link gives me a 404 [22:11:31] Right [22:11:36] But it shouldn't be this link. [22:11:41] What should it be? [22:11:50] http://127.0.0.1/mediawiki/extensions/LanguageTool/modules/ext.languageTool.js [22:11:56] I thought so [22:12:20] So, in the $wgResourceModules definition for the module that contains ext.languageTool.js , look at localBasePath and remoteExtPath and check they're correct [22:12:40] You probably set remoteExtPath to 'examples/LanguageTool' instead of 'LanguageTool' [22:13:49] RoanKattouw : yes, that's right. [22:13:52] Changed that. [22:14:01] which led to more errors. [22:14:01] :| [22:14:18] Uncaught ReferenceError: OO is not defined [22:14:49] (03CR) 10Jforrester: [C: 032] build: Updating development dependencies [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/219458 (owner: 10Legoktm) [22:14:55] in the line : OO.inheritClass( mw.languageTool, ve.ui.DialogTool ); [22:14:56] hah [22:15:07] That probably means you don't have the right dependencies [22:15:18] Does your module have any dependencies at all right now? [22:15:49] it is an extension for VisualEditor, so that. [22:16:37] I mean, in the $wgResourceModules['ext.languageTool.whatever'] = ... definition, are there any dependencies listed there? [22:16:50] Your module definition should include 'dependencies' => array( 'ext.visualEditor.mwcore' ) [22:16:56] (That probably needs to be documented better) [22:17:12] right now, there is nothing there [22:17:23] (03Merged) 10jenkins-bot: build: Updating development dependencies [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/219458 (owner: 10Legoktm) [22:17:23] oh okay [22:17:50] Basically what happens is modules are loaded in (approximately) alphabetical order unless there's a dependency saying that's not OK [22:17:58] So ext.languageTool comes before oojs-ui [22:18:02] in the alphabet [22:18:15] And so by the time you try to do OO.inheritClass(), oojs-ui hasn't loaded [22:18:44] By dependening on ext.visualEditor.mwcore you make sure that oojs-ui and a lot of VE things load before your code, so that you can use them [22:19:48] If there's no dependency declared, the system assumes it can just run things in whatever order it wants [22:20:05] RoanKattouw : ah okay. That makes sense. [22:20:10] And so it was doing crazy things like running your VE extension before VE itself :) [22:20:26] It works fine now. [22:20:31] Awesome [22:20:51] So let's say if it was not oojs-ui but something like abcd-module [22:21:06] Then it would probably work, by accident [22:21:12] ah okay [22:21:21] But sometimes, maybe 10% of the time, it wouldn't work, and everyone would be confused and not know why [22:21:24] (This has happened) [22:21:30] oh [22:22:13] Usually missing dependencies cause hard and fatal code breakage, like in your case [22:22:15] Well..thank you for the help! :) [22:22:22] And sometimes it causes intermittent issues that are hard to find [22:22:23] alright [23:08:51] 10VisualEditor: Align all VE tasks with higher-level Goals and Epics - https://phabricator.wikimedia.org/T102267#1384309 (10JAufrecht) [23:11:57] 10VisualEditor: Consolidate VE Planning efforts into one backlog - https://phabricator.wikimedia.org/T102262#1384325 (10JAufrecht) Closing because all work in this task has been broken into subtasks. [23:12:08] 10VisualEditor: Consolidate VE Planning efforts into one backlog - https://phabricator.wikimedia.org/T102262#1384328 (10JAufrecht) 5Open>3Invalid [23:12:09] 10VisualEditor, 7Epic: Make improvements to the VisualEditor team's processes - https://phabricator.wikimedia.org/T101207#1384330 (10JAufrecht) [23:12:40] 10VisualEditor, 7Epic: Make improvements to the VisualEditor team's processes - https://phabricator.wikimedia.org/T101207#1332658 (10JAufrecht) [23:14:09] 10VisualEditor: Measure and document results of changes to VE team processes - https://phabricator.wikimedia.org/T103197#1384332 (10JAufrecht) 3NEW [23:14:36] 10VisualEditor, 7Epic: Make improvements to the VisualEditor team's processes - https://phabricator.wikimedia.org/T101207#1384338 (10JAufrecht) Closing because all work has been moved to subtasks. [23:14:47] 10VisualEditor, 7Epic: Make improvements to the VisualEditor team's processes - https://phabricator.wikimedia.org/T101207#1384339 (10JAufrecht) 5Open>3Invalid [23:55:17] hey guys [23:55:24] getting this error in console: "VisualEditor failed to load: Error: Module ext.visualEditor.core has failed dependencies" [23:55:41] mw1.25.1, veREL1_25 [23:56:06] Have you run git submodule update --init ? [23:56:13] in the extensions/VisualEditor directory [23:57:24] yes [23:57:44] haven't got this far before. usually it hanged at 3/4 along the loading bar