[00:15:03] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] build: Configure banana-checker and jsonlint [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/220017 (owner: 10Legoktm)
[00:15:52] <grrrit-wm>	 (03Merged) 10jenkins-bot: build: Configure banana-checker and jsonlint [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/220017 (owner: 10Legoktm)
[00:27:31] <grrrit-wm>	 (03CR) 10Jforrester: [C: 031] Make toolgroup hack work on all target [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/219825 (owner: 10Esanders)
[01:10:22] <grrrit-wm>	 (03PS1) 10Jforrester: ve.init.mw.Target: Kill all <script> tags before sending to Parsoid [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/220028 (https://phabricator.wikimedia.org/T103430) 
[01:16:40] <grrrit-wm>	 (03CR) 10Catrope: [C: 031] ve.init.mw.Target: Kill all <script> tags before sending to Parsoid [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/220028 (https://phabricator.wikimedia.org/T103430) (owner: 10Jforrester)
[01:26:14] <wikibugs>	 10VisualEditor: External link modal dialog should trim whitespace - https://phabricator.wikimedia.org/T103450#1390557 (10awight) 3NEW
[01:37:11] <wikibugs>	 10VisualEditor: "Review changes" diff should always be displayed - https://phabricator.wikimedia.org/T103451#1390568 (10awight) 3NEW
[02:12:11] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 7Regression: <source> and <syntaxhighlight> no longer protected from content editable - https://phabricator.wikimedia.org/T103455#1390635 (10Krinkle) 3NEW
[02:14:15] <RoanKattouw>	 Oooooh
[02:14:16] <RoanKattouw>	 mw.org is special
[02:14:23] <RoanKattouw>	 For some silly reason, mwalienextension is experimental
[02:14:29] <RoanKattouw>	 And guess where experimental stuff is enabled
[02:15:25] <Krinkle>	 RoanKattouw: :)
[02:15:37] <RoanKattouw>	 lol, cross-channel jinx
[02:15:40] <RoanKattouw>	 Sorry for moving the conversation
[02:15:45] <RoanKattouw>	 Happened because the bot notified here
[02:16:07] <Krinkle>	 Ah yeah, enwiki too
[02:16:08] <Krinkle>	 shit
[02:16:30] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 7Regression: <source> and <syntaxhighlight> no longer protected from content editable - https://phabricator.wikimedia.org/T103455#1390646 (10Catrope) No, I was wrong, it's not due to the ModelRegistry changes. MWAlienExtensionNode isn't being loaded, because it's sti...
[02:16:44] <RoanKattouw>	 Whoops
[02:16:54] <RoanKattouw>	 Of course, you do realize, all those edits people make to code in code blocks is lost :(
[02:16:58] <RoanKattouw>	 *are lost
[02:17:35] <Krinkle>	 Yes
[02:17:38] <Krinkle>	 I noticed it on wikitech
[02:17:41] <Krinkle>	 it said there was no diff
[02:18:03] <RoanKattouw>	 Because Parsoid has no way to map changes to the rendering back to changes to the input, just like with templtes
[02:18:12] <RoanKattouw>	 It disregards the rendering changes and looks at data-mw instead
[02:18:31] <Krinkle>	 Why does it work on mw.org?
[02:18:36] <Krinkle>	 experimental is only true in labs
[02:18:51] <RoanKattouw>	 No, experimental is true on mw.org too, isn't it
[02:19:02] <Krinkle>	 I don't see it in wmf-config
[02:19:11] <Krinkle>	 Anyhow, fixing
[02:19:50] <Krinkle>	 RoanKattouw: Hold on. Why would it need that extension model to not be an alien?
[02:19:55] <Krinkle>	 Doesn't it default to alien?
[02:20:13] <RoanKattouw>	 It needs the alien extension model in order for there to be such a concept as an alien extension
[02:20:23] <RoanKattouw>	 AlienNode doesn't eat it because DivNode claims it
[02:20:30] <RoanKattouw>	 Oooh, so I guess it *is* Ed's MR changes, in part
[02:20:51] <RoanKattouw>	 Prior to those changes, DivNode couldn't claim it because of the mw:-prefixed RDFa type
[02:22:14] <Krinkle>	 Hm.. so where should it move to?
[02:22:26] <Krinkle>	 Should it become a dependency of some other module, or just list it in TargetLoader's array?
[02:22:30] <RoanKattouw>	 You could just add it to .. yeah
[02:22:31] <Krinkle>	 Seems wrong for it to only be specified client-side
[02:22:42] <Krinkle>	 without this, mw is broken
[02:22:44] <RoanKattouw>	 A lot of things are only listed in TargetLoader
[02:22:48] <RoanKattouw>	 Oh OK
[02:22:55] <RoanKattouw>	 Well in that case maybe mwcore should depend on it
[02:23:06] <RoanKattouw>	 Unless that results in a circular dependency
[02:23:17] <RoanKattouw>	 ...which it does
[02:25:16] <Krinkle>	 Looking in git blame, they were always in experimental only
[02:25:19] <Krinkle>	 Strange
[02:25:36] <Krinkle>	 Maybe they weren't always caught by DivNode
[02:25:50] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 7Regression: <source> and <syntaxhighlight> no longer protected from content editable - https://phabricator.wikimedia.org/T103455#1390721 (10Catrope) >>! In T103455#1390646, @Catrope wrote: > No, I was wrong, it's not due to the ModelRegistry changes. MWAlienExtensio...
[02:25:50] <RoanKattouw>	 Yes
[02:25:54] <RoanKattouw>	 See ---^^
[02:30:19] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 7Regression: <source> and <syntaxhighlight> no longer protected from content editable - https://phabricator.wikimedia.org/T103455#1390750 (10Krinkle)
[02:31:27] <grrrit-wm>	 (03PS1) 10Krinkle: Make ext.visualEditor.mwalienextension mandatory (no longer experimental) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/220031 (https://phabricator.wikimedia.org/T103455) 
[02:31:53] <grrrit-wm>	 (03CR) 10Catrope: [C: 031] Make ext.visualEditor.mwalienextension mandatory (no longer experimental) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/220031 (https://phabricator.wikimedia.org/T103455) (owner: 10Krinkle)
[02:32:40] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Make ext.visualEditor.mwalienextension mandatory (no longer experimental) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/220031 (https://phabricator.wikimedia.org/T103455) (owner: 10Krinkle)
[02:33:44] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 5Patch-For-Review, 7Regression: <source> and <syntaxhighlight> no longer protected from content editable - https://phabricator.wikimedia.org/T103455#1390776 (10Krinkle) p:5Triage>3High a:3Krinkle
[02:34:06] <grrrit-wm>	 (03PS2) 10Krinkle: Make ext.visualEditor.mwalienextension mandatory (no longer experimental) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/220031 (https://phabricator.wikimedia.org/T103455) 
[02:34:46] <grrrit-wm>	 (03CR) 10Jforrester: Make ext.visualEditor.mwalienextension mandatory (no longer experimental) (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/220031 (https://phabricator.wikimedia.org/T103455) (owner: 10Krinkle)
[02:34:48] <grrrit-wm>	 (03CR) 10Catrope: Make ext.visualEditor.mwalienextension mandatory (no longer experimental) (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/220031 (https://phabricator.wikimedia.org/T103455) (owner: 10Krinkle)
[02:35:07] <Krinkle>	 Guys, I already fixed that.
[02:35:15] <Krinkle>	 but thanks :)
[02:35:22] <grrrit-wm>	 (03CR) 10Catrope: [C: 031] Make ext.visualEditor.mwalienextension mandatory (no longer experimental) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/220031 (https://phabricator.wikimedia.org/T103455) (owner: 10Krinkle)
[02:35:47] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Make ext.visualEditor.mwalienextension mandatory (no longer experimental) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/220031 (https://phabricator.wikimedia.org/T103455) (owner: 10Krinkle)
[02:37:17] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Make ext.visualEditor.mwalienextension mandatory (no longer experimental) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/220031 (https://phabricator.wikimedia.org/T103455) (owner: 10Krinkle)
[02:37:39] <grrrit-wm>	 (03CR) 10Jforrester: "Meh." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/220031 (https://phabricator.wikimedia.org/T103455) (owner: 10Krinkle)
[02:40:03] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Make ext.visualEditor.mwalienextension mandatory (no longer experimental) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/220031 (https://phabricator.wikimedia.org/T103455) (owner: 10Krinkle)
[02:46:05] <grrrit-wm>	 (03PS3) 10Krinkle: Make ext.visualEditor.mwalienextension mandatory (no longer experimental) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/220031 (https://phabricator.wikimedia.org/T103455) 
[03:10:02] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Make ext.visualEditor.mwalienextension mandatory (no longer experimental) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/220031 (https://phabricator.wikimedia.org/T103455) (owner: 10Krinkle)
[03:12:28] <grrrit-wm>	 (03Merged) 10jenkins-bot: Make ext.visualEditor.mwalienextension mandatory (no longer experimental) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/220031 (https://phabricator.wikimedia.org/T103455) (owner: 10Krinkle)
[04:18:26] <wikibugs>	 10VisualEditor: VisualEditor deletes translate markers - https://phabricator.wikimedia.org/T103463#1390850 (10jayvdb) 3NEW
[04:49:39] <wikibugs>	 10VisualEditor, 10VisualEditor-Links, 10VisualEditor-Media: Pressing escape twice to cancel out of the link inspector, closes the entire media dialog - https://phabricator.wikimedia.org/T103433#1390874 (10Whatamidoing-WMF)
[05:11:37] <wikibugs>	 10VisualEditor: HotCat doesn't load after saving a page in VisualEditor (must refresh/reload first) - https://phabricator.wikimedia.org/T103285#1390892 (10Quiddity) Confirmed in Firefox 38, Ubuntu.  There are no relevant messages in webconsole. (@GermanJoe: Just FYI: that "localstorage" exception is related to R...
[05:12:08] <wikibugs>	 10VisualEditor: HotCat doesn't load after saving a page in VisualEditor (must refresh/reload first) - https://phabricator.wikimedia.org/T103285#1390893 (10Quiddity)
[05:17:28] <wikibugs>	 10VisualEditor: toolbars are not usable while typing parameter values in the VisualEditor template editor - https://phabricator.wikimedia.org/T103467#1390913 (10Amire80) 3NEW
[05:25:31] <wikibugs>	 10VisualEditor: toolbars are not usable while typing parameter values in the VisualEditor template editor - https://phabricator.wikimedia.org/T103467#1390930 (10eranroz) I guess it is relevant only for some parameters based on the type in the templatedata, probably "content" and unspecified parameter type (and m...
[06:26:13] <wikibugs>	 10Citoid, 10VisualEditor: Citoid should omit IISN if value from loc.gov is invalid (e.g. "None") - https://phabricator.wikimedia.org/T103478#1391054 (10Krinkle) 3NEW
[06:26:23] <wikibugs>	 10Citoid, 10VisualEditor: Citoid should omit ISSN if value from loc.gov is invalid (e.g. "None") - https://phabricator.wikimedia.org/T103478#1391061 (10Krinkle)
[06:33:58] <grrrit-wm>	 (03CR) 10Amire80: "I didn't test, but just a quick sanity check question: In https://he.wikipedia.org/w/index.php?diff=17005703 , which this patch is suppose" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/220028 (https://phabricator.wikimedia.org/T103430) (owner: 10Jforrester)
[08:50:04] <wikibugs>	 10VisualEditor, 10MediaWiki-General-or-Unknown, 10RESTBase, 6Services, and 3 others: Parsoid performance: Use RESTBase from the MediaWiki Virtual Rest Service on group1/group2 wikis - https://phabricator.wikimedia.org/T89066#1391430 (10mobrovac)
[09:43:31] <wikibugs>	 10Citoid, 10VisualEditor, 5WMF-deploy-2015-06-16_(1.26wmf10): Regression: Valid maps data with citoid field/ template data type mismatch causes a js error/ endless pending - https://phabricator.wikimedia.org/T100651#1391692 (10Mvolz) 5Open>3Resolved
[09:45:39] <wikibugs>	 10Citoid, 7Easy, 7I18n: It's unclear what does the word "Manual" refers to in the Citoid-citeFromIDDialog-use-general-error-message - https://phabricator.wikimedia.org/T98854#1391720 (10Mvolz) Resolved in https://gerrit.wikimedia.org/r/#/c/216970/
[09:45:57] <wikibugs>	 10Citoid, 7Easy, 7I18n: It's unclear what does the word "Manual" refers to in the Citoid-citeFromIDDialog-use-general-error-message - https://phabricator.wikimedia.org/T98854#1391722 (10Mvolz) 5Open>3Resolved
[09:55:32] <wikibugs>	 10Citoid, 10VisualEditor: After a paste happens directly after a click on citoid and a click outside of the citoid window,  gives 'Uncaught Error: Nested change of newModelSelection' - https://phabricator.wikimedia.org/T98079#1391738 (10Mvolz) I tried replicating when this first was reported, and I tried again...
[10:20:47] <wikibugs>	 10Citoid, 10Beta-Cluster: Can't start Zotero deployment in deployment-prep - https://phabricator.wikimedia.org/T103493#1391791 (10mobrovac) 3NEW
[11:28:51] <wikibugs>	 10VisualEditor, 6Collaboration-Team, 10Flow: Ctrl-Home doesn't allow further typing in VisualEditor in Flow posts - https://phabricator.wikimedia.org/T103494#1391889 (10Amire80) 3NEW
[11:40:19] <wikibugs>	 10VisualEditor, 6Collaboration-Team, 10Flow: Ctrl-Home doesn't allow further typing in VisualEditor in Flow posts - https://phabricator.wikimedia.org/T103494#1391915 (10IKhitron)
[12:01:10] <wikibugs>	 10Citoid, 10VisualEditor: Enable science direct translator (if working) - https://phabricator.wikimedia.org/T97042#1391955 (10mobrovac) I have debugged this a bit more. I ran tests from `sca1001` to check the responses, and unless I set the `Cookie` header I get the correct response. `curl`-ing with the exact...
[12:05:37] <wikibugs>	 10VisualEditor: Visualeditor is dead on WP/fr , Progress bar bar stopped at 75% - https://phabricator.wikimedia.org/T103498#1391961 (10Drongou) 3NEW
[12:16:10] <wikibugs>	 10Citoid: Improve Zotero Validation - https://phabricator.wikimedia.org/T101878#1391998 (10Mvolz) a:3Mvolz
[12:17:44] <grrrit-wm>	 (03CR) 10Alex Monk: "Are we fixing a bug here?" [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/219825 (owner: 10Esanders)
[12:21:30] <wikibugs>	 10VisualEditor: Visualeditor is dead on WP/fr , Progress bar bar stopped at 75% - https://phabricator.wikimedia.org/T103498#1392002 (10Krenair) Looks like this was caused by https://fr.wikipedia.org/w/index.php?title=MediaWiki:Common.js&diff=116224981&oldid=115320199 ?
[12:23:49] <wikibugs>	 10VisualEditor: Visualeditor is dead on WP/fr , Progress bar bar stopped at 75% - https://phabricator.wikimedia.org/T103498#1392012 (10Krenair) And probably some other wikis:  eswiki              MediaWiki:Common.js kabwiki             MediaWiki:Common.js krcwiki             MediaWiki:Common.js
[12:25:28] <wikibugs>	 10VisualEditor: JavaScript is broken on frwiki, eswiki, kabwiki, krcwiki - https://phabricator.wikimedia.org/T103498#1392016 (10Krenair)
[12:26:01] <wikibugs>	 10VisualEditor: JavaScript is broken on frwiki, eswiki, kabwiki, krcwiki - https://phabricator.wikimedia.org/T103498#1392018 (10Trizek-WMF) p:5Triage>3Unbreak!
[12:26:21] <Elitre>	 I was going to say that
[12:26:31] <Elitre>	 https://phabricator.wikimedia.org/T103498 should be unbreak now.
[12:27:21] <Elitre>	 Krenair: if the edit to the .js file caused this, why were people able to edit after that?
[12:28:36] <Elitre>	 who should look into this, guys?
[12:28:49] <Krenair>	 Those edits don't necessarily take effect immediately.
[12:29:47] <Krenair>	 I'll try undoing it on frwiki
[12:30:42] <Elitre>	 what can go wrong by reverting that edit? (as in, was it an emergency fix, or something else?)
[12:31:17] <Krenair>	 Nothing worse than the current situation
[12:32:17] <Krenair>	 I need to figure out why we have redirect=no all over the place at some point
[12:32:38] <Krenair>	 it was a mass replacement across many wikis
[12:33:54] * Elitre is waiting for the revert to be effective
[12:34:59] <Krenair>	 Elitre, try now?
[12:35:27] <Elitre>	 oh yes <3
[12:36:27] <wikibugs>	 10VisualEditor: JavaScript is broken on frwiki, eswiki, kabwiki, krcwiki - https://phabricator.wikimedia.org/T103498#1392037 (10Krenair) I reverted the edit on frwiki and VE appears to load now: https://fr.wikipedia.org/w/index.php?title=MediaWiki:Common.js&curid=1182982&diff=116237778&oldid=116224981
[12:36:29] <Elitre>	 just saved a test edit
[12:36:38] <Elitre>	 should we revert everywhere?
[12:37:55] <Krenair>	 I'm not sure everywhere the edit was done would actually be broken by it. On some wikis it was random gadgets
[12:38:28] <Elitre>	 and he made like 100 edits yesterday
[12:39:36] <Krenair>	 I'm undoing it on MediaWiki:Common.js
[12:39:48] <wikibugs>	 10VisualEditor: JavaScript is broken on frwiki, eswiki, kabwiki, krcwiki - https://phabricator.wikimedia.org/T103498#1392053 (10Thibaut120094) Yes, VE works on frwiki, thanks!
[12:40:35] <Trizek>	 Thank you Krenair! :)
[12:42:05] <wikibugs>	 10VisualEditor: JavaScript is broken on frwiki, eswiki, kabwiki, krcwiki - https://phabricator.wikimedia.org/T103498#1392061 (10Krenair) Same on eswiki, kabwiki, krcwiki, etc. Other places that may or may not be affected, let me know if any of them are: ```alex@alex-laptop:~/Development/MediaWiki/extensions/Visu...
[12:45:32] <Elitre>	 VE should be ok if you reverted all the changes at MediaWiki:Common.js , right?
[12:47:24] <mvolz>	 Elitre: if people have those other scripts running where he changed it then possible not
[12:47:33] <mvolz>	 but MediaWiki:Common.js affects everyone
[12:48:11] <Elitre>	 hi mvolz! and thanks for the info.
[12:48:40] <mvolz>	 Krenair: should we revert everywhere else too?
[12:49:52] <Elitre>	 14:37 <•Krenair> I'm not sure everywhere the edit was done would actually be broken by it. On some wikis it was random gadgets
[12:52:22] <mvolz>	 Is there a way to change your user preferences globally
[12:52:46] <mvolz>	 setting my home language on every single wiki is hard :)
[12:53:36] <Elitre>	 I'm checking if VE loads starting at the bottom of the list K. provided on the task.
[12:53:57] <Elitre>	 not yet, mvoz :/
[12:58:47] <Krenair>	 mvolz, yes, if you fancy writing and running a script to do it individually on every single one
[13:02:56] <mvolz>	 It's only 80, we can do it by hand... :P
[13:04:01] <mvolz>	 Krenair: https://en.wikipedia.org/wiki/User_talk:Ori_Livneh#sabotage.3F
[13:05:28] <Elitre>	 mvolz, the list Krenair provided is 35. I'm at hsbwiki (started from bottom)
[13:05:34] <Krenair>	 yep, seems to rely on https://gerrit.wikimedia.org/r/#/c/219562/
[13:05:43] <Elitre>	 so far VE loads - I think that's enough as a check?
[13:05:47] <Krenair>	 which is included in master, not any of the wmf branches so probably is not deployed
[13:06:12] <Krenair>	 Elitre, could also check console for the error message
[13:07:05] <mvolz>	 Bleh, I don't have rollback rights on my account
[13:07:43] <mvolz>	 https://en.wikipedia.org/w/index.php?title=MediaWiki:Gadget-imagelinks.js&action=history anyone want to do that one.
[13:08:53] <Krenair>	 you need editinterface to do these, not rollback
[13:09:50] <Elitre>	 https://gag.wikipedia.org/wiki/Respublika_Moldova?veaction=edit for example loads VE, but console says a lot of stuff is deprecated and other stuff should be used instead,
[13:10:01] <mvolz>	 yeah above my paygrade :) 
[13:10:02] <wikibugs>	 10VisualEditor: JavaScript is broken on frwiki, eswiki, kabwiki, krcwiki - https://phabricator.wikimedia.org/T103498#1392126 (10Krenair) https://en.wikipedia.org/wiki/User_talk:Ori_Livneh#sabotage.3F
[13:10:19] <Krenair>	 mvolz, done that link
[13:10:24] <Krenair>	 Elitre, yeah
[13:10:26] <Krenair>	 that's normal
[13:10:40] <Krenair>	 a lot of our wikis run really terribly old code that was copied from other wikis years ago
[13:11:01] <Krenair>	 and just sits there rotting for years
[13:11:40] <Elitre>	 yup, so I don't see console check as a priority while trying to figure out whether VE is working everywhere, sorry :)
[13:11:54] <Krenair>	 I meant checking for that specific console error.
[13:11:58] <mvolz>	 are you trying it with those gadgets enabled Elitre?
[13:13:43] <Elitre>	 not necessarily. I'm probably just wasting my time now.
[13:24:10] <wikibugs>	 10VisualEditor, 6Community-Liaison, 10Wikimania-Hackathon-2015, 3VisualEditor 2015/16 Q1 blockers: VisualEditor translathon at Wikimania Mexico - https://phabricator.wikimedia.org/T91108#1392162 (10Qgil) Hi, we haven't announced it yet, but you can schedule this session at https://wikimania2015.wikimedia.o...
[13:27:46] <wikibugs>	 10VisualEditor, 6Community-Liaison, 10Wikimania-Hackathon-2015, 3VisualEditor 2015/16 Q1 blockers: VisualEditor translathon at Wikimania Mexico - https://phabricator.wikimedia.org/T91108#1392165 (10Elitre) Thanks Quim! I'll consult with @siebrand about that tomorrow.
[13:39:58] <wikibugs>	 10WikiEditor, 7Easy, 5Patch-For-Review, 7Upstream: WikiEditor: Add SVG versions of editing toolbar icons - https://phabricator.wikimedia.org/T37342#1392216 (10Paladox) I think the italic I was done like that on purpose.
[13:45:53] <grrrit-wm>	 (03PS65) 10Paladox: WikiEditor: Add svg images [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (https://phabricator.wikimedia.org/T37342) 
[13:47:40] <wikibugs>	 10WikiEditor, 7Easy, 5Patch-For-Review, 7Upstream: WikiEditor: Add SVG versions of editing toolbar icons - https://phabricator.wikimedia.org/T37342#1392311 (10Paladox) i have uploaded patch that moves the signature button down slightly please could you check it. and if you want the italic i changed a bit c...
[13:50:25] <grrrit-wm>	 (03CR) 10Paladox: "Ok I have replied to you in the bug." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (https://phabricator.wikimedia.org/T37342) (owner: 10Paladox)
[13:58:08] <grrrit-wm>	 (03CR) 10Alex Monk: [C: 031] "Should work. Ed?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/220028 (https://phabricator.wikimedia.org/T103430) (owner: 10Jforrester)
[13:59:05] <grrrit-wm>	 (03CR) 10Alex Monk: "(Although it wouldn't get those comments.)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/220028 (https://phabricator.wikimedia.org/T103430) (owner: 10Jforrester)
[13:59:21] <wikibugs>	 10Citoid, 10Beta-Cluster: Can't start Zotero deployment in deployment-prep - https://phabricator.wikimedia.org/T103493#1392398 (10thcipriani) 5Open>3Resolved a:3thcipriani It's strange the directory `/srv/deployment/zotero/translators/.git/refs/tags/zotero` (which is ostensibly created because the tags t...
[14:09:23] <wikibugs>	 10VisualEditor, 10Wikimedia-General-or-Unknown, 7JavaScript: JavaScript is broken on various wikis - https://phabricator.wikimedia.org/T103498#1392433 (10Krenair)
[14:12:09] <Elitre>	 Krenair, you changed your mind about removing the VE project for that task?
[14:12:17] <Krenair>	 yeah
[14:12:37] <Krenair>	 these on-wiki JS tasks are a huge mess to manage in dev bug trackers
[14:12:44] <Krenair>	 we really shouldn't have to do it
[14:13:10] <Krenair>	 but when people break stuff in JS it tends to affect more official things and people come to phabricator/bz etc. for help
[14:51:41] <wikibugs>	 10Citoid, 10VisualEditor, 5Patch-For-Review: Enable science direct translator (if working) - https://phabricator.wikimedia.org/T97042#1392689 (10mobrovac) 5Open>3Resolved Squid proxy patch checked and works. I redeployed the translator activation patch and confirmed it is now working in production.
[14:51:51] <grrrit-wm>	 (03CR) 10Esanders: "citoid doesn't appear on mobile" [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/219825 (owner: 10Esanders)
[14:51:55] <wikibugs>	 10Citoid, 10VisualEditor: Enable science direct translator (if working) - https://phabricator.wikimedia.org/T97042#1392691 (10mobrovac)
[14:55:08] <wikibugs>	 10Citoid, 10VisualEditor: Enable science direct translator (if working) - https://phabricator.wikimedia.org/T97042#1392699 (10Elitre) I just tested with 10.1016/j.cagd.2005.06.005 - https://en.wikipedia.org/w/index.php?title=User%3AElitre_%28WMF%29%2FSandbox&type=revision&diff=668298042&oldid=667456505 , it se...
[14:57:14] <grrrit-wm>	 (03CR) 10Esanders: [C: 04-1] Allow structured citoid fields to be flattened (034 comments) [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/218946 (https://phabricator.wikimedia.org/T97044) (owner: 10Mvolz)
[14:59:20] <grrrit-wm>	 (03CR) 10Esanders: [C: 04-1] Focus on the first focusable element in template dialog (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/204204 (owner: 10Mooeypoo)
[15:02:54] <grrrit-wm>	 (03PS27) 10Paladox: Add svg to LESS file [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/195529 (https://phabricator.wikimedia.org/T37342) 
[15:06:04] <Krenair>	 Is "Error: Unknown dependency: ext.graph.visualEditor Error: Unknown dependency: ext.graph.visualEditor" in VE mobile on beta known edsanders?
[15:06:18] <Krenair>	 e.g. http://en.m.wikipedia.beta.wmflabs.org/wiki/0.02995365323426391#/editor/0
[15:07:14] <grrrit-wm>	 (03CR) 10Alex Monk: "Not just ve.init.target.constructor.static?" [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/219825 (owner: 10Esanders)
[15:10:47] <grrrit-wm>	 (03CR) 10Jforrester: "The alternative is blocking users with the plugin on sight." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/220028 (https://phabricator.wikimedia.org/T103430) (owner: 10Jforrester)
[15:14:39] <James_F>	 edsanders: Any chance you could +2 https://gerrit.wikimedia.org/r/#/c/219863/ https://gerrit.wikimedia.org/r/#/c/219865/ https://gerrit.wikimedia.org/r/#/c/220028/ ?
[15:15:05] <James_F>	 Krenair: Meh, sounds like poor target selector in extensions/Graph; ferdbold?
[15:15:18] <grrrit-wm>	 (03CR) 10Esanders: [C: 04-1] "we should check with Parsoid if we can permanently blacklist some more tags from the domspec, e.g. embed/style." (034 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/220028 (https://phabricator.wikimedia.org/T103430) (owner: 10Jforrester)
[15:16:04] <grrrit-wm>	 (03CR) 10Jforrester: ve.init.mw.Target: Kill all <script> tags before sending to Parsoid (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/220028 (https://phabricator.wikimedia.org/T103430) (owner: 10Jforrester)
[15:17:10] <grrrit-wm>	 (03CR) 10Esanders: "why lib/ve? why not all of lib?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/219863 (owner: 10Jforrester)
[15:17:26] <James_F>	 edsanders: Because some of lib is locally-written; but eh.
[15:17:42] <James_F>	 edsanders: (Also the rest of lib/ passes.)
[15:17:55] <edsanders>	 James_F, no it isn't
[15:18:09] <edsanders>	 Base64.js, Easy-Deflate, ve, zip.js
[15:18:15] <James_F>	 Base64.js is the ed_g2s version, ISTR.
[15:18:27] <edsanders>	 don't think so
[15:19:24] <ferdbold>	 Hmm, there's not any target selector for ext.graph.visualEditor, and it should fallback on the ext.graph one which is [mobile, desktop]
[15:19:41] <grrrit-wm>	 (03CR) 10Esanders: [C: 04-1] build: Don't run jsonlint on lib/ve [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/219863 (owner: 10Jforrester)
[15:19:45] <James_F>	 Meh.
[15:20:36] <grrrit-wm>	 (03PS2) 10Jforrester: build: Don't run jsonlint on lib [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/219863 
[15:25:25] <wikibugs>	 10VisualEditor, 10Wikimedia-General-or-Unknown, 7JavaScript: JavaScript is broken on various wikis - https://phabricator.wikimedia.org/T103498#1392844 (102526) thanks, Bro krenair, from urduwikipedia
[15:26:23] <grrrit-wm>	 (03CR) 10Esanders: [C: 032] build: Don't run jsonlint on lib [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/219863 (owner: 10Jforrester)
[15:26:25] <wikibugs>	 10VisualEditor, 10Wikimedia-General-or-Unknown, 7JavaScript, 7user-notice: JavaScript is broken on various wikis - https://phabricator.wikimedia.org/T103498#1392847 (10Jdforrester-WMF)
[15:26:29] <James_F>	 Thanks edsanders.
[15:26:37] <grrrit-wm>	 (03PS2) 10Esanders: Update VE core submodule to master (7b7b3d8) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/219865 (owner: 10Jforrester)
[15:26:45] <grrrit-wm>	 (03CR) 10Esanders: [C: 032] Update VE core submodule to master (7b7b3d8) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/219865 (owner: 10Jforrester)
[15:27:34] <grrrit-wm>	 (03CR) 10Jforrester: ve.init.mw.Target: Kill all <script> tags before sending to Parsoid (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/220028 (https://phabricator.wikimedia.org/T103430) (owner: 10Jforrester)
[15:28:55] <grrrit-wm>	 (03Merged) 10jenkins-bot: build: Don't run jsonlint on lib [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/219863 (owner: 10Jforrester)
[15:29:31] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update VE core submodule to master (7b7b3d8) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/219865 (owner: 10Jforrester)
[15:39:34] <grrrit-wm>	 (03CR) 10Esanders: ve.init.mw.Target: Kill all <script> tags before sending to Parsoid (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/220028 (https://phabricator.wikimedia.org/T103430) (owner: 10Jforrester)
[15:40:06] <grrrit-wm>	 (03CR) 10Jforrester: ve.init.mw.Target: Kill all <script> tags before sending to Parsoid (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/220028 (https://phabricator.wikimedia.org/T103430) (owner: 10Jforrester)
[15:42:47] <grrrit-wm>	 (03PS2) 10Jforrester: ve.init.mw.Target: Strip all <script>/<object>/<style>/<embed> on save [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/220028 (https://phabricator.wikimedia.org/T103430) 
[15:42:51] <James_F>	 edsanders: Done, but…
[15:59:27] <wikibugs>	 10Citoid, 10VisualEditor: Enable science direct translator (if working) - https://phabricator.wikimedia.org/T97042#1393021 (10Elitre) For some reason I couldn't add all the DOIs listed in Quiddity's comment in the same edit (it would still show me the error message). With these edits https://en.wikipedia.org/w...
[16:29:57] <wikibugs>	 10Citoid, 10VisualEditor: Enable science direct translator (if working) - https://phabricator.wikimedia.org/T97042#1393158 (10mobrovac) 5Resolved>3Open Reopening. Yet again.  >>! In T97042#1393021, @Elitre wrote: > For some reason I couldn't add all the DOIs listed in Quiddity's comment in the same edit (i...
[16:41:00] <wikibugs>	 10VisualEditor, 6Editing-Department, 3Readership-Web, 3Readership-Web-Next-Sprint-50-X______________: Extremely high amount of errors for anonymous editors - https://phabricator.wikimedia.org/T97494#1393213 (10phuedx) @Jdlrobson: It looks like we're going to have to separate out these errors: "http" could...
[16:42:15] <wikibugs>	 10VisualEditor, 10Wikimedia-General-or-Unknown, 7JavaScript, 7user-notice: JavaScript is broken on various wikis - https://phabricator.wikimedia.org/T103498#1393223 (10Krenair) a:3Krenair I'll check the rest of these later
[16:43:26] <James_F>	 Thanks, Krenair.
[16:53:07] <Elitre>	 what are <time> tags? is this an effect of copy/paste or something?
[16:55:15] <wikibugs>	 10VisualEditor, 7Epic: Figure out how to represent Goals, OKRs, and Milestones in Phab - https://phabricator.wikimedia.org/T102202#1393242 (10JAufrecht)
[16:56:41] <Krenair>	 Elitre, https://developer.mozilla.org/en-US/docs/Web/HTML/Element/time
[16:59:53] <Krenair>	 Is it being inserted into articles by strange VE edits?
[17:00:46] <Elitre>	 yes! See the sources section of https://fr.wikipedia.org/w/index.php?title=Bataille_du_d%C3%A9fil%C3%A9_de_Ver%C3%ADn&diff=next&oldid=116144125 .
[17:14:49] <wikibugs>	 10VisualEditor, 10VisualEditor-CopyPaste: Pasting stuff while editing makes the page jump to the top while using VE - https://phabricator.wikimedia.org/T103558#1393307 (10NiharikaKohli) 3NEW
[17:24:16] <Krenair>	 that feels like a dupe
[17:27:36] <wikibugs>	 10VisualEditor, 10Graph, 3VisualEditor 2015/16 Q1 blockers: VE-Graph integration breaks mobile VE - https://phabricator.wikimedia.org/T103561#1393347 (10Krenair) 3NEW
[17:28:45] <wikibugs>	 10VisualEditor, 10Graph, 3VisualEditor 2014/15 Q4 blockers: VE-Graph integration breaks mobile VE - https://phabricator.wikimedia.org/T103561#1393362 (10Jdforrester-WMF) a:3Krenair
[17:41:16] <Elitre>	 Krenair: so, was I right in guessing it could be a copy/paste thing? (first time I see that)
[17:43:11] <James_F>	 Elitre: Yeah. I'm not sure VE should remove them.
[17:43:30] <James_F>	 Elitre: Same as <mark> or <var> or <kbd> etc. ones, but not visible.
[17:45:20] <Elitre>	 is there a task about these tasks?
[17:46:44] <Elitre>	 *these tags
[17:46:49] <James_F>	 No.
[17:46:58] <James_F>	 We agreed to retain them.
[17:48:09] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10MobileFrontend-Feature-requests, 3VisualEditor 2015/16 Q1 blockers: Provide VisualEditor regardless of device size - https://phabricator.wikimedia.org/T85630#1393454 (10Florian) It would be easily possible to enable VE on mobile devices, but the problem is...
[17:50:35] <Elitre>	 is there a task about how to properly add these tags? :) I do use the mark one from time to time.
[17:51:27] <James_F>	 edsanders: https://gerrit.wikimedia.org/r/#/c/220028/ ping?
[17:51:49] <James_F>	 Elitre: https://phabricator.wikimedia.org/T66376 for <mark>
[17:51:51] <edsanders>	 James_F, I haven't heard back from Parsoid about the other tags yet
[17:52:02] <James_F>	 Elitre: https://phabricator.wikimedia.org/T54664 for <var>
[17:52:06] <James_F>	 Elitre: There are a few others.
[17:52:17] <James_F>	 Elitre: But low priority as we don't want to encourage.
[17:52:24] <James_F>	 edsanders: :-(
[17:53:42] <Krenair>	 James_F, so what are you supposed to be able to do with these graph elements in VE?
[17:53:45] <James_F>	 subbu: Do you have any quick thoughts on <embed>?
[17:53:49] <James_F>	 Krenair: Right now, just see them.
[17:53:52] <James_F>	 Krenair: Soon, edit them.
[17:53:53] <Krenair>	 right
[17:54:00] <James_F>	 Krenair: (Before the new patch, they weren't even visible.)
[17:54:03] <Krenair>	 and I presume we want to allow this on mobile?
[17:54:29] <James_F>	 Krenair: Sure, though like with <gallery> it's not likely to be satisfying any time soon.
[17:55:39] <subbu>	 James_F, not immediately. phab task?
[17:59:40] <James_F>	 subbu: Generally, https://phabricator.wikimedia.org/T54327 
[18:00:22] <James_F>	 subbu: We're thinking of just blacklisting <embed>, <object>, <script> and <style> elements on save (so dropping them from the HTML we send to Parsoid), but edsanders wanted to know if this would break things in Parsoid land.
[18:05:33] <wikibugs>	 10VisualEditor: Move high-level plans into Phabricator - https://phabricator.wikimedia.org/T102561#1393513 (10JAufrecht)
[18:05:34] <wikibugs>	 10VisualEditor, 7Epic: Figure out how to represent Goals, OKRs, and Milestones in Phab - https://phabricator.wikimedia.org/T102202#1393512 (10JAufrecht) 5Open>3Resolved
[18:08:21] <subbu>	 edsanders, James_F, ok .. will get back to you .. but, quick thought is: I don't see why dropping them from html would break parsoid (except if they came from original wikitext and dropping would cause dirty diffs -- but not sure why they some of these would show up in original wikitext ..)
[18:09:55] <wikibugs>	 10Citoid, 10VisualEditor, 5Patch-For-Review: Enable science direct translator (if working) - https://phabricator.wikimedia.org/T97042#1393533 (10mobrovac) p:5Unbreak!>3High I have deployed a hot fix into production which should keep Citoid from crashing for now if it receives an empty citation from Zoter...
[18:09:58] <James_F>	 subbu: Yeah.
[18:10:11] <wikibugs>	 10Citoid, 10VisualEditor: Enable science direct translator (if working) - https://phabricator.wikimedia.org/T97042#1393537 (10mobrovac)
[18:14:55] <Krenair>	 James_F, I've been looking at some of these problematic gadget changes that were made
[18:15:06] <Krenair>	 It seems that some do not have any effect at all
[18:15:17] <Krenair>	 Others cause errors loading the gadget but don't affect VE
[18:15:20] <James_F>	 Krenair: because the code is dead?
[18:15:23] <Krenair>	 yeah
[18:15:26] <James_F>	 Fuuuun.
[18:15:31] <Krenair>	 e.g. gadget files without an entry in gadgets-definition
[18:15:34] <Krenair>	 on arwiki
[18:15:40] * James_F sighs.
[18:15:51] <James_F>	 Yay for pre-commit code review on gadgets. Oh, wait.
[18:15:55] <Krenair>	 heh
[18:17:55] <quiddity>	 Krenair, there's a possibly mw.RegExp related issue being discussed at https://en.wikipedia.org/wiki/Wikipedia:Village_pump_%28technical%29#Something_up_with_collapsing.3F
[18:17:56] <wikibugs>	 10VisualEditor, 10Wikimedia-General-or-Unknown, 7JavaScript, 7user-notice: JavaScript is broken on various wikis - https://phabricator.wikimedia.org/T103498#1393556 (10Krenair)
[18:21:49] <wikibugs>	 10VisualEditor, 10Wikimedia-General-or-Unknown, 7JavaScript, 7user-notice: JavaScript is broken on various wikis - https://phabricator.wikimedia.org/T103498#1393571 (10ori) This was a major fuck-up on my part. I am sorry about that, and will look into any leftover changes that need to be reverted. I will a...
[18:22:51] <wikibugs>	 10VisualEditor, 10Wikimedia-General-or-Unknown, 7JavaScript, 7user-notice: JavaScript is broken on various wikis - https://phabricator.wikimedia.org/T103498#1393576 (10Krenair) 5Open>3Resolved
[18:28:22] <wikibugs>	 10VisualEditor, 10Graph, 5Patch-For-Review, 3VisualEditor 2014/15 Q4 blockers: VE-Graph integration breaks mobile VE - https://phabricator.wikimedia.org/T103561#1393597 (10Krenair) 5Open>3Resolved
[18:30:27] <wikibugs>	 10VisualEditor, 10Graph, 5Patch-For-Review, 3VisualEditor 2014/15 Q4 blockers: VE-Graph integration breaks mobile VE - https://phabricator.wikimedia.org/T103561#1393603 (10Jdforrester-WMF)
[18:30:47] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 5Patch-For-Review, 3VisualEditor 2014/15 Q4 blockers: Adguard injects code to VisualEditor edits - https://phabricator.wikimedia.org/T103430#1393605 (10Jdforrester-WMF) a:3Jdforrester-WMF
[18:32:51] <James_F>	 Krenair: Once you're done with cleanup, I'd suggest https://phabricator.wikimedia.org/T97723 then https://phabricator.wikimedia.org/T98845
[18:34:54] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 5Patch-For-Review, 7Regression, and 2 others: <source> and <syntaxhighlight> no longer protected from content editable - https://phabricator.wikimedia.org/T103455#1393627 (10Jdforrester-WMF) 5Open>3Resolved
[18:35:00] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 5Patch-For-Review, 7Regression, and 2 others: <source> and <syntaxhighlight> no longer protected from content editable - https://phabricator.wikimedia.org/T103455#1390635 (10Jdforrester-WMF)
[18:35:33] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 5Patch-For-Review, 7Testme, 3VisualEditor 2014/15 Q4 blockers: VisualEditor: CAPTCHA has no refresh button - https://phabricator.wikimedia.org/T103227#1384911 (10Jdforrester-WMF)
[18:37:44] <wikibugs>	 10VisualEditor, 10Wikimedia-General-or-Unknown, 7JavaScript, 3VisualEditor 2014/15 Q4 blockers, 7user-notice: JavaScript is broken on various wikis - https://phabricator.wikimedia.org/T103498#1393651 (10Jdforrester-WMF)
[18:37:49] <wikibugs>	 10VisualEditor, 10Wikimedia-General-or-Unknown, 7JavaScript, 3VisualEditor 2014/15 Q4 blockers, 7user-notice: JavaScript is broken on various wikis - https://phabricator.wikimedia.org/T103498#1391961 (10Jdforrester-WMF)
[18:39:42] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-References: Re-use of a named <ref> inside a <references> block renames it in the body but not inside the <references> - https://phabricator.wikimedia.org/T103415#1393657 (10Jdforrester-WMF) p:5Triage>3Normal
[18:39:49] <wikibugs>	 10VisualEditor, 7Epic: Figure out how to represent Goals, OKRs, and Milestones in Phab - https://phabricator.wikimedia.org/T102202#1393661 (10JAufrecht) Most questions addressed; we will go forward with this approach and see what works and what doesn't.
[18:40:15] <wikibugs>	 10VisualEditor: "Review changes" diff should always be displayed - https://phabricator.wikimedia.org/T103451#1393664 (10Jdforrester-WMF) 5Open>3declined a:3Jdforrester-WMF The vast majority of users don't care (and shouldn't need to care) about the exact diff.
[18:40:19] <wikibugs>	 10VisualEditor, 7Epic: Move goals, OKRs, and Milestones into Phabricator - https://phabricator.wikimedia.org/T102203#1393668 (10JAufrecht) a:5JAufrecht>3Jdforrester-WMF
[18:41:10] <wikibugs>	 10VisualEditor, 10VisualEditor-CopyPaste: Pasting stuff while editing makes the page jump to the top while using VE - https://phabricator.wikimedia.org/T103558#1393678 (10Jdforrester-WMF)
[18:41:13] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-CopyPaste, 10VisualEditor-Performance, and 3 others: Pasting content results in scroll flickering - https://phabricator.wikimedia.org/T89623#1393679 (10Jdforrester-WMF)
[18:44:58] <edsanders>	 subbu, we'd only be stripping them from the DOM. They are only going to be there because of browser plugin injection
[18:45:47] <edsanders>	 even if your wiki is in full HTML, parsoid doesn't generate script tags it appears - want to check you're happy with any or all of  them being banned form the DOM spec basically.
[18:52:04] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable, 7Epic, 5Patch-For-Review, 3VisualEditor 2015/16 Q1 blockers: [Regression wmf4] Link continuation is broken - https://phabricator.wikimedia.org/T74108#1393731 (10Jdforrester-WMF)
[19:01:18] <wikibugs>	 10VisualEditor, 3VisualEditor 2014/15 Q4 blockers: Remember last used tab on citation tool  - https://phabricator.wikimedia.org/T103582#1393743 (10Nirzar) 3NEW
[19:07:32] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 5Patch-For-Review, 7Testme, 3VisualEditor 2014/15 Q4 blockers: VisualEditor: CAPTCHA has no refresh button - https://phabricator.wikimedia.org/T103227#1384911 (10Jdforrester-WMF)
[19:17:29] <wikibugs>	 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References, 3VisualEditor 2014/15 Q4 blockers: Remember last used tab (auto/manual/re-use) on citation tool in a hidden preference and open to that one next time - https://phabricator.wikimedia.org/T103582#1393805 (10Jdforrester-WMF) p:5Triage>3Normal
[19:19:54] <wikibugs>	 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References, 3VisualEditor 2014/15 Q4 blockers: Remember last used tab (auto/manual/re-use) on citation tool in a hidden preference and open to that one next time - https://phabricator.wikimedia.org/T103582#1393820 (10Jdforrester-WMF) a:3Krenair
[20:16:26] <mooeypoo>	 James_F, Krenair YIKES, sorry about that, and thank you for the quick fix.
[20:16:46] <James_F>	 mooeypoo: It was only mobile. :-)
[20:17:11] <Krenair>	 only
[20:17:31] <James_F>	 'only'. ;-)
[20:18:00] <mooeypoo>	 Mobile? Pfft, who's using mobile.
[20:18:13] <mooeypoo>	 Sorry about that, though. I should've caught it on review.
[20:18:19] <mooeypoo>	 Totally missed that.
[20:18:23] <James_F>	 Krenair: Seen my comment about https://phabricator.wikimedia.org/T97723 and https://phabricator.wikimedia.org/T98845 BTW?
[20:19:31] <Krenair>	 James_F, no
[20:19:35] <James_F>	 Kk.
[20:19:55] <James_F>	 Krenair: I was suggesting they seemed quick, easy-ish tasks it'd be nice to get done. ;-)
[20:31:32] <Krenair>	 James_F, where did you say this?
[20:41:12] <grrrit-wm>	 (03CR) 10TheDJ: [C: 032] WikiEditor: Add svg images [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (https://phabricator.wikimedia.org/T37342) (owner: 10Paladox)
[20:42:02] <grrrit-wm>	 (03Merged) 10jenkins-bot: WikiEditor: Add svg images [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (https://phabricator.wikimedia.org/T37342) (owner: 10Paladox)
[20:43:21] <grrrit-wm>	 (03PS28) 10TheDJ: Add svg to LESS file [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/195529 (https://phabricator.wikimedia.org/T37342) (owner: 10Paladox)
[20:43:42] <grrrit-wm>	 (03CR) 10TheDJ: [C: 032] Add svg to LESS file [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/195529 (https://phabricator.wikimedia.org/T37342) (owner: 10Paladox)
[20:44:38] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add svg to LESS file [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/195529 (https://phabricator.wikimedia.org/T37342) (owner: 10Paladox)
[20:45:15] <wikibugs>	 10WikiEditor, 7Easy: WikiEditor: Add SVG versions of editing toolbar icons - https://phabricator.wikimedia.org/T37342#1394173 (10TheDJ) a:5TheDJ>3Paladox
[20:45:32] <wikibugs>	 10WikiEditor, 7Easy: WikiEditor: Add SVG versions of editing toolbar icons - https://phabricator.wikimedia.org/T37342#1394175 (10TheDJ) 5Open>3Resolved
[20:50:51] <grrrit-wm>	 (03CR) 10TheDJ: [C: 032] Remove unused parameter lang from $.wikiEditor.auto* functions [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/213600 (owner: 10Gerrit Patch Uploader)
[20:51:36] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove unused parameter lang from $.wikiEditor.auto* functions [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/213600 (owner: 10Gerrit Patch Uploader)
[21:08:48] <grrrit-wm>	 (03CR) 10Paladox: "Thanks" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (https://phabricator.wikimedia.org/T37342) (owner: 10Paladox)
[21:09:09] <grrrit-wm>	 (03PS1) 10Alex Monk: Force 'Open' button for internal links to use full path [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/220307 (https://phabricator.wikimedia.org/T85619) 
[21:09:10] <wikibugs>	 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-Links, 3VisualEditor 2015/16 Q1 blockers: "Open" button in the Link tool lead to a broken or incorrect target if on a /w/ entry point - https://phabricator.wikimedia.org/T85619#1394304 (10Krenair) a:3Krenair
[21:17:18] <wikibugs>	 10VisualEditor, 10VisualEditor-EditingTools, 7Design: Make lighter icons for the bullet/numbered list controls, in keeping with wider icon theme (and indent/outdent icons) - https://phabricator.wikimedia.org/T78084#1394338 (10KHammerstein) a:5KHammerstein>3None
[21:17:42] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 7Design: Polish : VisualEditor Loading indicator should feel more integrated into the interface - https://phabricator.wikimedia.org/T1181#1394339 (10KHammerstein) a:5KHammerstein>3None
[21:19:10] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 3VisualEditor 2015/16 Q1 blockers: VE should give more useful message on save error due to block - https://phabricator.wikimedia.org/T95752#1394352 (10Krenair) a:5Krenair>3None Actually, as I discussed with James a day or so ago in IRC, I think we need to clear u...
[21:29:00] <wikibugs>	 10VisualEditor, 10VisualEditor-Links, 3VisualEditor 2014/15 Q4 blockers: Link button remains depressed after canceling out of link inspector in insertion mode - https://phabricator.wikimedia.org/T98845#1394395 (10Krenair)
[21:50:13] <Krenair>	 James_F, I'm not sure https://phabricator.wikimedia.org/T98845 is easy
[21:51:23] <James_F>	 It's not? :-(
[21:51:47] <Krenair>	 annotation inspectors have close actions which work because they're dialogs, but I don't think you can properly go back to the tool and ensure it's deactivated from there when that action is used..
[22:03:43] <grrrit-wm>	 (03PS1) 10Jforrester: Update OOjs UI to v0.11.6 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/220333 
[22:04:07] <James_F>	 Krenair: Ah.
[22:09:20] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.11.6 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/220333 (owner: 10Jforrester)
[22:17:58] <Krenair>	 MatmaRex, ^
[22:22:02] <MatmaRex>	 hmm
[22:25:09] <Krenair>	 it's a VE core or OOjs UI thing
[22:25:20] <James_F>	 :-(
[22:26:11] <grrrit-wm>	 (03PS2) 10Jforrester: MWInternalLinkAnnotationWidget: Force 'Open' button to use full path [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/220307 (https://phabricator.wikimedia.org/T85619) (owner: 10Alex Monk)
[22:26:19] <grrrit-wm>	 (03CR) 10Jforrester: [C: 031] MWInternalLinkAnnotationWidget: Force 'Open' button to use full path [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/220307 (https://phabricator.wikimedia.org/T85619) (owner: 10Alex Monk)
[22:26:51] <grrrit-wm>	 (03PS2) 10Jforrester: Save dialog: Show reload link next to FancyCaptchas [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/219583 (https://phabricator.wikimedia.org/T103227) (owner: 10Alex Monk)
[22:27:04] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] MWInternalLinkAnnotationWidget: Force 'Open' button to use full path [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/220307 (https://phabricator.wikimedia.org/T85619) (owner: 10Alex Monk)
[22:27:18] <James_F>	 Yeah yeah, jenkins, hush.
[22:27:52] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Save dialog: Show reload link next to FancyCaptchas [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/219583 (https://phabricator.wikimedia.org/T103227) (owner: 10Alex Monk)
[22:28:22] <MatmaRex>	 Krenair: James_F: hmmmmm. i'm not sure if that is the bug we'd want to fix there
[22:28:42] <MatmaRex>	 first, i note that when pressing Ctrl+K to open the inspector, the toolbar tool doesn't get activated
[22:29:09] <Krenair>	 I feel like I've seen a task for that before
[22:29:30] <MatmaRex>	 i'm not sure if we want it to
[22:30:00] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update OOjs UI to v0.11.6 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/220333 (owner: 10Jforrester)
[22:30:12] <MatmaRex>	 but assuming that we do, the best way to fix this seems to emit 'updateState' events on the toolbar, and handle them in each tool (to activate the tool is corresponding dialog is open)
[22:30:18] <MatmaRex>	 (and deactivate when closed)
[22:30:41] <MatmaRex>	 this way that tool wouldn't have to have access directly to the dialog
[22:30:52] <MatmaRex>	 emit 'updateState' events on the toolbar when a dialog is opened/closed*
[22:33:48] <grrrit-wm>	 (03CR) 10Jforrester: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/220307 (https://phabricator.wikimedia.org/T85619) (owner: 10Alex Monk)
[22:33:56] <grrrit-wm>	 (03CR) 10Jforrester: [C: 031] "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/219583 (https://phabricator.wikimedia.org/T103227) (owner: 10Alex Monk)
[22:45:36] <grrrit-wm>	 (03PS5) 10Mooeypoo: Focus on the first focusable element in template dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/204204 
[22:46:43] <grrrit-wm>	 (03PS1) 10Paladox: WikiEditor: Add svg images [extensions/WikiEditor] (REL1_25) - 10https://gerrit.wikimedia.org/r/220344 (https://phabricator.wikimedia.org/T37342) 
[22:48:50] <grrrit-wm>	 (03CR) 10Paladox: [C: 04-1] "Need to update CDs file to support svg first" [extensions/WikiEditor] (REL1_25) - 10https://gerrit.wikimedia.org/r/220344 (https://phabricator.wikimedia.org/T37342) (owner: 10Paladox)
[22:52:56] <mooeypoo>	 James_F, I don't see the error that lead to developing this patch. When I open the template dialog, the focus is on the first element. I thought I saw that, which is why I asked if it's still relevant. Am I misremembering?
[22:54:03] <James_F>	 mooeypoo: It's about re-setting the focus when you delete multi-template transclusions, isn't it? 
[22:54:30] <mooeypoo>	 it's calling it onTransclusionReady
[22:54:50] <James_F>	 Hmm.
[22:55:20] <James_F>	 Maybe it got fixed upstream?
[22:56:05] <mooeypoo>	 I think it might have. I'm testing
[22:57:50] <mooeypoo>	 meh, saving takes forever
[22:58:15] <mooeypoo>	 oops... Uncaught TypeError: Cannot read property 'replace' of undefined
[22:58:44] <Krenair>	 uh oh
[22:59:02] <Krenair>	 on save on which wiki mooeypoo?
[22:59:07] <mooeypoo>	 Krenair, local
[22:59:10] <Krenair>	 oh
[22:59:14] <mooeypoo>	 I'm checking to see if it's a local error
[22:59:32] <mooeypoo>	 it's just going and going, and btw, the "Save" button is still enabled while it's thinking
[22:59:49] <Krenair>	 yeah, that sort of behaviour is normal when you hit such errors
[23:00:19] <Krenair>	 it's probably not doing anything useful in the background
[23:00:25] <mooeypoo>	 meh
[23:00:33] <mooeypoo>	  mw.Api error:  badcachekey Object {error: Object}
[23:00:43] <mooeypoo>	 It did save, though. 
[23:01:10] <Krenair>	 huh
[23:03:19] <mooeypoo>	 ok, I have to say, I see no difference in behavior between this patch and master
[23:03:27] <mooeypoo>	 it was either fixed in master, or my patch isn't relevant anymore...
[23:03:33] <mooeypoo>	 fixed upstream, I mean
[23:03:41] <mooeypoo>	 This is weird.
[23:04:04] <Krenair>	 James_F, so https://phabricator.wikimedia.org/T97723 - the first time I open the link inspector (on plain text), it shows all search suggestions
[23:04:13] <Krenair>	 if I cancel it and try again, it doesn't bring up suggestions at all
[23:04:32] <James_F>	 Krenair: Until you modify the content of the search field, at which point it shows it again.
[23:04:44] <Krenair>	 yep
[23:04:46] <James_F>	 mooeypoo: Abandon, then? Sorry to steal your time.
[23:04:52] <Krenair>	 That's the issue, right?
[23:05:01] <mooeypoo>	 no problems, I'm just a little confused. Not sure what fixed it upstream
[23:05:10] <Krenair>	 after the first time, you have to modify the content to get the suggestions to show?
[23:05:11] <James_F>	 Krenair: Presumably because we re-use the window or something and so something in init() should be in setup() or whatever?
[23:05:13] <James_F>	 Krenair: Yes.
[23:05:45] <Krenair>	 okay
[23:08:50] <grrrit-wm>	 (03Abandoned) 10Mooeypoo: Focus on the first focusable element in template dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/204204 (owner: 10Mooeypoo)
[23:08:56] <mooeypoo>	 Very weird.
[23:09:08] <wikibugs>	 10VisualEditor, 10VisualEditor-Links, 3VisualEditor 2014/15 Q4 blockers: Link button remains depressed after canceling out of link inspector in insertion mode - https://phabricator.wikimedia.org/T98845#1394748 (10Krenair) This is something in VE core or OOjsUI, so removed the VE-MW-Links project. Annotation...
[23:11:04] <Krenair>	 James_F, I'm wondering whether we, analytics, or some other team needs to do https://phabricator.wikimedia.org/T101270
[23:11:51] <Krenair>	 just need to pull a list of VE revisions out of the analytics DBs for that time period and make sure they all have the VE change tag, right?
[23:12:00] <James_F>	 Krenair: Yeah. :-( I have no idea if it's ever been done for RCtags before. Probably something you could do, maybe? Might be tricky.
[23:12:28] <Krenair>	 I don't think I have proper access to the analytics databases
[23:12:54] <James_F>	 neilpquinn can give a dump of all editSuccess VE events from that period if that'd help?
[23:13:10] <James_F>	 The access to analytics is easy, it's the write action on prod that's hard. :-)
[23:13:28] <Krenair>	 I can deal with the write to prod
[23:13:38] <James_F>	 Sounds like a match made in heaven, then. :-)
[23:13:43] <James_F>	 Can you work out the timestamps involved?
[23:15:10] <Krenair>	 probably
[23:15:16] <Krenair>	 did this break on different wikis at different times?
[23:17:38] <James_F>	 Slightly (by a few seconds), but not much.
[23:17:58] <James_F>	 We'd want the addition to only happen if the tag isn't there.
[23:18:10] <James_F>	 Something like "SELECT id, timestamp, wiki, event_page.revid AS rev_id, event_page.title AS title FROM Edit_11448630 WHERE event_action = 'saveSuccess' AND event_editor = 'visualeditor' AND timestamp < 'X' AND timestamp > 'Y' ORDER BY wiki, id;"
[23:27:37] <neilpquinn>	 I could definitely do that. Krenair, what format would you like the dump in?
[23:28:40] <Krenair>	 csv of wiki,rev_id?
[23:39:55] <wikibugs>	 10VisualEditor, 6Community-Liaison, 7user-notice: Advertise VisualEditor's cool new features to existing editors - https://phabricator.wikimedia.org/T101211#1394783 (10Neil_P._Quinn_WMF)
[23:41:05] <wikibugs>	 10VisualEditor, 6Community-Liaison, 7user-notice: Advertise VisualEditor's cool new features to existing editors - https://phabricator.wikimedia.org/T101211#1332730 (10Neil_P._Quinn_WMF)
[23:41:08] <wikibugs>	 10VisualEditor, 6Design Research Backlog, 7Epic, 3VisualEditor 2015/16 Q1 blockers: Improve and streamline VisualEditor's user education features - https://phabricator.wikimedia.org/T101481#1394786 (10Neil_P._Quinn_WMF)
[23:42:04] <wikibugs>	 10VisualEditor, 6Design Research Backlog, 7Epic, 3VisualEditor 2015/16 Q1 blockers: Improve and streamline VisualEditor's user education features - https://phabricator.wikimedia.org/T101481#1340043 (10Neil_P._Quinn_WMF) @Quiddity, I removed T101211 as a blocker because I intended this task to be about educ...
[23:44:06] <grrrit-wm>	 (03CR) 10Esanders: "needs comment from Parsoid team" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/220028 (https://phabricator.wikimedia.org/T103430) (owner: 10Jforrester)