[00:20:25] (03PS9) 10Divec: WIP: Explicitly enter/exit link annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/217257 [00:22:24] (03CR) 10jenkins-bot: [V: 04-1] WIP: Explicitly enter/exit link annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/217257 (owner: 10Divec) [00:26:07] (03PS4) 10Divec: Cope with derived method call from base constructor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/221884 [00:26:20] (03CR) 10Divec: "Done" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/221884 (owner: 10Divec) [00:28:14] (03CR) 10jenkins-bot: [V: 04-1] Cope with derived method call from base constructor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/221884 (owner: 10Divec) [00:40:13] 10VisualEditor, 3VisualEditor 2015/16 Q1 blockers: Fix warning message template layout for Visual Editor - https://phabricator.wikimedia.org/T104409#1416280 (10Nirzar) 3NEW a:3Nirzar [00:42:06] (03PS5) 10Divec: Cope with derived method call from base constructor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/221884 [00:44:17] (03CR) 10jenkins-bot: [V: 04-1] Cope with derived method call from base constructor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/221884 (owner: 10Divec) [00:44:55] 10VisualEditor, 3VisualEditor 2015/16 Q1 blockers: Fix warning message template layout for Visual Editor - https://phabricator.wikimedia.org/T104409#1416290 (10Nirzar) [05:30:50] 10VisualEditor: VisualEditor will not load completely - TypeError: this.title[0] is undefined - at some articles with {{infobox country}} on enwiki - https://phabricator.wikimedia.org/T104377#1416506 (10Quiddity) Oh, I meant to add webconsole: ``` titles:[titles];state=state===undefined?true:!!state;var i,pages=... [05:36:11] 10VisualEditor: VisualEditor will not load completely - TypeError: this.title[0] is undefined - at some articles with {{infobox country}} on enwiki - https://phabricator.wikimedia.org/T104377#1416522 (10Quiddity) [05:36:47] 10VisualEditor: VisualEditor will not load completely - TypeError: this.title[0] is undefined - at some articles with {{infobox country}} on enwiki - https://phabricator.wikimedia.org/T104377#1414922 (10Quiddity) [05:49:09] 10VisualEditor, 10Wikimedia-General-or-Unknown, 7JavaScript, 3VisualEditor 2014/15 Q4 blockers, 7user-notice: JavaScript is broken on various wikis (after replacing deprecated escapeRE with mw.RegExp) - https://phabricator.wikimedia.org/T103498#1416538 (10Info-farmer) [https://ta.wikipedia.org/s/3t2z ta.... [06:57:51] 10WikiEditor: Media selector doesn't find local media in private wiki - https://phabricator.wikimedia.org/T65282#1416568 (10Fannon) I've got the same problem (on a private wiki). Couldn't change that with the proposed permission fix. Interestingly, If i type "*", it finds my image, if I type the name (or part... [07:01:36] 10WikiEditor: Media selector doesn't find local media in private wiki - https://phabricator.wikimedia.org/T65282#1416579 (10Fannon) I've just noticed that entering * triggers an endless flood of API requests, quite a few per second. **Using:** VisualEditor-REL1_25 MediaWiki 1.25.1 PHP 5.5.9-1ubuntu4.9 (apache2h... [08:34:42] (03PS1) 10Esanders: Unbreak i18n after new language added [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/222077 [08:36:59] (03CR) 10Esanders: [C: 032] "If i18n bot does it..." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/222077 (owner: 10Esanders) [08:37:21] (03PS6) 10Esanders: Cope with derived method call from base constructor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/221884 (owner: 10Divec) [08:39:12] (03Merged) 10jenkins-bot: Unbreak i18n after new language added [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/222077 (owner: 10Esanders) [08:39:35] (03CR) 10jenkins-bot: [V: 04-1] Cope with derived method call from base constructor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/221884 (owner: 10Divec) [08:39:49] (03PS7) 10Esanders: Cope with derived method call from base constructor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/221884 (owner: 10Divec) [08:42:12] (03CR) 10Esanders: WIP: Explicitly enter/exit link annotations (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/217257 (owner: 10Divec) [08:42:31] (03CR) 10Esanders: [C: 032] Cope with derived method call from base constructor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/221884 (owner: 10Divec) [08:44:55] (03Merged) 10jenkins-bot: Cope with derived method call from base constructor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/221884 (owner: 10Divec) [09:34:01] 10VisualEditor: VisualEditor will not load completely - TypeError: this.title[0] is undefined - at some articles with {{infobox country}} on enwiki - https://phabricator.wikimedia.org/T104377#1416754 (10TheDJ) undefined is not an object (evaluating 'this.title[0].toUpperCase') This sounds like a bug in a replac... [11:01:23] 10VisualEditor, 10Wikimedia-General-or-Unknown, 7JavaScript, 3VisualEditor 2014/15 Q4 blockers, 7user-notice: JavaScript is broken on various wikis (after replacing deprecated escapeRE with mw.RegExp) - https://phabricator.wikimedia.org/T103498#1416937 (10Aklapper) @Info-farmer: For that "File Upload Wiz... [11:13:44] (03PS1) 10Esanders: Make toolbar save button frameless [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/222094 (https://phabricator.wikimedia.org/T101165) [13:37:26] 10Citoid: Improve Zotero Validation - https://phabricator.wikimedia.org/T101878#1417165 (10Mvolz) [13:38:23] 10Citoid: Improve Zotero Validation - https://phabricator.wikimedia.org/T101878#1350276 (10Mvolz) [13:39:25] 10Citoid: Add crossref metadata request to lib/Scraper.js - https://phabricator.wikimedia.org/T103238#1417177 (10Mvolz) a:3Mvolz [15:28:39] Krenair: https://phabricator.wikimedia.org/T104377 might be easy to fix, I dunno? [15:30:12] James_F, I looked at that once and was confused because I got a different error to the reporter [15:30:46] Krenair: In debug mode, it's clear that mw.Title isn't happy parsing ".foo" as a title. I imagine that's fixable? [15:30:54] Krenair: (but I could be missing something.) [15:31:10] probably [15:33:23] Probably missing something? ;-) [15:33:38] (03PS1) 10Esanders: Fix typo in CSS [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/222130 [15:34:00] edsanders: Surely that causes a bug? [15:34:09] es [15:34:11] yes [15:34:19] But nothing in Phabricator? Or just not looked? [15:34:26] padding is off when screen width is low [15:34:29] (Happy to look for you.) [15:34:57] it was only yesterday [15:35:03] you merged it remember [15:35:12] Oh, yes. [15:35:13] * James_F sighs. [15:35:18] I'm clearly still ill. [15:35:24] (03CR) 10Jforrester: [C: 032] Fix typo in CSS [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/222130 (owner: 10Esanders) [15:35:29] and it only occurs in "non-HD" mode (<982px) which no one actually uses [15:35:56] (03PS2) 10Jforrester: ViewPageTarget-vector.css: Fix non-HD mode typo [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/222130 (owner: 10Esanders) [15:36:05] (03CR) 10Jforrester: [C: 032] ViewPageTarget-vector.css: Fix non-HD mode typo [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/222130 (owner: 10Esanders) [15:37:45] it tries to do ucfirst [15:37:57] but that won't work as this.title is an empty string [15:43:44] (03Merged) 10jenkins-bot: ViewPageTarget-vector.css: Fix non-HD mode typo [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/222130 (owner: 10Esanders) [15:46:11] (03PS4) 10Jforrester: Show as surface placeholder, not an edit notice [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/221893 (https://phabricator.wikimedia.org/T104227) (owner: 10Alex Monk) [15:46:16] (03CR) 10Jforrester: [C: 032] Show as surface placeholder, not an edit notice [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/221893 (https://phabricator.wikimedia.org/T104227) (owner: 10Alex Monk) [15:47:44] did you test that locally by the way, James_F? [15:48:09] Krenair: Yeah, it seemed to work for me. [15:48:14] Krenair: Why did you have worries? [15:48:19] * James_F can abort. [15:48:34] the placeholder sort of appeared a bit lower than I was expecting [15:48:40] not an issue with my code, obviously :) [15:48:55] Oh, yeah, Ed tweaked the position of placeholders. Might want to reconsider. Meh. [15:49:14] (03Merged) 10jenkins-bot: Show as surface placeholder, not an edit notice [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/221893 (https://phabricator.wikimedia.org/T104227) (owner: 10Alex Monk) [15:53:41] is wikibugs dead again? [15:56:30] Probably. [16:35:51] 10VisualEditor: VisualEditor not loading at all - mw.libs.ve.targetLoader.requestPageData/restbasePromise - https://phabricator.wikimedia.org/T104376#1417927 (10Quiddity) 5Open>3Resolved a:3Quiddity Works for me now. Closing as no-longer reproduceable. [16:35:57] 10VisualEditor: VisualEditor not loading at all - mw.libs.ve.targetLoader.requestPageData/restbasePromise - https://phabricator.wikimedia.org/T104376#1417931 (10Quiddity) a:5Quiddity>3None [16:48:32] (03PS11) 10Jforrester: Use Parsoid's new Cite HTML and CSS [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207483 (https://phabricator.wikimedia.org/T86782) (owner: 10Marcoil) [16:50:22] (03CR) 10Jforrester: [C: 031] "Good to go? We need this merged into master before Parsoid deploys their change which uses it to avoid visual confusion." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207483 (https://phabricator.wikimedia.org/T86782) (owner: 10Marcoil) [17:26:59] Krenair: Are there unit tests for mw.Title? [17:27:54] hm [17:28:06] Krenair: If yes, guess what my code review is. :-) [17:28:23] https://github.com/wikimedia/mediawiki/blob/master/tests/qunit/suites/resources/mediawiki/mediawiki.Title.test.js [17:28:38] Hmm. [17:28:43] (being pulled away by family to do something else, back in ~15 minutes) [17:28:44] It has '.com' as a valid test title. [17:28:49] * James_F nods. [17:29:36] (03PS1) 10Dduvall: WIP QA: Upgrading to mw-selenium 1.x [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/222143 [17:31:40] (03CR) 10jenkins-bot: [V: 04-1] WIP QA: Upgrading to mw-selenium 1.x [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/222143 (owner: 10Dduvall) [17:34:04] (03PS2) 10Jforrester: IME tests: Add Ubuntu IBus Japanese Mozc [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/221800 (owner: 10Divec) [17:36:38] (03CR) 10Jforrester: [C: 032] "PS2 adds the files to modules.json." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/221800 (owner: 10Divec) [17:39:09] (03Merged) 10jenkins-bot: IME tests: Add Ubuntu IBus Japanese Mozc [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/221800 (owner: 10Divec) [17:48:52] (03CR) 10Esanders: "Is there a bug/follow up commit that uses this?" [unicodejs] - 10https://gerrit.wikimedia.org/r/221323 (owner: 10Divec) [18:07:05] (03CR) 10Jforrester: "@Ed: T104472." [unicodejs] - 10https://gerrit.wikimedia.org/r/221323 (owner: 10Divec) [18:07:38] (03PS5) 10Divec: Strong directionality support [unicodejs] - 10https://gerrit.wikimedia.org/r/221323 (https://phabricator.wikimedia.org/T104472) [18:36:19] (03PS6) 10Divec: WIP: Cursoring: find adjacent position in DOM order [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/217222 [18:36:46] (03PS10) 10Divec: WIP: Explicitly enter/exit link annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/217257 [18:38:54] (03CR) 10jenkins-bot: [V: 04-1] WIP: Explicitly enter/exit link annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/217257 (owner: 10Divec) [18:39:02] 10VisualEditor, 10VisualEditor-Performance, 10Parsoid, 10RESTBase, 7RESTBase-API: RFC: API for retrieval and saving of top-level HTML elements / sections by element ID - https://phabricator.wikimedia.org/T94890#1418295 (10mobrovac) >>! In T94890#1410095, @Pchelolo wrote: > Created a PR for html->wikitext... [18:42:51] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic: Provide a single edit tab which has both VisualEditor and wikitext modes and allows on-the-fly switching without saving - https://phabricator.wikimedia.org/T102398#1418317 (10Jdforrester-WMF) [18:42:54] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic, 3VisualEditor 2015/16 Q1 blockers: VisualEditor: Where VisualEditor is the primary editor, redlinks in read mode should open VE (not wikitext editor) - https://phabricator.wikimedia.org/T55441#1418316 (10Jdforrester-WMF) [18:43:05] 10VisualEditor, 10VisualEditor-MediaWiki, 10RESTBase, 7Epic, and 2 others: VisualEditor: Provide a way for the user to switch between VisualEditor and wikitext source editor modes without saving - https://phabricator.wikimedia.org/T49779#1418319 (10Jdforrester-WMF) [18:43:07] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic, 3VisualEditor 2015/16 Q1 blockers: VisualEditor: Where VisualEditor is the primary editor, redlinks in read mode should open VE (not wikitext editor) - https://phabricator.wikimedia.org/T55441#560865 (10Jdforrester-WMF) [18:53:17] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic: Provide a modern wikitext editor - https://phabricator.wikimedia.org/T104479#1418337 (10Jdforrester-WMF) 3NEW [18:57:21] 10VisualEditor, 10VisualEditor-MediaWiki, 10RESTBase, 7Epic, and 2 others: VisualEditor: Provide a way for the user to switch between VisualEditor and wikitext source editor modes without saving - https://phabricator.wikimedia.org/T49779#1418344 (10Krenair) >>! In T49779#1172521, @Jdforrester-WMF wrote: >>... [19:07:35] 10VisualEditor, 10Browser-Tests: Update VisualEditor repository to mediawiki_selenium Ruby gem 1.1 - https://phabricator.wikimedia.org/T99661#1418352 (10Ryasmeen) a:3dduvall [19:11:07] (03PS1) 10Jforrester: Update OOjs UI to v0.11.7 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/222163 [19:16:42] (03CR) 10Trevor Parscal: [C: 032] Update OOjs UI to v0.11.7 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/222163 (owner: 10Jforrester) [19:30:59] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-General-or-Unknown, 7JavaScript, 5Patch-For-Review: Links to [[.ar]] etc. inside a transclusion throw an error from ve.ce.MWTransclusionNode:178 as the href makes mw.Title break - https://phabricator.wikimedia.org/T104377#1418421 (10Krenair) 5Open>... [19:37:16] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-General-or-Unknown, 7JavaScript, 5Patch-For-Review: Links to [[.ar]] etc. inside a transclusion throw an error from ve.ce.MWTransclusionNode:178 as the href makes mw.Title break - https://phabricator.wikimedia.org/T104377#1418451 (10Jdforrester-WMF) C... [19:37:29] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-General-or-Unknown, 7JavaScript, 3VisualEditor 2015/16 Q1 blockers: Links to [[.ar]] etc. inside a transclusion throw an error from ve.ce.MWTransclusionNode:178 as the href makes mw.Title break - https://phabricator.wikimedia.org/T104377#1418452 (10Jdf... [19:37:34] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-General-or-Unknown, 7JavaScript, 3VisualEditor 2015/16 Q1 blockers: Links to [[.ar]] etc. inside a transclusion throw an error from ve.ce.MWTransclusionNode:178 as the href makes mw.Title break - https://phabricator.wikimedia.org/T104377#1414922 (10Jdf... [19:38:37] (03Merged) 10jenkins-bot: Update OOjs UI to v0.11.7 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/222163 (owner: 10Jforrester) [19:38:41] 10VisualEditor, 6Community-Liaison: Deliver a "translation table" to some Phase 5 wikis - https://phabricator.wikimedia.org/T96845#1418461 (10Jdforrester-WMF) [20:31:58] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 7Verified-in-Phase0, 5WMF-deploy-2015-06-30_(1.26wmf12): [Regression pre-wmf12] Link inspector won't close on escape/cancel/done, remains zombied - https://phabricator.wikimedia.org/T104231#1418637 (10Ryasmeen) [20:32:42] 10Cite, 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References, and 3 others: Basic reference shouldn't appear in catch-all group - https://phabricator.wikimedia.org/T101130#1418649 (10Ryasmeen) [20:33:26] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References, 7Verified-in-Phase0, 5WMF-deploy-2015-06-30_(1.26wmf12): Remember last used tab (auto/manual/re-use) on citation tool in a hidden preference and open to that one next time - https://phabricator.wikimedia.org/T103582#1418652 (10Ryasmeen) [20:34:28] 10VisualEditor, 10VisualEditor-MediaWiki-References, 7Verified-in-Phase0, 5WMF-deploy-2015-06-30_(1.26wmf12): Text in reference inspectors cannot be selected - https://phabricator.wikimedia.org/T104184#1418653 (10Ryasmeen) [20:40:35] 10VisualEditor, 10VisualEditor-MediaWiki-References, 7Browser-Support-Firefox, 5WMF-deploy-2015-06-30_(1.26wmf12): Right-clicking on the reference inspector offers to search Google for "☢" - https://phabricator.wikimedia.org/T104185#1418659 (10Ryasmeen) 5Resolved>3Open This is still happening for two o... [21:07:33] 10VisualEditor, 10VisualEditor-EditingTools, 6Collaboration-Team, 7JavaScript, 3Reading-Web: Add user settings frontend JavaScript API - https://phabricator.wikimedia.org/T96155#1418742 (10Jdlrobson) [21:12:57] 10VisualEditor, 10VisualEditor-MediaWiki-References, 7Browser-Support-Firefox, 5WMF-deploy-2015-06-30_(1.26wmf12): Right-clicking on the reference inspector offers to search Google for "☢" - https://phabricator.wikimedia.org/T104185#1418798 (10Thryduulf) I'm also seeing it when right-clicking on a template... [22:45:56] (03CR) 10Jforrester: [C: 032] Make toolbar save button frameless [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/222094 (https://phabricator.wikimedia.org/T101165) (owner: 10Esanders) [22:46:22] 10VisualEditor, 6Design Research Backlog, 7Design, 3VisualEditor 2015/16 Q1 blockers: Emphasize VE's save button by animating the progress bar attached to the bottom of the toolbar - https://phabricator.wikimedia.org/T99274#1419100 (10Jdforrester-WMF) [22:46:25] 10VisualEditor, 10VisualEditor-MediaWiki, 10OOjs-UI, 7Design, and 2 others: Make the save page button flush to the toolbar - https://phabricator.wikimedia.org/T101165#1419098 (10Jdforrester-WMF) 5Open>3Resolved a:3Esanders [22:46:39] 10VisualEditor, 10VisualEditor-MediaWiki, 10OOjs-UI, 7Design, and 2 others: Make the save page button flush to the toolbar - https://phabricator.wikimedia.org/T101165#1331691 (10Jdforrester-WMF) [22:48:18] (03Merged) 10jenkins-bot: Make toolbar save button frameless [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/222094 (https://phabricator.wikimedia.org/T101165) (owner: 10Esanders) [22:57:56] 10VisualEditor, 10VisualEditor-MediaWiki, 10OOjs-UI, 7Design, and 2 others: Make the save page button flush to the toolbar - https://phabricator.wikimedia.org/T101165#1419150 (10Jdforrester-WMF) [23:11:03] 10VisualEditor, 6Collaboration-Team, 10Flow, 7I18n: visualeditor-wikitext-warning must be different for Flow - https://phabricator.wikimedia.org/T103971#1419181 (10DannyH) p:5Triage>3Normal [23:11:09] 10VisualEditor, 6Collaboration-Team, 10Flow, 7I18n: visualeditor-wikitext-warning must be different for Flow - https://phabricator.wikimedia.org/T103971#1419183 (10Catrope) [23:25:01] 10VisualEditor, 10VisualEditor-MediaWiki: VE treats interwiki links as external links - https://phabricator.wikimedia.org/T103636#1419243 (10Krenair) [23:27:40] 10VisualEditor, 10VisualEditor-MediaWiki: VE treats interwiki links as external links - https://phabricator.wikimedia.org/T103636#1419254 (10Krenair) I made an interwiki link like [[wikipedia:asdwqe]], it showed up without the external icon, then when I opened it in VE it had the external icon... And when I we... [23:34:08] 10VisualEditor, 6Collaboration-Team, 10Flow: Ctrl-Home doesn't allow further typing in VisualEditor in Flow posts - https://phabricator.wikimedia.org/T103494#1419279 (10Catrope) p:5Triage>3High [23:50:54] 10VisualEditor, 10VisualEditor-MediaWiki: VE treats interwiki links as external links - https://phabricator.wikimedia.org/T103636#1419346 (10Krenair) Apparently this is a #Parsoid thing: `