[01:57:06] (03PS13) 10Jforrester: Add a clean-up script for use as a pre-commit hook [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118758 [02:30:43] 10TemplateData, 10VisualEditor, 10VisualEditor-EditingTools: TemplateData could mark meta templates, so they can be filtered out from autosuggest - https://phabricator.wikimedia.org/T97757#1423721 (10Whatamidoing-WMF) See http://imgur.com/UciVLHL for a screenshot that shows (with red dots) a list of pages in... [02:42:53] 10TemplateData: Please make "required" display as bold-face in the TemplateData block on a template's documentation - https://phabricator.wikimedia.org/T104674#1423736 (10Whatamidoing-WMF) 3NEW [04:19:12] Glaisher, would you have a link? I can't find that VisualEditor Edit failure bug discussed at https://lists.wikimedia.org/pipermail/wikitech-l/2015-July/thread.html (nor June) [05:39:09] 10VisualEditor: VisualEditor hangs while opening - https://phabricator.wikimedia.org/T97346#1423927 (10Whatamidoing-WMF) 5Open>3Resolved a:3Whatamidoing-WMF [06:13:54] 10MediaWiki-extensions-Graph-VE: Weekly reports for "Enable VisualEditor support in Graph extension" - https://phabricator.wikimedia.org/T101119#1423972 (10NiharikaKohli) Hey @ferdbold. Keep the reports updated, please. [07:36:09] 10MediaWiki-extensions-Graph-VE: Weekly reports for "Enable VisualEditor support in Graph extension" - https://phabricator.wikimedia.org/T101119#1424058 (10Mvolz) @NiharikaKohli, @ferdbold has moved recently (which he notified us of ahead of time) and has only gotten internet access as of yesterday, I'm sure we'... [07:40:38] 10VisualEditor, 10Parsoid: https://en.wikipedia.org/wiki/User:Amire80/single_break_nowiki cannot be edited in VE in Chrome - https://phabricator.wikimedia.org/T104557#1424059 (10Elitre) Just to confirm how weird the situation is with that page, I just saved a test edit there with Chrome, then undid it, and for... [07:58:05] Whoever doesn't observe the office holiday today, can you please let me know why edits like https://en.wikipedia.org/w/index.php?title=User:Amire80/single_break_nowiki&diff=next&oldid=669615507 don't trigger a nowiki filter? [08:06:11] 10VisualEditor: visualeditor-dialog-media-dimensionseparator contains trailing whitespace - https://phabricator.wikimedia.org/T104691#1424086 (10Nikerabbit) 3NEW [08:06:49] (03PS1) 10Legoktm: Revert "Use new MediaWiki core TitleInputWidget" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/222550 [08:06:53] (03CR) 10jenkins-bot: [V: 04-1] Revert "Use new MediaWiki core TitleInputWidget" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/222550 (owner: 10Legoktm) [08:10:19] (03PS2) 10Legoktm: Revert "Use new MediaWiki core TitleInputWidget" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/222550 [08:14:08] 10MediaWiki-extensions-Graph-VE: Weekly reports for "Enable VisualEditor support in Graph extension" - https://phabricator.wikimedia.org/T101119#1424100 (10NiharikaKohli) @mvolz, okay, thanks for informing me! [08:55:53] 10VisualEditor, 10WikiEditor, 6WMF-Design-Research, 7Easy, and 2 others: Tooltip text on the "Edit" and "Edit Source" tabs should be more helpful to new users - https://phabricator.wikimedia.org/T99271#1424117 (10Nemo_bis) Cf. d42ab1f94b54b69897fb8fd233e18a765e25f8a1 [10:08:26] (03PS1) 10Esanders: Remove unused dependency [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/222557 [10:52:58] 10VisualEditor, 10VisualEditor-MediaWiki, 10OOjs-UI, 7Design, and 2 others: Make the save page button flush to the toolbar - https://phabricator.wikimedia.org/T101165#1331691 (10matmarex) [11:32:18] "padding: 1.1953125em 0.3125em;" [11:32:32] edsanders needs therapy :> [11:54:52] * edsanders needs LESS processing [12:00:50] (03PS1) 10Esanders: Use core dimension widget times separator [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/222569 (https://phabricator.wikimedia.org/T104691) [12:03:02] (03CR) 10jenkins-bot: [V: 04-1] Use core dimension widget times separator [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/222569 (https://phabricator.wikimedia.org/T104691) (owner: 10Esanders) [12:05:20] MatmaRex, the other case for buttons is process dialogs [12:06:03] there may be a case for supporting both in that case [12:06:54] edsanders: hmm. i'd argue that should also belong to the dialogs' styles [12:07:02] edsanders: or to ActionWidget's, i guess [12:07:14] yes - but we may need to support both modes [12:07:34] why? [12:08:05] because we may not be able to use frameless on desktop [12:08:14] but probably should on mobile [12:08:43] why not on desktop? that might actually look better for dialogs than the current buttons [12:09:41] it was said that they conflict with framed buttons elsewhere in the dialog [12:09:55] we had to back out such as change last year [12:10:54] hmm [12:10:56] hmm - oojsui isn't building for me [12:10:59] eh [12:11:10] >> Source file "dist/oojs-ui-apex-noimages.raster.css" not found. [12:11:21] edsanders: the build process got rejiggered [12:11:22] oh, hmm [12:11:44] the only other error is [12:11:45] Loading "grunt-karma.js" tasks...ERROR [12:11:45] >> Error: Cannot find module 'socket.io' [12:12:31] eh, why is that a source file? [12:14:17] (builds for me) [12:14:33] all the paths in the demo seem wrong too [12:14:33] (you also need to run `npm run demos` afterwards for the demo to work, apparently) [12:14:45] oh, since when? [12:15:00] since early morning today [12:15:12] i think it could work better, filed https://phabricator.wikimedia.org/T104696 [12:19:53] See "Process dialog (frameless buttons)" [12:20:28] it should probably be a flag on the ActionWidget (passed through the dialog config) [12:20:47] and support primary [12:21:12] oh, i've never seen that. i didn't know that we even support it. [12:21:39] it's newish [12:21:46] (03PS2) 10Esanders: Use core dimension widget times separator [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/222569 (https://phabricator.wikimedia.org/T104691) [12:22:28] James has been +2 trigger happy, you need to keep an eye on my review queue :) [12:26:04] edsanders: hmm, we might need to revert the patch that added 'framed: false' for the button in VE [12:26:20] yup [12:26:59] 10VisualEditor, 10VisualEditor-MediaWiki, 10OOjs-UI, 7Design, and 2 others: Make the save page button flush to the toolbar - https://phabricator.wikimedia.org/T101165#1424502 (10matmarex) [12:40:35] wtf variable names: [12:40:36] foreach ( $cached->getLinks() as $ns => $dbks ) { [12:40:36] foreach ( $dbks as $dbk => $id ) { [12:40:36] $pft = Title::makeTitle( $ns, $dbk )->getPrefixedText(); [12:40:36] if ( $id == 0 ) { [12:40:36] $links['missing'][] = $pft; [12:40:38] } elseif ( $restoring ) { [12:40:40] $links['extant'][] = $pft; [12:40:42] } [12:40:44] } [12:40:46] } [12:41:46] dbks is apparently "Database keys" [12:42:13] no idea what $pft [12:42:18] are we rationing letters? [12:49:35] :D prefixed text, i guess [13:22:33] (03PS1) 10Esanders: Check if links are 'known' rather than 'exist' locally [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/222589 (https://phabricator.wikimedia.org/T104604) [14:30:25] 10VisualEditor: this.model.getOuterRange is not a function - https://phabricator.wikimedia.org/T104580#1424803 (10Esanders) How are you triggering this bug? this.model should be a ve.dm.Node which implements the method. [14:32:30] 10VisualEditor: this.model.getOuterRange is not a function - https://phabricator.wikimedia.org/T104580#1424808 (10Nischayn22) I have a VE plugin for SemanticMediaWiki extension that calls getFragment() See https://en.wikipedia.org/wiki/User:Nischayn22/veSMW.js [14:35:11] edsanders, MatmaRex: hi. 2 things. [14:35:34] https://phabricator.wikimedia.org/T104377 is marked as fixed, but I can still reproduce? [14:36:04] also, shouldn't edits like https://en.wikipedia.org/w/index.php?title=User:Amire80/single_break_nowiki&diff=next&oldid=669615507 trigger a nowiki filter? [14:36:07] thank you! [14:46:22] (sorry, I see now about the first question that the fix is meant for next week.) [14:56:37] There are several reports about that task, and I'm surprised it's not backported. [15:02:59] 10VisualEditor, 10Parsoid: https://en.wikipedia.org/wiki/User:Amire80/single_break_nowiki cannot be edited in VE in Chrome - https://phabricator.wikimedia.org/T104557#1424921 (10Elitre) A similar issue is [[ https://en.wikipedia.org/wiki/Wikipedia:VisualEditor/Feedback#cannot_open_article_using_the_visual_edit... [15:30:14] (03CR) 10Alex Monk: "Okay, so this will probably deal with existing links when we open VE, but what about new ones? Also this sounds like T72123" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/222589 (https://phabricator.wikimedia.org/T104604) (owner: 10Esanders) [15:30:51] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 5Patch-For-Review: Valid (blue) links to Commons’ images display as red - https://phabricator.wikimedia.org/T104604#1424960 (10Krenair) Sounds like this is part of T72123 [15:51:22] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 5Patch-For-Review: Valid (blue) links to Commons’ images display as red - https://phabricator.wikimedia.org/T104604#1425011 (10Jdforrester-WMF) [15:51:23] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Links, 7Browser-Support-Firefox: VisualEditor: Direct link to a non-extant local file ([[:File:Foo]]) is red even if there is an extant file in a remote repo - https://phabricator.wikimedia.org/T65355#1425012 (10Jdforrester-WMF) [15:51:55] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Links: Direct link to a non-extant local file ([[:File:Foo]]) is red even if there is an extant file in a remote repo - https://phabricator.wikimedia.org/T65355#1425014 (10Jdforrester-WMF) a:3Esanders [15:52:16] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 5Patch-For-Review: Valid (blue) links to Commons’ images display as red - https://phabricator.wikimedia.org/T104604#1421989 (10Jdforrester-WMF) Actually… [15:52:46] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 5Patch-For-Review: Check if links are 'known' rather than 'exist' locally - https://phabricator.wikimedia.org/T104604#1425022 (10Jdforrester-WMF) 5duplicate>3Open [15:53:35] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 5Patch-For-Review: Check if links are 'known' rather than 'exist' locally - https://phabricator.wikimedia.org/T104604#1421989 (10Jdforrester-WMF) [15:53:36] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Links: Direct link to a non-extant local file ([[:File:Foo]]) is red even if there is an extant file in a remote repo - https://phabricator.wikimedia.org/T65355#1425029 (10Jdforrester-WMF) [15:53:44] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 5Patch-For-Review: Check if links are 'known' rather than 'exist' locally - https://phabricator.wikimedia.org/T104604#1421989 (10Jdforrester-WMF) [15:53:46] 10VisualEditor, 10VisualEditor-MediaWiki, 10GlobalUserPage, 10MediaWiki-extensions-EducationProgram: VisualEditor redlink detection should obey TitleIsAlwaysKnown hook (so that EducationProgram pages and GlobalUserPage links render correctly) - https://phabricator.wikimedia.org/T72123#1425031 (10Jdforrester... [15:55:50] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Links, 7Regression: Link inspector input wrongly shown as "does not exist" when redirect exists - https://phabricator.wikimedia.org/T101611#1425039 (10Jdforrester-WMF) [15:55:50] 10VisualEditor, 10VisualEditor-MediaWiki-Links: Work out what VisualEditor should do (if anything) if search lies and claims a link doesn't exist when it does - https://phabricator.wikimedia.org/T98612#1425040 (10Jdforrester-WMF) [15:56:43] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 10OOjs-UI: TextInputWidget icon/indicator use the "pointer" (hand) mouse cursor, but don't do anything button-like - https://phabricator.wikimedia.org/T98213#1425043 (10Jdforrester-WMF) p:5Normal>3Low a:5Esanders>3None [15:57:34] 10VisualEditor, 7Design, 3VisualEditor 2015/16 Q1 blockers: Increase width of inspectors on desktop - https://phabricator.wikimedia.org/T101290#1425045 (10Jdforrester-WMF) Would partially address {T59200}. [15:59:52] 10VisualEditor, 6Collaboration-Team, 10Flow, 10MediaWiki-Interface: Style invalid TitleInputWidgets - https://phabricator.wikimedia.org/T74970#1425056 (10Jdforrester-WMF) [16:00:09] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 10VisualEditor-MediaWiki-Templates: Red links inside templates should display as red - https://phabricator.wikimedia.org/T104602#1425061 (10Jdforrester-WMF) [16:00:10] 10VisualEditor, 10VisualEditor-MediaWiki: VisualEditor: Blue link / red link logic should descend into links inside non-transclusion generated content nodes - https://phabricator.wikimedia.org/T73900#1425062 (10Jdforrester-WMF) [16:07:53] 10VisualEditor, 10Parsoid: https://en.wikipedia.org/wiki/User:Amire80/single_break_nowiki cannot be edited in VE in Chrome - https://phabricator.wikimedia.org/T104557#1425086 (10Amire80) And on a few pages in the Hebrew Wikipedia today. I happened to mostly test drafts in user space, but I'm not sure that it's... [16:12:59] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: When providing a list of potential links, show redirects' destinations, not just that they are redirects - https://phabricator.wikimedia.org/T67890#1425088 (10Jdforrester-WMF) 5Open>3Resolved a:3Jdforrester-WMF This was fixed a while ago. [16:20:59] 10VisualEditor, 10VisualEditor-MediaWiki: VisualEditor: Blue link / red link logic should descend into links inside non-transclusion generated content nodes - https://phabricator.wikimedia.org/T73900#1425106 (10Jdforrester-WMF) [16:21:00] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Templates: When I changed the website link in an infobox all other links got redlinks - https://phabricator.wikimedia.org/T78472#1425105 (10Jdforrester-WMF) [16:23:20] 10VisualEditor, 10VisualEditor-EditingTools, 7Design: Make lighter icons for the bullet/numbered list controls, in keeping with wider icon theme (and indent/outdent icons) - https://phabricator.wikimedia.org/T78084#1425108 (10Jdforrester-WMF) 5Open>3Resolved a:3Jdforrester-WMF Done as part of switching... [16:29:08] (03CR) 10Jforrester: Use core dimension widget times separator (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/222569 (https://phabricator.wikimedia.org/T104691) (owner: 10Esanders) [16:30:05] 10VisualEditor, 6Collaboration-Team, 10Flow: betalabs: Existing pages for File internal links are displayed red in VE - https://phabricator.wikimedia.org/T97830#1425116 (10Jdforrester-WMF) Maybe this is {T65355}? [16:31:28] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-Links: Search results (for links, redirects, categories…) should select the exact match by default - https://phabricator.wikimedia.org/T71716#1425118 (10Jdforrester-WMF) [16:34:52] 10VisualEditor, 10VisualEditor-MediaWiki: Release VisualEditor-MediaWiki as "1.0" - https://phabricator.wikimedia.org/T84936#1425125 (10Jdforrester-WMF) [16:34:54] 10VisualEditor, 10VisualEditor-ContentLanguage: Japanese text disappears (kanji and maybe hiragana, not katakana) when you are writing list entries - https://phabricator.wikimedia.org/T78118#1425122 (10Jdforrester-WMF) 5Open>3Resolved a:3Jdforrester-WMF As far as I can tell, this issue and other Japanese... [16:35:29] 10VisualEditor, 10VisualEditor-ContentLanguage: VisualEditor: Text in Japanese disappears - https://phabricator.wikimedia.org/T74619#1425126 (10Jdforrester-WMF) As far as I can tell, this issue and other Japanese text entry issues are all now fixed. Sorry it took so long to confirm! >>! In T74619#977974, @Yuk... [16:40:00] 10VisualEditor, 10VisualEditor-MediaWiki: Release VisualEditor-MediaWiki as "1.0" - https://phabricator.wikimedia.org/T84936#1425133 (10Jdforrester-WMF) [16:40:02] 10VisualEditor, 10VisualEditor-ContentLanguage: VisualEditor: a line started with Japanese input disappear when I switch to and start non-Japanese (latin) input - https://phabricator.wikimedia.org/T74508#1425130 (10Jdforrester-WMF) 5Open>3Resolved a:3Jdforrester-WMF As far as I can tell, this issue and o... [16:40:38] 10VisualEditor, 10VisualEditor-MediaWiki: Release VisualEditor-MediaWiki as "1.0" - https://phabricator.wikimedia.org/T84936#934150 (10Jdforrester-WMF) [16:40:39] 10VisualEditor, 10VisualEditor-ContentLanguage: VisualEditor: Text in Japanese disappears - https://phabricator.wikimedia.org/T74619#1425141 (10Jdforrester-WMF) 5Open>3Resolved a:3Jdforrester-WMF [16:52:22] 10VisualEditor, 6Collaboration-Team, 10Flow: Explore ideas for collaborative contribution - https://phabricator.wikimedia.org/T103081#1425161 (10Pginer-WMF) [17:09:09] 10VisualEditor: Enable VisualEditor for the Portal namespace at the Japanese Wikipedia - https://phabricator.wikimedia.org/T97313#1425176 (10Jdforrester-WMF) >>! In T97313#1287730, @Miya wrote: > @Jdforrester-WMF: VisualEditor works well enough these days - at least for me and other (perhaps "relatively new") us... [17:15:12] (03CR) 10Raimond Spekking: "@James: no idea what happened here. I will verify today's export. If broken again I will revert and check for reason on monday as I am in " [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/222470 (owner: 10Jforrester) [17:16:26] 10VisualEditor, 10VisualEditor-ContentLanguage: VisualEditor: Cannot type in Korean using Mozilla on Windows 7 with dual-script keyboard - https://phabricator.wikimedia.org/T72353#1425188 (10Jdforrester-WMF) [17:16:57] 10VisualEditor, 10VisualEditor-ContentLanguage, 7I18n: VisualEditor: CE eats up syllables except a last syllable of a word in Korean IME - https://phabricator.wikimedia.org/T52631#578634 (10Jdforrester-WMF) [17:24:25] 10VisualEditor, 5Patch-For-Review: visualeditor-dialog-media-dimensionseparator contains trailing whitespace - https://phabricator.wikimedia.org/T104691#1425219 (10Jdforrester-WMF) Should we instead make the message "`$1 × $2`" so that languages which don't want spaces there can remove them? Or just put them i... [17:25:02] (03PS5) 10Divec: ve.FrozenSelection: DOM selection data class [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/222221 (https://phabricator.wikimedia.org/T104517) [17:27:31] (03CR) 10jenkins-bot: [V: 04-1] ve.FrozenSelection: DOM selection data class [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/222221 (https://phabricator.wikimedia.org/T104517) (owner: 10Divec) [17:28:11] (03PS2) 10Divec: ve.adjustLinkSelection: fixup link-bisecting selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/222488 [17:30:35] (03CR) 10jenkins-bot: [V: 04-1] ve.adjustLinkSelection: fixup link-bisecting selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/222488 (owner: 10Divec) [17:30:55] (03PS3) 10Divec: ve.ce.adjustLinkSelection: fixup link-bisecting selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/222488 [17:32:34] (03PS1) 10Divec: WIP: Fixup links [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/222619 [17:33:08] (03CR) 10jenkins-bot: [V: 04-1] ve.ce.adjustLinkSelection: fixup link-bisecting selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/222488 (owner: 10Divec) [17:34:35] (03PS6) 10Divec: ve.FrozenSelection: DOM selection data class [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/222221 (https://phabricator.wikimedia.org/T104517) [17:35:00] (03CR) 10jenkins-bot: [V: 04-1] WIP: Fixup links [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/222619 (owner: 10Divec) [17:35:04] (03PS4) 10Divec: ve.ce.adjustLinkSelection: fixup link-bisecting selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/222488 [17:35:24] (03PS2) 10Divec: WIP: Fixup links [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/222619 [17:37:26] (03CR) 10jenkins-bot: [V: 04-1] ve.ce.adjustLinkSelection: fixup link-bisecting selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/222488 (owner: 10Divec) [17:37:48] (03CR) 10jenkins-bot: [V: 04-1] WIP: Fixup links [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/222619 (owner: 10Divec) [17:37:52] 10VisualEditor, 5Patch-For-Review: visualeditor-dialog-media-dimensionseparator contains trailing whitespace - https://phabricator.wikimedia.org/T104691#1425228 (10Jdforrester-WMF) p:5Triage>3Normal [17:39:22] (03CR) 10Jforrester: "> @James: no idea what happened here. I will verify today's export. If broken again I will revert and check for reason on monday as I am i" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/222470 (owner: 10Jforrester) [17:44:01] 10VisualEditor, 10VisualEditor-ContentLanguage, 10VisualEditor-MediaWiki: In the visual editor, pressing ⌫ (Erase) 3 times erases 4 characters - https://phabricator.wikimedia.org/T95865#1425241 (10Jdforrester-WMF) [17:44:18] 10VisualEditor, 10VisualEditor-ContentLanguage, 10VisualEditor-MediaWiki, 7Browser-Support-Apple-Safari: In the visual editor, pressing ⌫ (Erase) 3 times erases 4 characters - https://phabricator.wikimedia.org/T95865#1201973 (10Jdforrester-WMF) [17:45:53] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 10CirrusSearch, 6Discovery, and 2 others: [Regression] Redirects no longer indexed in search suggestions - https://phabricator.wikimedia.org/T88621#1425247 (10Jdforrester-WMF) p:5Normal>3High [17:46:51] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 5Patch-For-Review, 3VisualEditor 2015/16 Q1 blockers: Check if links are 'known' rather than 'exist' locally - https://phabricator.wikimedia.org/T104604#1425249 (10Jdforrester-WMF) [17:46:57] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 5Patch-For-Review, 3VisualEditor 2015/16 Q1 blockers: Check if links are 'known' rather than 'exist' locally - https://phabricator.wikimedia.org/T104604#1421989 (10Jdforrester-WMF) [17:49:29] 10VisualEditor, 10VisualEditor-MediaWiki-References, 10Parsoid, 3VisualEditor 2015/16 Q1 blockers: Copy-and-pasting a reference between VE surfaces causes a Parsoid 500 error. - https://phabricator.wikimedia.org/T104230#1425354 (10Jdforrester-WMF) [17:50:37] 10VisualEditor, 10VisualEditor-ContentEditable: Make sure Firefox 39 doesn't break fix for T70537 - https://phabricator.wikimedia.org/T104397#1425369 (10Jdforrester-WMF) p:5Triage>3High [17:50:48] 10VisualEditor, 10VisualEditor-MediaWiki-References, 10Parsoid, 3VisualEditor 2015/16 Q1 blockers: Copy-and-pasting a reference between VE surfaces causes a Parsoid 500 error - https://phabricator.wikimedia.org/T104230#1425370 (10Jdforrester-WMF) [17:54:32] 10VisualEditor, 10VisualEditor-MediaWiki, 10Analytics-EventLogging, 6Labs, and 3 others: Pages can't be saved with VisualEditor on wikitech (Uncaught ReferenceError: attrId is not defined) - https://phabricator.wikimedia.org/T104360#1425384 (10Jdforrester-WMF) Yup, statsv complaint shows up but otherwise n... [18:00:49] 10VisualEditor, 10Wikimedia-Site-requests, 5Patch-For-Review, 3VisualEditor 2015/16 Q1 blockers, 7user-notice: Enable VisualEditor for the Portal namespace at the Japanese Wikipedia - https://phabricator.wikimedia.org/T97313#1425424 (10Jdforrester-WMF) p:5Triage>3Normal a:3Jdforrester-WMF [18:00:56] 10VisualEditor, 10Wikimedia-Site-requests, 5Patch-For-Review, 3VisualEditor 2015/16 Q1 blockers, 7user-notice: Enable VisualEditor for the Portal namespace at the Japanese Wikipedia - https://phabricator.wikimedia.org/T97313#1425428 (10Jdforrester-WMF) [18:13:06] 10MediaWiki-extensions-Graph-VE: Weekly reports for "Enable VisualEditor support in Graph extension" - https://phabricator.wikimedia.org/T101119#1425466 (10ferdbold) [18:15:56] 10VisualEditor, 5Patch-For-Review: visualeditor-dialog-media-dimensionseparator contains trailing whitespace - https://phabricator.wikimedia.org/T104691#1425474 (10Nikerabbit) Your suggestion for having variables is good, if that works for you. [18:38:02] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-Links, 3VisualEditor 2015/16 Q1 blockers: Copying link makes it relative to edited page - https://phabricator.wikimedia.org/T95136#1425578 (10Krenair) I wonder if the fix for T85619 might've resolved this [19:03:41] edsanders , eranroz , aharoni : hi [19:04:08] I am working on this proof reading extension for VisualEditor called LanguageTool [19:04:50] ankita-ks: hi :) [19:05:05] Now, I query the LanguageTool server (setup on tools-labs) with the text in the editing area. I get an xml response. [19:05:16] I want to annotate the response in the editing area itself. [19:05:30] [ the most interesting part! ] [19:05:50] something like this perhaps : http://tools.wmflabs.org/languageproofing-ui/ [19:06:16] I was looking at how this has been done. This is the relevant code : https://gist.github.com/ankita-kumari/1a187cca8ad7f792461d [19:06:55] So what they do essentially is take the find the index of where the error is [this is present within the xml response] [19:07:43] extract the entire text from the editing area, add html tags before and after the error indices and then replace entire text with this [19:07:58] Is there any way I can do this with VisualEditor? [19:09:54] mooeypoo, edsanders: ^ I suppose that there's some way to query the surface and get the text and the HTML content [19:10:17] ankita-ks: did you try to look at how the search-and-replace is implemented in VisualEditor? [19:11:13] edsanders probably will give better answer, but I think there are 2 ways to go: 1. either use DOM and jquery to locate the text html and assign the relevant part a class, 2. use surface ve.init.target.getSurface().getView().getDocument() and extract the text from it [19:11:46] eranroz's suggestion #2 is probably much better. [19:12:05] I have some code sample how to extract text from surface that you may find useful: https://en.wikipedia.org/wiki/User:%D7%A2%D7%A8%D7%9F/WeaselWords.js [19:12:13] VE developers repeatedly tell everybody to avoid querying the DOM directly. [19:14:23] okay [19:14:37] by extracting text do you mean extract the editable text? [19:14:50] or extract text with html tags? [19:15:09] aharoni : yes, I have been looking at search-and-replace [19:15:18] And there are some relevant things I found. [19:15:45] the editable text. but this is older code than the search and replace - so you amy find there better tricks to extract the editable text [19:16:43] for intsnace the highlightFocused function [19:17:12] I was going to try adding new css class to the errors [19:17:34] like it has been done in highlightFocused function [19:18:03] I suppose this is what the eranroz suggested? [19:18:17] yes [19:19:09] try to avoid adding new (html) elements and prefer assigning class to existing elements [19:20:03] Alright, I will try doing that. [19:32:20] You should look at how the search code is implemented [19:41:32] (03PS1) 10Jforrester: Delete the never-used 'MW alien' Beta Feature hook/i18n [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/222694 [20:02:22] (03CR) 10Esanders: [C: 032] Delete the never-used 'MW alien' Beta Feature hook/i18n [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/222694 (owner: 10Jforrester) [20:04:21] Thanks, edsanders. [20:04:39] (03Merged) 10jenkins-bot: Delete the never-used 'MW alien' Beta Feature hook/i18n [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/222694 (owner: 10Jforrester) [20:06:33] ankita-ks, the way to read data from VE is via the model [20:07:17] ve.init.target.getSurface().getModel().getDocument().data (not getView) [20:07:40] changing the data is done with transactions applied to the surface model [20:07:47] ( ve.init.target.getSurface().getModel() ) [20:07:59] ve.dm.Transaction has static methods for constructing transactions [20:08:34] language tags are applied as annotations, i.e. individually to each character [20:09:17] ve.ui.AnnotationAction has methods for applying annotations [20:10:38] edsanders : That is how I read the data from VE. [20:11:05] But I was not sure how to highlight the errors. [20:11:54] As suggested I have been looking at how it is done in Find-and-replace [20:11:54] I think that if you have the text of specific node, you can check whether the error is relevant to that node [20:13:44] eranroz : are you suggesting that I do that to find the location of the error? [20:21:02] ankita-ks: it is possible to go over the nodes and for each of them extract the text and find if it match, but I'm taking back this idea as there is findText method in Document that gives you the relevant ranges [20:21:32] I suppose I can just calculate the offset of the error. [20:21:52] The xml response contains the starting and ending index of the error. [20:23:34] (03PS7) 10Divec: ve.SelectionState: DOM selection snapshot [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/222221 (https://phabricator.wikimedia.org/T104517) [20:24:34] can you tell me what "getLinearFragment" does? [20:27:38] ankita-ks: there is tree model and linear model. you can test ve.init.target.getSurface().getModel().getLinearFragment(ve.init.target.getSurface().getModel().getDocument().findText('textToFind')[0]) vs (getFragment which is not linear but tree model) [20:28:19] (03PS5) 10Divec: ve.ce.adjustLinkSelection: fixup link-bisecting selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/222488 [20:28:48] the relevant ranges are linear, so only getLinearFragment return the correct fragment I think [20:29:34] eranroz : what is a fragment? [20:29:54] what fragment does getLinearFragment return? [20:29:55] (03PS3) 10Divec: WIP: Fixup links [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/222619 [20:30:58] (03CR) 10jenkins-bot: [V: 04-1] ve.ce.adjustLinkSelection: fixup link-bisecting selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/222488 (owner: 10Divec) [20:31:13] ankita-ks: Fragment is object behind specific range in the document with the associated annotations [20:32:13] (03CR) 10jenkins-bot: [V: 04-1] WIP: Fixup links [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/222619 (owner: 10Divec) [20:34:37] (03PS6) 10Divec: ve.ce.adjustLinkSelection: fixup link-bisecting selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/222488 [20:34:59] (03PS4) 10Divec: WIP: Fixup links [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/222619 [21:30:29] I have a question about the VisualEditor plugin; are there plans to integrate the Parsoid service so that it can be deployed simultaneously with a MediaWiki installation (ie not needing have a separate NodeJS service) [21:42:57] Hello? [21:46:11] hi WikiCurious [21:46:33] alas, probably not. but it's recognized as something we'd like to have, given infitite resources and infinite time [21:47:01] WikiCurious: hi, I think there are no plans for doing it. but you can add feature request in https://phabricator.wikimedia.org/ [21:48:07] I'm not sure why parsoid is nodejs service from the begining... (is there are lots of code shared between parsoid and VE?) [21:48:24] Ya I thought that was weird too... [21:48:31] eranroz: We don't hate our users enough to make them wait multiple minutes before each edit. [21:48:43] There is already parsing code in the PHP codebase [21:49:40] But are willing to restrict the new VisualEditor to sysadmins willing to pay/use an additional service like Heroku or a VPS? [21:49:57] James_F: is there nodejs vs php (with HHVM) performence benchmark in which nodejs wins significantly? [21:50:03] eranroz: All of them. [21:50:10] eranroz: Even with HHVM [22:12:51] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-Links, 3VisualEditor 2015/16 Q1 blockers: Copying link makes it relative to edited page - https://phabricator.wikimedia.org/T95136#1425807 (10Jdforrester-WMF) I now can't reproduce this in production (wmf12). Can someone confirm? [22:18:13] (03CR) 10Jforrester: [C: 032] "Meh." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/222569 (https://phabricator.wikimedia.org/T104691) (owner: 10Esanders) [22:18:41] 10VisualEditor, 5Patch-For-Review: visualeditor-dialog-media-dimensionseparator contains trailing whitespace - https://phabricator.wikimedia.org/T104691#1425842 (10Jdforrester-WMF) 5Open>3Resolved a:3Jdforrester-WMF On reflection, it's not worth the duplication. [22:19:05] 10VisualEditor, 7Technical-Debt, 3VisualEditor 2015/16 Q1 blockers: visualeditor-dialog-media-dimensionseparator contains trailing whitespace - https://phabricator.wikimedia.org/T104691#1425846 (10Jdforrester-WMF) a:5Jdforrester-WMF>3Esanders [22:19:07] 10VisualEditor, 7Technical-Debt, 3VisualEditor 2015/16 Q1 blockers: visualeditor-dialog-media-dimensionseparator contains trailing whitespace - https://phabricator.wikimedia.org/T104691#1424086 (10Jdforrester-WMF) [22:19:58] (03CR) 10Jforrester: [C: 032] Remove unused dependency [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/222557 (owner: 10Esanders) [22:20:34] (03Merged) 10jenkins-bot: Use core dimension widget times separator [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/222569 (https://phabricator.wikimedia.org/T104691) (owner: 10Esanders) [22:21:42] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-extensions-TimedMediaHandler, 6Multimedia, 7Epic: Show nicer previews of complex (timed, paged, …) media inside VisualEditor - https://phabricator.wikimedia.org/T104237#1425852 (10Jdforrester-WMF) [22:21:58] 10VisualEditor, 6Multimedia: VE does not display PDF thumbnails: Big empty box and (browser's) broken file icon - https://phabricator.wikimedia.org/T100453#1425853 (10Jdforrester-WMF) [22:22:00] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-extensions-TimedMediaHandler, 6Multimedia, 7Epic: Show nicer previews of complex (timed, paged, …) media inside VisualEditor - https://phabricator.wikimedia.org/T104237#1411153 (10Jdforrester-WMF) [22:22:16] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-extensions-PdfHandler, 6Multimedia: VE does not display PDF thumbnails: Big empty box and (browser's) broken file icon - https://phabricator.wikimedia.org/T100453#1425856 (10Jdforrester-WMF) p:5Triage>3Low [22:22:27] (03Merged) 10jenkins-bot: Remove unused dependency [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/222557 (owner: 10Esanders) [22:24:57] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-Links, 3VisualEditor 2015/16 Q1 blockers: Copying link makes it relative to edited page - https://phabricator.wikimedia.org/T95136#1425859 (10Krenair) 5Open>3Resolved a:3Krenair Confirmed. [22:25:12] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-Links, 3VisualEditor 2015/16 Q1 blockers: Copying link makes it relative to edited page - https://phabricator.wikimedia.org/T95136#1425862 (10Krenair) a:5Krenair>3None [22:29:32] 10VisualEditor, 10VisualEditor-MediaWiki, 10Analytics-EventLogging, 6Labs, and 3 others: Pages can't be saved with VisualEditor on wikitech (Uncaught ReferenceError: attrId is not defined) - https://phabricator.wikimedia.org/T104360#1425875 (10Krinkle) 5Open>3Resolved a:3Krinkle Can't reproduce this... [22:29:55] 10VisualEditor, 10VisualEditor-MediaWiki, 6Labs, 10wikitech.wikimedia.org, 7Regression: Pages can't be saved with VisualEditor on wikitech (Uncaught ReferenceError: attrId is not defined) - https://phabricator.wikimedia.org/T104360#1425878 (10Krinkle) [22:31:58] 10VisualEditor, 10VisualEditor-MediaWiki, 6Labs, 10wikitech.wikimedia.org, 7Regression: Pages can't be saved with VisualEditor on wikitech (Uncaught ReferenceError: attrId is not defined) - https://phabricator.wikimedia.org/T104360#1425880 (10Jdforrester-WMF) 5Resolved>3Open Still trivially reproduci... [22:36:36] 10VisualEditor, 10VisualEditor-MediaWiki, 6Labs, 10wikitech.wikimedia.org, 7Regression: Pages can't be saved with VisualEditor on wikitech (Uncaught ReferenceError: attrId is not defined) - https://phabricator.wikimedia.org/T104360#1425886 (10Krenair) Why didn't https://gerrit.wikimedia.org/r/#/c/221969/... [22:37:19] 10VisualEditor, 10VisualEditor-MediaWiki, 6Labs, 10wikitech.wikimedia.org, 7Regression: Pages can't be saved with VisualEditor on wikitech (Uncaught ReferenceError: attrId is not defined) - https://phabricator.wikimedia.org/T104360#1425888 (10Jdforrester-WMF) p:5Triage>3Low [23:41:08] 10VisualEditor, 10Wikimedia-Site-requests, 5Patch-For-Review, 3VisualEditor 2015/16 Q1 blockers: Enable VisualEditor for the Portal namespace at the Japanese Wikipedia - https://phabricator.wikimedia.org/T97313#1425994 (10gpaumier)