[07:54:22] 10VisualEditor-LanguageTool, 10Continuous-Integration-Config: setup continuous integration for the LanguageTool extension - https://phabricator.wikimedia.org/T104760#1426274 (10Amire80) 3NEW [08:21:47] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-General-or-Unknown, 7JavaScript, and 4 others: Links to [[.ar]] etc. inside a transclusion throw an error from ve.ce.MWTransclusionNode:178 as the href makes mw.Title break - https://phabricator.wikimedia.org/T104377#1426299 (10Krinkle) Backporting sinc... [08:49:56] 10VisualEditor, 6Design Research Backlog, 7Epic, 3VisualEditor 2015/16 Q1 blockers: Improve and streamline VisualEditor's user education features - https://phabricator.wikimedia.org/T101481#1426347 (10Nemo_bis) [08:49:57] 10VisualEditor, 10VisualEditor-MediaWiki: Help VisualEditor users find the wikitext "Save" button - https://phabricator.wikimedia.org/T90864#1426345 (10Nemo_bis) 5stalled>3Open > There's already a GuidedTour kicked off by the GettingStarted system for the first-time wikitext edit experience; is this insuff... [08:50:32] 10VisualEditor-LanguageTool, 10Continuous-Integration-Config: setup continuous integration for the LanguageTool extension - https://phabricator.wikimedia.org/T104760#1426348 (10Amire80) [10:14:23] when adding ?debug=1 VE edit tab isn't displayed (enwiki). is it a bug or feature? :) [12:06:00] 10VisualEditor-LanguageTool, 10Continuous-Integration-Config: setup continuous integration for the LanguageTool extension - https://phabricator.wikimedia.org/T104760#1426430 (10hashar) You want to setup a npm task that runs JSHint and banana lint checker as well. See https://www.mediawiki.org/wiki/Continuous_i... [18:47:59] 10VisualEditor, 10VisualEditor-MediaWiki, 6Labs, 10wikitech.wikimedia.org, 7Regression: Pages can't be saved with VisualEditor on wikitech (Uncaught ReferenceError: attrId is not defined) - https://phabricator.wikimedia.org/T104360#1426705 (10Krenair) a:5Krinkle>3None [19:00:52] edsanders : Hi, could you explain to me how raw text is mapped onto fragments in VisualEditor? [19:02:09] For the extension that I am working on, I extract the raw text and send it to a server which responds with an xml document containing errors and their offsets [19:02:41] 10VisualEditor: Editing a certain paragraph with the visual editor. - https://phabricator.wikimedia.org/T104776#1426709 (10elyashiv) 3NEW [19:02:44] So when I take a substring from the raw text I sent to the server, I can locate the error. [19:03:15] But when I convert the offsets to ve.range and get the fragments for that range, it does not give me the correct error. [19:03:42] I have been wondering if it has something to do with how raw text is represented in fragments. [19:17:41] eranroz, ankita-ks - shalom [19:17:45] anything interesting today? [19:18:14] aharoni : shalom :) [19:18:35] I have been trying to mark the errors in the editing area. [19:18:51] And I am stuck with this one glitch. [19:18:58] commit early, commit often [19:19:05] (to Gerrit) [19:19:09] hi amir :) [19:19:27] every now and then I do more than fixing whitespace ;) [19:19:43] aharoni : yes, I should. :) [19:20:03] I will commit now. So you can take a look. [19:20:04] ankita-ks: whatever you have now - commit it, I'd love to see it, even if it doesn't work [19:24:45] mooey|away, eranroz: did you see the discussion in the Hebrew WP Village Pump about how Rimon ISP screws up VE? [19:26:08] i saw something but didn't check it [19:26:12] An ISP screws up VE? [19:26:22] I don't know Hebrew but I'd love to know what that's about [19:26:30] it sounds very strange. i don't think ISP can remove links from the VE [19:27:01] (this is ISP of orthodox, removing sex related images and links) [19:27:14] aharoni : https://gerrit.wikimedia.org/r/#/c/222846/1/modules/ext.LanguageToolAction.js [19:27:42] eranroz: VE is HTML, and their software removes links from HTML even before it's saved. [19:29:47] We communicate with RESTBase over HTTPS [19:29:55] an orthodox friend once asked me to fix an error in Wikipedia - he said that an article about a certain female basketball player says: "Match spectators shout at her because she is." [19:29:57] Is this a client-side thing? [19:30:04] And he thought that the sentence is incomplete. [19:30:16] The sentence, of course, said that she is lesbian. [19:30:41] Wow... [19:30:47] but he connected through that ISP, which silently censored the page. [19:31:03] Well that shouldn't be possible anymore with HTTPS [19:31:22] Hmm, interesting. [19:31:34] I'm reporting a bug, anyway... it's among the stranger issues. [19:31:48] Maybe they also have some client-side software that does things to the DOM. [19:31:59] That's more likely. [19:32:26] We've seen lots of different browser plugins injecting crap into VE. [19:32:33] This could be taking legitimate content out. [19:37:55] 10VisualEditor: content filtering tools remove links and may cause VE users to vandalize articles unintentionally - https://phabricator.wikimedia.org/T104778#1426737 (10Amire80) 3NEW [19:38:02] 10VisualEditor: content filtering tools remove links and may cause VE users to vandalize articles unintentionally - https://phabricator.wikimedia.org/T104778#1426744 (10Amire80) [19:38:23] 10VisualEditor: content filtering tools remove links and may cause VE users to vandalize articles unintentionally - https://phabricator.wikimedia.org/T104778#1426737 (10Amire80) [19:39:00] Krenair: yes, it takes legitimate content out. [19:39:08] To be honest this sounds like something you could catch with a clever AbuseFilter [19:39:12] ankita-ks: looking [19:39:37] Krenair: does AbuseFilter have IP ranges? [19:39:46] yes [19:39:54] OK, this can probably be done. [19:40:38] also IP ranges for logged-in users? [19:40:51] amm i think no [19:41:02] If it were up to me, people going through such an ISP would be completely blocked from editing any Wikipedia. It's not up to me. [19:41:57] agree. or we can change the ve and call it sex and it will remove all the relevant JS :) [19:42:07] haha [19:45:11] ankita-ks: can you please update your LanguageTool code from Gerrit, [19:45:17] ? [19:45:41] your patches are for an older versions before today's fixes [19:49:05] aharoni : updating [19:49:20] and you'll need to rebase [19:49:28] if you have any trouble rebasing, just tell me [20:39:31] 10VisualEditor: content filtering tools remove links and may cause VE users to vandalize articles unintentionally - https://phabricator.wikimedia.org/T104778#1426771 (10Krenair) Our connection to RESTBase is over HTTPS, so I'm guessing this is some sort of client-side tool. [20:54:04] 10VisualEditor: content filtering tools remove links and may cause VE users to vandalize articles unintentionally - https://phabricator.wikimedia.org/T104778#1426787 (10eranroz) I think it is some client side tool. possible solution: for(var i=0;i 10VisualEditor: content filtering tools remove links and may cause VE users to vandalize articles unintentionally - https://phabricator.wikimedia.org/T104778#1426788 (10Krenair) Maybe we could look at something like that... The code wouldn't look like that, but perhaps something that checks through navigator.plu...