[06:17:31] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic, 3VisualEditor 2015/16 Q1 blockers: VisualEditor: Where VisualEditor is the primary editor, redlinks in read mode should open VE (not wikitext editor) - https://phabricator.wikimedia.org/T55441#1428645 (10TTO) @Krenair I'm a little puzzled by your... [07:59:33] 10VisualEditor: Link colour changes based on length of link (interproject) - https://phabricator.wikimedia.org/T104168#1428790 (10Lokal_Profil) 5Open>3Invalid a:3Lokal_Profil Looks like that might have been the case. Now it's back to always being blue, independent of length or existence. Closing as invalid [08:35:33] 10VisualEditor: Code in SyntaxHighlight blocks is editable, but changes are lost on save - https://phabricator.wikimedia.org/T102913#1428928 (10Krinkle) [08:35:35] 10VisualEditor, 10VisualEditor-MediaWiki, 5Patch-For-Review, 7Regression: and no longer protected from content editable - https://phabricator.wikimedia.org/T103455#1428929 (10Krinkle) [08:40:31] 10VisualEditor: Code in SyntaxHighlight blocks is editable, but changes are lost on save - https://phabricator.wikimedia.org/T102913#1428947 (10Krinkle) >>! In T102913#1426979, @MrStradivarius wrote: > Presumably this was fixed by T45126? Not exactly. The problem in this task is that VisualEditor wrongly allowe... [10:49:05] 10VisualEditor: [Regression pre-wmf13] Article URL with namespace '/wiki/' is getting added in the page while adding it from the link inspector - https://phabricator.wikimedia.org/T104838#1429171 (10Ryasmeen) 3NEW [11:09:09] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic, 3VisualEditor 2015/16 Q1 blockers: VisualEditor: Where VisualEditor is the primary editor, redlinks in read mode should open VE (not wikitext editor) - https://phabricator.wikimedia.org/T55441#1429220 (10Nemo_bis) Indeed, this bug is not about act... [11:12:23] edsanders: this is me pinging you re: code review :) [11:36:01] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic, 3VisualEditor 2015/16 Q1 blockers: VisualEditor: Where VisualEditor is the primary editor, redlinks in read mode should open VE (not wikitext editor) - https://phabricator.wikimedia.org/T55441#1429288 (10Amire80) >>! In T55441#1429220, @Nemo_bis w... [12:41:41] (03PS1) 10TheDJ: Toolbar: Let's remove a speedup loop... [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/223017 [13:47:59] (03CR) 10Krinkle: [C: 032] Toolbar: Let's remove a speedup loop... [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/223017 (owner: 10TheDJ) [13:48:49] (03Merged) 10jenkins-bot: Toolbar: Let's remove a speedup loop... [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/223017 (owner: 10TheDJ) [14:40:42] (03PS8) 10Divec: ve.SelectionState: DOM selection snapshot [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/222221 (https://phabricator.wikimedia.org/T104517) [14:41:21] (03PS7) 10Divec: ve.ce.adjustLinkSelection: fixup link-bisecting selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/222488 [14:42:34] (03PS5) 10Divec: WIP: Fixup links [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/222619 [14:59:26] edsanders: You around? [15:07:26] 10VisualEditor, 10Wikimedia-Site-requests, 5Patch-For-Review, 3VisualEditor 2015/16 Q1 blockers: Enable VisualEditor for the Portal namespace at the Japanese Wikipedia - https://phabricator.wikimedia.org/T97313#1430021 (10Jdforrester-WMF) 5Open>3Resolved This now works; see https://ja.wikipedia.org/wik... [15:45:16] (03CR) 10Jforrester: "If821bea06 seeks to fix." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/215090 (https://phabricator.wikimedia.org/T87992) (owner: 10Jforrester) [15:59:34] (03PS1) 10Jforrester: Update jQuery.i18n to v1.0.3 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/223045 [16:26:43] (03CR) 10Divec: [C: 032] Update jQuery.i18n to v1.0.3 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/223045 (owner: 10Jforrester) [16:28:37] every times I get an "Error loading data from server: HTTP 0. Would you like to retry?" message, a little part of me dies. [16:29:08] you get those errors in production? [16:29:37] (03Merged) 10jenkins-bot: Update jQuery.i18n to v1.0.3 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/223045 (owner: 10Jforrester) [16:45:29] Just got it on officewiki :( [16:46:22] Elitre, officewiki is private so that works differently [16:47:39] It shouldn't fail to connect though [16:48:02] is this intermittent? [16:57:18] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki-References: Citations in VisualEditor are copied as regular links on Chrome - https://phabricator.wikimedia.org/T104788#1430662 (10Neil_P._Quinn_WMF) [18:00:04] (03PS1) 10Jforrester: Follow-up 0ca48d8: Actually load jquery.i18n.emitter.bidi.js too [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/223066 [18:01:49] (03CR) 10Catrope: [C: 032] Follow-up 0ca48d8: Actually load jquery.i18n.emitter.bidi.js too [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/223066 (owner: 10Jforrester) [18:01:58] RoanKattouw: Thanks. ;-) [18:04:15] (03Merged) 10jenkins-bot: Follow-up 0ca48d8: Actually load jquery.i18n.emitter.bidi.js too [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/223066 (owner: 10Jforrester) [18:11:55] (03PS1) 10Jforrester: i18n: Remove references to 'VisualEditor', instead say 'the visual editor' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/223070 [18:12:02] neilpquinn: ^^^ [18:53:13] krenair, I only made one edit there today. [18:54:00] for your daily dose of "VE won't finish loading for me", see https://en.wikipedia.org/wiki/Wikipedia:VisualEditor/Feedback#Article_not_loading instead :p [18:54:02] I loaded VE on a few more pages there and it worked OK [18:54:33] that one worked for me as well [18:55:06] for me too. [18:55:45] but failures to load on enwiki and failures to load on officewiki are two completely separate things [18:55:56] private wikis can't use restbase [18:57:45] (03PS1) 10Legoktm: Don't always override $wgVisualEditorNamespaces [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/223080 [19:01:07] (03CR) 10jenkins-bot: [V: 04-1] Don't always override $wgVisualEditorNamespaces [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/223080 (owner: 10Legoktm) [19:02:23] (03PS2) 10Legoktm: Don't always override $wgVisualEditorNamespaces [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/223080 [19:03:56] (03CR) 10Jforrester: [C: 04-1] "This makes it impossible to limit namespaces to e.g. only NS_USER through config." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/223080 (owner: 10Legoktm) [19:07:59] (03CR) 10Legoktm: "That was already an issue before this patch. We have a few options:" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/223080 (owner: 10Legoktm) [19:08:14] 10Citoid, 10Beta-Cluster: On beta cluster citoid should self update and reload after change is merged - https://phabricator.wikimedia.org/T95652#1431520 (10hashar) p:5Triage>3High [19:08:33] 10Citoid, 10Beta-Cluster: On beta cluster citoid should self update and reload after change is merged - https://phabricator.wikimedia.org/T95652#1431523 (10hashar) p:5High>3Normal [19:09:10] (03CR) 10Jforrester: [C: 032] "Meh." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/223080 (owner: 10Legoktm) [19:09:33] Krenair: Feel like doing "option three"? [19:09:43] option three? [19:09:48] 10Citoid, 10Beta-Cluster: On beta cluster citoid should self update and reload after change is merged - https://phabricator.wikimedia.org/T95652#1196889 (10hashar) @mobrovac and I had some pairing last week to train him up on JJB usage. The informal .plan is to revisit each of the mediawiki services backend an... [19:10:00] oh, in legoktm's comment [19:10:03] Krenair: Yeah. [19:10:39] Let's call it a new config name. wgVisualEditorAvailableNamespaces( foo => true, bar => false ); [19:11:00] Though not sure how we'd do *TALK => false. ;-) [19:11:37] okay, file a task and assign it to me? [19:11:52] (03Merged) 10jenkins-bot: Don't always override $wgVisualEditorNamespaces [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/223080 (owner: 10Legoktm) [19:12:48] Sure. [19:13:00] I updated https://gerrit.wikimedia.org/r/#/c/223040/ as well [19:15:07] 10VisualEditor, 10VisualEditor-MediaWiki: Replace wgVisualEditorNamespaces with a 2D array of namespace => enabled state - https://phabricator.wikimedia.org/T104898#1431556 (10Jdforrester-WMF) 3NEW a:3Krenair [19:15:28] legoktm: LGTM; should we wait to SWAT it tonight, or do it sooner to work out if it fixes the fatals? [19:16:12] sooner probably, except it will enable VE on those svwikt namespaces in prod... [19:16:44] legoktm: Oh well. [19:16:52] legoktm: It's a Beta Feature. [19:16:59] oh okay [19:20:50] Krenair: You OK to deploy it if RelEng are OK with going? [19:21:11] backporting that VE change? [19:21:34] ok [19:21:53] Krenair: The config change, I was thinking. [19:21:56] Krenair: No need to back-port. [19:23:26] ah, right [19:23:29] yes, ok [19:36:33] 10Citoid, 10Beta-Cluster: On beta cluster citoid should self update and reload after change is merged - https://phabricator.wikimedia.org/T95652#1196889 (10hashar) [19:46:49] 10VisualEditor: VisualEditor Edit bar font size issue in 1.25 - https://phabricator.wikimedia.org/T104903#1431742 (10Rosencrantz) 3NEW [19:57:20] 10VisualEditor: VisualEditor Edit bar font size issue in 1.25 - https://phabricator.wikimedia.org/T104903#1431780 (10Rosencrantz) [20:04:22] hi, is there way I can annotate fragment using something like fragment.annotate( 'set', 'textStyle/bold' ) ? [20:10:51] figured it out. :) It was annotateContent it seems. [20:11:28] But the examples in this wiki use annotate : https://www.mediawiki.org/wiki/VisualEditor/API/Data_Model/Surface [20:11:37] Is that a different usage? [20:12:13] edsanders : can you help me understand how raw text in a wiki is mapped to fragments? [20:13:39] For eg, when I take the raw text from my wiki and take a substring from index_1 to index_2, it's different from what the text I get from a fragment with that range. [20:13:43] Why is that? [20:28:35] (03CR) 10Esanders: [C: 04-1] ve.SelectionState: DOM selection snapshot (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/222221 (https://phabricator.wikimedia.org/T104517) (owner: 10Divec) [20:29:08] ankita-ks, hi [20:29:27] edsanders : hello [20:29:29] what do you mean by raw text? [20:29:38] wikitext? [20:33:18] no, I mean if I extracted text from the editing area from each text node. [20:34:16] and then concatenated them with a newline after each textnode's text. [20:34:51] edsanders ^ [20:35:25] text nodes from the DOM? [20:36:10] The DOM is the view - you shouldn't be using it for extracting data [20:36:18] if you want data, query the model [20:36:26] from the surface [20:37:04] the surface, like most things, has a view and a model [20:37:11] what are you trying to get? [20:37:14] yes, I am querying the model. (I suppose) [20:37:28] ve.init.target.getSurface().getModel().getDocument().getDocumentNode() [20:37:40] I extract all the nodes of the type text [20:37:52] what's the high-level goal? [20:38:16] if you want the text content you can just look at the linear model [20:38:42] there's even a getText method which strips annotations and concatenates the letters [20:39:11] I want to extract the text content and then send it to the LanguageTool server which proof reads it and sends back the errors in an xml format. [20:39:41] I need to highlight the errors from the received xml response. [20:40:00] for example Foobar is represented as [ ['F',[0]], ['o',[0]], ['o',[0]], 'b', 'a', 'r' ] in the linear model [20:40:26] you don't need the model tree for that, just the flat linear model [20:41:00] ve.init.target.getSurface().getModel().getDocument().data [20:41:53] that is an instance of ve.dm.ElementLinearData [20:41:54] okay, so does it include spaces and newlines as well? [20:42:19] it is the canonical representation of the data [20:42:47] everything is in the linmod, and all other structures are derived from it [20:43:51] all changes must be applied directly to it as well (using transactions) [20:44:23] okay, so i am going to try this and see if it works. [20:45:09] ve.dm.ElementLinearData.prototype.getText [20:46:09] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-Tables: Automatically give pasted tables class="wikitable" in VE-MW - https://phabricator.wikimedia.org/T85577#1432000 (10Neil_P._Quinn_WMF) So it sounds like `.wikitable` is, in fact, just one style out of many. So I think task will remain limited to... [21:01:24] 10VisualEditor, 10VisualEditor-MediaWiki: Fix "1 notice" on the remaining wikis - https://phabricator.wikimedia.org/T103693#1432075 (10Stryn) [21:03:16] edsanders : same problem as before. [21:03:35] what is the problem? [21:05:50] The error offsets that I receive from the server mark are from the raw text that is sent to the server [21:05:57] extracted as you asked before. [21:06:48] 10VisualEditor: VisualEditor Edit bar font size issue in 1.25 - https://phabricator.wikimedia.org/T104903#1432131 (10Jdforrester-WMF) Looks like: * https://gerrit.wikimedia.org/r/#/c/206102/ in VE-core, and * https://gerrit.wikimedia.org/r/#/c/206103/ in VE-MW … need to get cherry-picked to REL1_25 of VE-MW (whi... [21:06:49] but when i create a fragment for those indices, they are different from the ones in raw text. [21:07:05] 10VisualEditor, 10VisualEditor-MediaWiki: VisualEditor Edit bar font size issue in 1.25 - https://phabricator.wikimedia.org/T104903#1432139 (10Jdforrester-WMF) p:5Triage>3Low [21:07:25] Basically what I am trying to say that if an error position is ind_1 to ind_2 in the raw text [21:07:53] and I create a new fragment from the range (ind_1, ind_2) [21:08:36] The text in this fragment is different from the one in extracted-text.substring( ind_1, ind_2 ) [21:10:18] ankita-ks,you can take a look on ve.init.target.getSurface().getModel().getDocument().data.getData() [21:10:37] eranroz : looking [21:10:44] it gives you an array of characaters, and elements (paragraph, image, transcludion etc) [21:11:33] I think .getLinearFragment(new ve.Range(start,end)) will give you the correct text if the range incluse the non characters also [21:11:41] 10VisualEditor, 7Technical-Debt: Extract the 'typos linter' task and make it an npm package - https://phabricator.wikimedia.org/T104916#1432151 (10Jdforrester-WMF) 3NEW [21:13:34] 10VisualEditor, 6Collaboration-Team, 7Technical-Debt: Extract the 'typos linter' task and make it an npm package - https://phabricator.wikimedia.org/T104916#1432158 (10Legoktm) [21:14:43] Okay, so I extract text using ve.init.target.getSurface().getModel().getDocument().data.getText() [21:15:12] and send it to the server. In the response the errors offsets are calculated on this text. [21:15:45] But when i need to annotate it, I need to map this back to ve.init.target.getSurface().getModel().getDocument().data.getData() [21:16:19] Am I right eranroz ? [21:16:57] yes [21:17:28] here is some ugly trick that may work to map again from the raw text to the original index in the getData [21:17:48] for(var i=0;i the first object in mapper is the index of the first character in the data [21:19:56] so data refers to the raw text extracted? [21:21:39] data refers to ....getDocument().data.getData() [21:22:17] data[mapper[getText()[i]]]=getText()[i] [21:24:36] (03PS12) 10Jforrester: Use Parsoid's new Cite HTML and CSS [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207483 (https://phabricator.wikimedia.org/T86782) (owner: 10Marcoil) [21:28:34] (03CR) 10Jforrester: [C: 032] Use Parsoid's new Cite HTML and CSS [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207483 (https://phabricator.wikimedia.org/T86782) (owner: 10Marcoil) [21:30:48] (03Merged) 10jenkins-bot: Use Parsoid's new Cite HTML and CSS [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/207483 (https://phabricator.wikimedia.org/T86782) (owner: 10Marcoil) [21:44:01] 10VisualEditor: Removing a Project from a task may not be captured in the dump - https://phabricator.wikimedia.org/T104920#1432238 (10JAufrecht) 3NEW a:3chasemp [21:44:11] 10VisualEditor: Removing a Project from a task may not be captured in the dump - https://phabricator.wikimedia.org/T104920#1432238 (10JAufrecht) p:5High>3Normal [21:53:44] (03PS1) 10Divec: EventSequencer: fixes and unit tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/223187 [22:08:53] (03PS6) 10Divec: Fixup links [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/222619 [22:31:33] (03CR) 10Esanders: [C: 04-1] "minor doc fix, good otherwise" (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/223187 (owner: 10Divec) [22:31:42] James_F: When you extract grunt-typos, I'd recommend providing a preset similar to jscs to reduce duplication and simplify updates. [22:34:40] (03Abandoned) 10Legoktm: Revert "Use new MediaWiki core TitleInputWidget" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/222550 (owner: 10Legoktm) [22:34:52] Krinkle: I was thinking the same. [22:36:36] (03PS2) 10Jforrester: EventSequencer: fixes and unit tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/223187 (owner: 10Divec) [22:40:10] (03PS9) 10Divec: ve.SelectionState: DOM selection snapshot [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/222221 (https://phabricator.wikimedia.org/T104517) [22:40:49] (03PS8) 10Divec: ve.ce.adjustLinkSelection: fixup link-bisecting selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/222488 [22:41:51] (03PS7) 10Divec: WIP: Fixup links [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/222619 [22:44:32] (03PS3) 10Divec: EventSequencer: fixes and unit tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/223187 [22:47:36] 10Cite, 6Collaboration-Team, 10Flow, 6Language-Engineering, and 7 others: Use CSS to style Parsoid's Cite extension output - https://phabricator.wikimedia.org/T86782#1432395 (10Jdforrester-WMF) 5Open>3Resolved [22:47:57] 10Cite, 6Collaboration-Team, 10Flow, 6Language-Engineering, and 7 others: Use CSS to style Parsoid's Cite extension output - https://phabricator.wikimedia.org/T86782#976382 (10Jdforrester-WMF) [22:50:58] 10Cite, 7Technical-Debt: Remove the old wikitext styling code from Cite - https://phabricator.wikimedia.org/T104926#1432402 (10Jdforrester-WMF) 3NEW [22:51:02] 10Cite, 10VisualEditor, 6Editing-Department, 6Parsing-Team: Use ext.cite.style to style output, rather than wikitext styling - https://phabricator.wikimedia.org/T104927#1432409 (10Jdforrester-WMF) 3NEW [22:51:11] 10Cite, 7Technical-Debt: Remove the old wikitext styling code from Cite - https://phabricator.wikimedia.org/T104926#1432416 (10Jdforrester-WMF) [22:51:12] 10Cite, 10VisualEditor, 6Editing-Department, 6Parsing-Team: Use ext.cite.style to style output, rather than wikitext styling - https://phabricator.wikimedia.org/T104927#1432417 (10Jdforrester-WMF) [22:52:23] 10Cite, 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-References, and 4 others: Move ext.visualEditor.mwreference registration back to extension.json once ext.cite.style is definitely available - https://phabricator.wikimedia.org/T104928#1432421 (10Jdforrester-WMF) 3NEW [22:52:45] 10Cite, 10VisualEditor, 6Editing-Department, 6Parsing-Team: Use ext.cite.style to style output, rather than wikitext styling - https://phabricator.wikimedia.org/T104927#1432409 (10Jdforrester-WMF) [22:52:47] 10Cite, 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-References, and 4 others: Move ext.visualEditor.mwreference registration back to extension.json once ext.cite.style is definitely available - https://phabricator.wikimedia.org/T104928#1432421 (10Jdforrester-WMF) [22:53:11] 10Cite, 6Collaboration-Team, 10Flow, 6Language-Engineering, and 7 others: Use CSS to style Parsoid's Cite extension output - https://phabricator.wikimedia.org/T86782#1432432 (10Jdforrester-WMF) Follow-ups moved to {T104927}. [22:54:10] (03PS11) 10Divec: WIP: Explicitly enter/exit link annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/217257 [22:56:30] (03CR) 10Jforrester: [C: 032] EventSequencer: fixes and unit tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/223187 (owner: 10Divec) [22:59:19] (03Merged) 10jenkins-bot: EventSequencer: fixes and unit tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/223187 (owner: 10Divec) [23:02:15] 10Cite, 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-References, and 4 others: Move ext.visualEditor.mwreference registration back to extension.json once ext.cite.style is definitely available - https://phabricator.wikimedia.org/T104928#1432438 (10Jdforrester-WMF) [23:02:16] 10Cite, 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Plugins, and 3 others: Cite: Refactor VisualEditor editing plugin for Cite back into the Cite extension - https://phabricator.wikimedia.org/T41621#1432437 (10Jdforrester-WMF) [23:08:22] (03PS1) 10Krinkle: Toolbar: Let's remove a speedup loop... [extensions/WikiEditor] (wmf/1.26wmf12) - 10https://gerrit.wikimedia.org/r/223200