[00:15:13] 10Citoid, 10VisualEditor, 3VisualEditor 2015/16 Q1 blockers: MediaWiki flakiness (?) caused (? causes ?) auto-cite tool to become unavailable somehow - https://phabricator.wikimedia.org/T104944#1439834 (10Krinkle) [00:15:15] 10Citoid, 10VisualEditor, 3VisualEditor 2015/16 Q1 blockers: Citoid request for MediaWiki:Citoid-template-type-map.json should be fetched in a data module, not as an i18n message - https://phabricator.wikimedia.org/T93800#1439835 (10Krinkle) [00:16:01] 10Citoid, 10VisualEditor, 3VisualEditor 2015/16 Q1 blockers: Value for citoid-template-type-map.json randomly missing in some languages - https://phabricator.wikimedia.org/T93800#1439845 (10Krinkle) p:5Normal>3Unbreak! [00:36:47] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 3VisualEditor 2015/16 Q1 blockers: [Regression wmf13] Adding an link with the link inspector in insertion mode inserts an anchor with "/wiki/" prepended - https://phabricator.wikimedia.org/T104838#1439898 (10Krenair) Sounds like this could've been caused by htt... [01:03:21] (03PS1) 10Alex Monk: Bypass ve.ui.MWInternalLinkAnnotationWidget.prototype.getHref when determining text [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/223707 (https://phabricator.wikimedia.org/T104838) [01:04:20] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 5Patch-For-Review, 3VisualEditor 2015/16 Q1 blockers: [Regression wmf13] Adding an link with the link inspector in insertion mode inserts an anchor with "/wiki/" prepended - https://phabricator.wikimedia.org/T104838#1439931 (10Krenair) We should probably be a... [06:33:14] 10VisualEditor-LanguageTool: rename this.$findResults in mw.languageToolAction - https://phabricator.wikimedia.org/T105268#1440089 (10Amire80) 3NEW a:3Ankita-ks [06:35:36] 10VisualEditor-LanguageTool: reconsider the use of this.surfaceModel in mw.languageToolAction - https://phabricator.wikimedia.org/T105269#1440096 (10Amire80) 3NEW a:3Ankita-ks [06:36:24] 10VisualEditor-LanguageTool: this.ignoredRulesIds doesn't seem to be used in mw.languageToolAction - https://phabricator.wikimedia.org/T105270#1440103 (10Amire80) 3NEW a:3Ankita-ks [06:37:19] 10VisualEditor-LanguageTool: this.fragments doesn't seem to be used in mw.languageToolAction - https://phabricator.wikimedia.org/T105271#1440113 (10Amire80) 3NEW a:3Ankita-ks [06:46:05] 10VisualEditor-LanguageTool: suggestion variable initialization in mw.languageToolAction.prototype.processXML should use the dot notation - https://phabricator.wikimedia.org/T105272#1440135 (10Amire80) 3NEW a:3Ankita-ks [08:04:33] (03CR) 10Legoktm: [C: 032] Use the plain-text GPL [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/216614 (owner: 10Ricordisamoa) [08:05:37] (03Merged) 10jenkins-bot: Use the plain-text GPL [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/216614 (owner: 10Ricordisamoa) [08:34:45] 10VisualEditor-LanguageTool: rename this.$findResults in mw.languageToolAction - https://phabricator.wikimedia.org/T105268#1440434 (10Amire80) p:5High>3Low [08:34:47] 10VisualEditor-LanguageTool: rename openDialog in LanguageTool - https://phabricator.wikimedia.org/T105267#1440442 (10Amire80) p:5High>3Low [08:34:50] 10VisualEditor-LanguageTool: suggestion variable initialization in mw.languageToolAction.prototype.processXML should use the dot notation - https://phabricator.wikimedia.org/T105272#1440444 (10Amire80) p:5High>3Low [08:34:53] 10VisualEditor-LanguageTool: reconsider the use of this.surfaceModel in mw.languageToolAction - https://phabricator.wikimedia.org/T105269#1440447 (10Amire80) p:5High>3Low [08:34:56] 10VisualEditor-LanguageTool: this.ignoredRulesIds doesn't seem to be used in mw.languageToolAction - https://phabricator.wikimedia.org/T105270#1440449 (10Amire80) p:5High>3Low [08:34:59] 10VisualEditor-LanguageTool: this.fragments doesn't seem to be used in mw.languageToolAction - https://phabricator.wikimedia.org/T105271#1440451 (10Amire80) p:5High>3Low [10:09:49] 10VisualEditor-LanguageTool: have a working online demo of VE/LanguageTool integration - https://phabricator.wikimedia.org/T105303#1440626 (10Amire80) 3NEW [10:35:55] 10VisualEditor, 10VisualEditor-MediaWiki, 10Parsoid, 5Patch-For-Review, 3VisualEditor 2015/16 Q1 blockers: Enable scrubWikitext=1 in VisualEditor's save route to Parsoid - https://phabricator.wikimedia.org/T105239#1440679 (10Esanders) [10:39:09] (03CR) 10Esanders: [C: 04-1] "tested - didn't work :)" (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/223683 (https://phabricator.wikimedia.org/T105239) (owner: 10Jforrester) [10:40:18] (03PS2) 10Esanders: ApiVisualEditor: Ask Parsoid to 'scrubWikitext' on save [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/223683 (https://phabricator.wikimedia.org/T105239) (owner: 10Jforrester) [10:50:17] (03PS1) 10Esanders: Revert "For empty / whitespace-only headings, output

instead of " [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/223759 [11:02:52] (03PS4) 10Zfilipin: WIP QA: Upgrading to mw-selenium 1.x [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/222143 (https://phabricator.wikimedia.org/T99661) (owner: 10Dduvall) [11:03:42] (03CR) 10Zfilipin: "Patch set 4 fixes two rubocop violations." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/222143 (https://phabricator.wikimedia.org/T99661) (owner: 10Dduvall) [11:06:48] (03CR) 10Zfilipin: [C: 031] WIP QA: Upgrading to mw-selenium 1.x [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/222143 (https://phabricator.wikimedia.org/T99661) (owner: 10Dduvall) [11:45:44] 10VisualEditor, 10VisualEditor-MediaWiki-References, 7Browser-Support-Firefox, 5WMF-deploy-2015-06-30_(1.26wmf12): Right-clicking on the reference inspector offers to search Google for "☢" - https://phabricator.wikimedia.org/T104185#1440845 (10Esanders) 5Open>3Resolved The fix was for all instances. If... [12:08:39] (03PS1) 10Esanders: Strip data related attributes from paste context [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/223767 [12:24:18] 10VisualEditor: this.model.getOuterRange is not a function - https://phabricator.wikimedia.org/T104580#1440976 (10Esanders) Firstly instead of overriding core classes, you should be creating subclasses and registering those over the originals. I'm not sure what you need the fragment for at this point, but there... [12:38:46] 10VisualEditor, 10VisualEditor-MediaWiki-References, 10Parsoid, 3VisualEditor 2015/16 Q1 blockers: Copy-and-pasting a reference between VE surfaces causes a Parsoid 500 error - https://phabricator.wikimedia.org/T104230#1441027 (10Esanders) There is no reference body, just an id. We need to tell the convert... [12:39:21] Hey guys, anyone online? :) [12:40:08] (03PS1) 10Esanders: Never use orignal data optimisation when in clipboard mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/223770 (https://phabricator.wikimedia.org/T104230) [12:42:12] 10VisualEditor-LanguageTool, 7Easy: this.fragments doesn't seem to be used in mw.languageToolAction - https://phabricator.wikimedia.org/T105271#1441042 (10Aklapper) (Please feel enouraged to tag #easy tasks as such.) [12:42:17] (03CR) 10jenkins-bot: [V: 04-1] Never use orignal data optimisation when in clipboard mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/223770 (https://phabricator.wikimedia.org/T104230) (owner: 10Esanders) [12:42:46] 10VisualEditor-LanguageTool, 7Easy: this.ignoredRulesIds doesn't seem to be used in mw.languageToolAction - https://phabricator.wikimedia.org/T105270#1441044 (10Aklapper) (Please feel enouraged to tag #Easy tasks as such.) [13:04:22] 10VisualEditor: Why do I have to click on the undo arrow to exit a link edit? - https://phabricator.wikimedia.org/T105207#1441114 (10HistoryStamp) [15:15:44] 10VisualEditor: this.model.getOuterRange is not a function - https://phabricator.wikimedia.org/T104580#1441518 (10Nischayn22) I understand that's more of a comment on the code rather than this bug. I code is very messy, I need to fix it but first I need to make it working. [15:50:06] 10Citoid, 10VisualEditor: MediaWiki flakiness (?) caused (? causes ?) auto-cite tool to become unavailable somehow - https://phabricator.wikimedia.org/T104944#1441640 (10Jdforrester-WMF) [15:50:14] 10Citoid, 10VisualEditor, 3VisualEditor 2015/16 Q1 blockers: Value for citoid-template-type-map.json randomly missing in some languages - https://phabricator.wikimedia.org/T93800#1441641 (10Jdforrester-WMF) [15:50:27] 10Citoid, 10VisualEditor, 10MediaWiki-ResourceLoader, 3VisualEditor 2015/16 Q1 blockers: Value for citoid-template-type-map.json randomly missing in some languages - https://phabricator.wikimedia.org/T93800#1146361 (10Jdforrester-WMF) [16:08:20] (03PS1) 10Esanders: Fix padding in format dropdown [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/223814 [16:15:36] (03PS1) 10Esanders: Add checks to ve.ui.ContextItem#getFragment [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/223817 (https://phabricator.wikimedia.org/T104580) [16:21:55] 10VisualEditor, 7Browser-Support-Internet-Explorer, 3VisualEditor 2015/16 Q1 blockers: VisualEditor hangs on Spanish Wikipedia in IE11 - https://phabricator.wikimedia.org/T97788#1441770 (10Esanders) es.wiki have a bug in their common.js (using document.attachEvent which doesn't exist in IE11) but that doesn'... [16:31:02] 10Citoid, 10VisualEditor, 10MediaWiki-ResourceLoader, 3VisualEditor 2015/16 Q1 blockers: Value for citoid-template-type-map.json randomly missing in some languages - https://phabricator.wikimedia.org/T93800#1441825 (10Krinkle) Please do report here every time this happens again on one wiki or another. I ne... [16:32:20] Krenair, I don't have global admin, can you fix: https://es.wikipedia.org/wiki/MediaWiki_discusi%C3%B3n:Common.js#URGENT:_Exceptions_thrown_in_IE11 [16:33:14] looking [16:34:48] if ( +$.client.profile().versionBase < 11 ) ? [16:38:21] edsanders, can you test it now? [16:39:41] you can wrap more code if that if block [16:39:54] the three vars [16:40:20] works though [16:40:56] and the comment [16:41:21] also you've used tabs instead of spaces so indentation looks less readable [16:43:14] common.js is a nightmare [16:43:44] it should be wrapped in a try/catch that logs errors [16:44:22] edsanders, okay, shall I move the version check up to be with the IE check? [16:44:28] no [16:44:50] oh, I see, the three vars above it [16:45:00] yeah, and the comment probably [16:45:04] yeah [16:49:34] 10VisualEditor: VisualEditor does not preview changes to references - https://phabricator.wikimedia.org/T105362#1441968 (10He7d3r) 3NEW [16:55:57] 10VisualEditor, 10Wikimedia-General-or-Unknown, 7JavaScript: Catch errors thrown in common.js - https://phabricator.wikimedia.org/T105363#1441994 (10Esanders) 3NEW [16:57:40] 10VisualEditor: VisualEditor does not preview changes to references - https://phabricator.wikimedia.org/T105362#1442012 (10Esanders) The reference list at the bottom of the page uses a template. If you use a simple tag it will update, but we can't update the template without asking Parsoid to re-re... [16:58:44] 10VisualEditor, 7JavaScript: "TypeError: this.resizableSurface is null" after an edit using VisualEditor - https://phabricator.wikimedia.org/T105364#1442017 (10He7d3r) 3NEW [16:58:58] 10VisualEditor, 10VisualEditor-MediaWiki-References, 7Design: Show a message explaining how to edit references when user selects a references list - https://phabricator.wikimedia.org/T54736#1442026 (10Jdforrester-WMF) [16:59:16] 10VisualEditor: VisualEditor does not preview changes to references - https://phabricator.wikimedia.org/T105362#1442029 (10Jdforrester-WMF) [16:59:18] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Parsoid's render of {{reflist}} has no context, so no references appear; similarly, edited templates inside structures, look odd on edit - https://phabricator.wikimedia.org/T53146#1442030 (10Jdforrester-WMF) [17:01:04] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Parsoid's render of {{reflist}} has no context, so no references appear; similarly, edited templates inside structures, look odd on edit - https://phabricator.wikimedia.org/T53146#1442033 (10Esanders) Where is the bug to move all the functionality over... [17:01:52] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Table cell templates are editable, but their re-rendering is broken - https://phabricator.wikimedia.org/T69856#1442042 (10He7d3r) [17:01:54] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Parsoid's render of {{reflist}} has no context, so no references appear; similarly, edited templates inside structures, look odd on edit - https://phabricator.wikimedia.org/T53146#1442043 (10He7d3r) [17:03:43] 10VisualEditor, 6Editing-Department: Obviate the need for wikis' wrapper and functionality-replacement templates - https://phabricator.wikimedia.org/T95543#1442052 (10He7d3r) [17:03:45] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Parsoid's render of {{reflist}} has no context, so no references appear; similarly, edited templates inside structures, look odd on edit - https://phabricator.wikimedia.org/T53146#535649 (10He7d3r) [17:04:29] (03PS5) 10Jforrester: Update VE core submodule to master (baa21a8) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/223485 [17:08:06] 10VisualEditor, 7Browser-Support-Internet-Explorer, 3VisualEditor 2015/16 Q1 blockers: VisualEditor hangs on Spanish Wikipedia in IE11 - https://phabricator.wikimedia.org/T97788#1442058 (10Esanders) 5Open>3Resolved a:3Esanders [17:11:54] 10Citoid, 10VisualEditor, 10MediaWiki-ResourceLoader, 3VisualEditor 2015/16 Q1 blockers: Value for citoid-template-type-map.json randomly missing in some languages - https://phabricator.wikimedia.org/T93800#1442078 (10Mvolz) Will do. I'm also a little perplexed because if loading via inContentLanguage() d... [17:25:00] 10VisualEditor, 7JavaScript: "TypeError: this.resizableSurface is null" after an edit using VisualEditor - https://phabricator.wikimedia.org/T105364#1442158 (10Esanders) Which browser? [17:25:03] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 10OOjs-UI: TextInputWidget icon/indicator use the "pointer" (hand) mouse cursor, but don't do anything button-like - https://phabricator.wikimedia.org/T98213#1442159 (10matmarex) a:3matmarex [17:28:44] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 10OOjs-UI, 5OOjs-UI-next-release, 3VisualEditor 2015/16 Q1 blockers: TextInputWidget icon/indicator use the "pointer" (hand) mouse cursor, but don't do anything button-like - https://phabricator.wikimedia.org/T98213#1442166 (10Jdforrester-WMF) 5Open>3Res... [17:28:50] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 10OOjs-UI, 5OOjs-UI-next-release, 3VisualEditor 2015/16 Q1 blockers: TextInputWidget icon/indicator use the "pointer" (hand) mouse cursor, but don't do anything button-like - https://phabricator.wikimedia.org/T98213#1262448 (10Jdforrester-WMF) [17:29:26] 10VisualEditor, 7JavaScript: "TypeError: this.resizableSurface is null" after an edit using VisualEditor - https://phabricator.wikimedia.org/T105364#1442169 (10He7d3r) Firefox 39.0 on Ubuntu (Studio) 14.10. [17:36:46] 10Citoid, 10VisualEditor, 10MediaWiki-ResourceLoader, 3VisualEditor 2015/16 Q1 blockers: Value for citoid-template-type-map.json randomly missing in some languages - https://phabricator.wikimedia.org/T93800#1442260 (10Krinkle) >>! In T93800#1442078, @Mvolz wrote: > I'm also a little perplexed because if lo... [17:47:03] 10VisualEditor, 7Design, 3VisualEditor 2015/16 Q1 blockers: Increase width of inspectors on desktop - https://phabricator.wikimedia.org/T101290#1442277 (10Nirzar) @esanders I think it's not a big deal. to my eyes the link inspector is cramped and it's a very basic thing to have good enough white space. I can... [18:00:22] 10VisualEditor, 7JavaScript: "TypeError: this.resizableSurface is null" after an edit using VisualEditor - https://phabricator.wikimedia.org/T105364#1442305 (10He7d3r) [18:23:22] Hey, how likely is it for the fix at the bottom here: https://phabricator.wikimedia.org/T66822 to get cherry-picked back into the REL1_25 branch of VE? [18:31:20] (03PS1) 10Jforrester: MWMediaResourceProvider: Use exist instead of bool check on API values [extensions/VisualEditor] (REL1_25) - 10https://gerrit.wikimedia.org/r/223853 (https://phabricator.wikimedia.org/T66822) [18:31:31] Rosencrantz: Looks easy enough… [18:32:47] (03CR) 10Jforrester: [C: 032] MWMediaResourceProvider: Use exist instead of bool check on API values [extensions/VisualEditor] (REL1_25) - 10https://gerrit.wikimedia.org/r/223853 (https://phabricator.wikimedia.org/T66822) (owner: 10Jforrester) [18:32:51] Rosencrantz: {{done}} [18:32:57] Woo! [18:33:00] Thanks James_F ! [18:33:15] Rosencrantz: It'll take up to 24 hours (I think?) for ExtensionDistributor to pick it up. [18:33:20] But no worries. :-) [18:35:20] (03Merged) 10jenkins-bot: MWMediaResourceProvider: Use exist instead of bool check on API values [extensions/VisualEditor] (REL1_25) - 10https://gerrit.wikimedia.org/r/223853 (https://phabricator.wikimedia.org/T66822) (owner: 10Jforrester) [18:40:54] (03CR) 10Alex Monk: [C: 032] Update VE core submodule to master (baa21a8) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/223485 (owner: 10Jforrester) [18:43:51] (03Merged) 10jenkins-bot: Update VE core submodule to master (baa21a8) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/223485 (owner: 10Jforrester) [19:03:42] 10VisualEditor, 7JavaScript: "TypeError: str is undefined" when attempting to save and edit with VisualEditor - https://phabricator.wikimedia.org/T105386#1442544 (10He7d3r) 3NEW [19:09:38] 10VisualEditor, 7JavaScript: "TypeError: str is undefined" when attempting to save and edit with VisualEditor - https://phabricator.wikimedia.org/T105386#1442554 (10Jdforrester-WMF) p:5Triage>3Unbreak! Looks to be in ve.ce.FocusableNode#calculateHighlights on line 437: surfaceOffset = this.focusableSurf... [19:11:21] James_F, I tried opening the editor on that page and it worked.. [19:11:39] Is this on save? [19:12:09] Ah, right, the title says save. [19:12:13] So that would make sense. [19:12:16] :) [19:13:44] haha oh dear [19:14:12] I tried editing my sandbox from my WMF account on that wiki and an anti-vandal bot is not happy [19:35:16] Krenair: Ha. [19:37:23] hmm, random HTTP 500 from restbase [19:37:54] :-( [19:38:00] ;-( indeed [19:38:30] we are considering to 'clear the cache' [19:38:31] Thought the size of the RB shards or something has been reduced to fix those? [19:38:33] ah. [19:38:39] That might be expensive, I guess? [19:38:46] a truncate is very cheap [19:38:56] Re-calculating won't be. [19:39:01] but, like with varnish, it'll lead to cache misses afterwards [19:39:02] Lots of Parsoid load. [19:39:20] not much load, no- but increased client latency [19:39:25] Oh. [19:39:31] the client request rates are *very* low [19:39:32] Truncate and not re-fill? [19:39:40] Yes. [19:39:54] we can start to re-fill right away by doing an HTML dump, but it won't be instantaneous [19:40:01] * James_F nods. [19:40:09] Do we need a new HTML dump anyway? ;-) [19:40:23] feels like it, doesn't it? [19:40:32] * James_F grins. [19:40:37] Maybe we should do that, then. [19:40:40] James_F, do we know how many pages https://phabricator.wikimedia.org/T105386#1442554 applies to? [19:40:45] or what circumstances it appears under? [19:40:48] Krenair: No idea, sorry. [19:40:57] I tried a few basic things on my sandbox and couldn't reproduce the issue there [19:41:04] don't really want to touch a live article [19:41:14] Krenair: Better than not finding the bug… [19:41:28] Krenair: But it didn't trigger on wikitext diff, only on save. [19:41:46] James_F: we'll make a call in a bit, but definitely today [19:42:01] Krenair: You can self-revert a second later. [19:42:14] I'm not going to continue babysit C* 19 out of 24 hours per day [19:42:29] gwicke: Yeah. [19:42:34] James_F, Or I could copy the article contents into my sandbox [19:42:46] Krenair: That'd be a start. [19:43:49] And it saved fine. [19:43:55] Hmm. Odd. [19:44:17] Maybe there's something odd in Common.js or whatever that's interfering? Feels odd though. [19:44:59] James_F, did you test that in firefox? [19:45:05] Krenair: Chrome. [19:45:22] I was trying in chrome as well [19:45:35] if it was a common.js thing it'd likely affect both of us [19:45:48] True. [20:17:05] congrats for the promotions. [20:21:01] Elitre: Thank you. [20:23:50] 10VisualEditor, 6Collaboration-Team, 10Flow: Side rail description using VE asks about saving changes while nothing was changed - https://phabricator.wikimedia.org/T99893#1442837 (10SBisson) [20:26:26] 10VisualEditor-LanguageTool, 6Editing-Department, 6Language-Engineering, 3Google-Summer-of-Code-2015, 7I18n: Unified language proofing tools integration framework - https://phabricator.wikimedia.org/T89107#1442847 (10Ankita-ks) [20:26:28] 10VisualEditor-LanguageTool: Don't allow saving articles with LanguageTool highlighting - https://phabricator.wikimedia.org/T105145#1442845 (10Ankita-ks) 5Open>3Resolved [20:28:44] 10VisualEditor-LanguageTool: Create Labs project for LanguageTool Extension to VisualEditor - https://phabricator.wikimedia.org/T103111#1442858 (10Ankita-ks) 5Resolved>3Open [20:29:07] 10VisualEditor-LanguageTool: Create Labs project for LanguageTool Extension to VisualEditor - https://phabricator.wikimedia.org/T103111#1382679 (10Ankita-ks) 5Open>3Resolved [20:29:12] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 5Patch-For-Review, 3VisualEditor 2015/16 Q1 blockers: [Regression wmf13] Adding an link with the link inspector in insertion mode inserts an anchor with "/wiki/" prepended - https://phabricator.wikimedia.org/T104838#1442864 (10Krenair) a:3Krenair [20:30:07] 10VisualEditor-LanguageTool, 6Editing-Department, 6Language-Engineering, 3Google-Summer-of-Code-2015, 7I18n: Unified language proofing tools integration framework - https://phabricator.wikimedia.org/T89107#1442875 (10Ankita-ks) [20:30:08] 10VisualEditor-LanguageTool: Don't allow saving articles with LanguageTool highlighting - https://phabricator.wikimedia.org/T105145#1442874 (10Ankita-ks) 5Resolved>3Open [20:30:21] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/223707/ [20:56:49] (03CR) 10Jforrester: [C: 04-1] "Need to fix the tests." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/223770 (https://phabricator.wikimedia.org/T104230) (owner: 10Esanders) [21:15:00] (03PS6) 10Jforrester: ve.init.mw.TargetLoader: Error when RESTbase load call fails [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/221748 (https://phabricator.wikimedia.org/T97041) (owner: 10Alex Monk) [21:15:50] (03CR) 10Jforrester: "PS6: I've reverted the code back to using window.alert(), leaving the nice new OOUI code in a comment until such time as it's available." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/221748 (https://phabricator.wikimedia.org/T97041) (owner: 10Alex Monk) [21:33:18] 10VisualEditor, 10VisualEditor-MediaWiki: Replace wgVisualEditorNamespaces with a 2D array of namespace => enabled state - https://phabricator.wikimedia.org/T104898#1443144 (10Krenair) Per option 3 in @legoktm's comment in https://gerrit.wikimedia.org/r/#/c/223080/ This would also solve our double-listing of t... [21:52:22] (03PS1) 10Alex Monk: Replace wgVisualEditorNamespaces with an associative array [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/223967 (https://phabricator.wikimedia.org/T104898) [21:55:07] (03CR) 10jenkins-bot: [V: 04-1] Replace wgVisualEditorNamespaces with an associative array [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/223967 (https://phabricator.wikimedia.org/T104898) (owner: 10Alex Monk) [21:56:09] (03CR) 10Alex Monk: [C: 032] Fix padding in format dropdown [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/223814 (owner: 10Esanders) [21:58:45] (03Merged) 10jenkins-bot: Fix padding in format dropdown [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/223814 (owner: 10Esanders) [21:58:59] (03PS2) 10Alex Monk: Replace wgVisualEditorNamespaces with an associative array [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/223967 (https://phabricator.wikimedia.org/T104898) [22:03:35] Krenair: Neat; could you do a draft config patch to switch over to the new format? [22:05:13] (03CR) 10Alex Monk: [C: 032] Add checks to ve.ui.ContextItem#getFragment [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/223817 (https://phabricator.wikimedia.org/T104580) (owner: 10Esanders) [22:05:47] James_F, ok [22:05:55] Thanks. :-) [22:06:02] (03CR) 10Legoktm: [C: 04-1] Replace wgVisualEditorNamespaces with an associative array (035 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/223967 (https://phabricator.wikimedia.org/T104898) (owner: 10Alex Monk) [22:06:49] hi, I need help with something. I am trying to create an language-proofing extension for VisualEditor. So far I have managed to highlight the errors. What I would like to do now is show what the suggestions are when one clicks on the error. [22:07:16] Something like this : http://tools.wmflabs.org/languageproofing-ui/ [22:07:42] (03Merged) 10jenkins-bot: Add checks to ve.ui.ContextItem#getFragment [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/223817 (https://phabricator.wikimedia.org/T104580) (owner: 10Esanders) [22:07:59] (Click on 'Check Text', that will highlight the errors. Suggestions are displayed once you click on the highlighted errors) [22:08:18] Can anyone suggest how do I go about that? [22:08:31] 10VisualEditor, 10VisualEditor-DataModel: this.model.getOuterRange is not a function - https://phabricator.wikimedia.org/T104580#1443241 (10Jdforrester-WMF) 5Open>3Resolved p:5Triage>3Normal a:3Esanders [22:08:52] legoktm, how would we put $wgVisualEditorAvailableNamespaces[NS_USER] = true; into extension.json? [22:09:25] Krenair: { 2: true } [22:09:38] I don't think that will work? [22:09:51] grr json [22:10:03] >>> JSON.parse( "{ 2: true }" ) [22:10:03] Krenair: SyntaxError: Unexpected number [22:11:06] Krenair: {'2': true} should work because of PHP: [22:11:07] php > var_dump(array('2' => true)); [22:11:07] array(1) { [22:11:07] [2]=> [22:11:07] bool(true) [22:11:09] } [22:13:30] php > var_dump( json_decode( "{\"2\": true}" ) ); [22:13:30] object(stdClass)#1 (1) { [22:13:30] ["2"]=> [22:13:30] bool(true) [22:13:31] } [22:14:06] Oh. [22:14:12] php > var_dump( json_decode( "{'2': true}", true ) ); [22:14:12] array(1) { [22:14:12] [2]=> [22:14:12] bool(true) [22:14:13] } [22:14:15] WTF PHP? [22:17:17] Krenair: Yeah, setting the second param to true causes it to use associative arrays rather than stdClass for {} objects [22:17:33] Yeah. [22:18:12] Oh, I guess it has to convert that int to a string for stdClass. [22:18:13] Meh. [22:19:08] (03PS3) 10Alex Monk: Replace wgVisualEditorNamespaces with an associative array [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/223967 (https://phabricator.wikimedia.org/T104898) [22:27:12] edsanders, are we fixing anything specific in https://gerrit.wikimedia.org/r/#/c/223767/1 ? [22:43:27] 10VisualEditor: Visual editor (link inspector) prepending "/wiki/" to displayed text of internal links when created without text selected - https://phabricator.wikimedia.org/T105415#1443381 (10Thryduulf) 3NEW [22:44:47] Krenair: Dupe? ---^^ [22:44:56] yep [22:45:31] 10VisualEditor: Visual editor (link inspector) prepending "/wiki/" to displayed text of internal links when created without text selected - https://phabricator.wikimedia.org/T105415#1443401 (10Krenair) [22:45:32] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 5Patch-For-Review, 3VisualEditor 2015/16 Q1 blockers: [Regression wmf13] Adding an link with the link inspector in insertion mode inserts an anchor with "/wiki/" prepended - https://phabricator.wikimedia.org/T104838#1443402 (10Krenair) [22:46:56] 10VisualEditor: Visual editor (link inspector) prepending "/wiki/" to displayed text of internal links when created without text selected - https://phabricator.wikimedia.org/T105415#1443405 (10Thryduulf) I've managed to reproduce it (without saving) in the main namespace at it.wikipedia as well [22:52:52] 10VisualEditor: Page jumps while using link tool - https://phabricator.wikimedia.org/T105418#1443417 (10Nirzar) 3NEW a:3Esanders [23:05:42] Krenair, Chrome was messing up references when copying between instances in some circumstances [23:05:47] there was no bug for it [23:06:13] the existing paragraphs no have an id due to Parsoid

[23:07:19] we do a check that elements with IDs havent been removed, because Chrome does sometimes [23:07:29] but if that

has an id it throws off the check [23:20:29] (03CR) 10Esanders: [C: 032] "We should tidy this up so that LinkAnnotationWidget has a getText/Title method, rather than trying to use getHref for two purposes." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/223707 (https://phabricator.wikimedia.org/T104838) (owner: 10Alex Monk) [23:22:42] edsanders: Doesn't something like that exist? [23:22:51] (03Merged) 10jenkins-bot: Bypass ve.ui.MWInternalLinkAnnotationWidget.prototype.getHref when determining text [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/223707 (https://phabricator.wikimedia.org/T104838) (owner: 10Alex Monk) [23:22:52] I swear I remember creating something like that [23:23:12] there's a static method [23:23:24] which getHref uses [23:23:46] I refactored this all recently [23:31:55] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 3VisualEditor 2015/16 Q1 blockers: [Regression wmf13] Adding an link with the link inspector in insertion mode inserts an anchor with "/wiki/" prepended - https://phabricator.wikimedia.org/T104838#1443564 (10Krenair) [23:32:30] edsanders, should we backport and deploy that? ^ [23:33:29] probably? [23:34:24] It's broken in wikipedia production [23:34:27] doing [23:34:52] (03PS1) 10Alex Monk: Bypass ve.ui.MWInternalLinkAnnotationWidget.prototype.getHref when determining text [extensions/VisualEditor] (wmf/1.26wmf13) - 10https://gerrit.wikimedia.org/r/223983 (https://phabricator.wikimedia.org/T104838) [23:35:02] (03CR) 10Alex Monk: [C: 032] Bypass ve.ui.MWInternalLinkAnnotationWidget.prototype.getHref when determining text [extensions/VisualEditor] (wmf/1.26wmf13) - 10https://gerrit.wikimedia.org/r/223983 (https://phabricator.wikimedia.org/T104838) (owner: 10Alex Monk) [23:41:39] (03Merged) 10jenkins-bot: Bypass ve.ui.MWInternalLinkAnnotationWidget.prototype.getHref when determining text [extensions/VisualEditor] (wmf/1.26wmf13) - 10https://gerrit.wikimedia.org/r/223983 (https://phabricator.wikimedia.org/T104838) (owner: 10Alex Monk)