[00:38:44] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 5Patch-For-Review, 3VisualEditor 2015/16 Q1 blockers, and 2 others: [Regression wmf13] Adding an link with the link inspector in insertion mode inserts an anchor with "/wiki/" prepended - https://phabricator.wikimedia.org/T104838#1443678 (10Krenair) I backpor... [00:40:30] Krenair: Thanks for doing that [00:40:54] First Gerrit decided that the VE repository wasn't going to get automatic submodule updates [00:41:10] Then TalkTalk decided that I could no longer connect to wikitech, gerrit, git, bast1001... etc. [00:43:50] James_F, on the other hand, I did find out that we hadn't done any backports to wmf branches since May [00:44:22] Krenair: That sounds about right. It's been quiet and we've not had any backports for a while. [00:48:39] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 5Patch-For-Review, 3VisualEditor 2015/16 Q1 blockers, and 2 others: [Regression wmf13] Adding an link with the link inspector in insertion mode inserts an anchor with "/wiki/" prepended - https://phabricator.wikimedia.org/T104838#1443699 (10Jdforrester-WMF) ... [00:48:47] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 3VisualEditor 2015/16 Q1 blockers, 5WMF-deploy-2015-07-07_(1.26wmf13), 5WMF-deploy-2015-07-14_(1.26wmf14): [Regression wmf13] Adding an link with the link inspector in insertion mode inserts an anchor with "... - https://phabricator.wikimedia.org/T104838#1443701 [00:54:04] Anyway. [00:54:06] * James_F offs. [00:54:10] Krenair: Thanks again. [02:45:52] 10VisualEditor, 10Parsoid, 5Patch-For-Review, 3VisualEditor 2015/16 Q1 blockers: nowiki link-like strings that aren't in s - https://phabricator.wikimedia.org/T103364#1443828 (10cscott) 5Open>3Resolved a:3cscott [03:35:17] (03PS1) 10Legoktm: Gruntfile.js: Remove unused 'pkg' [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/224006 [03:35:42] (03PS1) 10Legoktm: Gruntfile.js: Remove unused 'pkg' [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/224007 [03:36:25] (03PS1) 10Legoktm: Gruntfile.js: Remove unused 'pkg' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/224008 [03:37:53] (03CR) 10jenkins-bot: [V: 04-1] Gruntfile.js: Remove unused 'pkg' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/224008 (owner: 10Legoktm) [03:39:03] (03Abandoned) 10Legoktm: Gruntfile.js: Remove unused 'pkg' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/224008 (owner: 10Legoktm) [04:48:14] 10VisualEditor, 10VisualEditor-ContentEditable: Cut and Paste of references occasionally fails - https://phabricator.wikimedia.org/T60552#1443913 (10Neil_P._Quinn_WMF) I can't reproduce either. [04:48:21] 10VisualEditor, 10VisualEditor-ContentEditable: Cut and Paste of references occasionally fails - https://phabricator.wikimedia.org/T60552#1443914 (10Neil_P._Quinn_WMF) 5Open>3Resolved [05:01:27] 10VisualEditor, 10VisualEditor-InterfaceLanguage, 10VisualEditor-MediaWiki, 7Design, 7I18n: The checkboxen in the save dialog wrap poorly if the texts are too long - https://phabricator.wikimedia.org/T70572#1443917 (10Neil_P._Quinn_WMF) [06:48:33] 10VisualEditor, 6Editing-Department, 10MediaWiki-extensions-ContentTranslation, 7Design, 7Epic: replace plain contenteditable with VisualEditor in ContentTranslation - https://phabricator.wikimedia.org/T105447#1444044 (10Amire80) 3NEW [06:49:17] 10VisualEditor, 6Editing-Department, 10MediaWiki-extensions-ContentTranslation, 7Design, 7Epic: [Epic] replace plain contenteditable with VisualEditor in ContentTranslation - https://phabricator.wikimedia.org/T105447#1444058 (10Amire80) [08:08:17] (03PS1) 10Hashar: Test please ignore [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/224027 [08:10:06] (03PS2) 10Hashar: Test please ignore [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/224027 [08:10:33] (03Abandoned) 10Hashar: Test please ignore [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/224027 (owner: 10Hashar) [10:20:20] 10VisualEditor, 10Browser-Tests, 10Wikimania-Hackathon-2015: add true internationalized content support to auto-screenshots - https://phabricator.wikimedia.org/T105466#1444372 (10Amire80) 3NEW [11:06:46] (03PS2) 10Esanders: Never use orignal data optimisation when in clipboard mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/223770 (https://phabricator.wikimedia.org/T104230) [11:24:12] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-Tables, 7Browser-Support-Firefox, 3VisualEditor 2015/16 Q1 blockers: Cannot move cursor into VisualEditor table cells in Firefox 39 and later - https://phabricator.wikimedia.org/T103035#1444559 (10Esanders) *sigh* this is a massive regression... [11:41:13] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-Tables, 7Browser-Support-Firefox, 3VisualEditor 2015/16 Q1 blockers: Cannot move cursor into VisualEditor table cells in Firefox 39 and later - https://phabricator.wikimedia.org/T103035#1444570 (10Esanders) In fact it's any ce=true/ce=false n... [12:04:01] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-Tables, 7Browser-Support-Firefox, 3VisualEditor 2015/16 Q1 blockers: Cannot move cursor into VisualEditor table cells in Firefox 39 and later - https://phabricator.wikimedia.org/T103035#1444586 (10Esanders) The irony being the regression was... [12:10:54] (03PS1) 10Esanders: Make table editing less critically broken in Firefox 39 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/224054 (https://phabricator.wikimedia.org/T103035) [12:53:51] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Parsoid's render of {{reflist}} has no context, so no references appear; similarly, edited templates inside structures, look odd on edit - https://phabricator.wikimedia.org/T53146#1444679 (10Aklapper) >>! In T53146#1442033, @Esanders wrote: > Where is... [14:22:37] 10VisualEditor: Cursor wobbles vertically in empty paragraph - https://phabricator.wikimedia.org/T105496#1444994 (10Esanders) 3NEW a:3Esanders [14:24:23] (03PS2) 10Esanders: Fix cursor wobble around chimeras [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/222363 (https://phabricator.wikimedia.org/T105496) [15:21:44] (03CR) 10Jforrester: Make table editing less critically broken in Firefox 39 (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/224054 (https://phabricator.wikimedia.org/T103035) (owner: 10Esanders) [15:49:23] 10VisualEditor, 6Editing-Department, 10MediaWiki-extensions-ContentTranslation, 7Design, 7Epic: [Epic] replace plain contenteditable with VisualEditor in ContentTranslation - https://phabricator.wikimedia.org/T105447#1445303 (10Amire80) [15:52:39] James_F, what will https://phabricator.wikimedia.org/T105239 solve exactly? [16:06:26] (03CR) 10Catrope: Make table editing less critically broken in Firefox 39 (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/224054 (https://phabricator.wikimedia.org/T103035) (owner: 10Esanders) [16:19:25] (03CR) 10Jforrester: [C: 031] Make table editing less critically broken in Firefox 39 (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/224054 (https://phabricator.wikimedia.org/T103035) (owner: 10Esanders) [17:54:09] Krenair: https://www.mediawiki.org/wiki/Parsoid/Normalizations#scrubWikitext [17:54:29] RoanKattouw, I found that page already [17:54:58] Does this just mean Parsoid will produce cleaner wikitext? [17:55:18] (03CR) 10Catrope: [C: 032] Make table editing less critically broken in Firefox 39 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/224054 (https://phabricator.wikimedia.org/T103035) (owner: 10Esanders) [17:55:38] (03PS1) 10Jforrester: Make table editing less critically broken in Firefox 39 [VisualEditor/VisualEditor] (wmf/1.26wmf13) - 10https://gerrit.wikimedia.org/r/224119 (https://phabricator.wikimedia.org/T103035) [17:55:44] (03CR) 10Jforrester: [C: 032] Make table editing less critically broken in Firefox 39 [VisualEditor/VisualEditor] (wmf/1.26wmf13) - 10https://gerrit.wikimedia.org/r/224119 (https://phabricator.wikimedia.org/T103035) (owner: 10Jforrester) [17:58:10] Yes, pretty much [17:58:11] (03Merged) 10jenkins-bot: Make table editing less critically broken in Firefox 39 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/224054 (https://phabricator.wikimedia.org/T103035) (owner: 10Esanders) [17:58:33] They implemented some of the cleanups we had been talking about implementing in VE for years [17:58:59] Like outputting foobar instead of foobar [17:59:05] (03Merged) 10jenkins-bot: Make table editing less critically broken in Firefox 39 [VisualEditor/VisualEditor] (wmf/1.26wmf13) - 10https://gerrit.wikimedia.org/r/224119 (https://phabricator.wikimedia.org/T103035) (owner: 10Jforrester) [17:59:07] It'll only do it on non-selser'ed stuff. [18:00:03] (03CR) 10Alex Monk: [C: 032] ApiVisualEditor: Ask Parsoid to 'scrubWikitext' on save [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/223683 (https://phabricator.wikimedia.org/T105239) (owner: 10Jforrester) [18:00:13] Woo. [18:00:27] (03PS1) 10Jforrester: Update VE core submodule to master (80b68df) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/224121 [18:03:05] (03PS1) 10Jforrester: Update VE core submodule to 1.26wmf13 HEAD (80b68df) [extensions/VisualEditor] (wmf/1.26wmf13) - 10https://gerrit.wikimedia.org/r/224122 [18:05:34] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to 1.26wmf13 HEAD (80b68df) [extensions/VisualEditor] (wmf/1.26wmf13) - 10https://gerrit.wikimedia.org/r/224122 (owner: 10Jforrester) [18:06:09] (03CR) 10Jforrester: "recheck" [extensions/VisualEditor] (wmf/1.26wmf13) - 10https://gerrit.wikimedia.org/r/224122 (owner: 10Jforrester) [18:07:10] (03Merged) 10jenkins-bot: ApiVisualEditor: Ask Parsoid to 'scrubWikitext' on save [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/223683 (https://phabricator.wikimedia.org/T105239) (owner: 10Jforrester) [18:07:43] 10VisualEditor, 10VisualEditor-MediaWiki, 10Parsoid, 3VisualEditor 2015/16 Q1 blockers: Enable scrubWikitext=1 in VisualEditor's save route to Parsoid - https://phabricator.wikimedia.org/T105239#1446010 (10Jdforrester-WMF) 5Open>3Resolved a:3Jdforrester-WMF [18:09:00] 10VisualEditor, 10VisualEditor-DataModel, 7Epic, 3VisualEditor 2015/16 Q1 blockers: VisualEditor: Ordered application of annotations to avoid fragmentation (e.g. ''[[Foo|Fo]]''[[Foo|o]]) - https://phabricator.wikimedia.org/T52098#1446019 (10Jdforrester-WMF) Now that {T105239} is done, this should only impa... [18:11:06] 10VisualEditor, 10VisualEditor-DataModel, 7Epic: VisualEditor: Ordered application of annotations to avoid fragmentation (e.g. ''[[Foo|Fo]]''[[Foo|o]]) - https://phabricator.wikimedia.org/T52098#1446037 (10Jdforrester-WMF) p:5Normal>3Low [18:18:37] 10VisualEditor, 10VisualEditor-DataModel: VisualEditor: Link annotations can be split into two adjacent ones when other annotations overlap - https://phabricator.wikimedia.org/T75202#1446076 (10Jdforrester-WMF) Note that this remains the case even post {T105239} as Parsoid's `scrubWikitext` model doesn't aggre... [18:22:00] 10VisualEditor, 10VisualEditor-DataModel, 7Epic: Ordered application of annotations to avoid fragmentation (e.g. ''[[Foo|Fo]]''[[Foo|o]]) - https://phabricator.wikimedia.org/T52098#1446102 (10Jdforrester-WMF) a:5Esanders>3None [18:36:11] (03CR) 10Alex Monk: [C: 032] Update VE core submodule to master (80b68df) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/224121 (owner: 10Jforrester) [18:36:38] Krenair: Thanks; asking Chad in -releng if it's OK to deploy the wmf13 one. [18:38:37] (03Merged) 10jenkins-bot: Update VE core submodule to master (80b68df) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/224121 (owner: 10Jforrester) [18:48:24] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic, 3VisualEditor 2015/16 Q1 blockers: VisualEditor: Where VisualEditor is the primary editor, redlinks in read mode should open VE (not wikitext editor) - https://phabricator.wikimedia.org/T55441#1446154 (10Krenair) I'm not sure we want to use this h... [18:51:48] James_F, shall I take that as a yes...? [18:52:07] Krenair: I… guess. [18:52:16] Krenair: (Tested in Beta Cluster and it works well.) [18:53:07] (03CR) 10Alex Monk: [C: 032] Update VE core submodule to 1.26wmf13 HEAD (80b68df) [extensions/VisualEditor] (wmf/1.26wmf13) - 10https://gerrit.wikimedia.org/r/224122 (owner: 10Jforrester) [18:55:41] (03Merged) 10jenkins-bot: Update VE core submodule to 1.26wmf13 HEAD (80b68df) [extensions/VisualEditor] (wmf/1.26wmf13) - 10https://gerrit.wikimedia.org/r/224122 (owner: 10Jforrester) [18:56:15] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic, 3VisualEditor 2015/16 Q1 blockers: VisualEditor: Where VisualEditor is the primary editor, redlinks in read mode should open VE (not wikitext editor) - https://phabricator.wikimedia.org/T55441#1446171 (10Ricordisamoa) >>! In T55441#1446154, @Krena... [19:13:23] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic, 3VisualEditor 2015/16 Q1 blockers: VisualEditor: Where VisualEditor is the primary editor, redlinks in read mode should open VE (not wikitext editor) - https://phabricator.wikimedia.org/T55441#1446206 (10Solstag) Please, this bug is not about havi... [19:43:04] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-Tables, 3VisualEditor 2015/16 Q1 blockers, and 2 others: Cannot move cursor into VisualEditor table cells in Firefox 39 and later - https://phabricator.wikimedia.org/T103035#1446250 (10Jdforrester-WMF) 5Open>3Resolved p:5High>3Unbreak!... [19:45:36] edsanders: https://gerrit.wikimedia.org/r/#/c/221748/ CR? [19:45:57] (03PS3) 10Catrope: Never use original data optimisation when in clipboard mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/223770 (https://phabricator.wikimedia.org/T104230) (owner: 10Esanders) [19:46:46] (03CR) 10Catrope: [C: 032] Never use original data optimisation when in clipboard mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/223770 (https://phabricator.wikimedia.org/T104230) (owner: 10Esanders) [19:47:41] (03PS1) 10Jforrester: Never use original data optimisation when in clipboard mode [extensions/VisualEditor] (wmf/1.26wmf13) - 10https://gerrit.wikimedia.org/r/224172 (https://phabricator.wikimedia.org/T104230) [19:47:56] (03CR) 10Jforrester: [C: 031] "For Monday's SWAT, I suggest." [extensions/VisualEditor] (wmf/1.26wmf13) - 10https://gerrit.wikimedia.org/r/224172 (https://phabricator.wikimedia.org/T104230) (owner: 10Jforrester) [19:49:43] (03Merged) 10jenkins-bot: Never use original data optimisation when in clipboard mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/223770 (https://phabricator.wikimedia.org/T104230) (owner: 10Esanders) [19:51:39] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic, 3VisualEditor 2015/16 Q1 blockers: VisualEditor: Where VisualEditor is the primary editor, redlinks in read mode should open VE (not wikitext editor) - https://phabricator.wikimedia.org/T55441#1446269 (10matmarex) >>! In T55441#1446171, @Ricordisa... [19:59:02] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic, 3VisualEditor 2015/16 Q1 blockers: VisualEditor: Where VisualEditor is the primary editor, redlinks in read mode should open VE (not wikitext editor) - https://phabricator.wikimedia.org/T55441#1446273 (10Jdforrester-WMF) >>! In T55441#1446206, @So... [20:02:23] 10VisualEditor, 6Editing-Department, 10MediaWiki-extensions-ContentTranslation, 7Design, 7Epic: [Epic] replace plain contenteditable with VisualEditor in ContentTranslation - https://phabricator.wikimedia.org/T105447#1446282 (10Amire80) I am adding this task as a blocker to several other tasks, just to s... [20:02:53] 10VisualEditor, 6Editing-Department, 10MediaWiki-extensions-ContentTranslation, 7Design, 7Epic: [Epic] replace plain contenteditable with VisualEditor in ContentTranslation - https://phabricator.wikimedia.org/T105447#1446284 (10Amire80) [20:03:04] 10VisualEditor, 6Editing-Department, 10MediaWiki-extensions-ContentTranslation, 7Design, 7Epic: [Epic] replace plain contenteditable with VisualEditor in ContentTranslation - https://phabricator.wikimedia.org/T105447#1444044 (10Amire80) [20:03:14] 10VisualEditor, 6Editing-Department, 10MediaWiki-extensions-ContentTranslation, 7Design, 7Epic: [Epic] replace plain contenteditable with VisualEditor in ContentTranslation - https://phabricator.wikimedia.org/T105447#1444044 (10Amire80) [20:25:00] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki-References, 7Browser-Support-Google-Chrome, and 2 others: Citations in VisualEditor are copied as regular links on Chrome - https://phabricator.wikimedia.org/T104788#1446316 (10Jdforrester-WMF) 5Open>3Resolved a:3Esanders [20:29:07] Krenair, is there a hook that an extension can use after VE save ? [20:29:34] mooeypoo, on the server-side, specifically after VE only? [20:29:51] Krenair, preferably JS actually, but could be server side [20:30:52] I don't think we have anything on the server-side for it [20:31:00] client side is better [20:31:08] wikipage.content should work, I think? [20:31:18] mooeypoo: mw.hook( 'wikipage.content' ).add( function ( $content ) { .... } ); [20:31:27] ferdbold, ^^ [20:31:30] That'd fire on non-VE things [20:31:34] Yes it would [20:31:39] See https://doc.wikimedia.org/mediawiki-core/master/js/#!/api/mw.hook for more documentation on this system [20:31:52] modules/ve-mw/ui/dialogs/ve.ui.MWSaveDialog.js: mw.hook( 've.saveDialog.stateChanged' ).fire(); [20:32:41] we need to have it when the new content loaded, though [20:32:45] so we can refresh vega [20:32:48] I wonder what that hook is for. [20:32:57] It doesn't seem particularly useful for this though [20:33:17] You're talking about the stateChanged hook or wikipage.content hook? [20:34:04] I know wikipage.content gets called after a VE save, that's how the current error with vega reloading gets logged [20:34:52] mooeypoo, statechanged [20:35:29] ferdbold, then if you register the hook with a function that reloads vega it should work, no? [20:36:07] it's not actually about reloading vega, it's about refreshing a particular mw.config parameter [20:36:19] Krenair, re https://gerrit.wikimedia.org/r/#/c/221748/6/modules/ve-mw/init/ve.init.mw.TargetLoader.js [20:36:20] wait, why? [20:36:26] I'd remove the message dialog code [20:36:41] ferdbold, oh, crap. var specs = mw.config.get( 'wgGraphSpecs' ); [20:36:43] this.. [20:36:45] the way ext.graph works is by looking for tags that have specific graph IDs in them [20:36:59] when you edit a graph its ID gets refreshed, but ext.graph doesn't know about it [20:37:01] given OOUI's browser support it isn't going to be loaded by default soon [20:37:17] Hm. [20:37:21] doesn't MW have a messaging system we can use? [20:37:42] edsanders, James added that and it wasn't going to work. He then commented it out. [20:38:01] There is mw.notify [20:38:26] hm [20:38:35] edsanders: We're going to have OOUI available on page paint relatively soon. [20:38:46] edsanders: It's going to be used to construct chunks of the wider UI, so… [20:38:51] and since wikipage.content already fetches wgGraphSpecs, it seems like this doesn't get refreshed at all until a hard reload of the page [20:38:51] 10WikiEditor: Media selector doesn't find local media in private wiki - https://phabricator.wikimedia.org/T65282#1446346 (10Tgr) Presumably some permission is missing. Can you post the exact API requests and responses? [20:39:05] really, the JS? [20:39:48] let's put it in a separate commit, anyway then I don't have to review your commented code [20:40:23] ferdbold, I put the debugger statement in the hook, it doesn't seem like that's the issue. It seems like the issue is that it fires before the page is appended again, which means the graph extension checks for [20:40:24] $content.find( '.mw-wiki-graph' ).each( function () { [20:40:29] mw.notify might not be error-y enough though [20:40:30] and no .mw-wiki-graph is found [20:41:00] and yet, this is testing over the new $content. It should work [20:43:10] edsanders: :-P [20:43:12] edsanders: OK. [20:43:31] edsanders: And yeah, mw.notify is not appropriate. This is a modal "oh dear everything broke" message. [21:06:30] Krenair, when I'm adding a hook, say, the wikipage.content -- is there a way to make sure my function loads early? as in, 'run this first'? the .add seems to add it to a queue [21:08:35] I don't think so [21:08:43] What are you trying to achieve exactly? [21:09:21] Krenair, Graph extension already has a hook for wikipage.content -- it uses it to re-render the graphs [21:09:48] the problem is that it reads its data from a config that's set in the server-side script; it basically attaches the specs of each graph to the graph ID. [21:10:32] When we change things (So, when VE edits a graph) the Id of that graph CHANGES. We need to change the config variable that the already-existing hook uses to render the graphs -- because the Ids are now different [21:10:51] So we need to get the new method running before the general graph method for the same hook is running. [21:10:54] that makes sense? [21:12:22] I don't think you can do that [21:13:56] But I don't know enough about what you're trying to do to help [21:14:28] okay I think we have a reasonable plan B, but I was hoping that there's a better and easier way [21:17:27] Okay.. [21:37:45] Krenair, basically, graph extension does X on wikipage.content. We are creating a VE module for the graph extension, and it needs to do Y *before* graph extension does its X. [21:38:05] yes, I understand that bit [21:38:22] That's what we're not sure we can do [21:40:12] I don't think so [21:40:18] Krinkle_ might have some ideas [21:40:48] Even if you can mess around with what hooks are registered, you probably shouldn't [21:41:01] what callbacks are registered for a hook* [21:45:24] hm [22:53:39] (03PS1) 10Jforrester: Comment*: Use the same icon for the CE and UI renderings [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/224197 (https://phabricator.wikimedia.org/T94479) [22:55:57] (03CR) 10jenkins-bot: [V: 04-1] Comment*: Use the same icon for the CE and UI renderings [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/224197 (https://phabricator.wikimedia.org/T94479) (owner: 10Jforrester) [23:07:54] (03PS2) 10Jforrester: Comment*: Use the same icon for the CE and UI renderings [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/224197 (https://phabricator.wikimedia.org/T94479) [23:36:06] (03CR) 10Jforrester: [C: 04-1] "OOjs UI dependency isn't merged, let alone released, yet." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/224197 (https://phabricator.wikimedia.org/T94479) (owner: 10Jforrester)