[10:36:39] WYSIWYG, my ass... https://usercontent.irccloud-cdn.com/file/fBV79JCx/User%20Josve05a%20-%20Wikimedia%20Commons.png https://usercontent.irccloud-cdn.com/file/SSAWGZAp/Editing%20User%20Josve05a%20-%20Wikimedia%20Commons.png [10:38:08] that is quite curious. [10:38:36] (sorry for my lang.) [10:39:22] i guess Parsoid is interpreting the broken HTML differently that PHP parser? there's something very wrong with the 'style' attribute on that 'div' [10:40:02] also, is the image "selected" in the second image, or does the color tint actually change when editing? [10:40:53] 1. The same thing happens for the template {{enwp}} on sv.wp. [10:41:54] 2. I think I hovered (sp?) my mouse over the image... [10:42:21] re 2, yeah, i think that's it [10:42:30] this template https://commons.wikimedia.org/w/index.php?title=Template:Refbegin&action=edit definitely generates bad HTML [10:43:20] heh, and no one noticed for 8 years [10:43:20] Well it should be used in conjunction with {{refend}} https://commons.wikimedia.org/w/index.php?title=Template:Refend&action=edit [10:43:29] yeah, but apart from that [10:43:54] It is displaying correctly in viewer-mode, at least :) [10:43:55] it generates a 'div' with multiple 'style' attributes, every attribute must only appear once and repeated occurences are ignored [10:44:11] (buyt I've seen different templates on multiple wikis have this problem.. [10:44:25] and the {{#if…}}-s are incorrectly nested with the multiple attributes [10:44:25] but* [10:44:53] it's still an interesting failure case for parsoid… but the template is definitely badly made [10:45:30] look at this part: {{#if: {{{colwidth|}}}| style="-moz-column-width:{{{colwidth}}}; column-width:{{{colwidth}}};" | {{#if: {{{1|}}}| style="-moz-column-count:{{{1}}}; column-count:{{{1}}} }}};" |}} [10:45:39] there is one '}}}' too many at the end [10:46:15] hmm, in fact [10:47:01] instead of: }}};" |}} it should be: ;" }} }} [10:47:07] i think. didn't test. [10:47:23] haha, so much wrong with old templates [10:48:50] and I wouldn't dare to test it, since if I brake soemthing, I can't fix it [10:59:07] 10WikiEditor: Media selector doesn't find local media in private wiki - https://phabricator.wikimedia.org/T65282#1466587 (10Fannon) Yes, this is the API request that fails to find the image: ``` api.php?callback=jQuery1113038504008506424725_1437475882811&action=query&format=json&iiurlheight=200&generator=search... [11:04:35] I want to report citoid malfuntions, but I think they are all already reported, so I don't want to report them, but...you know...it feels odd :P [11:08:45] 10Citoid, 10VisualEditor: Random DOIs and links from sv.wiki tested with Citoid on the Beta site [Random tests] - https://phabricator.wikimedia.org/T106201#1466601 (10Josve05a) @Mvolz I did another small test with links and doi's: - http://query.nytimes.com/mem/archive-free/pdf?res=FB0610FF3F5912738DDDAC0A9... [11:12:07] Hi, I need help with understanding how LinkAnnotationInspectors work. [11:13:01] I want to implement something like this for my extension LanguageTool where a the errors are highlighted and when the user clicks on an error an inspector appears to describe what the error is. [11:13:24] MatmaRex : Could you spare a minute? [11:14:47] hi ankita-ks, sure. but i'm not all up-to-date on VisualEditor internals currently. [11:15:23] MatmaRex : Alright, I have some very basic questions to start with so if you could suggest who do i ask? [11:15:35] For starters I want to know how annotation is added to dm [11:15:45] I could create my own annotation then. [11:16:21] I can see that when VisualEditor is loaded, all links get the annotations attached to them. [11:16:39] ankita-ks: last time i looked at link inspector is was a complicated beast, you might want to start from LanguageInspector (probably unrelated to your project, despite the similar name) [11:16:59] Alright, looking at it. [11:17:36] (it lets you mark some text as being in a particular language, like English or German) [11:17:42] MatmaRex : where in the UI can I use it? [11:17:49] I could test it out. [11:19:27] ankita-ks: http://i.imgur.com/XrZa2bx.png [11:19:40] Thanks! [11:19:40] :) [11:41:11] 10Citoid, 10VisualEditor: Random DOIs and links from sv.wiki tested with Citoid on the Beta site [Random tests] - https://phabricator.wikimedia.org/T106201#1466610 (10Mvolz) Re: nytimes, yes, the translator doesn't recognise that url so that should be fixed upstream. Re: DOI, that is being recognized, or at l... [11:53:50] 10Citoid, 6Services: DOI redirect handler for iopscience is very slow/ potentially causes citoid to behave oddly. - https://phabricator.wikimedia.org/T106374#1466616 (10Mvolz) 3NEW [11:54:32] 10Citoid, 6Services: DOI redirect handler for iopscience is very slow/ potentially causes citoid to behave oddly. - https://phabricator.wikimedia.org/T106374#1466632 (10Mvolz) @mobrovac, can you replicate this on your localhost? Not sure why it's having so much trouble finding redirect. [12:09:38] MatmaRex : is there some documentation on how annotations work? Currently I can see a lot of functions that I can not figure out. For instance, toDomElements or toDataElements [12:10:40] 10Citoid, 10VisualEditor: Random DOIs and links from sv.wiki tested with Citoid on the Beta site [Random tests] - https://phabricator.wikimedia.org/T106201#1466734 (10Josve05a) Re the Doi, if i just used the doi it didn't work on the beta cluser. if I used the "doi.org-url" it didn't work, but if I tried the "... [12:11:07] 10Citoid, 6Services: DOI redirect handler for iopscience is very slow/ potentially causes citoid to behave oddly. - https://phabricator.wikimedia.org/T106374#1466736 (10Josve05a) [12:11:09] 10Citoid, 10VisualEditor: Random DOIs and links from sv.wiki tested with Citoid on the Beta site [Random tests] - https://phabricator.wikimedia.org/T106201#1466735 (10Josve05a) [12:14:25] ankita-ks: i'm not aware of any documentation :( ask edsanders|away or RoanKattouw_away when they're online, i think [12:14:50] MatmaRex : Alright, will do. [12:27:53] 10Citoid, 10MediaWiki-Vagrant: Citoid provisioning fails with npm errors - https://phabricator.wikimedia.org/T103634#1466747 (10Mvolz) Is this resolved? [12:29:33] 10Citoid: Results of a test with 10 random .es URLs on the beta cluster - https://phabricator.wikimedia.org/T98902#1466755 (10Mvolz) [12:34:33] 10Citoid, 10VisualEditor: Random DOIs and links tested with Citoid on the Beta site [Random tests] - https://phabricator.wikimedia.org/T106201#1466757 (10Josve05a) [12:37:57] 10Citoid, 10VisualEditor: STICKY: Report failing DOIs or URLs here. - https://phabricator.wikimedia.org/T106201#1466759 (10Mvolz) [12:38:22] 10Citoid, 10VisualEditor: STICKY: Report failing DOIs or URLs here. - https://phabricator.wikimedia.org/T106201#1461716 (10Mvolz) [12:38:42] 10Citoid, 10VisualEditor: STICKY: Report failing DOIs or URLs here. - https://phabricator.wikimedia.org/T106201#1461716 (10Mvolz) [12:39:24] 10Citoid, 10VisualEditor: Random DOIs and links tested with Citoid on the Beta site [Random tests] - https://phabricator.wikimedia.org/T106201#1466769 (10Josve05a) [12:40:08] sucheta : around? [12:41:15] Could you help me out with figuring out annotations on VisualEditor? What do the functions 'toDataElements' and 'toDomElements' do? [12:42:40] 10Citoid, 10VisualEditor: STICKY: Report failing DOIs or URLs here. - https://phabricator.wikimedia.org/T106201#1466778 (10Josve05a) [12:44:39] 10Citoid, 10VisualEditor: STICKY: Report failing DOIs or URLs here. - https://phabricator.wikimedia.org/T106201#1461716 (10Josve05a) [12:45:40] 10Citoid, 10VisualEditor: STICKY: Report failing DOIs or URLs here. - https://phabricator.wikimedia.org/T106201#1466783 (10Josve05a) [13:01:24] 10Citoid, 10VisualEditor: STICKY: Report failing DOIs or URLs here. - https://phabricator.wikimedia.org/T106201#1466794 (10Josve05a) [13:03:11] divec : Hi, could you help me understand how new annotations are created an added in VisualEditor? [13:30:41] 10Citoid, 10VisualEditor: STICKY: Report failing DOIs or URLs here. - https://phabricator.wikimedia.org/T106201#1466828 (10Josve05a) [13:38:58] 10Citoid, 10VisualEditor: STICKY: Report failing DOIs or URLs here. - https://phabricator.wikimedia.org/T106201#1466835 (10Josve05a) [13:45:50] 10Citoid, 10VisualEditor: STICKY: Report failing DOIs or URLs here. - https://phabricator.wikimedia.org/T106201#1466843 (10Josve05a) [14:52:09] ankita-ks_ , divec - hi [14:52:24] ankita-ks_ had some questions about how inspectors work [14:52:31] divec, can you please help? [14:53:02] 10TemplateData: Display a warning when user will leave TemplateData form - https://phabricator.wikimedia.org/T106382#1467006 (10Trizek-WMF) 3NEW [14:53:23] divec aharoni : hi [16:24:54] 10VisualEditor: Add edges to Phabricator task data dump transaction history - https://phabricator.wikimedia.org/T104920#1467330 (10chasemp) a:5chasemp>3csteipp Need to get @csteipp's feeling on this but I think it's OK.... Examples... 1. Adding project `foo` ``` id: 602 phid: PHID... [16:35:57] (03CR) 10Jforrester: [C: 032] [BrowserTest] Add prefixes to language screenshot messages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/225844 (owner: 10Amire80) [16:38:02] ... wait a minute [16:38:06] ryasmeen, .... are you here? [16:38:37] (03Merged) 10jenkins-bot: [BrowserTest] Add prefixes to language screenshot messages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/225844 (owner: 10Amire80) [16:40:02] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 3VisualEditor 2015/16 Q1 blockers: Broken link inspector UI with Context menu and link inspector appearing together after placing the cursor at the end of the selected text to close the link inspector - https://phabricator.wikimedia.org/T98811#1467503 (10Neil_P.... [16:47:56] 10VisualEditor, 6Collaboration-Team, 10OOjs-UI, 10Wikimania-Hackathon-2015, and 2 others: Extract the 'typos linter' task and make it an npm package - https://phabricator.wikimedia.org/T104916#1467532 (10Jdforrester-WMF) 5Open>3Resolved [16:48:06] 10VisualEditor, 6Collaboration-Team, 10OOjs-UI, 10Wikimania-Hackathon-2015, and 2 others: Extract the 'typos linter' task and make it an npm package - https://phabricator.wikimedia.org/T104916#1432151 (10Jdforrester-WMF) [16:55:36] (03CR) 10Alex Monk: [C: 032] WikiEditor: Improve help section [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/225849 (https://phabricator.wikimedia.org/T26128) (owner: 10Gerrit Patch Uploader) [16:56:47] (03Merged) 10jenkins-bot: WikiEditor: Improve help section [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/225849 (https://phabricator.wikimedia.org/T26128) (owner: 10Gerrit Patch Uploader) [17:19:27] James_F: can you point me to more info about the OAuth session expiration issue you mentioned the other day? [17:33:56] mooeypoo : around? [17:34:58] divec : around? [17:36:46] mooeypoo : If you have a few minutes, could you explain the code flow of LanguageInspector? [17:36:59] or point me to some related documentation? [17:40:14] edsanders : can you help? [18:12:41] 10VisualEditor, 3VisualEditor 2015/16 Q1 blockers: Improvements to VE Burnup charts - https://phabricator.wikimedia.org/T105929#1467957 (10Jdforrester-WMF) [18:14:18] 10VisualEditor, 6Community-Liaison, 10Wikimania-Hackathon-2015, 3VisualEditor 2015/16 Q1 blockers: VisualEditor translathon at Wikimania Mexico - https://phabricator.wikimedia.org/T91108#1467962 (10Jdforrester-WMF) 5Open>3Resolved [18:15:19] 10VisualEditor, 10VisualEditor-Performance, 7Epic, 5Patch-For-Review, and 3 others: Internal nodes should eventually be in a separate document ("sub-documents") - https://phabricator.wikimedia.org/T49344#1467963 (10Jdforrester-WMF) [18:15:28] 10VisualEditor, 10VisualEditor-MediaWiki, 10RESTBase, 7Epic, and 2 others: VisualEditor: Provide a way for the user to switch between VisualEditor and wikitext source editor modes without saving - https://phabricator.wikimedia.org/T49779#1467966 (10Jdforrester-WMF) [18:15:40] 10VisualEditor, 10VisualEditor-MediaWiki, 7Epic, 3VisualEditor 2015/16 Q1 blockers: VisualEditor: Implement some form of auto-save - https://phabricator.wikimedia.org/T57370#1467970 (10Jdforrester-WMF) [18:15:41] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-Tables, 7Epic, 3VisualEditor 2015/16 Q1 blockers: Tab/Shift-Tab behaviour in contexts other than list indent/outdent (e.g. tables) - https://phabricator.wikimedia.org/T72665#1467972 (10Jdforrester-WMF) [18:16:19] 10VisualEditor, 10VisualEditor-DataModel, 3VisualEditor 2015/16 Q1 blockers: Strip initial and trailing
s out of section headings - https://phabricator.wikimedia.org/T68846#1467978 (10Jdforrester-WMF) [18:17:17] 10VisualEditor, 10VisualEditor-Initialisation, 10VisualEditor-Performance, 10MediaWiki-ResourceLoader, and 2 others: Pre-fetch VisualEditor modules to improve load speed - https://phabricator.wikimedia.org/T59952#1467987 (10Jdforrester-WMF) [18:17:26] 10VisualEditor, 10VisualEditor-DataModel, 7Epic, 3VisualEditor 2015/16 Q1 blockers: VisualEditor: Deal with universal types like mw:Error, mw:ExpandedAttrs, mw:Placeholder - https://phabricator.wikimedia.org/T63969#1467990 (10Jdforrester-WMF) [18:18:53] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 7Browser-Support-Android-Google-Chrome, 3VisualEditor 2015/16 Q1 blockers: VisualEditor Mobile: Tapping at the end of each link duplicates the preceding link text in Nexus 7 (Android 4.4.2) - https://phabricator.wikimedia.org/T68754#1468002 (10Jdforrester-WMF) [18:18:56] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 7Browser-Support-Android-Google-Chrome, 3VisualEditor 2015/16 Q1 blockers: VisualEditor Mobile: Cursor moving handle (?) doesn't appear in Android - https://phabricator.wikimedia.org/T68783#1468004 (10Jdforrester-WMF) [18:18:57] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 7Browser-Support-Android-Google-Chrome, 3VisualEditor 2015/16 Q1 blockers: VisualEditor Mobile: In android, while trying to apply a link on a selected text, strips off the first letter of the text in the link ... - https://phabricator.wikimedia.org/T70244#1468006 [18:19:18] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 7Browser-Support-Google-Chrome, 3VisualEditor 2015/16 Q1 blockers: VisualEditor Mobile: Chrome for mobile keyboard doesn't fire useful key events for backspace - https://phabricator.wikimedia.org/T69262#1468010 (10Jdforrester-WMF) [18:19:21] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3VisualEditor 2015/16 Q1 blockers: VisualEditor Mobile: For long drop down menus the options are not at all accessible when the screen is set to landscape in iOS device - https://phabricator.wikimedia.org/T69340#1468012 (10Jdforrester-WMF) [18:19:23] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 7Browser-Support-Android-Google-Chrome, 3VisualEditor 2015/16 Q1 blockers: VisualEditor Mobile: Tapping on Return while cursor is at the end of a text, deletes that text in Nexus 7 (Android 4.4.2) - https://phabricator.wikimedia.org/T68758#1468017 (10Jdforres... [18:19:24] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 7Browser-Support-Android-Google-Chrome, 3VisualEditor 2015/16 Q1 blockers: VisualEditor Mobile: Tapping at the end of each link, does copy-paste of preceding link text in Nexus 7(Android 4.4.2) - https://phabricator.wikimedia.org/T68755#1468019 (10Jdforrester... [18:19:42] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3VisualEditor 2015/16 Q1 blockers: VisualEditor Mobile: Allow formatting editing - https://phabricator.wikimedia.org/T67586#1468022 (10Jdforrester-WMF) [18:19:52] 10VisualEditor, 10VisualEditor-ContentEditable, 7Browser-Support-Apple-Safari, 7Epic, 3VisualEditor 2015/16 Q1 blockers: Native browser font styling tool fails to get content into DM, just CE, in Safari - https://phabricator.wikimedia.org/T63884#1468024 (10Jdforrester-WMF) [18:20:00] 10VisualEditor, 10VisualEditor-MediaWiki, 3VisualEditor 2015/16 Q1 blockers: VisualEditor: Provide support for BLP edit notices on enwiki - https://phabricator.wikimedia.org/T56029#1468026 (10Jdforrester-WMF) [18:20:14] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10VisualEditor-Performance, 7Browser-Support-Apple-Safari, and 2 others: VisualEditor Mobile: Switching tabs in mobile safari often causes page to refresh causing data loss of session changes - https://phabricator.wikimedia.org/T70017#1468028 (10Jdforrester-W... [18:20:35] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 7Browser-Support-Apple-Safari, 3VisualEditor 2015/16 Q1 blockers: VisualEditor Mobile: The Citation icon does not get highlighted upon clicking or tapping on it in Mobile VE using desktop Safari and iOS safari - https://phabricator.wikimedia.org/T74410#1468032... [18:20:37] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3VisualEditor 2015/16 Q1 blockers: VisualEditor Mobile: Performance issue with adding Citations in Mobile - https://phabricator.wikimedia.org/T72184#1468034 (10Jdforrester-WMF) [18:20:49] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 7Browser-Support-Android-Google-Chrome, 3VisualEditor 2015/16 Q1 blockers: VE Mobile: Tapping words sometimes moves them to the lead section and makes them bold - https://phabricator.wikimedia.org/T71634#1468041 (10Jdforrester-WMF) [18:20:52] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3VisualEditor 2015/16 Q1 blockers: Selecting nodes (references/images/templates) on iOS < 8 causes the on-screen keyboard to close, so they cannot be deleted - https://phabricator.wikimedia.org/T62110#1468043 (10Jdforrester-WMF) [18:21:05] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10VisualEditor-Tables, 3VisualEditor 2015/16 Q1 blockers: Editing tables in Mobile - Edit mode displays broken tables - https://phabricator.wikimedia.org/T74819#1468047 (10Jdforrester-WMF) [18:24:36] 10VisualEditor: Extract text contents of https://phabricator.wikimedia.org/project/sprint/profile/1297/ and put somewhere users can see - https://phabricator.wikimedia.org/T106401#1468057 (10Jdforrester-WMF) 3NEW a:3JAufrecht [18:26:06] ankita-ks, sorry, I'm back now [18:26:14] What do you mean the flow of the LanguageInspector ? [18:26:19] mooeypoo : hey! [18:26:39] hi :) [18:26:43] 10VisualEditor: Extract text contents of https://phabricator.wikimedia.org/project/sprint/profile/1297/ and put somewhere users can see - https://phabricator.wikimedia.org/T106401#1468057 (10Jdforrester-WMF) We're just putting them at [[https://www.mediawiki.org/wiki/VisualEditor/Weekly_triage_meetings]]. Also n... [18:27:01] I mean that you define a new annotation and it gets added to the text at some point of time. [18:27:41] That annotations can either be inspected and changed using LanguageInspector. [18:27:46] *annotation [18:28:06] I want to understand at what point in the code does the annotation get added. [18:28:42] hang on, the inspector got changed since i worked on it a while back, let me revisit that code [18:29:15] Alright :) [18:29:31] okay, so you have LanguageInspector which is a subset of AnnotationInspector [18:29:43] 10VisualEditor, 10Wikimedia-Site-requests: Enable VisualEditor on outreach.wikimedia.org - https://phabricator.wikimedia.org/T106298#1468071 (10Jdforrester-WMF) [18:29:44] 10VisualEditor, 10VisualEditor-EditingTools, 5WMF-deploy-2015-07-21_(1.26wmf15): Provide command whitelist in Target - https://phabricator.wikimedia.org/T106061#1468072 (10Jdforrester-WMF) [18:29:46] 10VisualEditor, 10VisualEditor-ContentEditable, 5WMF-deploy-2015-07-21_(1.26wmf15): Ctrl+B/I/U should always be prevented - https://phabricator.wikimedia.org/T106059#1468073 (10Jdforrester-WMF) [18:29:49] 10Citoid, 10VisualEditor, 6Services, 5Patch-For-Review: Citoid is blacklisted from ncbi.nlm.nih.gov - https://phabricator.wikimedia.org/T106044#1468074 (10Jdforrester-WMF) [18:30:10] mooeypoo : okay [18:31:08] look at ve.ui.AnnotationInspector.js #getTeardownProcess [18:31:27] yes, looking [18:32:00] So unlike a lot of other things, annotations (link and language) are inserted and changed without having to click "apply" -- so, your inspector is open, you make whatever changes, and when you close the inspector (either by clicking close or by clicking anywhere else in the document) the action is applied [18:32:05] that's why it's in getTeardownProcess [18:32:15] you can see in there that it checks what the action is -- replace, remove, etc [18:33:05] It also checks whether we are working with a brand new annotation (in which case we have to insert "dummy" text -- in the case of link it's the raw link, and in the case of language it's the language name) [18:33:09] ankita-ks, you see it? [18:37:34] mooeypoo, yes, I can see that. [18:37:50] So what are the essential parts of defining a new annotation? [18:38:11] For instance I can see the function getComparableObject being called a lot of times. [18:38:15] What is that used for? [18:39:06] That's in ve.dm.LanguageAnnotation [18:39:20] it's used to define what is considered an annotation [18:39:45] and is used to compare if the annotation is the same [18:39:47] or was changed [18:40:44] So you can see that AnnotationSet for example asks to compare 2 annotations [18:40:49] and the way it does that is be "getComparableObject" [18:41:00] that way, only the pieces that matter to check whether the annotations are the same are being compared [18:42:27] ankita-ks, what are you trying to do? Might be easier to go at it if I know the direction you want to go in [18:43:13] 10Citoid, 6Services: DOI redirect handler for iopscience is very slow/ potentially causes citoid to behave oddly. - https://phabricator.wikimedia.org/T106374#1468234 (10mobrovac) I can, but rarely. It seems `request` is having trouble retrieving http://iopscience.iop.org/0004-637X/802/1/65/ and sometimes the r... [18:43:32] Okay, so I am working on a language proofing tool. I need to highlight the errors in such a way that when the user clicks on it, there is a description of what the error is. [18:44:02] I can locate the error. I think the next step would be to define a new annotation for it and a corresponding inspector. [18:44:10] Is that correct? [18:44:25] (03CR) 10Jforrester: "Could we have a WIP patch for mw-config switching over to this method?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/223967 (https://phabricator.wikimedia.org/T104898) (owner: 10Alex Monk) [18:45:07] 10VisualEditor, 10VisualEditor-MediaWiki, 5Patch-For-Review: Replace wgVisualEditorNamespaces with a 2D array of namespace => enabled state - https://phabricator.wikimedia.org/T104898#1468236 (10Jdforrester-WMF) p:5Triage>3Normal [18:47:59] 10VisualEditor, 10VisualEditor-Initialisation, 10VisualEditor-Performance, 7Browser-Support-Firefox, 7Performance: Improve VisualEditor's loading performance in Firefox - https://phabricator.wikimedia.org/T52616#1468245 (10Jdforrester-WMF) [18:48:30] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Testme: VisualEditor: CAPTCHA that appears when saving is hard to find - https://phabricator.wikimedia.org/T72266#1468252 (10Jdforrester-WMF) [18:48:32] 10VisualEditor, 10VisualEditor-MediaWiki: Intermittent VisualEditor load failures - https://phabricator.wikimedia.org/T99026#1468254 (10Neil_P._Quinn_WMF) I just got a big rash of these in 41.0a2, on both enwiki and eswiki. [18:51:25] ankita-ks, that sounds like one way of doing that. edsanders might have more input on this, though. [18:51:46] mooeypoo, what else would you suggest? [18:51:47] It sounds like annotations might be a good direction for that [18:52:02] i'm trying to think. You want an inspector to open when the user clicks on either of the selections? [18:52:33] yes, something like this : http://tools.wmflabs.org/languageproofing-ui/ [18:52:41] or close enough [18:54:16] ankita-ks, nothing pops up for me in that page [18:55:03] Interesting. It does for me :/ Anyway, this then : https://www.languagetool.org/ [18:55:11] There is a textbook here [18:56:20] *text-box [18:57:43] okay I see it [18:58:02] Yeah it sounds like some sort of faux-annotation is needed [18:58:35] you need to make sure those annotations aren't passing later to parsoid so those words are not encompassed by some tag or something [18:59:59] If they are annotations, you will have to define ve.dm object for them. I think that's the right way to go here, but since that starts being a little more involved, I'd like to get edsanders' input on it before you start creating faux annotations and dm elements [19:00:12] He might be on his way back from Wikimania, though [19:00:28] James_F: FYI, https://phabricator.wikimedia.org/T106079#1468269 [19:00:49] RoanKattouw: Fun. [19:01:44] mooeypoo, ankita-ks: Ed's flight should have landed about 4 hours ago, so he's probably just barely home [19:02:29] I will look for him tomorrow sometime then. [19:02:53] ankita-ks, I would just verify with him that this is the right way to go [19:03:05] Alright, I will do that. [19:03:35] Could you in the mean time just give me an overview of ve.dm.*Annotations work? [19:03:37] because if it is, then you'll probably have to define ve.dm. spellCheckAnnotations (or something like that) and then ve.ce one (for the styling of the selected words) and an inspector that inherits from ve.ui.AnnotationInspector [19:03:58] okay [19:04:02] it doesn't sound too horrific to me, I thin kthat is probably a good way to go, but you will need to make sure those annotations don't "stick" [19:04:08] like, they're not sent to parsoid afterwards [19:04:19] okay, how do I ensure that? [19:04:45] and why? [19:04:54] whatever you wrap thme with needs to go away. I'm not sure with annotations. We did this for comment nodes, but comment nodes are already defined in what we're getting -- and here you want to define a new type of node [19:04:56] 10Citoid, 6Services: DOI redirect handler for iopscience is very slow/ potentially causes citoid to behave oddly. - https://phabricator.wikimedia.org/T106374#1468280 (10mobrovac) a:3mobrovac Aha! Found the culprit - we are not setting the UA in `unshorten()` which apparently creates problems for `iop.org`. W... [19:05:18] well you don't want some to appear around the words that popped up in your spellcheck [19:05:21] hmm..any example to look at? [19:05:53] RoanKattouw, am I over complicating things? I am not sure if a dm object requires special care when we *do* want it to go out to parsoid or when we don't. If that makes sense. [19:05:57] You know more about this than I do [19:06:01] Wait are you guys talking about magically disappearing s? [19:06:06] * RoanKattouw hasn't read backscroll yet [19:06:13] RoanKattouw, ankita is working on spellCheck stuff [19:06:20] But ve.dm.NowikiAnnotation has magically disappearing spans :) [19:06:21] she wants to mark the words that are found [19:06:23] oh [19:06:25] OK [19:06:25] awesome [19:06:34] That... probably isn't suitable for an annotation though [19:06:54] You should talk to Ed about what exactly to use, but I don't think an annotation is the way to go [19:06:57] Well, it seemed to be a sort of faux annotation [19:06:58] but yes [19:07:00] OK [19:07:00] exactly [19:07:15] I suggested Ed be involved too. [19:07:29] Yeah you need some sort of thing that behaves like an annotation in the rendering (CE) but not in the model (DM) [19:07:40] I think it actually makes sense as some faux-annotation, but that actually migth make it more complicated [19:07:40] yeah [19:07:51] [11:58] mooeypoo you need to make sure those annotations aren't passing later to parsoid so those words are not encompassed by some tag or something [19:07:54] Because of exactly that ---^^ [19:08:01] yeah exactly [19:08:17] 10VisualEditor, 10VisualEditor-MediaWiki-Links: Link editor can't be closed - https://phabricator.wikimedia.org/T106270#1468285 (10Jdforrester-WMF) p:5Triage>3High [19:08:20] So the search and replace code has highlighting functionality which might be useful here [19:08:35] 10Citoid, 10VisualEditor, 5Patch-For-Review: Doi regex is not detecting http://dx.doi.org/10.14344/IOC.ML.4.4 - https://phabricator.wikimedia.org/T106235#1468288 (10Jdforrester-WMF) p:5Triage>3Normal [19:08:36] But AIUI that's more like divs that are absolutely positioned on top of text, not spans wrapping text [19:08:47] yes, so I used something similar to highlight things [19:08:53] *errors to be specific [19:08:55] 10Citoid, 10VisualEditor: Urlencoded slash in doi unable to generate citation - https://phabricator.wikimedia.org/T106234#1468290 (10Jdforrester-WMF) p:5Triage>3Normal [19:09:09] but I also need a popup with a description of what the error is [19:09:45] 10VisualEditor, 7Technical-Debt: ve.ui.Sequence#execute should silently ignore missing commands - https://phabricator.wikimedia.org/T106060#1468297 (10Jdforrester-WMF) p:5Triage>3High [19:11:01] 10Citoid, 10VisualEditor: STICKY: Report failing DOIs or URLs here. - https://phabricator.wikimedia.org/T106201#1468304 (10Jdforrester-WMF) 5Open>3declined a:3Jdforrester-WMF We don't use sticky tasks in Phabricator; use a project instead, please. [19:12:33] 10Citoid, 10VisualEditor: STICKY: Report failing DOIs or URLs here. - https://phabricator.wikimedia.org/T106201#1468310 (10Josve05a) Ping @Mvolz. [19:13:19] 10VisualEditor, 6Collaboration-Team, 10Flow: Ctrl-Home doesn't allow further typing in VisualEditor in Flow posts - https://phabricator.wikimedia.org/T103494#1468311 (10Amire80) >>! In T103494#1419453, @Catrope wrote: > I can't reproduce this when editing https://he.wikipedia.org/w/index.php?title=%D7%A0%D7%... [19:14:41] 10VisualEditor, 10MediaWiki-extensions-UniversalLanguageSelector, 7I18n: Add a way to correct Romanian diacritics in VE before the page is saved - https://phabricator.wikimedia.org/T106049#1468312 (10Jdforrester-WMF) [19:14:51] 10VisualEditor, 6Collaboration-Team, 10Flow: Ctrl-Home doesn't allow further typing in VisualEditor in Flow posts - https://phabricator.wikimedia.org/T103494#1468313 (10Catrope) >>! In T103494#1468311, @Amire80 wrote: > It's reproducible. > > In any wiki, start a new post, type "* hello", let it auto-conver... [19:15:01] 10VisualEditor: Ctrl-Home doesn't allow further typing in VisualEditor in Flow posts - https://phabricator.wikimedia.org/T103494#1468314 (10Catrope) [19:15:08] 10VisualEditor, 10Parsoid: creates incorrect wikitext by removing last newline between template and heading - https://phabricator.wikimedia.org/T105745#1468315 (10Jdforrester-WMF) p:5Triage>3Normal [19:15:15] 10VisualEditor: Ctrl-Home from bullet list doesn't allow further typing in VisualEditor - https://phabricator.wikimedia.org/T103494#1468316 (10Catrope) [19:15:23] ankita-ks, RoanKattouw yeah the "popup menu" sort of thing is why the annotation inspector came up [19:15:41] she probably needs an inspector there on each of those word selections. It can of course not just be an annotation, but yeah [19:16:47] mooeypoo, RoanKattouw : could you explain to me what is the problem with a normal annotation? [19:16:52] 10VisualEditor: Page jumps while using link tool - https://phabricator.wikimedia.org/T105418#1468319 (10Jdforrester-WMF) a:5Esanders>3None [19:17:08] ankita-ks, annotations *actually* annotate the text, so they add something around it [19:17:33] link adds (or the wikitext equivalent) and language adds [19:17:36] From what I understand, the errors will be annotated and then when someone edits the highlighted text, the annotations can be removed based on whether it is correct or not. [19:17:46] Yeah mostly that ---^^ [19:17:47] they do that so that when you *save* the page those annotations stick -- they are *also* saved [19:17:50] yes, so what's wrong with that? [19:17:53] You could write the annotation so that it doesn't do that [19:18:10] But you would have other problems, like how and where to insert the annotations [19:18:14] Well you don't want the page to be saved with "Blah blah something" just because "something" is caught by spellCheck [19:18:31] You'd have to generate them at conversion time and also monitor the page for new typos and commit transactions to add new annotations [19:18:34] Which would be a mess [19:18:57] she'd have that problem even without annotations though [19:19:03] Conceptually, annotating something as a spelling mistake doesn't belong in the model, it'll probably cause a bunch of subtle problems [19:19:20] the "spellcheck" button would examine the text and find the missing words -- and those she'd have to wrap with something... annotation or something else? [19:19:22] mooeypoo: The monitoring, yes, but you wouldn't have to *commit a transaction* to mark something as a typo [19:19:31] indeed [19:19:34] yes, right, good point [19:19:38] Because that transaction will go on the undo stack [19:19:49] but inspectors load onto dm nodes [19:19:51] Ctrl+Z past the point where you pressed the spellcheck button and now all your annotations are gone [19:20:00] like, they recognize whether they need to pop up according to the dm node they're no [19:20:01] on [19:20:16] Yes, with annotations you'd get that kind of stuff for free [19:20:22] But that's not the only way to do inspectors [19:20:40] right, there are other inspectors, but they still depend on dm nodes..... I .... think.....? [19:20:55] Right now all inspectors do, I think, yes [19:21:01] Well, yes and no [19:21:07] They're FragmentInspectors, so they need a fragment [19:21:14] Which you would have, a range of text is a fragment [19:21:41] But there wouldn't be a node (but that's OK, the link and language inspectors have that) and there wouldn't be the automatic detection thing using DM stuff [19:21:48] So you'd have to have different logic for deciding when to show it [19:21:57] All in all it sounds like you guys need Ed to invent a few things [19:22:36] RoanKattouw, while edsanders shows up, could you suggest an example of fragment inspector that I could look at? [19:22:51] You probably shouldn't go with fragments, though, ankita-ks [19:23:04] fragment inspectors rather [19:23:28] Maybe, maybe not [19:23:39] why and why not? [19:23:42] But yeah it's probably too early to dive into those right now [19:24:08] Right now all the fragment inspectors are about editing DM nodes or annotations [19:24:21] You can write a fragment inspector that just corrects a typo, but no one's really done that kind of thing yet [19:25:00] Since it's starting to get a bit more infrastructur'y, I'd suggest the best course of action is probably waiting up for Ed to pitch in [19:25:33] Yes [19:25:37] we've mentioned his name a bunch, I imagine his IRC log will go all red when he rejoins ;) [19:25:43] heh yeah [19:26:43] RoanKattouw, mooeypoo : alright. waiting for edsanders :) [19:27:37] Sorry :S we can spitball and can generally help you with most things, but when it comes to inventing new infrastructure, you need Ed [19:27:41] 10VisualEditor: Help the HTML Editing Task Force shape "Editing on the Web" (aka future of contentEditable) - https://phabricator.wikimedia.org/T91781#1468385 (10Jdforrester-WMF) p:5Normal>3Lowest a:5Esanders>3None [19:29:04] RoanKattouw, mooeypoo : Not a problem at all. Glad you could take time out to explain things [19:30:01] np :) [19:31:12] 10Cite, 6Collaboration-Team, 10Flow, 6Language-Engineering, and 7 others: Use CSS to style Parsoid's Cite extension output - https://phabricator.wikimedia.org/T86782#1468406 (10He7d3r) That works. Thanks @Arlolra! [19:40:36] 10VisualEditor, 10VisualEditor-MediaWiki-Links: Link editor can't be closed - https://phabricator.wikimedia.org/T106270#1468460 (10Catrope) [19:40:51] James_F: https://phabricator.wikimedia.org/T103494 [19:43:23] 10VisualEditor, 10VisualEditor-ContentEditable: Ctrl-Home from bullet list doesn't allow further typing without clicking out of the slug - https://phabricator.wikimedia.org/T103494#1468467 (10Jdforrester-WMF) p:5High>3Normal [19:43:39] 10VisualEditor: Re-add cancel button to desktop VE toolbar - https://phabricator.wikimedia.org/T106295#1468471 (10Jdforrester-WMF) [19:44:52] (03PS1) 10Catrope: Make ve.SelectionState#flip return an actual SelectionState [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/226158 (https://phabricator.wikimedia.org/T106270) [19:46:34] (03CR) 10Jforrester: [C: 032] Make ve.SelectionState#flip return an actual SelectionState [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/226158 (https://phabricator.wikimedia.org/T106270) (owner: 10Catrope) [19:46:53] (03PS1) 10Jforrester: Make ve.SelectionState#flip return an actual SelectionState [VisualEditor/VisualEditor] (wmf/1.26wmf15) - 10https://gerrit.wikimedia.org/r/226178 (https://phabricator.wikimedia.org/T106270) [19:47:36] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 5WMF-deploy-2015-07-21_(1.26wmf15), 5WMF-deploy-2015-07-28_(1.26wmf16): Link editor can't be closed - https://phabricator.wikimedia.org/T106270#1468514 (10Jdforrester-WMF) 5Open>3Resolved a:3Catrope [19:47:49] (03PS1) 10Jforrester: Make ve.SelectionState#flip return an actual SelectionState [VisualEditor/VisualEditor] (wmf/1.26wmf14) - 10https://gerrit.wikimedia.org/r/226189 (https://phabricator.wikimedia.org/T106270) [19:48:14] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 5Patch-For-Review, 5WMF-deploy-2015-07-21_(1.26wmf15), 5WMF-deploy-2015-07-28_(1.26wmf16): Link editor can't be closed - https://phabricator.wikimedia.org/T106270#1468525 (10Jdforrester-WMF) [19:54:04] (03CR) 10jenkins-bot: [V: 04-1] Make ve.SelectionState#flip return an actual SelectionState [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/226158 (https://phabricator.wikimedia.org/T106270) (owner: 10Catrope) [19:54:37] (03PS2) 10Catrope: Make ve.SelectionState#flip return an actual SelectionState [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/226158 (https://phabricator.wikimedia.org/T106270) [19:54:42] Krinkle: Are you screwing around with CI stuff? [19:54:55] I am not [19:55:01] Hmm. Something else, then. [19:56:17] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-extensions-Translate: Edit tab on translatable pages flashes "Translate" before changing "Edit wikitext". - https://phabricator.wikimedia.org/T94386#1468578 (10Nikerabbit) p:5Triage>3Normal [19:58:30] (03CR) 10Jforrester: [C: 032] Make ve.SelectionState#flip return an actual SelectionState [VisualEditor/VisualEditor] (wmf/1.26wmf14) - 10https://gerrit.wikimedia.org/r/226189 (https://phabricator.wikimedia.org/T106270) (owner: 10Jforrester) [19:58:37] (03CR) 10Jforrester: [C: 032] Make ve.SelectionState#flip return an actual SelectionState [VisualEditor/VisualEditor] (wmf/1.26wmf15) - 10https://gerrit.wikimedia.org/r/226178 (https://phabricator.wikimedia.org/T106270) (owner: 10Jforrester) [19:58:46] (03CR) 10Jforrester: [C: 032] Make ve.SelectionState#flip return an actual SelectionState [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/226158 (https://phabricator.wikimedia.org/T106270) (owner: 10Catrope) [20:08:53] (03Merged) 10jenkins-bot: Make ve.SelectionState#flip return an actual SelectionState [VisualEditor/VisualEditor] (wmf/1.26wmf14) - 10https://gerrit.wikimedia.org/r/226189 (https://phabricator.wikimedia.org/T106270) (owner: 10Jforrester) [20:08:55] (03Merged) 10jenkins-bot: Make ve.SelectionState#flip return an actual SelectionState [VisualEditor/VisualEditor] (wmf/1.26wmf15) - 10https://gerrit.wikimedia.org/r/226178 (https://phabricator.wikimedia.org/T106270) (owner: 10Jforrester) [20:08:57] (03Merged) 10jenkins-bot: Make ve.SelectionState#flip return an actual SelectionState [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/226158 (https://phabricator.wikimedia.org/T106270) (owner: 10Catrope) [20:09:54] 10VisualEditor: Re-add cancel button to desktop VE toolbar - https://phabricator.wikimedia.org/T106295#1468644 (10Jdforrester-WMF) p:5Triage>3Lowest A proposal we might look at is having "Cancel" be an option in a menu coming out of the save button, though even that feels like it's likely to take up more roo... [20:10:19] 10VisualEditor, 10VisualEditor-MediaWiki: Re-add cancel button to desktop VE-MW toolbar - https://phabricator.wikimedia.org/T106295#1468650 (10Jdforrester-WMF) [20:11:21] 10VisualEditor: Enlarge the "review your changes" window - https://phabricator.wikimedia.org/T106187#1468656 (10Jdforrester-WMF) Currently this window is `larger`, as large as we let any window get; the next size up is `full`, as in full-screen-mode. Would covering up the logo and all other traces of where you a... [20:11:35] 10VisualEditor, 10VisualEditor-MediaWiki: Enlarge the "review your changes" window - https://phabricator.wikimedia.org/T106187#1468657 (10Jdforrester-WMF) 5Open>3stalled p:5Triage>3Low [20:12:23] (03PS1) 10Jforrester: Update VE core submodule to master (aeaad4e) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/226214 [20:15:16] (03PS1) 10Jforrester: Update VE core submodule to wmf/1.26wmf14 HEAD (50893b0) [extensions/VisualEditor] (wmf/1.26wmf14) - 10https://gerrit.wikimedia.org/r/226217 (https://phabricator.wikimedia.org/T106270) [20:16:36] (03PS1) 10Jforrester: Update VE core submodule to wmf/1.26wmf15 HEAD (2cbe96b) [extensions/VisualEditor] (wmf/1.26wmf15) - 10https://gerrit.wikimedia.org/r/226218 (https://phabricator.wikimedia.org/T106270) [20:17:00] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (aeaad4e) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/226214 (owner: 10Jforrester) [20:17:14] (03CR) 10Catrope: [C: 032] Update VE core submodule to wmf/1.26wmf14 HEAD (50893b0) [extensions/VisualEditor] (wmf/1.26wmf14) - 10https://gerrit.wikimedia.org/r/226217 (https://phabricator.wikimedia.org/T106270) (owner: 10Jforrester) [20:17:18] (03CR) 10Catrope: [C: 032] Update VE core submodule to wmf/1.26wmf15 HEAD (2cbe96b) [extensions/VisualEditor] (wmf/1.26wmf15) - 10https://gerrit.wikimedia.org/r/226218 (https://phabricator.wikimedia.org/T106270) (owner: 10Jforrester) [20:29:32] 10VisualEditor, 10MediaWiki-extensions-UniversalLanguageSelector, 7I18n: Add a way to correct Romanian diacritics in VE before the page is saved - https://phabricator.wikimedia.org/T106049#1468734 (10Jdforrester-WMF) I recommend that you look at whether ULS's "jquery IME" tool can help here. [20:29:38] 10VisualEditor, 10MediaWiki-extensions-UniversalLanguageSelector, 7I18n: Add a way to correct Romanian diacritics in VE before the page is saved - https://phabricator.wikimedia.org/T106049#1468735 (10Jdforrester-WMF) p:5Triage>3Normal [20:30:50] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 10VisualEditor-MediaWiki-Media: Pressing escape twice to cancel out of the link inspector, closes the entire media dialog - https://phabricator.wikimedia.org/T103433#1468737 (10Jdforrester-WMF) p:5Triage>3Low [20:31:14] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 10VisualEditor-MediaWiki-Media: Pressing escape twice to cancel out of the link inspector, closes the entire media dialog - https://phabricator.wikimedia.org/T103433#1389992 (10Jdforrester-WMF) > In contrast, clicking [Esc] twice within the link inspector (once... [20:35:47] (03CR) 10Hashar: [C: 032] Update VE core submodule to wmf/1.26wmf14 HEAD (50893b0) [extensions/VisualEditor] (wmf/1.26wmf14) - 10https://gerrit.wikimedia.org/r/226217 (https://phabricator.wikimedia.org/T106270) (owner: 10Jforrester) [20:35:51] (03CR) 10Hashar: [C: 032] Update VE core submodule to wmf/1.26wmf15 HEAD (2cbe96b) [extensions/VisualEditor] (wmf/1.26wmf15) - 10https://gerrit.wikimedia.org/r/226218 (https://phabricator.wikimedia.org/T106270) (owner: 10Jforrester) [20:36:20] ah [20:36:33] James_F: RoanKattouw: sorry I screwed up a zuul sneaky deploy [20:36:51] I have +2 ed again a couple VE bumps for the wmf branches [20:37:00] https://gerrit.wikimedia.org/r/#/c/226217/ and https://gerrit.wikimedia.org/r/#/c/226218/ [20:37:13] I will write 100 times "do not touch CI during deploy windows" [20:37:47] It's OK, we didn't have a deploy window [20:37:55] Although I guess the train did [20:38:07] hashar: No worries, those aren't deploy +2s. [20:38:17] hashar: Because VE doesn't get auto-updated, we can do old-style. [20:43:40] 10VisualEditor, 10VisualEditor-ContentLanguage: VisualEditor: IME shift+ function for adding diacritical marks in Arabic broken - https://phabricator.wikimedia.org/T52105#565797 (10Jdforrester-WMF) [20:43:45] 10VisualEditor, 10VisualEditor-ContentLanguage: VisualEditor: Text in Japanese disappears - https://phabricator.wikimedia.org/T74619#1468772 (10Jdforrester-WMF) [20:43:52] 10VisualEditor, 10VisualEditor-ContentLanguage: Japanese text disappears (kanji and maybe hiragana, not katakana) when you are writing list entries - https://phabricator.wikimedia.org/T78118#1468773 (10Jdforrester-WMF) [20:43:57] 10VisualEditor, 10VisualEditor-ContentLanguage: VisualEditor: a line started with Japanese input disappear when I switch to and start non-Japanese (latin) input - https://phabricator.wikimedia.org/T74508#1468774 (10Jdforrester-WMF) [20:44:29] Hey, I'm running the REL 1_25 branch of VE and the summary box is losing focus whenever I save something. Is there an open bug report on that? (I haven't been able to find one yet, but figured I'd ask here first). [20:45:26] 10TemplateData, 10VisualEditor: VE: does not show a property "example" for templates - https://phabricator.wikimedia.org/T97417#1468780 (10Jdforrester-WMF) [20:46:00] 10TemplateData, 10VisualEditor: VE: does not show a property "example" for templates - https://phabricator.wikimedia.org/T97417#1241642 (10Jdforrester-WMF) [20:51:09] (03CR) 10GOIII: [C: 031] Fix spaces [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/225846 (owner: 10Gerrit Patch Uploader) [20:55:54] 10VisualEditor: VE focus issues in REL 1_25 - https://phabricator.wikimedia.org/T106419#1468849 (10Rosencrantz) 3NEW [21:12:17] (03CR) 10TheDJ: [C: 032] Fix spaces [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/225846 (owner: 10Gerrit Patch Uploader) [21:42:32] (03CR) 10TheDJ: [C: 032] WikiEditor shouldn't store wrong cookies for booklets [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/225014 (https://phabricator.wikimedia.org/T27184) (owner: 10Gerrit Patch Uploader) [21:48:55] (03CR) 10TheDJ: [V: 032] Fix spaces [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/225846 (owner: 10Gerrit Patch Uploader) [22:04:13] (03CR) 10Jforrester: [C: 032] "…" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/226214 (owner: 10Jforrester) [22:05:28] 10WikiEditor: Media selector doesn't find local media in private wiki - https://phabricator.wikimedia.org/T65282#1469061 (10Tgr) I could not reproduce the error on officewiki (a private wiki which is about a week behind master). Both your examples return a `readapidenied` error (which is a bug on its own right,... [22:08:36] (03CR) 10Jforrester: [C: 032] Update VE core submodule to wmf/1.26wmf14 HEAD (50893b0) [extensions/VisualEditor] (wmf/1.26wmf14) - 10https://gerrit.wikimedia.org/r/226217 (https://phabricator.wikimedia.org/T106270) (owner: 10Jforrester) [22:08:43] (03CR) 10Jforrester: [C: 032] "…" [extensions/VisualEditor] (wmf/1.26wmf15) - 10https://gerrit.wikimedia.org/r/226218 (https://phabricator.wikimedia.org/T106270) (owner: 10Jforrester) [22:13:15] i have a wiki farm with ve installed. On one wiki it works fine, no error messages, but on another wiki in the farm, the VE is not evident and there's this is in the parsoid log: [warning/api/expandtemplates][ofc_demo/Main_Page?oldid=1376] Template Expansion Unrecognized values for parameter 'prop': modules, jsconfigvars [22:14:03] i'm on 25.1.. I'm able to see html for "curl -L http://aws03.belltower.wiki:8142/ofc_demo/Main_Page"... but the access.log has ""GET /Main_Page?veaction=edit HTTP/1.1" 304" [22:14:45] no VE output I guess due to the 304. [22:23:05] (03CR) 10TheDJ: "Just wanted to say, rly nice work !" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/224971 (owner: 10Mooeypoo) [22:24:04] maybe it's a permissions problem [22:38:57] 10VisualEditor: Extract text contents of https://phabricator.wikimedia.org/project/sprint/profile/1297/ and put somewhere users can see - https://phabricator.wikimedia.org/T106401#1469166 (10JAufrecht) Added links from the home page and the triage page to the tranche definitions. [22:39:06] 10VisualEditor: Extract text contents of https://phabricator.wikimedia.org/project/sprint/profile/1297/ and put somewhere users can see - https://phabricator.wikimedia.org/T106401#1469170 (10JAufrecht) 5Open>3Resolved [22:39:46] it's a bootstrapmini skin getting in the way. [22:45:10] 10VisualEditor: Extract text contents of https://phabricator.wikimedia.org/project/sprint/profile/1297/ and put somewhere users can see - https://phabricator.wikimedia.org/T106401#1469199 (10Jdforrester-WMF) [22:53:28] 10TemplateData, 10VisualEditor: TemplateData: Add property to indicate a template must be substituted - https://phabricator.wikimedia.org/T67550#1469227 (10Jdforrester-WMF) [22:55:24] 10TemplateData, 10VisualEditor: Template Documentation Editor: Language label and Template description input field text should be aligned - https://phabricator.wikimedia.org/T90252#1469234 (10Jdforrester-WMF) [22:55:52] (03CR) 10Legoktm: [C: 032] "re+2 for jenkins" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/226214 (owner: 10Jforrester) [22:55:56] (03CR) 10Legoktm: [C: 032] "re+2 for jenkins" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/225846 (owner: 10Gerrit Patch Uploader) [22:55:59] (03CR) 10Legoktm: [C: 032] "re+2 for jenkins" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/225014 (https://phabricator.wikimedia.org/T27184) (owner: 10Gerrit Patch Uploader) [23:01:57] (03Merged) 10jenkins-bot: Update VE core submodule to master (aeaad4e) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/226214 (owner: 10Jforrester) [23:01:59] (03Merged) 10jenkins-bot: Fix spaces [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/225846 (owner: 10Gerrit Patch Uploader) [23:02:02] (03Merged) 10jenkins-bot: WikiEditor shouldn't store wrong cookies for booklets [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/225014 (https://phabricator.wikimedia.org/T27184) (owner: 10Gerrit Patch Uploader) [23:02:25] (03CR) 10Jforrester: [C: 032] "…" [extensions/VisualEditor] (wmf/1.26wmf14) - 10https://gerrit.wikimedia.org/r/226217 (https://phabricator.wikimedia.org/T106270) (owner: 10Jforrester) [23:02:35] (03CR) 10Jforrester: [C: 032] "…" [extensions/VisualEditor] (wmf/1.26wmf15) - 10https://gerrit.wikimedia.org/r/226218 (https://phabricator.wikimedia.org/T106270) (owner: 10Jforrester) [23:02:54] (03CR) 10Catrope: [C: 032] Update VE core submodule to wmf/1.26wmf14 HEAD (50893b0) [extensions/VisualEditor] (wmf/1.26wmf14) - 10https://gerrit.wikimedia.org/r/226217 (https://phabricator.wikimedia.org/T106270) (owner: 10Jforrester) [23:05:21] (03Merged) 10jenkins-bot: Update VE core submodule to wmf/1.26wmf14 HEAD (50893b0) [extensions/VisualEditor] (wmf/1.26wmf14) - 10https://gerrit.wikimedia.org/r/226217 (https://phabricator.wikimedia.org/T106270) (owner: 10Jforrester) [23:05:23] (03Merged) 10jenkins-bot: Update VE core submodule to wmf/1.26wmf15 HEAD (2cbe96b) [extensions/VisualEditor] (wmf/1.26wmf15) - 10https://gerrit.wikimedia.org/r/226218 (https://phabricator.wikimedia.org/T106270) (owner: 10Jforrester) [23:09:16] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 5WMF-deploy-2015-07-21_(1.26wmf15), 5WMF-deploy-2015-07-28_(1.26wmf16): Link editor can't be closed - https://phabricator.wikimedia.org/T106270#1469305 (10Jdforrester-WMF) [23:36:47] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 5WMF-deploy-2015-07-14_(1.26wmf14), 5WMF-deploy-2015-07-21_(1.26wmf15), 5WMF-deploy-2015-07-28_(1.26wmf16): Link editor can't be closed - https://phabricator.wikimedia.org/T106270#1469398 (10Jdforrester-WMF) Should now be fixed everywhere. [23:37:20] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 5WMF-deploy-2015-07-14_(1.26wmf14), 5WMF-deploy-2015-07-21_(1.26wmf15), 5WMF-deploy-2015-07-28_(1.26wmf16): Link editor can't be closed - https://phabricator.wikimedia.org/T106270#1469402 (10Jdforrester-WMF)