[00:26:56] 10VisualEditor, 7Epic: Negotiate Service Levels between VE and Stakeholders and identify underlying contradictory needs - https://phabricator.wikimedia.org/T102571#1469521 (10Jdforrester-WMF) [00:27:02] 10VisualEditor: Measure and document results of changes to VE team processes - https://phabricator.wikimedia.org/T103197#1469522 (10Jdforrester-WMF) [00:27:11] 10VisualEditor: Align all VE tasks with higher-level Goals and Epics - https://phabricator.wikimedia.org/T102267#1469523 (10Jdforrester-WMF) [00:27:19] 10VisualEditor, 7Epic: Move goals, OKRs, and Milestones into Phabricator - https://phabricator.wikimedia.org/T102203#1469524 (10Jdforrester-WMF) [00:27:31] 10VisualEditor: Make Cycle Time Chart for VE Backlog - https://phabricator.wikimedia.org/T106356#1469525 (10Jdforrester-WMF) [01:01:18] 10VisualEditor, 10VisualEditor-MediaWiki: Assist de/it/pl/pt/ru-wiki communities in updating their edit-notice systems to stop hidden content showing as "1 notice" - https://phabricator.wikimedia.org/T95822#1469574 (10Krinkle) a:5Krinkle>3None [01:01:52] Krinkle: That task is assigned to you because you didn't document how to fix it, so you're the only person on Earth who can. [01:01:59] I'm writing a comment [01:02:04] Krinkle: Point me to some documentation or I'll just re-assign it to you. :-) [01:02:08] Also, not true, I did document it [01:02:12] Where? [01:02:17] Patience :) [01:02:19] I spent an hour searching. [01:02:29] 10VisualEditor, 10MediaWiki-extensions-UniversalLanguageSelector, 5Patch-For-Review: Move jQuery.i18n module to core - https://phabricator.wikimedia.org/T95666#1469577 (10Jdforrester-WMF) [01:02:31] OK. I'll be sure to include it [01:02:36] Thanks. [01:04:19] 10VisualEditor, 7JavaScript: "TypeError: str is undefined" when attempting to save and edit with VisualEditor - https://phabricator.wikimedia.org/T105386#1469578 (10Jdforrester-WMF) [01:04:36] 10VisualEditor, 10VisualEditor-MediaWiki: Save dialog hang (related to 404 in error console?) - https://phabricator.wikimedia.org/T105610#1469579 (10Jdforrester-WMF) [01:05:16] 10VisualEditor, 10Parsoid: Parsoid creates incorrect wikitext by letting a user remove the newline between template and the start of a heading - https://phabricator.wikimedia.org/T105745#1469582 (10Jdforrester-WMF) [01:06:58] 10VisualEditor, 10VisualEditor-MediaWiki, 5Patch-For-Review: Replace wgVisualEditorNamespaces with a 2D array of namespace => enabled state - https://phabricator.wikimedia.org/T104898#1469589 (10Jdforrester-WMF) [01:07:07] 10VisualEditor, 10Wikimedia-Site-requests: Enable VisualEditor on outreach.wikimedia.org - https://phabricator.wikimedia.org/T106298#1469590 (10Jdforrester-WMF) [01:07:25] 10Citoid, 10VisualEditor: Urlencoded slash in doi unable to generate citation - https://phabricator.wikimedia.org/T106234#1469593 (10Jdforrester-WMF) [01:07:32] 10Citoid, 10VisualEditor, 5Patch-For-Review: Doi regex is not detecting http://dx.doi.org/10.14344/IOC.ML.4.4 - https://phabricator.wikimedia.org/T106235#1469594 (10Jdforrester-WMF) [01:08:17] 10Citoid, 10VisualEditor, 6Services, 5Patch-For-Review: Citoid is blacklisted from ncbi.nlm.nih.gov - https://phabricator.wikimedia.org/T106044#1469595 (10Jdforrester-WMF) [01:08:27] 10VisualEditor, 7Technical-Debt: ve.ui.Sequence#execute should silently ignore missing commands - https://phabricator.wikimedia.org/T106060#1469596 (10Jdforrester-WMF) [01:08:48] 10VisualEditor: Page jumps while using link tool - https://phabricator.wikimedia.org/T105418#1469597 (10Jdforrester-WMF) [01:47:57] 10VisualEditor, 10VisualEditor-MediaWiki: Assist de/it/pl/pt/ru-wiki communities in updating their edit-notice systems to stop hidden content showing as "1 notice" - https://phabricator.wikimedia.org/T95822#1469642 (10Krinkle) >>! In T95822#1399689, @matmarex wrote: > I'm increasingly convinced that we should... [04:02:13] 10VisualEditor: VE incorrectly keeps settings even if the page settings dialog box is closed via cancel instead of apply - https://phabricator.wikimedia.org/T106467#1469792 (10MarkAHershberger) 3NEW [04:15:27] 10VisualEditor, 7Easy: venotify=created isn't removed when veaction=edit is selected - https://phabricator.wikimedia.org/T106468#1469799 (10MarkAHershberger) 3NEW [07:32:15] 10WikiEditor, 5Patch-For-Review, 5WMF-deploy-2015-07-21_(1.26wmf15): Minor improvements of help in toolbar - https://phabricator.wikimedia.org/T26128#1469926 (10Schnark) 5Open>3Resolved a:3Schnark [07:33:12] 10WikiEditor, 5Patch-For-Review, 5WMF-deploy-2015-07-28_(1.26wmf16): Toolbar API: Unnecessary cookies are stored when inserting a booklet - https://phabricator.wikimedia.org/T27184#1469928 (10Schnark) 5Open>3Resolved a:3Schnark [07:55:52] matt_flaschen: morning [07:56:09] is there a way in VE to add a desc to an external link ? [08:17:19] ryasmeen: do you now the answer ? [12:16:42] 10VisualEditor, 10VisualEditor-MediaWiki: Re-add cancel button to desktop VE-MW toolbar - https://phabricator.wikimedia.org/T106295#1470512 (10matmarex) I like this idea from @Whatamidoing-WMF's T85470: > However, what about an escape clause under the Help menu, or next to the "Switch to source" item in the P... [12:35:38] 10Cite, 10Math, 10MediaWiki-extensions-MathSearch: Hook Cite::checkRefsNoReferences has invalid call signature; - https://phabricator.wikimedia.org/T105598#1470557 (10matmarex) The problem is actually with the Math extension, which calls the ParserAfterParse hook for some reason (I refuse to investigate what... [14:01:51] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-extensions-FlaggedRevs: Flagged Revisions doesn't mark as reviewed the latest version after Visual Editor edit - https://phabricator.wikimedia.org/T75171#1470731 (10Stryn) [14:02:53] 10Cite, 10Math, 10MediaWiki-extensions-MathSearch, 5Patch-For-Review: Hook Cite::checkRefsNoReferences has invalid call signature; - https://phabricator.wikimedia.org/T105598#1470737 (10Physikerwelt) @matmarex Thank you very much for looking into this. This workaround is really one of the ugliest things at... [14:09:51] 10Cite, 10Math, 10MediaWiki-extensions-MathSearch, 5Patch-For-Review: Hook Cite::checkRefsNoReferences has invalid call signature; - https://phabricator.wikimedia.org/T105598#1470745 (10Physikerwelt) The patch is definetly a step forward. But the problem is not solved. ``` Exception encountered, of type "... [14:21:34] 10VisualEditor, 10Wikimedia-Site-requests: Enable VisualEditor on outreach.wikimedia.org - https://phabricator.wikimedia.org/T106298#1470770 (10Elitre) TL;DR, VE can already be used at outreach wiki (activate it from your Beta Features, like on Meta). 40+ users have already activated it. I'd say you may want... [14:54:13] James_F: hi, is there a way in VE to add a desc to an external link ? [14:57:32] matanya: You mean Foo? [14:58:27] James_F: no, a simple [https://foo something] which shows "somthing" as the text for an external link [14:58:44] matanya: Yes, of course. [14:58:54] matanya: Oh, have you created an auto-numbered link? [14:59:09] no, just one extenal link [14:59:18] reduses to show my text [14:59:28] (probably i am doing something wrong) [14:59:34] *refuses [14:59:41] matanya: Edit it, click "add label". [14:59:42] Oh. [14:59:43] Hmm. [14:59:58] there is no such thing, looked for labes [15:00:04] *label [15:00:07] You should be able to just type in the anchor you want in the link. [15:00:13] https://he.wikipedia.org/wiki/%D7%9E%D7%A9%D7%AA%D7%9E%D7%A9:Matanya/%D7%98%D7%99%D7%95%D7%98%D7%94?veaction=edit [15:00:14] Is that not working? [15:00:21] correct [15:00:44] That page is two templates plus an auto-numbered link. [15:00:47] [1]. [15:00:50] right [15:01:08] try to add http://archaeology.huji.ac.il/Hamam/Default.aspx as an external link with some desc [15:01:09] If you click on the [1], click edit, and click add label, you then get an editable link. [15:01:42] Done. [15:01:46] two things: 1. when i do so, nothing happens when i click on "label" [15:01:59] 2. i can't do that while creating the external link [15:03:16] James_F: would a screencast help ? [15:03:21] Yes [15:08:13] https://commons.wikimedia.org/wiki/File:VE_external_link.webm [15:08:58] James_F: ^ [15:09:45] matanya: … that seems to work to me? [15:09:53] matanya: The wikitext turned from [link] to [link link]. [15:09:59] yes, i noticed [15:10:05] And then you just didn't change the display text from 'link' to what you wanted. [15:10:12] i tried [15:10:18] It didn't work? [15:10:28] but there was no option for input text [15:11:08] you saw the mouse hovering over the text ? i tried exaclty that [15:11:34] No? [15:12:54] still not working [15:14:14] I can confirm what matanya says... if you click on "label" there's no place where you could write a label. [15:14:36] What are you expecting? [15:14:40] James_F: are you using chrome ? [15:15:13] matanya: And Firefox. [15:16:05] clearly something on my part, but i can't figure it [15:16:09] matanya: https://www.dropbox.com/s/pbtefxaxkqwr0ur/Video%20for%20Matanya.mov?dl=0 [15:16:14] matanya: (Sorry for the size.) [15:16:15] so might be a UX issue :) [15:20:13] thanks James_F yes, a UX problem [15:20:42] i was expecting a box for edititing the labal, not raw link text [15:20:53] and appreantly i am not the only one [15:21:15] matanya: Oooooooh. [15:21:37] matanya: Yeah, that. No. We can't possible give you a sane interface for that, without massively limiting what MediaWiki lets you put in a link's anchor. [15:22:02] so you would need to clarify that in some way [15:22:16] matanya: Other editors just lock you down (e.g. Pages won't even let you do foobar). [15:22:28] yeah, makes sense [15:22:39] now that i figured, that is obvious :) [15:22:39] Which, umm, I don't think the community would be too happy about. :-) [15:23:47] so, since I was asked by our community why there is no way to edit the text of an external link, and struggeled myself, i think we should find a way to clarify this [15:24:02] It's in the user guide. [15:24:07] Not that that's necessarily helpful. [15:24:14] i know, i actully read it [15:24:21] And most users when we studied wrote the label and then applied the link to it. [15:24:32] Which works the same for internal and external links. [15:24:46] but still couldn't do it, and i don't consider myself dumb :D [15:24:55] Indeed. [15:25:19] putting this a side for amoment, why do we need two steps for it ? [15:25:26] Two steps for what? [15:25:34] adding a label [15:25:49] Because it's the most common action. [15:26:08] didn't quite get it [15:26:21] i would like to add the label upon creation [15:26:30] not add the link, and then add a label [15:27:00] i.e. : box for link, box for label in the same creation box [15:27:08] i can mock it if you wish [15:27:39] That sounds really ugly. :-( [15:27:59] prehaps [15:28:18] you think the current way is the correct way ? [15:32:28] matanya: I think it's the least-bad. [15:33:18] fair enough, i would argure, but it is not that critical [15:36:56] * James_F nods. [15:38:34] thank you James_F [15:38:41] Always. [15:56:52] 10VisualEditor, 10MediaWiki-extensions-FlaggedRevs: FlaggedRevisions icon "Non sighted" shown after saving even that editor has autoreview right - https://phabricator.wikimedia.org/T78691#1470969 (10Jdforrester-WMF) Is this the same as {T75171}? [15:57:27] 10VisualEditor, 7Easy: venotify=created isn't removed when veaction=edit is selected - https://phabricator.wikimedia.org/T106468#1470972 (10Jdforrester-WMF) I think we fixed that a few months ago? [15:59:57] 10VisualEditor, 10VisualEditor-MediaWiki, 7Easy: venotify=created isn't removed when veaction=edit is selected - https://phabricator.wikimedia.org/T106468#1470984 (10Jdforrester-WMF) [16:00:20] 10VisualEditor, 10VisualEditor-MediaWiki, 7Easy: venotify=created isn't removed when veaction=edit is selected - https://phabricator.wikimedia.org/T106468#1470989 (10Jdforrester-WMF) p:5Triage>3Low [16:01:55] 10VisualEditor: VE incorrectly keeps settings even if the page settings dialog box is closed via cancel instead of apply - https://phabricator.wikimedia.org/T106467#1470996 (10Jdforrester-WMF) [16:01:57] 10VisualEditor, 10VisualEditor-MediaWiki: Options: 'Cancel' button does not cancel entered values and applies 'Show the Table of Contents' immediately(?) - https://phabricator.wikimedia.org/T97682#1470997 (10Jdforrester-WMF) [16:04:32] 10VisualEditor, 10MediaWiki-extensions-FlaggedRevs: FlaggedRevisions icon "Non sighted" shown after saving even that editor has autoreview right - https://phabricator.wikimedia.org/T78691#1471007 (10Chewbacca2205) I don't think so. The bug described in T75171 sounds new to me. But this bug here seems to be sol... [16:05:08] 10VisualEditor, 10MediaWiki-extensions-FlaggedRevs: FlaggedRevisions icon "Non sighted" shown after saving even that editor has autoreview right - https://phabricator.wikimedia.org/T78691#1471008 (10Jdforrester-WMF) 5Open>3Resolved a:3Jdforrester-WMF Ah, hmm. OK, will provisionally mark this as closed, t... [16:05:25] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-extensions-FlaggedRevs: Flagged Revisions doesn't mark as reviewed the latest version after Visual Editor edit - https://phabricator.wikimedia.org/T75171#1471012 (10Jdforrester-WMF) Is this still an issue? [16:24:17] 10Cite, 10Math, 10MediaWiki-extensions-MathSearch, 5Patch-For-Review: Hook Cite::checkRefsNoReferences has invalid call signature; - https://phabricator.wikimedia.org/T105598#1471137 (10Jdforrester-WMF) 5Open>3Resolved a:3Jdforrester-WMF [16:29:57] 10VisualEditor: VE focus issues in REL 1_25: Unable to use the Summary and Search box - https://phabricator.wikimedia.org/T106419#1471198 (10Aklapper) [16:35:22] 10VisualEditor, 10VisualEditor-MediaWiki, 7Easy: venotify=created isn't removed when veaction=edit is selected - https://phabricator.wikimedia.org/T106468#1471237 (10MarkAHershberger) Jdforrester-WMF writes: > I think we fixed that a few months ago? a) Just visited https://en.wikipedia.org/wiki/User:MarkAH... [16:44:28] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-extensions-FlaggedRevs: Flagged Revisions doesn't mark as reviewed the latest version after Visual Editor edit - https://phabricator.wikimedia.org/T75171#1471295 (10Stryn) >>! In T75171#1471012, @Jdforrester-WMF wrote: > Is this still an issue? It is. Ju... [17:26:51] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-CopyPaste, 7Browser-Support-Apple-Safari: VisualEditor: Copying text causes browser to scroll to the top of the page and move the cursor to the top in Safari - https://phabricator.wikimedia.org/T73728#1471604 (10Whatamidoing-WMF) Update: As of... [17:27:10] 10VisualEditor, 10OOjs-UI: Gray for active elements in the VE toolbar is too light - https://phabricator.wikimedia.org/T98988#1471608 (10Prtksxna) >>! In T98988#1286120, @matmarex wrote: > Interesting that the text of all dropdown menus is pure black #000, not #555 like the toolbar. I'm not sure if that's inte... [17:29:08] 10Cite, 10Math, 10MediaWiki-extensions-MathSearch, 5Patch-For-Review, 5WMF-deploy-2015-07-28_(1.26wmf16): Hook Cite::checkRefsNoReferences has invalid call signature; - https://phabricator.wikimedia.org/T105598#1471612 (10Jdforrester-WMF) a:5Jdforrester-WMF>3Physikerwelt [17:35:33] (03PS8) 10Divec: WIP: Cursoring: find adjacent position in DOM order [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/217222 [17:35:54] (03PS13) 10Divec: WIP: Explicitly enter/exit link annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/217257 [17:36:22] (03PS10) 10Divec: ve.ce.adjustLinkSelection: fixup link-bisecting selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/222488 [17:37:10] (03PS9) 10Divec: WIP: Fixup links [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/222619 [17:39:06] Krenair: You about? Looks like we're going to want https://gerrit.wikimedia.org/r/#/c/225051/ and https://gerrit.wikimedia.org/r/#/c/225052/ merged and back-ported to be used before the train next week. Could you review? [17:42:38] 10VisualEditor: VisualEditor: Removing or breaking HTML tags ( and tags vanish) - https://phabricator.wikimedia.org/T62585#1471696 (10Jdforrester-WMF) 5stalled>3Resolved a:3Jdforrester-WMF I think this has been long-since fixed. [17:46:17] 10VisualEditor, 10VisualEditor-MediaWiki, 7Browser-Support-Firefox: When the user opens VisualEditor from a section link, then scroll to that section upon opening in Firefox - https://phabricator.wikimedia.org/T106557#1471713 (10Whatamidoing-WMF) 3NEW [18:01:36] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Reading-Web: Mobile VE - Save page title wrapping weirdly - https://phabricator.wikimedia.org/T92016#1471780 (10Florian) a:3Florian [18:01:59] 10VisualEditor, 10OOjs-UI: Gray for active elements in the VE toolbar is too light - https://phabricator.wikimedia.org/T98988#1471781 (10Prtksxna) [18:07:24] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 7Design, 3Reading-Web: Mobile VE - Dropdown menus need larger tap areas - https://phabricator.wikimedia.org/T92010#1471803 (10Florian) Actual Design: {F207336} [18:08:16] edsanders : Hi, I need help with something. Could you spare a few minutes? [18:08:55] I am working on an extension for VisualEditor. It highlights all the errors (spelling and grammar) [18:09:04] James_F, sort of about, not feeling great at the moment [18:09:19] When the user clicks on the highlighted error, they should be see an explanation about what it is. [18:09:26] *should se [18:09:28] *see [18:09:46] Something like this maybe : https://www.languagetool.org/ [18:10:05] Krenair: :-( [18:10:19] I was thinking that I could create a new annotation and attach that to the errors. [18:10:37] And create an annotation inspector to view what the error is. [18:10:45] What do you think about this approach? [18:11:12] I had a long discussion about this with mooeypoo and RoanKattouw yesterday. [18:15:08] James_F, I'm not sure what the purpose of the isLoggedIn check here is? [18:16:18] surely all users that get passed to AuthPluginAutoCreate are logged in? [18:19:20] oh, maybe not [18:21:11] nope, it should definitely get a user ID set before this code can possibly be triggered [18:22:14] LoginForm::authenticateUserData will call attemptAutoCreate before deciding to call this hook, and that does initUser which calls User::addToDatabase [18:22:17] addToDatabase sets up the UID [18:22:39] (03CR) 10Alex Monk: Hooks: Support auto-enabling for auto-created accounts (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/225051 (owner: 10Jforrester) [18:23:30] (03CR) 10Jforrester: Hooks: Support auto-enabling for auto-created accounts (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/225051 (owner: 10Jforrester) [18:23:38] (03CR) 10Alex Monk: Hooks: Support auto-enabling for a proportion of new accounts (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/225052 (owner: 10Jforrester) [18:25:25] auto-enabling for new accounts="One small patch for man, one giant leap for wikipedia" :) [18:25:45] eranroz: Some new accounts. :-) But yes. [18:30:20] Is there a way to get a list of all nodes of a particular type in a document? [18:33:52] Krenair: It's been in there since 2013, so… probably Roan wrote it out of an abundance of caution? Let's just leave it in though. [18:34:10] ankita-ks: Don't think edsanders is around, sorry. [18:34:22] hi [18:34:24] ferdbold: Not off the top of my head. Why? [18:34:41] edsanders, hi [18:34:42] (03CR) 10Alex Monk: [C: 032] Hooks: Support auto-enabling for auto-created accounts [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/225051 (owner: 10Jforrester) [18:34:57] Krenair: Thanks. :-) [18:35:40] Do you think there is a way around annotations getting saved with text? (in reference to the question I asked earlier) [18:35:58] (03CR) 10Alex Monk: [C: 032] Hooks: Support auto-enabling for a proportion of new accounts [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/225052 (owner: 10Jforrester) [18:36:08] Krenair: This code is (ideally) not long for this world… [18:36:51] Krenair: Did you see my comment on https://gerrit.wikimedia.org/r/#/c/223967/ BTW? It looks OK to me, but a WIP config patch showing how to use it would be good. [18:37:05] James_F, yes. [18:37:25] it's somewhere in my queue of like 40 things to action in some way [18:37:30] :-) [18:37:40] "Somewhere" close to the top? ;-) [18:39:12] ankita-ks, I would use mostly the find and replace code for highlighting [18:39:56] edsanders, that is what I did. But when the user clicks on the highlighted error, they should be able to see an explanation. [18:40:03] How do i implement that? [18:40:10] you can listen to model selection events [18:40:43] you can iterate over all your fragments and see which ones are in range [18:41:03] that should be pretty fast unless you have millions of fragments (so no need to do a binary search) [18:43:13] (03Merged) 10jenkins-bot: Hooks: Support auto-enabling for auto-created accounts [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/225051 (owner: 10Jforrester) [18:43:39] (03Merged) 10jenkins-bot: Hooks: Support auto-enabling for a proportion of new accounts [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/225052 (owner: 10Jforrester) [18:44:08] James_F, haha [18:44:24] you could then build the explanation into your toolbar dialog, so you don't conflict with the context (e.g. links) [18:44:49] James_F, it actually works more like a stack, usually [18:45:46] James_F: sorry, was afk. Basically I want to run a static function once that has to poll every instance of a node to compare values [18:46:29] edsanders, I do not understand what are model selection events? [18:46:55] shouldn't I attach some kind of onclick even listener? [18:47:00] *Event [18:47:03] James_F: since that function runs off a hook I'd prefer to only hook it once, hence the static. I _could_ run the logic on every node but I feel it'd overcomplicate things [18:48:03] and what kind of dialog are we talking about exactly? Is it some kind of generic dialog that is displayed? or would it be possible to anchor it at the highlighted error that was clicked? [18:52:16] 10VisualEditor, 10VisualEditor-MediaWiki-Templates: Extra blocks being displayed in VisualEditor - https://phabricator.wikimedia.org/T106573#1471992 (10Whatamidoing-WMF) 3NEW [18:55:36] 10WikiEditor, 7Technical-Debt: WikiEditor leaves style="position: static;" behind on the - https://phabricator.wikimedia.org/T106574#1472008 (10Krinkle) 3NEW [18:55:49] 10WikiEditor, 7Technical-Debt: WikiEditor leaves style="position: static;" behind on the - https://phabricator.wikimedia.org/T106574#1472017 (10Krinkle) [18:56:03] ankita-ks, ToolbarDialog just controls the position at the moment [18:56:42] you will probably want to copy a lot of features from FindAndReplaceDialog [18:56:59] what kind of features? [18:57:34] I copied how the highlighting of phrases are handled. [18:57:42] yeah that's mostly it [18:57:55] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-References, 10VisualEditor-MediaWiki-Templates, 10Parsoid: Ref generating templates show reflists when edited - https://phabricator.wikimedia.org/T101553#1472032 (10Whatamidoing-WMF) Also galleries: {T106573} [18:58:23] we can look at base classing common code later but for now just copy it over [18:58:49] WRT to events, click events are just one of many that can change the selection [18:58:59] as well as programmatic things, like undo/redo [18:59:24] the model emits 'select' events whenever the selection changes [19:01:22] you can then see if your selection is contained without one of your result fragments, and display the info for that result in to the toolbar [19:07:04] what do you mean by selection being contained without result fragment? [19:07:08] (03PS1) 10TheDJ: Toolbar: Remove Opera redraw hack [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/226333 (https://phabricator.wikimedia.org/T106574) [19:07:40] Krinkle_: kill it, with fire :) [19:08:59] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 5Patch-For-Review, 3Reading-Web, 5WMF-deploy-2015-07-28_(1.26wmf16): Mobile VE - Save page title wrapping weirdly - https://phabricator.wikimedia.org/T92016#1472072 (10Florian) 5Open>3Resolved [19:14:48] ankita-ks, within [19:15:16] thedj: I think there may be one other position=static in that case [19:15:18] Can you check? [19:15:19] so if you get back from your results there are errors at [20,30] and [56,70], whenever the selection changes [19:15:23] (03CR) 10Krinkle: [C: 032] Toolbar: Remove Opera redraw hack [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/226333 (https://phabricator.wikimedia.org/T106574) (owner: 10TheDJ) [19:15:34] By selection you mean the highlighted error clicked on? [19:16:14] e.g. to [27,27] you can see that that is within [20,30] [19:16:19] (03Merged) 10jenkins-bot: Toolbar: Remove Opera redraw hack [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/226333 (https://phabricator.wikimedia.org/T106574) (owner: 10TheDJ) [19:16:50] using ve.Range#containsRange [19:17:44] which means this will work with moving the cursor to the error, not only clicking [19:18:22] Krinkle: checking [19:19:47] (03PS1) 10Jforrester: Hooks: Support auto-enabling for a proportion of new accounts [extensions/VisualEditor] (wmf/1.26wmf15) - 10https://gerrit.wikimedia.org/r/226339 [19:19:58] (03PS1) 10Jforrester: Hooks: Support auto-enabling for auto-created accounts [extensions/VisualEditor] (wmf/1.26wmf15) - 10https://gerrit.wikimedia.org/r/226340 [19:21:41] so when the cursor is on an error, it should display what the error is, eranroz ? [19:22:06] Krinkle: $( this ).addClass( 'section-hidden' ).css( 'position', 'static' ); [19:22:23] but i don't think that should be a problem for anyone... [19:22:59] ankita-ks: yes [19:23:05] 10VisualEditor: Placeholder is incorrectly formatted if document is just an empty heading (as opposed to a paragraph) - https://phabricator.wikimedia.org/T106582#1472151 (10Esanders) 3NEW [19:23:10] okay [19:23:25] But I still do not understand how the details should be displayed? [19:23:26] and where? [19:23:28] 10VisualEditor, 10VisualEditor-EditingTools: Placeholder is incorrectly formatted if document is just an empty heading (as opposed to a paragraph) - https://phabricator.wikimedia.org/T106582#1472159 (10Jdforrester-WMF) [19:23:45] ankita-ks, so once you have worked out which fragment the cursor is in [19:23:50] okay [19:24:02] I assume you can have the error details associated with that still in memory [19:25:05] maybe you have objects like, error = { details: 'Bad grammar', fragment: fragmentObject } [19:25:06] yes, I can store them somewhere [19:25:11] right [19:25:12] yes [19:25:33] so you can leave some space in the toolbarDialog to show the details [19:25:46] instead of inline like links [19:26:16] the only mechanism for showing stuff inline is the inspector, but that is designed around things being in the model, which this isn't [19:26:31] hmm, okay [19:27:25] and whenever the cursor is over an error, the toolbar dialog should display what the error is [19:27:32] That makes sense. [19:27:36] yup [19:37:49] Is there a way to get all nodes of a particular type in a document? [19:39:42] Not directly right now [19:39:47] ferdbold: What do you need this for? [19:40:31] RoanKattouw: I need to run a function once on page save which needs to poll every node of a given type to compare values [19:41:02] Why? [19:41:11] (This is about graph nodes, right?) [19:41:18] RoanKattouw: (Always haha) [19:41:34] JamesF: I wrote some patch (haven't pushed yet to gerrit) for adding tracking category for cite errors, and I noticed now tehre is already patch by Amire80 for it in https://gerrit.wikimedia.org/r/#/c/222897/ [19:41:44] Oh right [19:41:50] Didn't that break mysteriously last time we tried? [19:41:52] RoanKattouw: Basically I need to compare the graph IDs stored in every node with the ones stored in mw.config [19:41:55] (03PS1) 10Jforrester: Update OOjs UI to v0.12.1 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/226346 [19:42:06] do you know what was the issue that cause the revert of the previous patch (of alex)? [19:42:10] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.12.1 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/226346 (owner: 10Jforrester) [19:42:21] or is there a unittest for it? [19:42:29] RoanKattouw: No that's another issue [19:42:30] I don't remember [19:42:33] eranroz: Epic parser failures. [19:42:40] eranroz: No unit test. No reproduction steps. [19:42:43] ferdbold: What kind of decision do you need to make based on this comparison? [19:42:47] eranroz: Very very very unhappy times. [19:44:22] eranroz: But "sometimes" s would be replaced with UNIT-123456-TINU or something. [19:44:49] RoanKattouw: Every graph has an ID which is a hash based off its definition, so two identical graphs will have the exact same ID. These IDs are currently stored on mw.config, as well as data attributes on the corresponding DOM elements, and the graph extension will only try to render graphs that match the IDs it has in mw.config [19:45:16] RoanKattouw: So when I edit a graph, its ID actually changes, which means I have to compare on page save which IDs changed and update them in mw.config [19:45:44] (03CR) 10jenkins-bot: [V: 04-1] Update OOjs UI to v0.12.1 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/226346 (owner: 10Jforrester) [19:46:23] RoanKattouw: I kinda need to make this a static function called only once on page save, since multiple graphs can have the same ID would make a member method override graph IDs that are maybe still used by other graphs [19:47:11] You could potentially do this from toDomElements instead [19:47:15] Or at least collect data from there [19:47:32] You can't directly find all graph nodes, but if you've just saved then toDomElements will have run recently and visited all nodes [19:48:15] (03PS2) 10Jforrester: Update OOjs UI to v0.12.1 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/226346 [19:48:17] It's possible for toDomElements to run multiple times (open save dialog, view diff, oh wait I need to make another change, then save for real --> two toDomElement runs), that may or may not be a problem [19:50:12] James_F: thanks. I thought maybe we should delay addTrackingCategory to the end, but looking at the code of addTrackingCategory it doesn't seem to output anything but just changes the mCategories of page (except debug message in case of invalid tacking category name) [19:50:44] eranroz: Parser funkiness is beyond me, sadly. :-( [19:51:51] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.12.1 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/226346 (owner: 10Jforrester) [19:51:53] 10Cite: Cite: Provide a way for users to find articles which have the reference list inserted automatically - https://phabricator.wikimedia.org/T69700#1472316 (10Jdforrester-WMF) >>! In T69700#1296362, @matmarex wrote: > This is likely to be possible now without everything exploding thanks to 944b24542827f827cdf... [19:51:56] James, who is the parser master? god/brion? [19:52:42] eranroz: TimStarling (who is not in this channel but is in #mediawiki-parsoid) [19:52:50] eranroz: There isn't one, really; Tim Starling is the expert, but… [19:52:51] He's also in Australia so he's probably not awake yet [19:54:00] OK, so i will update the commit with explanation and add Tim to the reviewers. thanks [19:54:09] 10Cite: Cite: Provide a way for users to find articles which have the reference list inserted automatically - https://phabricator.wikimedia.org/T69700#1472342 (10Jdforrester-WMF) >>! In T69700#1427327, @Amire80 wrote: > Related: T104792. > > A fix for this bug was reverted in https://gerrit.wikimedia.org/r/#/c/... [19:54:41] RoanKattouw: But when toDomElements run, doesn't it run once for each node? I need to be able to access all graphIDs at once [19:55:20] eranroz: Thanks. [19:56:44] ferdbold: Yes exactly, it runs for each node. So my idea was, in toDomElements you collect information, push it into some sort of global/central place [19:56:56] Then once toDomElements is done, you have all the information in that place and you can process it further [19:58:06] How would I know toDomElements is over? [19:58:26] OK so you're saying you need to do this "on save" [19:58:36] Yeah exactly :P [19:58:37] Why is that? Is it because the page view is going to be rerendered? [19:58:39] (03Merged) 10jenkins-bot: Update OOjs UI to v0.12.1 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/226346 (owner: 10Jforrester) [19:59:46] Yeah once it's rerendered, the IDs on the DOM graph nodes are updated, but not the ones on mw.config, so there's a mismatch and any graph you've just edited will not render until you hard refresh the page again [20:24:50] 10VisualEditor, 10Parsoid: Please remove unnecessary empty span tags before colons - https://phabricator.wikimedia.org/T106561#1472511 (10cscott) [20:30:21] 10VisualEditor, 10Parsoid: Please remove unnecessary empty span tags before colons - https://phabricator.wikimedia.org/T106561#1472546 (10Arlolra) Copy / paste? [21:09:49] 10VisualEditor, 10Parsoid, 5Patch-For-Review: nowiki link-like strings that aren't in s - https://phabricator.wikimedia.org/T103364#1472711 (10cscott) This is now deployed. Test case: https://en.wikipedia.org/w/index.php?title=User%3ACscott%2Fsandbox&type=revision&diff=672635006&oldid=672634917 But see al... [21:43:03] 10VisualEditor: Focus on the target page name input box automatically after checking "Redirect this page to" - https://phabricator.wikimedia.org/T106616#1472922 (10Amire80) 3NEW [21:43:25] 10VisualEditor, 10Collaboration-Team-Sprint-F-2015-08-04: Run LQT conversion script on mediawiki VE/Feedback - https://phabricator.wikimedia.org/T106613#1472929 (10Jdforrester-WMF) [21:44:27] 10VisualEditor, 10Collaboration-Team-Sprint-F-2015-08-04: Run LQT conversion script on mediawiki VE/Feedback - https://phabricator.wikimedia.org/T106613#1472938 (10DannyH) [21:47:20] 10VisualEditor, 10Collaboration-Team-Sprint-F-2015-08-04: Run LQT conversion script on mediawiki VE/Feedback - https://phabricator.wikimedia.org/T106613#1472955 (10DannyH) [21:55:10] James_F, do we have to have points on the workboard, it takes up loads of vertical space and gives them undue prominence [21:55:34] edsanders: Use the non-points view. [21:55:50] edsanders: https://phabricator.wikimedia.org/project/board/483/ [21:56:06] where is that listed? [21:56:30] edsanders: Go to https://phabricator.wikimedia.org/project/profile/483/ and click the "two columns" icon in the top left. [21:56:58] https://phabricator.wikimedia.org/project/profile/483/ is the 'home page' of the project. [21:58:25] edsanders: OK? [21:58:35] ok [22:00:23] Kk. [22:00:50] (03CR) 10Esanders: "ping" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/223759 (owner: 10Esanders) [22:01:08] edsanders: Everything look OK in production? [22:01:28] ? [22:01:48] edsanders: Well, before I merge 223759 do you think the world will end? ;-) [22:02:25] I tested it locally [22:02:29] OK. [22:02:32] (03CR) 10Jforrester: [C: 032] Revert "For empty / whitespace-only headings, output

instead of " [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/223759 (owner: 10Esanders) [22:02:34] can't tell on live because this code runs first [22:02:37] Yeah. [22:03:04] edsanders: No tests for https://gerrit.wikimedia.org/r/#/c/223767/ ? [22:03:14] edsanders: And can I bully you into merging https://gerrit.wikimedia.org/r/#/c/224197/ please/ [22:03:40] edsanders: And fixing https://gerrit.wikimedia.org/r/#/c/205291/ given its failing unit test and not-mergy-ness. [22:04:02] (03PS1) 10Jforrester: Update VE core submodule to master (d6effdd) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/226430 [22:05:36] (03Merged) 10jenkins-bot: Revert "For empty / whitespace-only headings, output

instead of " [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/223759 (owner: 10Esanders) [22:06:44] Oh, I can rebase. [22:08:59] 10VisualEditor: VisualEditor: adding a reference duplicates infobox on da.wp - https://phabricator.wikimedia.org/T61600#1473090 (10Neil_P._Quinn_WMF) I tried reproducing this and got nothing. Feel free to reopen if I've missed something. [22:09:07] 10VisualEditor: VisualEditor: adding a reference duplicates infobox on da.wp - https://phabricator.wikimedia.org/T61600#1473092 (10Neil_P._Quinn_WMF) 5Open>3Resolved [22:09:12] (03PS4) 10Jforrester: Add removable flag to meta items [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205291 (https://phabricator.wikimedia.org/T96528) (owner: 10Esanders) [22:09:21] (03CR) 10Jforrester: "PS4 is a rebase." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205291 (https://phabricator.wikimedia.org/T96528) (owner: 10Esanders) [22:12:51] (03CR) 10jenkins-bot: [V: 04-1] Add removable flag to meta items [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205291 (https://phabricator.wikimedia.org/T96528) (owner: 10Esanders) [22:13:23] (03PS1) 10Jforrester: build: Drop last jscs over-ride and make pass [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/226434 [22:13:56] James_F: Someone's asking me what the "TR1: Releases" column means wrt priority. Context of https://phabricator.wikimedia.org/T71799 [22:14:09] (community member) [22:14:23] It means it's been prioritised for the next main release, right? [22:14:23] Krinkle: Something more important than TR2 but less important than TR0. [22:14:35] Krinkle: It's in the list of things for us to work on soon, yes. [22:14:41] Okay [22:14:46] 10VisualEditor, 7Browser-Support-Google-Chrome: VisualEditor: Cutting (removing) last sections on page, and then pasting them back in, results in increased indentation in Chrome - https://phabricator.wikimedia.org/T61849#1473117 (10Neil_P._Quinn_WMF) 5stalled>3Resolved [22:14:50] 10VisualEditor, 7Browser-Support-Google-Chrome: VisualEditor: Cutting (removing) last sections on page, and then pasting them back in, results in increased indentation in Chrome - https://phabricator.wikimedia.org/T61849#627997 (10Neil_P._Quinn_WMF) I've tested this out and it seems to work correctly now. Fee... [22:15:10] Krinkle: That column is "things that are worth getting fixed as part of releasing VE to big wikis", which is a bit meh. [22:15:49] (03CR) 10Esanders: [C: 032] Comment*: Use the same icon for the CE and UI renderings [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/224197 (https://phabricator.wikimedia.org/T94479) (owner: 10Jforrester) [22:16:00] edsanders: Thanks. You rock. [22:16:25] Krinkle: TR0 is "Interrupt" as in "we didn't plan to work on this, but it's urgent so tough". [22:16:55] Right [22:17:56] (03CR) 10Jforrester: [C: 04-1] Replace wgVisualEditorNamespaces with an associative array (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/223967 (https://phabricator.wikimedia.org/T104898) (owner: 10Alex Monk) [22:18:02] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-Tables: When a partial table is pasted into VE, separate cell contents with spaces - https://phabricator.wikimedia.org/T101478#1473143 (10Neil_P._Quinn_WMF) [22:19:20] (03Merged) 10jenkins-bot: Comment*: Use the same icon for the CE and UI renderings [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/224197 (https://phabricator.wikimedia.org/T94479) (owner: 10Jforrester) [22:19:52] 10VisualEditor, 10VisualEditor-EditingTools, 5WMF-deploy-2015-07-28_(1.26wmf16): Make the comment icon in the toolbar menu match the exclamation mark one used in the surface - https://phabricator.wikimedia.org/T94479#1473149 (10Jdforrester-WMF) 5Open>3Resolved a:3Jdforrester-PERSONAL [22:20:21] (03CR) 10Jforrester: [C: 031] "Unit testable?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/223767 (owner: 10Esanders) [22:35:17] (03PS4) 10Alex Monk: Replace wgVisualEditorNamespaces with an associative array [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/223967 (https://phabricator.wikimedia.org/T104898) [22:35:28] (03CR) 10jenkins-bot: [V: 04-1] Replace wgVisualEditorNamespaces with an associative array [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/223967 (https://phabricator.wikimedia.org/T104898) (owner: 10Alex Monk) [22:37:45] (03PS5) 10Alex Monk: Replace wgVisualEditorNamespaces with an associative array [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/223967 (https://phabricator.wikimedia.org/T104898) [23:03:20] (03CR) 10Jforrester: [C: 031] Replace wgVisualEditorNamespaces with an associative array [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/223967 (https://phabricator.wikimedia.org/T104898) (owner: 10Alex Monk) [23:03:51] (03CR) 10Alex Monk: [C: 032] Hooks: Support auto-enabling for a proportion of new accounts [extensions/VisualEditor] (wmf/1.26wmf15) - 10https://gerrit.wikimedia.org/r/226339 (owner: 10Jforrester) [23:04:39] (03CR) 10Alex Monk: [C: 032] Hooks: Support auto-enabling for auto-created accounts [extensions/VisualEditor] (wmf/1.26wmf15) - 10https://gerrit.wikimedia.org/r/226340 (owner: 10Jforrester) [23:07:08] (03Merged) 10jenkins-bot: Hooks: Support auto-enabling for a proportion of new accounts [extensions/VisualEditor] (wmf/1.26wmf15) - 10https://gerrit.wikimedia.org/r/226339 (owner: 10Jforrester) [23:07:54] (03Merged) 10jenkins-bot: Hooks: Support auto-enabling for auto-created accounts [extensions/VisualEditor] (wmf/1.26wmf15) - 10https://gerrit.wikimedia.org/r/226340 (owner: 10Jforrester) [23:17:51] 10VisualEditor, 6Collaboration-Team, 10Collaboration-Team-Sprint-F-2015-08-04, 10Flow: Run LQT conversion script on mediawiki VE/Feedback - https://phabricator.wikimedia.org/T106613#1473287 (10DannyH) [23:20:42] 10VisualEditor: Make the 'review your changes' dialog clearer when the page has been edited since the visual editor was opened - https://phabricator.wikimedia.org/T76898#1473306 (10Neil_P._Quinn_WMF) [23:22:59] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-References: VisualEditor: Make each reference editable where it appears in the reference list as well as on the edit surface - https://phabricator.wikimedia.org/T54750#1473324 (10Neil_P._Quinn_WMF) p:5Normal>3Low [23:23:17] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-References: VisualEditor: Make each reference editable where it appears in the reference list as well as on the edit surface - https://phabricator.wikimedia.org/T54750#583733 (10Neil_P._Quinn_WMF) [23:45:48] 10VisualEditor, 10OOjs-UI, 5OOjs-UI-0.12.0: PopupWidget close button off in Firefox - https://phabricator.wikimedia.org/T105164#1473493 (10Jdforrester-WMF) [23:45:50] 10VisualEditor, 10OOjs-UI, 5OOjs-UI-0.12.0, 5Patch-For-Review: Pressing enter in the language search widget does nothing - https://phabricator.wikimedia.org/T105684#1473492 (10Jdforrester-WMF) [23:46:04] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 10OOjs-UI, 5OOjs-UI-0.12.0: TextInputWidget icon/indicator use the "pointer" (hand) mouse cursor, but don't do anything button-like - https://phabricator.wikimedia.org/T98213#1473497 (10Jdforrester-WMF) [23:46:12] 10VisualEditor, 10OOjs-UI, 5OOjs-UI-0.12.0: Pressing enter in the language search widget does nothing - https://phabricator.wikimedia.org/T105684#1473501 (10Jdforrester-WMF) [23:49:36] 10VisualEditor, 10VisualEditor-DataModel, 5Patch-For-Review: Empty annotations cannot be deleted - https://phabricator.wikimedia.org/T96528#1473533 (10Jdforrester-WMF) p:5Normal>3Low De-prioritising, now that Parsoid trims empty annotations (at least some of the time). [23:51:49] 10TemplateData, 10VisualEditor: VE: does not show a property "example" for templates - https://phabricator.wikimedia.org/T97417#1473561 (10Jdforrester-WMF) p:5Triage>3Normal [23:52:09] 10VisualEditor: VisualEditor: Removing or breaking HTML tags ( and tags vanish) - https://phabricator.wikimedia.org/T62585#1473565 (10Jdforrester-WMF) p:5Triage>3Normal [23:52:16] 10VisualEditor: VisualEditor: adding a reference duplicates infobox on da.wp - https://phabricator.wikimedia.org/T61600#1473566 (10Jdforrester-WMF) p:5Triage>3Normal [23:52:29] 10VisualEditor, 10VisualEditor-ContentEditable: Cut and Paste of references occasionally fails - https://phabricator.wikimedia.org/T60552#1473571 (10Jdforrester-WMF) p:5Triage>3Normal [23:52:37] 10VisualEditor, 10Parsoid: https://en.wikipedia.org/wiki/User:Amire80/single_break_nowiki cannot be edited in VE in Chrome - https://phabricator.wikimedia.org/T104557#1473576 (10Jdforrester-WMF) p:5Triage>3Normal