[00:03:02] 10VisualEditor, 10VisualEditor-MediaWiki, 10Wikimedia-Site-requests, 5Patch-For-Review: Kill $wmgUseVisualEditorNamespace - https://phabricator.wikimedia.org/T92797#1473619 (10Jdforrester-WMF) 5Open>3Resolved Thanks, all. [00:03:58] 10VisualEditor, 10VisualEditor-MediaWiki, 10Wikimedia-Site-requests, 5WMF-deploy-2015-07-21_(1.26wmf15): Kill $wmgUseVisualEditorNamespace - https://phabricator.wikimedia.org/T92797#1473624 (10Jdforrester-WMF) [00:34:43] 10VisualEditor, 6Collaboration-Team, 10Collaboration-Team-Sprint-F-2015-08-04, 10Flow: Run LQT conversion script on mediawiki VE/Feedback - https://phabricator.wikimedia.org/T106613#1473713 (10DannyH) a:3Mattflaschen [00:42:15] 10VisualEditor, 6Collaboration-Team, 10Collaboration-Team-Sprint-F-2015-08-04, 10Flow: F8. Run LQT conversion script on mediawiki VE/Feedback - https://phabricator.wikimedia.org/T106613#1473751 (10DannyH) [01:55:24] 10Cite: Show an error if a named is defined multiple times - https://phabricator.wikimedia.org/T85386#1473850 (10eranroz) a:3eranroz [05:04:08] 10VisualEditor: '' and ''' don't produce "Wikitext markup detected" - https://phabricator.wikimedia.org/T106641#1473950 (10Amire80) 3NEW [05:07:01] (03PS1) 10Legoktm: Set license-name [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/226477 [07:24:02] 10VisualEditor, 10Wikimedia-Site-requests: Enable VisualEditor on outreach.wikimedia.org - https://phabricator.wikimedia.org/T106298#1474104 (10awight) 5Open>3Invalid @Elitre wrote, > TL;DR, VE can already be used at outreach wiki (activate it from your Beta Features, like on Meta). Aaha! Thanks for the... [07:32:33] 10VisualEditor, 10Wikimedia-Site-requests: Enable VisualEditor on outreach.wikimedia.org - https://phabricator.wikimedia.org/T106298#1474117 (10awight) Sigh, and the coffin is sealed: T55974. Visual editor doesn't do translated pages, yet. [07:41:06] eranroz, around? [09:07:44] 10VisualEditor, 10Browser-Tests, 10Wikimania-Hackathon-2015, 5Patch-For-Review, 5WMF-deploy-2015-07-21_(1.26wmf15): add true internationalized content support to auto-screenshots - https://phabricator.wikimedia.org/T105466#1474255 (10Aklapper) What is the status of this task, now that Wikimania 2015 is o... [09:07:49] 10VisualEditor, 10Parsoid, 10Wikimania-Hackathon-2015, 7Epic: HTML diffs of edits for everything - https://phabricator.wikimedia.org/T105173#1474257 (10Aklapper) What is the status of this task, now that Wikimania 2015 is over? Did this hacking project take place and was successfully finished? If yes: Plea... [09:25:55] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 7Browser-Support-Apple-Safari: Cannot scroll dialogs or suggestions in iOS Safari - https://phabricator.wikimedia.org/T71038#1474308 (10Nnemo) [13:12:16] 10VisualEditor, 10Browser-Tests, 10Wikimania-Hackathon-2015, 5WMF-deploy-2015-07-21_(1.26wmf15): add true internationalized content support to auto-screenshots - https://phabricator.wikimedia.org/T105466#1474863 (10Amire80) 5Open>3Resolved [13:12:59] 10VisualEditor, 10Browser-Tests, 10Wikimania-Hackathon-2015, 5WMF-deploy-2015-07-21_(1.26wmf15): add true internationalized content support to auto-screenshots - https://phabricator.wikimedia.org/T105466#1444372 (10Amire80) Basic support is done by Vikas, further work will be done in the coming weeks. Thanks! [14:28:02] 10VisualEditor: '' is frequently used unnecessarily in VisualEditor and put in - https://phabricator.wikimedia.org/T106641#1475048 (10Amire80) [14:30:04] 10Cite, 5Patch-For-Review: add pages with citation errors to a maintenance tracking category - https://phabricator.wikimedia.org/T104792#1475059 (10matej_suchanek) [14:33:48] 10VisualEditor: Adding a label (הוספת תווית) to an external link is only available after save + edit - https://phabricator.wikimedia.org/T106686#1475079 (10TomerA) 3NEW [14:45:09] 10VisualEditor, 10Wikimedia-Site-requests: Enable VisualEditor on outreach.wikimedia.org - https://phabricator.wikimedia.org/T106298#1475124 (10AKoval_WMF) Thanks, @Awight. For the record, I agree with @Elitre. Please, please consult the community and allow them ample time to discuss before requesting any feat... [14:51:56] James_F|Away: despite what we talked yesterday, a not-so-pleased editor opend: https://phabricator.wikimedia.org/T106686 [15:27:05] I've found a bug :/ [15:33:54] 10VisualEditor, 6Commons: Unable to add unspecified parameters to templates on Commons [Regression?] - https://phabricator.wikimedia.org/T106696#1475319 (10Josve05a) 3NEW [15:34:23] James_F, Krinkle_: Can you help changing the title for that one ^ [15:35:05] 10VisualEditor, 6Commons: Unable to add unspecified parameters to templates on Commons [Regression?] - https://phabricator.wikimedia.org/T106696#1475328 (10Josve05a) Mozilla/5.0 (X11; CrOS x86_64 6946.63.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/43.0.2357.130 Safari/537.36 [15:35:25] 10VisualEditor, 6Commons: Unable to add unspecified parameters to templates on Commons [Regression?] - https://phabricator.wikimedia.org/T106696#1475339 (10Josve05a) p:5Triage>3Unbreak! [15:42:49] James_F, is the 'grunt-tyops' module intentionally written this way? I can't decide if I'm amused or horrified. [15:42:51] :D [15:43:02] mooeypoo: Yes. :-) [15:43:08] That's brilliant. [15:43:13] Well done, sir. [15:46:27] :) [15:48:10] 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 6Commons: Unable to add unspecified parameters to templates on Commons [Regression?] - https://phabricator.wikimedia.org/T106696#1475410 (10Josve05a) [16:05:55] 10VisualEditor, 10Wikimedia-Site-requests, 7notice, 7user-notice: Re-enable VisualEditor by default for all newly-created accounts on the English Wikipedia - https://phabricator.wikimedia.org/T90664#1475476 (10Jdforrester-WMF) [16:09:28] 10VisualEditor, 10Wikimedia-Site-requests: Re-enable VisualEditor by default for all users of the English Wikipedia - https://phabricator.wikimedia.org/T90662#1475488 (10Jdforrester-WMF) [16:35:12] 10VisualEditor, 10VisualEditor-CopyPaste, 7Browser-Support-Firefox: VisualEditor: Cannot select across template in Firefox - https://phabricator.wikimedia.org/T106708#1475600 (10Neil_P._Quinn_WMF) 3NEW [16:43:14] 10VisualEditor, 10VisualEditor-CopyPaste, 7Browser-Support-Firefox: VisualEditor: Cannot select across template in Firefox - https://phabricator.wikimedia.org/T106708#1475664 (10Neil_P._Quinn_WMF) [16:59:12] no stand-up today? [17:09:28] jaufrecht: Nope. [17:56:11] 10VisualEditor, 6Community-Liaison, 7Documentation: Check and update VE Documentation - https://phabricator.wikimedia.org/T96237#1476009 (10Elitre) Several new documentation (sub)pages were created in the meanwhile and will be connected to the relevant main pages ASAP. [17:57:01] 10Citoid, 10VisualEditor, 6Community-Liaison: Update Help:VisualEditor/User_guide#Editing_references at mediawiki.org - https://phabricator.wikimedia.org/T94938#1476011 (10Elitre) [17:57:03] 10VisualEditor, 6Community-Liaison, 7Documentation: Check and update VE Documentation - https://phabricator.wikimedia.org/T96237#1476010 (10Elitre) [17:57:52] 10Citoid, 10VisualEditor, 6Community-Liaison: Update Help:VisualEditor/User_guide#Editing_references at mediawiki.org - https://phabricator.wikimedia.org/T94938#1176329 (10Elitre) Several new documentation (sub)pages were created in the meanwhile and will be connected to the relevant main pages ASAP. I admit... [17:57:54] 10VisualEditor, 6Community-Liaison, 7user-notice: Make GIFs which advertise VisualEditor's cool new features to existing editors - https://phabricator.wikimedia.org/T101211#1476015 (10gpaumier) Have these files been added to any other pages? I'd like to advertise them in Tech News, but I'd rather not link to... [18:06:09] 10VisualEditor, 6Community-Liaison, 10Wikimania-Hackathon-2015: VisualEditor translathon at Wikimania Mexico - https://phabricator.wikimedia.org/T91108#1476037 (10Elitre) 5Resolved>3Open I haven't announced the winners or provided much data about the initiative (other than what's on the showcase slides a... [18:15:41] 10VisualEditor, 10Parsoid, 10Parsoid-Nowiki: nowiki is added when adding spaces after a single line break - https://phabricator.wikimedia.org/T104554#1476061 (10Jdforrester-WMF) [18:18:12] 10VisualEditor, 10OOjs, 10OOjs-UI: Submit OOjs UI and OOjs to cdnjs - https://phabricator.wikimedia.org/T106721#1476063 (10Jdforrester-WMF) p:5Triage>3Normal a:3Jdforrester-WMF [18:19:58] 10VisualEditor, 6Community-Liaison, 7user-notice: Make GIFs which advertise VisualEditor's cool new features to existing editors - https://phabricator.wikimedia.org/T101211#1476072 (10Neil_P._Quinn_WMF) @gpaumier, I haven't. We considered adding them to the VE help pages, but thought they'd be too distractin... [18:43:20] Krenair: Could you +2 https://gerrit.wikimedia.org/r/#/c/226430/ and its child? [18:45:02] (03CR) 10Alex Monk: [C: 032] Update VE core submodule to master (d6effdd) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/226430 (owner: 10Jforrester) [18:45:12] Yay. [18:46:09] (03CR) 10Alex Monk: [C: 032] build: Drop last jscs over-ride and make pass [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/226434 (owner: 10Jforrester) [18:46:13] James_F, done [18:46:18] Krenair: Thanks. [18:47:54] (03Merged) 10jenkins-bot: Update VE core submodule to master (d6effdd) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/226430 (owner: 10Jforrester) [18:48:49] (03Merged) 10jenkins-bot: build: Drop last jscs over-ride and make pass [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/226434 (owner: 10Jforrester) [18:49:22] (03PS6) 10Jforrester: Replace wgVisualEditorNamespaces with an associative array [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/223967 (https://phabricator.wikimedia.org/T104898) (owner: 10Alex Monk) [18:49:43] (03PS3) 10Jforrester: Parse SpamBlacklist error on the server-side [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/221867 (https://phabricator.wikimedia.org/T99830) (owner: 10Alex Monk) [18:51:22] (03CR) 10Jforrester: "Should we push the config supporting this (with BC) to production first?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/223967 (https://phabricator.wikimedia.org/T104898) (owner: 10Alex Monk) [18:51:59] (03CR) 10Jforrester: [C: 032] "Holding my nose…" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/221867 (https://phabricator.wikimedia.org/T99830) (owner: 10Alex Monk) [18:53:18] (03PS2) 10Esanders: Strip data related attributes from paste context [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/223767 [19:00:19] James_F, I found an issue with https://gerrit.wikimedia.org/r/#/c/226414/ by the way [19:00:35] which is why I didn't push it out in my list of config changes last night [19:00:42] * James_F nods. [19:01:07] (03CR) 10Esanders: [C: 031] "Direct config variables never make for clean APIs. enableNamespaces(nsList), disableNamespaces(nsList), getEnabledNamespaces(), isNamspace" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/223967 (https://phabricator.wikimedia.org/T104898) (owner: 10Alex Monk) [19:01:48] We push wmgVisualEditorNamespaces into wgVisualEditorAvailableNamespaces. [19:02:07] But not wgVisualEditorNamespaces. [19:02:22] yep [19:02:33] this code needs to handle both config systems at once [19:09:11] James_F, want to put that config change up for swat then? [19:09:53] Krenair: Yup. [19:09:58] Krenair: Thanks! [19:22:45] (03PS1) 10Jforrester: Update OOjs to v1.1.8 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/226606 [19:23:01] (03CR) 10Catrope: [C: 032] Update OOjs to v1.1.8 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/226606 (owner: 10Jforrester) [19:25:50] 10VisualEditor, 10OOjs, 10OOjs-UI: Submit OOjs UI and OOjs to cdnjs - https://phabricator.wikimedia.org/T106721#1476273 (10Jdforrester-WMF) Meh. ``` $ cdnjs-importer -c . ssh://gerrit.wikimedia.org:29418/oojs/core.git info [12:16.17 - 23.07.2015] Cloning ssh://gerrit.wikimedia.org:29418/oojs/core.git into... [19:27:12] 10VisualEditor, 6Community-Liaison, 7user-notice: Make GIFs which advertise VisualEditor's cool new features to existing editors - https://phabricator.wikimedia.org/T101211#1476275 (10gpaumier) >>! In T101211#1476072, @Neil_P._Quinn_WMF wrote: > Perhaps we could make a duplicate of my user subpage at https:/... [19:30:58] (03CR) 10Jforrester: [C: 032] Set license-name [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/226477 (owner: 10Legoktm) [19:34:26] (03CR) 10Jforrester: [C: 032] Parse SpamBlacklist error on the server-side [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/221867 (https://phabricator.wikimedia.org/T99830) (owner: 10Alex Monk) [19:35:22] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-extensions-SpamBlacklist: VisualEditor not parsing SpamBlacklist error message - https://phabricator.wikimedia.org/T99830#1476327 (10Jdforrester-WMF) 5Open>3Resolved [19:41:39] (03Merged) 10jenkins-bot: Set license-name [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/226477 (owner: 10Legoktm) [19:44:49] (03CR) 10jenkins-bot: [V: 04-1] Parse SpamBlacklist error on the server-side [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/221867 (https://phabricator.wikimedia.org/T99830) (owner: 10Alex Monk) [19:45:23] (03CR) 10Jforrester: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/221867 (https://phabricator.wikimedia.org/T99830) (owner: 10Alex Monk) [19:48:22] 10VisualEditor: Prevent user from adding a langlink - https://phabricator.wikimedia.org/T103635#1476358 (10Krenair) [19:48:29] James_F, have you seen ^ ? [19:48:37] I looked at it before and misunderstood it [19:48:46] I think [19:49:20] * James_F looks. [19:49:44] basically if you set a link to target en:Knowledge_Graph it'll do exactly as you say and insert that link. Except then MW will interpret it as a langlink and won't show it as expected [19:50:08] so for some prefixes we should be prepending : [19:50:59] except then on wikis which do still use that, there's no way to add them [19:51:12] 10VisualEditor, 10VisualEditor-MediaWiki: Stop the user from adding a langlink when we magically think they wanted to insert an interwiki instead - https://phabricator.wikimedia.org/T103635#1476369 (10Jdforrester-WMF) p:5Triage>3Lowest [19:51:13] Better? [19:52:24] I think so [19:52:45] I think this is the sifilteriw param [19:53:45] i.e. all of these would let you form unwanted links if we don't prepend ':': https://en.wikipedia.org/w/api.php?action=query&meta=siteinfo&siprop=interwikimap&sifilteriw=local [19:54:01] Not a priority, anyway. [19:54:15] We'd have to have something in the Parsoid request to tell it what we wanted. [19:54:18] except... I'm not sure about some of those like otrs:, otrswiki:, outreach:, outreachwiki: [19:57:07] and loads more [20:08:50] I wonder what this RelatedSites extension we have in production does [20:09:54] ah, something for wikivoyage [20:15:52] As so often. [20:36:09] 10VisualEditor, 6Community-Liaison, 7user-notice: Make GIFs which advertise VisualEditor's cool new features to existing editors - https://phabricator.wikimedia.org/T101211#1476531 (10Neil_P._Quinn_WMF) @gpaumier, it's now available at https://www.mediawiki.org/wiki/VisualEditor/GIFs. Feel free to edit the p... [20:37:20] 10VisualEditor, 6Community-Liaison, 7user-notice: Make GIFs which advertise VisualEditor's cool new features to existing editors - https://phabricator.wikimedia.org/T101211#1476532 (10gpaumier) @Neil_P._Quinn_WMF Perfect, thank you! [20:38:13] 10VisualEditor, 6Community-Liaison, 7user-notice: Make GIFs which advertise VisualEditor's cool new features to existing editors - https://phabricator.wikimedia.org/T101211#1476534 (10Neil_P._Quinn_WMF) [20:45:33] (03CR) 10Jforrester: [C: 032] Parse SpamBlacklist error on the server-side [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/221867 (https://phabricator.wikimedia.org/T99830) (owner: 10Alex Monk) [20:46:28] (03CR) 10Jforrester: [C: 032] Update OOjs to v1.1.8 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/226606 (owner: 10Jforrester) [20:48:00] (03Merged) 10jenkins-bot: Parse SpamBlacklist error on the server-side [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/221867 (https://phabricator.wikimedia.org/T99830) (owner: 10Alex Monk) [20:50:51] (03CR) 10jenkins-bot: [V: 04-1] Update OOjs to v1.1.8 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/226606 (owner: 10Jforrester) [21:05:36] (03CR) 10Jforrester: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/226606 (owner: 10Jforrester) [21:10:26] I think there's a bug in some of our title input code [21:11:40] mw.widgets.TitleInputWidget.prototype.getLookupMenuOptionsFromData's titles array gets filled with a bunch of undefineds [21:16:46] 10VisualEditor, 10VisualEditor-CopyPaste: When pasting a mix of eted and nondeleted text into the visual editor, the deleted text is not shown - https://phabricator.wikimedia.org/T66760#1476722 (10Neil_P._Quinn_WMF) 5stalled>3Open p:5Triage>3High [21:17:06] 10VisualEditor, 10VisualEditor-CopyPaste: When pasting a mix of eted and nondeleted text into the visual editor, the deleted text is not shown - https://phabricator.wikimedia.org/T66760#1476733 (10Neil_P._Quinn_WMF) Verified and updated. [21:25:16] Ew. [21:25:17] Ewwwwwwwwww. [21:25:31] 10VisualEditor: VisualEditor cut off last several characters of article text during two edits at pl.wp - https://phabricator.wikimedia.org/T66182#1476798 (10Neil_P._Quinn_WMF) 5stalled>3Resolved [21:25:40] 10VisualEditor: VisualEditor cut off last several characters of article text during two edits at pl.wp - https://phabricator.wikimedia.org/T66182#707226 (10Neil_P._Quinn_WMF) Can't reproduce. Reopen if you can. [21:25:43] Krenair: Oh? [21:26:03] In mw.widgets.TitleInputWidget.prototype.getLookupMenuOptionsFromData I started making it dump each value of suggestionPage [21:26:16] I started getting back array functions [21:26:21] "Jdforrester-WMF changed the edit policy of this Project from "Custom Policy" to "Custom Policy"." [21:26:36] arrayPrototypeUniq, arrayPrototypeUniq, arrayChunk [21:26:51] Elitre, ? [21:27:28] Krenair: https://phabricator.wikimedia.org/project/profile/483/#13239 [21:28:07] Elitre, okay... [21:28:22] :D [21:28:47] He removed neilpquinn and added Neil_P._Quinn_WMF and TrevorParscal to the list of people able to edit the VE project [21:29:17] Am I missing something? [21:30:25] Elitre: Yup. [21:30:32] Phabricator sucks. [21:30:40] (Also, wrong neilpquinn account, hence the change.) [21:30:40] the last line on that page is the one I quoted above (at least for me), and I thought it was a funny change. [21:32:35] Krinkle_, what did we decide about gadgets which do things like set Array.prototype.uniq? [21:33:12] or rather, you [21:33:13] or someone [21:34:41] Which starts causing issues when you do things like https://github.com/wikimedia/mediawiki/blob/master/resources/src/mediawiki.widgets/mw.widgets.TitleInputWidget.js#L195 and get indexes like 'uniq' with function values, which our (quite reasonable, imo) code doesn't expect [21:38:20] 10VisualEditor: VisualEditor: Word missing from wikilink - https://phabricator.wikimedia.org/T63550#1476841 (10Neil_P._Quinn_WMF) 5stalled>3Resolved [21:38:27] 10VisualEditor: VisualEditor: Word missing from wikilink - https://phabricator.wikimedia.org/T63550#676219 (10Neil_P._Quinn_WMF) Seems to be fixed now. [21:42:48] 10VisualEditor, 6Collaboration-Team, 10Collaboration-Team-Sprint-F-Finishing-Move-2015-08-04, 10Flow: F8. Run LQT conversion script on mediawiki VE/Feedback - https://phabricator.wikimedia.org/T106613#1476862 (10DannyH) [21:42:58] 10VisualEditor, 6Collaboration-Team, 10Collaboration-Team-Sprint-F-Finishing-Move-2015-08-04, 10Flow: F8. Run LQT conversion script on mediawiki VE/Feedback - https://phabricator.wikimedia.org/T106613#1472870 (10DannyH) [21:50:51] Krenair: It's discouraged but not yet actively disallowed. [21:51:01] Krenair: They should only use es5-shim for standard methods [21:51:09] and other core shims [21:51:22] no custom shims or non-standard prototype methods because they poison everything else [21:51:38] they should instead have their own MyUtilWhatever object and stuff it there [22:02:48] 10VisualEditor, 10VisualEditor-MediaWiki: Stop the user from adding a langlink when we magically think they wanted to insert an interwiki instead - https://phabricator.wikimedia.org/T103635#1476972 (10Krenair) I looked into trying to identify things that MW will turn into langlinks and only prepending ':' to t... [22:19:28] 10Citoid, 10MediaWiki-Vagrant: Citoid provisioning fails with npm errors - https://phabricator.wikimedia.org/T103634#1477043 (10Mattflaschen) 5Open>3Resolved a:3Mattflaschen [22:19:56] 10Citoid, 10MediaWiki-Vagrant: Citoid provisioning fails with npm errors - https://phabricator.wikimedia.org/T103634#1394946 (10Mattflaschen) a:5Mattflaschen>3mobrovac [22:30:49] 10VisualEditor, 10VisualEditor-MediaWiki-Templates: Make transcluding interface messages using the visual editor more user-friendly - https://phabricator.wikimedia.org/T106755#1477134 (10Neil_P._Quinn_WMF) 3NEW [22:31:14] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Support editing {{int:name}} blocks - https://phabricator.wikimedia.org/T67644#1477151 (10Neil_P._Quinn_WMF) >Update: I can insert parser functions by adding a "template" named (for example) "int:vector-view-edit". It says there's no TemplateData, but... [22:31:28] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Support editing {{int:name}} blocks - https://phabricator.wikimedia.org/T67644#1477156 (10Neil_P._Quinn_WMF) 5Open>3Resolved [22:36:44] Krenair: Did you want to put https://gerrit.wikimedia.org/r/#/c/226414/ in the SWAT? [22:39:58] James_F, done [22:41:06] OK. [22:43:50] 10VisualEditor, 10MediaWiki-extensions-UniversalLanguageSelector, 5Patch-For-Review, 7Technical-Debt: Move jQuery.i18n module to core - https://phabricator.wikimedia.org/T95666#1477241 (10Jdforrester-WMF) [23:00:03] 10VisualEditor, 10VisualEditor-EditingTools, 7Epic: VisualEditor: Transclusions editor should support parser functions and variables - https://phabricator.wikimedia.org/T52855#1477303 (10Neil_P._Quinn_WMF) p:5Normal>3Low [23:01:34] (03CR) 10Jforrester: "… which is now merged." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/223217 (owner: 10Jforrester) [23:01:39] (03PS2) 10Jforrester: Load the jquery.i18n library from MediaWiki, not lib/ve [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/223217 [23:03:33] (03CR) 10jenkins-bot: [V: 04-1] Load the jquery.i18n library from MediaWiki, not lib/ve [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/223217 (owner: 10Jforrester) [23:08:40] 10VisualEditor: VisualEditor isn't able to handle header and row templates - https://phabricator.wikimedia.org/T62598#1477332 (10Neil_P._Quinn_WMF) As @Etonkovidova said, it is possible (though not user-friendly) to do this. I'm tentatively closing; if anyone has specific ideas for how to make this more user fri... [23:08:50] 10VisualEditor: VisualEditor isn't able to handle header and row templates - https://phabricator.wikimedia.org/T62598#1477334 (10Neil_P._Quinn_WMF) 5Open>3Resolved [23:15:52] mooeypoo: hey, would you mind testing something in RTL? DateInputWidget: https://gerrit.wikimedia.org/r/#/c/216375/ (it should support hebrew) [23:16:30] MatmaRex, I'll pull it to core, but do you have a demo working to test? or do I need to create one? [23:16:53] Where do I see it? [23:16:57] mooeypoo: i'm not sure how the arrows buttons should work, and whether they happen to work correctly. if you press Tab to focus the calendar, you can also navigate with arrow keys and pageup/pagedown, this part probably doesn't behave correctly. [23:17:05] there's an example in the followup commit [23:17:10] oh ok, hang on [23:18:19] mooeypoo: or you can try it at http://giefuidcfa.localtunnel.me/w/index.php?title=Specjalna:Pusta_strona&uselang=en (this points to a VM on my computer) [23:18:52] ok, I can do that too [23:19:00] I pulled the demo, I just need to figure out which page to go to to see it [23:19:04] history of something [23:19:30] http://giefuidcfa.localtunnel.me/w/index.php?title=Specjalna:Pusta_strona&uselang=en <-- this isn't working [23:19:31] Special:BlankPage [23:19:46] It works for me [23:19:49] It just loads really really slowly [23:19:59] It's still loading actually [23:20:01] I see it locally [23:20:22] (it died, should be back up now) [23:20:31] SyntaxError: missing } in compound statement [23:20:34] ooh it looks great [23:20:36] ReferenceError: mw is not defined [23:20:38] trying it in hebrew [23:20:40] Oh maybe I should reload [23:21:25] MatmaRex, first off, this looks really nice [23:21:32] second, it works fine with ?uselang=he [23:21:36] The directions work well [23:21:59] only thing is that you might want to let people edit the way this shortens the date (does that exist? ) [23:22:05] or like, the format of the date, etc [23:22:09] which I assume exists [23:22:27] it's using moment.js for date formatting [23:22:50] oh ok, so people can choose their own [23:23:10] it looks great, I can't see anything immediately wrong with the RTL version [23:23:46] mooeypoo: after you focus the field, press Tab once to focus the calendar, and try arrow keys. are they sane too? [23:24:35] oooh arrow keys [23:24:43] yeah, good instinct == those are backwards [23:24:46] i go left it goes right [23:25:04] MatmaRex: In uselang=nl (and probably all other LTR langs), pressing right arrow on the 31st causes an animation while switching to the next month, but pressing left arrow on the 1st does not cause an animation while switching to the previous month [23:25:17] up and down work well [23:25:27] Same for down vs up [23:25:44] mooeypoo: (it doesn't respect MW's user preferences, if that's what you're asking? it's a mostly standalone library, although i'm considering implementing something from scratch using MW's date formats and stuff, since moment.js is large-ish dependency) [23:26:11] And pgdn/pgup skip entire months, nice [23:26:20] MatmaRex, yeah no i just wanted to make sure that the widget allows for customizing the formatting of the date. If you're using moment.js the answer's yes [23:26:37] MatmaRex, okay, so arrows are backwards in RTL [23:26:41] RoanKattouw: i can't reproduce the animation problems, although somebody reported that earlier. i think chrome just goes funky if you switch them too fast. [23:26:41] and so are page up/down [23:26:49] (I'm testing in Firefox) [23:27:08] I don't see the animation problem either [23:27:11] Also, it seems you can't get to the month or year views with the keyboard [23:27:26] Even if you use the mouse to get to them, then tab into the widget, it moves back to the day view [23:27:48] mooeypoo: okay, will fix. can you comment on the changeset? [23:27:52] page down should go back or forward? [23:27:55] I'm confused [23:28:20] In LTR, page down goes forwards in time [23:28:30] Then it works in RTL perfectly [23:28:31] It means "this date but next month" [23:28:33] the arrows don't [23:28:41] yeah i wasn't sure if that's supposed to be forward or back [23:28:54] RoanKattouw: yeah, intentional limitation. i figured that if you're using the keyboard already, it'll be easier to type the date in. and implementing keyboard support for all the views looked tedious. [23:29:11] Right [23:29:36] (by the way, you both can totally feel free to review the thing! :D) [23:32:40] RoanKattouw: hmm, i can now reproduce the lack of half of the transitions on Firefox, and Firefox only. curious. [23:33:16] (modern Opera, IE and old Opera all behave correctly) [23:33:48] Also not always [23:34:27] If you move forward a bunch of times using PgDn and then suddenly switch to moving backwards with PgUp (and press the buttons relatively rapidly), the backwards transitions will happen about 1/3 - 1/2 of the time [23:34:42] If you switch panes at a slow pace, the backwards transitions don't happen at all [23:48:11] (03CR) 10Jforrester: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/223217 (owner: 10Jforrester) [23:48:37] (03CR) 10Jforrester: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/226606 (owner: 10Jforrester) [23:50:24] (03CR) 10Legoktm: [C: 04-1] Load the jquery.i18n library from MediaWiki, not lib/ve (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/223217 (owner: 10Jforrester) [23:52:47] (03CR) 10Jforrester: Load the jquery.i18n library from MediaWiki, not lib/ve (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/223217 (owner: 10Jforrester) [23:53:02] (03PS3) 10Jforrester: Load the jquery.i18n library from MediaWiki, not lib/ve [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/223217 [23:56:55] (03CR) 10Jforrester: [C: 032] "Config now ready and working in prod for this." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/223967 (https://phabricator.wikimedia.org/T104898) (owner: 10Alex Monk) [23:57:08] 10VisualEditor, 10VisualEditor-MediaWiki: Replace wgVisualEditorNamespaces with a 2D array of namespace => enabled state - https://phabricator.wikimedia.org/T104898#1477452 (10Jdforrester-WMF) 5Open>3Resolved [23:57:22] (03CR) 10Jforrester: [C: 032] Strip data related attributes from paste context [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/223767 (owner: 10Esanders) [23:59:52] (03Merged) 10jenkins-bot: Replace wgVisualEditorNamespaces with an associative array [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/223967 (https://phabricator.wikimedia.org/T104898) (owner: 10Alex Monk)