[00:05:55] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Please show the file name in the media dialog, and make it easy to copy it - https://phabricator.wikimedia.org/T71726#1483800 (10Krenair) 5Open>3Resolved a:3Krenair I added `[[File:Diederich Graminaeus (1550-1610). Beschreibung derer Fürstlicher... [00:17:20] 10VisualEditor, 10VisualEditor-MediaWiki-Media: VisualEditor: Please show the file name in the media dialog, and make it easy to copy it - https://phabricator.wikimedia.org/T71726#1483804 (10Jdforrester-WMF) p:5Triage>3Low a:5Krenair>3Mooeypoo [00:19:38] 10VisualEditor, 10VisualEditor-MediaWiki-Media: Show a user's recent uploads in the MW insert media dialog - https://phabricator.wikimedia.org/T62398#1483809 (10Jdforrester-WMF) a:5Esanders>3None [00:25:59] 10Citoid, 10VisualEditor, 6Services: DOI redirect handler for iopscience is very slow/ potentially causes citoid to behave oddly. - https://phabricator.wikimedia.org/T106374#1483818 (10Jdforrester-WMF) p:5Triage>3High [00:26:05] 10Citoid, 10VisualEditor, 6Services: DOI redirect handler for iopscience is very slow/ potentially causes citoid to behave oddly. - https://phabricator.wikimedia.org/T106374#1466616 (10Jdforrester-WMF) [02:21:51] 10VisualEditor, 10VisualEditor-Performance, 10Parsoid, 7Parsoid-Token-Stream-Transforms, and 2 others: Batch Parsoid's API requests - https://phabricator.wikimedia.org/T45888#1483854 (10ssastry) Sounds good to me since it looks like it keeps complexity down implementing this since the code can be customize... [04:25:24] 10WikiEditor: Icons are missing on fast closing and opening the tabs - https://phabricator.wikimedia.org/T106993#1483880 (10Fomafix) The reason for the strange behavior are unfinished animations. https://gerrit.wikimedia.org/r/226676 combines the animation of the height and the fading of the icons to one animati... [05:48:07] 10VisualEditor, 10Wikimedia-Site-requests: Enable VisualEditor on Meta-Wiki's Meta namespace - https://phabricator.wikimedia.org/T107003#1483948 (10Glaisher) 3NEW [08:42:28] (03CR) 10Fomafix: [C: 031] WikiEditor: Move HTML for dialogs to separate files [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/227187 (owner: 10Gerrit Patch Uploader) [09:29:33] 10VisualEditor: Useless nowiki tag added after a template - https://phabricator.wikimedia.org/T107012#1484272 (10NicoV) 3NEW [17:01:11] Is there a easy way to dump PHP vars on the screen for debug purposes? var_dump doesn't seem to work [17:10:43] ferdbold, what are you trying to dump? [17:11:36] The results from the API call in parseWikiText() in ApiVisualEditorEdit.php [17:12:18] I've tried logging them to the PHP log as well but these don't seem to work either, could it be some funky vagrant config thing to enable? [17:18:41] how can var_dump not work. Hm. [17:20:03] ferdbold, and where are you expecting the results to appear? [17:20:41] On the screen, or at least somewhere in the DOM [17:21:03] that's ApiVisualEditorEdit.php [17:21:25] it's only called when VE saves the document by posting to api.php?action=visualeditoredit [17:21:56] hm, how can we examine the result, then, Krenair ? any advice? [17:21:58] you'll only see the result in the response body to that request [17:22:01] network tab [17:22:08] oh the network tab! right. [17:22:40] ferdbold, you know the networks tab in chrome? [17:25:02] On behalf of Grace: does the 7:30 am PT time tomorrow for the Team Health Check work for all? [17:25:06] Oh right, not using this tag often though [17:25:10] tab* [17:26:23] I'm seeing an api.php?action=visualeditor but not an action=visualeditoredit, I'm guessing these are not the same thing [17:26:39] uh, right [17:26:45] it probably posts to api.php [17:26:58] with action=visualeditoredit as part of the actual data sent [17:28:02] Oh right visualeditoredit only pops up after I've done a save action, that was my blonde moment of the week haha [17:30:30] predeployment review this week? [17:35:15] jaufrecht: Given no Ed I guess it's pointless. [17:35:36] hrm. I'll need to bump the SLU meeting too, then. It needs Ed. [17:35:42] Yeah. :-( [17:52:13] Hi, VE Team! Could you please accept or decline the calendar invite for tomorrow's Team Health Check? [17:54:19] 10VisualEditor, 10MediaWiki-extensions-UploadWizard, 6Multimedia, 10OOjs-UI: Create a datepicker input widget - https://phabricator.wikimedia.org/T97425#1485544 (10Jdforrester-WMF) [17:54:27] 10VisualEditor, 10VisualEditor-MediaWiki-Templates: Calendar input widget for dates in infoboxes - https://phabricator.wikimedia.org/T100206#1485548 (10Jdforrester-WMF) [17:55:47] * marktraceur pings James_F for ggellerman__'s query [18:00:53] marktraceur: I accepted a month ago.\ [18:02:57] James_F: You're also the Team Whip, so [18:05:19] ferdbold, you making progress or still stuck? [18:05:30] Krinkle, is around, I think (?) and may be able to help more [18:08:12] mooeypoo so far so good, I'm still wrestling with the network tab a bit to see values though [18:08:26] eranroz: do you have any news about https://phabricator.wikimedia.org/T106996? [18:09:01] ferdbold, tip: open VE, then open the networks tab, then clear the networks tab and save -- you'll have only the relevant API call/reply in the tab now, and easier to find what you're looking for [18:09:06] reza1615: no, I just created it yesterday and no one yet reviewed it [18:09:31] who can help us to solve this bug? [18:09:55] if wikimedia wants to active VE before 2016 [18:10:12] they should solve this problem to have some JS tools on it [18:10:23] James_F can assign it priority/or ask good questions why do we need it :) [18:10:23] mooeypoo: I was mainly using the filter to only display XHR, I suppose that's the only thing I'm looking for [18:11:31] I always forget if it's XHR or SCRIPT [18:11:39] 10VisualEditor: Provide easy interface for manipulating/replacements of ve Document - https://phabricator.wikimedia.org/T106996#1485619 (10Jdforrester-WMF) > Global replacements aren't supported - Going global replacements similar to hewiki/fawiki scripts isn't possible with the current model, and even if it is... [18:11:47] so blanking out that tab and looking at "ALL" just makes things simpler for me [18:12:08] a read some where which they want to active VE as default before 2016. before activing this they should help us to have local JS tools on it [18:16:02] reza1615: VE team are very kind and helpful :) just ask them specific question [18:17:38] I want to get text and do some edites on it and push it VE before save. [18:18:22] by eranroz's help we developed https://fa.wikipedia.org/wiki/%D9%85%D8%AF%DB%8C%D8%A7%D9%88%DB%8C%DA%A9%DB%8C:Gadget-VeSuperTool.js [18:18:41] but it removes [[]] after the edits [18:22:21] 10VisualEditor: Provide easy interface for manipulating/replacements of ve Document - https://phabricator.wikimedia.org/T106996#1485656 (10eranroz) I know the hewiki script so I will explain it : It is a site-wide common replacements for keeping conventions and consistency across the wiki. The replacements are f... [18:22:43] reza1615: can you describe in the bug what is the use case used for the script in fawiki? [18:22:59] sure [18:26:43] mooeypoo: got the DOM ruler sticker just now, thanks! [18:27:17] Krinkle, np! These stickers were winning at that conference :) [18:30:06] 10VisualEditor, 10Wikimedia-Site-requests: Enable VisualEditor on Meta-Wiki's Meta namespace - https://phabricator.wikimedia.org/T107003#1485679 (10Jdforrester-WMF) We've mostly avoided enabling it in signed namespaces… [18:31:56] 10VisualEditor: Provide easy interface for manipulating/replacements of ve Document - https://phabricator.wikimedia.org/T106996#1485682 (10Yamaha5) At fawikipedia we have a local code which corrects text's wrong words and convert numbers to Persian with many regexes (which they limited by some exception patterns... [18:49:10] 10VisualEditor, 10Analytics-EventLogging, 10Beta-Cluster: Beta cluster is sending VisualEditor events to production bits.wikimedia.org/statsv - https://phabricator.wikimedia.org/T98196#1485738 (10Jdforrester-WMF) [18:51:23] Does anyone have any workaround suggestions for this: https://phabricator.wikimedia.org/T106419 [18:51:52] It's probably one of the major things keeping me from upgrading my prod stuff up to 1.25 [19:18:54] 10Citoid, 10Security-Reviews, 6Security-Team: Security review of Citoid - https://phabricator.wikimedia.org/T98096#1485865 (10MoritzMuehlenhoff) [19:28:41] 10VisualEditor, 10VisualEditor-ContentEditable: Unable to remove bold and italic formatting from pastes of external sources - https://phabricator.wikimedia.org/T101212#1485931 (10Neil_P._Quinn_WMF) p:5Triage>3High [19:33:48] 10VisualEditor, 10VisualEditor-ContentEditable: Unable to remove bold and italic formatting from pastes of external sources - https://phabricator.wikimedia.org/T101212#1485952 (10Neil_P._Quinn_WMF) Verified on Firefox 41.0a2. I don't see anything odd in the linear model or the HTML. However, the problem goes... [19:35:59] 10VisualEditor: Badly formatted reference in template is not escaped by VE, resulting in completely damaged article - https://phabricator.wikimedia.org/T106795#1485964 (10Whatamidoing-WMF) I can't reproduce this: https://en.wikipedia.org/w/index.php?diff=673351534&oldid=671886705 However, when I pasted in the... [19:40:59] 10VisualEditor, 10VisualEditor-Tables: Do not allow editors to add empty spaces or blank lines in table cells - https://phabricator.wikimedia.org/T107076#1485986 (10Whatamidoing-WMF) 3NEW [19:48:22] 10VisualEditor, 10Wikimedia-Interwiki-links: Sometimes, some interwiki links (to other language Wikipedias) are not being formatted ideally - https://phabricator.wikimedia.org/T107077#1486014 (10Whatamidoing-WMF) 3NEW [19:51:46] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References: When inserting a new automatic citation, offer "Edit" as well as "Insert" button - https://phabricator.wikimedia.org/T107078#1486025 (10Whatamidoing-WMF) 3NEW [19:53:00] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References: When inserting a new automatic citation, offer "Edit" as well as "Insert" button - https://phabricator.wikimedia.org/T107078#1486033 (10Jdforrester-WMF) 5Open>3declined a:3Jdforrester-WMF We discussed this at length when we created the auto... [19:54:49] 10VisualEditor, 10VisualEditor-Tables: Do not allow editors to add empty spaces or blank lines in table cells - https://phabricator.wikimedia.org/T107076#1486039 (10NicoV) I don't agree on the description of this problem, that's not what I explained. There are 2 things under the term of "stray spaces" : -... [19:56:20] 10VisualEditor, 10VisualEditor-Tables: Do not allow editors to add empty spaces or blank lines in table cells - https://phabricator.wikimedia.org/T107076#1486043 (10NicoV) I don't agree on the description of this problem, that's not what I explained. There are 2 things under the term of "stray spaces" : -... [20:03:49] 10VisualEditor, 10VisualEditor-MediaWiki-Links: VisualEditor should let people link to another wiki easily, maybe with integrated suggestions or its own tab? - https://phabricator.wikimedia.org/T98135#1486062 (10Jdforrester-WMF) [20:06:16] 10VisualEditor, 10VisualEditor-MediaWiki-Links: VisualEditor should let people link to another wiki easily, maybe with integrated suggestions or its own tab? - https://phabricator.wikimedia.org/T98135#1486069 (10Jdforrester-WMF) Maybe we could try to integrate the cross-wiki options into the response for "sear... [20:09:16] 10VisualEditor, 10VisualEditor-MediaWiki-Links: VisualEditor should let people link to another wiki easily, maybe with integrated suggestions or its own tab? - https://phabricator.wikimedia.org/T98135#1486085 (10eranroz) On non technical perspective - it shouldn't be "too easy" to add links to other wikis, so... [20:12:58] 10VisualEditor, 10VisualEditor-MediaWiki-Links: VisualEditor should let people link to another wiki easily, maybe with integrated suggestions or its own tab? - https://phabricator.wikimedia.org/T98135#1486089 (10Jdforrester-WMF) >>! In T98135#1486085, @eranroz wrote: > On non technical perspective - it shouldn... [20:17:30] 10VisualEditor, 10VisualEditor-MediaWiki-Links: VisualEditor should let people link to another wiki easily, maybe with integrated suggestions or its own tab? - https://phabricator.wikimedia.org/T98135#1486097 (10eranroz) Another option: completely ignore it in the front side (VE) and let users add it as extern... [20:19:41] 10VisualEditor, 10VisualEditor-MediaWiki-Links: VisualEditor should let people link to another wiki easily, maybe with integrated suggestions or its own tab? - https://phabricator.wikimedia.org/T98135#1486103 (10Jdforrester-WMF) >>! In T98135#1486097, @eranroz wrote: > Another option: completely ignore it in t... [20:20:18] parsoid is awsome :) I didn't know it already does it. [20:21:58] eranroz: :-) [20:22:11] eranroz: No rush to do T98135 from my end. [20:22:24] eranroz: Just musing about how to encourage more cross-wiki working and linking for readers. [20:22:33] eranroz: {{sister projects}} is now and has always been horrible. [20:23:09] James_F: (I was about to say maybe add "sisterproject" as type in template data) [20:23:20] and use it for suggestions [20:23:29] but i agree that sister projects is horrible [20:24:02] Also, all templates are horrible. [20:24:03] ;-) [20:30:29] (03PS1) 10Ferdbold: Added jsconfigvars and modules to the save mechanism [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227332 [20:32:28] (03PS2) 10Ferdbold: Added jsconfigvars and modules to the save mechanism [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227332 [20:33:42] (03PS3) 10Ferdbold: Added jsconfigvars and modules to the save mechanism [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227332 [20:36:31] ferdbold, are you fixing something specific here? [20:55:52] Krenair: This fixes the problem that page modules (e.g. addModules) don't work properly post-save in VE. [20:56:03] Because modules are not loaded, and mw.config is stale [20:56:09] Specifically for the Graph extension [20:56:15] which stores data in mw.config and loads itself [20:56:45] wikipage.content is already fired so that one is fine. [20:57:35] I'm still fine with it even if this isn't currently causing issues for users. Just wondering if we should be linking some tasks here [20:58:13] Yeah [20:59:13] (03CR) 10Krinkle: Added jsconfigvars and modules to the save mechanism (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227332 (owner: 10Ferdbold) [21:05:04] RoanKattouw: Crap, the data is broken again. [21:05:09] The php entry point is gone [21:05:16] I guess scap removes it [21:06:04] scap and sync-dir remove things which don't exist on the master (and sync-dblist for removing dblists) [21:06:12] Yeah [21:06:13] context? [21:06:17] Even on mw1011 [21:06:20] mw1017 [21:06:29] Isn't mw1011 crazy at the moment? [21:06:30] I created a temporary php file there to debug something [21:06:35] ah. [21:06:40] I hve no idea what mw1011 is [21:07:02] Oh well, so we have an hour of blackness. [21:07:16] server that went nuts earlier and started spamming the logs with errors about a built-in function not being defined [21:12:14] Krinkle: Ugh, so we have to start over again? :S [21:12:21] Nah, it's fine [21:12:26] we're only missing about 35min of data [21:16:09] Before or after the switch [21:19:28] RoanKattouw: 35min after 15min after the switch [21:19:45] Hrmph [21:19:57] That's a valuable window of data though [21:20:09] Yeah [21:20:23] We could increment the version again... [21:20:26] Switch at 19:12 [21:20:28] UTC [21:20:42] In the 5 minutes following there are frequent hits [21:20:56] then from 16:53 onwards, there is only 1 hit per minute for a while [21:21:05] the last hit was at 19:26 [21:21:07] then there is a gap [21:21:14] and nothing since the gap [21:21:18] 21:21 now [21:22:05] 16:53 = 19:16:53 [21:22:27] Hmm [21:22:35] So maybe we should increment the version again and get cleaner data [21:22:48] Yeah, maybe [21:22:57] I'll first add the script to the git repo [21:23:01] before it gets lost again [21:23:02] Or maybe not? [21:23:14] Can make it conditional on testwiki to avoid abuse [21:23:23] Or hostname rather [21:23:56] Weren't we using mw.org instead of test? [21:24:07] RoanKattouw: site module of test [21:24:11] rl-test.php logger on test [21:24:15] site module of mw.org [21:24:22] rl-test.php logger on mw1017 [21:24:44] Right, so the request to rl-test.php always goes to test.wikipedia.org [21:24:49] Yes [21:31:37] Krinkle: BTW, can I get your opinion on this trick? https://gist.github.com/catrope/2593bd431d5cf18b94b9 [21:31:42] I don't really like the dummy deferred thing [21:31:58] But I think it might be the only way that I can emit an event with a promise before starting the switching process [21:32:47] RoanKattouw: Why [21:33:06] While also emitting the event immediately [21:33:19] Are there evil event handlers/ [21:33:19] Hmm I guess it's OK to emit the event a bit late as long as it's synchronously late [21:33:30] One main thing the event handler is gonna do is pushPending() [21:33:50] Right [21:33:51] Yeah [21:33:54] But it doesn't matter if that happens a bit later after the process is started as long as it's synchronously later and not asynchronously later [21:33:57] Should be fine to start the chain first [21:33:59] Because the rendering thread is locked anyway [21:34:08] Yep [21:34:16] And the promise creation should be cheap [21:34:32] Right, so I can just do this.switchingPromise = convert.then.then.then; this.emit( 'switch', this.switchingPromise ); return this.switchingPromise; [21:37:26] Sounds good [21:41:53] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References: When inserting a new automatic citation, offer "Edit" as well as "Insert" button - https://phabricator.wikimedia.org/T107078#1486380 (10Whatamidoing-WMF) Do you believe that "people bailing when given an extra option" exceeds the number of "peopl... [21:54:02] 10VisualEditor: '' is frequently used unnecessarily in VisualEditor and put in - https://phabricator.wikimedia.org/T106641#1486424 (10Amire80) [22:09:31] Krinkle: Ugh, so that also has issues. Because I can't do this.switchingPromise = convert.then.then.then...then( widget.switchingPromise = null; ) , because if the whole then chain runs synchronously, this.switchingPromise will be cleared before it's set :S [22:09:48] Right now I'm working around that with a local stillSwitching variable that's initially true and is set to false by the then callback [22:23:08] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki: VisualEditor: Handle invalid input for redirect title in meta dialog - https://phabricator.wikimedia.org/T74971#1486465 (10Krenair) Right now it shows the red outline around the textbox when you try to do this. Do we want to block it from... [22:33:04] 10VisualEditor: TypeError "Cannot read property 'length' of undefined" appears while trying to select the same reference from Use Existing Reference dialog - https://phabricator.wikimedia.org/T90476#1486503 (10Krenair) Or reusing the same reference can cause us to just discard any of your changes and close the r... [22:43:06] wtf [22:44:13] https://phabricator.wikimedia.org/P1077 [22:45:25] MatmaRex, ^ [22:49:02] whenever I try to load /w/load.php?modules=oojs-ui.styles.icons [22:52:27] It looks fine if I dump $this->getPath( $context ) in ResourceLoaderImage::variantize [22:52:41] and then run that through (new DOMDocument)->load( $path ) in php -a [22:52:43] Krinkle, ^ [22:53:39] If I add libxml_disable_entity_loader(false); it works... [22:53:48] Yes, this is a known issue [22:53:52] Import.php does the same [22:54:40] and TimedMediaHandler, and core/HtmlFormatter [23:11:58] 10VisualEditor: [Regression pre-wmf16] VE crashes when clicking on the Row/Column inserter arrow - https://phabricator.wikimedia.org/T107102#1486719 (10Ryasmeen) 3NEW [23:12:28] 10VisualEditor: [Regression pre-wmf16] VE crashes when clicking on the Row/Column inserter arrow - https://phabricator.wikimedia.org/T107102#1486726 (10Ryasmeen) p:5Triage>3Unbreak! [23:38:39] Krinkle: Oh BTW I'm scapping now [23:38:47] Krinkle: So I hope that doesn't nuke your entry point on mw1017 [23:39:06] RoanKattouw: It probably will, but I've got a copy now [23:39:18] I'll add it back after [23:40:28] OK [23:40:33] I'll ping you when it finishes [23:44:27] Krenair: Krinkle: hmm [23:45:36] Krenair: that code always looked like this. did that just start happening? locally, or wmf prod? [23:45:50] local [23:45:56] I think I've run into it a couple of times before [23:48:09] interesting. so we should probably wrap that in $old = libxml_disable_entity_loader() … libxml_disable_entity_loader($old) [23:48:25] Yeah, that's what I've done locally. [23:48:28] or use file_get_contents() and load from strings, since these are short files