[00:01:08] 10VisualEditor, 6Analytics-Backlog, 10Analytics-Dashiki: Improve the edit analysis dashboard {lion} - https://phabricator.wikimedia.org/T104261#1486963 (10Neil_P._Quinn_WMF) a:3Neil_P._Quinn_WMF [00:01:09] Krinkle: [17:00] logmsgbot !log catrope Finished scap: SWAT (duration: 22m 15s) [00:01:15] Thx [00:18:10] 10TemplateData, 10MediaWiki-extensions-Scribunto: There should be a Lua method mw.loadTemplateData() - https://phabricator.wikimedia.org/T107119#1487052 (10jeblad) 3NEW [00:21:35] 10VisualEditor, 10Parsoid, 10Parsoid-Nowiki, 10RESTBase: scrubWikitext doesn't reach Parsoid - https://phabricator.wikimedia.org/T106909#1487075 (10Jdforrester-WMF) [00:46:50] 10VisualEditor, 6Editing-Department, 7Blocked-on-Editing: VisualEditor tests fail in target agnostic mode - https://phabricator.wikimedia.org/T107122#1487144 (10Jdlrobson) 3NEW a:3Jdlrobson [01:08:56] 10VisualEditor, 10Parsoid, 10Parsoid-Nowiki, 10RESTBase: scrubWikitext doesn't reach Parsoid - https://phabricator.wikimedia.org/T106909#1487173 (10GWicke) PR at https://github.com/wikimedia/restbase/pull/285 [01:09:10] 10VisualEditor, 6Editing-Department, 7Blocked-on-Editing: VisualEditor tests fail in target agnostic mode - https://phabricator.wikimedia.org/T107122#1487174 (10Jdlrobson) They seem to be failing due to `Error: Unfinished animations: 1` [01:34:56] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 10VisualEditor-MediaWiki-Media, 10OOjs-UI: Pressing escape twice to cancel out of the link inspector, closes the entire media dialog - https://phabricator.wikimedia.org/T103433#1487207 (10Krenair) Seems to be something to do with the OO.ui.Dialog code. I trie... [01:46:32] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 10VisualEditor-MediaWiki-Media, 10OOjs-UI: Pressing escape twice to cancel out of the link inspector, closes the entire media dialog - https://phabricator.wikimedia.org/T103433#1487224 (10Krenair) Ah. That event is actually attached to the whole document. [03:03:25] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 10VisualEditor-MediaWiki-Media, 10OOjs-UI: Pressing escape twice to cancel out of the link inspector, closes the entire media dialog - https://phabricator.wikimedia.org/T103433#1487309 (10Quiddity) >>! In T103433#1468737, @Jdforrester-WMF wrote: >> In contras... [03:33:27] 10VisualEditor, 6Collaboration-Team, 10Collaboration-Team-Sprint-F-Finishing-Move-2015-08-04, 10Flow: F8. Run LQT conversion script on mediawiki.org VE/Feedback - https://phabricator.wikimedia.org/T106613#1487328 (10Mattflaschen) [07:02:02] 10VisualEditor: Article content put after categories - https://phabricator.wikimedia.org/T107134#1487504 (10NicoV) 3NEW [07:03:53] 10VisualEditor: Article content put after categories - https://phabricator.wikimedia.org/T107134#1487511 (10NicoV) [07:06:25] 10VisualEditor: '' is frequently used unnecessarily in VisualEditor and put in - https://phabricator.wikimedia.org/T106641#1487514 (10NicoV) Since T106997 was merged with this task, I'm adding the request that if the nowiki tags are added, they should be added just around the two apostrophes, not around... [08:28:00] 10VisualEditor, 10Parsoid, 10Parsoid-Nowiki, 10RESTBase: scrubWikitext doesn't reach Parsoid - https://phabricator.wikimedia.org/T106909#1487549 (10mobrovac) >>! In T106909#1487173, @GWicke wrote: > PR at https://github.com/wikimedia/restbase/pull/285 This has been merged (not yet deployed, though). [08:39:17] 10VisualEditor, 10Wikimedia-Site-requests: Enable VisualEditor on Meta-Wiki's Meta namespace - https://phabricator.wikimedia.org/T107003#1487556 (10Glaisher) >>! In T107003#1485679, @Jdforrester-WMF wrote: > We've mostly avoided enabling it in signed namespaces… Meta-Wiki's main namespace is also a signed nam... [09:19:01] 10Citoid, 10VisualEditor, 6Services, 5Patch-For-Review: Trust Zotero results for pubmed central, excepting 501s, in which case use DOI api as fallback - https://phabricator.wikimedia.org/T106044#1487646 (10Mvolz) [09:19:11] 10Citoid, 10VisualEditor, 6Services, 5Patch-For-Review: Trust Zotero results for pubmed central, excepting 501s, in which case use DOI api as fallback - https://phabricator.wikimedia.org/T106044#1457597 (10Mvolz) a:3Mvolz [09:20:59] 10Citoid, 10VisualEditor, 6Services: Trust Zotero results for pubmed central, excepting 501s, in which case use DOI api as fallback - https://phabricator.wikimedia.org/T106044#1457597 (10Mvolz) [09:51:41] 10VisualEditor: Article content put after categories - https://phabricator.wikimedia.org/T107134#1487721 (10Aklapper) > Reported by Kerry Raymond on enwiki: Exact links highly welcome. :) [09:56:35] 10VisualEditor: Article content put after categories - https://phabricator.wikimedia.org/T107134#1487729 (10Esanders) This appears to be a very specific problem, in most cases the categories do remain at the end. Trying to reproduce locally. [09:56:45] 10VisualEditor: Article content sometimes put after categories - https://phabricator.wikimedia.org/T107134#1487730 (10Esanders) [09:57:48] 10TemplateData, 10MediaWiki-extensions-Scribunto: Provide a Lua method mw.loadTemplateData() - https://phabricator.wikimedia.org/T107119#1487731 (10Aklapper) [09:58:43] 10VisualEditor: Article content sometimes put after categories - https://phabricator.wikimedia.org/T107134#1487733 (10NicoV) [10:03:12] 10VisualEditor, 10Parsoid, 10Parsoid-Nowiki, 10RESTBase: scrubWikitext doesn't reach Parsoid - https://phabricator.wikimedia.org/T106909#1487739 (10Esanders) 5Open>3Resolved a:3Esanders [10:06:19] 10Citoid, 10VisualEditor: STICKY: Report failing DOIs or URLs here. - https://phabricator.wikimedia.org/T106201#1487747 (10mobrovac) [10:06:21] 10Citoid, 10VisualEditor, 6Services: DOI redirect handler for iopscience is very slow/ potentially causes citoid to behave oddly. - https://phabricator.wikimedia.org/T106374#1487745 (10mobrovac) 5Open>3Resolved Deployed, resolving. [10:06:36] 10Citoid, 10VisualEditor, 5Patch-For-Review: Citing doi vs link to doi.org gives different results - https://phabricator.wikimedia.org/T106975#1487749 (10mobrovac) 5Open>3Resolved a:3mobrovac Deployed, resolving. [10:07:31] 10Citoid, 10VisualEditor, 5Patch-For-Review: Science direct translator displays unusual behaviour (occasionally gets stuck in redirect loop). - https://phabricator.wikimedia.org/T97042#1487752 (10mobrovac) 5stalled>3Resolved This should be now fixed in the latest deployed version of Citoid, so resolving.... [10:07:57] 10Citoid, 10VisualEditor: Science direct translator displays unusual behaviour (occasionally gets stuck in redirect loop). - https://phabricator.wikimedia.org/T97042#1487756 (10mobrovac) [10:08:02] (03PS1) 10Esanders: Update documentation and code to show that model is optional in ContextItem [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/227434 (https://phabricator.wikimedia.org/T107102) [10:08:17] 10Citoid, 10VisualEditor: STICKY: Report failing DOIs or URLs here. - https://phabricator.wikimedia.org/T106201#1461716 (10mobrovac) [10:08:24] 10Citoid, 10VisualEditor: Doi regex is not detecting http://dx.doi.org/10.14344/IOC.ML.4.4 - https://phabricator.wikimedia.org/T106235#1487767 (10mobrovac) [10:09:06] 10Citoid, 10VisualEditor: Citing doi vs link to doi.org gives different results - https://phabricator.wikimedia.org/T106975#1487769 (10mobrovac) [13:13:01] 10TemplateData: Provide a Lua method mw.loadTemplateData() - https://phabricator.wikimedia.org/T107119#1488015 (10Anomie) [13:13:03] 10TemplateData: Provide a Lua method mw.loadTemplateData() - https://phabricator.wikimedia.org/T107119#1487052 (10Anomie) > but it does not really belong in either of them. Sure it does: it belongs in TemplateData, if reading it from the wikitext really is a problem. Much like how TitleBlacklist, ParserFunction... [15:03:02] 10VisualEditor, 10Parsoid, 10Parsoid-Nowiki, 10RESTBase: scrubWikitext doesn't reach Parsoid - https://phabricator.wikimedia.org/T106909#1488215 (10Jdforrester-WMF) a:5Esanders>3GWicke [15:07:17] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References: When inserting a new automatic citation, offer "Edit" as well as "Insert" button - https://phabricator.wikimedia.org/T107078#1488220 (10GermanJoe) @Jdforrester-WMF I don't understand what you mean by 'they get an "Edit" button immediately)'. User... [15:13:58] 10MediaWiki-extensions-Graph-VE: Weekly reports for "Enable VisualEditor support in Graph extension" - https://phabricator.wikimedia.org/T101119#1488233 (10ferdbold) [15:27:34] What's ve.debounce for? [15:28:21] (I ask because that seems to be where focus is being stolen erroneously [15:47:56] 10VisualEditor: VE focus issues in REL 1_25: Unable to use the Summary and Search box - https://phabricator.wikimedia.org/T106419#1488327 (10Rosencrantz) After poking around in Chrome's debugger I managed to find that ve.debounce seems to be what's changing the focus back to the edit layer. [16:00:07] Rosencrantz: ve.debounce() is a utility function for "do this only once after N ms" [16:00:30] Rosencrantz: In any case, the bug you're talking about sounds a lot like something we fixed a while ago, probably one thing just needs to be backported [16:00:34] I think the bug was in OOUI though [16:03:12] 10MediaWiki-extensions-Graph-VE: Edit a force-directed graph within VisualEditor - https://phabricator.wikimedia.org/T100359#1488364 (10Mvolz) [16:03:13] 10MediaWiki-extensions-Graph-VE: Edit a world map within VisualEditor - https://phabricator.wikimedia.org/T100358#1488365 (10Mvolz) [16:03:17] 10MediaWiki-extensions-Graph-VE, 10VisualEditor, 10Graph, 10Parsoid, and 2 others: Graph editing in VisualEditor - https://phabricator.wikimedia.org/T89287#1488363 (10Mvolz) [16:03:45] 10MediaWiki-extensions-Graph-VE, 10VisualEditor, 10Graph, 10Parsoid, and 2 others: Graph editing in VisualEditor - https://phabricator.wikimedia.org/T89287#1092492 (10Mvolz) Leaving pie chart in as a stretch goal :) [16:04:54] Ahhh. I was wondering about that. So would putting in a different version of OOUI via composer help? Or is it more involved than that? [16:07:48] That will probably just break [16:07:54] But a higher minor version would probably work [16:08:54] That is to say, if the version is uses is 0.X.Y, you can upgrade to 0.X.Z where Z>Y , but you can't upgrade to 0.V.W where V > X [16:08:56] if that makes sense [16:09:03] yep [16:13:42] (03PS11) 10Divec: ve.ce.adjustLinkSelection: fixup link-bisecting selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/222488 [16:16:14] (03CR) 10jenkins-bot: [V: 04-1] ve.ce.adjustLinkSelection: fixup link-bisecting selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/222488 (owner: 10Divec) [16:16:20] (03PS12) 10Divec: ve.ce.adjustLinkSelection: fixup link-bisecting selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/222488 [16:18:42] (03CR) 10jenkins-bot: [V: 04-1] ve.ce.adjustLinkSelection: fixup link-bisecting selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/222488 (owner: 10Divec) [16:20:04] RoanKattouw: Well newer minor versions of oojs-ui don't break anything else, but it doesn't fix it either :/ [16:20:14] :( [16:21:55] 10MediaWiki-extensions-Graph-VE: Edit a force-directed graph within VisualEditor - https://phabricator.wikimedia.org/T100359#1488485 (10ferdbold) p:5Normal>3Low [16:22:00] Hi, I have a question related to VE. I have written a plugin that adds the functionality of adding a SMW annotation. It works mostly except that the undo functionality isn't working, and the 'save' button stays grey when I make some changes to the document model. I think I am missing a line of code maybe. Would be really helpful if someone could point what [16:22:00] could be missing. Here's the code https://en.wikipedia.org/wiki/User:Nischayn22/veSMW.js [16:22:03] 10MediaWiki-extensions-Graph-VE: Edit a world map within VisualEditor - https://phabricator.wikimedia.org/T100358#1488487 (10ferdbold) p:5Normal>3Low [16:22:09] 10MediaWiki-extensions-Graph-VE: Allow stacked bar and area charts - https://phabricator.wikimedia.org/T100356#1488489 (10ferdbold) p:5Normal>3Low [16:23:59] 10MediaWiki-extensions-Graph-VE: Allow stacked bar and area charts - https://phabricator.wikimedia.org/T100356#1310920 (10ferdbold) [16:24:01] 10MediaWiki-extensions-Graph-VE, 10VisualEditor, 10Graph, 10Parsoid, and 2 others: Graph editing in VisualEditor - https://phabricator.wikimedia.org/T89287#1488501 (10ferdbold) [17:23:15] (03PS2) 10Jforrester: ContextItem: Update documentation, code to show that model is optional [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/227434 (https://phabricator.wikimedia.org/T107102) (owner: 10Esanders) [17:23:27] (03CR) 10Jforrester: [C: 032] ContextItem: Update documentation, code to show that model is optional [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/227434 (https://phabricator.wikimedia.org/T107102) (owner: 10Esanders) [17:26:12] (03Merged) 10jenkins-bot: ContextItem: Update documentation, code to show that model is optional [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/227434 (https://phabricator.wikimedia.org/T107102) (owner: 10Esanders) [17:27:51] (03PS1) 10Jforrester: Update VE core submodule to master (cb14f66) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227487 [17:28:11] Krenair: Can you +2 https://gerrit.wikimedia.org/r/227487 right now? Pull-through of a UBN for the cut. [17:29:25] sure [17:29:30] Thanks Krenair. [17:29:43] (03CR) 10Alex Monk: [C: 032] Update VE core submodule to master (cb14f66) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227487 (owner: 10Jforrester) [17:30:45] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-Tables, 5WMF-deploy-2015-07-28_(1.26wmf16): [Regression pre-wmf16] VE crashes when clicking on the Row/Column inserter arrow - https://phabricator.wikimedia.org/T107102#1488694 (10Jdforrester-WMF) 5Open>3Resolved a:3Esanders [17:33:49] (03Merged) 10jenkins-bot: Update VE core submodule to master (cb14f66) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227487 (owner: 10Jforrester) [18:02:00] 10Citoid, 6Services: REGRESSION: polluted error message - https://phabricator.wikimedia.org/T107176#1488820 (10Mvolz) 3NEW [18:07:09] 10Citoid, 6Services: REGRESSION: polluted error message - https://phabricator.wikimedia.org/T107176#1488858 (10Mvolz) 5Open>3Invalid [18:07:39] 10Citoid, 6Services: REGRESSION: polluted error message - https://phabricator.wikimedia.org/T107176#1488820 (10Mvolz) 5Invalid>3Open [18:18:47] (03PS12) 10Jforrester: Allow skin developers to set an offset for toolbar floating [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/203011 (https://phabricator.wikimedia.org/T95528) (owner: 10Florianschmidtwelzow) [18:19:15] (03CR) 10Jforrester: [C: 031] "PS12 is a rebase." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/203011 (https://phabricator.wikimedia.org/T95528) (owner: 10Florianschmidtwelzow) [18:48:58] 10Citoid, 6Services, 5Patch-For-Review: Polluted error message - https://phabricator.wikimedia.org/T107176#1489151 (10Mvolz) [19:07:58] 10VisualEditor, 10Parsoid: Article content sometimes put after categories - https://phabricator.wikimedia.org/T107134#1489262 (10Jdforrester-WMF) p:5Triage>3Low [19:11:13] 10Citoid, 10VisualEditor: Citing Reuters.com gives Reuters as a work, should be agency - https://phabricator.wikimedia.org/T106892#1489284 (10Jdforrester-WMF) p:5Triage>3Low [19:12:49] 10VisualEditor, 10VisualEditor-MediaWiki-Links: "Add label" to an external link only allows me to add one letter - https://phabricator.wikimedia.org/T106875#1489287 (10Jdforrester-WMF) [19:12:50] 10VisualEditor, 10VisualEditor-ContentEditable, 7Epic: Change how link annotations work (and fix link continuation rendering) - https://phabricator.wikimedia.org/T91285#1489288 (10Jdforrester-WMF) [19:13:56] 10VisualEditor: Badly formatted reference in template is not escaped by VE, resulting in completely damaged article - https://phabricator.wikimedia.org/T106795#1489308 (10Jdforrester-WMF) Broken template is broken? What's the action requested here? [19:16:06] 10VisualEditor: '' is frequently used unnecessarily in VisualEditor and put in - https://phabricator.wikimedia.org/T106641#1489316 (10Jdforrester-WMF) p:5Normal>3Lowest [19:16:27] 10VisualEditor, 10VisualEditor-MediaWiki: Focus on the target page name input box automatically after checking "Redirect this page to" - https://phabricator.wikimedia.org/T106616#1489318 (10Jdforrester-WMF) p:5Triage>3Low [19:18:30] 10VisualEditor, 10Parsoid: Decide on a strategy for the special-casing of auto-whitespace in front of colons for French output - https://phabricator.wikimedia.org/T106561#1489325 (10Jdforrester-WMF) [19:24:04] RoanKattouw on that focus thing I just tried merging the REL1_25 and 1.26wmf1 branches, that seems to work, but I'm not sure what else (if anything) that might have broken. [19:24:32] 10VisualEditor, 7JavaScript: "TypeError: this.resizableSurface is null" after an edit using VisualEditor - https://phabricator.wikimedia.org/T105364#1489362 (10Jdforrester-WMF) Still an issue? Gadget issue? [19:24:56] 10VisualEditor, 10MediaWiki-ResourceLoader, 10Wikimedia-General-or-Unknown, 7JavaScript: Catch errors thrown in common.js - https://phabricator.wikimedia.org/T105363#1489364 (10Jdforrester-WMF) [19:25:57] 10VisualEditor, 10VisualEditor-MediaWiki, 7Browser-Support-Firefox: When the user opens VisualEditor from a section link, then scroll to that section upon opening in Firefox - https://phabricator.wikimedia.org/T106557#1489373 (10JAufrecht) Possibly related: {T53998}, {T51563}, {T97789}, {T54577} Master task... [19:29:34] 10VisualEditor, 10OOjs-UI: Disabled bar tools can take focus - https://phabricator.wikimedia.org/T105200#1489399 (10Jdforrester-WMF) p:5Triage>3Normal [19:30:57] 10VisualEditor: What do I do with popup second link popup? - https://phabricator.wikimedia.org/T105206#1489403 (10JAufrecht) Interpretation from Triage meeting: we think this means, doing the normal use case to add a link can confuse some users, because the final state of the editing process leaves a popup dialo... [19:30:58] 10VisualEditor, 10OOjs-UI: Consistent closing of menu items by clicking - https://phabricator.wikimedia.org/T105199#1489404 (10Jdforrester-WMF) [19:32:00] 10VisualEditor: Badly formatted reference in template is not escaped by VE, resulting in completely damaged article - https://phabricator.wikimedia.org/T106795#1489409 (10NicoV) @Jdforrester-WMF Well, it's simple : [[ https://fr.wikipedia.org/w/index.php?title=13e_demi-brigade_de_L%C3%A9gion_%C3%A9trang%C3%A8re... [19:32:16] 10VisualEditor: Ctrl+F steals default Ctrl+F behaviour - https://phabricator.wikimedia.org/T105117#1489410 (10Jdforrester-WMF) 5Open>3declined a:3Jdforrester-WMF [19:35:21] 10VisualEditor: Ctrl+F steals default Ctrl+F behaviour - https://phabricator.wikimedia.org/T105117#1489418 (10Josve05a) I keep having to press 'outside' the editing window to search for specific footnotes, say Ctrl+f: '[23]' . THis is a pain, since I keep forgetting to press outside the editing box to be able to... [19:37:56] Hi, I asked a question previously on this channel, but couldn't get a response yet. Would really appreciate if someone could help. [19:38:02] I am calling surfaceModel.getFragment().annotateContent( 'set', 'link/mwInternal', linkAnnotation ); [19:38:15] But somehow this isn't recorded in the undo stack. [19:39:39] That's weird, that shouldn't happen [19:40:05] nischayn22: I did notice that your script appears to remember the surfaceModel globally in some cases instead of using this.getFragment().getSurface() [19:40:25] So ... maybe if you open VE, then close it, then reopen it, all while staying on the same page, it might break? [19:40:59] But otherwise I see no reason why your global surface variable would !== fragment.getSurfacE() [19:41:36] (You should not have a global surface variable for other reasons, but I don't quite see it causing this breakage directly) [19:41:49] I set the global in onEditButtonClick and then execute the following code: [19:41:50] this.context.getSurface().execute( 'window', 'open', 'smw-property-annotation', null ); [19:41:59] So, I don't think the VE session is different. [19:42:02] nischayn22: Hmm, actually... do you get linkAnnotation from somewhere, then modify it, and apply it back? [19:43:12] Because that might break in certain cases [19:44:13] At one place I am not applying the annotation properly [19:44:30] Since I was not able to get the fragment, instead I am doing this: [19:44:42] https://www.irccloud.com/pastebin/G1CxqAEG/ [19:46:12] That's because of this bug https://phabricator.wikimedia.org/T104580 [19:46:18] I wasn't able to get the fragment. [19:51:54] Whoooa [19:51:58] model.element = linkAnnotation; [19:52:05] That will almost certainly mess things up [19:56:57] Right, I think that's the one. Hopefully the fix will help me eliminate this hack. [19:57:51] Thanks RoanKattouw for all the suggestions, I will try it and keep posted. [19:58:53] (03CR) 10Jforrester: [C: 032] Allow skin developers to set an offset for toolbar floating [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/203011 (https://phabricator.wikimedia.org/T95528) (owner: 10Florianschmidtwelzow) [20:01:59] (03Merged) 10jenkins-bot: Allow skin developers to set an offset for toolbar floating [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/203011 (https://phabricator.wikimedia.org/T95528) (owner: 10Florianschmidtwelzow) [20:03:46] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-Interface, 5Patch-For-Review: ve.ui.Toolbar should have a configurable offset for fixed headers - https://phabricator.wikimedia.org/T95528#1489479 (10Florian) 5Open>3Resolved Thanks @Jdforrester-WMF [20:29:37] I wonder if I should tell James that the huge VisualEditor banner he just placed on the edge of the office window now prevents me from seeing the hunk from the apartment across the street in the morning. [20:29:57] :p [20:30:15] That is probably not office-appropirate and was meant for another channel! [20:30:41] guillom: Send pictures! /me whistles innocent [20:30:47] heh [20:33:27] Josve05a: Here you go: https://dl.dropboxusercontent.com/u/17195534/IMG_2180.JPG [20:33:47] not...of...that... [20:33:49] :-D [20:33:50] :P [20:35:19] Well played, Sir. Well played. [20:36:05] https://phabricator.wikimedia.org/T107197 << related to VE...barely [20:37:18] James_F: ^ That last comment is most likely directed to you [20:50:25] what does TR0: Interrupt stand for ? [21:00:23] 10VisualEditor: cannot edit most of page - https://phabricator.wikimedia.org/T107212#1489777 (10JanZerebecki) 3NEW [21:02:50] 10VisualEditor, 10VisualEditor-ContentEditable: cannot edit most of page - https://phabricator.wikimedia.org/T107212#1489794 (10Josve05a) [21:19:01] 10VisualEditor, 10VisualEditor-ContentEditable: cannot edit most of page - https://phabricator.wikimedia.org/T107212#1489865 (10Catrope) I think this is because `integration/config.git` should end with `` not `` [21:19:27] Tasks that pre-empt all planned work for VE [21:19:39] TR is an abbreviation for "Tranche" [21:19:50] matanya: ^ [21:26:59] 10VisualEditor, 10VisualEditor-ContentEditable: cannot edit most of page with missing closing tt-tag - https://phabricator.wikimedia.org/T107212#1489881 (10JanZerebecki) 5Open>3Resolved [21:27:13] 10VisualEditor, 10VisualEditor-ContentEditable: cannot edit most of page with missing closing tt-tag - https://phabricator.wikimedia.org/T107212#1489777 (10JanZerebecki) Thx that was the problem. [21:42:41] hm, ryasmeen you around? [21:42:55] are you back yet on firm San Franciscan ground? [21:42:55] 10VisualEditor: Badly formatted reference in template is not escaped by VE, resulting in completely damaged article - https://phabricator.wikimedia.org/T106795#1489894 (10Whatamidoing-WMF) I had checked adding the citation in regular article text, and it was obvious that it didn't look normal. I just checked as... [21:45:32] mooeypoo: She was in the office yesterday! [21:45:54] RoanKattouw, ooh! welcome back to her, yay [21:46:01] okay, I need a VE victim, then [21:46:04] VEctim? [21:46:26] anywyas, there's a bug reported in hewiki that I can't reproduce, and neither can Amir, *but* it is a horrific bug that may be worth forcing the issue for? [21:46:40] Apparently WFH today and I'm not surprised given how late our group finished dinner last night [21:46:51] do I just report and see if ryasmeen manages to coax it out, or ... [21:46:57] That works [21:47:11] Someone complaind it erased a huge edit [21:47:23] ok, I'll do that. I can't reproduce for now, but if anyone can, she can [21:47:42] Yeah [21:48:14] Her mere presence causes bugs to reveal themselves [21:48:23] indeed [21:48:23] Unfortunately that also applies to airlines apparently :S [21:48:28] hahaha [21:48:33] and the state department [21:48:36] Yup [21:48:53] Are we saying she has a buggy aura? [21:49:26] No, no, she controls bugs, like Mila Kunis's character in Jupiter Ascending ;) [21:49:39] (OK those were bees but still) [21:49:54] mooeypoo: I think I have idea how to reproduce [21:50:16] use backspace for do "back" in the settings page [21:51:29] (the "are you sure" dialog appears only when pressing back in the article, but not in page settings) [21:51:43] siiiigh [21:51:49] So Ed's change (which I +2ed) broke LinkCache completely [21:51:55] 10VisualEditor, 10VisualEditor-MediaWiki-References: Make a better keyboard shortcut for adding a citation - https://phabricator.wikimedia.org/T99299#1489916 (10Whatamidoing-WMF) I guess that this is the next question: Can we use whatever modifier keys are normal for the browser/OS + r? Or should we do some... [21:51:56] All of ApiResultCache really [21:55:31] James_F|Away: Did you know that redlink rendering is broken in VE in wmf16? Same bug as the Flow bug I'm working on [21:55:38] Hey mooeypoo!! :D [21:55:52] yes I am back, missed you yesterdat at office :) [21:56:11] I can try reproducing the bug..have you reported it already? [21:56:48] 10VisualEditor, 10VisualEditor-EditingTools, 7Design: VisualEditor: Allow the user to edit categories at the bottom of the page, similar to HotCat - https://phabricator.wikimedia.org/T52239#1489926 (10Whatamidoing-WMF) This has been discussed several times on wiki, and none of the experienced editors have me... [21:57:18] Or... wait, not quite [21:57:31] There's probably a broken edge case with oldids though [21:59:37] I think our SyntaxHighlight integration is broken [22:00:07] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Support editing {{int:name}} blocks - https://phabricator.wikimedia.org/T67644#1489928 (10Whatamidoing-WMF) It is still not possible to edit them, e.g., to fix a typo. You have to delete them and re-create them. This is perhaps not surprising, since... [22:00:37] Krenair: How? [22:00:42] I discovered it today [22:00:48] The "show line numbers" check box is nifty :) [22:01:13] OK, so red links are only very slightly broken [22:01:20] But I should fix this LinkCache/ApiResponseCache bug [22:01:25] I haven't figured it out yet. For some reason the languages don't load sometimews [22:01:27] sometimes* [22:08:09] Seems to be caused by debug=true [22:08:15] Bugs caused by debug, yay... [22:09:49] Krinkle, ResourceLoaderGeSHiVisualEditorModule [22:10:11] /w/load.php?modules=ext.geshi.visualEditor&debug=false makes it call addLanguage with the list [22:10:31] (03PS1) 10Catrope: Follow-up 8250c8ad54: unbreak ApiResponseCache [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227589 (https://phabricator.wikimedia.org/T107212) [22:10:38] Krenair: edsanders|away ---^^ [22:10:43] but debug=true... and it simply doesn't [22:10:47] wmf16 regression [22:11:32] (03CR) 10Alex Monk: [C: 032] Follow-up 8250c8ad54: unbreak ApiResponseCache [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227589 (https://phabricator.wikimedia.org/T107212) (owner: 10Catrope) [22:11:44] (03PS1) 10Alex Monk: Follow-up 8250c8ad54: unbreak ApiResponseCache [extensions/VisualEditor] (wmf/1.26wmf16) - 10https://gerrit.wikimedia.org/r/227590 (https://phabricator.wikimedia.org/T107212) [22:11:48] Thanks man [22:12:15] RoanKattouw, any thoughts re. RL modules and debug=true? [22:12:30] I think I can guess why that might happen [22:12:40] Perhaps that geshi module extends FileModule [22:12:45] it does [22:13:17] Right [22:13:40] FileModules are URLable and this subclass injects extra JS, but that breaks its URLability [22:13:45] Unless it pulls some rabbits out of a hat [22:15:34] 10VisualEditor, 10Parsoid, 10Parsoid-Nowiki, 5Patch-For-Review: nowiki is added when adding spaces after a single line break - https://phabricator.wikimedia.org/T104554#1489965 (10Arlolra) 5Open>3Resolved To be deployed tomorrow. [22:15:40] In Chrome Sources tab, is there a search option that search in all the loaded scripts (similar to firebug?)? [22:16:02] I always find it annoying to locate the specific script :) [22:16:14] eranroz: I think Ctrl+Shift+F might work [22:16:33] RoanKattouw: thanks! [22:17:58] RoanKattouw, what if we separated this into it's own module definition and made it non-urlable? [22:18:05] or is there a better way? [22:18:33] If you made that languages thing into its own module that wasn't a FileModule subclass, it would probably just work automatically [22:18:55] 10VisualEditor: Adding categories and sorting potentially results in losing edit data - https://phabricator.wikimedia.org/T107219#1489968 (10Mooeypoo) 3NEW [22:19:23] mooeypoo: Did the user save their edit or not? [22:19:29] (i.e. can we see a diff in the history) [22:19:34] James_F, ^^ I could not reproduce this, and neither could aharoni, but the bug is potentially horrific so it might be worth double checking? [22:19:39] RoanKattouw, yes, in Wikitext. [22:19:49] he lost all data and got really frustrated [22:19:52] mooeypoo: I think he just did backspace and navigated to the previous page [22:19:59] RoanKattouw, https://gerrit.wikimedia.org/r/#/c/220646/2/ResourceLoaderGeSHiVisualEditorModule.php [22:20:06] the are you sure dialog isn't shown when you do it from page settings [22:20:07] eranroz, he did *after* he lost the data, according to the report [22:20:10] OK but so that means there's no entry in any page history anywhere where we could see this happen? [22:20:21] RoanKattouw, no :\ [22:20:29] [15:20] eranroz the are you sure dialog isn't shown when you do it from page settings [22:20:31] Wait, what, really? [22:20:38] I guess I understand why that happens, but that sounds like a bug [22:20:57] Krinkle, you around? [22:20:59] Krenair: lol, well, whoops [22:21:25] RoanKattouw, https://he.wikipedia.org/wiki/%D7%95%D7%99%D7%A7%D7%99%D7%A4%D7%93%D7%99%D7%94:%D7%A2%D7%95%D7%A8%D7%9A_%D7%97%D7%96%D7%95%D7%AA%D7%99/%D7%9E%D7%A9%D7%95%D7%91#.D7.94.D7.AA.D7.A0.D7.94.D7.92.D7.95.D7.AA_.D7.9E.D7.A2.D7.A6.D7.91.D7.A0.D7.AA_.D7.91.D7.94.D7.95.D7.A1.D7.A4.D7.AA_.D7.9E.D7.99.D7.95.D7.9F_.D7.9C.D7.A7.D7.98.D7.92.D7.95.D7.A8.D7.99.D7.94 [22:21:26] i pressed backspace in the page settings and was got out of edit, so it should be pontential similar bug [22:21:29] RoanKattouw, this is his WIKITEXT edit [22:21:43] his step 7 and 8 are the frustrated "drink water and relax / edit again in Wikitext" [22:21:45] (03Merged) 10jenkins-bot: Follow-up 8250c8ad54: unbreak ApiResponseCache [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227589 (https://phabricator.wikimedia.org/T107212) (owner: 10Catrope) [22:22:25] RoanKattouw, he also added the unfortunate "fool me once shame on you, fool be twice, shame on me" :( [22:22:48] eranroz, oh, wow, okay, that may explain it [22:22:53] eranroz, can you add it to the bug? [22:23:00] eranroz: Had you modified the page before that? (Outside of the dialog) [22:23:47] I just tried that and got the "are you sure" dialog [22:24:36] RoanKattouw & mooeypoo : yes, but only in FF [22:24:40] in chrome it works [22:24:43] *sigh* [22:24:44] Of course [22:24:46] interesting [22:24:54] Story of our lives [22:24:57] the user reported this in chrome, so potentially there's another bug [22:25:15] Well, if he got an empty page, then he may have just clicked through the data loss warning [22:25:18] i suggest history.push when opening dialogs :) [22:25:26] Ooh that's not a bad idea [22:25:47] James_F: [15:25] eranroz i suggest history.push when opening dialogs [22:25:55] James_F: So the back button would close the dialog, not exit VE [22:26:07] Eww. [22:26:10] RoanKattouw, he didn't get an empty page, he got the view page [22:26:18] wat [22:26:25] By ... doing what? [22:26:30] Clicking back? Pressing backspace? [22:26:31] According to him, nothing. [22:26:40] No, just hitting "Enter" in the sort category inspector [22:26:49] (Of course there could be more than that, but that's strictly what he reported) [22:27:11] It sounds vaguely back-button-y [22:27:23] According to him, he hit "enter" in the sorting popup of the category, and poof = he's in view mode. He tried to go "Back" a couple fo times to save his edit and failed. [22:27:24] Maybe he pressed backspace while no input was focused [22:27:36] Oh, hah [22:27:56] RoanKattouw, yeah, maybe, though I tried to do the same (including hitting 'back' when nothing is focused) but got "Are you sure...." dialog [22:28:05] MAYBE he hit back and THEN enter, not noticing? [22:28:22] in any case, might be worth forcing the reproduction of this.. :\ [22:29:19] RoanKattouw, actually I'm not sure that revert fixed anything [22:29:43] bah, broken for a different reason [22:31:32] Krenair: RoanKattouw: To make the subclass not urlable, call the base class method from the subclass for geturls [22:32:13] Krenair: RoanKattouw: function getScriptURLsForDebug, return RLModule:;getScriptURLsForDebug( .. ); [22:32:18] Mobile does the same [22:36:27] 10VisualEditor, 10VisualEditor-EditingTools, 7Design: VisualEditor: Allow the user to edit categories at the bottom of the page, similar to HotCat - https://phabricator.wikimedia.org/T52239#1490055 (10Qgil) Just reinforcing @whatamidoing-wmf's point. This is one of those features where some user feedback wou... [22:37:39] Krinkle, but don't we want the scripts in this module to be included by full url? [22:37:47] Yes, we do [22:37:57] otherwise it'll be invalid [22:38:06] Debugging raw files isn't possible and it doesn't matter anyway [22:38:08] raw files suck [22:38:20] so it still needs to be urlable [22:38:35] Everything will be urlable, always is [22:38:40] tis' only a matter of how [22:38:51] whether references to raw files, or to individual load.php urls [22:39:02] the latter is the default and what we need here [22:39:06] fileModule overrides it [22:40:23] aren't I going to trigger warnings about calling non-static methods statically? [23:03:31] (03CR) 10Alex Monk: [C: 032] Follow-up 8250c8ad54: unbreak ApiResponseCache [extensions/VisualEditor] (wmf/1.26wmf16) - 10https://gerrit.wikimedia.org/r/227590 (https://phabricator.wikimedia.org/T107212) (owner: 10Alex Monk) [23:04:43] 10VisualEditor: [Regression wmf 16] Cannot switch to wikitext editor from VE - https://phabricator.wikimedia.org/T107225#1490112 (10Ryasmeen) 3NEW [23:06:07] 10VisualEditor: [Regression wmf 16] Cannot switch to wikitext editor from VE - https://phabricator.wikimedia.org/T107225#1490120 (10Jdforrester-WMF) Which wiki? Working fine on enwiki Beta Cluster and on MW.org. [23:06:15] 10VisualEditor: [Regression wmf 16] Cannot switch to wikitext editor from VE - https://phabricator.wikimedia.org/T107225#1490122 (10Catrope) What's the error message? Or what's the line the debugger freezes on? It's not visible in the screenshot [23:06:29] (03Merged) 10jenkins-bot: Follow-up 8250c8ad54: unbreak ApiResponseCache [extensions/VisualEditor] (wmf/1.26wmf16) - 10https://gerrit.wikimedia.org/r/227590 (https://phabricator.wikimedia.org/T107212) (owner: 10Alex Monk) [23:08:56] 10VisualEditor, 10VisualEditor-MediaWiki-References: Make a better keyboard shortcut for adding a citation - https://phabricator.wikimedia.org/T99299#1490134 (10matmarex) No, they're awkward. We should stick to what we were doing so far: either Ctrl+X or Ctrl+Shift+X (Cmd+X or Cmd+Shift+X on Mac OS). [23:12:23] 10VisualEditor: [Regression wmf 16] Cannot switch to wikitext editor from VE - https://phabricator.wikimedia.org/T107225#1490148 (10Ryasmeen) I am getting it on Beta-Cluster not on test2 or mw.org [23:13:14] 10VisualEditor, 6Phabricator, 10Phabricator-Sprint-Extension: Sprint extension doesn't scale to thousands of tasks in a single sprint: burndown page exceeds max execution timeout on visual editor project - https://phabricator.wikimedia.org/T107197#1490156 (10Josve05a) [23:15:54] 10VisualEditor, 6Phabricator, 6operations: Unable to load https://phabricator.wikimedia.org/tag/visualeditor/ - https://phabricator.wikimedia.org/T107229#1490160 (10Josve05a) 3NEW [23:16:20] 10VisualEditor: [Regression wmf 16] Cannot switch to wikitext editor from VE - https://phabricator.wikimedia.org/T107225#1490169 (10Ryasmeen) Ok, not getting the issue anymore. [23:22:07] (03PS1) 10Jforrester: Update OOjs UI to v0.12.2 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/227610 [23:25:10] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.12.2 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/227610 (owner: 10Jforrester) [23:28:10] (03Merged) 10jenkins-bot: Update OOjs UI to v0.12.2 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/227610 (owner: 10Jforrester) [23:49:57] 10VisualEditor, 10VisualEditor-MediaWiki: Trigger spam blacklist upon opening a page in VisualEditor - https://phabricator.wikimedia.org/T99803#1490255 (10Krenair) Yeah, okay. I can see how this affects VE much more than wikitext editors. I wonder if we can do something more helpful involving highlighting link... [23:56:53] 10VisualEditor, 6WMF-Design-Research, 7Epic: Improve and streamline VisualEditor's user education features - https://phabricator.wikimedia.org/T101481#1490263 (10Neil_P._Quinn_WMF) [23:56:55] 10VisualEditor, 10WikiEditor, 6WMF-Design-Research, 7Easy, 5Patch-For-Review: Tooltip text on the "Edit" and "Edit Source" tabs should be more helpful to new users - https://phabricator.wikimedia.org/T99271#1490261 (10Neil_P._Quinn_WMF) 5Resolved>3Open Both tooltips currently display as "edit this pa...