[00:08:11] 10VisualEditor, 6Phabricator, 6operations: Unable to load https://phabricator.wikimedia.org/tag/visualeditor/ - https://phabricator.wikimedia.org/T107229#1490292 (10Christopher) It seems that https://phabricator.wikimedia.org/project/view/483/ loads, so this is sprint extension related. [00:12:58] 10VisualEditor, 6Phabricator, 6operations: Unable to load https://phabricator.wikimedia.org/tag/visualeditor/ - https://phabricator.wikimedia.org/T107229#1490294 (10Jdforrester-WMF) > Related to {T107197} Duplicate of… [00:19:00] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-extensions-FlaggedRevs: Flagged Revisions doesn't mark as reviewed the latest version after Visual Editor edit - https://phabricator.wikimedia.org/T75171#1490300 (10Krenair) We're not updating the oldid in the FlaggedRevs page review form when we update t... [00:24:25] ugh [00:24:29] that FR form uses action=ajax [00:24:32] 10VisualEditor, 6Phabricator, 6operations: Unable to load https://phabricator.wikimedia.org/tag/visualeditor/ - https://phabricator.wikimedia.org/T107229#1490309 (10Josve05a) >>! In T107229#1490294, @Jdforrester-WMF wrote: > Duplicate of… Feel free to merge. I wasn't sure if related. [00:27:44] "Invalid inclusion parameter key" what [00:30:17] 10VisualEditor, 6Phabricator, 6operations: Unable to load https://phabricator.wikimedia.org/tag/visualeditor/ - https://phabricator.wikimedia.org/T107229#1490329 (10Christopher) debug tick is also set for 15 seconds, meaning that a possible full load time window of 30 seconds is never reached. @mmodell? [00:33:37] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-extensions-FlaggedRevs: Flagged Revisions doesn't mark as reviewed the latest version after Visual Editor edit - https://phabricator.wikimedia.org/T75171#1490341 (10Krenair) But if you try to change it, you get "Invalid inclusion parameter key". That key... [00:39:07] (03CR) 10Jforrester: [C: 032] Close the wikitext switch confirmation dialog if serialisation errors [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/226974 (https://phabricator.wikimedia.org/T103632) (owner: 10Alex Monk) [00:39:47] 10VisualEditor, 10VisualEditor-MediaWiki: If you encounter an error while trying to convert to source editing, the conversion dialogue gets stuck working and is not obviously closable - https://phabricator.wikimedia.org/T103632#1490362 (10Jdforrester-WMF) 5Open>3Resolved p:5Triage>3Normal [00:41:27] (03Merged) 10jenkins-bot: Close the wikitext switch confirmation dialog if serialisation errors [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/226974 (https://phabricator.wikimedia.org/T103632) (owner: 10Alex Monk) [00:51:21] 10VisualEditor, 6Phabricator, 6operations: Unable to load https://phabricator.wikimedia.org/tag/visualeditor/ - https://phabricator.wikimedia.org/T107229#1490375 (10mmodell) @christopher I turned the debug time back to 0 [01:02:06] 10VisualEditor, 6Phabricator, 6operations: Unable to load https://phabricator.wikimedia.org/tag/visualeditor/ - https://phabricator.wikimedia.org/T107229#1490391 (10Jdforrester-WMF) [01:02:09] 10VisualEditor, 6Phabricator, 10Phabricator-Sprint-Extension: Sprint extension doesn't scale to thousands of tasks in a single sprint: burndown page exceeds max execution timeout on visual editor project - https://phabricator.wikimedia.org/T107197#1490392 (10Jdforrester-WMF) [02:06:58] 10VisualEditor, 10MediaWiki-ResourceLoader, 10Wikimedia-General-or-Unknown, 7JavaScript: Catch errors thrown in common.js - https://phabricator.wikimedia.org/T105363#1490475 (10Krinkle) 5Open>3declined a:3Krinkle The site module has always been its own HTTP request (dedicated script tag) for legacy r... [02:22:37] 10VisualEditor, 10MediaWiki-ResourceLoader, 10Wikimedia-General-or-Unknown, 7JavaScript: Catch errors thrown in site module (MediaWiki:Common.js, etc.) - https://phabricator.wikimedia.org/T105363#1490497 (10Legoktm) [04:29:20] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-Tables, 7Verified-in-Phase0, 5WMF-deploy-2015-07-28_(1.26wmf16): [Regression pre-wmf16] VE crashes when clicking on the Row/Column inserter arrow - https://phabricator.wikimedia.org/T107102#1490635 (10Ryasmeen) [04:29:42] 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 5Patch-For-Review, 7Verified-in-Phase0, and 2 others: [Regression wmf15] Unable to add parameters to templates - https://phabricator.wikimedia.org/T106696#1490636 (10Ryasmeen) [04:30:57] 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 5Patch-For-Review, 7Verified-in-Phase0, and 3 others: [Regression wmf15] Unable to add parameters to templates - https://phabricator.wikimedia.org/T106696#1475319 (10Ryasmeen) [04:32:38] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 7Verified-in-Phase0, 7Verified-in-Phase2, and 3 others: Link editor can't be closed - https://phabricator.wikimedia.org/T106270#1490641 (10Ryasmeen) [04:32:59] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Links, 7Verified-in-Phase0, 5WMF-deploy-2015-07-28_(1.26wmf16): Regression: Link context not showing images - https://phabricator.wikimedia.org/T106819#1490642 (10Ryasmeen) [04:33:21] 10VisualEditor, 10VisualEditor-EditingTools, 7Verified-in-Phase0, 5WMF-deploy-2015-07-28_(1.26wmf16): Make the comment icon in the toolbar menu match the exclamation mark one used in the surface - https://phabricator.wikimedia.org/T94479#1490643 (10Ryasmeen) [04:33:40] 10VisualEditor, 10VisualEditor-MediaWiki, 7Verified-in-Phase0, 5WMF-deploy-2015-07-28_(1.26wmf16): "Review your changes" dialog should have a save button - https://phabricator.wikimedia.org/T69868#1490644 (10Ryasmeen) [05:30:52] 10VisualEditor, 10VisualEditor-MediaWiki, 7Regression: "Save page" in "Review your changes" panel doesn't work correctly when edit summary is required - https://phabricator.wikimedia.org/T107251#1490688 (10Krinkle) 3NEW [05:33:00] 10VisualEditor, 7Regression: [Regression 1.26wmf16] "Save page" in "Review your changes" panel doesn't work correctly when edit summary is required - https://phabricator.wikimedia.org/T107251#1490701 (10Krinkle) [05:33:31] 10VisualEditor, 10VisualEditor-MediaWiki, 7Regression: [Regression 1.26wmf16] "Save page" in "Review your changes" panel doesn't work correctly when edit summary is required - https://phabricator.wikimedia.org/T107251#1490688 (10Krinkle) [06:03:58] 10VisualEditor, 6Collaboration-Team, 10Collaboration-Team-Sprint-F-Finishing-Move-2015-08-04, 10Flow: F8. Run LQT conversion script on mediawiki.org VE/Feedback - https://phabricator.wikimedia.org/T106613#1490749 (10Mattflaschen) [06:04:09] 10VisualEditor, 6Collaboration-Team, 10Collaboration-Team-Sprint-F-Finishing-Move-2015-08-04, 10Flow: F8. Run LQT conversion script on mediawiki.org VE/Feedback - https://phabricator.wikimedia.org/T106613#1472870 (10Mattflaschen) Removed blocker since the workaround is sufficient for now. [08:50:32] 10VisualEditor, 10VisualEditor-EditingTools, 7Design: VisualEditor: Allow the user to edit categories at the bottom of the page, similar to HotCat - https://phabricator.wikimedia.org/T52239#1490877 (10Ricordisamoa) How about extracting the categories editor and making it a beta feature as "HotCatoid"? [09:22:09] 10Cite, 10MediaWiki-Categories: Automatically categorize articles with named references without text - https://phabricator.wikimedia.org/T107263#1490962 (10NicoV) 3NEW [09:23:33] 10Cite, 10MediaWiki-Categories: Automatically categorize articles with named references without text - https://phabricator.wikimedia.org/T107263#1490969 (10NicoV) [09:27:52] 10Cite, 10MediaWiki-Categories: Automatically categorize articles with named references without text - https://phabricator.wikimedia.org/T107263#1490973 (10NicoV) Related to T104792 Probably it's better to have different tracking categories for different problems ? Or maybe make it configurable per wiki ? [10:08:50] (03PS1) 10Esanders: Placeholder CSS fixes for skins [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227671 [10:14:00] (03PS1) 10Esanders: Replace placeholder color with opacity [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/227675 [10:43:15] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Reading-Web, 7Technical-Debt, 7Tracking: Move VisualEditor code from MobileFrontend to VisualEditor - https://phabricator.wikimedia.org/T96186#1491170 (10Jhernandez) [10:43:17] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Reading-Web: Inspector titles clipped in VisualEditor on mobile - https://phabricator.wikimedia.org/T85068#1491171 (10Jhernandez) [12:51:29] 10VisualEditor, 10VisualEditor-ContentEditable: Changing the second word in bold sequence unbolds the previous word - https://phabricator.wikimedia.org/T99487#1491388 (10Esanders) a:3dchan [12:53:24] 10VisualEditor, 10VisualEditor-Tables: Do not allow editors to add empty spaces or blank lines in table cells - https://phabricator.wikimedia.org/T107076#1491390 (10Esanders) "Spaces at the beginning of lines" is caused by our whitespace preservation algorithm. This is necessary to prevent dirty diffs elsewher... [13:17:03] 10VisualEditor, 10VisualEditor-MediaWiki: Use lib/ve/build/modules.json to build extension.json - https://phabricator.wikimedia.org/T107283#1491458 (10Esanders) 3NEW [13:30:19] 10VisualEditor, 10VisualEditor-Tables: Do not allow editors to add empty spaces or blank lines in table cells - https://phabricator.wikimedia.org/T107076#1491483 (10NicoV) >>! In T107076#1491390, @Esanders wrote: > "Spaces at the beginning of lines" is caused by our whitespace preservation algorithm. This is n... [13:33:11] (03PS1) 10Esanders: [BREAKING CHANGE] Mobile improvements [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227699 [14:05:03] (03PS1) 10Esanders: Rename (View|Mobile)PageTarget to (Desktop|Mobile)ArticleTarget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227706 [14:05:05] (03PS1) 10Esanders: Replace ve-init-mw-desktopArticleTarget-* with ve-init-mw-target-* [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227707 [14:05:07] (03PS1) 10Esanders: Rename pageTarget to target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227708 [14:08:08] (03CR) 10jenkins-bot: [V: 04-1] Replace ve-init-mw-desktopArticleTarget-* with ve-init-mw-target-* [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227707 (owner: 10Esanders) [14:08:28] (03CR) 10jenkins-bot: [V: 04-1] Rename (View|Mobile)PageTarget to (Desktop|Mobile)ArticleTarget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227706 (owner: 10Esanders) [14:10:10] (03CR) 10jenkins-bot: [V: 04-1] Rename pageTarget to target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227708 (owner: 10Esanders) [14:24:18] (03CR) 10Esanders: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227706 (owner: 10Esanders) [15:03:09] 10VisualEditor, 7JavaScript: "TypeError: this.resizableSurface is null" after an edit using VisualEditor - https://phabricator.wikimedia.org/T105364#1491711 (10He7d3r) 5Open>3Resolved a:3He7d3r I was not able to reproduce it on https://pt.wikipedia.org/w/index.php?diff=42987197 https://pt.wikipedia.org/w... [15:18:47] edsanders: Nice series of patches there. :-) [15:48:39] (03CR) 10Jforrester: [C: 031] "Fine by me, but given this feature is only actually used in Flow I guess they should weigh in." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/227675 (owner: 10Esanders) [15:48:55] rebasing into a sensible order [15:53:35] (03PS2) 10Esanders: [BREAKING CHANGE] Mobile improvements [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227699 [15:53:37] (03PS2) 10Esanders: Replace ve-init-mw-desktopArticleTarget-* with ve-init-mw-target-* [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227707 [15:53:39] (03PS2) 10Esanders: [BREAKING CHANGE] Rename (View|Mobile)PageTarget to (Desktop|Mobile)ArticleTarget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227706 [15:53:41] (03PS2) 10Esanders: Rename pageTarget to target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227708 [15:54:54] (03PS1) 10Esanders: Support other types of 'empty' document placeholders [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/227736 (https://phabricator.wikimedia.org/T106582) [15:56:16] (03CR) 10Esanders: "This should result in roughly the same colour, but it is required to make the next commit work as sets the font colour in some themes" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/227675 (owner: 10Esanders) [15:56:22] (03CR) 10Jforrester: [C: 04-1] "My previous comment should have been a -1, I guess." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/211101 (owner: 10Esanders) [15:56:24] (03CR) 10jenkins-bot: [V: 04-1] Replace ve-init-mw-desktopArticleTarget-* with ve-init-mw-target-* [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227707 (owner: 10Esanders) [15:56:39] (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Rename (View|Mobile)PageTarget to (Desktop|Mobile)ArticleTarget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227706 (owner: 10Esanders) [15:57:03] (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Mobile improvements [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227699 (owner: 10Esanders) [16:00:53] (03CR) 10jenkins-bot: [V: 04-1] Rename pageTarget to target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227708 (owner: 10Esanders) [16:13:07] (03PS3) 10Esanders: [BREAKING CHANGE] Bring in some code from MobileFrontend [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227699 (https://phabricator.wikimedia.org/T96186) [16:13:09] (03PS1) 10Esanders: Collapse text style buttons in mobile [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227742 (https://phabricator.wikimedia.org/T93325) [16:14:58] 10Citoid, 6Services, 6operations: Package and test Zotero for Jessie - https://phabricator.wikimedia.org/T107302#1491929 (10mobrovac) 3NEW [16:17:06] (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Bring in some code from MobileFrontend [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227699 (https://phabricator.wikimedia.org/T96186) (owner: 10Esanders) [16:17:08] (03CR) 10jenkins-bot: [V: 04-1] Collapse text style buttons in mobile [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227742 (https://phabricator.wikimedia.org/T93325) (owner: 10Esanders) [16:18:32] 10Cite, 10MediaWiki-extensions-ContentTranslation, 5ContentTranslation-Release6: ContentTranslation created a reference that renders as UNIQ--nowiki-00000007-QINU at [[Google Cardboard]] in he.wikipedia - https://phabricator.wikimedia.org/T107303#1491939 (10Amire80) 3NEW [16:21:31] 10Citoid, 6Services: Test Citoid on Jessie - https://phabricator.wikimedia.org/T107304#1491946 (10mobrovac) 3NEW [16:40:14] (03PS1) 10Esanders: Disable scroll animation when running tests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227745 (https://phabricator.wikimedia.org/T107122) [16:45:03] (03PS2) 10Esanders: Abort scroll animations on teardown [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227745 (https://phabricator.wikimedia.org/T107122) [16:48:54] (03PS1) 10Alex Monk: When saving from review screen, swap to main save screen [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227747 (https://phabricator.wikimedia.org/T107251) [16:49:06] 10VisualEditor, 10VisualEditor-MediaWiki, 5Patch-For-Review, 7Regression: [Regression 1.26wmf16] "Save page" in "Review your changes" panel doesn't work correctly when edit summary is required - https://phabricator.wikimedia.org/T107251#1492081 (10Krenair) a:3Krenair [16:53:31] (03CR) 10Esanders: [C: 04-1] Abort scroll animations on teardown [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227745 (https://phabricator.wikimedia.org/T107122) (owner: 10Esanders) [16:55:14] (03PS2) 10Alex Monk: Support other types of 'empty' document placeholders [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/227736 (https://phabricator.wikimedia.org/T106582) (owner: 10Esanders) [16:57:50] (03PS1) 10Esanders: Make scrollIntoView a VE utility function [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/227751 (https://phabricator.wikimedia.org/T107122) [16:58:24] (03Abandoned) 10Esanders: Abort scroll animations on teardown [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227745 (https://phabricator.wikimedia.org/T107122) (owner: 10Esanders) [16:59:14] (03CR) 10jenkins-bot: [V: 04-1] Support other types of 'empty' document placeholders [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/227736 (https://phabricator.wikimedia.org/T106582) (owner: 10Esanders) [16:59:24] do we know why the hhvm task is failing here: https://gerrit.wikimedia.org/r/#/c/227706/ [16:59:56] edsanders: "The module 'ext.visualEditor.mobileViewTarget' required by 'mobile.editor.ve' must exist" [17:00:23] edsanders: I.e., that change breaks MF and because VE and MF are tested together… [17:00:29] that's stupid [17:00:33] Yup. [17:00:42] Do a commit in MF that works with either name. [17:00:47] Then do the breaking change in VE [17:00:51] ffs [17:00:53] Then remove the old-style support from MF. [17:00:57] um, how? [17:01:07] I don't know. [17:01:28] standup [17:01:34] I can't. [17:01:37] Room stolen. [17:01:39] Trying to fix. [17:01:45] But some idiot is talking to me here instead. :-) [17:02:20] (03CR) 10jenkins-bot: [V: 04-1] Make scrollIntoView a VE utility function [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/227751 (https://phabricator.wikimedia.org/T107122) (owner: 10Esanders) [17:08:51] hey werdna [17:09:32] edsanders, is there any way to get just a document with just an empty

from wikitext? [17:10:08] Krenair, not from wikitext is the current config, probably [17:10:45] but the core editor, or a different mw integration (e.g. flow) might want to do something different [17:11:03] we populate empty documents with

but that could be changed... [17:15:16] edsanders, actually you can just use

directly, interesting [17:15:29] I kind of assumed we limited you to the normal wikitext syntax.. [17:16:05] (03PS4) 10Esanders: [BREAKING CHANGE] Bring in some code from MobileFrontend [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227699 (https://phabricator.wikimedia.org/T96186) [17:16:07] (03PS3) 10Esanders: Replace ve-init-mw-desktopArticleTarget-* with ve-init-mw-target-* [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227707 [17:16:09] (03PS3) 10Esanders: [BREAKING CHANGE] Rename (View|Mobile)PageTarget to (Desktop|Mobile)ArticleTarget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227706 [17:16:11] (03PS3) 10Esanders: Rename pageTarget to target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227708 [17:17:58] (03CR) 10Alex Monk: [C: 032] Support other types of 'empty' document placeholders [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/227736 (https://phabricator.wikimedia.org/T106582) (owner: 10Esanders) [17:18:49] (03CR) 10jenkins-bot: [V: 04-1] Replace ve-init-mw-desktopArticleTarget-* with ve-init-mw-target-* [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227707 (owner: 10Esanders) [17:19:04] (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Bring in some code from MobileFrontend [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227699 (https://phabricator.wikimedia.org/T96186) (owner: 10Esanders) [17:19:12] (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Rename (View|Mobile)PageTarget to (Desktop|Mobile)ArticleTarget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227706 (owner: 10Esanders) [17:20:39] (03CR) 10jenkins-bot: [V: 04-1] Rename pageTarget to target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227708 (owner: 10Esanders) [17:22:22] James_F, I added an alias target - where we you seeing the error, https://integration.wikimedia.org/ci/job/mediawiki-extensions-hhvm/25302/console ? [17:22:51] ugh, full log [17:24:48] (03PS5) 10Esanders: [BREAKING CHANGE] Bring in some code from MobileFrontend [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227699 (https://phabricator.wikimedia.org/T96186) [17:24:50] (03PS4) 10Esanders: Replace ve-init-mw-desktopArticleTarget-* with ve-init-mw-target-* [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227707 [17:24:52] (03PS4) 10Esanders: [BREAKING CHANGE] Rename (View|Mobile)PageTarget to (Desktop|Mobile)ArticleTarget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227706 [17:24:54] (03PS4) 10Esanders: Rename pageTarget to target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227708 [17:24:56] (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Bring in some code from MobileFrontend [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227699 (https://phabricator.wikimedia.org/T96186) (owner: 10Esanders) [17:24:58] (03CR) 10jenkins-bot: [V: 04-1] Replace ve-init-mw-desktopArticleTarget-* with ve-init-mw-target-* [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227707 (owner: 10Esanders) [17:25:00] (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Rename (View|Mobile)PageTarget to (Desktop|Mobile)ArticleTarget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227706 (owner: 10Esanders) [17:25:02] (03CR) 10jenkins-bot: [V: 04-1] Rename pageTarget to target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227708 (owner: 10Esanders) [17:27:00] (03PS6) 10Esanders: [BREAKING CHANGE] Bring in some code from MobileFrontend [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227699 (https://phabricator.wikimedia.org/T96186) [17:27:02] (03PS5) 10Esanders: Replace ve-init-mw-desktopArticleTarget-* with ve-init-mw-target-* [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227707 [17:27:04] (03PS5) 10Esanders: [BREAKING CHANGE] Rename (View|Mobile)PageTarget to (Desktop|Mobile)ArticleTarget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227706 [17:27:06] (03PS5) 10Esanders: Rename pageTarget to target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227708 [17:28:57] edsanders: One solution would be to force-merge the MF changes ahead of the VE ones, I guess. [17:29:35] (03PS1) 10Esanders: Remove mobileViewTarget alias hack [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227754 [17:30:47] who added the sideways dependency tests? [17:32:06] (03CR) 10jenkins-bot: [V: 04-1] Remove mobileViewTarget alias hack [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227754 (owner: 10Esanders) [17:35:05] 10Citoid, 10VisualEditor, 7Privacy: Trim the user's search string from Google Books search URLs - https://phabricator.wikimedia.org/T107322#1492253 (10Jdforrester-WMF) 3NEW [17:37:24] edsanders: hashar. [17:37:29] edsanders: And Krinkle_. [17:40:48] (03PS2) 10Esanders: Collapse text style buttons in mobile [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227742 (https://phabricator.wikimedia.org/T93325) [17:41:39] (03CR) 10Esanders: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/227751 (https://phabricator.wikimedia.org/T107122) (owner: 10Esanders) [17:41:44] edsanders: Will you be mad at me if I point out that it's a desktop page, not just a desktop article? [17:42:00] edsanders: "Article" is canonically NS0 and other wgContentNamespace pages. [17:42:14] VE's used on NS2 etc. [17:42:22] hm [17:43:03] Or were you going to pronouncability of "DAT"? [17:43:39] do we need use NS terminology though, because there are NS's we might have different targets for (e.g. talk) [17:43:52] True. [17:44:27] But e.g. https://en.wikipedia.org/wiki/Wikipedia:VisualEditor isn't an "article" but we'd still (eventually) want it to be VEable. [17:44:52] in that terminology [17:45:02] In MediaWiki's terminology. [17:45:11] Inventing our own feels like a bad move. [17:45:39] Is a flow page a 'Page'? [17:45:49] A Flow Board is a Page. [17:46:11] right, which this target will never support [17:46:22] it's more specific than Page [17:48:39] back a in a few hours [17:50:10] Umm. [17:50:17] Well, ish. [17:52:00] (03CR) 10Jforrester: [C: 031] "Maybe call it "DesktopPageTarget"? Otherwise good." (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227706 (owner: 10Esanders) [17:55:19] (03CR) 10Trevor Parscal: [C: 032] "LGTM" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227706 (owner: 10Esanders) [17:57:52] (03Merged) 10jenkins-bot: [BREAKING CHANGE] Rename (View|Mobile)PageTarget to (Desktop|Mobile)ArticleTarget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227706 (owner: 10Esanders) [17:57:56] (03CR) 10Jforrester: [C: 031] Replace ve-init-mw-desktopArticleTarget-* with ve-init-mw-target-* [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227707 (owner: 10Esanders) [17:58:34] (03PS6) 10Jforrester: DesktopArticleTarget#activate: Rename pageTarget to target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227708 (owner: 10Esanders) [17:58:39] (03CR) 10Jforrester: [C: 032] DesktopArticleTarget#activate: Rename pageTarget to target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227708 (owner: 10Esanders) [18:00:03] 10VisualEditor, 5Patch-For-Review, 3Reading-Web-Sprint-52-Zoolander, 5WMF-deploy-2015-07-28_(1.26wmf16): Revisit box-sizing: border-box for everything in MobileFrontend - https://phabricator.wikimedia.org/T86366#1492336 (10Jdforrester-WMF) [18:03:19] (03CR) 10Jforrester: [C: 032] Collapse text style buttons in mobile [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227742 (https://phabricator.wikimedia.org/T93325) (owner: 10Esanders) [18:14:12] BTW James_F, do you remember ever writing this: "The decline in new contributor growth is the single most serious challenge facing the Wikimedia movement in the year 2011. Removing the avoidable technical impediments associated with Wikimedia's editing interface is a necessary precondition for increasing the number of Wikimedia contributors." ? Apparently I wrote it in https://www.mediawiki.org/w/index.php?title=VisualEditor&diff= [18:14:12] 416093&oldid=416080 but I'm not sure I'm the one who first wrote it, or if I stole it from somewhere else. [18:14:20] 10VisualEditor, 10OOjs-UI, 5OOjs-UI-0.12.2, 5WMF-deploy-2015-07-28_(1.26wmf16): #p-personal hides OO.ui.Dialog - https://phabricator.wikimedia.org/T105300#1492373 (10Jdforrester-WMF) [18:17:22] (03CR) 10Jforrester: [C: 032] Replace ve-init-mw-desktopArticleTarget-* with ve-init-mw-target-* [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227707 (owner: 10Esanders) [18:18:18] (For the record: It came from https://strategy.wikimedia.org/wiki/Product_Whitepaper ) [18:19:47] (03Merged) 10jenkins-bot: Replace ve-init-mw-desktopArticleTarget-* with ve-init-mw-target-* [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227707 (owner: 10Esanders) [18:19:57] (03Merged) 10jenkins-bot: DesktopArticleTarget#activate: Rename pageTarget to target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227708 (owner: 10Esanders) [18:25:17] (03CR) 10Jforrester: [C: 031] Make scrollIntoView a VE utility function [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/227751 (https://phabricator.wikimedia.org/T107122) (owner: 10Esanders) [18:28:59] (03PS7) 10Jforrester: [BREAKING CHANGE] Bring in some code from MobileFrontend [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227699 (https://phabricator.wikimedia.org/T96186) (owner: 10Esanders) [18:32:19] (03CR) 10Jforrester: [C: 032] Replace placeholder color with opacity [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/227675 (owner: 10Esanders) [18:34:12] 10VisualEditor, 10VisualEditor-EditingTools: Placeholder is incorrectly formatted if document is just an empty heading (as opposed to a paragraph) - https://phabricator.wikimedia.org/T106582#1492419 (10Jdforrester-WMF) 5Open>3Resolved a:3Esanders [18:34:28] 10VisualEditor, 10VisualEditor-EditingTools, 5WMF-deploy-2015-08-04_(1.26wmf17): Placeholder is incorrectly formatted if document is just an empty heading (as opposed to a paragraph) - https://phabricator.wikimedia.org/T106582#1472151 (10Jdforrester-WMF) [18:34:39] (03Merged) 10jenkins-bot: Replace placeholder color with opacity [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/227675 (owner: 10Esanders) [18:34:41] (03Merged) 10jenkins-bot: Support other types of 'empty' document placeholders [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/227736 (https://phabricator.wikimedia.org/T106582) (owner: 10Esanders) [18:35:23] Krenair: Want to sanity-check +2 https://gerrit.wikimedia.org/r/#/c/227751/ before I pull through? [18:35:37] ("No" is a fine answer. :-)) [18:36:10] (03PS8) 10Jforrester: [BREAKING CHANGE] Bring in some code from MobileFrontend [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227699 (https://phabricator.wikimedia.org/T96186) (owner: 10Esanders) [18:43:35] (03CR) 10Jforrester: [C: 031] [BREAKING CHANGE] Bring in some code from MobileFrontend [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227699 (https://phabricator.wikimedia.org/T96186) (owner: 10Esanders) [18:50:06] (03PS2) 10Jforrester: Remove mobileViewTarget alias hack [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227754 (owner: 10Esanders) [18:51:44] 10Citoid, 10VisualEditor, 7Privacy: Trim the user's search string from Google Books search URLs - https://phabricator.wikimedia.org/T107322#1492485 (10Krinkle) In general using the canonical url (either `link rel=canonical` or `meta name=og:url`) would be a good idea for citations. That would automatically s... [18:53:05] (03CR) 10Jforrester: [C: 032] Remove mobileViewTarget alias hack [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227754 (owner: 10Esanders) [18:53:36] (03CR) 10Jforrester: [C: 032] Placeholder CSS fixes for skins [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227671 (owner: 10Esanders) [18:55:19] (03Merged) 10jenkins-bot: Remove mobileViewTarget alias hack [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227754 (owner: 10Esanders) [18:55:21] (03CR) 10jenkins-bot: [V: 04-1] Placeholder CSS fixes for skins [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227671 (owner: 10Esanders) [18:56:12] (03CR) 10Jforrester: "Meh." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227671 (owner: 10Esanders) [19:02:51] (03PS2) 10Jforrester: DesktopArticleTarget-*.css: Placeholder CSS fixes for skins [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227671 (owner: 10Esanders) [19:03:42] (03CR) 10Jforrester: [C: 031] "PS2 is a rebase. Ed can +2 if he's happy." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227671 (owner: 10Esanders) [19:44:43] 10VisualEditor: Reach Service Level Understanding between VE and Scrum of Scrums - https://phabricator.wikimedia.org/T107334#1492569 (10JAufrecht) 3NEW a:3JAufrecht [20:02:13] (03PS1) 10Jforrester: [BREAKING CHANGE] Kill ve.indexOf and thus @until [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/227868 [20:03:27] (03CR) 10Jforrester: "No uses in all of @wikimedia on GitHub. We've been trying to kill this for many months. Let's just do it." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/227868 (owner: 10Jforrester) [20:10:53] Krinkle: Want to merge https://gerrit.wikimedia.org/r/227868 then? [20:30:38] 10WikiEditor: "Warn me when I leave an edit page with unsaved changes" Does not work in MW 1.25.1 on Chrome - https://phabricator.wikimedia.org/T107339#1492682 (10Zoglun) 3NEW [20:33:29] James_F: I'm not supposed to. Ori will hunt me down. [20:34:17] Krinkle: :-P [20:34:32] (03CR) 10Krinkle: [C: 032] "I created you and now I will banish you to the depths of git log. You've served us well, Sir @until." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/227868 (owner: 10Jforrester) [20:34:45] * James_F grins at Krinkle. [20:34:52] Krinkle: But there's still the one in VE-MW. [20:34:58] Clones!! [20:35:03] Yup. [20:35:09] It's like a pestilence. [20:37:09] (03Merged) 10jenkins-bot: [BREAKING CHANGE] Kill ve.indexOf and thus @until [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/227868 (owner: 10Jforrester) [20:49:22] (03CR) 10Jforrester: [C: 031] When saving from review screen, swap to main save screen [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227747 (https://phabricator.wikimedia.org/T107251) (owner: 10Alex Monk) [20:53:36] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Support editing {{int:name}} blocks - https://phabricator.wikimedia.org/T67644#1492753 (10Neil_P._Quinn_WMF) @Whatamidoing-WMF, fair point. Do you want to file a separate task for changing the name of an existing transclusion? [21:39:54] (03PS1) 10Jforrester: build: Bump various devDependencies to latest [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/227884 [21:39:56] (03PS1) 10Jforrester: build: Bump grunt-jscs to 2.0.0 and make pass [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/227885 [21:40:15] (03CR) 10Jforrester: "This doesn't work yet, and is possibly the wrong approach." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/227885 (owner: 10Jforrester) [21:42:19] (03CR) 10jenkins-bot: [V: 04-1] build: Bump grunt-jscs to 2.0.0 and make pass [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/227885 (owner: 10Jforrester) [21:43:49] (03CR) 10jenkins-bot: [V: 04-1] build: Bump various devDependencies to latest [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/227884 (owner: 10Jforrester) [21:44:04] .../targets/{ve.init.mw.ViewPageTarget.init.js => ve.init.mw.DesktopArticleTarget.init.js} | 24 +++---- [21:44:04] .../init/targets/{ve.init.mw.ViewPageTarget.js => ve.init.mw.DesktopArticleTarget.js} | 170 +++++++++++++++++++++++---------------------- [21:44:05] :o [21:46:32] 10VisualEditor, 6Editing-Department: Define performance indicators for the VisualEditor team - https://phabricator.wikimedia.org/T107351#1492919 (10Neil_P._Quinn_WMF) 3NEW a:3Neil_P._Quinn_WMF [21:54:25] (03PS2) 10Jforrester: build: Bump grunt-jscs to 2.0.0 and make pass [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/227885 [21:56:46] (03CR) 10jenkins-bot: [V: 04-1] build: Bump grunt-jscs to 2.0.0 and make pass [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/227885 (owner: 10Jforrester) [21:57:47] (03PS2) 10Jforrester: build: Bump various devDependencies to latest [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/227884 [22:00:57] (03CR) 10Alex Monk: [C: 04-1] "Mostly looks good, one missing i18n message?" (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227699 (https://phabricator.wikimedia.org/T96186) (owner: 10Esanders) [22:06:19] (03CR) 10Alex Monk: [C: 032] Make scrollIntoView a VE utility function [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/227751 (https://phabricator.wikimedia.org/T107122) (owner: 10Esanders) [22:06:28] Whee. [22:08:51] (03Merged) 10jenkins-bot: Make scrollIntoView a VE utility function [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/227751 (https://phabricator.wikimedia.org/T107122) (owner: 10Esanders) [22:11:12] (03CR) 10Alex Monk: [C: 032] DesktopArticleTarget-*.css: Placeholder CSS fixes for skins [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227671 (owner: 10Esanders) [22:13:07] (03PS1) 10Jforrester: Update VE core submodule to master (43652b6) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227890 [22:14:07] (03Merged) 10jenkins-bot: DesktopArticleTarget-*.css: Placeholder CSS fixes for skins [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227671 (owner: 10Esanders) [22:19:05] 10VisualEditor, 6Editing-Department, 7Blocked-on-Editing, 5Patch-For-Review: VisualEditor tests fail in target agnostic mode - https://phabricator.wikimedia.org/T107122#1493040 (10Jdlrobson) Thanks for the speediness. Looks like there is one remaining problem: ve.dm.** several FAILED: Unfinished AJAX reque... [22:58:01] Why is VE activated on https://commons.wikimedia.org/wiki/Commons:Village_pump/Copyright ? Should it be? It is almost impossble to edit with it... [22:58:52] (03PS1) 10Alex Monk: Settings dialog: Focus redirect target input when redirect is enabled [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227904 (https://phabricator.wikimedia.org/T106616) [23:00:01] Josve05a: Because Commons has it on for the Commons: namespace. [23:00:22] any way to turn it off for that page? Or make it..usable? [23:00:30] No and no. [23:00:34] Well, a gadget… [23:00:41] I did advise against having it on for that namespace. [23:01:28] Josve05a: See for example also https://www.wikidata.org/wiki/Wikidata:Property_proposal/Person [23:01:40] urgh [23:02:30] Did I say that I was using a value of 5 points for unpointed stories? "default_points = 10" oops. [23:02:33] There is magic words to add "new topic" on Commons-namespaces and Wikipedia namespaces (SOmething in line with __NEWSECTION__ or something, can something like that be created to be added to specific pages which should not have VE? (Until FLow comes) [23:04:45] jaufrecht: Ha. [23:04:57] Josve05a: No. [23:05:03] :/ [23:05:04] Josve05a: "Can", yes. "Will", no. [23:05:33] Well, I 'can' go to the moon. Will I ever get an opertunity to be able to go to the moon? No. [23:05:56] You can? I can't. [23:09:17] Well, I can break in to NASA, kill everyone there and steal a spaceship or something [23:09:48] I cannot condone or endorse any form of illegal activity, I'm afraid. :-) [23:11:14] :) [23:16:48] (03CR) 10Jforrester: [BREAKING CHANGE] Bring in some code from MobileFrontend (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227699 (https://phabricator.wikimedia.org/T96186) (owner: 10Esanders) [23:17:25] (03PS9) 10Jforrester: [BREAKING CHANGE] Bring in some code from MobileFrontend [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227699 (https://phabricator.wikimedia.org/T96186) (owner: 10Esanders) [23:18:11] 10VisualEditor, 10Beta-Cluster, 6Collaboration-Team, 10Flow: Parsoid broken in beta for VisualEditor but not for Flow (RESTbase breakage?) - https://phabricator.wikimedia.org/T107342#1493319 (10Catrope) [23:23:58] 10VisualEditor, 6Collaboration-Team, 10Flow: Initial render of mention output in an empty (placeholder'ed) VE Flow reply is blank until it is changed - https://phabricator.wikimedia.org/T107342#1493332 (10Jdforrester-WMF) [23:24:27] 10VisualEditor, 6Collaboration-Team, 10Flow: Initial render of mention output in an empty (placeholder'ed) VE Flow reply is blank until it is changed - https://phabricator.wikimedia.org/T107342#1492766 (10Jdforrester-WMF) Title was sufficiently concerning to make me try this out myself. :-) Not a Parsoid or... [23:26:11] 10VisualEditor, 6Collaboration-Team, 10Flow: Initial render of mention output in an empty (placeholder'ed) VE Flow reply is blank until it is changed - https://phabricator.wikimedia.org/T107342#1493356 (10Catrope) The preview request to `api.php?action=visualeditor&paction=parsefragment` results in a `parsoi... [23:27:36] 10VisualEditor, 6Collaboration-Team, 10Flow: Initial render of mention output in an empty (placeholder'ed) VE Flow reply is blank until it is changed - https://phabricator.wikimedia.org/T107342#1493360 (10Jdforrester-WMF) http://en.wikipedia.beta.wmflabs.org/wiki/Flow?veaction=edit works fine. [23:28:32] 10VisualEditor, 6Collaboration-Team, 10Flow: Initial render of mention output in an empty (placeholder'ed) VE Flow reply is blank until it is changed - https://phabricator.wikimedia.org/T107342#1493366 (10Catrope) >>! In T107342#1493332, @Jdforrester-WMF wrote: > Title was sufficiently concerning to make me... [23:28:45] 10VisualEditor, 6Collaboration-Team, 10Flow, 10RESTBase: Initial render of mention output in an empty (placeholder'ed) VE Flow reply is blank until it is changed - https://phabricator.wikimedia.org/T107342#1493367 (10Catrope) [23:33:28] 10VisualEditor, 6Collaboration-Team, 10Flow: Initial render of mention output in an empty (placeholder'ed) VE Flow reply is blank until it is changed - https://phabricator.wikimedia.org/T107342#1493415 (10Catrope) [23:33:46] 10VisualEditor, 6Collaboration-Team, 10Flow: Initial render of mention output in an empty (placeholder'ed) VE Flow reply is blank until it is changed - https://phabricator.wikimedia.org/T107342#1492766 (10Catrope) Sounds like this is a bug in the VE API module not expecting RB's (legitimate) 404s. [23:44:49] (03CR) 10Alex Monk: [C: 032] [BREAKING CHANGE] Bring in some code from MobileFrontend [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227699 (https://phabricator.wikimedia.org/T96186) (owner: 10Esanders) [23:47:09] (03Merged) 10jenkins-bot: [BREAKING CHANGE] Bring in some code from MobileFrontend [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/227699 (https://phabricator.wikimedia.org/T96186) (owner: 10Esanders)