[00:07:16] (03CR) 10Krinkle: [C: 032] Update VE core submodule to master (d9d4e33) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/228574 (owner: 10Jforrester) [00:09:34] (03Merged) 10jenkins-bot: Update VE core submodule to master (d9d4e33) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/228574 (owner: 10Jforrester) [01:55:34] 10VisualEditor-LanguageTool, 10Continuous-Integration-Config, 5Patch-For-Review: setup continuous integration for the LanguageTool extension - https://phabricator.wikimedia.org/T104760#1501089 (10Legoktm) 5Open>3Resolved Done, "npm" tests are failing though, as demonstrated on https://gerrit.wikimedia.or... [02:24:05] 10VisualEditor-LanguageTool, 10Continuous-Integration-Config, 5Patch-For-Review: setup continuous integration for the LanguageTool extension - https://phabricator.wikimedia.org/T104760#1501110 (10Jdforrester-WMF) >>! In T104760#1501089, @Legoktm wrote: > Done, "npm" tests are failing though, as demonstrated... [06:51:36] 10VisualEditor: VE grabs comments as part of parameter value - https://phabricator.wikimedia.org/T100137#1501270 (10Neil_P._Quinn_WMF) 5Open>3declined a:3Neil_P._Quinn_WMF Well, the comment in question //is// part of the parameter value (because values run from the equals sign until the next pipe, no matte... [07:10:58] 10VisualEditor: Parameters of Infobox cricketer not properly set for Visual Editor - https://phabricator.wikimedia.org/T100138#1501286 (10Neil_P._Quinn_WMF) p:5Triage>3Lowest @Magioladitis, makes sense, thank you for helping me catch up! I don't think it's worth building an additional system to do fallback d... [09:31:46] 10Cite, 10MediaWiki-Parser, 10MediaWiki-extensions-ContentTranslation, 5ContentTranslation-Release6: ContentTranslation created a reference that renders as UNIQ--nowiki-00000007-QINU at [[Google Cardboard]] in he.wikipedia - https://phabricator.wikimedia.org/T107303#1501346 (10Amire80) [10:38:34] (03PS1) 10Esanders: DataTransferHandler improvements [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/228629 [10:38:36] (03PS1) 10Esanders: Allow the target to specify a DTH factory [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/228630 [11:06:11] (03PS2) 10Esanders: Allow the target to specify a DTH factory [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/228630 [11:06:13] (03PS2) 10Esanders: DataTransferHandler improvements [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/228629 [11:06:15] (03PS1) 10Esanders: PasteRules.plainText fixup [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/228633 [11:12:34] (03PS1) 10Esanders: Use target-specific command registry [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/228634 [11:15:24] (03CR) 10jenkins-bot: [V: 04-1] Use target-specific command registry [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/228634 (owner: 10Esanders) [11:31:35] (03PS2) 10Esanders: Use target-specific command registry [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/228634 [11:31:37] (03PS1) 10Esanders: Fix typo in ve.init.mw.Target.prototype.save [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/228637 [11:31:39] (03PS1) 10Esanders: Use super constructors in ArticleTargets [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/228638 [11:31:42] (03PS1) 10Esanders: Move command registrations to the files which introduce the commands [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/228639 [11:33:59] (03CR) 10jenkins-bot: [V: 04-1] Move command registrations to the files which introduce the commands [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/228639 (owner: 10Esanders) [11:34:14] (03CR) 10jenkins-bot: [V: 04-1] Use target-specific command registry [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/228634 (owner: 10Esanders) [11:34:16] (03CR) 10jenkins-bot: [V: 04-1] Use super constructors in ArticleTargets [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/228638 (owner: 10Esanders) [11:34:29] (03CR) 10jenkins-bot: [V: 04-1] Fix typo in ve.init.mw.Target.prototype.save [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/228637 (owner: 10Esanders) [12:21:32] (03PS2) 10Esanders: Move command registrations to the files which introduce the commands [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/228639 [12:21:34] (03PS3) 10Esanders: Use target-specific command registry [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/228634 [12:21:36] (03PS1) 10Esanders: Remove
from diff panel [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/228646 [12:24:03] (03CR) 10jenkins-bot: [V: 04-1] Remove
from diff panel [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/228646 (owner: 10Esanders) [12:24:35] (03CR) 10jenkins-bot: [V: 04-1] Use target-specific command registry [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/228634 (owner: 10Esanders) [12:24:37] (03CR) 10jenkins-bot: [V: 04-1] Move command registrations to the files which introduce the commands [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/228639 (owner: 10Esanders) [13:14:39] 10VisualEditor, 10VisualEditor-Tables: "Insert column" in partially template-generated table does not shift non-heading column data to the right - https://phabricator.wikimedia.org/T107650#1501510 (10matmarex) [14:35:03] (03PS2) 10Jforrester: PasteRules#plainText: Fallback if rules.external is undefined [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/228633 (owner: 10Esanders) [14:35:18] (03CR) 10Jforrester: [C: 032] PasteRules#plainText: Fallback if rules.external is undefined [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/228633 (owner: 10Esanders) [14:38:22] (03Merged) 10jenkins-bot: PasteRules#plainText: Fallback if rules.external is undefined [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/228633 (owner: 10Esanders) [14:38:51] (03PS3) 10Jforrester: DataTransferHandler improvements [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/228629 (owner: 10Esanders) [16:08:37] 10VisualEditor, 10MediaWiki-General-or-Unknown: Don't lose the sort key of the added category - https://phabricator.wikimedia.org/T107701#1501610 (10Nnemo) 3NEW [16:11:25] 10VisualEditor, 10MediaWiki-General-or-Unknown: Don't lose the sort key of the added category - https://phabricator.wikimedia.org/T107701#1501610 (10Nnemo) I have tried several times. I always repro the bug. [18:29:00] (03PS1) 10Esanders: Remove redundant check of this.imageModel existence [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/228678 [18:29:02] (03PS1) 10Esanders: Separate out linmod generation in MWImageModel [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/228679 [18:29:38] (03CR) 10Esanders: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/228637 (owner: 10Esanders) [18:30:41] James_F|Away, this causes post save to throw an exception: https://gerrit.wikimedia.org/r/#/c/228637/ [18:31:28] (03CR) 10jenkins-bot: [V: 04-1] Remove redundant check of this.imageModel existence [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/228678 (owner: 10Esanders) [18:31:43] (03CR) 10jenkins-bot: [V: 04-1] Separate out linmod generation in MWImageModel [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/228679 (owner: 10Esanders) [19:39:30] 10VisualEditor: URLs added "manually" via the Cite tool get 'd - https://phabricator.wikimedia.org/T107431#1501728 (10Tgr) This is a big problem for wikis which do not have any citation templates set up: there is only the "basic" option for citations, which shows you a text box, and if you paste an URL t... [20:52:30] 10VisualEditor, 10VisualEditor-MediaWiki, 5WMF-deploy-2015-07-28_(1.26wmf16): Replace wgVisualEditorNamespaces with a 2D array of namespace => enabled state - https://phabricator.wikimedia.org/T104898#1501817 (10Legoktm) 5Resolved>3Open Reverted in {7ca1afbbd2f02abbc95853e0f0c116a84612b136}. [20:53:06] 10VisualEditor, 10VisualEditor-MediaWiki, 5WMF-deploy-2015-07-28_(1.26wmf16): Replace wgVisualEditorNamespaces with a 2D array of namespace => enabled state - https://phabricator.wikimedia.org/T104898#1501820 (10Legoktm) [20:53:18] 10VisualEditor, 10VisualEditor-MediaWiki, 5WMF-deploy-2015-07-28_(1.26wmf16): Replace wgVisualEditorNamespaces with a 2D array of namespace => enabled state - https://phabricator.wikimedia.org/T104898#1431556 (10Legoktm) [21:30:44] (03PS1) 10Alex Monk: Revert "Revert "Replace wgVisualEditorNamespaces with an associative array"" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/228746 [21:31:19] (03PS2) 10Alex Monk: Revert "Revert "Replace wgVisualEditorNamespaces with an associative array"" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/228746 (https://phabricator.wikimedia.org/T104898) [21:32:27] (03CR) 10Legoktm: [C: 04-1] Revert "Revert "Replace wgVisualEditorNamespaces with an associative array"" (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/228746 (https://phabricator.wikimedia.org/T104898) (owner: 10Alex Monk) [21:33:43] (03CR) 10jenkins-bot: [V: 04-1] Revert "Revert "Replace wgVisualEditorNamespaces with an associative array"" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/228746 (https://phabricator.wikimedia.org/T104898) (owner: 10Alex Monk) [21:35:24] Thank you, legoktm, it's a work in progress :p [21:35:30] :P [21:42:50] (03CR) 10Eranroz: "adding indication for some more serious "typo" :)" (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/228637 (owner: 10Esanders) [21:44:39] legoktm, I think we may have broken something else [21:44:46] oh? [21:44:48] :/ [21:45:50] as in the VE extension no longer loads on master [21:45:51] 10VisualEditor: Can't type an edit summary - https://phabricator.wikimedia.org/T107719#1501878 (10gregoire) 3NEW [21:45:57] o.O [21:47:55] it doesn't show upon Special:Version for me...wtf [21:49:20] legoktm, everything gets array_merge [21:49:35] eh... [21:50:01] ohh [21:50:19] wait [21:50:48] ugh, extension credits are a mess [21:50:57] because we handle that in the processor [21:51:00] er, registry [21:51:58] working on a patch [22:13:33] (03PS3) 10Alex Monk: Revert "Revert "Replace wgVisualEditorNamespaces with an associative array"" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/228746 (https://phabricator.wikimedia.org/T104898) [22:16:14] (03CR) 10jenkins-bot: [V: 04-1] Revert "Revert "Replace wgVisualEditorNamespaces with an associative array"" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/228746 (https://phabricator.wikimedia.org/T104898) (owner: 10Alex Monk) [22:17:50] 10TemplateData: Parameters of Infobox cricketer not properly set for Visual Editor - https://phabricator.wikimedia.org/T100138#1501964 (10Krenair) I think it's about hard-coding some common template parameter names into #TemplateData to have specific default labels where the editors have not created TemplateData... [22:17:58] 10TemplateData: Parameters of Infobox cricketer not properly set for Visual Editor - https://phabricator.wikimedia.org/T100138#1501966 (10Krenair) 5Open>3declined a:3Krenair [22:18:51] legoktm, could you look at that failing test too? "Could not load some extensions because they are missing the expected entry point: Parsoid" [22:19:03] I thought we killed the Parsoid extension [22:19:44] we did [22:19:58] I bet that's why it's failing [22:22:21] (03CR) 10Legoktm: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/228746 (https://phabricator.wikimedia.org/T104898) (owner: 10Alex Monk) [22:25:22] 10TemplateData: Parameters of Infobox cricketer not properly set for Visual Editor - https://phabricator.wikimedia.org/T100138#1501976 (10Magioladitis) OK. So that means, it is community's responsibility to update TemplateData in popular infoboxes. [23:47:01] Krenair: if the namespaces thing breaks again, we'll be able to notice in beta right? [23:47:10] should be [23:48:03] yep [23:48:32] (03CR) 10Legoktm: [C: 032] Revert "Revert "Replace wgVisualEditorNamespaces with an associative array"" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/228746 (https://phabricator.wikimedia.org/T104898) (owner: 10Alex Monk) [23:50:46] (03Merged) 10jenkins-bot: Revert "Revert "Replace wgVisualEditorNamespaces with an associative array"" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/228746 (https://phabricator.wikimedia.org/T104898) (owner: 10Alex Monk) [23:57:04] legoktm, oh we'll still need that part in the prod config before this gets deployed [23:57:17] ... and probably beta [23:57:52] I'll do that now