[00:06:59] 10VisualEditor, 6Analytics-Engineering: VE-related data for the Galician Wikipedia - https://phabricator.wikimedia.org/T86944#1516826 (10Jdforrester-WMF) [00:52:58] 10Citoid, 10VisualEditor, 10MediaWiki-ResourceLoader: Value for citoid-template-type-map.json randomly missing in some languages - https://phabricator.wikimedia.org/T93800#1516907 (10Josve05a) ```
10Citoid, 10VisualEditor, 10MediaWiki-ResourceLoader: Value for citoid-template-type-map.json randomly missing in some languages - https://phabricator.wikimedia.org/T93800#1517640 (10GermanJoe) Currently Citoid is down for me at en-Wiki (FF 39.0, Windows XP, vector skin, desktop). The main menu shows "Cite"... [10:46:59] 10Citoid, 10VisualEditor, 10MediaWiki-ResourceLoader: Value for citoid-template-type-map.json randomly missing in some languages - https://phabricator.wikimedia.org/T93800#1517664 (10GermanJoe) Quick update: purged per the advice on top of this thread (thanks) and Citoid and regular UI are available again. [12:15:19] 10VisualEditor, 10Parsoid-Nowiki: Consecutive nowiki tags - https://phabricator.wikimedia.org/T108009#1517747 (10NicoV) @ssastry An other example, a lot more awful than the previous one... 2 self closing nowiki tags, just between 2 italics formatting (meaning italics around nothing)... `''''` [12:57:09] (03PS1) 10Esanders: Emit blur/focus events from the surface model [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230083 [12:57:11] (03PS1) 10Esanders: Style mobile context [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230084 [12:58:19] (03PS1) 10Esanders: Switch to using surface model focus/blur events [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230085 [12:58:21] (03PS1) 10Esanders: Use platform's iOS detection, instead of collecting from MobileFrontend [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230086 [12:59:28] (03PS1) 10Esanders: Flag cancel/back actions [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/230087 [12:59:30] (03PS1) 10Esanders: Prevent toolGroup hack from running twice [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/230088 [13:04:23] (03CR) 10Jforrester: [C: 032] "Ick." [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/230088 (owner: 10Esanders) [13:05:05] (03CR) 10Jforrester: [C: 032] Flag cancel/back actions [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/230087 (owner: 10Esanders) [13:05:41] (03Merged) 10jenkins-bot: Flag cancel/back actions [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/230087 (owner: 10Esanders) [13:05:43] (03Merged) 10jenkins-bot: Prevent toolGroup hack from running twice [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/230088 (owner: 10Esanders) [13:36:59] (03PS2) 10Esanders: Use platform's iOS detection, instead of collecting from MobileFrontend [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230086 [13:37:01] (03PS2) 10Esanders: Switch to using surface model focus/blur events [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230085 [13:37:03] (03PS1) 10Esanders: Mobile toolbar style tweak [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230096 [14:47:40] 10VisualEditor: Facility for incremental edit summary has been lost in current version - https://phabricator.wikimedia.org/T108329#1518158 (10Spinningspark) 3NEW [14:49:11] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: Tapping edit on an existing link shows a misaligned title suggestion - https://phabricator.wikimedia.org/T108330#1518165 (10Florian) 3NEW [15:34:29] (03PS2) 10Jforrester: MobileArticleTarget: Remove incorrect border from toolbar [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230096 (owner: 10Esanders) [15:34:39] (03CR) 10Jforrester: [C: 032] MobileArticleTarget: Remove incorrect border from toolbar [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230096 (owner: 10Esanders) [15:35:48] edsanders: Until we get proper auto-expanding toolbars in OOUI, do you have any idea how to give iPad/etc. users a better experience? Right now it's very odd. [15:36:48] (03PS3) 10Jforrester: Use platform's iOS detection, instead of collecting from MobileFrontend [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230086 (owner: 10Esanders) [15:36:55] (03Merged) 10jenkins-bot: MobileArticleTarget: Remove incorrect border from toolbar [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230096 (owner: 10Esanders) [15:37:06] (03PS4) 10Jforrester: MobileArticleTarget: Use platform's iOS detection, not MobileFrontend's [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230086 (owner: 10Esanders) [15:37:17] (03CR) 10Jforrester: [C: 032] MobileArticleTarget: Use platform's iOS detection, not MobileFrontend's [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230086 (owner: 10Esanders) [15:40:00] (03Merged) 10jenkins-bot: MobileArticleTarget: Use platform's iOS detection, not MobileFrontend's [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230086 (owner: 10Esanders) [15:40:21] so... [15:40:30] paste doesn't seem to go through the sequenceregistry [15:40:41] edsanders: ^ known bug? misfeature? [15:40:53] cscott: Known issue. Not really fixable, I believe. [15:41:05] cscott: (JS copy/paste security model.) [15:41:10] it's deliberate [15:41:19] well, i could manually trigger the sequence registry after the paste [15:41:32] how do you expect that copy/paste of an autolink url should work? [15:41:44] or rather, autolinking a pasted url [15:42:00] using a DataTransferHandler [15:42:10] edsanders: a significant number of the insertions we're seeing appear to be due to folks pasting wikitext [15:42:24] we have numbers [15:42:25] which hooks into data transfers (paste or dragndrop) [15:42:54] edsanders: so a completely different mechanism that a sequenceregistry for 'http://' [15:42:57] you can register a plain text data transfer handler and do a wikitext scan on it, auto link crap etc [15:43:00] *than [15:43:11] yes [15:43:12] (03PS2) 10Jforrester: Style mobile context [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230084 (owner: 10Esanders) [15:43:23] sequences are typing shortcuts [15:43:52] (03PS3) 10Jforrester: MobileContext: Use frameless buttons, fix vertical heights/alignments [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230084 (owner: 10Esanders) [15:43:58] (03CR) 10Jforrester: [C: 032] MobileContext: Use frameless buttons, fix vertical heights/alignments [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230084 (owner: 10Esanders) [15:44:07] the 'traditional' autolink mechanism (as implemented by google docs, etc) doesn't fit neatly into the sequence odel [15:45:00] it works a little bit better if I wait until you enter some whitespace after the link, and then autolink it. but that doesn't handle paste very well -- or our issue, where the url is the only thing entered in the box. [15:45:31] pasting a URL or '* ' into Google docs does nothing [15:46:13] they only auto link / auto list if you type them out [15:46:34] specifically, entering the whitespace *after* the link is what autolinks it in google docs [15:46:45] same thing for paste. paste the url, then press *space* and voila, autolink [15:46:58] right, the sequence is http://.*[\w] [15:47:14] why couldn't we do that? [15:47:19] so i can implement that with the sequenceregistry model easily enough. but... [15:47:32] the cute thing is that google docs et al then let you press backspace to *unlink* [15:47:43] (without deleting the whitespace) [15:47:50] i don't think our sequence registry model does that [15:47:59] no, it just does undo at the moment [15:48:01] cscott: We have undo instead. [15:48:16] really it's pushing a special "backspace means undo" handler, which goes away at the next non-backspace keystroke [15:48:20] we don't have that, do we? [15:48:23] cscott: And I think the backspace-to-undo-but-not-backspace idea is insanely bad. [15:48:37] Also I have no idea how that would work properly with IMEs. [15:48:45] ok, fine, i'm happy not to bother implementing that! [15:48:49] :_) [15:48:58] it depends on the sequence [15:49:04] i just want to make sure i'm implementing desired behavior. [15:49:13] (03Merged) 10jenkins-bot: MobileContext: Use frameless buttons, fix vertical heights/alignments [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230084 (owner: 10Esanders) [15:49:18] for bullet lists it makes sense, but that should be the behaviour for all lists [15:49:28] so, my plan is: (1) implement autolink after url+whitespace as a sequenceregistry thing, which is mostly done. [15:49:39] right [15:49:52] (2) implement some sort of plain-text handler to handle pasted urls, perhaps? [15:50:25] (3) maybe invoke sequence editor before closing the dialog or some evil hack like that in order to get the common pasted-url-in- case to work? [15:50:32] s/editor/registry/ [15:50:57] since (3) is actually the only use case we actually care about, in terms of people complaining that parsoid is adding s around their pasted urls when it's really VE's fault. [15:51:08] yes but will contain wikitext [15:51:16] it's doable [15:51:29] you need a data import handler than matches .* [15:52:22] the parses the wikitext via the API and inserts the HTML [15:52:47] DataTransferHandlers are async, and it will even show a progress dialog by default [15:53:09] edsanders: for reference, it's https://phabricator.wikimedia.org/T107431 which i'm working on. [15:53:49] edsanders: Can't cscott run the registry on the (DOM) contents of the reference? [15:55:14] what i'm thinking is that the user opens the cite tool, selects the "manual" option (because they are a 'power user' and think they know what they are doing), pastes in a url, and then closes the dialog. [15:55:38] there's no whitespace manually added, so we the whole thing to preserve it as text (WYSIWYG) [15:56:00] cscott: Alternatively, if we detect that you're creating http://…, we /could/ just throw it at Citoid… :-D [15:56:13] (Let's not, at least, not now.) [15:56:14] if i can just intercept the dialog close and treat end-of-document as whitespace somehow, i might be able to use the normal sequenceregistry path [15:56:50] James_F: yeah, the problem is that the user is either *deliberately* not using the cite web tab in citoid, or else the wiki doesn't have {{Cite}} templates configured. [15:57:08] * James_F nods. [15:57:12] it's really a user error, but they are blaming us (parsoid+ve) because they expect autolinking to "just work" [15:57:23] Yeah, let's not do anything magical beyond auto-linking for now. [15:57:56] well, i'm going to work on the sequenceregistry first, since that's straightforward and i think we agree on how that works ( 'http:///... + whitespace') [15:58:12] * James_F nods. [15:58:13] i've already written a small patch to the sequence registry to let it accept a regexp as well as a literal string [15:58:14] Sounds good. [15:58:29] cscott, DTH will look something like this: https://gist.github.com/edg2s/8ceee4f112c8663c3913 [15:58:54] cscott, how did you deal the the length problem? [15:59:05] edsanders: yeah, that. [15:59:33] do you just grab everything to the left until a node? [16:00:00] He can anchor from whitespace, surely? [16:00:01] edsanders: i thought about using the existing Data support for "current word" ranges, and say that regexp sequences must still watch in a certain word range. but right now I'm just grabbing everything to the left. [16:00:27] so from a performance point of view [16:00:37] every sequence runs on every keystroke [16:00:39] James_F: yeah, but one way or another you end up limiting your regexp somehow. it would also be reasonable to require a specific max string length when you specify the regexp pattern. [16:00:58] so, autolink, but i promise my urls are less than 255 characters, never give me more than that. [16:01:53] something like that. any way i can think about it is a little bit of a kludge, but it can be bikeshedded [16:01:56] [$\w]{protocol:}//[]*\w [16:01:59] it might be worth grabbing the text in the factory once, and pass it to the handlers [16:02:00] * James_F is lazy. [16:02:04] there are a couple reasonable things to do. [16:03:48] you can also track max length required as sequences are registered [16:03:53] James_F: something like https://gist.github.com/gruber/249502#gistcomment-1328838 to get fancy. but i agree that http:// https:// and maybe ftp:// are sufficient. [16:04:06] the regexp might be a little clever about close parens [16:06:06] but i think that's actually not in the sequenceregistry regexp, my experiments with google docs seem to show that it's always whitespace which triggers the autolink (not the close paren) but that it kicks close parens out of the link itself in the same way the PHP parser does. [16:06:44] 10VisualEditor, 10VisualEditor-MediaWiki: VisualEditor: Provide support for BLP edit notices on enwiki - https://phabricator.wikimedia.org/T56029#1518383 (10Jdforrester-WMF) [16:06:59] so \bhttps?://\W+\w might be an acceptable regexp [16:07:44] edsanders: i'm going to split up the patches (once I test everything together) so I can get your input on the regexp sequence stuff (esp performance) independent of the autolink stuff. [16:09:27] 10VisualEditor, 10VisualEditor-MediaWiki-References, 10Parsoid: Bare unlinked URLs added "manually" via the Cite tool get intentionally 'd by Parsoid - https://phabricator.wikimedia.org/T107431#1518409 (10Esanders) So there are two problems: 1. People pasting into basic instead of Citoid - this seem... [16:16:39] 10VisualEditor, 10VisualEditor-MediaWiki-References, 10Parsoid: Bare unlinked URLs added "manually" via the Cite tool get intentionally 'd by Parsoid - https://phabricator.wikimedia.org/T107431#1518449 (10cscott) It seems to be mostly "power users" who "know how to add refs". I think (1) adding prop... [16:18:46] edsanders, James_F: https://fr.wikipedia.org/wiki/Wikip%C3%A9dia:%C3%89diteurVisuel/Avis/Nowiki is a quantification of insertion on frwiki [16:19:38] of 33 problematic insertions of in the examined time period, 6 of them were due to pasted wikitext, and 3 were due to the lack of autolinking. [16:20:05] so 20% solved by a DataTransferHandler, and 10% solved by the patches I'm currently working on. [16:21:04] https://gist.github.com/edg2s/8ceee4f112c8663c3913 makes it look like the DataTransferHandler could actually be the easier patchset to work on. [16:21:47] just come up with a regexp likely to identify "wikitext" and then invoke parsoid wt2html [16:27:10] ^(==+)[^=].*\1$ | \[\[[^\]+]\]\] | \{\{[^\}]+\}\} [16:27:37] would catch all but one of the examples on frwiki [16:28:29] the last example has lots of ''\w+'' but I worry that would get false positives. [16:35:45] cscott: there may be spaces after == in the end of line so unless you trim them you should $ => \s*$ [16:37:59] also notice == can be limited to at most 6. so maybe ={2,6} instead of ==+ [16:40:16] ok, i have installed all of the dependencies, started parsoid, enabled the module.. how do i actually invoke the visual editor? [16:41:34] juri_: click "edit" [16:41:39] i've added myself an account and poked around at the settings. one checkbox mentions disabling the visual editor while it is in beta, but that is unchecked. [16:41:45] juri_: if everything is installed correctly, you can browser to you local mediawiki and press alt+shift+V [16:42:20] this might be useful in your LocalSettings.php: [16:42:21] // OPTIONAL: Enable VisualEditor in other namespaces [16:42:21] // By default, VE is only enabled in NS_MAIN [16:42:21] $wgVisualEditorNamespaces[] = NS_USER; [16:42:21] // Enable by default for everybody [16:42:23] $wgDefaultUserOptions['visualeditor-enable'] = 1; [16:42:23] // Don't allow users to disable it [16:42:25] $wgHiddenPrefs[] = 'visualeditor-enable'; [16:43:01] i'm guessing it's the wgDefaultUserOptions line in particular which might be useful? i'm pretty sure this is mentioned on the VE installation wiki page. [16:43:28] oddly i already have this all. [16:43:40] nothing is happening tho. it's the standard editor. [16:44:23] juri_: check Special:Version and see if VE is actually being loaded? [16:45:15] indeed, it is. [16:45:52] 0.1.0 (c947b49) 18:31, 9 July 2015 [16:45:55] juri_: ?veaction=edit in teh url? [16:46:02] or is it action=edit [16:46:10] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10OOjs-UI: List tool popup not visible on narrow screens - https://phabricator.wikimedia.org/T108344#1518600 (10Esanders) 3NEW a:3Esanders [16:46:48] 10TemplateData, 6Community-Liaison, 10WMF-Product-Strategy: Please make me a list of commonly used templates in Wikipedia articles - https://phabricator.wikimedia.org/T96323#1518612 (10Elitre) Ok, actually all the last comments by me were directed at @MZMcBride :) [16:47:04] it was action=edit. changing that to veaction just shows me the page. [16:47:31] juri_: Alt+shift+J / F12 shows any JS error? [16:48:05] *Ctrl+shift+J [16:52:17] ok, switching to another browser fixed it. [16:52:34] aparently the visual editor does not like midori. [16:52:59] James_F: ^^ [16:54:02] What does Midori report itself as? Is it based on IE8 or something? [16:54:36] Oh, it's WebKit based. [16:54:46] I wonder what version? To fail our tests it has to be pretty old. [16:54:55] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10OOjs-UI, 5Patch-For-Review: ProcessDialog fitLabel doesn't work for relative widths (e.g. full screen 100%) - https://phabricator.wikimedia.org/T108326#1518624 (10Esanders) [16:55:00] it's in debian stable. but i'm running the one from unstable. [16:55:46] and still, the edit button defaults to action=, not veaction=. [16:57:30] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Reading-Web, 7Technical-Debt: VisualEditorOverlay should be written as an OO.ui.ProcessDialog - https://phabricator.wikimedia.org/T88559#1518648 (10Esanders) [16:57:31] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Reading-Web, 7Technical-Debt: Rewrite the edit summary screen of VisualEditorOverlay in OOjs UI - https://phabricator.wikimedia.org/T96188#1518644 (10Esanders) 5Open>3Resolved a:3Esanders https://gerrit.wikimedia.org/r/#/c/229576/ [16:58:27] fat load of good it will do my nontechnical users if they have to edit the URL carefully. ;P [17:00:01] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Reading-Web: Mobile VE - cursor remains in place while contents scoll - https://phabricator.wikimedia.org/T92004#1518660 (10Esanders) 5Open>3Resolved a:3Esanders This is a bug in iOS Safari, not fixable. [17:00:53] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 7Epic: Make VisualEditor good enough for mobile tablet and phone enablement - https://phabricator.wikimedia.org/T94725#1518671 (10Esanders) [17:00:55] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 7Browser-Support-Apple-Safari: VisualEditor Mobile: The Citation icon does not get highlighted upon clicking or tapping on it in Mobile VE using desktop Safari and iOS safari - https://phabricator.wikimedia.org/T74410#1518668 (10Esanders) 5Open>3Resolved a... [17:03:29] juri_: We're working on that. [17:07:51] fwiw, i'm seeing that behavior (have to add veaction) on chromium from debian unstable, which identifies itsself as 'Mozilla/5.0 (X11; Linux i686 (x86_64)) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/43.0.2357.124 Safari/537.36' [17:09:12] juri_: Yes, that's intentional. [17:09:20] juri_: We don't steal action=edit right now. [17:09:25] More work to do first [17:22:37] edsanders: here's another fun thing -- the sequence matcher doesn't trigger on newline, since that doesn't fire onSurfaceObserverContentChange [17:22:59] edsanders: that's a bug? or should we be watching some other event for newline insertion? [17:24:03] yeah probably - you have to be careful where you place the listeners, as you can get in a lot of trouble if you have model events which trigger more model changes [17:24:06] edsanders: i tried triggering checkSequences onSurfaceObserverBranchNodeChange but that doesn't see to be the right fix. [17:24:15] *seem to be [17:25:16] you could just manually trigger it from handleLinearEnter [17:25:16] it seems to be triggered a lot during load, as opposed to onSurfaceObserverContentChange which seems to trigger only after everything is fully loaded. [17:32:30] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10MobileFrontend-Feature-requests, 5WMF-deploy-2015-08-11_(1.26wmf18), 7user-notice: Provide VisualEditor regardless of device size - https://phabricator.wikimedia.org/T85630#1518817 (10Jdforrester-WMF) 5Open>3Resolved a:3Esanders [17:34:13] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10MobileFrontend-Feature-requests, 5WMF-deploy-2015-08-11_(1.26wmf18), 7user-notice: Provide VisualEditor regardless of device size - https://phabricator.wikimedia.org/T85630#951148 (10Jdforrester-WMF) As of https://gerrit.wikimedia.org/r/230077 all device... [17:35:13] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10MobileFrontend-Feature-requests, 5WMF-deploy-2015-08-11_(1.26wmf18), 7user-notice: Provide VisualEditor regardless of device size - https://phabricator.wikimedia.org/T85630#1518838 (10Jdforrester-WMF) [17:35:13] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 7Epic: Make VisualEditor good enough for mobile tablet and phone enablement - https://phabricator.wikimedia.org/T94725#1518839 (10Jdforrester-WMF) [17:35:55] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10MobileFrontend-Feature-requests, 5WMF-deploy-2015-08-11_(1.26wmf18), 7user-notice: Provide VisualEditor regardless of device size - https://phabricator.wikimedia.org/T85630#1518845 (10Florian) For completeness, that's how it looks on an emulated Nexus 5:... [17:36:03] (03CR) 10Alex Monk: "Makes sense, but what is this for/is there a task?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230083 (owner: 10Esanders) [17:36:51] edsanders: How much of https://phabricator.wikimedia.org/T96186 is left to do? Just https://phabricator.wikimedia.org/T88559 ? [17:36:53] "Just". [17:37:56] (03PS1) 10Esanders: Use short save messages in mobile save dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230136 [17:38:48] something like that [17:38:52] (03PS2) 10Jforrester: MWMobileSaveDialog: Use short save messages for space [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230136 (owner: 10Esanders) [17:38:59] (03CR) 10Jforrester: [C: 032] MWMobileSaveDialog: Use short save messages for space [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230136 (owner: 10Esanders) [17:39:07] edsanders: Cool. [17:39:19] edsanders: Is https://gerrit.wikimedia.org/r/#/c/203478/ useful for that? [17:39:33] for now it'll be duplicating code we rely on in Editor.js into the mobile target [17:39:45] (03CR) 10Jforrester: "Used by https://gerrit.wikimedia.org/r/#/c/230085/" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230083 (owner: 10Esanders) [17:39:51] * James_F nods. [17:40:28] VE won't be a dialog [17:40:49] (03PS2) 10Alex Monk: Emit blur/focus events from the surface model [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230083 (owner: 10Esanders) [17:40:59] I'm just going to keep separating it until the MF loader is just "append VE target to the body and hide everything else" [17:41:09] edsanders: "full screen" dialog? [17:41:16] (03Merged) 10jenkins-bot: MWMobileSaveDialog: Use short save messages for space [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230136 (owner: 10Esanders) [17:41:41] (03CR) 10Alex Monk: [C: 032] Emit blur/focus events from the surface model [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230083 (owner: 10Esanders) [17:42:24] edsanders: Did you not want to merge https://gerrit.wikimedia.org/r/#/c/222488/ in case David wants to change it? [17:42:53] I'll ask him [17:45:43] (03CR) 10jenkins-bot: [V: 04-1] Emit blur/focus events from the surface model [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230083 (owner: 10Esanders) [17:46:05] edsanders: Thanks. [17:48:32] edsanders, so what's the purpose of https://gerrit.wikimedia.org/r/#/c/230085/2 ? [17:51:55] (03PS1) 10Jforrester: Update VE core submodule to master (07288e0) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230143 [17:52:11] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Reading-Web, 7Technical-Debt: VisualEditorOverlay should be written as an OO.ui.ProcessDialog - https://phabricator.wikimedia.org/T88559#1518906 (10Esanders) Not sure this will necessarily be the best approach... [17:52:32] (03PS3) 10Jforrester: Switch to using surface model focus/blur events [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230085 (owner: 10Esanders) [17:52:34] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10OOjs-UI: OOjs UI: "Back" button support for dialogs - https://phabricator.wikimedia.org/T73488#1518907 (10Esanders) [17:52:51] (03CR) 10Jforrester: "PS3: Rebase of PS2 onto the required pull-through." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230085 (owner: 10Esanders) [17:53:17] 10VisualEditor: Redirect should remain on the first line (odd result from list formatting on redirect) - https://phabricator.wikimedia.org/T108354#1518914 (10Whatamidoing-WMF) 3NEW [17:55:00] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10OOjs-UI, 5OOjs-UI-next-release: List tool popup not visible on narrow screens - https://phabricator.wikimedia.org/T108344#1518928 (10Jdforrester-WMF) 5Open>3Resolved [17:55:23] hey James_F, asking here because I don't know where else, but... you know that issue where a table's separator lines sometimes disappear/reappear depending on if you zoom in/out? I guess, is that known, generally? [17:55:55] I don't think that's a VE-specific issue, is it? [17:56:56] no [17:57:03] it's a table issue, but since ya'll know tables.... [17:57:19] (is there a #wikimedia-reading that is actually used?) [17:57:39] Irssi: #wikimedia-reading: Total of 1 nicks [1 ops, 0 halfops, 0 voices, 0 normal] [17:57:42] nope [17:59:09] also, you're just my "knows all the little issues that have been issues for 5 years" goto [17:59:59] I think they have a mailing list instead [18:02:04] (03PS1) 10Cscott: WIP: support RegExp sequences; trigger sequence matcher after newline. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230144 [18:02:06] (03PS1) 10Cscott: WIP: autolink URLs. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230145 [18:05:12] (03CR) 10jenkins-bot: [V: 04-1] WIP: support RegExp sequences; trigger sequence matcher after newline. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230144 (owner: 10Cscott) [18:05:24] (03CR) 10jenkins-bot: [V: 04-1] WIP: autolink URLs. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230145 (owner: 10Cscott) [18:14:56] 10VisualEditor, 10VisualEditor-CopyPaste, 10Parsoid: Pasted lists of multiple lines are treated as one list item with
- https://phabricator.wikimedia.org/T108357#1519016 (10Whatamidoing-WMF) 3NEW [18:20:20] (03PS1) 10Cscott: WIP: Detect pastes of wikitext or bare autolinks and auto-convert them. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230146 [18:20:50] 10VisualEditor, 10VisualEditor-MediaWiki-References, 10Parsoid: Bare unlinked URLs added "manually" via the Cite tool get intentionally 'd by Parsoid - https://phabricator.wikimedia.org/T107431#1519049 (10cscott) https://gerrit.wikimedia.org/r/230145 addresses (1) -- autolink support in VE. https://g... [18:21:45] 10VisualEditor, 10VisualEditor-CopyPaste, 10Parsoid: Pasted lists of multiple lines are treated as one list item with
- https://phabricator.wikimedia.org/T108357#1519064 (10Arlolra) Related to T106722 [18:22:40] (03CR) 10jenkins-bot: [V: 04-1] WIP: Detect pastes of wikitext or bare autolinks and auto-convert them. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230146 (owner: 10Cscott) [18:22:53] Krenair, the view events are subtly different [18:24:33] also the model is the authority - so going by that is more reliable [18:26:04] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10OOjs-UI, 5OOjs-UI-next-release: List tool popup not visible on narrow screens - https://phabricator.wikimedia.org/T108344#1519112 (10Jdforrester-WMF) p:5Triage>3High [18:26:10] (03PS2) 10Cscott: WIP: autolink URLs. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230145 [18:26:12] (03PS2) 10Cscott: WIP: support RegExp sequences; trigger sequence matcher after newline. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230144 [18:26:43] edsanders, we were already using the surface model [18:26:56] this is just switching from the select event to focus/blur [18:27:07] oh that difference [18:27:18] yeah focus/blur only fire when the selection changes from/to null [18:27:48] select fires on every selection change, and doesn't tell you the old selection [18:29:05] (03PS2) 10Cscott: WIP: Detect pastes of wikitext or bare autolinks and auto-convert them. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230146 [18:29:21] (03CR) 10Alex Monk: [C: 032] Switch to using surface model focus/blur events [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230085 (owner: 10Esanders) [18:30:09] edsanders: i'm interested in early input on https://gerrit.wikimedia.org/r/230144 (regexp sequences) [18:30:16] (03CR) 10Esanders: "in MW we can also use ve.init.platform.getExternalLinkUrlProtocolsRegExp()" (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230145 (owner: 10Cscott) [18:33:18] (03CR) 10Eranroz: "Consider also:" (033 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230146 (owner: 10Cscott) [18:35:00] (03CR) 10Esanders: "If we've passed in plainText, we don't need to pass in the linear data as well." (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230144 (owner: 10Cscott) [18:35:25] (03CR) 10Cscott: "At the moment I was sticking to http and friends because that makes it MW independent. Any HTML editor will want to link those. The MW-s" (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230145 (owner: 10Cscott) [18:38:37] (03CR) 10Cscott: WIP: support RegExp sequences; trigger sequence matcher after newline. (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230144 (owner: 10Cscott) [18:39:26] (03CR) 10Esanders: WIP: Detect pastes of wikitext or bare autolinks and auto-convert them. (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230146 (owner: 10Cscott) [18:40:49] 10VisualEditor: VisualEditor: Coordinates template is displaying in the wrong place - https://phabricator.wikimedia.org/T67648#1519198 (10Whatamidoing-WMF) Today in (try here: https://en.wikipedia.org/wiki/Burpengary_Creek?veaction=edit ) it is on the far right, so far right that there is no margin between the... [18:41:50] (03CR) 10Cscott: "This is currently in VE-MW, which is not part of core VE." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230146 (owner: 10Cscott) [18:44:22] (03CR) 10Esanders: "I think Eranroz meant VE-MW vs VE-WMF. For now we leave it in VE-MW, but being just one file it should be easy to separate later." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230146 (owner: 10Cscott) [18:45:48] (03CR) 10Esanders: "Re: tests, have a look at DSVFileTransferHandler.test.js" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230146 (owner: 10Cscott) [18:48:15] (03CR) 10Cscott: "thanks all, very helpful." (034 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230146 (owner: 10Cscott) [18:48:46] (03CR) 10Esanders: "That's the beatuy of ve.init.platform :) In standalone it will just return /^https?\:\/\//, whereas in MW it will return wgUrlProtocols." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230145 (owner: 10Cscott) [18:50:35] edsanders: do you have some form of RegExp join available in VE? Parsoid has https://github.com/wikimedia/parsoid/blob/master/lib/jsutils.js#L100 which is very useful in pasting together wgUrlProtocols with the rest of the needed regexp. [18:51:34] (03CR) 10Esanders: WIP: support RegExp sequences; trigger sequence matcher after newline. (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230144 (owner: 10Cscott) [18:52:12] cscott, what for? [18:52:35] oh I see [18:52:48] would it be that bad just to run two regexes? [18:53:17] although that leading ^ in wgUrlProtocols is a pain in any case, parsoid has both anchored and unanchored forms: https://github.com/wikimedia/parsoid/blob/master/lib/mediawiki.WikiConfig.js#L422 [18:53:59] edsanders: it's certainly the case that the autolinkUrl command could take a second look at the url string and decide not to take any action. [18:54:06] (03CR) 10Eranroz: WIP: Detect pastes of wikitext or bare autolinks and auto-convert them. (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230146 (owner: 10Cscott) [18:55:06] edsanders: so maybe the solution is just to use a very general protocol matcher and let autolinkUrl handle the subtleties [18:55:57] (03CR) 10Eranroz: WIP: Detect pastes of wikitext or bare autolinks and auto-convert them. (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230146 (owner: 10Cscott) [18:57:32] (03CR) 10Esanders: WIP: Detect pastes of wikitext or bare autolinks and auto-convert them. (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230146 (owner: 10Cscott) [19:00:43] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki-Links: VisualEditor: Ctrl-Click / middle-click on a link should open it in another window; on an image, should open the image's description page - https://phabricator.wikimedia.org/T52321#1519277 (10Quiddity) Note/update: Using ctrl-cli... [19:02:00] (03CR) 10Cscott: WIP: Detect pastes of wikitext or bare autolinks and auto-convert them. (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230146 (owner: 10Cscott) [19:04:45] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki-Links: VisualEditor: Ctrl-Click / middle-click on a link should open it in another window; on an image, should open the image's description page - https://phabricator.wikimedia.org/T52321#1519306 (10Quiddity) [19:06:37] (03CR) 10Cscott: "How about RFC/ISBN/PMID? Is there a ve.init.platform.getMagicWordsRegExp? Or is (a) monkey patching the VE link action, or (b) adding a " [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230145 (owner: 10Cscott) [19:08:00] cscott: There isn't. [19:08:52] James_F: maybe it's worth adding something like that, because I think in the future certain wikis would like to disable the magic words too. [19:09:08] Can they actually be disabled in MW? [19:09:11] (Or expanded?) [19:09:16] James_F: so all that can be hidden inside VE-MW (via whatever config option is exposed to say "no we don't want magic words") [19:09:25] they can't be disabled... yet. [19:09:36] but there's a long-standing bug to allow them to be disabled. [19:09:59] I'd much rather they were removed from core and turned into some actual syntax. [19:10:03] {{ISBN:12345}} [19:10:11] yeah, i think that's part of why it hasn't been done yet [19:10:14] Or whatever. [19:10:21] Extension-ified. [19:10:36] nobody wants to actually just make them configurable, they want to yank them out of core entirely and make it into a parser extension or something like that [19:10:37] But that's impossible given the current way it 'works' in the parser, I assume. [19:10:40] but the bikeshedding on the [19:10:42] i actually like the ISBN auto linking by core, this is mroe native than {{ISBN:XXX}} [19:10:44] "something like that" is endless. [19:10:51] cscott: Ha. [19:11:04] eranroz: Isn't it rather user-surprising, surely? [19:11:40] user should be surprised of having autolinks to http://XXX? this is similar case [19:11:57] Yes, plausibly. [19:12:10] Most of wikitext is user-surprising, however. [19:12:18] Moving to HTML storage is the most sane approach. :-) [19:27:08] Krenair: When you get a moment, could you look at https://gerrit.wikimedia.org/r/#/c/189178/ ? It looks like it could replace the BLP hacks for enwiki edit notices in a way that works for VE and reduces client-side load, but it's had no code review… [19:33:04] James_F, the whole editintro=Template:BLP_editintro thing? [19:34:41] (I managed to mostly avoid dealing with their edit notice stuff, poor Krinkle_ though...) [19:35:39] Krenair: Yes. [19:56:35] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10OOjs-UI, 5OOjs-UI-next-release: ProcessDialog fitLabel doesn't work for relative widths (e.g. full screen 100%) - https://phabricator.wikimedia.org/T108326#1519421 (10Jdforrester-WMF) 5Open>3Resolved a:3Esanders [19:58:55] edsanders: https://gerrit.wikimedia.org/r/#/c/230216/1/modules/ve-mw/i18n/de.json [19:58:59] edsanders: 16 characters for 'short'. [19:59:02] * James_F sighs. [19:59:57] neilpquinn, Editing session analysis for VE test: https://meta.wikimedia.org/wiki/Research_talk:VisualEditor%27s_effect_on_newly_registered_editors/Work_log/2015-05-28#Edit_session_stats [20:00:03] ffs [20:00:11] This is where I develop the metric strategy during the pilot [20:09:54] neilpquinn, did you see the message above? [20:10:08] Halfak, yes, I did. Looking at it. [20:10:42] kk. Just wanted to check off the todo item :) [20:20:49] halfak: what library are you using in your code snippets here? https://meta.wikimedia.org/wiki/Research_talk:VisualEditor's_effect_on_newly_registered_editors/Work_log/2015-05-28#Edit_success [20:23:30] R [20:23:54] https://github.com/halfak/VE_newcomers_May_2015 [20:24:07] https://github.com/halfak/VE_newcomers_May_2015/blob/master/R/edit_success/plots_and_tables.R [20:24:34] Actually the stuff you see in the write-up is probably in this file: https://github.com/halfak/VE_newcomers_May_2015/blob/master/R/edit_success/experiment.R [21:01:59] (03CR) 10Esanders: [C: 032] Update VE core submodule to master (07288e0) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230143 (owner: 10Jforrester) [21:04:59] (03Merged) 10jenkins-bot: Update VE core submodule to master (07288e0) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230143 (owner: 10Jforrester) [21:05:03] (03Merged) 10jenkins-bot: Switch to using surface model focus/blur events [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230085 (owner: 10Esanders) [21:38:56] (03PS6) 10Jforrester: build: Bump grunt-jscs to 2.0.0 and make pass [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/227885 [21:41:01] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki-Links, 6Collaboration-Team-Backlog, and 2 others: VisualEditor: Ctrl-Click / middle-click on a link should open it in another window; on an image, should open the image's description pa... - https://phabricator.wikimedia.org/T52321#1519780 [21:43:29] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-Links, 7Tracking, 5VisualEditor pre-2015 work: VisualEditor: Improvements and behaviour changes to the link input widget (tracking) - https://phabricator.wikimedia.org/T50789#1519796 (10Jdforrester-WMF) [21:43:31] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki-Links, 6Collaboration-Team-Backlog, and 2 others: VisualEditor: Ctrl-Click / middle-click on a link should open it in another window; on an image, should open the image's description pa... - https://phabricator.wikimedia.org/T52321#1519793 [22:01:20] Some of that getParentCategories stuff is from 2004 or earlier :/ [22:02:30] Maybe we should re-write the old SVN link notes to point to Phabricator at some point. . . [22:42:29] Krenair: Maybe. [22:56:28] 10VisualEditor, 6Community-Liaison: Write August 2015 newsletter for VisualEditor - https://phabricator.wikimedia.org/T108401#1520060 (10Whatamidoing-WMF) 3NEW a:3Whatamidoing-WMF [22:56:54] 10VisualEditor, 6Community-Liaison: Write August 2015 newsletter for VisualEditor - https://phabricator.wikimedia.org/T108401#1520070 (10Jdforrester-WMF) [22:57:51] 10VisualEditor, 6Community-Liaison: Send the August 2015 newsletter for VisualEditor - https://phabricator.wikimedia.org/T108402#1520073 (10Whatamidoing-WMF) 3NEW a:3Elitre [22:58:03] 10VisualEditor, 6Community-Liaison: Send the August 2015 newsletter for VisualEditor - https://phabricator.wikimedia.org/T108402#1520080 (10Jdforrester-WMF)