[00:52:07] (03PS4) 10Cscott: WIP: autolink URLs. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230145 [00:52:09] (03PS4) 10Cscott: WIP: support RegExp sequences; trigger sequence matcher after newline. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230144 [00:52:45] (03PS7) 10Cscott: Detect paste of wikitext or bare autolinkable text and convert it. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230146 [00:52:47] (03PS1) 10Cscott: Add ve.ui.LinkAction and unanchoredExternalLinkProtocolsRegExp [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230476 [00:54:09] (03CR) 10Cscott: "I added a test case." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230146 (owner: 10Cscott) [00:54:37] (03CR) 10jenkins-bot: [V: 04-1] Add ve.ui.LinkAction and unanchoredExternalLinkProtocolsRegExp [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230476 (owner: 10Cscott) [00:54:55] (03CR) 10jenkins-bot: [V: 04-1] WIP: autolink URLs. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230145 (owner: 10Cscott) [00:55:01] (03CR) 10jenkins-bot: [V: 04-1] Detect paste of wikitext or bare autolinkable text and convert it. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230146 (owner: 10Cscott) [01:29:49] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-Links: VisualEditor: Link input widget should recognise input text that look like urls without protocol as external links (e.g. "www.example.org/foo") - https://phabricator.wikimedia.org/T52360#1523127 (10Krenair) So we now have a separate... [01:32:53] 10VisualEditor, 10VisualEditor-MediaWiki: Stop the user from adding a langlink when we think they wanted to insert an interwiki instead - https://phabricator.wikimedia.org/T103635#1523129 (10Krenair) [01:33:10] 10VisualEditor: VisualEditor doesn't colon-prefix interwiki links when needed, causing them to become language links - https://phabricator.wikimedia.org/T101406#1523132 (10Krenair) Are this and {T103635} duplicates of {T95850}? [01:45:56] 10VisualEditor: VE introduces tables with weird href attributes - https://phabricator.wikimedia.org/T108506#1523160 (10Lfstevens) I indeed used copy/paste to add a table to Solar cycle. [03:08:18] (03CR) 10Cscott: "Failing jenkins because it depends on I21976ce0cc823af29bdd2a5c163476fea2408488" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230476 (owner: 10Cscott) [03:09:11] (03CR) 10Cscott: "I26904c85cad5de45856f1e1eea45fa14cafcbfe3 is a corresponding patch to the ve-mw repo to add the new files." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230145 (owner: 10Cscott) [04:49:49] 10VisualEditor: Lines grouped together - https://phabricator.wikimedia.org/T108550#1523255 (10NicoV) 3NEW [05:05:25] (03PS3) 10Cscott: Allow more than one DataTransferHandler to match a given item. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230310 [05:05:27] (03PS5) 10Cscott: Autolink URLs when typing. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230145 [05:05:29] (03PS5) 10Cscott: Support RegExp sequences; trigger sequence matcher after newline. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230144 [05:05:31] (03PS1) 10Cscott: Update CONTRIBUTING.md [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230488 [05:05:33] (03PS1) 10Cscott: Add a mechanism to wait until ve.init.platform has been created [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230489 [05:28:07] (03PS1) 10Cscott: DONT PUSH: jenkins test failure debugging [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230491 [05:29:48] (03CR) 10jenkins-bot: [V: 04-1] DONT PUSH: jenkins test failure debugging [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230491 (owner: 10Cscott) [05:33:25] 10VisualEditor, 6Discovery, 3Discovery-Cirrus-Sprint: index appears to be missing from search API responses if the page is a resolved redirect - https://phabricator.wikimedia.org/T108554#1523323 (10Deskana) 3NEW [05:34:54] 10VisualEditor: Image file name can't be changed in the visual editor - https://phabricator.wikimedia.org/T108555#1523331 (10benjli) 3NEW a:3Amire80 [05:35:00] 10VisualEditor, 6Discovery, 3Discovery-Cirrus-Sprint: index appears to be missing from search API responses if the page is a resolved redirect - https://phabricator.wikimedia.org/T108554#1523339 (10Deskana) [05:37:13] 10VisualEditor: Image file name can't be changed in the visual editor - https://phabricator.wikimedia.org/T108555#1523342 (10Krenair) a:5Amire80>3None [05:37:30] 10VisualEditor, 10VisualEditor-Media, 10VisualEditor-MediaWiki-Media: Image file name can't be changed in the visual editor - https://phabricator.wikimedia.org/T108555#1523331 (10Krenair) [05:39:53] 10VisualEditor, 6Discovery, 3Discovery-Cirrus-Sprint: index appears to be missing from search API responses if the page is a resolved redirect - https://phabricator.wikimedia.org/T108554#1523346 (10Deskana) It may be wise to add some code into VisualEditor to deal with the possibility that the results come b... [05:45:19] 10VisualEditor, 10VisualEditor-Media, 10VisualEditor-MediaWiki-Media: Image file name can't be changed in the visual editor - https://phabricator.wikimedia.org/T108555#1523352 (10Amire80) 5Open>3Invalid a:3Amire80 It's already possible. Open the image for editing and click the "Change image" button at... [05:50:35] 10VisualEditor, 6Discovery, 3Discovery-Cirrus-Sprint: index appears to be missing from search API responses if the page is a resolved redirect - https://phabricator.wikimedia.org/T108554#1523355 (10Deskana) p:5Normal>3High [05:51:18] 10VisualEditor, 6Discovery, 10MediaWiki-API, 3Discovery-Cirrus-Sprint: index appears to be missing from search API responses if the page is a resolved redirect - https://phabricator.wikimedia.org/T108554#1523323 (10Deskana) [06:54:48] (03PS2) 10Cscott: DONT PUSH: jenkins test failure debugging [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230491 [06:54:50] (03PS1) 10Cscott: WIP: use mocks to test auto-convert paste [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230493 [06:58:49] (03CR) 10jenkins-bot: [V: 04-1] WIP: use mocks to test auto-convert paste [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230493 (owner: 10Cscott) [06:59:54] (03CR) 10jenkins-bot: [V: 04-1] DONT PUSH: jenkins test failure debugging [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230491 (owner: 10Cscott) [07:12:13] (03PS2) 10Cscott: WIP: use mocks to test auto-convert paste [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230493 [07:12:15] (03PS3) 10Cscott: DONT PUSH: jenkins test failure debugging [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230491 [07:14:44] (03CR) 10jenkins-bot: [V: 04-1] WIP: use mocks to test auto-convert paste [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230493 (owner: 10Cscott) [07:15:29] (03CR) 10jenkins-bot: [V: 04-1] DONT PUSH: jenkins test failure debugging [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230491 (owner: 10Cscott) [07:22:00] (03PS2) 10Cscott: Add ve.ui.LinkAction and unanchoredExternalLinkProtocolsRegExp [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230476 [07:22:02] (03PS8) 10Cscott: Detect paste of wikitext or bare autolinkable text and convert it. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230146 [07:22:42] (03Abandoned) 10Cscott: WIP: use mocks to test auto-convert paste [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230493 (owner: 10Cscott) [07:22:57] (03Abandoned) 10Cscott: DONT PUSH: jenkins test failure debugging [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230491 (owner: 10Cscott) [07:23:32] (03CR) 10jenkins-bot: [V: 04-1] Add ve.ui.LinkAction and unanchoredExternalLinkProtocolsRegExp [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230476 (owner: 10Cscott) [08:12:35] 10VisualEditor, 6Community-Liaison: Send the August 2015 newsletter for VisualEditor - https://phabricator.wikimedia.org/T108402#1523507 (10Elitre) Thank you. I have now ported the newsletter there and marked it for translation. Will announce it later today though: as we need to deliver Translathon barnstars,... [08:25:00] (03PS6) 10Cscott: Autolink URLs when typing. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230145 [08:33:04] 10VisualEditor: Non-finalised input is added to the document when using the Anthy Japanese IME with VisualEditor - https://phabricator.wikimedia.org/T108566#1523518 (10MrStradivarius) 3NEW [08:37:44] 10VisualEditor: Non-finalised input is added to the document when using the Anthy Japanese IME with VisualEditor - https://phabricator.wikimedia.org/T108566#1523525 (10MrStradivarius) [08:43:53] 10VisualEditor: Non-finalised input is added to the document when using the Anthy Japanese IME with VisualEditor - https://phabricator.wikimedia.org/T108566#1523533 (10MrStradivarius) [08:58:36] 10VisualEditor: Non-finalised input is added to the document when using the Anthy Japanese IME with VisualEditor - https://phabricator.wikimedia.org/T108566#1523545 (10MrStradivarius) More about issue #2: I've noticed that this isn't the same across all Ubuntu apps. If you click somewhere else before finalising... [10:28:21] 10VisualEditor, 10VisualEditor-ContentLanguage: Word breaking rules used in VisualEditor do not work optimally in Japanese - https://phabricator.wikimedia.org/T101917#1523647 (10MrStradivarius) >>! In T101917#1352218, @dchan wrote: > Is "longest character set run" actually a good rule for Japanese? Or just the... [11:50:54] 10VisualEditor, 6Discovery, 10MediaWiki-API, 3Discovery-Cirrus-Sprint: index appears to be missing from search API responses if the page is a resolved redirect - https://phabricator.wikimedia.org/T108554#1523696 (10Dbrant) ...duplicate? T92796 [12:03:23] 10VisualEditor, 6Discovery, 10MediaWiki-API, 3Discovery-Cirrus-Sprint: index appears to be missing from search API responses if the page is a resolved redirect - https://phabricator.wikimedia.org/T108554#1523707 (10Dbrant) p.s. The Android app has been dealing with `index`-less search results for a while n... [12:06:37] 10VisualEditor, 6Discovery, 10MediaWiki-API, 3Discovery-Cirrus-Sprint: index appears to be missing from search API responses if the page is a resolved redirect - https://phabricator.wikimedia.org/T108554#1523711 (10dcausse) a:3dcausse [12:13:34] 10VisualEditor, 6Discovery, 10MediaWiki-API, 3Discovery-Cirrus-Sprint: index appears to be missing from search API responses if the page is a resolved redirect - https://phabricator.wikimedia.org/T108554#1523714 (10Dbrant) [12:32:32] (03PS2) 10Esanders: Provide a context item for table cells in mobile [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230397 (https://phabricator.wikimedia.org/T108514) [12:32:34] (03PS1) 10Esanders: Separate SA target into Mobile and Desktop [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230522 [12:32:36] (03PS1) 10Esanders: Move toolbar floating code up to the target [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230523 [12:35:17] (03CR) 10jenkins-bot: [V: 04-1] Separate SA target into Mobile and Desktop [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230522 (owner: 10Esanders) [12:35:19] (03CR) 10jenkins-bot: [V: 04-1] Provide a context item for table cells in mobile [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230397 (https://phabricator.wikimedia.org/T108514) (owner: 10Esanders) [12:35:21] (03CR) 10jenkins-bot: [V: 04-1] Move toolbar floating code up to the target [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230523 (owner: 10Esanders) [12:36:40] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: iOS scrolls the cursor off the page if it is near the top of the page - https://phabricator.wikimedia.org/T108576#1523808 (10Esanders) 3NEW [12:44:07] (03PS2) 10Esanders: Separate SA target into Mobile and Desktop [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230522 [12:44:09] (03PS3) 10Esanders: Provide a context item for table cells in mobile [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230397 (https://phabricator.wikimedia.org/T108514) [12:44:11] (03PS2) 10Esanders: Move toolbar floating code up to the target [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230523 [12:46:10] (03PS3) 10Esanders: Separate SA target into Mobile and Desktop [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230522 [12:47:14] (03PS1) 10Esanders: [PULL THROUGH] Target handles toolbar floating [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230528 [12:47:44] (03CR) 10jenkins-bot: [V: 04-1] Move toolbar floating code up to the target [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230523 (owner: 10Esanders) [12:48:35] (03CR) 10Alex Monk: [C: 032] Ensure demo init script runs last [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230395 (owner: 10Esanders) [12:50:45] (03CR) 10jenkins-bot: [V: 04-1] [PULL THROUGH] Target handles toolbar floating [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230528 (owner: 10Esanders) [12:52:48] (03Merged) 10jenkins-bot: Ensure demo init script runs last [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230395 (owner: 10Esanders) [13:02:09] (03CR) 10Alex Monk: [C: 04-1] Separate SA target into Mobile and Desktop (033 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230522 (owner: 10Esanders) [13:02:48] (03CR) 10Alex Monk: Separate SA target into Mobile and Desktop (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230522 (owner: 10Esanders) [13:04:40] (03PS4) 10Esanders: Separate SA target into Mobile and Desktop [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230522 [13:04:53] (03CR) 10Esanders: Separate SA target into Mobile and Desktop (035 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230522 (owner: 10Esanders) [13:06:57] edsanders, where are you using the emit event from https://gerrit.wikimedia.org/r/#/c/230294/4 ? [13:07:08] resize event* [13:12:22] (03CR) 10Esanders: [C: 04-1] Autolink URLs when typing. (033 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230145 (owner: 10Cscott) [13:25:15] (03CR) 10Esanders: [C: 04-1] Detect paste of wikitext or bare autolinkable text and convert it. (035 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230146 (owner: 10Cscott) [13:26:35] (03CR) 10Esanders: "Looks good but could do with some unit tests now (like ModelRegistry.test)" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230310 (owner: 10Cscott) [13:29:52] (03CR) 10Esanders: [C: 04-1] Support RegExp sequences; trigger sequence matcher after newline. (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230144 (owner: 10Cscott) [13:44:27] Krenair, MobileFrontend [13:45:16] specifically https://gerrit.wikimedia.org/r/#/c/230399/2/resources/mobile.editor.ve/ve.init.mw.MobileFrontendArticleTarget.js [13:46:14] 10VisualEditor: Lines concatenanted and losing breaks (grouped together) after edit on fr.wp - https://phabricator.wikimedia.org/T108550#1523965 (10Aklapper) [13:47:44] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-Performance, 10RESTBase: VisualEditor should load data-mw from a separate API call alongside the body content - https://phabricator.wikimedia.org/T88623#1523974 (10Esanders) Not really part of the //minimum// viable product. This is fairly large piec... [13:49:42] (03PS2) 10Esanders: Use new table cell context item in mobile [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230400 [13:49:44] (03PS5) 10Esanders: Mobile fixes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230300 [13:49:46] (03PS2) 10Esanders: [PULL THROUGH] Target handles toolbar floating [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230528 [13:49:48] (03PS3) 10Esanders: Centre tools in mobile [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230302 (https://phabricator.wikimedia.org/T92027) [13:49:56] (03CR) 10Alex Monk: [C: 032] Context emits resize events [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230294 (owner: 10Esanders) [13:50:21] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10OOjs-UI, 7Design, and 2 others: Make mobile toolbar wider where possible - https://phabricator.wikimedia.org/T92027#1523988 (10Esanders) [13:51:45] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10OOjs-UI, 7Design, and 2 others: Make mobile toolbar wider where possible - https://phabricator.wikimedia.org/T92027#1101767 (10Esanders) 5Open>3Resolved a:3Esanders The tagged commit centers the tools, but the toolbar is already reponsive width. [13:52:21] (03CR) 10jenkins-bot: [V: 04-1] Use new table cell context item in mobile [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230400 (owner: 10Esanders) [13:52:46] (03CR) 10jenkins-bot: [V: 04-1] [PULL THROUGH] Target handles toolbar floating [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230528 (owner: 10Esanders) [13:52:49] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: The editor switcher icon for Mobile VE has irregular highlight on focus from wikitext editor and stretched out in Mobile VE - https://phabricator.wikimedia.org/T107545#1523995 (10Esanders) 5Open>3Invalid a:3Esanders Tool has been moved. [13:53:37] (03Merged) 10jenkins-bot: Context emits resize events [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230294 (owner: 10Esanders) [13:53:58] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 7Browser-Support-Android-Google-Chrome: VE Mobile: Tapping words sometimes moves them to the lead section and makes them bold - https://phabricator.wikimedia.org/T71634#1524003 (10Esanders) Is this still reproduceable? [14:02:16] (03PS1) 10Esanders: Bring in MobileWindowManagers styles from MW-Minerva [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230544 [14:05:38] (03CR) 10jenkins-bot: [V: 04-1] Bring in MobileWindowManagers styles from MW-Minerva [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230544 (owner: 10Esanders) [14:15:44] (03PS2) 10Esanders: Bring in MobileWindowManagers styles from MW-Minerva [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230544 (https://phabricator.wikimedia.org/T96703) [14:19:02] (03CR) 10jenkins-bot: [V: 04-1] Bring in MobileWindowManagers styles from MW-Minerva [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230544 (https://phabricator.wikimedia.org/T96703) (owner: 10Esanders) [14:21:24] (03PS1) 10Esanders: Remove Minerva MobileWindowManager.css [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230548 (https://phabricator.wikimedia.org/T96703) [14:31:54] "" [14:31:56] (03PS5) 10Esanders: Separate SA target into Mobile and Desktop [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230522 [14:31:58] (03PS3) 10Esanders: Move toolbar floating code up to the target [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230523 [14:35:27] 10VisualEditor, 6Discovery, 10MediaWiki-API, 3Discovery-Cirrus-Sprint, 5Patch-For-Review: index appears to be missing from search API responses if the page is a resolved redirect - https://phabricator.wikimedia.org/T108554#1524067 (10Anomie) [14:35:45] 10VisualEditor, 6Discovery, 10MediaWiki-API, 3Discovery-Cirrus-Sprint, 5Patch-For-Review: index appears to be missing from search API responses if the page is a resolved redirect - https://phabricator.wikimedia.org/T108554#1523323 (10Anomie) >>! In T108554#1523696, @Dbrant wrote: > ...duplicate? T92796... [15:09:23] (03CR) 10Jforrester: [C: 032] Provide a context item for table cells in mobile [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230397 (https://phabricator.wikimedia.org/T108514) (owner: 10Esanders) [15:10:15] 10MediaWiki-extensions-Graph-VE: Weekly reports for "Enable VisualEditor support in Graph extension" - https://phabricator.wikimedia.org/T101119#1524134 (10ferdbold) [15:10:17] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 5WMF-deploy-2015-08-11_(1.26wmf18): Table cells not editable on mobile - https://phabricator.wikimedia.org/T108514#1524135 (10Jdforrester-WMF) 5Open>3Resolved [15:11:25] (03CR) 10Jforrester: [C: 031] Move toolbar floating code up to the target [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230523 (owner: 10Esanders) [15:12:43] (03Merged) 10jenkins-bot: Provide a context item for table cells in mobile [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230397 (https://phabricator.wikimedia.org/T108514) (owner: 10Esanders) [15:13:48] (03CR) 10Jforrester: [C: 031] Separate SA target into Mobile and Desktop [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230522 (owner: 10Esanders) [15:16:00] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 5Patch-For-Review: iOS scrolls the cursor off the page if it is near the top of the page - https://phabricator.wikimedia.org/T108576#1524156 (10Jdforrester-WMF) a:3Esanders [15:16:09] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 5Patch-For-Review: iOS scrolls the cursor off the page if it is near the top of the page - https://phabricator.wikimedia.org/T108576#1523808 (10Jdforrester-WMF) p:5Triage>3High [15:17:20] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References: Build a custom per-wiki per-template inserter tool for citation templates with URL/DOI/ISBN lookup - https://phabricator.wikimedia.org/T108521#1524163 (10Jdforrester-WMF) p:5Triage>3Lowest [15:18:28] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 5WMF-deploy-2015-08-11_(1.26wmf18): Table cells not editable on mobile - https://phabricator.wikimedia.org/T108514#1524167 (10Jdforrester-WMF) p:5Triage>3Normal [15:20:13] (03PS3) 10Jforrester: MobileWindowManager: Bring in styles from MW-Minerva [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230544 (https://phabricator.wikimedia.org/T96703) (owner: 10Esanders) [15:21:40] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 7Technical-Debt: Tech debt: Clean up "minerva" folder theme in VE-mw - https://phabricator.wikimedia.org/T96704#1524183 (10Jdforrester-WMF) {T96703} moves the stuff for the mobile window manager, but that leaves `ve.ui.MWParameterPage.css`. [15:22:57] 10VisualEditor, 10VisualEditor-EditingTools: Put cursor in the middle of 'encapsulate'-type special chars when inserted (instead of applied to a selection) - https://phabricator.wikimedia.org/T108540#1524187 (10Jdforrester-WMF) p:5Triage>3Low [15:23:32] (03CR) 10Jforrester: [C: 032] MobileWindowManager: Bring in styles from MW-Minerva [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230544 (https://phabricator.wikimedia.org/T96703) (owner: 10Esanders) [15:24:55] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10OOjs-UI: OOjs UI: "Back" button support for dialogs - https://phabricator.wikimedia.org/T73488#761639 (10Jdforrester-WMF) [15:25:34] 10VisualEditor, 10VisualEditor-ContentLanguage: Non-finalised input is added to the document when using the Anthy Japanese IME with VisualEditor - https://phabricator.wikimedia.org/T108566#1524200 (10Jdforrester-WMF) p:5Triage>3High [15:26:31] (03Merged) 10jenkins-bot: MobileWindowManager: Bring in styles from MW-Minerva [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230544 (https://phabricator.wikimedia.org/T96703) (owner: 10Esanders) [15:30:49] (03PS3) 10Jforrester: Update VE core submodule to master (58912e1) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230400 (owner: 10Esanders) [15:33:15] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (58912e1) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230400 (owner: 10Esanders) [15:41:25] 10VisualEditor, 6Discovery, 10MediaWiki-API, 10MediaWiki-Search, 3Discovery-Cirrus-Sprint: Prefix search API doesn't return "index" field when "redirects" is enabled. - https://phabricator.wikimedia.org/T92796#1524239 (10Jdforrester-WMF) [15:46:32] (03PS4) 10Jforrester: MobileArticleTarget: Centre toolbar tools [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230302 (https://phabricator.wikimedia.org/T92027) (owner: 10Esanders) [15:46:38] (03CR) 10Jforrester: [C: 032] MobileArticleTarget: Centre toolbar tools [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230302 (https://phabricator.wikimedia.org/T92027) (owner: 10Esanders) [15:47:27] (03CR) 10jenkins-bot: [V: 04-1] MobileArticleTarget: Add webkit touch scrolling to panels [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230300 (owner: 10Esanders) [15:48:02] (03PS4) 10Jforrester: Update VE core submodule to master (58912e1) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230400 (owner: 10Esanders) [15:48:14] (03Merged) 10jenkins-bot: MobileArticleTarget: Add webkit touch scrolling to panels [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230300 (owner: 10Esanders) [15:49:33] edsanders, James_F: I just tried with https://gerrit.wikimedia.org/r/#/c/230397/3 on my phone [15:49:45] It's not quite working for me.. [15:50:03] Krenair: Oh. It worked for me, if a bit oddly. What went wrong? [15:50:03] I select the cell and type, but the text doesn't show up [15:50:09] Android? [15:50:19] yes [15:50:24] The text goes in [15:50:33] I tested on an iPhone. Maybe that's it? [15:50:40] But does not display [15:51:20] Shows if you enter, backspace and then type another character [15:51:51] That's not good. [15:52:09] It's better than not being able to edit the cell at all [15:52:55] Yes. [15:53:01] But still not good. :-) [15:53:14] (03PS2) 10Jforrester: Remove Minerva MobileWindowManager.css [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230548 (https://phabricator.wikimedia.org/T96703) (owner: 10Esanders) [15:53:34] :) [15:53:47] (03CR) 10Jforrester: [C: 032] Remove Minerva MobileWindowManager.css [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230548 (https://phabricator.wikimedia.org/T96703) (owner: 10Esanders) [15:55:08] (03CR) 10Alex Monk: [C: 032] Update VE core submodule to master (58912e1) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230400 (owner: 10Esanders) [15:56:18] (03PS2) 10Jforrester: AlignableContextItem: Fix styling in mobile [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230411 (owner: 10Esanders) [15:56:24] (03CR) 10Jforrester: [C: 032] AlignableContextItem: Fix styling in mobile [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230411 (owner: 10Esanders) [15:57:35] (03Merged) 10jenkins-bot: Update VE core submodule to master (58912e1) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230400 (owner: 10Esanders) [15:57:38] (03Merged) 10jenkins-bot: Remove Minerva MobileWindowManager.css [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230548 (https://phabricator.wikimedia.org/T96703) (owner: 10Esanders) [15:59:43] (03Merged) 10jenkins-bot: AlignableContextItem: Fix styling in mobile [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230411 (owner: 10Esanders) [16:02:12] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 5Patch-For-Review, 7Technical-Debt, 5WMF-deploy-2015-08-11_(1.26wmf18): Tech debt: Move the "minerva" mobile css files to VisualEditor core - https://phabricator.wikimedia.org/T96703#1524296 (10Jdforrester-WMF) 5Open>3Resolved a:3Esanders [16:03:47] 10VisualEditor, 6Discovery, 10MediaWiki-API, 10MediaWiki-Search, and 2 others: Prefix search API doesn't return "index" field when "redirects" is enabled. - https://phabricator.wikimedia.org/T92796#1524299 (10EBernhardson) What if we add redirect handling 'modes'? With no value or an unknown value in the... [16:08:48] (03CR) 10Alex Monk: [C: 032] Separate SA target into Mobile and Desktop [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230522 (owner: 10Esanders) [16:09:23] Krenair, works on my nexus 5 [16:09:52] Let's not have any issues specific to particular vendors or models, please. [16:09:57] That would be very sad. [16:10:13] Krenair, you using Chrome+Android4/5? [16:10:42] Chrome+Android4.3 [16:11:45] Chrome 44 [16:12:41] does it work in ve standalone mobile? [16:17:18] edsanders, nope, same issue there [16:17:33] is there a cursor visible? [16:17:37] no [16:17:44] but you can type? [16:17:46] and it goes in the model? [16:19:18] I can type, and it clearly gets recorded as you'd expect [16:19:28] just not shown until you fiddle around with it [16:19:48] pressing space causes the keyboard to disappear, the cursor to appear and a space to become visible. [16:20:10] (after typing some invisible text) [16:20:55] crazy [16:21:12] got access to another Android? [16:21:36] will have a look on crossbrowsertesting [16:21:48] I'll see what I can get [16:25:56] works on chrome 38 + android4.4 + nexus 5 (crossbrowsertesting) [16:27:06] I think I managed to break something else in the process [16:27:16] 10VisualEditor, 6Discovery, 10MediaWiki-API, 10MediaWiki-Search, and 2 others: Prefix search API doesn't return "index" field when "redirects" is enabled. - https://phabricator.wikimedia.org/T92796#1524353 (10Deskana) >>! In T92796#1524299, @EBernhardson wrote: > What if we add redirect handling 'modes'?... [16:28:25] now when I type the space I get a ♚ [16:29:22] A black chess king? [16:30:11] yes [16:30:53] well that's odd...now we can play chess on WIkipedia...oh I just got a great idea :P [16:31:31] Krenair, all the devices on CBT work [16:37:06] edsanders, reproduced the issue on my brother's tablet against en.m.wikipedia.beta.wmflabs.org [16:38:56] Chrome 44 on a nvidia shield tablet [16:48:13] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Making an image Frameless with out any wrap option deletes the content of the caption - https://phabricator.wikimedia.org/T68808#1524442 (10ssastry) [16:52:57] (03PS9) 10Divec: Cursoring: find adjacent position in DOM order [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/217222 [16:56:26] (03PS16) 10Divec: WIP: Explicitly enter/exit link annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/217257 [16:57:11] (03PS15) 10Divec: ve.ce.adjustLinkSelection: fixup link-bisecting selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/222488 [17:00:24] (03PS11) 10Divec: Fixup link selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/222619 [17:08:36] 10VisualEditor, 6Community-Liaison: Send the August 2015 newsletter for VisualEditor - https://phabricator.wikimedia.org/T108402#1524518 (10Elitre) #2 is now done. [17:11:01] 10VisualEditor, 6Discovery, 10MediaWiki-API, 10MediaWiki-Search, and 2 others: Prefix search API doesn't return "index" field when "redirects" is enabled. - https://phabricator.wikimedia.org/T92796#1524519 (10EBernhardson) @Deskana the problem with making anything the default parameter is that this redirec... [17:13:53] 10VisualEditor, 10Parsoid: Paragraph after a list was added to the last list item - https://phabricator.wikimedia.org/T108595#1524528 (10Whatamidoing-WMF) 3NEW [17:15:21] Krenair, which page? [17:15:37] does http://en.wikipedia.beta.wmflabs.org/wiki/Table work? [17:15:57] http://en.wikipedia.beta.wmflabs.org/wiki/N [17:23:24] ew - empty cells [17:23:32] does it work with a proper table? [17:25:06] edsanders, I can take a cell with text in it, remove all the text, and reproduce the same issue [17:25:25] so it only breaks in empty cells? [17:25:31] only happens when you start your edit from an empty cell [17:27:13] 10VisualEditor, 6Discovery, 10MediaWiki-API, 10MediaWiki-Search, and 2 others: Prefix search API doesn't return "index" field when "redirects" is enabled. - https://phabricator.wikimedia.org/T92796#1524609 (10Deskana) >>! In T92796#1524519, @EBernhardson wrote: > @Deskana the problem with making anything t... [17:27:46] ok, can you file that then? [17:29:39] (03CR) 10Jforrester: "Love it." (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/217257 (owner: 10Divec) [17:30:33] ok [17:39:22] Krenair: Is https://phabricator.wikimedia.org/T107674#1522285 enough for you? [17:40:55] I'm not quite clear [17:41:15] OK, it's not just me. ;-) [17:41:21] "I'll know it when I see it", it seems. [17:41:27] it already lets you select an item by typing the value [17:41:40] we need to make sure the user can only insert a value that is in the provided list? [17:42:44] Yeah, I guess. [17:49:19] Krenair: Did you review https://gerrit.wikimedia.org/r/#/c/230523/ ? LGTM and you +2'ed a patch above it in the stack. [17:49:51] edsanders: David wanted you to review and ideally merge https://gerrit.wikimedia.org/r/#/c/217222/ in case you didn't get a link. [17:51:07] (03PS2) 10Jforrester: CONTRIBUTING.md: Update file paths and build instructions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230488 (owner: 10Cscott) [17:51:15] (03CR) 10Jforrester: [C: 032] CONTRIBUTING.md: Update file paths and build instructions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230488 (owner: 10Cscott) [17:54:07] James_F, not in great detail, haven't tested it or anything [17:54:35] other than with the other patch [17:54:46] Krenair: Kk. There's a pull-through in VE and another in MF to land alongside it, so if we're going to merge it let's do so sooner rather than later. :-) [17:55:14] It's a bit more fiddly than I was happy +2'ing. [17:55:20] (03Merged) 10jenkins-bot: CONTRIBUTING.md: Update file paths and build instructions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230488 (owner: 10Cscott) [17:59:37] 10VisualEditor, 6Collaboration-Team-Backlog, 10Collaboration-Team-Current, 10Flow: F8. Run LQT conversion script on mediawiki.org VE/Feedback - https://phabricator.wikimedia.org/T106613#1524752 (10Mattflaschen) Log is at http://people.wikimedia.org/~mattflaschen/2015_07_30_LQT_Flow_VE_Feedback_and_Support_... [18:12:15] 10VisualEditor, 6Collaboration-Team-Backlog, 10Collaboration-Team-Current, 10Flow: F8. Run LQT conversion script on mediawiki.org VE/Feedback - https://phabricator.wikimedia.org/T106613#1524820 (10Jdforrester-WMF) Thank you again! [18:18:15] 10VisualEditor: `instanceof RegExp` not reliable - https://phabricator.wikimedia.org/T108481#1524847 (10Esanders) This problem (RegExp !== frame.contentWindow.RegExp) is not specific to RegExp. If we were going to be context neutral we'd need to fix all uses of instanceof X. That said, even when we had iFrames... [18:18:33] 10VisualEditor: `instanceof RegExp` not reliable - https://phabricator.wikimedia.org/T108481#1524848 (10Esanders) [18:58:04] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: Selecting nodes (references/images/templates) on iOS < 8 causes the on-screen keyboard to close, so they cannot be deleted - https://phabricator.wikimedia.org/T62110#1524986 (10Esanders) I have a patch which adds a delete action. The only question is should we h... [19:00:48] (03PS1) 10Esanders: [WIP] Delete button for node context items [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230592 (https://phabricator.wikimedia.org/T62110) [19:05:10] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Delete button for node context items [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230592 (https://phabricator.wikimedia.org/T62110) (owner: 10Esanders) [19:05:35] (03CR) 10Jforrester: "See also I8804ecfecf." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230592 (https://phabricator.wikimedia.org/T62110) (owner: 10Esanders) [19:25:08] (03CR) 10Jforrester: [C: 032] Move toolbar floating code up to the target [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230523 (owner: 10Esanders) [19:28:50] (03Merged) 10jenkins-bot: Move toolbar floating code up to the target [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230523 (owner: 10Esanders) [19:28:52] (03Merged) 10jenkins-bot: Separate SA target into Mobile and Desktop [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230522 (owner: 10Esanders) [19:33:36] (03PS3) 10Jforrester: Update VE core submodule to master (da9d929) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230528 (owner: 10Esanders) [19:44:06] 10VisualEditor, 6Discovery, 10MediaWiki-API, 10MediaWiki-Search, and 2 others: Prefix search API doesn't return "index" field when "redirects" is enabled. - https://phabricator.wikimedia.org/T92796#1525115 (10Deskana) p:5Low>3High Changing priority to high to reflect the fact that #Discovery is at work... [19:44:42] 10VisualEditor, 10VisualEditor-MediaWiki: On user's first use of VE-MW, provide a couple of educational pop-ups for links and for citations with some toolbar highlights to trigger them - https://phabricator.wikimedia.org/T108620#1525119 (10Jdforrester-WMF) 3NEW [19:45:17] 10VisualEditor, 10VisualEditor-MediaWiki: On user's first use of VE-MW, provide a couple of educational pop-ups for links and for citations with some toolbar highlights to trigger them - https://phabricator.wikimedia.org/T108620#1525119 (10Jdforrester-WMF) [19:54:19] 10MediaWiki-extensions-Graph-VE, 5Patch-For-Review: Integrate basic editor dialog displaying raw JSON - https://phabricator.wikimedia.org/T99937#1525133 (10ferdbold) [19:55:26] 10Citoid, 10VisualEditor: VisualEditor: Select link, have option to turn into citation - https://phabricator.wikimedia.org/T108621#1525135 (10Harej) 3NEW [20:11:55] 10VisualEditor, 10VisualEditor-ContentEditable, 7Epic: Change how link annotations work to actively enter/leave the annotation - https://phabricator.wikimedia.org/T91285#1525175 (10Jdforrester-WMF) [20:19:45] 10VisualEditor, 10VisualEditor-EditingTools, 10Parsoid: In an indented list, enter/return in a blank terminal li should move to a new li in the parent list, not a

in the current one - https://phabricator.wikimedia.org/T108595#1525286 (10Jdforrester-WMF) [20:19:54] 10VisualEditor, 10VisualEditor-EditingTools: In an indented list, enter/return in a blank terminal li should move to a new li in the parent list, not a

in the current one - https://phabricator.wikimedia.org/T108595#1524528 (10Jdforrester-WMF) p:5Triage>3Normal [20:20:18] 10VisualEditor, 10VisualEditor-EditingTools: In an indented list, enter/return in a blank terminal li should move to a new li in the parent list, not a

in the current one - https://phabricator.wikimedia.org/T108595#1524528 (10Jdforrester-WMF) Re-titling to be about the change in VE; I think Parsoid was doi... [20:20:47] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: Tapping edit on an existing link shows a misaligned title suggestion - https://phabricator.wikimedia.org/T108330#1525296 (10Jdforrester-WMF) p:5Triage>3Normal [20:21:05] 10VisualEditor: VisualEditor: Unclosed

and
tags caused by absent {{refend}} template cannot be repaired - https://phabricator.wikimedia.org/T62395#1525300 (10Jdforrester-WMF) p:5Triage>3Low [20:21:08] 10VisualEditor, 10WikiEditor, 6Design Research Backlog, 7Easy, 5Patch-For-Review: Tooltip text on the "Edit" and "Edit Source" tabs should be more helpful to new users - https://phabricator.wikimedia.org/T99271#1525302 (10ggellerman) [20:22:07] 10VisualEditor: Please generate a list of Most referenced domains on the Dutch Wikipedia - https://phabricator.wikimedia.org/T107788#1525305 (10Jdforrester-WMF) p:5Triage>3Normal [20:24:17] 10VisualEditor, 10VisualEditor-EditingTools: Change to the sequence for bullet list from '^* ' to '^*' (dropping the whitespace requirement) - https://phabricator.wikimedia.org/T108492#1525316 (10Jdforrester-WMF) p:5Triage>3Normal [20:24:38] 10VisualEditor, 10VisualEditor-ContentEditable: Can't select beyond inline focusable - https://phabricator.wikimedia.org/T108299#1525320 (10Jdforrester-WMF) p:5Triage>3High [20:24:54] 10VisualEditor, 10VisualEditor-ContentEditable: Applying annotation breaks view selection - https://phabricator.wikimedia.org/T108297#1525323 (10Jdforrester-WMF) p:5Triage>3Normal [20:25:12] 10VisualEditor, 6Analytics-Engineering: VE-related data for the Galician Wikipedia - https://phabricator.wikimedia.org/T86944#1525331 (10Jdforrester-WMF) p:5Triage>3Normal [20:26:09] 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 10Parsoid: Newly added parameters in templates are being recorded in the order that they're inserted into the template dialog, rather than the order that is specified in TemplateData - https://phabricator.wikimedia.org/T108133#1525334 (10Jdforrester-WMF) p:... [20:26:38] 10VisualEditor: Failure to render some broken links - https://phabricator.wikimedia.org/T107434#1525339 (10Jdforrester-WMF) 5Open>3Invalid [20:26:57] 10VisualEditor, 7Design, 7I18n: The "Generated from" label in the template inspector seems superfluous - https://phabricator.wikimedia.org/T108004#1525341 (10Jdforrester-WMF) 5Open>3declined a:3Jdforrester-WMF [20:27:10] 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 7Design, 7I18n: The "Generated from" label in the template inspector seems superfluous - https://phabricator.wikimedia.org/T108004#1510111 (10Jdforrester-WMF) [20:27:29] 10VisualEditor, 10VisualEditor-Tables, 10Parsoid: Newlines after bolded text in tables lost on save - https://phabricator.wikimedia.org/T104032#1525345 (10Jdforrester-WMF) p:5Triage>3High [20:28:32] 10VisualEditor: VisualEditor doesn't colon-prefix interwiki links when needed, causing them to become language links - https://phabricator.wikimedia.org/T101406#1525357 (10Jdforrester-WMF) [20:28:34] 10VisualEditor, 10VisualEditor-MediaWiki: Stop the user from adding a langlink when we think they wanted to insert an interwiki instead - https://phabricator.wikimedia.org/T103635#1525358 (10Jdforrester-WMF) [20:28:46] 10VisualEditor: Visual Editor blocks ctrl-0 (=default font size) in Firefox - https://phabricator.wikimedia.org/T108623#1525360 (10Raymond) 3NEW [20:28:59] 10VisualEditor, 10VisualEditor-MediaWiki: Stop the user from adding a langlink when we think they wanted to insert an interwiki instead - https://phabricator.wikimedia.org/T103635#1394973 (10Jdforrester-WMF) Note that {T95850} is related but not the same. [20:31:29] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10VisualEditor-Tables, 3Reading-Web: Table design overlaps Overlay header in mobile - https://phabricator.wikimedia.org/T103293#1525382 (10Jdforrester-WMF) p:5Triage>3Normal [20:32:20] 10VisualEditor: [Regression pre-wmf22] The icon for Citations are getting overlapped with text inside the Autofill Citation dialog - https://phabricator.wikimedia.org/T92688#1525389 (10Jdforrester-WMF) 5Open>3Resolved a:3Jdforrester-WMF Looks fine now. [20:33:36] 10VisualEditor: Visual Editor blocks ctrl-0 (=default font size) in Firefox - https://phabricator.wikimedia.org/T108623#1525394 (10Jdforrester-WMF) Yes, it's a keyboard shortcut. Like with several of these, they have special behaviour inside VE compared to outside. Click out of the editor and it works fine. [20:33:41] 10VisualEditor, 10VisualEditor-MediaWiki, 7JavaScript: Infinite collapsing/uncollapsing of VisualEditor's Edit tab - https://phabricator.wikimedia.org/T108588#1525395 (10Krinkle) [20:35:11] 10VisualEditor, 10VisualEditor-MediaWiki, 7JavaScript: Infinite collapsing/uncollapsing of VisualEditor's Edit tab - https://phabricator.wikimedia.org/T108588#1525401 (10Krinkle) Focussing this task on VisualEditor's instance of this bug. The general issue is T71729 (which is likely wont-fix). I suspect tha... [20:35:59] 10VisualEditor: Visual Editor blocks ctrl-0 (=default font size) in Firefox - https://phabricator.wikimedia.org/T108623#1525404 (10Raymond) >>! In T108623#1525394, @Jdforrester-WMF wrote: > Yes, it's a keyboard shortcut. Like with several of these, they have special behaviour inside VE compared to outside. Click... [20:44:49] (03CR) 10Alex Monk: [C: 032] Update VE core submodule to master (da9d929) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230528 (owner: 10Esanders) [20:45:22] James_F, https://phabricator.wikimedia.org/T103635 is not the same as https://phabricator.wikimedia.org/T95850 ? [20:46:42] Krenair: One is "VE should put a ':' in-front". [20:46:55] Krenair: The other is "Parsoid should round-trip its HTML cleanly". [20:47:17] Krenair: Parsoid doing T95850 means VE's screw-up is just tech debt. [20:47:22] But it doesn't get rid of the issue. [20:47:56] ok [20:48:33] Why were langlinks implemented like that again? [20:48:48] Indeed. [20:51:03] (03PS5) 10Dduvall: WIP QA: Upgrading to mw-selenium 1.x [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/222143 (https://phabricator.wikimedia.org/T99661) [20:52:26] (03Merged) 10jenkins-bot: Update VE core submodule to master (da9d929) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230528 (owner: 10Esanders) [20:52:53] (03CR) 10jenkins-bot: [V: 04-1] WIP QA: Upgrading to mw-selenium 1.x [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/222143 (https://phabricator.wikimedia.org/T99661) (owner: 10Dduvall) [21:03:57] (03PS5) 10Jforrester: MobileArticleTarget: Centre toolbar tools [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230302 (https://phabricator.wikimedia.org/T92027) (owner: 10Esanders) [21:04:03] (03CR) 10Jforrester: [C: 032] MobileArticleTarget: Centre toolbar tools [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230302 (https://phabricator.wikimedia.org/T92027) (owner: 10Esanders) [21:05:17] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: iOS scrolls the cursor off the page if it is near the top of the page - https://phabricator.wikimedia.org/T108576#1525501 (10Jdforrester-WMF) 5Open>3Resolved [21:07:02] (03Merged) 10jenkins-bot: MobileArticleTarget: Centre toolbar tools [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230302 (https://phabricator.wikimedia.org/T92027) (owner: 10Esanders) [21:13:37] 10VisualEditor, 6Editing-Department: Investigate why visual editor users have a higher save rate in EventLogging data but didn't in the A/B test - https://phabricator.wikimedia.org/T108241#1525545 (10Neil_P._Quinn_WMF) [21:17:45] Krenair: Do you think https://gerrit.wikimedia.org/r/#/c/228040/ and https://gerrit.wikimedia.org/r/#/c/228041/ will work OK? [21:19:33] James_F, seems okay [21:19:54] * James_F crosses his fingers and hopes. :-) [21:26:16] James_F, I'd +2 it if that makes you feel better [21:26:20] 10Citoid, 10Security-Reviews, 6Security-Team, 6operations: http://citoid.wikimedia.org/ should force HTTPS - https://phabricator.wikimedia.org/T108632#1525587 (10Jdforrester-WMF) 3NEW [21:26:45] Krenair: That probably would, actually. [21:27:23] 10Citoid, 10Security-Reviews, 6Security-Team, 6operations, 7HTTPS: http://citoid.wikimedia.org/ should force HTTPS - https://phabricator.wikimedia.org/T108632#1525597 (10Krenair) [21:27:56] 10Citoid, 6Security, 6Security-Team, 10Traffic, and 2 others: http://citoid.wikimedia.org/ should force HTTPS - https://phabricator.wikimedia.org/T108632#1525587 (10Krenair) [21:28:17] James_F, we have one of those about parsoid-lb somewhere probably? [21:28:37] Krenair: https://phabricator.wikimedia.org/T103919 Maybe? [21:31:15] James_F, I don't think parsoid-lb is behind misc-web? [21:31:28] Krenair: Maybe no. [21:31:30] +t [21:31:42] parsoid-lb.eqiad 1H IN A 208.80.154.248 [21:31:43] 1H IN AAAA 2620:0:861:ed1a::3:14 [21:34:09] File it? [21:34:47] misc-web stuff is "IN CNAME misc-web-lb.eqiad", and misc-web-lb.eqiad 1H IN A 208.80.154.241 [21:35:06] * James_F nods. [21:35:20] I think Citoid and Parsoid are the same box. [21:35:36] parsoid-lb has another issue though [21:35:40] it's under .eqiad [21:35:40] Nope. [21:35:47] It's not a permanent URL. [21:35:51] and therefore the *.wikimedia.org cert won't match [21:35:58] Ideally we're meant to use RB only. [21:36:15] In fact, other than for testing and private wikis, what do we use parsoid-lb for? [21:38:31] Also, isn't Citoid in SCA and parsoid has it's own machines (wtp*) and caches? [21:38:58] wtp* are Parsoid-specific and not externally accessible, yeah. [21:39:09] I think CX in labs uses parsoid-lb [21:39:30] I think several things use Parsoid's Varnish for various things. [21:41:03] wmf-config/CommonSettings-labs.php: $wgContentTranslationParsoid['url'] = 'http://parsoid-lb.eqiad.wikimedia.org'; [21:41:13] // $wmgParsoidURL from production is not accessible from Beta, so use public URL [21:41:58] so beta CX, private production wikis and testing [21:44:01] 10VisualEditor: Failure to render some broken links - https://phabricator.wikimedia.org/T107434#1525668 (10awight) 5Invalid>3Open Reopening, I'm not convinced that this is an invalid bug. Here's an example: ``` See this link: [[en:Wikipedia:WikiProject X|WikiProject X]] (missing) Correct link: [[:en:Wikipe... [21:44:04] Most of the services aren't configured on mw-config. [21:44:32] E.g. I think mathoid uses the same box that citoid does. [21:45:37] iegreview? [21:45:48] cxserver [21:46:01] oh, my random script to update [[meta:System_administrators]] uses it. Oops. [21:46:12] 10VisualEditor: Failure to render some broken links - https://phabricator.wikimedia.org/T107434#1525690 (10Jdforrester-WMF) 5Open>3Invalid The problem is with us not stopping you from thinking that 'en:Foo' is a link to the English Wikipedia (it isn't, it's a language link). There's {T103635} in VE to fix t... [21:47:32] (03PS1) 10Bartosz Dziewoński: ve.ui.MWMediaDialog: Remove weird spinner relicts [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230663 [21:48:03] and i only looked there to steal some code… [21:49:43] Krenair: :-D [21:49:48] MatmaRex: Ha. Fun. [21:54:58] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-extensions-FlaggedRevs, 7JavaScript: Infinite collapsing/uncollapsing of VisualEditor's Edit tab (?)when FlaggedRevs is also installed - https://phabricator.wikimedia.org/T108588#1525720 (10Jdforrester-WMF) [21:55:16] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-extensions-FlaggedRevs, 7JavaScript: Infinite collapsing/uncollapsing of VisualEditor's Edit tab (?)when FlaggedRevs is also installed - https://phabricator.wikimedia.org/T108588#1524228 (10Jdforrester-WMF) I can't reproduce testing without FlaggedRevs. [22:06:01] (03Abandoned) 10Esanders: [WIP] Add a "Remove" context button to all Focusable nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163662 (https://phabricator.wikimedia.org/T62110) (owner: 10Jforrester) [22:06:14] edsanders: You're no fun. [22:06:36] edsanders: What's a little rebasing between friends? [22:07:15] (03CR) 10Jforrester: [WIP] Delete button for node context items (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230592 (https://phabricator.wikimedia.org/T62110) (owner: 10Esanders) [22:08:00] (03PS1) 10Bartosz Dziewoński: ve.ui.MWMediaDialog: Remove dead code with 'HACK' comments [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230678 [22:09:17] well seeing as I already rewrote the patch... [22:09:41] 10VisualEditor, 6Discovery, 10MediaWiki-API, 10MediaWiki-Search, and 2 others: Prefix search API doesn't return "index" field when "redirects" is enabled. - https://phabricator.wikimedia.org/T92796#1525826 (10EBernhardson) a:3EBernhardson [22:09:52] edsanders: Yeah. [22:10:06] 10VisualEditor, 6Discovery, 10MediaWiki-API, 10MediaWiki-Search, and 2 others: Prefix search API doesn't return "index" field when "redirects" is enabled. - https://phabricator.wikimedia.org/T92796#1120484 (10EBernhardson) looks like this might get pushed back till next week, the primary api maintainer is... [22:14:12] (03CR) 10Esanders: [C: 032] "Old feature" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230678 (owner: 10Bartosz Dziewoński) [22:14:38] (03CR) 10Esanders: [C: 032] ve.ui.MWMediaDialog: Remove weird spinner relicts [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230663 (owner: 10Bartosz Dziewoński) [22:24:20] (03Merged) 10jenkins-bot: ve.ui.MWMediaDialog: Remove weird spinner relicts [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230663 (owner: 10Bartosz Dziewoński) [22:24:22] (03Merged) 10jenkins-bot: ve.ui.MWMediaDialog: Remove dead code with 'HACK' comments [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230678 (owner: 10Bartosz Dziewoński) [22:36:03] 10VisualEditor, 6Editing-Department: Investigate why visual editor users have a higher save rate in EventLogging data but didn't in the A/B test - https://phabricator.wikimedia.org/T108241#1525928 (10Neil_P._Quinn_WMF) [22:37:25] (03PS6) 10Dduvall: QA: Upgrading to mw-selenium 1.x [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/222143 (https://phabricator.wikimedia.org/T99661) [23:10:22] James_F, naming assistance if you may. Going with the trend of "able" stuff (say, 'switchable' / 'abortable' / etc) if I have something that can have content... contentable? [23:23:07] 10Citoid, 10RESTBase, 6Services, 7RESTBase-API: Set-up Citoid behind RESTBase - https://phabricator.wikimedia.org/T108646#1526094 (10mobrovac) 3NEW [23:23:26] 10Citoid, 10RESTBase, 6Services, 7RESTBase-API: Set-up Citoid behind RESTBase - https://phabricator.wikimedia.org/T108646#1526104 (10mobrovac) [23:27:51] 10Citoid, 6Security, 6Security-Team, 10Traffic, and 2 others: http://citoid.wikimedia.org/ should force HTTPS - https://phabricator.wikimedia.org/T108632#1526118 (10mobrovac) Hopefully we will be able to turn off `parsoidcache` soon(TM), which effectively means `citoid.wikimedia.org` would disappear. Inste... [23:30:32] 10Citoid, 6Security, 6Security-Team, 10Traffic, and 2 others: http://citoid.wikimedia.org/ should force HTTPS - https://phabricator.wikimedia.org/T108632#1526127 (10BBlack) @mobrovac: the code used to redirect the main sites can be enabled for parsoidcache with the flick of a virtual switch. We just didn'... [23:31:22] 10Citoid, 6Security, 6Security-Team, 10Traffic, and 2 others: http://citoid.wikimedia.org/ should force HTTPS - https://phabricator.wikimedia.org/T108632#1526130 (10Jdforrester-WMF) >>! In T108632#1526118, @mobrovac wrote: > Hopefully we will be able to turn off `parsoidcache` soon(TM), which effectively m... [23:31:42] (03PS1) 10Jforrester: [WIP] VisualEditor.hooks.php: Only do stuff if we're in a VE-namespace [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230701 [23:34:08] 10Citoid, 10RESTBase, 6Services, 7RESTBase-API: Set-up Citoid behind RESTBase - https://phabricator.wikimedia.org/T108646#1526139 (10GWicke) > Store the response using (language,format,query) as the key Would it make sense to share citations globally whenever the content does not vary by `Accept-Language`... [23:34:17] (03CR) 10Jforrester: "Untested, blah blah blah." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230701 (owner: 10Jforrester) [23:34:27] Krenair: https://gerrit.wikimedia.org/r/#/c/230701/ When you're done. [23:36:28] 10Citoid, 6Security, 6Security-Team, 10Traffic, and 2 others: http://citoid.wikimedia.org/ should force HTTPS - https://phabricator.wikimedia.org/T108632#1526149 (10BBlack) So long as the mapping is trivial (e.g. `https://citoid.wikimedia.org/foo/bar` becomes `https://en.wikipedia.org/api/v1/citoid/foo/bar... [23:37:47] (03CR) 10jenkins-bot: [V: 04-1] QA: Upgrading to mw-selenium 1.x [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/222143 (https://phabricator.wikimedia.org/T99661) (owner: 10Dduvall) [23:37:50] 10Citoid, 6Security, 6Security-Team, 10Traffic, and 2 others: http://citoid.wikimedia.org/ should force HTTPS - https://phabricator.wikimedia.org/T108632#1526152 (10Jdforrester-WMF) >>! In T108632#1526149, @BBlack wrote: > So long as the mapping is trivial (e.g. `https://citoid.wikimedia.org/foo/bar` becom...