[00:02:16] (03PS2) 10Alex Monk: [WIP] autodisable preference [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230949 [00:10:00] 10Citoid: Link works in Zotero, Citoid gets lost - https://phabricator.wikimedia.org/T108772#1530061 (10Halibutt) 3NEW [00:13:22] 10Citoid: Link works in Zotero, Citoid gets lost - https://phabricator.wikimedia.org/T108772#1530070 (10Halibutt) [00:22:05] 10VisualEditor, 10VisualEditor-MediaWiki, 7Verified-in-Phase2: On second edit attempt between loads, VisualEditor fails to load, complaining about revID mis-match - https://phabricator.wikimedia.org/T97069#1530079 (10Krenair) Ping. [00:31:23] 10Citoid: Link works in Zotero, Citoid gets lost - https://phabricator.wikimedia.org/T108772#1530114 (10Halibutt) Weird as it is, the very same links I checked a couple of minutes before now work - but they are interpreted as web pages (cite web) and not as books, even though Zotero interprets them as such corre... [00:47:00] 10VisualEditor, 10Wikimedia-MediaWiki-config: Enable VisualEditor as an editing option by default on WMF 'private' wikis - https://phabricator.wikimedia.org/T106803#1530180 (10Krenair) 5Open>3Invalid Boldly marking this as invalid per my comment above [01:44:33] 10VisualEditor, 6Labs, 10Parsoid, 10wikitech.wikimedia.org: visual editor on wikitech fails - https://phabricator.wikimedia.org/T108776#1530322 (10Dzahn) 3NEW [01:45:49] 10VisualEditor, 6Labs, 10Parsoid, 10wikitech.wikimedia.org: visual editor on wikitech fails - https://phabricator.wikimedia.org/T108776#1530332 (10Dzahn) 18:41 < gwicke> I think that has been broken since the last bigger VE deploy 18:43 < gwicke> James_F, is there a task for the wikitech issue? [01:46:08] 10VisualEditor, 6Labs, 10Parsoid, 10wikitech.wikimedia.org: visual editor on wikitech fails - https://phabricator.wikimedia.org/T108776#1530333 (10Dzahn) [01:51:55] 10VisualEditor, 6Labs, 10Parsoid, 10wikitech.wikimedia.org: visual editor on wikitech fails - https://phabricator.wikimedia.org/T108776#1530336 (10Jdforrester-WMF) Meh. [01:52:53] 10VisualEditor, 6Labs, 10Parsoid, 10wikitech.wikimedia.org: VisualEditor on wikitech fails - https://phabricator.wikimedia.org/T108776#1530337 (10Jdforrester-WMF) a:3Krenair [01:59:35] 10Citoid, 10TemplateData, 10VisualEditor: Citing http://www.imdb.com/title/tt0407650/ gives |date=6 Apr 1983 - https://phabricator.wikimedia.org/T98675#1530346 (10czar) Didn't see it brought up so I thought I'd mention that IMDB, as a user-contributed site, should largely not be used as a source ([[ https://... [03:45:21] 10VisualEditor, 6Labs, 10Parsoid, 10wikitech.wikimedia.org: VisualEditor on wikitech fails - https://phabricator.wikimedia.org/T108776#1530469 (10Krenair) ```error: Config Request failure for "https://wikitech.wikimedia.org/w/api.php": 404 path: /labswiki/Main_Page Error: Config Request failure for "https:... [03:48:26] 10VisualEditor, 6Labs, 10Parsoid, 10wikitech.wikimedia.org: VisualEditor on wikitech fails - https://phabricator.wikimedia.org/T108776#1530481 (10Krenair) If that's Parsoid trying to hit Varnish, see T102178 [03:50:13] 10VisualEditor, 6Labs, 10Parsoid, 10wikitech.wikimedia.org: VisualEditor on wikitech fails - https://phabricator.wikimedia.org/T108776#1530492 (10Krenair) You can reproduce that error easily (without manually editing the VE error handling code live on silver) by browsing to http://parsoid-lb.eqiad.wikimedi... [04:03:20] 10VisualEditor, 6Labs, 10Parsoid, 10wikitech.wikimedia.org: Parsoid on wikitech fails - https://phabricator.wikimedia.org/T108776#1530494 (10Krenair) a:5Krenair>3GWicke [04:07:05] 10VisualEditor, 6Labs, 10Parsoid, 10wikitech.wikimedia.org: Parsoid on wikitech fails - https://phabricator.wikimedia.org/T108776#1530497 (10GWicke) This looks like a Parsoid <-> wikitech API communication issue to me. Moving on to Parsoid. [04:07:38] 10VisualEditor, 6Labs, 10Parsoid, 10wikitech.wikimedia.org: Parsoid on wikitech fails - https://phabricator.wikimedia.org/T108776#1530498 (10GWicke) a:5GWicke>3Arlolra [04:09:38] 10VisualEditor, 6Labs, 10Parsoid, 10wikitech.wikimedia.org: Parsoid on wikitech fails - https://phabricator.wikimedia.org/T108776#1530501 (10Krenair) Might be due to `lib/mediawiki.ParsoidConfig.js`'s check for private/fishbowl wikis, which would turn off use of the default proxy. But since https://gerrit.... [04:12:06] 10VisualEditor, 6Labs, 10Parsoid, 10wikitech.wikimedia.org: Parsoid on wikitech fails - https://phabricator.wikimedia.org/T108776#1530502 (10Krenair) https://gerrit.wikimedia.org/r/#/c/228024/1/lib/sitematrix.json - seems like Parsoid has it's own local version of sitematrix and wikitech was updated to no... [04:16:36] 10VisualEditor, 6Labs, 10Parsoid, 10wikitech.wikimedia.org: Parsoid on wikitech fails - https://phabricator.wikimedia.org/T108776#1530508 (10GWicke) @Krenair, nice research! [04:40:27] (03PS3) 10Cscott: Add ve.ui.LinkAction and unanchoredExternalLinkProtocolsRegExp [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230476 [04:40:29] (03PS9) 10Cscott: Detect paste of wikitext and convert it [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230146 [04:40:31] (03PS1) 10Cscott: Autolink pasted URLs and bare autolinkable text [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230972 [04:40:33] (03PS1) 10Cscott: Make ve.ui.MWLinkAction extend ve.ui.LinkAction [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230973 [04:41:47] (03CR) 10Cscott: "Split the URL-paste portion into I82281a11f63bb6a358b41c1348d7ead5d92c3f65" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230146 (owner: 10Cscott) [04:42:27] (03CR) 10jenkins-bot: [V: 04-1] Add ve.ui.LinkAction and unanchoredExternalLinkProtocolsRegExp [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230476 (owner: 10Cscott) [04:42:38] (03CR) 10jenkins-bot: [V: 04-1] Make ve.ui.MWLinkAction extend ve.ui.LinkAction [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230973 (owner: 10Cscott) [04:43:44] (03CR) 10Cscott: "Jenkins fails on this patch because I21976ce0cc823af29bdd2a5c163476fea2408488 is not merged in the VE repo." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230973 (owner: 10Cscott) [05:35:31] hi, curl -L 52.26.103.139:8142/ofc_demo/Prototype:_Topic?oldid=2054 is parsing fine, but I get no errors for http://demo.myoffice.wiki/Prototype:_Topic even though it spins forever [05:36:20] mw 1.25.1 and ve 0.1 and parsoid 0.2.2 [05:37:21] that is, it spins forever when I 'edit' the page [05:45:10] i have tried the todays ve master and still same problem - progress bar about 2/3 of the way done [05:48:42] oh, found an error in the apache log, need to fix [05:49:23] (03CR) 10Eranroz: [C: 04-1] Autolink pasted URLs and bare autolinkable text (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230972 (owner: 10Cscott) [05:52:39] can this emanate from visual editor (from debug.log): error: :real_connect(): (28000/1045): Access denied for user 'wikiuser'@'localhost' (using password: NO) ?? [05:52:52] 10VisualEditor, 10MediaWiki-General-or-Unknown, 7Mobile: Typing {{ in the Web visual editor fails to show the dialog and gives a broken and puzzling UI - https://phabricator.wikimedia.org/T108677#1530597 (10Nnemo) See the screen photo: {F1304631, alt="Screen photo. The Web visual editor is broken and puzzli... [05:53:51] hypergrove, I doubt it, but you're probably doing something wrong is using password is NO [06:04:32] could this come from api.php not findoing LocalSettings.php? This is a farm and my first exposure to api.php [06:05:14] pasrsoid uses the api but its log says it parsed [06:08:56] sorry, such an idiot here, it's an old mediawiki debug log [06:18:02] (03CR) 10Cscott: Support RegExp sequences; trigger sequence matcher after newline. (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230144 (owner: 10Cscott) [06:22:41] i am getting a 404 for http://demo.myoffice.wiki/extensions/VisualEditor/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.init.js [06:22:56] (03CR) 10Cscott: Autolink URLs when typing. (033 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230145 (owner: 10Cscott) [06:23:21] this is with the latest ve from master loaded [06:24:03] 10VisualEditor, 10MediaWiki-General-or-Unknown: In the Web visual editor, clicking the menu Insérer makes it disappear - https://phabricator.wikimedia.org/T108789#1530705 (10Nnemo) 3NEW [06:30:22] transient error.... [06:32:02] ok, so the status is editor still stops at 70% progress bar and no messages in any of 3 logs (parsoid,wfErroLog and syslog) ... this is with the current dev loaded [06:32:53] curl -L 52.26.103.139:8142/ofc_demo/Prototype:_Topic?oldid=2054 is parsing fine, but I get no errors for http://demo.myoffice.wiki/Prototype:_Topic [06:51:55] (03CR) 10Cscott: Autolink pasted URLs and bare autolinkable text (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230972 (owner: 10Cscott) [07:09:52] (earlier, I noted 404s.... they do occur in debug=true mode, for http://demo.myoffice.wiki/extensions/VisualEditor/modules/ve-mw/init/styles/ve.init.mw.ViewPageTarget.init.css and http://demo.myoffice.wiki/extensions/VisualEditor/modules/ve-mw/init/styles/ve.init.mw.ViewPageTarget.init.js) [07:24:16] 10VisualEditor, 10VisualEditor-MediaWiki: VisualEditor: Button to initiate UploadWizard and insert image on completion - https://phabricator.wikimedia.org/T40030#1530850 (10Prtksxna) //Comments from the pitch meeting last week// * Show a preview of the image in the dialog? Easier in VE but useful for WE. * Lic... [07:32:31] 10VisualEditor, 10VisualEditor-MediaWiki, 7Browser-Support-Apple-Safari: When using an iPad on the desktop site, adding a category with a sort key silently drops the sort key on apply for some reason - https://phabricator.wikimedia.org/T107701#1530888 (10Nnemo) [08:41:31] 10VisualEditor, 10VisualEditor-MediaWiki: VisualEditor: Button to initiate UploadWizard and insert image on completion - https://phabricator.wikimedia.org/T40030#1530956 (10Prtksxna) I had a discussion with @nirzar, on how we can integrate the [[https://doc.wikimedia.org/mediawiki-core/master/js/#!/api/mw.Uplo... [08:42:45] 10VisualEditor, 10VisualEditor-MediaWiki: VisualEditor: Button to initiate UploadWizard and insert image on completion - https://phabricator.wikimedia.org/T40030#1530958 (10Prtksxna) Notes from `#wikimedia-multimedia`, with @matmarex and @marktraceur //(logs are edited to keep only relevant messages)//: {P187... [08:43:29] 10VisualEditor, 10VisualEditor-MediaWiki: VisualEditor: Button to initiate UploadWizard and insert image on completion - https://phabricator.wikimedia.org/T40030#1530961 (10Prtksxna) @nirzar, @matmarex, @marktraceur, please clarify if I've missed or misunderstood anything. [08:45:01] 10Citoid, 10VisualEditor: After a paste happens directly after a click on citoid and a click outside of the citoid window, gives 'Uncaught Error: Nested change of newModelSelection' - https://phabricator.wikimedia.org/T98079#1530965 (10Mvolz) 5Open>3Resolved [08:45:18] 10Citoid, 10VisualEditor: After a paste happens directly after a click on citoid and a click outside of the citoid window, gives 'Uncaught Error: Nested change of newModelSelection' - https://phabricator.wikimedia.org/T98079#1258948 (10Mvolz) Marking resolved as can't replicate; probably a VE error now fixed,... [08:52:01] 10Citoid: Link works in Zotero, Citoid gets lost - https://phabricator.wikimedia.org/T108772#1530968 (10Mvolz) This looks like it might be the translator? https://github.com/zotero/translators/blob/master/Library%20Catalog%20(Encore).js If so the issue is this: https://www.mediawiki.org/wiki/Citoid#Testing_for_... [08:52:54] 10Citoid: Enable encore translator (if it works) - https://phabricator.wikimedia.org/T108772#1530969 (10Mvolz) [08:59:04] 10Citoid: Enable encore translator (if it works) - https://phabricator.wikimedia.org/T108772#1530977 (10Mvolz) Just tried it, the translator indeed does not work outside the browser. Sometimes they do but have survivable errors, in this case even when the translator is enabled, Zotero is unable to scrape the pag... [08:59:41] 10Citoid: Library Catalogue (Encore) translator does not work even when enabled - https://phabricator.wikimedia.org/T108772#1530980 (10Mvolz) p:5Triage>3Lowest [09:05:48] 10Citoid, 10TemplateData, 10VisualEditor: Rewrite Zotero translator to treat imdb is a webpage, not a movie. - https://phabricator.wikimedia.org/T98675#1530998 (10Mvolz) p:5Triage>3Low [09:08:16] 10Citoid, 10TemplateData, 10VisualEditor: Rewrite Zotero translator to treat imdb is a webpage, not a movie. - https://phabricator.wikimedia.org/T98675#1531000 (10Mvolz) >>! In T98675#1530346, @czar wrote: > Didn't see it brought up so I thought I'd mention that IMDB, as a user-contributed site, should large... [09:23:11] 10Citoid, 10TemplateData, 10VisualEditor: Rewrite Zotero translator to treat imdb as a webpage, not a movie. - https://phabricator.wikimedia.org/T98675#1531033 (10Mvolz) [09:31:52] (03CR) 10Esanders: [C: 04-1] "Neato, minor comment." (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230310 (owner: 10Cscott) [09:37:59] (03CR) 10Esanders: [C: 032] Support RegExp sequences; trigger sequence matcher after newline [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230144 (owner: 10Cscott) [09:43:54] (03CR) 10Esanders: [C: 032] Autolink URLs when typing [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230145 (owner: 10Cscott) [09:46:01] (03CR) 10Esanders: [C: 032] Allow drag and drop of links (and subsequent autolinking) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230979 (owner: 10Cscott) [09:46:56] (03CR) 10Esanders: [C: 032] Update ve.dm.ElementLinearData#hasContent documentation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230980 (owner: 10Cscott) [09:47:40] (03CR) 10Esanders: [C: 032] Make ve.dm.example.postprocessAnnotations fluent [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230981 (owner: 10Cscott) [09:58:25] (03CR) 10Esanders: [C: 04-1] "There is no handler in core for transferred links. It seems odd that we auto link on typing but not dropping/pasting a link?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230979 (owner: 10Cscott) [10:03:58] 10Citoid: Library Catalogue (Encore) translator does not work even when enabled - https://phabricator.wikimedia.org/T108772#1531091 (10Halibutt) Thanks for letting me know. I [[ https://github.com/zotero/translators/issues/933 | filed a new issue at GitHub ]], perhaps the Zotero guys could shed some light on thi... [10:35:36] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10VisualEditor-Performance, 7Browser-Support-Apple-Safari, 7Epic: VisualEditor Mobile: Switching tabs in mobile safari often causes page to refresh causing data loss of session changes - https://phabricator.wikimedia.org/T70017#1531169 (10Esanders) Auto-sa... [11:50:27] 10VisualEditor: In the Web visual editor, clicking the menu Insérer makes it disappear - https://phabricator.wikimedia.org/T108789#1531318 (10Aklapper) [12:28:01] 10Citoid, 10RESTBase, 6Services, 7RESTBase-API: Set-up Citoid behind RESTBase - https://phabricator.wikimedia.org/T108646#1531386 (10Mvolz) >>! In T108646#1526139, @GWicke wrote: >> Store the response using (language,format,query) as the key > > Would it make sense to share citations globally whenever the... [13:54:33] 10Citoid: Enable JSTOR translator - https://phabricator.wikimedia.org/T108826#1531574 (10Mvolz) 3NEW [14:02:18] (03PS1) 10Robert Vogel: MWMediaResultWidget: Fallback for 'images' without dimensions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/231004 [14:26:07] 10Citoid, 6Services: JSTOR link causes possible Event Emitter memory leak error - https://phabricator.wikimedia.org/T108831#1531668 (10Mvolz) 3NEW [14:28:07] 10Citoid: Remove url parameters when getting DOI from URL - https://phabricator.wikimedia.org/T108832#1531677 (10Mvolz) 3NEW [14:31:48] 10Citoid, 5Patch-For-Review: Enable JSTOR translator - https://phabricator.wikimedia.org/T108826#1531688 (10Mvolz) Fails on http://www.jstor.org/discover/10.1086/378695?uid=3739832&uid=2&uid=4&uid=3739256&sid=21105503736473 Works on http://www.jstor.org/stable/2094536 [14:32:08] 10Citoid, 5Patch-For-Review: Enable JSTOR translator - https://phabricator.wikimedia.org/T108826#1531690 (10Mvolz) [14:32:08] 10Citoid, 5Patch-For-Review: Various citations reportedly not working properly - https://phabricator.wikimedia.org/T106802#1531689 (10Mvolz) [14:33:23] 10Citoid, 5Patch-For-Review: Various citations reportedly not working properly - https://phabricator.wikimedia.org/T106802#1478662 (10Mvolz) [15:03:36] (03PS1) 10Esanders: Make DM nodes sensibly hashable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/231016 [15:03:38] (03PS1) 10Esanders: Provide methods to (de)serialize transactions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/231017 [15:07:54] (03CR) 10jenkins-bot: [V: 04-1] Provide methods to (de)serialize transactions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/231017 (owner: 10Esanders) [15:10:32] 10Citoid, 10RESTBase, 6Services, 7RESTBase-API: Set-up Citoid behind RESTBase - https://phabricator.wikimedia.org/T108646#1531799 (10GWicke) > So each language wiki will have its own set of pages. If we store this per project, then that's a lot less cache hits. Do you think it would be safe to share respo... [15:12:23] (03CR) 10Cscott: "By design. And what you're asking for is a separate patch, it shouldn't be a -1 on this particular patch (which just makes a functionality" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230979 (owner: 10Cscott) [15:14:14] 10VisualEditor, 10VisualEditor-Tables: Can't edit table cell contents in Firefox on Ubuntu - https://phabricator.wikimedia.org/T108712#1531801 (10WereSpielChequers) This was probably one of them https://en.wikipedia.org/w/index.php?title=Earth-Two&diff=prev&oldid=675335760 [15:15:23] (03CR) 10Cscott: "If you compare google docs, it also doesn't autolink on paste, but requires you to press "space" after pasting. Which is exactly the func" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230979 (owner: 10Cscott) [15:22:24] (03PS5) 10Cscott: Allow more than one DataTransferHandler to match a given item [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230310 [15:22:54] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References, 7Design: Be able to use the auto-cite tool to insert a citation template outside of a reference - https://phabricator.wikimedia.org/T95702#1531832 (10Sadads) I would think that including this functionality IS a priority, its a low hanging fruit... [15:23:03] (03PS2) 10Cscott: Make ve.dm.example.postprocessAnnotations fluent [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230981 [15:24:14] (03CR) 10Cscott: [C: 032] "Re-applied Ed's C+2 after rebasing to eliminate an unnecessary dependency on other patches." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230981 (owner: 10Cscott) [15:24:58] (03PS2) 10Cscott: Update ve.dm.ElementLinearData#hasContent documentation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230980 [15:27:30] (03Merged) 10jenkins-bot: Make ve.dm.example.postprocessAnnotations fluent [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230981 (owner: 10Cscott) [15:27:55] 10Citoid, 10RESTBase, 6Services, 7RESTBase-API: Set-up Citoid behind RESTBase - https://phabricator.wikimedia.org/T108646#1531837 (10mobrovac) >>! In T108646#1531799, @GWicke wrote: > If we store this per project, then that's a lot less cache hits. Do you think it would be safe to share responses if all of... [15:28:00] 10VisualEditor, 10OOjs-UI: OOjs UI: Responsive VE toolbar - https://phabricator.wikimedia.org/T92315#1531839 (10Esanders) If we can come up with abbreviations for Paragraph, Heading X, Blockquote & Pre-formatted we can have a narrow version of the formatting tool (it can show the full titles when expanded, we... [15:29:38] (03CR) 10Cscott: [C: 032] "Re-applied Ed's C+2 after rebasing to eliminate an unnecessary dependency on other patches." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230980 (owner: 10Cscott) [15:30:57] 10VisualEditor: Visual Editor not working fully on Microsoft Edge - https://phabricator.wikimedia.org/T108837#1531842 (10Mdann52) 3NEW [15:32:22] (03Merged) 10jenkins-bot: Update ve.dm.ElementLinearData#hasContent documentation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230980 (owner: 10Cscott) [15:32:54] (03PS2) 10Cscott: Allow drag and drop of links (and subsequent autolinking) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230979 [15:32:56] (03PS8) 10Cscott: Autolink URLs when typing [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230145 [15:32:58] (03PS7) 10Cscott: Support RegExp sequences; trigger sequence matcher after newline [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230144 [15:33:00] (03PS3) 10Cscott: Add a mechanism to wait until ve.init.platform has been created [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230489 [15:34:49] (03CR) 10Cscott: [C: 032] "Re-applied Ed's C+2 after rebasing to eliminate an unnecessary dependency on other patches." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230144 (owner: 10Cscott) [15:37:52] (03CR) 10Cscott: [C: 032] "Re-applied Ed's C+2 after rebase, but this is blocked waiting for review on I3c64c1d396a67ba3b3bc4e3d4c320b750663f40a at the moment. (Tha" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230145 (owner: 10Cscott) [15:38:12] (03Merged) 10jenkins-bot: Support RegExp sequences; trigger sequence matcher after newline [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230144 (owner: 10Cscott) [15:43:57] edsanders: apologies if my initial response at https://gerrit.wikimedia.org/r/230979 seemed short, I added a follow-up to explain my reasoning better. too bad (?) gerrit doesn't allow editing comments... [15:45:14] edsanders: i'd be interested in a second opinion on https://gerrit.wikimedia.org/r/230972 as well [15:45:19] cscott, I think we should auto-link stuff with an explicit link mime-type [15:46:04] (google docs does that too, e.g. drag a link from another address bar) [15:46:05] edsanders: well, it's a URL mime-type, not a link mime type. and we currently paste the URL fine, via the text/plain handler [15:46:28] URL/link whatever [15:46:33] edsanders: oh, does it? i thought i tested that. but maybe it's just not recognizing the gnome url type. [15:46:47] works in Chrome [15:47:03] * edsanders tries FF [15:47:11] oh, hm! and it preserves the link title. i'll have to look into that more. [15:47:23] It does? [15:47:55] i just dragged the "more info" link from https://integration.wikimedia.org/zuul/ to a new google doc, and it showed up as "more info" [15:48:19] I'm not seeing title preservation here [15:48:30] i'll figure out what magic is involved [15:48:55] but it does autolink in Chrome & FF [15:49:01] i'm running chrome 45.0.2454.15 beta, although i'd expect everyone is auto-updated to relatively consistent chrome versions these days [15:49:07] maybe i'm on a beta channel though [15:49:26] shall I +2 and you can fix in a follow-up? [15:49:36] so, autolink in core is annoying because every patch to core requires a corresponding patch to ve-mw to fixup the external link type. [15:49:36] (I'm 44.0) [15:49:56] cscott, well not quite [15:50:06] In this case the wikitext handler handles links too [15:50:07] but yeah, the point of my first comment was just that adding the mime types to the paste dispatch is a prerequisite in any case [15:50:15] edsanders: not in my testing [15:50:30] oh, wait, maybe you're saying something else? [15:50:41] if you just use 'type: link' in the annotation, ve-mw gets very unhappy [15:51:19] the wikitext transfer handler should de-register or override the core link transfer handler [15:51:32] it doesn't recognize it as a link, so if you highlight the 'type: link' text and use the link tool, you generate text with both type:link *and* type: link/mwExternal, which then serializes do foo [15:52:01] 10VisualEditor, 6Labs, 10Parsoid, 10wikitech.wikimedia.org, 5Patch-For-Review: Parsoid on wikitech fails - https://phabricator.wikimedia.org/T108776#1531891 (10ssastry) >>! In T108776#1530502, @Krenair wrote: > https://gerrit.wikimedia.org/r/#/c/228024/1/lib/sitematrix.json - seems like Parsoid has it's... [15:52:07] cscott, yes that's correct [15:52:23] but I was suggesting you wouldn't need the core handler with the WT one about [15:52:27] edsanders: but i see what you're saying about the existing WikitextDataTransfer stuff overriding the core stuff without additional muss & fuss [15:52:40] although it might be neater to keep them separate [15:53:13] especially as a link handler wouldn't require Parsoid [15:53:20] the attraction of the combined thing was that I could handle pasting "RFC 1234" with the same code as pasting "http://rfc.org" [15:53:55] and i was originally thinking that pasting 'http://en.wikipedia.org/wiki/Foo' could yield '[[Foo]]', but I couldn't figure out how to do that elegantly [15:54:17] I think we do that already [15:54:23] sort of [15:55:10] neither drag and drop or paste do that, i think you mean if you use the link inspector tool? do you already have a method somewhere to determine whether there is an interwiki prefix for a given URL? [15:56:14] *anyway* i think the ve-core link-paste handler is a separate file and separate patch, more-or-less independent from the core piece which just makes sure uris are dispatched as possible string kinds. [15:56:16] yeah - somewhere [15:57:03] i did separate out the URL autolinking as separate from the probably-wikitext-paste stuff, specifically because i thought we might fiddle around with the URL part of it some. [15:57:03] (03CR) 10Esanders: [C: 032] "Drag and drop of url mime type should auto link but that can be a follow up patch." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230979 (owner: 10Cscott) [15:57:33] so we can review/merge the wikitext paste and then leave the URL part in ve-mw hanging until we figure out how best to arrange things. [15:57:50] #with drag and drop we currently sanitize away all links [15:57:59] (and copy/paste) [15:58:17] you mean with the text/html handler [15:59:56] well actually paste skips over the text/html handler and uses some hard-coded functionality, but yeah [16:00:07] so the external->internal magic is done via ve.dm.MWInternalLinkAnnotation.static.getTargetDataFromHref [16:00:47] (03CR) 10Cscott: "Can I use the serialized form to transfer transactions between two documents? It seems like the hashes already have to be in the store be" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/231017 (owner: 10Esanders) [16:02:29] ok, so getTargetDataFromHref doesn't actually do interwiki links, it just does links to the current wiki. That's probably enough. [16:03:11] > ve.dm.MWInternalLinkAnnotation.static.getTargetDataFromHref('http://google.com/foo', document) [16:03:11] < Object {title: "http://google.com/foo", hrefPrefix: ""} [16:03:11] > ve.dm.MWInternalLinkAnnotation.static.getTargetDataFromHref('http://localhost/MediaWiki/core/index.php/New_page1', document) [16:03:11] < Object {title: "New_page1", hrefPrefix: ""} [16:03:32] so if the input is equal to result.title, then you had a non-local link [16:03:45] yeah, it would be nicer if it would return 'local: true' in the second case. [16:03:53] you could probably refactor that a bit [16:04:01] right [16:05:43] but also only if the original link was absolute [16:06:09] because: [16:06:12] > ve.dm.MWInternalLinkAnnotation.static.getTargetDataFromHref('/New_page1', document) [16:06:12] < Object {title: "/New_page1", hrefPrefix: ""} [16:06:45] yeah, that's a good reason to put the logic inside getTargetDataFromHref and hide it from the caller [16:07:50] and now doubt it all breaks if your url is http://en.wikipedia.org/wiki/http://google.com [16:10:57] i don't think '/New_page1' is a valid internal link. [16:11:41] %2FNew_page 1 or ./%2FNew_page1 might be, though. [16:14:30] https://en.wikipedia.org/w/index.php?title=/New_page1&action=edit&redlink=1 :) [16:15:59] Josve05a_train: yes, Parsoid will emit a link to http://en.wikipedia.org/wiki/%2FNew_page1 in that case. PHP should, too. [16:17:21] The %-encoding is specifically to override the usual meaning of / as a path separator. [16:26:25] my visual editor stops at 70% progress bar and no messages in any of 3 logs (parsoid,wfErroLog and syslog) ... this is with the current master loaded [16:28:55] hypergrove: sounds like a problem connecting to parsoid, have you checked your browser javascript console? [16:29:30] edsanders: google docs is preserving the link title because it is pasting the text/html, not the text/uri-list [16:30:11] edsanders: but this causes problems if you drag a link from firefox to google docs, since firefox's text/html version of the link includes not just the tag but some surrounding context. [16:30:51] eg, dragging the 'featured context' link the enwiki sidebar results in <�li id="n-featuredcontent"><�a href="https://en.wikipedia.org/wiki/Portal:Featured_content" title="Featured content  the best of Wikipedia">Featured content<�/a><�/li> [16:31:38] in both google docs and visual editor (until my text/uri-list patches are merged, then it appears as `https://en.wikipedia.org/wiki/Portal:Featured_content`, autolinked.) [16:32:33] so we might be able to play some cautious games where, when given text/uri-list, we try to match the text/html version against title to extract the title and then bail if things don't look right. [16:33:08] curl -L 52.26.103.139:8142/ofc_demo/Prototype:_Topic?oldid=2054 is parsing fine, but I get no errors for http://demo.myoffice.wiki/Prototype:_Topic [16:34:59] hypergrove: what browser are you using? if you've got chrome, you should be able to open the 'network' view in the developer tools window and see the exact network request which is hanging (if that's indeed what is going on) [16:35:21] firefox, thank you [16:36:04] (I noted 404s.... they do occur in debug=true mode, for http://demo.myoffice.wiki/extensions/VisualEditor/modules/ve-mw/init/styles/ve.init.mw.ViewPageTarget.init.css and http://demo.myoffice.wiki/extensions/VisualEditor/modules/ve-mw/init/styles/ve.init.mw.ViewPageTarget.init.js) [16:36:25] that's the only error i have found [16:38:00] i don't see those 404, nor do I have those files in my local wiki, which is running bleeding-edge VE. [16:38:22] you might want to track those down, perhaps something is not quite up-to-date. [16:39:07] edsanders: interestingly enough, chrome generates text/x-moz-url when dragging from chrome to firefox, but it doesn't generate that when dragging to itself. perhaps we need to advertise that we accept it, somewhere? [16:39:07] i get two 404s with http://demo.myoffice.wiki/Prototype:_Topic?veaction=edit&debug=true [16:39:26] the only 404 I get locally is "GET http://localhost/favicon.ico" [16:40:02] hmm dont know why i get them, hmm [16:40:45] i don't think you can edit without nbeing logged in, let me open up the wiki [16:45:37] 10VisualEditor, 10OOjs-UI: OOjs UI: Responsive VE toolbar - https://phabricator.wikimedia.org/T92315#1532018 (10Jdforrester-WMF) >>! In T92315#1531839, @Esanders wrote: > If we can come up with abbreviations How short? I think we can do single-character for many. > for Paragraph, "⁋"? > Heading X, "§" >... [16:59:38] i created acct irc then "thankyou" at http://demo.myoffice.wiki/Special:UserLogin [17:06:16] (03CR) 10Divec: "Esanders, can you recheck this?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/217222 (owner: 10Divec) [17:07:41] 10Citoid, 6Services: JSTOR link causes possible Event Emitter memory leak error - https://phabricator.wikimedia.org/T108831#1532068 (10Mvolz) @Dzahn notes on https://gerrit.wikimedia.org/r/#/c/231005/ that the failing DOI doesn't work in the browser either. Ergo this is likely unresolvable on our end. [17:11:47] just tried again, same issue of 70% progress bar, but no errors in any of 3 logs [17:12:04] parsoid log says it completed parsing [17:14:08] hypergrove: you seem to have some sort of network transfer issue. but i still think it's probably worthwhile to chase down those 404s you're seeing, they might have a similar root cause. [17:15:24] ok they are only occurring with debug=true [17:16:53] 10Citoid, 6Services: JSTOR link causes possible Event Emitter memory leak error - https://phabricator.wikimedia.org/T108831#1532078 (10Mvolz) Reported to the Zotero translator; https://github.com/zotero/translators/issues/935 (This won't resolve the issue, just letting them know as well.) [17:22:50] I found /var/www/extensions/VisualEditor-1.25/VisualEditor.php: 'scripts' => 'modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.init.js' [17:23:12] that file does not exist [17:23:20] that i can find :( [17:24:13] I just got an HTTP 503 error while trying to VEdit anonymously http://en.wikipedia.beta.wmflabs.org/wiki/Sandbox . [17:25:51] 10VisualEditor, 10OOjs-UI: OOjs UI: Responsive VE toolbar - https://phabricator.wikimedia.org/T92315#1532095 (10Esanders) That depends on how well those sorts of symbols localise. I was thinking we leave it up to translators, but <5 chars ish, so for en maybe: "⁋/P/Para", "H1", ..., "H6", "Quote", "Pre", but... [17:26:23] i find it in the 1.25 edition of VisualEditor, but not the master dev version [17:27:09] that's about as far as I'm able to track it down -- it's not in master [17:27:26] neither file is in master [17:29:17] maybe it was renamed from ViewPageTarget to DesktopArticleTarget but the resource list wasnt changed? [17:32:07] another renaming that apparently is in place: ve.init.mw.MobileViewTarget.js renamed to ve.init.mw.MobileArticleTarget.js [18:04:47] isnt this something that deserbves a bug report? [18:14:47] hypergrove: are you saying your PHP mediawiki is too old for the latest VE? [18:17:57] 10MediaWiki-extensions-Graph-VE, 10VisualEditor, 10Graph, 10Parsoid, and 2 others: Graph editing in VisualEditor - https://phabricator.wikimedia.org/T89287#1532206 (10NiharikaKohli) Thanks for the information, @mooeypoo! I'm curious if by >We're already merging the code (large pieces of it are merged alre... [18:20:41] (03CR) 10Catrope: [C: 032] Make DM nodes sensibly hashable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/231016 (owner: 10Esanders) [18:21:25] 10MediaWiki-extensions-Graph-VE, 10VisualEditor, 10Graph, 10Parsoid, and 2 others: Graph editing in VisualEditor - https://phabricator.wikimedia.org/T89287#1532217 (10Mooeypoo) The Graph extension is available in production, so by merging the code it's actually in production already. See a small test here... [18:23:42] (03Merged) 10jenkins-bot: Make DM nodes sensibly hashable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/231016 (owner: 10Esanders) [18:25:48] cscott: no the opposite [18:26:14] the newest master is missing those two files [18:26:47] hypergrove: the newest master VE? i'm running the latest VE and the latest PHP and I don't see any problem. I don't have those two files, but I'm not getting 404s either. [18:27:17] perhaps your extensions/VisualEditor is out of sync with your extensions/VisualEditor/lib/ve ? [18:27:42] did you 'git submodule update' after you pulled? [18:34:55] cscott, did you try debug mode? i am not getting the error in normal mode [18:35:07] i always run in debug mode [18:35:16] edsanders: Did you look at https://gerrit.wikimedia.org/r/#/c/230489/ ? [18:35:35] interesting. ok, i have backed down to the 1.25 edition i got from distributer [18:36:59] hypergrove: Oh, yeah, don't try to run master of VE-MW against a release version of MediaWiki. It's rare that they're compatible, sadly. [18:37:20] oh didnt realize that, thank you James_F [18:37:55] hypergrove: We have to make lots of fixes to MW and we don't keep master backwards-compatible. [18:38:03] i've only tried master because 1.25 is hanging at 70% progress bar, with no error messages anywhere [18:38:31] Hmm. In the network tab, does the request to Parsoid for the page content not time out? [18:38:38] I created acct "irc" with password "thankyou" [18:38:51] on http://demo.myoffice.wiki [18:39:26] 200 = http://demo.myoffice.wiki/api.php?action=visualeditor&format=json&paction=parse&page=Prototype:_Topic&uselang=en [18:40:45] Hmm. Very odd. [18:40:55] Yeah, http://demo.myoffice.wiki/api.php?action=visualeditor&format=json&paction=parse&page=MyOffice%3A_Adding_Products&uselang=en loads directly for me, but fails inside VE. [18:41:05] I'm not sure why. [18:41:43] i am willing to help however i can, important to us! [18:42:47] 10MediaWiki-extensions-Graph-VE, 10VisualEditor, 10Graph, 10Parsoid, and 2 others: Graph editing in VisualEditor - https://phabricator.wikimedia.org/T89287#1532261 (10NiharikaKohli) Awesome. This looks pretty cool! :D [18:45:49] ooh i so want to install that! [18:50:24] since backing away from master, those 404s went away.... [18:52:07] Also you have a JS fatal on every page, which is a bit confusing. [18:52:13] But I don't think that will be causing the issue. [18:52:18] oh ? looking [18:52:57] 10VisualEditor, 10MediaWiki-extensions-MultimediaViewer, 6Multimedia: MMV not working for pages after saved with VisualEditor and not reloaded - https://phabricator.wikimedia.org/T97010#1532307 (10Florian) a:3Florian [18:53:20] 10MediaWiki-extensions-Graph-VE, 10VisualEditor, 5WMF-deploy-2015-08-11_(1.26wmf18): Integrate basic editor dialog displaying raw JSON - https://phabricator.wikimedia.org/T99937#1532309 (10Jdforrester-WMF) [18:53:25] 10MediaWiki-extensions-Graph-VE, 10VisualEditor, 5WMF-deploy-2015-08-11_(1.26wmf18): Integrate basic editor dialog displaying raw JSON - https://phabricator.wikimedia.org/T99937#1302222 (10Jdforrester-WMF) [18:57:43] having troubles finding source code.... cllicking on the error opens window that contains "/* cache key: w2521-andre_:resourceloader:filter:minify-js:7:7a0dc386b01f41ba70c4edaa29209d43 */" ... so maybe it's generated code? [18:57:56] * James_F looks. [18:58:09] It's Common.js, line one. [18:58:19] thanks [18:58:22] "importArticles(…)" [18:58:25] It's not defined. [19:00:53] oh darn, that cleared the problem [19:00:58] i mean, hooray [19:01:00] The problem with VE? [19:01:03] yeo [19:01:06] Ha. [19:01:07] yep [19:01:23] details drive me crazy sometimes, thanks James [19:01:24] Well, um, great news. :-) [19:01:27] No worries. [19:01:29] Good luck! [19:01:56] Also, your "MyOffice: Banner" template doesn't close its
. [19:02:10] thanks WMF for providing this chatroom, it cannot be emphasized enough how impoortant you are [19:02:20] So VE can't let users edit the contents of it as rich text. [19:02:23] will talk to andre bout tht [19:02:25] See e.g. http://demo.myoffice.wiki/MyOffice:_Adding_Products?veaction=edit [19:02:31] No problem at all. :-) [19:07:10] 10VisualEditor, 10MediaWiki-extensions-MultimediaViewer, 6Multimedia, 5Patch-For-Review: MMV not working for pages after saved with VisualEditor and not reloaded - https://phabricator.wikimedia.org/T97010#1532329 (10Jdforrester-WMF) p:5Triage>3Normal [19:07:37] incidentally, parsoid and VE rock -- as much as I prefer ppl to use browser back-utton, I'll add my vote to adding an optional "cancel" to the editor... ppl have legacy behaviors [19:08:31] We had a cancel button but it took up so much space and it was very rarely used. [19:10:41] maybe stick it in the pulldown [19:11:19] That's an option, yeah. [19:11:25] Maybe [ Save | v ] [19:11:40] With "v" being a save-related menu for cancel/switch. [19:11:57] it is quite possible to display VE without a backbutton (opening a new window) so it's not always available [19:12:40] it's = a "cancel" button [19:13:24] True. [19:13:57] switching one's editor to the visual editor does not change the edit this page, when creating a new page. [19:14:15] no [19:14:17] wait [19:14:20] but a socalled power user who knows how to get to a fresh editing window, would kinda know how to get out of it without closing the window (switch to source editor, then cancel) [19:14:24] how do you "switch one's editor to the visual editor"? [19:14:57] it your preferences? [19:15:00] er. in. [19:15:09] you can only enable ve [19:15:16] not switch between one editor or the other [19:15:26] semantics. [19:15:43] Too bad. [19:15:48] after enabling it, i see links that still use the old editor. you happier now? [19:16:13] yep, that's expected [19:17:10] so, how do i change this behavior? [19:17:53] juri_: You can't. [19:18:03] juri_: We're working on it, but it will take a while. [19:18:09] agree with juri_ that consistently displaying the 'correct' editor for a namespace is important [19:18:25] sorry to butt in [19:18:31] No worries. [19:18:31] James_F: how can i help? [19:18:32] VE does not take over the wikitext editor right now. [19:18:33] (not my place!) [19:19:00] juri_: The task is https://phabricator.wikimedia.org/T55441 (red links should go to the user's main editor). [19:19:14] 10VisualEditor, 6Labs, 10Parsoid, 10wikitech.wikimedia.org, 5Patch-For-Review: Parsoid on wikitech fails - https://phabricator.wikimedia.org/T108776#1532353 (10Arlolra) Should the sitematrix mark it as nonglobal? https://gerrit.wikimedia.org/r/231086 [19:19:15] juri_: Our plan is to have VE take over the 'edit' tab entirely (not have a secondary tab). [19:19:40] juri_: To do this (https://phabricator.wikimedia.org/T102398), VE needs have a wikitext editor that's good enough to not need the current wikitext editor. [19:19:48] juri_: That's https://phabricator.wikimedia.org/T104479 [19:20:03] i have implemented onAlternateEdit to display a (semantic) form for all new pages ... [19:20:14] 10MediaWiki-extensions-Graph-VE, 10VisualEditor, 10Graph, 10Parsoid, and 2 others: Graph editing in VisualEditor - https://phabricator.wikimedia.org/T89287#1532359 (10ferdbold) [19:20:19] 10MediaWiki-extensions-Graph-VE, 5Patch-For-Review: Switch between basic graph types - https://phabricator.wikimedia.org/T99939#1532358 (10ferdbold) 5Open>3Resolved [19:20:47] 10MediaWiki-extensions-Graph-VE, 10VisualEditor, 5WMF-deploy-2015-08-18_(1.26wmf19): Switch between basic graph types - https://phabricator.wikimedia.org/T99939#1532361 (10Jdforrester-WMF) [19:20:52] 10MediaWiki-extensions-Graph-VE, 10VisualEditor, 5WMF-deploy-2015-08-18_(1.26wmf19): Switch between basic graph types - https://phabricator.wikimedia.org/T99939#1302246 (10Jdforrester-WMF) [19:20:54] 10MediaWiki-extensions-Graph-VE, 10VisualEditor, 10Graph, 6Services, 3Google-Summer-of-Code-2015: Graph editing in VisualEditor - https://phabricator.wikimedia.org/T89287#1532362 (10ssastry) [19:20:56] kindof interesting because I am trying to get ppl to be rigorous about page-naming process [19:21:19] to see what I'm talking about go to http://demo.myoffice.wiki/Special:MyLanguage/Form:NewPage [19:21:50] eranroz, mooey|lunch: What's the status of https://phabricator.wikimedia.org/T104479 by the way? [19:22:14] hypergrove: Neat idea. [19:22:19] hypergrove: Do users follow it? [19:22:39] no non-JS version and not at parity with WE? [19:23:25] users will be, hard (but not impossible) to create pages that go around this dialog [19:24:13] not at parity with VE ... not sure what youre asking [19:24:52] they were working on something like this [19:25:03] Krenair: Ed's working on it in VE based on the hackathon work. [19:25:42] Oh right, there was that gerrit commit [19:25:47] interesting. this one is semforms based, involving changes in a special:formedit and an onalternateedit hook proc [19:26:11] One of the presumably numerous gerrit commits which I should be reviewing but haven't [19:26:38] Krenair: Ed said it was "mostly" a proof-of-concept at this stage. [19:27:42] i am pushing the process in this "myoffice" wiki of creating things in a 'private' (using haloacl) area and when ready, to *move* it to a public area [19:28:07] feel free to pass the linkto Ed [19:28:50] Krenair: We'll probably steal RoanKattouw_away's and mooey|lunch's work to make a multi-editor switcher widget and shoe-horn that into VE (or, rather, the other way around). [19:29:08] though the major difference is that I *require* all pages to be labelled with their 'topic-type', eg a page on Bernie Sanders could be Candidate: Bernie Sanders [19:29:15] Krenair: Right now it's JS-only with a single-editor-concept for no-JS, but a PHP-land widget is plausble. [19:29:19] Krenair: Loads of work, though. [19:29:31] yeah [19:29:39] this eliminates practically all disambiguations of course, important to semantic wikis [19:29:40] James_F: was there ever a hook made to allow https://gerrit.wikimedia.org/r/#/c/178817/ to function? [19:30:03] juri_: https://gerrit.wikimedia.org/r/#/c/178817/ /is/ the hook. [19:33:04] James_F: the commit message does not make that clear. [19:33:35] and, i'm really asking if an appropriate patch to use this code was written for VE? [19:34:24] juri_: No. We're not convinced it's a good approach. [19:34:58] when will it be possible to add our own widgets to VE (need instructions...) [19:35:55] i have two needs: a souped-up text-area and I need to allow smw annotation sof links and text [19:36:11] hypergrove: It's possible now. See https://www.mediawiki.org/wiki/VisualEditor_gadgets [19:36:14] the souped-up text area is for entry to specific templates [19:36:23] too cool thx [19:40:00] James_F: so, what do you think is a good approach? [19:40:51] juri_: The one I outlined above (single edit tab with switching between editors within the tab). [19:45:15] that's definately outside of my skillset. [19:46:31] juri_: Yeah. :-( [19:46:39] juri_: It's a lot of work. [19:48:31] Any rec how to best integrate annotaitons into VE -- [[property-name :: value]] where value can be text or a link (the type of property indicates whether 'value' is a link or text) [19:48:33] ... this is for yet another corporate internal wiki. [19:49:45] hypergrove: You'd need to build a custom gadget/extension. Is this Semantic MW based? [19:51:32] yes it is smw - i am thinking of a expanding the "link" into a pulldown, with a) raw link b) annotated link and c) annotated text. [19:51:48] (03PS1) 10Cscott: Autolink pasted links. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/231145 [19:51:52] (03CR) 10Cscott: "Follow-up patch is I80bc95e436563f797849ebd0204e04ae0e277308" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230979 (owner: 10Cscott) [19:52:56] hypergrove: Yeah, I don't think anyone has properly looked at adding VE support to SMW. [19:53:04] (03CR) 10Cscott: "Perhaps superceded by I80bc95e436563f797849ebd0204e04ae0e277308 ? (Although I'd like to keep the RFC xxxx autolinking from this patch set" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230972 (owner: 10Cscott) [19:53:36] or i suppose i could add the stuff to the link dialog, but i worry about making it too complex and too tightly bound to your link code [19:53:52] (03CR) 10jenkins-bot: [V: 04-1] Autolink pasted links. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/231145 (owner: 10Cscott) [19:54:00] James_F, thats exactly what i am doing [19:54:23] hypergrove: Our link editor is probably not a good place to start changing things. [19:54:30] hypergrove: It changes quite a bit. [19:55:32] thats what i thought - so any thought whether better to change the link image into a pulldown, or add a new menuitem for annotations [19:55:34] ? [19:55:53] I'd probably add a new button to the toolbar, yes. [19:57:37] only reason i've shied from that approach is then annoation process is fully divorced from link-creation process, causing confusion and ineffiiencies... so tonight i'll start on that [19:57:59] True. [19:58:08] You could suppress the VE link inspector and show your own. [20:00:09] the "link inspector" is a parser? [20:00:36] i'm noting "the link inspector doesnt work well with external links" [20:00:58] It doesn't? [20:02:04] "Detection of external links in link inspector sucks (Roan)" https://www.mediawiki.org/wiki/VisualEditor/Todo_later_list [20:02:12] maybe old [20:02:36] Oh, wow. [20:02:44] Very old. [20:03:04] Marked as such. [20:03:07] sorry to waste your valuable time [20:03:18] Ha. Sorry for not marking that as old. [20:03:47] yeah, June release-related -- ancient! [20:04:15] June *2012* release-related. [20:04:19] omg [20:04:36] now that is funny [20:04:46] Oh that list [20:06:34] 10VisualEditor, 6Labs, 10Parsoid, 10wikitech.wikimedia.org, 5Patch-For-Review: Parsoid on wikitech fails - https://phabricator.wikimedia.org/T108776#1530322 (10Jdforrester-WMF) [20:08:42] 10VisualEditor, 10VisualEditor-MediaWiki, 7Browser-Support-Microsoft-Edge: Save dialog does not dismiss after saving the page, but the save goes through, when using Edge - https://phabricator.wikimedia.org/T108837#1532518 (10Jdforrester-WMF) [20:10:06] 10VisualEditor, 10VisualEditor-MediaWiki, 7Browser-Support-Microsoft-Edge: Save dialog does not dismiss after saving the page, but the save goes through, when using Edge - https://phabricator.wikimedia.org/T108837#1531842 (10Jdforrester-WMF) p:5Triage>3Normal [20:12:26] 10VisualEditor, 10VisualEditor-MediaWiki, 5Patch-For-Review, 7Verified-in-Phase0, and 2 others: [Regression pre-wmf18] VisualEditor doesn't load, throwing "Uncaught TypeError: Cannot read property 'requestPageData' of undefined" - https://phabricator.wikimedia.org/T107979#1532530 (10Ryasmeen) [20:20:10] (03PS2) 10Jforrester: Auto-link pasted links [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/231145 (owner: 10Cscott) [20:20:37] (03CR) 10Jforrester: "PS2: Fix trivial jscs error." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/231145 (owner: 10Cscott) [20:20:57] thanks, James_F [20:21:10] cscott: No problem. Awesome stuff. :-) [20:22:58] (03CR) 10Jforrester: Auto-link pasted links (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/231145 (owner: 10Cscott) [20:25:44] edsanders|away, RoanKattouw, divec: Look upon thy works, ye mighties, and despair: https://gerrit.wikimedia.org/r/#/q/status:open+project:VisualEditor/VisualEditor+message:WIP,n,z [20:28:06] (03PS2) 10Cscott: Make ve.ui.MWLinkAction extend ve.ui.LinkAction [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230973 [20:28:08] (03PS4) 10Cscott: Add ve.ui.LinkAction and unanchoredExternalLinkProtocolsRegExp [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230476 [20:28:10] (03PS10) 10Cscott: Detect paste of wikitext and convert it [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230146 [20:28:12] (03PS1) 10Cscott: Builder for ve.dm.MWInternalLinkAnnotation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/231155 [20:28:14] (03PS1) 10Cscott: Add UrlStringTransferHandler from core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/231156 [20:28:20] towers of patches [20:28:43] cscott: Also, *cough*, your TX stuff would be nice to de-WIP at some point. [20:29:41] (03CR) 10jenkins-bot: [V: 04-1] Make ve.ui.MWLinkAction extend ve.ui.LinkAction [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230973 (owner: 10Cscott) [20:29:55] yeah, i was thinking about that [20:29:56] cscott: In your Copious Free Time™. :-) [20:30:01] cscott: No hurry. [20:30:07] (03CR) 10jenkins-bot: [V: 04-1] Add ve.ui.LinkAction and unanchoredExternalLinkProtocolsRegExp [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230476 (owner: 10Cscott) [20:30:36] James_F: jenkins hates the patches that depend on changes to VisualEditor/VisualEditor [20:31:11] is it kosher to `git add lib/ve` pointing to an unmerged commit hash? does that even work? [20:31:13] (03CR) 10jenkins-bot: [V: 04-1] Detect paste of wikitext and convert it [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230146 (owner: 10Cscott) [20:31:26] (03CR) 10jenkins-bot: [V: 04-1] Add UrlStringTransferHandler from core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/231156 (owner: 10Cscott) [20:31:44] cscott: Not kosher, and doesn't work. [20:31:53] alas, jenkins will just hate me then. [20:31:57] cscott: We just ignore them. [20:32:02] 10VisualEditor, 7JavaScript, 7Verified-in-Phase0, 5WMF-deploy-2015-08-11_(1.26wmf18): "TypeError: this.resizableSurface is null" after an edit using VisualEditor - https://phabricator.wikimedia.org/T105364#1532584 (10Ryasmeen) [20:32:25] Things that fix-up for breaking changes we normally mark [PULL THROUGH] to make it clear. [20:32:37] (03CR) 10jenkins-bot: [V: 04-1] Builder for ve.dm.MWInternalLinkAnnotation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/231155 (owner: 10Cscott) [20:32:38] (And theoretically https://gerrit.wikimedia.org/r/231156 could have been that.) [20:32:51] cscott: It's more incentive to bully edsanders|away into merging them all. :-) [20:32:55] oh, ok. i can do that. [20:33:04] cscott: It doesn't fix Jenkins though. [20:33:09] Just humans. [20:33:48] James_F: is there a standard way to mark which VisualEditor/VisualEditor patches a particular [PULL THROUGH] depends on? [20:34:38] We just say "Depends on I12abcdef in VE-core" or whatever in the commit message (not the title). [20:35:14] Krenair: Do you feel comfortable +2ing https://gerrit.wikimedia.org/r/#/c/230489/3 ? [20:35:31] It looks sane to me, and Ed +2'ed everything in the stack except it. [20:39:05] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10OOjs-UI, 7Design, and 4 others: Make mobile toolbar wider where possible - https://phabricator.wikimedia.org/T92027#1532600 (10Ryasmeen) [20:49:39] (03CR) 10Alex Monk: [C: 032] Add a mechanism to wait until ve.init.platform has been created [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230489 (owner: 10Cscott) [20:50:07] Woo. [20:50:10] Thanks Krenair. [20:50:14] Now for a fun pull-through. [20:50:22] :) [20:50:46] James_F: yeah, let me tweak the commit messages a bit before you pull through. [20:50:58] i think i also need to do a little rebase dance to put the pull throughs at the bottom [20:51:19] Tell me what you want where and I can do it no worries. [20:51:29] * James_F does rebases and pull-throughs all the time. [20:52:00] Krenair: https://gerrit.wikimedia.org/r/230310 would be nice, too. ;) [20:52:23] edsanders|away had a minor comment on the previous version, which i fixed [20:52:58] (03Merged) 10jenkins-bot: Add a mechanism to wait until ve.init.platform has been created [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230489 (owner: 10Cscott) [20:53:00] (03Merged) 10jenkins-bot: Autolink URLs when typing [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230145 (owner: 10Cscott) [20:53:04] (03Merged) 10jenkins-bot: Allow drag and drop of links (and subsequent autolinking) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230979 (owner: 10Cscott) [20:53:08] cscott, I'm not comfortable merging that one [20:53:34] Krenair: Relevant change is https://gerrit.wikimedia.org/r/#/c/230310/4..5/tests/ui/ve.ui.DataTransferHandlerFactory.test.js [20:53:38] Kk. [20:54:21] Krenair: ok. it just makes things a little tricky because i've got two patches which add text/plain handlers, which conflict with each other if https://gerrit.wikimedia.org/r/230310 isn't merged. but i can rebase to put it back in the dependency tree. [20:54:50] nothing's broken *yet*. ;) [20:59:07] cscott: FWICS, I need to put https://gerrit.wikimedia.org/r/#/c/230476/ and https://gerrit.wikimedia.org/r/#/c/231156/ into the pull-through. [20:59:12] cscott: Seem right to you? [20:59:25] hang on a second [21:01:12] (03PS3) 10Cscott: [PULL THROUGH] Make ve.ui.MWLinkAction extend ve.ui.LinkAction [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230973 [21:01:14] (03PS2) 10Cscott: Builder for ve.dm.MWInternalLinkAnnotation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/231155 [21:01:16] (03PS5) 10Cscott: [PULL THROUGH] Add ve.ui.LinkAction and unanchoredExternalLinkProtocolsRegExp [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230476 [21:01:18] (03PS2) 10Cscott: [PULL THROUGH] Add UrlStringTransferHandler from core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/231156 [21:01:20] (03PS11) 10Cscott: Detect paste of wikitext and convert it [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230146 [21:01:22] (03PS1) 10Cscott: WIP: add more test cases for 'detect paste of wikitext' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/231162 [21:02:21] James_F: i think https://gerrit.wikimedia.org/r/230973 and https://gerrit.wikimedia.org/r/230476 are the currently cleared pull throughs, although the latter depends on a refactoring ( https://gerrit.wikimedia.org/r/231155 ) [21:03:01] (03CR) 10jenkins-bot: [V: 04-1] [PULL THROUGH] Make ve.ui.MWLinkAction extend ve.ui.LinkAction [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230973 (owner: 10Cscott) [21:03:30] https://gerrit.wikimedia.org/r/230146 is the tricky case which might depends implicitly on https://gerrit.wikimedia.org/r/230310 if some other text/plain handler is added, i have to stare at my patch forest a little more. [21:03:44] (03CR) 10jenkins-bot: [V: 04-1] [PULL THROUGH] Add ve.ui.LinkAction and unanchoredExternalLinkProtocolsRegExp [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230476 (owner: 10Cscott) [21:03:49] (03CR) 10jenkins-bot: [V: 04-1] Builder for ve.dm.MWInternalLinkAnnotation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/231155 (owner: 10Cscott) [21:04:01] (03CR) 10jenkins-bot: [V: 04-1] [PULL THROUGH] Add UrlStringTransferHandler from core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/231156 (owner: 10Cscott) [21:04:05] (03CR) 10jenkins-bot: [V: 04-1] WIP: add more test cases for 'detect paste of wikitext' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/231162 (owner: 10Cscott) [21:04:17] (03PS1) 10Jforrester: Update VE core submodule to master (e61ebf2) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/231164 [21:04:35] I'm not sure how much those are pull-throughs so much as depends-ons. [21:05:18] (03CR) 10jenkins-bot: [V: 04-1] Detect paste of wikitext and convert it [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230146 (owner: 10Cscott) [21:05:24] life is tricksy in the "visualeditor is not really a wikitext editor, it's an html editor" world. [21:05:35] Yes. [21:05:50] These patches push it quite far away from that. :-P [21:07:42] (03PS6) 10Cscott: Allow more than one DataTransferHandler to match a given item [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230310 [21:07:44] (03PS3) 10Cscott: WIP: Autolink pasted links [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/231145 [21:08:11] well, edsanders|away asked me to refactor out https://gerrit.wikimedia.org/r/231145 which makes more of the pasted-link handling MW-independent [21:08:16] cscott: I've not properly tested, but 231164 looks like it works without the pull-throughs, so I'll rebase them onto it but not squash them in. [21:08:24] * James_F nods. [21:09:46] the thing to watch for is the fact that without https://gerrit.wikimedia.org/r/230476 the autolinked selection will be of type: 'link' instead of type: 'link/mwExternal' which will confuse VE. The missing unanchoredExternalLinkProtocolsRegExp might throw an exception, too, since for whatever reason the VE-mw Platform doesn't inherit sensible defaults from VE-sa. [21:11:25] True. [21:11:49] SA isn't an interface, it's a demo. [21:12:20] yeah, but the Platform initializes the *RegExp properties to `null`, instead of something harmless. [21:12:30] Yeah. [21:14:08] (03PS6) 10Cscott: [PULL THROUGH] Add ve.ui.LinkAction and unanchoredExternalLinkProtocolsRegExp [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230476 [21:14:42] Gah. [21:14:48] i just rebased 230476 on top of your 231164 to double check that makes jenkins happy (it should) [21:14:49] What did you change? [21:14:53] Ah, OK. [21:14:58] I'm squashing it in. [21:15:41] (03PS7) 10Jforrester: Update VE core submodule to master (e61ebf2) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230476 (owner: 10Cscott) [21:16:16] (03Abandoned) 10Jforrester: Update VE core submodule to master (e61ebf2) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/231164 (owner: 10Jforrester) [21:17:03] 10VisualEditor: The Escape key should close VisualEditor inspectors, rather than suggest exiting VisualEditor - https://phabricator.wikimedia.org/T108872#1532712 (10Amire80) 3NEW [21:17:08] James_F: you probably want https://gerrit.wikimedia.org/r/#/c/230973/1/modules/ve-mw/ui/actions/ve.ui.MWLinkAction.js as well (PS1). [21:17:41] cscott: Does that really depend on https://gerrit.wikimedia.org/r/#/c/231155/ ? [21:17:47] James_F: let me split 230973 into half so that the part you want doesn't depend on https://gerrit.wikimedia.org/r/231155 [21:17:50] cscott: 'Cos if so, we'll have to squash it too. [21:17:51] OK. [21:18:21] PS1 didn't depend on 231155. Then I got all fancy with the internal links and refactored 231155 out in the process. [21:18:31] hang on, i'll make things slightly saner. [21:18:34] cscott: Also, "Task: T12345" doesn't work, you need "Bug: T12345". [21:18:37] * James_F grins. [21:18:46] Fancy often means slower review and merge. [21:19:16] yeah, i keep thinking they're bound to fix the 'task' thing at some point, alas. you know, the elusive "they". [21:19:31] cscott: Indeed. I do it too. [21:20:06] cscott: Are you going to split into a new commit and have me squash, or do you want to do that? [21:24:44] (03PS4) 10Cscott: [PULL THROUGH] Make ve.ui.MWLinkAction extend ve.ui.LinkAction [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230973 [21:24:46] (03PS3) 10Cscott: Builder for ve.dm.MWInternalLinkAnnotation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/231155 (https://phabricator.wikimedia.org/T64816) [21:24:48] (03PS1) 10Cscott: Use ve.dm.MWInternalLinkAnnotation for autolinks where appropriate [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/231167 [21:24:52] I split and I'll let you squash [21:25:00] OK. :-) [21:25:03] 230973 is smaller and squashable [21:25:08] * James_F nods. [21:25:18] 231167 depends on the unreviewed refactor, it can wait. [21:26:36] (03CR) 10jenkins-bot: [V: 04-1] [PULL THROUGH] Make ve.ui.MWLinkAction extend ve.ui.LinkAction [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230973 (owner: 10Cscott) [21:26:49] (03CR) 10jenkins-bot: [V: 04-1] Use ve.dm.MWInternalLinkAnnotation for autolinks where appropriate [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/231167 (owner: 10Cscott) [21:27:05] the scary part of 230973 is just that it renames the 'mwlink' action to 'link', so that we don't go crazy. [21:27:06] (03CR) 10jenkins-bot: [V: 04-1] Builder for ve.dm.MWInternalLinkAnnotation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/231155 (https://phabricator.wikimedia.org/T64816) (owner: 10Cscott) [21:27:15] * James_F nods. [21:27:21] but i don't know why jenkins hates me, let me see. i bet it's code style. [21:27:52] Warning: /mnt/jenkins-workspace/workspace/mwext-VisualEditor-jsduck/modules/ve-mw/ui/actions/ve.ui.MWLinkAction.js:38: @inheritdoc - parent member not found [21:28:04] hm, that's weird. [21:28:15] I'll fix. [21:28:55] 10VisualEditor, 10Parsoid-Nowiki: Title with just nowiki tag - https://phabricator.wikimedia.org/T107774#1532781 (10ssastry) 5Open>3Resolved a:3ssastry With the deployment today that allows normalization of edited content, i think we can call this done. Please reopen if you see any other nowikis of this... [21:29:14] ve.ui.LinkAction#getLinkAnnotation should exist since you updated the lib/ve hash. [21:29:56] oh, i see: i forgot to update the @extends tag in ve.ui.MWLinkAction [21:30:10] it should be @extends ve.ui.LinkAction now, not @extends ve.ui.Action [21:30:19] Yeah. [21:30:25] silly me, i was thinking jsduck would pick up the superclass from OO.inheritClass. [21:30:32] If only. [21:30:44] ok, i'll let you handle that. [21:30:50] Just re-testing now. [21:30:56] jsduck takes ~60s to run locally. [21:31:00] (For VE-MW.) [21:31:14] yeah, it's not a speedy duck [21:31:17] Done. [21:31:19] (03PS5) 10Jforrester: Update VE core submodule to master (e61ebf2) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230973 (owner: 10Cscott) [21:31:53] Oh, bah. [21:32:03] the change-id keeps shifting :) [21:32:13] Yeah. [21:32:16] My screw-up. [21:32:18] Oh, whatever. [21:32:33] (03Abandoned) 10Jforrester: Update VE core submodule to master (e61ebf2) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230476 (owner: 10Cscott) [21:32:49] all the change-id references go the other way, they point at core-ve. nothing i've written cares what the change ids are on the extensions/VisualEditor side. [21:33:07] Yeah. [21:33:11] But gerrit does. :-) [21:33:39] OK, so. [21:33:50] *Theoretically*, https://gerrit.wikimedia.org/r/#/c/230973/ should be good to merge now. [21:34:13] I'm leaving it to edsanders|away and Krenair though. :-) [21:36:31] (03PS2) 10Cscott: Use ve.dm.MWInternalLinkAnnotation for autolinks where appropriate [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/231167 [21:36:33] (03PS4) 10Cscott: Builder for ve.dm.MWInternalLinkAnnotation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/231155 (https://phabricator.wikimedia.org/T64816) [21:36:44] ok, the other two should be rebased on top of 230973 now, and jenkins should love them [21:37:11] Kk. [21:37:25] * James_F runs for coffee. [21:38:17] (03CR) 10jenkins-bot: [V: 04-1] Use ve.dm.MWInternalLinkAnnotation for autolinks where appropriate [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/231167 (owner: 10Cscott) [21:38:19] (03CR) 10jenkins-bot: [V: 04-1] Builder for ve.dm.MWInternalLinkAnnotation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/231155 (https://phabricator.wikimedia.org/T64816) (owner: 10Cscott) [21:38:30] oh, screw you jenkins. [21:40:26] (03PS3) 10Cscott: Use ve.dm.MWInternalLinkAnnotation for autolinks where appropriate [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/231167 [21:40:28] (03PS5) 10Cscott: Builder for ve.dm.MWInternalLinkAnnotation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/231155 (https://phabricator.wikimedia.org/T64816) [21:42:15] (03CR) 10jenkins-bot: [V: 04-1] Use ve.dm.MWInternalLinkAnnotation for autolinks where appropriate [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/231167 (owner: 10Cscott) [21:47:37] 10VisualEditor, 6Labs, 10Parsoid, 10wikitech.wikimedia.org, 5Patch-For-Review: Parsoid on wikitech fails - https://phabricator.wikimedia.org/T108776#1532852 (10Krenair) 5Open>3Resolved [21:47:59] (03CR) 10Esanders: [C: 032] Update VE core submodule to master (e61ebf2) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230973 (owner: 10Cscott) [21:50:21] (03Merged) 10jenkins-bot: Update VE core submodule to master (e61ebf2) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230973 (owner: 10Cscott) [21:53:43] (03CR) 10Esanders: [C: 032] Allow more than one DataTransferHandler to match a given item [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230310 (owner: 10Cscott) [22:03:59] (03CR) 10jenkins-bot: [V: 04-1] Allow more than one DataTransferHandler to match a given item [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230310 (owner: 10Cscott) [22:04:08] aw [22:09:07] (03PS3) 10Cscott: [PULL THROUGH] Add UrlStringTransferHandler from core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/231156 [22:09:09] (03PS12) 10Cscott: Detect paste of wikitext and convert it [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230146 [22:09:15] (03Abandoned) 10Cscott: WIP: add more test cases for 'detect paste of wikitext' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/231162 (owner: 10Cscott) [22:10:02] (03CR) 10Cscott: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230310 (owner: 10Cscott) [22:10:32] (03CR) 10jenkins-bot: [V: 04-1] [PULL THROUGH] Add UrlStringTransferHandler from core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/231156 (owner: 10Cscott) [22:11:23] edsanders: You're back. [22:12:37] (03CR) 10Jforrester: [C: 032] Allow more than one DataTransferHandler to match a given item [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230310 (owner: 10Cscott) [22:14:11] (03CR) 10jenkins-bot: [V: 04-1] Allow more than one DataTransferHandler to match a given item [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230310 (owner: 10Cscott) [22:14:29] (03CR) 10Eranroz: [C: 031] Detect paste of wikitext and convert it [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230146 (owner: 10Cscott) [22:15:23] cscott: So, now I need to go write up Phabricator tickets after the fact for all the things you've made happen. :-) [22:19:58] (03Merged) 10jenkins-bot: Allow more than one DataTransferHandler to match a given item [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/230310 (owner: 10Cscott) [22:20:02] Whee. [22:20:06] 10VisualEditor, 10MediaWiki-extensions-MultimediaViewer, 6Multimedia, 5Patch-For-Review: MMV not working for pages after saved with VisualEditor and not reloaded - https://phabricator.wikimedia.org/T97010#1532995 (10Tgr) [22:20:09] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-extensions-MultimediaViewer, 6Multimedia: MediaViewer does not work directly after saving a VisualEditor edit - https://phabricator.wikimedia.org/T101951#1532994 (10Tgr) [22:20:16] James_F: write one task and split it to 3 and then to 5 [22:20:36] hyra path requires hyra task [22:20:41] hydra* [22:20:51] eranroz: More complicatedly, these fix /some/ parts of /some/ tasks, /some/ of which exist already. [22:20:54] :-) [22:21:55] ugh, I hate repository corruption [22:24:29] Krenair: Locally? [22:24:44] yes [22:24:49] Fun, yeah. :-( [22:39:06] (03Abandoned) 10Jforrester: [HACKATHON-WIP] Create a Wikitext Surface editor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/224816 (owner: 10Mooeypoo) [22:39:30] (03Abandoned) 10Jforrester: [HACKATHON-WIP] Create an OOUI module for WikiEditor [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/224971 (owner: 10Mooeypoo) [22:42:41] James_F: not to depress you, but after fixing a bug, and updating that patch to default to veaction, i get the behavior i want. [22:43:05] should i bother reporting a bug in that patch? [22:45:21] so let's see, what bits and bobs are left? [22:48:21] (03PS4) 10Cscott: Use ve.dm.MWInternalLinkAnnotation for autolinks where appropriate [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/231167 [22:54:29] juri_: A comment would be helpful, yes. [22:59:27] 10VisualEditor, 10VisualEditor-MediaWiki: Loading the read view while VE is loading can create a fused page with both the read and VE versions of the page - https://phabricator.wikimedia.org/T99139#1533161 (10Krenair) this.activating can be true when ve.init.mw.DesktopArticleTarget.prototype.cancel gets called... [22:59:54] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 7Verified-in-Phase0, 5WMF-deploy-2015-08-11_(1.26wmf18): Table cells not editable on mobile - https://phabricator.wikimedia.org/T108514#1533162 (10Ryasmeen) [23:01:06] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design: SurfaceWidget when active should be styled like other OOUI widgets are (blue box/etc.) - https://phabricator.wikimedia.org/T78358#1533173 (10Jdforrester-WMF) [23:09:18] (03CR) 10Jforrester: Builder for ve.dm.MWInternalLinkAnnotation (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/231155 (https://phabricator.wikimedia.org/T64816) (owner: 10Cscott) [23:17:49] 10VisualEditor: Create third version of VE burnup report - https://phabricator.wikimedia.org/T107482#1533251 (10JAufrecht) [23:22:10] 10VisualEditor, 10VisualEditor-Tables, 10MediaWiki-Templates, 5Patch-For-Review, and 2 others: Support editing table cells whose formatting is defined by a template - https://phabricator.wikimedia.org/T85648#1533261 (10Ryasmeen) [23:31:32] (03CR) 10Jforrester: WIP: Explicitly enter/exit link annotations (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/217257 (owner: 10Divec) [23:50:17] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10OOjs-UI, 5OOjs-UI-0.12.3, 5WMF-deploy-2015-08-18_(1.26wmf19): List tool popup not visible on narrow screens - https://phabricator.wikimedia.org/T108344#1533441 (10Jdforrester-WMF) [23:50:19] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10OOjs-UI, 5OOjs-UI-0.12.3, 5WMF-deploy-2015-08-18_(1.26wmf19): ProcessDialog fitLabel doesn't work for relative widths (e.g. full screen 100%) - https://phabricator.wikimedia.org/T108326#1533442 (10Jdforrester-WMF) [23:50:21] 10VisualEditor, 10OOjs-UI, 5OOjs-UI-0.12.3, 5Patch-For-Review, 5WMF-deploy-2015-08-18_(1.26wmf19): Text of the Cite tool when disabled is blue not grey in Monobook - https://phabricator.wikimedia.org/T108018#1533443 (10Jdforrester-WMF) [23:50:28] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 10VisualEditor-MediaWiki-Mobile, 10OOjs-UI, and 3 others: [Regression pre-wmf17] Link suggestions are not appearing for mobile VE because the z-index system was broken in OOUI - https://phabricator.wikimedia.org/T107619#1533446 (10Jdforrester-WMF) [23:52:36] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Reading-Web, 5WMF-deploy-2015-08-11_(1.26wmf18): Mobile VE - Context toolbars are misaligned and confusing users - https://phabricator.wikimedia.org/T91842#1533458 (10Jdforrester-WMF) 5Open>3Resolved p:5Triage>3Normal a:3Esanders [23:53:33] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Reading-Web, 5WMF-deploy-2015-08-11_(1.26wmf18): Mobile VE - tapping a different context item should indicate change - https://phabricator.wikimedia.org/T91843#1533464 (10Jdforrester-WMF) 5Open>3Resolved a:3Esanders [23:54:27] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Reading-Web, 5WMF-deploy-2015-08-04_(1.26wmf17): Mobile VE - Context Toolbar titles are messed up - https://phabricator.wikimedia.org/T91845#1533472 (10Jdforrester-WMF) 5Open>3Resolved p:5Triage>3Normal a:3Esanders [23:55:31] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Reading-Web, 5WMF-deploy-2015-08-04_(1.26wmf17): Mobile VE - Toolbar buttons are the incorrect sizes - https://phabricator.wikimedia.org/T91847#1533490 (10Jdforrester-WMF) 5Open>3Resolved p:5Triage>3Normal a:3Esanders [23:59:31] 10VisualEditor, 10VisualEditor-EditingTools, 10WikiEditor: Special character insertion replaces selected content (including focusable nodes) - https://phabricator.wikimedia.org/T62802#1533503 (10Jdforrester-WMF) 5Open>3declined a:3Jdforrester-WMF If it's a wrapper, we add it top/tail like you'd expect;...