[12:05:46] (03CR) 10Divec: "I've changed the logic again, so that entering/exiting the link consumes a delete/backspace press. It turns out the alternative is conside" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/217257 (https://phabricator.wikimedia.org/T91285) (owner: 10Divec) [12:05:52] (03PS1) 10Esanders: Add down indicator to advanced menu in mobile [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/232479 [12:58:06] (03PS1) 10Esanders: Rebuild tree when toggling input debugging [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/232483 [13:10:30] 10VisualEditor, 7I18n: Add PLURAL support to visualeditor-dialog-transclusion-contextitem-description - https://phabricator.wikimedia.org/T109564#1552723 (10Aklapper) [13:36:20] (03CR) 10Divec: [C: 032] "Thanks, much more convenient" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/232483 (owner: 10Esanders) [13:39:30] (03Merged) 10jenkins-bot: Rebuild tree when toggling input debugging [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/232483 (owner: 10Esanders) [13:43:35] (03CR) 10Jforrester: [C: 032] Add down indicator to advanced menu in mobile [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/232479 (owner: 10Esanders) [13:46:12] (03Merged) 10jenkins-bot: Add down indicator to advanced menu in mobile [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/232479 (owner: 10Esanders) [13:50:57] (03CR) 10Jforrester: [C: 032] "So it's OK if we break it without noticing? :-P Very well." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/232276 (owner: 10Esanders) [13:54:08] (03Merged) 10jenkins-bot: ve.ce.Surface#afterPaste: Use only relevant HTML when creating DTI from image [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/232276 (owner: 10Esanders) [13:57:42] Up already James_F|Away? [13:58:05] edsanders, do you know when IE support was fixed? [13:58:18] (IE11) [14:46:54] (03CR) 10Cscott: [C: 032] build: Update various devDependencies to latest [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/232415 (owner: 10Jforrester) [14:47:05] Krenair: Yes. [14:47:32] Krenair: IE11 support landed some time in Q3 I think. RoanKattouw_away did it. [14:47:51] yeah [14:48:03] Someone's been emailing us with questions about VE from April 2014 [14:48:13] "Us"? [14:48:46] some of the team [14:48:59] Forward to me. I can reply bluntly for you. :-) [14:49:07] I already handled it [14:49:11] Kk. [14:49:21] Basically, table editing and IE11 support were not present in April 2014 :) [14:49:26] We intentionally don't have an e-mail address for support, because we don't offer it. [14:49:36] Why April 2014? Was that REL1_23 or something? [14:50:16] (03Merged) 10jenkins-bot: build: Update various devDependencies to latest [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/232415 (owner: 10Jforrester) [14:50:24] yeah [14:50:47] The lie of "LTS" is going to be with us for a long time. :-( [14:57:33] (03CR) 10Cscott: [C: 04-1] build: Enable jscs's checkParamNames jsdoc rule and make pass (039 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/232417 (owner: 10Jforrester) [14:58:24] cscott: So now I have to psychically work out what edsanders meant when he copy-pasted? ;-) [14:59:05] there was indeed much copy-pasta [14:59:10] cscott: I intentionally left descriptions alone where I didn't know. [14:59:46] well, i helped out where i could; perhaps edsanders should review as well and maybe he can fix some of the unknowns [15:00:03] the danger of updating documentation is that it suddenly looks "official" instead of "obviously not correct" [15:00:10] Yeah. [15:00:33] Whereas leaving it as "@param {number} range Offset to…" makes it obviously not correct. [15:00:39] (03CR) 10Cscott: [C: 031] "Looks fine, but maybe could just be squashed with the previous patch?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/232418 (owner: 10Jforrester) [15:01:07] in that case i looked at the code, and "range" is the correct thing i think. [15:01:07] cscott: Thanks for the review, though. :-) [15:01:26] it looks left from the start and right from the end. as an LTR-reader would say. [15:01:36] Yeah. [15:01:54] Krenair, I didn't know it was broken [15:02:15] (I use "up-page" and "down-page" when I want to be scrupulously middling, though that won't hold water when we do TTB/BTT support.) [15:02:26] what commit is this? [15:02:41] James_F: did you find a jscs-jsdoc bug for the "jscs-jsdoc doesn't grok `return { … }`" thing? i tried searching their issues and i couldn't find it documented as not working. (although it was obviously broken in some way for parsoid as well) [15:02:55] cscott: I was about to report them this morning. [15:03:04] cscott: I reported three of them a couple of weeks ago. [15:03:06] edsanders: https://gerrit.wikimedia.org/r/232417 a jsdoc update [15:03:13] cscott: I worry about deluging them with complaints. ;-) [15:03:21] James_F: ok, good. let me know when you have a issue #, i'd like to follow the bug [15:03:32] cscott: Sure. [15:03:48] i just // jscs:ignore'd the cases where we did a "return {...}" which jscs didn't like, i'd like to remove those comments at some point. [15:03:54] * James_F nods. [15:04:15] The "@return foo … return new Foo()" issue is rather sad. [15:05:06] (03CR) 10Esanders: build: Enable jscs's checkParamNames jsdoc rule and make pass (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/232417 (owner: 10Jforrester) [15:05:18] from a brief perusal of the code base, it looks like the type checker has an explicit "unknown" type which won't trigger warnings, so it should be trivial to make "new ..." return "unknown", at least. [15:05:44] Hmm. I'd rather it actually knew, but yeh. [15:05:46] the return type checking was mostly useful in parsoid's case of finding a couple of "return null" cases that weren't included in the documented return type. [15:05:55] Same for VE. [15:06:26] Lots of our code is documented for no-one, though. Internal use only. Ah well. [15:06:40] i find it useful! as an internal user. [15:06:47] OK, good. :-) [15:07:02] and i think i convinced the parsoid team to generate docs for devs, even though the "public API" of parsoid is small. [15:07:33] i think the jscs param documentation and type checking is actually more useful than the generated HTML docs in our case. [15:07:51] edsanders: Other "{number} offset Offset" matches should be fixed as well? [15:08:10] um, if they're wrong... [15:08:22] but we did add a big "Parsoid Internal APIs (unstable)" category to https://doc.wikimedia.org/Parsoid/master/ to try to make it clearer to non-internal users which parts of the docs they can/should ignore. [15:08:30] edsanders: OK, will hunt. [15:10:05] James_F: fwiw we did turn on "checkRedundantParams" for parsoid, but it does have its issues with varargs. [15:10:13] Yeah. [15:10:13] there's an undocumented ... type which helps, though. [15:10:25] It's documented in jsDuck. [15:10:34] That's one of the bugs I'm going to file. [15:11:24] it would be nice if there was a @varargs tag (or some such) which just turned off checkRedundantParams for that one method. [15:12:56] It'd be nicer if it worked as-is. [15:13:04] https://gerrit.wikimedia.org/r/#/c/232183/4/lib/mediawiki.Util.js has an example on line 369 of a varargs method. it wasn't too painful. [15:15:06] Wait. [15:15:30] They support "...Object" but not "Object..." which is what jsDuck documents as the syntax? [15:16:06] This'll be fun to investigate and file. [15:17:54] (03CR) 10Esanders: build: Enable jscs's checkParamNames jsdoc rule and make pass (036 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/232417 (owner: 10Jforrester) [15:21:10] James_F, is there a rule enforcing @return vs @returns ? [15:21:21] edsanders: Yes. [15:21:21] It appears we only have @returns in MW now [15:21:34] edsanders: Yeah, @return is apparently the standard now. [15:21:37] edsanders: Ask Timo. [15:21:55] that's fine - we should fix MW [15:21:59] ve-mw [15:22:33] Yeah, it's on my list. [15:22:43] I wanted to get VE-core awesome first, then fix VE-MW. [15:22:48] Optimism. ;_) [15:23:04] (and when i said undocumented i really meant "not well documented" -- I think the ...Object syntax came from the official jsdoc or closure docs, instead of the jsduck docs?) [15:23:12] cscott: Eww. [15:23:48] cscott: https://github.com/senchalabs/jsduck/wiki/Type-Definitions [15:23:51] i was just happy it worked and shut up the checkRedundantParams check like it should. but maybe Object... works as well? I can check. [15:23:53] (For comparison.) [15:23:57] It doesn't. [15:24:05] It's why I disabled it. See my commit summary. :-( [15:24:37] http://stackoverflow.com/questions/4729516/correct-way-to-document-open-ended-argument-functions-in-jsdoc [15:24:47] answer one: "Search for "Variable parameters (in @param annotations)" on this page to see for yourself: http://code.google.com/closure/compiler/docs/js-for-compiler.html" [15:25:04] Oy. [15:25:19] So jsduck's documentation is wrong? Or its support? Or both? [15:25:35] it's quite possible that *jsduck* doesn't support this syntax, but that *jscs-jsdoc* does. [15:25:43] let me check the generated output [15:26:24] no, https://doc.wikimedia.org/Parsoid/master/#!/api/Util-method-extendProps looks right. [15:26:37] perhaps you just need to edit https://github.com/senchalabs/jsduck/wiki/Type-Definitions [15:26:41] it's a wiki, after all ;) [15:26:52] Hmm. ;-) [15:27:44] hm, "subject: ...Object" looks correct in the parameters list, but the method is listed as "extendProps(tgt, subject) : Object". [15:27:54] it would be nicer if there were a ... before subject there. [15:27:54] Hmm. [15:28:05] maybe jsduck only kinda supports it [15:28:46] (03PS2) 10Jforrester: build: Enable jscs's checkParamNames jsdoc rule and make pass [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/232417 [15:28:54] anyway, it works enough to use. that's good enough for me for now. [15:29:00] :-) [15:30:18] cscott: https://gerrit.wikimedia.org/r/#/c/232416/ is trivial BTW. :-) [15:31:58] yes, i objected on philosophical grounds ;) [15:32:27] that is, i looked at the patch and it was huge and i thought "should parsoid enable this as well" and decided "no, probably not, it's just annoying to coders and doesn't add any value" [15:32:43] so i figured i'd let someone on the VE team sign off on the change, instead of me. [15:33:29] just a -0, not a -1. but i didn't want to shove it down edsanders' throat if he didn't want it [15:34:08] I find it makes it more readable [15:34:22] (03CR) 10Esanders: [C: 032] build: Enable jscs's requireNewlineAfterDescription jsdoc rule and make pass [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/232416 (owner: 10Jforrester) [15:34:25] Thanks, edsanders. [15:34:27] good enough for me. [15:34:46] we'll be laughing when they start paying us by the line [15:35:06] Ha. [15:35:12] no, i'm saving up my patch for that until after the pay-by-the-line policy starts. i'll be raking in the bucks with my first patches! [15:35:19] * James_F grins. [15:35:53] cscott: I think enforcing "if ( foo ) { \n bar \n }" -> "if ( foo ) \n { \n bar \n }" would be very valuable. [15:36:04] cscott: About 10k extra lines, for instance. ;-) [15:36:12] i hope it's at least a dollar a line [15:36:46] if we can get paid for other kinds of whitespace as well, maybe parsoid will switch to the wikimedia preset. [15:36:52] * James_F grins. [15:36:56] cscott: No no no. [15:37:05] cscott: /First/ you have to write readable variable names. [15:37:13] and imagine the bucks for switching from tabs to spaces! [15:37:36] cscott: No more "usiwfc" but instead "userSuppliedInputWikitextForComparison"! [15:37:41] i'm talking easy money. readable variable names would be *work*. [15:37:51] (03Merged) 10jenkins-bot: build: Enable jscs's requireNewlineAfterDescription jsdoc rule and make pass [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/232416 (owner: 10Jforrester) [15:38:53] cscott: So very much work for Parsoid. [15:39:00] (03PS1) 10Jforrester: build: Enable jscs's checkTypes jsdoc rule and make pass [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/232520 [15:39:14] cscott: ^^ Tah-dah. Thanks for the tip. [15:40:11] (03PS2) 10Jforrester: build: Enable jscs's requireParamTypes jsdoc rule and make pass [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/232418 [15:40:27] (03CR) 10Jforrester: "> Looks fine, but maybe could just be squashed with the previous patch?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/232418 (owner: 10Jforrester) [15:43:19] (03CR) 10jenkins-bot: [V: 04-1] build: Enable jscs's checkTypes jsdoc rule and make pass [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/232520 (owner: 10Jforrester) [15:43:30] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media, 7I18n: Actually pass username to visualeditor-dialog-media-info-meta-artist - https://phabricator.wikimedia.org/T109563#1553225 (10Krenair) [15:48:12] (03CR) 10Jforrester: "That seems fine to me." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/217257 (https://phabricator.wikimedia.org/T91285) (owner: 10Divec) [15:49:56] (03PS1) 10Jforrester: Update VE core submodule to master (4c8168a) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/232522 [15:50:18] (03Abandoned) 10Jforrester: Update VE core submodule to master (2a67aa8) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/232434 (owner: 10Jforrester) [15:52:46] (03PS1) 10Alex Monk: Actually get uploader details when querying media info [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/232523 (https://phabricator.wikimedia.org/T109563) [15:54:22] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media, 7I18n, 5Patch-For-Review: Actually pass username to visualeditor-dialog-media-info-meta-artist - https://phabricator.wikimedia.org/T109563#1553276 (10Krenair) I think you misunderstood. What I wrote was: > I think that our code to... [15:55:10] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media, 7I18n, 5Patch-For-Review: Actually pass username to visualeditor-dialog-media-info-meta-artist - https://phabricator.wikimedia.org/T109563#1553278 (10Krenair) a:3Krenair [16:03:52] (03CR) 10Jforrester: "Where is this used? It doesn't pop out to me in MWMediaResultWidget." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/232523 (https://phabricator.wikimedia.org/T109563) (owner: 10Alex Monk) [16:10:59] (03PS1) 10Alex Monk: Pass number of templates to visualeditor-dialog-transclusion-contextitem-description [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/232527 (https://phabricator.wikimedia.org/T109564) [16:11:42] (03CR) 10Alex Monk: "line 411, imageinfo.user" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/232523 (https://phabricator.wikimedia.org/T109563) (owner: 10Alex Monk) [16:12:05] 10VisualEditor, 7I18n, 5Patch-For-Review: Add PLURAL support to visualeditor-dialog-transclusion-contextitem-description - https://phabricator.wikimedia.org/T109564#1553486 (10Krenair) a:3Krenair [16:12:19] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Templates, 7I18n, 5Patch-For-Review: Add PLURAL support to visualeditor-dialog-transclusion-contextitem-description - https://phabricator.wikimedia.org/T109564#1552126 (10Krenair) [16:12:33] (03CR) 10Jforrester: [C: 031] "Oh, I see. A result isn't shown as a result. Fun." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/232523 (https://phabricator.wikimedia.org/T109563) (owner: 10Alex Monk) [16:12:45] (03CR) 10jenkins-bot: [V: 04-1] Pass number of templates to visualeditor-dialog-transclusion-contextitem-description [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/232527 (https://phabricator.wikimedia.org/T109564) (owner: 10Alex Monk) [16:14:26] (03PS2) 10Alex Monk: Pass number of templates to visualeditor-dialog-transclusion-contextitem-description [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/232527 (https://phabricator.wikimedia.org/T109564) [16:17:32] (03CR) 10Jforrester: [C: 031] Pass number of templates to visualeditor-dialog-transclusion-contextitem-description (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/232527 (https://phabricator.wikimedia.org/T109564) (owner: 10Alex Monk) [16:23:38] (03CR) 10Alex Monk: Pass number of templates to visualeditor-dialog-transclusion-contextitem-description (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/232527 (https://phabricator.wikimedia.org/T109564) (owner: 10Alex Monk) [16:32:30] (03CR) 10Jforrester: Pass number of templates to visualeditor-dialog-transclusion-contextitem-description (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/232527 (https://phabricator.wikimedia.org/T109564) (owner: 10Alex Monk) [17:22:00] 10Citoid, 10VisualEditor, 10MediaWiki-ResourceLoader: Value for citoid-template-type-map.json randomly missing in some languages - https://phabricator.wikimedia.org/T93800#1553793 (10Esanders) Happening on live again [17:24:16] 10VisualEditor, 10VisualEditor-MediaWiki-Media: Links in captions for new images don't link to the correct page in the media dialog - https://phabricator.wikimedia.org/T109599#1553901 (10Whatamidoing-WMF) 3NEW [17:29:57] 10VisualEditor-LanguageTool: Upgrade the LanguageTool server in the labs - https://phabricator.wikimedia.org/T105144#1553917 (10kaldari) What is the LanguageTool server and where is it running on Tool Labs? Could someone add some documentation about this to https://www.mediawiki.org/wiki/Extension:LanguageTool o... [18:04:08] (03PS3) 10Cscott: Factor out ve.ui.LinkAction#autolink [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/232389 [18:07:20] (03CR) 10jenkins-bot: [V: 04-1] Factor out ve.ui.LinkAction#autolink [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/232389 (owner: 10Cscott) [18:10:39] (03PS1) 10Cscott: Strip trailing quotes when autolinking URLs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/232540 [18:13:41] (03CR) 10jenkins-bot: [V: 04-1] Strip trailing quotes when autolinking URLs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/232540 (owner: 10Cscott) [18:38:40] (03PS1) 10Jforrester: build: Bump jscs devDependency from 1.8.0 to 2.1.0 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/232546 [18:38:42] (03PS1) 10Jforrester: build: Enable jscs rule 'requireDotNotation' and make pass [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/232547 [18:38:44] (03PS1) 10Jforrester: build: Enable jscs rule 'requireSpacesInsideBrackets' and make pass [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/232548 [18:38:46] (03PS1) 10Jforrester: build: Enable jscs rule 'requireVarDeclFirst' and make pass [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/232549 [18:38:48] (03PS1) 10Jforrester: build: Enable jscs jsDoc rule 'checkAnnotations' and make pass [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/232550 [18:38:50] (03PS1) 10Jforrester: build: Enable jscs jsDoc rule 'requireNewlineAfterDescription' and make pass [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/232551 [18:38:52] (03PS1) 10Jforrester: build: Enable jscs jsDoc rule 'checkParamNames' and make pass [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/232552 [18:38:54] (03PS1) 10Jforrester: build: Enable jscs jsDoc rules 'checkRedundant*' and make pass [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/232553 [18:38:56] (03PS1) 10Jforrester: build: Enable jscs jsDoc rule 'checkTypes' and make pass [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/232554 [18:38:58] (03PS1) 10Jforrester: build: Enable jscs jsDoc rules 'require*Types' and make pass [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/232555 [18:39:03] Whee. [18:39:56] cscott: Now /those/ will make your code have to be rebased, if we don't get it in first. ;-) [18:40:31] i'm already working on rebasing the outstanding patches to ve-core. [18:53:30] cscott: No hurry. [19:03:11] James_F: I also discovered that "http://example.com" (typed with the quotes) gets autolinked differently in VE and PHP [19:03:25] Fun. [19:03:28] Punctuation issues? [19:03:33] Or something else? [19:03:34] " isn't a URL character according to PHP, so it gets shoved out of the link even though it's not in the "trailing punctuation" set. [19:04:17] so VE needs to use a slightly larger "trailing punctuation" set than PHP does, I think. https://gerrit.wikimedia.org/r/232540 does something reasonable for standalone. [19:04:30] Fun. [19:04:48] i'm working on the ve-mw version of that, trying to ensure I'm RTL sensitive and all. [19:05:06] but i also have to rebase and jscs --fix everything ;) [19:06:51] (03PS4) 10Cscott: Factor out ve.ui.LinkAction#autolink [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/232389 [19:06:59] * James_F nods. [19:07:07] * James_F blames Ed. ;-) [19:08:22] ^ I had to add a newline after the jsdoc description to that one. [19:08:58] (03CR) 10Jforrester: [C: 031] Factor out ve.ui.LinkAction#autolink (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/232389 (owner: 10Cscott) [19:11:01] (03PS2) 10Cscott: Strip trailing quotes when autolinking URLs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/232540 [19:13:34] (03CR) 10Cscott: [C: 032] build: Bump jscs devDependency from 1.8.0 to 2.1.0 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/232546 (owner: 10Jforrester) [19:21:29] (03CR) 10Cscott: "Presumably VE is ES5-only, and doesn't run on ES3 browsers (IE8, IE9)?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/232547 (owner: 10Jforrester) [19:23:30] (03CR) 10Jforrester: "We're ES5 only except for ve.init.mw.DesktopArticleTarget.init.js as that's loaded for all clients (and asserts ES5 compatibility alongsid" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/232547 (owner: 10Jforrester) [19:23:37] (03CR) 10Alex Monk: [C: 032] Update VE core submodule to master (4c8168a) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/232522 (owner: 10Jforrester) [19:23:42] Thanks, Krenair. [19:24:04] it would be nice to get at least https://gerrit.wikimedia.org/r/231155 merged before the jscs-pocalypse, though. [19:24:44] * James_F grins. [19:25:25] (03CR) 10Jforrester: [C: 031] Builder for ve.dm.MWInternalLinkAnnotation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/231155 (https://phabricator.wikimedia.org/T64816) (owner: 10Cscott) [19:25:42] cscott: It looks fine but Ed is Promming and I'm not confident enough to +2. [19:25:55] (03Merged) 10jenkins-bot: Update VE core submodule to master (4c8168a) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/232522 (owner: 10Jforrester) [19:26:06] (03Merged) 10jenkins-bot: build: Bump jscs devDependency from 1.8.0 to 2.1.0 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/232546 (owner: 10Jforrester) [19:33:51] (03CR) 10Cscott: [C: 032] "Only one minor thing, really; I'll just do a follow-up patch for that. Easier than a stack of rebases." (033 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/232417 (owner: 10Jforrester) [19:34:35] (03CR) 10Jforrester: build: Enable jscs's checkParamNames jsdoc rule and make pass (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/232417 (owner: 10Jforrester) [19:36:59] 10VisualEditor, 6Collaboration-Team-Backlog, 10Flow, 10OOjs-UI, and 2 others: [Regression pre-wmf19] Inspectors insta-close on open due to OOUI breakage - https://phabricator.wikimedia.org/T108966#1554411 (10Ryasmeen) [19:37:39] (03CR) 10Cscott: [C: 032] build: Enable jscs's requireParamTypes jsdoc rule and make pass [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/232418 (owner: 10Jforrester) [19:37:56] (03PS1) 10Cscott: doc: Fix jsdoc for ve.ui.WindowAction#getWindowManager [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/232573 [19:38:28] (03Merged) 10jenkins-bot: build: Enable jscs's checkParamNames jsdoc rule and make pass [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/232417 (owner: 10Jforrester) [19:39:02] (03PS1) 10Jforrester: [WIP] build: Force DesktopArticleTarget.init to be ES3-compatible [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/232574 [19:39:15] cscott: https://gerrit.wikimedia.org/r/232574 tries to make your idea work, but it doesn't, so… [19:40:14] (03CR) 10Jforrester: [C: 032] doc: Fix jsdoc for ve.ui.WindowAction#getWindowManager [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/232573 (owner: 10Cscott) [19:40:41] James_F: try a /* jscs: es3: true */ comment at the top of the DesktopArticileTarget.init file? (or the appropriate *correct* syntax for that) [19:40:48] cscott: I did that too. [19:41:04] cscott: But actually, it seems jscs doesn't have a per-file additional rule concept. [19:41:08] cscott: Just disabling them. [19:41:23] cscott: And "ES5 support" is no longer a rule you can disable. [19:41:43] // jscs:enable es3 [19:41:45] maybe? [19:41:56] Nope. [19:42:15] I spent 5 minutes trying and gave up. [19:42:54] (03CR) 10Jforrester: "This doesn't work – it passes even when you write ES5-only content into the file." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/232574 (owner: 10Jforrester) [19:45:02] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 10VisualEditor-MediaWiki-Mobile, 10OOjs-UI, and 2 others: [Regression pre-wmf17] Link suggestions are not appearing for mobile VE because the z-index system was broken in OOUI - https://phabricator.wikimedia.org/T107619#1554437 (10Ryasmeen) [19:45:18] (03CR) 10jenkins-bot: [V: 04-1] build: Enable jscs's requireParamTypes jsdoc rule and make pass [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/232418 (owner: 10Jforrester) [19:45:43] (03Merged) 10jenkins-bot: doc: Fix jsdoc for ve.ui.WindowAction#getWindowManager [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/232573 (owner: 10Cscott) [19:54:55] James_F: oh, hm. i think i figured it out -- requireDotNotation: { allExcept: [ 'keywords'] } -- just says that foo['default'] isn't an error. it *doesn't* make foo.default and error. :( [20:04:14] (03CR) 10Cscott: "This works, in so far as it allows you to write" (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/232574 (owner: 10Jforrester) [20:07:09] (03CR) 10Cscott: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/232418 (owner: 10Jforrester) [20:10:11] (03CR) 10Jforrester: [WIP] build: Force DesktopArticleTarget.init to be ES3-compatible (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/232574 (owner: 10Jforrester) [20:15:14] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10OOjs-UI, 7Verified-in-Phase0, 5WMF-deploy-2015-08-18_(1.26wmf19): List tool popup not visible on narrow screens - https://phabricator.wikimedia.org/T108344#1554519 (10Ryasmeen) [20:19:58] (03CR) 10Jforrester: "Filed upstream as https://github.com/jscs-dev/node-jscs/issues/1706" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/232574 (owner: 10Jforrester) [20:27:20] (03CR) 10Cscott: [C: 032] build: Enable jscs rule 'requireDotNotation' and make pass [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/232547 (owner: 10Jforrester) [20:27:46] (03PS1) 10Jforrester: Follow-up 3819ff6: Fix build for added language 'su' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/232633 [20:27:49] (03PS7) 10Cscott: Use ve.dm.MWInternalLinkAnnotation for autolinks where appropriate [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/231167 [20:27:51] (03PS3) 10Cscott: Autolink typed ISBN/RFC/PMIDs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/232391 (https://phabricator.wikimedia.org/T109498) [20:27:53] (03PS8) 10Cscott: Builder for ve.dm.MWInternalLinkAnnotation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/231155 (https://phabricator.wikimedia.org/T64816) [20:28:08] cscott: Want to +2 https://gerrit.wikimedia.org/r/#/c/232633/ whilst you're at it? [20:28:40] (03CR) 10Cscott: [C: 032] build: Enable jscs rule 'requireSpacesInsideBrackets' and make pass [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/232548 (owner: 10Jforrester) [20:30:19] (03CR) 10jenkins-bot: [V: 04-1] Autolink typed ISBN/RFC/PMIDs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/232391 (https://phabricator.wikimedia.org/T109498) (owner: 10Cscott) [20:31:38] (03Merged) 10jenkins-bot: build: Enable jscs rule 'requireDotNotation' and make pass [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/232547 (owner: 10Jforrester) [20:31:40] (03Merged) 10jenkins-bot: build: Enable jscs rule 'requireSpacesInsideBrackets' and make pass [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/232548 (owner: 10Jforrester) [20:32:53] 10MediaWiki-extensions-Graph-VE: Edit a world map within VisualEditor - https://phabricator.wikimedia.org/T100358#1554643 (10ferdbold) 5Open>3stalled [20:33:13] 10MediaWiki-extensions-Graph-VE: Edit a world map within VisualEditor - https://phabricator.wikimedia.org/T100358#1310942 (10ferdbold) 5stalled>3Open [20:34:37] 10MediaWiki-extensions-Graph-VE: Edit a world map within VisualEditor - https://phabricator.wikimedia.org/T100358#1310942 (10ferdbold) 5Open>3declined p:5Low>3Lowest [20:35:12] 10MediaWiki-extensions-Graph-VE: Allow stacked bar and area charts - https://phabricator.wikimedia.org/T100356#1554664 (10ferdbold) 5Open>3declined p:5Low>3Lowest [20:35:31] 10MediaWiki-extensions-Graph-VE, 10VisualEditor, 10Graph, 6Services, 3Google-Summer-of-Code-2015: Graph editing in VisualEditor - https://phabricator.wikimedia.org/T89287#1554669 (10ferdbold) [20:35:35] 10MediaWiki-extensions-Graph-VE: Edit a pie chart within VisualEditor - https://phabricator.wikimedia.org/T100357#1554666 (10ferdbold) 5Open>3declined p:5Normal>3Lowest [20:36:02] 10MediaWiki-extensions-Graph-VE: Edit a bar chart Vega specification within VisualEditor - https://phabricator.wikimedia.org/T100354#1554670 (10ferdbold) 5Open>3declined p:5Normal>3Lowest [20:36:26] 10MediaWiki-extensions-Graph-VE: Edit a force-directed graph within VisualEditor - https://phabricator.wikimedia.org/T100359#1554673 (10ferdbold) 5Open>3declined p:5Low>3Lowest [20:37:18] 10MediaWiki-extensions-Graph-VE: Create a graph from scratch within VisualEditor - https://phabricator.wikimedia.org/T100355#1554676 (10ferdbold) p:5Normal>3Low [20:40:43] (03CR) 10Cscott: build: Enable jscs rule 'requireVarDeclFirst' and make pass (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/232549 (owner: 10Jforrester) [20:41:31] (03CR) 10Jforrester: build: Enable jscs rule 'requireVarDeclFirst' and make pass (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/232549 (owner: 10Jforrester) [20:41:55] (03CR) 10Cscott: [C: 032] Follow-up 3819ff6: Fix build for added language 'su' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/232633 (owner: 10Jforrester) [20:42:03] Thanks. [20:42:25] 'twould be nice if those were autogenerated from some master language list in a single place. [20:42:48] It /is/ autogenerated from a master list (`ls` ;-)). [20:42:51] (03CR) 10Cscott: [C: 032] build: Enable jscs rule 'requireVarDeclFirst' and make pass [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/232549 (owner: 10Jforrester) [20:43:13] i mean 'grunt build:lang' [20:43:17] But l10n-bot just bypasses it. [20:43:44] Yeah, but unless we re-write l10n-bot to actually do something other than a blind push we won't get it fixed. [20:43:53] 10MediaWiki-extensions-Graph-VE, 6Engineering-Community, 3ECT-August-2015, 3ECT-September-2015, and 2 others: Wrap-up report for "Graph editing in VE" - https://phabricator.wikimedia.org/T109291#1554691 (10ferdbold) [20:44:19] Also the follow-ups average one a month, so it's not the end of the world. [20:44:59] (03Merged) 10jenkins-bot: Follow-up 3819ff6: Fix build for added language 'su' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/232633 (owner: 10Jforrester) [20:45:14] (03Merged) 10jenkins-bot: build: Enable jscs rule 'requireVarDeclFirst' and make pass [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/232549 (owner: 10Jforrester) [20:45:57] (03PS3) 10Jforrester: build: Enable jscs's requireParamTypes jsdoc rule and make pass [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/232418 [20:46:58] 10MediaWiki-extensions-Graph-VE, 6Engineering-Community, 3ECT-August-2015, 3ECT-September-2015, and 3 others: End-term evaluation for "Graph editing in VE" - https://phabricator.wikimedia.org/T109305#1554697 (10ferdbold) [20:47:40] (03CR) 10Cscott: [C: 032] build: Enable jscs jsDoc rule 'checkAnnotations' and make pass [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/232550 (owner: 10Jforrester) [20:48:25] (03PS2) 10Jforrester: build: Enable the remaining jscs jsdoc rules we can [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/232419 [20:48:28] 10MediaWiki-extensions-Graph-VE: Edit graph colors in VE - https://phabricator.wikimedia.org/T109629#1554710 (10ferdbold) 3NEW [20:48:39] 10MediaWiki-extensions-Graph-VE: Create a graph from scratch within VisualEditor - https://phabricator.wikimedia.org/T100355#1554724 (10ferdbold) p:5Low>3Lowest a:5ferdbold>3None [20:48:39] (03CR) 10Jforrester: "PS2: Rebase." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/232419 (owner: 10Jforrester) [20:48:59] (03PS2) 10Jforrester: build: Enable jscs's checkTypes jsdoc rule and make pass [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/232520 [20:49:50] 10MediaWiki-extensions-Graph-VE: Edit axis captions in graphs from VisualEditor - https://phabricator.wikimedia.org/T109630#1554735 (10ferdbold) 3NEW [20:49:56] (03CR) 10Cscott: [C: 032] build: Enable jscs jsDoc rule 'requireNewlineAfterDescription' and make pass [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/232551 (owner: 10Jforrester) [20:50:01] (03Merged) 10jenkins-bot: build: Enable jscs jsDoc rule 'checkAnnotations' and make pass [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/232550 (owner: 10Jforrester) [20:50:36] 10MediaWiki-extensions-Graph-VE: Edit graph size in VisualEditor - https://phabricator.wikimedia.org/T109631#1554745 (10ferdbold) 3NEW [20:50:45] 10MediaWiki-extensions-Graph-VE: Edit graph colors in VisualEditor - https://phabricator.wikimedia.org/T109629#1554755 (10ferdbold) [20:52:40] (03Merged) 10jenkins-bot: build: Enable jscs jsDoc rule 'requireNewlineAfterDescription' and make pass [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/232551 (owner: 10Jforrester) [20:53:12] (03PS5) 10Jforrester: Factor out ve.ui.LinkAction#autolink [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/232389 (owner: 10Cscott) [20:53:14] (03PS3) 10Jforrester: Strip trailing quotes when autolinking URLs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/232540 (owner: 10Cscott) [20:53:29] cscott: Rebased your things onto the stack and fixed them up for you. [20:53:38] i was about to do that, but maybe you rebased further than i did. [20:53:50] cscott: (It was a single character change in "Factor out ve.ui.LinkAction#autolink".) [20:54:06] oh, wait, you're working in ve-core [20:54:19] yeah, i'm doing the same thing, but in extensions/VisualEditor [20:54:23] * James_F nods. [20:57:47] (03PS8) 10Cscott: Use ve.dm.MWInternalLinkAnnotation for autolinks where appropriate [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/231167 [20:57:49] (03PS4) 10Cscott: Autolink typed ISBN/RFC/PMIDs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/232391 (https://phabricator.wikimedia.org/T109498) [20:57:51] (03PS9) 10Cscott: Builder for ve.dm.MWInternalLinkAnnotation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/231155 (https://phabricator.wikimedia.org/T64816) [20:59:12] (03CR) 10Jforrester: [C: 031] Strip trailing quotes when autolinking URLs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/232540 (owner: 10Cscott) [20:59:24] (03CR) 10Jforrester: [C: 031] Factor out ve.ui.LinkAction#autolink [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/232389 (owner: 10Cscott) [20:59:53] (03CR) 10jenkins-bot: [V: 04-1] Autolink typed ISBN/RFC/PMIDs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/232391 (https://phabricator.wikimedia.org/T109498) (owner: 10Cscott) [21:00:47] the v-1 is due to a pull through dependency [21:00:58] Yeah. [21:04:07] (03CR) 10Jforrester: [C: 032] "Per C. Scott." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/232418 (owner: 10Jforrester) [21:04:52] (03CR) 10Cscott: build: Enable the remaining jscs jsdoc rules we can (033 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/232419 (owner: 10Jforrester) [21:05:00] (03CR) 10Jforrester: [C: 031] Builder for ve.dm.MWInternalLinkAnnotation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/231155 (https://phabricator.wikimedia.org/T64816) (owner: 10Cscott) [21:06:45] (03CR) 10Jforrester: build: Enable the remaining jscs jsdoc rules we can (033 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/232419 (owner: 10Jforrester) [21:07:42] (03Merged) 10jenkins-bot: build: Enable jscs's requireParamTypes jsdoc rule and make pass [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/232418 (owner: 10Jforrester) [21:08:29] (03PS3) 10Jforrester: build: Enable the remaining jscs jsdoc rules we can [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/232419 [21:08:31] (03CR) 10Cscott: build: Enable the remaining jscs jsdoc rules we can (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/232419 (owner: 10Jforrester) [21:08:52] 10VisualEditor-LanguageTool: Weekly Reports for LanguageTool Extension for VisualEditor - https://phabricator.wikimedia.org/T101695#1554801 (10Ankita-ks) [21:09:07] (03CR) 10Cscott: [C: 032] build: Enable the remaining jscs jsdoc rules we can [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/232419 (owner: 10Jforrester) [21:09:41] James_F: https://gerrit.wikimedia.org/r/232520 needs to be rebased? [21:10:16] (03PS3) 10Jforrester: build: Enable jscs's checkTypes jsdoc rule and make pass [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/232520 [21:12:43] (03CR) 10Cscott: [C: 032] build: Enable jscs jsDoc rule 'checkParamNames' and make pass [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/232552 (owner: 10Jforrester) [21:13:01] (03Merged) 10jenkins-bot: build: Enable the remaining jscs jsdoc rules we can [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/232419 (owner: 10Jforrester) [21:13:24] (03CR) 10Cscott: [C: 032] build: Enable jscs jsDoc rules 'checkRedundant*' and make pass [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/232553 (owner: 10Jforrester) [21:14:27] (03CR) 10jenkins-bot: [V: 04-1] build: Enable jscs's checkTypes jsdoc rule and make pass [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/232520 (owner: 10Jforrester) [21:15:20] (03CR) 10Cscott: [C: 032] build: Enable jscs jsDoc rule 'checkTypes' and make pass [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/232554 (owner: 10Jforrester) [21:16:04] (03CR) 10Cscott: [C: 032] build: Enable jscs jsDoc rules 'require*Types' and make pass [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/232555 (owner: 10Jforrester) [21:20:30] (03CR) 10Cscott: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/232520 (owner: 10Jforrester) [21:23:43] (03CR) 10Cscott: [C: 032] build: Enable jscs's checkTypes jsdoc rule and make pass [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/232520 (owner: 10Jforrester) [21:24:04] (03PS6) 10Cscott: Factor out ve.ui.LinkAction#autolink [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/232389 [21:24:14] (03PS4) 10Cscott: Strip trailing quotes when autolinking URLs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/232540 [21:28:49] cscott: Tsk, you've gone and merged everything of mine! ;-) [21:28:59] turnabout is fair play, you know [21:29:09] * James_F grins [21:29:30] we are getting paid by the character for this, aren't we? [21:31:30] Clearly. [21:37:31] 10VisualEditor, 10Parsoid, 5Patch-For-Review: Link with as only label - https://phabricator.wikimedia.org/T95730#1554915 (10Arlolra) 5Open>3Resolved [21:59:29] 10MediaWiki-extensions-Graph-VE, 6Engineering-Community, 3ECT-August-2015, 3ECT-September-2015, and 3 others: End-term evaluation for "Graph editing in VE" - https://phabricator.wikimedia.org/T109305#1554995 (10Mooeypoo) [21:59:51] (03CR) 10jenkins-bot: [V: 04-1] Strip trailing quotes when autolinking URLs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/232540 (owner: 10Cscott) [22:01:42] jenkins hates us [22:02:08] time to go pick up my son, maybe the world will be happy and functional again by the time i get back [22:16:04] 10MediaWiki-extensions-Graph-VE: Bar charts are not displaying properly directly after a save in VisualEditor - https://phabricator.wikimedia.org/T109645#1555102 (10ferdbold) 3NEW [22:17:29] 10MediaWiki-extensions-Graph-VE: Bar charts are not displaying properly directly after a save in VisualEditor - https://phabricator.wikimedia.org/T109645#1555112 (10ferdbold) [22:19:01] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 7Easy: Remove "Open" button from MWExternalLinkNode inspector - https://phabricator.wikimedia.org/T109646#1555115 (10Jdforrester-WMF) 3NEW [22:20:55] James_F, because we already link it? [22:20:58] or..? [22:51:32] Krenair: Yeah. [22:51:32] Krenair: We don't have "open" buttons on the other kind any more. [22:51:32] (03CR) 10Esanders: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/232552 (owner: 10Jforrester) [22:51:32] * James_F does it. [22:53:29] (03CR) 10Jforrester: [C: 032] "…" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/232520 (owner: 10Jforrester) [22:56:44] (03Merged) 10jenkins-bot: build: Enable jscs's checkTypes jsdoc rule and make pass [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/232520 (owner: 10Jforrester) [22:59:15] (03PS1) 10Jforrester: MWLinkNodeInspector: Remove 'Open' button [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/232653 (https://phabricator.wikimedia.org/T109646) [22:59:31] (03CR) 10Jforrester: [C: 032] "…" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/232552 (owner: 10Jforrester) [22:59:42] (03CR) 10Jforrester: [C: 032] "…" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/232553 (owner: 10Jforrester) [22:59:51] (03CR) 10Jforrester: [C: 032] "…" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/232554 (owner: 10Jforrester) [23:00:01] (03CR) 10Jforrester: [C: 032] "…" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/232555 (owner: 10Jforrester) [23:02:02] (03Merged) 10jenkins-bot: build: Enable jscs jsDoc rule 'checkParamNames' and make pass [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/232552 (owner: 10Jforrester) [23:02:13] (03Merged) 10jenkins-bot: build: Enable jscs jsDoc rules 'checkRedundant*' and make pass [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/232553 (owner: 10Jforrester) [23:02:15] (03Merged) 10jenkins-bot: build: Enable jscs jsDoc rule 'checkTypes' and make pass [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/232554 (owner: 10Jforrester) [23:03:40] (03Merged) 10jenkins-bot: build: Enable jscs jsDoc rules 'require*Types' and make pass [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/232555 (owner: 10Jforrester) [23:04:49] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10OOjs-UI, 7Verified-in-Phase0, 5WMF-deploy-2015-08-18_(1.26wmf19): ProcessDialog fitLabel doesn't work for relative widths (e.g. full screen 100%) - https://phabricator.wikimedia.org/T108326#1555359 (10Ryasmeen) [23:34:18] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-EditingTools, 7Verified-in-Phase0, 5WMF-deploy-2015-08-18_(1.26wmf19): URL schemes are case-insensitive - https://phabricator.wikimedia.org/T109013#1555505 (10Ryasmeen) [23:38:23] 10VisualEditor, 10VisualEditor-MediaWiki, 7Verified-in-Phase0, 5WMF-deploy-2015-08-18_(1.26wmf19): [Regression] Save dialog clears its contents on each open, making progressively writing the summary impossible - https://phabricator.wikimedia.org/T108329#1555535 (10Ryasmeen) [23:44:20] 10VisualEditor, 10OOjs-UI, 7Verified-in-Phase0, 5WMF-deploy-2015-08-18_(1.26wmf19): Text of the Cite tool when disabled is blue not grey in Monobook - https://phabricator.wikimedia.org/T108018#1555572 (10Ryasmeen)