[00:34:45] 10VisualEditor, 10MediaWiki-Page-editing, 7Availability: Investigate bad_token statsd spikes - https://phabricator.wikimedia.org/T109797#1559442 (10aaron) 3NEW [00:52:03] (03PS1) 10Jforrester: Increase width of desktop context, inspectors to 400px [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/232876 (https://phabricator.wikimedia.org/T101290) [00:52:05] (03PS1) 10Jforrester: LanguageInspector: Made the widget use one line for language [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/232877 [00:52:42] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-Links, 10VisualEditor-MediaWiki-Links, and 2 others: Increase width of inspectors on desktop - https://phabricator.wikimedia.org/T101290#1559474 (10Jdforrester-WMF) a:3Jdforrester-WMF [00:59:24] 10MediaWiki-extensions-Graph-VE, 6Engineering-Community, 3ECT-August-2015, 3ECT-September-2015, and 2 others: Wrap-up report for "Graph editing in VE" - https://phabricator.wikimedia.org/T109291#1559485 (10ferdbold) [01:03:33] (03PS1) 10Alex Monk: Don't retry request in tryWithPreparedCacheKey unless the error was badcachekey [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/232878 (https://phabricator.wikimedia.org/T109787) [01:05:42] (03CR) 10Catrope: [C: 032] Don't retry request in tryWithPreparedCacheKey unless the error was badcachekey [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/232878 (https://phabricator.wikimedia.org/T109787) (owner: 10Alex Monk) [01:08:29] (03Merged) 10jenkins-bot: Don't retry request in tryWithPreparedCacheKey unless the error was badcachekey [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/232878 (https://phabricator.wikimedia.org/T109787) (owner: 10Alex Monk) [01:10:11] 10VisualEditor, 10VisualEditor-Initialisation, 10VisualEditor-MediaWiki, 7Performance: mw.Target should not retry badtoken error with full HTML - https://phabricator.wikimedia.org/T109787#1559513 (10Jdforrester-WMF) 5Open>3Resolved [01:11:46] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/230949/ [01:15:53] (03CR) 10Catrope: [C: 04-1] "James says this should be working with the betatempdisable preference instead of the -enable preference. But I don't understand the desire" (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230949 (owner: 10Alex Monk) [01:28:44] 10VisualEditor, 10VisualEditor-MediaWiki: Release VisualEditor-MediaWiki as "1.0" - https://phabricator.wikimedia.org/T84936#1559539 (10Jdforrester-WMF) [01:28:46] 10VisualEditor, 10VisualEditor-ContentLanguage: Chinese full stop disappears at the end of paragraphs, if preceded by ref tags - https://phabricator.wikimedia.org/T78122#1559536 (10Jdforrester-WMF) 5Open>3Resolved a:3Jdforrester-WMF I've re-tested and this seems to now work. [01:29:07] 10VisualEditor, 10VisualEditor-ContentLanguage: Chinese full stop disappears at the end of paragraphs, if preceded by ref tags - https://phabricator.wikimedia.org/T78122#835980 (10Jdforrester-WMF) [01:44:10] (03CR) 10Alex Monk: "We want to flip the default to on for all users, but don't necessarily want to turn it on for currently active users with a lot of contrib" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230949 (owner: 10Alex Monk) [03:20:24] 10VisualEditor, 10VisualEditor-ContentEditable, 7Browser-Support-Firefox: Focusing VisualEditor does not work in Firefox - https://phabricator.wikimedia.org/T109805#1559647 (10Catrope) 3NEW a:3Catrope [03:20:48] 10VisualEditor, 10VisualEditor-ContentEditable, 7Browser-Support-Firefox: Focusing VisualEditor does not work in Firefox - https://phabricator.wikimedia.org/T109805#1559657 (10Catrope) [03:21:54] (03PS1) 10Catrope: Make focusing surfaces work in Firefox [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/232893 (https://phabricator.wikimedia.org/T109805) [04:34:22] https://phabricator.wikimedia.org/T93800 Happening on sv.wp now again! [04:35:42] Krenair Elitre TrevorP|Away Krinkle_ mooey|away ^ [04:35:59] 10Citoid, 10VisualEditor, 10MediaWiki-ResourceLoader: Value for citoid-template-type-map.json randomly missing in some languages - https://phabricator.wikimedia.org/T93800#1559755 (10Josve05a) Now on sv.wp again [05:12:05] 10VisualEditor, 10VisualEditor-EditingTools, 7Verified-in-Phase0, 7Verified-in-Phase2: Make the comment icon in the toolbar menu match the exclamation mark one used in the surface - https://phabricator.wikimedia.org/T94479#1559773 (10Jooojay) It is unclear to me what is happening here since there are no no... [07:03:58] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic: Provide a modern wikitext editor - https://phabricator.wikimedia.org/T104479#1559850 (10Ricordisamoa) Honestly I think contributors preferring wikitext don't give a ... about the editor being "modern", "dynamic/responsive" or "OOUI-based". T47300 an... [09:12:14] 10VisualEditor: Tracking IME issues on Japanese Wikipedia - https://phabricator.wikimedia.org/T109818#1559977 (10Trizek-WMF) 3NEW [09:55:41] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References, 7Design: Change label in "Basic form" to "Basic" - https://phabricator.wikimedia.org/T108713#1560054 (10GermanJoe) As a German I don't know how common the term is, but how about "Free-form"? The problem with "Basic" in this context is: this cit... [10:16:46] edsanders : I am trying to get VisualEditor up and running on a labs instance accessible here ( http://testinstance.wmflabs.org/mediawiki/index.php/Main_Page ) [10:17:04] But whenever I enable VisualEditor, I get this error in the browser : [10:17:10] [2c2df9bc] 2015-08-21 10:16:11: Fatal exception of type MWException [10:17:15] How do I debug this? [10:17:33] look at your apache error log [10:18:08] Krenair : looking thanks :) [11:18:28] Krenair : VisualEditor and Parsed installed [11:18:34] But when I click Edit [11:18:46] I get this error : Error loading data from server: HTTP 500 [11:18:53] Any idea what can cause this? [11:19:01] I can't guess [11:19:07] you'll have to check your logs [11:25:38] Krenair : Error log has this entry [11:25:39] PHP Fatal error: Call to undefined function curl_multi_init() in /var/lib/mediawiki/includes/libs/MultiHttpClient.php on line 399, referer: http://testinstance.wmflabs.org/mediawiki/index.php/Main_Page?veaction=edit [11:26:02] you need to install the php5-curl package [11:27:45] Thanks! [11:47:17] 10VisualEditor-LanguageTool: have a working online demo of VE/LanguageTool integration - https://phabricator.wikimedia.org/T105303#1560251 (10Ankita-ks) It's available here : http://testinstance.wmflabs.org/mediawiki/index.php/Main_Page More than slightly buggy for now. But I am trying to make it smoother. [12:41:26] 10VisualEditor-LanguageTool, 6Engineering-Community, 3ECT-August-2015, 3ECT-September-2015, and 3 others: End-term evaluation for "Unified Language proofing tools integration framework" - https://phabricator.wikimedia.org/T109306#1560364 (10Amire80) [12:41:29] 10VisualEditor-LanguageTool: have a working online demo of VE/LanguageTool integration - https://phabricator.wikimedia.org/T105303#1560361 (10Amire80) 5Open>3Resolved What buggy, it works ;) Thanks a lot to Ankita and @KartikMistry for pulling this off! [12:42:06] 10VisualEditor-LanguageTool, 6Engineering-Community, 3ECT-August-2015, 3ECT-September-2015, and 3 others: End-term evaluation for "Unified Language proofing tools integration framework" - https://phabricator.wikimedia.org/T109306#1545370 (10Amire80) [13:07:41] (03PS3) 10Alex Monk: [WIP] autodisable preference [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230949 [13:16:25] 10Cite: Citation issue - https://phabricator.wikimedia.org/T109781#1560429 (10Aklapper) 5Open>3Invalid a:3Aklapper Hi @Shreerajtheauthor. Thanks for taking the time to report this. I assume this is about English Wikipedia and the classic Wikieditor (not VisualEditor). Using any web browser's developer to... [13:17:12] 10Cite: en.wp's MediaWiki:RefToolbar.js does not show any citation templates due to TypeError - https://phabricator.wikimedia.org/T109781#1560432 (10Aklapper) [14:16:41] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic: Provide a modern wikitext editor - https://phabricator.wikimedia.org/T104479#1560549 (10TheDJ) @ricordisamoa, they might not, but good foundations are often a criterium to build other stuff on top off. [14:17:00] 10VisualEditor: Add "Interlanguage link" tab to the Link dialog - https://phabricator.wikimedia.org/T109835#1560552 (10Kanzat) 3NEW [14:37:49] 10VisualEditor: Add "Interlanguage link" tab to the Link dialog - https://phabricator.wikimedia.org/T109835#1560571 (10Kanzat) [14:55:50] 10VisualEditor: Add "Interlanguage link" tab to the Link dialog - https://phabricator.wikimedia.org/T109835#1560591 (10eranroz) may be duplicate with T98135? [15:18:33] (03PS20) 10Divec: Explicitly enter/exit link annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/217257 (https://phabricator.wikimedia.org/T91285) [15:18:35] (03PS19) 10Divec: ve.ce.adjustLinkSelection: fixup link-bisecting selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/222488 [15:18:46] (03PS14) 10Divec: Fixup link selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/222619 [15:21:01] (03CR) 10jenkins-bot: [V: 04-1] ve.ce.adjustLinkSelection: fixup link-bisecting selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/222488 (owner: 10Divec) [15:21:31] (03CR) 10jenkins-bot: [V: 04-1] Fixup link selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/222619 (owner: 10Divec) [15:22:31] (03CR) 10jenkins-bot: [V: 04-1] Explicitly enter/exit link annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/217257 (https://phabricator.wikimedia.org/T91285) (owner: 10Divec) [15:23:56] 10VisualEditor, 10VisualEditor-ContentEditable, 7Browser-Support-Firefox, 5Patch-For-Review: Focusing VisualEditor does not work in Firefox - https://phabricator.wikimedia.org/T109805#1560642 (10Jdforrester-WMF) p:5Triage>3High [15:24:03] 10VisualEditor, 10VisualEditor-ContentEditable, 7Browser-Support-Firefox, 5Patch-For-Review: Focusing VisualEditor does not work in Firefox - https://phabricator.wikimedia.org/T109805#1559647 (10Jdforrester-WMF) [16:09:44] 10VisualEditor: Add edges to Phabricator task data dump transaction history - https://phabricator.wikimedia.org/T104920#1560750 (10JAufrecht) as per discussion: *ping* [16:39:00] (03CR) 10Alex Monk: [WIP] autodisable preference (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230949 (owner: 10Alex Monk) [16:43:41] (03PS1) 10Esanders: Factor our surface config compilation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/232953 [16:49:38] (03CR) 10jenkins-bot: [V: 04-1] Factor our surface config compilation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/232953 (owner: 10Esanders) [16:51:11] (03CR) 10Esanders: [C: 032] Make focusing surfaces work in Firefox [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/232893 (https://phabricator.wikimedia.org/T109805) (owner: 10Catrope) [16:53:56] (03Merged) 10jenkins-bot: Make focusing surfaces work in Firefox [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/232893 (https://phabricator.wikimedia.org/T109805) (owner: 10Catrope) [16:54:40] (03CR) 10Esanders: [C: 032] Builder for ve.dm.MWInternalLinkAnnotation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/231155 (https://phabricator.wikimedia.org/T64816) (owner: 10Cscott) [16:56:07] (03CR) 10Esanders: [C: 032] Use ve.dm.MWInternalLinkAnnotation for autolinks where appropriate [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/231167 (owner: 10Cscott) [16:58:09] (03Merged) 10jenkins-bot: Builder for ve.dm.MWInternalLinkAnnotation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/231155 (https://phabricator.wikimedia.org/T64816) (owner: 10Cscott) [16:58:26] 10VisualEditor: Selection should collapse to end after autolink paste (instead of spanning pasted contents) - https://phabricator.wikimedia.org/T109852#1560955 (10Esanders) 3NEW a:3cscott [16:59:17] (03Merged) 10jenkins-bot: Use ve.dm.MWInternalLinkAnnotation for autolinks where appropriate [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/231167 (owner: 10Cscott) [16:59:51] 10VisualEditor: Paste special should bypass autolink functionality - https://phabricator.wikimedia.org/T109854#1560974 (10Esanders) 3NEW a:3cscott [17:00:54] 10VisualEditor, 10VisualEditor-EditingTools, 7Technical-Debt: VisualEditor: Create infrastructure for creating annotations/nodes from the UI - https://phabricator.wikimedia.org/T64816#1560986 (10Jdforrester-WMF) [17:01:35] 10VisualEditor: Selection should collapse to end after autolink paste (instead of spanning pasted contents) - https://phabricator.wikimedia.org/T109852#1560994 (10cscott) This is if you do a paste with a region already selected, presumably? Seems like this should be part of the generic paste mechanism, not spec... [17:02:53] 10VisualEditor: Paste special should bypass autolink functionality - https://phabricator.wikimedia.org/T109854#1560999 (10cscott) What are the actual intended semantics of "Paste Special"? Again, this seems to be a generic paste-handler issue, if "Paste Special" is intended to mean "use the plaintext handler" o... [17:12:36] 10VisualEditor, 10VisualEditor-MediaWiki-Links: VisualEditor should let people link to another wiki easily, maybe with integrated suggestions or its own tab? - https://phabricator.wikimedia.org/T98135#1561041 (10Kanzat) Hi, as I mentioned in [[https://phabricator.wikimedia.org/T109835|T109835]] - it could be v... [17:12:55] 10VisualEditor: Add "Interlanguage link" tab to the Link dialog - https://phabricator.wikimedia.org/T109835#1561042 (10Kanzat) Yeah, looks like duplicate. [17:24:01] 10VisualEditor, 10VisualEditor-MediaWiki-Links: VisualEditor should let people link to another wiki easily, maybe with integrated suggestions or its own tab? - https://phabricator.wikimedia.org/T98135#1561102 (10Aklapper) [17:24:02] 10VisualEditor: Add "Interlanguage link" tab to the Link dialog - https://phabricator.wikimedia.org/T109835#1561101 (10Aklapper) [17:29:28] (03CR) 10Jforrester: Factor our surface config compilation (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/232953 (owner: 10Esanders) [17:30:26] (03PS3) 10Cscott: Use Parsoid v2 API [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/217995 (https://phabricator.wikimedia.org/T100681) [17:40:29] edsanders: You should update your version of svgo. [17:45:30] 10VisualEditor, 10VisualEditor-ContentEditable, 7Browser-Support-Firefox, 5WMF-deploy-2015-08-25_(1.26wmf20): Focusing VisualEditor does not work in Firefox - https://phabricator.wikimedia.org/T109805#1561246 (10Jdforrester-WMF) 5Open>3Resolved [17:46:22] (03PS1) 10Jforrester: Update VE core submodule to master (7ec7bb5) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/232964 [17:47:59] (03CR) 10Cscott: "Parsoid dependency has been deployed." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/232391 (https://phabricator.wikimedia.org/T109498) (owner: 10Cscott) [17:48:59] (03CR) 10Cscott: "edsanders: this is the next patch to merge." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/232389 (owner: 10Cscott) [17:50:12] edsanders: Prioritised review queue: https://gerrit.wikimedia.org/r/#/c/232389 https://gerrit.wikimedia.org/r/#/c/232540 https://gerrit.wikimedia.org/r/#/c/232876 https://gerrit.wikimedia.org/r/#/c/232877 [17:51:10] James_F: if edsanders +2s https://gerrit.wikimedia.org/r/232389 then you update VE core to master, that lets https://gerrit.wikimedia.org/r/232391 then be reviewed and merged to extensions/VisualEditor as its own independent patch (not as a pull through). [17:51:20] * James_F nods. [17:52:35] cscott: And then https://gerrit.wikimedia.org/r/#/c/232540/ -> https://gerrit.wikimedia.org/r/#/c/232646/ as a pull-through. [17:52:37] https://gerrit.wikimedia.org/r/#/c/232540 has https://gerrit.wikimedia.org/r/232646 as a pull-through. [17:52:41] jinx [17:52:42] Snap. [17:53:25] you can probably use https://gerrit.wikimedia.org/r/232646 as the pull through for https://gerrit.wikimedia.org/r/#/c/232389 as well, assuming edsanders does them in your priority order. ;) [17:53:27] * James_F looks forlornly at https://gerrit.wikimedia.org/r/#/q/owner:cananian%2540wikimedia.org+status:open+message:WIP+project:VisualEditor/VisualEditor,n,z [17:53:38] cscott: Assuming. ;-) [17:54:04] https://gerrit.wikimedia.org/r/#/q/status:open+message:WIP+project:VisualEditor/VisualEditor,n,z is much worse, though. [17:54:23] there's a real chance i'm going to have a daughter born next week, so my priority is getting the *non*-WIP patches actually merged. [17:54:49] * James_F grins. [17:54:57] Good excuse. :-) [17:55:14] cscott: Though your input on Ed's transaction serialising patch would be nice. [17:55:47] yeah, i was going to try to review that patch and arlo's patch updating express to 4.x today (for subbu's benefit, since i noticed he just popped in) [17:55:54] Awesome. [17:56:27] yes please :) [17:56:47] i just updated https://gerrit.wikimedia.org/r/217995 as well, which gets VE to use the Parsoid v2 API, but I think gwicke would prefer that we jump straight to an as-yet-unwritten Parsoid v3 which is more similar to the RESTBase API. [17:57:20] that's ambitious, but I might try to pull that into shape once Arlo's express patches merge. [17:57:27] Fun. [17:57:52] (Parsoid v3 API being another of those fun projects involving simultaneous patches to Parsoid, VE, and core. Oh, and Flow probably, but I haven't dipped into that code base yet.) [17:58:47] but the API patches change core first, with backwards compatibility, so I won't need to start hounding VE to upgrade until after the core patches land and ride the train. [17:58:57] or "get on the train" at least. [18:01:25] >> function foo(x) { console.log(x, arguments); x = 3; console.log(x, arguments); arguments[0] = 4; console.log(x, arguments); }; foo(1,2); [18:01:25] cscott: undefined; Console: 1, {0: 1, 1: 2, callee: (function) foo, length: 2}, 3, {0: 3, 1: 2, callee: (function) foo, length: 2}, 4, {0: 4, 1: 2, callee: (function) foo, length: 2} [18:01:43] that's fun. arguments[0] and x are aliased. [18:03:19] James_F: your input on https://phabricator.wikimedia.org/T109852 and https://phabricator.wikimedia.org/T109854 might be helpful, since I'm not clear exactly what behavior I should be implementing there. [18:03:43] * James_F looks. [18:04:29] 10VisualEditor: Paste special should bypass autolink functionality - https://phabricator.wikimedia.org/T109854#1561308 (10Jdforrester-WMF) >>! In T109854#1560999, @cscott wrote: > What are the actual intended semantics of "Paste Special"? "Paste exactly clipboard as plain-text without interpretation" [18:04:44] 10VisualEditor, 10VisualEditor-CopyPaste: Paste special should bypass autolink functionality - https://phabricator.wikimedia.org/T109854#1561309 (10Jdforrester-WMF) p:5Triage>3Normal [18:08:00] 10VisualEditor: Selection should collapse to end after autolink paste (instead of spanning pasted contents) - https://phabricator.wikimedia.org/T109852#1561320 (10Jdforrester-WMF) >>! In T109852#1560994, @cscott wrote: > This is if you do a paste with a region already selected, presumably? No. Right now if you... [18:08:11] 10VisualEditor, 10VisualEditor-CopyPaste: Selection should collapse to end after autolink paste (instead of spanning pasted contents) - https://phabricator.wikimedia.org/T109852#1561321 (10Jdforrester-WMF) p:5Triage>3High [18:18:44] 10Cite: en.wp's MediaWiki:RefToolbar.js does not show any citation templates due to TypeError - https://phabricator.wikimedia.org/T109781#1561365 (10Aklapper) [18:20:05] 10Cite: en.wp's MediaWiki:RefToolbar.js does not show any citation templates due to TypeError - https://phabricator.wikimedia.org/T109781#1559000 (10Aklapper) For future reference, if you want to debug such problems yourself (because everybody can): You can open your browser's console (or whatever it is called... [18:36:34] 10VisualEditor, 10VisualEditor-CopyPaste: Selection should collapse to end after autolink paste (instead of spanning pasted contents) - https://phabricator.wikimedia.org/T109852#1561429 (10cscott) Oh, hm! How did I not notice that? But still, there is no range-related code in the DataTransferHandler. So I s... [18:39:59] 10VisualEditor, 10VisualEditor-CopyPaste: Paste special should bypass autolink functionality - https://phabricator.wikimedia.org/T109854#1561449 (10cscott) Ok. But this should also not be autolink specific. "Paste Special" should hard code the PlainTextStringTransferHandler and not go looking for better hand... [18:49:53] 10VisualEditor, 10VisualEditor-CopyPaste: Paste special should bypass autolink functionality - https://phabricator.wikimedia.org/T109854#1561490 (10cscott) Hm. `ve.ce.Surface` seems to use a different semantics for `pasteSpecial` which is "sanitize the data by stripping down to plain text after pasting". The... [18:58:33] 10VisualEditor, 10VisualEditor-MediaWiki: Loading the read view while VE is loading can create a fused page with both the read and VE versions of the page - https://phabricator.wikimedia.org/T99139#1561505 (10Krenair) Now I can't reproduce this bug again. [18:59:24] 10VisualEditor, 10VisualEditor-CopyPaste: Paste special should bypass autolink functionality - https://phabricator.wikimedia.org/T109854#1561507 (10Jdforrester-WMF) Hmm. Not sure. [19:11:28] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-extensions-Other, 7JavaScript, and 2 others: Multiple extensions: VisualEditor JavaScript should only be added if VisualEditor is installed - https://phabricator.wikimedia.org/T88227#1561550 (10Krenair) [19:17:41] 10VisualEditor, 10VisualEditor-CopyPaste: Paste special should bypass autolink functionality - https://phabricator.wikimedia.org/T109854#1561581 (10Esanders) Yes - the fix should not be specific to autolink - I was just giving an example of the bug. I think what I called "paste special" in the code should mea... [19:22:12] 10VisualEditor, 10VisualEditor-CopyPaste: Selection should collapse to end after autolink paste (instead of spanning pasted contents) - https://phabricator.wikimedia.org/T109852#1561596 (10Esanders) Yes - this is how all transfer handlers behave. It should be configurable how the selection ends up. [19:27:35] (03CR) 10Alex Monk: [C: 032] MWLinkNodeInspector: Remove 'Open' button [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/232653 (https://phabricator.wikimedia.org/T109646) (owner: 10Jforrester) [19:27:39] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 7Easy, 5Patch-For-Review: Remove "Open" button from MWExternalLinkNode inspector - https://phabricator.wikimedia.org/T109646#1561607 (10Krenair) a:3Jdforrester-WMF [19:27:48] Thanks, Krenair. [19:28:08] I had forgotten about that commit, sorry [19:28:14] No worries. :-) [19:28:20] * James_F is very forgettable. [19:30:42] (03Merged) 10jenkins-bot: MWLinkNodeInspector: Remove 'Open' button [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/232653 (https://phabricator.wikimedia.org/T109646) (owner: 10Jforrester) [19:31:40] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 7Easy, 5WMF-deploy-2015-08-25_(1.26wmf20): Remove "Open" button from MWExternalLinkNode inspector - https://phabricator.wikimedia.org/T109646#1561617 (10Jdforrester-WMF) 5Open>3Resolved [19:33:12] (03CR) 10Alex Monk: [C: 032] Update VE core submodule to master (7ec7bb5) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/232964 (owner: 10Jforrester) [19:36:00] (03Merged) 10jenkins-bot: Update VE core submodule to master (7ec7bb5) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/232964 (owner: 10Jforrester) [19:57:39] (03PS1) 10Cscott: Don't autolink or autoconvert on "Paste Special" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/233039 (https://phabricator.wikimedia.org/T109854) [19:58:59] (03CR) 10Jforrester: [C: 031] "Neat." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/233039 (https://phabricator.wikimedia.org/T109854) (owner: 10Cscott) [20:01:40] 10VisualEditor, 10VisualEditor-CopyPaste, 5Patch-For-Review: Paste special should bypass autolink functionality - https://phabricator.wikimedia.org/T109854#1561719 (10cscott) I tried enforcing the use of the PlainTextStringHandler on "paste special" but the results were suboptimal. As @esanders suggested, j... [20:03:17] (03CR) 10jenkins-bot: [V: 04-1] Don't autolink or autoconvert on "Paste Special" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/233039 (https://phabricator.wikimedia.org/T109854) (owner: 10Cscott) [20:04:09] (03CR) 10Jforrester: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/233039 (https://phabricator.wikimedia.org/T109854) (owner: 10Cscott) [20:05:29] 10VisualEditor, 10VisualEditor-CopyPaste: Selection should collapse to end after autolink paste (instead of spanning pasted contents) - https://phabricator.wikimedia.org/T109852#1561720 (10cscott) I don't understand what "it should be configurable how the selection ends up" means. The DataTransferHandler does... [20:06:07] 10VisualEditor, 10VisualEditor-CopyPaste: Selection should collapse to end after autolink paste (instead of spanning pasted contents) - https://phabricator.wikimedia.org/T109852#1561724 (10Jdforrester-WMF) Configurable by the surface or by each DTH? [20:08:05] 10VisualEditor, 6Editing-Department, 10MediaWiki-Page-editing, 6Performance-Team, 7Availability: Investigate bad_token statsd spikes - https://phabricator.wikimedia.org/T109797#1561730 (10Jdforrester-WMF) [20:08:59] 10VisualEditor, 6Editing-Department, 10MediaWiki-Page-editing, 6Performance-Team, 7Availability: Investigate bad_token statsd spikes - https://phabricator.wikimedia.org/T109797#1561733 (10Jdforrester-WMF) p:5Triage>3Normal [20:09:08] 10VisualEditor: Tracking IME issues on Japanese Wikipedia - https://phabricator.wikimedia.org/T109818#1561734 (10Jdforrester-WMF) p:5Triage>3High [20:09:28] 10VisualEditor, 10Graph: VisualEditor throws exception while trying to open empty node - https://phabricator.wikimedia.org/T109667#1561736 (10Jdforrester-WMF) p:5Triage>3Normal [20:15:15] 10VisualEditor, 10VisualEditor-MediaWiki-Media: When inserting an image on a sub-page (Foo/Bar), the target of links in captions link to sibling pages (Foo/Baz) rather than uncle pages (Baz) - https://phabricator.wikimedia.org/T109599#1561772 (10Jdforrester-WMF) [20:15:45] 10VisualEditor, 10VisualEditor-MediaWiki-Media: When inserting an image on a sub-page (Foo/Bar), the target of links in captions link to sibling pages (Foo/Baz) rather than uncle pages (Baz) - https://phabricator.wikimedia.org/T109599#1553901 (10Jdforrester-WMF) We fixed this a year ago or so for the main docu... [20:15:58] 10VisualEditor, 10VisualEditor-MediaWiki-Media: When inserting an image on a sub-page (Foo/Bar), the target of links in captions link to sibling pages (Foo/Baz) rather than uncle pages (Baz) - https://phabricator.wikimedia.org/T109599#1561777 (10Jdforrester-WMF) [20:33:19] 10Cite: en.wp's MediaWiki:RefToolbar.js does not show any citation templates due to TypeError - https://phabricator.wikimedia.org/T109781#1561831 (10Aklapper) [20:37:01] 10Cite: en.wp's MediaWiki:RefToolbar.js does not show any citation templates due to TypeError - https://phabricator.wikimedia.org/T109781#1561840 (10Mike_Peel) According to https://en.wikipedia.org/w/index.php?title=MediaWiki:RefToolbar.js&action=history , the Javascript here hasn't been changed since November 2... [20:37:43] 10Cite: en.wp's MediaWiki:RefToolbar.js does not show any citation templates due to TypeError - https://phabricator.wikimedia.org/T109781#1561841 (10Mike_Peel) 5Invalid>3Open [20:41:22] (03PS1) 10Cscott: Don't select pasted content [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/233048 (https://phabricator.wikimedia.org/T109852) [20:42:21] 10VisualEditor, 10VisualEditor-CopyPaste, 5Patch-For-Review: Selection should collapse to end after autolink paste (instead of spanning pasted contents) - https://phabricator.wikimedia.org/T109852#1561860 (10cscott) Implemented "set range to end of inserted content" for all DTHs. If a future DTH has some di... [21:15:40] (03CR) 10Esanders: [C: 032] Don't autolink or autoconvert on "Paste Special" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/233039 (https://phabricator.wikimedia.org/T109854) (owner: 10Cscott) [21:16:18] 10Cite: en.wp's MediaWiki:RefToolbar.js does not show any citation templates due to TypeError - https://phabricator.wikimedia.org/T109781#1561941 (10Aklapper) a:5Aklapper>3None [21:19:41] (03CR) 10jenkins-bot: [V: 04-1] Don't autolink or autoconvert on "Paste Special" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/233039 (https://phabricator.wikimedia.org/T109854) (owner: 10Cscott) [21:20:57] (03CR) 10Cscott: [C: 032] "jenkins, try not to trip over yourself this time." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/233039 (https://phabricator.wikimedia.org/T109854) (owner: 10Cscott) [21:22:57] 10Cite: en.wp's MediaWiki:RefToolbar.js does not show any citation templates due to TypeError - https://phabricator.wikimedia.org/T109781#1562037 (10Mike_Peel) p:5Triage>3High [21:25:13] 10Cite: en.wp's MediaWiki:RefToolbar.js does not show any citation templates due to TypeError - https://phabricator.wikimedia.org/T109781#1562069 (10Mike_Peel) Moving this to 'high' priority since this is directly affecting content edits. [21:31:07] (03Merged) 10jenkins-bot: Don't autolink or autoconvert on "Paste Special" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/233039 (https://phabricator.wikimedia.org/T109854) (owner: 10Cscott) [21:32:03] 10VisualEditor, 10VisualEditor-MediaWiki: Save dialog hang (related to 404 in error console?) - https://phabricator.wikimedia.org/T105610#1562109 (10Krenair) I don't think the 404 is related. Has the issue been seen since mid July? [21:45:32] 10WikiEditor: en.wp's MediaWiki:RefToolbar.js does not show any citation templates due to TypeError - https://phabricator.wikimedia.org/T109781#1562163 (10TheDJ) [21:46:03] (03CR) 10TheDJ: "Caused https://phabricator.wikimedia.org/T109781" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/227187 (owner: 10Gerrit Patch Uploader) [21:48:52] (03PS1) 10TheDJ: Dialogs: handle jQuery content for dialogs [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/233064 (https://phabricator.wikimedia.org/T109781) [21:50:38] (03PS2) 10TheDJ: Dialogs: handle jQuery content for dialogs [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/233064 (https://phabricator.wikimedia.org/T109781) [21:57:28] 10VisualEditor, 10Parsoid: Do not permit blank lines between list elements (== do not permit adjacent lists with no intervening elements) - https://phabricator.wikimedia.org/T109905#1562291 (10Whatamidoing-WMF) 3NEW [22:02:12] 10WikiEditor, 5Patch-For-Review: en.wp's MediaWiki:RefToolbar.js does not show any citation templates due to TypeError - https://phabricator.wikimedia.org/T109781#1562310 (10TheDJ) Edit request for a workaround in https://en.wikipedia.org/wiki/MediaWiki_talk:Gadget-refToolbarBase.js#Protected_edit_request_on_2... [22:03:07] 10VisualEditor, 10VisualEditor-CopyPaste, 5WMF-deploy-2015-08-25_(1.26wmf20): Paste special should bypass autolink functionality - https://phabricator.wikimedia.org/T109854#1562313 (10Jdforrester-WMF) 5Open>3Resolved [22:06:40] 10WikiEditor, 5Patch-For-Review: en.wp's MediaWiki:RefToolbar.js does not show any citation templates due to TypeError - https://phabricator.wikimedia.org/T109781#1562336 (10Mike_Peel) Thanks! Edit made, and everything seems to be working OK again now! [22:07:15] 10WikiEditor, 5Patch-For-Review: en.wp's MediaWiki:RefToolbar.js does not show any citation templates due to TypeError - https://phabricator.wikimedia.org/T109781#1562337 (10Mike_Peel) Can this change be merged into MediaWiki? [22:07:22] (03CR) 10Jforrester: [C: 031] "Eww." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/233064 (https://phabricator.wikimedia.org/T109781) (owner: 10TheDJ) [22:11:26] James_F: eww indeed. .html() -> parseHTML and p00f went the gadget:) [22:11:52] thedj: It's almost as if that's a huge security vulnerability. :-) [22:13:49] well gadgets are deployed by responsible and security aware people right ;) [22:19:23] thedj: And TWN does a full security review before every push. ;-) [22:20:32] 10WikiEditor, 5Patch-For-Review: en.wp's MediaWiki:RefToolbar.js does not show any citation templates due to TypeError - https://phabricator.wikimedia.org/T109781#1562377 (10Aklapper) >>! In T109781#1562337, @Mike_Peel wrote: > Can this change be merged into MediaWiki? See https://phabricator.wikimedia.org/T1... [22:35:23] (03CR) 10Kaldari: [C: 04-1] Dialogs: handle jQuery content for dialogs (031 comment) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/233064 (https://phabricator.wikimedia.org/T109781) (owner: 10TheDJ) [23:01:49] (03PS3) 10TheDJ: Dialogs: handle jQuery content for dialogs [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/233064 (https://phabricator.wikimedia.org/T109781)