[00:01:11] 10VisualEditor, 10VisualEditor-MediaWiki, 5Patch-For-Review, 7Verified, and 2 others: References inserted with dialog (basic or reuse) get deselected after insertion - https://phabricator.wikimedia.org/T109990#1573745 (10Ryasmeen) [00:14:33] 10VisualEditor, 10VisualEditor-MediaWiki, 6Community-Tech: [AOI] HotCat doesn't load after saving a page in VisualEditor (must refresh/reload first) - https://phabricator.wikimedia.org/T103285#1573769 (10kaldari) [00:19:02] (03PS1) 10Jforrester: Update OOjs UI to v0.12.6 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/233885 [00:22:58] (03CR) 10jenkins-bot: [V: 04-1] Update OOjs UI to v0.12.6 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/233885 (owner: 10Jforrester) [00:23:20] Whut? [00:24:06] Bah. [00:24:07] (03PS2) 10Jforrester: Update OOjs UI to v0.12.6 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/233885 [00:26:09] (03CR) 10Catrope: [C: 032] Update OOjs to v1.1.9 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/233862 (owner: 10Jforrester) [00:27:14] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.12.6 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/233885 (owner: 10Jforrester) [00:37:18] (03CR) 10jenkins-bot: [V: 04-1] Update OOjs to v1.1.9 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/233862 (owner: 10Jforrester) [00:37:48] * James_F sighs. [00:45:36] (03CR) 10jenkins-bot: [V: 04-1] Update OOjs UI to v0.12.6 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/233885 (owner: 10Jforrester) [00:46:39] (03CR) 10Catrope: [C: 032] Update OOjs to v1.1.9 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/233862 (owner: 10Jforrester) [00:49:34] (03Merged) 10jenkins-bot: Update OOjs to v1.1.9 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/233862 (owner: 10Jforrester) [00:51:27] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.12.6 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/233885 (owner: 10Jforrester) [00:54:46] (03Merged) 10jenkins-bot: Update OOjs UI to v0.12.6 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/233885 (owner: 10Jforrester) [00:55:18] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/233755/ [00:55:58] (03CR) 10Catrope: [C: 032] bin/listRecentCommits.sh: Don't try to loop over OOUI commits [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/233755 (owner: 10Jforrester) [00:58:49] (03Merged) 10jenkins-bot: bin/listRecentCommits.sh: Don't try to loop over OOUI commits [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/233755 (owner: 10Jforrester) [01:01:47] 10VisualEditor, 10VisualEditor-MediaWiki, 7Verified-in-Phase2: On second edit attempt between loads, VisualEditor fails to load, complaining about revID mis-match - https://phabricator.wikimedia.org/T97069#1573862 (10Krenair) Hello? [01:02:52] 10VisualEditor, 10VisualEditor-MediaWiki, 7Verified-in-Phase2: On second edit attempt between loads, VisualEditor fails to load, complaining about revID mis-match - https://phabricator.wikimedia.org/T97069#1573863 (10Jdforrester-WMF) a:5Jdforrester-WMF>3Ryasmeen [01:08:04] https://phabricator.wikimedia.org/T108620 looks like it is part of https://phabricator.wikimedia.org/T89074 ? [01:33:46] Krenair: No, T89074 is about doing so re-using GuidedTours, T108620 is about doing something different. [01:33:56] Krenair: If you feel like building T108620 that'd be awesome. [01:34:27] We're probably going to Decline T89074 once we've built T108620 and are happy with how it tests. [01:36:23] (Moved to Backlog.) [01:41:03] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 7Easy, 5Patch-For-Review, 5WMF-deploy-2015-08-25_(1.26wmf20): Remove "Open" button from link inspectors - https://phabricator.wikimedia.org/T109646#1573986 (10Jdforrester-WMF) [01:48:18] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Mobile: "Value null is the wrong type for property "action.saveIntent.timing" (integer expected) " appears upon opening the Save dialog in mobile VE - https://phabricator.wikimedia.org/T109525#1573998 (10Krenair) This is because the computeD... [01:51:21] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Mobile: "Value null is the wrong type for property "action.saveIntent.timing" (integer expected) " appears upon opening the Save dialog in mobile VE - https://phabricator.wikimedia.org/T109525#1573999 (10Krenair) And, of course: `modules/ve-... [01:52:10] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Mobile: "Value null is the wrong type for property "action.saveIntent.timing" (integer expected) " appears upon opening the Save dialog in mobile VE - https://phabricator.wikimedia.org/T109525#1574001 (10Jdforrester-WMF) Yeah, I probably sho... [01:55:12] 10VisualEditor, 10VisualEditor-MediaWiki: Merge MobileWebEditing schema into Edit schema - https://phabricator.wikimedia.org/T110272#1574002 (10Jdforrester-WMF) 3NEW [01:56:25] 10VisualEditor, 10VisualEditor-MediaWiki: Merge MobileWebEditing schema into Edit schema - https://phabricator.wikimedia.org/T110272#1574010 (10Jdforrester-WMF) [01:56:26] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Mobile: "Value null is the wrong type for property "action.saveIntent.timing" (integer expected) " appears upon opening the Save dialog in mobile VE - https://phabricator.wikimedia.org/T109525#1574009 (10Jdforrester-WMF) [02:08:19] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Mobile: "Value null is the wrong type for property "action.saveIntent.timing" (integer expected) " appears upon opening the Save dialog in mobile VE - https://phabricator.wikimedia.org/T109525#1574014 (10Krenair) And when you move that call... [03:03:48] 10VisualEditor, 10Security-Reviews: Add edges to Phabricator task data dump transaction history - https://phabricator.wikimedia.org/T104920#1574029 (10chasemp) [07:46:09] 10Citoid: http://www.example.com/10.1086/378695 returns citation with same author listed twice - https://phabricator.wikimedia.org/T109431#1574491 (10Mvolz) [10:09:39] edsanders : I am trying to setup LanguageTool extension in a Labs instance with Mediawiki-vagrant. [10:09:49] I have role visual editor enabled [10:10:46] But I can not see LanguageTool in the toolbar [10:11:50] even though I can see it here : http://languagetoolextension.wmflabs.org/wiki/Special:Version [10:12:05] The LanguaeTool module is not loaded at all. [10:12:19] Do you have any clue wy that could happen? [10:12:21] :/ [10:38:28] 10VisualEditor: '' is frequently used unnecessarily in VisualEditor and put in - https://phabricator.wikimedia.org/T106641#1574775 (10Esanders) It would certainly be possible to override this warning in the site's common.js. You'd need to create a new command based on MWWikitextWarningCommand then overr... [11:02:19] 10VisualEditor, 10VisualEditor-MediaWiki: Inspector not repositions when inserting new extension node - https://phabricator.wikimedia.org/T110314#1574821 (10Esanders) 3NEW a:3Esanders [11:25:53] 10VisualEditor, 3Discovery-Analysis-Sprint: Get R expert to help tweak report - https://phabricator.wikimedia.org/T110080#1574880 (10Ironholds_backup) [11:27:49] (03PS1) 10Esanders: Rerender extension node immediately if no images exist [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/233935 [11:51:39] 10VisualEditor: Inspector is misplaced when inserting focusable content - https://phabricator.wikimedia.org/T110323#1574951 (10Esanders) 3NEW a:3Esanders [11:52:01] (03PS1) 10Esanders: Don't using start selection to position context for focusable nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/233938 (https://phabricator.wikimedia.org/T110323) [12:14:12] (03CR) 10Esanders: [C: 032] Move MWReferenceSourceSelectWidget into Citoid [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/233406 (https://phabricator.wikimedia.org/T109988) (owner: 10Alex Monk) [12:14:38] (03Merged) 10jenkins-bot: Move MWReferenceSourceSelectWidget into Citoid [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/233406 (https://phabricator.wikimedia.org/T109988) (owner: 10Alex Monk) [13:48:53] 10VisualEditor: Crappy code additions from visual editor - https://phabricator.wikimedia.org/T110329#1575263 (10Vituzzu) 3NEW [15:15:53] 10VisualEditor, 7Parsoid-Nowiki: ISBN are surrounded by nowiki - https://phabricator.wikimedia.org/T110347#1575669 (10NicoV) 3NEW [15:23:52] 10VisualEditor, 7Parsoid-Nowiki: ISBN are surrounded by nowiki - https://phabricator.wikimedia.org/T110347#1575690 (10cscott) Will be fixed by this week's VE deploy (tomorrow). [15:25:09] cscott, if this is fixed on master, close it [15:27:10] 10VisualEditor, 10VisualEditor-MediaWiki: Inspector not repositioned when inserting new extension node - https://phabricator.wikimedia.org/T110314#1575707 (10Esanders) [15:30:21] 10VisualEditor, 7Parsoid-Nowiki: ISBN are surrounded by nowiki - https://phabricator.wikimedia.org/T110347#1575717 (10cscott) 5Open>3Resolved a:3cscott [15:34:18] 10VisualEditor, 10OOjs-UI, 5OOjs-UI-0.12.6, 7Regression, 5WMF-deploy-2015-09-01_(1.26wmf21): Icons repeating in toolbar dropdown menu - https://phabricator.wikimedia.org/T109995#1575742 (10Jdforrester-WMF) [15:35:06] Krenair: done. [15:35:11] thanks [15:37:20] 10VisualEditor, 7Parsoid-Nowiki, 5WMF-deploy-2015-08-25_(1.26wmf20): ISBN are surrounded by nowiki - https://phabricator.wikimedia.org/T110347#1575763 (10Jdforrester-WMF) [15:37:57] (03CR) 10Jforrester: [C: 032] Move MWReferenceSourceSelectWidget out to Citoid [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/233407 (https://phabricator.wikimedia.org/T109988) (owner: 10Alex Monk) [15:38:16] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki, 5Patch-For-Review, and 2 others: Move MWReferenceSourceSelectWidget to Citoid - https://phabricator.wikimedia.org/T109988#1575774 (10Jdforrester-WMF) 5Open>3Resolved [15:40:21] (03Merged) 10jenkins-bot: Move MWReferenceSourceSelectWidget out to Citoid [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/233407 (https://phabricator.wikimedia.org/T109988) (owner: 10Alex Monk) [15:41:31] (03CR) 10Jforrester: [C: 031] Don't using start selection to position context for focusable nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/233938 (https://phabricator.wikimedia.org/T110323) (owner: 10Esanders) [15:41:46] 10VisualEditor, 10VisualEditor-EditingTools, 5Patch-For-Review: Inspector is misplaced when inserting focusable content - https://phabricator.wikimedia.org/T110323#1575796 (10Jdforrester-WMF) [15:41:59] 10VisualEditor, 10VisualEditor-EditingTools, 5Patch-For-Review: Inspector is misplaced when inserting focusable content - https://phabricator.wikimedia.org/T110323#1575802 (10Jdforrester-WMF) p:5Triage>3Normal [15:42:35] (03CR) 10Jforrester: "Is this to fix T110314 or just bonus?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/233935 (owner: 10Esanders) [15:42:49] 10VisualEditor, 10VisualEditor-MediaWiki: Inspector not repositioned when inserting new extension node - https://phabricator.wikimedia.org/T110314#1575803 (10Jdforrester-WMF) p:5Triage>3Normal [15:44:17] 10VisualEditor, 10VisualEditor-MediaWiki-Templates: Show a personalised (per-user) list of most recent / commonly used templates when selecting from dropdown - https://phabricator.wikimedia.org/T109253#1575808 (10Jdforrester-WMF) 5stalled>3Open p:5Triage>3Lowest [15:44:31] 10VisualEditor, 10VisualEditor-MediaWiki-Templates: Show a personalised (per-user) list of most recent / commonly used templates when selecting from dropdown - https://phabricator.wikimedia.org/T109253#1544045 (10Jdforrester-WMF) Understood. That makes this much harder to do, of course. [15:49:49] 10VisualEditor: Crappy code additions from visual editor - https://phabricator.wikimedia.org/T110329#1575829 (10Jdforrester-WMF) 5Open>3stalled Can you explain why you think this is anything other than the user making these changes? [15:53:18] hey all [15:53:36] Citoid seems to be broken on en.wp. @James_F [15:53:40] (03CR) 10Alex Monk: [C: 032] Don't using start selection to position context for focusable nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/233938 (https://phabricator.wikimedia.org/T110323) (owner: 10Esanders) [15:53:47] Elitre: Fun. [15:53:56] Elitre: Has someone null-edited it to fix it? [15:54:08] I followed instructions at https://en.wikipedia.org/w/api.php?action=purge&titles=MediaWiki:Citoid-template-type-map.json but that doesn't seem to make a difference [15:54:47] Elitre: Looks to be working fine to me… [15:55:03] then maybe it did? [15:55:18] 10Citoid, 10VisualEditor, 10MediaWiki-ResourceLoader: Value for citoid-template-type-map.json randomly missing in some languages - https://phabricator.wikimedia.org/T93800#1575852 (10Jdforrester-WMF) And again on enwiki just now. [15:55:40] yup, I see it now as well. I guess it also takes a few mins to take effect. [15:55:51] * James_F sighs. [15:56:34] Yes, MediaWiki namespace edits don't always take effect immediately. [15:56:42] (03Merged) 10jenkins-bot: Don't using start selection to position context for focusable nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/233938 (https://phabricator.wikimedia.org/T110323) (owner: 10Esanders) [15:56:46] thanks. [15:57:06] 10VisualEditor, 10VisualEditor-EditingTools: Inspector is misplaced when inserting focusable content - https://phabricator.wikimedia.org/T110323#1575855 (10Jdforrester-WMF) [15:57:14] 10VisualEditor, 10VisualEditor-EditingTools, 5WMF-deploy-2015-09-01_(1.26wmf21): Inspector is misplaced when inserting focusable content - https://phabricator.wikimedia.org/T110323#1574951 (10Jdforrester-WMF) [15:57:21] 10VisualEditor, 10VisualEditor-EditingTools, 5WMF-deploy-2015-09-01_(1.26wmf21): Inspector is misplaced when inserting focusable content - https://phabricator.wikimedia.org/T110323#1575857 (10Jdforrester-WMF) 5Open>3Resolved [15:57:27] 10Citoid, 10VisualEditor, 10MediaWiki-ResourceLoader: Value for citoid-template-type-map.json randomly missing in some languages - https://phabricator.wikimedia.org/T93800#1575858 (10Elitre) If clicking on the link provided in the description is enough, that's what I did, but it took some mins for the change... [15:59:00] 10VisualEditor, 10VisualEditor-MediaWiki-Templates: {{Italic title}} produced two invisible-template icons - https://phabricator.wikimedia.org/T95720#1575863 (10Jdforrester-WMF) 5Open>3stalled Possibly one was from this template and the other was from another? [16:08:48] 10Citoid, 10VisualEditor: Make adding page numbers to {{cite book}} more efficient - https://phabricator.wikimedia.org/T96000#1575882 (10Whatamidoing-WMF) `pages` is already "suggested" in the TemplateData. When you add a template via the citoid service, or when you edit a pre-existing one that does not con... [16:30:56] @TrevorP|Away I learned a new thing today! Had to read the wikipedia article re: sticky buns. [16:55:35] (03PS1) 10Jforrester: Update VE core submodule to master (c194486) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/234006 [16:57:06] 10VisualEditor, 7Parsoid-Nowiki, 5WMF-deploy-2015-08-25_(1.26wmf20): ISBN are surrounded by nowiki - https://phabricator.wikimedia.org/T110347#1575995 (10cscott) Related phab tasks, for reference: T109498 T109371 T54204 T107431 T107433 T103364 . [17:13:45] 10VisualEditor, 7Design: Most of the editing toolbar buttons are unlabeled icons, which can reduce usability - https://phabricator.wikimedia.org/T95233#1576028 (10Jdforrester-WMF) p:5Triage>3Low [17:14:09] 10VisualEditor, 10VisualEditor-ContentEditable: Shift-enter should create
line break - https://phabricator.wikimedia.org/T95518#1576031 (10Jdforrester-WMF) p:5Triage>3Normal [17:15:19] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 7Epic: Make VisualEditor good enough for mobile tablet and phone default enablement - https://phabricator.wikimedia.org/T94725#1576044 (10Jdforrester-WMF) [17:15:21] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 7Browser-Support-Android-Google-Chrome: VE Mobile: Tapping words sometimes moves them to the lead section and makes them bold - https://phabricator.wikimedia.org/T71634#1576040 (10Jdforrester-WMF) 5Open>3stalled a:3Ryasmeen [17:15:23] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 7Browser-Support-Android-Google-Chrome: VisualEditor Mobile: In android, while trying to apply a link on a selected text, strips off the first letter of the text in the link inspector - https://phabricator.wikimedia.org/T70244#1576042 (10Jdforrester-WMF) 5Ope... [17:15:25] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 7Browser-Support-Android-Google-Chrome: VisualEditor Mobile: Cursor moving handle (?) doesn't appear in Android - https://phabricator.wikimedia.org/T68783#1576045 (10Jdforrester-WMF) 5Open>3stalled a:3Ryasmeen [17:15:27] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 7Epic: Make VisualEditor good enough for mobile tablet and phone default enablement - https://phabricator.wikimedia.org/T94725#1171139 (10Jdforrester-WMF) [17:15:29] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 7Browser-Support-Android-Google-Chrome: VisualEditor Mobile: Tapping at the end of each link, does copy-paste of preceding link text in Nexus 7(Android 4.4.2) - https://phabricator.wikimedia.org/T68755#1576050 (10Jdforrester-WMF) 5Open>3stalled a:3Ryasmeen [17:15:31] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 7Browser-Support-Android-Google-Chrome: VisualEditor Mobile: Tapping on Return while cursor is at the end of a text, deletes that text in Nexus 7 (Android 4.4.2) - https://phabricator.wikimedia.org/T68758#1576047 (10Jdforrester-WMF) 5Open>3stalled a:3Ryas... [17:15:33] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 7Epic: Make VisualEditor good enough for mobile tablet and phone default enablement - https://phabricator.wikimedia.org/T94725#1171139 (10Jdforrester-WMF) [17:15:35] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 7Browser-Support-Android-Google-Chrome: VisualEditor Mobile: Tapping at the end of each link duplicates the preceding link text in Nexus 7 (Android 4.4.2) - https://phabricator.wikimedia.org/T68754#1576053 (10Jdforrester-WMF) 5Open>3stalled a:3Ryasmeen [17:15:38] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 7Epic: Make VisualEditor good enough for mobile tablet and phone default enablement - https://phabricator.wikimedia.org/T94725#1171139 (10Jdforrester-WMF) [17:17:01] James_F, edsanders: Three unmerged link patches are more-or-less ready [17:17:11] * James_F nods. [17:17:36] I'd really like us to put the patches in front of some users for some quick design testing. [17:17:41] divec, comment on 222488 [17:17:50] The main one is 217257 (Explicitly enter/exit link selections), and then there are two follow-ups: 222488 (ve.ce.adjustLinkSelection: fixup link-bisecting selections) and 222619 (Fixup link selections) [17:18:10] Also we could probably do with another pass on the visual design cues. [17:18:11] 10VisualEditor, 10VisualEditor-MediaWiki: Merge MobileWebEditing schema into Edit schema - https://phabricator.wikimedia.org/T110272#1576062 (10Neil_P._Quinn_WMF) [17:20:06] (03CR) 10Divec: "This code gets used by Id8d827b58cf63a11f89299388960d49224295685 to prevent partial selections. I see no reasonable, IME-safe way to deal " [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/222488 (owner: 10Divec) [17:35:39] 10VisualEditor, 10VisualEditor-EditingTools: Make it easy to copy some information from one ref to another, by keeping both windows open at the same time - https://phabricator.wikimedia.org/T110357#1576156 (10Whatamidoing-WMF) 3NEW [17:45:49] (03CR) 10Divec: Explicitly enter/exit link annotations (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/217257 (https://phabricator.wikimedia.org/T91285) (owner: 10Divec) [17:46:05] (03PS22) 10Divec: Explicitly enter/exit link annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/217257 (https://phabricator.wikimedia.org/T91285) [17:46:38] (03PS21) 10Divec: ve.ce.adjustLinkSelection: fixup link-bisecting selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/222488 [17:46:49] (03PS16) 10Divec: Fixup link selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/222619 [17:47:19] James_F: How best would we organise some user design testing? [17:47:33] divec_: Through Nirzar. [17:49:12] (03CR) 10jenkins-bot: [V: 04-1] Explicitly enter/exit link annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/217257 (https://phabricator.wikimedia.org/T91285) (owner: 10Divec) [17:50:37] divec_: We'd probably want to throw a quick test wiki up on Labs with this configuration (i.e. with all the patches). [17:50:48] divec_: Probably could do it just with the stand-alone VE. [17:52:05] (03CR) 10jenkins-bot: [V: 04-1] ve.ce.adjustLinkSelection: fixup link-bisecting selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/222488 (owner: 10Divec) [17:52:25] James_F: Ok - would we be aiming to see how to improve the visual cues? [17:52:28] (03CR) 10jenkins-bot: [V: 04-1] Fixup link selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/222619 (owner: 10Divec) [17:52:43] divec_: I dunno, I like it enough right now but Nirzar may have some thoughts. [17:53:20] divec_: My main issue really right now is that double-click expands only out to the pins, not the 'whole' word, but it's not really important (and not obviously fixable). [17:53:57] Good point. Shall I email everyone then? [17:54:42] divec_: That sounds good. [17:58:25] I need someone with Chrome (maybe James_F?) to look at https://en.wikipedia.org/wiki/Wikipedia:VisualEditor/Feedback#Summary_field_NOT_ACTIVE_on_.22Save_Page.22 and see whether it's reproducible. [18:00:13] mooeypoo: https://phabricator.wikimedia.org/T68808 ? [18:00:37] whatami: Looking. [18:01:08] whatami: It works for me. Chrome 44 on Mac. [18:01:54] Okay. He runs a wiki, so I'll ask whether he encountered it here or there. [18:01:58] Thanks. [18:02:12] whatami: Oh, yeah, that is an issue with the last release of VE. [18:02:20] whatami: We fixed it six months ago, but… [18:02:40] I believe that was reported in June, so it probably wasn't quite six months ago. [18:03:52] whatami: We fixed it in master; the release of VE was already out at that point. [18:04:48] edsanders: Could you respond to that user on wikitech-l? [18:04:56] 10VisualEditor: Unwanted tag additions (__NOEDITSECTION__, __INDICE__, etc) from visual editor - https://phabricator.wikimedia.org/T110329#1576309 (10Aklapper) [18:12:29] 10VisualEditor: Make it easy to find existing citations in the body of an article - https://phabricator.wikimedia.org/T110364#1576343 (10Whatamidoing-WMF) 3NEW [18:15:04] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 7Verified, 7Verified-in-Phase0, 5WMF-deploy-2015-08-25_(1.26wmf20): Selecting a paragraph shows a context menu with the message in mobile VE - https://phabricator.wikimedia.org/T109503#1576356 (10Ryasmeen) [18:28:13] 10VisualEditor, 10VisualEditor-MediaWiki-References: When a ref is selected, gray out the options in the Cite menu that aren't possible - https://phabricator.wikimedia.org/T110368#1576408 (10Whatamidoing-WMF) 3NEW [18:29:41] 10VisualEditor, 10VisualEditor-ContentEditable, 7Browser-Support-Firefox, 7Verified-in-Phase0, 5WMF-deploy-2015-08-25_(1.26wmf20): Focusing VisualEditor does not work in Firefox - https://phabricator.wikimedia.org/T109805#1576423 (10Ryasmeen) [18:34:07] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References: The citoid-enabled Cite menu offers to "Add a citation" when you are "Editing" rather than "Adding" one - https://phabricator.wikimedia.org/T110369#1576437 (10Whatamidoing-WMF) 3NEW [18:42:04] (03CR) 10Cscott: WIP: Specialized inspector for ISBN magic links (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/233669 (https://phabricator.wikimedia.org/T63558) (owner: 10Cscott) [18:42:39] 10MediaWiki-extensions-Graph-VE, 10VisualEditor, 10Graph, 6Services, 3Google-Summer-of-Code-2015: Graph editing in VisualEditor - https://phabricator.wikimedia.org/T89287#1576489 (10Yaron_Koren) Hi - I take it that this project consisted of changes to the Graph extension (https://www.mediawiki.org/wiki/E... [19:08:57] 10VisualEditor: Inspector crashes while trying to open it in a position where another inspector was opened previously - https://phabricator.wikimedia.org/T110378#1576585 (10Ryasmeen) 3NEW [19:16:07] 10VisualEditor: Inspector crashes while trying to open it in a position where another inspector was opened previously - https://phabricator.wikimedia.org/T110378#1576609 (10Ryasmeen) This happens for all inspectors, if you delete any previous node for example: Gallery/Link/Math/Language and try to open another l... [19:18:35] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References: The citoid-enabled Cite menu offers to "Add a citation" when you are "Editing" rather than "Adding" one - https://phabricator.wikimedia.org/T110369#1576614 (10Mvolz) @krenair @esanders was this the result of moving the reference widget into citoid? [19:28:34] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References: The citoid-enabled Cite menu offers to "Add a citation" when you are "Editing" rather than "Adding" one - https://phabricator.wikimedia.org/T110369#1576658 (10Jdforrester-WMF) >>! In T110369#1576614, @Mvolz wrote: > @krenair @esanders was this th... [19:28:46] 10VisualEditor: The blue selection highlight of a node appears over the toolbar in mobile VE - https://phabricator.wikimedia.org/T110380#1576659 (10Ryasmeen) [19:29:28] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References: Clicking "Cite" when selecting an existing citation inserts a new one after it, rather than editing the existing one - https://phabricator.wikimedia.org/T110369#1576671 (10Jdforrester-WMF) [19:30:32] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References: Clicking "Cite" when selecting an existing citation inserts a new one after it, rather than editing the existing one - https://phabricator.wikimedia.org/T110369#1576437 (10Jdforrester-WMF) I've re-worded the title to be clear. I think this behavi... [19:37:01] James_F, I don't think I do wikitech-l [19:37:11] edsanders: "Do"? [19:37:55] It's my Campbellism [19:38:10] Uh-huh. [19:38:21] Should I reply to the list telling him to speak to you in IRC? ;-) [19:39:05] or phabricator if there's a specific task, e.g. "Improve VE gadget documentation" [19:40:08] "Binding on components events (e.g. the 'save' event, to analyze content and maybe abort saving)" is a WONTFIX, right? [19:40:22] We're staying the hell away from hooks. [19:45:21] I'd look at what they're trying to do then come with a suitable recommendation [19:45:32] I'll reply. [19:52:45] I don't think we'll have pre-save validation - the document should always be valid [19:53:34] for (3) just rewrite the class and overwrite in the registry [19:53:36] Replied. [19:53:48] Now you can follow-up to my reply and say where I'm wrong. :-) [19:54:06] Maybe he wants a gadget that stops you saving a page without the word "fish" in it. [19:54:15] That would be "validation" but not "HTML validation". [19:54:37] But yeah, we need to get an idea of what he's looking for before we can usefully answer. [19:56:04] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 7Browser-Support-Android-Google-Chrome: VE Mobile: Tapping words sometimes moves them to the lead section and makes them bold - https://phabricator.wikimedia.org/T71634#1576790 (10Esanders) I have some annotation corruption in Android which looked very much li... [19:57:08] I mean any sort of document validation [19:57:14] that information should be displayed live [19:57:56] that there is even a single save point is an artefact of MW [19:59:24] 10Citoid, 10VisualEditor, 10MediaWiki-ResourceLoader: Value for citoid-template-type-map.json randomly missing in some languages - https://phabricator.wikimedia.org/T93800#1576796 (10Elitre) Now reported on de.wp. I'm applying the workaround. [20:02:43] 10Citoid, 10VisualEditor, 10MediaWiki-ResourceLoader: Value for citoid-template-type-map.json randomly missing in some languages - https://phabricator.wikimedia.org/T93800#1576802 (10Mvolz) @krinkle have you had a chance to examine the bug in production yet? Do you need us to stop clearing the cache so you h... [20:05:58] 10Citoid, 10VisualEditor, 10MediaWiki-ResourceLoader: Value for citoid-template-type-map.json randomly missing in some languages - https://phabricator.wikimedia.org/T93800#1576807 (10Krinkle) >>! In T93800#1576802, @Mvolz wrote: > @krinkle have you had a chance to examine the bug in production yet? Do you ne... [20:08:58] 10Citoid, 10VisualEditor, 10MediaWiki-ResourceLoader: Value for citoid-template-type-map.json randomly missing in some languages - https://phabricator.wikimedia.org/T93800#1576823 (10Elitre) Having to ping you on IRC was a step I was not aware of. We can all consider doing that the next time this happens. [20:14:10] 10VisualEditor, 3Discovery-Analysis-Sprint: Get R expert to help tweak report - https://phabricator.wikimedia.org/T110080#1576844 (10Ironholds_backup) @Jaufrecht so I discussed this with James yesterday; it initially sounded like a 30-minute task but given that it is 300 lines of plotting code is actually a lo... [20:14:13] edsanders: Hm.. would you say it's expected behaviour that selecting plain text, opening link inspector, typing name, selecting result and clicking back in the document does not result in a link? [20:14:33] Eventhough it is previewed as a in CE temporarily, it then unlinks it because I didn't press "Done" [20:15:56] we changed it so that you had to press done to commit a change [20:16:05] that was more for editing than creating links [20:16:15] but it might be odd if it behaved differently between those two [20:16:19] 10VisualEditor, 10VisualEditor-InterfaceLanguage, 10VisualEditor-MediaWiki, 7Design, and 4 others: The checkboxen in the save dialog wrap poorly if the texts are too long - https://phabricator.wikimedia.org/T70572#1576849 (10Ryasmeen) [20:16:29] Yeah. But in dialogs I choose between cancel or apply changes [20:16:32] or cancel and insert [20:16:44] with links there is an non-explicit cancelling which I find counter-intuitive. [20:17:02] in dialogs the user can't exist without choosing one of those two [20:17:03] that's the problem with the inspector being non-modal [20:17:06] with inspectors the user isn't reminded. [20:17:10] Yeah [20:17:13] you have to pick something [20:17:13] It hits me every time. [20:17:26] when we picked apply people were annoyed that it didn't dismiss their changes [20:17:30] Or rather, it hits me every time I haven't used VE for 24 hours. [20:17:47] 10VisualEditor, 10VisualEditor-InterfaceLanguage, 10VisualEditor-MediaWiki, 7Design, and 5 others: The checkboxen in the save dialog wrap poorly if the texts are too long - https://phabricator.wikimedia.org/T70572#728300 (10Ryasmeen) [20:18:14] makes it quite tedious when adding links to a bunch of words in a list, select, cmd K, select option, *Done*, then off to the next. [20:18:26] I think now that we have it cancel on dismiss we should get rid of the visual preview [20:18:41] Google docs is the same - it just doesn't show the link like it's already been applied [20:18:48] right [20:19:42] The word "Done" also doesn't read to me like it performs the actual change. I'd be looking for something like "Insert", "Add" or "Create". Done sounds to me like an optional thing for novice users needing a button that power users bypass. [20:20:03] Google uses 'Apply' [20:20:10] Yeah [20:20:16] the staging is useful for stuff like inserting references, so it might be odd to have it for that but not links [20:20:18] "when we picked apply people were annoyed that it didn't dismiss their changes" [20:20:20] what do you mean by that? [20:20:56] when it was the other way around, i.e. clicking away from the inspector applied your changes [20:21:10] people complained that they expected clicking away to dismiss their changes [20:22:17] it is annoying anyway (auto-cancel/auto-apply), so maybe the inspector should kept open? [20:23:03] eranroz, changing the selection while the inspector is open creates a whole lot of other problems [20:23:42] and it equally counter-intuitive - people expect to be able to dismiss it by moving somewhere else [20:25:18] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References, 7Design: Change label in "Basic form" to "Basic" - https://phabricator.wikimedia.org/T108713#1576888 (10Jdforrester-WMF) 5Open>3stalled Marking as 'stalled' until someone comes up with some good wording. [20:26:20] 10VisualEditor, 10VisualEditor-MediaWiki-References: Clicking "Cite X" when selecting an existing citation inserts a new one after it, rather than editing the existing one - https://phabricator.wikimedia.org/T110368#1576891 (10Jdforrester-WMF) [20:27:31] 10VisualEditor, 10VisualEditor-MediaWiki-References: Clicking "Cite X" when selecting an existing citation inserts a new one after it, rather than editing the existing one - https://phabricator.wikimedia.org/T110368#1576408 (10Jdforrester-WMF) This suffers from the same general conceptual belief as {T110369} –... [20:28:15] krinkle [20:28:21] Elitre: o/ [20:28:34] I think I found the wiki you need to check Citoid issues :) [20:28:44] OK [20:28:46] it's currently not working on nl.wp. [20:28:52] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References, 7Design, and 2 others: Show separation between template and 'basic' citation types in the "manual" tab - https://phabricator.wikimedia.org/T108725#1576898 (10Ryasmeen) [20:29:22] Elitre: Perfect [20:30:15] Krinkle: Solution is to use VE more often. ;-) [20:30:22] Elitre: I'm investigating now [20:30:27] (Previous discussion.) [20:30:32] Elitre: Don't fix nlwiki. :-) [20:30:35] thanks! [20:30:45] James_F: ... yes. [20:30:49] Also, yes, woo Krinkle you're awesome. [20:31:33] I assume it was triggered by the deployment train when the localisation was rebuilt [20:31:57] Krinkle: Hmm. Plausible. [20:32:22] Krinkle: Note that the majority of incidents have seemed to have happened at ~ 03:00 PDT (i.e., after the nightly LocalisationUpdate). [20:34:54] I checked the other wikis with citoid, and only 3 so far seem to be broken today. [20:35:16] "Only". :-( [20:35:32] well, "it's something"? :/ [20:36:48] 10Citoid, 10VisualEditor, 10MediaWiki-ResourceLoader: Value for citoid-template-type-map.json randomly missing in some languages - https://phabricator.wikimedia.org/T93800#1576915 (10Elitre) I actually just found one, and Krinkle is looking into it now. [20:37:48] Krinkle: will you please remember to fix the wiki when you're done? :) [20:38:10] Yes [20:38:19] I'll ask them to bear patience in the meanwhile. [20:45:11] Elitre: purged. [20:45:13] (by me) [20:45:27] Krinkle: Any leads? [20:49:12] James_F: One. Which is enough for now. [20:49:13] Looking into it [20:51:32] VisualEditor/modules/ve-mw/ui/styles/images/icons - rtl/ltr icons designed by humans or by "smart" auto flip software? [20:52:17] eranroz: Humans. [20:52:33] eranroz: Mostly, me. ;_0 [20:52:44] eranroz: CssJanus will flip things, though. [20:52:53] s/flip/switch variants/ [20:52:53] so question mark in RTL language is the same as in English! [20:53:05] i will fix it... [20:53:22] 10Citoid, 10VisualEditor, 10MediaWiki-ResourceLoader: Value for citoid-template-type-map.json randomly missing in some languages - https://phabricator.wikimedia.org/T93800#1576995 (10Elitre) That was nl.wp, and Krinkle just fixed it. [20:53:50] I'll go now. I'll follow the task for updates. thank you! [20:54:58] Thank you Elitre. [20:55:02] eranroz: No. [20:55:23] eranroz: RTL '?' is flipped for all languages except he and yi, per aharoni. [20:55:36] eranroz: He said that he and yi users would expect it to not be flipped. [20:56:03] eranroz: We spent a huge amount of effort to make a system that let us flip for RTL but not for some RTL languages. Please don't report that that was for nought. :-) [20:56:31] i see fliped question mark for page-not-found-rtl.svg [21:03:49] James_F: what do you mean "flip for RTL but not for some RTL languages"? what is that system, is it part of janus? some magic like @noflip @except[lang="he"]? [21:09:39] eranroz: no, it's a separate one, only available for icons (or other images) used in CSS. we actually have brand new docs for it: https://www.mediawiki.org/wiki/ResourceLoader/Images#Identifying_different_icons [21:17:56] (03PS1) 10Eranroz: Fixing question mark in he and yi [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/234145 [21:23:45] cscott, I think I've found an issue with the parsoid v3 stuff [21:25:51] or actually, the restbase part [21:26:14] "Only 'html' format is currently supported" [21:32:44] 'html' and the title are getting passed in the wrong way around [21:34:07] Krenair: what is it? [21:35:43] ahh [21:35:57] 10Citoid, 10VisualEditor, 10MediaWiki-ResourceLoader: Value for citoid-template-type-map.json randomly missing in some languages - https://phabricator.wikimedia.org/T93800#1577178 (10Krinkle) I confirmed that this bug is caused by a race condition in Varnish during a deployment (e.g. the first request coming... [21:36:22] this is because I had 'parsoidCompat' => true in my restbase vrs config, cscott [21:36:29] James_F: No solution yet. I'm hoping another resident MediaWiki core all-around developer gets some inspiration from my leads [21:36:56] Krenair: that's the only format VisualEditor uses for a POST, AFAIK. [21:36:57] Flow uses POST for both directions of the transform, but it doesn't use VRS (yet!) [21:36:57] My Flow-VRS patch will use the parsoid v3 API from the start, so it won't be a problem. [21:36:57] Krenair: unless you can trigger this message with VE somehow? or some other way? [21:37:34] I triggered it with VE by having $wgVirtualRestConfig['modules']['restbase']['parsoidCompat'] = true [21:37:42] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki-Links, 7Verified-in-Phase0, 5WMF-deploy-2015-08-25_(1.26wmf20): Automatically recognise bare links and magic links (ISBN/etc.), and display as a link - https://phabricator.wikimedia.org/T54204#1577184 (10Ryasmeen) [21:38:23] 10VisualEditor, 10VisualEditor-MediaWiki, 7Verified-in-Phase0, 5WMF-deploy-2015-08-25_(1.26wmf20), 7user-notice: Autolink typed ISBN/PMID/RFCs - https://phabricator.wikimedia.org/T109498#1577193 (10Ryasmeen) [21:41:19] cscott, okay, one last thing [21:41:40] I notice you set the default $wgVirtualRestConfig['global']['domain'] to $wgCanonicalServer in DefaultSettings [21:42:01] Doesn't that need to be done in Setup? [21:42:24] (if the user hasn't already overridden it in their config) [21:43:19] 10VisualEditor, 7Parsoid-Nowiki, 7Verified-in-Phase0, 5WMF-deploy-2015-08-25_(1.26wmf20): ISBN are surrounded by nowiki - https://phabricator.wikimedia.org/T110347#1577198 (10Ryasmeen) [21:54:01] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki, 7Verified-in-Phase0, 5WMF-deploy-2015-08-25_(1.26wmf20): Convert pasted fragments of basic wikitext into rich content - https://phabricator.wikimedia.org/T109449#1577214 (10Ryasmeen) [21:54:41] Krinkle: Right-o. [21:55:34] Krenair: oh, you're probably right about the Setup thing. [21:55:59] (03CR) 10Jforrester: "We should probably have an RTL image with a double-mirrored ? instead for he/yi, yes?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/234145 (owner: 10Eranroz) [21:57:01] and if you could leave a comment on the patch about the parsoidCompat thing, the v3 VE patch (which I'm assuming you were using) should probably force parsoidCompat to false, to be safe. [21:57:21] (03CR) 10Eranroz: "what do you mean? (isn't the ltr=double mirrored?)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/234145 (owner: 10Eranroz) [21:58:19] (03CR) 10Jforrester: "No, see the curvature at the bottom of the icon. These are intended as part of the design to give a feeling of forward-movement." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/234145 (owner: 10Eranroz) [21:58:27] (03CR) 10Alex Monk: Use RESTBase v1 API (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/217995 (https://phabricator.wikimedia.org/T100681) (owner: 10Cscott) [21:58:30] cscott, done [22:00:30] Krenair: thanks. I'll make that tweak later tonight. (Unless you feel like doing it!) [22:06:11] 10VisualEditor, 10VisualEditor-MediaWiki-Templates: {{Italic title}} produced two invisible-template icons - https://phabricator.wikimedia.org/T95720#1577267 (10Whatamidoing-WMF) It's a tiny stub, and there aren't that many templates. The entire wikitext code is visible in the diff here: https://en.wikipedi... [22:09:29] 10VisualEditor, 6Analytics-Backlog, 10Analytics-Dashiki, 6Editing-Analysis: Start generating a visual editor adoption metric - https://phabricator.wikimedia.org/T109158#1577289 (10Jdforrester-WMF) [22:09:35] 10VisualEditor, 6Editing-Analysis, 6Editing-Department: Investigate why visual editor users have a higher save rate in EventLogging data but didn't in the A/B test - https://phabricator.wikimedia.org/T108241#1577291 (10Jdforrester-WMF) [22:09:38] 10VisualEditor, 6Editing-Analysis, 6Editing-Department: Define performance indicators for the VisualEditor team - https://phabricator.wikimedia.org/T107351#1577293 (10Jdforrester-WMF) [22:35:40] 10VisualEditor, 10VisualEditor-MediaWiki-Links: Relative links to subpages aren't treated as links to the mainspace that start with / - https://phabricator.wikimedia.org/T110413#1577391 (10Whatamidoing-WMF) 3NEW [22:36:00] 10VisualEditor, 10VisualEditor-MediaWiki-Links: Relative links to subpages are treated as links to the mainspace that start with / until after saving - https://phabricator.wikimedia.org/T110413#1577398 (10Whatamidoing-WMF) [22:43:50] (03CR) 10Eranroz: "OK you are right. But I see it isn't possible to do this magic easily with Inkscape :(" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/234145 (owner: 10Eranroz) [22:50:31] eranroz: It's easy, I'll do it. [22:50:44] eranroz: File a Phabricator task? [22:59:51] 10VisualEditor, 10VisualEditor-EditingTools, 7Verified-in-Phase0, 5WMF-deploy-2015-08-25_(1.26wmf20): Put the LanguageInspector's language and language code fields be on a single line - https://phabricator.wikimedia.org/T110127#1577508 (10Ryasmeen) [23:06:15] (03PS2) 10Jforrester: page-not-found*.svg: Provide semi-flipped variant for he, yi [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/234145 (owner: 10Eranroz) [23:07:37] eranroz: +1 and I'll +2? [23:15:39] 10VisualEditor, 6Discovery, 10MediaWiki-API, 10MediaWiki-Search, and 5 others: Prefix search API doesn't return "index" field when "redirects" is enabled. - https://phabricator.wikimedia.org/T92796#1577619 (10ksmith) [23:18:19] (03CR) 10Eranroz: [C: 031] page-not-found*.svg: Provide semi-flipped variant for he, yi [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/234145 (owner: 10Eranroz) [23:18:43] Thanks! [23:18:50] standalone="no" in the svg? [23:18:51] Hmm. We should really have a Phabricator task. [23:19:09] eranroz: Hmm. svgo output… [23:19:52] 10VisualEditor: Missing page question mark icon should be similar to LTR for he and yi - https://phabricator.wikimedia.org/T110429#1577657 (10eranroz) 3NEW a:3eranroz [23:20:43] 10VisualEditor, 10VisualEditor-MediaWiki-Links: The "page not found" icon should be semi-flipped for he, yi - https://phabricator.wikimedia.org/T110430#1577666 (10Jdforrester-WMF) 3NEW a:3Jdforrester-WMF [23:20:49] Ha. [23:20:51] Timing. :-) [23:21:01] 10VisualEditor, 10VisualEditor-MediaWiki-Links: The "page not found" icon should be semi-flipped for he, yi - https://phabricator.wikimedia.org/T110430#1577674 (10Jdforrester-WMF) [23:21:03] 10VisualEditor: Missing page question mark icon should be similar to LTR for he and yi - https://phabricator.wikimedia.org/T110429#1577675 (10Jdforrester-WMF) [23:21:46] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 7I18n: Missing page question mark icon should be similar to LTR for he and yi - https://phabricator.wikimedia.org/T110429#1577683 (10Jdforrester-WMF) p:5Triage>3Normal [23:21:55] (03PS3) 10Jforrester: page-not-found*.svg: Provide semi-flipped variant for he, yi [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/234145 (https://phabricator.wikimedia.org/T110429) (owner: 10Eranroz) [23:22:06] (03CR) 10Jforrester: [C: 032] page-not-found*.svg: Provide semi-flipped variant for he, yi [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/234145 (https://phabricator.wikimedia.org/T110429) (owner: 10Eranroz) [23:23:37] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 7I18n: Missing page question mark icon should be similar to LTR for he and yi - https://phabricator.wikimedia.org/T110429#1577694 (10Jdforrester-WMF) 5Open>3Resolved [23:23:48] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-Links, 10VisualEditor-MediaWiki-Links, and 4 others: Increase width of inspectors on desktop - https://phabricator.wikimedia.org/T101290#1577696 (10Ryasmeen) [23:27:49] (03PS2) 10Krinkle: Removes compatibility aliases for old ve init modules [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/229442 (owner: 10Jforrester) [23:28:06] Krinkle: … [23:28:22] James_F: I renamed it because it was linked from Tech News by you, and that name wasn't very useful. [23:28:26] (the revert summary) [23:28:26] (03Merged) 10jenkins-bot: page-not-found*.svg: Provide semi-flipped variant for he, yi [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/234145 (https://phabricator.wikimedia.org/T110429) (owner: 10Eranroz) [23:28:39] Krinkle: Sure, but you violated your own commit title standards. :-P [23:28:45] (03CR) 10Jforrester: Removes compatibility aliases for old ve init modules (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/229442 (owner: 10Jforrester) [23:28:48] James_F: Oh? [23:28:56] Krinkle: Imperative, not descriptive. [23:28:58] OH [23:28:59] Remove [23:28:59] Yes [23:29:00] Thanks [23:29:05] (03PS3) 10Krinkle: Remove compatibility aliases for old ve init modules [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/229442 (owner: 10Jforrester) [23:29:07] Hence my surprise. [23:30:10] It's more my reflex to add -s to words. It's not specific for that purpose. It's a common typo of mine. When I type fast I often slip down to 's' after 'e'. [23:30:44] * James_F nods. [23:37:04] it will be interesting to see the half-life span of methods in VE compared to mw or other extensions until deprecation. it is hard to maintain VE gadgets |: [23:37:26] RL changes are documented better in mw wiki [23:39:39] eranroz: Wait for VE to exit beta. :-) [23:40:05] is chrome and gmail still in beta? :) [23:43:17] No and no. [23:43:32] Chrome was never in public pre-release, IIRC. [23:43:36] Firefox was. [23:50:29] (03PS2) 10Jforrester: [BREAKING CHANGE] Remove ve.selectEnd() [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/232777 (owner: 10Catrope) [23:51:11] (03CR) 10Jforrester: [C: 032] [BREAKING CHANGE] Remove ve.selectEnd() [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/232777 (owner: 10Catrope) [23:51:42] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 7Verified-in-Phase0, 7Verified-in-Phase2, and 2 others: Provide a context item for MWNumberedExternalLinkNodes - https://phabricator.wikimedia.org/T98211#1577811 (10Ryasmeen) [23:51:43] (03PS2) 10Jforrester: Use .moveCursorToEnd() instead of ve.selectEnd() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/232778 (owner: 10Catrope) [23:51:59] (03PS3) 10Jforrester: MWSaveDialog: Use .moveCursorToEnd() instead of ve.selectEnd() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/232778 (owner: 10Catrope) [23:52:12] (03CR) 10Jforrester: [C: 032] MWSaveDialog: Use .moveCursorToEnd() instead of ve.selectEnd() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/232778 (owner: 10Catrope) [23:53:22] (03CR) 10Krinkle: WIP: Specialized inspector for ISBN magic links (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/233669 (https://phabricator.wikimedia.org/T63558) (owner: 10Cscott) [23:55:07] (03Merged) 10jenkins-bot: [BREAKING CHANGE] Remove ve.selectEnd() [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/232777 (owner: 10Catrope) [23:55:09] (03Merged) 10jenkins-bot: MWSaveDialog: Use .moveCursorToEnd() instead of ve.selectEnd() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/232778 (owner: 10Catrope) [23:55:11] Woo. [23:57:19] (03PS1) 10Jforrester: Update VE core submodule to master (9123d3b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/234189 [23:57:48] (03CR) 10Jforrester: "Breaking change no longer affects this repo after Ic7ed8a24a." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/234189 (owner: 10Jforrester)