[06:10:31] 10VisualEditor, 10VisualEditor-MediaWiki, 10Architecture, 7Epic: API/Hooks to intercept certain events in VisualEditor - https://phabricator.wikimedia.org/T110644#1588426 (10Osnard) @Esanders: I just want to perform some checks on the page content (one example is "Has the user assigned at least one categor... [06:15:06] 10VisualEditor, 10VisualEditor-MediaWiki, 10Architecture, 7Epic: API/Hooks to intercept certain events in VisualEditor - https://phabricator.wikimedia.org/T110644#1588428 (10Osnard) @Jdforrester-WMF: Yes, totaly :) [09:22:45] 10VisualEditor: Please generate a list of Most referenced domains on the Dutch Wikipedia - https://phabricator.wikimedia.org/T107788#1588684 (10Elitre) Hi @Edgars2007! Thank you so much for your work. So these lists need to inform work related to Citoid. If a heavily used source on a given wiki is not working pr... [09:32:05] 10VisualEditor, 7Tracking: Tracking IME issues on Korean Wikipedia - https://phabricator.wikimedia.org/T110654#1588710 (10Trizek-WMF) Thank you @revi :) [09:41:34] 10Citoid, 10VisualEditor, 6Community-Liaison: Recurring checks for Citoid's status - https://phabricator.wikimedia.org/T110597#1588728 (10Elitre) [09:43:47] 10Citoid, 10VisualEditor, 6Community-Liaison: Recurring checks for Citoid's status - https://phabricator.wikimedia.org/T110597#1588730 (10Elitre) Well, thanks @Josve05a! If you want to specify time and date manually, please also add a timezone :) [09:57:21] 10VisualEditor, 10WikiEditor, 7Epic: Remember the "often used" special characters on a per user basis - https://phabricator.wikimedia.org/T110722#1588759 (10Elitre) Ooh la la, Epic. And we thought a plain cookie would fix this :) [10:32:04] 10VisualEditor: Please generate a list of Most referenced domains on the Dutch Wikipedia - https://phabricator.wikimedia.org/T107788#1588826 (10Edgars2007) @Elitre [[https://sv.wikipedia.org/wiki/Anv%C3%A4ndare:Edgars2007/Most_frequent_domains|Here you are]]. Created also for [[https://es.wikipedia.org/wiki/Usua... [12:26:37] (03CR) 10Zfilipin: [C: 04-1] "Voting -1 until merge conflict is resolved." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/225288 (https://phabricator.wikimedia.org/T90577) (owner: 10Vikassy) [13:58:36] 10VisualEditor: Please generate a list of Most referenced domains on the Dutch Wikipedia - https://phabricator.wikimedia.org/T107788#1504001 (10Elitre) (Can you please describe the method you used, or at least say if it has anything to do with the one detailed in the task description? TY!) [14:13:37] 10MediaWiki-extensions-Graph-VE, 10VisualEditor, 10Graph, 6Services, 3Google-Summer-of-Code-2015: Graph editing in VisualEditor - https://phabricator.wikimedia.org/T89287#1589196 (10NiharikaKohli) [14:13:41] 10MediaWiki-extensions-Graph-VE, 6Engineering-Community, 3ECT-August-2015, 3ECT-September-2015, and 3 others: End-term evaluation for "Graph editing in VE" - https://phabricator.wikimedia.org/T109305#1589193 (10NiharikaKohli) 5Open>3Resolved Looks good. Yay, we have an awesome new VE feature now. :)... [14:13:56] 10VisualEditor-LanguageTool, 6Editing-Department, 6Language-Engineering, 3Google-Summer-of-Code-2015, 7I18n: Unified language proofing tools integration framework - https://phabricator.wikimedia.org/T89107#1589200 (10NiharikaKohli) [14:14:09] 10MediaWiki-extensions-Graph-VE, 6Engineering-Community, 3ECT-August-2015, 3ECT-September-2015, and 2 others: Wrap-up report for "Graph editing in VE" - https://phabricator.wikimedia.org/T109291#1589201 (10NiharikaKohli) 5Open>3Resolved Nicely done! [14:14:14] 10MediaWiki-extensions-Graph-VE, 10VisualEditor, 10Graph, 6Services, 3Google-Summer-of-Code-2015: Graph editing in VisualEditor - https://phabricator.wikimedia.org/T89287#1125095 (10NiharikaKohli) [15:08:56] 10VisualEditor, 10VisualEditor-MediaWiki-References: The first time the (citoid-enabled) Cite dialog is open, don't default to Re-use - https://phabricator.wikimedia.org/T110134#1589372 (10Elitre) I was surprised by this behaviour as well, FWIW. [15:13:09] 10Citoid, 10VisualEditor, 6Community-Liaison: Recurring checks for Citoid's status - https://phabricator.wikimedia.org/T110597#1589382 (10Elitre) Everything's ok (I was just surprised by T110134!). [15:18:03] 10VisualEditor, 6Design Research Backlog, 10MediaWiki-General-or-Unknown: MediaWiki's feedback tool interface is confusing - https://phabricator.wikimedia.org/T100011#1589397 (10aripstra) Thanks for the suggestions @Capt_Swing, I agree with all of them. One further suggestion have is to clearly define "user... [15:23:53] James_F, https://en.wikipedia.org/wiki/Wikipedia:VisualEditor/Feedback#Visual_editor_failing_to_load_.28happening_a_lot.29 [15:24:11] edsanders: Could you look at https://gerrit.wikimedia.org/r/#/c/234346/ and merge if you're happy? Roan wants it for VE in Flow. [15:24:43] subbu|afk: Hmm. Sounds like a RESTbase failure. Odd. [15:35:40] (03CR) 10Jforrester: [C: 04-1] "Needs to be flagged as a breaking change and fix uses." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/221171 (owner: 10Paladox) [15:39:46] (03PS1) 10Esanders: Use model-only surface in ListAction test [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/235022 [15:39:49] (03PS1) 10Esanders: Reuse test view in paste tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/235023 [15:39:51] (03PS1) 10Esanders: Reuse example surface across surface view tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/235024 [15:42:58] 10VisualEditor, 6Collaboration-Team-Backlog, 10Flow, 7Design: Cancel the modal on templates with no parameters - https://phabricator.wikimedia.org/T110800#1589488 (10Esanders) I think it can be improved, for example pressing escape/cancel should leave the {{ on the page, but given that it's such a rare thi... [15:43:35] (03CR) 10jenkins-bot: [V: 04-1] Reuse example surface across surface view tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/235024 (owner: 10Esanders) [15:43:42] (03CR) 10jenkins-bot: [V: 04-1] Reuse test view in paste tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/235023 (owner: 10Esanders) [15:46:57] 10VisualEditor, 6Collaboration-Team-Backlog, 10Flow, 7Design: Cancel the modal on templates with no parameters - https://phabricator.wikimedia.org/T110800#1589492 (10Jdforrester-WMF) 5Open>3declined a:3Jdforrester-WMF I think the ask here is to be able to type `{{foo}}` and just have it insert the te... [15:55:38] (03CR) 10Esanders: "Yes, user config. Updated as such. See the follow up commit for usage." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/234609 (owner: 10Esanders) [15:59:00] (03PS2) 10Esanders: Reuse example surface across surface view tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/235024 [15:59:02] (03PS2) 10Esanders: Reuse test view in paste tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/235023 [16:01:17] (03PS4) 10Esanders: [PULL THROUGH] Implement getUserConfig and setUserConfig in MW [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/234611 [16:02:23] (03CR) 10jenkins-bot: [V: 04-1] Reuse example surface across surface view tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/235024 (owner: 10Esanders) [16:04:03] (03CR) 10jenkins-bot: [V: 04-1] [PULL THROUGH] Implement getUserConfig and setUserConfig in MW [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/234611 (owner: 10Esanders) [16:04:19] 10VisualEditor: Please generate a list of Most referenced domains on the Dutch Wikipedia - https://phabricator.wikimedia.org/T107788#1589539 (10Edgars2007) I'm using [[http://quarry.wmflabs.org/query/2948|this query]]. [16:08:28] (03PS5) 10Esanders: [PULL THROUGH] Implement getUserConfig and setUserConfig in MW [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/234611 [16:10:56] (03CR) 10jenkins-bot: [V: 04-1] [PULL THROUGH] Implement getUserConfig and setUserConfig in MW [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/234611 (owner: 10Esanders) [16:12:54] 10VisualEditor-LanguageTool: Weekly Reports for LanguageTool Extension for VisualEditor - https://phabricator.wikimedia.org/T101695#1589574 (10NiharikaKohli) 5Open>3Resolved [16:12:55] 10VisualEditor-LanguageTool, 6Editing-Department, 6Language-Engineering, 3Google-Summer-of-Code-2015, 7I18n: Unified language proofing tools integration framework - https://phabricator.wikimedia.org/T89107#1589576 (10NiharikaKohli) [16:13:19] 10MediaWiki-extensions-Graph-VE: Weekly reports for "Enable VisualEditor support in Graph extension" - https://phabricator.wikimedia.org/T101119#1589577 (10NiharikaKohli) 5Open>3Resolved [16:13:25] 10MediaWiki-extensions-Graph-VE, 10VisualEditor, 10Graph, 6Services, 3Google-Summer-of-Code-2015: Graph editing in VisualEditor - https://phabricator.wikimedia.org/T89287#1589579 (10NiharikaKohli) [16:18:04] (03CR) 10Cscott: Allow trailing punctuation for typed ISBN/PMID/RFC autolinks (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/234566 (https://phabricator.wikimedia.org/T110690) (owner: 10Cscott) [16:24:52] (03CR) 10Esanders: [C: 04-1] "works fine, code style things" (035 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/233669 (https://phabricator.wikimedia.org/T63558) (owner: 10Cscott) [16:27:46] (03PS1) 10Esanders: Remove explicit setting of ce=false on FocusableNodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/235036 [16:30:32] (03CR) 10Jforrester: [C: 032] Remove explicit setting of ce=false on FocusableNodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/235036 (owner: 10Esanders) [16:32:06] (03CR) 10Esanders: [C: 04-1] "Also should there be an API to this through the view?" (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/234346 (owner: 10Catrope) [16:32:21] edsanders: Thanks. [16:59:25] 10VisualEditor, 10VisualEditor-ContentLanguage: Non-finalised input is added to the document when using the Anthy Japanese IME with VisualEditor - https://phabricator.wikimedia.org/T108566#1589678 (10Trizek-WMF) [16:59:27] 10VisualEditor, 10VisualEditor-ContentLanguage: Word breaking rules used in VisualEditor do not work optimally in Japanese - https://phabricator.wikimedia.org/T101917#1589679 (10Trizek-WMF) [16:59:29] 10VisualEditor: Tracking IME issues on Japanese Wikipedia - https://phabricator.wikimedia.org/T109818#1589677 (10Trizek-WMF) [16:59:36] 10VisualEditor, 7Tracking: Tracking IME issues on Japanese Wikipedia - https://phabricator.wikimedia.org/T109818#1559977 (10Trizek-WMF) [17:02:43] (03PS23) 10Divec: Explicitly enter/exit link annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/217257 (https://phabricator.wikimedia.org/T91285) [17:06:12] (03CR) 10jenkins-bot: [V: 04-1] Explicitly enter/exit link annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/217257 (https://phabricator.wikimedia.org/T91285) (owner: 10Divec) [17:13:30] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-References, 10Parsoid: VisualEditor: References inside galleries being displayed separately, inside the gallery, instead of in the correct block at the end of the page - https://phabricator.wikimedia.org/T74865#1589730 (10... [17:30:29] (03CR) 10Catrope: Add ve.dm.Surface#selectLastContentOffset (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/234346 (owner: 10Catrope) [17:41:26] edsanders|away: Also +2 on https://gerrit.wikimedia.org/r/#/c/234805/ please? [17:44:06] (03CR) 10Jforrester: [C: 031] Add user config methods and implement in standalone using localStorage [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/234609 (owner: 10Esanders) [17:45:40] edsanders|away: Also also, worth considering doing https://phabricator.wikimedia.org/T85638 (but only for VE) as a user localStorage thing? [17:46:22] (03CR) 10Jforrester: [C: 031] Store find and replace toggle states in user config [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/234610 (https://phabricator.wikimedia.org/T110541) (owner: 10Esanders) [17:47:15] edsanders|away: And if so, would you like Krenair to look at it or you or just ignore? [17:48:41] (03CR) 10Jforrester: [C: 032] Use model-only surface in ListAction test [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/235022 (owner: 10Esanders) [17:49:17] (03CR) 10Jforrester: [C: 032] Reuse test view in paste tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/235023 (owner: 10Esanders) [17:49:38] (03PS3) 10Jforrester: tests: Re-use example surface across surface view tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/235024 (owner: 10Esanders) [17:49:46] (03CR) 10Jforrester: [C: 032] tests: Re-use example surface across surface view tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/235024 (owner: 10Esanders) [17:54:35] (03CR) 10jenkins-bot: [V: 04-1] Use model-only surface in ListAction test [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/235022 (owner: 10Esanders) [17:54:37] (03CR) 10jenkins-bot: [V: 04-1] Reuse test view in paste tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/235023 (owner: 10Esanders) [17:54:39] (03CR) 10jenkins-bot: [V: 04-1] tests: Re-use example surface across surface view tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/235024 (owner: 10Esanders) [17:56:14] (03CR) 10Cscott: Specialized inspector for ISBN magic links (035 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/233669 (https://phabricator.wikimedia.org/T63558) (owner: 10Cscott) [17:56:40] (03PS2) 10Jforrester: tests: Use model-only surface in ListAction test [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/235022 (owner: 10Esanders) [17:56:47] (03CR) 10Jforrester: [C: 032] tests: Use model-only surface in ListAction test [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/235022 (owner: 10Esanders) [18:01:38] (03CR) 10jenkins-bot: [V: 04-1] tests: Use model-only surface in ListAction test [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/235022 (owner: 10Esanders) [18:07:16] 10VisualEditor, 6Discovery, 10MediaWiki-API, 10MediaWiki-Search, and 5 others: Prefix search API doesn't return "index" field when "redirects" is enabled. - https://phabricator.wikimedia.org/T92796#1589968 (10EBernhardson) So how can we move this forward? One idea could be setting some sort of merge policy... [18:09:33] 10VisualEditor, 10Parsoid, 10RESTBase: Possible cases where scrubWikitext wasn't being passed? - https://phabricator.wikimedia.org/T110153#1589982 (10ssastry) [18:14:33] 10VisualEditor, 10Parsoid, 10RESTBase: Possible cases where scrubWikitext wasn't being passed? - https://phabricator.wikimedia.org/T110153#1590012 (10ssastry) [18:17:49] James_F: VE stopped working for me locally after i updated stuff recently. it that related to restbase stuff? do you know how do i get it to work again? [18:18:08] (parsoidserver-http: HTTP 404) [18:27:59] Krenair: ^ (i'm trying to get your SyntaxHighlight patch, eh) [18:38:43] (03PS1) 10Divec: Don't call setInsertionAnnotations on handleInsertion [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/235054 [18:44:06] (03CR) 10Divec: "Catrope, care to check my sanity on this?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/235054 (owner: 10Divec) [19:00:22] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Plugins, 10SyntaxHighlight, and 2 others: Prompt the user with a drop-down list of available languages when VE-editing a SyntaxHighlight block - https://phabricator.wikimedia.org/T103756#1590283 (10matmarex) This fixes the performance, but... [19:01:01] MatmaRex: I don't see it on Mac. [19:01:44] James_F: by the way, do you know how to get VE working locally again? [19:01:57] MatmaRex: `vagrant git-update`. [19:01:59] looks like restbase-related changes broke it for me [19:02:02] MatmaRex: Which isn't helpful. [19:02:04] i don't use vagrant…? [19:02:10] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Plugins, 10SyntaxHighlight, and 2 others: Prompt the user with a drop-down list of available languages when VE-editing a SyntaxHighlight block - https://phabricator.wikimedia.org/T103756#1590293 (10Jdforrester-WMF) Looks fine to me: {F2514... [19:02:25] MatmaRex: Yeah, I outsource my making-sysadmin-things-work to the MW-Vagrant team. :-) [19:02:32] i have the mediawiki/blahblah repos cloned, i have parsoid installed via apt [19:02:41] everything is on the latest version [19:02:56] Did you fix the config? [19:03:05] New MW-core config for how to point to Parsoid/etc. [19:03:10] what config do i need to fix? or, how do i learn that i have to fix it? [19:03:15] I /think/ it wasn't backwards-incompatible. [19:03:19] But maybe some bit of it was. [19:04:41] i guess https://www.mediawiki.org/wiki/Extension:VisualEditor#Linking_with_Parsoid [19:04:55] MatmaRex: https://gerrit.wikimedia.org/r/#/c/214351/ is the change. [19:05:26] MatmaRex: Adds the new 'domain' config value, but it also sets it to a sane default. [19:05:35] Unless $wgCanonicalServer isn't right for you? [19:12:16] MatmaRex: Success? [19:14:22] no, it's still fucked and i'm flailing [19:14:44] i didn't have $wgCanonicalServer set, so instead i removed my existing config and used https://www.mediawiki.org/wiki/Extension:VisualEditor#Linking_with_Parsoid [19:14:52] but it did not help [19:14:55] Hmm. [19:15:06] the parsoidConfig.setMwApi thing seems new, since i did not have that in my settings.js file [19:15:07] MatmaRex: The experts are Krenair and cscott, and neither are around. :-( [19:16:15] 10VisualEditor, 10VisualEditor-MediaWiki-References: The first time the (citoid-enabled) Cite dialog is open, don't default to Re-use - https://phabricator.wikimedia.org/T110134#1590335 (10Whatamidoing-WMF) I like remembering what I used last for this page/this editing session; I don't like remembering what (o... [19:16:33] but adding that did not help either; i'm getting a different error now, though, (curl error: 7) Couldn't connect to server: parsoidserver-http-error: (curl error: 7) Couldn't connect to server. [19:27:49] (03CR) 10Jforrester: [C: 032] tests: Use model-only surface in ListAction test [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/235022 (owner: 10Esanders) [19:30:51] (03Merged) 10jenkins-bot: tests: Use model-only surface in ListAction test [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/235022 (owner: 10Esanders) [19:31:14] (03PS3) 10Jforrester: tests: Reuse test view in paste tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/235023 (owner: 10Esanders) [19:31:19] (03PS4) 10Jforrester: tests: Reuse test view in paste tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/235023 (owner: 10Esanders) [19:31:25] (03CR) 10Jforrester: [C: 032] tests: Reuse test view in paste tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/235023 (owner: 10Esanders) [19:34:29] (03Merged) 10jenkins-bot: tests: Reuse test view in paste tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/235023 (owner: 10Esanders) [19:35:00] (03PS4) 10Jforrester: tests: Re-use example surface across surface view tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/235024 (owner: 10Esanders) [19:35:07] (03CR) 10Jforrester: [C: 032] tests: Re-use example surface across surface view tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/235024 (owner: 10Esanders) [19:37:58] (03Merged) 10jenkins-bot: tests: Re-use example surface across surface view tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/235024 (owner: 10Esanders) [19:38:14] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References: Clicking "Cite" when selecting an existing citation inserts a new one after it, rather than editing the existing one - https://phabricator.wikimedia.org/T110369#1590418 (10Whatamidoing-WMF) The "alternative" that I want is: # A new "ref" does... [19:42:50] James_F: okay, i identified the first problem: the documentation at https://www.mediawiki.org/wiki/Extension:VisualEditor#Linking_with_Parsoid lies [19:43:01] trying to call parsoidConfig.setMwApi like this results in the service not starting [19:43:05] MatmaRex: Fun. [19:43:07] because parsoidConfig.setMwApi takes two parameters, not one [19:43:29] Was it prematurely written before the https://gerrit.wikimedia.org/r/#/c/217995/ was merged? [19:43:38] i can't tell if the docs are wrong, or if the apt parsoid is out of date [19:45:40] James_F: when i do configure it in a way that works, i get [fatal/request][localhost/v3/page/html/SyntaxHighlight/338] Did not find page revisions for V3/page/html/SyntaxHighlight/338 in the log ("SyntaxHighlight" is page title) [19:46:26] Even better. [19:46:27] * James_F sighs. [19:46:38] It seems to be working in Beta Cluster… [19:46:47] What's different about the config there? [19:49:40] who knows [19:50:00] but my setup isn't really special, so i imagine you'll get more people with this problem [19:50:08] * James_F nods. [19:50:11] let me know if anyone comes and manages to solve it [19:50:13] because i give up [19:50:23] :-( [19:50:32] please point cscott or whoever at the broken docs [19:50:39] Wait until tomorrow when Alex and cscott are back. [19:54:40] James_F, the localStorage implementation is only for SA. If we want to use LS for MW & WMF that would involve other considerations [19:55:03] edsanders: LS/whatever. [19:56:18] edsanders: But not a priority. :-) [19:56:25] edsanders: https://gerrit.wikimedia.org/r/#/c/234805/ is more os. :-) [19:58:41] (03CR) 10Esanders: [C: 032] Update VE core submodule to master (ff259df) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/234805 (owner: 10Jforrester) [19:59:20] Ta. [19:59:45] 10VisualEditor, 10VisualEditor-EditingTools, 5WMF-deploy-2015-09-01_(1.26wmf21): FindAndReplaceDialog throws exception during VE deactivation - https://phabricator.wikimedia.org/T110538#1590476 (10Jdforrester-WMF) 5Open>3Resolved [20:00:10] 10VisualEditor, 10VisualEditor-EditingTools, 5WMF-deploy-2015-09-01_(1.26wmf21): Highlights not hidden when mouse out on gallery - https://phabricator.wikimedia.org/T110195#1590478 (10Jdforrester-WMF) 5Open>3Resolved [21:09:34] (03CR) 10Catrope: [C: 04-1] "It looks like the "annotations" variable is unused in both code paths after this change, so it should be removed (that also saves you havi" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/235054 (owner: 10Divec) [21:30:26] (03CR) 10Catrope: "I'm particularly concerned about whether this will change behavior when inserting over top of an annotated selection. For example, have Fo" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/235054 (owner: 10Divec) [21:32:14] Krinkle: You OK with Ed's responses on https://gerrit.wikimedia.org/r/#/c/234609/ ? [21:44:21] 10VisualEditor, 7Parsoid-Nowiki: VisualEditor should not ISBN numbers - https://phabricator.wikimedia.org/T110953#1590780 (10Tgr) 3NEW [21:45:13] (03PS1) 10Jforrester: Follow-up 94105a7: Fix build for added language 'en-ca' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/235136 [21:45:48] 10VisualEditor, 7Parsoid-Nowiki: VisualEditor should not ISBN numbers - https://phabricator.wikimedia.org/T110953#1590788 (10Jdforrester-WMF) You mean Parsoid. And it was fixed last week. [21:47:33] mooeypoo: Could I ask you to +2 https://gerrit.wikimedia.org/r/#/c/235136/ ? [21:48:48] 10VisualEditor: Finish reconstruction refactoring - https://phabricator.wikimedia.org/T110704#1590790 (10JAufrecht) [21:51:17] (03PS2) 10Jforrester: MWReferenceNode: Don't allow cross-VE paste of template-defined ref [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/234408 (https://phabricator.wikimedia.org/T110479) (owner: 10Esanders) [21:51:42] RoanKattouw: Could I ask you to +2 https://gerrit.wikimedia.org/r/234408 ? It's a save crasher. :-( [21:52:01] (03CR) 10Jforrester: MWReferenceNode: Don't allow cross-VE paste of template-defined ref (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/234408 (https://phabricator.wikimedia.org/T110479) (owner: 10Esanders) [21:52:38] 10VisualEditor, 7Parsoid-Nowiki: VisualEditor should not ISBN numbers - https://phabricator.wikimedia.org/T110953#1590800 (10ssastry) Parsoid will nowiki if it gets text that looks like wikitext markup. I think this is a duplicate of T110690. [21:55:08] 10VisualEditor, 7Parsoid-Nowiki: VisualEditor should not ISBN numbers - https://phabricator.wikimedia.org/T110953#1590803 (10Jdforrester-WMF) >>! In T110953#1590800, @ssastry wrote: > Parsoid will nowiki if it gets text that looks like wikitext markup. I think this is a duplicate of T110690. There's... [21:55:12] 10VisualEditor, 7Parsoid-Nowiki: VisualEditor should not ISBN numbers - https://phabricator.wikimedia.org/T110953#1590804 (10Jdforrester-WMF) [21:55:14] 10VisualEditor, 10VisualEditor-MediaWiki, 5Patch-For-Review: Typed ISBN autolinks do not allow trailing punctuation - https://phabricator.wikimedia.org/T110690#1590805 (10Jdforrester-WMF) [21:57:45] (03CR) 10Catrope: [C: 032] MWReferenceNode: Don't allow cross-VE paste of template-defined ref [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/234408 (https://phabricator.wikimedia.org/T110479) (owner: 10Esanders) [21:59:42] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/235136/ [21:59:50] (03Merged) 10jenkins-bot: MWReferenceNode: Don't allow cross-VE paste of template-defined ref [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/234408 (https://phabricator.wikimedia.org/T110479) (owner: 10Esanders) [22:00:00] (03CR) 10Catrope: [C: 032] Follow-up 94105a7: Fix build for added language 'en-ca' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/235136 (owner: 10Jforrester) [22:02:58] (03Merged) 10jenkins-bot: Follow-up 94105a7: Fix build for added language 'en-ca' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/235136 (owner: 10Jforrester) [22:03:24] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki-References, 5WMF-deploy-2015-09-01_(1.26wmf21): Copying a template-defined reference should be blocked because VE has no HTML to copy (causing Parsoid to throw a 500 error) - https://phabricator.wikimedia.org/T110479#1590816 (10Jdforrester-W... [22:13:09] 10VisualEditor: Generate project data from edge transaction data - https://phabricator.wikimedia.org/T110955#1590845 (10JAufrecht) 3NEW a:3JAufrecht [22:14:23] (03CR) 10Krinkle: Add user config methods and implement in standalone using localStorage (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/234609 (owner: 10Esanders) [22:14:42] (03CR) 10Krinkle: [C: 031] "Looks good to me on that front :) See inline comment though." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/234609 (owner: 10Esanders) [22:20:33] keep in mind - localstorage is full for wikipedia firefox users https://bugzilla.mozilla.org/show_bug.cgi?id=1064466 :) [22:24:07] eranroz: It doesn't use LS in MW. [22:24:13] eranroz: That's the stand-alone version. [22:24:18] eranroz: I.e., "demo". [22:26:11] James_F: what is demo here? isn't it going to master and be used later? [22:26:50] eranroz: No. Ignoring Flow, ve.init.sa.Platform isn't loaded in MW production. [22:27:01] Instead there's ve.init.mw.Platform* [22:27:19] This is what 'multiple integrations' means. :-) [22:29:02] eranroz: (And yes, it's really confusing, I know.) [22:36:47] (03CR) 10Eranroz: Store find and replace toggle states in user config (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/234610 (https://phabricator.wikimedia.org/T110541) (owner: 10Esanders) [22:45:36] (03CR) 10Eranroz: Add user config methods and implement in standalone using localStorage (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/234609 (owner: 10Esanders) [22:48:48] (03PS3) 10Jforrester: Platform: Add user config methods [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/234609 (owner: 10Esanders) [22:50:36] (03CR) 10Jforrester: Platform: Add user config methods (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/234609 (owner: 10Esanders) [22:50:46] (03CR) 10Jforrester: Platform: Add user config methods (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/234609 (owner: 10Esanders) [22:51:59] eranroz: In my new version (as well as fixing Krinkle's astute observation) I renamed it to focus on the main value-add, not the demo-specific example. [22:52:04] eranroz: Hope that's helpful? [22:57:55] I don't see what was renamed, but I don't understand what is "user" here. If anyone who use this device (with same browser) shares this config it is device/platform/something else config, not user config [22:58:31] eranroz: They don't. [23:00:29] (03CR) 10Jforrester: Store find and replace toggle states in user config (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/234610 (https://phabricator.wikimedia.org/T110541) (owner: 10Esanders) [23:05:07] eranroz: On stand-alone, 'user' is device, yes, but that's just an issue for the demo. For VE-MW, user is the MW account. [23:05:47] ok I get it, it stores it using the API with specific user config [23:06:15] (03PS3) 10Jforrester: Store find and replace toggle states in user config [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/234610 (https://phabricator.wikimedia.org/T110541) (owner: 10Esanders) [23:06:53] eranroz: Yeah. [23:07:12] eranroz: But in stand-alone we don't have a 'user' concept, so we fall back to using localStorage which is good enough for a demo. [23:12:44] (03CR) 10Alex Monk: [C: 04-1] [PULL THROUGH] Implement getUserConfig and setUserConfig in MW (033 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/234611 (owner: 10Esanders) [23:18:45] (03CR) 10Krinkle: [PULL THROUGH] Implement getUserConfig and setUserConfig in MW (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/234611 (owner: 10Esanders) [23:39:29] 10VisualEditor: Finish reconstruction refactoring - https://phabricator.wikimedia.org/T110704#1591215 (10JAufrecht) [23:39:54] 10VisualEditor: Incorporate Kevin's code review feedback - https://phabricator.wikimedia.org/T110977#1591217 (10JAufrecht) 3NEW a:3JAufrecht [23:40:12] 10VisualEditor: Change interrupt trend chart to be interrupt % chart - https://phabricator.wikimedia.org/T110087#1591224 (10JAufrecht) 5Open>3Resolved [23:40:13] 10VisualEditor: Create third version of VE burnup report - https://phabricator.wikimedia.org/T107482#1591225 (10JAufrecht) [23:54:47] (03PS9) 10Cscott: Specialized inspector for ISBN magic links [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/233669 (https://phabricator.wikimedia.org/T63558) [23:55:16] 10VisualEditor: Find-Replace: some parts of the box are still visible after closing. - https://phabricator.wikimedia.org/T86791#1591255 (10Jdforrester-WMF) [23:55:34] 10VisualEditor, 10VisualEditor-ContentEditable: VisualEditor: Inserting Whitespaces at the end of a preformatted text takes the cursor out of the pre tags. - https://phabricator.wikimedia.org/T70455#1591259 (10Jdforrester-WMF)