[00:09:14] 10VisualEditor, 10Wikimedia-Site-Requests, 5WMF-deploy-2015-09-01_(1.26wmf21): Enable the visual editor in the Wikipedia namespace on the English Wikipedia - https://phabricator.wikimedia.org/T100067#1604998 (10Jdforrester-WMF) 5Resolved>3Open Now undone. [00:09:29] 10VisualEditor, 10Wikimedia-Site-Requests, 7Community-consensus-needed: Enable the visual editor in the Wikipedia namespace on the English Wikipedia - https://phabricator.wikimedia.org/T100067#1605001 (10Jdforrester-WMF) 5Open>3stalled [00:13:34] 10Cite: Integration tests in combination with Cite returns a Notice: Undefined property: Parser::$extCite - https://phabricator.wikimedia.org/T111475#1605008 (10mwjames) 3NEW [00:19:09] James_F: https://phabricator.wikimedia.org/P1980 [00:42:21] 10WikiEditor, 6Editing-Analysis: Switch the wikitext editor to use version 13457736 of the Edit schema - https://phabricator.wikimedia.org/T111421#1605087 (10Krenair) [00:44:02] James_F: Empty up_value rows (sorted in the wrong order, sorry) [00:45:34] 10VisualEditor, 10VisualEditor-MediaWiki, 6Editing-Analysis, 5Patch-For-Review: Switch the visual editor to use the version 13457736 of the Edit schema - https://phabricator.wikimedia.org/T111420#1605103 (10Krenair) a:3Krenair [00:45:48] 10WikiEditor, 6Editing-Analysis: Switch the wikitext editor to use version 13457736 of the Edit schema - https://phabricator.wikimedia.org/T111421#1605104 (10Krenair) a:3Krenair [00:47:12] (03PS1) 10Alex Monk: Bump Schema:Edit to 13457736 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/235950 (https://phabricator.wikimedia.org/T111420) [00:49:20] I remember why the last schema update required so many changes now [00:50:40] (03PS1) 10Alex Monk: Bump Schema:Edit to revision 13457736 [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/235951 (https://phabricator.wikimedia.org/T111421) [00:51:05] (03PS2) 10Alex Monk: Bump Schema:Edit to revision 13457736 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/235950 (https://phabricator.wikimedia.org/T111420) [00:59:16] Turns out we don't actually use the 'bot' value for user.class [01:07:52] resources/mobile.editor.overlay.withtoolbar/EditorOverlayWithToolbar.js: editor: 'SourceEditorWithFormatting', [01:08:04] James_F, neilpquinn: What should we do with that? [01:08:21] Krenair: Yeah, not yet. 'bot' is for later. [01:08:43] Krenair: Let that be. It's not used in WMF production. [01:09:05] Krenair: Unless it's wired into the schema somehow, in which case, eww. [01:09:19] Aha. I can check that now :D [01:09:39] But it'll take 8 minutes [01:11:00] James_F, it is tied into the schema though [01:11:19] Krenair: Hmm. [01:11:20] https://meta.wikimedia.org/wiki/Schema:MobileWebEditing [01:11:29] editor: 'VisualEditor', 'SourceEditor' [01:11:41] Or the undocumented one: 'SourceEditorWithFormatting' [01:11:54] A string, not an enum of course [01:11:55] Krenair: List it as wikitext then? But eww. [01:11:59] * James_F nods. [01:12:02] Helpful. :-) [01:12:15] Yeah, will pull up stats before making a decision [01:29:56] Krinkle: https://jsfiddle.net/Inez/b8huvo38/ [01:30:03] compare on jquery 1.11 and 1.9 :) [01:33:02] InezK: 1.11 is better? [01:33:17] In 1.9 '*' also matched text nodes [01:33:32] so closest('*') returned the text node again instead of traversing up to

[01:33:47] yeah [01:33:57] Either way, passing a TextNode to $() is not supported for anything other than events [01:34:07] do you know what would be the selector to get just ELEMENT and no TEXT? [01:34:08] closest/addClass/attr/ etc. [01:34:18] cause we are on old version of jquery [01:34:25] InezK: Why? [01:34:34] InezK: There were no breaking changes between 1.9 and 1.11 [01:34:46] The only major breaking release was 1.8, which I assume you're already over. [01:36:07] Or rather, 1.8 to 1.9 was the breaking change. But you're already running 1.9 [01:36:38] shit, we are on 1.8 [01:36:40] booo [01:37:01] Then you can use 1.9+ (e.g. 1.11) with the jquery.migrate.js plugin [01:37:07] that's what we did for 6 months as well [01:37:40] Anyway, I understand that's non-trivial, though I feel quite certain it won't break anything. We didn't encounter any issues. [01:37:51] Ok, we finally should switch [01:37:52] in core, extensions, or even in all the user scripts. [01:38:04] However we are upgrading to newest VE - big change by itself [01:38:13] so many changes in ResourceLoader I had to port [01:38:57] Yeah :) [01:39:10] InezK: So, why not do closest('p') [01:39:21] I mean, what is the actual code you're using? [01:39:29] You shouldn't be passing text nodes to jquery() constructor [01:39:39] maybe you mean children() instead of content()? [01:42:03] it's that code: ve.scrollIntoView( $( newSel.focusNode ).closest( '*' ).get( 0 ) ); [01:42:18] I guess I could check what I'm getting from closest and then call parent() if needed [02:55:41] 10VisualEditor, 10VisualEditor-Initialisation, 10VisualEditor-Performance, 7Performance: Pre-fetch VisualEditor modules to improve load speed - https://phabricator.wikimedia.org/T59952#1605320 (10Krinkle) [07:23:53] 10VisualEditor: VE adds tags - https://phabricator.wikimedia.org/T111491#1605516 (10Magioladitis) 3NEW [07:25:12] 10VisualEditor: VE adds nowiki tags around plain urls making them unclickable - https://phabricator.wikimedia.org/T111492#1605523 (10Magioladitis) 3NEW [09:09:24] 10VisualEditor, 10Wikimedia-Site-Requests, 7Community-consensus-needed: Enable the visual editor in the Wikipedia namespace on the English Wikipedia - https://phabricator.wikimedia.org/T100067#1605693 (10SalixAlba) [09:09:24] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Provide a tool to insert a talk signature in namespaces that need it - https://phabricator.wikimedia.org/T53154#1605694 (10SalixAlba) [09:32:35] (03CR) 10TheDJ: [C: 032] Bump Schema:Edit to revision 13457736 [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/235951 (https://phabricator.wikimedia.org/T111421) (owner: 10Alex Monk) [09:33:28] (03Merged) 10jenkins-bot: Bump Schema:Edit to revision 13457736 [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/235951 (https://phabricator.wikimedia.org/T111421) (owner: 10Alex Monk) [09:34:42] 10Cite, 5Patch-For-Review: Convert Cite to use extension registration - https://phabricator.wikimedia.org/T87893#1605840 (10Liuxinyu970226) [10:30:37] 10VisualEditor, 10Continuous-Integration-Infrastructure: language screenshot jobs are failing - https://phabricator.wikimedia.org/T111510#1606097 (10Amire80) 3NEW a:3zeljkofilipin [10:33:36] 10VisualEditor, 10Continuous-Integration-Infrastructure: language screenshot jobs are failing - https://phabricator.wikimedia.org/T111510#1606118 (10hashar) Can you please enhance the task by: * giving the job URL * a copy paste of the console that shows the failure [10:34:37] 10WikiEditor, 6Editing-Analysis, 5Patch-For-Review, 5WMF-deploy-2015-09-08_(1.26wmf22): Switch the wikitext editor to use version 13457736 of the Edit schema - https://phabricator.wikimedia.org/T111421#1606119 (10TheDJ) 5Open>3Resolved [10:38:12] 10VisualEditor, 10Continuous-Integration-Infrastructure: language screenshot jobs are failing - https://phabricator.wikimedia.org/T111510#1606128 (10Amire80) This should be useful: https://integration.wikimedia.org/ci/view/BrowserTests/view/VisualEditor/job/browsertests-VisualEditor-language-screenshot-os_x_10... [10:39:56] 10VisualEditor, 10Browser-Tests, 10Continuous-Integration-Infrastructure: browsertests-VisualEditor-language-screenshot-os_x_10.10-firefox jenkins job failing - https://phabricator.wikimedia.org/T111510#1606129 (10zeljkofilipin) [10:45:18] 10VisualEditor, 10Browser-Tests, 10Continuous-Integration-Infrastructure: browsertests-VisualEditor-language-screenshot-os_x_10.10-firefox jenkins job failing - https://phabricator.wikimedia.org/T111510#1606148 (10hashar) Yup seems the credentials are wrong :-( Apparently the username is LanguageScreenshotB... [10:52:23] 10VisualEditor, 10Wikimedia-Site-Requests, 7Community-consensus-needed: Enable the visual editor in the Wikipedia namespace on the English Wikipedia - https://phabricator.wikimedia.org/T100067#1606157 (10Elitre) Thanks James. Here's a link to the [[ https://en.wikipedia.org/wiki/Wikipedia:VisualEditor/Feedba... [10:59:16] 10Citoid, 10VisualEditor, 6Community-Liaison: Recurring checks for Citoid's status - https://phabricator.wikimedia.org/T110597#1606163 (10Elitre) Citoid's still where it's supposed to be. [13:18:43] 10VisualEditor, 10Browser-Tests, 10Continuous-Integration-Infrastructure: browsertests-VisualEditor-language-screenshot-os_x_10.10-firefox jenkins job failing - https://phabricator.wikimedia.org/T111510#1606319 (10zeljkofilipin) @hashar: I think `LanguageScreenshotBot` is used only for uploading files to Com... [13:21:11] 10VisualEditor, 10Browser-Tests, 10Continuous-Integration-Infrastructure: browsertests-VisualEditor-language-screenshot-os_x_10.10-firefox jenkins job failing - https://phabricator.wikimedia.org/T111510#1606330 (10zeljkofilipin) Hm, but looks like the password is really wrong: https://integration.wikimedia.... [13:23:52] 10VisualEditor, 10Browser-Tests, 10Continuous-Integration-Infrastructure: browsertests-VisualEditor-language-screenshot-os_x_10.10-firefox jenkins job failing - https://phabricator.wikimedia.org/T111510#1606332 (10zeljkofilipin) Oh, looks like (at least the browser) uses `Selenium user` as username, but `Lan... [13:45:21] 10Citoid, 10VisualEditor, 6Community-Liaison: Recurring checks for Citoid's status - https://phabricator.wikimedia.org/T110597#1606394 (10Josve05a) https://nl.wikipedia.org/wiki/Special:Random?veaction=edit yet again linked to https://nl.wikipedia.org/w/index.php?title=Mesitius_szaboi&veaction=edit&redirect=... [13:55:06] (03PS1) 10Divec: Back out "Re-use example surface across surface view tests" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/236023 [13:55:53] (03PS5) 10Divec: Don't call setInsertionAnnotations on handleInsertion [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/235054 (https://phabricator.wikimedia.org/T111047) [13:56:26] (03PS32) 10Divec: Explicitly enter and exit link annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/217257 (https://phabricator.wikimedia.org/T91285) [13:56:40] (03PS24) 10Divec: ve.ce.adjustLinkSelection: fixup link-bisecting selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/222488 [13:56:54] (03PS21) 10Divec: Fixup link selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/222619 [13:58:19] (03CR) 10Divec: "For an example of such test a failure, see https://integration.wikimedia.org/ci/job/npm/23079/console" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/236023 (owner: 10Divec) [13:59:07] (03CR) 10jenkins-bot: [V: 04-1] Back out "Re-use example surface across surface view tests" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/236023 (owner: 10Divec) [14:03:13] 10VisualEditor, 10Browser-Tests, 10Continuous-Integration-Infrastructure, 5Patch-For-Review: browsertests-VisualEditor-language-screenshot-os_x_10.10-firefox jenkins job failing - https://phabricator.wikimedia.org/T111510#1606420 (10zeljkofilipin) Looks like a recent change to [[ https://phabricator.wikime... [14:06:47] (03PS2) 10Divec: Back out "Re-use example surface across surface view tests" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/236023 [14:07:10] 10VisualEditor, 10Browser-Tests: No such file or directory - i18n/af.json (Errno::ENOENT) - https://phabricator.wikimedia.org/T111525#1606436 (10zeljkofilipin) 3NEW [14:08:30] 10VisualEditor, 10Browser-Tests, 10Continuous-Integration-Infrastructure, 5Patch-For-Review: browsertests-VisualEditor-language-screenshot-os_x_10.10-firefox jenkins job failing - https://phabricator.wikimedia.org/T111510#1606097 (10zeljkofilipin) I have created subtask {T111525} [14:09:03] 10VisualEditor, 10Browser-Tests: No such file or directory - i18n/af.json (Errno::ENOENT) - https://phabricator.wikimedia.org/T111525#1606450 (10Amire80) a:3Amire80 Oh drat, we didn't implement fallback in Ruby. [14:12:24] (03PS6) 10Divec: Don't call setInsertionAnnotations on handleInsertion [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/235054 (https://phabricator.wikimedia.org/T111047) [14:12:45] (03PS33) 10Divec: Explicitly enter and exit link annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/217257 (https://phabricator.wikimedia.org/T91285) [14:13:40] (03PS25) 10Divec: ve.ce.adjustLinkSelection: fixup link-bisecting selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/222488 [14:14:01] (03PS22) 10Divec: Fixup link selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/222619 [15:03:36] (03CR) 10Esanders: [C: 032] ":(" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/236023 (owner: 10Divec) [15:06:54] (03Merged) 10jenkins-bot: Back out "Re-use example surface across surface view tests" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/236023 (owner: 10Divec) [15:29:24] (03PS1) 10Esanders: Provide alternative access to citoid-template-type-map.json [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/236028 (https://phabricator.wikimedia.org/T93800) [15:29:44] (03CR) 10jenkins-bot: [V: 04-1] Provide alternative access to citoid-template-type-map.json [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/236028 (https://phabricator.wikimedia.org/T93800) (owner: 10Esanders) [15:35:18] 10VisualEditor: Invoking VE on nl.wp will sometimes fail - https://phabricator.wikimedia.org/T111533#1606649 (10Elitre) 3NEW [15:45:50] * Elitre waves at Stryn [15:47:37] (03PS2) 10Esanders: Provide alternative access to citoid-template-type-map.json [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/236028 (https://phabricator.wikimedia.org/T93800) [15:55:07] (03PS1) 10Esanders: Use ve.userConfig for storing citoid-mode [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/236034 [16:51:15] 10VisualEditor, 10Browser-Tests, 10Continuous-Integration-Infrastructure, 5Patch-For-Review: browsertests-VisualEditor-language-screenshot-os_x_10.10-firefox jenkins job failing - https://phabricator.wikimedia.org/T111510#1606908 (10JanZerebecki) Isn't the bug that the wrong password is used? As it shouldn... [17:46:15] Elitre: Thanks for the bug filing there :D [17:58:35] (03CR) 10Alex Monk: [C: 04-1] Provide alternative access to citoid-template-type-map.json (032 comments) [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/236028 (https://phabricator.wikimedia.org/T93800) (owner: 10Esanders) [18:11:48] (03PS1) 10Alex Monk: Load new gallery styles module [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/236053 (https://phabricator.wikimedia.org/T98878) [18:12:43] you're welcome! it was bugging me as well. [18:14:29] I actually turned it on in beta this week, though that was the problem, that I didn't have it turned on, but nope. Still problem so :/ [18:14:37] beta-functions* [18:18:22] (03CR) 10Jforrester: [C: 032] Load new gallery styles module [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/236053 (https://phabricator.wikimedia.org/T98878) (owner: 10Alex Monk) [18:18:48] (03CR) 10Alex Monk: [C: 032] Use ve.userConfig for storing citoid-mode [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/236034 (owner: 10Esanders) [18:23:12] (03Merged) 10jenkins-bot: Load new gallery styles module [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/236053 (https://phabricator.wikimedia.org/T98878) (owner: 10Alex Monk) [18:23:13] (03Merged) 10jenkins-bot: Use ve.userConfig for storing citoid-mode [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/236034 (owner: 10Esanders) [18:45:52] 10VisualEditor, 10VisualEditor-MediaWiki, 6Design Research Backlog: It is very difficult to edit pages wrapped with {{Indentar}} and {{Indentar/fim}} - https://phabricator.wikimedia.org/T62541#1609808 (10ggellerman) Removing Design Research project. Please feel free to re-add if work starts on this task. [18:46:03] 10VisualEditor, 10VisualEditor-MediaWiki: It is very difficult to edit pages wrapped with {{Indentar}} and {{Indentar/fim}} - https://phabricator.wikimedia.org/T62541#1609822 (10ggellerman) [18:47:58] 10WikiEditor, 6Editing-Analysis, 5Patch-For-Review, 5WMF-deploy-2015-09-08_(1.26wmf22): Switch the wikitext editor to use version 13457736 of the Edit schema - https://phabricator.wikimedia.org/T111421#1609866 (10Neil_P._Quinn_WMF) @Krenair, sorry, I forgot to say we should also start logging `abort.switch... [18:48:11] 10WikiEditor, 6Editing-Analysis, 5Patch-For-Review, 5WMF-deploy-2015-09-08_(1.26wmf22): Switch the wikitext editor to use version 13457736 of the Edit schema - https://phabricator.wikimedia.org/T111421#1609869 (10Neil_P._Quinn_WMF) [19:21:36] 10WikiEditor, 6Editing-Analysis, 5Patch-For-Review, 5WMF-deploy-2015-09-08_(1.26wmf22): Switch the wikitext editor to use version 13457736 of the Edit schema - https://phabricator.wikimedia.org/T111421#1610359 (10Neil_P._Quinn_WMF) 5Resolved>3Open [19:32:00] I see that in DOM currently toolbar lives inside the target? Does anyone remember if it changed fairly recently? I thought toolbar was outside of the target before. [19:38:45] InezK: yes, it changed a few months (?) ago [19:39:52] // Move all native content inside the target [19:39:52] this.$element.append( this.$element.siblings() ); [19:39:59] That's in DesktopTarget [19:40:03] big changes ;) [19:40:57] neilpquinn, ummm... I just realised we already have action.abort.type = 'nochange' [19:42:07] MatmaRex: by any chance you remember reason for that change? [19:42:52] InezK: IIRC it was bugging someone that the Target (or was it Surface) was adding stuff to DOM outside of its .$element [19:43:38] Krenair: I was just thinking about that. My intention there is for 'nochange' to measure exits excluding switches, and 'switchnochange' to measure switches. [19:43:41] right [19:43:43] Does that makes sense to you? [19:43:46] Yep [19:45:00] (03CR) 10Cscott: "And Content Translation just updated their VRS code, but they used VE's *current* code, instead of the code-as-patched-here, which means n" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/217995 (https://phabricator.wikimedia.org/T110780) (owner: 10Cscott) [19:45:42] 10WikiEditor, 6Editing-Analysis, 5Patch-For-Review, 5WMF-deploy-2015-09-08_(1.26wmf22): Switch the wikitext editor to use version 13457736 of the Edit schema - https://phabricator.wikimedia.org/T111421#1610448 (10Neil_P._Quinn_WMF) [19:45:55] 10VisualEditor, 10VisualEditor-MediaWiki, 6Editing-Analysis, 5Patch-For-Review: Switch the visual editor to use the version 13457736 of the Edit schema - https://phabricator.wikimedia.org/T111420#1610451 (10Neil_P._Quinn_WMF) [19:48:31] (03PS1) 10Alex Monk: Finish updates for Schema:Edit [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/236105 (https://phabricator.wikimedia.org/T111421) [19:56:58] MatmaRex: thanks [20:09:54] 10VisualEditor, 10ContentTranslation-Deployments, 10ContentTranslation-cxserver, 10Parsoid, and 3 others: Decom parsoid-lb.eqiad.wikimedia.org entrypoint - https://phabricator.wikimedia.org/T110474#1610495 (10cscott) [20:10:17] so it looks like all MF edit inits go via a URL change :\ [20:19:29] Krenair: Fun. [20:21:03] Not sure what to do about action.init.mechanism [20:23:39] guess I'll have to figure out how to catch them each separately [20:23:49] catch each separately* [20:24:36] Krenair: I think it's OK to assume 'click' for mobile. [20:25:02] Krenair: "url" is very hard to do. [20:25:13] Krenair: And ISTR that red links aren't shown on mobile? Or has that changed? [20:25:27] I'm not sure [20:26:13] will check [20:27:44] James_F, ah, yes, there are red links [20:28:23] and they set &redlink=1 [20:28:29] so that's fine [20:30:15] Krenair: Ah, useful. [20:30:18] Hey mvolz. [20:42:14] James_F, oh, there's another problem with init [20:42:25] We need to set the editor field [20:42:37] But if VE fails to load, it'll load the source editor [20:43:05] So you'd have a session initialising VE, and then being ready with the source editor [20:45:47] Krenair: Isn't that a new init at that point? [20:45:57] Krenair: And probably a abort-fail or whatever it's called for VE? [20:55:47] action.init.type seems easy though - all source editing is sections, VE is page [20:56:31] Or is that not the definition... [20:57:45] James_F, the edit button at the top of the page is for the lead section, but obviously VE will open the full page... page or section? [20:58:05] Krenair: section I guess. [20:58:23] Krenair: But… eh. It doesn't matter until/unless we implement actual section editing. [20:58:29] yeah [20:58:30] At which point we'd revisit this stuff. [21:01:44] So VE loading fails... action.abort.type = preinit? [21:01:57] no [21:02:36] preinit: Editor has be initialised but is not yet ready [21:02:46] yeah I guess that does sort of work then [21:03:28] not sure what to record for action.abort.mechanism in that situation though [21:09:42] (03PS1) 10Jforrester: Bump Schema:Edit to revision 13457736 [extensions/WikiEditor] (wmf/1.26wmf21) - 10https://gerrit.wikimedia.org/r/236197 (https://phabricator.wikimedia.org/T111421) [21:11:04] (03CR) 10Jforrester: [C: 032] Bump Schema:Edit to revision 13457736 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/235950 (https://phabricator.wikimedia.org/T111420) (owner: 10Alex Monk) [21:11:13] (03PS1) 10Jforrester: Bump Schema:Edit to revision 13457736 [extensions/VisualEditor] (wmf/1.26wmf21) - 10https://gerrit.wikimedia.org/r/236198 (https://phabricator.wikimedia.org/T111420) [21:14:03] (03Merged) 10jenkins-bot: Bump Schema:Edit to revision 13457736 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/235950 (https://phabricator.wikimedia.org/T111420) (owner: 10Alex Monk) [21:23:09] (03PS3) 10Esanders: Provide alternative access to citoid-template-type-map.json [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/236028 (https://phabricator.wikimedia.org/T93800) [21:23:12] (03CR) 10Esanders: Provide alternative access to citoid-template-type-map.json (032 comments) [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/236028 (https://phabricator.wikimedia.org/T93800) (owner: 10Esanders) [21:36:32] (03CR) 10TheDJ: [C: 032] Finish updates for Schema:Edit [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/236105 (https://phabricator.wikimedia.org/T111421) (owner: 10Alex Monk) [21:37:36] (03Merged) 10jenkins-bot: Finish updates for Schema:Edit [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/236105 (https://phabricator.wikimedia.org/T111421) (owner: 10Alex Monk) [21:42:53] (03CR) 10Alex Monk: [C: 032] Provide alternative access to citoid-template-type-map.json [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/236028 (https://phabricator.wikimedia.org/T93800) (owner: 10Esanders) [21:43:11] (03Merged) 10jenkins-bot: Provide alternative access to citoid-template-type-map.json [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/236028 (https://phabricator.wikimedia.org/T93800) (owner: 10Esanders) [21:44:49] 10WikiEditor, 6Editing-Analysis, 5Patch-For-Review, 5WMF-deploy-2015-09-08_(1.26wmf22): Switch the wikitext editor to use version 13457736 of the Edit schema - https://phabricator.wikimedia.org/T111421#1610776 (10Krenair) 5Open>3Resolved [22:29:44] (03PS1) 10Jforrester: Provide alternative access to citoid-template-type-map.json [extensions/Citoid] (wmf/1.26wmf21) - 10https://gerrit.wikimedia.org/r/236218 (https://phabricator.wikimedia.org/T93800) [22:39:51] (03PS1) 10Alex Monk: Actually use new backup message [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/236221 (https://phabricator.wikimedia.org/T93800) [22:41:07] (03CR) 10Jforrester: [C: 032] "Not sure this is needed, but belt-and-braces…" [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/236221 (https://phabricator.wikimedia.org/T93800) (owner: 10Alex Monk) [22:41:29] (03Merged) 10jenkins-bot: Actually use new backup message [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/236221 (https://phabricator.wikimedia.org/T93800) (owner: 10Alex Monk) [22:42:43] (03CR) 10Alex Monk: [C: 032] "will be cherry-picking follow-up as well" [extensions/Citoid] (wmf/1.26wmf21) - 10https://gerrit.wikimedia.org/r/236218 (https://phabricator.wikimedia.org/T93800) (owner: 10Jforrester) [22:43:08] (03Merged) 10jenkins-bot: Provide alternative access to citoid-template-type-map.json [extensions/Citoid] (wmf/1.26wmf21) - 10https://gerrit.wikimedia.org/r/236218 (https://phabricator.wikimedia.org/T93800) (owner: 10Jforrester) [22:43:28] (03PS1) 10Jforrester: Actually use new backup message [extensions/Citoid] (wmf/1.26wmf21) - 10https://gerrit.wikimedia.org/r/236222 (https://phabricator.wikimedia.org/T93800) [22:45:47] (03CR) 10Alex Monk: [C: 032] Actually use new backup message [extensions/Citoid] (wmf/1.26wmf21) - 10https://gerrit.wikimedia.org/r/236222 (https://phabricator.wikimedia.org/T93800) (owner: 10Jforrester) [22:46:09] (03Merged) 10jenkins-bot: Actually use new backup message [extensions/Citoid] (wmf/1.26wmf21) - 10https://gerrit.wikimedia.org/r/236222 (https://phabricator.wikimedia.org/T93800) (owner: 10Jforrester) [22:53:29] 10Citoid, 10VisualEditor, 6Community-Liaison: Recurring checks for Citoid's status - https://phabricator.wikimedia.org/T110597#1610981 (10Jdforrester-WMF) We just pushed out a patch which will hopefully cover over this issue whilst we find out the cause, so theoretically these checks won't be needed in futur... [22:54:53] 10Citoid, 10VisualEditor, 10MediaWiki-ResourceLoader, 5Patch-For-Review, and 2 others: Value for citoid-template-type-map.json randomly missing in some languages - https://phabricator.wikimedia.org/T93800#1610989 (10Jdforrester-WMF) p:5Unbreak!>3High We just pushed out a patch which will hopefully cove... [23:13:42] (03PS2) 10Jforrester: mw.trackSubscriber: Log platform as phone vs. desktop [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/235661 [23:28:49] 10VisualEditor, 10VisualEditor-MediaWiki, 6Editing-Analysis, 5Patch-For-Review, 5WMF-deploy-2015-09-08_(1.26wmf22): Switch the visual editor to use the version 13457736 of the Edit schema - https://phabricator.wikimedia.org/T111420#1611034 (10Jdforrester-WMF) 5Open>3Resolved [23:46:41] James_F, neilpquinn: I don't think error → saveFailure is right [23:46:46] seems to cover load errors [23:47:42] Krenair: You mean 'error' is currently used only for load errors? OK. [23:48:01] no [23:48:04] it includes load errors [23:48:12] and save errors [23:48:19] Eww. [23:50:29] just ignoring the load errors and stopping the logging of them [23:51:11] Kk. [23:52:47] 10VisualEditor, 6Editing-Analysis, 5WMF-deploy-2015-09-08_(1.26wmf22): Update utilities which consume the Edit schema to use version 13457736 - https://phabricator.wikimedia.org/T111557#1611053 (10Jdforrester-WMF)