[00:01:26] 10VisualEditor, 10VisualEditor-MediaWiki, 6Editing-Analysis, 10MobileFrontend: Instrument MobileFrontend to use version 13457736 of the Edit schema instead of the MobileWebEditing schema - https://phabricator.wikimedia.org/T110272#1611064 (10Krenair) `error` → `saveFailure` is not 100% right. It includes l... [00:06:58] James_F, for the purposes of the action.abort type and mechanism fields, what is the MF back button exactly? [00:07:17] navigate-back? Not just for the browser's own back button? [00:08:02] Err. [00:08:04] Cancel? [00:08:39] maybe? [00:09:46] and then type... nochange, abandon and abandonMidsave depending on the circumstance I guess [00:14:23] Yeah. [00:19:36] James_F, not abandonMidsave because trying to press back while MF is saving does not discard changes [00:19:45] Krenair: … [00:19:52] Krenair: Is it forked as a promise? [00:20:50] well it saves via the API [00:21:05] Interesting. [00:21:08] onSaveBegin is called before and onSaveComplete is called when the promise resolves [00:21:42] * James_F nods. [00:22:00] It doesn't store the promise anywhere so you can't just abort it [00:22:05] * James_F grins. [00:22:09] Of course not. [00:22:09] to make it discard changes [00:22:51] Phone browsers crash a lot. Making it a promise makes sense. [00:24:22] heh, that reminds me, one of the links you shared recently made the FB app continually crash [00:27:20] Oh, whoops. [00:27:23] Which one? [00:27:27] (Also, which FB app?) [00:37:28] -> pm [00:37:46] James_F, we said an 'abort' event for when VE fails to load in MF, right? [00:37:49] Not sure if VE does that [00:37:59] can't find an appropriate value of action.abort.mechanism for it [00:38:02] Is that ve-load? [00:38:33] It doesn't have a mechanism. [00:38:42] so... null? [00:38:52] Abort is about a user-driven stop. [00:39:05] VE fails to load for technical reasons isn't an abort. [00:39:33] I think we should just generate a new token and init the wikitext editor instead [00:39:36] It'd be an initFailure, but we don't have that in the schema because we assumed it was very rare. [00:39:42] Yeah, that makes sense. [00:39:46] Or use the same token? [00:40:00] That way if we get init {ID} ve and then init {ID} wt we know what happened? [00:40:35] okay [00:40:39] and we don't care about action.init.mechanism = 'url', right? [00:52:12] James_F, ^ [00:52:47] Yes. [00:54:21] So the only thing I'm left wondering is whether the MF sessionId works the way we expect [00:58:52] nope. [01:15:58] Krenair: Surprise. ;-) [01:36:49] [Edit] Missing or empty schema :/ [01:47:13] Krenair: Local testing is fun. [01:59:51] It just doesn't load the Edit schema for some reason [02:06:31] But others work? [02:07:30] yeah [02:08:32] Umm. [02:08:35] Interesting. [02:08:43] Typo in version ID? [02:12:36] I think it's a bug in MF's code to add dependencies [02:13:24] James_F, https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/includes/MobileFrontend.hooks.php#L987 [02:13:28] See that array addition? [02:13:49] Krenair: Should that be array_merge? [02:14:07] Yep. [02:14:25] It drops the first two values from $schemaModules [02:14:34] Helpful. [02:15:21] I should probably make a separate commit to fix this :| [02:16:25] Yeah. [02:17:13] (Earlier in the stack.) [02:26:47] I think this was broken recently too [02:27:41] https://gerrit.wikimedia.org/r/#/c/232304/15/includes/MobileFrontend.hooks.php [02:33:57] Just this week. [02:34:21] Does this mean they've lost data since the train went out? [02:35:21] I think so, yeah [02:37:49] Helpful. [02:39:17] * James_F files them a bug. [03:09:44] 10VisualEditor, 10VisualEditor-MediaWiki, 6Editing-Analysis, 10MobileFrontend, 5Patch-For-Review: Instrument MobileFrontend to use version 13457736 of the Edit schema instead of the MobileWebEditing schema - https://phabricator.wikimedia.org/T110272#1611339 (10Krenair) (Does not include timing fields) [03:13:03] Krenair: Thanks! :-) I'm heading off. [07:43:11] 10VisualEditor, 10Browser-Tests, 10Continuous-Integration-Infrastructure, 5Patch-For-Review: browsertests-VisualEditor-language-screenshot-os_x_10.10-firefox jenkins job failing - https://phabricator.wikimedia.org/T111510#1611401 (10zeljkofilipin) No, the problem is that `Selenium user` is used as username... [09:14:21] 10VisualEditor: autocomplete of templates selects unexpected template - https://phabricator.wikimedia.org/T111598#1611426 (10LuisVilla) 3NEW [10:33:48] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Transclusion dialogs panes should include a link to the template's definition page (for further documentation), even if there is TemplateData to document it - https://phabricator.wikimedia.org/T51772#1611469 (10Sunpriat) Exists templates with variable... [12:38:22] 10VisualEditor: Invoking VE on nl.wp will sometimes fail - https://phabricator.wikimedia.org/T111533#1611528 (10Esanders) There is an exception thrown in 'ext.gadget.ProtectionTemplates' where mw.util.$content is null and we try to check its length. [12:40:01] 10VisualEditor: Invoking VE on nl.wp will sometimes fail - https://phabricator.wikimedia.org/T111533#1611529 (10Esanders) https://nl.wikipedia.org/wiki/MediaWiki:Gadget-ProtectionTemplates.js "author @Krinkle" [12:41:26] 10VisualEditor: Invoking VE on nl.wp will sometimes fail - https://phabricator.wikimedia.org/T111533#1611531 (10Esanders) Confirm intermittent reproduction, some sort of race condition? [12:41:36] 10VisualEditor: Invoking VE on nl.wp will sometimes fail - https://phabricator.wikimedia.org/T111533#1611532 (10Esanders) p:5Triage>3Unbreak! [12:41:59] 10VisualEditor: Invoking VE on nl.wp will sometimes fail - https://phabricator.wikimedia.org/T111533#1611535 (10Esanders) a:3Krinkle [12:43:34] 10VisualEditor, 10Parsoid: VE adds tags - https://phabricator.wikimedia.org/T111491#1611536 (10Esanders) [12:43:45] 10VisualEditor, 10Parsoid: VE adds tags - https://phabricator.wikimedia.org/T111491#1605516 (10Esanders) Very odd, Parsoid team? [12:46:23] 10VisualEditor, 10VisualEditor-ContentEditable: Highlights too tall for focusable nodes that contain scrollable areas - https://phabricator.wikimedia.org/T100826#1611542 (10Esanders) Ugh. I guess we should not descend into nodes with overflow hidden or scroll which means doing computed CSS... [12:48:25] 10VisualEditor, 10VisualEditor-ContentEditable: Highlights too tall for focusable nodes that contain scrollable areas - https://phabricator.wikimedia.org/T100826#1611543 (10Esanders) HTML to reproduce but in standalone: ```
(03PS1) 10Esanders: Abstract mwExtension behaviour into MWExtensionWindow [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/236265 [14:29:57] (03CR) 10jenkins-bot: [V: 04-1] Abstract mwExtension behaviour into MWExtensionWindow [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/236265 (owner: 10Esanders) [14:46:44] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References: When inserting a new automatic citation, offer "Edit" as well as "Insert" button - https://phabricator.wikimedia.org/T107078#1611614 (10Mvolz) @Jdforrester-WMF, since this was closed I've seen at least two more complaints about this on community... [14:51:17] (03PS2) 10Esanders: Abstract mwExtension behaviour into MWExtensionWindow [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/236265 [14:53:32] (03CR) 10jenkins-bot: [V: 04-1] Abstract mwExtension behaviour into MWExtensionWindow [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/236265 (owner: 10Esanders) [15:00:49] (03PS3) 10Esanders: Abstract mwExtension behaviour into MWExtensionWindow [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/236265 [15:28:26] 10TemplateData, 10VisualEditor: Don't propose parameters which are just used as aliases instead - https://phabricator.wikimedia.org/T111320#1611642 (10Sunpriat) [15:40:17] 10TemplateData, 10VisualEditor: Don't propose parameters which are just used as aliases instead - https://phabricator.wikimedia.org/T111320#1611643 (10Sunpriat) [16:40:36] 10VisualEditor, 10Parsoid, 10RESTBase: VE adds tags - https://phabricator.wikimedia.org/T111491#1611683 (10GWicke) To me it also looks as if selective serialization had been completely disabled, which might mean that a) no original HTML (and data-parsoid) was provided to Parsoid, b) the original HTML an... [17:12:25] 10VisualEditor, 10Parsoid, 10RESTBase: VE adds tags - https://phabricator.wikimedia.org/T111491#1611699 (10ssastry) >>! In T111491#1611683, @GWicke wrote: > To me it also looks as if selective serialization had been completely disabled, which might mean that > > a) no original HTML (and data-parsoid) wa... [17:13:17] 10VisualEditor, 10Parsoid, 10RESTBase: VE adds tags - https://phabricator.wikimedia.org/T111491#1611700 (10GWicke) @ssastry: I realized the same & reworked my post to reflect that. [17:18:34] (03PS4) 10Esanders: Abstract mwExtension behaviour into MWExtensionWindow [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/236265 [18:50:10] 10VisualEditor, 10Parsoid: In scrubWikitext mode, Parsoid should drop tags with no attributes - https://phabricator.wikimedia.org/T111151#1611741 (10ssastry) p:5Triage>3High a:3Arlolra [18:50:57] 10VisualEditor, 10Parsoid: In scrubWikitext mode, Parsoid should drop tags with no attributes - https://phabricator.wikimedia.org/T111151#1595922 (10ssastry) p:5High>3Triage [18:52:03] 10VisualEditor, 10VisualEditor-MediaWiki, 10Parsoid: Template change preview wrongly uses instead of {{!}} to escape pipe - https://phabricator.wikimedia.org/T105198#1611747 (10ssastry) p:5Triage>3Normal [18:52:30] 10VisualEditor, 10Parsoid: In scrubWikitext mode, Parsoid should drop tags with no attributes - https://phabricator.wikimedia.org/T111151#1611749 (10ssastry) p:5Triage>3High [20:21:55] (03PS1) 10Esanders: De-duplicate methods in NodeDialog and NodeInspector using mixin [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/236346 [20:24:37] (03CR) 10jenkins-bot: [V: 04-1] De-duplicate methods in NodeDialog and NodeInspector using mixin [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/236346 (owner: 10Esanders) [20:34:23] edsanders|away: What's NodeWindow meant to be inheriting from? [20:35:46] (03PS2) 10Jforrester: De-duplicate methods in NodeDialog and NodeInspector using mixin [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/236346 (owner: 10Esanders) [20:36:13] (03CR) 10Jforrester: [C: 04-1] De-duplicate methods in NodeDialog and NodeInspector using mixin (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/236346 (owner: 10Esanders) [20:38:47] (03CR) 10jenkins-bot: [V: 04-1] De-duplicate methods in NodeDialog and NodeInspector using mixin [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/236346 (owner: 10Esanders) [20:50:46] (03CR) 10Jforrester: [C: 032] "Neat." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/236262 (https://phabricator.wikimedia.org/T100826) (owner: 10Esanders) [20:52:59] 10VisualEditor, 10VisualEditor-ContentEditable, 5WMF-deploy-2015-09-08_(1.26wmf22): Highlights too tall for focusable nodes that contain scrollable areas - https://phabricator.wikimedia.org/T100826#1611820 (10Jdforrester-WMF) 5Open>3Resolved a:3Esanders [20:53:49] (03Merged) 10jenkins-bot: Don't descend into overflow clipped nodes for highlights [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/236262 (https://phabricator.wikimedia.org/T100826) (owner: 10Esanders) [21:00:36] 10VisualEditor, 10VisualEditor-ContentEditable, 5Patch-For-Review: Don't call setInsertionAnnotations on handleInsertion - https://phabricator.wikimedia.org/T111047#1611834 (10Jdforrester-WMF) [21:03:14] (03CR) 10Jforrester: [C: 032] "I think the changed behaviour as discussed on T111047 is reasonable." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/235054 (https://phabricator.wikimedia.org/T111047) (owner: 10Divec) [21:03:41] 10VisualEditor, 10VisualEditor-ContentEditable, 5WMF-deploy-2015-09-08_(1.26wmf22): Don't call setInsertionAnnotations on handleInsertion - https://phabricator.wikimedia.org/T111047#1611845 (10Jdforrester-WMF) 5Open>3Resolved [21:06:29] (03Merged) 10jenkins-bot: Don't call setInsertionAnnotations on handleInsertion [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/235054 (https://phabricator.wikimedia.org/T111047) (owner: 10Divec) [21:07:32] (03CR) 10Jforrester: [C: 04-1] "The link tool should be active at the same times as the cursor triggering the explicit entry behaviour – right now it matches the HEAD^ be" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/217257 (https://phabricator.wikimedia.org/T91285) (owner: 10Divec) [21:10:30] James_F, nothing, it's a mixin [21:12:00] edsanders: Then in can't @inheritdoc. :_) [21:12:20] edsanders: Want me to re-write as @see ? [21:12:27] hey James_F [21:12:31] Heya Krenair. [21:12:45] did you send a note to reading people about the MF schema bug? [21:13:09] (03PS3) 10Esanders: De-duplicate methods in NodeDialog and NodeInspector using mixin [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/236346 [21:13:10] Krenair: I didn't because after looking at the dashboards they seemed to be OK [21:13:25] fixed [21:13:26] hm [21:13:29] * Krenair will check the data [21:14:05] edsanders: And unfixed my other fixes. :-) [21:14:09] * James_F refixes. [21:15:10] (03CR) 10jenkins-bot: [V: 04-1] De-duplicate methods in NodeDialog and NodeInspector using mixin [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/236346 (owner: 10Esanders) [21:17:11] (03PS4) 10Jforrester: De-duplicate methods in NodeDialog and NodeInspector using mixin [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/236346 (owner: 10Esanders) [21:17:32] (03CR) 10Jforrester: De-duplicate methods in NodeDialog and NodeInspector using mixin (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/236346 (owner: 10Esanders) [21:17:45] (03CR) 10Jforrester: De-duplicate methods in NodeDialog and NodeInspector using mixin (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/236346 (owner: 10Esanders) [21:17:53] (03CR) 10Jforrester: [C: 032] De-duplicate methods in NodeDialog and NodeInspector using mixin [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/236346 (owner: 10Esanders) [21:17:54] James_F, https://phabricator.wikimedia.org/P1987 [21:20:23] Hmm. [21:20:49] (03Merged) 10jenkins-bot: De-duplicate methods in NodeDialog and NodeInspector using mixin [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/236346 (owner: 10Esanders) [21:21:35] That commit would've gone to wikipedias on the 3rd [21:22:00] 19:31 logmsgbot: twentyafterfour@tin rebuilt wikiversions.cdb and synchronized wikiversions files: wikipedia wikis to 1.26wmf21 [21:22:12] Krenair: Aha, yeah, it's only the bottom graph in http://mobile-reportcard.wmflabs.org/ that uses this data? [21:24:02] (03CR) 10Jforrester: [C: 032] Abstract mwExtension behaviour into MWExtensionWindow [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/236265 (owner: 10Esanders) [21:26:32] (03Merged) 10jenkins-bot: Abstract mwExtension behaviour into MWExtensionWindow [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/236265 (owner: 10Esanders) [21:29:04] (03PS3) 10Jforrester: mw.trackSubscriber: Log platform as phone vs. desktop [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/235661 [21:29:50] (03CR) 10Alex Monk: [C: 032] mw.trackSubscriber: Log platform as phone vs. desktop [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/235661 (owner: 10Jforrester) [21:29:57] Ta. [21:30:09] James_F, I don't know how any of those sites work [21:30:47] Krenair: "Poorly". :_) [21:30:52] heh [21:32:00] (03PS1) 10Jforrester: Update VE core submodule to master (d58d7d4) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/236350 [21:32:24] (03CR) 10jenkins-bot: [V: 04-1] mw.trackSubscriber: Log platform as phone vs. desktop [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/235661 (owner: 10Jforrester) [21:33:41] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (d58d7d4) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/236350 (owner: 10Jforrester) [21:33:48] Meh. [21:34:25] (03PS2) 10Jforrester: Update VE core submodule to master (d58d7d4) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/236350 [21:35:04] Turns out that you need to amend a commit, not just git add. :-) [21:35:55] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (d58d7d4) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/236350 (owner: 10Jforrester) [21:38:18] Krenair: Think we should just +2 the fix in MF? [21:40:22] I'd prefer to have someone involved in the breaking commit read and understand what went wrong [21:40:43] Well, we should also make a cherry-pick and leave that to them to deploy, right? [21:49:51] I added a couple more people to the reviewers list and am poking some on hangouts [21:50:43] * James_F nods. [22:08:50] (03PS1) 10Purodha: Removing a reference to a screen position [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/236355 [22:10:17] (03CR) 10Jforrester: [C: 04-1] "This weakens the instruction without benefit (there is no TTB support in MW yet)." [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/236355 (owner: 10Purodha) [22:30:17] (03CR) 10Purodha: "I do not understand a single word of the comment of Jforrester" [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/236355 (owner: 10Purodha) [22:50:52] 10VisualEditor: Invoking VE on nl.wp will sometimes fail - https://phabricator.wikimedia.org/T111533#1612007 (10Krinkle) >>! In T111533#1611529, @Esanders wrote: > https://nl.wikipedia.org/wiki/MediaWiki:Gadget-ProtectionTemplates.js > > "author @Krinkle" Ah, past me was doing things he shouldn't. This gadget... [22:51:41] 10VisualEditor, 5WMF-deploy-2015-09-08_(1.26wmf22): Invoking VE on nl.wp will sometimes fail - https://phabricator.wikimedia.org/T111533#1612014 (10Jdforrester-WMF) 5Open>3Resolved [22:52:58] (03PS3) 10Jforrester: Update VE core submodule to master (d58d7d4) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/236350 [22:55:26] (03PS4) 10Jforrester: Update VE core submodule to master (d58d7d4) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/236350 [23:02:08] (03CR) 10Alex Monk: [C: 032] Update VE core submodule to master (d58d7d4) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/236350 (owner: 10Jforrester) [23:04:07] (03Merged) 10jenkins-bot: Update VE core submodule to master (d58d7d4) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/236350 (owner: 10Jforrester)