[06:52:16] (03PS34) 10Divec: Explicitly enter and exit link annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/217257 (https://phabricator.wikimedia.org/T91285) [06:53:08] (03PS26) 10Divec: ve.ce.adjustLinkSelection: fixup link-bisecting selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/222488 [06:53:48] (03PS23) 10Divec: Fixup link selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/222619 [06:57:17] (03PS2) 10Divec: WIP POC: Fix wrapping glich with temporary block style [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/233740 [06:59:39] (03CR) 10jenkins-bot: [V: 04-1] WIP POC: Fix wrapping glich with temporary block style [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/233740 (owner: 10Divec) [07:03:44] 10WikiEditor: Wikieditor Publish button ignores edit summary in old field - https://phabricator.wikimedia.org/T111670#1613204 (10Tgr) 3NEW [07:21:41] 10WikiEditor: WikiEditor: Extra buttons are confusing: "Publish" and "Save changes" - https://phabricator.wikimedia.org/T60588#1613227 (10Nemo_bis) [07:22:31] 10VisualEditor, 10VisualEditor-MediaWiki: Help VisualEditor users find the wikitext "Save" button - https://phabricator.wikimedia.org/T90864#1069602 (10Nemo_bis) [07:29:38] (03PS35) 10Divec: Explicitly enter and exit link annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/217257 (https://phabricator.wikimedia.org/T74108) [07:29:59] (03PS27) 10Divec: ve.ce.adjustLinkSelection: fixup link-bisecting selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/222488 [07:30:48] (03PS24) 10Divec: Fixup link selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/222619 [07:37:46] 10VisualEditor: Shift+Del and Shift+Insert are not recognized as shortcuts on VisualEdtor - https://phabricator.wikimedia.org/T111671#1613246 (10Trizek-WMF) 3NEW [07:45:07] 10VisualEditor, 10VisualEditor-ContentEditable, 7Epic, 5Patch-For-Review: [Regression wmf4] Link continuation is broken - https://phabricator.wikimedia.org/T74108#1613257 (10dchan) Commit a32524705038bfc832bcd0e04e2e4e6322b080f5 (heed cursor position relative to annotations) has bearing on this, in that if... [07:45:25] (03PS36) 10Divec: Explicitly enter and exit link annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/217257 (https://phabricator.wikimedia.org/T91285) [07:46:04] (03PS28) 10Divec: ve.ce.adjustLinkSelection: fixup link-bisecting selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/222488 [07:46:22] (03PS25) 10Divec: Fixup link selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/222619 [07:46:47] (03PS3) 10Divec: WIP POC: Fix wrapping glich with temporary block style [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/233740 [07:50:20] (03CR) 10jenkins-bot: [V: 04-1] WIP POC: Fix wrapping glich with temporary block style [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/233740 (owner: 10Divec) [07:59:46] (03PS37) 10Divec: Links: Explicit entry/exit with cartouches [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/217257 (https://phabricator.wikimedia.org/T91285) [08:01:03] (03PS29) 10Divec: ve.ce.adjustLinkSelection: fixup link-bisecting selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/222488 [08:01:56] (03PS26) 10Divec: Fixup link selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/222619 [08:05:17] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-ContentLanguage: Ugly wrapping of link cartouches - https://phabricator.wikimedia.org/T111672#1613267 (10dchan) 3NEW a:3dchan [08:06:24] (03PS4) 10Divec: WIP POC: Fix wrapping glich with temporary block style [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/233740 (https://phabricator.wikimedia.org/T111672) [08:08:24] (03PS5) 10Divec: WIP POC: Fix cartouche wrapping glich with temporary block style [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/233740 (https://phabricator.wikimedia.org/T111672) [08:14:20] (03CR) 10jenkins-bot: [V: 04-1] WIP POC: Fix cartouche wrapping glich with temporary block style [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/233740 (https://phabricator.wikimedia.org/T111672) (owner: 10Divec) [08:37:49] (03PS6) 10Divec: WIP POC: Fix cartouche wrapping glich with temporary block style [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/233740 (https://phabricator.wikimedia.org/T111672) [08:56:27] 10VisualEditor: Break lines are missing while inserting infoboxes or categories with VisualEditor - https://phabricator.wikimedia.org/T111674#1613326 (10Trizek-WMF) 3NEW [09:05:11] 10VisualEditor, 10Browser-Tests, 10Continuous-Integration-Infrastructure, 5Patch-For-Review: browsertests-VisualEditor-language-screenshot-os_x_10.10-firefox jenkins job failing - https://phabricator.wikimedia.org/T111510#1613338 (10hashar) The problem is the job uses the LanguageScreenshotBot user name. T... [10:26:33] 10Citoid, 10VisualEditor, 6Community-Liaison: Recurring checks for Citoid's status - https://phabricator.wikimedia.org/T110597#1613442 (10Elitre) So the change is already live on Wikipedias? If so, I might declare this task tentatively closed. [10:30:45] 10Citoid, 10VisualEditor: STICKY: Report failing DOIs or URLs here. - https://phabricator.wikimedia.org/T106201#1613450 (10Mvolz) [10:30:47] 10Citoid, 10VisualEditor, 6Services: DOI redirect handler for iopscience is very slow/ potentially causes citoid to behave oddly. - https://phabricator.wikimedia.org/T106374#1613448 (10Mvolz) 5Resolved>3Open p:5High>3Normal [10:31:40] 10Citoid, 10VisualEditor, 6Services: DOI redirect handler for iopscience is very slow/ potentially causes citoid to behave oddly. - https://phabricator.wikimedia.org/T106374#1466616 (10Mvolz) Re-opened as we are no longer detecting redirects for this site now as of the last few weeks. [12:07:25] 10VisualEditor, 10Browser-Tests, 10Continuous-Integration-Infrastructure: browsertests-VisualEditor-language-screenshot-os_x_10.10-firefox jenkins job failing - https://phabricator.wikimedia.org/T111510#1613650 (10zeljkofilipin) [12:42:04] 10VisualEditor, 10Browser-Tests, 10Continuous-Integration-Infrastructure, 5Patch-For-Review: browsertests-VisualEditor-language-screenshot-os_x_10.10-firefox jenkins job failing - https://phabricator.wikimedia.org/T111510#1613698 (10zeljkofilipin) 236540 is the simplest fix for the problem, until I have so... [12:44:50] 10VisualEditor, 10VisualEditor-MediaWiki: Help VisualEditor users find the wikitext "Save" button - https://phabricator.wikimedia.org/T90864#1613700 (10Krenair) [15:19:33] 10VisualEditor, 10VisualEditor-MediaWiki, 7JavaScript: Infinite collapsing/uncollapsing of VisualEditor's Edit tab on some screen resolutions - https://phabricator.wikimedia.org/T108588#1614082 (10matmarex) [15:29:27] (03CR) 10Bartosz Dziewoński: "Thanks." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/236053 (https://phabricator.wikimedia.org/T98878) (owner: 10Alex Monk) [15:47:01] 10Cite, 5Patch-For-Review: Show an error if a named is defined multiple times - https://phabricator.wikimedia.org/T85386#1614120 (10Nemo_bis) An error (that all users would see) seems too much, especially as the content can be identical. A tracking category is a good idea. [15:58:22] 10Cite, 5Patch-For-Review: Show an error if a named is defined multiple times - https://phabricator.wikimedia.org/T85386#1614148 (10Jdforrester-WMF) >>! In T85386#1614120, @Nemo_bis wrote: > An error (that all users would see) seems too much, especially as the content can be identical. A tracking categor... [15:59:45] (03CR) 10Jforrester: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/235661 (owner: 10Jforrester) [16:03:39] (03CR) 10Alex Monk: mw.trackSubscriber: Log platform as phone vs. desktop [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/235661 (owner: 10Jforrester) [16:03:45] (03CR) 10Alex Monk: [C: 032] mw.trackSubscriber: Log platform as phone vs. desktop [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/235661 (owner: 10Jforrester) [16:06:09] (03Merged) 10jenkins-bot: mw.trackSubscriber: Log platform as phone vs. desktop [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/235661 (owner: 10Jforrester) [16:06:17] Finally. [16:06:19] Thanks, Krenair. [16:08:47] Krenair: You had time to test https://gerrit.wikimedia.org/r/#/c/236244/ yet? [16:09:30] It did change from "completely untested" to "mostly untested" at some point :) [16:09:43] not fully though, no. was planning to check things through in more detail today [16:16:07] :-) [16:16:10] Cool. [17:23:13] [13grunt-banana-checker] 15Krinkle 04deleted 06release-0.3.0 at 14101eaf9: 02https://github.com/wikimedia/grunt-banana-checker/commit/101eaf9 [17:27:58] [13grunt-banana-checker] 15Krinkle tagged 06v0.3.0 at 14101eaf9: 02https://github.com/wikimedia/grunt-banana-checker/commits/v0.3.0 [17:33:10] [13grunt-banana-checker] 15Krinkle created 06readme (+1 new commit): 02https://github.com/wikimedia/grunt-banana-checker/commit/45c71dec7d9f [17:33:10] 13grunt-banana-checker/06readme 1445c71de 15Timo Tijhof: readme: Add line break between images and h1... [17:33:20] [13grunt-banana-checker] 15Krinkle opened pull request #29: readme: Add line break between images and h1 (06master...06readme) 02https://github.com/wikimedia/grunt-banana-checker/pull/29 [17:35:18] James_F: https://travis-ci.org/wikimedia/grunt-banana-checker/builds/79158484 [17:35:23] This job is running on our legacy infrastructure. Please read our docs on how to upgrade [17:35:31] Wanna give that a shot? [17:35:34] (I've already done it a few times) [17:36:53] Krinkle: Sure. After I actually cut 0.3.0, or now? [17:37:03] Krinkle: (Whichever you think is best.) [17:37:06] It's cut and published [17:37:09] Oh, hah. [17:37:11] OK. :-) [17:37:29] But if you have a tardis standing by, before would be cool, too. [17:37:34] * James_F grins. [17:37:39] https://github.com/wikimedia/grunt-banana-checker/releases/tag/v0.3.0 is confusing. [17:37:48] I didn't tag it at all, let alone 6 days ago. [17:37:52] GitHub, you suck. [17:40:21] Yeah [17:40:29] In fact, I'll tell them, right now [17:40:37] (the former tha tis) [17:42:42] Tell whom what? [17:44:10] James_F: Did you enable the protected branches for banana? [17:45:59] James_F: That GitHub tagging interface is wrong. [17:46:15] Krinkle: I did. [17:46:21] Krinkle: Seemed like a good thing to play with. [17:46:25] Yeah, It's great [17:46:33] not so great is that it isn't logged in the repo audit log [17:47:09] * Krinkle gained two gold stars by submitting two issues to @github under 160 chars [17:47:28] Ha. [17:47:35] It's completely meaning less but funny. [17:47:38] They like them short? [17:47:40] Yeah [17:48:30] 10VisualEditor, 10Math: CSS for - https://phabricator.wikimedia.org/T111712#1614382 (10SalixAlba) 3NEW [17:51:23] edsanders, are you around? I'm trying to do something extremely hacky in VE and need advice. We need the editor widget in Flow to properly give us a value of 'hasBeenModified'. The problem is that the content of the editor changes every time we click "edit" (because we are re-fetching the actual data from the api). So as far as VE is concerned, it *always* changed, because we're setting new data into it. [17:51:51] edsanders, is there a way to tell VE that some specific point is its "initial data" to compare? [17:52:10] I remember we tried to do something like that with breakpoints but I think I am remembering wrong, and I'm not sure how hacky that is. [17:55:51] 10VisualEditor, 6Community-Liaison: VisualEditor translathon at Wikimania Mexico - https://phabricator.wikimedia.org/T91108#1614406 (10Elitre) Now at https://commons.wikimedia.org/wiki/File:VisualEditor_Translathon_2015.pdf . [18:30:12] (03PS1) 10Catrope: sa.DesktopTarget: Clean up handling of actions toolbar [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/236587 [18:31:36] [13grunt-banana-checker] 15jdforrester created 06jdforrester-patch-1 (+1 new commit): 02https://github.com/wikimedia/grunt-banana-checker/commit/8f5774a14cc5 [18:31:36] 13grunt-banana-checker/06jdforrester-patch-1 148f5774a 15James Forrester: Migrating Travis to container-based infrastructure... [18:33:30] (03PS1) 10Catrope: Initialize actions toolbars [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/236589 [18:33:37] (03CR) 10jenkins-bot: [V: 04-1] sa.DesktopTarget: Clean up handling of actions toolbar [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/236587 (owner: 10Catrope) [18:34:00] (03CR) 10Catrope: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/236587 (owner: 10Catrope) [18:45:01] (03PS1) 10Jforrester: build: Upgrade grunt-banana-checker to v0.3.0 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/236594 [18:45:20] 10VisualEditor: VE and wiki-italic syntax for links can create unneeded apostrophes - https://phabricator.wikimedia.org/T111627#1614498 (10Aklapper) [18:53:03] 10VisualEditor, 10VisualEditor-ContentEditable: VE displays multiple placeholders when editor only contains a single template - https://phabricator.wikimedia.org/T111107#1614528 (10Catrope) [19:00:24] (03PS1) 10Jforrester: build: Upgrade grunt-banana-checker to v0.3.0 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/236597 [19:11:24] James_F: Can you rebase your branch to not contain a "master merge" commit underneath from your local merge? [19:11:30] Merge branch 'master' into jdforrester-patch-1 [19:11:40] Krinkle: That was inserted by GitHub… [19:11:48] Krinkle: Maybe? [19:11:56] Did you click "Update branch" ? [19:12:28] Because that's a new GitHub feature (< 10 days) that does that indeed. Very ugly and annoying [19:12:41] A merge commit when merging a commit makes sense (though also unneeded) [19:12:57] but when just updating a PR branch, unless it's a long-lived branch, it doens't really make sense. Just pollutes history more. [19:13:06] Yeah. [19:13:10] Sorry. [19:29:18] (03CR) 10Jforrester: [C: 032] Initialize actions toolbars [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/236589 (owner: 10Catrope) [19:30:51] 10VisualEditor, 10OOjs-UI, 5OOjs-UI-next-release: SelectFileWidget doesn't trim long text, hiding the button - https://phabricator.wikimedia.org/T111631#1614606 (10Jdforrester-WMF) 5Open>3Resolved a:3Esanders [19:30:56] 10VisualEditor, 10OOjs-UI, 5OOjs-UI-next-release: SelectFileWidget doesn't trim long text, hiding the button - https://phabricator.wikimedia.org/T111631#1612368 (10Jdforrester-WMF) [19:35:26] (03Merged) 10jenkins-bot: Initialize actions toolbars [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/236589 (owner: 10Catrope) [19:37:15] 10TemplateData, 10VisualEditor, 10VisualEditor-MediaWiki-Templates: "No unused fields" doesn't make sense when there is no TemplateData present - https://phabricator.wikimedia.org/T111717#1614616 (10Whatamidoing-WMF) 3NEW [20:51:42] Krenair: So… think we should push out the cherry-picks? https://gerrit.wikimedia.org/r/#/q/status:open+branch:wmf/1.26wmf21,n,z [20:52:30] Wasn't there something else needed? [20:52:45] https://gerrit.wikimedia.org/r/#/c/236105/ [20:52:57] and don't we want the MobileFrontend commit at the same time? [20:58:16] Krenair: It's not currently writing to it, so it's not crisis-urgent? [20:58:23] But yeah, we want the other WE one. [20:58:38] (03PS1) 10Jforrester: Finish updates for Schema:Edit [extensions/WikiEditor] (wmf/1.26wmf21) - 10https://gerrit.wikimedia.org/r/236679 (https://phabricator.wikimedia.org/T111421) [21:10:55] (03CR) 10Alex Monk: [C: 032] Bump Schema:Edit to revision 13457736 [extensions/WikiEditor] (wmf/1.26wmf21) - 10https://gerrit.wikimedia.org/r/236197 (https://phabricator.wikimedia.org/T111421) (owner: 10Jforrester) [21:12:23] (03Merged) 10jenkins-bot: Bump Schema:Edit to revision 13457736 [extensions/WikiEditor] (wmf/1.26wmf21) - 10https://gerrit.wikimedia.org/r/236197 (https://phabricator.wikimedia.org/T111421) (owner: 10Jforrester) [21:13:32] (03CR) 10Alex Monk: [C: 032] Bump Schema:Edit to revision 13457736 [extensions/VisualEditor] (wmf/1.26wmf21) - 10https://gerrit.wikimedia.org/r/236198 (https://phabricator.wikimedia.org/T111420) (owner: 10Jforrester) [21:14:01] (03CR) 10Alex Monk: [C: 032] Finish updates for Schema:Edit [extensions/WikiEditor] (wmf/1.26wmf21) - 10https://gerrit.wikimedia.org/r/236679 (https://phabricator.wikimedia.org/T111421) (owner: 10Jforrester) [21:15:41] (03Merged) 10jenkins-bot: Bump Schema:Edit to revision 13457736 [extensions/VisualEditor] (wmf/1.26wmf21) - 10https://gerrit.wikimedia.org/r/236198 (https://phabricator.wikimedia.org/T111420) (owner: 10Jforrester) [21:15:45] (03Merged) 10jenkins-bot: Finish updates for Schema:Edit [extensions/WikiEditor] (wmf/1.26wmf21) - 10https://gerrit.wikimedia.org/r/236679 (https://phabricator.wikimedia.org/T111421) (owner: 10Jforrester) [21:21:41] oh, damn submodule updates [21:46:57] mooeypoo, you can count the history length [21:49:33] I don't know what you mean by "everytime you click edit" [21:49:46] are you getting false positives or false negatives from hasBeenModified? [22:06:06] [13grunt-banana-checker] 15Krinkle pushed 1 new commit to 06master: 02https://github.com/wikimedia/grunt-banana-checker/commit/d2accbb0183537c20ab1cecd8815716070106e68 [22:06:06] 13grunt-banana-checker/06master 14d2accbb 15Timo Tijhof: Merge pull request #30 from wikimedia/jdforrester-patch-1... [22:09:47] 10Citoid, 6Services: Citoid test using Zotero results (DOI in URL with query params) failing locally - https://phabricator.wikimedia.org/T111734#1614977 (10mobrovac) 3NEW a:3mobrovac [22:21:24] 10Citoid, 6Services: Citoid test using Zotero results (DOI in URL with query params) failing locally - https://phabricator.wikimedia.org/T111734#1614998 (10mobrovac) I have run the test suite in an MW-Vagrant LXC instance and the test in question is passing. The logs suggest that my local copy of the translati... [22:48:38] [Edit] Value null is the wrong type for property "action.saveIntent.timing" (integer expected) [22:48:39] :/ [22:59:33] bah, of course [23:00:17] the problem is VE-MW doing part of its logging regardless of target and doing the other part for only the desktop target [23:15:39] Krenair: Oh, whoops. [23:17:12] 10WikiEditor: Wikieditor Publish button ignores edit summary in old field - https://phabricator.wikimedia.org/T111670#1615138 (10Liuxinyu970226)