[00:01:58] Krenair: Into what? The education feature? [00:02:12] the popup for it, yeah [00:02:24] Hmm. [00:02:26] I blame mooey|away. :-) [00:03:02] any particular commit? [00:04:11] "PopupWidget: Make it possible to add static footers"? [00:04:23] Yeah, plausibly. [00:04:39] (Moriel's been adding features to OOUI's popups, hence the blame.) [00:14:30] James_F, yep, it's that commit to blame [00:14:41] addition of $clippableContainer: this.$popup [00:15:45] * James_F nods. [00:16:03] Pass in as the container? [00:17:00] popup.setClippableContainer( null ) :) [00:18:16] 10VisualEditor, 10VisualEditor-MediaWiki: Be able to auto-disable VisualEditor whilst in Beta Feature state for some users before switching to default state - https://phabricator.wikimedia.org/T112352#1633083 (10Jdforrester-WMF) 3NEW a:3Krenair [00:18:25] * James_F grins. [00:19:19] (03PS8) 10Jforrester: Autodisable preference [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230949 (https://phabricator.wikimedia.org/T112352) (owner: 10Alex Monk) [00:19:23] (03CR) 10jenkins-bot: [V: 04-1] Autodisable preference [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230949 (https://phabricator.wikimedia.org/T112352) (owner: 10Alex Monk) [00:26:47] * Krenair grumbles [00:28:32] (03PS9) 10Jforrester: Autodisable preference [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230949 (https://phabricator.wikimedia.org/T112352) (owner: 10Alex Monk) [00:28:33] Krenair: Fixed. [00:28:34] (03PS1) 10Jforrester: Hooks: Respect VisualEditorDisableForAnons for section edit links too [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/237866 [00:28:41] Krenair: And found an issue in the mean time. :-) [00:29:26] thanks [00:29:29] boo [00:29:45] An issue not yet affecting production. [00:29:59] How do I get sitename on the client? [00:30:32] Oh, never mind [00:30:38] wgSiteName [00:30:49] * Krenair grumbles about Skin objects to get Users [00:31:00] Yeah, but actually I can just use {{SITENAME}} in the i18n message. [00:31:22] You can? [00:31:27] I can't? [00:31:37] Eh, I'll pass it. [00:31:41] Bare in mind that I have 0 trust in the client-side mediawiki message functions :) [00:31:45] :-D [00:32:19] (03CR) 10Alex Monk: [C: 04-1] "$config is set further down the function" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/237866 (owner: 10Jforrester) [00:32:32] mw.config.values.wgSiteName feels icky. [00:33:53] mw.config.get( 'wgSiteName' ) [00:34:13] Krenair: Also, by what method are you slapping an image into an OOUI display? I need to do it for this patch too… [00:34:19] Oh, of course. :-) [00:34:39] Actually I just had the popup and text [00:34:51] Oh, you'd not done the image bit yet? [00:34:53] One of several reasons it wasn't ready to upload yet [00:34:56] :-) [00:34:58] OK. [00:35:18] When I do get to that bit though - where is the image coming from? [00:35:31] (03PS4) 10Jforrester: [WIP] Alter welcome text to be welcoming [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/221762 (https://phabricator.wikimedia.org/T99963) [00:35:49] The Phab ticket? [00:35:50] * James_F looks. [00:36:06] 10VisualEditor, 10VisualEditor-MediaWiki, 5Patch-For-Review: Be able to auto-disable VisualEditor whilst in Beta Feature state for some users before switching to default state - https://phabricator.wikimedia.org/T112352#1633109 (10Jdforrester-WMF) [00:37:10] I'll attach them. [00:37:21] https://dl.dropboxusercontent.com/spa/tuyaic6q75gkcv4/Exports/Citation%20interaction/Citation%20interaction.hyperesources/VE_cite.gif ? [00:40:37] I thought we were going for the static ones? [00:40:46] The animation is cool, though. [00:41:06] I don't know? All I've been told about this is the ticket :) [00:41:11] :-) [00:42:02] either way the image can be swapped at a later time [00:53:21] Krenair: https://www.dropbox.com/sh/1fptrxwvgzfld5s/AAB186M3PFknl_GgULPiDWvVa?dl=0 [00:54:03] (03CR) 10Ricordisamoa: "Nobody refers to themselves the way others do." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/237736 (owner: 10Jforrester) [00:58:28] 10WikiEditor, 6Editing-Analysis, 5Patch-For-Review, 5WMF-deploy-2015-09-08_(1.26wmf22): Switch the wikitext editor to use version 13457736 of the Edit schema - https://phabricator.wikimedia.org/T111421#1633118 (10Jdforrester-WMF) [00:58:30] 10VisualEditor, 6Editing-Analysis, 5Patch-For-Review, 5WMF-deploy-2015-09-08_(1.26wmf22): Update utilities which consume the Edit schema to use version 13457736 - https://phabricator.wikimedia.org/T111557#1633116 (10Jdforrester-WMF) 5Open>3Resolved [00:58:31] 10VisualEditor, 10VisualEditor-MediaWiki, 6Editing-Analysis, 5WMF-deploy-2015-09-08_(1.26wmf22): Switch the visual editor to use the version 13457736 of the Edit schema - https://phabricator.wikimedia.org/T111420#1633119 (10Jdforrester-WMF) [01:15:22] 10VisualEditor: Change Welcome dialogue content to more helpful message to new users - https://phabricator.wikimedia.org/T112354#1633141 (10Jdforrester-WMF) 3NEW a:3Jdforrester-WMF [01:15:38] 10VisualEditor, 10VisualEditor-MediaWiki: Change Welcome dialogue content to more helpful message to new users - https://phabricator.wikimedia.org/T112354#1633141 (10Jdforrester-WMF) p:5Normal>3High [01:16:48] (03PS5) 10Jforrester: MWBetaWelcomeDialog: Alter to be welcoming, use a nice image [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/221762 (https://phabricator.wikimedia.org/T99963) [01:17:24] (03CR) 10Jforrester: "This is untested, I assume doesn't work, and is probably the wrong way to go?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/221762 (https://phabricator.wikimedia.org/T99963) (owner: 10Jforrester) [01:17:41] Krenair: "// FIXME how do I do this?", the comment of legends. :-) [01:19:35] James_F, where's that from? your code? [01:19:41] Krenair: Yeah. [01:20:01] "$( '' ).prop( 'src', 'VisualEditor_-_education_illustration_-_welcome.png' ) // FIXME how do I do this?" [01:20:44] (03CR) 10Jforrester: "> i18n messages define how should others call the software." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/237736 (owner: 10Jforrester) [01:23:34] (03PS2) 10Jforrester: Hooks: Respect VisualEditorDisableForAnons for section edit links too [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/237866 [01:23:46] (03PS10) 10Jforrester: Autodisable preference [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230949 (https://phabricator.wikimedia.org/T112352) (owner: 10Alex Monk) [01:23:48] James_F, wasn't there some ResourceLoaderImageModule thing that MatmaRex did/was involved in somehow? [01:24:00] I was planning to investigate that code [01:24:08] Krenair: I'm sure there's a clever way to do it, yeah. [01:24:31] But I thought RLIM was for often-used images that need to be embedded in the page, not on-off static assets? [01:24:32] * James_F shrugs. [01:24:48] * James_F adds him as a reviewer to make him cry. :-) [02:18:26] (03CR) 10Alex Monk: [C: 04-1] MWBetaWelcomeDialog: Alter to be welcoming, use a nice image (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/221762 (https://phabricator.wikimedia.org/T99963) (owner: 10Jforrester) [03:00:13] (03CR) 10Alex Monk: MWBetaWelcomeDialog: Alter to be welcoming, use a nice image (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/221762 (https://phabricator.wikimedia.org/T99963) (owner: 10Jforrester) [03:12:34] https://phabricator.wikimedia.org/P2016 [03:41:18] (03PS6) 10Alex Monk: MWBetaWelcomeDialog: Alter to be welcoming, use a nice image [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/221762 (https://phabricator.wikimedia.org/T99963) (owner: 10Jforrester) [03:41:20] (03CR) 10Alex Monk: MWBetaWelcomeDialog: Alter to be welcoming, use a nice image (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/221762 (https://phabricator.wikimedia.org/T99963) (owner: 10Jforrester) [03:42:58] (03PS7) 10Alex Monk: MWBetaWelcomeDialog: Alter to be welcoming, use a nice image [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/221762 (https://phabricator.wikimedia.org/T99963) (owner: 10Jforrester) [09:41:04] 10Citoid: Extended deepEqual in assert.js doesn't require that strings match; some current tests fail as a result - https://phabricator.wikimedia.org/T112305#1633486 (10Mvolz) 5Open>3Invalid [10:13:10] 10VisualEditor: Ugly edit => edit source replacement on page load - https://phabricator.wikimedia.org/T112366#1633537 (10eranroz) 3NEW [10:39:12] (03PS1) 10Eranroz: Avoid flicks in talk pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/237891 [10:44:36] 10VisualEditor: Ugly edit => edit source replacement on page load - https://phabricator.wikimedia.org/T112366#1633594 (10eranroz) a:3eranroz [10:45:35] 10VisualEditor: Ugly edit => edit source replacement on page load - https://phabricator.wikimedia.org/T112366#1633537 (10eranroz) gerrit bot is too lazy to comment here? https://gerrit.wikimedia.org/r/#/c/237891/ [11:20:01] (03CR) 10Nemo bis: [C: 031] "This is an improvement. Even better would be to clarify what sort of tab this is, so that it can be found by similarity to interface eleme" [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/236355 (owner: 10Purodha) [13:05:29] 10VisualEditor, 5Patch-For-Review: Ugly edit => edit source replacement on page load - https://phabricator.wikimedia.org/T112366#1633671 (10Aklapper) >>! In T112366#1633594, @eranroz wrote: > gerrit bot is too lazy to comment here? @eranroz: No, [[ https://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelin... [13:39:08] (03PS2) 10Eranroz: Avoid flicks in talk pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/237891 (https://phabricator.wikimedia.org/T112366) [15:59:35] 10VisualEditor, 10Parsoid, 10RESTBase: Change VisualEditor's error logging to not assume all VRS errors are Parsoid errors - https://phabricator.wikimedia.org/T112339#1633990 (10ssastry) I left a bunch of comments on the CX extension code .. https://gerrit.wikimedia.org/r/#/c/237421/ Looking at the VE code... [19:39:30] [13grunt-banana-checker] 15Krinkle created 06travis-newnode (+1 new commit): 02https://github.com/wikimedia/grunt-banana-checker/commit/b541ec32a646 [19:39:30] 13grunt-banana-checker/06travis-newnode 14b541ec3 15Timo Tijhof: build: Add Node.js v0.12 and v4.0... [19:39:43] [13grunt-banana-checker] 15Krinkle opened pull request #34: build: Add Node.js v0.12 and v4.0 (06master...06travis-newnode) 02https://github.com/wikimedia/grunt-banana-checker/pull/34 [19:43:13] [13grunt-banana-checker] 15Krinkle merged 06travis-newnode into 06master: 02https://github.com/wikimedia/grunt-banana-checker/compare/d2accbb01835...b541ec32a646 [19:43:58] [13grunt-banana-checker] 15Krinkle created 06grunt-clbye (+1 new commit): 02https://github.com/wikimedia/grunt-banana-checker/commit/ba3db1b9ef26 [19:43:58] 13grunt-banana-checker/06grunt-clbye 14ba3db1b 15Timo Tijhof: build: Remove use of global grunt-cli [19:49:13] [13grunt-banana-checker] 15Krinkle merged 06grunt-clbye into 06master: 02https://github.com/wikimedia/grunt-banana-checker/compare/b541ec32a646...ba3db1b9ef26 [19:49:23] [13grunt-banana-checker] 15Krinkle 04deleted 06grunt-clbye at 14ba3db1b: 02https://github.com/wikimedia/grunt-banana-checker/commit/ba3db1b [21:05:47] 10VisualEditor, 10Parsoid: Copying a rendered table into VE missed a |- and other parsing issues - https://phabricator.wikimedia.org/T112394#1634324 (10ssastry) [21:12:50] 10VisualEditor, 10Parsoid: Copying a rendered table into VE missed a |- and other parsing issues - https://phabricator.wikimedia.org/T112394#1634343 (10ssastry) The line breaks are specific to what VE gets from the copy-paste functionality of the browsers. Parsoid is not involved there. When I opened that san... [23:21:20] 10VisualEditor: Extra bullets in bullet point list - https://phabricator.wikimedia.org/T112418#1634529 (10LuisVilla) 3NEW