[00:06:16] legoktm, thanks for reviewing it [00:06:27] np [00:30:59] (03CR) 10Legoktm: [C: 032] Add a clean-up script for use as a pre-commit hook [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118758 (owner: 10Jforrester) [00:33:33] (03Merged) 10jenkins-bot: Add a clean-up script for use as a pre-commit hook [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118758 (owner: 10Jforrester) [01:52:53] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Support for SFN and similar references - https://phabricator.wikimedia.org/T53522#1636102 (10Tbayer) I guess I agree that it may not be worthwhile to support creating new footnotes with the [[https://en.wikipedia.org/wiki/Template:Sfn| shortened footno... [04:30:27] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-extensions-InputBox, 5Patch-For-Review, 5WMF-deploy-2015-09-15_(1.26wmf23): Option to choose editor (traditional vs VisualEditor) in InputBox extension - https://phabricator.wikimedia.org/T89341#1636169 (10Krenair) 5Open>3Resolved patch was merged [05:14:41] (03PS11) 10Alex Monk: Autodisable preference [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230949 (https://phabricator.wikimedia.org/T112352) [05:15:58] (03CR) 10Alex Monk: [C: 032] Hooks: Respect VisualEditorDisableForAnons for section edit links too [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/237866 (owner: 10Jforrester) [05:17:04] (03CR) 10jenkins-bot: [V: 04-1] Autodisable preference [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230949 (https://phabricator.wikimedia.org/T112352) (owner: 10Alex Monk) [05:18:16] (03Merged) 10jenkins-bot: Hooks: Respect VisualEditorDisableForAnons for section edit links too [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/237866 (owner: 10Jforrester) [05:21:21] (03PS12) 10Alex Monk: Autodisable preference [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230949 (https://phabricator.wikimedia.org/T112352) [06:38:59] 10VisualEditor: Getting occasional "Parsoidserver-http: HTTP 400" error when editing Czech Wikipedia using VE - https://phabricator.wikimedia.org/T112496#1636260 (10Vojtech.dostal) 3NEW [07:17:36] i see a few parsoid/VE 400/500 errors being reported on the feedback page as well ^ [07:18:26] 10VisualEditor: Getting occasional "Parsoidserver-http: HTTP 400" error when editing Czech Wikipedia using VE - https://phabricator.wikimedia.org/T112496#1636335 (10TheDJ) There are several similar problems being reported on https://en.wikipedia.org/wiki/Wikipedia:VisualEditor/Feedback#Strange_repeatable_error [07:39:22] 10VisualEditor, 10VisualEditor-MediaWiki, 10OOjs-UI, 10Vector: Change OOUI MediaWiki theme to be optimized for font-size of 14px (0.875em×16px), instead of 12.8px (0.8em×16px), like MediaWiki Vector skin - https://phabricator.wikimedia.org/T97631#1636347 (10matmarex) a:5matmarex>3None I can't seem to f... [08:31:45] 10VisualEditor, 10VisualEditor-DataModel, 10VisualEditor-MediaWiki-References, 7Technical-Debt: Reference serialization could explode if user deletes reflist - https://phabricator.wikimedia.org/T93159#1636415 (10Catrope) I'm not sure if it's ever caused an issue in practice, but it's certainly worrying, si... [09:48:48] (03PS7) 10Divec: WIP: Fix cartouche wrapping glich with temporary block style on img [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/233740 (https://phabricator.wikimedia.org/T111672) [09:51:49] (03CR) 10jenkins-bot: [V: 04-1] WIP: Fix cartouche wrapping glich with temporary block style on img [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/233740 (https://phabricator.wikimedia.org/T111672) (owner: 10Divec) [10:39:12] 10VisualEditor: Getting occasional "Parsoidserver-http: HTTP 400" error when editing Czech Wikipedia using VE - https://phabricator.wikimedia.org/T112496#1636648 (10Elitre) It's a duplicate of https://phabricator.wikimedia.org/T112286. [10:46:05] 10Citoid, 7Technical-Debt: Switch from tabs to spaces - https://phabricator.wikimedia.org/T112507#1636669 (10mobrovac) 3NEW [10:46:43] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Support for SFN and similar references - https://phabricator.wikimedia.org/T53522#1636679 (10MauryMarkowitz) JD, can you point to the "as discussed previously"? I am not familiar with the problem, so do I understand why this would be a "horrible hack". [10:56:21] 10VisualEditor: Getting occasional "Parsoidserver-http: HTTP 400" error when editing Czech Wikipedia using VE - https://phabricator.wikimedia.org/T112496#1636702 (10Esanders) [10:56:25] 10VisualEditor, 10Parsoid, 10RESTBase: Reports of 400 and 500 errors with Parsoid - https://phabricator.wikimedia.org/T112286#1636703 (10Esanders) [11:00:11] 10VisualEditor: Remainder of heading irrecoverably removed after deleting part of it - https://phabricator.wikimedia.org/T89972#1636721 (10Esanders) Which block of text did you remove. What was the exact selection and what did you type (backspace?)? [11:12:36] Do I need special rights or something to be able to merge tasks? I tried twice and Phab just did nothing. [11:14:36] (03PS1) 10Esanders: MWSaveDialog: Checkbox vertical alignment tweak [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/238117 [11:15:42] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Be able to set an item's size in upright terms in the media edit dialog - https://phabricator.wikimedia.org/T64671#1636771 (10Trizek-WMF) [[https://fr.wikipedia.org/w/index.php?title=Wikip%C3%A9dia:%C3%89diteurVisuel/Avis&diff=118625212&oldid=118570520... [11:20:46] Elitre, no, I don't think so [11:21:13] then Phab just hates me. oh well. [11:22:03] Elitre, you went to T112286, clicked 'Merge Duplicates In', selected T112496 and it didn't do anything? [11:22:40] and clicked Save or whatever the final button says, yup. [11:23:33] I did it twice in case I had done something wrong the first time, but nothing. [11:36:24] (03PS1) 10Esanders: Dialog: Use a 'done' button on edit param page instead of 'back' [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/238123 [11:37:49] 10Citoid: Field abstract should be abstractNote - https://phabricator.wikimedia.org/T107444#1636835 (10mobrovac) 5Open>3Resolved Deployed, resolving [11:38:01] (03PS13) 10Alex Monk: Autodisable preference [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230949 (https://phabricator.wikimedia.org/T112352) [11:38:23] 10Citoid: Remove url parameters when getting DOI from URL - https://phabricator.wikimedia.org/T108832#1636846 (10mobrovac) 5Open>3Resolved Deployed, resolving. [11:39:36] 10Citoid: Citoid identifies non-DOI URLs as DOIs - https://phabricator.wikimedia.org/T109536#1636850 (10mobrovac) 5Open>3Resolved Deployed, resolving. @Jonesey95 please open a separate task for spaces and dashes in DOIs. [11:40:16] 10Citoid: http://www.example.com/10.1086/378695 returns citation with same author listed twice - https://phabricator.wikimedia.org/T109431#1636855 (10mobrovac) 5Open>3Resolved Deployed, resolving. [11:40:39] 10Citoid, 7Easy: Strip whitespace out of openGraph fields - https://phabricator.wikimedia.org/T105805#1636859 (10mobrovac) Deployed, resolving. [11:40:49] 10Citoid, 7Easy: Strip whitespace out of openGraph fields - https://phabricator.wikimedia.org/T105805#1636860 (10mobrovac) 5Open>3Resolved [11:41:32] 10Citoid: Extended deepEqual in assert.js doesn't require that strings match; some current tests fail as a result - https://phabricator.wikimedia.org/T112305#1636869 (10Mvolz) Ok, but I think it should be called something other than deepEqual... a bit confusing, no? [11:41:53] Hi, can someone help me with this parsoid issue [11:42:07] Everytime I try to enter edit mode, i get this error : http://languagetool_testaccount.wmflabs.org/ [11:42:27] sorry, the error is : "Error loading data from server: 404: parsoidserver-http: HTTP 404. Would you like to retry?" [11:42:39] The previous link is the web proxy for the instance [11:42:46] So you can try it out yourself [11:42:59] I can't see anything in the logs either [11:43:21] and by logs I mean logs in /srv/mediawiki-vagrant/logs [11:43:44] I might be missing some config options [12:10:44] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-extensions-Translate: Edit tab on translatable pages flashes "Translate" before changing "Edit wikitext". - https://phabricator.wikimedia.org/T94386#1636935 (10Krenair) 5Open>3Resolved [12:11:36] ankita-ks, where is your parsoid instance? [12:21:44] 10VisualEditor: Remainder of heading irrecoverably removed after deleting part of it - https://phabricator.wikimedia.org/T89972#1636983 (10Mvolz) I think it was part of the heading (maybe In) up to the end of the text where the bullets were, and definitely backspace. But... I can't replicate it now on mediawik... [12:35:02] Krenair : The instance is within vagrant [12:35:16] I have enable visualeditor role [12:35:32] And I suppose it sets up a parsoid instance itself [12:35:56] Can't help you then, sorry [12:43:30] Krenair : That's okay. but could you just point me in some direction? Because even though it is inside vagrant, it seems to be like a normal installation with error logs and all [12:43:38] And I have been stuck for over two weeks now [12:43:39] :/ [12:44:12] try connecting to parsoid directly and checking that [12:44:16] check parsoid config [12:44:31] okay [12:44:40] What do you mean by connect to parsoid ? [12:44:54] and by parsoid config, do you mean localsettings.js? [12:45:02] browse to parsoid and see if it works [12:45:28] okay, I can make curl requests too right? [12:46:11] sure [12:46:55] okay, I will try that [12:47:11] 10Citoid, 6Services, 10Traffic, 6operations: Remove citoid from parsoidcache - https://phabricator.wikimedia.org/T110476#1637106 (10BBlack) I don't see where that's noted there. Are you saying there's a reason to keep a separate cxserver.wikimedia.org in the long term, even after making it available via RB? [13:07:05] 10Citoid, 6Services, 10Traffic, 6operations: Remove citoid from parsoidcache - https://phabricator.wikimedia.org/T110476#1637147 (10Mvolz) It was mentioned on another task (and I can't currently find the thread!) but @Jdforrester-WMF mentioned that we've been actively encouraging developers to use the cito... [13:09:19] 10Citoid, 6Services, 10Traffic, 6operations: Remove citoid from parsoidcache - https://phabricator.wikimedia.org/T110476#1637153 (10mobrovac) >>! In T110476#1637106, @BBlack wrote: > I don't see where that's noted there. Hm, indeed, it's not. Hm, strange. I remember discussing it with @Jdforrester-WMF on... [13:15:01] 10Citoid: Read dublin core embedded metadata in lib/scrape.js - https://phabricator.wikimedia.org/T76224#1637179 (10Mvolz) a:3Mvolz [14:05:34] Krenair : There? [14:05:48] yes [14:06:02] So when I send a simple curl request to localhost:8000 [14:06:07] This is what I get : [14:06:55] https://gist.github.com/ankita-kumari/35dd6cef12c5d6073536 [14:07:31] great [14:08:02] So now try localhost:8000/localhost/Main_Page [14:09:33] https://gist.github.com/ankita-kumari/afc08dc7e2b6f55f89b3 [14:09:40] It results in error [14:10:08] open your localsettings [14:10:17] tell me everything configured [14:11:46] LocalSettings.php you mean? [14:11:51] no [14:12:01] This is parsoid erroring, so we must be discussing parsoid [14:12:05] okay, localsettings.js for parsoid [14:12:09] right, sorry [14:14:46] Krenair : https://gist.github.com/ankita-kumari/04a88842b82a698319e2 [14:15:11] I have not configured anything [14:15:13] is your instance called mediawiki-vagrant.wmflabs.org ? [14:15:18] if not, this won't work [14:15:21] 10VisualEditor-LanguageTool, 6Editing-Department, 6Language-Engineering, 3Google-Summer-of-Code-2015, 7I18n: Unified language proofing tools integration framework - https://phabricator.wikimedia.org/T89107#1637331 (10Qgil) What is the situation with [[ https://www.mediawiki.org/wiki/Extension:LanguageToo... [14:15:24] No, but I changed it to my instance name [14:15:28] and it did not work either [14:15:33] So I restored defaults [14:15:36] okay, what is the error from that? [14:15:36] ugh [14:15:50] Same error [14:15:51] put it back and let's at least attempt to debug it. reversing your progress can't help matters [14:16:08] the error still refers to http://mediawiki-vagrant.wmflabs.org:8080/w/api.php ? [14:16:08] Error loading data from server: 404: parsoidserver-http: HTTP 404. Would you like to retry? [14:16:17] Okay, trying it [14:21:33] Krenair : So, i changed the url, and it still throws the same error [14:21:41] parsoidConfig.setMwApi( { [14:21:41] prefix: 'localhost', [14:21:41] domain: 'languagetool_testaccount.wmflabs.org', [14:21:41] uri: 'http://languagetool_testaccount.wmflabs.org:8080/w/api.php', [14:21:41] } ); [14:21:51] still referring to http://mediawiki-vagrant.wmflabs.org:8080/w/api.php ? [14:22:23] So maybe, this localsettings.js is not being used at all [14:22:52] does it refer to http://mediawiki-vagrant.wmflabs.org:8080/w/api.php or not? [14:28:13] No, it does not [14:32:01] ankita-ks, does it refer to the new domain you just set? [14:35:50] How do I find out? I mean I have set the domain..But I can't see the call being made in the inspector [14:36:16] (03PS1) 10Esanders: Add new krl language [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/238147 [14:36:27] ankita-ks, please just forget VE exists for now and focus [14:36:52] What is the error that parsoid returns to you now that you have corrected the domain in your parsoid localsettings? [14:37:06] (03CR) 10Esanders: [C: 032] "Self +2 to fix build, as i18n broke build with self +2." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/238147 (owner: 10Esanders) [14:37:54] edsanders, do we have a ticket against TWN about fixing that i18n breakage? [14:38:09] https://gist.github.com/ankita-kumari/d3d4d17a5d7ce3104593 [14:38:16] This is the error that I get [14:38:49] ankita-ks, you said it does not refer to http://mediawiki-vagrant.wmflabs.org:8080/w/api.php [14:38:56] This one very clearly says http://mediawiki-vagrant.wmflabs.org:8080/w/api.php [14:39:18] But that's what, I have changed the domain in localsettings.js [14:39:40] (03PS1) 10Esanders: ve.dm.Scalable: Create unit tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/238148 (https://phabricator.wikimedia.org/T95411) [14:40:12] (03Merged) 10jenkins-bot: Add new krl language [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/238147 (owner: 10Esanders) [14:40:12] ankita-ks, did you restart parsoid? [14:40:34] No, doing that now [14:41:55] (03PS2) 10Esanders: ve.dm.Scalable: Create unit tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/238148 (https://phabricator.wikimedia.org/T95411) [14:46:12] Heya. [14:46:44] (03CR) 10Jforrester: [C: 032] MWSaveDialog: Checkbox vertical alignment tweak [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/238117 (owner: 10Esanders) [14:48:33] (03CR) 10Jforrester: [C: 032] Fix language widget [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/238004 (owner: 10Esanders) [14:48:44] (03CR) 10Jforrester: [C: 032] Use ActionFieldLayout for 'Add parameter' [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/238005 (owner: 10Esanders) [14:49:59] (03CR) 10Jforrester: [C: 032] "Good catch." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/238123 (owner: 10Esanders) [14:52:50] (03Merged) 10jenkins-bot: MWSaveDialog: Checkbox vertical alignment tweak [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/238117 (owner: 10Esanders) [14:52:52] (03Merged) 10jenkins-bot: Fix language widget [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/238004 (owner: 10Esanders) [14:52:56] (03Merged) 10jenkins-bot: Use ActionFieldLayout for 'Add parameter' [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/238005 (owner: 10Esanders) [14:53:00] (03Merged) 10jenkins-bot: Dialog: Use a 'done' button on edit param page instead of 'back' [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/238123 (owner: 10Esanders) [15:07:15] 10VisualEditor, 10Parsoid, 10RESTBase: Reports of 400 and 500 errors with Parsoid - https://phabricator.wikimedia.org/T112286#1637506 (10GWicke) Progress update: The script is at -3951775668321071380, so a few more days to go. [15:08:18] 10VisualEditor, 10Parsoid, 10RESTBase: Reports of 400 and 500 errors with Parsoid - https://phabricator.wikimedia.org/T112286#1637518 (10Elitre) Thanks a lot for your work and for the update! It's much appreciated when we can give an ETA :) [15:12:39] (03CR) 10Jforrester: [C: 031] "Coverage before/after – overall 75.36% -> 76.08%, dm 87.32% -> 89.56%, ve.dm.Scalable 46.07% -> 98.08%" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/238148 (https://phabricator.wikimedia.org/T95411) (owner: 10Esanders) [15:12:48] edsanders: Thoughts on getting to 100%? [15:12:51] ^^ [15:57:42] in dm we could get close [16:00:57] edsanders: Want me to try to address my points? :-) [16:01:30] if you want [16:01:39] Kk. [16:02:02] There's a balance between time spent writing code vs lines tested [16:04:10] Krenair, dunno, ask James_F [16:04:46] What's the question? [16:04:58] edsanders, do we have a ticket against TWN about fixing that i18n breakage? [16:05:12] (TW adding new languages) [16:05:23] (I read scrollback but…) [16:05:38] it breaks the VE build [16:05:40] Oh, yss. [16:05:43] There's a simple fix. [16:05:48] James_F, also did you see my PM? [16:05:51] No. [16:14:12] (03PS1) 10Alex Monk: Change a bunch of parsoid references to acknowledge that RESTBase is sometimes in the middle [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/238177 (https://phabricator.wikimedia.org/T112339) [16:16:27] (03CR) 10jenkins-bot: [V: 04-1] Change a bunch of parsoid references to acknowledge that RESTBase is sometimes in the middle [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/238177 (https://phabricator.wikimedia.org/T112339) (owner: 10Alex Monk) [16:21:58] (03PS2) 10Alex Monk: Change a bunch of parsoid references to acknowledge that RESTBase is sometimes in the middle [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/238177 (https://phabricator.wikimedia.org/T112339) [16:32:31] Krinkle, https://gerrit.wikimedia.org/r/#/c/238176/ [16:34:00] k [16:39:57] (03CR) 10Cscott: "Some minor tweaks" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/238177 (https://phabricator.wikimedia.org/T112339) (owner: 10Alex Monk) [16:40:29] James_F, Krinkle, failed, rebase required [16:43:50] James_F, I don't know what I'm doing: https://gerrit.wikimedia.org/r/#/c/238167/ [16:43:55] trying to get it to recheck with +2 [16:44:18] edsanders: Wait. [16:44:27] edsanders: It needs to be pushed to CI prod. [16:44:34] edsanders: Patience. [16:44:34] ok [16:44:53] :( [16:45:13] edsanders: I'm sure Krinkle is about to push it. :-) [16:46:42] edsanders: And done. [16:50:02] Should be all good now. [16:50:24] a "recheck" or rebase can be deceiving as that uses your credentials, not hers. [16:53:04] * Krenair grumbles [16:53:08] looks like something is broken in beta again [16:55:25] http://en.wikipedia.beta.wmflabs.org/api/rest_v1/page/html/Main_Page [16:55:34] "Error in Cassandra table storage backend" [17:02:35] edsanders, Krenair: We're going late, sorry. [17:06:15] James_F, how late? [17:06:25] edsanders: Meeting still going, so… [17:06:57] Ooh, we're escaping. [18:19:44] James_F, in banana, what is the "... is a duplicate of the primary message" error all about? [18:30:02] 10VisualEditor, 10VisualEditor-MediaWiki, 6Community-Tech, 3Community-Tech-Sprint: [AOI] HotCat doesn't load after saving a page in VisualEditor (must refresh/reload first) - https://phabricator.wikimedia.org/T103285#1638478 (10kaldari) [18:31:41] edsanders: I think it means that the translation is identical to the English message? [18:31:47] Yup. [18:31:56] Or French or whatever the primary message definition is. [18:39:42] I guessed that bit, but why would it ever be useful as an error? [18:40:52] fr.table = "Table" is not the same as fr.table = undefined [18:41:03] the latter means "don't know, not yet translated" [18:47:46] *maybe* if you project only contain language variants (en, en-gb) you might want that option, but it should definitely be disabled by default [18:53:32] edsanders: Blame legoktm and Krinkle; I was going to leave it disabled by default. [18:54:01] hi [18:54:29] https://github.com/wikimedia/grunt-banana-checker/issues/33 ;) [18:55:24] that depends. Often case, duplicate translation is wrong and unintended. But if the word happens to be the same, it's not an error indeed because if we change the English word from "table" to "grid" it wouldn't be French anymore [18:55:57] I agree though, for anything from translatewiki it is entirely inappropiate to enable such warning [18:56:11] Krinkle, I think for most projects in general it's inappropriate [18:56:13] because it's not our responsibility to curate that as developers. [18:56:27] it can be set on a per-message basis maybe [18:58:48] "often" is not good enough to be a linting rule [18:59:50] It would be a fairly strange project that always disabled duplicate translations, so having the rule available at all is debatable, and it definitely shouldn't be the default [19:03:40] 10VisualEditor-LanguageTool, 6Editing-Department, 6Language-Engineering, 3Google-Summer-of-Code-2015, 7I18n: Unified language proofing tools integration framework - https://phabricator.wikimedia.org/T89107#1638645 (10Ankita-ks) @Qgil : Yes, but there are too many bugs right now. I am working on setting u... [19:04:21] [13grunt-banana-checker] 15edg2s created 06disallow-duplicate-false from 06master (+0 new commits): 02https://github.com/wikimedia/grunt-banana-checker/commits/disallow-duplicate-false [19:06:17] [13grunt-banana-checker] 15edg2s pushed 1 new commit to 06disallow-duplicate-false: 02https://github.com/wikimedia/grunt-banana-checker/commit/a9d3aaddc3df9b9f933340d55d0b337a12964eae [19:06:17] 13grunt-banana-checker/06disallow-duplicate-false 14a9d3aad 15Ed Sanders: Make disallowDuplicateTranslations default to false, fixes #35 [19:06:42] [13grunt-banana-checker] 15edg2s opened pull request #35: Make disallowDuplicateTranslations default to false, fixes #35 (06master...06disallow-duplicate-false) 02https://github.com/wikimedia/grunt-banana-checker/pull/35 [19:32:47] (03CR) 10Jforrester: "@cscott – did you mean to make some tweaks?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/238177 (https://phabricator.wikimedia.org/T112339) (owner: 10Alex Monk) [19:33:55] (03CR) 10Cscott: "Whoops, sorry, these comments were made on PS1 and there was a race with Alex submitting PS2 which confused gerrit (or me)." (033 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/238177 (https://phabricator.wikimedia.org/T112339) (owner: 10Alex Monk) [19:35:23] James_F: fyi, i'm sorta back from leave. my kid is doing well, so i'm going to try returning to full time work and see how it goes. but i still might disappear suddenly if i'm needed at home. [19:41:27] cscott: Thanks. [19:41:30] cscott: Welcome back! [19:42:14] (03PS1) 10Esanders: Add more tests to ve.dm.SurfaceFragment [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/238225 [19:43:32] James_F, you fixing https://gerrit.wikimedia.org/r/#/c/238148/2 ? [19:44:48] (03PS2) 10Esanders: Add more tests to ve.dm.SurfaceFragment [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/238225 [19:46:09] (03CR) 10Alex Monk: "Most likely you wrote comments on PS1, then returned to the main review screen where I'd just uploaded PS2 and submitted the review, causi" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/238177 (https://phabricator.wikimedia.org/T112339) (owner: 10Alex Monk) [19:48:22] edsanders: Slowly, yes, sorry. [19:48:47] cscott, welcome [19:48:57] edsanders: It'd probably be much faster if you did it, if you feel like it. ;-) [19:49:19] just +2 that commit - I might come back to it later [19:49:43] (03PS3) 10Alex Monk: Change a bunch of parsoid references to acknowledge that RESTBase is sometimes in the middle [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/238177 (https://phabricator.wikimedia.org/T112339) [19:49:50] Kk. [19:50:01] (03CR) 10Cscott: "yep, that sounds right. in any case, it was just some minor "and" -> "or" stuff." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/238177 (https://phabricator.wikimedia.org/T112339) (owner: 10Alex Monk) [19:50:39] (03CR) 10Jforrester: [C: 032] "Let's do in a follow-up." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/238148 (https://phabricator.wikimedia.org/T95411) (owner: 10Esanders) [19:52:25] (03CR) 10Cscott: "I'm going to set someone from VE do the +2 because of the 'parsoidserver' -> 'docserver' change (I don't know if that has side effects on " [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/238177 (https://phabricator.wikimedia.org/T112339) (owner: 10Alex Monk) [19:54:05] (03CR) 10Jforrester: [C: 031] Change a bunch of parsoid references to acknowledge that RESTBase is sometimes in the middle (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/238177 (https://phabricator.wikimedia.org/T112339) (owner: 10Alex Monk) [19:54:15] (03Merged) 10jenkins-bot: ve.dm.Scalable: Create unit tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/238148 (https://phabricator.wikimedia.org/T95411) (owner: 10Esanders) [19:55:34] 10VisualEditor, 10VisualEditor-DataModel, 7Technical-Debt, 5WMF-deploy-2015-09-15_(1.26wmf23): Create unit tests for ve.dm.Scalable - https://phabricator.wikimedia.org/T95411#1638864 (10Jdforrester-WMF) 5Open>3Resolved a:3Esanders [19:56:18] (03PS4) 10Eranroz: Avoid flickers on talk pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/237891 (https://phabricator.wikimedia.org/T112366) [19:56:22] (03CR) 10jenkins-bot: [V: 04-1] Avoid flickers on talk pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/237891 (https://phabricator.wikimedia.org/T112366) (owner: 10Eranroz) [20:00:23] (03PS5) 10Eranroz: Avoid flickers on talk pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/237891 (https://phabricator.wikimedia.org/T112366) [20:14:45] (03PS39) 10Divec: Links: Explicit entry/exit with cartouches [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/217257 (https://phabricator.wikimedia.org/T91285) [20:15:00] (03PS1) 10Alex Monk: If init fails once, don't completely break when the user retries [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/238303 (https://phabricator.wikimedia.org/T96437) [20:17:28] (03CR) 10Divec: "Patchset 39 fixes the tools being out of sync with the cartouche." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/217257 (https://phabricator.wikimedia.org/T91285) (owner: 10Divec) [20:18:02] (03CR) 10jenkins-bot: [V: 04-1] Links: Explicit entry/exit with cartouches [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/217257 (https://phabricator.wikimedia.org/T91285) (owner: 10Divec) [20:18:04] (03PS31) 10Divec: ve.ce.adjustLinkSelection: fixup link-bisecting selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/222488 [20:18:08] (03PS4) 10Alex Monk: Change a bunch of parsoid references to acknowledge that RESTBase is sometimes in the middle [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/238177 (https://phabricator.wikimedia.org/T112339) [20:18:22] (03PS28) 10Divec: Fixup link selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/222619 [20:21:27] (03CR) 10jenkins-bot: [V: 04-1] ve.ce.adjustLinkSelection: fixup link-bisecting selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/222488 (owner: 10Divec) [20:21:32] (03CR) 10jenkins-bot: [V: 04-1] Fixup link selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/222619 (owner: 10Divec) [20:26:32] (03PS8) 10Divec: WIP: Fix cartouche wrapping glich with temporary block style on img [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/233740 (https://phabricator.wikimedia.org/T111672) [20:29:36] (03CR) 10jenkins-bot: [V: 04-1] WIP: Fix cartouche wrapping glich with temporary block style on img [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/233740 (https://phabricator.wikimedia.org/T111672) (owner: 10Divec) [20:31:01] (03PS40) 10Divec: Links: Explicit entry/exit with cartouches [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/217257 (https://phabricator.wikimedia.org/T91285) [20:59:05] Krinkle or anyone, is it reliable that range.startOffset gets updated when inserting/removing siblings before that offset? (See https://jsfiddle.net/csjd2m8t/ ) [21:02:29] divec_: The spec doesn't explicitly state whether it's live or not. But in general I expect DOM properties / IDL attributes to be live getters yes [21:02:52] I can quickly run it through a bunch of browsers if yo liek [21:04:57] Krinkle, It's OK - I mainly wanted to know whether my code comment ought to say "range objects *usually* get updated" :-) [21:06:08] https://jsfiddle.net/csjd2m8t/1/ [21:06:18] running now [21:07:43] edsanders: Oh dear. [21:07:57] edsanders: I've found a bug in Scalable. [21:08:16] ... [21:08:41] Krinkle: oh cool [21:08:45] clone = scalable.clone(); seems to change its mind about the ratio. [21:09:32] edsanders: [21:09:33] https://www.dropbox.com/s/62ez8uldm8biz3v/Screen%20Shot%202015-09-14%20at%2014.08.56.png?dl=0 [21:09:51] divec_: .remove() is not a valid DOM method [21:10:29] Fixed in https://jsfiddle.net/csjd2m8t/2/. [21:11:58] Runs as expected in: Chrome 43, Safari 8, Firefox 40, Firefox 24, Firefox 4, IE 11, IE 10, Opera 12.16. [21:12:02] Krinkle: https://developer.mozilla.org/en-US/docs/Web/API/ChildNode/remove ? [21:12:35] It's been tried a few times, removed/added [21:12:48] It will probably land in DOM4 (which isn't a release candidate yet, still a draft) [21:12:55] some browsers do implement it indeed [21:13:09] So I should always use node.parentNode.removeChild( node ) for now? [21:13:15] Yes. [21:13:17] edsanders: Oh, I've found it, it was being broken in the unit tests earlier. [21:13:21] Ok, thanks [21:14:01] 10VisualEditor, 10Parsoid: Copying a rendered table into VE missed a |- and other parsing issues - https://phabricator.wikimedia.org/T112394#1639221 (10Quiddity) >>! In T112394#1634343, @ssastry wrote: > What browser did you use for the copy-paste? Added the VisualEditor project in case this is known. > Also,... [21:14:05] Mobile Safari doens't have it, Firefox 4-10 doens't have it, and no IE or Edge version [21:16:46] (03PS41) 10Divec: Links: Explicit entry/exit with cartouches [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/217257 (https://phabricator.wikimedia.org/T91285) [21:17:47] 10VisualEditor, 10Parsoid: Copying a rendered table into VE missed a |- and other parsing issues - https://phabricator.wikimedia.org/T112394#1639237 (10ssastry) I think this is VE-land issue with the HTML that is pasted in copy-paste mode. @Jdforrester-WMF, @esanders. [21:23:05] (03PS1) 10Divec: Use removeChild instead of remove [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/238328 [21:25:23] 10VisualEditor, 10VisualEditor-EditingTools, 5WMF-deploy-2015-09-15_(1.26wmf23): Listed items get deleted upon drag-dropping them - https://phabricator.wikimedia.org/T96092#1639267 (10Ryasmeen) 5Resolved>3Open The issue of Drag-drop of listed items causing the content to be lost is fixed now. From the fi... [21:25:35] 10VisualEditor, 10VisualEditor-EditingTools, 7Verified-in-Phase0, 5WMF-deploy-2015-09-15_(1.26wmf23): Listed items get deleted upon drag-dropping them - https://phabricator.wikimedia.org/T96092#1639269 (10Ryasmeen) [21:26:00] (03CR) 10jenkins-bot: [V: 04-1] Use removeChild instead of remove [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/238328 (owner: 10Divec) [21:27:40] divec_: I'll fix. [21:29:35] James_F: thanks! [21:33:36] (03PS32) 10Divec: ve.ce.adjustLinkSelection: fixup link-bisecting selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/222488 [21:33:39] (03PS1) 10Jforrester: Follow-up 761d817: Fix build for added language 'olo' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/238330 [21:33:41] (03PS1) 10Jforrester: ve.dm.Scalable: Get test coverage to 100% [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/238331 [21:33:49] divec_: +2 https://gerrit.wikimedia.org/r/238330 please? [21:34:18] (03CR) 10Divec: [C: 032] Follow-up 761d817: Fix build for added language 'olo' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/238330 (owner: 10Jforrester) [21:34:51] Ta. [21:36:43] No - thank you! [21:37:37] (03Merged) 10jenkins-bot: Follow-up 761d817: Fix build for added language 'olo' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/238330 (owner: 10Jforrester) [21:38:34] (03PS2) 10Divec: Use removeChild instead of remove [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/238328 [21:39:03] (03CR) 10Jforrester: [C: 032] Use removeChild instead of remove [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/238328 (owner: 10Divec) [21:39:09] (03PS42) 10Divec: Links: Explicit entry/exit with cartouches [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/217257 (https://phabricator.wikimedia.org/T91285) [21:39:26] (03CR) 10Jforrester: [C: 04-1] "Off by one conditional for some reason." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/238331 (owner: 10Jforrester) [21:39:37] (03PS33) 10Divec: ve.ce.adjustLinkSelection: fixup link-bisecting selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/222488 [21:39:54] (03PS29) 10Divec: Fixup link selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/222619 [21:41:57] (03PS9) 10Divec: WIP: Fix cartouche wrapping glich with temporary block style on img [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/233740 (https://phabricator.wikimedia.org/T111672) [21:42:37] (03Merged) 10jenkins-bot: Use removeChild instead of remove [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/238328 (owner: 10Divec) [21:43:11] (03Abandoned) 10Divec: Declare functions before use in ve.demo.init.js [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/235895 (owner: 10Divec) [21:45:07] (03CR) 10jenkins-bot: [V: 04-1] WIP: Fix cartouche wrapping glich with temporary block style on img [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/233740 (https://phabricator.wikimedia.org/T111672) (owner: 10Divec) [21:45:20] (03PS3) 10Jforrester: ve.dm.SurfaceFragment: Add more unit tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/238225 (owner: 10Esanders) [21:45:33] (03CR) 10Jforrester: [C: 032] ve.dm.SurfaceFragment: Add more unit tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/238225 (owner: 10Esanders) [21:50:17] (03Merged) 10jenkins-bot: ve.dm.SurfaceFragment: Add more unit tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/238225 (owner: 10Esanders) [21:50:54] (03CR) 10Jforrester: [C: 032] If init fails once, don't completely break when the user retries [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/238303 (https://phabricator.wikimedia.org/T96437) (owner: 10Alex Monk) [21:51:04] 10VisualEditor, 10VisualEditor-Initialisation, 10VisualEditor-MediaWiki: Error during editor initialization makes it impossible to try to edit a second time - https://phabricator.wikimedia.org/T96437#1639363 (10Jdforrester-WMF) 5Open>3Resolved [21:52:12] (03CR) 10Jforrester: Avoid flickers on talk pages (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/237891 (https://phabricator.wikimedia.org/T112366) (owner: 10Eranroz) [21:55:43] (03Merged) 10jenkins-bot: If init fails once, don't completely break when the user retries [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/238303 (https://phabricator.wikimedia.org/T96437) (owner: 10Alex Monk) [21:57:42] (03PS1) 10Jforrester: Update VE core submodule to master (7847bf5) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/238339 [21:59:08] (03CR) 10Jforrester: [C: 031] MWBetaWelcomeDialog: Alter to be welcoming, use a nice image [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/221762 (https://phabricator.wikimedia.org/T99963) (owner: 10Jforrester) [21:59:18] Krenair: That's probably good to go if you're happy with it. [22:01:36] When I tried it, something else was completely broken [22:01:42] not related, seemed to be message cache [22:03:17] James_F, basically despite the commit changing a message, wfMessage would still return the old text [22:03:33] Maybe it was just behaving as expected and I was missing something obvious [22:03:44] like maybe I had overridden the message on-wiki and forgotten about it or something [22:04:54] 10VisualEditor, 10VisualEditor-EditingTools, 7Verified-in-Phase0, 5WMF-deploy-2015-09-15_(1.26wmf23): Keyboard shortcuts dialog too small for its contents - https://phabricator.wikimedia.org/T78179#1639420 (10Ryasmeen) [22:08:45] 10VisualEditor, 10VisualEditor-Tables, 7Verified-in-Phase0, 7Verified-in-Phase2, 5WMF-deploy-2015-09-15_(1.26wmf23): Menu items in table popup widget (e.g. "Insert before") truncated in most languages (box not wide enough) - https://phabricator.wikimedia.org/T78119#1639426 (10Ryasmeen) [22:13:34] (03CR) 10Krinkle: "I imagine it previously passed code review under the false assumption that it may've been a jQuery object (which has .remove). Nice method" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/238328 (owner: 10Divec) [22:19:03] 10VisualEditor, 10VisualEditor-EditingTools, 7Verified-in-Phase0, 5WMF-deploy-2015-09-15_(1.26wmf23): Listed items get deleted upon drag-dropping them - https://phabricator.wikimedia.org/T96092#1639460 (10Ryasmeen) 5Open>3Resolved [22:20:50] Krenair: Yeah, that's… troubling. [22:32:07] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Mobile: Show the VE-MW welcome dialog to first-time users on mobile too - https://phabricator.wikimedia.org/T112599#1639500 (10Jdforrester-WMF) 3NEW [22:33:00] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Mobile: Show the VE-MW welcome dialog to first-time users on mobile too - https://phabricator.wikimedia.org/T112599#1639508 (10Jdforrester-WMF) [22:33:01] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 7Epic: Make VisualEditor good enough for mobile tablet and phone default enablement - https://phabricator.wikimedia.org/T94725#1639507 (10Jdforrester-WMF) [22:33:18] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Mobile: Show the VE-MW welcome dialog to first-time users on mobile too - https://phabricator.wikimedia.org/T112599#1639500 (10Jdforrester-WMF) [22:34:12] 10VisualEditor, 10Parsoid, 10RESTBase, 5Patch-For-Review: Change VisualEditor's error logging to not assume all VRS errors are Parsoid errors - https://phabricator.wikimedia.org/T112339#1632752 (10Jdforrester-WMF) [22:35:07] 10VisualEditor, 5Patch-For-Review: Ugly edit => edit source replacement on page load - https://phabricator.wikimedia.org/T112366#1639517 (10Jdforrester-WMF) Can you say which wiki/page and with what browser you get a flicker? I don't… [22:37:22] 10VisualEditor, 10VisualEditor-MediaWiki, 10Math, 5WMF-deploy-2015-09-15_(1.26wmf23): Math node updates rendering when ID field is typed into - https://phabricator.wikimedia.org/T112466#1639524 (10Jdforrester-WMF) 5Open>3Resolved [22:38:00] 10VisualEditor, 10VisualEditor-MediaWiki-Links: [Regression wmf??] Auto-switching of external links typed into the link inspector no longer working - https://phabricator.wikimedia.org/T112158#1639528 (10Jdforrester-WMF) a:3Esanders [22:38:06] 10VisualEditor, 10VisualEditor-MediaWiki-Links: [Regression wmf??] Auto-switching of external links typed into the link inspector no longer working - https://phabricator.wikimedia.org/T112158#1627475 (10Jdforrester-WMF) p:5Triage>3Normal [22:41:07] 10VisualEditor, 10VisualEditor-MediaWiki-Plugins, 10Math, 7Epic: List requirements for a visual VisualEditor plugin tool to add/edit maths blocks - https://phabricator.wikimedia.org/T106310#1639541 (10Jdforrester-WMF) Hey, do you need any support with this? [22:43:50] 10VisualEditor, 10VisualEditor-MediaWiki-Templates: Consider ways to cope more prettily with block-outputting templates in non-block contexts - https://phabricator.wikimedia.org/T112418#1639560 (10Jdforrester-WMF) p:5Triage>3Low [22:48:26] 10VisualEditor: VE breaks on faked section edit links - https://phabricator.wikimedia.org/T111919#1639581 (10Jdforrester-WMF) 5Open>3declined a:3Jdforrester-WMF These aren't an API and we won't be retaining them for that long, so pouring effort into this ultra-edge case is not worthwhile, sorry. [22:49:28] 10VisualEditor, 10VisualEditor-MediaWiki: Some kind of filtering or security software ("NetFree") inserts an HTML comment when editing with VisualEditor - https://phabricator.wikimedia.org/T111906#1639589 (10Jdforrester-WMF) p:5Triage>3Low [22:53:32] 10VisualEditor, 10VisualEditor-MediaWiki, 7JavaScript: Infinite collapsing/uncollapsing of VisualEditor's Edit tab on some screen resolutions when tabs are inserted by JS (which doen't happen frequently) - https://phabricator.wikimedia.org/T108588#1639613 (10Jdforrester-WMF) >>! In T108588#1611584, @Ciencia_... [22:54:31] 10VisualEditor: VE breaks on faked section edit links - https://phabricator.wikimedia.org/T111919#1639618 (10matmarex) > or a new class should be introduced with the same styles as `mw-editsection` to discourage abuse like my script. There is one, `.mw-editsection-like`. [22:56:00] 10VisualEditor, 10VisualEditor-MediaWiki, 5Patch-For-Review, 5WMF-deploy-2015-09-15_(1.26wmf23): Image paths inside generated nodes (extension/template) aren't absolutised when copied to the external clipboard - https://phabricator.wikimedia.org/T111927#1639619 (10Jdforrester-WMF) 5Open>3Resolved p:5T... [22:58:22] 10VisualEditor: Disable some parts of the editing interface from IPs and newbies because we don't trust them to use them correctly - https://phabricator.wikimedia.org/T110329#1639631 (10Jdforrester-WMF) >>! In T110329#1635295, @Supernino wrote: > [Citoid] ignores relevant infos like date and author Those sound... [23:01:04] (03CR) 10Alex Monk: [C: 032] Update VE core submodule to master (7847bf5) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/238339 (owner: 10Jforrester) [23:03:17] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor:Cannot go to the next line of an article after copy-paste of an hiero as the error "TypeError: outermostNode is null" appears - https://phabricator.wikimedia.org/T61092#1639658 (10Jdforrester-WMF) 5Open>3Resolved a:3Jdforrester-WMF This looks like... [23:03:27] 10VisualEditor, 10VisualEditor-EditingTools, 5VisualEditor pre-2015 work: VisualEditor:Cannot go to the next line of an article after copy-paste of an hiero as the error "TypeError: outermostNode is null" appears - https://phabricator.wikimedia.org/T61092#1639661 (10Jdforrester-WMF) [23:03:41] (03Merged) 10jenkins-bot: Update VE core submodule to master (7847bf5) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/238339 (owner: 10Jforrester) [23:04:05] RoanKattouw: I wonder if's possible to in, modern browsers, hide the whole CE dom in a shadow dom using some obsecure <-x-fuckoff> wrapper custom element. [23:04:16] That way incompetence shit storm software can't touch it. [23:04:33] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-EditingTools, 5VisualEditor pre-2015 work: VisualEditor:Cutting the section heading along with the content under it and pasting them back moves the heading under the content - https://phabricator.wikimedia.org/T61877#1639669 (10Jdforrester-WMF) 5Ope... [23:05:50] lol [23:05:58] 10VisualEditor, 10VisualEditor-MediaWiki-References, 10VisualEditor-MediaWiki-Templates: You should be able to re-use a reference in a template invocation - https://phabricator.wikimedia.org/T63505#1639678 (10Jdforrester-WMF) p:5Triage>3Normal [23:07:15] Krinkle: I'm not sure we should use "<-x-fuckoff>" given the code of conduct, but perhaps. [23:07:47] Krinkle: However, how about a CI coverage reporter first? ;-) https://gerrit.wikimedia.org/r/#/c/237234/ ;-P [23:07:52] It would be aimed at robots and machines. Not sure they've been given CoC rights yet but sure :) [23:11:55] 10VisualEditor, 10Gallery: Wall of code in tag - https://phabricator.wikimedia.org/T102914#1639704 (10Jdforrester-WMF) [23:12:00] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-References, 10Gallery, 10Parsoid: VisualEditor: References inside galleries being displayed separately, inside the gallery, instead of in the correct block at the end of ... - https://phabricator.wikimedia.org/T74865#1639707 [23:12:03] 10VisualEditor, 10VisualEditor-ContentEditable, 10Gallery: Allow to add special characters to gallery - https://phabricator.wikimedia.org/T87532#1639706 (10Jdforrester-WMF) [23:12:35] 10VisualEditor, 10Gallery, 10MediaWiki-Interface, 10Possible-Tech-Projects: Rearranging the order of image (link)s in galleries via drag and drop (AJAXy) - https://phabricator.wikimedia.org/T13500#1639753 (10Jdforrester-WMF) [23:12:48] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-References, 10Gallery, 10Parsoid: VisualEditor: References inside galleries being displayed separately, inside the gallery, instead of in the correct block at the end of ... - https://phabricator.wikimedia.org/T74865#1639768 [23:14:14] 10VisualEditor, 10VisualEditor-EditingTools, 10Gallery: VisualEditor: Adding gallery as Heading creates inconsistency between readmode and VE mode - https://phabricator.wikimedia.org/T63787#1639808 (10Jdforrester-WMF) 5Open>3Resolved p:5Triage>3Low [23:15:05] Krinkle: :-) [23:16:13] Looks like Shadow DOM comes with style encapsulation by default. Which means none of our css woudl apply. Kind of like iframes. [23:16:25] And the option to disable that separately was removed from the spec [23:16:46] Either you trust css and javascript, or neither. [23:16:50] Is "General Backlog" Maintenance or New Work, for purposes of Maintenance Fraction? [23:17:46] jaufrecht: I have lost track of what definition of "General Backlog" is at this point. [23:18:32] anything that isn't in Q3 or Q4 or a Tranche [23:21:55] 10VisualEditor, 10VisualEditor-ContentEditable: figure class="default size" inserted in a caption - https://phabricator.wikimedia.org/T88099#1639834 (10Jdforrester-WMF) 5Open>3Resolved a:3Jdforrester-WMF Not good. However, I've not seen this happen again (possibly a deploy gremlin), so provisionally I'm... [23:22:02] 10VisualEditor, 10VisualEditor-ContentEditable: figure class="default size" inserted in a caption - https://phabricator.wikimedia.org/T88099#1639837 (10Jdforrester-WMF) [23:29:00] jaufrecht: Post-2015-01-01, Maintenance (and should theoretically be zero things). [23:29:41] should be, but we found 200+ due to edge cases like old things being closed recently, etc [23:29:55] Yeah. [23:30:25] (03CR) 10Jforrester: [C: 04-1] "Hold on this whilst the Echo OOUI dependency tree is tweaked." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/224216 (owner: 10Jforrester) [23:30:31] to reconfirm: we are treating all such things (not in a tranche, status = resolved) as General Backlog up until date X, and as a relevant data glitch to be corrected after date X [23:30:38] right? if so, when is date X? [23:30:51] (03PS1) 10Esanders: Update to Unicode 8 [unicodejs] - 10https://gerrit.wikimedia.org/r/238358 [23:31:15] I would say all such things should be assumed to be pre-2015. [23:31:20] And just mis-dated. [23:36:06] (03CR) 10Trevor Parscal: [C: 032] build: Upgrade grunt-banana-checker to v0.3.0 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/236594 (owner: 10Jforrester) [23:43:03] (03CR) 10Esanders: "*cough* https://github.com/wikimedia/grunt-banana-checker/pull/35" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/236594 (owner: 10Jforrester) [23:45:51] (03Merged) 10jenkins-bot: build: Upgrade grunt-banana-checker to v0.3.0 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/236594 (owner: 10Jforrester) [23:51:39] 10VisualEditor, 10VisualEditor-MediaWiki-Plugins, 10Math, 7Epic: List requirements for a visual VisualEditor plugin tool to add/edit maths blocks - https://phabricator.wikimedia.org/T106310#1639959 (10SalixAlba) Is this going to be a new product to the one already there? Are we thinking of a editor for the... [23:52:15] 10VisualEditor, 10OOjs-UI, 10Vector, 5WMF-deploy-2015-09-15_(1.26wmf23): #p-personal hides OO.ui.Dialog in Vector skin - https://phabricator.wikimedia.org/T105300#1639961 (10Jdforrester-WMF) 5Open>3Resolved [23:54:47] (03CR) 10Jforrester: MWBetaWelcomeDialog: Alter to be welcoming, use a nice image (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/221762 (https://phabricator.wikimedia.org/T99963) (owner: 10Jforrester) [23:56:06] (03CR) 10Divec: [C: 032] Update to Unicode 8 [unicodejs] - 10https://gerrit.wikimedia.org/r/238358 (owner: 10Esanders) [23:57:03] (03Merged) 10jenkins-bot: Update to Unicode 8 [unicodejs] - 10https://gerrit.wikimedia.org/r/238358 (owner: 10Esanders)