[00:03:28] (03PS8) 10Divec: Fix arrow key fixups for inline focusable node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/194409 (https://phabricator.wikimedia.org/T91518) [00:07:51] (03CR) 10jenkins-bot: [V: 04-1] Fix arrow key fixups for inline focusable node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/194409 (https://phabricator.wikimedia.org/T91518) (owner: 10Divec) [01:34:56] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-EditingTools, 10VisualEditor-Links: On applying new link annotation, place cursor outside of the link - https://phabricator.wikimedia.org/T113082#1661842 (10John_Broughton) Other websites with editing interfaces - Quora comes most readily to mi... [04:52:28] 10VisualEditor, 6Collaboration-Team-Backlog, 10Flow, 6Language-Engineering, and 2 others: Provide an API flag to suppress auto-generated - https://phabricator.wikimedia.org/T113331#1661976 (10ssastry) 3NEW [04:53:59] 10VisualEditor, 10VisualEditor-ContentEditable, 10Parsoid: Reference list is shown on top of page after editing infobox with references inside - https://phabricator.wikimedia.org/T95851#1201694 (10ssastry) [04:54:02] 10VisualEditor, 6Collaboration-Team-Backlog, 10Flow, 6Language-Engineering, and 2 others: Provide an API flag to suppress auto-generated - https://phabricator.wikimedia.org/T113331#1661987 (10ssastry) [07:22:48] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 5WMF-deploy-2015-09-15_(1.26wmf23): Pasting external link to a local page converts to a link on save, but not on insertion - https://phabricator.wikimedia.org/T98613#1662161 (10Jdforrester-WMF) 5Open>3Resolved a:3cscott [07:23:13] 10VisualEditor, 10VisualEditor-MediaWiki, 10OOjs-UI: Bottom border of text box in save dialog only appears when zoomed in, in VisualEditor when using the OOjs UI MediaWiki theme - https://phabricator.wikimedia.org/T78051#1662168 (10Jdforrester-WMF) 5Open>3Resolved a:3Esanders [07:25:36] 10VisualEditor, 10VisualEditor-MediaWiki-Templates: Merge the (simple only?) template editing workflow into the transclusion node context menu - https://phabricator.wikimedia.org/T98460#1662173 (10Jdforrester-WMF) [07:26:07] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 10VisualEditor-MediaWiki-Mobile, 7Design: Consider changing the design of the link dialog on tablets to not be full screen - https://phabricator.wikimedia.org/T71635#1662174 (10Jdforrester-WMF) [07:26:20] 10VisualEditor, 10VisualEditor-MediaWiki-Links: Link dialog caused a scrolling frenzy - https://phabricator.wikimedia.org/T93229#1662180 (10Jdforrester-WMF) [07:26:33] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-extensions-GuidedTour, 7Design: Change Welcome dialog content to more helpful message to new users based on the GuidedTour - https://phabricator.wikimedia.org/T89072#1662181 (10Jdforrester-WMF) [07:33:39] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-EditingTools, 10VisualEditor-Links: On applying new link annotation, place cursor outside of the link - https://phabricator.wikimedia.org/T113082#1662207 (10Jdforrester-WMF) >>! In T113082#1654409, @Quiddity wrote: >>>! In T113082#1654300, @Jdf... [07:50:18] 10Citoid: Use start page and end page parameters for crossRef - https://phabricator.wikimedia.org/T107647#1662253 (10mobrovac) [08:31:09] 10Citoid: Use html-metadata node library's open graph data in lib/Scraper.js - https://phabricator.wikimedia.org/T1069#18535 (10mobrovac) [08:32:24] 10Citoid: "Language not recognized" error on adding urls with openGraph metadata - https://phabricator.wikimedia.org/T93337#1662323 (10mobrovac) [10:48:47] Krenair: Is "As in some don't actually get logged at all." worse than "They all get logged but into a black hole", do you think? [10:56:38] James_F, I'm not sure [10:57:04] Should we leave and improve instead? [10:57:09] * James_F is loathe to re-revert. :-) [11:07:23] James_F, I think we need to discuss VE's behaviour around this first [11:07:30] For some events, VE logs for all targets [11:07:38] For others, only DesktopArticleTarget [11:07:41] * James_F nods. [11:07:51] Which events are unlogged? [11:08:06] MF needs to log for wikitext as well as VE mode [11:09:33] I can't remember now :/ [11:29:37] (03CR) 10Jforrester: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/194409 (https://phabricator.wikimedia.org/T91518) (owner: 10Divec) [12:54:32] (03PS1) 10Esanders: Reduce padding for IndexLayout panels in fragment inspectors [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/240081 [12:55:39] (03PS1) 10Esanders: Inspector: Use upstream padding settings [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/240082 [13:02:17] (03CR) 10Jforrester: [C: 032] Reduce padding for IndexLayout panels in fragment inspectors [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/240081 (owner: 10Esanders) [13:06:34] (03CR) 10jenkins-bot: [V: 04-1] Reduce padding for IndexLayout panels in fragment inspectors [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/240081 (owner: 10Esanders) [13:11:40] James_F, we coming over then? [13:11:59] edsanders: I'm heading off in half an hour or so. Maybe tomorrow? [13:12:06] (03CR) 10Esanders: [C: 032] Reduce padding for IndexLayout panels in fragment inspectors [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/240081 (owner: 10Esanders) [13:12:08] ok [13:15:33] (03Merged) 10jenkins-bot: Reduce padding for IndexLayout panels in fragment inspectors [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/240081 (owner: 10Esanders) [13:19:10] (03PS1) 10Jforrester: Update VE core submodule to master (171fe11) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/240085 [13:19:16] edsanders: ^^ [13:37:43] 10VisualEditor, 10VisualEditor-MediaWiki, 10Score: Organise the score inspector into tabs - https://phabricator.wikimedia.org/T113354#1662701 (10Tchanders) 3NEW a:3Tchanders [13:50:19] 10VisualEditor, 10VisualEditor-MediaWiki, 10Score: Organise the score inspector into tabs - https://phabricator.wikimedia.org/T113354#1662742 (10Jdforrester-WMF) [13:58:17] * James_F heads off. [14:09:25] (03PS9) 10Divec: Fix arrow key fixups for inline focusable node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/194409 (https://phabricator.wikimedia.org/T91518) [14:18:35] (03CR) 10Divec: "Phew, finally not a Chrome failure." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/194409 (https://phabricator.wikimedia.org/T91518) (owner: 10Divec) [14:25:22] (03CR) 10Esanders: [C: 032] Update VE core submodule to master (171fe11) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/240085 (owner: 10Jforrester) [14:27:36] (03Merged) 10jenkins-bot: Update VE core submodule to master (171fe11) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/240085 (owner: 10Jforrester) [14:40:07] James_F|Away: did you check in that patch to lib/ve/ 's REL1_25? i'm not seeing it. [15:18:03] who's around to "translate" a user agent for me? [15:18:11] "User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/45.0.2454.93 Safari/537.36" [15:39:46] 10VisualEditor, 10VisualEditor-ContentEditable, 7Epic: Augment ve.Range with annotation boundary side information - https://phabricator.wikimedia.org/T113361#1662981 (10dchan) 3NEW a:3dchan [15:43:01] 10VisualEditor, 10VisualEditor-ContentEditable, 7Epic: Augment ve.Range with annotation boundary side information - https://phabricator.wikimedia.org/T113361#1663001 (10dchan) This task is really to document the requirement. I don't suggest we should start working on it now - we don't yet have a user issue t... [15:45:34] (03PS6) 10Divec: Zero-width space to avoid empty annotation cursoring bug [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/208355 (https://phabricator.wikimedia.org/T96307) [15:55:28] (03PS1) 10Esanders: [WIP] Image uploading [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/240116 [15:57:02] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Image uploading [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/240116 (owner: 10Esanders) [16:06:45] 10VisualEditor: add magic words to enable and disable visual editor regardless of namespace - https://phabricator.wikimedia.org/T107426#1663083 (10Kipod) this request was closed as "duplicate" of T54141, which in turn was closed as "declined". i think it's wrong: T54141 only mentioned _disabling_ VE on specific... [16:16:49] (03PS1) 10Esanders: Fix page title font size in Vector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/240118 [16:18:18] James_F|Away: several students in different courses have run into parsoid 400 errors when trying to edit pages with VE. Do you know of a likely common thread / workaround for when that happens? [16:18:22] (03CR) 10Esanders: [C: 032] Fix arrow key fixups for inline focusable node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/194409 (https://phabricator.wikimedia.org/T91518) (owner: 10Divec) [16:19:03] (03CR) 10Esanders: [C: 032] Zero-width space to avoid empty annotation cursoring bug [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/208355 (https://phabricator.wikimedia.org/T96307) (owner: 10Divec) [16:21:42] (03Merged) 10jenkins-bot: Zero-width space to avoid empty annotation cursoring bug [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/208355 (https://phabricator.wikimedia.org/T96307) (owner: 10Divec) [16:24:27] ragesoss, https://phabricator.wikimedia.org/T112286 .. [16:24:51] so, should have been fixed as of Friday. [16:26:51] okay, thanks subbu. I'll try to find out when this user hit the problem. The user reported it last night, with a screenshot, so I think it was after Friday that it happened. [16:29:00] ragesoss, and the page title would be useful as well. [16:29:42] subbu: from the report I have, it was happening last night, and the article is [[Pittsburgh]]. [16:29:49] on en.wiki [16:31:51] ya .. pittsburgh is a heavily edited page so it is unlikely to have been an issue from T112286 anyway. [16:32:18] the user reported trying repeatedly over the course of half an hour, with the 400 error coming up each time. [16:32:22] i'll ask the restbase guys if they have any error reports logged for this page ... the error (while it says parsoid error) is most often not parsoid. [16:36:07] thansk subbu. BTW, I've got an item on my todo list to talk with you about visual diffing. [16:37:08] That's something that is on my roadmap for dashboard.wikiedu.org... being able to show a visual diff in a modal from the dashboard, instead of just linking to Wikipedia (wikitext) diffs. [16:38:16] subbu: do you have a demo up and running for that visual diffing? [16:38:51] not sure if the visual diffs that i generate is useful for your application .. but one sec .. let me show you how they look. [16:39:01] i think you are looking for html diffs. [16:39:33] ah, yeah, htmol diffs sounds more like what I need. [16:40:18] https://phabricator.wikimedia.org/T105173 is related to that. [16:43:13] http://parsoid-tests.wikimedia.org/visualdiff-item/pngs/enwiki/Hampi.diff.png is an example of a visual diff .. it compares parsoid's rendering with php parser's rendering, but it generalizes to any two html files .. but i am pretty sure that is not what you want. [16:43:16] ragesoss, ^ [16:43:45] it is more a tool for developers. [16:44:44] subbu aha! thanks. also, very neat though! [16:45:21] edsanders, Krenair, I think the 4xx errors are being lost somewhere in the VE -> VRS -> Restbase pipeline .... restbase hasn't logged any for the Pittsburgh 400 reports that ragesoss reports. [16:46:38] unless those html2wt reqs. did get all the way to parsoid. [16:47:46] ragesoss, can you send me the screenshot just in case the error report gives us a clue? [16:49:41] subbu: it's a terrible screenshot, but it's in your inbox. [16:50:07] thanks. [16:52:49] ragesoss, oh .. ok, so it is the generic 'something went wrong' message. [16:53:26] anyway, i think we need to fix error logging and reporting in the whole pipeline to track these down better [16:54:02] subbu: I thought I saw parsoid in the fuzz, but I may have imagined it, because I know I got another report from a student last week describing a 400 error with a parsoid message... which I'm pretty sure *was* the one that got fixed. [16:54:12] yes, they all say parsoid :) [16:54:19] :) [16:54:21] but, the problem is that it is misleading. [16:54:38] VE doesn't talk with parsoid directly anymore. [16:54:59] heh. so VE and parsoid are no longer on speaking terms. [16:55:01] interesting. [16:55:04] ;) [16:55:12] yes, we have intermediaries. [16:56:01] VE talks to a thin VRS layer which talks with RESTBase with talks with Prsoid [16:56:50] https://phabricator.wikimedia.org/T112330 [17:00:37] Anyway, you may not care about these details .. but RESTBase and Parsoid can both issue 4xx responses, but, that error report gets munged into the generic one (since human editors don't care about those internal details) but looks like the original report is lost somewhere. We are going to fix this in Parsoid to at least log the Parsoid-originated ones and ask RESTBase to do the same if they aren't already. [17:11:21] (03CR) 10Esanders: [C: 032] SurfaceObserver: use plain function call to Surface, instead of emit [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/239388 (https://phabricator.wikimedia.org/T108299) (owner: 10Divec) [17:12:24] (03PS2) 10Jforrester: DesktopArticleTarget: Fix page title (first H1) font size in Vector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/240118 (owner: 10Esanders) [17:13:15] (03CR) 10Jforrester: [C: 032] DesktopArticleTarget: Fix page title (first H1) font size in Vector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/240118 (owner: 10Esanders) [17:16:18] 10VisualEditor, 10Parsoid, 10RESTBase, 5Patch-For-Review: Change VisualEditor's error logging to not assume all VRS errors are Parsoid errors - https://phabricator.wikimedia.org/T112339#1663429 (10ssastry) In addition, it makes sense for the VE extension to log any 4xx errors it gets on the save / review w... [17:17:38] (03CR) 10jenkins-bot: [V: 04-1] SurfaceObserver: use plain function call to Surface, instead of emit [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/239388 (https://phabricator.wikimedia.org/T108299) (owner: 10Divec) [17:17:40] (03CR) 10jenkins-bot: [V: 04-1] Fix arrow key fixups for inline focusable node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/194409 (https://phabricator.wikimedia.org/T91518) (owner: 10Divec) [17:21:51] (03Merged) 10jenkins-bot: DesktopArticleTarget: Fix page title (first H1) font size in Vector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/240118 (owner: 10Esanders) [17:24:03] 10VisualEditor, 10VisualEditor-ContentEditable, 5WMF-deploy-2015-09-22_(1.26wmf24): Cursoring over an MWLinkNode takes you two characters to the right/left, not one - https://phabricator.wikimedia.org/T96307#1663468 (10Jdforrester-WMF) 5Open>3Resolved [17:25:35] 10VisualEditor, 10VisualEditor-ContentEditable, 5WMF-deploy-2015-09-22_(1.26wmf24): Cursoring over an MWLinkNode takes you two characters to the right/left, not one - https://phabricator.wikimedia.org/T96307#1214005 (10Jdforrester-WMF) 5Resolved>3Open [17:25:46] 10VisualEditor, 10VisualEditor-ContentEditable, 5WMF-deploy-2015-09-22_(1.26wmf24): Cursoring over an MWLinkNode takes you two characters to the right/left, not one - https://phabricator.wikimedia.org/T96307#1214005 (10Jdforrester-WMF) Belay that, now it's two in both directions. [17:26:01] (03CR) 10Jforrester: [C: 032] "…" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/239388 (https://phabricator.wikimedia.org/T108299) (owner: 10Divec) [17:30:10] * Elitre tries again... [17:31:55] Elitre: ? [17:31:59] I'm curious as to what "User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/45.0.2454.93 Safari/537.36" translates to - OS? Browser? [17:32:28] Elite Chrome 45 on Windows Vista. [17:32:37] (03CR) 10jenkins-bot: [V: 04-1] SurfaceObserver: use plain function call to Surface, instead of emit [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/239388 (https://phabricator.wikimedia.org/T108299) (owner: 10Divec) [17:32:39] (03CR) 10jenkins-bot: [V: 04-1] Fix arrow key fixups for inline focusable node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/194409 (https://phabricator.wikimedia.org/T91518) (owner: 10Divec) [17:32:42] Sorry, Windows 7. [17:33:40] ok, thanks! [17:33:53] Elitre: Or theoretically "Windows Server 2008 R2", but it's unlikely. [17:34:15] I'm guessing there's no way to display that info in a form that even I can understand? :) [17:35:34] (03CR) 10Jforrester: [C: 032] SurfaceObserver: use plain function call to Surface, instead of emit [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/239388 (https://phabricator.wikimedia.org/T108299) (owner: 10Divec) [17:36:35] Elitre: There's a tool that converts it, but searching Google will tell you in a second. :-) [17:36:56] ok, will GTFM next time. [17:37:00] :-) [17:41:50] (03CR) 10jenkins-bot: [V: 04-1] SurfaceObserver: use plain function call to Surface, instead of emit [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/239388 (https://phabricator.wikimedia.org/T108299) (owner: 10Divec) [17:41:52] (03CR) 10jenkins-bot: [V: 04-1] Fix arrow key fixups for inline focusable node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/194409 (https://phabricator.wikimedia.org/T91518) (owner: 10Divec) [17:42:05] Oy. [17:47:11] (03CR) 10Jforrester: [C: 032] SurfaceObserver: use plain function call to Surface, instead of emit [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/239388 (https://phabricator.wikimedia.org/T108299) (owner: 10Divec) [17:50:21] c u at the triage meeting later! [17:50:22] (03Merged) 10jenkins-bot: SurfaceObserver: use plain function call to Surface, instead of emit [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/239388 (https://phabricator.wikimedia.org/T108299) (owner: 10Divec) [17:52:54] (03CR) 10Jforrester: [C: 032] Inspector: Use upstream padding settings [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/240082 (owner: 10Esanders) [17:53:01] James_F: hey there! [17:53:10] juri_: Hey. [17:53:30] it looks to me like you neglected to apply that patch to REL1_25. [17:53:37] (03Merged) 10jenkins-bot: Inspector: Use upstream padding settings [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/240082 (owner: 10Esanders) [17:53:49] juri_: … no? [17:53:54] and, did you look at the install directions i wrote for debian 8? [17:54:19] juri_: https://git.wikimedia.org/log/mediawiki%2Fextensions%2FVisualEditor.git/refs%2Fheads%2FREL1_25 [17:55:21] um, yes? [17:55:42] 10VisualEditor, 10VisualEditor-ContentEditable, 5WMF-deploy-2015-09-29_(1.27.0-wmf.1): Can't select beyond inline focusable - https://phabricator.wikimedia.org/T108299#1663666 (10Jdforrester-WMF) 5Open>3Resolved [17:56:07] definately. [17:56:14] (03PS10) 10Jforrester: Fix arrow key fixups for inline focusable node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/194409 (https://phabricator.wikimedia.org/T91518) (owner: 10Divec) [17:56:20] (03CR) 10Jforrester: [C: 032] Fix arrow key fixups for inline focusable node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/194409 (https://phabricator.wikimedia.org/T91518) (owner: 10Divec) [17:56:52] the patch i'm requesting is against src/ce/ve.ce.Surface.js [17:58:44] (03CR) 10Jforrester: [WIP] Image uploading (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/240116 (owner: 10Esanders) [17:59:28] juri_: The top commit https://git.wikimedia.org/commit/mediawiki%2Fextensions%2FVisualEditor.git/be843138bb14271eaadec2c32ab2551cbeb59707 updates the submodule for that patch [17:59:54] juri_: You need to do `git submodule update` for the submodule once you've pulled REL1_25 for the VE-MW repo. [18:00:32] I've been changing into the directory for the submodule, and pulling REV1_25 there. [18:01:58] That's should be good enough, but it's much safer to go into the directory for VE-MW and pull REL1_25 for that too. [18:02:04] aha. [18:02:38] somehow i pulled REL1_25 before you updated the patch. [18:02:49] (03CR) 10jenkins-bot: [V: 04-1] Fix arrow key fixups for inline focusable node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/194409 (https://phabricator.wikimedia.org/T91518) (owner: 10Divec) [18:03:08] juri_: Ha. [18:03:13] juri_: That'd do it. ;-) [18:06:01] (03Merged) 10jenkins-bot: Fix arrow key fixups for inline focusable node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/194409 (https://phabricator.wikimedia.org/T91518) (owner: 10Divec) [18:09:33] 10VisualEditor, 10VisualEditor-ContentEditable, 5WMF-deploy-2015-09-29_(1.27.0-wmf.1): Unused and/or broken code in ce.Surface selection fixup - https://phabricator.wikimedia.org/T91518#1663694 (10Jdforrester-WMF) 5Open>3Resolved [18:09:45] 10VisualEditor, 10VisualEditor-ContentEditable, 5WMF-deploy-2015-09-29_(1.27.0-wmf.1): Selection fixup inside a focusable node is incorrect - https://phabricator.wikimedia.org/T113278#1663696 (10Jdforrester-WMF) 5Open>3Resolved [18:10:52] edsanders: https://gerrit.wikimedia.org/r/#/c/238331/ [18:21:04] 10VisualEditor, 10Parsoid, 5Patch-For-Review: In scrubWikitext mode, Parsoid should drop tags with no attributes - https://phabricator.wikimedia.org/T111151#1663736 (10ssastry) 5Open>3Resolved Will be deployed tomorrow / Monday the 28th. [18:26:26] (03PS2) 10Jforrester: ve.dm.Scalable: Get test coverage to 100% [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/238331 [18:28:35] (03CR) 10Jforrester: "Before, ve.dm.Scalable.js was:" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/238331 (owner: 10Jforrester) [18:29:59] edsanders: ^^^ and also https://gerrit.wikimedia.org/r/#/c/238607/ please? [18:30:28] (03CR) 10jenkins-bot: [V: 04-1] ve.dm.Scalable: Get test coverage to 100% [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/238331 (owner: 10Jforrester) [18:30:34] Meh. [18:30:53] (03PS3) 10Jforrester: ve.dm.Scalable: Get test coverage to 100% [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/238331 [18:34:47] (03CR) 10Esanders: [C: 04-1] ve.dm.Scalable: Get test coverage to 100% [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/238331 (owner: 10Jforrester) [18:36:55] (03CR) 10Esanders: ve.dm.Scalable: Get test coverage to 100% (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/238331 (owner: 10Jforrester) [18:53:14] 10VisualEditor: [Regression pre-wmf24] Save Page and Review changes dialogs are appearing much smaller in length - https://phabricator.wikimedia.org/T113388#1663847 (10Ryasmeen) 3NEW [18:58:48] 10VisualEditor: [Regression pre-wmf24] Save Page and Review changes dialogs are appearing much smaller in length - https://phabricator.wikimedia.org/T113388#1663868 (10Krenair) 5Open>3Invalid a:3Krenair https://gerrit.wikimedia.org/r/#/c/239879/ [18:59:27] 10VisualEditor: "selection.getMatrixCells is not a function" appears while saving a page when both Special Character inserter and table menu is open - https://phabricator.wikimedia.org/T113390#1663873 (10Ryasmeen) 3NEW [18:59:33] 10VisualEditor: [Regression pre-wmf24] Save Page and Review changes dialogs are appearing much smaller in length - https://phabricator.wikimedia.org/T113388#1663881 (10Jdforrester-WMF) Yeah, this is intentional, sorry; we now make the height appropriate to the content. [18:59:37] Krenair: Yay clash. :-) [19:00:14] (03PS4) 10Jforrester: ve.dm.Scalable: Get test coverage to 100% [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/238331 [19:00:18] :) [19:01:02] (03CR) 10Jforrester: ve.dm.Scalable: Get test coverage to 100% (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/238331 (owner: 10Jforrester) [19:05:58] (03CR) 10jenkins-bot: [V: 04-1] ve.dm.Scalable: Get test coverage to 100% [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/238331 (owner: 10Jforrester) [19:06:38] 10VisualEditor, 6Collaboration-Team-Backlog, 10Flow: Reconsider that typing ':' at the start of a paragraph in VisualEditor creates a
, not a
which is the wikitext equivalent - https://phabricator.wikimedia.org/T112690#1663924 (10Jdforrester-WMF) p:5Triage>3Low [19:07:22] 10VisualEditor: Cannot edit the last character in a link after creation - https://phabricator.wikimedia.org/T112883#1663928 (10Jdforrester-WMF) 5Open>3Resolved a:3Jdforrester-WMF I think this is now resolved in master? [19:09:11] 10VisualEditor, 10VisualEditor-MediaWiki-Links: [Regression wmf23] On creating an inter-wiki link, the nice regex strips section parts of the link - https://phabricator.wikimedia.org/T112898#1663938 (10Jdforrester-WMF) p:5Triage>3Normal [19:10:45] 10VisualEditor, 10VisualEditor-MediaWiki, 10RESTBase, 6Services: RESTBase wrongly refusing to serve revision if username is hidden (VE fails to load if latest edit has hidden username) - https://phabricator.wikimedia.org/T113117#1663957 (10Jdforrester-WMF) p:5Triage>3High [19:10:50] 10VisualEditor, 10VisualEditor-MediaWiki, 10RESTBase, 6Services: RESTBase wrongly refusing to serve revision if username is hidden (VE fails to load if latest edit has hidden username) - https://phabricator.wikimedia.org/T113117#1655376 (10Jdforrester-WMF) [19:11:56] 10VisualEditor, 7Browser-Support-Internet-Explorer: Cannot save some pages using IE11 - https://phabricator.wikimedia.org/T113163#1663977 (10Jdforrester-WMF) 5Open>3stalled Is this actually specific to IE11? Do the exact same edits work in other browsers? If so, can you identify what parts of the edit sudd... [19:19:23] 10VisualEditor, 10VisualEditor-MediaWiki-Links: [Regression wmf23] On creating an inter-wiki link, the nice regex strips section parts of the link - https://phabricator.wikimedia.org/T112898#1664021 (10cscott) How exactly was this link created? Pasting a URL? Using the link inspector tool? [19:27:29] 10VisualEditor, 10VisualEditor-MediaWiki-Links: [Regression wmf23] On creating an inter-wiki link, the nice regex strips section parts of the link - https://phabricator.wikimedia.org/T112898#1664043 (10Jdforrester-WMF) Open a VE editor, write a word hello, select it, apply a link with the value "`en:Foo#Bar`",... [19:27:51] (03CR) 10Jforrester: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/238331 (owner: 10Jforrester) [19:39:44] (03PS2) 10Esanders: [WIP] Image uploading [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/240116 (https://phabricator.wikimedia.org/T40030) [19:42:59] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Image uploading [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/240116 (https://phabricator.wikimedia.org/T40030) (owner: 10Esanders) [20:16:26] 10VisualEditor, 10Phlogiston, 3Discovery-Analysis-Sprint, 3Team-Practices-This-Week: Help requested from an R expert to help tweak phlogiston (burnup chart scripts) - https://phabricator.wikimedia.org/T110080#1568428 (10Deskana) @JAufrecht Thanks for the questions. I've reprioritised this now. Unfortunatel... [20:16:55] (03PS1) 10Jforrester: Update OOjs UI to v0.12.9 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/240172 [20:19:02] (03CR) 10Esanders: [C: 032] Update OOjs UI to v0.12.9 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/240172 (owner: 10Jforrester) [20:24:11] (03CR) 10jenkins-bot: [V: 04-1] Update OOjs UI to v0.12.9 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/240172 (owner: 10Jforrester) [20:25:23] (03Merged) 10jenkins-bot: Update OOjs UI to v0.12.9 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/240172 (owner: 10Jforrester) [21:02:04] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-extensions-GuidedTour, 7Design, and 3 others: Offer new users of VisualEditor a short guided tour - https://phabricator.wikimedia.org/T89074#1664383 (10Neil_P._Quinn_WMF) [21:02:07] 10VisualEditor: VisualEditor: Provide a GuidedTour for first-time VisualEditor users (ones for both newbies for and experienced editors?) - https://phabricator.wikimedia.org/T52601#1664384 (10Neil_P._Quinn_WMF) [21:02:09] 10VisualEditor, 6Design Research Backlog, 7Epic: Improve and streamline VisualEditor's user education features - https://phabricator.wikimedia.org/T101481#1664385 (10Neil_P._Quinn_WMF) [21:02:39] 10VisualEditor, 6Design Research Backlog, 7Epic: Improve and streamline VisualEditor's user education features - https://phabricator.wikimedia.org/T101481#1340043 (10Neil_P._Quinn_WMF) Whoops, sorry, meant to merge into T108620 instead. [21:02:59] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-extensions-GuidedTour, 7Design: Change Welcome dialog content to more helpful message to new users based on the GuidedTour - https://phabricator.wikimedia.org/T89072#1664392 (10Neil_P._Quinn_WMF) [21:03:02] 10VisualEditor, 6Design Research Backlog, 7Epic: Improve and streamline VisualEditor's user education features - https://phabricator.wikimedia.org/T101481#1664391 (10Neil_P._Quinn_WMF) [21:03:04] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-extensions-GuidedTour, 7Design, and 3 others: Offer new users of VisualEditor a short guided tour - https://phabricator.wikimedia.org/T89074#1664390 (10Neil_P._Quinn_WMF) 5duplicate>3Open [21:03:08] 10VisualEditor: VisualEditor: Provide a GuidedTour for first-time VisualEditor users (ones for both newbies for and experienced editors?) - https://phabricator.wikimedia.org/T52601#1664393 (10Neil_P._Quinn_WMF) 5duplicate>3Open [21:03:29] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-extensions-GuidedTour, 7Design, and 3 others: Offer new users of VisualEditor a short guided tour - https://phabricator.wikimedia.org/T89074#1026989 (10Neil_P._Quinn_WMF) [21:03:31] 10VisualEditor: VisualEditor: Provide a GuidedTour for first-time VisualEditor users (ones for both newbies for and experienced editors?) - https://phabricator.wikimedia.org/T52601#1664396 (10Neil_P._Quinn_WMF) [21:03:33] 10VisualEditor, 10VisualEditor-MediaWiki, 5Patch-For-Review: On user's first use of VE-MW, provide a couple of educational pop-ups for links and for citations with some toolbar highlights to trigger them - https://phabricator.wikimedia.org/T108620#1525119 (10Neil_P._Quinn_WMF) [21:06:27] 10VisualEditor, 6Design Research Backlog, 7Epic: Improve and streamline VisualEditor's user education features - https://phabricator.wikimedia.org/T101481#1664399 (10Neil_P._Quinn_WMF) 5Open>3declined This task is really a tracker without any clear purpose of its own; I'm going to go ahead and close it.... [21:06:59] 10VisualEditor, 10VisualEditor-MediaWiki-Links: [Regression wmf23] On creating an inter-wiki link, the nice regex strips section parts of the link - https://phabricator.wikimedia.org/T112898#1664404 (10cscott) In the link inspector, the url is *displayed* as "en:Foo#Bar" but mouseover reveals that target href... [21:11:30] 10VisualEditor, 10VisualEditor-MediaWiki-Links: [Regression wmf23] On creating an inter-wiki link, the nice regex strips section parts of the link - https://phabricator.wikimedia.org/T112898#1664410 (10cscott) FWIW, *pasting* the string `[[mw:Flow#Design FAQ]]` or `[[mw:Flow#Design FAQ|FAQ]]` works fine as a w... [21:20:26] 10VisualEditor, 7Browser-Support-Internet-Explorer: Cannot save some pages using IE11 - https://phabricator.wikimedia.org/T113163#1664437 (10TTO) 5stalled>3Open I can create new pages but not edit existing ones. It is specific to IE11 insofar as I can compare it with Firefox; I am not able to test other I... [21:20:40] 10VisualEditor, 7Browser-Support-Internet-Explorer: Cannot save existing pages using IE11 - https://phabricator.wikimedia.org/T113163#1664443 (10TTO) [22:08:54] (03PS4) 10Alex Monk: [WIP] Educational popups and highlights for links+citations [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/238380 (https://phabricator.wikimedia.org/T108620) [22:11:30] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Educational popups and highlights for links+citations [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/238380 (https://phabricator.wikimedia.org/T108620) (owner: 10Alex Monk) [22:16:03] (03PS5) 10Alex Monk: [WIP] Educational popups and highlights for links+citations [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/238380 (https://phabricator.wikimedia.org/T108620) [23:52:22] (03CR) 10Alex Monk: "Should I be using user_editcount here instead?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230949 (https://phabricator.wikimedia.org/T112352) (owner: 10Alex Monk)