[08:24:50] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/238380 (https://phabricator.wikimedia.org/T108620) (owner: 10Alex Monk) [08:25:51] Anyone here encountered an error of "out of memory out of memory" (the repeat is the original exception shown in FF console) during VE activation? [10:01:10] 10VisualEditor, 10VisualEditor-ContentEditable, 10MediaWiki-Gallery: Gallery popup should be stable - https://phabricator.wikimedia.org/T113837#1680217 (10Aklapper) [10:14:39] 10VisualEditor, 10VisualEditor-CopyPaste: Copy-paste of odd content into VE introduces tables with weird href attributes - https://phabricator.wikimedia.org/T108506#1680267 (10Aklapper) @Lfstevens, @Magioladitis : Can you reproduce the problem? [10:15:57] 10VisualEditor, 10Score, 7I18n, 7RTL: The element that show Lilypond errors in VisualEditor in English must English language and direction definition - https://phabricator.wikimedia.org/T113935#1680268 (10Amire80) 3NEW [11:11:32] (03CR) 10Alex Monk: "If instead we want to autodisable for users with any edits, maybe something like this:" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230949 (https://phabricator.wikimedia.org/T112352) (owner: 10Alex Monk) [11:12:10] (03CR) 10Alex Monk: "(Um... although that group by does look useless now)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230949 (https://phabricator.wikimedia.org/T112352) (owner: 10Alex Monk) [11:56:44] MatmaRex: can you review https://gerrit.wikimedia.org/r/#/c/226464/ ? [11:58:55] eranroz: hm, maybe. Cite is a bit scary though. [13:04:37] 10VisualEditor: Add support for spell checking in the TDEditor fields - https://phabricator.wikimedia.org/T113947#1680657 (10Sunpriat) 3NEW [13:05:29] 10VisualEditor: Add support for spell checking in the TDEditor fields - https://phabricator.wikimedia.org/T113947#1680664 (10Sunpriat) [13:53:10] 10TemplateData, 6Community-Liaison, 7Documentation: Update Help:TemplateData at mediawiki.org - https://phabricator.wikimedia.org/T94937#1680886 (10Aklapper) I've updated/overwritten the three screenshots on https://www.mediawiki.org/wiki/Help:TemplateData and the text about the UI in https://www.mediawiki.o... [14:48:27] Heya. [14:49:56] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-Templates: Add support for web browser's spell checking functionality in TemplateData editor fields - https://phabricator.wikimedia.org/T113947#1681018 (10Aklapper) [15:04:19] 10Cite, 10Parsoid, 5Patch-For-Review: Show an error if a named is defined multiple times - https://phabricator.wikimedia.org/T85386#1681056 (10ssastry) [15:06:41] 10Cite, 10Parsoid, 5Patch-For-Review: Show an error if a named is defined multiple times - https://phabricator.wikimedia.org/T85386#1681059 (10ssastry) This will need a similar fix in Parsoid after the core cite extension has this fixed. [15:49:00] edsanders|away: https://gerrit.wikimedia.org/r/#/c/241668/ [15:54:12] MatmaRex, if you do replacewith you loose the classnames [15:55:09] which classnames? (and, why do we have to change anything in that code, anyway?) i did not test it :) [15:56:07] oh wait, they get restored in setLabelElement [15:56:50] couldn't you override $label in config? [15:57:33] hmm, maybe [16:02:27] seems to work... [16:06:53] They're currently immutable for other reasons, but I can fix that later [16:31:20] 10VisualEditor, 10VisualEditor-MediaWiki, 10SyntaxHighlight: In SyntaxHighlight VE inspector, language dropdown opens automatically when the inspector is opened on a second node - https://phabricator.wikimedia.org/T112798#1681449 (10Krenair) a:5Krenair>3None [17:18:40] 10VisualEditor, 10VisualEditor-ContentEditable, 6Collaboration-Team-Backlog, 10Flow: VE displays multiple placeholders when editor only contains a single template - https://phabricator.wikimedia.org/T111107#1681744 (10DannyH) [17:41:17] edsanders: are you still here? any chance you could review https://gerrit.wikimedia.org/r/#/c/238998/ today? [17:43:22] MatmaRex: Didn't RoanKattouw +1 only because it was awaiting pull-through? Has it regressed? [17:43:46] dunno. presumably it still works. [17:43:53] ok [17:44:58] MatmaRex, so there are two calendars position directly on top of each other? [17:45:31] that seems super evil [17:45:35] yes! [17:45:36] and yes [17:45:49] even more evil that fixing up the focus [17:46:05] edsanders: no, fixing up the focus manually is eviller [17:46:18] the focus thing breaking seems much more palatable too [17:46:29] we already do it in dialogs [17:46:41] if we get that wrong it's no big deal [17:46:52] edsanders: no, we don't have the problem with any other dropdown things, because they can't have focus [17:47:06] when this goes wrong, we get rendering errors, confusing behaviour etc. [17:47:15] in all other cases the focus stays with the text input the dropdown is connected with, and the dropdown listens for events on the input [17:47:24] (I mean we fix up focus in dialogs, with the tab catcher) [17:47:26] but CalendarWidget listens to events on itself and can hold focus [17:48:08] edsanders: unless you're seeing something that i don't, fixing up the focus here is much more difficult [17:48:59] I think this will be more painful in the future [17:49:02] given that A is the text field and B is the dropdown, and B is inserted somewhere else in the document: moving focus from A to B on tab is easy, moving focus from B to next-focusable-after-A is nasty [17:49:33] we have all the methods for it [17:49:51] i'm pretty sure we don't [17:50:06] also could we onkeydown TAB [17:50:24] if we are in the last focusable of calendar, then move the focus back to the input before key up [17:50:25] yes, of course, but that doesn't help us in deciding where the focus should go after B [17:50:38] eugh. does that work? [17:50:57] let me see... [17:53:48] MatmaRex, yes: http://codepen.io/anon/pen/bVBONZ [17:54:40] hmmmm. [17:55:04] you could cache first/last focusable when the Calendar's DOM is updated [17:55:30] then it's just > if ( !shift && last || shift && first ) { move focus } [17:55:48] yeahhhh [17:56:39] I'm sure it's not perfect - but it I'm less concerned about minor screen reader bugs, than the issues the double rendering could throw up [18:07:23] 10VisualEditor, 10Wikimedia-Site-Requests: Re-enable VisualEditor by default for all logged-in users of the English Wikipedia, exempting some users - https://phabricator.wikimedia.org/T112348#1682037 (10Jdforrester-WMF) [18:08:54] edsanders: thanks, i'll work on that. in the meantime, want to see my version of https://gerrit.wikimedia.org/r/#/c/241082/ ? [18:14:16] 10VisualEditor, 10Wikimedia-Site-Requests: Re-enable VisualEditor by default for logged-in users on the English Wikipedia, exempting anyone who's ever edited - https://phabricator.wikimedia.org/T112348#1682059 (10Jdforrester-WMF) [18:19:54] sure? [18:20:30] oh you amended [18:22:17] we should separate the theme styles at some point, and provide apex like for monobook... [18:23:45] I'm not sure I agree that the calendar should take the outline [18:24:43] tough one [18:25:47] I think when you interact with the popup you aren't blurring the calendar widget [18:25:53] edsanders: i filed a bug about the separate theme thing [18:25:55] as when the calendar is blurred the popup is not visible [18:26:27] https://phabricator.wikimedia.org/T112747 [18:26:33] the same happens with autocomplete - cursoring around an autocomplete list doesn't remove :focus from the input [18:27:01] edsanders: but there it does, no? (are you looking at the code, or at the working widget? because it is confusing) [18:27:07] but here it does* [18:27:36] just because technically the browser takes focus away - I don't think it does in the user's model of how the widget works [18:27:53] the popup is just an advanced auto-complete [18:28:43] http://i.imgur.com/A99nppw.png / http://i.imgur.com/wDAZY9W.png [18:28:54] these are the two flavors of focus you get now [18:29:16] in the first, only the text field has focus, and the calendar autoupdates to match it; in the second, only calendar has focus, and the text field autoupdates to match it [18:29:47] perhaps allowing the calendar to hold focus was a bad decision, but that's how it currently works [18:30:25] I think it's fine for the calendar to have focus [18:31:14] in the user model (and DOM) the calendar is a child of the dateInput, that extends beyond the borders [18:31:36] whenever the dateinput is (focused) it should have a blue outline [18:31:49] the calendar widget is not an input so should never have a blue outline [18:32:30] we will need another way to show the focus being on a particular day as currently that behaves no differently [18:33:49] the blue outline staying on the date tells the user they are still inputting this field, and not some new field that just appeared [18:35:25] eh [18:35:51] edsanders: are you saying that what you really liked was the previous design, which you're changing? because that's what i see you saying… [18:36:00] no [18:36:08] oh wait, you want the inverse [18:36:10] the previous design outlined the calendar as well [18:36:27] only text inputs have blue insets [18:36:56] I think the blue inset should stay visible when either the date or calendar is focused [18:37:09] blue inset on text field? [18:37:16] when the calendar is focused, the selected day should get some additional styling [18:37:18] yes [18:37:35] implementing that is sure going to suck [18:37:57] :) [18:38:39] so this comes back to the fact we give focus to the calendar widget right [18:39:03] because we need to handle left/right key events differently [18:39:14] edsanders: so, again, you want this: when text field has focus, text field has blue inset. when calendar has focus, STILL only the text field has blue inset. right? [18:39:34] yeah [18:39:37] hmm. [18:39:56] which is basically how ComboBox behaves [18:40:17] i dunno, i think there should be some difference (other than the blinking cursor, i guess). trying to type while focus is on the calendar will not work. [18:41:03] yeah - the focus within the calendar widget should be highlighted (not with a blue inset though) [18:41:17] hmm. alright [18:42:27] jQueryUI lol: https://jqueryui.com/datepicker/ [18:42:45] yeah, theirs is super-simple [18:43:14] pressing TAB momentarily focuses the calendar, then closes it [18:43:16] although most of our problems come from the fact that i decided to make the calendar focusable [18:44:09] I think it's useful [18:46:26] edsanders: okay, so in my opinion, what you're saying makes sense, but is blocked on a) faking focus on a TextInputWidget and b) design for focus on the calendar. my current version of your solution is not as thought out, but it works fairly well and works now. can we merge it, and keep the task open? [18:46:48] WFM. [18:47:30] (https://gerrit.wikimedia.org/r/#/c/241082/ is better than master both in code quality and in design, IMO) [18:48:03] merge and fixup? [18:48:40] fixup what? [18:51:08] you want me to merge 241082 and you fix it up later? [18:52:57] edsanders: i guess, yes [18:53:46] edsanders: if you accept that "later" is "within next month or so". it's not exactly exciting work and i have other things waiting. personally, i find the state after 241082 satisfactory (although i also find the state before 241082 satisfactory) [18:59:09] (03CR) 10Divec: [C: 04-1] "I need to get my head round the use of getNearestContentOffset when getting the annotations for the first character of a range." (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/241555 (owner: 10Divec) [19:59:29] RoanKattouw: Can I get review (and ideally merge) from you on https://gerrit.wikimedia.org/r/#/c/230949/ today? :-) [20:01:24] (03CR) 10Jforrester: [C: 031] Move cursor offset calc from CE Surface to DM Document [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/241510 (owner: 10Divec) [20:04:31] (03CR) 10Catrope: [C: 04-1] "Yes, please use user_editcount instead. That allows you to get rid of the join on revision, the GROUP BY, and the COUNT(*). That should ma" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230949 (https://phabricator.wikimedia.org/T112352) (owner: 10Alex Monk) [20:06:12] (03CR) 10Jforrester: "I guess we can simplify the query still further if there's no time requirement? (Make it optional, and if not passed, use 'ever')?" (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230949 (https://phabricator.wikimedia.org/T112352) (owner: 10Alex Monk) [20:06:19] RoanKattouw: Thanks. [20:08:28] (03CR) 10Catrope: "Oh right, you can't actually get rid of the join or the group by as long as the condition on MAX(rev_timestamp) is there, good point." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230949 (https://phabricator.wikimedia.org/T112352) (owner: 10Alex Monk) [20:08:38] :-) [20:12:42] 10VisualEditor, 10VisualEditor-MediaWiki: Re-add cancel button to desktop VE-MW toolbar - https://phabricator.wikimedia.org/T106295#1682539 (10Isarra) >>! In T106295#1470512, @matmarex wrote: > I like this idea from @Whatamidoing-WMF's T85470: > >> However, what about an escape clause under the Help menu, or... [20:22:14] (03CR) 10Jforrester: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/241229 (https://phabricator.wikimedia.org/T101169) (owner: 10Esanders) [20:49:51] 10VisualEditor, 10VisualEditor-Performance, 10MediaWiki-General-or-Unknown, 10MediaWiki-Interface, and 9 others: Use Parsoid HTML for read-only views too - https://phabricator.wikimedia.org/T55784#1682727 (10GWicke) [20:51:08] 10VisualEditor, 10VisualEditor-Performance, 10MediaWiki-General-or-Unknown, 10MediaWiki-Interface, and 9 others: Use Parsoid HTML for all page views - https://phabricator.wikimedia.org/T55784#1682736 (10GWicke) [20:54:28] 10VisualEditor, 10VisualEditor-Performance, 10MediaWiki-General-or-Unknown, 10MediaWiki-Interface, and 9 others: Use Parsoid HTML for all page views - https://phabricator.wikimedia.org/T55784#1682762 (10GWicke) [21:00:46] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 6Design Research Backlog, 7Design, and 2 others: Agree a new overall design for VisualEditor on mobile phone-sized devices - https://phabricator.wikimedia.org/T93325#1682789 (10Jdforrester-WMF) Talked with Nirzar and we agreed that the different toolbars on... [21:04:48] 10VisualEditor, 10VisualEditor-Performance, 10MediaWiki-General-or-Unknown, 10MediaWiki-Interface, and 9 others: Use Parsoid HTML for all page views - https://phabricator.wikimedia.org/T55784#1682814 (10cscott) FWIW, I did get some informal agreement that using Parsoid HTML for "Printable page" views was a... [21:07:19] (03CR) 10Jforrester: [C: 032] MWLinkAnnotationInspector: Use TitleSearchWidget instead of TitleInputWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/241229 (https://phabricator.wikimedia.org/T101169) (owner: 10Esanders) [21:10:03] 10VisualEditor, 10VisualEditor-Performance, 10MediaWiki-General-or-Unknown, 10MediaWiki-Interface, and 9 others: Use Parsoid HTML for all page views - https://phabricator.wikimedia.org/T55784#1682837 (10GWicke) [21:10:56] (03Merged) 10jenkins-bot: MWLinkAnnotationInspector: Use TitleSearchWidget instead of TitleInputWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/241229 (https://phabricator.wikimedia.org/T101169) (owner: 10Esanders) [21:11:03] 10VisualEditor, 10VisualEditor-Performance, 10MediaWiki-General-or-Unknown, 10MediaWiki-Interface, and 10 others: Use Parsoid HTML for all page views - https://phabricator.wikimedia.org/T55784#554184 (10GWicke) [21:36:39] (03PS14) 10Alex Monk: Autodisable preference [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230949 (https://phabricator.wikimedia.org/T112352) [21:39:31] (03CR) 10jenkins-bot: [V: 04-1] Autodisable preference [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230949 (https://phabricator.wikimedia.org/T112352) (owner: 10Alex Monk) [21:42:31] (03CR) 10Alex Monk: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230949 (https://phabricator.wikimedia.org/T112352) (owner: 10Alex Monk) [22:02:21] edsanders: We've lost the redirect/disambig/Wikidata description stuff from the link inspector with your change, BTW; forgot to ask if there's a follow-up coming with the replacement? [22:14:41] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Links: If using the link tool near the bottom of the screen such that a reasonable number of suggestions can't be shown, scroll the editor up until there can be - https://phabricator.wikimedia.org/T105418#1683165 (10Jdforrester-WMF) Done in h... [22:14:54] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Links, 5WMF-deploy-2015-09-29_(1.27.0-wmf.1): If using the link tool near the bottom of the screen such that a reasonable number of suggestions can't be shown, scroll the editor up until the... - https://phabricator.wikimedia.org/T105418#1683166 [22:15:11] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 10VisualEditor-MediaWiki-Mobile, 6Editing-Department, 6WMF-Design-Research: Sometimes in mobile, link suggestions open up in the wrong place, off to the side and not attached to the text box - https://phabricator.wikimedia.org/T113643#1683173 (10Jdforrester-... [22:15:15] 10VisualEditor, 7Design, 5WMF-deploy-2015-09-29_(1.27.0-wmf.1): [Usability] Convert the pop-over suggestions list to be an embedded search widget in the link inspector - https://phabricator.wikimedia.org/T101169#1683170 (10Jdforrester-WMF) 5Open>3Resolved a:3Esanders [22:15:19] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 6Editing-Department, 6WMF-Design-Research: In mobile, link suggestions only show on focus, go away when you close the keyboard (e.g. to see more of them) - https://phabricator.wikimedia.org/T113636#1683174 (10Jdforrester-WMF) [22:19:23] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 6Design Research Backlog: Mobile user testing tracking bug - https://phabricator.wikimedia.org/T113755#1683227 (10Jdforrester-WMF) [22:21:44] (03PS1) 10Siebrand: Update mediawiki-codesniffer and parallel-lint settings [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/241924 [22:22:48] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 6Design Research Backlog: Mobile user testing tracking bug - https://phabricator.wikimedia.org/T113755#1683249 (10Jdforrester-WMF) [22:22:49] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 6Editing-Department, 6WMF-Design-Research, 5WMF-deploy-2015-09-29_(1.27.0-wmf.1): In mobile, link suggestions only show on focus, go away when you close the keyboard (e.g. to see more of them) - https://phabricator.wikimedia.org/T113636#1683245 (10Jdforrest... [22:23:33] (03PS1) 10Siebrand: Update mediawiki-codesniffer and parallel-lint settings [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/241927 [22:23:43] (03CR) 10jenkins-bot: [V: 04-1] Update mediawiki-codesniffer and parallel-lint settings [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/241924 (owner: 10Siebrand) [22:24:58] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 6Design Research Backlog: Mobile user testing tracking bug - https://phabricator.wikimedia.org/T113755#1683267 (10Jdforrester-WMF) 5Open>3Resolved Provisionally closing until further bugs come up. [22:25:28] (03PS1) 10Siebrand: Update mediawiki-codesniffer and parallel-lint settings [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/241932 [22:26:25] (03CR) 10jenkins-bot: [V: 04-1] Update mediawiki-codesniffer and parallel-lint settings [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/241927 (owner: 10Siebrand) [22:26:58] (03CR) 10jenkins-bot: [V: 04-1] Update mediawiki-codesniffer and parallel-lint settings [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/241932 (owner: 10Siebrand) [22:30:22] 10VisualEditor, 10VisualEditor-MediaWiki-Links: Move buttons in the link editor away from underneath the input, as they're hidden by the pop-over suggestions - https://phabricator.wikimedia.org/T71690#1683292 (10Jdforrester-WMF) 5Open>3Resolved a:3Jdforrester-WMF They're now moved down. [22:30:32] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 5WMF-deploy-2015-09-29_(1.27.0-wmf.1): Move buttons in the link editor away from underneath the input, as they're hidden by the pop-over suggestions - https://phabricator.wikimedia.org/T71690#1683295 (10Jdforrester-WMF) a:5Jdforrester-WMF>3Esanders [22:45:00] (03CR) 10Jforrester: [C: 04-1] Autodisable preference (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230949 (https://phabricator.wikimedia.org/T112352) (owner: 10Alex Monk) [22:49:16] (03PS2) 10Siebrand: Update mediawiki-codesniffer and parallel-lint settings [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/241924 [22:50:28] (03CR) 10Jforrester: [C: 04-1] Update mediawiki-codesniffer and parallel-lint settings (031 comment) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/241924 (owner: 10Siebrand) [22:51:13] (03CR) 10jenkins-bot: [V: 04-1] Update mediawiki-codesniffer and parallel-lint settings [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/241924 (owner: 10Siebrand) [22:51:18] (03CR) 10Siebrand: Update mediawiki-codesniffer and parallel-lint settings (031 comment) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/241924 (owner: 10Siebrand) [22:51:44] (03CR) 10Jforrester: Update mediawiki-codesniffer and parallel-lint settings (031 comment) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/241924 (owner: 10Siebrand) [22:52:54] (03PS3) 10Siebrand: Update mediawiki-codesniffer and parallel-lint settings [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/241924 [22:53:38] (03CR) 10Jforrester: [C: 032] "Thanks!" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/241924 (owner: 10Siebrand) [22:56:24] (03PS4) 10Siebrand: Update mediawiki-codesniffer and parallel-lint settings [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/241924 [22:56:48] (03CR) 10Jforrester: [C: 031] "Answered directly. LGTM. Not tested." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230949 (https://phabricator.wikimedia.org/T112352) (owner: 10Alex Monk) [22:58:31] (03PS2) 10Siebrand: Update mediawiki-codesniffer and parallel-lint settings [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/241927 [23:03:12] (03PS1) 10Siebrand: Update mediawiki-codesniffer and parallel-lint settings [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/241955 [23:03:26] (03CR) 10Jforrester: [C: 032] Update mediawiki-codesniffer and parallel-lint settings [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/241927 (owner: 10Siebrand) [23:03:32] (03PS1) 10Siebrand: Update mediawiki-codesniffer and parallel-lint settings [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/241956 [23:03:51] (03PS3) 10Jforrester: build: Update mediawiki-codesniffer and parallel-lint settings [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/241927 (owner: 10Siebrand) [23:04:39] (03CR) 10Paladox: [C: 031] Update mediawiki-codesniffer and parallel-lint settings [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/241956 (owner: 10Siebrand) [23:07:31] (03PS2) 10Siebrand: Update mediawiki-codesniffer and parallel-lint settings [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/241955 [23:09:44] (03PS4) 10Jforrester: build: Update mediawiki-codesniffer from 0.3.0 to 0.4.0 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/241927 (owner: 10Siebrand) [23:09:52] (03CR) 10Jforrester: [C: 032] build: Update mediawiki-codesniffer from 0.3.0 to 0.4.0 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/241927 (owner: 10Siebrand) [23:10:30] (03CR) 10Alex Monk: Autodisable preference (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230949 (https://phabricator.wikimedia.org/T112352) (owner: 10Alex Monk) [23:11:04] (03PS3) 10Jforrester: build: Alter settings to force utf-8 and allow .php5/.inc extensions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/241955 (owner: 10Siebrand) [23:11:08] (03PS4) 10Jforrester: build: Alter settings to force utf-8 and allow .php5/.inc extensions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/241955 (owner: 10Siebrand) [23:11:19] (03CR) 10Jforrester: build: Alter settings to force utf-8 and allow .php5/.inc extensions (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/241955 (owner: 10Siebrand) [23:11:31] (03CR) 10Jforrester: [C: 031] "See comment on PS2 though." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/241955 (owner: 10Siebrand) [23:18:39] (03CR) 10Krinkle: [C: 04-1] "Should this allow page names that are valid transclusion targets outside the Template namespace? E.g. ":Foo" (ns=0), or "User:Foo"? And th" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/239184 (https://phabricator.wikimedia.org/T88900) (owner: 10Jforrester) [23:19:23] (03Merged) 10jenkins-bot: build: Update mediawiki-codesniffer from 0.3.0 to 0.4.0 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/241927 (owner: 10Siebrand) [23:20:42] (03CR) 10Krinkle: "The task has only 1 comment (mine) which asks for a use case. This has not been answered." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/239184 (https://phabricator.wikimedia.org/T88900) (owner: 10Jforrester) [23:23:26] (03PS2) 10Krinkle: Add a url type for URLs [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/239185 (https://phabricator.wikimedia.org/T54880) (owner: 10Jforrester) [23:24:35] (03CR) 10Krinkle: [C: 031] Add a url type for URLs [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/239185 (https://phabricator.wikimedia.org/T54880) (owner: 10Jforrester) [23:25:16] (03CR) 10Jforrester: [C: 031] "Changes look OK to me." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/239185 (https://phabricator.wikimedia.org/T54880) (owner: 10Jforrester) [23:27:23] (03CR) 10Catrope: [C: 04-1] "Looks good, one thing inline" (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230949 (https://phabricator.wikimedia.org/T112352) (owner: 10Alex Monk) [23:27:41] (03CR) 10Jforrester: "> Should this allow page names that are valid transclusion targets outside the Template namespace? E.g. ":Foo" (ns=0), or "User:Foo"? And " [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/239184 (https://phabricator.wikimedia.org/T88900) (owner: 10Jforrester) [23:30:57] (03PS15) 10Alex Monk: Autodisable preference [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230949 (https://phabricator.wikimedia.org/T112352) [23:37:41] (03CR) 10Catrope: [C: 032] Autodisable preference [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230949 (https://phabricator.wikimedia.org/T112352) (owner: 10Alex Monk) [23:37:50] Gosh. [23:37:52] Thanks, RoanKattouw. [23:39:03] (03PS1) 10Siebrand: Update mediawiki-codesniffer and parallel-lint settings [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/241999 [23:41:28] 10VisualEditor, 10VisualEditor-MediaWiki, 5WMF-deploy-2015-09-29_(1.27.0-wmf.1): Be able to auto-disable VisualEditor whilst in Beta Feature state for some users before switching to default state - https://phabricator.wikimedia.org/T112352#1683579 (10Jdforrester-WMF) 5Open>3Resolved [23:41:29] 10VisualEditor, 10Wikimedia-Site-Requests: Re-enable VisualEditor by default for logged-in users on the English Wikipedia, exempting anyone who's ever edited - https://phabricator.wikimedia.org/T112348#1683581 (10Jdforrester-WMF) [23:47:03] (03Merged) 10jenkins-bot: Autodisable preference [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/230949 (https://phabricator.wikimedia.org/T112352) (owner: 10Alex Monk) [23:49:51] (03PS5) 10Jforrester: build: Update mediawiki-codesniffer from 0.3.0 to 0.4.0 [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/241924 (owner: 10Siebrand) [23:49:57] (03CR) 10Jforrester: [C: 032] build: Update mediawiki-codesniffer from 0.3.0 to 0.4.0 [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/241924 (owner: 10Siebrand) [23:53:22] 10VisualEditor: VE crashes after opening Link inspector in the same position after deleting link - https://phabricator.wikimedia.org/T114064#1683612 (10Ryasmeen) 3NEW [23:53:39] (03Merged) 10jenkins-bot: build: Update mediawiki-codesniffer from 0.3.0 to 0.4.0 [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/241924 (owner: 10Siebrand) [23:56:23] (03Abandoned) 10Siebrand: Update mediawiki-codesniffer and parallel-lint settings [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/241932 (owner: 10Siebrand)