[00:03:07] RoanKattouw, hmm... Now that I think about it, weren't the BetaFeatures prefs separate somehow? [00:03:36] like it doesn't use the ordinary prefs we all test against in dev? [00:04:05] Huh? [00:04:14] If that's true I don't know anything about it [00:05:18] Our onGetPreferences hook actually doesn't set up the visualeditor-enable pref if you have BetaFeatures installed [00:05:58] Yeah, because instead BF does it magically. [00:06:45] autodisable preference was set up so that if you go and explicitly enable VE, you are no longer marked as autodisable [00:07:16] I don't think that's going to work on wikis with BetaFeatures installed? [00:07:43] VE won't use BF once we've done this change, though. [00:08:09] VE via BF -- { run script} -- { switch to default on } --> VE via regular preferences with autodisable. [00:08:26] visualeditor-betatempdisable [00:08:28] Or whatever. [00:09:57] So once we've set up the autodisable preference, we're going to pull BetaFeatures support out of VE? [00:10:00] Ahm, I think we might have broken something [00:10:06] ryasmeen says she doesn't get the VE tab in beta labs any more [00:10:51] I do... [00:11:29] Hmm I still see it [00:11:45] She does have the beta feature pref enabled [00:20:02] autodisable is true for her somehow [00:20:55] But it's false for me [00:21:04] * RoanKattouw looks at which users have autodisable=1 in enwiki beta [00:21:41] oh, yeah [00:21:48] I might have run it in beta at some point [00:22:03] would've been based on edit count and last edit timestam [00:22:05] timestamp* [00:22:33] Aaaah OK [00:22:41] That's why such a random set of users has this pref [00:22:49] The problem is though, ryasmeen already had enable=1 [00:22:51] And still does [00:22:59] So how is she supposed to unset autodisable now? [00:23:01] Opt out and back in? [00:23:15] there's betafeatures right? so I don't think she can [00:23:30] ? [00:23:32] Wait, but [00:23:37] We also have betafeatures in production [00:23:43] So how is this not going to break prod in 3 days? [00:23:48] I guess we just don't run the script? [00:24:10] Also all but one affected users have /high/ edit counts [00:24:30] James said we're getting rid of BF support from VE once the switch is flipped. [00:24:31] https://gist.github.com/catrope/d8cbe4d88dc4a7aa38ee [00:24:47] OK but in the meantime stuff does need to keep working [00:25:04] dunno why petrb was there [00:25:31] Krenair: Not support, just config for enwiki. [00:25:39] And yes, it still needs to not break. [00:25:48] Well anyway [00:26:06] James_F, okay, well, then we need to revert this change go and alter BetaFeatures so we can make the trick work there too. [00:26:23] Revert or just extend? [00:26:58] What I don't understand though [00:27:13] is 1) why accounts with -enable=1 had autodisable=1 set [00:27:31] did they have -enable=1 at the time? [00:27:34] When did you run the script? Presumably not the current version. :-) [00:27:39] 2) why the hook that sets autodisable=0 when enable=1 is set wouldn't work for BF [00:27:44] I don't remember [00:27:44] Oh yeah maybe you ran an old version of the script [00:27:51] Obviously it was an old version [00:27:51] But I'm pretty sure she's had -enable=1 for a long time [00:29:06] why don't you just drop those autodisable entries from beta and re-run it? [00:30:25] James_F, so what's your plan for BF config on enwiki? [00:30:56] * Announce [00:31:02] * Start the script to add the new preference to the 8m users that get it. [00:31:10] * Wait (days/weeks) for script to finish [00:31:18] * When complete, change the 'default' state from BF to opt-out. [00:31:20] * Announce complete. [00:32:06] Krenair: … [00:32:12] Krenair: Shouldn't the code be fiddling with visualeditor-betatempdisable ? [00:32:43] visualeditor-enable is the site-config in opt-out mode, not the user preference. [00:40:16] James_F, I don't even remember what that preference does or how you set it [00:40:38] I guess it just prevents visualeditor-enable from having any effect [00:41:34] (03PS1) 10Alex Monk: Revert "Autodisable preference" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/242022 [00:43:20] 10VisualEditor, 10VisualEditor-MediaWiki, 5WMF-deploy-2015-09-29_(1.27.0-wmf.1): Be able to auto-disable VisualEditor whilst in Beta Feature state for some users before switching to default state - https://phabricator.wikimedia.org/T112352#1683714 (10Krenair) 5Resolved>3Open Some of that code isn't going... [00:43:21] 10VisualEditor, 10Wikimedia-Site-Requests: Re-enable VisualEditor by default for logged-in users on the English Wikipedia, exempting anyone who's ever edited - https://phabricator.wikimedia.org/T112348#1683716 (10Krenair) [01:21:29] (03PS1) 10Catrope: Update autodisable logic [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/242033 [01:23:24] (03CR) 10Jforrester: [C: 032] Update autodisable logic [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/242033 (owner: 10Catrope) [01:26:26] (03CR) 10jenkins-bot: [V: 04-1] Update autodisable logic [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/242033 (owner: 10Catrope) [01:27:37] (03CR) 10Jforrester: [C: 032] Update autodisable logic [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/242033 (owner: 10Catrope) [01:27:39] (03CR) 10Catrope: [C: 032] Update autodisable logic [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/242033 (owner: 10Catrope) [01:30:10] (03Merged) 10jenkins-bot: Update autodisable logic [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/242033 (owner: 10Catrope) [01:39:05] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/242037/ [01:58:03] Krenair: From my testing it now appears OK. [02:06:27] 10VisualEditor, 10Wikimedia-Site-Requests, 5Patch-For-Review: Re-enable VisualEditor by default for logged-in users on the English Wikipedia, exempting anyone who's ever edited - https://phabricator.wikimedia.org/T112348#1683823 (10Jdforrester-WMF) [02:06:28] 10VisualEditor, 10VisualEditor-MediaWiki, 5WMF-deploy-2015-09-29_(1.27.0-wmf.1): Be able to auto-disable VisualEditor whilst in Beta Feature state for some users before switching to default state - https://phabricator.wikimedia.org/T112352#1683821 (10Jdforrester-WMF) 5Open>3Resolved >>! In T112352#168371... [02:14:05] (03Abandoned) 10Jforrester: Revert "Autodisable preference" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/242022 (owner: 10Alex Monk) [02:37:32] (03PS1) 10Catrope: MWInlineExtensionNode: Don't assume responses are always

-wrapper [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/242049 [03:02:53] 10VisualEditor: Cannot resubmit save page form after error - https://phabricator.wikimedia.org/T113874#1683847 (10Jdforrester-WMF) > After an error occurs when you try to submit the "save page" dialog, a red message appears. When I dismiss that message, the "Save page" button in the dialog box remains grayed out... [03:02:59] 10VisualEditor, 10VisualEditor-MediaWiki: Cannot resubmit save page form after error - https://phabricator.wikimedia.org/T113874#1683848 (10Jdforrester-WMF) [03:03:32] 10VisualEditor, 10Score, 7I18n, 7RTL: The element that show Lilypond errors in VisualEditor in English must English language and direction definition - https://phabricator.wikimedia.org/T113935#1683854 (10Jdforrester-WMF) p:5Triage>3Low [03:03:59] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-ContentLanguage, 5Patch-For-Review: Firefox: Annotation boundary sidedness failure using IMEs - https://phabricator.wikimedia.org/T113875#1678996 (10Jdforrester-WMF) [07:28:13] 10Cite, 10MediaWiki-General-or-Unknown, 5Patch-For-Review: Style for print is not applied at printable version - https://phabricator.wikimedia.org/T93746#1684032 (10Fomafix) 5Open>3Resolved a:3Fomafix The print styles get now applied on the printable version. The backlinks are hidden on the printable v... [07:34:45] 10Citoid, 6Community-Tech, 10Possible-Tech-Projects: Add wikitext support for citoid for automatic reference insertion - https://phabricator.wikimedia.org/T94223#1684049 (10Anmolkalia) Hi. I would like to contribute to this in the upcoming round of Outreachy and hence I would like to understand more about ba... [08:23:24] 10Cite, 10MediaWiki-Parser, 10MediaWiki-extensions-ContentTranslation, 5ContentTranslation-Release6, 5ContentTranslation-Release7: ContentTranslation created a reference that renders as UNIQ--nowiki-00000007-QINU at [[Google Cardboard]] in he.wikipedia - https://phabricator.wikimedia.org/T107303#1684085 (... [08:23:34] 10Cite, 10MediaWiki-Parser, 10MediaWiki-extensions-ContentTranslation, 5ContentTranslation-Release7: ContentTranslation created a reference that renders as UNIQ--nowiki-00000007-QINU at [[Google Cardboard]] in he.wikipedia - https://phabricator.wikimedia.org/T107303#1684087 (10Amire80) [08:25:32] 10Cite, 10MediaWiki-Parser, 10MediaWiki-extensions-ContentTranslation, 5ContentTranslation-Release7: ContentTranslation created a reference that renders as UNIQ--nowiki-00000007-QINU at [[Google Cardboard]] in he.wikipedia - https://phabricator.wikimedia.org/T107303#1491939 (10Amire80) [08:26:00] 10Cite, 10MediaWiki-Parser, 10MediaWiki-extensions-ContentTranslation, 5ContentTranslation-Release7: ContentTranslation creates references that render themselves as UNIQ--nowiki-00000007-QINU - https://phabricator.wikimedia.org/T107303#1684090 (10Amire80) [08:48:12] 10VisualEditor: Auto-numbered links used as references are invisible - https://phabricator.wikimedia.org/T114085#1684121 (10Elitre) 3NEW [08:56:21] 10VisualEditor, 7Parsoid-Nowiki: VE/Parsoid add with spaces in the beginning of a paragraph after a single line break - https://phabricator.wikimedia.org/T114087#1684143 (10Amire80) 3NEW [08:57:49] 10VisualEditor, 10Parsoid, 7Parsoid-Nowiki: VE/Parsoid add with spaces in the beginning of a paragraph after a single line break - https://phabricator.wikimedia.org/T114087#1684160 (10Amire80) [09:00:52] 10VisualEditor: Auto-numbered links used as references are invisible - https://phabricator.wikimedia.org/T114085#1684164 (10Elitre) [09:17:32] 10Citoid, 6Community-Tech, 10Possible-Tech-Projects: Add wikitext support for citoid for automatic reference insertion - https://phabricator.wikimedia.org/T94223#1684182 (10Mvolz) Primarily PHP && Javascript. But a necessary precondition is also another mentor for this project since it only has one and every... [09:21:38] 10Citoid, 6Community-Tech, 10Possible-Tech-Projects: Add wikitext support for citoid for automatic reference insertion - https://phabricator.wikimedia.org/T94223#1684189 (10Mvolz) >>! In T94223#1280486, @kaldari wrote: > Would this include creating a citation template editing interface (similar to RefToolbar... [09:24:00] 10Citoid, 6Community-Tech, 10Possible-Tech-Projects: Add wikitext support for citoid for automatic reference insertion - https://phabricator.wikimedia.org/T94223#1157891 (10Qgil) [09:28:00] 10Citoid, 6Community-Tech, 10Possible-Tech-Projects: Add wikitext support for citoid for automatic reference insertion - https://phabricator.wikimedia.org/T94223#1684220 (10Qgil) Maybe @SalixAlba would be interested in co-mentoring? With such team of competent mentors, the workload for each of you should be... [09:33:04] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki-References: Odd ref names being added by VisualEditor - https://phabricator.wikimedia.org/T94712#1684252 (10Trizek-WMF) The user does not replicate the bug ([[https://fr.wikipedia.org/w/index.php?title=Utilisateur%3AElitre_%28WMF%29%2FBrouill... [09:59:24] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/239185 (https://phabricator.wikimedia.org/T54880) (owner: 10Jforrester) [11:19:32] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 6Design Research Backlog, 7Design, and 2 others: Agree a new overall design for VisualEditor on mobile phone-sized devices - https://phabricator.wikimedia.org/T93325#1684534 (10Florian) @Jdforrester-WMF: Is Undo really something we need in mobile? There is n... [11:52:07] 10Citoid, 6Community-Tech, 10Possible-Tech-Projects: Add wikitext support for citoid for automatic reference insertion - https://phabricator.wikimedia.org/T94223#1684590 (10SalixAlba) Adding this as a cross-wiki reference mechanism depends quite a lot on how references are done on other non-English wikis. I... [12:40:35] (03CR) 10Esanders: [C: 032] MWInlineExtensionNode: Don't assume responses are always

-wrapper [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/242049 (owner: 10Catrope) [12:43:38] (03Merged) 10jenkins-bot: MWInlineExtensionNode: Don't assume responses are always

-wrapper [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/242049 (owner: 10Catrope) [12:53:45] 10Citoid, 6Community-Tech, 10Possible-Tech-Projects: Add wikitext support for citoid for automatic reference insertion - https://phabricator.wikimedia.org/T94223#1684704 (10Mvolz) I figured we'd just use what VE uses already, which is a mediawiki namespace message and template data. Most of the i18n issue is... [13:08:48] 10VisualEditor: Oxford/Harvard style citations don't work well with VE - https://phabricator.wikimedia.org/T114105#1684748 (10Halibutt) 3NEW [13:29:36] 10VisualEditor, 6Parsing-Team, 7Parsoid-Nowiki: Cleanup redundant - https://phabricator.wikimedia.org/T107675#1684819 (10Strainu) @Ladsgroup, even if it's a bit late, I want to mention that abusing Dexbot's bot flag for making these changes is not OK. I can understand that you considered the change... [13:39:06] 10TemplateData: Add support for web browser's spell checking functionality in TemplateData editor fields - https://phabricator.wikimedia.org/T113947#1684836 (10Esanders) [13:40:45] 10TemplateData: Add support for web browser's spell checking functionality in TemplateData editor fields - https://phabricator.wikimedia.org/T113947#1680657 (10Esanders) WFM. The inputs are standard textarea and text inputs, without the spellchecker disabled. [14:33:23] 10VisualEditor: Oxford/Harvard style citations don't work well with VE - https://phabricator.wikimedia.org/T114105#1685008 (10Jdforrester-WMF) No. This is a duplicate of {T52474}. [14:34:35] 10VisualEditor, 10VisualEditor-MediaWiki-References: A reference whose contents is just an auto-numbered link is rendered as blank in the re-use dialog - https://phabricator.wikimedia.org/T114085#1685022 (10Jdforrester-WMF) p:5Triage>3Normal [14:35:11] 10VisualEditor: Oxford/Harvard style citations don't work well with VE - https://phabricator.wikimedia.org/T114105#1685026 (10Jdforrester-WMF) [14:35:15] 10VisualEditor, 10VisualEditor-DataModel, 10VisualEditor-MediaWiki-References, 7Epic: In VisualEditor, references in templates cannot be reused and are numbered separately from references in the text. - https://phabricator.wikimedia.org/T52474#558083 (10Jdforrester-WMF) [14:35:57] 10VisualEditor, 10VisualEditor-MediaWiki: GalleryInspector: Selector for gallery mode (normal/etc.) - https://phabricator.wikimedia.org/T110641#1582990 (10Jdforrester-WMF) [14:37:15] 10VisualEditor: Increasing indent by typing ':' when "increase indent" is greyed out in VE is anti-intuitive - https://phabricator.wikimedia.org/T113812#1685044 (10Jdforrester-WMF) 5Open>3declined a:3Jdforrester-WMF `:` doesn't mean "indent" in wikitext. It means "insert `

`. However, using this for... [14:40:48] 10TemplateData: Add support for web browser's spell checking functionality in TemplateData editor fields - https://phabricator.wikimedia.org/T113947#1685051 (10Jdforrester-WMF) 5Open>3stalled [14:41:49] 10TemplateData: Add support for web browser's spell checking functionality in TemplateData editor fields - https://phabricator.wikimedia.org/T113947#1680657 (10Jdforrester-WMF) This is about the TemplateData GUI editor, but the point stands. [14:43:28] (03CR) 10Esanders: [C: 032] "hasSlugAtOffset was view-only until one of my "great slug rewrite of..." commits, which is why this method was still lurking in the view." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/241510 (owner: 10Divec) [14:43:49] edsanders: Does that need to be pulled through for this release? [14:44:04] it's just cleanup [14:44:33] 10Citoid, 6Community-Tech, 10Possible-Tech-Projects: Add wikitext support for citoid for automatic reference insertion - https://phabricator.wikimedia.org/T94223#1685059 (10Jdforrester-WMF) This is already something we're planning to work on in Editing. It seems a bit of a waste to duplicate efforts… [14:44:48] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki, 6Community-Tech, 10Possible-Tech-Projects: Add wikitext support for citoid for automatic reference insertion - https://phabricator.wikimedia.org/T94223#1685060 (10Jdforrester-WMF) [14:45:26] Kk. [14:46:35] Krenair: You about? [14:46:52] Yep [14:47:02] You OK with the thing I have in SWAT going out? [14:47:46] (03Merged) 10jenkins-bot: Move cursor offset calc from CE Surface to DM Document [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/241510 (owner: 10Divec) [14:47:52] In 10 minutes? [14:47:57] I don't know what that setting does. [14:48:44] Krenair: It sets it so that if people opt-in and then opt-out of VE right now, they'll get autodisable set true. [14:49:05] So the script doesn't miss them later (if they changed status after the script was run). [14:49:26] ok [14:51:30] seems fine [14:52:07] Kk. [15:04:03] (03CR) 10Jforrester: De-Houdini-fy the handling of observed DOM changes (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/241144 (https://phabricator.wikimedia.org/T113797) (owner: 10Divec) [15:09:50] (03CR) 10Esanders: Move insertion annotation calc logic from DM Surface to ElementLinearData (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/241555 (owner: 10Divec) [15:40:32] (03CR) 10Divec: De-Houdini-fy the handling of observed DOM changes (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/241144 (https://phabricator.wikimedia.org/T113797) (owner: 10Divec) [15:41:15] (03PS7) 10Divec: De-Houdini-fy the handling of observed DOM changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/241144 (https://phabricator.wikimedia.org/T113797) [15:58:16] (03PS4) 10Esanders: [WIP/POC/POS] Wikitext surface [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/229567 [16:01:35] (03CR) 10jenkins-bot: [V: 04-1] [WIP/POC/POS] Wikitext surface [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/229567 (owner: 10Esanders) [16:02:46] (03PS6) 10Esanders: [WIP] Image uploading [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/240116 (https://phabricator.wikimedia.org/T40030) [16:07:36] 10VisualEditor: Increasing indent by typing ':' when "increase indent" is greyed out in VE is anti-intuitive - https://phabricator.wikimedia.org/T113812#1685416 (10MarkAHershberger) This is an almost perfect illustration of the prescriptivist vs descriptivist points of view. Fascinating. Note that I'm not sayi... [16:15:15] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media, 6Multimedia, and 2 others: Button in VisualEditor to initiate Commons file uploading, and insert image on completion - https://phabricator.wikimedia.org/T40030#1685475 (10Jdforrester-WMF) [16:15:17] 10VisualEditor, 10VisualEditor-CopyPaste: VisualEditor: Upload-by-insertion of images via copy-paste - https://phabricator.wikimedia.org/T39932#1685476 (10Jdforrester-WMF) [16:17:03] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki, 6Community-Tech, 10Possible-Tech-Projects: Add wikitext support for citoid for automatic reference insertion - https://phabricator.wikimedia.org/T94223#1685491 (10Jdforrester-WMF) (See https://gerrit.wikimedia.org/r/229567 for the first work here.) [16:33:39] (03PS2) 10Jforrester: build: Upgrade various devDependencies to latest and make pass [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/239194 [16:36:27] (03PS1) 10Esanders: Follow-up If556afa10: Fix typo: nodeType -> nodeName [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/242182 [16:37:01] (03CR) 10Jforrester: [C: 032] "Whoops." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/242182 (owner: 10Esanders) [16:39:46] (03Merged) 10jenkins-bot: Follow-up If556afa10: Fix typo: nodeType -> nodeName [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/242182 (owner: 10Esanders) [16:46:08] (03PS2) 10Paladox: Update mediawiki-codesniffer and parallel-lint settings [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/241956 (owner: 10Siebrand) [16:53:04] Thalia: https://gerrit.wikimedia.org/r/#/c/240091/ needs a manual rebase, sadly. [16:53:44] OK [17:25:27] edsanders: It's not immediately apparent to me how I'd take your changes to MWMediaDialog and make them a separable, experimental module. :-( [17:28:03] 10VisualEditor, 10VisualEditor-ContentLanguage, 5WMF-deploy-2015-09-29_(1.27.0-wmf.1): Cannot type in Korean using Mozilla on Windows 7 with dual-script keyboard - https://phabricator.wikimedia.org/T72353#1685826 (10dchan) Hello, does it now work correctly on http://deployment.wikimedia.beta.wmflabs.org/wiki... [17:48:09] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki, 6Community-Tech, 10Possible-Tech-Projects: Add wikitext support for citoid for automatic reference insertion - https://phabricator.wikimedia.org/T94223#1685971 (10Qgil) So... should we stop this project idea altogether? It looks like that. Is there a t... [17:49:51] 10VisualEditor, 6Editing-Analysis, 6Editing-Department: Investigate why visual editor users have a higher save rate in EventLogging data but didn't in the A/B test - https://phabricator.wikimedia.org/T108241#1685996 (10Neil_P._Quinn_WMF) p:5High>3Normal [17:51:13] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki, 6Community-Tech, 10Possible-Tech-Projects: Add wikitext support for citoid for automatic reference insertion - https://phabricator.wikimedia.org/T94223#1686010 (10Jdforrester-WMF) >>! In T94223#1685971, @Qgil wrote: > So... should we stop this project i... [18:05:33] (03CR) 10TheDJ: "recheck" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/241956 (owner: 10Siebrand) [18:08:40] (03CR) 10TheDJ: [C: 032] Update mediawiki-codesniffer and parallel-lint settings [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/241956 (owner: 10Siebrand) [18:09:40] (03Merged) 10jenkins-bot: Update mediawiki-codesniffer and parallel-lint settings [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/241956 (owner: 10Siebrand) [18:40:57] (03PS1) 10Divec: More specific names for IME tests; IE11 Win8.1 Korean [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/242232 [18:47:06] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki, 6Community-Tech, 10Possible-Tech-Projects: Add wikitext support for citoid for automatic reference insertion - https://phabricator.wikimedia.org/T94223#1686332 (10SalixAlba) I think we should stick to this task. Integrating citoid with the existing edit... [18:57:26] (03PS2) 10Jforrester: IME tests: Add IE11 Win8.1 Korean; name specific Windows versions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/242232 (owner: 10Divec) [18:57:33] (03CR) 10Jforrester: [C: 032] IME tests: Add IE11 Win8.1 Korean; name specific Windows versions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/242232 (owner: 10Divec) [19:02:08] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 7Design, 5WMF-deploy-2015-09-29_(1.27.0-wmf.1), 7user-notice: [Usability] Convert the pop-over suggestions list to be an embedded search widget in the link inspector - https://phabricator.wikimedia.org/T101169#1686439 (10Jdforrester-WMF) [19:02:10] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki, 6Community-Tech, 10Possible-Tech-Projects: Add wikitext support for citoid for automatic reference insertion - https://phabricator.wikimedia.org/T94223#1686441 (10kaldari) @SalixAlba: The citation features in the existing edit toolbar aren't actually pa... [19:02:32] (03Merged) 10jenkins-bot: IME tests: Add IE11 Win8.1 Korean; name specific Windows versions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/242232 (owner: 10Divec) [19:04:00] 10VisualEditor, 10Parsoid, 7Parsoid-Nowiki: VE/Parsoid add with spaces in the beginning of a paragraph after a single line break - https://phabricator.wikimedia.org/T114087#1686446 (10Jdforrester-WMF) This is probably a cut-and-paste from somewhere via Firefox (which adds spurious single newlines). [19:04:42] 10VisualEditor, 10Parsoid, 7Parsoid-Nowiki: VE/Parsoid add with spaces in the beginning of a paragraph after a single line break - https://phabricator.wikimedia.org/T114087#1686447 (10Jdforrester-WMF) [19:04:44] 10VisualEditor, 10VisualEditor-CopyPaste, 7Browser-Support-Firefox: Pasting into a VE surface in Firefox adds spurious line breaks and nowikis - https://phabricator.wikimedia.org/T104790#1686448 (10Jdforrester-WMF) [19:05:09] 10VisualEditor, 10VisualEditor-MediaWiki-Links: VE crashes after opening Link inspector in the same position after deleting link - https://phabricator.wikimedia.org/T114064#1686450 (10Jdforrester-WMF) p:5Triage>3Normal [19:05:46] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 7Browser-Support-Firefox: VisualEditor: Link editor does not always open in Firefox with one click - https://phabricator.wikimedia.org/T113872#1686456 (10Jdforrester-WMF) p:5Triage>3Normal [19:06:14] 10VisualEditor, 10VisualEditor-ContentEditable, 10MediaWiki-Gallery: Gallery popup should be stable - https://phabricator.wikimedia.org/T113837#1686460 (10Jdforrester-WMF) [19:06:16] 10VisualEditor, 10VisualEditor-MediaWiki: With extension editors, show rendering errors inside the inspector, not the ce node - https://phabricator.wikimedia.org/T113172#1686461 (10Jdforrester-WMF) [19:06:45] 10VisualEditor, 10VisualEditor-MediaWiki, 10Math, 10MediaWiki-Gallery, and 2 others: With extension editors, show rendering errors inside the inspector, not the ce node - https://phabricator.wikimedia.org/T113172#1656767 (10Jdforrester-WMF) [19:07:38] 10VisualEditor, 10VisualEditor-MediaWiki, 10RESTBase, 6Services, 7RESTBase-API: VE should send If-Match header to the VRS to send on to RESTbase - https://phabricator.wikimedia.org/T113728#1686466 (10Jdforrester-WMF) p:5Triage>3Normal [19:08:47] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki-Templates: A template got substituted to
-tags (due to copy-and-paste?) - https://phabricator.wikimedia.org/T113717#1686477 (10Jdforrester-WMF) p:5Triage>3Low [19:10:07] 10VisualEditor, 10Phlogiston, 6Team-Practices: VE Project Burnup chart showing burnup separately for each tranche - https://phabricator.wikimedia.org/T113271#1686493 (10JAufrecht) 5Open>3Resolved [19:11:01] 10VisualEditor: [Regression pre-wmf24] On the second attempt of opening the Code Block inspector, the language selector drop down does not expand even after clicking the drop-down arrow, requires a second click on the drop down arrow to open it - https://phabricator.wikimedia.org/T113088#1686498 (10Jdforrester-WM... [19:12:22] 10VisualEditor: [Regression pre-wmf24] The SyntaxHighlight VE inspector is appearing too long, reaching the end of page while trying to open it for the second time - https://phabricator.wikimedia.org/T113086#1686513 (10Jdforrester-WMF) 5Open>3Resolved a:3Jdforrester-WMF Fingers crossed. [19:14:34] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Link, Formula and Text Styles etc. should be disabled when focus is inside the comment/gallery/math/hieroglypics/… editors - https://phabricator.wikimedia.org/T72343#1686528 (10Jdforrester-WMF) [19:14:48] 10VisualEditor, 10VisualEditor-EditingTools, 10Math: VisualEditor should display formulae using the user's preferred method, not just the default PNG one - https://phabricator.wikimedia.org/T62728#1686529 (10Jdforrester-WMF) [19:16:13] 10VisualEditor, 10VisualEditor-EditingTools: In Firefox, While changing the math node to Inline/Block for the first time in a page the text {\textstyle\math funtion} flickers on CE - https://phabricator.wikimedia.org/T78583#1686531 (10Jdforrester-WMF) [19:16:24] 10MediaWiki-extensions-Graph-VE, 10VisualEditor, 10MediaWiki-API: Add action=parse ability to do recursivePreprocess - https://phabricator.wikimedia.org/T100570#1686532 (10Jdforrester-WMF) [19:18:54] 10VisualEditor, 10VisualEditor-ContentEditable: [Regression wmf19] Annotated text: typing, deleting and then again typing it, does not remove the annotation - https://phabricator.wikimedia.org/T90155#1686553 (10Jdforrester-WMF) 5Open>3declined a:3Jdforrester-WMF Actually, I think this behaviour is more c... [19:27:43] edsanders|away: https://hacks.mozilla.org/2015/09/flash-free-clipboard-for-the-web/ worth looking at? [19:32:05] 10VisualEditor: Make math syntax helper dialog - https://phabricator.wikimedia.org/T114163#1686597 (10Tchanders) 3NEW a:3Tchanders [19:32:21] 10VisualEditor: Make math syntax helper dialog - https://phabricator.wikimedia.org/T114163#1686605 (10Tchanders) p:5Triage>3Low [19:35:12] 10VisualEditor, 10Math: Make math syntax helper dialog - https://phabricator.wikimedia.org/T114163#1686620 (10Jdforrester-WMF) [19:38:29] 10VisualEditor, 10VisualEditor-MediaWiki, 10RESTBase, 6Services, 7RESTBase-API: VE should send If-Match header to the VRS to send on to RESTbase - https://phabricator.wikimedia.org/T113728#1686628 (10GWicke) @esanders, @krenair: Are you okay with sending the If-Match header from VE? [19:49:07] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki: Add wikitext support for citoid for automatic reference insertion - https://phabricator.wikimedia.org/T94223#1686694 (10Mvolz) [19:53:38] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki: Add wikitext support for citoid for automatic reference insertion - https://phabricator.wikimedia.org/T94223#1686721 (10Mvolz) Ah, I didn't realise a surface for wikieditor was in the works. Agreed, silly to do this then. Thanks for clearing that up James! [19:54:39] 10Citoid, 6Community-Tech: Add Citoid support to RefToolbar gadget - https://phabricator.wikimedia.org/T114156#1686723 (10Mvolz) [19:56:45] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki: Add wikitext support for citoid for automatic reference insertion - https://phabricator.wikimedia.org/T94223#1686725 (10Mvolz) [20:02:05] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic: Provide a modern wikitext editor - https://phabricator.wikimedia.org/T104479#1686764 (10Mvolz) [20:02:07] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki: Add wikitext support for citoid for automatic reference insertion - https://phabricator.wikimedia.org/T94223#1686763 (10Mvolz) [20:03:44] (03CR) 10Divec: "As discussed, I will fix the legacy use of getNearestContentOffset in a separate commit, for ease of testing and bisecting." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/241555 (owner: 10Divec) [20:25:36] 10VisualEditor, 10VisualEditor-MediaWiki: VisualEditor: avoid causing "Translation unit markers in unexpected position" edit abort - https://phabricator.wikimedia.org/T67653#1686890 (10Aklapper) [20:27:20] 10VisualEditor: [Regression pre-wmf24] The SyntaxHighlight VE inspector is appearing too long, reaching the end of page while trying to open it for the second time - https://phabricator.wikimedia.org/T113086#1686908 (10Ryasmeen) 5Resolved>3Open Still reproducible actually. {F2645198} [20:33:44] 10VisualEditor, 10ContentTranslation-Deployments, 10ContentTranslation-cxserver, 10Parsoid, and 4 others: Decom parsoid-lb.eqiad.wikimedia.org entrypoint - https://phabricator.wikimedia.org/T110474#1686928 (10bd808) >>! In T110474#1578555, @Krenair wrote: > And from puppet: > manifests/role/iegreview.pp:... [20:53:26] 10VisualEditor: [Regression pre-wmf1]Search is not returning matched article names in the link target suggestion drop down inside link inspector - https://phabricator.wikimedia.org/T114175#1687044 (10Ryasmeen) 3NEW [20:56:38] 10VisualEditor: [Regression pre-wmf1]Search is not returning matched article names in the link target suggestion drop down inside link inspector - https://phabricator.wikimedia.org/T114175#1687081 (10Ryasmeen) It could be due to the slowness in the overall search mechanism, I feel it has got significantly slower... [20:58:16] 10VisualEditor: [Regression pre-wmf1]Search is not returning matched article names in the link target suggestion drop down inside link inspector - https://phabricator.wikimedia.org/T114175#1687087 (10Catrope) Perhaps the request for suggestions beginning with "L" was not canceled, and arrived after the suggestio... [21:00:21] 10VisualEditor: [Regression pre-wmf1]Search results appear in the drop down even after clearing the search term inside the link inspector - https://phabricator.wikimedia.org/T114178#1687097 (10Catrope) [21:00:40] 10VisualEditor: [Regression wmf1]Search results appear in the drop down even after clearing the search term inside the link inspector - https://phabricator.wikimedia.org/T114178#1687099 (10Catrope) [21:14:23] 10VisualEditor: [Regression pre-wmf1]Search is not returning matched article names in the link target suggestion drop down inside link inspector - https://phabricator.wikimedia.org/T114175#1687140 (10Catrope) This appears to happen because TitleWidget doesn't abort pending requests, and requests are able to over... [21:14:41] James_F: FYI, the new link inspector has a number of bugs because code wasn't reused, see https://phabricator.wikimedia.org/T114175 and friends [21:15:37] RoanKattouw: Are you asking why code in MW-core doesn't re-use code in VE? ;-) [21:15:49] Isn't LookupElement in OOUI? [21:15:59] RoanKattouw: The use of it is in VE, but yes. [21:16:14] Sure, but the base class with things like caching and request aborts is in OOUI [21:16:27] * James_F nods. I blame MatmaRex. ;-) [21:18:37] 10VisualEditor, 10VisualEditor-MediaWiki-Links: [Regression wmf.1] Search is not returning matched article names in the link target suggestion drop down inside link inspector - https://phabricator.wikimedia.org/T114175#1687172 (10Jdforrester-WMF) a:3Esanders [21:18:59] 10VisualEditor, 10VisualEditor-MediaWiki-Links: [Regression wmf.1] Search results appear in the drop down even after clearing the search term inside the link inspector - https://phabricator.wikimedia.org/T114178#1687178 (10Jdforrester-WMF) p:5Triage>3High a:3Esanders [21:20:46] edsanders|away: Thoughts? [21:22:37] 10VisualEditor: [Regression wmf 1] Even after selecting one of the link target suggestions, the drop down is not getting closed and showing other link target suggestions - https://phabricator.wikimedia.org/T114180#1687191 (10Ryasmeen) 3NEW [21:23:56] (03PS1) 10Jforrester: Update OOjs UI to v0.12.10 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/242354 [21:25:54] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.12.10 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/242354 (owner: 10Jforrester) [21:28:16] 10VisualEditor, 10VisualEditor-MediaWiki-Links: Once the user has selected a suggestion in the link editor, hide all other link target suggestions until (?) they edit the search box - https://phabricator.wikimedia.org/T114180#1687230 (10Jdforrester-WMF) p:5Triage>3Low [21:28:24] 10VisualEditor, 10VisualEditor-MediaWiki-Links: Once the user has selected a suggestion in the link editor, hide all other link target suggestions until (?) they edit the search box - https://phabricator.wikimedia.org/T114180#1687191 (10Jdforrester-WMF) This was intentional, but… [21:30:07] (03Merged) 10jenkins-bot: Update OOjs UI to v0.12.10 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/242354 (owner: 10Jforrester) [21:39:05] gwicke, what exactly are you asking in https://phabricator.wikimedia.org/T113728 ? [21:39:06] what's broken? [21:39:26] i blame ed [21:39:55] gwicke, you want us to change the code to do it? [21:40:01] gwicke, or you want to know if we'd accept a patch for it? [21:40:08] titleInputWidget doesn't use LookupElement? [21:40:13] * MatmaRex does a double take [21:40:40] I think I last saw Ed touch that code? [21:40:53] oh right, because that's TitleSearchWidget, not InputWidget [21:41:22] or maybe not [21:41:30] i still blame ed~ [21:42:57] * RoanKattouw blames TitleWidget [21:43:54] 10VisualEditor, 10Phlogiston: Create third version of VE burnup report - https://phabricator.wikimedia.org/T107482#1687248 (10JAufrecht) [21:43:57] 10VisualEditor, 10Phlogiston, 6Team-Practices: Generate project data from newly available transaction data instead of via hack - https://phabricator.wikimedia.org/T110955#1687247 (10JAufrecht) 5Open>3Resolved [21:47:53] Krenair: the proposal is to deprecate the mw:TimeUuid meta tag hack that we added in Parsoid HTML to round-trip the timeuuid of the render; instead, we would like clients to send the original ETag header back as If-Match: . [21:48:22] And it will behave exactly the same as if we sent the mw:TimeUUID meta tag? [21:48:37] I don't want to end up with issues around editing older versions, edit conflicts, etc. [21:49:01] Didn't we have this discussion months ago? [21:49:20] IIRC I argued for a tag instead of an HTTP header because a tag would be a lot easier to support for clients [21:49:54] Krenair: it'll take precedence [21:50:16] precedence over a provided meta tag? [21:50:23] the mw:TimeUuid thing was added as a temporary fall-back mechanisms for clients that don't support If-Match yet [21:50:29] If we're moving from one to another, that doesn't sound like an issue [21:51:29] RoanKattouw: it's somewhat easier, yes- but setting a single header (or POST variable) isn't so hard either [21:51:52] Right, for VE we could run it through POST var, good point [21:52:07] I didn't want to have to deal with sending HTTP headers from a browser using JS, but we proxy the request anyway so we wouldn't have to [21:52:46] for a fetch or XHR, setting headers shouldn't be hard either [21:53:05] {headers: { 'if-match': etag }} [21:53:47] Oh right, jQuery AJAX supports headers: {...} [21:53:58] I got confused with POSTing a body with a different content type (e.g. JSON RPC) [21:54:00] that one is a pain [21:54:03] But headers are easier [21:54:31] yeah, content-type is one of the headers with special overrides [21:55:27] there is also a proposal to provide a generic way to provide headers as post vars: https://phabricator.wikimedia.org/T111748 [21:55:46] _http.headers.if-match: "679786764/581593fe-54d0-11e5-96a3-1b0c6675c2e8" [22:06:57] 10VisualEditor, 10ContentTranslation-Deployments, 10ContentTranslation-cxserver, 10Parsoid, and 4 others: Decom parsoid-lb.eqiad.wikimedia.org entrypoint - https://phabricator.wikimedia.org/T110474#1687346 (10cscott) @bd808 the new hotness is to use the REST API's /transform/wikitext/to/html endpoint to do... [22:14:15] (03PS1) 10Jforrester: Update VE core submodule to master (ca4bd8c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/242366 [22:19:11] 10VisualEditor: Sometimes link suggestions from previous search are appearing immediately after opening link inspector - https://phabricator.wikimedia.org/T114187#1687412 (10Ryasmeen) 3NEW [22:19:29] 10VisualEditor: [Regression wmf 1] Sometimes link suggestions from previous search are appearing immediately after opening link inspector - https://phabricator.wikimedia.org/T114187#1687419 (10Ryasmeen) [22:30:57] Krenair, RoanKattouw: do you mind weighing in on https://phabricator.wikimedia.org/T113728 ? [22:31:59] gwicke, I don't think you've answered my first question. [22:35:31] 10VisualEditor, 10Phlogiston, 6Team-Practices: Add a vertical indicator of quarters in time series charts - https://phabricator.wikimedia.org/T113063#1687510 (10JAufrecht) 5Open>3Resolved manually added indicators. Will have to be manually updated each quarter, until the pain becomes unbearable. [22:35:32] well, the first decision to make is about the API change [22:35:59] Krenair: but, I hear you re who is going to do the work ;) [22:37:42] 10VisualEditor, 10VisualEditor-MediaWiki, 10RESTBase, 6Services, 7RESTBase-API: VE should send If-Match header to the VRS to send on to RESTbase - https://phabricator.wikimedia.org/T113728#1687522 (10Krenair) I have no objections to someone patching it to use this instead. [22:38:54] 10VisualEditor: [Regression wmf 1] Previously added link appears below the search text box for a specific case - https://phabricator.wikimedia.org/T114188#1687528 (10Ryasmeen) 3NEW [22:42:57] 10VisualEditor: [Regression wmf 1] Sometimes link suggestions from previous search are appearing immediately after opening link inspector - https://phabricator.wikimedia.org/T114187#1687573 (10Ryasmeen) update: this happens when you click "cancel" on the link inspector after clearing the search term on your pre... [22:52:29] 10VisualEditor: [Regression pre-wmf24] On the second attempt of opening the Code Block inspector, the language selector drop down does not expand even after clicking the drop-down arrow, requires a second click on the drop down arrow to open it - https://phabricator.wikimedia.org/T113088#1687608 (10Ryasmeen) 5R... [22:53:39] 10VisualEditor, 10VisualEditor-MediaWiki, 10SyntaxHighlight: After the first time the SyntaxHighlighter inspector opens, the language drop-down only appears after a second click on the indicator - https://phabricator.wikimedia.org/T113088#1687615 (10Jdforrester-WMF) p:5Triage>3Low [22:57:43] 10VisualEditor: [Regression wmf 1] Drop-down for Link suggestions from previous search are appearing immediately after opening link inspector - https://phabricator.wikimedia.org/T114187#1687633 (10Ryasmeen) [23:00:17] James_F, interesting [23:04:28] edsanders: :-) RoanKattouw was being impolite. [23:04:42] ? [23:05:13] (separately, do you know how to do a query to list every page containing " edsanders: "Why wasn't LookupElement reused here? :S We solved all these problems years ago, over the course of multiple painful months." [23:05:36] edsanders: Yes, I think it adds a page prop. [23:05:37] One second. [23:05:58] what's that in relation to? [23:06:14] edsanders: https://en.wikipedia.org/wiki/Special:PagesWithProp?propname=score&propname-other=sc [23:06:20] edsanders: https://phabricator.wikimedia.org/T114175#1687140 [23:06:30] sweek [23:06:33] sweet [23:08:31] 10VisualEditor, 10VisualEditor-MediaWiki-Links: [Regression wmf.1] Search is not returning matched article names in the link target suggestion drop down inside link inspector - https://phabricator.wikimedia.org/T114175#1687651 (10Esanders) The main difference was the appearance. LookupElement renders as an abs... [23:08:41] James_F, can you filter by namespace? [23:09:26] oh wait - there are 384 total, nevermind [23:16:28] edsanders: That's https://phabricator.wikimedia.org/T50247 FWIW. [23:19:39] big one: https://en.wikipedia.org/wiki/Cwm_Rhondda [23:19:41] 10VisualEditor, 10VisualEditor-MediaWiki-Links: [Regression wmf.1] Suggestions from previous search should not appear on opening the link inspector - https://phabricator.wikimedia.org/T114187#1687684 (10Jdforrester-WMF) p:5Triage>3High a:3Esanders [23:20:17] edsanders: Typical British. :_) [23:20:37] edsanders: In a template. :-( [23:22:10] boo templates [23:23:48] edsanders: Yeah. Maybe at some point we could do transparent editing of templates, but… [23:36:40] (03PS3) 10Divec: Move insertion annotation calc logic from DM Surface to ElementLinearData [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/241555 [23:37:17] (03PS1) 10Divec: Refactor the code that determine insertion annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/242407 [23:40:48] (03PS8) 10Divec: De-Houdini-fy the handling of observed DOM changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/241144 (https://phabricator.wikimedia.org/T113797) [23:42:52] (03CR) 10jenkins-bot: [V: 04-1] De-Houdini-fy the handling of observed DOM changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/241144 (https://phabricator.wikimedia.org/T113797) (owner: 10Divec)