[00:00:33] (03CR) 10Esanders: [C: 04-1] "needs more thinking" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/242894 (owner: 10Esanders) [00:00:56] 10VisualEditor, 10VisualEditor-MediaWiki, 10Math: [Regression pre-wmf.2] There is no way to edit a wrong LaTeX formula from VE since it is not appearing as an inspectable node with context menu over it - https://phabricator.wikimedia.org/T114455#1695852 (10Jdforrester-WMF) p:5Triage>3High a:3Tchanders [00:01:58] 10VisualEditor, 10VisualEditor-MediaWiki, 10Score, 7Verified, 5WMF-deploy-2015-10-06_(1.27.0-wmf.2): Organise the score inspector into tabs - https://phabricator.wikimedia.org/T113354#1695854 (10Ryasmeen) [00:03:28] (03CR) 10Jforrester: [C: 032] Hack to stop logging edit events for non-desktop targets [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/242952 (https://phabricator.wikimedia.org/T110272) (owner: 10Alex Monk) [00:03:57] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Mobile, 5Patch-For-Review: "Value null is the wrong type for property "action.saveIntent.timing" (integer expected) " appears upon opening the Save dialog in mobile VE - https://phabricator.wikimedia.org/T109525#1695856 (10Jdforrester-WMF) [00:04:07] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Mobile, 5Patch-For-Review: "Value null is the wrong type for property "action.saveIntent.timing" (integer expected) " appears upon opening the Save dialog in mobile VE - https://phabricator.wikimedia.org/T109525#1695858 (10Jdforrester-WMF)... [00:07:21] 10VisualEditor, 10VisualEditor-Performance, 10Parsoid, 7Parsoid-Token-Stream-Transforms, and 2 others: Batch Parsoid's API requests - https://phabricator.wikimedia.org/T45888#1695867 (10GWicke) @subbu, good point re load. Added the parse request rate for completeness. [00:09:06] (03Merged) 10jenkins-bot: Hack to stop logging edit events for non-desktop targets [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/242952 (https://phabricator.wikimedia.org/T110272) (owner: 10Alex Monk) [00:13:30] Krenair: hmm, it seems to return 404 no matter what page I ask [00:14:27] Parsoid returns a 404 directly? [00:14:33] or you're still trying to open random pages in VE? [00:15:01] Krenair: I did this http://i.imgur.com/H1y2ivy.png . Isn't Parsoid supposed to return something here? [00:15:33] (I guess you can tell by now that I am pretty confused haha) [00:15:50] I think so [00:15:58] So probably your parsoid config isn't right [00:16:11] there should be a file called localsettings.js somewhere [00:16:43] Yeah, I've been looking for it, but my extensions/Parsoid folder is empty now and I can't figure out where Parsoid is installed now [00:17:04] Parsoid is an external storage and is not a MediaWiki extension [00:17:19] there was an extension which used to be used to purge caches in parsoid or something, but it's gone now [00:17:24] an external service* [00:18:07] Yeah that's what confused me, but I think I've found the file now, I guess /srv/parsoid/cnf/wmf looks like a promising path for parsoid to be hiding :P [00:18:24] * Krenair sighs [00:18:28] I wouldn't even be surprised if it's there. [00:18:56] Oh wait, there's one in /sev/parsoid/src/api as well [00:19:02] srv* [00:19:29] what about /srv/parsoid/localsettings.js? [00:19:54] oh, right [00:19:55] it's in the api dir [00:29:58] Hmmm, can't see anything fishy in there, it's effectively using setMwApi() [00:29:58] Here's what it looks like https://gist.github.com/ferdbold/7ca4e80ffdfef03d77c0 [00:33:22] yes but is the uri correct? [00:33:36] and also, that domain? not sure if that will work.... [00:33:53] ok. try browsing to localhost:8080/127.0.0.1/v3/page/html/Main_Page [00:37:12] 10VisualEditor, 10VisualEditor-MediaWiki, 10Parsoid, 10RESTBase: Implement something similar to the RESTBase 'section' API to provide wikitext structure information - https://phabricator.wikimedia.org/T114402#1695909 (10GWicke) We actually store those section offsets both in data-parsoid, and separately in... [00:38:51] 10VisualEditor, 10VisualEditor-MediaWiki, 10Parsoid, 10RESTBase: Implement something similar to the RESTBase 'section' API to provide wikitext structure information - https://phabricator.wikimedia.org/T114402#1695912 (10GWicke) For marking up / extracting inline content elements, there are some thoughts in... [00:39:12] nope, 404 as well :/ [00:43:37] hey there [00:43:50] are you following the instructions in https://www.mediawiki.org/wiki/Parsoid/Setup ? [00:45:04] One thing I'm definitely noticing: which is on port 8080? Your wiki, or your parsoid? [00:45:14] https://gist.github.com/ferdbold/7ca4e80ffdfef03d77c0#file-localsettings-js-L9 says that your wiki is on port 8080. [00:45:36] ferdbold: ^ [00:45:51] Yeah it is, that's the default port Vagrant runs off [00:46:01] so what port is parsoid on? [00:46:14] From my devtools parsoid seems to run on 7231 [00:46:58] so, browse to http://localhost:7231/127.0.0.1/v3/page/html/Main_Page to test parsoid [00:47:44] also, if you're getting vagrant running, you might want to look at tackling https://phabricator.wikimedia.org/T111223 once you're done. [00:48:21] No dice :| http://i.imgur.com/GJ4IOsv.png [00:48:21] i wonder why vagrant chose port 7231, that's random. parsoid's default when installed from a .deb is 8142. [00:49:03] (GraphTest is a local page of mine I use for my tests) [00:49:05] do you get anything at http://localhost:7231/ ? [00:49:31] oh, you've got restbase set up there, that's not a parsoid error. [00:49:47] Yeah indeed, 7231 takes me to restbase [00:50:08] ok, so you should go over to #wikimedia-services and see if they can help you set up restbase then. [00:50:41] I don't think we established that parsoid was working? [00:50:41] Okay, and what changed recently with Parsoid is needing restbase to work, correct? [00:50:49] and, again, pester them to actually fix https://phabricator.wikimedia.org/T111223 while they are at it. [00:50:57] ferdbold: I have no idea. I don't speak vagrant. [00:51:20] Well me neither haha [00:52:40] ferdbold: you might try https://www.mediawiki.org/wiki/Parsoid/Setup/RESTBase to see if that gives any clues. [00:53:38] that documents the restbase configuration to point at parsoid. It seems like restbase, localsettings.php, and the parsoid configuration file don't all agree on what the 'domain' string should be for your wiki. [00:54:20] see in particular the last paragraph of https://www.mediawiki.org/wiki/Parsoid/Setup/RESTBase#Pointing_RESTBase_at_a_local_Parsoid [01:01:59] I noticed that restbase sets the parsoid port to 8000 while parsoid is set to 8080, but changing them both to 8080 doesn't seem to fix it [01:02:42] Also I don't have any serverPort directive in my localsettings.js, only a port specified in the uri [01:08:06] i think parsoid's port defaults to 8000 if it's not otherwise specified. [01:08:27] but you should be able to visit http://localhost:8000 or http://localhost:8080 and find out for sure where parsoid is hiding. [01:17:03] can't seem to get anything out of :8000 [01:17:26] :8080 takes me to the wiki just fine, but I guess parsoid has to run off a different port than the wiki, right? [01:45:05] ferdbold: does `ps afx | fgrep parsoid` show any parsoid process running? [01:45:40] yep, shows 2 [01:46:17] what installation instructions are you following for vagrant? maybe I should just set up vagrant for myself and take a look. [01:48:04] https://www.mediawiki.org/wiki/MediaWiki-Vagrant#Quick_start [01:54:09] ferdbold: with the "visualeditor" role? [01:54:59] yeah, I have also parsoid and restbase activated, I think parsoid gets automatically added if you enable visualeditor [01:55:13] restbase i enabled earlier tonight [02:02:07] it looks like it will take a little bit of time for me to get vagrant up, but watch https://phabricator.wikimedia.org/T111223 for patches i guess. [02:03:13] yeah first vagrant up took about half an hour on my old macbook, so brace yourself haha [02:03:50] I'm actually gonna do something else (hopefully more productive but I doubt it at this hour), but I really appreciate the help [02:45:53] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-extensions-GuidedTour: GuidedTour referencing a VE-MW renamed class - viewPageTarget - https://phabricator.wikimedia.org/T111842#1695993 (10Mattflaschen) There doesn't seem to be a clear replacement selector (there is ve-ui-mwSaveDialog, but that's not sp... [08:00:41] 10WikiEditor, 10Wikimedia-General-or-Unknown, 7Browser-Support-Internet-Explorer: Missing WikiEditor panel (in IE8 with compatibility mode?) - https://phabricator.wikimedia.org/T114323#1696348 (10Schnark) Well, since it is a problem with IE9 and CSS, this might be some issue in the neighborhood of {T108727}... [09:06:23] 10WikiEditor, 10Wikimedia-General-or-Unknown, 7Browser-Support-Internet-Explorer: Missing WikiEditor panel (in IE8 with compatibility mode?) - https://phabricator.wikimedia.org/T114323#1696411 (10Mormegil) @Schnark: I see… `if ( document.documentMode === 9 )` kinda explains why the bug appears _only_ in IE9... [09:32:02] 10Citoid, 10VisualEditor: Citoid/VisualEditor doesn't handle citations for book chapters correctly - https://phabricator.wikimedia.org/T114450#1696462 (10Mvolz) This is similar to: T93355 Basically, we are conforming to a third party standard, which is Zotero's type and field system, full list of types and fi... [09:36:37] 10Citoid, 6Services: Figure out how to deploy phantomjs - https://phabricator.wikimedia.org/T114215#1696474 (10Mvolz) Phantomjs is actually packaged for 14.01 after all, but it's 1.9. It's 2.0 that has the problem (and I couldn't even get 2.0 to compile from source myself, the first two times it actually cause... [10:38:37] (03PS4) 10Esanders: [BREAKING CHANGE] GeneratedContentNode: Introduce new hash for rendering [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/242894 [10:39:01] (03PS1) 10Eranroz: Introducing template format [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/243138 (https://phabricator.wikimedia.org/T64217) [10:40:25] (03CR) 10jenkins-bot: [V: 04-1] Introducing template format [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/243138 (https://phabricator.wikimedia.org/T64217) (owner: 10Eranroz) [10:41:51] (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] GeneratedContentNode: Introduce new hash for rendering [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/242894 (owner: 10Esanders) [10:44:05] 10TemplateData, 5Patch-For-Review: TemplateData: Provide information about preferred formatting of transclusions - https://phabricator.wikimedia.org/T64217#1696653 (10eranroz) a:3eranroz [10:53:59] 10Citoid, 6Services: Figure out how to deploy phantomjs - https://phabricator.wikimedia.org/T114215#1696691 (10mobrovac) Note that we plan to move the production services (Citoid and Zotero included) to Debian Jessie soon (cf. {T96017}) [11:19:47] (03PS5) 10Esanders: [BREAKING CHANGE] GeneratedContentNode: Introduce new hash for rendering [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/242894 [11:35:47] (03CR) 10Esanders: [C: 032] Move insertion annotation calc logic from DM Surface to ElementLinearData [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/241555 (owner: 10Divec) [11:38:55] (03CR) 10Esanders: [C: 032] Refactor the code that determine insertion annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/242407 (owner: 10Divec) [11:39:06] (03Merged) 10jenkins-bot: Move insertion annotation calc logic from DM Surface to ElementLinearData [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/241555 (owner: 10Divec) [11:41:17] (03CR) 10Esanders: [C: 04-1] De-Houdini-fy the handling of observed DOM changes (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/241144 (https://phabricator.wikimedia.org/T113797) (owner: 10Divec) [11:42:07] (03Merged) 10jenkins-bot: Refactor the code that determine insertion annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/242407 (owner: 10Divec) [11:49:10] (03CR) 10Esanders: Introducing template format (033 comments) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/243138 (https://phabricator.wikimedia.org/T64217) (owner: 10Eranroz) [11:59:33] (03PS2) 10Eranroz: Introducing template format [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/243138 (https://phabricator.wikimedia.org/T64217) [12:00:37] (03CR) 10jenkins-bot: [V: 04-1] Introducing template format [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/243138 (https://phabricator.wikimedia.org/T64217) (owner: 10Eranroz) [12:01:00] (03CR) 10Eranroz: Introducing template format (033 comments) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/243138 (https://phabricator.wikimedia.org/T64217) (owner: 10Eranroz) [12:12:42] 10VisualEditor, 10MediaWiki-Vagrant, 10Parsoid, 10RESTBase, and 2 others: Update vagrant to use VRS to configure VisualEditor/Flow - https://phabricator.wikimedia.org/T111223#1696745 (10mobrovac) [12:20:37] (03PS1) 10Tchanders: Always render generated content the first time, including errors [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/243153 (https://phabricator.wikimedia.org/T114455) [12:27:15] 10VisualEditor, 10MediaWiki-Vagrant, 10Parsoid, 10RESTBase, and 2 others: Update vagrant to use VRS to configure VisualEditor/Flow - https://phabricator.wikimedia.org/T111223#1696780 (10mobrovac) I added a section about it to the [MW-Vagrant manual](https://www.mediawiki.org/wiki/MediaWiki-Vagrant#visualed... [12:28:03] (03PS1) 10Esanders: Add block/inline icons [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/243155 [12:29:02] (03CR) 10jenkins-bot: [V: 04-1] Add block/inline icons [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/243155 (owner: 10Esanders) [12:50:37] (03PS2) 10Tchanders: Always render generated content the first time, including errors [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/243153 (https://phabricator.wikimedia.org/T114455) [12:56:11] 10WikiEditor, 10Wikimedia-General-or-Unknown, 7Browser-Support-Internet-Explorer: Missing WikiEditor panel (in IE8 with compatibility mode?) - https://phabricator.wikimedia.org/T114323#1696860 (10TheDJ) Confirmed, if I switch documentMode to IE8 in IE9, then it seems that the scripts start working. If I take... [13:03:15] (03CR) 10Esanders: [C: 032] Always render generated content the first time, including errors [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/243153 (https://phabricator.wikimedia.org/T114455) (owner: 10Tchanders) [13:05:49] 10VisualEditor: Render an error in generated content on closing the inspector - https://phabricator.wikimedia.org/T114480#1696864 (10Tchanders) 3NEW a:3Esanders [13:06:23] (03Merged) 10jenkins-bot: Always render generated content the first time, including errors [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/243153 (https://phabricator.wikimedia.org/T114455) (owner: 10Tchanders) [13:08:23] 10VisualEditor: [Regression pre-wmf.2] Wrong LaTeX formula still renders as correct one after editing - https://phabricator.wikimedia.org/T114453#1696878 (10Tchanders) In some cases, displaying the last non-erroneous rendering probably does make the most sense, e.g. in the process of changing \pi to \sqrt\pi, th... [13:09:34] (03PS1) 10Esanders: Pass staging state through Document#commit to ve.dm.Node update event [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/243166 (https://phabricator.wikimedia.org/T114480) [13:11:36] (03PS1) 10Esanders: Ensure full error message is show when inspector is closed [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/243167 (https://phabricator.wikimedia.org/T114480) [13:18:39] (03PS1) 10Esanders: MWExtensionNode: Fix selector to find dimension-less images [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/243168 [13:21:55] (03CR) 10Tchanders: [C: 032] MWExtensionNode: Fix selector to find dimension-less images [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/243168 (owner: 10Esanders) [13:24:43] (03Merged) 10jenkins-bot: MWExtensionNode: Fix selector to find dimension-less images [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/243168 (owner: 10Esanders) [13:41:24] (03CR) 10Divec: De-Houdini-fy the handling of observed DOM changes (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/241144 (https://phabricator.wikimedia.org/T113797) (owner: 10Divec) [14:09:43] 10VisualEditor, 10MediaWiki-Vagrant, 10Parsoid, 10RESTBase, and 2 others: Update vagrant to use VRS to configure VisualEditor/Flow - https://phabricator.wikimedia.org/T111223#1696980 (10Esanders) I hope the long term fix doesn't involve getting people to enable restbase [14:11:29] 10VisualEditor, 10MediaWiki-Vagrant, 10Parsoid, 10RESTBase, and 2 others: Update vagrant to use VRS to configure VisualEditor/Flow - https://phabricator.wikimedia.org/T111223#1696983 (10Esanders) A quicker fix I found worked was to change "VisualEditorParsoidDomain" in extension.json from "localhost" to "1... [14:17:21] 10VisualEditor, 10MediaWiki-Vagrant, 10Parsoid, 10RESTBase, and 2 others: Update vagrant to use VRS to configure VisualEditor/Flow - https://phabricator.wikimedia.org/T111223#1696987 (10mobrovac) >>! In T111223#1696980, @Esanders wrote: > I hope the long term fix doesn't involve getting people to enable re... [14:34:28] 10WikiEditor, 10Wikimedia-General-or-Unknown, 7Browser-Support-Internet-Explorer: Missing WikiEditor panel (in IE8 with compatibility mode?) - https://phabricator.wikimedia.org/T114323#1697004 (10matmarex) My investigation of this is somewhat hampered by the fact that it works for me locally :( [14:40:13] (03PS12) 10Divec: De-Houdini-fy the handling of observed DOM changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/241144 (https://phabricator.wikimedia.org/T113797) [14:42:54] (03CR) 10Esanders: [C: 031] Introducing template format [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/243138 (https://phabricator.wikimedia.org/T64217) (owner: 10Eranroz) [14:48:55] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-extensions-GuidedTour: GuidedTour referencing a VE-MW renamed class - viewPageTarget - https://phabricator.wikimedia.org/T111842#1697060 (10Krenair) 5Open>3Resolved a:3Mattflaschen [14:53:40] 10WikiEditor, 10Wikimedia-General-or-Unknown, 7Browser-Support-Internet-Explorer: Missing WikiEditor panel (in IE8 with compatibility mode?) - https://phabricator.wikimedia.org/T114323#1697094 (10matmarex) Bah, I see why it doesn't work. This was a really stupid mistake on my part. [14:58:37] 10VisualEditor, 10MediaWiki-Vagrant, 10Parsoid, 10RESTBase, and 2 others: Update vagrant to use VRS to configure VisualEditor/Flow - https://phabricator.wikimedia.org/T111223#1697118 (10Esanders) >> I hope the long term fix doesn't involve getting people to enable restbase > > That was a problem in the ea... [15:02:35] 10WikiEditor, 10MediaWiki-General-or-Unknown, 7Browser-Support-Internet-Explorer, 5Patch-For-Review: Missing WikiEditor panel when using IE 9 - https://phabricator.wikimedia.org/T114323#1697140 (10matmarex) [15:02:41] 10WikiEditor, 10MediaWiki-General-or-Unknown, 7Browser-Support-Internet-Explorer, 5Patch-For-Review: Missing WikiEditor panel when using IE 9 - https://phabricator.wikimedia.org/T114323#1691429 (10matmarex) a:5Davcza>3matmarex [15:20:58] 10WikiEditor, 10MediaWiki-General-or-Unknown, 7Browser-Support-Internet-Explorer: Missing WikiEditor panel when using IE 9 - https://phabricator.wikimedia.org/T114323#1697224 (10matmarex) 5Open>3Resolved p:5Triage>3High [15:35:17] 10Citoid: Citoid should respect the order of parameters in citation templates that is specified in TemplateData - https://phabricator.wikimedia.org/T104599#1697299 (10Mvolz) [15:35:19] 10TemplateData, 5Patch-For-Review: TemplateData: Provide information about preferred formatting of transclusions - https://phabricator.wikimedia.org/T64217#1697300 (10Mvolz) [15:38:48] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media, 6Multimedia, and 2 others: Way in VisualEditor to initiate Commons file uploading, and insert image on completion - https://phabricator.wikimedia.org/T40030#1697313 (10Jdforrester-WMF) [15:39:04] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media, 6Multimedia, and 2 others: Way in VisualEditor to initiate Commons file uploading, and insert image on completion - https://phabricator.wikimedia.org/T40030#428437 (10Jdforrester-WMF) p:5Low>3High [15:55:41] 10VisualEditor, 10MediaWiki-Vagrant, 10Parsoid, 10RESTBase, 6Services: Update vagrant to use VRS to configure VisualEditor/Flow - https://phabricator.wikimedia.org/T111223#1697343 (10mobrovac) [16:00:14] 10VisualEditor, 10MediaWiki-Vagrant, 10Parsoid, 10RESTBase, 6Services: Update vagrant to use VRS to configure VisualEditor/Flow - https://phabricator.wikimedia.org/T111223#1697380 (10mobrovac) >>! In T111223#1697118, @Esanders wrote: > Performance is important too. Vagrant boxes are running with 1/4 of t... [16:01:26] 10VisualEditor, 10MediaWiki-Vagrant, 10Parsoid, 10RESTBase, 6Services: Update vagrant to use VRS to configure VisualEditor/Flow - https://phabricator.wikimedia.org/T111223#1697385 (10GWicke) Also, if we really care about the last 40mb of RAM, we could even combine Parsoid & RESTBase in a single process. [16:11:20] (03PS3) 10Eranroz: Introducing template format [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/243138 (https://phabricator.wikimedia.org/T64217) [17:44:01] 10VisualEditor, 6WMF-Design-Research, 5Design Research and product team collaboration: Create test plan for VE on mobile evaluation for new users - https://phabricator.wikimedia.org/T88756#1697852 (10aripstra) [18:04:01] 10Citoid, 10TemplateData: Missing parameter in citation - https://phabricator.wikimedia.org/T93355#1697938 (10Mvolz) [18:08:56] (03PS3) 10Mvolz: Fix restoring of last used inspector tab [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/242603 (https://phabricator.wikimedia.org/T114268) (owner: 10Alex Monk) [18:10:12] (03CR) 10Mvolz: [C: 032] "Tested, fixes bug." [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/242603 (https://phabricator.wikimedia.org/T114268) (owner: 10Alex Monk) [18:11:26] 10Citoid, 10VisualEditor: [Regression] Citoid won't remember last used tab (auto/manual/re-use) on inspector - https://phabricator.wikimedia.org/T114268#1697978 (10Jdforrester-WMF) 5Open>3Resolved [18:22:40] (03PS1) 10Esanders: Consistently use spaces inside brackets in CSS [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/243224 [18:23:11] (03CR) 10Jforrester: [C: 031] "Is there a csslint rule we can apply to avoid regressions?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/243224 (owner: 10Esanders) [18:23:36] James_F, I thought CSSlint was broken? [18:23:58] edsanders: It's "not good". [18:24:04] But I thought it worked OK? [18:24:13] (Stale project, I was looking at a replacement.) [18:24:39] (03CR) 10Tchanders: Ensure full error message is show when inspector is closed (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/243167 (https://phabricator.wikimedia.org/T114480) (owner: 10Esanders) [18:26:20] edsanders: Also, is the meeting in a bit OK? [18:26:25] does it vote? [18:26:54] Erm. [18:27:00] Yes? [18:27:02] It's in npm. [18:27:07] (wikitext switch meeting?) [18:27:24] (yes.) [18:27:24] ok, and it causes npm to fail, not just warn... [18:27:28] Yeah. [18:27:29] (yes) [18:27:30] Oh. [18:27:34] Let me check. [18:28:08] it seems to pass in lib/ve [18:28:37] Yes, it does fail. [18:28:54] we were discussing the state of css/less linting in FESG [18:29:13] I was looking at stylelint or something last week. [18:29:13] I mentioned you'd been looking at them, so TrevorParscal is supposed to come and ask you about it [18:29:33] we also want to enforce kebab-case on less variable names [18:29:50] * James_F nods. [18:29:57] I'll try to find what I did. [18:30:37] can't find anything about brackets/parentheses here: https://github.com/CSSLint/csslint/wiki/Rules [18:30:43] Fun. [18:31:19] seems more concerted with the token stream than the code style [18:33:07] csscomb maybe? [18:34:19] 10WikiEditor, 10MediaWiki-General-or-Unknown, 7Browser-Support-Internet-Explorer, 5MW-1.26-release, and 3 others: Missing WikiEditor panel when using IE 9 - https://phabricator.wikimedia.org/T114323#1698076 (10matej_suchanek) [18:35:10] 10VisualEditor, 10Math: Make math syntax helper dialog - https://phabricator.wikimedia.org/T114163#1698079 (10Nirzar) [18:36:05] has a lot of cool rules, but not brackets [18:40:42] edsanders: That was it. [18:40:46] I found a PostCSS plugin. [18:40:52] Stylelint [18:40:58] But PostCSS is a pain to get set up. [18:41:03] So I gave up. :-) [18:41:14] Stylelint does (limited) auto-fixing as well. [18:41:26] Which was interesting to me mostly to try and get MW-core's CSS passing. [18:41:31] (It's horrendous right now.) [18:41:46] https://github.com/stylelint/stylelint [18:42:21] (/cc Krinkle who may have thoughts.) [18:43:18] The main issue I had is that PostCSS expects to take multiple inputs and turn them into a single output (or, at least, a distinct directory for built output). [18:50:50] 10VisualEditor, 10Math: Make math syntax helper dialog - https://phabricator.wikimedia.org/T114163#1698143 (10Physikerwelt) By the way... I like http://www.wiris.com/ maybe this gives additional inspirations [18:51:13] 10Citoid, 10TemplateData: Decide what to do for types that aren't coerced well into standard templates - https://phabricator.wikimedia.org/T114515#1698145 (10Krenair) guessing projects [19:24:05] James_F: opinion on https://phabricator.wikimedia.org/T93355 and https://phabricator.wikimedia.org/T114450? As you marked it as high priority ;) [19:24:11] (03PS1) 10Jforrester: [WIP] Use grunt-postcss with stylelint instead of csslint [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/243233 [19:24:35] or rather https://phabricator.wikimedia.org/T114515 [19:27:09] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Use grunt-postcss with stylelint instead of csslint [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/243233 (owner: 10Jforrester) [19:27:11] mvolz: For T114515, option two – but can we fall back with existing temmplates' TemplateData? And can we then persue Option 3 for the remaining ones? [19:27:42] mvolz: For T93355, making a new template seems good. Elitre might be able to help do it? [19:30:57] James_F: Not sure how we would fallback exactly- maybe make two requests, and then try to add it both ways? Seems a bit inefficient, would we do that forever? or just as a backwards compatibility measure? [19:33:07] * Elitre making a template? Or you meant, finding someone who can? :-) [19:33:37] well it's theoretically quite simply, you just copy another template but call it something different :P [19:33:41] simple* [19:34:02] mvolz: Just for back-compat. [19:34:09] Elitre: Either. :-) [19:34:13] James_F: okay good plan [19:34:25] mvolz: Cool. :-) [19:34:32] any chance I could get rights to edit the mediawiki namespace message? [19:34:33] mvolz: Also, thank you for bugging me. :-) [19:34:36] np [19:34:58] or I'll just get Krenair to do it [19:34:59] :) [19:35:35] hi [19:35:42] When I learn coding, I'll apply to work with your team, James. [19:36:25] 10Citoid, 10TemplateData: Add ability to request base types in citoid, and offer use of both in extension for backwards compatibility until all templateData has been updated. - https://phabricator.wikimedia.org/T114515#1698302 (10Mvolz) [19:37:04] what do you want me to do mvolz? [19:37:37] oh nothing right now but I'll need to edit a medaiwiki namespace message on a few wikis for citoid [19:37:48] you have The Power, no ?:) [19:38:39] 10Citoid, 10TemplateData: Add ability to request base types in citoid, and offer use of both in extension for backwards compatibility until all templateData has been updated. - https://phabricator.wikimedia.org/T114515#1698312 (10Mvolz) As per James in chat, plan is to do option 2 but offer the use of both fie... [19:41:19] 10Citoid, 10TemplateData: Add ability to request base types in citoid, and offer use of both in extension for backwards compatibility until all templateData has been updated. - https://phabricator.wikimedia.org/T114515#1698317 (10Mvolz) a:3Mvolz [19:41:25] (03PS1) 10Esanders: Consistently use spaces inside brackets in CSS [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/243234 [19:43:50] (03CR) 10jenkins-bot: [V: 04-1] Consistently use spaces inside brackets in CSS [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/243234 (owner: 10Esanders) [19:45:38] mvolz, sure, no problem [19:54:36] 10VisualEditor, 10VisualEditor-MediaWiki, 10WikiEditor, 10RESTBase, and 2 others: Provide a way for the user to switch between VisualEditor and wikitext source editor modes without saving - https://phabricator.wikimedia.org/T49779#1698346 (10Jdforrester-WMF) [19:54:51] 10VisualEditor, 10Parsoid, 10RESTBase: Provide a mechanism in RESTbase for switching between WT and DOM - https://phabricator.wikimedia.org/T104663#1698349 (10Jdforrester-WMF) p:5Triage>3High [19:58:44] (03PS2) 10Esanders: Ensure full error message is shown when inspector is closed [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/243167 (https://phabricator.wikimedia.org/T114480) [20:00:45] (03CR) 10Tchanders: [C: 031] Ensure full error message is shown when inspector is closed [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/243167 (https://phabricator.wikimedia.org/T114480) (owner: 10Esanders) [20:00:55] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic: Provide a single edit tab which has both visual and wikitext modes and allows on-the-fly switching between them - https://phabricator.wikimedia.org/T102398#1698364 (10Jdforrester-WMF) [20:01:12] (03CR) 10Tchanders: [C: 031] Pass staging state through Document#commit to ve.dm.Node update event [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/243166 (https://phabricator.wikimedia.org/T114480) (owner: 10Esanders) [20:02:07] James_F, meeting? [20:02:38] how about a h-o? [20:03:14] Hey. [20:03:41] Err, we could [20:03:48] * James_F hunts for a room. [20:04:08] * James_F was expecting an IRC meeting. [20:04:56] could you add a h-o? [20:05:01] there isn't any in the invite yet [20:06:05] Added. [20:09:59] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic: Provide a single edit tab which has both visual and wikitext modes and allows on-the-fly switching between them - https://phabricator.wikimedia.org/T102398#1698377 (10Jdforrester-WMF) [20:16:37] 10VisualEditor: [Regression pre-wmf.2] Red highlight appearing instead of blue on selecting an image - https://phabricator.wikimedia.org/T114527#1698396 (10Ryasmeen) 3NEW [20:16:44] James_F: whoa, are we meeting right now? [20:16:56] didn't see your invite until just now [20:17:41] cscott: It's just in case you might be interested. [20:20:45] gah, hangouts hates me it seems. [20:20:55] cscott: No worries. I can talk about it here if you're interested. [20:25:13] gwicke, James_F: wouldn't some of the offset stuff from T114402 be useful for this stashing scheme? [20:26:26] ok, i'll chat in IRC [20:26:37] hi [20:26:49] for PST i think we could come up with a or tag in parsoid that we agree just to ignore [20:27:09] something like or whatever other wikitext stuff we want to ignore. [20:27:20] Could do. [20:27:23] it would be uneditable in VE, but have a little icon like we use for comments or whatever. [20:27:36] cscott: But that'd do it for link trails etc. too. [20:27:41] just a placeholder we agree to not lose. [20:27:44] Pipe trick, even. [20:27:54] [[Foo (bar)|]] would be alienated on switch. [20:28:29] maybe. we'd probably have to consider each PST case separately to see what makes sense. [20:29:04] erm. which might mean implementing PST in parsoid somehow, just so we can recognize and encapsulate it. [20:29:15] sigh. [20:29:31] wouldn't be the *worst* thing. [20:29:49] I think T114402 is still relevant, if you want to make a nice wikitext editor for the switch. [20:30:19] you're going to still want collapsable templates or what have you. which means that your stash has to maintain just enough information about offsets to let you fix them up as you switch. [20:30:39] it's worth planning for that from the outset, i think. [20:31:08] i mean, if you wanted to get fancy, you could have a live-updating HTML/wikitext editor like the one in my wikimania demo. [20:31:25] it might be really helpful for development to do that, actually, since you could see in real time when the offsets get screwed [20:32:32] with a proper offset map, you could translate every cursor movement in VE into a corresponding movement in the wikitext; again, which would help with this patching scheme but also help debug the offsets necessary for the patching scheme. [20:53:34] 10VisualEditor, 10VisualEditor-MediaWiki, 7Epic: Change VE integration to only use one edit tab - https://phabricator.wikimedia.org/T114530#1698519 (10Jdforrester-WMF) 3NEW [20:53:46] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic: Provide a single edit tab which has both visual and wikitext modes and allows on-the-fly switching between them - https://phabricator.wikimedia.org/T102398#1698526 (10Jdforrester-WMF) [20:54:08] 10VisualEditor, 10VisualEditor-MediaWiki, 7Epic: Change VE integration to only use one edit tab - https://phabricator.wikimedia.org/T114530#1698519 (10Jdforrester-WMF) [20:54:10] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic: Provide a single edit tab which has both visual and wikitext modes and allows on-the-fly switching between them - https://phabricator.wikimedia.org/T102398#1363629 (10Jdforrester-WMF) [20:54:13] 10VisualEditor, 10VisualEditor-MediaWiki: VisualEditor: VE should use the existing "action" URL parameter instead of the new "veaction" - https://phabricator.wikimedia.org/T54281#1698529 (10Jdforrester-WMF) [20:54:25] 10VisualEditor, 10VisualEditor-MediaWiki, 7Epic: Change VE integration to only use one edit tab - https://phabricator.wikimedia.org/T114530#1698519 (10Jdforrester-WMF) [20:54:27] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic: Provide a single edit tab which has both visual and wikitext modes and allows on-the-fly switching between them - https://phabricator.wikimedia.org/T102398#1363629 (10Jdforrester-WMF) [20:54:30] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic: Provide a modern wikitext editor - https://phabricator.wikimedia.org/T104479#1698535 (10Jdforrester-WMF) [20:55:11] 10VisualEditor, 10VisualEditor-MediaWiki, 7Epic: Change VE integration to only use one edit tab - https://phabricator.wikimedia.org/T114530#1698519 (10Jdforrester-WMF) [20:55:13] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic: Provide a single edit tab which has both visual and wikitext modes and allows on-the-fly switching between them - https://phabricator.wikimedia.org/T102398#1363629 (10Jdforrester-WMF) [20:55:16] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic: VisualEditor: Where VisualEditor is the primary editor, redlinks in read mode should open VE (not wikitext editor) - https://phabricator.wikimedia.org/T55441#1698536 (10Jdforrester-WMF) [20:56:15] 10VisualEditor, 10VisualEditor-MediaWiki: VE should intercept all calls to action=edit (undo, diffs, etc.) to apply consistently for user expectation - https://phabricator.wikimedia.org/T114531#1698539 (10Jdforrester-WMF) 3NEW [20:56:32] 10VisualEditor, 10VisualEditor-MediaWiki: VE should intercept all calls to action=edit (undo, diffs, etc.) to apply consistently for user expectation - https://phabricator.wikimedia.org/T114531#1698548 (10Jdforrester-WMF) [20:56:33] 10VisualEditor, 10VisualEditor-MediaWiki: The undo link in the page history leads to the source editor and not VisualEditor - https://phabricator.wikimedia.org/T78550#1698547 (10Jdforrester-WMF) [20:58:17] 10VisualEditor, 10VisualEditor-MediaWiki: VE should intercept all calls to action=edit (undo, diffs, etc.) to apply consistently for user expectation - https://phabricator.wikimedia.org/T114531#1698539 (10Jdforrester-WMF) [20:58:19] 10VisualEditor, 10VisualEditor-MediaWiki: VisualEditor is not the editor linked from the diff page - https://phabricator.wikimedia.org/T89060#1698550 (10Jdforrester-WMF) [20:58:56] 10VisualEditor, 10VisualEditor-MediaWiki: VE should intercept all calls to action=edit (undo, diffs, etc.) to apply consistently for user expectation - https://phabricator.wikimedia.org/T114531#1698553 (10Jdforrester-WMF) [20:58:58] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic: Provide a single edit tab which has both visual and wikitext modes and allows on-the-fly switching between them - https://phabricator.wikimedia.org/T102398#1698552 (10Jdforrester-WMF) [20:59:05] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic: Provide a single edit tab which has both visual and wikitext modes and allows on-the-fly switching between them - https://phabricator.wikimedia.org/T102398#1363629 (10Jdforrester-WMF) [20:59:23] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic: Provide a single edit tab which has both visual and wikitext modes and allows on-the-fly switching between them - https://phabricator.wikimedia.org/T102398#1698557 (10Jdforrester-WMF) p:5Normal>3High [21:12:46] Krenair: So… https://phabricator.wikimedia.org/T102398 :-D [21:13:10] oh you've reorganised all of the blockers? [21:13:49] Krenair: And created a few. [21:13:54] Krenair: It's going to be a lot of work. [21:14:04] Story Points: 8 [21:14:04] Krenair: Not all of it for you. :-) [21:14:22] Krenair: Points are distributed through the stack. And also mostly not yet applied. [21:14:29] 10VisualEditor, 10VisualEditor-MediaWiki, 7Epic: Change VE integration to only use one edit tab - https://phabricator.wikimedia.org/T114530#1698579 (10Jdforrester-WMF) [21:14:33] 10VisualEditor, 10VisualEditor-EditingTools, 10OOjs-UI, 10UI-Standardization, and 2 others: Gray for "inactive" elements in the toolbar is too light - https://phabricator.wikimedia.org/T89271#1698582 (10violetto) FYI, currently being discussed here T109915 [21:14:37] 10VisualEditor, 10VisualEditor-MediaWiki: VE should intercept all calls to action=edit (undo, diffs, etc.) to apply consistently for user expectation - https://phabricator.wikimedia.org/T114531#1698584 (10Jdforrester-WMF) [21:14:45] 10VisualEditor, 10VisualEditor-MediaWiki: [Regression pre-wmf.2] Red highlight appearing instead of blue on selecting an image - https://phabricator.wikimedia.org/T114527#1698586 (10Jdforrester-WMF) p:5Triage>3Unbreak! [21:16:06] 10VisualEditor, 10VisualEditor-MediaWiki, 10Math, 5Patch-For-Review: [Regression pre-wmf.2] There is no way to edit a wrong LaTeX formula from VE since it is not appearing as an inspectable node with context menu over it - https://phabricator.wikimedia.org/T114455#1698598 (10Jdforrester-WMF) 5Open>3Reso... [21:18:32] 10VisualEditor, 10VisualEditor-EditingTools, 10OOjs-UI, 10UI-Standardization, and 2 others: Gray for "inactive" elements in the toolbar is too light - https://phabricator.wikimedia.org/T89271#1698613 (10violetto) [21:23:10] (03CR) 10Esanders: [C: 031] Introducing template format [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/243138 (https://phabricator.wikimedia.org/T64217) (owner: 10Eranroz) [21:24:05] 10VisualEditor, 10VisualEditor-EditingTools, 10OOjs-UI, 10UI-Standardization, and 2 others: Gray for "inactive" elements in the toolbar is too light - https://phabricator.wikimedia.org/T89271#1698625 (10violetto) [21:37:35] 10VisualEditor, 10Phlogiston: Generate Burnup chart with maintenance shown below the axis - https://phabricator.wikimedia.org/T113270#1698670 (10Jdforrester-WMF) [22:49:00] 10Citoid, 10VisualEditor, 7Verified, 5WMF-deploy-2015-10-06_(1.27.0-wmf.2): [Regression] Citoid won't remember last used tab (auto/manual/re-use) on inspector - https://phabricator.wikimedia.org/T114268#1698935 (10Ryasmeen) [22:49:23] 10VisualEditor, 10VisualEditor-EditingTools, 10OOjs-UI, 10UI-Standardization, and 2 others: Gray for "inactive" elements in the toolbar is too light - https://phabricator.wikimedia.org/T89271#1698939 (10Isarra) Regarding what quiddity said, there's a problematic balance that needs to be found between makin... [23:07:31] 10VisualEditor: Cursoring left next to an about-grouped alien leaves the cursor inside it - https://phabricator.wikimedia.org/T114545#1698972 (10Esanders) 3NEW a:3dchan [23:22:44] 10VisualEditor, 10VisualEditor-EditingTools, 10OOjs-UI, 10UI-Standardization, and 2 others: Gray for "inactive" elements in the toolbar is too light - https://phabricator.wikimedia.org/T89271#1698992 (10violetto) > The problem is when they're consistently legible due to sufficient contrast, they tend to al...