[09:29:27] 10VisualEditor, 10VisualEditor-MediaWiki: Find a way to visualize a space as sortkey for a category - https://phabricator.wikimedia.org/T114635#1701545 (10Schnark) 3NEW [09:30:31] 10VisualEditor, 10VisualEditor-MediaWiki: Expose the configuration for the toolbar containing help and meta - https://phabricator.wikimedia.org/T114637#1701562 (10Schnark) 3NEW [10:21:20] 10VisualEditor: "Visual anchoring" for images - https://phabricator.wikimedia.org/T114369#1701643 (10Elitre) T70709 is somehow related. [10:21:45] 10Citoid, 10VisualEditor: Add ability to request base types in citoid, and offer use of both in extension for backwards compatibility until all templateData has been updated. - https://phabricator.wikimedia.org/T114515#1701645 (10Mvolz) [10:22:17] 10Citoid, 7Technical-Debt: Switch from tabs to spaces - https://phabricator.wikimedia.org/T112507#1701648 (10Mvolz) a:3Mvolz [11:52:17] (03CR) 10Esanders: [C: 032] ve.ui.MWParameterPage: Use more natural DOM order for text field and buttons [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/243527 (https://phabricator.wikimedia.org/T114562) (owner: 10Bartosz Dziewoński) [11:54:45] 10VisualEditor, 10VisualEditor-MediaWiki, 10OOjs-UI, 5Patch-For-Review: Focusing a template field or adding a new field focusses the info icon, not the text widget - https://phabricator.wikimedia.org/T114562#1701784 (10Esanders) Merged DOM order fix, but I think we should merge https://gerrit.wikimedia.or... [11:55:06] (03Merged) 10jenkins-bot: ve.ui.MWParameterPage: Use more natural DOM order for text field and buttons [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/243527 (https://phabricator.wikimedia.org/T114562) (owner: 10Bartosz Dziewoński) [11:59:33] Hi, can anyone help me with the right way to make changes to the model in Visual Editor? I am making an extension, and have successfully registered ve.dm (model) and ve.ce (view) nodes, but am not quite clear on how to make changes. It looks like I need to create a transaction and call model.doc.commit(myTransaction)? [12:00:50] Also, the documentation indicates that 'surfaces' are meant to be responsible for this, but none of the existing pieces seem to use them? [13:14:55] 10VisualEditor: When adding a label to two consecutive autonumbered links, the second link disappears - https://phabricator.wikimedia.org/T114643#1701917 (10Elitre) 3NEW [13:17:32] 10VisualEditor, 10VisualEditor-MediaWiki-Links: When adding a label to two consecutive autonumbered links, the second link disappears - https://phabricator.wikimedia.org/T114643#1701929 (10Elitre) [14:00:59] (03CR) 10Bartosz Dziewoński: [C: 031] "Pending OOUI update (jsduck won't let us merge it)." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/243388 (https://phabricator.wikimedia.org/T114562) (owner: 10Esanders) [14:59:14] (03CR) 10Jforrester: [C: 032] Consistently use spaces inside brackets in CSS [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/243234 (owner: 10Esanders) [14:59:21] (03CR) 10Jforrester: [C: 032] Consistently use spaces inside brackets in CSS [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/243224 (owner: 10Esanders) [15:00:31] (03CR) 10Jforrester: "Aren't there icons we can use in OOUI?" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/243155 (owner: 10Esanders) [15:02:27] (03Merged) 10jenkins-bot: Consistently use spaces inside brackets in CSS [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/243234 (owner: 10Esanders) [15:02:29] (03Merged) 10jenkins-bot: Consistently use spaces inside brackets in CSS [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/243224 (owner: 10Esanders) [15:03:09] (03PS1) 10Esanders: ReferenceContextItem: Factor out getReferenceNode and use correct node [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/243669 [15:10:42] (03CR) 10Esanders: [C: 04-1] "CSS needs some work:" (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/238380 (https://phabricator.wikimedia.org/T108620) (owner: 10Alex Monk) [15:12:20] (03CR) 10Jforrester: [C: 032] Toolbar config: Prevent 'Table' from moving after menu expand [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/243504 (owner: 10Esanders) [15:14:49] (03Merged) 10jenkins-bot: Toolbar config: Prevent 'Table' from moving after menu expand [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/243504 (owner: 10Esanders) [15:19:13] 10VisualEditor, 10VisualEditor-MediaWiki: VisualEditor Edit bar font size issue in 1.25 - https://phabricator.wikimedia.org/T104903#1702145 (10noboddy) Does anybody have a solution to this? [15:24:47] 10VisualEditor, 10VisualEditor-ContentEditable: VisualEditor: Sometimes it's somehow possible for VE/Parsoid to insert a
at the start of a heading - https://phabricator.wikimedia.org/T53444#1702176 (10Elitre) If you want an example of how that happens on a private wiki, see above line 114 [[ https://offic... [15:44:34] 10VisualEditor, 10VisualEditor-MediaWiki: VisualEditor Edit bar font size issue in 1.25 - https://phabricator.wikimedia.org/T104903#1702249 (10Rosencrantz) Honestly I just added that bit above to my Common.css. It's not a great solution, but it works. [15:49:45] Kemayo: Hey, could you try to `git review` a patch (doesn't matter what, just a "hello" edit) into gerrit? Trying to give you merge access but it doesn't think you're real yet, and I'm wildly guess this might be why. [15:52:00] Kemayo: Belay that, we're investigating. [15:53:12] Consider it belayed. [15:53:25] :-) [15:54:13] Kemayo: Found it; your shell name is kemayo not DLynch, hence the confusion. :-) [15:54:46] Ah, I'm being confusing. Got it. :D [15:54:57] Kemayo, Thalia|away, and ferdbold-who-isn't-here: You should all now have merge rights in all the main repos. Please use carefully, etc. etc. [15:55:08] * MatmaRex appears [15:55:11] more sneak hires? [15:55:11] https://www.mediawiki.org/wiki/Gerrit/%2B2 is the main documentation. [15:55:16] MatmaRex: Sneak? [16:01:48] edsanders: Any chance https://gerrit.wikimedia.org/r/#/c/240116/ could be de-WIP'ed? Don't think it needs an experimental module; we now have the error handling done, at least as a first pass. [16:09:07] It's probably going to take me a while before I stop going `arc diff` instead of `git review` on sheer muscle memory. [16:09:19] :-) [16:09:31] (03CR) 10Tchanders: [C: 032] Ensure full error message is shown when inspector is closed [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/243167 (https://phabricator.wikimedia.org/T114480) (owner: 10Esanders) [16:09:36] The vague plan is for us to move to Phab at some point. [16:09:45] (For code review.) [16:10:11] (03CR) 10Jforrester: [C: 04-2] "Isn't the core pull-through needed first?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/243167 (https://phabricator.wikimedia.org/T114480) (owner: 10Esanders) [16:10:44] (03CR) 10Jforrester: [C: 032] Pass staging state through Document#commit to ve.dm.Node update event [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/243166 (https://phabricator.wikimedia.org/T114480) (owner: 10Esanders) [16:11:39] Kemayo: You'll adapt just in time for us to move code review off Gerrit :) [16:12:36] :-) [16:12:36] Since my adaptation speed is clearly a core metric for our migration, I'll have to start taking bribes from the pro- and anti- Phabricator camps. [16:14:02] (03CR) 10Jforrester: [C: 032] Fix ve.ce.Document HTML tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/243511 (owner: 10Esanders) [16:14:24] (03CR) 10Jforrester: [C: 032] Wrap
s so their margins are clickable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/243509 (https://phabricator.wikimedia.org/T52770) (owner: 10Esanders) [16:15:20] (03Merged) 10jenkins-bot: Pass staging state through Document#commit to ve.dm.Node update event [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/243166 (https://phabricator.wikimedia.org/T114480) (owner: 10Esanders) [16:17:42] (03Merged) 10jenkins-bot: Fix ve.ce.Document HTML tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/243511 (owner: 10Esanders) [16:18:31] (03Merged) 10jenkins-bot: Wrap
s so their margins are clickable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/243509 (https://phabricator.wikimedia.org/T52770) (owner: 10Esanders) [16:21:48] (03CR) 10Jforrester: [C: 032] DimensionsWidget: Fix alignment of labels [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/242868 (owner: 10Esanders) [16:22:18] (03CR) 10Jforrester: [C: 031] Pass generated content error to inspector [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/243599 (https://phabricator.wikimedia.org/T113172) (owner: 10Tchanders) [16:23:18] Kemayo: *grins*. [16:23:30] (03CR) 10Paladox: [C: 04-1] "Needs rebase." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/215003 (https://phabricator.wikimedia.org/T109170) (owner: 10Esanders) [16:24:38] 10VisualEditor, 10VisualEditor-MediaWiki: VisualEditor Edit bar font size issue in 1.25 - https://phabricator.wikimedia.org/T104903#1702453 (10noboddy) Thank you Rosenkrantz, I'll try that [16:28:07] edsanders: Does Thalia|away want to use her shiny new +2 powers? https://gerrit.wikimedia.org/r/#/c/243523/ [16:35:54] edsanders: (And join IRC.) [16:55:27] (03PS1) 10Jforrester: Update VE core submodule to master (8feaeef) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/243690 [16:55:43] edsanders: Also ^^^ [16:56:34] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (8feaeef) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/243690 (owner: 10Jforrester) [16:57:24] (03PS2) 10Jforrester: Update VE core submodule to master (8feaeef) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/243690 [17:05:07] (03CR) 10Esanders: [C: 032] Update VE core submodule to master (8feaeef) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/243690 (owner: 10Jforrester) [17:07:37] (03Merged) 10jenkins-bot: Update VE core submodule to master (8feaeef) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/243690 (owner: 10Jforrester) [17:15:08] Whee. [17:15:42] (03PS3) 10Jforrester: Ensure full error message is shown when inspector is closed [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/243167 (https://phabricator.wikimedia.org/T114480) (owner: 10Esanders) [17:15:48] (03CR) 10Jforrester: [C: 032] Ensure full error message is shown when inspector is closed [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/243167 (https://phabricator.wikimedia.org/T114480) (owner: 10Esanders) [17:16:35] edsanders: https://gerrit.wikimedia.org/r/#/c/243599/ in core and thus https://gerrit.wikimedia.org/r/#/c/243600/ in MW would be smashing to get into this week's release too. [17:18:11] (03Merged) 10jenkins-bot: Ensure full error message is shown when inspector is closed [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/243167 (https://phabricator.wikimedia.org/T114480) (owner: 10Esanders) [17:19:30] (03CR) 10Jforrester: [C: 031] Store text inputs to find and replace between sessions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/243501 (owner: 10Esanders) [17:21:00] 10VisualEditor, 10VisualEditor-MediaWiki, 10Math, 5WMF-deploy-2015-10-06_(1.27.0-wmf.2): [Regression pre-wmf.2] There is no way to edit a wrong LaTeX formula from VE since it is not appearing as an inspectable node with context menu over it - https://phabricator.wikimedia.org/T114455#1702734 (10Jdforrester-... [17:21:21] 10VisualEditor, 10VisualEditor-EditingTools, 5WMF-deploy-2015-10-06_(1.27.0-wmf.2): Render an error in generated content on closing the inspector - https://phabricator.wikimedia.org/T114480#1702736 (10Jdforrester-WMF) 5Open>3Resolved [17:21:34] 10VisualEditor, 10VisualEditor-ContentEditable, 5WMF-deploy-2015-10-06_(1.27.0-wmf.2): Horizontal lines (----,
) extremely hard to delete - https://phabricator.wikimedia.org/T52770#1702738 (10Jdforrester-WMF) 5Open>3Resolved a:3Esanders [17:22:51] (03CR) 10Jforrester: [C: 031] "Let's merge this after the cut tomorrow." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/242894 (owner: 10Esanders) [17:25:02] edsanders, how is https://gerrit.wikimedia.org/r/#/c/242894/5 breaking exactly? [17:25:50] Krenair: Any GCN without a getHashObjectForRendering method will be rather broken. [17:26:08] Krenair, at the moment we are using that model hash to lookup the generated content in toDomElements [17:27:14] so the fact GCN's no longer populate using the model hash means they will have nothing to lookup [17:27:29] ah, yeah.. [17:27:37] I think it only matters for clipboard mode [17:27:45] (03CR) 10Alex Monk: [C: 031] [BREAKING CHANGE] GeneratedContentNode: Introduce new hash for rendering [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/242894 (owner: 10Esanders) [17:28:06] if it fails lookup for conversion it just falls back to re-rendering the DOM nodes, but that might break selser (data-parsoid dropped) [17:28:52] because we no longer put anything in the store for the model, the follow-up MW patches remove the hash comparison (index===originalIndex) [17:29:04] and use dataMW === originalDataMw instead [17:35:44] (03CR) 10Esanders: [C: 04-1] Pass generated content error to inspector (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/243599 (https://phabricator.wikimedia.org/T113172) (owner: 10Tchanders) [17:38:43] (03CR) 10Esanders: [C: 031] "As the error message consists of 3 DOM nodes (wrapper, icon, label) and an internal state (expanded, collapsed) it's a good candidate for " [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/243600 (https://phabricator.wikimedia.org/T113172) (owner: 10Tchanders) [17:45:41] (03PS2) 10Tchanders: Pass generated content error to inspector [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/243599 (https://phabricator.wikimedia.org/T113172) [17:53:03] 10VisualEditor, 10VisualEditor-MediaWiki, 5WMF-deploy-2015-10-06_(1.27.0-wmf.2): [Regression pre-wmf.2] Red highlight appearing instead of blue on selecting an image - https://phabricator.wikimedia.org/T114527#1702943 (10Jdforrester-WMF) 5Open>3Resolved [17:54:46] 10VisualEditor, 10Score, 7I18n, 7RTL, 5WMF-deploy-2015-10-06_(1.27.0-wmf.2): The element that show Lilypond errors in VisualEditor in English must English language and direction definition - https://phabricator.wikimedia.org/T113935#1702965 (10Jdforrester-WMF) 5Open>3Resolved a:3Esanders [17:55:07] 10VisualEditor, 10VisualEditor-MediaWiki, 5WMF-deploy-2015-10-06_(1.27.0-wmf.2): LiveExtensionInspector doesn't call updateMwData when closing the inspector - https://phabricator.wikimedia.org/T113078#1702968 (10Jdforrester-WMF) 5Open>3Resolved [17:55:58] 10VisualEditor, 10VisualEditor-MediaWiki, 10Score, 5WMF-deploy-2015-10-06_(1.27.0-wmf.2): Improve the Score inspector interface by splitting into tabs - https://phabricator.wikimedia.org/T114227#1702970 (10Jdforrester-WMF) 5Open>3Resolved [17:56:52] 10VisualEditor, 6Collaboration-Team-Backlog, 10ContentTranslation-cxserver, 10Flow, and 5 others: bodyOnly is now body_only - https://phabricator.wikimedia.org/T114185#1702976 (10Jdforrester-WMF) [17:57:10] 10VisualEditor, 6Collaboration-Team-Backlog, 10ContentTranslation-cxserver, 10Flow, and 5 others: bodyOnly is now body_only - https://phabricator.wikimedia.org/T114185#1702977 (10Jdforrester-WMF) 5Open>3Resolved a:3Jdforrester-WMF I'll mark this as provisionally closed. [17:57:11] (03CR) 10Esanders: [C: 032] Pass generated content error to inspector [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/243599 (https://phabricator.wikimedia.org/T113172) (owner: 10Tchanders) [17:58:10] James_F, https://gerrit.wikimedia.org/r/#/c/242894/5 is causing a bug btw [17:58:32] edsanders: Will cause a bug? Or failing to merge it will keep a bug? [17:58:33] although not a major one, I guess [17:58:37] *fixing a bug [17:58:51] Which one? Want me to whip up a Phab ticket? [17:59:29] changes to non-rendered attributes (which ATM is just 'id' in math node) don't get saved [17:59:44] Oh, ick. But yeah, not worth panicking over. [17:59:55] no [17:59:59] (03PS1) 10Jforrester: ve.ui.MWParameterPage: Use more natural DOM order for text field and buttons [extensions/VisualEditor] (wmf/1.27.0-wmf.1) - 10https://gerrit.wikimedia.org/r/243704 (https://phabricator.wikimedia.org/T114562) [18:00:32] (although we'll be adding more soon, e.g. all the audio attributes in Score) [18:00:53] 10VisualEditor, 10VisualEditor-MediaWiki: Changes to non-rendered attributes of GeneratedContentNodes don't get saved - https://phabricator.wikimedia.org/T114689#1703021 (10Jdforrester-WMF) 3NEW a:3Esanders [18:00:53] Yeah. [18:00:57] (03Merged) 10jenkins-bot: Pass generated content error to inspector [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/243599 (https://phabricator.wikimedia.org/T113172) (owner: 10Tchanders) [18:01:01] 10VisualEditor, 10VisualEditor-MediaWiki: Changes to non-rendered attributes of GeneratedContentNodes don't get saved - https://phabricator.wikimedia.org/T114689#1703030 (10Jdforrester-WMF) [18:01:18] edsanders: OK for me to add the task? [18:01:41] 10VisualEditor, 10VisualEditor-MediaWiki, 10OOjs-UI, 5WMF-deploy-2015-10-06_(1.27.0-wmf.2): Focusing a template field or adding a new field focusses the info icon, not the text widget - https://phabricator.wikimedia.org/T114562#1703036 (10Jdforrester-WMF) 5Open>3Resolved [18:03:56] 10VisualEditor: [Regression ?] Context menu for link inspector does not appear after typing something after the link unless user goes to next line - https://phabricator.wikimedia.org/T114333#1703055 (10Jdforrester-WMF) I can't reproduce now. Can you? [18:04:07] 10VisualEditor, 10VisualEditor-MediaWiki-Links: [Regression ?] Context menu for link inspector does not appear after typing something after the link unless user goes to next line - https://phabricator.wikimedia.org/T114333#1703056 (10Jdforrester-WMF) 5Open>3stalled [18:11:01] sure [18:23:59] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 7Design: The link dialog expands over the visible part of the page - https://phabricator.wikimedia.org/T114614#1703116 (10Spage) p:5Triage>3High I'm seeing this too on mw.org. The list wasn't that long before, it fit within the window. I'm also having the... [18:24:37] ^ I'm noticing weird regression in Link inspector on mw.org, the above is the closest Phab ticket I could find. [18:36:30] (03PS6) 10Jforrester: [BREAKING CHANGE] GeneratedContentNode: Introduce new hash for rendering [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/242894 (https://phabricator.wikimedia.org/T114689) (owner: 10Esanders) [18:39:44] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 7Design: Maximum height of the link editor should take into account the toolbar height too - https://phabricator.wikimedia.org/T114614#1703206 (10Jdforrester-WMF) p:5High>3Normal [18:47:50] (03CR) 10Esanders: [C: 032] ve.ui.MWParameterPage: Use more natural DOM order for text field and buttons [extensions/VisualEditor] (wmf/1.27.0-wmf.1) - 10https://gerrit.wikimedia.org/r/243704 (https://phabricator.wikimedia.org/T114562) (owner: 10Jforrester) [18:58:03] (03Merged) 10jenkins-bot: ve.ui.MWParameterPage: Use more natural DOM order for text field and buttons [extensions/VisualEditor] (wmf/1.27.0-wmf.1) - 10https://gerrit.wikimedia.org/r/243704 (https://phabricator.wikimedia.org/T114562) (owner: 10Jforrester) [19:40:36] 10VisualEditor: [Regression pre-wmf.2] Template descriptions are appearing beyond the Add a Template dialog - https://phabricator.wikimedia.org/T114310#1703356 (10Ryasmeen) 5Open>3Resolved [19:41:50] 10VisualEditor: [Regression pre-wmf.2] Template descriptions are appearing beyond the Add a Template dialog - https://phabricator.wikimedia.org/T114310#1703361 (10Jdforrester-WMF) [19:42:47] 10VisualEditor, 7Verified, 5WMF-deploy-2015-10-06_(1.27.0-wmf.2): [Regression pre-wmf.2] Template descriptions are appearing beyond the Add a Template dialog - https://phabricator.wikimedia.org/T114310#1703373 (10Ryasmeen) 5duplicate>3Resolved [19:43:45] 10VisualEditor, 10VisualEditor-MediaWiki, 7Verified, 5WMF-deploy-2015-10-06_(1.27.0-wmf.2): [Regression pre-wmf.2] Red highlight appearing instead of blue on selecting an image - https://phabricator.wikimedia.org/T114527#1703376 (10Ryasmeen) [19:44:33] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-extensions-GuidedTour, 5WMF-deploy-2015-10-06_(1.27.0-wmf.2): GuidedTour referencing a VE-MW renamed class - viewPageTarget - https://phabricator.wikimedia.org/T111842#1703377 (10Jdforrester-WMF) p:5Triage>3Normal [19:45:54] 10VisualEditor, 10VisualEditor-MediaWiki, 10Math, 7Verified, 5WMF-deploy-2015-10-06_(1.27.0-wmf.2): [Regression pre-wmf.2] There is no way to edit a wrong LaTeX formula from VE since it is not appearing as an inspectable node with context menu over it - https://phabricator.wikimedia.org/T114455#1703380 (1... [19:46:53] 10VisualEditor, 10VisualEditor-EditingTools, 7Verified, 5WMF-deploy-2015-10-06_(1.27.0-wmf.2): Render an error in generated content on closing the inspector - https://phabricator.wikimedia.org/T114480#1703383 (10Ryasmeen) [20:04:49] edsanders: Progress on https://gerrit.wikimedia.org/r/#/c/240116/ ? [20:11:49] (03PS1) 10Jforrester: Update VE core submodule to master (737a235) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/243745 [20:20:13] (03PS8) 10Esanders: [WIP] Image uploading [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/240116 (https://phabricator.wikimedia.org/T40030) [20:23:38] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Image uploading [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/240116 (https://phabricator.wikimedia.org/T40030) (owner: 10Esanders) [20:25:30] edsanders: … that qunit failure's a bit surprising. [20:26:01] (03CR) 10Jforrester: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/240116 (https://phabricator.wikimedia.org/T40030) (owner: 10Esanders) [20:53:21] (03CR) 10Jforrester: "Should be re-written to base on I1030442, adding a new tab for "My recent uploads" (and not as the default tab)." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/210831 (https://bugzilla.wikimedia.org/60398) (owner: 10MarkAHershberger) [21:14:31] edsanders: Any update? We really need to merge this in the next hour or so if we're going to test it enough. [21:14:39] sure [21:14:46] Sorry for the rush. [21:23:51] 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 5Patch-For-Review, 7Verified, 5WMF-deploy-2015-10-06_(1.27.0-wmf.2): Search for templates with no response fatals, doesn't ever tell the user it's given up - https://phabricator.wikimedia.org/T113647#1703675 (10Ryasmeen) [21:26:52] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Mobile, 5Patch-For-Review, and 2 others: "Value null is the wrong type for property "action.saveIntent.timing" (integer expected) " appears upon opening the Save dialog in mobile VE - https://phabricator.wikimedia.org/T109525#1703685 (10Rya... [21:37:20] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: [Regression ?] The reference notes are not appearing for external link only the external icon for mobile VE - https://phabricator.wikimedia.org/T114713#1703717 (10Ryasmeen) 3NEW [21:37:51] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: [Regression ?] The reference notes are not appearing for external links only the external link icons in mobile VE - https://phabricator.wikimedia.org/T114713#1703726 (10Ryasmeen) [21:44:08] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: [Regression ?] Newline is appearing before every listed item in mobile VE - https://phabricator.wikimedia.org/T114716#1703745 (10Ryasmeen) 3NEW [21:55:29] James_F, if I get a filename exists error, changing the filename doesn't fix it [22:02:06] is there an MD5 check or something [22:13:25] (03PS9) 10Esanders: Add image upload tab to media dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/240116 (https://phabricator.wikimedia.org/T40030) [22:15:34] (03CR) 10Esanders: "Ready to go" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/240116 (https://phabricator.wikimedia.org/T40030) (owner: 10Esanders) [22:48:06] (03CR) 10Esanders: [C: 032] Update VE core submodule to master (737a235) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/243745 (owner: 10Jforrester) [22:50:52] (03CR) 10Esanders: [C: 032] Add error element to MWLiveExtensionInspector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/243600 (https://phabricator.wikimedia.org/T113172) (owner: 10Tchanders) [22:51:06] (03Merged) 10jenkins-bot: Update VE core submodule to master (737a235) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/243745 (owner: 10Jforrester) [22:53:22] (03Merged) 10jenkins-bot: Add error element to MWLiveExtensionInspector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/243600 (https://phabricator.wikimedia.org/T113172) (owner: 10Tchanders) [23:07:01] 10VisualEditor, 10VisualEditor-MediaWiki, 10Math, 10MediaWiki-Gallery, and 3 others: With extension editors, show rendering errors inside the inspector, not the ce node - https://phabricator.wikimedia.org/T113172#1703999 (10Jdforrester-WMF) 5Open>3Resolved [23:07:06] 10VisualEditor, 10VisualEditor-MediaWiki, 10Math, 10MediaWiki-Gallery, and 3 others: With extension editors, show rendering errors inside the inspector, not the ce node - https://phabricator.wikimedia.org/T113172#1656767 (10Jdforrester-WMF) Nice. [23:08:58] (03CR) 10Jforrester: [C: 031] Add image upload tab to media dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/240116 (https://phabricator.wikimedia.org/T40030) (owner: 10Esanders) [23:13:02] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media, 6Multimedia: VisualEditor: Initiate file upload by drag-and-drop - https://phabricator.wikimedia.org/T40031#1704030 (10Jdforrester-WMF) [23:13:04] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media, 6Multimedia, and 2 others: Way in VisualEditor to initiate Commons file uploading, and insert image on completion - https://phabricator.wikimedia.org/T40030#1704031 (10Jdforrester-WMF) [23:16:16] Krenair: Any chance you'll want to merge https://gerrit.wikimedia.org/r/240116 today? :-) [23:16:50] I haven't reviewed that one yet [23:16:51] I should do that [23:17:03] Thank you. [23:17:15] From quick testing I was OK with it, FWIW. [23:17:31] I've got rather a lot of CR requests lately and I'm sure a few things have gone missing [23:17:37] * James_F nods. [23:17:49] This one's new, though. But very much appreciated if it could be merged before tomorrow. :-) [23:19:44] (03PS2) 10Jforrester: Add block/inline icons [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/243155 (owner: 10Esanders) [23:20:46] James_F, ah, now I know why I hadn't received anything :) [23:20:55] you asked me to review it within the last 10 minutes [23:21:01] Yeah. :-) [23:21:02] I last checked my inbox 15 minutes ago [23:42:33] (03CR) 10Esanders: "I don't think so. Where would we have used them before?" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/243155 (owner: 10Esanders) [23:45:46] (03CR) 10Jforrester: "I was thinking of the "Outline" and "Layout" icons in editing-advanced. They're different, but not that different." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/243155 (owner: 10Esanders) [23:56:16] (03CR) 10Mooeypoo: [C: 04-1] Introducing template format (038 comments) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/243138 (https://phabricator.wikimedia.org/T64217) (owner: 10Eranroz)