[00:00:48] 10VisualEditor, 6Design Research Backlog, 7Epic: Improve and streamline VisualEditor's user education features - https://phabricator.wikimedia.org/T101481#1704180 (10Jdforrester-WMF) [00:00:50] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-extensions-GuidedTour, 7Design: Change Welcome dialog content to more helpful message to new users based on the GuidedTour - https://phabricator.wikimedia.org/T89072#1704177 (10Jdforrester-WMF) 5Open>3declined a:3Jdforrester-WMF Overtaken by events. [00:02:03] 10VisualEditor, 10VisualEditor-MediaWiki: Allow PreviewElement to do live previews - https://phabricator.wikimedia.org/T114230#1704184 (10Jdforrester-WMF) [00:02:58] 10VisualEditor, 10VisualEditor-MediaWiki: Allow PreviewElement to do live previews - https://phabricator.wikimedia.org/T114230#1688956 (10Jdforrester-WMF) Is this done? [00:03:52] 10VisualEditor, 10VisualEditor-EditingTools, 7Verified, 5WMF-deploy-2015-10-06_(1.27.0-wmf.2): Render an error in generated content on closing the inspector - https://phabricator.wikimedia.org/T114480#1704190 (10Jdforrester-WMF) [00:03:54] 10VisualEditor, 10VisualEditor-MediaWiki, 10Math, 10MediaWiki-Gallery, and 3 others: With extension editors, show rendering errors inside the inspector, not the ce node - https://phabricator.wikimedia.org/T113172#1704191 (10Jdforrester-WMF) [00:03:57] 10VisualEditor: [Regression pre-wmf.2] Wrong LaTeX formula still renders as correct one after editing - https://phabricator.wikimedia.org/T114453#1704189 (10Jdforrester-WMF) [00:04:06] 10VisualEditor, 5WMF-deploy-2015-10-06_(1.27.0-wmf.2): [Regression pre-wmf.2] Wrong LaTeX formula still renders as correct one after editing - https://phabricator.wikimedia.org/T114453#1704192 (10Jdforrester-WMF) 5Open>3Resolved p:5Triage>3Normal a:3Tchanders [00:08:07] Regression...Where is the Cite-button in the reference-dialog? https://usercontent.irccloud-cdn.com/file/uaqrcNhd/Screenshot%202015-10-06%20at%2002.07.20.png [00:08:38] James_F ^ [00:10:56] Should I create a ticket, or am I missing something here? Elitre? [00:10:59] Josve05a: There isn't one. [00:11:07] There ahs been one... [00:11:09] has* [00:11:10] Josve05a: We took it away as it was too complicated and confusing users. [00:11:18] Josve05a: About a month ago. Maybe two. [00:11:40] Josve05a: What are you trying to do? Can't you just made a new reference? [00:11:50] no... I used to dubble press on references which was "bare" url, and fill in them with citoid, like 2 days ago... [00:12:06] double* [00:12:14] Cut-and-paste fixes that. [00:12:20] But I was sure it was a while ago. [00:12:33] Without having to fear breaking reused references (ref name) [00:13:01] I could just doubble press and replace the content. [00:14:02] now, I have to create a new reference, and find out the old ones ref name, and name this either the same, or add this new one where the old broken refs are [00:14:06] :/ [00:14:13] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 5WMF-deploy-2015-09-29_(1.27.0-wmf.1): Link dialog caused a scrolling frenzy - https://phabricator.wikimedia.org/T93229#1704221 (10Jdforrester-WMF) 5Open>3Resolved a:3Esanders [00:14:32] You can't name references. [00:14:53] You could copy-paste the resulting new reference into the old one. [00:15:08] Maybe we should instead have a button to magic-up an existing reference, though? [00:16:03] :D I like how you're thinking [00:19:39] Citoid is a great way to fix these https://en.wikipedia.org/w/index.php?title=Special:WhatLinksHere/Template:Cleanup-bare_URLs&hideredirs=1&hidelinks=1 [00:19:45] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 7Easy: Remove "Open" button from all four link inspectors - https://phabricator.wikimedia.org/T109646#1704234 (10Jdforrester-WMF) [00:19:49] * James_F nods. [00:20:03] https://en.wikipedia.org/w/index.php?title=Special%3AWhatLinksHere&hideredirs=1&hidelinks=1&target=Template%3ACleanup-bare+URLs&namespace=0 is probably better, FWIW. :_) [00:20:24] Talk-page mentions of the template shouldn't generally be 'fixed'. [00:20:55] * Josve05a nods in agreement [00:21:26] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-extensions-GuidedTour, 7Design: Change Welcome dialog content to more helpful message to new users based on the GuidedTour - https://phabricator.wikimedia.org/T89072#1704241 (10Quiddity) Focus moved to {T108620} instead. [00:25:02] 10VisualEditor, 10VisualEditor-MediaWiki-Templates: Extra blocks being displayed in VisualEditor - https://phabricator.wikimedia.org/T106573#1704244 (10Jdforrester-WMF) [00:25:04] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-References, 10VisualEditor-MediaWiki-Templates, 10Parsoid: Ref generating templates show reflists when edited - https://phabricator.wikimedia.org/T101553#1704245 (10Jdforrester-WMF) [00:26:33] 10VisualEditor, 6Design Research Backlog, 7Epic: Improve and streamline VisualEditor's user education features - https://phabricator.wikimedia.org/T101481#1704246 (10Neil_P._Quinn_WMF) I wrote this in response to an email asking what I meant by closing this; posting just in case someone else is curious: >I'... [00:27:09] 10VisualEditor, 10VisualEditor-MediaWiki, 7user-notice: Change Welcome dialogue content to more helpful message to new users - https://phabricator.wikimedia.org/T112354#1704248 (10Jdforrester-WMF) [00:27:10] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design: Encourage editors to use the built-in MediaWiki feedback tool when providing feedback - https://phabricator.wikimedia.org/T111759#1704249 (10Jdforrester-WMF) [00:27:13] 10VisualEditor, 10VisualEditor-MediaWiki, 7Easy: Harmonize some warning messages - https://phabricator.wikimedia.org/T99963#1704251 (10Jdforrester-WMF) [00:27:15] 10VisualEditor, 10VisualEditor-MediaWiki, 5Patch-For-Review, 7user-notice: On user's first use of VE-MW, provide a couple of educational pop-ups for links and for citations with some toolbar highlights to trigger them - https://phabricator.wikimedia.org/T108620#1704250 (10Jdforrester-WMF) [00:27:17] 10VisualEditor, 10WikiEditor, 6Design Research Backlog, 7Easy, 5Patch-For-Review: Tooltip text on the "Edit" and "Edit Source" tabs should be more helpful to new users - https://phabricator.wikimedia.org/T99271#1704253 (10Jdforrester-WMF) [00:27:19] 10VisualEditor, 10VisualEditor-MediaWiki-Links: Remove tooltips from search results in the link inspector - https://phabricator.wikimedia.org/T99312#1704252 (10Jdforrester-WMF) [00:27:21] 10VisualEditor, 6Community-Liaison, 7Documentation: Check and update VE Documentation - https://phabricator.wikimedia.org/T96237#1704254 (10Jdforrester-WMF) [00:27:29] 10VisualEditor, 6Design Research Backlog, 7Epic: Improve and streamline VisualEditor's user education features - https://phabricator.wikimedia.org/T101481#1704247 (10Jdforrester-WMF) [00:28:59] Krenair: https://gerrit.wikimedia.org/r/240116 maybe? :-) Also, how's the script doing? Should we ready the switch-over for tomorrow morning? [00:29:05] ("Morning" SF time.) [00:33:16] James_F, almost at 7 out of 8 [00:33:20] Nice. [00:33:25] So… maybe? [00:33:42] Maybe tomorrow evening. [00:33:46] * James_F nods. [00:34:44] 10Citoid, 10VisualEditor: Create a way to use citoid on existing references - https://phabricator.wikimedia.org/T114727#1704273 (10Josve05a) 3NEW [00:34:58] Josve05a: Thanks. :-) [00:35:06] 10Citoid, 10VisualEditor: Create a way to use citoid on existing references - https://phabricator.wikimedia.org/T114727#1704280 (10Josve05a) [00:35:13] :) [00:36:07] James_F, actually, maybe it could be done tomorrow morning [00:36:26] It'd be nice to do it earlier in the day, for the CLs. [00:36:47] Especially to avoid making a late-night call to revert, which'd suck. [00:36:55] Looks like it's been going for about 120 hours [00:37:02] 120/8=15 [00:37:13] 15 hours time = middle of the 'morning' swat [00:37:30] Yeah, but it's likely to go slower, not faster. [00:37:47] 10Citoid, 10VisualEditor: Use |jstor= in {{cite journal}} - https://phabricator.wikimedia.org/T114728#1704284 (10Josve05a) 3NEW [00:37:58] (With the higher load in the SF 'night'.) [00:38:10] I guess it wouldn't be the end of the world to switch prematurely, but I'd rather avoid it. [00:48:34] 10VisualEditor: VE crashes after deleting a heading without the line under it, throws error " Offset could not be translated to a DOM element and offset: 1" - https://phabricator.wikimedia.org/T114730#1704312 (10Ryasmeen) 3NEW [00:48:54] 10VisualEditor: VE crashes after deleting a Page Title/Heading without the line under it, throws error " Offset could not be translated to a DOM element and offset: 1" - https://phabricator.wikimedia.org/T114730#1704319 (10Ryasmeen) [00:49:16] 10VisualEditor: VE crashes after deleting a Page Title/Heading without the line under it, throws error " Offset could not be translated to a DOM element and offset: 1" - https://phabricator.wikimedia.org/T114730#1704312 (10Ryasmeen) p:5Triage>3High [00:50:41] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 6Design Research Backlog, 7Design, and 2 others: Agree a new overall design for VisualEditor on mobile phone-sized devices - https://phabricator.wikimedia.org/T93325#1704322 (10Nirzar) Here's second iteration for the VE on Mobile - Changes: - At any g... [00:51:04] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 6Design Research Backlog, 7Design, and 2 others: Agree a new overall design for VisualEditor on mobile phone-sized devices - https://phabricator.wikimedia.org/T93325#1704323 (10Nirzar) [00:55:46] 10VisualEditor, 10Parsoid, 10RESTBase, 6Services: Provide an API that allows stashing temporary wikitext / html conversion metadata - https://phabricator.wikimedia.org/T114548#1704324 (10GWicke) WIP PR at https://github.com/wikimedia/restbase/pull/363. [03:07:08] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-References, 10VisualEditor-MediaWiki-Templates, 10Parsoid: Ref generating templates show reflists when edited - https://phabricator.wikimedia.org/T101553#1704410 (10ssastry) [03:07:11] 10VisualEditor, 6Collaboration-Team-Backlog, 10Flow, 6Language-Engineering, and 2 others: Provide an API flag to suppress auto-generated - https://phabricator.wikimedia.org/T113331#1704411 (10ssastry) [03:10:52] 10VisualEditor, 10Parsoid: Parsoid creates incorrect wikitext by letting a user remove the newline between template and the start of a heading - https://phabricator.wikimedia.org/T105745#1450698 (10ssastry) Probably a similar fix as {T86271} which is close to being deployed and resolved. [03:11:09] 10VisualEditor, 10Parsoid: Parsoid creates incorrect wikitext by letting a user remove the newline between template and the start of a heading - https://phabricator.wikimedia.org/T105745#1704420 (10ssastry) Probably a similar fix as {T86271} which is close to being deployed and resolved. [03:43:32] 10VisualEditor, 10MediaWiki-Gallery, 10MediaWiki-Interface, 10Possible-Tech-Projects: Rearranging the order of image (link)s in galleries via drag and drop (AJAXy) - https://phabricator.wikimedia.org/T13500#160851 (10TasneemLo) Moving this to Missing Mentors, as the descriptions seems possible for a gsoc/o... [08:27:48] (03CR) 10Nikerabbit: "I am curious why are we suddenly doing mass conversions to the *less* common form?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/243224 (owner: 10Esanders) [08:29:03] 10VisualEditor, 10VisualEditor-EditingTools, 10OOjs-UI, 10UI-Standardization, and 2 others: Gray for "inactive" elements in the toolbar is too light - https://phabricator.wikimedia.org/T89271#1704694 (10Volker_E) @Quiddity The very inherent functionality in a disabled item (button, widget, etc.) in basical... [09:49:28] (03CR) 10Prtksxna: "Tested locally (passing local targetHost to FSUBL), works for me." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/240116 (https://phabricator.wikimedia.org/T40030) (owner: 10Esanders) [10:05:59] in the toDomElements function of ve.dm.Model [https://doc.wikimedia.org/VisualEditor/master/#!/api/ve.dm.Model], for a tag extension, should it be returning the XML-like tag, or the HTML thing that tag turns into when parsed? [10:54:04] 10VisualEditor, 6Design Research Backlog, 7Epic: Improve and streamline VisualEditor's user education features - https://phabricator.wikimedia.org/T101481#1704940 (10Elitre) It wouldn't make sense to reopen something which was supposed to be a tracking task, and now doesn't have blocking tasks anymore. Howev... [10:54:56] 10VisualEditor, 3Discovery-Cirrus-Sprint, 7Needs-user-research: Replace VE's use of prefix search for link/template/image suggestions with full text search - https://phabricator.wikimedia.org/T113110#1704942 (10dcausse) All to what Erik said: full-text search is not designed for search as you type and should... [11:32:31] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: Detect annotation changes on poll - https://phabricator.wikimedia.org/T114751#1705010 (10Esanders) 3NEW a:3dchan [11:38:07] (03PS10) 10Happy5214: Pre-fill fields in image dialog when image code is selected in editor [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/176927 (https://phabricator.wikimedia.org/T40829) [11:38:40] (03CR) 10Happy5214: "Let's try splitting up the if statement at the end." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/176927 (https://phabricator.wikimedia.org/T40829) (owner: 10Happy5214) [11:57:24] 10VisualEditor, 7Technical-Debt: ve.init.mw.ViewPageTarget.prototype.onSaveErrorNewUser is evil - https://phabricator.wikimedia.org/T87219#1705095 (10matmarex) [11:57:26] 10VisualEditor, 10VisualEditor-MediaWiki, 7I18n: Message 'visualeditor-dialog-transclusion-no-template-description' uses raw HTML - https://phabricator.wikimedia.org/T87131#1705096 (10matmarex) [11:58:20] 10VisualEditor, 10VisualEditor-MediaWiki, 7I18n: Message 'visualeditor-dialog-transclusion-no-template-description' uses raw HTML - https://phabricator.wikimedia.org/T87131#1705111 (10matmarex) a:3matmarex The dependency wasn't quite as nasty as it looked. [11:58:52] 10VisualEditor, 7Technical-Debt: ve.init.mw.ViewPageTarget.prototype.onSaveErrorNewUser is evil - https://phabricator.wikimedia.org/T87219#1705116 (10matmarex) a:3matmarex Fixing T49395 indeed wasn't that bad. [12:33:51] 10VisualEditor, 10Browser-Tests, 6Collaboration-Team-Backlog, 10Flow, 10MobileFrontend: Create Jenkins builds for Editing across repositories (MobileFrontend, VisualEditor etc) - https://phabricator.wikimedia.org/T90647#1705246 (10hashar) 5Open>3Invalid Apparently not intensive to follow up on this.... [13:03:21] (03PS11) 10Alex Monk: Educational popups and highlights for links+citations [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/238380 (https://phabricator.wikimedia.org/T108620) [13:07:02] 10VisualEditor: Make error widget for displaying an error in an inspector - https://phabricator.wikimedia.org/T114754#1705361 (10Tchanders) 3NEW a:3Tchanders [13:11:16] edsanders, I've been fiddling with making this open when you click instead of hover [13:11:31] It's mostly okay, but I need to hide the blue dot when it's disabled [13:14:17] which I think means I also need to run the dot's positioning code differently [13:15:25] which doesn't quite seem to work properly [13:29:56] (03PS12) 10Alex Monk: Educational popups and highlights for links+citations [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/238380 (https://phabricator.wikimedia.org/T108620) [13:32:37] (03CR) 10jenkins-bot: [V: 04-1] Educational popups and highlights for links+citations [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/238380 (https://phabricator.wikimedia.org/T108620) (owner: 10Alex Monk) [13:34:01] (03PS13) 10Alex Monk: Educational popups and highlights for links+citations [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/238380 (https://phabricator.wikimedia.org/T108620) [13:56:51] (03CR) 10Alex Monk: "I am not happy with some of the core code this relies on..." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/240116 (https://phabricator.wikimedia.org/T40030) (owner: 10Esanders) [13:57:48] (03CR) 10Alex Monk: "I can't actually test this on my own wiki." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/240116 (https://phabricator.wikimedia.org/T40030) (owner: 10Esanders) [14:07:45] 10VisualEditor, 10Parsoid, 5Patch-For-Review: Parsoid should be able to understand HTML entities in links - https://phabricator.wikimedia.org/T98960#1705484 (10cscott) This one is weird. That's a totally bogus link, right? It doesn't actually work? We do a sanity-checking pass after template expansion on... [14:11:33] NASA calling at https://www.mediawiki.org/wiki/Topic:Sq9px5b1hfnskutc , FYI [14:11:58] answer is no [14:13:49] (03CR) 10Prtksxna: "To test, I changed line 190 in ve.ui.MWMediaDialog.js to:" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/240116 (https://phabricator.wikimedia.org/T40030) (owner: 10Esanders) [14:14:19] (03CR) 10Alex Monk: "I guess that works if you use /w/ as your script path, yeah." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/240116 (https://phabricator.wikimedia.org/T40030) (owner: 10Esanders) [14:27:00] (03CR) 10Alex Monk: [C: 04-1] "* Core ForeignApi handling of script paths is bad-to-nonexistent and should never have been approved." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/240116 (https://phabricator.wikimedia.org/T40030) (owner: 10Esanders) [14:29:04] (03CR) 10Alex Monk: "(Correction: script path issue was found in ForeignUpload class, where it creates a ForeignApi object)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/240116 (https://phabricator.wikimedia.org/T40030) (owner: 10Esanders) [15:22:25] (03CR) 10Prtksxna: "> Does not handle errors properly (mustbeloggedin = "An error occurred" message to the user, same with filetype-banned)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/240116 (https://phabricator.wikimedia.org/T40030) (owner: 10Esanders) [15:41:29] (03CR) 10Jforrester: "@Nikerabbit: https://www.mediawiki.org/wiki/Manual_talk:Coding_conventions/CSS#Add_spaces_around_mixin_parameters_.3F" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/243224 (owner: 10Esanders) [15:46:48] (03CR) 10Alex Monk: "My copy of core tends to be around 1-2 weeks old, it's probably that." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/240116 (https://phabricator.wikimedia.org/T40030) (owner: 10Esanders) [16:11:59] (03CR) 10Alex Monk: "* Going to be addressed as part of T114765" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/240116 (https://phabricator.wikimedia.org/T40030) (owner: 10Esanders) [16:13:14] (03CR) 10Alex Monk: [C: 04-1] "Oh but there is another issue in saving the description page - the dialog is not necessarily big enough to open the date selector, and usi" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/240116 (https://phabricator.wikimedia.org/T40030) (owner: 10Esanders) [16:34:08] 10VisualEditor, 6Discovery, 10MediaWiki-API, 10MediaWiki-Search, and 4 others: Prefix search API doesn't return "index" field when "redirects" is enabled. - https://phabricator.wikimedia.org/T92796#1705796 (10dcausse) a:5dcausse>3None [16:49:01] (03PS1) 10Bartosz Dziewoński: Stop using raw HTML for 'visualeditor-dialog-transclusion-no-template-description' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/243952 (https://phabricator.wikimedia.org/T87131) [16:52:08] MatmaRex: Keen. :_) [16:53:11] 10VisualEditor: Remove or deprecate unused ve.getHtmlAttributes and ve.getOpeningHtmlTag? - https://phabricator.wikimedia.org/T114770#1705840 (10matmarex) 3NEW [16:54:27] (03CR) 10Bartosz Dziewoński: "I can undo the changes to translations here and perform them on Translatewiki instead, if that makes this simpler for you." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/243952 (https://phabricator.wikimedia.org/T87131) (owner: 10Bartosz Dziewoński) [16:56:06] (03CR) 10Jforrester: [C: 031] "It'd be nice to have localised the Template: bit, but eh." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/243952 (https://phabricator.wikimedia.org/T87131) (owner: 10Bartosz Dziewoński) [16:57:16] 10VisualEditor, 7Technical-Debt: ve.init.mw.Target.prototype.saveErrorNewUser is evil - https://phabricator.wikimedia.org/T87219#1705868 (10matmarex) [16:58:07] (03CR) 10Bartosz Dziewoński: "No, we can't localise it, because it would point to nowhere when the user language is different from content language." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/243952 (https://phabricator.wikimedia.org/T87131) (owner: 10Bartosz Dziewoński) [16:59:17] MatmaRex: Oh, good point. In that case, add a warning to the qqq. [16:59:56] yeah, we probably should [17:00:03] doesn't TWN show a warning about this in the interface? [17:04:27] (03PS1) 10Bartosz Dziewoński: ve.init.mw.Target: Remove jqueryMsg hacks in #saveErrorNewUser [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/243957 (https://phabricator.wikimedia.org/T87219) [17:06:50] (03CR) 10jenkins-bot: [V: 04-1] ve.init.mw.Target: Remove jqueryMsg hacks in #saveErrorNewUser [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/243957 (https://phabricator.wikimedia.org/T87219) (owner: 10Bartosz Dziewoński) [17:06:56] (03PS2) 10Bartosz Dziewoński: Stop using raw HTML for 'visualeditor-dialog-transclusion-no-template-description' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/243952 (https://phabricator.wikimedia.org/T87131) [17:09:53] (03CR) 10Bartosz Dziewoński: "Lies, it works." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/243957 (https://phabricator.wikimedia.org/T87219) (owner: 10Bartosz Dziewoński) [17:17:50] MatmaRex: Maybe? [17:20:22] (03CR) 10Jforrester: [C: 031] Stop using raw HTML for 'visualeditor-dialog-transclusion-no-template-description' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/243952 (https://phabricator.wikimedia.org/T87131) (owner: 10Bartosz Dziewoński) [17:29:26] 10VisualEditor: When a wikilink is the first element on a page, don't launch the link context menu automatically - https://phabricator.wikimedia.org/T114376#1706035 (10Florian) Hmm, ok, but what if I want to edit the link after I clicked "Edit"? Do I need to click somewhere else and on the link again, or do I ha... [17:43:53] 10VisualEditor, 10VisualEditor-MediaWiki: VisualEditor: Provide simultaneous access to editor and edit summary - https://phabricator.wikimedia.org/T52961#1706054 (10Elitre) (Although they won't be able to do so if they enabled the warning that doesn't allow to save without providing an edit summary, as noted a... [18:11:06] 10Cite, 10Parsoid, 5WMF-deploy-2015-10-06_(1.27.0-wmf.2), 7user-notice: Show an error if a named is defined multiple times with different content - https://phabricator.wikimedia.org/T85386#1706201 (10matmarex) [18:13:06] 10Cite, 10Parsoid, 5WMF-deploy-2015-10-06_(1.27.0-wmf.2), 7user-notice: Show an error if a named is defined multiple times with different content - https://phabricator.wikimedia.org/T85386#1706210 (10IKhitron) Hello, @matmarex, why did you change this? You mean the new future can't recognize the erro... [18:23:34] 10Cite, 10Parsoid, 5WMF-deploy-2015-10-06_(1.27.0-wmf.2), 7user-notice: Show an error if a named is defined multiple times with different content - https://phabricator.wikimedia.org/T85386#1706264 (10matmarex) Yes, defining the same ref multiple times with the same content is explicitly not an error,... [18:27:39] 10Cite, 10Parsoid, 5WMF-deploy-2015-10-06_(1.27.0-wmf.2), 7user-notice: Show an error if a named is defined multiple times with different content - https://phabricator.wikimedia.org/T85386#1706286 (10IKhitron) I see, @matmarex. Thanks. Looks reasonable. So after I'll fix different content on our wiki... [18:30:39] 10Cite, 10Parsoid, 5WMF-deploy-2015-10-06_(1.27.0-wmf.2), 7user-notice: Show an error if a named is defined multiple times with different content - https://phabricator.wikimedia.org/T85386#1706289 (10IKhitron) PS: I changed Help:Extension:Cite accordingly. [18:33:16] (03CR) 10jenkins-bot: [V: 04-1] MediaSizeWidget: Allow an user to really use a custom size [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/243979 (owner: 10Florianschmidtwelzow) [18:45:41] Krenair, still got education popup problems? [18:49:41] no [18:50:09] I mentioned earlier that I had changed it to open on click instead of hover [18:50:19] if you could review that, that'd be great [19:02:43] 10VisualEditor, 10VisualEditor-EditingTools: Make error widget for displaying an error in an inspector - https://phabricator.wikimedia.org/T114754#1706396 (10Jdforrester-WMF) p:5Triage>3Normal [19:03:05] 10VisualEditor, 7Technical-Debt: Remove or deprecate unused ve.getHtmlAttributes and ve.getOpeningHtmlTag? - https://phabricator.wikimedia.org/T114770#1706401 (10Jdforrester-WMF) p:5Triage>3Low [19:05:10] 10VisualEditor, 10VisualEditor-DataModel: VE crashes on trying to save a document with an empty heading, throws error " Offset could not be translated to a DOM element and offset: 1" - https://phabricator.wikimedia.org/T114730#1706413 (10Jdforrester-WMF) [19:05:38] 10Citoid, 10VisualEditor: Use |jstor= in {{cite journal}} - https://phabricator.wikimedia.org/T114728#1706418 (10Jdforrester-WMF) p:5Triage>3Normal [19:06:02] 10Citoid, 10VisualEditor: Create a way to use citoid on existing references - https://phabricator.wikimedia.org/T114727#1706421 (10Jdforrester-WMF) p:5Triage>3High [19:06:20] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: [Regression ?] Newline is appearing before every listed item in mobile VE - https://phabricator.wikimedia.org/T114716#1706424 (10Jdforrester-WMF) p:5Triage>3High [19:06:47] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: [Regression ?] The reference notes are not appearing for external links only the external link icons in mobile VE - https://phabricator.wikimedia.org/T114713#1706428 (10Jdforrester-WMF) p:5Triage>3High [19:10:17] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki-Links: Selection after auto-converting a basic (autonumbered) link to a regular external link selects outside the pin, meaning typing deletes the annotation, if it's not at the start of ... - https://phabricator.wikimedia.org/T114643#1706458 [19:10:23] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki-Links: Selection after auto-converting a basic (autonumbered) link to a regular external link selects outside the pin, meaning typing deletes the annotation, if it's not at the start of ... - https://phabricator.wikimedia.org/T114643#1701917 [19:10:46] 10Citoid, 10VisualEditor: Add ability to request base types in citoid, and offer use of both in extension for backwards compatibility until all templateData has been updated. - https://phabricator.wikimedia.org/T114515#1706464 (10Jdforrester-WMF) p:5Triage>3High [19:12:19] 10VisualEditor, 10VisualEditor-MediaWiki: Expose the configuration for the toolbar containing help and meta - https://phabricator.wikimedia.org/T114637#1706470 (10Jdforrester-WMF) p:5Triage>3Low [19:12:49] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-Categories, 7Design: Find a way to visualize a space as sortkey for a category - https://phabricator.wikimedia.org/T114635#1706474 (10Jdforrester-WMF) p:5Triage>3Low [19:13:25] 10Citoid, 10VisualEditor: Create a way to use citoid on existing references - https://phabricator.wikimedia.org/T114727#1706479 (10Jdforrester-WMF) [19:13:26] 10VisualEditor, 10VisualEditor-MediaWiki-References: Convert plain references of type URL to rich references in one click using Citoid - https://phabricator.wikimedia.org/T114564#1706480 (10Jdforrester-WMF) [19:13:35] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References, 7Design: Convert plain references of type URL to rich references in one click using Citoid - https://phabricator.wikimedia.org/T114564#1706482 (10Jdforrester-WMF) p:5Triage>3High [19:14:03] 10Citoid, 10VisualEditor: Citoid/VisualEditor doesn't handle citations for book chapters correctly - https://phabricator.wikimedia.org/T114450#1706485 (10Jdforrester-WMF) p:5Triage>3Normal [19:14:35] 10VisualEditor, 10Parsoid: API call which gives the rendering of a data-mw node from the data-mw & tyepof - https://phabricator.wikimedia.org/T114409#1706489 (10Jdforrester-WMF) [19:15:00] 10VisualEditor, 10VisualEditor-MediaWiki, 10Parsoid, 10RESTBase: Implement something similar to the RESTBase 'section' API to provide wikitext structure information - https://phabricator.wikimedia.org/T114402#1694434 (10Jdforrester-WMF) [19:15:19] 10VisualEditor: When a wikilink is the first element on a page, don't launch the link context menu automatically - https://phabricator.wikimedia.org/T114376#1706494 (10Jdforrester-WMF) 5Open>3declined a:3Jdforrester-WMF [19:17:59] 10VisualEditor: VisualEditor: Edge case of unintentional image removal - https://phabricator.wikimedia.org/T70709#1706500 (10Jdforrester-WMF) 5stalled>3Resolved a:3Jdforrester-WMF This is probably now fixed, as we change the selection when you type and move the object into view (so it's clear what's going... [19:18:45] 10VisualEditor, 10VisualEditor-Media, 10VisualEditor-MediaWiki-Media, 7Design, 7Epic: Consider some sort of "visual anchoring" for images that are "in" one place but floated into another - https://phabricator.wikimedia.org/T114369#1706513 (10Jdforrester-WMF) p:5Triage>3Low [19:19:02] 10VisualEditor: When a wikilink is the first element on a page, don't launch the link context menu automatically - https://phabricator.wikimedia.org/T114376#1706519 (10Esanders) 5declined>3Open This may be possible with the new link cartouches as there are two positions at the start of the document, one whic... [19:22:04] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki-References: Drag-and-drop of a reference in a set of sequential references to elsewhere in the sequence doesn't work (but cut-and-paste does) - https://phabricator.wikimedia.org/T114355#1706524 (10Jdforrester-WMF) p:5Triage>3Normal [19:22:24] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-ContentLanguage: Observed changes: widen heuristic criteria for guessing a change is simple - https://phabricator.wikimedia.org/T114260#1706529 (10Jdforrester-WMF) p:5Normal>3High [19:23:45] 10VisualEditor, 10VisualEditor-MediaWiki: When editing, prompt the user with suggested images used in other languages' version of this article - https://phabricator.wikimedia.org/T114233#1706532 (10Jdforrester-WMF) p:5Triage>3Low [19:23:50] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design: Design a user workflow system which prompts/suggests/requires the user to do things as they edit - https://phabricator.wikimedia.org/T111848#1706537 (10Jdforrester-WMF) [19:23:52] 10VisualEditor, 10VisualEditor-MediaWiki: When editing, prompt the user with suggested images used in other languages' version of this article - https://phabricator.wikimedia.org/T114233#1689017 (10Jdforrester-WMF) [19:24:13] 10VisualEditor, 10VisualEditor-ContentEditable: When a wikilink is the first element on a page, don't launch the link context menu automatically - https://phabricator.wikimedia.org/T114376#1706540 (10Jdforrester-WMF) p:5Triage>3Normal a:5Jdforrester-WMF>3dchan [19:25:37] 10VisualEditor, 10VisualEditor-MediaWiki, 10SyntaxHighlight: Consider converting the Language selector drop-down in SyntaxHighlight VE from a combo-box to a drop-down since we are not letting user insert any other language - https://phabricator.wikimedia.org/T114201#1706546 (10Jdforrester-WMF) [19:25:56] 10VisualEditor, 10VisualEditor-MediaWiki, 10SyntaxHighlight: Consider converting the Language selector drop-down in SyntaxHighlight VE from a combo-box to a drop-down since we are not letting user insert any other language - https://phabricator.wikimedia.org/T114201#1687869 (10Jdforrester-WMF) p:5Triage>3... [19:26:25] 10VisualEditor, 10Score: Use TitleInputWidget in the Score inspector for choosing filenames - https://phabricator.wikimedia.org/T114798#1706550 (10Esanders) 3NEW a:3Tchanders [19:26:45] 10VisualEditor: [Regression wmf 1] Previously added link appears below the search text box for a specific case - https://phabricator.wikimedia.org/T114188#1706558 (10Jdforrester-WMF) [19:26:47] 10VisualEditor, 10VisualEditor-MediaWiki-Links: [Regression wmf.1] Suggestions from previous search should not appear on opening the link inspector - https://phabricator.wikimedia.org/T114187#1706559 (10Jdforrester-WMF) [19:27:03] 10VisualEditor, 10Score: Use TitleInputWidget in the Score inspector for choosing filenames - https://phabricator.wikimedia.org/T114798#1706560 (10Jdforrester-WMF) p:5Triage>3Normal [19:27:26] 10VisualEditor, 10SyntaxHighlight: Misplaced drop down for language appears after canceling the first attempt to add a code block - https://phabricator.wikimedia.org/T114202#1706564 (10Jdforrester-WMF) p:5Triage>3Low [19:27:42] 10VisualEditor: [Regression pre-wmf24] The SyntaxHighlight VE inspector is appearing too long, reaching the end of page while trying to open it for the second time - https://phabricator.wikimedia.org/T113086#1706571 (10Jdforrester-WMF) p:5Triage>3Low [19:27:48] 10VisualEditor, 10VisualEditor-MediaWiki, 10SyntaxHighlight: Consider converting the Language selector drop-down in SyntaxHighlight VE from a combo-box to a drop-down since we are not letting user insert any other language - https://phabricator.wikimedia.org/T114201#1706573 (10Esanders) Yeah - the dropdown l... [19:45:18] (03PS3) 10Esanders: Add ve.dm.Surface#selectLastContentOffset [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/234346 (owner: 10Catrope) [19:47:41] (03CR) 10Esanders: [C: 032] "Unit tests as tech debt" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/234346 (owner: 10Catrope) [19:51:12] (03Merged) 10jenkins-bot: Add ve.dm.Surface#selectLastContentOffset [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/234346 (owner: 10Catrope) [19:55:21] 10VisualEditor, 10VisualEditor-MediaWiki-Links: [Regression ?] Context menu for link inspector does not appear after typing something after the link unless user goes to next line - https://phabricator.wikimedia.org/T114333#1706635 (10Ryasmeen) 5stalled>3Open yes I can. Screen capture attached. {F2662546} [19:57:04] (03CR) 10Bartosz Dziewoński: "You need to pass { $overlay: this.$overlay } to the Upload.BookletLayout for that." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/240116 (https://phabricator.wikimedia.org/T40030) (owner: 10Esanders) [20:04:54] 10VisualEditor, 6Collaboration-Team-Backlog, 10Flow, 6Language-Engineering, and 2 others: Provide an API flag to suppress auto-generated - https://phabricator.wikimedia.org/T113331#1706668 (10Mattflaschen) We probably actually want the auto-generated . [20:27:28] edsanders: Sorry :S I told James I was going to write unit tests, and then ... well [20:48:19] 10VisualEditor, 10VisualEditor-MediaWiki-Links: [Regression ?] Cannot escape out of the blue highlight of a newly created link even after explicitly clicking outside of it - https://phabricator.wikimedia.org/T114802#1706750 (10Ryasmeen) 3NEW [20:58:37] (03CR) 10Alex Monk: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/243957 (https://phabricator.wikimedia.org/T87219) (owner: 10Bartosz Dziewoński) [21:00:51] 10VisualEditor: The drop down menu for Insert does not resize down after clicking on "Fewer" when the window is resized down and scroll bar appears inside the drop down menu - https://phabricator.wikimedia.org/T114804#1706783 (10Ryasmeen) 3NEW [21:07:08] (03CR) 10Alex Monk: [C: 032] ve.init.mw.Target: Remove jqueryMsg hacks in #saveErrorNewUser [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/243957 (https://phabricator.wikimedia.org/T87219) (owner: 10Bartosz Dziewoński) [21:08:37] 10VisualEditor, 6Editing-Department, 10MediaWiki-Page-editing: Exception while trying to save an edit on mediawiki.org - https://phabricator.wikimedia.org/T114808#1706838 (10Florian) 3NEW [21:09:59] (03Merged) 10jenkins-bot: ve.init.mw.Target: Remove jqueryMsg hacks in #saveErrorNewUser [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/243957 (https://phabricator.wikimedia.org/T87219) (owner: 10Bartosz Dziewoński) [21:10:01] 10VisualEditor: The pages that are visited has different styling inside the link suggestions drop down - https://phabricator.wikimedia.org/T114809#1706855 (10Ryasmeen) 3NEW [21:14:35] 10VisualEditor, 6Editing-Department, 10MediaWiki-Page-editing, 7Wikimedia-log-errors: Exception while trying to save an edit on mediawiki.org - https://phabricator.wikimedia.org/T114808#1706890 (10hashar) [21:16:28] 10VisualEditor, 6Editing-Department, 10MediaWiki-Page-editing, 7Wikimedia-log-errors: Exception while trying to save an edit on mediawiki.org - https://phabricator.wikimedia.org/T114808#1706922 (10Krenair) [21:16:37] 10VisualEditor, 6Editing-Department, 10MediaWiki-Page-editing, 7Wikimedia-log-errors: Exception while trying to save an edit on mediawiki.org - https://phabricator.wikimedia.org/T114808#1706925 (10hashar) [21:25:52] (03CR) 10Krinkle: [C: 04-1] "Merge conflict." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/239194 (owner: 10Jforrester) [21:48:58] (03CR) 10DLynch: [C: 032] "Makes sense. Tested it. Error no longer happens -- no other undesirable behavior seems to happen as a consequence." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/240907 (https://phabricator.wikimedia.org/T90476) (owner: 10Alex Monk) [21:49:15] Kemayo: First merge! Nice. :-) [21:50:58] Thanks Kemayo, and congratulations [21:51:18] Everything melting down and exploding in 3... 2... 1... [21:52:12] 10VisualEditor, 10VisualEditor-MediaWiki, 7Technical-Debt, 5WMF-deploy-2015-10-13_(1.27.0-wmf.3): ve.init.mw.Target.prototype.saveErrorNewUser is evil - https://phabricator.wikimedia.org/T87219#1707124 (10Jdforrester-WMF) 5Open>3Resolved [21:54:37] * James_F grins. [21:55:16] Kemayo: If it makes you feel better, it's not going to hit production for ~164 hours. You picked the perfect day for your first merge. :-) [21:58:08] (03Merged) 10jenkins-bot: Don't error when trying to re-use a reference as itself. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/240907 (https://phabricator.wikimedia.org/T90476) (owner: 10Alex Monk) [22:00:09] 10VisualEditor, 10VisualEditor-MediaWiki-References, 5WMF-deploy-2015-10-13_(1.27.0-wmf.3): Trying to re-use a reference replacing itself crashes; should instead be a no-op - https://phabricator.wikimedia.org/T90476#1707154 (10Jdforrester-WMF) 5Open>3Resolved [22:00:16] Kemayo, in theory this is a pretty safe commit [22:00:42] Oh that looks really safe [22:00:45] Then again I deployed a 'safe' commit yesterday and took down all of the wikimedia wikis for a minute [22:00:50] So maybe I shouldn't be commenting on safety right now [22:00:56] I think it's the first time I've seen someone use getProp() with 'length' though :) [22:00:58] Krenair: :-D [22:01:50] Turns out 'array' only has two 'r's, and you don't want to get that muddled up when changing PHP files run in every wiki request that hits apache. [22:02:17] two of us missed that, as well as the tests [22:03:57] RoanKattouw, I think I had an even more unusual use of [gs]etProp somewhere [22:04:31] oh, no, actually it was pretty basic: https://gerrit.wikimedia.org/r/#/c/240904/1/modules/ve-mw/ui/widgets/ve.ui.MWTemplateTitleInputWidget.js [22:04:32] oh well [22:04:55] Oh that's like the exact use case I had in mind when I wrote that function [22:05:24] I wrote getProp() because I got tired of writing data && data.query && data.query.pages && ... [22:08:40] [13grunt-banana-checker] 15jdforrester created 06release-0.4.0 (+1 new commit): 02https://github.com/wikimedia/grunt-banana-checker/commit/8e5b3a66a6de [22:08:40] 13grunt-banana-checker/06release-0.4.0 148e5b3a6 15James Forrester: History.md: Details for v0.4.0 [22:09:35] [13grunt-banana-checker] 15jdforrester created 06release-0.4.0-package (+1 new commit): 02https://github.com/wikimedia/grunt-banana-checker/commit/196af09d3a7d [22:09:35] 13grunt-banana-checker/06release-0.4.0-package 14196af09 15James Forrester: package.json: Update for v0.4.0 [22:09:50] [13grunt-banana-checker] 15jdforrester opened pull request #40: package.json: Update for v0.4.0 (06release-0.4.0...06release-0.4.0-package) 02https://github.com/wikimedia/grunt-banana-checker/pull/40 [22:12:22] [13grunt-banana-checker] 15catrope closed pull request #40: package.json: Update for v0.4.0 (06release-0.4.0...06release-0.4.0-package) 02https://github.com/wikimedia/grunt-banana-checker/pull/40 [22:12:47] [13grunt-banana-checker] 15jdforrester opened pull request #41: Release 0.4.0 (06master...06release-0.4.0) 02https://github.com/wikimedia/grunt-banana-checker/pull/41 [22:30:14] [13grunt-banana-checker] 15catrope closed pull request #41: Release 0.4.0 (06master...06release-0.4.0) 02https://github.com/wikimedia/grunt-banana-checker/pull/41 [22:33:05] [13grunt-banana-checker] 15jdforrester tagged 06v0.4.0 at 06master: 02https://github.com/wikimedia/grunt-banana-checker/commits/v0.4.0 [22:36:09] [13grunt-banana-checker] 15jdforrester 04deleted 06release-0.4.0-package at 14196af09: 02https://github.com/wikimedia/grunt-banana-checker/commit/196af09 [23:16:53] 10VisualEditor, 10MediaWiki-General-or-Unknown, 10Reading-Community-Engagement, 6WMF-Design-Research, 5Design Research and product team collaboration: MediaWiki's feedback tool interface is confusing - https://phabricator.wikimedia.org/T100011#1707392 (10aripstra) [23:19:11] When we implement edit suggestions in VE, can they please be better than the ones in Google Docs? [23:19:22] In addition to the fun James_F and I had today, I've now discovered this as well: http://i.imgur.com/EgNufan.png [23:19:40] "When". [23:19:43] (That empty bullet point only appeared when I suggested deleting the last bullet) [23:20:38] James_F: I made vague noises about a cool new feature on IRC around midnight London time, are you trying to tell me Ed won't have it done by the end of the week? :P [23:21:34] RoanKattouw: Says the guy that never follows-through on his "C+1 – supply a unit test" patches? :-) [23:23:39] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 6Editing-Department, 6WMF-Design-Research, and 2 others: Showing the Back and Undo buttons in the same place in mobile might be confusing for users; suggest an alternative design - https://phabricator.wikimedia.org/T113638#1707429 (10aripstra) [23:24:09] Yeah... [23:24:12] * RoanKattouw hides sheepishly [23:27:02] (03PS6) 10Jforrester: build: Upgrade various devDependencies to latest and make pass [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/239194 [23:28:10] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/242041/ [23:39:27] 10VisualEditor, 10Wikimedia-Site-Requests, 5Patch-For-Review: Re-enable VisualEditor by default for logged-in users on the English Wikipedia, exempting anyone who's ever edited - https://phabricator.wikimedia.org/T112348#1707464 (10Krenair) Exemption script completed, this should be good to go