[00:24:45] (03PS7) 10Jforrester: build: Upgrade various devDependencies to latest and make pass [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/239194 [00:24:53] (03CR) 10Krinkle: [C: 032] build: Upgrade various devDependencies to latest and make pass [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/239194 (owner: 10Jforrester) [00:26:46] (03Merged) 10jenkins-bot: build: Upgrade various devDependencies to latest and make pass [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/239194 (owner: 10Jforrester) [01:01:28] jaufrecht: "Sorry, the file you have requested does not exist." unfortunately, wrt the SUL (heh, typo, but I'm leaving it for legoktm ) document [01:02:00] huh? [01:07:10] legoktm: it's for a SLU (Service Level Understanding) doc, but I typo'd SUL, because, well, yeah [01:07:17] hahaha [01:11:26] 10Citoid, 10VisualEditor: Add ability to request base types in citoid, and offer use of both in extension for backwards compatibility until all templateData has been updated. - https://phabricator.wikimedia.org/T114515#1707645 (10kaldari) Option 1: This doesn't solve the problem for 3rd party users of citoid.... [01:14:34] 10Citoid, 10VisualEditor: Add ability to request base types in citoid, and offer use of both in extension for backwards compatibility until all templateData has been updated. - https://phabricator.wikimedia.org/T114515#1707648 (10kaldari) I posted my comment above before reading that Option 2 has already been... [01:40:26] (03PS10) 10Jforrester: Add image upload tab to media dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/240116 (https://phabricator.wikimedia.org/T40030) (owner: 10Esanders) [01:40:44] (03CR) 10Jforrester: [C: 031] Add image upload tab to media dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/240116 (https://phabricator.wikimedia.org/T40030) (owner: 10Esanders) [01:50:07] (03CR) 10Catrope: [C: 032] Add image upload tab to media dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/240116 (https://phabricator.wikimedia.org/T40030) (owner: 10Esanders) [01:52:41] James_F, is it intentional that we only seem to allow upload when you tick the own-work button? [01:52:46] oh, Roan just +2'd it... okay... [01:53:14] Ahm [01:53:17] Should I revoke that [01:53:19] ? [01:53:39] I don't think it will break much [01:53:45] so nah [01:54:13] James_F, also what about detecting logged out status and showing a warning before the user tries to actually upload stuff? [01:54:20] I don't know if I'd go as far as hiding the tab [01:54:21] (03Merged) 10jenkins-bot: Add image upload tab to media dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/240116 (https://phabricator.wikimedia.org/T40030) (owner: 10Esanders) [01:57:52] Krenair: Yes. [01:58:10] Krenair: Logged-out-on-Commons-but-logged-in-here? [01:58:47] is that possible with wikimedia's system? but yes, good point [01:58:53] ah, yes [01:59:01] I guess that when this is used from private wikis, that'd happen [01:59:20] We should add something to not show it when you're logged-out, though, you're right. [02:00:28] Right now I'm trying to work out how we can do T40031. :-) [02:01:06] Because we don't expose in JS $wgFileExtensions, let alone another wiki's $wgFileExtensions, and we need both that and a list of allowed MIME types. :-) [02:02:30] (03CR) 10Jforrester: [C: 032] [BREAKING CHANGE] GeneratedContentNode: Introduce new hash for rendering [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/242894 (https://phabricator.wikimedia.org/T114689) (owner: 10Esanders) [02:02:39] James_F, query the API for action=query&meta=siteinfo&siprop=fileextensions? [02:03:24] Ah, nice. I suppose we don't expose the MIME types though? [02:04:58] And we need a way to get the remote target's API.php endpoint, I guess? [02:05:49] Mark is working on that [02:06:01] OK. :-) [02:06:42] or something like that anyway [02:06:42] https://gerrit.wikimedia.org/r/#/c/243993/2 [02:07:00] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media, 6Multimedia: VisualEditor: Initiate file upload by drag-and-drop - https://phabricator.wikimedia.org/T40031#1707687 (10Jdforrester-WMF) [02:08:02] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media, 6Multimedia: VisualEditor: Initiate file upload by drag-and-drop - https://phabricator.wikimedia.org/T40031#428525 (10Jdforrester-WMF) [02:08:11] * James_F nods. [02:09:32] (03Merged) 10jenkins-bot: [BREAKING CHANGE] GeneratedContentNode: Introduce new hash for rendering [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/242894 (https://phabricator.wikimedia.org/T114689) (owner: 10Esanders) [02:09:53] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media, 6Multimedia: VisualEditor: Initiate file upload by drag-and-drop - https://phabricator.wikimedia.org/T40031#1707695 (10Jdforrester-WMF) VE's drop handler needs a list of allowed file extensions on the target remote wiki. You can get... [02:11:06] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media, 6Multimedia: VisualEditor: Initiate file upload by drag-and-drop - https://phabricator.wikimedia.org/T40031#1707698 (10Jdforrester-WMF) p:5Low>3High [02:29:15] (03PS1) 10Jforrester: Update VE core submodule to master (363adf2) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/244106 [02:29:44] (03CR) 10Jforrester: "Breaking change means Ib64a11841 needs to be merged immediately after this. No impact on this repo, though." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/244106 (owner: 10Jforrester) [07:16:07] 10VisualEditor, 10VisualEditor-MediaWiki: "Prompt me when entering a blank edit summary" preference should also apply to summaries with only the section title - https://phabricator.wikimedia.org/T114857#1707939 (10Schnark) 3NEW [10:04:15] 10Cite, 7Browser-Support-Internet-Explorer, 5Patch-For-Review: IE9 does not show reference backlinks - https://phabricator.wikimedia.org/T93319#1708233 (10Fomafix) I guess this bug is fixed since https://gerrit.wikimedia.org/r/241696 [11:34:00] 10VisualEditor, 10Score: Use TitleInputWidget in the Score inspector for choosing filenames - https://phabricator.wikimedia.org/T114798#1708411 (10Tchanders) This is probably only useful if it restricts the results to the correct file types. This functionality currently doesn't exist in TitleInputWidget, but i... [13:00:45] 10VisualEditor, 10VisualEditor-MediaWiki: VisualEditor: Provide simultaneous access to editor and edit summary - https://phabricator.wikimedia.org/T52961#1708591 (10Elitre) (Aaand there's an exception for that. See T114857.) [13:35:58] 10Cite, 7Browser-Support-Internet-Explorer, 5Patch-For-Review: IE9 does not show reference backlinks - https://phabricator.wikimedia.org/T93319#1708665 (10matmarex) 5Open>3Resolved a:3matmarex Indeed, looks fixed to me, and this was likely the same underlying issue as T108727. [13:40:42] 10VisualEditor, 10Parsoid, 10RESTBase, 6Services: Provide an API that allows stashing temporary wikitext / html conversion metadata - https://phabricator.wikimedia.org/T114548#1708681 (10mobrovac) Spec [PR 21](https://github.com/wikimedia/restbase-mod-table-spec/pull/21) introduces the `temp` revision poli... [13:46:29] 10VisualEditor, 10Parsoid, 10RESTBase, 6Services: Provide an API that allows stashing temporary wikitext / html conversion metadata - https://phabricator.wikimedia.org/T114548#1708701 (10mobrovac) >>! In T114548#1704324, @GWicke wrote: > WIP PR at https://github.com/wikimedia/restbase/pull/363. The PR is... [14:17:47] 10Cite, 10Parsoid, 5WMF-deploy-2015-10-06_(1.27.0-wmf.2), 7user-notice: Show an error if a named is defined multiple times with different content - https://phabricator.wikimedia.org/T85386#1708782 (10IKhitron) By the way: I checked now on enwiki, it doesn't work yet. Special:Version shows October, 6... [14:29:04] 10VisualEditor, 7Regression: adding or editing a wikilink consting of an anchor should work - https://phabricator.wikimedia.org/T114895#1708834 (10JanZerebecki) 3NEW [14:30:19] 10VisualEditor, 7Regression: adding or editing a wikilink consting of an anchor should work - https://phabricator.wikimedia.org/T114895#1708842 (10Jdforrester-WMF) [14:30:20] 10VisualEditor, 10VisualEditor-MediaWiki-Links: [Regression wmf23] On creating an inter-wiki link, the nice regex strips section parts of the link - https://phabricator.wikimedia.org/T112898#1708843 (10Jdforrester-WMF) [14:35:59] 10VisualEditor: The pages that are visited has different styling inside the link suggestions drop down - https://phabricator.wikimedia.org/T114809#1708859 (10Jdforrester-WMF) 5Open>3declined a:3Jdforrester-WMF I disagree; I think we should maintain that links should 'work' the same way they do in the rest... [14:36:08] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 7Design: The pages that are visited has different styling inside the link suggestions drop down - https://phabricator.wikimedia.org/T114809#1708862 (10Jdforrester-WMF) [14:38:13] 10Citoid: REGRESSION: general type author metadata getting added to creators field - https://phabricator.wikimedia.org/T113232#1658167 (10mobrovac) [14:39:52] 10Citoid: Read dublin core embedded metadata in lib/scrape.js - https://phabricator.wikimedia.org/T76224#793303 (10mobrovac) [14:40:32] edsanders: For https://gerrit.wikimedia.org/r/#/c/244106/ is https://gerrit.wikimedia.org/r/#/c/242895/ really all that's needed to not break things? [14:41:54] 10Citoid, 10VisualEditor: Add support for restful crossRef api - https://phabricator.wikimedia.org/T108175#1514256 (10mobrovac) [14:52:18] James_F, um [14:52:25] there were some ve-mw changes [14:53:39] edsanders: Where? [14:53:44] good question [14:53:47] :-) [14:53:52] Never uploaded? [14:54:28] 10Cite, 10Parsoid, 5WMF-deploy-2015-10-06_(1.27.0-wmf.2), 7user-notice: Show an error if a named is defined multiple times with different content - https://phabricator.wikimedia.org/T85386#1708903 (10matmarex) No, all is fine. The English Wikipedia is still running 1.27.0-wmf.1, while this patch is i... [14:55:18] (03PS1) 10Esanders: [PULL THROUGH] Use new getHashForRendering in GeneratedContentNode users [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/244167 [14:55:20] apparently didn't make it [14:55:22] there it is [14:55:25] I'll merge. [14:58:08] (03CR) 10jenkins-bot: [V: 04-1] [PULL THROUGH] Use new getHashForRendering in GeneratedContentNode users [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/244167 (owner: 10Esanders) [14:58:20] And fix that. :-) [14:59:48] (03PS2) 10Jforrester: Update VE core submodule to master (363adf2) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/244167 (owner: 10Esanders) [14:59:54] * Elitre waves [15:00:18] (03Abandoned) 10Jforrester: Update VE core submodule to master (363adf2) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/244106 (owner: 10Jforrester) [15:00:34] (03PS3) 10Jforrester: Update VE core submodule to master (363adf2) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/244167 (https://phabricator.wikimedia.org/T114689) (owner: 10Esanders) [15:00:40] Elitre: Let's go. [15:00:49] * Elitre is excited! [15:03:10] 10Cite, 10Parsoid, 5WMF-deploy-2015-10-06_(1.27.0-wmf.2), 7user-notice: Show an error if a named is defined multiple times with different content - https://phabricator.wikimedia.org/T85386#1708943 (10IKhitron) Sorry, @matmarex, but it does not work on mediawiki. See https://www.mediawiki.org/wiki/Use... [15:03:43] Elitre: It's done. And looks like it works. [15:04:27] yes. [15:04:45] now, how do we know opted out people are still opted out? ;) [15:05:19] Elitre: Looking in the database. :-) [15:05:49] so green light for me? [15:05:53] Yup. [15:06:02] 10Cite, 10Parsoid, 5WMF-deploy-2015-10-06_(1.27.0-wmf.2), 7user-notice: Show an error if a named is defined multiple times with different content - https://phabricator.wikimedia.org/T85386#1708952 (10matmarex) It seems to work if you add ``, which most pages probably have. Still, it shou... [15:06:07] (03CR) 10Jforrester: [C: 032] Update VE core submodule to master (363adf2) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/244167 (https://phabricator.wikimedia.org/T114689) (owner: 10Esanders) [15:09:45] 10VisualEditor, 10Wikimedia-Site-Requests, 5Patch-For-Review, 7notice, 7user-notice: Re-enable VisualEditor by default for all logged-out users of the English Wikipedia - https://phabricator.wikimedia.org/T90663#1708962 (10Jdforrester-WMF) [15:09:47] 10VisualEditor, 10Wikimedia-Site-Requests, 5Patch-For-Review: Re-enable VisualEditor by default for all users of the English Wikipedia - https://phabricator.wikimedia.org/T90662#1708963 (10Jdforrester-WMF) [15:09:47] 10VisualEditor, 10Wikimedia-Site-Requests, 5Patch-For-Review: Re-enable VisualEditor by default for logged-in users on the English Wikipedia, exempting anyone who's ever edited - https://phabricator.wikimedia.org/T112348#1708960 (10Jdforrester-WMF) 5Open>3Resolved Now complete. [15:12:18] (03Merged) 10jenkins-bot: Update VE core submodule to master (363adf2) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/244167 (https://phabricator.wikimedia.org/T114689) (owner: 10Esanders) [15:15:03] James_F: https://en.wikipedia.org/wiki/Wikipedia:VisualEditor/Feedback#visual_editor_disappeared [15:17:56] Elitre: That was quick. :-) [15:18:04] It was indeed. [15:18:14] James_F: a very unlucky editor? [15:18:34] Elitre: At our scale I guess you'll always risk this, but yes, unlucky. [15:24:05] 10Cite: The error normally shown if a named is defined multiple times doesn't appear if the page is missing tag - https://phabricator.wikimedia.org/T114898#1709011 (10matmarex) 3NEW a:3matmarex [15:24:46] 10Cite, 10Parsoid, 5WMF-deploy-2015-10-06_(1.27.0-wmf.2), 7user-notice: Show an error if a named is defined multiple times with different content - https://phabricator.wikimedia.org/T85386#945596 (10matmarex) It's a small issue, I filed it as {T114898} for those of us who care about it. :) [15:26:40] 10Cite, 10Parsoid, 5WMF-deploy-2015-10-06_(1.27.0-wmf.2), 7user-notice: Show an error if a named is defined multiple times with different content - https://phabricator.wikimedia.org/T85386#1709029 (10IKhitron) Thanks. And it is indeed a problem, because some user forgot to do not know about using James_F: more likely that he was looking for VE in non-VE namespaces. [15:28:41] Possibly. [15:29:56] 10Cite: The error normally shown if a named is defined multiple times doesn't appear if the page is missing tag - https://phabricator.wikimedia.org/T114898#1709045 (10matmarex) I haven't noticed before, but it seems that `mReferencesErrors` was previously only used for errors that appeared fr... [15:31:55] 10Citoid, 10VisualEditor: Add support for restful crossRef api - https://phabricator.wikimedia.org/T108175#1709059 (10Mvolz) The merged patch was for the originally reported bug (bad date from crossref) but this still isn't done as we should still switch to the json api. [15:32:16] 10VisualEditor, 6Design Research Backlog, 7Design, 5Design Research and product team collaboration: Emphasize VE's save button by animating the progress bar attached to the bottom of the toolbar - https://phabricator.wikimedia.org/T99274#1709062 (10aripstra) [15:35:15] 10VisualEditor, 10WikiEditor, 6Design Research Backlog, 7Easy, and 2 others: Tooltip text on the "Edit" and "Edit Source" tabs should be more helpful to new users - https://phabricator.wikimedia.org/T99271#1709073 (10aripstra) [15:37:12] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 6Design Research Backlog, 7Design, and 3 others: Agree a new overall design for VisualEditor on mobile phone-sized devices - https://phabricator.wikimedia.org/T93325#1709082 (10aripstra) [15:38:54] Elitre: What's up with the triple smart quotes at https://en.wikipedia.org/wiki/Wikipedia_talk:VisualEditor#The_visual_editor.E2.80.99s_preference_has_moved ? :) [15:39:15] 10VisualEditor, 10VisualEditor-ContentEditable, 6Design Research Backlog, 5Design Research and product team collaboration: in VisualEditor, styling a whole paragraph plus the ending mark also styles the next paragraph - https://phabricator.wikimedia.org/T100308#1709088 (10aripstra) [15:40:02] I wasn't so smart, evidently [15:40:35] but I'm kind enough to avoid replying "sofixit" :p (thank you!) [15:41:17] lol, right, sorry [15:41:23] I could/should have just fixed that for you [15:41:46] absolutely not. BTW, obviously a copy/paste fail (thank you, GDocs) [15:41:55] 10Cite, 10Parsoid, 5WMF-deploy-2015-10-06_(1.27.0-wmf.2), 7user-notice: Show an error if a named is defined multiple times with different content - https://phabricator.wikimedia.org/T85386#1709105 (10IKhitron) 3 more issues (see https://www.mediawiki.org/w/index.php?title=User:IKhitron/draft&oldid=19... [15:42:49] Oooh I see [15:42:58] I was like how do you even get smart quotes in there... but gdocs, right [15:58:36] 10Citoid, 7Technical-Debt: Switch from tabs to spaces - https://phabricator.wikimedia.org/T112507#1636669 (10mobrovac) [15:59:08] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 7Easy: Remove "Open" button from all four link inspectors - https://phabricator.wikimedia.org/T109646#1709165 (10DLynch) a:5Jdforrester-WMF>3DLynch [16:16:16] 10Citoid, 7Technical-Debt: Switch from tabs to spaces - https://phabricator.wikimedia.org/T112507#1709211 (10mobrovac) 5Open>3Resolved Deployed. [16:16:31] 10Citoid: REGRESSION: general type author metadata getting added to creators field - https://phabricator.wikimedia.org/T113232#1709214 (10mobrovac) 5Open>3Resolved Deployed, resolving. [16:16:46] 10Citoid: Read dublin core embedded metadata in lib/scrape.js - https://phabricator.wikimedia.org/T76224#1709218 (10mobrovac) 5Open>3Resolved Deployed, resolving. [16:17:05] 10Citoid: Use start page and end page parameters for crossRef - https://phabricator.wikimedia.org/T107647#1709221 (10mobrovac) 5Open>3Resolved Deployed, resolving [16:17:22] 10Citoid: Use html-metadata node library's open graph data in lib/Scraper.js - https://phabricator.wikimedia.org/T1069#1709224 (10mobrovac) 5Open>3Resolved Deployed, resolving. [16:30:57] 10Citoid, 7Technical-Debt: Switch from tabs to spaces - https://phabricator.wikimedia.org/T112507#1709260 (10GWicke) How is the performance with spaces? [16:56:20] 10Citoid: Use resolved DOI link to final location for url parameter in citation. - https://phabricator.wikimedia.org/T106857#1709368 (10Mvolz) p:5Triage>3Normal a:3Mvolz [16:56:24] 10Cite, 5Patch-For-Review: The error normally shown if a named is defined multiple times doesn't appear if the page is missing tag - https://phabricator.wikimedia.org/T114898#1709370 (10matmarex) I copied the contents of https://www.mediawiki.org/wiki/User:IKhitron/draft to my local wiki, h... [16:56:51] Have we officially cancelled VE standup today? [16:59:58] 10Citoid: Paralellize scraper and Zotero requests - https://phabricator.wikimedia.org/T114907#1709389 (10Mvolz) 3NEW [17:03:32] 10Citoid: Merge results from various metadata types - https://phabricator.wikimedia.org/T114909#1709407 (10Mvolz) 3NEW [17:10:12] 10Cite, 5Patch-For-Review: The error normally shown if a named is defined multiple times doesn't appear if the page is missing tag - https://phabricator.wikimedia.org/T114898#1709430 (10IKhitron) Looks good. [17:11:13] 10VisualEditor: Moving focus from a link to a focusable node doesn't hide the cartouche - https://phabricator.wikimedia.org/T114912#1709444 (10Esanders) 3NEW a:3dchan [17:18:32] jaufrecht: yes? it's not on the calendar. [17:21:32] 10VisualEditor, 6Discovery, 10MediaWiki-API, 10MediaWiki-Search, and 4 others: Prefix search API doesn't return "index" field when "redirects" is enabled. - https://phabricator.wikimedia.org/T92796#1709470 (10EBernhardson) a:3EBernhardson [17:29:08] 10Cite: Add warning message when is not closed correctly - https://phabricator.wikimedia.org/T28145#1709502 (10Thgoiter) This old bug should be solved as it affects the articles' appearance in many cases (typically external links or navbars aren't shown). See [[ https://en.wikipedia.org/w/index.php... [17:43:10] 10VisualEditor, 6Collaboration-Team-Backlog, 10Flow, 6Language-Engineering, and 2 others: Provide an API flag to suppress auto-generated - https://phabricator.wikimedia.org/T113331#1709580 (10ssastry) >>! In T113331#1706668, @Mattflaschen wrote: > We probably actually want the auto-generated... [17:43:41] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-References, 10VisualEditor-MediaWiki-Templates, 10Parsoid: Ref generating templates show reflists when edited - https://phabricator.wikimedia.org/T101553#1709583 (10ssastry) 5duplicate>3Open [17:44:05] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-References, 10VisualEditor-MediaWiki-Templates, 10Parsoid: Ref generating templates show reflists when edited - https://phabricator.wikimedia.org/T101553#1342287 (10ssastry) [17:44:08] 10VisualEditor, 6Collaboration-Team-Backlog, 10Flow, 6Language-Engineering, and 2 others: Provide an API flag to suppress auto-generated - https://phabricator.wikimedia.org/T113331#1709587 (10ssastry) [17:45:20] 10Cite, 10Parsoid, 5WMF-deploy-2015-10-06_(1.27.0-wmf.2), 7user-notice: Show an error if a named is defined multiple times with different content - https://phabricator.wikimedia.org/T85386#1709592 (10IKhitron) In the new patch, 2 became irrelevant. [18:27:38] I'm trying to add Image in local wiki (with head code), and there is something weird in ve.ui.MWMediaDialog.prototype.chooseImageInfo - should the info be a function? [18:28:31] e.g "this.chooseImageInfo( item.getData );" and not "this.chooseImageInfo( item.getData() );" [18:31:51] edsanders - git blames you 97ddc8af [18:32:14] that seems wrong [18:32:26] how did that even work before? [18:33:36] oh, that's in the search feature [18:33:43] Don't know, but before 97ddc8af it was item.getData() and not it is this.chooseImageInfo( item.getData ); [18:33:53] *not=>now [18:34:46] (03PS1) 10Esanders: Fix typo in MWMediaDialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/244233 [18:35:02] (03CR) 10Jforrester: [C: 032] Fix typo in MWMediaDialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/244233 (owner: 10Esanders) [18:35:38] 10x [18:35:38] eranroz, thanks [18:37:15] (03CR) 10jenkins-bot: [V: 04-1] Fix typo in MWMediaDialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/244233 (owner: 10Esanders) [18:38:05] Meh. [18:38:10] (03Merged) 10jenkins-bot: Fix typo in MWMediaDialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/244233 (owner: 10Esanders) [19:12:23] 10VisualEditor: Save dialog appear again immediately after save - https://phabricator.wikimedia.org/T114929#1709878 (10awight) 3NEW [19:12:34] 10VisualEditor: Save dialog appears again immediately after save - https://phabricator.wikimedia.org/T114929#1709885 (10awight) [19:13:21] 10VisualEditor: Save dialog appears again immediately after save - https://phabricator.wikimedia.org/T114929#1709878 (10awight) [19:17:15] 10VisualEditor, 10VisualEditor-MediaWiki, 5WMF-deploy-2015-10-13_(1.27.0-wmf.3): Changes to non-rendered attributes of GeneratedContentNodes don't get saved - https://phabricator.wikimedia.org/T114689#1709902 (10Jdforrester-WMF) 5Open>3Resolved [19:23:21] (03PS1) 10Jforrester: ApiVisualEditor: Switch RESTbase config from 'scrubWikitext' to 'scrub_wikitext' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/244251 [19:30:19] hey James_F , any chance I can pick your brain before 1pm? :) [19:30:25] Elitre: Sure. [19:32:53] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media, 6Multimedia: VisualEditor: Initiate file upload by drag-and-drop - https://phabricator.wikimedia.org/T40031#1709956 (10Jdforrester-WMF) [19:32:55] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media, 6Multimedia, and 3 others: Way in VisualEditor to initiate Commons file uploading, and insert image on completion - https://phabricator.wikimedia.org/T40030#1709955 (10Jdforrester-WMF) 5Open>3Resolved [19:50:14] 10VisualEditor: The checkbox for "This is my own work" remains selected for the next time user tries to upload an image - https://phabricator.wikimedia.org/T114936#1710006 (10Ryasmeen) 3NEW [19:51:43] 10VisualEditor: There is no way to go back to Upload image page if user tries to change the image just selected - https://phabricator.wikimedia.org/T114938#1710022 (10Ryasmeen) 3NEW [19:56:31] 10VisualEditor: Trying to change the name of the image in the upload image dialog throws error "" - https://phabricator.wikimedia.org/T114940#1710047 (10Ryasmeen) 3NEW [19:59:51] 10VisualEditor: The date-picker in Upload image dialog does not close after selecting a date, requires clicking somewhere else to close it - https://phabricator.wikimedia.org/T114942#1710068 (10Ryasmeen) 3NEW [20:07:45] 10VisualEditor: The drop down for categories in Upload image dialog opens too slowly, even sometimes after moving to the next field - https://phabricator.wikimedia.org/T114945#1710111 (10Ryasmeen) 3NEW [20:08:23] 10VisualEditor, 6Design Research Backlog, 7Epic: Improve and streamline VisualEditor's user education features - https://phabricator.wikimedia.org/T101481#1710120 (10Neil_P._Quinn_WMF) @Elitre, the general trend now is to use Phabricator projects instead of tracking tasks. If it would help you a lot to be ab... [20:17:28] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media, 6Multimedia: VisualEditor: Initiate file upload by drag-and-drop - https://phabricator.wikimedia.org/T40031#1710163 (10matmarex) [20:18:07] (03PS1) 10Esanders: Media upload: Initiate upload process on image drop [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/244331 (https://phabricator.wikimedia.org/T40031) [20:21:14] (03CR) 10jenkins-bot: [V: 04-1] Media upload: Initiate upload process on image drop [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/244331 (https://phabricator.wikimedia.org/T40031) (owner: 10Esanders) [20:26:27] 10VisualEditor: Previously added Categories and Date value for another image remains selected while trying to upload a new image ( - https://phabricator.wikimedia.org/T114947#1710218 (10Ryasmeen) 3NEW [20:26:48] 10VisualEditor: Previously added Categories and Date value for another image remains selected while trying to upload a new image - https://phabricator.wikimedia.org/T114947#1710226 (10Ryasmeen) [20:29:43] (03PS1) 10Esanders: Media upload: Use new setFile method [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/244337 [20:32:42] (03CR) 10jenkins-bot: [V: 04-1] Media upload: Use new setFile method [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/244337 (owner: 10Esanders) [20:37:30] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media, 6Multimedia, 5Patch-For-Review: VisualEditor: Initiate file upload by drag-and-drop - https://phabricator.wikimedia.org/T40031#1710267 (10Jdforrester-WMF) [20:37:39] (03PS2) 10Esanders: Media upload: Initiate upload process on image drop [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/244331 (https://phabricator.wikimedia.org/T40031) [20:37:41] (03PS2) 10Esanders: Media upload: Use new setFile method [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/244337 [20:38:46] 10VisualEditor: Consider changing the error message that shows up while trying to upload an already uploaded image - https://phabricator.wikimedia.org/T114950#1710276 (10Ryasmeen) [20:41:03] 10VisualEditor, 10MediaWiki-RfCs, 6Parsing-Team, 10Parsoid: [RFC] Introduce notion of DOM scopes in wikitext - https://phabricator.wikimedia.org/T114444#1710301 (10GWicke) [20:43:52] edsanders: Does that support copy-paste? [20:44:27] edsanders: If yes, tag with https://phabricator.wikimedia.org/T39932 [20:44:34] I don't think so [20:44:41] Boo. [20:49:03] when you paste the transfer.getAsFile() returns a Blob, not a File [20:49:11] which you can't pass to SelectFileWidget [20:49:25] all the data is there, we just need to work on SelectFileWidget [20:49:32] there's also no filename [20:51:29] 10VisualEditor, 10Parsoid, 10RESTBase: Provide a mechanism in VRS/RESTbase for switching between WT and DOM - https://phabricator.wikimedia.org/T104663#1710338 (10Jdforrester-WMF) [20:51:40] 10VisualEditor, 10Parsoid, 10RESTBase: Provide a mechanism in VRS/RESTbase for switching between WT and DOM - https://phabricator.wikimedia.org/T104663#1423513 (10Jdforrester-WMF) [20:53:19] Yeah. And so the check-against-file-extensions stuff will have to be bypassed. [20:53:32] We can concoct an auto-name and set to invalid, maybe? [20:55:19] 10VisualEditor, 10VisualEditor-CopyPaste: VisualEditor: Upload-by-insertion of images via copy-paste - https://phabricator.wikimedia.org/T39932#1710347 (10Jdforrester-WMF) [20:55:20] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media, 6Multimedia, 5Patch-For-Review: VisualEditor: Initiate file upload by drag-and-drop - https://phabricator.wikimedia.org/T40031#1710348 (10Jdforrester-WMF) [20:55:32] 10VisualEditor, 10VisualEditor-CopyPaste: VisualEditor: Upload-by-insertion of images via copy-paste - https://phabricator.wikimedia.org/T39932#417800 (10Jdforrester-WMF) [20:59:13] Yeah - we'd need a placeholder value for the widget ("Pasted file") [20:59:34] we'd probably want to block on the file widget showing previews though [20:59:54] if someone pastes a tiny icon by mistake they might be confused at seeing the upload dialog [21:00:35] (03PS1) 10Jforrester: Update OOjs UI to v0.12.11 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/244344 [21:01:59] edsanders: Yeah. Maybe ignore the area for a while until we're happy the upload pipeline doesn't make people kill us. :-) [21:04:39] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.12.11 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/244344 (owner: 10Jforrester) [21:08:11] (03Merged) 10jenkins-bot: Update OOjs UI to v0.12.11 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/244344 (owner: 10Jforrester) [21:29:43] (03PS2) 10Jforrester: MWParameterPage: Focus value input when focussing page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/243388 (https://phabricator.wikimedia.org/T114562) (owner: 10Esanders) [21:32:32] (03CR) 10jenkins-bot: [V: 04-1] MWParameterPage: Focus value input when focussing page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/243388 (https://phabricator.wikimedia.org/T114562) (owner: 10Esanders) [21:32:40] 10VisualEditor, 10Parsoid, 10RESTBase, 6Services: Provide an API that allows stashing temporary wikitext / html conversion metadata - https://phabricator.wikimedia.org/T114548#1710486 (10GWicke) This is now merged & deployed in production. There is now a new 'stash' post flag in https://en.wikipedia.org/ap... [21:32:51] 10VisualEditor, 10Parsoid, 10RESTBase: Provide a mechanism in VRS/RESTbase for switching between WT and DOM - https://phabricator.wikimedia.org/T104663#1710488 (10GWicke) [21:32:55] 10VisualEditor, 10Parsoid, 10RESTBase, 6Services: Provide an API that allows stashing temporary wikitext / html conversion metadata - https://phabricator.wikimedia.org/T114548#1710487 (10GWicke) 5Open>3Resolved [21:34:54] 10VisualEditor, 10Parsoid, 10RESTBase, 6Services: Provide an API that allows stashing temporary wikitext / html conversion metadata - https://phabricator.wikimedia.org/T114548#1710505 (10Jdforrester-WMF) [21:35:32] (03PS3) 10Jforrester: MWParameterPage: Focus value input when focussing page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/243388 (https://phabricator.wikimedia.org/T114562) (owner: 10Esanders) [21:35:34] (03PS1) 10Jforrester: Update VE core submodule to master (c864138) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/244356 [21:35:46] (03CR) 10Jforrester: [C: 032] MWParameterPage: Focus value input when focussing page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/243388 (https://phabricator.wikimedia.org/T114562) (owner: 10Esanders) [21:41:42] (03CR) 10Jforrester: [C: 031] Educational popups and highlights for links+citations [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/238380 (https://phabricator.wikimedia.org/T108620) (owner: 10Alex Monk) [21:43:57] 10VisualEditor, 10Parsoid, 10RESTBase: Provide a mechanism in VRS/RESTbase for switching between WT and DOM - https://phabricator.wikimedia.org/T104663#1710561 (10Jdforrester-WMF) a:3Krenair @Krenair, could you look at this? [22:02:24] 10VisualEditor, 10Parsoid, 10RESTBase: Provide a mechanism in VRS/RESTbase for switching between WT and DOM - https://phabricator.wikimedia.org/T104663#1710691 (10Krenair) I understood this to be new Parsoid functionality? [22:03:33] (03CR) 10Alex Monk: [C: 032] Update VE core submodule to master (c864138) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/244356 (owner: 10Jforrester) [22:06:18] (03Merged) 10jenkins-bot: Update VE core submodule to master (c864138) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/244356 (owner: 10Jforrester) [22:07:00] 10VisualEditor, 10Parsoid, 10RESTBase: Provide a mechanism in VRS/RESTbase for switching between WT and DOM - https://phabricator.wikimedia.org/T104663#1710700 (10Jdforrester-WMF) >>! In T104663#1710691, @Krenair wrote: > I understood this to be new Parsoid functionality? The 'new' stuff is to give the refe... [22:07:59] (03Merged) 10jenkins-bot: MWParameterPage: Focus value input when focussing page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/243388 (https://phabricator.wikimedia.org/T114562) (owner: 10Esanders) [22:10:45] 10Cite, 10Parsoid, 5WMF-deploy-2015-10-06_(1.27.0-wmf.2), 7user-notice: Show an error if a named is defined multiple times with different content - https://phabricator.wikimedia.org/T85386#1710806 (10PeterBowman) It might be worth noting that Cite won't raise this kind of error unless a `... [22:12:56] 10VisualEditor, 10VisualEditor-MediaWiki, 5WMF-deploy-2015-10-06_(1.27.0-wmf.2): Allow PreviewElement to do live previews - https://phabricator.wikimedia.org/T114230#1710814 (10Jdforrester-WMF) 5Open>3Resolved [22:12:57] 10VisualEditor, 10Math: Make math syntax helper dialog - https://phabricator.wikimedia.org/T114163#1710816 (10Jdforrester-WMF) [22:13:29] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media, 6Multimedia, 5Patch-For-Review: VisualEditor: Initiate file upload by drag-and-drop - https://phabricator.wikimedia.org/T40031#1710817 (10Jdforrester-WMF) a:3Esanders [22:13:37] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media, 6Multimedia, and 2 others: VisualEditor: Initiate file upload by drag-and-drop - https://phabricator.wikimedia.org/T40031#428525 (10Jdforrester-WMF) [22:17:38] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 7Browser-Support-Apple-Safari: Cannot scroll dialogs or suggestions in iOS Safari - https://phabricator.wikimedia.org/T71038#1710834 (10Jdforrester-WMF) 5Open>3Resolved a:3Jdforrester-WMF Looks like this was solved a while ago. [22:21:07] 10VisualEditor, 10VisualEditor-ContentEditable: Cursoring over an MWLinkNode takes you two characters to the right/left, not one - https://phabricator.wikimedia.org/T96307#1710863 (10Jdforrester-WMF) [22:37:28] 10Cite, 10Parsoid, 5WMF-deploy-2015-10-06_(1.27.0-wmf.2), 7user-notice: Show an error if a named is defined multiple times with different content - https://phabricator.wikimedia.org/T85386#1710963 (10matmarex) Yeah, that's unintentional and tracked on T114898. I'll try to get that fixed tomorrow. [22:58:39] James_F: this is a thing I'm not sure how to search for easily, but, see this diff https://www.mediawiki.org/w/index.php?title=Wikimedia_Release_Engineering_Team/Gerrit_migration_why&diff=next&oldid=1897791 Is that comma in the first part, at the end of "various options,]]", something we can address in VE? Something like "don't add punctuation to the link"? [22:58:58] ...when adding content around it. [22:59:30] greg-g: We did that, and now we show a highlight when you [22:59:35] 're extending the link. [22:59:39] greg-g: But maybe it's not clear? [23:05:23] James_F: no, I mean, it shouldn't extend the link, right? [23:05:52] greg-g: It can if the user really wants it to do so. [23:07:39] James_F: I just assumed that's not what Neil was expecting [23:07:54] relatedly, something that influences my perception on this, which you might like: http://blogs.law.harvard.edu/pamphlet/2013/01/03/when-practice-and-logic-conflict-change-the-practice/ [23:19:20] (03PS3) 10Esanders: Media upload: Initiate upload process on image drop [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/244331 (https://phabricator.wikimedia.org/T40031) [23:19:22] (03PS3) 10Esanders: Media upload: Use new setFile method [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/244337 [23:22:54] (03PS1) 10DLynch: Remove the "Open" button from link inspectors [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/244373 (https://phabricator.wikimedia.org/T109646) [23:25:40] (03CR) 10jenkins-bot: [V: 04-1] Remove the "Open" button from link inspectors [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/244373 (https://phabricator.wikimedia.org/T109646) (owner: 10DLynch) [23:26:05] That… is odd. [23:26:13] Kemayo: That should have run the V+2 pipe… [23:26:22] Oh, wait, it did. [23:26:37] Let me fix that for you. [23:27:52] My knowledge of +2s is minimal at best. [23:28:42] (03PS2) 10Jforrester: Remove the "Open" button from link inspectors [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/244373 (https://phabricator.wikimedia.org/T109646) (owner: 10DLynch) [23:28:44] (03PS1) 10Jforrester: build: Update grunt-banana-checker from v0.3.0 to v0.4.0 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/244375 [23:29:42] There. My fault. [23:29:57] 244375 fixes one of our build tools to not whine about messages. [23:30:09] 244373 is now based off it, so should work. [23:30:28] (03CR) 10DLynch: [C: 032] build: Update grunt-banana-checker from v0.3.0 to v0.4.0 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/244375 (owner: 10Jforrester) [23:30:38] Thank you. :-) [23:31:09] I'll test when I'm out of this meeting. [23:33:21] (03Merged) 10jenkins-bot: build: Update grunt-banana-checker from v0.3.0 to v0.4.0 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/244375 (owner: 10Jforrester) [23:36:49] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 7Easy, 5Patch-For-Review: Remove "Open" button from all four link inspectors - https://phabricator.wikimedia.org/T109646#1711120 (10Esanders) I have a related patch at https://gerrit.wikimedia.org/r/#/c/241699/ which removes the link behaviour from the search... [23:39:12] (03CR) 10Esanders: [C: 04-1] "Code is great but discussion ongoing on the bug." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/244373 (https://phabricator.wikimedia.org/T109646) (owner: 10DLynch) [23:54:31] (03CR) 10Alex Monk: "looks good, just need to get that TODO done then I think we can merge this" (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/244331 (https://phabricator.wikimedia.org/T40031) (owner: 10Esanders)